[Koha-bugs] [Bug 9809] Get rid of reserveconstraints

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 7 14:31:43 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #9)
> Kyle,
> Thanks for these patches, it's a much more complete solution than the one I
> have proposed.
> 
> I have a doubt with the changes in GetReserveFee:
> Before the patches:
>     if ( $const eq "a" ) {
>         push @biblioitems, $data1;
>     }
>     else {
>         some code;
>     }
> 
> now you always execute some code.
> 
> But before the patch, $const was sometime equal to "a".
> I am not sure about the consequences of this change.

Can you add a splinter review? I'm not sure exactly where the code you are
referencing is. You can also add a followup to fix it if that's easier.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list