[Koha-bugs] [Bug 14368] Add discharges history

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14368

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Matts, a few notes on this patch.

- I like the idea, I think we should've had this for the 3.20 release already.
- There's a bug on the unit test you introduce for lifting the discharge,
because it should look like:

    ok( ! Koha::Borrower::Discharge::is_discharged({ borrowernumber =>
$borrowernumber }),
        'The patron is not discharged after the restriction has been lifted' );

And you will notice it fails :/

- There's a problem with Koha::Borrower::Discharge::discharge (not introduced
by your patch, but affects the beaviour): it overwrites the already defined
discharges... so no history! Heh.
- For fixing the previous, you will need to add a column to address the fact
that the discharge is active/non active. So you can have more than one
discharges for a borrowernumber, and always check only one is active at a time.

I'm attaching a followup with those changes on the tests, It'd be great if you
could take a look and maybe talk tomorrow on IRC about this to have this ready
ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.