[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jul 9 04:27:44 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

--- Comment #7 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Nicholas van Oudtshoorn from comment #6)
> As per Robin's suggestion in Comment 4, it no longer uses an XS module. I
> have, however, gone for Net::CIDR instead of Net::IP::Match. For one thing,
> it looks like it's already packaged for Debian (and, as a bonus, for Fedora
> too!) For another, Net::IP::Match seemed to want to know a list of addresses
> etc. to match at "compile time".

Brilliant, Net::CIDR has been in Debian since the dawn of time, so that makes
me happier :)

You've missed updating the use lines in sco-patron-image.pl though.

Also don't forget to update C4/Installer/PerlDependencies.pm (keep an eye on
the version version numbers being correct, wheezy has 0.15.)

> If this patch is acceptable, would another to adjust opac-search to use
> Net::CIDR be a nice "tidying to one standard" patch?

I'd make a new bug for that, it'll possibly be more complicated than you expect
as it'll have to account for the possibility of the format of a syspref
changing, and either correcting that in the database or accepting the old form
as well as the new one.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list