[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40852|0                           |1
        is obsolete|                            |

--- Comment #8 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Created attachment 40854
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40854&action=edit
Bug 14407 - Allow web-based self checkout to be limited by IP addresses/ranges

(In reply to Robin in Comment #7)
>Brilliant, Net::CIDR has been in Debian since the dawn of time, so that makes
>me happier :)
:-) Glad to have brought a sigh of relief!

> You've missed updating the use lines in sco-patron-image.pl though.
D'oh! Fixed that now

>Also don't forget to update C4/Installer/PerlDependencies.pm (keep an eye on the version version numbers being correct, wheezy has 0.15.)
Ah! Hadn't thought about that at all. Should be done now.

>> If this patch is acceptable, would another to adjust opac-search to use
>> Net::CIDR be a nice "tidying to one standard" patch?
>I'd make a new bug for that, it'll possibly be more complicated than you
>expect as it'll have to account for the possibility of the format of a syspref
>changing, and either correcting that in the database or accepting the old form
>as well as the new one.
Agreed it would need a new bug. Have had a quick squiz, and it seems that
NET::CIDR::range2cidr is perfectly happy with the format required by the
current preference. It could, however, be changed to allow for much greater
variety... (multiple subnets, individual IPs, etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.