[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Jul 9 13:41:56 CEST 2015
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452
Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Status|Signed Off |Failed QA
--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I won't use the splinter review, it will be confusing.
1/ There are 2 different ways to do the same thing:
247 if ( $line=~/itemtype/ ) { $line = $itype; }
257 $linefilter[0] = @$filters[9] if ($line =~ /itemtype/ ) ;
and
263 if ( $column=~/itemtype/ ) { $column = $itype; }
274 $colfilter[0] = @$filters[9] if ($column =~ $itype ) ;
2/ Please use sql placeholders for "issuingrules.itemtype=$itype" (x3)
3/
if (( @colfilter ) and ($colfilter[1])){
$sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'");
} elsif ($colfilter[0]) {
$sth2->execute;
} else {
$sth2->execute;
}
Could be :
if (( @colfilter ) and ($colfilter[1])){
$sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'");
} else {
$sth2->execute;
}
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list