[Koha-bugs] [Bug 10988] Allow login via Google OAuth2

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 40442
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40442
Bug 10988: Allow login via Google OAuth2

Review of attachment 40442:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10988&attachment=40442)
-----------------------------------------------------------------

I don't have an installation with a public ip, so I cannot test this patch.

Following a code review:
1/ Fix the patch's author (From: root <root at beta.pbcstudents.pbc.wa.edu.au>)
2/ perltidy the new file (opac/svc/googleoauth2)
3/ Maybe opac/svc/auth/googleoauth2 is more appropriate?
4/ the following:

::: opac/svc/googleoauth2
@@ +1,1 @@
> +#!/usr/bin/perl -w

Remove -w

@@ +36,5 @@
> +# means caching some information and updating it daily. But that
> +# would make things a lot faster
> +
> +use Modern::Perl;
> +use CGI qw/escape/;

and -utf8, even if not needed.

@@ +63,5 @@
> +    $query->delete('code');
> +    $query->param( 'OAuth2Failed' => $reason );
> +    my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
> +        {
> +            template_name   => 'opac-user.tmpl',

Should be opac-user.tt

@@ +75,5 @@
> +    $template->param( 'loginprompt'        => 1 );
> +    output_html_with_http_headers $query, $cookie, $template->output;
> +}
> +
> +#die $query->param('code');

To remove.

-- 
You are receiving this mail because:
You are watching all bug changes.