[Koha-bugs] [Bug 14530] 856$u URL checker ( check-url.pl ) complains about ftp based URLs

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 41026
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41026&action=edit
Bug 14530 - 856$u URL checker ( check-url.pl ) complains about ftp based URLs

The script check-url.pl assumes that any URL not prefixed with http must
be a relative URL. This is problematic as the URL could be prefixed with
ftp as well.

Any 856$u using an ftp url is given the error "400 URL Must be
absolute".

Since HTTP::Request cannot handle ftp urls, we should just skip them.

I also noticed that check-url-quick.pl checks for prefixes with
case insensitivity. That seems like a good idea so I've added
that to check-url.pl

Test Plan:
1) Apply this patch
2) Find or create a record with an ftp url in 865$u
3) Run check-url.pl
4) Note the ftp url is skipped
5) Run check-url-quick.pl
6) Note the ftp url is skipped

-- 
You are receiving this mail because:
You are watching all bug changes.