[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jul 24 14:41:47 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

--- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
(In reply to Zeno Tajoli from comment #7)
> Hi Olli,
> 
> Why is in discussion ?

Originally I made these factories to work best with Cucumber tests, and those
have their own stashing and tearDown-mechanisms. Back then I didn't think far
enough and those things have been dealt in the Cucumber framework.
So all the other ObjectFactories, sans the BorrowerFactory are of the old
model.

I refactored Borrowerfactory to include the features from Cucumber-framework
(multi-level stashing) but haven't done that for the rest of the
ObjectFactories.
So basically If one was to refactor this commit into something with only the
BorrowerFactory and the parent ObjectFactory, this would be ok.

I have tests and documentation to do for the REST API framework, so I can take
a look at this after that, but the separation is a very easy task and a good
exercise in getting to know the simplicity of these Factories.

There are other bugs to test for the big authentication rewrite, if you feel
like waiting for me to properly refactor this feature.
I have built Bug 14540 to be stand-alone testable (with all dependencies), but
most of these dependant bugs don't make much sense to test alone (since they do
not have the necessary context to prove their usefulness.
You can still safely apply this bug, since the non-refactored factories don't
hinder testing the whole rewrite or interfere with Koha in any way.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list