[Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41183|0                           |1
        is obsolete|                            |

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 41215
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41215&action=edit
[PASSED QA] Bug 10961: (followup) Make query fields explicit and add regression
tests

add correct frameworkcode to _koha_marc_update_bib_ids parameters

add test, prove with : prove t/db_dependent/Biblio.t

TEST PLAN
---------
1) git checkout -b bug_10961 origin/master
2) git bz apply 10961
3) git checkout origin/master -- C4/Biblio.pm
4) prove t/db_dependent/Biblio.t
   -- was expecting failure, got failure.
5) git reset --hard origin/master
6) git bz apply 10961
7) prove t/db_dependent/Biblio.t
   -- success as expected.
8) Read over code.
   -- Noted it also grabs the framework code for the biblio, rather than uses
default.
      And it also corrects an indentation issue.
      Test case looks like it attempts to cover the
biblionumber!=biblioitemnumber case
      by adding 1.
9) run koha qa test tools.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>

-- 
You are receiving this mail because:
You are watching all bug changes.