[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jul 29 14:57:17 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Rémi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |remi.mayrand-provencher at inL
                   |                            |ibro.com

--- Comment #12 from Rémi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> ---
Hi Jonathan,

> ::: acqui/basket.pl
> @@ +197,5 @@
> >          -type       => 'text/csv',
> >          -attachment => 'basket' . $basket->{'basketno'} . '.csv',
> >      );
> > +    if ( $query->param('csv_profile') eq 'default'){
> > +        print GetBasketAsCSV($query->param('basketno'), $query);
> 
> Actually this subroutine should take the csv profile in parameter, don't you
> think?

Could you be more specific about what are the changes you would like to see
here?

Thank you,

(In reply to Jonathan Druart from comment #11)
> Comment on attachment 37293 [details] [review]
> [SIGNED-OFF] Bug 8612 - System preference to have custom fields in export
> csv basket
> 
> Review of attachment 37293 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: acqui/basket.pl
> @@ +197,5 @@
> >          -type       => 'text/csv',
> >          -attachment => 'basket' . $basket->{'basketno'} . '.csv',
> >      );
> > +    if ( $query->param('csv_profile') eq 'default'){
> > +        print GetBasketAsCSV($query->param('basketno'), $query);
> 
> Actually this subroutine should take the csv profile in parameter, don't you
> think?
> 
> @@ +531,4 @@
> >      return \%line;
> >  }
> >  
> > +sub get_basket_DB_info{
> 
> Don't you have something in the module to do that? (I didn't check).
> In all cases, you cannot add it here in the pl. Yes that means tests.
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
> @@ +190,5 @@
> >                      [% END %]
> > +                       <div class="btn-group">
> > +                       <fieldset class="action">
> > +                          <label for="csv_code">Select CSV profile:</label>
> > +                          <select id="csv_profile_for_export">
> 
> This block is c/p twice, should be in a TT BLOCK.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list