From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 00:37:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 May 2015 22:37:54 +0000 Subject: [Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #42 from Indranil Das Gupta --- Created attachment 39724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39724&action=edit (Fixup) Fixes multiple issues in comment #40 Small fix - addresses the concerns pointed to by Mark Tompsett in comment #40 (code review) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 00:38:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 May 2015 22:38:23 +0000 Subject: [Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 00:40:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 May 2015 22:40:03 +0000 Subject: [Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 00:40:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 May 2015 22:40:31 +0000 Subject: [Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39724|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 02:05:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2015 00:05:32 +0000 Subject: [Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #43 from Indranil Das Gupta --- Created attachment 39725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39725&action=edit (Followup) Fixed issues pointed to in comment #40 Based on Mark's inputs in comment #40 - [1] selected 'mast' (short of 'masthead') and updated : (a) bug_14252-OpacLangSelectorMode_syspref.sql (b) sysprefs.sql (c) opac.pref [2] Reduced the calls to Koha.Preference() from : (a) masthead.inc (b) opac-bottom.inc After applying this patch, update the database once for it to pick up the new option values -'both|mast|foot'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 02:06:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2015 00:06:28 +0000 Subject: [Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 02:18:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2015 00:18:08 +0000 Subject: [Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #44 from Indranil Das Gupta --- Created attachment 39726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39726&action=edit (fix) address the indentation for the lang loop tidy the indentation for that lang selector loop code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 03:37:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2015 01:37:17 +0000 Subject: [Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #45 from M. Tompsett --- Comment on attachment 39707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39707 [Signed-off] (followup) Adds OpacLangSelectorMode syspref Review of attachment 39707: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14252&attachment=39707) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ +32,5 @@ > +[% IF ( Koha.Preference( 'OpacLangSelectorMode' ) == 'both' ) || ( Koha.Preference( 'OpacLangSelectorMode' ) == 'foot' ) %] > + [% IF ( opaclanguagesdisplay ) %] > + [% IF ( languages_loop && opaclanguagesdisplay ) %] > + [% UNLESS ( one_language_enabled ) %] > +