[Koha-bugs] [Bug 3206] OAI repositry deleted record support

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 39797
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39797
Bug 3206: OAI repository deleted records support.

Review of attachment 39797:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=3206&attachment=39797)
-----------------------------------------------------------------

::: installer/data/mysql/sysprefs.sql
@@ +479,5 @@
>  ('XSLTDetailsDisplay','default','','Enable XSL stylesheet control over details page display on intranet','Free'),
>  ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'),
>  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'),
> +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'),
> +('OAI-PMH:DeletedRecord','persistent','Koha\'s deletedbiblio table will never be deleted (persistent) or might be deleted (transient)','transient|persistent','Choice')

Insert the pref at the right place, this file must be kept ordered.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref
@@ +31,5 @@
> +            - Koha's deletedbiblio table
> +            - pref: "OAI-PMH:DeletedRecord"
> +              choices:
> +                  persistent: will never be emptied or truncated (persistent)
> +                  transient: might be emptied or truncated at some point (transient)

Does it make sense to have the "no" option?

::: opac/oai.pl
@@ +242,5 @@
>  
> +package C4::OAI::DeletedRecord;
> +
> +use strict;
> +use warnings;

Prefer Modern::Perl;

@@ +303,5 @@
> +        FROM deletedbiblio
> +        WHERE biblionumber=? " );
> +      $sth->execute( $biblionumber );
> +
> +      unless ( ($marcxml, $timestamp) = $sth->fetchrow ) {

Prefer $dbh->selectrow_*

@@ +358,4 @@
>      }
>      my $max = $repository->{koha_max_count};
>      my $sql = "
> +        (SELECT biblioitems.biblionumber, timestamp

Why do you remove the table name?

-- 
You are receiving this mail because:
You are watching all bug changes.