[Koha-bugs] [Bug 13881] Add desk management

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #3 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Hey,

thanks a lot for your comments.

(In reply to Bernardo Gonzalez Kriegel from comment #2)
> Hi, can this be tested?

It's not really functionnal yet, It'll be soon I hope, next week at least :).

> Comments:
> 1) Can this be defined into Koha namespace?

I'm not sure about it. I'm mostly unaware of namespace policy, I thought this
kind of code was for C4. Where can I find policy for namespaces ?

> 2) You could use GetBranchesLoop to get an ordered (by branchname) list of
> branches

Ho, thanks, I missed the note in the doc and didn't catch the function cause
it's not documented.

> 3) Many backticks (`) 
> (Coding guidelines SQL6: Backticks
> Don't use ` in table or column names (this is a mySQLism))

argh, ok, thanks.

> 4) I think we can't use smartmatch (~~). 
> In test "ok($deskcode ~~ @$desks, 'GetDesks returns desk codes');"
> Look at http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11468#c6

Thanks again. I'll try to fix those soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.