[Koha-bugs] [Bug 14256] Tests for TestBuilder fail randomly

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14256

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39836|0                           |1
        is obsolete|                            |

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 39855
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39855&action=edit
[SIGNED OFF] Bug 14256: (follow-up) Check for unique constraint to regenerate
random data

There were some issues in the previous patch. This patch fixes the
following:
- rename $value with $original_value
- remove $at_least_one_constraint_failed and $values_ok which make the
  code unnecessarily complicated
- the constraints have to be checked only if no original value is passed
- _buildColumnValue created a key to the default value hashref, it broke
  the test:
    last BUILD_VALUE if exists( $default_value->{$source} );

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.