[Koha-bugs] [Bug 12769] Notice fee management

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

--- Comment #14 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 39900
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39900
Bug 12769 - Notice fee management

Review of attachment 39900:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12769&attachment=39900)
-----------------------------------------------------------------

::: misc/cronjobs/advance_notices.pl
@@ +525,5 @@
> +        } else {
> +            $sendfee = C4::Context->preference('DefaultNoticeFee');
> +        }
> +
> +        if ($sendfee > 0){

$sendfee could be undefined. This would generate noise.

::: misc/cronjobs/overdue_notices.pl
@@ +599,5 @@
> +                } else {
> +                    $sendfee = C4::Context->preference('DefaultNoticeFee');
> +                }
> +
> +                if ($sendfee > 0){

Check if defined. :)

-- 
You are receiving this mail because:
You are watching all bug changes.