[Koha-bugs] [Bug 14339] Installer broken by bug 13967

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jun 5 16:15:09 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14339

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 39906
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39906&action=edit
Bug 14339: C4::Context->preference should return undef if DB is not populated

The current behaviour for C4::Context->preference when the DB is not still
populated with tables is to return undef. This is used by C4::Auth to identify
the need of running the installer.

This behaviour got broken by bug 13967, which lets DB errors to escalate and
thus Koha gets broken instead of prompting for install.

This patch wraps Koha::Config::Sysprefs->find inside an eval and sets undef if
needed.

To test:
- In current master, drop the DB
- Load OPAC and Intranet
=> FAIL: notice an ugly software error.
- Apply the patch
- Load the OPAC
=> SUCCESS: Maintenance mode screen is shown
- Load Intranet
=> SUCCESS: You are prompted the DB credentials to run the web installer.
- Sign off :-D

Tomas

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list