[Koha-bugs] [Bug 14329] Useless copy/pasta from Template::Plugin::HtmlToText

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jun 5 19:34:25 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14329

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39838|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 39915
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39915&action=edit
Bug 14329: Useless copy/pasta from Template::Plugin::HtmlToText

The synopsis of this TT plugin contains two example lines:
[% myhtml FILTER html2text(leftmargin => 0, rightmargin => 0) %]
[% myhtmltext | html2text %]

These lines have been copied (without too much thought :) to a few templates.
Since we do no use the variables myhtml or myhtmltext in these templates, these
lines are useless.

Test plan:
[1] Put some items in your cart. And send it.
[2] Send a shelf.
[3] Git grep on myhtml. Should not have results.

NOTE: Sent carts and lists in Intranet and OPAC successfully.
      Though, this does bring into question why the letters
      have HTML formatting if it is getting removed. That,
      however, is beyond the scope of this bug.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list