[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

--- Comment #20 from Blou <philippe.blouin at inlibro.com> ---
Hi Jonathan,
I'll try to reply to these to the best of my knowledge

1) tidying : I'm on it, but I couldn't find much beside 3-4 keywords.  No extra
space, as this code had been through qa-test before.

2) mediumint : no valid reason whatsoever, reasoning prb lost in time, along
with the initial coder.  I'll change to int(11)

3) simple ALTER ADD : Well, I remembered trying, so I tried again and could
not.  The existing constraints, the relation to OTT, the auto_increment...
Whatever I tried failed.  I won't say it's "simpler this way", but I just
couldn't make it work otherwise.

4) Took me a while to remember WHY we want it out.  I guess it's premature, but
this is the first step to allow for unlimited "steps", and as such that combo
cannot be unique.  BUT this being the first step, I cannot justify removing it
yet, only that it will be more complicated to remove later.
I WILL LEAVE IT IN, you being QA and all ;)

Mini Patch coming...

-- 
You are receiving this mail because:
You are watching all bug changes.