[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Jun 14 15:41:47 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

--- Comment #2 from Indranil Das Gupta <indradg at gmail.com> ---
Comment on attachment 38884
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38884
Add maxreserves and alreadyreserved checks when placing hold via ILSDI

Review of attachment 38884:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14155&attachment=38884)
-----------------------------------------------------------------

Alex,

I think the following :

::: C4/Reserves.pm
@@ +1117,5 @@
> +        return 1 if $borrowernumber eq $res->{borrowernumber};
> +    }
> +
> +    return 0;
> +}

needs added test in t/db_dependent/Reserves.t

@@ +1139,5 @@
> +        return 1;
> +    }
> +
> +    return 0;
> +}

needs added test in t/db_dependent/Reserves.t

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list