[Koha-bugs] [Bug 6810] Send membership expiry reminder notices

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

--- Comment #48 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 40122
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40122
Bug 6810 - Fix QA failures

Review of attachment 40122:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6810&attachment=40122)
-----------------------------------------------------------------

The tests file is db dependent.

::: C4/Letters.pm
@@ +35,4 @@
>  use Encode;
>  use Carp;
>  use Koha::Email;
> +use Koha::Template::Plugin::KohaDates;

No, you should not use Koha::Template::Plugin outside templates.
Use Koha::DateUtils.

::: t/Members.t
@@ +40,5 @@
> +        );
> +
> +});
> +
> +t::lib::Mocks::mock_preference('MembershipExpiryDaysNotice', 15);

Please add tests with MembershipExpiryDaysNotice equals 0 or undef.

-- 
You are receiving this mail because:
You are watching all bug changes.