[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 40035
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40035
[SIGNED-OFF] Bug 13918 - Add waiting expiration date to opac list of holds for
user

Review of attachment 40035:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13918&attachment=40035)
-----------------------------------------------------------------

::: Koha/Biblio.pm
@@ +43,5 @@
> +
> +sub subtitle {
> +    my ( $self ) = @_;
> +
> +    return GetRecordValue( 'subtitle', GetMarcBiblio( $self->id() ), GetFrameworkCode( $self->id() ) );

Shouldn't we provide a more efficient way to retrieve subtitle here?
Moreover the frameworkcode could be retrieved with self->frameworkcode.

::: Koha/Hold.pm
@@ +96,5 @@
> +Returns true if hold is a cancelable hold
> +
> +=cut
> +
> +sub is_cancelable {

tests are missing for this subroutine.

@@ +122,5 @@
> +Returns true if hold is a in_transit hold
> +
> +=cut
> +
> +sub is_at_destination {

tests are missing for this subroutine.

::: opac/opac-user.pl
@@ +281,4 @@
>  
> +$template->param(
> +    RESERVES       => $reserves,
> +    reserves_count => $reserves->count(),

Is it still needed?
We can access to the number of reserves from the template.

-- 
You are receiving this mail because:
You are watching all bug changes.