[Koha-bugs] [Bug 12913] wrong inventory results when notforloan filter is not used

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
I haven't tried the patch, but at a glance it might be trying to fix the wrong
part of inventory.pl. 

This is the section of code that probably needs to be changed:

# If we have scanned items with a non-matching notforloan value
if (none { $item->{'notforloancode'} eq $_ } @notforloans) {
    $item->{problem} = 'changestatus';
    push @items_with_problems, { %$item };
}

If you're not using the "Not for loans" filter, @notforloans should be empty.
Likewise, if your item isn't "Not for loan", $item->{'notforloancode'} should
be false. Thus, this if statement should always be true if you're not using
"Not for loans" and the item is not not for loan (ie is available).

So I think all we need here is to wrap this with a "if (@notforloans)" test.

I might take a look at this after I finish filing another Inventory bug
report...

-- 
You are receiving this mail because:
You are watching all bug changes.