[Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment and makepayment

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
             Status|Needs Signoff               |In Discussion

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
This patch is insufficient in my mind. Read the C4::Account code to which you
linked.

recordpayment sets $branch to logged in user's branch. Function seems to be SIP
based on comments, so should be user paying own fine, right?

recordpayment_selectaccts sets $branch to logged in user's branch. Function
seems to be SIP based on comments, so should be user paying own fine, right?

makepayment takes $branch as a parameter, but then uses $user in the
UpdateStats call?! This patch fixes that.

makepartialpayment takes $branch as a parameter, but then uses $user in the
UpdateStats call?! This patch misses this.

WriteOffFee takes $branch as a parameter, but if it is 0, '', or undef, it uses
the logged in user's branch. It correctly uses $branch for UpdateStats. I think
the handling used here should be duplicated in the makepayment and
makepartialpayment functions.

-- 
You are receiving this mail because:
You are watching all bug changes.