[Koha-bugs] [Bug 6810] Send membership expiry reminder notices

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #58 from Jonathan Druart <jonathan.druart at biblibre.com> ---
1/ 
+    my $dateexpiry = DateTime->now()->add(days => $days)->ymd();

You should use Koha::DateUtils->dt_from_string; to take the tz into account.

2/ The letter.code field is a varchar(20), I am sure you can find something
more meaningful than "MEMEXP".

3/ The file installer/data/mysql/sysprefs.sql should be kept ordered.
Don't put your line at the end of the file.

4/ The cronjob:
a. No need to warn, prefer say
b. use Modern::Perl;
c. a cronjob should not be interactive.
d. use Pod2usage for the usage (see other scripts).

5/ The letter: Are you sure that only information from the borrowers table is
useful?
It would be good to have info from the branches table, as a minimum.

-- 
You are receiving this mail because:
You are watching all bug changes.