[Koha-bugs] [Bug 12137] Extend CalendarFirstDayOfWeek to be any day

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137

--- Comment #18 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to M. Tompsett from comment #17)
> (In reply to Jonathan Druart from comment #14)
> > Since the list is complete, it would have been easier to add 'Saturday',
> > don't you think?
> 
> Look at the old code:
> CalendarFirstDayOfWeek => (
> C4::Context->preference("CalendarFirstDayOfWeek") eq "Sunday" ) ? 0 : 1
> 
> Is it easier to extend that with more code? Or just use the values 0-6 in
> the first place?

C4::Context->preference("CalendarFirstDayOfWeek") eq "Sunday"
 ? 0
 : C4::Context->preference("CalendarFirstDayOfWeek") eq "Saturday"
   ? 6
   : 1

Not very difficult.
We will just need to update the different options available for the pref and if
someone already uses this value outside of Koha (ok, there is certainly
nobody), he could continue to do it.

But this is not the question, is there another value than can exist for the
"first day of week"?
If only Sunday, Monday and Saturday are used all around the world, I don't see
any sense to propose the 4 other days :)

-- 
You are receiving this mail because:
You are watching all bug changes.