[Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
I did some testing and found the following issues:

POST-request

-There should be an exception for non-existent branchcode? So we pass a
branchcode as a param which doesn't match any branch we have.
-expirationdate-parameter is mandatory. Eg. it must be given as a parameter
with a value of null or something sensible.
-itemnumber is mandatory? How about biblio-level holds?
-C4::Reserves::AddReserves() modification out of scope.
-Repeatedly placing a reserve places multiple holds for the same itemnumber.
Etag/Timestamp needed to prevent accepting the same request many times. Also I
think this is against Koha business rules.

PUT-request

-Optional fields mandatory. Can be circumvented by using parameters "" and
"0000-00-00"

DELETE-request

-Deletes OK, but returns a "page not found"-error.

-- 
You are receiving this mail because:
You are watching all bug changes.