[Koha-bugs] [Bug 14437] New: Refactor C4::Auth::haspermission() to Koha::Object and return errors better.

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jun 23 11:17:11 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14437

            Bug ID: 14437
           Summary: Refactor C4::Auth::haspermission() to Koha::Object and
                    return errors better.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: gmcharlt at gmail.com
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Refactoring haspermission() and improving documentation.
Also added a return value unintrusively (in the old context still RETURNS the
same result) to tell which permission failed.

Modification should have no adverse effects, other than killing the process (by
throwing uncaught exceptions) if no valid parameters are given.

Depends on Bug 13995 - Proper Exception handling
    so apply it first.

Cannot create unit tests because there is no CRUD interface for permissions.
Not even with TestBuilder.

TEST PLAN:

1. Find a borrower with only the catalogue-permission.
2. try opening this page cgi-bin/koha/tools/manage-marc-import.pl
3. You get "Permission denied"

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list