[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 24 13:36:55 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #27 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 38458
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38458
[Signed-off] Bug 12747 - Add extra column in Z3950 search

Review of attachment 38458:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12747&attachment=38458)
-----------------------------------------------------------------

I am sorry to fail qa it again, but you have to provide tests for the change in
the C4::Breeding module.
I don't ask you to completely cover the subroutine, but at least highlight what
the new pref does.

::: C4/Breeding.pm
@@ +224,5 @@
>  
> +    @servers = ();
> +    foreach my $id (@id) {
> +        push @servers, {id => $id};
> +    }

This has been removed by

commit fb0834e8f582e9e268ecef6de891ba5dc25c6fd9
Bug 6536: Include SRU searching in Breeding.pm

Are you sure this change is intended?

@@ +232,5 @@
> +    if ($pref_addnumber){
> +        $template->param(
> +            additionalFields => '1',
> +        );
> +    }

I'd say you don't need to do that.
I can just access to the AdditionalFieldsInZ3950ResultSearch value from the
template using the Koha TT plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list