[Koha-bugs] [Bug 14345] parsed isbn has semi-colon fails to nicely link for idreambooks

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14345

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #7)
> Does the ';' you want to remove is the one generated by [% IF ( loop.last )
> %].[% ELSE %]; [% END %]?

Yes, if:
1) there are multiple 020$a's on the biblio record, and the first one is just a
number. OR
No, if:
2) someone intentionally types multiple ISBN's into 020$a on a biblio record
with the first one as a number followed immediately by semi-colon as a
delimiter.

We have no ISBN validation in the MARC Editor area.


> Because looking at the JS:
>     var isbn = $(".isbn:last").text().split(" ")[1];
> It seems that several .isbn is expected, but only one is created.

Actually, I was surprised that alert($(".isbn:last").text()) actually generated
that entire ISBN line. It's expecting spaces. The [1] is the first ISBN in the
list.


> Maybe the template should be more something like:
> <span class="results_summary isbns"><span class="label">ISBN:</span>
>     [% FOREACH MARCISBN IN MARCISBNS %]
>         <span class="isbn"[% MARCISBN %]</span>[% IF ( loop.last ) %].[%
> ELSE %]; [% END %]
>     [% END %]
> </span>

In order to make the semantics clearer, perhaps, but if you changed that just
change .isbn to .isbns in the JS code section after your suggested change,
you'd get the equivalent problem.

If we make the template change, we may have other things to test as well. This
is the quickest fix that is easily testable.

-- 
You are receiving this mail because:
You are watching all bug changes.