[Koha-bugs] [Bug 14468] Remove warnings when creating Labels

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Chris Nighswonger from comment #2)
> There will most likely be problems removing the use of internal fonts for
> those who cannot or do not desire to use TTFs. A better solution would be to
> incorporate the possibility of both. Ie. Check to see if TTFs are configured
> and fall back to internal fonts if not.

Yes, but that is what C4::Creators::PDF->Font does ATM.

sub Font {
    my $self = shift;
    my $fontName = shift;

    my $ttf = C4::Context->config('ttf');

    if ( $ttf ) {
        my $ttf_path = first { $_->{type} eq $fontName } @{ $ttf->{font} };
        if ( -e $ttf_path->{content} ) {
            return prTTFont($ttf_path->{content});
        } else {
            warn "ERROR in koha-conf.xml -- missing <font
type=\"$fontName\">/path/to/font.ttf</font>";
        }
    }
    return prFont($fontName);
}

It returns prTTFont or prFont using C4::Context->config('ttf')

Just tried with ttf 'disabled' I get

pdffonts label_batch_1.pdf 
name                                 type              encoding         emb sub
uni object ID
------------------------------------ ----------------- ---------------- --- ---
--- ---------
Courier                              Type 1            WinAnsi          no  no 
no       5  0
Helvetica                            Type 1            WinAnsi          no  no 
no       4  0

With ttf enabled
pdffonts label_batch_1.pdf 
name                                 type              encoding         emb sub
uni object ID
------------------------------------ ----------------- ---------------- --- ---
--- ---------
Courier                              Type 1            WinAnsi          no  no 
no       9  0
BXCJIM+DejaVuSans                    CID TrueType      Identity-H       yes yes
no       4  0

Courier is used below barcode, the other is for text.
It's working :) (but without ttf not for complex scripts)

-- 
You are receiving this mail because:
You are watching all bug changes.