[Koha-bugs] [Bug 14468] Remove warnings when creating Labels

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jun 29 15:51:20 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468

--- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Chris Nighswonger from comment #4)
> 
> I realize that. However, it appears that you remove the calls to that in
> your patch which is what triggered my concern.

Yes, I remove a call in C4/Labels/Label.pm, but add explicitly one on
C4/Creators/PDF.pm replacing Galen's code that do almost the same.
If we call it on Label.pm and again in PDF.pm then we have all those
warnings in the logs.


> I apologize if I'm missing something since I'm really not focused at the
> moment, but in any case, as long as things still work for someone who elects
> not to install TTFs on their system, I'm fine with the fix.

No problem :)
I tried that before your first comment and works fine without TTF fonts.

The problem only affects sites with TTF fonts on config.
Originally we transformed 'TR' to 'Ft1' on Labels.pm (using Font function)
then we searched 'Ft1' inside TTF fonts in StrWidth (using Galen's code) and 
spit a warning because it was not found.

Now I send 'TR' to StrWidth, it calls Font sub and get 'Ft1', that is
passed to prStrWidth (works the same with or without TTF)

That's the reason to remove the call on Label.pm

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list