From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 03:27:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 02:27:45 +0000
Subject: [Koha-bugs] [Bug 13700] Translated item search not working
In-Reply-To: <bug-13700-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13700-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13700-70-7rm8MTNeIh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #16 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 03:29:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 02:29:00 +0000
Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue
In-Reply-To: <bug-13682-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13682-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13682-70-5rjXa8EIZH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 03:30:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 02:30:52 +0000
Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number'
In-Reply-To: <bug-13593-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13593-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13593-70-GvQ0pNoXaR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 08:45:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 07:45:50 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-6gMMOfDy4q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34459|0                           |1
        is obsolete|                            |

--- Comment #66 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 36243
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36243&action=edit
Bug 11559 - Supporting changes for Rancor

* Extends login screen to pass along #hash
  * Adds JSONP support to C4::Service
  * Extends humanmsg to allow per-message classes
  * Adds proper charset to results of svc/bib

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 08:45:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 07:45:59 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-HKTL76LVL6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34460|0                           |1
        is obsolete|                            |

--- Comment #67 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 36244
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36244&action=edit
Bug 11559 - New libraries for Rancor

Adds the following JS libraries:

  * CodeMirror - extensible text editor
  * FileSaver - shim for saving files
  * pz2 - library for connecting to pazpar2
  * require - dependency resolver and module loader

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 08:46:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 07:46:09 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-R2pKfF8hty@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34461|0                           |1
        is obsolete|                            |

--- Comment #68 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 36245
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36245&action=edit
Bug 11559 - Rancor: professional cataloging interface

Test plan:

  1. Apply patches for bug 10486 and this bug.
  2. Reinstall patches for pazpar2.
  3. Switch back and forth between basic and advanced editor, and verify
     that preference is saved (by workstation, not user.
  4. Enter in a record (with all required fields).
  5. Save to ISO2709, MARCXML and catalog, verify that all three match.
  6. Import a MARCXML and ISO2709 record, and verify that the record is
     correct after import.
  7. Run keyword and advanced searches with a variety of Z39.50 servers
     to check that searching is correct, and try to both import records
     as new records and substitute them for the contents of existing
     records.
  8. Create, edit and delete macros, verifying that they are autosaved.
  9. Try running macros (example follows).
  10. Try enabling and disabling fixed-field widgets and customizing
      fonts, and test the editor afterwards.

Example macro:

goto field 003
copy field data
insert new field 040 data=
goto subfield end
insert new subfield a data=
goto subfield a
paste

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 08:46:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 07:46:15 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-zioNQhvC77@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34462|0                           |1
        is obsolete|                            |

--- Comment #69 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 36246
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36246&action=edit
Bug 11559 followup - Allow insertion of dollar sign, remove fixFloat

The dollar sign now shows up as {dollar} inside subfield contents. This
is converted on load and save.

Also, remove fixFloat, as it has moved and is no longer needed anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 08:46:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 07:46:35 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-sZVCbREPnS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34463|0                           |1
        is obsolete|                            |

--- Comment #70 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 36247
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36247&action=edit
Bug 11559 followup - Remove Pazpar2 dependency, bugfixes

Adds a new metasearch service, removing dependency on Pazpar2. Current
limitations:

  * Can only sort by title. Should be easy to fix.
  * Requires refetching results when changing pages.

Also adds an "edit items" link, and fixes a loading error when logged in
as the database user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 08:46:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 07:46:43 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-fbPVEkkd1l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #71 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 36248
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36248&action=edit
Bug 11559 followup - refactoring and cleanup

Added license headers to all JS files, moved metasearcher code into a
new service that largely lives in Koha::, and massively cleaned up the
internals of the textual MARC machinery. Also, fixed some encoding and
saving issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 18:07:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 17:07:41 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-0sCIKzpN9Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #31 from Marc V?ron <veron at veron.ch> ---
Created attachment 36249
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36249&action=edit
[Signed-off] Bug 13364 - Add a call number browser in item edition page

When editing an item, the call number browser search for existing call number.
If it shows a line is green between two calli numbers, the call numbers
searched is available. If the call number is highlighted in red, it means that
it already exists. This can be used to avoid repeated  call numbers in your
collection.

The call number browser also shows its position relative to the rest of the
collection.

Sponsored-by: CCSR

To test :

                   1) Go to MARC bibliographic framework
                   Home ? Administration ? MARC frameworks
                   2) Click in MARC structure (Default framework)
                   3) Search field 952 and click in subfields
                   4) Edit subfield o (Full call number)
                   5) Click Display more constraints
                   6) In Others Options, Plugin, Choose cn_browser.pl and save
changes
                   7) Search a record and edit its items
                   Validate : three points (?) beside Full call number input
                   8)  Click in ?
                   Validate : if it can not find the given call number, a green
line is shown. Otherwise,  the given call number is highlighted in red.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 18:08:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 17:08:17 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-d7E9b4QhoY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36235|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 18:08:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 17:08:39 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-h2zHbqHuNR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 18:42:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 17:42:16 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-2JWuk7pIqS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35997|0                           |1
        is obsolete|                            |

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Created attachment 36250
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36250&action=edit
Bug 4041 - Second Step: Add system preference and "German style" address
formats for staff

To test:

Apply patch
Do a database update (e.g. by changing version number in kohaversion.pl)
Find new system preference 'addressformat' in I18N/L10N
Choose 'German style'
Go to Patrons and edit a patron / create new patron
Verify that Zip code appears above City
Change system preference to 'US style'
Verify that Zip code appears between State and Country.

BTW: New formats can be added by editing i18n_l10n.pref (add a new code, e.g.
fr for "French style") and copy / modify the includes using the same code as
postfix.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 18:50:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 17:50:52 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-QffYQYhI7L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |veron at veron.ch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 18:58:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 17:58:23 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-o5GWcCbbtT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
Updated to make patch "Second Step" apply.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 20:00:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 19:00:02 +0000
Subject: [Koha-bugs] [Bug 13334] Add a warning during the return of a
 document that was reserved to a course.
In-Reply-To: <bug-13334-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13334-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13334-70-U8Anv4mT1V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13334

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
It works as expected on returns.pl

However when I go to circulation.pl and check in using the button "Renow or
check in selected items", I would expect a similar message as well (or some
information in the "Checkouts" table e.g. in the column "Title")

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 20:33:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 19:33:00 +0000
Subject: [Koha-bugs] [Bug 13766] biblioitems.ean field is too short
In-Reply-To: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13766-70-d0fXJkUVJB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 36251
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36251&action=edit
[Signed-off] Bug 13766 Set biblioitems.ean type to MEDIUMTEXT

biblioitems.ean field is too short. It's a VARCHAR(13) type. EAN can be
longer, especially if it's repeated in the biblio record.

When biblio records are imported, and 073 (Unimarc) or 024 (MARC21)
field is repeated, their content can't be stored in biblioitems.ean
field: it stops the biblio record import.

This field should be aligned to biblioitems.isbn type: MEDIUMTEXT.

Verified that tables biblioitems and deletedbiblioitems are changed.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 20:33:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 19:33:27 +0000
Subject: [Koha-bugs] [Bug 13766] biblioitems.ean field is too short
In-Reply-To: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13766-70-kAguYbVlib@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 20:35:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 19:35:02 +0000
Subject: [Koha-bugs] [Bug 13766] biblioitems.ean field is too short
In-Reply-To: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13766-70-WSZOd3pT3W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36233|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 21:05:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 20:05:40 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-mtrk1Vg6XW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35987|0                           |1
        is obsolete|                            |

--- Comment #10 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36252
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36252&action=edit
Bug 4041 - First step (staff interface): Extract address blocks to include
files

This patch extracts the address blocks in memberentrygen.tt to include files.

To test: The overall functionality should remain the same with this patch.

In further steps, more country- or region-dependent includes could be added,
along with functionality to select them using a system preference.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 21:15:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 20:15:59 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-AXUtrx0FfI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 21:16:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 20:16:25 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-PMPfA68HgR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 21:16:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 20:16:43 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-MyrWN3KZvG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36250|0                           |1
        is obsolete|                            |

--- Comment #11 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36253
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36253&action=edit
Bug 4041 - Second Step: Add system preference and "German style" address
formats for staff

To test:

Apply patch
Do a database update (e.g. by changing version number in kohaversion.pl)
Find new system preference 'addressformat' in I18N/L10N
Choose 'German style'
Go to Patrons and edit a patron / create new patron
Verify that Zip code appears above City
Change system preference to 'US style'
Verify that Zip code appears between State and Country.

BTW: New formats can be added by editing i18n_l10n.pref (add a new code, e.g.
fr for "French style") and copy / modify the includes using the same code as
postfix.
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 21:17:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 20:17:02 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-8G4Gn3nFYE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 21:18:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 20:18:38 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-H4tPwh5Rc1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

--- Comment #12 from Mirko Tietgen <mirko at abunchofthings.net> ---
Works for me. Not sure about the naming of the styles, maybe something more
generic would be possible.

?German style? should also move the street number for Main address.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 22:00:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 21:00:53 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-fv1zqFr4th@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36253|0                           |1
        is obsolete|                            |

--- Comment #13 from Marc V?ron <veron at veron.ch> ---
Created attachment 36254
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36254&action=edit
Bug 4041 - Second Step: Add system preference and "German style" address
formats for staff

To test:

Apply patch
Do a database update (e.g. by changing version number in kohaversion.pl)
Find new system preference 'addressformat' in I18N/L10N
Choose 'German style'
Go to Patrons and edit a patron / create new patron
Verify that Zip code appears above City
Change system preference to 'US style'
Verify that Zip code appears between State and Country.

BTW: New formats can be added by editing i18n_l10n.pref (add a new code, e.g.
fr for "French style") and copy / modify the includes using the same code as
postfix.
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

Patch amended to move street number after address. /Marc

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 22:03:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 21:03:06 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-4BhtHWsHuJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #14 from Marc V?ron <veron at veron.ch> ---
I think my amendement on Patch "Second step" needs a new Sign-off.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 22:07:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 21:07:18 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-WPTdsJPOuq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36254|0                           |1
        is obsolete|                            |

--- Comment #15 from Marc V?ron <veron at veron.ch> ---
Created attachment 36255
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36255&action=edit
Bug 4041 - Second Step: Add system preference and "German style" address
formats for staff

To test:

Apply patch
Do a database update (e.g. by changing version number in kohaversion.pl)
Find new system preference 'addressformat' in I18N/L10N
Choose 'German style'
Go to Patrons and edit a patron / create new patron
Verify that Zip code appears above City
Change system preference to 'US style'
Verify that Zip code appears between State and Country.

BTW: New formats can be added by editing i18n_l10n.pref (add a new code, e.g.
fr for "French style") and copy / modify the includes using the same code as
postfix.
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

Patch amended to move street number after address. /Marc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 22:10:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 21:10:12 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-RoZIBlisxP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36255|0                           |1
        is obsolete|                            |

--- Comment #16 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36256
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36256&action=edit
Bug 4041 - Second Step: Add system preference and "German style" address
formats for staff

To test:

Apply patch
Do a database update (e.g. by changing version number in kohaversion.pl)
Find new system preference 'addressformat' in I18N/L10N
Choose 'German style'
Go to Patrons and edit a patron / create new patron
Verify that Zip code appears above City
Change system preference to 'US style'
Verify that Zip code appears between State and Country.

BTW: New formats can be added by editing i18n_l10n.pref (add a new code, e.g.
fr for "French style") and copy / modify the includes using the same code as
postfix.
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

Patch amended to move street number after address. /Marc

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 22:10:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 21:10:40 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-OTGqFB5U2e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 23:27:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 22:27:51 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-TAUL7NmRi6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  1 23:30:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Mar 2015 22:30:37 +0000
Subject: [Koha-bugs] [Bug 13770] There should be a command in Debian
 packages to switch to DOM indexing
In-Reply-To: <bug-13770-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13770-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13770-70-GqA8fB9Oky@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13770

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 01:50:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 00:50:51 +0000
Subject: [Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19
	(October 2014)
In-Reply-To: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13322-70-o6j3yanzOc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36257
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36257&action=edit
Bug 13322: Update MARC21 frameworks to Update No. 19

Summary of changes:
1) Bibliographic
- Added fields 370 and 388
- 382s is non repeatable
- $g added to 650 and 651
- $g now repeatable on 100,110,111,130,240,243,246,247,
  600,610,611,630,700,710,711,730,800,810,811 and 830

2) Authority
- Added field 388
- New $g on 150,151,450,451,550,551,750 and 751
- New $i on 700,710,711,730,748,750,751,755,762,780,781,782 and 785
- New $4 on 700,710,711,730,748,750,751,755,762,780,781,782,785 and 788
- $g now repeatable on 100,110,111,130,400,410,411,430,500,
  510,511,530,700,710,711 and 730

This patch updates MARC21 frameworks to Update No. 19 (October 2014)
Also updates values on database for MARC21 installs.

To test
1. Apply the patch
2. Run updatedatbase.pl, check that runs without error
3. Remove default frameworks, bibliographic and authorities (all of them),
load again. Check that both files load without errors.
4. Verify changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 01:57:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 00:57:21 +0000
Subject: [Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19
	(October 2014)
In-Reply-To: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13322-70-JiNAMHe64F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36257|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36258
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36258&action=edit
Bug 13322: Update MARC21 frameworks to Update No. 19

Summary of changes:
1) Bibliographic
- Added fields 370 and 388
- 382s is non repeatable
- $g added to 650 and 651
- $g now repeatable on 100,110,111,130,240,243,246,247,
  600,610,611,630,700,710,711,730,800,810,811 and 830

2) Authority
- Added field 388
- New $g on 150,151,450,451,550,551,750 and 751
- New $i on 700,710,711,730,748,750,751,755,762,780,781,782 and 785
- New $4 on 700,710,711,730,748,750,751,755,762,780,781,782,785 and 788
- $g now repeatable on 100,110,111,130,400,410,411,430,500,
  510,511,530,700,710,711 and 730

This patch updates MARC21 frameworks to Update No. 19 (October 2014)
Also updates values on database for MARC21 installs.

To test
1. Apply the patch
2. Run updatedatbase.pl, check that runs without error
3. Remove default frameworks, bibliographic and authorities (all of them),
load again. Check that both files load without errors.
4. Verify changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 01:58:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 00:58:29 +0000
Subject: [Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19
	(October 2014)
In-Reply-To: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13322-70-Mr3YL7SAYI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 02:38:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 01:38:51 +0000
Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging
	in Koha
In-Reply-To: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13413-70-QBlHXm5apc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413

--- Comment #14 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #13)
> Did you read the discussion on bug 8190? There are a lot of ideas on it.
> 
> The way to use it is:
> 
>   my $logger = C4::Context->logger();
>   $logger->info("OPAC: Search for $query");

Yes, and that is precisely what I find inflexible. One size fits all is
offered. My approach was use it where/when you need it the way you need it. Log
to file/syslog/email/wherever depending on your needs. So the answer is - you
don't. Eg you configure it in the psgi script, or in a cron job. Or in a
module, if you need something special.

My initial pains were SIP and some cron jobs.

I do understand that majority may prefer having it already there in context
with some less flexibility, in which case we'll pick the other one and go with
that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 02:46:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 01:46:02 +0000
Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging
	in Koha
In-Reply-To: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13413-70-KYe9TgfZM8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34188|0                           |1
        is obsolete|                            |

--- Comment #15 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 36259
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36259&action=edit
bug_13413: Koha::Log - logging for Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 02:46:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 01:46:13 +0000
Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging
	in Koha
In-Reply-To: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13413-70-7Uojzon4wZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34189|0                           |1
        is obsolete|                            |

--- Comment #16 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 36260
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36260&action=edit
bug_13413: use Koha::Log with syslog sink instead of syslog directly in
Sipserver.pm

This way we can sift out debugs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 02:46:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 01:46:22 +0000
Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging
	in Koha
In-Reply-To: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13413-70-d7UWkhJnQo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34190|0                           |1
        is obsolete|                            |

--- Comment #17 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 36261
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36261&action=edit
bug_13413: Koha::Log in longoverdue.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 02:48:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 01:48:06 +0000
Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging
	in Koha
In-Reply-To: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13413-70-qSg7h3Ev3o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413

--- Comment #18 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---

> Go on the mainpage.
> boom, module is missing

Added dependancy.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 02:57:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 01:57:36 +0000
Subject: [Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19
	(October 2014)
In-Reply-To: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13322-70-aQJ80tEY88@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 07:22:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 06:22:56 +0000
Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client
In-Reply-To: <bug-13630-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13630-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13630-70-bc1ZOMcYeL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630

--- Comment #11 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 36262
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36262&action=edit
Bug 13630 - Basic Angular circulation client

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 07:37:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 06:37:37 +0000
Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar
In-Reply-To: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11211-70-NfhfwM16qQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

--- Comment #47 from Jesse Weaver <jweaver at bywatersolutions.com> ---
(In reply to Magnus Enger from comment #46)
> I have provided a followup in attachment 34040 [details] [review] that
> should take care of most of the problems I have found. This probably needs a
> signoff. If this followup meets with approval, I think there is still one
> question that needs to be addressed:
> 
> Jonatahan, comment 5: "Could you explain why you changed "holiday" with
> "event" and you removed "Holiday exception" please?"
> 
> Me, comment 32: "4. With this patch applied you now get to choose if the
> library is open or closed when you add an event. As far as I can tell, the
> special_holidays.isexception field is used to record open/closed. But the
> description for this field is "is this a holiday exception to a repeatable
> holiday (1 for yes, 0 for no)". Is open/closed a sensible use/interpretation
> of this field? I am not sure of the usage, so I am only raising this as a
> question."
> 
> To rephrase: Does the repurposing of special_holidays.isexception to store
> open/closed make sense, and does it mean we loose some functionality
> connected to making exceptions from repeating holidays?

RE: comment 5: I used event instead of holiday because you can now record that
a given day is open or closed, seperately of the precedence order of specific
day > day/month > weekday. 

RE: comment 32: I will at least cite lines 219-220 of Koha/Calendar.pm to argue
for this patch's interpretation of isexception == open:

        # exceptions are not holidays
        return 0;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:00:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 08:00:35 +0000
Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable
	version
In-Reply-To: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12399-70-6pCWbvixs6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:00:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 08:00:37 +0000
Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable
	version
In-Reply-To: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12399-70-jusHB7kRDD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35711|0                           |1
        is obsolete|                            |

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36263
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36263&action=edit
Bug 12399 - opaccredits printing at top on printable version

This patch introduces a new class "noprint" in
koha-tmpl/opac-tmpl/bootstrap/css/print.css
With this class, unwanted elements can be hidden when printing.

To test:
In OPAC, do a search with many results (> 1 Page)
Print page or do a print preview
See that footer elements are not displayed correctly (as of screenshot in
comment #1) and that on top of page 2 the language selector overlays the list
Apply patch
Repeat steps above.
Verify that printed page looks much nicer now by hiding unwanted elements
(including e.g. RSS icon, toolbar etc.)

This mechanism can be used on other pages as well.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:10:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 08:10:37 +0000
Subject: [Koha-bugs] [Bug 13761] Hide toolbar when printing a list page
In-Reply-To: <bug-13761-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13761-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13761-70-QRbyEImsn2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:38:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 08:38:44 +0000
Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with
 diacritics, utf-8 or ttf fonts
In-Reply-To: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13709-70-2Ayo1k5DMW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:38:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 08:38:45 +0000
Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with
 diacritics, utf-8 or ttf fonts
In-Reply-To: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13709-70-J7lVURFBxo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35906|0                           |1
        is obsolete|                            |

--- Comment #2 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36264
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36264&action=edit
Bug 13709 - Patron cards creator utf-8 encoding and ttf fonts broken

This change is similar to Bug 8375 which introduced ttf fonts for
labels printing in order to support diacritics and utf-8 encoding,
but this change was never implemented for patron cards.

Test scenario:

1. make sure that you have <ttf> font mapping in koha-conf.xml
2. define partron card layout, template, profile and batch
   (with utf-8 chars, probably in patron firstname or surname)
3. verify that without this patch pdf export file is error message
   Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820
4. apply this patch and verify that generated pdf has correct encoding

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Followed test plan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:41:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 08:41:14 +0000
Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item
	form
In-Reply-To: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13648-70-En2F5pao5o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #4 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36265
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36265&action=edit
0001-SIGNED-OFF-Bug-13648-OPAC-hidden-removes-pull-down

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:41:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 08:41:30 +0000
Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item
	form
In-Reply-To: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13648-70-pdxa5aJMDn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 09:55:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 08:55:40 +0000
Subject: [Koha-bugs] [Bug 13771] New: Koha 3.18 Help Files
Message-ID: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

            Bug ID: 13771
           Summary: Koha 3.18 Help Files
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Documentation
          Assignee: nengard at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

To come.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:27:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 09:27:49 +0000
Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client
In-Reply-To: <bug-13630-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13630-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13630-70-LWxbRn6349@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:28:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 09:28:51 +0000
Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client
In-Reply-To: <bug-13630-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13630-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13630-70-Yn0Tu5HBua@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630

--- Comment #12 from Nicole C. Engard <nengard at gmail.com> ---
Changed to 'needs signoff' since Jesse just attached a patch. Feel free to
change back if that was inaccurate.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:38:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 09:38:10 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-T05gOWEaA3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:43:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 09:43:57 +0000
Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name
 on patron details
In-Reply-To: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13657-70-2kQtK0jL42@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:43:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 09:43:59 +0000
Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name
 on patron details
In-Reply-To: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13657-70-nHoY4oMTqb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35805|0                           |1
        is obsolete|                            |

--- Comment #3 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 36266
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36266&action=edit
Bug 13657 - Don't show extra comma after guarantor name on patron details

This patch suppresses the first name part (including comma) if first name is
empty. This way, first name is still displays with natural persons, but not
with organizations.

To test:
Apply this patch (without the first patch).
Have one patron with a natural person as guarantor and one patron with an
organization as guarantor. Verify that both display properly on the patron
details page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:50:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 09:50:31 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-SLdzMHcXjY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36267
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36267&action=edit
0001-Bug-13771-Main-Page-Help-fro-3.18

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:51:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 09:51:55 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-YLEHPQvaNT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 10:58:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 09:58:30 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house uses
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-EcuoF2sZL6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |nengard at gmail.com

--- Comment #10 from Nicole C. Engard <nengard at gmail.com> ---
I am not seeing anything on my on site checkouts page and I do have an item
checked out for onsite. Is there something else I need to do?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:11:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:11:37 +0000
Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items
 and biblioitems
In-Reply-To: <bug-13707-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13707-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13707-70-E4X9lwmyhf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:14:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:14:53 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-2bYcTrN66Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #2 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 36268
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36268&action=edit
Bug 13771: Main Page Help fro 3.18

This updates the main page help file for 3.18.

To test:
* Log in to staff cleint
* Click help on the mian page
* Review help file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:14:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:14:51 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-jINKpfMIiu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:15:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:15:59 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-1kBEf8pqzs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com
  Attachment #36267|1                           |0
           is patch|                            |
  Attachment #36267|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:30:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:30:41 +0000
Subject: [Koha-bugs] [Bug 13772] New: koha-translate still looks for ccsr
 and prog OPAC themes
Message-ID: <bug-13772-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13772

            Bug ID: 13772
           Summary: koha-translate still looks for ccsr and prog OPAC
                    themes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Packaging
          Assignee: magnus at enger.priv.no
          Reporter: magnus at enger.priv.no
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

If you run e.g. "koha-translate -u nb-NO" you get some warnings about missing
directories:

$ sudo koha-translate -u nb-NO
/usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more
information.
/usr/share/koha/opac/htdocs/opac-tmpl/prog/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more
information.

This is caused by the following lines in koha-create:

rm -rf $KOHA_INSTALL_DIR/opac/htdocs/opac-tmpl/prog/$lang
rm -rf $KOHA_INSTALL_DIR/opac/htdocs/opac-tmpl/ccsr/$lang
rm -rf $KOHA_INSTALL_DIR/opac/htdocs/opac-tmpl/bootstrap/$lang
rm -rf $KOHA_INSTALL_DIR/intranet/htdocs/intranet-tmpl/prog/$lang

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:33:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:33:40 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-Vwi0b6rh1x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36268|Bug 13771: Main Page Help   |[SIGNED-OFF] Bug 13771:
        description|fro 3.18                    |Main Page Help fro 3.18

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:34:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:34:45 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-6LtPajnltS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #3 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36269
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36269&action=edit
BUG 13771: Update Tools Help Files for 3.18

To test:

* Visit tools > batch record deletion
* confirm help is right
* Visit tools > Notices & Slips
* confirm help is right
* Visit tools > export marc
* cofirm the help is right

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:34:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:34:52 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-gyGSvqz5su@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:50:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:50:10 +0000
Subject: [Koha-bugs] [Bug 13773] New: add stock number to details and items
	display
Message-ID: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

            Bug ID: 13773
           Summary: add stock number to details and items display
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: dpavlin at rot13.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:57:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:57:04 +0000
Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a
	basket/list by email
In-Reply-To: <bug-13345-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13345-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13345-70-TExd2mni7Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35509|0                           |1
        is obsolete|                            |
                 CC|                            |nengard at gmail.com

--- Comment #6 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36270
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36270&action=edit
[SIGNED-OFF] Bug 13345: Allow patrons to choose format on sending basket/list
by email

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:57:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:57:11 +0000
Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a
	basket/list by email
In-Reply-To: <bug-13345-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13345-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13345-70-AjdhQQyS40@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:57:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:57:52 +0000
Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for
 checking in items that are not checked out
In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13411-70-KNHBvYp5Mx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:58:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:58:22 +0000
Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for
 checking in items that are not checked out
In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13411-70-0MpQqAKB6L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35669|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36271
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36271&action=edit
Bug 13411 - Koha's SIP server returns not ok for checking in items that are not
checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an "ok" of 0, and the AF message "Item
not checked out". I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the "special handling" been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l
<instituation id> --item <barcode> -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not
checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP
account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not
recieve the item not checked out message.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:58:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:58:33 +0000
Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a
 suggestion can be treated
In-Reply-To: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13014-70-0nV2tqhDko@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:58:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:58:40 +0000
Subject: [Koha-bugs] [Bug 13772] koha-translate still looks for ccsr and
	prog OPAC themes
In-Reply-To: <bug-13772-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13772-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13772-70-LKOyum2wlh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13772

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:58:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:58:40 +0000
Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a
 suggestion can be treated
In-Reply-To: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13014-70-ERsLfsOs9U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35603|0                           |1
        is obsolete|                            |

--- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36272
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36272&action=edit
Bug 13014: Notify budget owner on new suggestion - UT

When a suggestion is created and linked to a fund, a mail will be
generated, using a cronjob, to notify the budget owner.

A suggestion is considered as "can be treated" if its status is "ASKED".

Signed-off-by: Frederic Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:58:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:58:48 +0000
Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a
 suggestion can be treated
In-Reply-To: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13014-70-9T0BMb4K1v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35604|0                           |1
        is obsolete|                            |

--- Comment #29 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36273
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36273&action=edit
Bug 13014: Notify budget owner on new suggestion - sample notices

This patch add the new notice suggestion > TO_PROCESS

Others will be added when the patch will be signed off.

Signed-off-by: Frederic Demians <f.demians at tamil.fr>

Followup expected :-) It would be nice also to have an updatabase.pl entry to
insert the new TO_PROCESS notification.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:59:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:59:10 +0000
Subject: [Koha-bugs] [Bug 13772] koha-translate still looks for ccsr and
	prog OPAC themes
In-Reply-To: <bug-13772-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13772-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13772-70-eBDFYfs4hz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13772

--- Comment #1 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36274
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36274&action=edit
Bug 13772 - koha-translate still looks for CCSR and prog

koha-translate still tries to use the CCSR and prog OPAC themes.

To reproduce:
- Make sure you have at least one other language than en installed
- Try to update the language with "koha-translate -u <langcode>"
- Observe warnings similar to this:

$ sudo koha-translate -u nb-NO
/usr/share/koha/opac/htdocs/opac-tmpl/ccsr/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
    Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more
information.
    /usr/share/koha/opac/htdocs/opac-tmpl/prog/en/: Input must be a directory.
    (Symbolic links are not supported at the moment)
    Try `/usr/share/koha/misc/translator/tmpl_process3.pl --help for more
information.

To test:
(This is probably easiest to test on a gitified setup)
- Apply the patch to your git repo
- Copy the modified koha-ranslate to a place where you can use it, e.g.:
  $ sudo cp debian/scripts/koha-translate /usr/sbin/koha-translate
- Run "koha-translate -u <langcode>" again
- Observe the lack of warnings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:59:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:59:21 +0000
Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a
 suggestion can be treated
In-Reply-To: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13014-70-TDehl5VQZz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35605|0                           |1
        is obsolete|                            |

--- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36275
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36275&action=edit
Bug 13014: Notify budget owner on new suggestion - cronjob

Test plan:
0/ Create a new notice suggestions > TO_PROCESS
You can use the one defined in the other patch.
1/ Create a suggestion and link it to a fund
2/ Add a owner to this fund and make sure this patron has an email
address (the email address used should be the one defined in the
AutoEmailPrimaryAddress syspref).
3/ Execute the cronjob script with the -v and without the -c argument
4/ The output should tell you that an email will be sent
5/ Execute the cronjob script with the -v and with the -c argument
6/ Verify the notice is generated in the message_queue table and it is
correctly formatted.

Signed-off-by: Frederic Demians <f.demians at tamil.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:59:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:59:34 +0000
Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a
 suggestion can be treated
In-Reply-To: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13014-70-afpCZfBP71@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35606|0                           |1
        is obsolete|                            |

--- Comment #31 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36276
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36276&action=edit
Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices

This patch adds the new notice for all other languages.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 11:59:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 10:59:45 +0000
Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a
 suggestion can be treated
In-Reply-To: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13014-70-F3L7yEhieh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35607|0                           |1
        is obsolete|                            |

--- Comment #32 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36277
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36277&action=edit
Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices

This patch updates the 2 optional sample_notices.sql files for ru-RU and
uk-UA.
Not sure if it is relevant but I don't understand why they are not
up-to-date.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:09:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:09:37 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-rinQTo7pGj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #14 from Viktor Sarge <viktor.sarge at regionhalland.se> ---
Thanks for helping out with newbie mistakes! I'll add links to the posts too
since 12729 is now pushed, but I think I'll do a new patch for that even if
it's a tiny patch so I don't mess this one up after it's now passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:09:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:09:55 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-igapbv2GiK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

--- Comment #110 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Picking this up again now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:12:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:12:23 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house uses
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-FUTKoxrKJU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:12:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:12:28 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house uses
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-tvcJZwrwRI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33185|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36278
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36278&action=edit
Bug 11201: Display overdues in red

On the pending on-site checkout list, the date for overdues are now
displayed in red.

Test plan:
Make sure you have on-site checkouts created today and before.
The date for the ones created before today should be displayed in red.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:18:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:18:36 +0000
Subject: [Koha-bugs] [Bug 13611] Serial enumeration not visible in the
 opac-user.pl when browsing own holds.
In-Reply-To: <bug-13611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13611-70-oDucxx7zoZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35465|0                           |1
        is obsolete|                            |
                 CC|                            |nengard at gmail.com

--- Comment #3 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36279
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36279&action=edit
[SIGNED-OFF] Bug 13611 - Serial enumeration not visible in the opac-user.pl
when browsing own holds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:18:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:18:44 +0000
Subject: [Koha-bugs] [Bug 13611] Serial enumeration not visible in the
 opac-user.pl when browsing own holds.
In-Reply-To: <bug-13611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13611-70-Qznv3gLkqu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:18:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:18:44 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house uses
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-dXIerTXKSd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Nicole C. Engard from comment #10)
> I am not seeing anything on my on site checkouts page and I do have an item
> checked out for onsite. Is there something else I need to do?

Sorry Nicole, there was a syntax error in the sql query.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:20:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:20:38 +0000
Subject: [Koha-bugs] [Bug 13611] Serial enumeration not visible in the
 opac-user.pl when browsing own holds.
In-Reply-To: <bug-13611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13611-70-kywr8HJVTo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611

--- Comment #4 from Nicole C. Engard <nengard at gmail.com> ---
Olli,

Next time you should include a test plan with the patch - this was obvious to
me so I was able to test it and sign off easily instead of waiting for a new
patch.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:24:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:24:32 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-0vq5K6TBzu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:24:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:24:36 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-4IQT9MUthK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

--- Comment #1 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36280
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36280&action=edit
Bug 13773 - add stock number to details and items display

This patch adds stocknumber to details table and items display if it exists.

Test scenario:
1. find item(s) which have stock number assigned
2. verify that you don't see stock number in items display
3. apply this patch
4. verify that stock number is now available

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:24:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:24:57 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-cylQsQwjoF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |dpavlin at rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:30:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:30:31 +0000
Subject: [Koha-bugs] [Bug 13774] New: Add the unique anchors of news as
 links in the RSS for news in Opac
Message-ID: <bug-13774-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774

            Bug ID: 13774
           Summary: Add the unique anchors of news as links in the RSS for
                    news in Opac
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: viktor.sarge at regionhalland.se
        QA Contact: testopia at bugs.koha-community.org

Bug 7843 introduces an RSS stream for news (currently passed QA) which is valid
but don't have a good unique URI of each newsitem for linking purposes. Bug
12729 (pushed) creates unique a unique anchor id for each newsitem and I
propose to update the RSS stream with links to these anchors as a first step.
The next step would be to create some form of single item view for news and
probably a news archive instead of deleting the news when they time out.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:32:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:32:43 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-YZguUkQW1a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #47 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Updated test plan:

Enable the makePreviousSerialAvailable syspref. Set the item-level_itypes
syspref to 'specific item'.

Create a subscription, with the 'create an item record when receiving this
serial' option enabled.

Select an item-type (let's say ItemType) and a previous item-type (let's say
OldItemType).

Receive a serial, and then another, then check that:

 - the first received serial's itemtype has been set to the "previous item
type" value which was set in the subscription (OldItemType in our example).

 - the first received has been made available.

 - the last received serial itemtype has been set to the "item type" value,
which was set in the subscription (ItemType in our example).

 - enumchron field of the item is automatically prefilled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:34:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:34:12 +0000
Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save
In-Reply-To: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13731-70-FvjIKKMvlP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:34:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:34:20 +0000
Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save
In-Reply-To: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13731-70-kgWKuGPIC9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36140|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36281
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36281&action=edit
[PASSED QA] Bug 13731: Suggestions reason does not save on updating the status

On the suggestion list view, if you set a status, it won't be saved.

Test plan:
1/ Create a suggestion
2/ Go on the suggestion list view (suggestion/suggestion.pl)
3/ Select a suggestion and marked it as "rejected" (or the status you
want) and choose a reason
4/ Save
5/ Browse you suggestions DB table (using your favorite MySQL CLI) and
verify that the "reason" field is correctly filled.

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as expected, thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:40:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:40:25 +0000
Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices
 cronjob is broken
In-Reply-To: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11120-70-wKVT6amwgK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:40:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:40:27 +0000
Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices
 cronjob is broken
In-Reply-To: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11120-70-4cNoyXnyEo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34962|0                           |1
        is obsolete|                            |

--- Comment #27 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36282
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36282&action=edit
Bug 11120: FIX the --date option for overdue_notices cronjob

Bug 7447 introduces the --date option for overdue notices.
This option has never worked: the code is waiting for a value but the
option is defined as a boolean.

This patch fixes the option and change the way to calculate the range of
dates.
This range is now managed in Perl instead of in the SQL query. To do it
in Perl allows to build dates simply using the DateTime and
DateTime::Duration modules.

To test this patch you should have a DB with a lot of overdues, (I
tested on a DB with 512 overdues).
A test plan could be:
1/ Dump your message_queue table
2/ Verify the number of overdues in the database before applying the
  patch:
  mysql> DELETE FROM message_queue;
  perl misc/cronjobs/overdue_notices.pl -v -t
  (the triggered option will generate overdue for today)
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 2A

  mysql> DELETE FROM message_queue;
  perl misc/cronjobs/overdue_notices.pl -v
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 2B

2/ Apply the patch
4/ Verify the number of overdues generated by the patched script:
  mysql> DELETE FROM message_queue;
  perl misc/cronjobs/overdue_notices.pl -v -t
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 4A

  mysql> DELETE FROM message_queue;
  perl misc/cronjobs/overdue_notices.pl -v
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 4B

  mysql> DELETE FROM message_queue;
  # The date should be defined depending your dateformat preference
  # and should be the date of the current day
  perl misc/cronjobs/overdue_notices.pl -v -t --date="YYYY-MM-DD"
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 4C

  mysql> DELETE FROM message_queue;
  # The date should be defined depending your dateformat preference
  # and should be the date of the current day
  perl misc/cronjobs/overdue_notices.pl -v --date="YYYY-MM-DD"
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 4D

5/ Compare the values: All values generated with the -t options should
be equals. Same for values without the -t options.
=> 2A == 4A == 4C and 2B == 4B == 4D

6/ Go back to a normal activity for 3 days or manually change the
date_due for issues in the DB:
  mysql> update issues SET date_due = DATE_SUB(date_due, INTERVAL 3 DAY);
Do again step 4C and 4D with a date equals to today - 3 days.
Values should be the same as 4C and 4D.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tested with my own test data, checked generating overdues
with and without the --date option.
All worked as expected.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
I test with 5318 overdues - works

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:40:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:40:35 +0000
Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices
 cronjob is broken
In-Reply-To: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11120-70-0LB7UpW02X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34979|0                           |1
        is obsolete|                            |

--- Comment #28 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36283
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36283&action=edit
Bug 11120: Follow-up: adding a hint about the date format

Adding 2 hints about the expected date format to the error
message and the help.

To test:
- Run overdue_notices.pl --date <someinvaliddate>
- Run overdue_notices.pl -man
- Verify hint about date format shows up

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:40:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:40:44 +0000
Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices
 cronjob is broken
In-Reply-To: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11120-70-YIImDnE7DG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34980|0                           |1
        is obsolete|                            |

--- Comment #29 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36284
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36284&action=edit
Bug 11120: the date input should be in a iso format (YYYY-MM-DD)

Note that it cans also accept a date in the same format defined in the
dateformat system preference.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:44:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:44:47 +0000
Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in
	koha-indexer
In-Reply-To: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13753-70-r5g73xAIZj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:44:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:44:53 +0000
Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in
	koha-indexer
In-Reply-To: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13753-70-PBYZDQaHXJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36169|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36285
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36285&action=edit
[PASSED QA] Bug 13731: Suggestions reason does not save on updating the status

On the suggestion list view, if you set a status, it won't be saved.

Test plan:
1/ Create a suggestion
2/ Go on the suggestion list view (suggestion/suggestion.pl)
3/ Select a suggestion and marked it as "rejected" (or the status you
want) and choose a reason
4/ Save
5/ Browse you suggestions DB table (using your favorite MySQL CLI) and
verify that the "reason" field is correctly filled.

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:47:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:47:01 +0000
Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in
	koha-indexer
In-Reply-To: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13753-70-2gvX4mRD51@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
  Attachment #36169|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:48:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:48:20 +0000
Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in
	koha-indexer
In-Reply-To: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13753-70-M8M15K25mI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36169|0                           |1
        is obsolete|                            |
  Attachment #36285|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36286
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36286&action=edit
[PASSED QA] Bug 13753: koha-indexer contains invalid statement

An incorrect conditional makes the indexer daemon fail to load.

To test:
- Enable the indexer daemon on packages [1]
- Restart koha-common:
  $ service koha-common restart
- Run
  $ ps waux | grep koha-indexer
=> FAIL: there's no reference to the rebuild_zebra.pl script
  (line should look like *rebuild_zebra.pl -daemon*)
   Run ps -ef | grep rebuild_zebra.pl too to make sure.
- Apply the patch, repeat the steps
=> SUCCESS: the rebuild_zebra.pl script is ran
- Sign off :-D

Thanks

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:50:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:50:24 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-mVlaVmU2AN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:51:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:51:12 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-gCnZsnfvdE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35686|0                           |1
        is obsolete|                            |
  Attachment #35687|0                           |1
        is obsolete|                            |
  Attachment #35688|0                           |1
        is obsolete|                            |
  Attachment #35689|0                           |1
        is obsolete|                            |
  Attachment #35690|0                           |1
        is obsolete|                            |
  Attachment #35691|0                           |1
        is obsolete|                            |
  Attachment #35832|0                           |1
        is obsolete|                            |

--- Comment #201 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36287
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36287&action=edit
Bug 9303 [1] - relative's checkouts in the opac - Database Updates

This patch gives patrons the option of allowing other
linked relatives to view his or her checkouts from
opac-user.pl in a manner similiar to the patron's own
checkouts tab. By default the setting is not enabled.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create three borrowers, link them as relatives
4) In the OPAC, go to "my privacy" and choose to allow
   relatives to view current checkouts for borrowers A and B
5) Check out some items to each borrower
6) Log into the OPAC as borrower A, you should see a "Relatives'
   checkouts" tab. In this tab you should see the checkouts for
   borrower B
7) Log into the OPAC as borrower C, you should be able to view
   the current checkouts for both borrower A and borrower B

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:51:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:51:47 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-7rCjcosqAw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #202 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36288
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36288&action=edit
Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e   
opac/svc/patron/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 12:52:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 11:52:22 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-UyOpeeA7q0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #203 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36289
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36289&action=edit
Bug 9303 [3] - relative's checkouts in the opac

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 13:32:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 12:32:32 +0000
Subject: [Koha-bugs] [Bug 13775] New: software error when choosing authority
	via plugin
Message-ID: <bug-13775-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

            Bug ID: 13775
           Summary: software error when choosing authority via plugin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When cataloging if you use the authority chooser plugin you get the following
error when clicking 'choose'



Software error:

Can't call method "field" on an undefined value at
/home/nengard/kohaclone/authorities/blinddetail-biblio-search.pl line 82.





My URL looks like this:
cgi-bin/koha/authorities/blinddetail-biblio-search.pl?authid=948&index=tag_600_subfield_a_847208_166743&repet=

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:13:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:13:04 +0000
Subject: [Koha-bugs] [Bug 13776] New: Problem linking an authority if an
 authorized value is linked to a biblio subfield framework
Message-ID: <bug-13776-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13776

            Bug ID: 13776
           Summary: Problem linking an authority if an authorized value is
                    linked to a biblio subfield framework
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

If on a biblio framework by mistake you link a subfield to an authorized value
(dropdown list) (let's say 100$e) on an field linked to authority records, then
when trying to link the authority the ?blinddetail-biblio-search.pl pop-up
never close and the authority is not linked.

Steps to reproduce:
+ Edit a subfield of a field linked to authority records to an authorized value
list (for example 100$e, or 650$2).
+ Edit or add a new biblio record.
+ Go to the selected field and try to add a new authority.
+ After clicking "choose" ?blinddetail-biblio-search.pl pop-up never close. The
link to auth record is not created.

Is not related but very similar to what happens on bug ?#5093.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:26:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:26:45 +0000
Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to
	circulation.pl
In-Reply-To: <bug-13315-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13315-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13315-70-PlybLMgTOY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34384|0                           |1
        is obsolete|                            |
  Attachment #34385|0                           |1
        is obsolete|                            |

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36290
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36290&action=edit
Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl

This patch changes the position and styling of the information about the
last checkout so that it is grouped with the checkout form itself,
placing the message in a more visible position, especially for patrons
with a lot of information in the right-hand messages column which might
push the checkouts table down offscreen.

To test, apply the patch and clear your browser cache in order to
refresh the main CSS file.

Check out an item and confirm that a message is prominently displayed.

Signed-off-by: Jason Burds  <jburds at dubuque.lib.ia.us>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:26:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:26:40 +0000
Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to
	circulation.pl
In-Reply-To: <bug-13315-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13315-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13315-70-rpR8r7SfYH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:27:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:27:34 +0000
Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to
	circulation.pl
In-Reply-To: <bug-13315-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13315-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13315-70-CbZj9SqJOY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36290|0                           |1
        is obsolete|                            |

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36291
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36291&action=edit
Bug 13315 - Add feedback for last item checked out to circulation.pl

It seems that many librarians find it disconcerting to have no feedback
with the new checkouts table. It seems that many of them wait for it to
fully load, check to verify the item was checked out, and only then
check out the next item.

To help alleviate this issue, we can have the checkouts page give
feedback about the item that was just checked out.

Test Plan:
1) Apply this patch
2) Check an item out
3) Note the message "$title ($barcode) due on $date_due"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

This works well and fixes a very problematic issue with the new AJAX
circ. I will be submitting a follow-up which I think is an improvement
to the display.

Signed-off-by: Jason Burds  <jburds at dubuque.lib.ia.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:27:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:27:47 +0000
Subject: [Koha-bugs] [Bug 13569] Shibboleth example config for Packages
In-Reply-To: <bug-13569-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13569-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13569-70-6qkDNXyUCV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569

--- Comment #3 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
I'm getting conflict when trying to apply this patch, can you re-base it
please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:27:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:27:55 +0000
Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to
	circulation.pl
In-Reply-To: <bug-13315-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13315-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13315-70-DzLg8fwpcl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36292
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36292&action=edit
Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl

This patch changes the position and styling of the information about the
last checkout so that it is grouped with the checkout form itself,
placing the message in a more visible position, especially for patrons
with a lot of information in the right-hand messages column which might
push the checkouts table down offscreen.

To test, apply the patch and clear your browser cache in order to
refresh the main CSS file.

Check out an item and confirm that a message is prominently displayed.

Signed-off-by: Jason Burds  <jburds at dubuque.lib.ia.us>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:33:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:33:05 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-uuV6HHJrWp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36293
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36293&action=edit
Bug 13159 [QA Followup] - Fix changed namespace for Sip::Constants

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:33:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:33:55 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-e4ydmS682S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36294
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36294&action=edit
Bug 13159 [QA Followup] - Move script back to it's original path

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:35:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:35:08 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-efx3UyT9CI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35783|0                           |1
        is obsolete|                            |

--- Comment #111 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36295
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36295&action=edit
Bug 11395: Add a batch record modification

This patch offers a new tool to modify records in a batch.

This feature adds:
- a new pl/tt files tools/batch_record_modification
- a new permission: tools > records_batchmod

Test plan for biblios:
0/ Create a new marc modification template with some actions.
1/ Generate a list of biblionumbers you want to modify.
There are two ways to generate a list of biblionumbers:
- using the basket: do a search, add some biblio to your basket, open
  the basket and click on the "Action" button > "Modify"
- generating a list from a report
2/ On the "Batch record modification" tool verify:
- information is correct.
- the preview link show you the needed record.
3/ After clicking on the "Modify selected recors" button, verify
the records have been modified as you wanted.

Test plan for authority:
0/ Create a new marc modification template with some actions.
1/ Generate a list of authid using a report:
2/ On the "Batch record modification" tool verify:
- authorities are display with the summary.
- the preview link show you the needed record.
3/ After clicking on the "Modify selected recors" button, verify
the records have been modified as you wanted.

Catch of errors:
if an error occurs during the modification process, the tool
displays an error message.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:35:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:35:14 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-9U8rxgOSAz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35784|0                           |1
        is obsolete|                            |

--- Comment #112 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36296
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36296&action=edit
Bug 11395: Add links to the new tool page

This patch adds links in the tool module to the new batch tool and in
the basket.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:35:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:35:20 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-0uL4hXXkij@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35785|0                           |1
        is obsolete|                            |

--- Comment #113 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36297
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36297&action=edit
Bug 11395: New service to preview a record.

The main patch adds the ability to preview a record. This is done using
an AJAX way. The preview record is processed on the server side.

Note: I don't think an authentification check is necessary here.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:35:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:35:25 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-5ZmGpQsgoW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35786|0                           |1
        is obsolete|                            |

--- Comment #114 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36298
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36298&action=edit
Bug 11395: The modification template should be changed on the list view

This patch fixes the following issue:
If the user comes from a basket, the list view is displayed but there is
no way to select the modification template.

Now the template can be chosen on the list view. This way, the user is
able to change the modifications to apply and see the previewed records.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:35:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:35:31 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-zocZ5HF3Mu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35787|0                           |1
        is obsolete|                            |

--- Comment #115 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36299
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36299&action=edit
Bug 11395: DB: Add permission tools_records_batchmod

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:35:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:35:37 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-GU05JUZrxa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35788|0                           |1
        is obsolete|                            |

--- Comment #116 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36300
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36300&action=edit
Bug 11395: Fix path for the checkboxes jQuery plugin

This patch fixes a bad resolution conflict (bug 12107).

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:35:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:35:42 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-fUgwZk5k99@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35789|0                           |1
        is obsolete|                            |

--- Comment #117 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36301
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36301&action=edit
Bug 11395: prevent processing no record

If no record is selected, the modification should not be launched.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:35:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:35:48 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-00rhPqkVC5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35791|0                           |1
        is obsolete|                            |

--- Comment #118 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36302
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36302&action=edit
Bug 11395: exit should be done after displaying the output

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:35:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:35:54 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-AKp9RzwOTe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

--- Comment #119 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36303
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36303&action=edit
[FAILED_QA] Bug 11395: Raise an alert if control field is used

If a control field is used with a copy or move action, the interface
should block the user in some cases:
- If a control field is used with a regular field
- The subfield should be empty

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:36:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:36:00 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-THV5TEQ3NK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

--- Comment #120 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36304
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36304&action=edit
[FAILED_QA] Bug 11395: A control field is a field with tag < 10

This patch fixes the existing test about control fields.
A control field is < 10, not <=10!

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:36:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:36:50 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-LlsQKT3Zz9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35792|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:36:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:36:53 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-u5CE7KmxJE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35790|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:38:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:38:50 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-UdoUaeuuLj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:38:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:38:52 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-MXjhOLNZpH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36269|0                           |1
        is obsolete|                            |

--- Comment #4 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 36305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36305&action=edit
BUG 13771: Update Tools Help Files for 3.18

This patch creates a helpf ile for the batch record delete tool
and updates the help files for notices and marc export.

To test:

* Visit tools > batch record deletion
* confirm help is right
* Visit tools > Notices & Slips
* confirm help is right
* Visit tools > export marc
* cofirm the help is right

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:39:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:39:27 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-wEFYcWjV4v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #121 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment: 

The new code looks quite good to me. I have some minor comments as to design
issues (no blockers).
My only concerns about code concentrate on changes to marc_mod_templates. Since
this report actually is a new interface on top of those rules, I would not
oppose pushing it without the patches changing marc_mod_templates. 
If we want to push it with those changes (last two now), I think we should
first make some corrections (see below). It is still somewhat unfinished now.
Aside from that, I would also suggest changes to marc mod templates to prevent
unneeded record saving (with ModBiblio).
And aside from that, I would love to see additional code for indicators in
Koha/SimpleMarc.pm (containing the actual routines for the record updates). 

My conclusion: I am setting the status back to Passed QA to pass the ball to
Tomas. If you also feel that we should wait for an improvement of the last two
patches, please set to FQA. Or push without those two?

=== Details:

tools/batch_record_modification.pl: Design may still need some work (no
blocker). E.g. label before the selected marc mod template (position&length,
color).
Typing an empty line in the biblio number field gives the warning: This
biblionumber does not exist in the database. (I would personally ignore the
whitespace, not warn here).
In the selected biblio number table you have Preview MARC. Just a style issue
again: It made me wonder if we had two links there. But it is only one. Note
that your column title is already Preview. In line with Cataloging Search,
please remove the Preview string in the table and just keep MARC.

About Preview: It was not clear to me at first sight that this preview would
show a modified record. I interpreted this view as a way to check the record
just before updating it. But it actually is a way to test the result of the
rule. If you have another name that makes this intuitively more clear, you are
welcome :)

The results list every biblio number successfully modified. This list could be
very long. Since I gave Koha the biblio numbers (in a file or via text box), I
would be more interested in the numbers where an error came up. At the same
time not all "successfully modified" records have actually been modified. Which
ones were really changed? That may however be considered outside the scope of
this report and would need some code adjustments in
MarcModificationTemplates.pm to make the copy/edit/delete routines return some
meaningful value. In that case it would not be necessary in this code to always
run ModBiblio (with less [theoretical] risks to hurt data that you did not want
to change in the first place)..

*** Bug-11395-Raise-an-alert-if-control-field
This patch deals with changes in marc mod templates itself. Note that I can
still add a rule like:
Update field 001$a with value XX (But 001 has no subfields.) 
Delete field 001$b 
When moving 022$a to 001, I still have the warning: Both subfields should be
filled or empty.
Add field 001 value XX: Not allowed, needs subfield !! 001 has not subfields.
etc.
When you allow rules like this, you can easily generate errors like:
The biblio 1 has not been modified. An error occurred on modifying it. (The
error was: Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl5/MARC/Field.pm line 453. , see the Koha logfile for more
information)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:45:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:45:51 +0000
Subject: [Koha-bugs] [Bug 13772] koha-translate still looks for ccsr and
	prog OPAC themes
In-Reply-To: <bug-13772-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13772-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13772-70-nMhyedpbJ7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13772

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Magnus Enger <magnus at enger.priv.no> ---
Hm, the warnings can not be reproduced on different systems. They might be
caused by weirdnessess in my setup. Marking as "resolved invalid".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:50:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:50:21 +0000
Subject: [Koha-bugs] [Bug 13774] Add the unique anchors of news as links in
 the RSS for news in Opac
In-Reply-To: <bug-13774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13774-70-dzUPboY5Fk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774

Viktor Sarge <viktor.sarge at regionhalland.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:50:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:50:30 +0000
Subject: [Koha-bugs] [Bug 13774] Add the unique anchors of news as links in
 the RSS for news in Opac
In-Reply-To: <bug-13774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13774-70-LaXVTsdbag@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774

--- Comment #1 from Viktor Sarge <viktor.sarge at regionhalland.se> ---
Created attachment 36306
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36306&action=edit
Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac

This patch adds the unique anchors of bugs from bug13729 into the rss stream of
the news in opac from bug7843.
Since 7843 is already passed QA and I'm new to Git and mess things up I chose
to post this update in a separate patch even if it's a tiny change.

The addition of a unique guid tag both help users and keeps validators happy.

Test plan:
* Make sure you are on master in order to get the anchors from bug 13729 (or
you could apply it manually).
* Apply bug 7843
* Apply this patch.
* Make shure you have enough news to make the Opac main page scroll.
* Find the RSS link at the bottom om opac main and klick it.
* Verify that the link displayed for each newsitem takes you to the right
anchor.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:52:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:52:40 +0000
Subject: [Koha-bugs] [Bug 13774] Add the unique anchors of news as links in
 the RSS for news in Opac
In-Reply-To: <bug-13774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13774-70-jG7L8vpe78@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774

Viktor Sarge <viktor.sarge at regionhalland.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7843

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 14:52:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 13:52:40 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-LVR0RJfHZ1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Viktor Sarge <viktor.sarge at regionhalland.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13774

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:04:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:04:32 +0000
Subject: [Koha-bugs] [Bug 13777] New: patron lists not showing on patron
	search results
Message-ID: <bug-13777-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13777

            Bug ID: 13777
           Summary: patron lists not showing on patron search results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 36307
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36307&action=edit
no lists

I have 2 patron lists and neither shows on the list of patron results.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:04:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:04:52 +0000
Subject: [Koha-bugs] [Bug 13777] patron lists not showing on patron search
	results
In-Reply-To: <bug-13777-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13777-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13777-70-hmL5xLATFM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13777

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36308
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36308&action=edit
lists exist

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:05:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:05:42 +0000
Subject: [Koha-bugs] [Bug 13778] New: lists buttons ugly
Message-ID: <bug-13778-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778

            Bug ID: 13778
           Summary: lists buttons ugly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 36309
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36309&action=edit
patron lists buttons

The lists buttons are wrapping in some cases when there is plenty of room for
them to show - makes them ugly looking.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:08:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:08:33 +0000
Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for
 checking in items that are not checked out
In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13411-70-eRQlW27J9m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36310
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36310&action=edit
Bug 13411 [QA Followup] - Add logging

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:09:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:09:34 +0000
Subject: [Koha-bugs] [Bug 13778] lists buttons ugly
In-Reply-To: <bug-13778-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13778-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13778-70-aBErnOXOQb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Maybe the button actions could be moved into a single pop-up menu like we did
with reports.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:12:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:12:57 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
 patron deletion tool
In-Reply-To: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10612-70-LnFAqFaEVl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36311
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36311&action=edit
[SIGNED-OFF] Bug 10612 [Code cleanup] - Rename some variables

To move towards a more consistent codebase, I have changed some
variables from being camelCased or onelongname to the more standard
convention of words_separated_with_underscores. In addition, this
changes the use of the word 'member' to the word 'patron' to move
towards unification of our terminology. Our internal terminology should
move towards matching our external terminology ( members, borrowers =>
patrons, reserves => holds, etc ).

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:13:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:13:37 +0000
Subject: [Koha-bugs] [Bug 13739] KohaDates should display hours if they
 exists by default unless specified
In-Reply-To: <bug-13739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13739-70-VYQ0C7PD55@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:13:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:13:39 +0000
Subject: [Koha-bugs] [Bug 13739] KohaDates should display hours if they
 exists by default unless specified
In-Reply-To: <bug-13739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13739-70-XOYFARydpw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36095|0                           |1
        is obsolete|                            |

--- Comment #2 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 36312
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36312&action=edit
Bug 13739 - KohaDates should display hours if they exists by default unless
specified

There are many parts of Koha that are now hiding hours by default. This
is rarely helpful. KohaDates should display hours by default unless the
time is 23:59, in which case the hours should be not be displayed.

Test Plan:
1) Check out two items, one due at at an hour, one not
2) View the patron's circ history, note you don't see the hours
3) Apply this patch
4) View the circ history again, note the hours are listed for date/time
   where the time is not 23:59.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:15:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:15:34 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
 patron deletion tool
In-Reply-To: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10612-70-rjsVn67x3y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:15:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:15:40 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
 patron deletion tool
In-Reply-To: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10612-70-1n0hwtBeeV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28779|0                           |1
        is obsolete|                            |
  Attachment #28780|0                           |1
        is obsolete|                            |
  Attachment #36311|0                           |1
        is obsolete|                            |

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36313
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36313&action=edit
[SIGNED-OFF] Bug 10612 - Add ability to delete patrons with batch patron
deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:16:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:16:11 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
 patron deletion tool
In-Reply-To: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10612-70-VUlhiunkPY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36314
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36314&action=edit
[SIGNED-OFF] Bug 10612 [Code cleanup] - Rename some variables

To move towards a more consistent codebase, I have changed some
variables from being camelCased or onelongname to the more standard
convention of words_separated_with_underscores. In addition, this
changes the use of the word 'member' to the word 'patron' to move
towards unification of our terminology. Our internal terminology should
move towards matching our external terminology ( members, borrowers =>
patrons, reserves => holds, etc ).

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:17:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:17:31 +0000
Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create
 duplicate fields in biblio
In-Reply-To: <bug-13760-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13760-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13760-70-dcGKhdojCL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Fridolin SOMERS from comment #1)
> Note that this patch changes the minium of code in order to rebase it
> easyly. A followup will do the code formatting.

I do not think that this is the recommended approach.
If you put some part of the code in an if-statement, you need to indent.

Note that part of the same code still contains tabs too..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:17:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:17:34 +0000
Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch
 patron deletion tool
In-Reply-To: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10612-70-DVjYDEbR7H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36314|0                           |1
        is obsolete|                            |

--- Comment #32 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36315
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36315&action=edit
[SIGNED-OFF] Bug 10612 [Code cleanup] - Rename some variables

To move towards a more consistent codebase, I have changed some
variables from being camelCased or onelongname to the more standard
convention of words_separated_with_underscores. In addition, this
changes the use of the word 'member' to the word 'patron' to move
towards unification of our terminology. Our internal terminology should
move towards matching our external terminology ( members, borrowers =>
patrons, reserves => holds, etc ).

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:22:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:22:58 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-up6wWXWZsh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34906|0                           |1
        is obsolete|                            |

--- Comment #4 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36316
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36316&action=edit
Bug 13507: Add intranet support for CAS authentication

This patch allows to use CAS authentication for intranet login.

 It works exactly the same as the OPAC login, except that the
 staffClientBaseURL syspref must be set for intranet login
 (like OPACBaseURL must be set for OPAC login).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:23:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:23:10 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-sElym8PPrk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34907|0                           |1
        is obsolete|                            |

--- Comment #5 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36317
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36317&action=edit
Bug 13507 [Follow-up] : Add unit test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:30:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:30:52 +0000
Subject: [Koha-bugs] [Bug 12769] Notice fee management
In-Reply-To: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12769-70-ZTMxcsTfKW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34335|0                           |1
        is obsolete|                            |

--- Comment #5 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 36318
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36318&action=edit
Bug 12769 - Notice fee management

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:32:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:32:24 +0000
Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons
In-Reply-To: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11900-70-1nOzFWOARx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com
             Status|Signed Off                  |Failed QA

--- Comment #6 from Jesse Maseto <jesse at bywatersolutions.com> ---
After the patch was applied to master, the "tooltip"icon did not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:39:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:39:39 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-fAkFJEQYdg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> ---
 FAIL    C4/Koha.pm
   OK      critic
   OK      forbidden patterns
   OK      pod
   FAIL      valid


 FAIL    admin/authorised_values.pl
   OK      critic
   OK      forbidden patterns
   OK      pod
   FAIL      valid


 FAIL    admin/itemtypes.pl
   OK      critic
   OK      forbidden patterns
   OK      pod
   FAIL      valid


 OK    installer/data/mysql/updatedatabase.pl
   OK      critic
   OK      forbidden patterns
   OK      pod
   OK      valid

 FAIL    opac/opac-search.pl
   OK      critic
   OK      forbidden patterns
   OK      pod
   FAIL      valid


 FAIL    t/db_dependent/Koha.t
   OK      critic
   OK      forbidden patterns
   OK      pod
   FAIL      valid

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:44:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:44:16 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-V0sv9LSpcY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |nengard at gmail.com

--- Comment #5 from Nicole C. Engard <nengard at gmail.com> ---
While the code works, this is a problem for many libraries. I think this should
be an on/off switch on the patron category administration page. That way some
categories can have it and others won't.  If it's there for all patrons it will
be requested that we hide it for all but children and that can't be done
easily.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:46:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:46:13 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-tz37F3tvvY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36305|BUG 13771: Update Tools     |[SIGNED-OFF] BUG 13771:
        description|Help Files for 3.18         |Update Tools Help Files for
                   |                            |3.18

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:47:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:47:48 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-3EXrW96YlB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Signed Off                  |In Discussion

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Would it not make much more sense to simply have a new `biblio` table field
`force_item_level_holds` rather than creating a completely new table with only
a single column?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:47:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:47:54 +0000
Subject: [Koha-bugs] [Bug 12769] Notice fee management
In-Reply-To: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12769-70-RNUqgVvp24@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

--- Comment #6 from Charles Farmer <charles.farmer at inlibro.com> ---
(In reply to Charles Farmer from comment #5)
> Created attachment 36318 [details] [review]
> Bug 12769 - Notice fee management

This last patch was solely made to solve merge-conflicts in updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:55:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:55:07 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-1PSS2WFHRY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #5 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 36319
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36319&action=edit
[SIGNED OFF] BUG 13771: Update Tools Help Files for 3.18

This patch creates a helpf ile for the batch record delete tool
and updates the help files for notices and marc export.

To test:

* Visit tools > batch record deletion
* confirm help is right
* Visit tools > Notices & Slips
* confirm help is right
* Visit tools > export marc
* cofirm the help is right

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 15:59:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 14:59:37 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-9QdzqcX5Hy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #619 from Kyle M Hall <kyle at bywatersolutions.com> ---
I must disagree. This work closely resembles the original RFC some table and
column name changes, as well as a few additions.

I've spend countless hours to track this feature against master. Nothing has
moved on. It has simply been a lack of persons willing to test and qa this
feature that has been the problem so far.

(In reply to Martin Renvoize from comment #618)
> Further to the above, when I attempted to lookup the original RFC for this,
> it does not remotely resemble the actually work, further confusing testing.
> 
> Please don't see this as completely negative.. I just feel things have moved
> on allot since this patch was written.. and that the way in which it has
> been posted as one massive bug is unmanageable for both testers and qa team.
> 
> I have a alternative schema I'd love to post as a counter patch.. but that
> all depends upon having a moment to get to it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:00:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:00:50 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-n1Wa93cus4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

Koha Team AMU <koha.aixmarseille at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha.aixmarseille at gmail.com

--- Comment #7 from Koha Team AMU <koha.aixmarseille at gmail.com> ---
I try on a sandbox :
Updatedatabase:
Upgrade to 3.19.00.000 done (there's life after 3.18)\nUpgrade to 3.19.00.001
done (Bug 13436: Add more options to UsageStatsLibraryType)\nupgrade to
3.19.00.002 done (Bug 10753: replace __ANY__ with empty string in
suggestions.branchcode)\nUpgrade to 3.19.00.003 done (Bug 1861 - Unique patrons
logins not (totally) enforced)\nUpgrade to 3.19.00.004 done (Bug 13346:
OpacExportOptions is now multiple)\nUpgrade to 3.19.00.005 done (Bug 13379 -
Modify authorised_values.category to varchar(32))\nUpgrade to 3.19.00.006 done
(Bug 11944 - Convert DB tables to utf8_unicode_ci)\nUpgrade to 3.19.00.007 done
(Bug 12905: Check budget integrity: OK)\nUpgrade to 3.19.00.008 done (Bug 12601
- Add new foreign key aqorders.budget_id WARNING: temporary budget and fund
have been created (search for "BACKUP_TMP"). At least one of your order was not
linked to a budget)\nUpgrade to 3.19.00.009 done (Bug 13007 - Add new foreign
key suggestions.budgetid)\nUpgrade to 3.19.00.010 done (Bug 5511 -
SessionRestrictionByIP)\nUpgrade to 3.19.00.011 done (Bug 13417: Add permission
to delete public lists)\nUpgrade to 3.19.00.012 done (Bug 13523 - Remove NOT
NULL restriction on field marcxml due to mysql STRICT_TRANS_TABLES)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:01:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:01:45 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-EOWdyip4si@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #6 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 36320
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36320&action=edit
[SIGNED OFF] Bug 13771: Main Page Help fro 3.18

This updates the main page help file for 3.18.

To test:
* Log in to staff cleint
* Click help on the mian page
* Review help file

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:02:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:02:16 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-6DA4d4sLJk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36268|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:02:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:02:48 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-rld1sPsoHm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36305|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:03:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:03:54 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-PwwtIh3FdO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36316|0                           |1
        is obsolete|                            |

--- Comment #6 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36321
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36321&action=edit
Bug 13507: Add intranet support for CAS authentication

This patch allows to use CAS authentication for intranet login.

 It works exactly the same as the OPAC login, except that the
 staffClientBaseURL syspref must be set for intranet login
 (like OPACBaseURL must be set for OPAC login).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:06:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:06:01 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-GLdRjHWRAR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #620 from Nicole C. Engard <nengard at gmail.com> ---
I'd like to add that 2 libraries are using it in production and have given
their sign off to the features. They are not having issues with anything - and
since we're talking money related issues you'd expect a lot of screaming if
there were issues.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:12:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:12:06 +0000
Subject: [Koha-bugs] [Bug 13739] KohaDates should display hours if they
 exists by default unless specified
In-Reply-To: <bug-13739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13739-70-vuFFWAxPsl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739

--- Comment #3 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 36322
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36322&action=edit
[SIGNED OFF] Bug 13739 - KohaDates should display hours if they exists by
default unless specified

There are many parts of Koha that are now hiding hours by default. This
is rarely helpful. KohaDates should display hours by default unless the
time is 23:59, in which case the hours should be not be displayed.

Test Plan:
1) Check out two items, one due at at an hour, one not
2) View the patron's circ history, note you don't see the hours
3) Apply this patch
4) View the circ history again, note the hours are listed for date/time
   where the time is not 23:59.

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:12:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:12:31 +0000
Subject: [Koha-bugs] [Bug 13739] KohaDates should display hours if they
 exists by default unless specified
In-Reply-To: <bug-13739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13739-70-PAf9tJmPQP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com
  Attachment #36312|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:15:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:15:06 +0000
Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials
In-Reply-To: <bug-13662-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13662-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13662-70-vhKiRWleHI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:15:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:15:09 +0000
Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials
In-Reply-To: <bug-13662-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13662-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13662-70-ZK9USdABFT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662

--- Comment #6 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36323
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36323&action=edit
Bug 13662: Fix the serials.receive_serials permissions

There are some issues with serial permissions.
For instance it's not possible to receive serials if the
edit_subscription is not set.
Also the toolbar is empty.

Test plan:
1/ Set the serials => receive_serials permissions to a patron (and only
this one for the serials module).
2/ Verify you cannot create a new subscription, you can search
subscriptions but cannot edit them.
3/ On the serial result list, receive a serial (action > Serial
receive).
You can now change the status and receive it.
4/ On the serial collection, you can edit 1+ serials to reveice it.
5/ Set the serials => edit_subscription permission and confirm there is
no regression.

QA note: I think we should introduce a C4::Serials::can_receive_serials
subroutine, to test the IndependentBranches pref, but I don't want to
add to much processing to check permissions.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:22:06 +0000
Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode,
 categorytype from table overduerules_transport_types
In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13624-70-meIeixW3NT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Viktor Sarge <viktor.sarge at regionhalland.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor.sarge at regionhalland.
                   |                            |se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:22:21 +0000
Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement
In-Reply-To: <bug-12770-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12770-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12770-70-OTwoBDWhsH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770

Viktor Sarge <viktor.sarge at regionhalland.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor.sarge at regionhalland.
                   |                            |se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:22:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:22:34 +0000
Subject: [Koha-bugs] [Bug 12769] Notice fee management
In-Reply-To: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12769-70-hynVOMg55Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

Viktor Sarge <viktor.sarge at regionhalland.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor.sarge at regionhalland.
                   |                            |se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:27:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:27:03 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-okLMZ5RnF4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Sean McGarvey <smcgarvey at pascocountyfl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |smcgarvey at pascocountyfl.net

--- Comment #621 from Sean McGarvey <smcgarvey at pascocountyfl.net> ---
I think i can help out here, Pasco County Library system has been using this
patch in production for almost an entire year. We've tested pretty much every
way this upgrade works and have made a lot of improvements. We've even found
new and interesting ways to break things that no one but a patron could have
thought of. Just to confirm I even stepped out to talk to my head of finance
who agreed that the system is solid and is functioning as described. We've had
7 libraries using it 5 days a week. At this point human error is what is
causing the vast majority of our problems. When this is live in master we hope
that other libraries can help us make more tweaks.  

I can confirm that the system is tested and functioning. Had it not been our
county clerk would have made it perfectly clear. If there are individual
questions about aspects ill try and answer them as best i can regarding actual
function in the library.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:27:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:27:38 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-d9Nw4SlWNj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

Corinne Flacher-David <corinne.flacher-david at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |corinne.flacher-david at bibli
                   |                            |bre.com

--- Comment #1 from Corinne Flacher-David <corinne.flacher-david at biblibre.com> ---
I add on a test case about user logged out on refresh after CAS authentication
:

4) When you try to log in, again, you cannot log in to the Opac.
It's impossible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:28:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:28:02 +0000
Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in
	koha-indexer
In-Reply-To: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13753-70-9IMYCcHVrQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:29:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:29:22 +0000
Subject: [Koha-bugs] [Bug 13759] git-build-snapshot misses YUI and dies of
 sorrow during build
In-Reply-To: <bug-13759-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13759-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13759-70-TF3HaQNYYH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13759

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:30:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:30:15 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-UYFT7Qo696@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:30:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:30:56 +0000
Subject: [Koha-bugs] [Bug 13646] Facets encoding problem with GRS1
In-Reply-To: <bug-13646-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13646-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13646-70-exhS2wcAyO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Failed QA

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Testing this with Jonathan we located another problem with how the links are
build - switching this to "Failed QA" waiting for a follow up or new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:31:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:31:31 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-DOCnHDNwWx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

--- Comment #2 from Corinne Flacher-David <corinne.flacher-david at biblibre.com> ---
I add on a test case about user logged out on refresh after CAS
authentication :

4) When you try to log in, again, you cannot authenticate to the OPAC through
CAS. It's impossible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:42:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:42:32 +0000
Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable
In-Reply-To: <bug-13741-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13741-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13741-70-TpmxHkhtZE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:43:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:43:23 +0000
Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and
 use CT for return branch
In-Reply-To: <bug-12021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12021-70-P4zxEoN2LS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021

--- Comment #7 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
I think there may be an error in the logic behind this patch. It includes a
testplan that starts with switching off automaticitemreturn, but if you have it
set on you want these fields set so that self checks place returns in correct
reshelving bins

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:43:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:43:36 +0000
Subject: [Koha-bugs] [Bug 13745] Serial collection page shows branchcode
 instead of branchname
In-Reply-To: <bug-13745-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13745-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13745-70-btig2ms7iN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13745

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:44:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:44:11 +0000
Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save
In-Reply-To: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13731-70-3yaueviQ20@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:50:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:50:22 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-5liG0rYRYe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

fpichenot at ville-roubaix.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fpichenot at ville-roubaix.fr
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #4 from fpichenot at ville-roubaix.fr ---
In item's detail, I can write a message of a type defined in an authorised
value list, but I can't save it.

Second problem : the ability to add message doesn't appear in "edit items".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:50:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:50:39 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-ErqM8ai2tp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35196|0                           |1
        is obsolete|                            |
  Attachment #35197|0                           |1
        is obsolete|                            |
  Attachment #35198|0                           |1
        is obsolete|                            |
  Attachment #35199|0                           |1
        is obsolete|                            |
  Attachment #35200|0                           |1
        is obsolete|                            |
  Attachment #35201|0                           |1
        is obsolete|                            |
  Attachment #35202|0                           |1
        is obsolete|                            |
  Attachment #35203|0                           |1
        is obsolete|                            |
  Attachment #35204|0                           |1
        is obsolete|                            |
  Attachment #35205|0                           |1
        is obsolete|                            |
  Attachment #35206|0                           |1
        is obsolete|                            |
  Attachment #35207|0                           |1
        is obsolete|                            |
  Attachment #35208|0                           |1
        is obsolete|                            |
  Attachment #35302|0                           |1
        is obsolete|                            |

--- Comment #622 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36324
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36324&action=edit
Bug 6427 - Update database

This patch set re-engineers Koha's accounting system to be faster, more
stable, and have a better historical accounting of fees and payments
while also unifying much of the payment logic and simplifying the code
behind it.

Three new tables have been created:
account_debits stores fines and fees owed by the patron.

account_credits stores payments, write-offs, and other line items that
reduce the amount owed by a patron.

account_offsets stores data about changes to debits and credits,
including which credits paid which debits.

borrowers.account_balance stores the current balance of the
patron, so it does not have to be calculated each time it needs to be
displayed.

issues.issue_id has been added so that individual fines can be directly
linked to the issue that caused them without ambiguity.

The various accounting code strings ( F, FU, Rent, etc ), some of which
have little or no documentation have been replaced by what enumerated
data types which are documented via POD.
There are three, one for each of Debits ( fees/fines ), Credits ( payments ),
and Offsets.

The system continues to allow custom fee types ( moving MANUAL_INV to
MANUAL_DEBIT )
while additionally allowing custom payment types ( MANUAL_CREDIT ).

The system also allows for overpayment, the the outstanding credit being
applied to future fees as they are created.

The system also allows for a librarian to accept a different amount of
money than what is to be paid, and will calculate the change to be
given.

Test Plan:
1) Apply this patch
2) Create some manual fees
3) Test the fee payments
   * Pay one fee
   * Pay multiple fees
   * Make a partial payment
   * Write off a fee
4) View the fees/payments, verify they are correct
5) Check out some items as overdue that should have fines
6) Run fines.pl, verify fines were generated
7) Pay on an accruing fine
8) Run fines.pl again, verify the fine hasn't changed
9) Increase the daily fine in issuing rules
10) Run fines.pl again, verify the fine has increased
11) Decrease the daily fine in issuing rules
12) Run fines.pl again, verify the fine has decreased
13) Test dropbox mode
14) Test WhenLostChargeReplacementFee both ways
15) Test RefundLostItemFeeOnReturn both ways
16) Test WhenLostForgiveFine both ways
17) Test CalculateFinesOnReturn both ways

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:52:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:52:06 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-JM1bAodTe6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:52:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:52:11 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-Ujnr826WHe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #7 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36325
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36325&action=edit
Bug 13771: Update Circ Help File

This updates the main circulation help file with new features in 3.18.

To test:

* visit circulation page
* click help
* review text

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:52:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:52:42 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-21395hFjzC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #623 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36326
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36326&action=edit
Bug 6427 - Update schema files

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:53:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:53:05 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-ztr5yDvQeD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #624 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36327
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36327&action=edit
Bug 6427 - Add new Accounts related Koha modules

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:53:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:53:33 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-u9HeetNijB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #625 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36328
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36328&action=edit
Bug 6427 - Update existing Koha perl modules

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:53:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:53:41 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-1wXVsFQbfM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.sassmannshausen at ptfs-e
                   |                            |urope.com

--- Comment #16 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Hi Julian,

I've just tried to sign this one off using a sandbox, but there was a problem
applying the patch.

I think it may need to be rebased again?

I'll try again when you've had a look.

Cheers,

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:53:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:53:58 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-qV5Q5Bkj07@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #626 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36329
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36329&action=edit
Bug 6427 - Add new TT plugin to deal with currency

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:54:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:54:21 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-UeLLlFT8Gx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #627 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36330
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36330&action=edit
Bug 6427 - Add TableTools plugin for DataTables

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:54:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:54:30 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-raKzxsmSYq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:54:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:54:44 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-C9XFiBt3Vc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #628 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36331
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36331&action=edit
Bug 6427 - Add new staff scripts for managing accounts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:55:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:55:26 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-LnRZCaT3bP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #629 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36332
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36332&action=edit
Bug 6427 - Update existing intranet scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:56:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:56:12 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-ajMh2Tg8fM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #630 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36333
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36333&action=edit
Bug 6427 - Update OPAC scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:56:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:56:32 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-rWRIPEO9Uy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #631 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36334
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36334&action=edit
Bug 6427 - Add & update cron scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:56:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:56:38 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-PySptMIv9f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Koha Team AMU from comment #7)
> I try on a sandbox :

And, what is the problem?
Is not an error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:57:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:57:36 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-M7X8Jv1Xoe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #632 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36335
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36335&action=edit
Bug 6427 - Delete unused and unnecessary files

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:58:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:58:10 +0000
Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle
 don't consider hold policy by item type
In-Reply-To: <bug-13687-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13687-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13687-70-KImoG7W5SJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:58:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:58:13 +0000
Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle
 don't consider hold policy by item type
In-Reply-To: <bug-13687-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13687-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13687-70-esIO1yaLWT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36014|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36336
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36336&action=edit
[PASSED QA] Bug 13687: Move hold policy check into CanItemBeReserved

This way ILS-DI HoldItem and HoldTitle services also benefit from this
check

Test plan:

1/ Define some default holds policies by item type in
/admin/smart-rules.pl
2/ Use ILS-DI HoldItem service and check that those rules are respected
3/ Check that staff and opac hold behaviour is unchanged regarding
these rules.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes tests and QA script. No regressions found,
improves the ILS-DI HoldItem response.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:58:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:58:47 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-9vnW6dPqIw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #633 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36337
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36337&action=edit
Bug 6427 - Unit Tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:59:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:59:23 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-n3wN48eSgo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #634 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36338
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36338&action=edit
Bug 6427 - Make fines tabs link to account payment page

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 16:59:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 15:59:27 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-bRhfHvsjOH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36321|0                           |1
        is obsolete|                            |

--- Comment #7 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36339
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36339&action=edit
Bug 13507: Add intranet support for CAS authentication

This patch allows to use CAS authentication for intranet login.

 It works exactly the same as the OPAC login, except that the
 staffClientBaseURL syspref must be set for intranet login
 (like OPACBaseURL must be set for OPAC login).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:00:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:00:05 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-2Aa1NLr1E8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #635 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36340
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36340&action=edit
Bug 6427 [QA Followup] - Improvements to OPAC view

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:03:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:03:36 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-bmEgFAyfZ5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36339|0                           |1
        is obsolete|                            |

--- Comment #8 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36341
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36341&action=edit
Bug 13507: Add intranet support for CAS authentication

This patch allows to use CAS authentication for intranet login.

 It works exactly the same as the OPAC login, except that the
 staffClientBaseURL syspref must be set for intranet login
 (like OPACBaseURL must be set for OPAC login).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:07:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:07:57 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-sXz0C0scis@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:08:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:08:01 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-8kvhJL9vey@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36047|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36342
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36342&action=edit
Bug 13733 - Give librarians the ability to add messages to an item

Some librarians would like the ability to leave messages attached to an
item ( outside the scope of itemnotes and itemnotes_nonpublic ). This
feature would give the librarians the ability to add and remove messages
of arbitrary types defined in an authorised value list.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Create some ITEM_MESSAGE authorised values
4) View an item's details
5) Try adding and deleting messages on an item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:08:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:08:23 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-CZurqtiG6e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
I believe the problem was in the database update. Please retest!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:11:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:11:14 +0000
Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions
In-Reply-To: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13392-70-KtezxbfnUI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #22 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:11:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:11:31 +0000
Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions
In-Reply-To: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13392-70-UQlDb8zSLo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36188|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:11:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:11:36 +0000
Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions
In-Reply-To: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13392-70-iN2TbPZeAP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36189|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:11:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:11:41 +0000
Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions
In-Reply-To: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13392-70-27BlbPLgKd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36190|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:11:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:11:51 +0000
Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions
In-Reply-To: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13392-70-oF689B7cpy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392

--- Comment #23 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36343
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36343&action=edit
Bug 13392: Add suggestions.ordereddate and suggestions.orderedby

Those fields are updated when suggestion status is changed to 'ORDERED'
and are displayed on suggestion/suggestion.pl page

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:11:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:11:54 +0000
Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions
In-Reply-To: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13392-70-gUi8V6VnkY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392

--- Comment #24 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36344
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36344&action=edit
Bug 13392: New statistics assistant for suggestions

New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests)

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:11:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:11:58 +0000
Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions
In-Reply-To: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13392-70-nYVnLnhXZ0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392

--- Comment #25 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36345
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36345&action=edit
Bug 13392: QA fixes

1/ Add tests descriptions
2/ Do not use Koha::I18N for suggestion statuses, and add statuses from
SUGGEST_STATUS authorised values
3/ Use copyrightdate instead of publicationyear which seems to be unused
4/ Display free text filters if there is no values in corresponding
authorised values list
5/ Rename 'Branch' to 'Library' and 'Reject reason' to 'Reason'

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:13:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:13:32 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-q72UlO2ZgX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36342|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36346
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36346&action=edit
Bug 13733 - Give librarians the ability to add messages to an item

Some librarians would like the ability to leave messages attached to an
item ( outside the scope of itemnotes and itemnotes_nonpublic ). This
feature would give the librarians the ability to add and remove messages
of arbitrary types defined in an authorised value list.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Create some ITEM_MESSAGE authorised values
4) View an item's details
5) Try adding and deleting messages on an item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:17:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:17:02 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-EaHD0Azubs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36113|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:21:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:21:51 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-IrCbh7SS1d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36347
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36347&action=edit
Bug 13744: Fix datatables paging on 'Holds to pull' report

The paging of the datatables on the 'holds to pull' report
page is broken without this patch.

To test:
- Make sure that some holds are placed on available items
  in your installation
- Go to the circulation start page
- Open the 'holds to pull' report
- Verify that the patch fixes the paging on the result table

Also: Fixes "None" in the filter pull downs to be translatable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:22:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:22:31 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-VguiCXHBCd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:37:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:37:08 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-KFXoP2JXNA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

fpichenot at ville-roubaix.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from fpichenot at ville-roubaix.fr ---
Ok, it works.

But I think it would be better if the message also appears in the "normal"
view.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:42:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:42:13 +0000
Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions
In-Reply-To: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13392-70-7DtkCMLTdD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392

Courret <scourret at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |scourret at gmail.com
             Status|Signed Off                  |Needs Signoff

--- Comment #26 from Courret <scourret at gmail.com> ---
The suggest date wizard works good. 

But it seems that Koha reports some suggestions that were rejected, even if
these suggestions do not appear in the staff interface.  

Some rejected suggestions that were refused for a lack of budget in the pro
interface do not appear later in the wizard report. 

Similar issue of inconsistency of results for pending suggestions : 9 reported
in the wizard while 19 appear in Koha pro interface. 

Unfortunately, we miss a running phpmyadmin interface to check the real content
of the database.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:45:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:45:14 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-lcnH1QUFjO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com
             Status|Needs Signoff               |Signed Off

--- Comment #9 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Koha Team AMU <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:45:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:45:29 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-LnatCK5rKU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36317|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:45:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:45:34 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-dnYChsuhVh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36341|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:45:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:45:41 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-7fmC8veazG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

--- Comment #10 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36348
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36348&action=edit
Bug 13507 [Follow-up] : Add unit test.

Signed-off-by: Koha Team AMU <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 17:45:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 16:45:44 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-aGS6ndpCLY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

--- Comment #11 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36349
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36349&action=edit
Bug 13507: Add intranet support for CAS authentication

 This patch allows to use CAS authentication for intranet login.

 It works exactly the same as the OPAC login, except that the
 staffClientBaseURL syspref must be set for intranet login
 (like OPACBaseURL must be set for OPAC login).

Signed-off-by: Koha Team AMU <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 18:55:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 17:55:32 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-sPEuS3Uqno@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #636 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to Kyle M Hall from comment #619)
> I must disagree. This work closely resembles the original RFC some table and
> column name changes, as well as a few additions.
> 
> I've spend countless hours to track this feature against master. Nothing has
> moved on. It has simply been a lack of persons willing to test and qa this
> feature that has been the problem so far.
> 
Hmmm, Martin and others have spent hours trying to QA this. They found
problems, they reported them in the spreadsheet. Have you read through the
spreadsheet?
Or the comment proceeding the one you replied to?

I find it quite insulting you just dismiss their findings, and blame them
instead.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 20:03:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 19:03:22 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-g2YOsWh1kj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34333|0                           |1
        is obsolete|                            |

--- Comment #5 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 36350
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36350&action=edit
Bug 12768 - Replacement cost and processing fee management

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 20:07:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 19:07:52 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-2DxgeG07pX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Sherry Sakovich <ssakovich at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ssakovich at hmcpl.org

--- Comment #637 from Sherry Sakovich <ssakovich at hmcpl.org> ---
Here at Huntsville-Madison County Public Library, we've been using the accounts
re-write in production since we went live on Koha a year ago.  We absolutely
love the granularity this feature allows for payment types and reporting.  As a
public library, our city/county auditors strictly require this type of detailed
information.  Also, as a 12 branch county-wide library system, we're able to
make better decisions as we now have better accounting.  Finally, our patrons
really appreciate that our system tracks what they've paid for and by what
method.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 20:09:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 19:09:12 +0000
Subject: [Koha-bugs] [Bug 12769] Notice fee management
In-Reply-To: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12769-70-NIjuXZOZb8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36318|0                           |1
        is obsolete|                            |

--- Comment #7 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 36351
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36351&action=edit
Bug 12769 - Notice fee management

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 20:37:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 19:37:07 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-Tgp3YjnRC4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Aaron Sakovich <asakovich at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |asakovich at hmcpl.org

--- Comment #638 from Aaron Sakovich <asakovich at hmcpl.org> ---
As Sherry said, we at HMCPL have been using this code in production for a whole
year. We have tested this exhaustively, on both 3.14 and 3.16, during that
period. And by "we", I mean a 12 branch library system open 7 days a week, with
well over 2 million items circulated in that time, exclusively using this code.
The current code base is functioning nominally, and even relatively gracefully
handled the upgrade from 3.14 to 3.16, as well as multiple patches since.
We've no outstanding bugs logged against this current version of the code on
our internal nor ByWater's ticketing systems. This current piece of kit is rock
solid and well tested; it is well beyond the beta stage that we started with a
year ago, and I humbly suggest that it is suitably ready for production.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 21:53:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 20:53:20 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-3tpAeOCnOH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

--- Comment #17 from Marc V?ron <veron at veron.ch> ---
Created attachment 36352
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36352&action=edit
Bug 4041 - Third step - Display address on patron's pages using the system
preference

This patch displays the address information in the left column of the patron's
pages using the new system preference.
The address is formatted in member-display-address-style-us.inc and
member-display-address-style-de.inc

To test:
- Apply patch on top of 1st and 2nd patch
- Select 'German style' in system preference 'addressformat' in I18N/L10N
- Verify that the address information displays properly in the left column of
all patron's pages.
- Verify that the address displays properly in the main area of moremember.pl
as well (Note: In right column, Alternate address /contact are not yet
touched))
- Switch system preference to US style, repeat checks

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 21:54:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 20:54:10 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-abWl6TkgDi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 22:16:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 21:16:28 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-ytGoNW5GeL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36352|0                           |1
        is obsolete|                            |

--- Comment #18 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36353
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36353&action=edit
Bug 4041 - Third step - Display address on patron's pages using the system
preference

This patch displays the address information in the left column of the patron's
pages using the new system preference.
The address is formatted in member-display-address-style-us.inc and
member-display-address-style-de.inc

To test:
- Apply patch on top of 1st and 2nd patch
- Select 'German style' in system preference 'addressformat' in I18N/L10N
- Verify that the address information displays properly in the left column of
all patron's pages.
- Verify that the address displays properly in the main area of moremember.pl
as well (Note: In right column, Alternate address /contact are not yet
touched))
- Switch system preference to US style, repeat checks

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 22:16:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 21:16:45 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-mkmSNY8HUo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 22:30:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 21:30:44 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-w41LxWWhxA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #639 from Brendan Gallagher <brendan at bywatersolutions.com> ---
(In reply to Chris Cormack from comment #636)
> (In reply to Kyle M Hall from comment #619)
> > I must disagree. This work closely resembles the original RFC some table and
> > column name changes, as well as a few additions.
> > 
> > I've spend countless hours to track this feature against master. Nothing has
> > moved on. It has simply been a lack of persons willing to test and qa this
> > feature that has been the problem so far.
> > 
> Hmmm, Martin and others have spent hours trying to QA this. They found
> problems, they reported them in the spreadsheet. Have you read through the
> spreadsheet?
> Or the comment proceeding the one you replied to?
> 
> I find it quite insulting you just dismiss their findings, and blame them
> instead.

Hi All - 

Please let's not read any tone into any message.  We are all friends here and
we speak many different languages - I am at fault for using the wrong word with
Katrin (someone that I would go to battle for and have the most respect for).  

So that being said.  I think Kyle needs to know how to work with this "BIG
IDEA" of the accounts rewrite and work with everyone - from the most
experienced (Tomas and Jonathan) to the most experienced me (Brendan).  

It may take 10 times of telling us to change certain things - but we are more
than will to work with anyone of you all - to make those changes.  Tempers fly
- and I say that is lost in translation.  

ok - how to change this.   Well we are going to sit down with Katrin, Tomas,
Jonathan, and hopefully Martin (on google hangouts), and talk about what needs
to be changed and how to submit the patches so that it works for everyone.  

Please remember that all of us - LOVE LOVE LOVE to be part of this community -
and all we ever want is to be part of this community.  many things are lost in
translation - if you need proof - just ask Paul about baseball.  

Seriously - all we want is to show that we've got so good code and we totally
realize that we need tons of help to get it in.

Tons of Respect,
Brendan Gallagher

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 22:32:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 21:32:42 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-N7z3BBViVq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #640 from Brendan Gallagher <brendan at bywatersolutions.com> ---
(In reply to Brendan Gallagher from comment #639)
> (In reply to Chris Cormack from comment #636)
> > (In reply to Kyle M Hall from comment #619)
> > > I must disagree. This work closely resembles the original RFC some table and
> > > column name changes, as well as a few additions.
> > > 
> > > I've spend countless hours to track this feature against master. Nothing has
> > > moved on. It has simply been a lack of persons willing to test and qa this
> > > feature that has been the problem so far.
> > > 
> > Hmmm, Martin and others have spent hours trying to QA this. They found
> > problems, they reported them in the spreadsheet. Have you read through the
> > spreadsheet?
> > Or the comment proceeding the one you replied to?
> > 
> > I find it quite insulting you just dismiss their findings, and blame them
> > instead.
> 
> Hi All - 
> 
> Please let's not read any tone into any message.  We are all friends here
> and we speak many different languages - I am at fault for using the wrong
> word with Katrin (someone that I would go to battle for and have the most
> respect for).  
That should be the most INexperienced me (bag)  darn typos 

> 
> So that being said.  I think Kyle needs to know how to work with this "BIG
> IDEA" of the accounts rewrite and work with everyone - from the most
> experienced (Tomas and Jonathan) to the most experienced me (Brendan).  
> 
> It may take 10 times of telling us to change certain things - but we are
> more than will to work with anyone of you all - to make those changes. 
> Tempers fly - and I say that is lost in translation.  
> 
> ok - how to change this.   Well we are going to sit down with Katrin, Tomas,
> Jonathan, and hopefully Martin (on google hangouts), and talk about what
> needs to be changed and how to submit the patches so that it works for
> everyone.  
> 
> Please remember that all of us - LOVE LOVE LOVE to be part of this community
> - and all we ever want is to be part of this community.  many things are
> lost in translation - if you need proof - just ask Paul about baseball.  
> 
> Seriously - all we want is to show that we've got so good code and we
> totally realize that we need tons of help to get it in.
> 
> Tons of Respect,
> Brendan Gallagher

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  2 23:59:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 22:59:07 +0000
Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons
In-Reply-To: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11900-70-FUHzwKHnvm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Hi Jesse,

I tested again with 

IE 11, Firefox 35 and Chrome 40 on Windows 7
IE 11 and Firefox 36 on Windows 8.1
Iceweasel 24.7 on Debian 

All of them display the tooltips on the "Cart" and "List"-links on top of the
OPAC page.

Can you please re-test? - Please select "English" to test. Maybe you have to
clear the caches.

Thanks
Marc

Switching back to "Needs Signoff"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 00:18:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 23:18:41 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-8hcbCVAqcA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #641 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #616)
> I don't see how this got to a signed off state, a large part of the testing
> spreadsheet recording test results shows half of it is untested.

The signer was an independent tester.

> I know when I tested it, I found all sorts of issues with display on the
> staff client.

Please let me know what those issue are!

> I also found issues with the code when delving into it to try and fix said
> bugs, I'd love to see a good comprehensive re-write of accounts, but this
> code shows that it was written some time ago and I don't believe it actually
> improved matters.

Again, pleases let me know what these bugs are!

I believe that this feature improves matters very much. The partners that have
been testing this have been able to do far more advanced reporting on fees and
payments than is possible with our current schema. I don't see how it *doesn't*
improve matters!

> 
> PTFS Europe spent a fair chunk of time attempting to get this in shape for
> passing through community so we could base our Cash Management work upon it,
> but we didn't even complete testing before we realised how difficult it
> would be to extend/enhance it further.

I can understand that you want to add a new feature to Koha, and this feature
is making it more difficult for you. I've been in the same situation. However,
I don't think that's reasonable justification for tossing it out.

If you can outline what parts of this are limiting for you, and how I can help
resolve this, I would be more than happy to! Have you posted an RFC for your
Cash Management feature?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 00:50:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 23:50:15 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-LAXK3gcEPI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29595|0                           |1
        is obsolete|                            |
  Attachment #30015|0                           |1
        is obsolete|                            |

--- Comment #20 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36354
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36354&action=edit
Bug 10988 - Allow login via Google OAuth2

This is my rework of a patch by Nicholas van Oudtshoorn.
Fixed the patch so that it again cleanly applies.

Adds googleoauth2 login to koha. Adds applicable system
preferences Modifies templates to support oauth2 login
failures changes the login links to use googleoauth2 when
oauth2 is enabled.

Test Plan:
 0) Back up your database
 1) Apply this patch
 2) In your mysql client use your Koha database and execute:
    > DELETE FROM systempreferences;
    > SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql;
    -- Should be no errors.
    > SELECT * FROM systempreferences LIKE 'GoogleOAuth%';
    -- Should see 4 entries.
    > QUIT;
 3) Restore your database
 4) Run ./installer/data/mysql/updatedatabase.pl;
 5) In your mysql client use your Koha database and execute:
    > SELECT * FROM systempreferences LIKE 'GoogleOAuth%';
    -- Should see the same 4 entries.
 6) Log into the staff client
 7) Home -> Koha administration -> Global system preferences
 8) -> Administration
    -- There should be a 'Google OAuth2' section with the ability
       to set those 4 system preferences.
 9) In a new tab, go to https://console.developers.google.com/project
10) Click 'Create Project'
11) Type in a project name that won't freak users out, like your
    library name (e.g. South Pole Library).
12) Click the 'Create' button.
13) Click the 'APIs & auth' in the left frame.
14) Click 'Credentials'
15) Click 'Create new Client ID'
16) Select 'Web application' and click 'Configure consent screen'.
17) Select the Email Address.
18) Put it a meaningful string into the Product Name
    (e.g. South Pole Library Authentication)
19) Fill in the other fields as desired (or not)
20) Click 'Save'
21) Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL.
    (http://library.yourDNS.org)
22) Change the 'AUTHORIZED REDIRECT URIS' to point to the new
    googleoauth2 script
    (http://library.yourDNS.org/cgi-bin/koha/svc/googleoauth2)
23) Click 'Create Client ID'
24) Copy and paste the 'CLIENT ID' into the GoogleOAuth2ClientID
    system preference.
25) Copy and paste the 'CLIENT SECRET' into the GoogleOAuth2ClientSecret
    system preference.
26) Change the GoogleOAuth2 preference to 'Use'.
27) Click 'Save all Administration preferences'
28) In the OPAC, click 'Log in to your account'.
    -- You should get a confirmation request, if you are
        already logged in, OR a login screen if you are not.
    -- You need to have the primary email address set to one
       authenticated by Google in order to log in.
29) Run koha qa test tools

I've obsoleted the two previous patches. Hopefully, I didn't
miss anything.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 00:51:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 23:51:40 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-TXibhBZePh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36354|0                           |1
        is obsolete|                            |

--- Comment #21 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36355
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36355&action=edit
Bug 10988 - Allow login via Google OAuth2

This is my rework of a patch by Nicholas van Oudtshoorn.
Fixed the patch so that it again cleanly applies.

Adds googleoauth2 login to koha. Adds applicable system
preferences Modifies templates to support oauth2 login
failures changes the login links to use googleoauth2 when
oauth2 is enabled.

Test Plan:
 0) Back up your database
 1) Apply this patch
 2) In your mysql client use your Koha database and execute:
    > DELETE FROM systempreferences;
    > SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql;
    -- Should be no errors.
    > SELECT * FROM systempreferences LIKE 'GoogleOAuth%';
    -- Should see 4 entries.
    > QUIT;
 3) Restore your database
 4) Run ./installer/data/mysql/updatedatabase.pl;
 5) In your mysql client use your Koha database and execute:
    > SELECT * FROM systempreferences LIKE 'GoogleOAuth%';
    -- Should see the same 4 entries.
 6) Log into the staff client
 7) Home -> Koha administration -> Global system preferences
 8) -> Administration
    -- There should be a 'Google OAuth2' section with the ability
       to set those 4 system preferences.
 9) In a new tab, go to https://console.developers.google.com/project
10) Click 'Create Project'
11) Type in a project name that won't freak users out, like your
    library name (e.g. South Pole Library).
12) Click the 'Create' button.
13) Click the 'APIs & auth' in the left frame.
14) Click 'Credentials'
15) Click 'Create new Client ID'
16) Select 'Web application' and click 'Configure consent screen'.
17) Select the Email Address.
18) Put it a meaningful string into the Product Name
    (e.g. South Pole Library Authentication)
19) Fill in the other fields as desired (or not)
20) Click 'Save'
21) Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL.
    (http://library.yourDNS.org)
22) Change the 'AUTHORIZED REDIRECT URIS' to point to the new
    googleoauth2 script
    (http://library.yourDNS.org/cgi-bin/koha/svc/googleoauth2)
23) Click 'Create Client ID'
24) Copy and paste the 'CLIENT ID' into the GoogleOAuth2ClientID
    system preference.
25) Copy and paste the 'CLIENT SECRET' into the GoogleOAuth2ClientSecret
    system preference.
26) Change the GoogleOAuth2 preference to 'Use'.
27) Click 'Save all Administration preferences'
28) In the OPAC, click 'Log in to your account'.
    -- You should get a confirmation request, if you are
        already logged in, OR a login screen if you are not.
    -- You need to have the primary email address set to one
       authenticated by Google in order to log in.
29) Run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 00:52:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 23:52:05 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-S906ZtoVeG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
         Depends on|                            |5010

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 00:52:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 23:52:05 +0000
Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol
In-Reply-To: <bug-5010-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5010-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5010-70-jl8tPAK5Y4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10988

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 00:53:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Mar 2015 23:53:33 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-GfdZDjuIV9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #22 from M. Tompsett <mtompset at hotmail.com> ---
It depends on 5010, because I cut out the hard coded 'http://' part of the code
in the new googleoauth2 script. Technically, you can test it without 5010, but
you need the protocol in your OPACBaseURL. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 04:02:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 03:02:39 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-8xU6WG1P5k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #23 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Thanks so much to M. Tompsett for doing this. I've been busy with other jobs
(including upgrading to 3.18!), and just haven't got around to sending in our
patch. :-)
(In reply to M. Tompsett from comment #22)
> It depends on 5010, because I cut out the hard coded 'http://' part of the
> code in the new googleoauth2 script. Technically, you can test it without
> 5010, but you need the protocol in your OPACBaseURL. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 05:32:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 04:32:46 +0000
Subject: [Koha-bugs] [Bug 13607] Patron management API
In-Reply-To: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13607-70-kQk1tnhlr7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 05:32:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 04:32:49 +0000
Subject: [Koha-bugs] [Bug 13607] Patron management API
In-Reply-To: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13607-70-WaM7K6SRJD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

--- Comment #17 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36356
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36356&action=edit
Bug 13607: correct handling of dateexpiry and dateenrolled

With this patch:
* if a dateexpiry is not provided, it is generated based on the
  category.
* if a dateenrolled is not provided, it is generated based on 'now'.

This applies when a user is created only.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 07:09:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 06:09:26 +0000
Subject: [Koha-bugs] [Bug 13779] New: sessionID declared twice in
	C4::Auth::checkauth()
Message-ID: <bug-13779-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779

            Bug ID: 13779
           Summary: sessionID declared twice in C4::Auth::checkauth()
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Authentication
          Assignee: gmcharlt at gmail.com
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

"$sessionID" is declared twice in C4::Auth::checkauth().

The first time is at the start of C4::Auth::checkauth(), while the second is in
the "unless ($userid || $sessionID)" block. 

This means that "return ( $userid, $cookie, $sessionID, $flags )", which is
called within the "if ( $loggedin || $authnotrequired )" block, will never ever
return the $sessionID created in the "unless ($userid || $sessionID)" block,
since it's out of scope.

The only time that "return ( $userid, $cookie, $sessionID, $flags )" will
return "$sessionID" is if the "elsif ( $sessionID = $query->cookie("CGISESSID")
)" block evaluates to true.

--

In other words, "my ( $userid, $cookie, $sessionID ) = checkauth( $query, 0,  {
borrow => 1 }, 'opac', '');" will only have a $sessionID if the user already
has the CGISESSID cookie set.

This doesn't prevent checkauth() from setting the session or the cookie
properly. It just means $sessionID isn't set even though it should be, because
it's the value that is stored in the cookie!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:10:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 07:10:32 +0000
Subject: [Koha-bugs] [Bug 12680] Shibboleth adaptive config
In-Reply-To: <bug-12680-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12680-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12680-70-jGQ2CkRNTc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12680
Bug 12680 depends on bug 13569, which changed state.

Bug 13569 Summary: Shibboleth example config for Packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:10:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 07:10:32 +0000
Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
In-Reply-To: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12027-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12027-70-VSeyaJKx2O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027
Bug 12027 depends on bug 13569, which changed state.

Bug 13569 Summary: Shibboleth example config for Packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:10:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 07:10:30 +0000
Subject: [Koha-bugs] [Bug 13569] Shibboleth example config for Packages
In-Reply-To: <bug-13569-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13569-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13569-70-S5ySiNwAbx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |mirko at abunchofthings.net

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---


*** This bug has been marked as a duplicate of bug 13571 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:10:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 07:10:30 +0000
Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync
 with koha-conf.xml
In-Reply-To: <bug-13571-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13571-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13571-70-zMFcjAuyJV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571

--- Comment #17 from Mirko Tietgen <mirko at abunchofthings.net> ---
*** Bug 13569 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:10:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 07:10:32 +0000
Subject: [Koha-bugs] [Bug 12681] Shibboleth attributes may contain lists
In-Reply-To: <bug-12681-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12681-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12681-70-9UuypbrRLQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12681
Bug 12681 depends on bug 13569, which changed state.

Bug 13569 Summary: Shibboleth example config for Packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:10:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 07:10:33 +0000
Subject: [Koha-bugs] [Bug 12682] Shibboleth attribute manipulation
In-Reply-To: <bug-12682-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12682-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12682-70-SF8M0oCmep@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12682
Bug 12682 depends on bug 13569, which changed state.

Bug 13569 Summary: Shibboleth example config for Packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:10:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 07:10:33 +0000
Subject: [Koha-bugs] [Bug 13114] Disabled Shibboleth authentication spams
	logs
In-Reply-To: <bug-13114-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13114-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13114-70-z09rPOwa8I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13114
Bug 13114 depends on bug 13569, which changed state.

Bug 13569 Summary: Shibboleth example config for Packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:10:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 07:10:31 +0000
Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning
In-Reply-To: <bug-12026-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12026-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12026-70-QjVOBabea6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026
Bug 12026 depends on bug 13569, which changed state.

Bug 13569 Summary: Shibboleth example config for Packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 08:19:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 07:19:32 +0000
Subject: [Koha-bugs] [Bug 10532] koha-run-backups option --output doesn't
	work
In-Reply-To: <bug-10532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10532-70-0BKY14WyQK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10532

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |mirko at abunchofthings.net

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
Setting this to failed QA based on Robin's comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:08:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:08:20 +0000
Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons
In-Reply-To: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11900-70-Jt9nb8hoHO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:08:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:08:23 +0000
Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons
In-Reply-To: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11900-70-vSgiwlQl4P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900

--- Comment #8 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 36357
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36357&action=edit
[SIGNOFF] Bug 11900 - OPAC cart can confuse patrons

This patch adds a title tag to the "Cart" link on Opac main page (and to the
"Lists" link as well).

Wording should be verified by a native speaker  :-)

To test:
Apply patch
Go to OPAC main page, verify that a tooltip appears on the "Cart" and "Lists"
links at the top of the page.

Signed-off-by: Nick <nick at quecheelibrary.org>
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:09:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:09:12 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-3g9vD9AR5I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35697|0                           |1
        is obsolete|                            |

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36358
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36358&action=edit
Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:09:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:09:53 +0000
Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons
In-Reply-To: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11900-70-tXG8EOSvSl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900

--- Comment #9 from Jesse Maseto <jesse at bywatersolutions.com> ---
Thank you Marc. I have retested this patch and have signed off.

-Jesse

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:10:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:10:41 +0000
Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons
In-Reply-To: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11900-70-muOldCmfvy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36239|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:14:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:14:03 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-ZxmzZsiaBC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:22:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:22:33 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-BzIVU4aqU6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
             Status|Signed Off                  |Failed QA

--- Comment #194 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Jonathan - 

updatabase just needs a quick rebase.  

Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Failed to merge in the changes.
Patch failed at 0001 Bug 10855: Update database entry

Thanks - Then I can test/qa.

-Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:28:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:28:12 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-PBrbqWd8VJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:28:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:28:20 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-uO32hjCNOY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35310|0                           |1
        is obsolete|                            |

--- Comment #195 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36359
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36359&action=edit
Bug 10855: Update database entry

Add 2 tables: additional_fields and additional_field_values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:36:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:36:29 +0000
Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed
In-Reply-To: <bug-13497-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13497-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13497-70-mLl6zJZ44g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36053|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36360
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36360&action=edit
[PASSED QA] Bug 13497: Remove the pref AddPatronsLists

The pref AddPatronLists does not work as expected if 'generic' is
selected.
Indeed a patron should be linked to a valid patron category (see the
constraint borrowers_ibfk_1 in the DB structure).

Test plan:
0/ Confirm that the AddPatronLists does not work as expected if you choose
the generic patron types.
1/ Delete all you patron categories and check that the interface invites
you to create one.
2/ Confirm that you are able to create a patron and to link it to a patron
category you have created.

I could not verify step 1/, because at least one Patron category
can not be deleted (Staff, since I'm logged in as a Staff patron
and you can not delete categories that are in use).
Tested 0/ and 2/
Signed-off-by: Marc V?ron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes QA script and tests.



Current patch-complexity: Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:37:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:37:57 +0000
Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed
In-Reply-To: <bug-13497-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13497-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13497-70-FP5nriZviZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, 

I am happy with the patch, but I am having some doubts if we understand how
this was meant to work correctly. Would you mind sending a short email to the
Koha mailing list asking people about removing it/a use case where this is
needed for?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:40:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:40:12 +0000
Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format
	dates
In-Reply-To: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4402-70-iDphpAWFlS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Jonathan, I am not sure I understand what you propose in your last comment -
should this go on a separate bug? I'd really like to see this fixed, but not
sure how to move on.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:47:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:47:05 +0000
Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed
In-Reply-To: <bug-13497-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13497-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13497-70-fs4SngXNsX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #6)
> Hi Jonathan, 
> 
> I am happy with the patch, but I am having some doubts if we understand how
> this was meant to work correctly. Would you mind sending a short email to
> the Koha mailing list asking people about removing it/a use case where this
> is needed for?

I am not sure it's necessary, the pref has been introduced by bug 1782, the
default value is categorycode, and it does not work if category_type if
defined.
Actually I think this pref should have never been created, and it does not make
sense since you need to set the borrowers.categorycode with a valid category
code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 09:54:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 08:54:13 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-gVH5vXn20T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

--- Comment #19 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Still works as intended, so leaving this bug as Signed off for QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:20:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:20:12 +0000
Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature
In-Reply-To: <bug-12461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12461-70-7Es5chtnnY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Pierre Angot <tredok.pierre at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tredok.pierre at gmail.com

--- Comment #9 from Pierre Angot <tredok.pierre at gmail.com> ---
We've tested it on sandbox.

The patch apply correctly, but we don't see the "Patron clubs" link.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:23:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:23:09 +0000
Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed
In-Reply-To: <bug-13497-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13497-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13497-70-N8l5yoOnCk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I guess I am just worried I misunderstood how it should work - looked for other
related bugs, but had not much luck.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:23:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:23:34 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-VL1IzkPdtj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:23:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:23:36 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-WLEw53S7vX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #8 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 36361
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36361&action=edit
[SIGNED OFF] Bug 13771: Update Circ Help File

This updates the main circulation help file with new features in 3.18.

To test:

* visit circulation page
* click help
* review text

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:51:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:51:56 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-x5J29oKG7C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:51:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:51:59 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-tVG2AG3S2E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35211|0                           |1
        is obsolete|                            |

--- Comment #196 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36362
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36362&action=edit
Bug 10855: Add the new package Koha::AdditionalField

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:52:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:52:09 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-nBQCA498rI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35212|0                           |1
        is obsolete|                            |

--- Comment #197 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36363
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36363&action=edit
Bug 10855: Add unit tests for the new package Koha::AdditionalField

Test plan:
- prove t/db_dependent/AdditionalField.t

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:52:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:52:14 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-XQtPESiuOP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35213|0                           |1
        is obsolete|                            |

--- Comment #198 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36364
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36364&action=edit
Bug 10855: interface configuration for adding new fields to subscriptions

This patch adds an interface configuration for adding fields to
subscriptions.

Test plan:
- go to serials/serials-home.pl
- click on the "Add subscription fields" link on the left of the screen
- try to add/update/delete new fields
You are not abble to add a field with an authorised value category and a
marcfield. Columns are sortable
- for the rest, you should have, at least:
  * a new field named af1, sortable, linked to a category
  * a new field named af2, sortable, linked to a marcfield
  * a new field named af3, not sortable

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:52:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:52:20 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-D9a9jkG8mj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35214|0                           |1
        is obsolete|                            |

--- Comment #199 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36365
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36365&action=edit
Bug 10855: New fields on adding/updating a subscription

This patch adds the ability to add values for additional fields when
adding/updating a subscription.

Test plan (test the following on adding a new subscription and on
editing an existent one):
- add/edit a subscription.
- verify all additional fields appears into the "Additional fields"
  block.
- fill a value for af1 and af3.
- fill others values if you are adding a new subscription.
- save.
- verify values appears on the detail of the subscription page.
- verify the af2 field is automatically filled with the specified
  marc field of the notice.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:52:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:52:26 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-VwsQsnLNQa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35215|0                           |1
        is obsolete|                            |

--- Comment #200 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36366
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36366&action=edit
Bug 10855: Search subscriptions by additional fields

Now you will abble to search subscriptions by additional fields.
The additional field values will be displayed in the table results.

Test plan:
- go on the subscriptions advanced search page
  (serials/serials-search.pl).
- verify all searchable additional fields are displayed on the form.
- combine 1 or more values and verify results are consistent.
- verify the values are displayed in new columns of the table.
- for field linked to an authorised value category, the description is
  displayed (not the code).

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:52:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:52:34 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-fhksS0HdJt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35216|0                           |1
        is obsolete|                            |

--- Comment #201 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36367
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36367&action=edit
Bug 10855: Search subscriptions by additional fields on the claim page

Test plan:
- create some serials in late.
- go on serials/claims.pl.
- choose a vendor.
- verify that additional fields are displayed in new columns.
- try filters on columns.
- verify there is no regression on this page.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:52:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:52:42 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-WRHKibYNr4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35217|0                           |1
        is obsolete|                            |

--- Comment #202 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36368
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36368&action=edit
Bug 10855: Squash several fixes

Bug 10855: FIX: Add additional fields for closed subscriptions

Bug 10855: Fix instance vs static method

This patch fixes the error message.
The 3 modified routines *are* static methods.

Bug 10855: FIX conflicts with bug 7688

Bug 10855: Fix typo addition_fields -> additional_fields

Bug 10855: A partial search should return the subscriptions

If a search on an additional fields is done using a partial string
("foo" and the defined value is "foobar"), the subscription should
appear in the result list.

Test plan:
Try to search a part of the string for an additional field.

Bug 10855: Filtering on additional fields don't work if value is equal to 0

If you tried to filter on an additional field linked to an authorised
value, that did not work if the value was 0.

Bug 10855: Remove the advanced serial search box on the serial home page

Bug 10855: FIX an add field should not be created if the marc field does not
exist.

This patch fixes the following:
Create an add fields linked to a nonexistent marc field (does not exist
in serials).
Edit a subscription and save.
Without this patch, an error occured:
Software error:
DBD::mysql::db do failed: Column 'value' cannot be null at
/var/root-koha/bug-10855/Koha/AdditionalField.pm line 107.

Bug 10855: Fix Type table vs tablename

Koha::AdditionalField->all method take "tablename" not "table" in
parameter".

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:52:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:52:52 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-6PpSXhZlHg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35218|0                           |1
        is obsolete|                            |

--- Comment #203 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36369
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36369&action=edit
Bug 10855: Fix QA issues

This patch fixes the following QA issues:

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
  FAIL   forbidden patterns
       forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug
10626) (line 2)

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
  FAIL   forbidden patterns
       forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug
10626) (line 2)

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
  FAIL   forbidden patterns
       forbidden pattern: To include datatables files, please use the include
file (see bug 10868) (line 12)

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:52:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:52:59 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-HDj7IUFumM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35220|0                           |1
        is obsolete|                            |

--- Comment #204 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36370
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36370&action=edit
Bug 10855: search with exact match if linked to an AV

If a field is linked to an AV, the search should be an exact match.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:53:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:53:05 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-Px1N5oBKOg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35221|0                           |1
        is obsolete|                            |

--- Comment #205 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36371
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36371&action=edit
Bug 10855: Additional marc fields are not inserted

In subscription-add.pl, the code for inserting additional_fields is not
the same for updating and inserting.
This patch refactores this code in code to do the same tests.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:53:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:53:11 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-ZaLnRPLWc8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35309|0                           |1
        is obsolete|                            |

--- Comment #206 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36372
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36372&action=edit
Bug 10855: Make tests to pass

Some recent changes in master make these tests fail.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:53:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:53:18 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-9sQHmXkt8L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35369|0                           |1
        is obsolete|                            |

--- Comment #207 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36373
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36373&action=edit
Bug 10855: (follow-up) Search subscriptions by additional fields

1 occurrence of KohaAuthorisedValues had not been replaced with
AuthorisedValues on fixing a previous conflict.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:53:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:53:25 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-XY6QRnSMNc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36359|0                           |1
        is obsolete|                            |

--- Comment #208 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36374
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36374&action=edit
Bug 10855: Update database entry

Add 2 tables: additional_fields and additional_field_values

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:57:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:57:30 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-CyfdNZlqdV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36325|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:57:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:57:53 +0000
Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for
 checking in items that are not checked out
In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13411-70-09cNn801ru@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
there is a small bug in the rebase on line 202:
Can't locate object method "Patron" via package "ILS" at C4/SIP/ILS.pm line
202.

$circ->patron( $patron = new ILS::Patron $item->{patron} );

should be:

$circ->patron($patron = C4::SIP::ILS::Patron->new( $item->{patron} ));

otherwise it breaks connection on checkin of checked out item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 10:59:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 09:59:34 +0000
Subject: [Koha-bugs] [Bug 13780] New: A patron without cardnumer will break
 searching for category code
Message-ID: <bug-13780-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13780

            Bug ID: 13780
           Summary: A patron without cardnumer will break searching for
                    category code
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If you have a patron without a cardnumber in your database and you try to
search for all patrons from a certain patron category, search will always
redirect you to this user, even if he doesn't fit the search criteria.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:02:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:02:19 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-jmDuON38s2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #9 from Brendan Gallagher <brendan at bywatersolutions.com> ---
FAIL    koha-tmpl/intranet-tmpl/prog/en/modules/help/circ/circulation.tt
   FAIL      forbidden patterns
        forbidden pattern: tab char (line 79)
        forbidden pattern: tab char (line 16)
   OK      tt_valid
   OK      valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:03:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:03:34 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-flbIkckIwC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #10 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36375
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36375&action=edit
Bug 13771: Add admin help files for 3.18

This patch adds a new help file for column settings and updates the
files for budgets, funds, libraries, patron categories, and circ rules.

To test:

* Visit the above listed admin pages
* Review help files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:08:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:08:18 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-TJfc7qeUOh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:08:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:08:18 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-Kr3Bqj8aHN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #11 from Nicole C. Engard <nengard at gmail.com> ---
Brendan,

All of the help files have tabs because they are HTML and this is okay
(according to the conversation with Katrin at hackfest).

Thanks,
Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:08:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:08:39 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-rCzvwtooJj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #12 from Nicole C. Engard <nengard at gmail.com> ---
The newest patch (admin help for 3.18) needs sign off.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:10:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:10:36 +0000
Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
In-Reply-To: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12532-70-l1bjbHbo2f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #7 from Jesse Maseto <jesse at bywatersolutions.com> ---
Bug 12532 - Redirect guarantee email to guarantor

35313 - Bug 12532 - Redirect guarantee email to guarantor

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12532 - Redirect guarantee email to guarantor
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Members.pm
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 12532 - Redirect guarantee email to guarantor
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-12532---Redirect-guarantee-email-to-guarantor-BQ1gJr.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:12:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:12:41 +0000
Subject: [Koha-bugs] [Bug 13781] New: Relative's checkouts tableis missing
 one column heading
Message-ID: <bug-13781-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

            Bug ID: 13781
           Summary: Relative's checkouts tableis missing one column
                    heading
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 36376
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36376&action=edit
Screenshot of the table

In the relatives' checkouts table one column heading is missing, so most of the
column headings are off and don't match what is shown in the column.

It looks like the very first column heading for 'due date' is missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:14:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:14:15 +0000
Subject: [Koha-bugs] [Bug 13781] Relative's checkouts tableis missing one
	column heading
In-Reply-To: <bug-13781-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13781-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13781-70-ef49vV9oGP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:15:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:15:24 +0000
Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts
In-Reply-To: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13605-70-zrAQGDHZbb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:15:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:15:28 +0000
Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts
In-Reply-To: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13605-70-IMNxMhRaOW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36377
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36377&action=edit
[PASSED QA] Bug 13605 - _AUTHOR_ not replaced in relatives checkouts

In members/moremember.pl, in relatives checkouts tab, "by _AUTHOR_" appears
before author.
This code sould be replaced in JS.

Test plan :
- Go to a borrower with relative's checkouts
=> without patch : you see "by _AUTHOR_" string before author name
=> with patch : you see "by" string before author name

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, fixes the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:15:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:15:53 +0000
Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts
In-Reply-To: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13605-70-tQG04T1TT1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
  Attachment #36151|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:24:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:24:29 +0000
Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects
In-Reply-To: <bug-7939-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7939-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7939-70-ENQjPUcUKu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36241|0                           |1
        is obsolete|                            |

--- Comment #11 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36378
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36378&action=edit
Bug 7939 - Separate po files for different MARC dialects

This patch implements separate PO files for
different MARC dialects.

It depends on correct filenames, i.e. it will build PO
files using files with/without "unimarc|normarc|marc21"
on their names.

Changes:
A) LangInstaller.pm
Added definitions to create or update xx-YY-{MARCFLAVOR}.po,
minor change to create and install procedure, and modification
of install procedure to handle multiple target dirs.
Updated documentation.

B) Standarization of filenames
STAFF po file is now xx-YY-staff-prog.po
MARC dialects po files are xx-YY-marc-{MARCFLAVOUR}.po

To test:
1) Update po files for your preferred language, ej. nn-NO
cd misc/translator
perl translate update nn-NO

2) Do some copying/renaming
cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-UNIMARC.po
cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-NORMARC.po
cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-MARC21.po
mv po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-staff-prog.po

(most MARC dialect strings are on staff, so we use that as basis)

3) Apply the patch

4) Update again to fix translation files, verbose
perl translate update nn-NO -v

5) Install language, verbose, verify translations
perl translate install nn-NO -v

6) Create translation files
rm po/nn-NO*
perl translate create nn-NO

we must have this list:
po/nn-NO-marc-MARC21.po
po/nn-NO-marc-NORMARC.po
po/nn-NO-marc-UNIMARC.po
po/nn-NO-opac-bootstrap.po
po/nn-NO-pref.po
po/nn-NO-staff-help.po
po/nn-NO-staff-prog.po

Additional tests:
7) Number of msgids
7.a) Before patch and after upgrade, extract and count msgids
for i in $(ls po/nn-NO-*po); \
do msginit -i $i -o nn-old.po --no-translator --no-wrap --locale=nn_NO; \
egrep ^msgid nn-old.po >> old; \
done
sort old | uniq | tee s-old | wc -l > n-old
s-old: have all msgids
n-old: number of msgids

7.b) After patch and after creation of new files
Repeat procedure, diferent files (s-new, n-new)

7.c) Compare (diff s-old snew), they are the same
(save for a strange UNIMARC char in my case, but
it's present on corresponding PO file)

8) Installed dirs/files
8.a) List of EN dirs/files
cd koha-tmpl
find | egrep "/en/" > en

8.b) List of nn-NO dirs/files. After patch and language install
cd koha-tmpl
find | egrep "/nn-NO/" | sed 's|/nn-NO/|/en/|' > nn

8.c) Compare (diff en nn), they are the same

Signed-off-by: Magnus Enger <magnus at enger.priv.no>
Followed the steps outlined by Bernardo, and everything works as
expected. I think the most important points are that "perl translate
create nn-NO" produces the right files, and translating anything in
them, then doing "translate install" makes the translations show
up in the interface. The numbers msgids in the nn-NO correspond
well wit the number of msgids in other sets of .po files.

I bet y'all will be happy when you don't have to see the stupid
Norwegian strings when you translate! ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:24:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:24:25 +0000
Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects
In-Reply-To: <bug-7939-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7939-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7939-70-FDEFwoAD0R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:26:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:26:28 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-Y4WuIPL2st@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #111 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
I'm not able to patch against master. Is there a dependency I'm missing?

fatal: sha1 information is lacking or useless (C4/Auth.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system
prefs to the Circulation Matrix

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:32:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:32:36 +0000
Subject: [Koha-bugs] [Bug 13578] Parameter public is lost on creating a
	report
In-Reply-To: <bug-13578-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13578-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13578-70-pAM5vhadsv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13578

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:32:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:32:39 +0000
Subject: [Koha-bugs] [Bug 13578] Parameter public is lost on creating a
	report
In-Reply-To: <bug-13578-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13578-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13578-70-XI9Ak2D90e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13578

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36152|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36379
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36379&action=edit
[PASSED QA] Bug 13578: Make sure the 'public' parameter is passed to the last
step

If no caching system is up ($usecache == 0), the public parameter is
lost on the step 3.
The hash passed to the template looks like:
   'cache_expiry', 300,
   'cache_expiry_units',
   'public', 1
So the template receives cache_expiry = 300, cache_expiry_units =
'public' and 1 = undef.

This patch fixes the problem passing the cache_expiry* parameters only
if the usecache is set.

Test plan:
0/ Disable any caching system
1/ Create a new public report and go up to the 6th step, save the report
and verify the report is created as public
2/ Enable a caching system
2/ Create a public report with a cache expiry value, save it and verify
the report is created as public and the cache expiry value is correct.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:33:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:33:21 +0000
Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format
	dates
In-Reply-To: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4402-70-Rf4VpSVGAZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402

--- Comment #31 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #30)
> Jonathan, I am not sure I understand what you propose in your last comment -
> should this go on a separate bug? I'd really like to see this fixed, but not
> sure how to move on.

Yes, it is not in the scope of this bug.
I suggested to add a global JS rule to add a check on all input dates.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:33:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:33:51 +0000
Subject: [Koha-bugs] [Bug 13578] Parameter public is lost on creating a
	report
In-Reply-To: <bug-13578-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13578-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13578-70-cPnOSXbRy2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13578

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This works nicely, but wondering why we put the public switch on the first step
instead of on the last step when saving the report? Then the forms to create an
SQL report and to save a guided report would be more similar. Not a blocker at
all as this is a bug fix, just got me a little confused :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:34:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:34:34 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-XFHHLx5YTx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

--- Comment #3 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
I cannot reproduce 4) on master. Relogging works for me. Can you provide more
informations about how 4) failed for you ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:34:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:34:48 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-uAyERXyF6g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #642 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36380
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36380&action=edit
Bug 6427 [QA Followup] - Drop old accounts tables

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:36:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:36:55 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-QBRkTuYGta@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36112|0                           |1
        is obsolete|                            |

--- Comment #7 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36381
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36381&action=edit
[SIGNED-OFF] Bug 13744: Fix datatables paging on 'order from subscription' page

The paging of the datatable on the 'order from subscription' page
is broken without this patch.

To test:
- Make sure you have a subscription, note the vendor
- Create a new basket for this vendor
- Add a new order line 'from a subscription'
- Check paging on the result table displays correctly

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:39:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:39:04 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-5HtGGJB7VT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36117|0                           |1
        is obsolete|                            |

--- Comment #8 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36382
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36382&action=edit
[SIGNED-OFF] Bug 13744: Fix datatables paging on 'checkout history' page

The paging in the datatable on the 'circulation history' page
is broken without this patch.

/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=...

To test:
- Search for a record with items that have been checked out
  in the past
- From the detail page, open the 'checkout history' tab
- Check paging displays correctly with this patch and is
  broken without

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:39:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:39:28 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-WWQ5nG2JyE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35598|0                           |1
        is obsolete|                            |

--- Comment #112 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36383
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36383&action=edit
Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to the
Circulation Matrix

C4::Reserves:
* Added OnShelfHoldsAllowed() to check issuingrules
* Added OPACItemHoldsAllowed() to check issuingrules
* IsAvailableForItemLevelRequest() changed interface, now takes
  $item_record,$borrower_record; calls OnShelfHoldsAllowed()

opac/opac-reserve.pl and opac/opac-search.pl:
* rewrote hold allowed rule to use OPACItemHoldsAllowed()
* also use OnShelfHoldsAllowed() through
* IsAvailableForItemLevelRequest()

templates:
* Removed AllowOnShelfHolds and OPACItemHolds global flags, they now
  only have meaning per item type

Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>

I have tested this patch left, right and upside down for the last
several months. All tests have passed.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:39:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:39:50 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-AzLSTjgb9M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #32 from Brendan Gallagher <brendan at bywatersolutions.com> ---
 FAIL    koha-tmpl/intranet-tmpl/prog/en/modules/tools/cn_browser.tt
   FAIL      forbidden patterns
        forbidden pattern: To include datatables files, please use the include
file (see bug 10868) (line 12)
   OK      tt_valid
   OK      valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:40:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:40:08 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-24vz095lfk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35599|0                           |1
        is obsolete|                            |

--- Comment #113 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36384
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36384&action=edit
Bug 5786 [QA Followup]

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:43:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:43:37 +0000
Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour
	customizable
In-Reply-To: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8994-70-t9KniYM73Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |paola.rossi at cineca.it

--- Comment #5 from Paola Rossi <paola.rossi at cineca.it> ---
I've tried to apply the patch against master 3.19.00.012 head 13731

Applying: MT9496: Improve FindDuplicateAuthority
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging C4/AuthoritiesMarc.pm
CONFLICT (content): Merge conflict in C4/AuthoritiesMarc.pm
Failed to merge in the changes.

So I pass the patch to "Patch doesn't apply" status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:43:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:43:37 +0000
Subject: [Koha-bugs] [Bug 13351] Untranslatable javascript in members.tt
In-Reply-To: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13351-70-b07303lnwL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
To reproduce:

Go to Home > Patrons (cgi-bin/koha/members/members-home.pl)
- Switch language e.g. to German
- Use filter and fill all fields

You get a result like:

Treffer gefunden for patron on standard fields beginnend mit Nepomuk mit
Kategorie Erwachsener in der Bibliothek Allschwil

Hmm, English version looks weird too:

Results found for patron on borrower number fields starting with 1 with
category Staff in library Fairview

Something like the following would look better and would be better to
translate:

Patrons found for: Standard containing 'A' with category 'Adult' in library
Airfield

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:44:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:44:08 +0000
Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar
In-Reply-To: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11211-70-Z3FJ2fUt82@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

--- Comment #48 from Magnus Enger <magnus at enger.priv.no> ---
(In reply to Jesse Weaver from comment #47)
> RE: comment 5: I used event instead of holiday because you can now record
> that a given day is open or closed, seperately of the precedence order of
> specific day > day/month > weekday. 

That change makes sense to me - it looks like a good generalization from
holiday (which to me is something like Easter or "summer hliday") to "event"
(which to me could be something like "the library is closed for renovation",
which would be hard to fit into the "holiday" concept).

> RE: comment 32: I will at least cite lines 219-220 of Koha/Calendar.pm to
> argue for this patch's interpretation of isexception == open:
> 
>         # exceptions are not holidays
>         return 0;

I can sort of see that, but I have two concerns:

1) That future developers will find it hard to understand the name

2) That we are loosing some functionality. The way I understand the current
functionality, you can say that there is a holiday and the library is closed
from date A to date C, BUT on date B (which is between A and C) the library is
open anyway. If I remember correctly, you can also say that the library is
closed for a month, but open on Wednesdays. Is it still possible to do
something like that after applying the patch on this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:45:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:45:32 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-Qnrdv6yolo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

--- Comment #67 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
In plack discussion we decided to use this patch as starting point for plack
sysprefs problems, but it doesn't apply for me:

Applying: Bug 11998 - move most syspref db access into Context.pm
fatal: sha1 information is lacking or useless (C4/Context.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 11998 - move most syspref db access into Context.pm

This one is quite large, so I'm reluctant to apply it by hand. Robin, can you
please rebase it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:45:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:45:55 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-Pt8AcoH3zx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:45:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:45:58 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-BX4tWqPI8y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36347|0                           |1
        is obsolete|                            |

--- Comment #9 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36385
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36385&action=edit
[SIGNED-OFF] Bug 13744: Fix datatables paging on 'Holds to pull' report

The paging of the datatables on the 'holds to pull' report
page is broken without this patch.

To test:
- Make sure that some holds are placed on available items
  in your installation
- Go to the circulation start page
- Open the 'holds to pull' report
- Verify that the patch fixes the paging on the result table

Also: Fixes "None" in the filter pull downs to be translatable.
Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:47:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:47:44 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-S1tdfEOpLC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #48 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Paola, about your remarks:

the "Item type" and "Previous item type" fields were not set to "Continuing
Resources" anymore! (ERROR)

=> fixed in a little patch I will submit.


When I received ("Arrived") an issue [in DB: table serial] of the suscription
(the first issue), I saw that the default value of the:
"y - Koha item type" field
of the new item was set to nothing (why?).

=> Is your itemtype field (995$y in your case) using itemtypes authorized
values in the bibliographic framework ? It does not work if authorized values
are not linked.


prove t/db_dependent/Serials_2.t

=> The tests also fail from test #3 on master, so my patch may have not broken
the tests (must be fixed on master to be sure, though).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:49:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:49:44 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-UEdNuk6z0N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:56:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:56:51 +0000
Subject: [Koha-bugs] [Bug 13351] Untranslatable javascript in members.tt
In-Reply-To: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13351-70-y7luW4qR2o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 36386
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36386&action=edit
Bug 13351 - Untranslatable javascript in members.tt

This patch streamlines the page title text for search results in Home > Patrons
to make it translateable (and more readable).

To test:
- Apply patch
- Select Englsh language
- Apply filter wit several values or click on a letter for "Browse by last
name"
- Verify that the title makes sense
- Translate to your language and select this language
- Verify that the text appears properly in your language

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 11:57:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 10:57:10 +0000
Subject: [Koha-bugs] [Bug 13351] Untranslatable javascript in members.tt
In-Reply-To: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13351-70-7wTJxJ9wf0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:00:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:00:16 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-uEOKBwq1qY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13782

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:00:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:00:16 +0000
Subject: [Koha-bugs] [Bug 13782] New: RSS for news needs a bit of styling
Message-ID: <bug-13782-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13782

            Bug ID: 13782
           Summary: RSS for news needs a bit of styling
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 7843

Created attachment 36387
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36387&action=edit
display of rss

It looks like the RSS feed for the news items could use a bit of styling
because right now it is right up against the main body content and that is
confusing.  I'd say the icon should be at the top of the news on the right or
in the opac footer instead of right below the news.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:03:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:03:07 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-GP9NbRLLCq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #12 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #11)
> Would it not make much more sense to simply have a new `biblio` table field
> `force_item_level_holds` rather than creating a completely new table with
> only a single column?

Not really, it is somewhat arbitrary. If many libraries would not use this
feature or just mark some exceptions as such, it is much cheaper in terms of
space to have an additional small table.
I would choose now for a small start: Moving the data into biblio at some point
in time is just a trivial db rev with a few lines and the table is gone!

Back to Signed off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:03:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:03:39 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-b2VxI3ofHL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #15 from Nicole C. Engard <nengard at gmail.com> ---
If you visit : http://mykoha/cgi-bin/koha/opac-main.pl then the RSS feed works
and goes to : http://mykoha/cgi-bin/koha/opac-news-rss.pl but if you're on
http://mykoha and you click the rss icon you get :
http://mykoha/opac-news-rss.pl which is a 404 page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:04:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:04:28 +0000
Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on
 creating record from Z39.50
In-Reply-To: <bug-9742-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9742-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9742-70-ItQXoQe16W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:04:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:04:31 +0000
Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on
 creating record from Z39.50
In-Reply-To: <bug-9742-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9742-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9742-70-eXVQcUWfWG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36139|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36388
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36388&action=edit
[PASSED QA] Bug 9742: Does not display the popup on creating new record

The new confirmation on starting a z39.50 serach in cataloguing always
pops up, even when you are working on a new record that has not been
saved yet.

Test plan:
1/ Edit an existing record, click on the Z3950 search button, confirm
the popup appears.
2/ Create a new record, click on the Z3950 search button, confirm
the popup does not appear.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:05:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:05:57 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-snKHlBEeEA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34223|0                           |1
        is obsolete|                            |

--- Comment #49 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36389
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36389&action=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

  - Fix missing itemtype and previous itemtype when adding a subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:07:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:07:39 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-BsU4s63KsP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #16 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36390
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36390&action=edit
(follow up) Improve RSS feed language

The RSS button used to read ' RSS for the librarys general newsfeed.'
This included one grammatical error and I think included more words
than most average people would read.  This patch simplifies it to say
'RSS for Library News.'

To test:
* Apply all patches
* Review RSS feed button's text on main page under news

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:08:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:08:13 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-USFMj1IciX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36390|(follow up) Improve RSS     |Bug 7843: (follow up)
        description|feed language               |Improve RSS feed language

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:09:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:09:39 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-eNAsYkMBUa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:12:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:12:13 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-h0TkXpMEvf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #643 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36391
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36391&action=edit
Bug 6427 [QA Followup] - Further improvments to updatadatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:16:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:16:56 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-DmlmFahZJB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:17:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:17:01 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-hOo3BMI3bd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36280|0                           |1
        is obsolete|                            |

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36392
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36392&action=edit
[SIGNED-OFF] Bug 13773 - add stock number to details and items display

This patch adds stocknumber to details table and items display if it exists.

Test scenario:
1. find item(s) which have stock number assigned
2. verify that you don't see stock number in items display
3. apply this patch
4. verify that stock number is now available

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:19:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:19:09 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-ch8xB68WU0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #644 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36393
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36393&action=edit
Bug 6427 [QA Followup] - Fix accounts table default sorting

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:20:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:20:04 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-tQwiYvxQPa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:21:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:21:16 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-JvmxuXkv2V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com
             Status|Needs Signoff               |Signed Off

--- Comment #84 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Lucie <lucie.rousseaux at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:21:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:21:53 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-OCxEsQlapb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36180|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:21:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:21:59 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-nbELUgJrx4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36181|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:22:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:22:07 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-YMNeOOnJe6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36182|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:22:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:22:14 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-wHLHy0preO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36183|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:22:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:22:21 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-mSStrXUYJr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36184|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:22:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:22:33 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-ti5CbtzQsn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36186|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:22:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:22:27 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-9ZqUOAE1vW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36185|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:22:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:22:40 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-FoivU3Cnjd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36187|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:22:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:22:50 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-vpW66qjb6m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #85 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36394
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36394&action=edit
Bug 8007: Discharge - DB changes

This patch adds:
- syspref useDischarge
- the new table discharges
- the discharge notice

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:22:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:22:54 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-uJZuJAbTvM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #86 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36395
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36395&action=edit
Bug 8007: Discharge - DBIx changes

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:22:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:22:58 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-djovo96Yo4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #87 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36396
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36396&action=edit
Bug 8007: Discharge - Glue

This patch adds:
- links to the new pages.
- syspref description
- links on the main page (intranet)
- the DISCHARGE type for debarment

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:23:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:23:02 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-pi8tXNMcnS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #88 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36397
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36397&action=edit
Bug 8007: Discharge management

This patch is the main patch. It adds new package and files for the new
pages (opac-discharge, members/discharge and members/discharges).

At the intranet, it is now possible to generate a discharge for a patron.
At the opac, a patron can request a discharge and a discharge if it has
been validated by a librarian.

Requirements:
    The perl module PDF::FromHTML

New sysprefs:
 - useDischarge: Allows librarians to discharge borrowers and borrowers
   to request a discharge

New letter with a letter_code DISCHARGE.

Test plan:
- Switch on the syspref useDischarge.
- Verify a new tab appears in the patron page (intranet and opac).
- Verify the discharge cannot be generated if the patron has issues.
- Verify the patron can request a discharge from it's opac area.
- The request appears on the main page (intranet).
- Generate the discharge from the intranet.
- Try to download it (from the opac and the intranet).

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:23:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:23:07 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-IEujkkadRO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #89 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36398
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36398&action=edit
Bug 8007: Discharge - Add unit tests

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:23:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:23:11 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-OhnzsIbjKG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #90 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36399
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36399&action=edit
Bug 8007 : Discharge - Adding Perl dependencie

HTML::HTMLDoc is required in order to generate the discharges in PDF format.

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:23:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:23:15 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-g2U5sLmxmG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #91 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36400
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36400&action=edit
Bug 8007: Replace HTML::HTMLDoc with PDF::FromHTML

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:23:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:23:19 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-4BTQFdQG55@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #92 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36401
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36401&action=edit
Bug 8007: Compatibility with bug 11944

This patch should be applied to work with bug 11944.
If you don't have 11944 yet, just don't apply this patch.

Note that the line
  binmode(STDOUT);
in pl files is mandatory.

It comes from bug 11944 that adds the line
  binmode( STDOUT, ":utf8" );
in C4::Templates::gettemplate.

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:24:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:24:12 +0000
Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format
	dates
In-Reply-To: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4402-70-W12LS6fPYD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:24:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:24:16 +0000
Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format
	dates
In-Reply-To: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4402-70-VMoGL6mqEN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35151|0                           |1
        is obsolete|                            |

--- Comment #32 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36402
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36402&action=edit
[SIGNED-OFF] Bug 4402: Date filter on parcels.tt required db date format

The date filters on the parcel page would only work with
dates formatted YYYY-MM-DD.

To test:
- Select a vendor, that already has a few invoices
- "Receive shipment" - you are on the parcels page
- Use the From and To filters on the left, notice there
  is now a date picker on those fields
- Verify the search works correctly for different date
  formats

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:27:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:27:16 +0000
Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha
In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13696-70-PamdaybTYx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #3 from Nicole C. Engard <nengard at gmail.com> ---
Owen,

Are you doing the testing? I'm not sure what I'm seeing on this that's off
kilter except that the bottom buttons are smaller.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:27:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:27:36 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-fJEQN9PxyK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is something here I am not so happy with - the test plan tells you test
one out of 4 notices that are touched by this patch set:
- notifications about new serial issues
- claims in serials
- claims in acq

I'd love if those could be tested as well. Could a tester take a look at these
as well please?

Another thing that I am not sure how to solve: there seems a lot of code repeat
in Letters.pm that might not be necessary, but is out of the scope of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:30:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:30:20 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-GOBfSkTtkw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Nicole C. Engard <nengard at gmail.com> ---
I tried to apply this patch and got the following:

Applying: Bug 13575 - Names do not appear in the Koha history Timeline. This
would be a good addition. The names to be added are: Kahurangi Cormack,
Alexander Cheeseman
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging docs/history.txt
CONFLICT (content): Merge conflict in docs/history.txt
Failed to merge in the changes.
Patch failed at 0001 Bug 13575 - Names do not appear in the Koha history
Timeline. This would be a good addition. The names to be added are: Kahurangi
Cormack, Alexander Cheeseman
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-13575---Names-do-not-appear-in-the-Koha-histor-aJO7vj.patch
koha at koha-vm:~/kohaclone$ 



Maybe you should add it to the official bug instead: bug 7143

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:32:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:32:29 +0000
Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement
In-Reply-To: <bug-12770-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12770-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12770-70-ILq4M1kKkv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:34:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:34:06 +0000
Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additional
	checkin)
In-Reply-To: <bug-9848-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9848-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9848-70-EsZFRrNAwM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
            Summary|SIP tests : fix in          |SIP tests : fix in
                   |10renew_all.t (additionnal  |10renew_all.t (additional
                   |checkin)                    |checkin)

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am in favor of pushing these - what I get from the discussion is, that it
'looks right', so it might help when the old testing files are ever used for
reference in writing new tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:45:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:45:52 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-OYbHl9Ti1R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

Pierre Angot <tredok.pierre at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tredok.pierre at gmail.com

--- Comment #9 from Pierre Angot <tredok.pierre at gmail.com> ---
I've tested on sandbox, but there is a software error when we click on items
tab.

Software error:

Template process failed: file error - doc-head-angular.inc: not found at
/home/koha/src/C4/Templates.pm line 121.

For help, please send mail to the webmaster (webmaster at test5-sandbox), giving
this error message and the time and date of the error.


It seem to be linked to patch 13563.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:46:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:46:52 +0000
Subject: [Koha-bugs] [Bug 13783] New: script koha_perl_deps.pl doesn't see
 all installed modules
Message-ID: <bug-13783-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13783

            Bug ID: 13783
           Summary: script koha_perl_deps.pl doesn't see all installed
                    modules
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: gmcharlt at gmail.com
          Reporter: z.tajoli at cineca.it
        QA Contact: testopia at bugs.koha-community.org

Testing with perl koha_perl_deps.pl -m -u with a today master, the script says:

Module Name                                   Version           Version        
   Required
--------------------------------------------------------------------------------------------
Readonly::XS                                  0 *               1.02           
        No
Test::DBIx::Class                             0 *               0.42           
        No

--------------------------------------------------------------------------------------------
Total modules reported: 2                      * Module is missing or requires
an upgrade.


In fact Readonly::XS  and Test::DBIx::Class  are installed by packages and I
have also installed by Readonly::XS.

I'm working on Xubuntu trusy, 14.04.2 LTS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:57:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:57:33 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-GOTAXYpC2H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36403
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36403&action=edit
Bug 7843: Followup - fix broken url

This patch fixes an invalid URL when clicking
on RSS feed.

To test:
1) Using Nicole words :)
If you visit : http://mykoha/cgi-bin/koha/opac-main.pl
then the RSS feed works.
If you're on http://mykoha and you click the rss icon you
get : http://mykoha/opac-news-rss.pl which is a 404 page.

2) Apply the patch

3) Repeat 1, error is now fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 12:58:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 11:58:00 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-mZeCpDSS8R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 13:06:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 12:06:28 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-wVUwu3iUty@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #20 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Testing SIP2 messages, looking into 3M SIP2.0 manual. MEssages are not
standards compliant:

63 && 23:
- Non-standard compliant, has no zero padded month, day and second. Distorts
fixed-length fields.
- fields ok


24:
- OK


64:
- OK

No institution ID anywhere??
Will be fixed by 13666.

Silly warning:
Use of uninitialized value $value in concatenation (.) or string at
./sip_cli_emulator.pl line 462, <GEN0> chunk 1.
is ruining my day.


Otherwise works as expected.

Will proceed to fix and provide a followup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:01:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 13:01:53 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-HVzVRkVIHv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

Juliane <jcasier at ville-roubaix.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jcasier at ville-roubaix.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:40:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 13:40:48 +0000
Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add
 items form from header and sidebar
In-Reply-To: <bug-13680-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13680-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13680-70-xeayQ7cm3V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:45:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 13:45:05 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-2GY55Rh3mH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:45:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 13:45:41 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-FnUh8MMOMQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36358|0                           |1
        is obsolete|                            |
           Assignee|julian.maurice at biblibre.com |alex.sassmannshausen at ptfs-e
                   |                            |urope.com

--- Comment #18 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Created attachment 36404
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36404&action=edit
Signed patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 14:52:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 13:52:38 +0000
Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha
In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13696-70-1e9vkixKvb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Nice Icons.

Is it possible to get kind of testig patch for a template just to see how it
works, e.g. to reproduce Owens's screenshot?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:02:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:02:57 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-wJykiv049U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36384|0                           |1
        is obsolete|                            |

--- Comment #114 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36405
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36405&action=edit
Bug 5786 [QA Followup]

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:04:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:04:38 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-VbowbRPOQJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #115 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Tests OK according to test plan.

Two tests in Circulation.t fail, but that error is already present on master
and has nothing to do with these patches:

t/db_dependent/Circulation.t .. 1/59 
#   Failed test 'userenv set'
#   at t/db_dependent/Circulation.t line 99.
#          got: 'surname'
#     expected: 'MPL'

#   Failed test '_GetCircControlBranch returned current branch'
#   at t/db_dependent/Circulation.t line 108.
#          got: 'surname'
#     expected: 'MPL'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:09:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:09:38 +0000
Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and
 use CT for return branch
In-Reply-To: <bug-12021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12021-70-WqxlcDkM5I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021

--- Comment #8 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
I might be mistaken, but AutomaticItemReturn triggers automatic transfer and
does not alert. Meaning logic to handle return messages/etc. is handled
elsewhere/manually and is not notified by SIP. At least this seems to be the
case. Whether that is good is another question, but changing that would require
another patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:14:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:14:43 +0000
Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add
 items form from header and sidebar
In-Reply-To: <bug-13680-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13680-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13680-70-ZWH6XcHgd9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure yet if I am just 'ew change!' or if it's something else that
bothers me. Still turning this around in my head, not feeling quite ready to
pass QA. 

I'd like to get some more eyes on this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:15:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:15:39 +0000
Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add
 items form from header and sidebar
In-Reply-To: <bug-13680-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13680-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13680-70-cJCzbp3nWH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:25:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:25:23 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-b9asLLsmc3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #50 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
About the tests, my bad: they are not broken in master, BUT these are
db_dependent tests, and as such, they need to be run with a proper database.

This patch allows to create such a database in your environment : 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

With this database on master, the tests run fine.

With this database and my patches, the tests also run fine:

> prove t/db_dependent/Serials_2.t
[...]
All tests successful.
Files=1, Tests=40,  2 wallclock secs ( 0.04 usr  0.00 sys +  1.14 cusr  0.08
csys =  1.26 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:28:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:28:58 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-yHAA2x9hiJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28606|0                           |1
        is obsolete|                            |

--- Comment #3 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Created attachment 36406
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36406&action=edit
Bug 12344 - Multi transport types for issues and checkins

This small patch corrects the order of generating notices for issues and
returns (checkout/checkin) so that borrower's notices are rendered correctly
(for sms,email,etc.)

Test plan:

1) Edit SMSSendDriver syspref to use driver 'Test'
2) Edit CHECKOUT template for sms to 'SMS test'
3) select SMS for test patron's messaging prefs for item checkout
4) checkout an item
5) check the table message_queue, verify that template sms is
   not used (message content is not 'SMS test')

6) apply patch, make new checkout
7) check that message_queue table now has a correctly generated
   notice with 'SMS test'

For a real world test use a real SMS::Send driver and run the
cronjob process-message-queue.pl to send messages immediately.

http://bugs.koha-community.org/show_bug.cgi?id=12344
Signed-off-by: Sophie Meynieux <sophie.meynieux at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:30:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:30:39 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-VBwx0XlBEo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Pierre Angot from comment #9)
> I've tested on sandbox, but there is a software error when we click on items
> tab.
> 
> Software error:
> 
> Template process failed: file error - doc-head-angular.inc: not found at
> /home/koha/src/C4/Templates.pm line 121.
> 
> For help, please send mail to the webmaster (webmaster at test5-sandbox),
> giving this error message and the time and date of the error.
> 
> 
> It seem to be linked to patch 13563.

I believe that must be because you did not apply the two dependencies.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:31:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:31:14 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-zTAxSfOZeE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sophie.meynieux at biblibre.co
                   |                            |m
             Status|Needs Signoff               |Signed Off

--- Comment #4 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Works as described :
- without patch, letter model used is the one for email
- with patch, letter model used is the one for sms

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:31:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:31:54 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-sc6Qd5lpGi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 36407
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36407&action=edit
[Signed-off] Bug 13350 - Untranslatable strings in aqbudgetperiods.tt

This patch fix a few untranslatable strings in aqbudgetperiods.tt.
Style not pretty but work. The section modified is BREADCRUMBS.
This patch adds html tags to be recognized by misc/translator/translate script.

Test plan
---------------
1) Use another language (not English)
2) Go to More > Administration > Budgets. Notice that "> Budgets
administration" is untranslatable in the Navigation section.
3) Try to create a New budget. Notice the same happens as previous step.
4) Try delete, edit, duplicate, and close a budget. The result is the same.
5) Apply the patch.
6) Run perl translate update xx-XX (in my case es-ES)
7) Edit es-ES-i-staff-t-prog-v-3006000.po
8) Get notice that a new lines has been adhered to po file.
9) Run perl translate install es-ES
10) Go to Global system preferences and search for "language" in I18N/L10N
preferences. Enable Espa?ol(es-ES).
11) Follow step 2 and 3 and notice that the strings were translated.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>

Followed test plan. Works as expected.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:32:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:32:21 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-Z1IHCvJxGj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #36004|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:32:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:32:37 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-aCI2xc4ckV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:32:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:32:55 +0000
Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons
In-Reply-To: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11900-70-LUh2P8w45C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|String patch                |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:32:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:32:59 +0000
Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons
In-Reply-To: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11900-70-AHKUGnkxcF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36357|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36408
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36408&action=edit
[PASSED QA] Bug 11900 - OPAC cart can confuse patrons

This patch adds a title tag to the "Cart" link on Opac main page (and to the
"Lists" link as well).

Wording should be verified by a native speaker  :-)

To test:
Apply patch
Go to OPAC main page, verify that a tooltip appears on the "Cart" and "Lists"
links at the top of the page.

Signed-off-by: Nick <nick at quecheelibrary.org>
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, no problems found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:40:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:40:41 +0000
Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to
	OpacAdditionalStyleSheet
In-Reply-To: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10328-70-MAdWcYrGN5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Rename opaccolorstylesheet  |Rename opaccolorstylesheet
                   |to OpacColorStyleSheet      |to OpacAdditionalStyleSheet
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:43:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:43:10 +0000
Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to
	OpacAdditionalStyleSheet
In-Reply-To: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10328-70-hQ97ZryPTK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:43:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:43:15 +0000
Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to
	OpacAdditionalStyleSheet
In-Reply-To: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10328-70-9rmPurqD0y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36172|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36409
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36409&action=edit
[PASSED QA] Bug 10328 - Rename opaccolorstylesheet to OpacAdditionalStylesheet

Test plan (from comment #1)
1) Apply this patch
2) Run updatedatabase.pl
3) Verify the system pref OpacColorStyleSheet still works
   i.e. no change should be noted

Additionally, I changed the path to an other stylesheet and verified that it
worked.

Signed-off-by: Marc V?ron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described and no more occurences of opaccolorstylesheet were found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:47:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:47:41 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-YGb5SAhEre@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

--- Comment #11 from Pierre Angot <tredok.pierre at gmail.com> ---
Yes, you are right ! 

Sorry for the mistake.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:57:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:57:14 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-D26fuftHuP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com
             Status|Needs Signoff               |Signed Off

--- Comment #9 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Koha Team AMU <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:57:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:57:29 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-7JZgHrkW5F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36150|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:57:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:57:34 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-mS859VLXxw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36157|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:57:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:57:45 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-ctbhSRTLfD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

--- Comment #11 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36411
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36411&action=edit
Bug 13740: Fix null vs not null in the query

The previous patch did not work, only patrons *with* guanrantees were
deleted!

Signed-off-by: Koha Team AMU <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 15:57:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 14:57:42 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-4uS9mij8C2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

--- Comment #10 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36410
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36410&action=edit
Bug 13740: Remove the NOT NULL clause in GetBorrowersToExpunge

C4::Borrowers::GetBorrowersToExpunge should not use a "NOT IN", it is
not efficient at all.

With only 1 guarantor and more than 136k patrons, the not in clause in
this subroutine takes ages:
mysql> select count(*) FROM   borrowers where  borrowernumber NOT IN
(SELECT guarantorid FROM borrowers WHERE guarantorid IS NOT NULL AND
guarantorid <> 0) ;
[...]

not ended after 5min

With the query modified by this patch, the results come after 1 sec :)

Test plan:
Verify the delete_patrons.pl cronjob or the cleanborrowers tools work as
before.
Especially with guarantors.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Koha Team AMU <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:02:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:02:14 +0000
Subject: [Koha-bugs] [Bug 13784] New: Koha-stop-zebra should also work for
 disabled instances
Message-ID: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

            Bug ID: 13784
           Summary: Koha-stop-zebra should also work for disabled
                    instances
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larry at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

Patch to come.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:02:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:02:37 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-xVto4MEDL8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |larry at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:07:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:07:43 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-2ah8DFJFZz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:07:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:07:53 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-Fz1BJC0DTe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

--- Comment #1 from Larry Baerveldt <larry at bywatersolutions.com> ---
Created attachment 36412
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36412&action=edit
Koha-stop-zebra should also work for disabled instances

Currently koha-stop-zebra will not stop zebra for disabled instances. It should
work more like koha-stop-sip, which does work for disabled instances. Also,
koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly
should also apply to disabled instances.

To Test:
1) Disable a koha instance.
2) Run koha-stop-zebra INSTANCE. You should get message
   "Instance INSTANCE disabled. No action taken."
3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra
   to package site over /usr/sbin/koha-stop-zebra.
4) Disable koha instance.
5) Run koha-stop-zebra INSTANCE. It should now stop zebra.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:08:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:08:21 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-0qfiuGAN1K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

--- Comment #12 from Koha Team AMU <koha.aixmarseille at gmail.com> ---
Sorry, no problem to apply the patch. Patrons are not deleted if they are
guarantor or if there is a fee. So, ok for the deletion.
About the massive deletion, we tried it on a sandbox, but the import tool was
not efficient. We tried on our server : ok. Even if a message tell us that time
is out, the deletion will end.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:29:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:29:15 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-tje8tJWhOy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Nicole C. Engard from comment #12)
> The newest patch (admin help for 3.18) needs sign off.
> 
> Nicole

On help/admin/branches.tt, it's 'New library' and 'New group', not with
capitalized second word
There are similar cases on the other files, but that predates this bug.

koha-qa complains about tabs, not all of them, only the new ones that you are
introducing :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:31:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:31:22 +0000
Subject: [Koha-bugs] [Bug 13785] New: Koha-disable should also stop SIP and
 zebra for instance
Message-ID: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

            Bug ID: 13785
           Summary: Koha-disable should also stop SIP and zebra for
                    instance
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: larry at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

Patch to come.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:31:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:31:31 +0000
Subject: [Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra
	for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-jF9g9s3fFy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |larry at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:39:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:39:39 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-rupoNVlLBd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13785

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:39:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:39:39 +0000
Subject: [Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra
	for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-1e7u1aMSnS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13784
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:39:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:39:41 +0000
Subject: [Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra
	for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-fBTLBLH46h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

--- Comment #1 from Larry Baerveldt <larry at bywatersolutions.com> ---
Created attachment 36413
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36413&action=edit
Bug 13785 - Koha-disable should also stop SIP and zebra for instance

Currently koha-disable ONLY disables the instance in the apache conf
file. Presumably if you want to disable the instance, you also want
its processes to stop, so this patch will stop zebra, if running,
and SIP, if enabled.

Depends on Bug 13784.

To Test:
1) Have an enabled instance, with zebra and SIP running.
2) Run koha-disable INST. Note that after, both zebra and SIP
   will still be running.
3) Re-enable INST.
4) Apply patch, and then copy debian/scripts/koha-disable to
   package site, over /usr/sbin/koha-disable.
5) Run koha-disable INST. You should now see that both zebra
   and SIP have been stopped.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:51:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:51:14 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-jSzqoOhqlf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com
             Status|Needs Signoff               |Signed Off

--- Comment #18 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Pierre <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:51:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:51:39 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-WhFi4XFKeY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36023|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:51:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:51:43 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-9HtyL3sPIu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36024|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:51:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:51:48 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-0zAatb4OCy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36025|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:51:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:51:53 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-ud6yya1hqw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36390|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:51:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:51:58 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-1TuL1iNBn7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36403|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:52:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:52:07 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-0R8tTXWI48@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #19 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36414
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36414&action=edit
Bug 7843 Create an RSS feed for news in Opac

Test plan:
* Install the patch
* Make shure there is news in the Opac
* Go to the Opac (opac-main.pl)
* Make shure you see an RSS icon below the news and a short text.
* Click the RSS icon and verify that you get an RSS feed that validates.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

I took the liberty of fixing the copyright statement when signing it off

Signed-off-by: Pierre <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:52:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:52:10 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-IIw2U78QiJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #20 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36415
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36415&action=edit
Bug 7843: Remove the useless use of casAuthentication

Certainly a c/p error from opac-main.pl

Signed-off-by: Pierre <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:52:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:52:14 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-LrwU7XCQSU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #21 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36416
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36416&action=edit
Bug 7843: (qa-followup) Create an RSS feed for news in Opac

1/ use strict and warnings are useless, Modern::Perl is used
2/ Prefer to use the interface and theme TT var instead of the hard
coded path

Signed-off-by: Pierre <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:52:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:52:17 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-q6WzVVXiHL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #22 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36417
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36417&action=edit
(follow up) Improve RSS feed language

The RSS button used to read ' RSS for the librarys general newsfeed.'
This included one grammatical error and I think included more words
than most average people would read.  This patch simplifies it to say
'RSS for Library News.'

To test:
* Apply all patches
* Review RSS feed button's text on main page under news

http://bugs.koha-community.org/show_bug.cgi?id=7843

Signed-off-by: Pierre <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:52:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:52:20 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-Ez0Sli6ZYI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #23 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36418
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36418&action=edit
Bug 7843: Followup - fix broken url

This patch fixes an invalid URL when clicking
on RSS feed.

To test:
1) Using Nicole words :)
If you visit : http://mykoha/cgi-bin/koha/opac-main.pl
then the RSS feed works.
If you're on http://mykoha and you click the rss icon you
get : http://mykoha/opac-news-rss.pl which is a 404 page.

2) Apply the patch

3) Repeat 1, error is now fixed

Signed-off-by: Pierre <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:55:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:55:42 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-lM9dgkGoYZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #113 from Brendan Gallagher <brendan at bywatersolutions.com> ---
I'm really itching to get this fixed up and tested this week - while we have
everyone hacking.  We can get some great testing done here and get you the
feedback.  Really important for this week.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 16:59:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 15:59:00 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-3YsNQlhoxy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
FWIW I think Kyle is right, we don't need to create a new table for a 1:1
relationship.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:19:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:19:00 +0000
Subject: [Koha-bugs] [Bug 13774] Add the unique anchors of news as links in
 the RSS for news in Opac
In-Reply-To: <bug-13774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13774-70-05qHUf3ZvQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774

Pierre Angot <tredok.pierre at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tredok.pierre at gmail.com

--- Comment #2 from Pierre Angot <tredok.pierre at gmail.com> ---
I've tested on sandbox.

I've added the RSS on my agregator (Leed). It works correctly, but when I click
on a link, I'm not direct to the opac.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:20:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:20:05 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-Eb8LbIKREI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Starting to work on this today, I'd like to suggest a change:

- Remove the database update and don't force the new report group into existing
installatoins. My reasoning is that when they have serials reports, they will
already have created the REPORT_GROUPS to match their needs and it might be
annoying or even create a duplicate warning if they have used SER as well. And
adding a report group is optional on the saving step.

- Add the new REPORT_GROUP values to the sample data for new installations
instead.

Otherwise this works pretty well and I am almost ready to pass QA :) Setting to
"FQA" to gt Jonathan's attention.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:20:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:20:12 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-hznj0WwNb4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:24:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:24:28 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-2mp5hYGWnH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35666|0                           |1
        is obsolete|                            |

--- Comment #21 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36419
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36419&action=edit
Bug 13159 - Enhancements to the SIP2 command line emulator

I needed to be able to perform checkout operations for testing from the
command line. I ended up reengineering the SIP2 command line tester
quite a bit.

Enhancements:
* Moved message generation code to subroutines
* Added support for more messages
* Added command line switches for each supported message
* Enabled use of Sip::Constants to keep code DRY and more understandable
* Moved script from misc to C4/SIP
* Designed with an eye towards possibly moving some code to CPAN in the future
* Also designed to make adding new messages much easier in the future

Test Plan:
1) Apply this patch
2) Look at help via ./C4/SIP/sip_cli_emulator.pl --help
3) Test patron status request and patron information, should work as before
   except you need to pass the command line switche -m <message_name>
4) Test the new checkout option using -m checkout -i <item barcode>

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Worked as advertised, with one warning at renew only:

Trying 'renew'
Use of uninitialized value $value in concatenation (.) or string at
./sip_cli_emulator.pl line 462, <GEN0> chunk 1.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:24:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:24:56 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-RDpJIFvjd9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36143|0                           |1
        is obsolete|                            |

--- Comment #22 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36420
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36420&action=edit
Bug 13159 [QA Followup] - Fix flag parameters

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:25:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:25:41 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-I3TKgNRN0s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36293|0                           |1
        is obsolete|                            |

--- Comment #23 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36421
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36421&action=edit
Bug 13159 [QA Followup] - Fix changed namespace for Sip::Constants

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:26:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:26:36 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-SDlHxVqJZj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36294|0                           |1
        is obsolete|                            |

--- Comment #24 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36422
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36422&action=edit
Bug 13159 [QA Followup] - Move script back to it's original path

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:27:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:27:07 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-BGJA8tPvDO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

--- Comment #25 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36423
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36423&action=edit
Bug 13159 [QA Followup] - Fix transaction_date and undefined warning

cli-client doesnt respect the transaction_date format
  "YYYYMMDDZZZZHHMMSS"
Using timestamp() to generate the proper datetime format.

"String $value undefined"-warning in build_field() fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:27:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:27:59 +0000
Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour
	customizable
In-Reply-To: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8994-70-8pTBaxjgtz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22465|0                           |1
        is obsolete|                            |

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36424
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36424&action=edit
Bug 8994: Improve FindDuplicateAuthority

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:28:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:28:08 +0000
Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch
 from institution_id field AO
In-Reply-To: <bug-13666-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13666-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13666-70-eF7jxIgb3v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Hi! I would need more information about the use-cases.

> - SIPConfig.xml would not need reconfiguration each time a new client is added

I don't understand how this patch has to do with SIPConfig? There are no such
followups/dependencies for that either.

> - SIP2 connections could fetch from a pool of connections, so e.g. ten SIP2 workers could easily serve hundreds of clients

SIP2 connections are already reused by the Net::Server?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:28:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:28:14 +0000
Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour
	customizable
In-Reply-To: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8994-70-SP1ngiJ7NG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:39:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:39:03 +0000
Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add
 items form from header and sidebar
In-Reply-To: <bug-13680-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13680-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13680-70-sVdYZiGZlf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
I played around with the orignil an d the new version. My conclusion is that
the new version (item list on bottom of the page) would be better.

CSS patch follows as a proposition for formatting the form a little bit to make
it more compact and better readable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:40:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:40:02 +0000
Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add
 items form from header and sidebar
In-Reply-To: <bug-13680-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13680-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13680-70-RVy1ATk0AI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Created attachment 36425
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36425&action=edit
Bug 13680 - Make form on edit items page more compact and better readable

This patch makes the form on the edit items page more compact by decreasing the
label font and indenting properly if a laberl has multiple rows. Additionally,
a thin white line helps the eye to connect a label with the appropriate field.

It is just a proposition regardless whether the form will be displayed above or
below the items table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:47:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:47:21 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-viaLtA1Ig8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36422|0                           |1
        is obsolete|                            |

--- Comment #26 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36426
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36426&action=edit
Bug 13159 [QA Followup] - Move script back to it's original path

Fixed bug in C4/SIP/ILS.pm line 202 as mentioned above.
Tested OK again and setting to Signed Off as it already working before QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:48:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:48:04 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-A0lP8zWyQh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I talked to Kyle earlier about this and I am also in favor of not adding
another table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:50:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:50:14 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-JFo8MzMQWR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36426|0                           |1
        is obsolete|                            |

--- Comment #27 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Comment on attachment 36426
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36426
Bug 13159 [QA Followup] - Move script back to it's original path

patched the wrong bug, silly me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 17:50:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 16:50:45 +0000
Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line
	emulator
In-Reply-To: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13159-70-YjaFswrWy3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36422|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:09:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 17:09:28 +0000
Subject: [Koha-bugs] [Bug 13351] Untranslatable javascript in members.tt
In-Reply-To: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13351-70-hhFzUGhPNH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36386|0                           |1
        is obsolete|                            |

--- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36427
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36427&action=edit
Bug 13351 - Untranslatable javascript in members.tt

This patch streamlines the page title text for search results in Home > Patrons
to make it translateable (and more readable).

To test:
- Apply patch
- Select Englsh language
- Apply filter wit several values or click on a letter for "Browse by last
name"
- Verify that the title makes sense
- Translate to your language and select this language
- Verify that the text appears properly in your language

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:09:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 17:09:58 +0000
Subject: [Koha-bugs] [Bug 13351] Untranslatable javascript in members.tt
In-Reply-To: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13351-70-RgORLCH5ih@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:15:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 17:15:47 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-dVS79lDlmL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Wouldn't it make more sense to make to have koha-disable stop Zebra (if it does
not do that atm)? Why would you have Zebra running for disabled instances and
need to disable it with koha-stop-zebra?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:15:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 17:15:57 +0000
Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for
 checking in items that are not checked out
In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13411-70-RrLt5wHwbp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36310|0                           |1
        is obsolete|                            |

--- Comment #14 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36428
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36428&action=edit
Bug 13411 [QA Followup] - Add logging

Added a fix for bug in C4/SIP/ILS.pm line 202 as described above.

Tested OK. Setting to Signed Off as it works as previously noted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:17:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 17:17:08 +0000
Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for
 checking in items that are not checked out
In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13411-70-bfbEiOuvo5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:17:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 17:17:56 +0000
Subject: [Koha-bugs] [Bug 13769] Barcode showing blank in catalog/null in
	database
In-Reply-To: <bug-13769-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13769-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13769-70-TNLUlOOfrd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13769

Johnathan Cintron <jcintron at hccc.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 18:32:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 17:32:58 +0000
Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature
In-Reply-To: <bug-12461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12461-70-vF8DMJKvSE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
I do not see see the "Patron clubs" link either.

It seems that changes to /prog/en/modules/tools/tools-home.tt are missing. They
were e.g. in Attachment #30456

(Going to the page directly with /cgi-bin/koha/clubs/clubs.pl works)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:23:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 20:23:03 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-4UkFp7tU9C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Failed QA                   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:24:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 20:24:17 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-lhm9RX4J2K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

--- Comment #41 from Mirko Tietgen <mirko at abunchofthings.net> ---
Patch does not apply. I already did half the test plan, I'd continue testing if
you'd rebase it.

Apply? [(y)es, (n)o, (i)nteractive] i
Applying: Bug 10963 - Simplified creation - FA framework
Applying: Bug 10963 - Simplified creation - BKS framework
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging
installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql
CONFLICT (content): Merge conflict in
installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:39:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 20:39:42 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-HF7wMNEfo5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:39:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 20:39:46 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-c7sxvT6b2A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35168|0                           |1
        is obsolete|                            |

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 36429
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36429&action=edit
Bug 13575 - Names do not appear in the Koha history Timeline. This would be a
good addition. The names to be added are: Kahurangi Cormack, Alexander
Cheeseman

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:40:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 20:40:19 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-UyfXURRCZd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
One from one of the Academy students, fixed the conflict, can we just punch
this one through, unless you really need me to shift the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 21:55:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 20:55:36 +0000
Subject: [Koha-bugs] [Bug 13786] New: Strange _AUTHOR_ tag in Relative's
	checkout table
Message-ID: <bug-13786-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13786

            Bug ID: 13786
           Summary: Strange _AUTHOR_ tag in Relative's checkout table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

In relatives issues tabel on Checkout page I get a strange tag _AUHOR_ in Title
Column

Example: 
Wachtmeister Studers erste F?lle : by _AUTHOR_ Glauser

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 22:05:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 21:05:36 +0000
Subject: [Koha-bugs] [Bug 13786] Strange _AUTHOR_ tag in Relative's checkout
	table
In-Reply-To: <bug-13786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13786-70-N4Mszd8n4R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13786

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Seems to be related to following line in
koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc

var BY = _("by _AUTHOR_");

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 22:06:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 21:06:02 +0000
Subject: [Koha-bugs] [Bug 13786] Strange _AUTHOR_ text in Relative's
	checkout table
In-Reply-To: <bug-13786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13786-70-9YdEPxYOJ6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13786

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Strange _AUTHOR_ tag in     |Strange _AUTHOR_ text in
                   |Relative's checkout table   |Relative's checkout table

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 22:11:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 21:11:06 +0000
Subject: [Koha-bugs] [Bug 13786] Strange _AUTHOR_ text in Relative's
	checkout table
In-Reply-To: <bug-13786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13786-70-4mGmnzS0W6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13786

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 36430
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36430&action=edit
Bug 13786 - Strange _AUTHOR_ text in Relative's checkout table

To reproduce:
Go to Home > Circulation > Checkouts > [a patron who has relatives with
checkouts]
Select Tab "Relative's checkouts"
Result: In Title Column the text by _AUTHOR_ appears, e.g. by _AUTHOR_ Glauser,
Friedrich

To test:
Apply patch and refresh
Result: The text _AUTHOR_ no longer appears. The Example above reads by
Glauser, Friedrich

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 22:11:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 21:11:43 +0000
Subject: [Koha-bugs] [Bug 13786] Strange _AUTHOR_ text in Relative's
	checkout table
In-Reply-To: <bug-13786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13786-70-UIePG1VAGY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13786

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 22:21:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 21:21:30 +0000
Subject: [Koha-bugs] [Bug 12459] clicking spent on acq main page not showing
	everything
In-Reply-To: <bug-12459-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12459-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12459-70-3YyJsrVCb4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12459

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagud at orex.es

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:01:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 22:01:26 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-Ff8qUJ1QC1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #33 from simith.doliveira at inlibro.com ---
Created attachment 36431
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36431&action=edit
fix datatables.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:03:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 22:03:12 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-phAmRBqkF7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #34 from simith.doliveira at inlibro.com ---
QA corrected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:11:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 22:11:07 +0000
Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts
In-Reply-To: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13605-70-Z7lMi8SZTd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 13786 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:11:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 22:11:07 +0000
Subject: [Koha-bugs] [Bug 13786] Strange _AUTHOR_ text in Relative's
	checkout table
In-Reply-To: <bug-13786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13786-70-BxtLtaMG35@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13786

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry, I think this is a duplicate - I QA'd the other patch today.

*** This bug has been marked as a duplicate of bug 13605 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar  3 23:26:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 22:26:28 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-T50LT3C3KW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #55 from simith.doliveira at inlibro.com ---
I got that when I ran QA :

 OK    C4/Koha.pm
   OK      pod
   OK      valid
   OK      critic
   OK      forbidden patterns

 OK    admin/authorised_values.pl
   OK      pod
   OK      valid
   OK      critic
   OK      forbidden patterns

 OK    admin/itemtypes.pl
   OK      pod
   OK      forbidden patterns
   OK      valid
   OK      critic

 OK    installer/data/mysql/updatedatabase.pl
   OK      forbidden patterns
   OK      valid
   OK      critic
   OK      pod

 OK    opac/opac-search.pl
   OK      critic
   OK      valid
   OK      forbidden patterns
   OK      pod

 OK    t/db_dependent/Koha.t
   OK      valid
   OK      critic
   OK      forbidden patterns
   OK      pod

 OK    koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
   OK      valid_template
   OK      forbidden patterns
   OK      tt_valid

 OK    koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
   OK      tt_valid
   OK      forbidden patterns
   OK      valid_template


Can anyone else run QA?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 00:18:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 23:18:21 +0000
Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha
In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13696-70-za3A5oEvrH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

--- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36432
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36432&action=edit
Bug 13636  SAMPLE: Add support for Font Awesome icons in Koha

This is just a sample file, not part of the enhancement.
Changing members-toolbar.inc to FontAwesome icons (fixed width).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 00:22:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 23:22:49 +0000
Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha
In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13696-70-DVOxmzLr42@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36432|0                           |1
        is obsolete|                            |

--- Comment #6 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36433
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36433&action=edit
Bug 13636  SAMPLE: Add support for Font Awesome icons in Koha

This is just a sample file, not part of the enhancement.
Changing members-toolbar.inc to FontAwesome icons (fixed width).

http://bugs.koha-community.org/show_bug.cgi?id=13696

Bug 13636  SAMPLE: Add support for Font Awesome icons in Koha
Some more icons changed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 00:28:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 23:28:19 +0000
Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha
In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13696-70-alEwVJl0ks@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35829|0                           |1
        is obsolete|                            |

--- Comment #7 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36434
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36434&action=edit
Bug 13696 - Add support for Font Awesome icons in Koha

Font Awesome is similar to Glyphicons included in Twitter Bootstrap,
except better in every way and more Free.

Test Plan:
1) Apply this patch
2) Edit the template for a page, and add a Font Awesome tag to it,
   examples can be found here:
   http://fortawesome.github.io/Font-Awesome/examples/
3) Reload the page and verify the icon displays.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 00:33:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 23:33:52 +0000
Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha
In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13696-70-yX4f5ZEZc5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Mirko Tietgen <mirko at abunchofthings.net> ---
Patch works as promised. I came across these icons some time ago and wondered
if we could use them in Koha, nice enhancement!

This is not supposed to invalidate Owen's concerns, just confirming that using
the icons on a page works for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 00:58:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 23:58:07 +0000
Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password
In-Reply-To: <bug-13143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13143-70-ABYN1EW0SO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33962|0                           |1
        is obsolete|                            |

--- Comment #17 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36435
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36435&action=edit
Bug 13143: Followup - Correct the pause message

'read anykey' actually requires enter under sh.
This patch changes the string from:
    'Press any key to clear the screen...'
to
    'Press enter to clear the screen...'

TEST PLAN
---------
1) Apply the first two patches
2) Trigger the script.
2) Press 'q' or anything other than enter when prompted.
   --- You could type a whole sentence! Oops!
3) Press enter.
4) Apply this patch
5) Trigger the script.
6) Be happy that you aren't told any key will work.
7) run koha qa tools

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

http://bugs.koha-community.org/show_bug.cgi?id=13141

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 00:58:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Mar 2015 23:58:30 +0000
Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password
In-Reply-To: <bug-13143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13143-70-kqcgyxOqVm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 01:30:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 00:30:04 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-rOR9BrjQx5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #116 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
(In reply to Benjamin Rokseth from comment #115)
> Tests OK according to test plan.
> 
> Two tests in Circulation.t fail, but that error is already present on master
> and has nothing to do with these patches:

Yes, I have fixed that elsewhere, will submit a bug/patch shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 01:42:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 00:42:10 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-QMkvw3xPjd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

--- Comment #13 from David Cook <dcook at prosentient.com.au> ---
I'm going to take another look at this bug when I have a chance. Tempted to
break this into 2 separate bugs as well... one for the HTML and one for the
UTF-8 stuff.

A lot of the code around Notices && Slips could use a good refactoring... :/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 02:06:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 01:06:58 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-okOab2qqHD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #24 from David Cook <dcook at prosentient.com.au> ---
I'm just wrapping up a local project on using OpenID Connect, which is
basically a wrapper around OAuth2.0 with a few extras thrown in on top, so I'd
be interested in taking a look at this at some point.

Could we look at making this more extensible though? There are lots of other
OAuth2.0 providers than just Google. 

Have yo looked at
http://search.cpan.org/~kgrennan/Net-OAuth2-0.06/lib/Net/OAuth2.pm? I believe
Chris Cormack took a look at that recently.

Anywho, I could be interested in testing this out down the road!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 02:12:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 01:12:34 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-u40KbGjZyy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #25 from David Cook <dcook at prosentient.com.au> ---
Hmm, it might be a better idea to add a parameter instead of using the $persona
parameter in C4::Auth::checkauth().

C4::Auth needs a clean-up in general... which Martin (ashimema) is working on,
I believe.

In any case, locally I added a $external_authen hashref as a parameter after
$persona. I use $external_authen->{OpenIDConnect} to store the data I need to
pass to checkauth(), add some handling in the appropriate spots, and that's it.

You might want to look at RFC 6749 (OAuth 2.0)
http://tools.ietf.org/html/rfc6749 as well, as it might give you some more
information.

OpenID Connect has a lot of validation steps, which may or may not also exist
in OAuth2.0... not sure.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 02:41:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 01:41:16 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-VJupHGvWsP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

--- Comment #3 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Mirko Tietgen from comment #2)
> Wouldn't it make more sense to make to have koha-disable stop Zebra (if it
> does not do that atm)? Why would you have Zebra running for disabled
> instances and need to disable it with koha-stop-zebra?

You are correct, but there's also no reason to have it not work if it could be
useful in some weird circumstance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 02:41:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 01:41:20 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-my82YOjKPL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #26 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to David Cook from comment #25)
> Hmm, it might be a better idea to add a parameter instead of using the
> $persona parameter in C4::Auth::checkauth().

I would think the parameter would be better renamed to $AuthenticatedEmail,
because persona and this OAuth patch both authenticate against an Email address
(the primary email address is used to find the user).


> C4::Auth needs a clean-up in general... which Martin (ashimema) is working
> on, I believe.

True, it does need clean-up.


> In any case, locally I added a $external_authen hashref as a parameter after
> $persona. I use $external_authen->{OpenIDConnect} to store the data I need
> to pass to checkauth(), add some handling in the appropriate spots, and
> that's it.

NOOOOOO! Please hashref the parameter!
If there are more than 3 parameters, you probably should use a hashref.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 03:01:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 02:01:39 +0000
Subject: [Koha-bugs] [Bug 13787] New: Clean up noisy koha qa tool warnings
Message-ID: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

            Bug ID: 13787
           Summary: Clean up noisy koha qa tool warnings
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: mtompset at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

While testing bug 10937, there were noisy warnings, which
distracted from testing the functionality of it.

Here is a snippet of the after the patch warnings:
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 384.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.

Tweaking the [% IF %] statements eliminated the warnings.

TEST PLAN
---------
1) Apply patch
2) Run koha qa test tools.
   -- there will be noisy warnings in the before processing, but
      there will be no such messages in the after processing.
3) git diff origin/master
   -- there should be no visible typos.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 03:02:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 02:02:33 +0000
Subject: [Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
In-Reply-To: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13787-70-PpIVn3eWWK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 03:02:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 02:02:36 +0000
Subject: [Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
In-Reply-To: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13787-70-7Ivi5twpaX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36436
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36436&action=edit
Bug 13787 - Clean up noisy opac-advsearch warnings

While testing bug 10937, there were noisy warnings, which
distracted from testing the functionality of it.

Here is a snippet of the after the patch warnings:
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 384.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.

Tweaking the [% IF %] statements eliminated the warnings.

TEST PLAN
---------
1) Apply patch
2) Run koha qa test tools.
   -- there will be noisy warnings in the before processing, but
      there will be no such messages in the after processing.
3) git diff origin/master
   -- there should be no visible typos.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 03:02:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 02:02:56 +0000
Subject: [Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
In-Reply-To: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13787-70-rq5M1v3zX2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |mtompset at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 03:37:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 02:37:38 +0000
Subject: [Koha-bugs] [Bug 13788] New: Checked out On Date Appears without
	Time
Message-ID: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

            Bug ID: 13788
           Summary: Checked out On Date Appears without Time
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: rizwan.ahmed at 1campusconsulting.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 36437
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36437&action=edit
KOHA - Check Out On Time Missing

The staff has checked out a book but the system did not show time in field
"Checked Out On"; it is only displaying date for the recent item. For previous
checked out items, the system is displaying both date and time in the field
"Checked Out On". What could be the reason of this error ? How we can fix it ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 03:43:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 02:43:11 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-OGi1F3HUJI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #27 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
(In reply to David Cook from comment #24)
> I'm just wrapping up a local project on using OpenID Connect, which is
> basically a wrapper around OAuth2.0 with a few extras thrown in on top, so
> I'd be interested in taking a look at this at some point.
> 
> Could we look at making this more extensible though? There are lots of other
> OAuth2.0 providers than just Google. 
> 
> Have yo looked at
> http://search.cpan.org/~kgrennan/Net-OAuth2-0.06/lib/Net/OAuth2.pm? I
> believe Chris Cormack took a look at that recently.
> 
> Anywho, I could be interested in testing this out down the road!

Hi David,

I like the idea of making it more extensible, and when I get a chance (probably
in a few weeks from now) I'll see about checking out OAuth2.pm . Since we run
Google Apps for Education for our students (at library.pbc.wa.edu.au), Google's
oauth2 was our priority. It's been quite a while since I wrote this, but I
think google has some google-specific functionality available - like the hd
parameter. (Actually, the hd parameter isn't all that useful for us, seeing as
it doesn't seem to like subdomains)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 03:53:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 02:53:36 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-UajJidnyAi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

Rizwan <rizwan.ahmed at 1campusconsulting.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |critical
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:19:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 08:19:02 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-OITjsddzYr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

--- Comment #4 from Larry Baerveldt <larry at bywatersolutions.com> ---
It's not even that weird of a situation. We often need to temporarily block
access to a site for both the public catalog and the staff client (such as when
performing maintenance, or other actions where we wouldn't want the database to
be touched), and disabling the instance is the fastest way to do that, and
still present a "maintenance" page to the user. Unless you remember to stop
zebra manually first, then if you have already disabled the instance, then you
*can't* stop zebra without just killing the processes. This patch addresses
that.

Also, I did just submit a patch for koha-disable to stop zebra (and SIP) (see
13785). However, for that patch to work, this one first has to be pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:28:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 08:28:08 +0000
Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores
In-Reply-To: <bug-11368-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11368-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11368-70-KPdYBaZrAy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28092|0                           |1
        is obsolete|                            |

--- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36438
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36438&action=edit
Bug 11368 - Add script to import Lexile scores

Koha needs a script to automate the importing of Lexile score data for
titles that have available scores but are not currently in the title's
record.

This script will take a CSV file of Lexile scores, and locate any
matching records in the Koha database ( by ISBN ). If the record already
has a score, it will be updated. If not, the Lexile score field will be
created.

Test Plan:
1) Apply this patch
2) Catalog a record for each of the following ISBNs:
   0789170191
   9780673779410
3) Download the file LexileTitlesTruncated.txt attached
   to this bug report
4) Run the script from the command line:
   ./misc/migraction_tools/import_lexile.pl -v --file
/path/to/LexileTitlesTruncated.txt
5) View those records in Koha
6) Note those records now have valid Lexile scores
7) Edit the Lexile score ( 521$a ) and change the value to something else
8) Repeat step 4
9) Note the original Lexile score has been restored

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:28:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 08:28:47 +0000
Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores
In-Reply-To: <bug-11368-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11368-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11368-70-dFsveXnI8o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:31:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 08:31:12 +0000
Subject: [Koha-bugs] [Bug 13611] Serial enumeration not visible in the
 opac-user.pl when browsing own holds.
In-Reply-To: <bug-13611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13611-70-Z0E8h0LVai@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:31:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 08:31:17 +0000
Subject: [Koha-bugs] [Bug 13611] Serial enumeration not visible in the
 opac-user.pl when browsing own holds.
In-Reply-To: <bug-13611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13611-70-CmXu9gHIc9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36279|0                           |1
        is obsolete|                            |

--- Comment #5 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36439
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36439&action=edit
Bug 13611 - Serial enumeration not visible in the opac-user.pl when browsing
own holds.

Having placed holds on Serial Items with an enumchron, and browsing the
opac-user.pl's "Holds"-tab, the user cannot see which numbers of
magazines/serials he has on hold.

This patch appends the koha.items.enumchron after the title component in the
opac-user.pl's Holds-view.

Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:42:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 08:42:39 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-38dzbQ2YEK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

--- Comment #5 from Robin Sheat <robin at catalyst.net.nz> ---
Well the idea being that if koha-disable stops zebra, then zebra still running
would be a weird situation :)

I'm quite happy with all these patches, all going well I'll have a real look at
them tomorrow and get them through.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 09:55:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 08:55:25 +0000
Subject: [Koha-bugs] [Bug 13789] New: facets with accented utf-8 characters
 generate double encoded links
Message-ID: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

            Bug ID: 13789
           Summary: facets with accented utf-8 characters generate double
                    encoded links
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: dpavlin at rot13.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 10:01:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 09:01:36 +0000
Subject: [Koha-bugs] [Bug 3] mod_env module checking in installer.pl
In-Reply-To: <bug-3-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3-70-K8l6uhWKnQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3

--- Comment #1 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36440
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36440&action=edit
Bug 13744: Fix datatables paging on 'Holds to pull' report

The paging of the datatables on the 'holds to pull' report
page is broken without this patch.

To test:
- Make sure that some holds are placed on available items
  in your installation
- Go to the circulation start page
- Open the 'holds to pull' report
- Verify that the patch fixes the paging on the result table

Also: Fixes "None" in the filter pull downs to be translatable.
Signed-off-by: Nicole <nicole at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 10:04:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 09:04:08 +0000
Subject: [Koha-bugs] [Bug 13774] Add the unique anchors of news as links in
 the RSS for news in Opac
In-Reply-To: <bug-13774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13774-70-EeoSxYrUCs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 10:08:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 09:08:35 +0000
Subject: [Koha-bugs] [Bug 13790] New: Add unique id issue_id to issues and
 oldissues tables
Message-ID: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

            Bug ID: 13790
           Summary: Add unique id issue_id to issues and oldissues tables
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 10:30:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 09:30:06 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	oldissues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-zMJQCusThq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 10:30:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 09:30:10 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	oldissues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-oUYSua5lVV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36441
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36441&action=edit
Bug 13790 - Add unique id issue_id to issues and old_issues tables

Test Plan:
1) Use a database with existing issues and old issues
2) Apply this patch
3) Run updatedatabase
4) Inspect the database
   a) old_issues should now have a column issue_id starting with 1
   b) issues should now have a column issue_id starting with the number
      of rows in the old_issues table plus one

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 10:30:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 09:30:59 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	oldissues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-lVrpIoNXeV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36442
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36442&action=edit
Bug 13790 - Update Koha Schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 10:55:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 09:55:45 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-R2a7PeqBbZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Marijana Glavica <mglavica at ffzg.hr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mglavica at ffzg.hr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:03:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:03:23 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-tabvsxiZ0F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #6 from Nicole C. Engard <nengard at gmail.com> ---
I want to sign off on this - but can only test the staff client part of things.
 Everything there works great!! Maybe someone else could test the long over due
cron part?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:04:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:04:55 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-4kIld0ifoF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11944
           Assignee|gmcharlt at gmail.com          |dpavlin at rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:04:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:04:55 +0000
Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11944-70-ORQj9XtFsD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13789

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:05:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:05:59 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-5JlwiAkfeP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13425

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:05:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:05:59 +0000
Subject: [Koha-bugs] [Bug 13425] There is an xss vulnerability in 3.16,
 3.18 and master in the opac and intranet facets
In-Reply-To: <bug-13425-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13425-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13425-70-t83fACC6rI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13425

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13789

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:09:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:09:25 +0000
Subject: [Koha-bugs] [Bug 13791] New: Plack out of the box
Message-ID: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

            Bug ID: 13791
           Summary: Plack out of the box
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: dpavlin at rot13.org
        QA Contact: testopia at bugs.koha-community.org

Offer plack as valid alternative for installation.

For now, some progress is documented at wiki page:

http://wiki.koha-community.org/wiki/Plack

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:26:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:26:38 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-KDhXWkWCcT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:26:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:26:49 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-mg7cNVaq2B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36429|0                           |1
        is obsolete|                            |

--- Comment #6 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36443
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36443&action=edit
Bug 13575 - Names do not appear in the Koha history Timeline. This would be a
good addition. The names to be added are: Kahurangi Cormack, Alexander
Cheeseman

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:32:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:32:51 +0000
Subject: [Koha-bugs] [Bug 13792] New: Impossibility to pay a fee
Message-ID: <bug-13792-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13792

            Bug ID: 13792
           Summary: Impossibility to pay a fee
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jcasier at ville-roubaix.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

I'm working on the master version of    3.19.00.012
I create a patron in a category with enrolment fee to pay
I try to pay it clicking on "Make payment" / Pay amount / confirm
The Fees & Charges doesn't deseapear. 

I tried the same on the 3.18.03.000 version of Koha, I don't have the problem

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:33:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:33:19 +0000
Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines
In-Reply-To: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11430-70-aDXtqebNTj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33835|0                           |1
        is obsolete|                            |

--- Comment #74 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36444
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36444&action=edit
Bug 11430: DB changes: Add the primary key for search_history

Adds a primary key search_history.id.

Signed-off-by: sonia BOUIS <sonia.bouis at univ-lyon3.fr>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:33:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:33:38 +0000
Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines
In-Reply-To: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11430-70-rxPu8AN3wh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

--- Comment #75 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
patch rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:36:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:36:38 +0000
Subject: [Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron
 changes to a category with enrolment fee
In-Reply-To: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13697-70-X5JQ7wavrw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697

Juliane <jcasier at ville-roubaix.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |jcasier at ville-roubaix.fr

--- Comment #5 from Juliane <jcasier at ville-roubaix.fr> ---
Ok, tested and it works. 

Case 1 tested: the patron has already a category with enrolment fee, I change
it to another category with enrolment fee, the patron has no enrolment fee to
pay 

Case 2 tested : the patron has a free category , I change it to a category with
enrolment fee, the patron has no enrolment fee to pay



Howether, I created the 13792 bugzilla : testing make me realise a bug about
payment on fees on the master version of koha (not linked to this patch)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:42:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:42:03 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-dAuGQI5mAJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

--- Comment #1 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36445
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36445&action=edit
Bug 13789 - facets with accented utf-8 characters generate double encoded links

Bug 13425 tried to fix XSS in OPAC, but as result it double encoded strings
in facets and made links with accented characters (which where encoded
by url filter) broken.

This is just a test commit to see wheater removing url filter fixes this
(it does), but it also re-introduces XSS bug so it's not ready for signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:45:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:45:09 +0000
Subject: [Koha-bugs] [Bug 13791] Plack out of the box
In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13791-70-UgaVUMh9D0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:46:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:46:18 +0000
Subject: [Koha-bugs] [Bug 13792] Impossibility to pay a fee
In-Reply-To: <bug-13792-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13792-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13792-70-13UskpdktR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13792

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:49:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:49:06 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-h55j7gFzKS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34221|0                           |1
        is obsolete|                            |

--- Comment #51 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36446
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36446&action=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:49:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:49:27 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-v6mMO6qNkn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #52 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
patch rebased for updatedatabase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:50:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:50:01 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-eeGeuoKj7k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36443|0                           |1
        is obsolete|                            |

--- Comment #7 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36447
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36447&action=edit
Bug 13575 - Names do not appear in the Koha history Timeline. This would be a
good addition. The names to be added are: Kahurangi Cormack, Alexander
Cheeseman

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:50:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:50:46 +0000
Subject: [Koha-bugs] [Bug 13793] New: The installer does not output the
 result of the update using Plack
Message-ID: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

            Bug ID: 13793
           Summary: The installer does not output the result of the update
                    using Plack
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Under Plack, the installer does not output the result of the update.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:51:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:51:25 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-Yki61PTVVe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13791

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:51:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:51:25 +0000
Subject: [Koha-bugs] [Bug 13791] Plack out of the box
In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13791-70-dmDjLIvHgY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13793

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:57:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:57:55 +0000
Subject: [Koha-bugs] [Bug 9897] members/member.pl double encoded utf-8
	strings
In-Reply-To: <bug-9897-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9897-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9897-70-xvAkW9uk6V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9897

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
This bug was fixed by subsequent code changes so no need to keep it open.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:58:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:58:27 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-75ccWBFg9f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36446|0                           |1
        is obsolete|                            |

--- Comment #53 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36448
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36448&action=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:59:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:59:36 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-SLKuLm1kQS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36448|0                           |1
        is obsolete|                            |

--- Comment #54 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36449
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36449&action=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:59:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:59:45 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-opnZVKC4AH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34220|0                           |1
        is obsolete|                            |

--- Comment #55 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36450
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36450&action=edit
Bug 7677: UT: add unit tests for GetPreviousSerialid

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 11:59:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 10:59:51 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-9Risi4asoX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34222|0                           |1
        is obsolete|                            |

--- Comment #56 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36451
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36451&action=edit
Bug 7677: FIX QA issues

FAIL    C4/Serials.pm
   FAIL      forbidden patterns
    forbidden pattern: trailing space char (line 1501)
    forbidden pattern: trailing space char (line 921)

 FAIL    serials/serials-edit.pl
   FAIL      valid
        "my" variable $dbh masks earlier declaration in same scope

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:00:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:00:05 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-W46glgtT1z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34665|0                           |1
        is obsolete|                            |

--- Comment #57 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36452
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36452&action=edit
Bug 7677: Fix tests

They don't pass since bug 12098 has been pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:00:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:00:12 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-LAokQpTe43@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36389|0                           |1
        is obsolete|                            |

--- Comment #58 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36453
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36453&action=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Fix missing itemtype and previous itemtype when adding a subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:03:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:03:46 +0000
Subject: [Koha-bugs] [Bug 13791] Plack out of the box
In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13791-70-ox6eMvGcpv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:03:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:03:49 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-PrRiBqCOp5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:03:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:03:52 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-ZD0V4yVeVI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36454
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36454&action=edit
Bug 13793: Make the installer output the result of the updates under Plack

Test plan:
0/ Start plack for intranet
1/ Create a new entry in updatedatabase.pl, something like:

$DBversion = "3.19.00.013";
if(CheckVersion($DBversion)) {
    print "Upgrade to $DBversion done (Bug test plack - This is a
est)\n";
    print "Upgrade to $DBversion done (Bug test plack - This is anoter
est)\n";
    print "Upgrade to $DBversion done (Bug test plack - This is a third
est)\n";
    warn "this is an error";
}
and modify the kohaversion.pl accordingly.
You can also warn something to simulate an error.
2/ Go on the mainpage (or wherever you want), you should be redirected
to the installer
3/ Notice that the output of the updatedatabase is displayed on the
screen.
4/ Confirm that new files have been created in your Koha log directory
(check the logdir entry in your koha conf file).
5/ Confirm that the output is still displayed without Plack.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:11:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:11:01 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-HdhnkfMwit@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #72 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 36455
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36455&action=edit
Bug 11559 followup - a number of small UI bugfixes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:12:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:12:20 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-rgwY0xT92c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #56 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Looks good to me too.
Kyle could you run perl -wc Koha.pm and tell us what is the error/warning?
It's certainly related to the perl version (5.20 here).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:14:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:14:02 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-0oVJl65hyA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #73 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Notes: All settings, including switching between the basic editor and Rancor,
are saved per-user as local settings. This means they should be completely
separated by user (though not private). Also, the [@number] markings are just
an artifact of the software used to prepare this.

The individual parts of this test plan should be separately testable; please
test what you can!

1. Apply patch.

*** Part 1 - Navigating to editor
2. [@2] Go to the Cataloging section.
3. Click on "Advanced editor." This should take you to Rancor with an empty
record loaded.
4. Click on "Settings" -> "Switch to basic editor," then "OK." This should
switch to the basic editor with an empty record.
5. Click on "Switch to advanced editor." This should take you back to Rancor.
6. Navigate to a record, and click "Edit" -> "Edit record." This should load
the record in Rancor.
7. Verify that clicking on "(view)" and "(edit items)" go to the correct
screens for the current record (in a new window).
8. Click "Settings" -> "Switch to basic editor," then repeat. This should now
load in the basic editor. Click "Switch to advanced editor" for the following
steps.
9. Go back to the Cataloging home page.
10. Click on "New from Z39.50/SRU," run a Z39.50 search (doesn't matter what
for) and click "Import." This should open in the basic editor; the old-style
Z39.50 search interface is separate from that built into Rancor.
*** Part 2 - Editing records 
11. [@11] Return back to a new record in Rancor.
12. Verify that the data portion non-control fields (>010) can be freely typed
into. Typing a dollar sign, alphanumeric and a space should create a new
subfield. For known MARC subfields, the description of the current field (and
subfield) should be shown in the status bar at the bottom.
13. The data portion of control fields, tag numbers and indicators should be
editable, but in overwrite mode. If a syntactically incorrect MARC tag is
entered, the entire line should lose any other highlighting and turn red.
14. For known fixed fields (currently only MARC21 leader or 000, 005 and 008),
the data portion of the field should be displayed as a widget, with underlined
portions that expand into text fields/dropdowns for the various coded parts of
the field. These widgets are toggleable in the settings.
15. Subfields with authorized values attached to them should also be displayed
as simple, single-dropdown widgets.
16. It should be possible to tab between the tag number, indicators, each
subfield and each element in a fixed field widget. Typing values for these
fields should work as expected.
17. By pressing Enter anywhere in a field, the cursor should be moved to a new
field on the next line.
18. After typing in the number of a tag, pressing Tab should tab through and
automatically create the indicator positions.
19. By pressing Ctrl-X, the entire field should be deleted.

*** Part 3 - Record Import/Export
20. [@20] By entering text into any of the given fields on the left, a search
will be run with the given search field and contents (and none of the others).
Verify that they can be focused with their listed keyboard shortcuts.
21. Click on the checkboxes next to any of the available search targets to
enable/disable that target.
22. Click on the arrows above any column to resort the results by that column.
Sorting defaults to title. NOTE: performance of the above will be severely
degraded if Koha::Cache is not running in memcached/fastmmap mode.
23. Click on "View MARC" to show a preview of the record contents, and "Hide
MARC" to return to the original view.
24. Click on "Import", and the record contents should be replaced with that of
the selected record.
25. Click on "Advanced" in the search box on the left.
26. Check or uncheck any of the servers to enable/disable them before the
search. The search query will be ANDed together from any non-empty fields.
27. Verify that advanced search behaves similarly to a quick search after
results are returned.
28. Open an existing catalog record in Rancor.
29. Perform a search, and verify that "Substitute" copies the record contents
into the current catalog record, while "Import" starts editing a new record.
30. Verify that "Save" correctly saves record contents to the catalog.
31. Click on the dropdown next to "Save to catalog," then either "Save as
ISO2709 (.mrc) file" or "Save as MARCXML (.xml) file." Click "Save file" (or
your browser's equivalent), then verify that the exported record's contents are
correct.
32. Click on "Import record", then any ISO-2709 (.mrc) or MARC-XML (.xml)
record. The record contents should be loaded.

*** Part 4 - Settings/Macros
33. [@33] The "Settings" menu contains several font configuration options.
Verify that they all work as expected (some fonts may not exist on your
system).
34. Click on "Macros." This should bring up a screen with no existing macros.
35. Click "New macro..." and type in a name for the new macro. It should be
added to the list on the side.
36. The format dropdown exists to allow compatibility with a proprietary vendor
format; the default of Rancor should be sufficient.
37. Type any text into the macro editor, and it should be autosaved after a
brief delay.
38. Hit "Delete macro" to delete this macro.
39. Create a new macro, insert some text, wait for it to autosave, then reload
the page to verify that the macro contents are saved.
40. Enter in some test macros, and verify that they work as expected. There are
a number of possible macro commands, but all are variants of two basic forms:
    - delete TARGET :: Deletes the given TARGET.
    - TARGET=SOURCE :: Copies the contents of SOURCE into TARGET (spaces around
the equals sign are not allowed for reasons of ambiguity in fixed fields).
41. The possible targets are (specific tags/subfields are used, but only as
examples):
    - 001 :: The entire contents of a control field (will be created if
needed).
    - 245 :: The entire contents of the first 245 field (will be created if
needed).
    - new 245 :: The entire contents of a new 245 field, inserted in numerical
order.
    - new 245 grouped :: The entire contents of a new 245 field, inserted at
the end of the 200s.
    - 245a OR 245a at end :: The contents of the $a subfield of the first 245
field (will be created at the end of the field if needed).
    - 245a after c :: The contents of the 245 $a subfield (will be created
after the $c subfield if needed).
    - new 245a OR new 245a at end OR new 245a after c :: The contents of a new
245 $a subfield in the given position.
    - $a :: The contents of the $a subfield of the last mentioned tag.
    - 245 indicators OR indicators :: Sets both indicators of either the first
field with the given tag or the last mentioned tag. 
42. The possible sources are:
    - 001 OR 245 :: The entire contents of the first field with the given tag.
    - 245a :: The contents of the first $a subfield of the first 245 field.
43. Some example commands:
    - new 245=$a Charlotte's Web /$c by E.B. White.
    - delete 245c
    - 003=ByWater
44. Verify that entering a syntactically correct macro and hitting "Run macro"
closes the macro editor and runs the given macro.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:15:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:15:12 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-tMUKdyuaow@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #74 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Addendum to the above, part 2; Ctrl-D should insert the subfield delimiter
(currently somewhat hardcoded as $).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:16:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:16:23 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-B2ETdbS03h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36375|0                           |1
        is obsolete|                            |

--- Comment #14 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 36456
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36456&action=edit
Bug 13771: Add admin help files for 3.18

This patch adds a new help file for column settings and updates the
files for budgets, funds, libraries, patron categories, and circ rules.

To test:

* Visit the above listed admin pages
* Review help files

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:19:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:19:04 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-MV5wG1m5jn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36456|Bug 13771: Add admin help   |[SIGNED OFF] Bug 13771: Add
        description|files for 3.18              |admin help files for 3.18

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:19:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:19:17 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-9Xg0yvgfA6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:24:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:24:13 +0000
Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new
	search
In-Reply-To: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12460-70-ZLkBZoSMJU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire.hernandez at biblibre.c
                   |                            |om

--- Comment #7 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> ---
To add in test plan:
Enable syspref EnableSearchHistory before testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:28:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:28:17 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-0f12oW3aV1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:28:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:28:25 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-FRjY1AooZH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35301|0                           |1
        is obsolete|                            |

--- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36457
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36457&action=edit
Bug 5338: Add "Serials" to the report group list

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:28:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:28:40 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-jNWcwfzZk1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

--- Comment #29 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36458
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36458&action=edit
Bug 5338: Use insert ignore to avoid a warning if 'SER' already exists

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:28:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:28:48 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-Dbe0LoGTxG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

--- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36459
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36459&action=edit
Bug 5338: Add the "SER" report group for all languages.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:29:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:29:28 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-VniAkaDVti@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

--- Comment #31 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #27)
> - Remove the database update and don't force the new report group into
> existing installatoins. My reasoning is that when they have serials reports,
> they will already have created the REPORT_GROUPS to match their needs and it
> might be annoying or even create a duplicate warning if they have used SER
> as well. And adding a report group is optional on the saving step.

Compromise found using insert ignore :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:58:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:58:36 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-n2bxboZ9bC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27056|0                           |1
        is obsolete|                            |

--- Comment #42 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36460
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36460&action=edit
Bug 10963: Simplified creation - FA framework

Patch 1/9

This patch modifies Fast Add framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:58:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:58:46 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-ZWIsy2262t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27057|0                           |1
        is obsolete|                            |

--- Comment #43 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36461
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36461&action=edit
Bug 10963: Simplified creation - BKS framework

Patch 2/9

This patch rewrites BKS framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:58:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:58:57 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-XW0OrXFsTq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27058|0                           |1
        is obsolete|                            |

--- Comment #44 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36462
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36462&action=edit
Bug 10963: Simplified creation - CF framework

Patch 3/9

This patch rewrites CF framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:59:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:59:13 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-TWAzosj6N2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27059|0                           |1
        is obsolete|                            |

--- Comment #45 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36463
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36463&action=edit
Bug 10963: Simplified creation - SR framework

Patch 4/9

This patch rewrites SR framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:59:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:59:28 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-uaXgnBTNl1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27060|0                           |1
        is obsolete|                            |

--- Comment #46 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36464
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36464&action=edit
Bug 10963: Simplified creation - VR framework

Patch 5/9

This patch rewrites VR framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:59:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:59:44 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-wqSrG0KefA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27061|0                           |1
        is obsolete|                            |

--- Comment #47 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36465
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36465&action=edit
Bug 10963: Simplified creation - AR framework

Patch 6/9

This patch rewrites AR framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 12:59:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 11:59:54 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-SSSzeByz02@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27062|0                           |1
        is obsolete|                            |

--- Comment #48 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36466
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36466&action=edit
Bug 10963: Simplified creation - KT framework

Patch 7/9

This patch rewrites KT framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:00:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:00:06 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-4fRyj4iJeV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27063|0                           |1
        is obsolete|                            |

--- Comment #49 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36467
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36467&action=edit
Bug 10963: Simplified creation - IR framework

Patch 8/9

This patch rewrites IR framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:00:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:00:19 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-DaRkmeDAU0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27064|0                           |1
        is obsolete|                            |

--- Comment #50 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36468
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36468&action=edit
Bug 10963: Simplified creation - SER framework

Patch 9/9

This patch rewrites SER framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:00:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:00:29 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-xDrINcAOSr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27065|0                           |1
        is obsolete|                            |

--- Comment #51 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36469
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36469&action=edit
Bug 10963: Revert old hidden values

This patch reverts old hidden values to marc_subfield_structure.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:02:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:02:18 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-PrTy8lmZdz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #52 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Mirko Tietgen from comment #41)
> Patch does not apply. I already did half the test plan, I'd continue testing
> if you'd rebase it.
> 

Patches rebased, Thanks for testing!!
Test on Comment #26 still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:02:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:02:29 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-EXewuVm7N7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:02:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:02:33 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-pictss96BW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #22 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36470
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36470&action=edit
[SIGNED-OFF] Small improvements for the availability informations in the search
results list on the OPAC.

http://bugs.koha-community.org/show_bug.cgi?id=11881
Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:35:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:35:22 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-fvdti8cXjd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:43:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:43:32 +0000
Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes
In-Reply-To: <bug-13487-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13487-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13487-70-gJcXcmoJNn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13744

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:43:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:43:32 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-Ce6yaodhXy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13487
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:47:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:47:40 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house uses
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-hMAQBKUFB3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31666|0                           |1
        is obsolete|                            |

--- Comment #13 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36471
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36471&action=edit
[SIGNED-OFF] Bug 11201: Add a in-house use list pages

The circulation page has a new entry: a link to a list of the pending
in-house use.

Bug 10860 introduces a new way for managing in-house uses.
This patch adds a new page (from the circulation home page) to list all
pending in-house uses.

Test plan:
Go on the circulation home page and click on the in-house use link.
Verify all your in-house uses are listed and information are consistent.

Bug 11201: Display lib instead of AV code

This patch assumes that items.location is linked the the LOC
authorised values.

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:49:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:49:35 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-DEKSKR6HUZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:49:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:49:38 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-PCz8OVTbDD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36381|0                           |1
        is obsolete|                            |
  Attachment #36382|0                           |1
        is obsolete|                            |
  Attachment #36385|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36472
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36472&action=edit
Bug 13744: Fix datatables paging on 'order from subscription' page

The paging of the datatable on the 'order from subscription' page
is broken without this patch.

To test:
- Make sure you have a subscription, note the vendor
- Create a new basket for this vendor
- Add a new order line 'from a subscription'
- Check paging on the result table displays correctly

Signed-off-by: Nicole <nicole at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:50:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:50:29 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-2lqSH6itHG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36473
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36473&action=edit
Bug 13744: Fix datatables paging on 'checkout history' page

The paging in the datatable on the 'circulation history' page
is broken without this patch.

/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=...

To test:
- Search for a record with items that have been checked out
  in the past
- From the detail page, open the 'checkout history' tab
- Check paging displays correctly with this patch and is
  broken without

Signed-off-by: Nicole <nicole at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:50:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:50:34 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-YnGKrkUmrp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36474
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36474&action=edit
Bug 13744: Fix datatables paging on 'Holds to pull' report

The paging of the datatables on the 'holds to pull' report
page is broken without this patch.

To test:
- Make sure that some holds are placed on available items
  in your installation
- Go to the circulation start page
- Open the 'holds to pull' report
- Verify that the patch fixes the paging on the result table

Also: Fixes "None" in the filter pull downs to be translatable.
Signed-off-by: Nicole <nicole at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:50:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:50:56 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house uses
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-jVuGDmryf1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:51:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:51:02 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house uses
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-Hxf16Ov2ng@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

--- Comment #14 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36475
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36475&action=edit
[SIGNED-OFF] Bug 11201: Display overdues in red

On the pending on-site checkout list, the date for overdues are now
displayed in red.

Test plan:
Make sure you have on-site checkouts created today and before.
The date for the ones created before today should be displayed in red.

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:54:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:54:39 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-6dOrRKbs5F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Simith,
The css file is generated from the less file (less/opac.less).
You need to attach to the patch the change you have done to this file too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:55:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:55:20 +0000
Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed
In-Reply-To: <bug-2499-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2499-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2499-70-ap4LnIJV3X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:56:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:56:27 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-HL0iyNLwdu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Needs Signoff               |Failed QA

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
a) _insert_accontlines() has a typo, it should be _insert_accountlines()

b) Can you please either rewrite chargelostitem() to use manualinvoice() for
creating the accountline, or change manualinvoice() to use
_insert_accontlines() as well?

c) You have chargelostitem() returning an accountline as a value, which can be
either the processing fee or the lost fee, but not both even though both may be
charged. This return value is not even used by any code. The simplest
resolution would be to delete the line.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:58:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:58:32 +0000
Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related
 to their branch.
In-Reply-To: <bug-8438-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8438-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8438-70-mGtm7udblt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, here it is: 

- We failed to get superserials and this patch set into the same version. 
- Superserials permission has been in use for quite a while now (see bug 8435) 
- This patch currently updates your permission set to add 'superserials' to it,
if you had the permission to claim serials before.
- We have a time gap here that will cause some change in behaviour, no matter
how we do it.

So this is the situation as I see it:

1) Not using IndependentBranches
= Nothing needs to be done, because nothing should change. 
No need to update the permissions in that case. 
We could add an additional check for IndependentBranches to the database
update.

2) Using IndependentBranches

a) Having superserials permission already
= Nothing changes

b) Not having superserials permission before update
= Can now suddenly manage serials from other branches after the update.
If we don't update the permission:
= Can suddenly no longer claim issues from other branches

So what can we do here?
- Introducing a 'superserialclaim permission' seems silly.
- Taking away a smaller permission seems making more sense than giving access
to even more data than before.
- I'd vote for 'don't add the superserials permission on update'.

Another thing: If I am not allowed to claim the issues from other branches,
should these issues be visible to me? A user without
superlibrarian/superserials will still see all issues that need claiming in the
serial claim view, but they will miss the checkbox for claiming them. This
doesn't seem to make sense, as I can't find the subscription using the
search... but I can access it form the link. This is not very clean.

I think the access problem could be on a separate bug ("Can still access other
branches subsriptions with IndyBranches and no superserials"), but I'd really
like to see a filtered view for the claims.

Jonathan, could you take a look? Woudl also be good to get more opinions about
b).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:59:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:59:51 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-2ScWGFyOvV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|Medium patch                |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 13:59:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 12:59:56 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-zugaV1u1l7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #22 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36476
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36476&action=edit
[SIGNED-OFF] Bug 6934 New report Cash Register Statistics

This patch creates a new report that outputs cash register stats for a specific
period.

Changes:

koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc               - Added
cash register report link
koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt  - new
file
koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt         - Added
cash register report link
reports/cash-register_stats.pl                                          - new
file

Testing:

I Apply the patch

0) Go to reports home page (Home ? Reports);
1) Validate link << Cash Register >> under Statistics wizards;
2) Click link;
3) Validate page with three fieldsets;
4) Chose a date interval, a transaction type, a library and an output;
5) Validade the result.

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:02:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:02:10 +0000
Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions
In-Reply-To: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13392-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13392-70-TrwlBynYg3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:02:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:02:53 +0000
Subject: [Koha-bugs] [Bug 13334] Add a warning during the return of a
 document that was reserved to a course.
In-Reply-To: <bug-13334-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13334-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13334-70-AoqLcRdZUT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13334

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:07:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:07:48 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-hmKnL1OBh3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
  Attachment #30259|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:11:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:11:25 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-sW4JWTDWXS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:16:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:16:38 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-yQdGWweWFV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi Jonathan,
Seems that 'usmarc' is not a valid value for 'marcflavour' syspref,
only MARC21, UNIMARC and NORMARC

And the same error is on line 916 of addbiblio.pl

Perhaps is better to write the code as:

if ( $record ne "-1" ) {
    if ( C4::Context->preference('marcflavour') =~/unimarc/i ) {
        $template->param( title => $record->subfield('200',"a") );
    } else {
        $template->param( title => $record->title() );
    }
}

... unless I'm mistaken.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:18:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:18:46 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-1GzYADnunG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30259|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:31:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:31:58 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-7KL4lBgQ1j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:32:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:32:01 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-EStbn9hB0c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36445|0                           |1
        is obsolete|                            |

--- Comment #2 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36477
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36477&action=edit
Bug 13789 - facets with accented utf-8 characters generate double encoded links

Bug 13425 tried to fix XSS in OPAC, by using url filter in template toolkit
on whole generated url. This doesn't work and create double encoded strings
in facets because we are creating url variable by concatenating query_cgi
(which did pass through uri_escape_utf8 on perl side) and other
parameters which have to be escaped in template.

Also, code like

[% SET limit_cgi_f = limit_cgi | url %]

doesn't do anything (at least doesn't apply url filter) so it's not needed.

Test scenario:
1. find results in your opac which contain accented characters
2. click on them and verify that results are missing
3. apply this patch
4. re-run search and click on facets link verifying that there are
   now results
5. verify that facets are still safe from injection by constructing url like
  
/cgi-bin/koha/opac-search.pl?q=123&sort_by='"><script>prompt('Happy_Holidays')</script>&limit=123
   and verifying that you DON'T see prompt window in your browser

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:32:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:32:05 +0000
Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode,
 categorytype from table overduerules_transport_types
In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13624-70-HLk3Mc7wGy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |jesse at bywatersolutions.com

--- Comment #9 from Jesse Maseto <jesse at bywatersolutions.com> ---
I received a CONFLICT while trying to apply this patch.

-Jesse


CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.
Patch failed at 0001 Bug #13624: Remove columns branchcode, categorytype from
table overduerules_transport_types

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:34:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:34:29 +0000
Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
In-Reply-To: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13382-70-J4DHo09dpD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:37:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:37:49 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-XbapY96mBf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Aur?lie Fichot <aurelie.fichot at iepg.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #77 from Aur?lie Fichot <aurelie.fichot at iepg.fr> ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 8236:
<h1>Something went wrong !</h1>Applying: Bug 8236 Renewing policy in overdue or
restriction case
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging C4/Circulation.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 8236 Renewing policy in overdue or restriction case

When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 8236 - Prevent renewing if overdue or restriction

35372 - Bug 8236 Renewing policy in overdue or restriction case

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-8236-Renewing-policy-in-overdue-or-restriction-Gwo9FG.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:42:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:42:08 +0000
Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert
 arbitrary files to MARC from record staging tool
In-Reply-To: <bug-12412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12412-70-G9jdVYfho2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:42:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:42:11 +0000
Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert
 arbitrary files to MARC from record staging tool
In-Reply-To: <bug-12412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12412-70-nVqsZFma6b@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35483|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36478
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36478&action=edit
[PASSED QA] Bug 12412 - Add ability for plugins to convert arbitrary files to
MARC from record staging tool

Many libraries would like to be able to import various types of files as
MARC records ( citations, csv files, etc ). We can add a new function to
the plugins system to allow that kind of behavior at a very custom
level.

Test Plan:
1) Ensure you have plugins enabled and configured correctly
2) Installed the attached version 2.00 of the Kitchen Sink plugin
3) Download the attached text file
4) Browse to "Stage MARC records for import"
5) Select the downloaded text file for staging
6) After uploading, you should see a new area "Transform file to MARC:",
   select "Example Kitchen-Sink Plugin" from the pulldown menu
7) Click 'Stage for import"
8) Click 'Manage staged records"
9) You should now see two new MARC records!

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described - interesting new feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:48:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:48:35 +0000
Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert
 arbitrary files to MARC from record staging tool
In-Reply-To: <bug-12412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12412-70-10KW8f1x3b@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Wondering if we should update this to be a 'new feature'?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:53:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:53:47 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-PDCXkIbkGu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it

--- Comment #75 from Zeno Tajoli <z.tajoli at cineca.it> ---
Hi Jessie,

What about transfer support of JSONP for services in a specific bug ?
It is a modification of C4/Service.pm.

I think could be useful alone.
And probably in this way coulod be possible to extract also metasearch for Opac
on z39.50

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 14:59:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 13:59:50 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-97quEMaPZ6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36460|0                           |1
        is obsolete|                            |
  Attachment #36461|0                           |1
        is obsolete|                            |
  Attachment #36462|0                           |1
        is obsolete|                            |
  Attachment #36463|0                           |1
        is obsolete|                            |
  Attachment #36464|0                           |1
        is obsolete|                            |
  Attachment #36465|0                           |1
        is obsolete|                            |
  Attachment #36466|0                           |1
        is obsolete|                            |
  Attachment #36467|0                           |1
        is obsolete|                            |
  Attachment #36468|0                           |1
        is obsolete|                            |
  Attachment #36469|0                           |1
        is obsolete|                            |

--- Comment #53 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36479
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36479&action=edit
Bug 10963: Simplified creation - FA framework

Patch 1/9

This patch modifies Fast Add framework

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:00:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:00:09 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-EJliT8mPTj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #54 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36480
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36480&action=edit
Bug 10963: Simplified creation - BKS framework

Patch 2/9

This patch rewrites BKS framework

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:00:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:00:19 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-zOEXYcj3aQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #55 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36481
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36481&action=edit
Bug 10963: Simplified creation - CF framework

Patch 3/9

This patch rewrites CF framework

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:00:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:00:29 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-AvgrISCWiH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #56 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36482
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36482&action=edit
Bug 10963: Simplified creation - SR framework

Patch 4/9

This patch rewrites SR framework

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:00:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:00:40 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-LJ1BcvkqLG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #57 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36483
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36483&action=edit
Bug 10963: Simplified creation - VR framework

Patch 5/9

This patch rewrites VR framework

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:00:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:00:50 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-qf0EfKI759@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #58 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36484
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36484&action=edit
Bug 10963: Simplified creation - AR framework

Patch 6/9

This patch rewrites AR framework

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:01:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:01:02 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-xBps9VvYXs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #59 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36485
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36485&action=edit
Bug 10963: Simplified creation - KT framework

Patch 7/9

This patch rewrites KT framework

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:01:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:01:12 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-CFuiCjVrHB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #60 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36486
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36486&action=edit
Bug 10963: Simplified creation - IR framework

Patch 8/9

This patch rewrites IR framework

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:01:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:01:23 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-so1D1sISnd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #61 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36487
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36487&action=edit
Bug 10963: Simplified creation - SER framework

Patch 9/9

This patch rewrites SER framework

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:01:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:01:29 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-fbb8xcwnuz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #62 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36488
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36488&action=edit
Bug 10963: Revert old hidden values

This patch reverts old hidden values to marc_subfield_structure.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:03:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:03:04 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-AHHSphsADc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #63 from Mirko Tietgen <mirko at abunchofthings.net> ---
Followed the test plan in comment 26, diffs contain no lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:04:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:04:50 +0000
Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a
 suggestion can be treated
In-Reply-To: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13014-70-9dgHeTdWq7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

this looks good so far in code review and the unit tests all pass. 

Just wondering: Why not send out the email immediately like the other emails,
but via a cronjob?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:05:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:05:47 +0000
Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging
In-Reply-To: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7683-70-DZCxuI1Heu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28466|0                           |1
        is obsolete|                            |

--- Comment #81 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36489
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36489&action=edit
Bug 7683: Cataloguing statistics wizard improvements

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:05:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:05:59 +0000
Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging
In-Reply-To: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7683-70-K5TSHENp9x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28467|0                           |1
        is obsolete|                            |

--- Comment #82 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36490
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36490&action=edit
Bug 7683 [Follow-up] Move unit tests in t/db_dependent/Biblio.t

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:06:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:06:11 +0000
Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging
In-Reply-To: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7683-70-Hu1YaOSWrS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28468|0                           |1
        is obsolete|                            |

--- Comment #83 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36491
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36491&action=edit
Bug 7683: Remove use of items.statisticvalue and DHTMLcalendar()

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:06:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:06:23 +0000
Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging
In-Reply-To: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7683-70-WISJfHVI3f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28469|0                           |1
        is obsolete|                            |

--- Comment #84 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36492
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36492&action=edit
Bug 7683: Remove dead code about dewey and lccn filters

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:06:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:06:43 +0000
Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging
In-Reply-To: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7683-70-udWsYUzfFO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28470|0                           |1
        is obsolete|                            |

--- Comment #85 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36493
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36493&action=edit
Bug 7683: Fix a shift in date filter indexes

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:08:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:08:33 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-hbpeNPXFc7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:08:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:08:45 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-t37hEWL3VS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

--- Comment #4 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Anyway, the logout occurs because directly after login the ticket parameter is
still in the url. 

When pressing refresh, the page is called again with the ticket parameter,
which will trigger ticket validation, that will fail because the ticket has
already been used, provoking the logout.

A possible fix would be to check if the user is already logged-in and prevent
CAS ticket validation if it is the case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:09:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:09:04 +0000
Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode,
 categorytype from table overduerules_transport_types
In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13624-70-zulA7Gd85R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36122|0                           |1
        is obsolete|                            |

--- Comment #10 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 36494
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36494&action=edit
Bug #13624: Remove columns branchcode, categorytype from table
overduerules_transport_types

Sponsored by Halland County Library

This patch is a _requirement_ to Bug #12771, and will be necessary once we
start managing more than 3 levels of overdue notice

In installer/data/mysql/updatedatabase.pl
    - A new column and primary key, 'overduerules_id', is added to the table
'overduerules'
    - A new column referencing a foreign key, 'overduerules_id', is added to
the table 'overduerules_transport_types'
    - The columns 'branchcode' and 'categorytype' are removed from the table
'overduerules_transport_types'
    - Data is migrated from the old tables to the new ones

In installer/data/mysql/kohastructure.sql :
    - Table 'overduerules'
    - Added a primary key named 'overduerules_id'
    - Table 'overduerules_transport_types'
    - Added a foreign key named 'overduerules_id'
    - Dropped columns 'branchcode', 'categorycode' since we now have them
referenced through 'overduerules_id'

In tools/overduerules.pl
    - INSERT and DELETE queries on 'overduerules_transport_types' were changed
to reflect the new schema

In C4/Overdues.pm :
    - The SQL query of the function 'GetOverdueMessageTransportTypes' is
changed to take into account the new design of 'overduerules_transport

In t/db_dependent/Overdues.t :
    - The INSERT calls before the tests were changed to take into account the
new design of 'overduerules' and 'overduerules_transport_types'

TEST PLAN
---------
1) Apply the patch
2) Run the script installer/data/mysql/updatedatabase.pl
    - It will create new tables and migrate the data
3) Run Overdues.t. Tests should be successful

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:09:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:09:35 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-iIhpni2Urb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36470|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:10:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:10:29 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-ktXMHf2t8U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:10:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:10:39 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-3UbXr7ZzHI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36447|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36495
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36495&action=edit
[PASSED QA] Bug 13575 - Names do not appear in the Koha history Timeline.

This would be a good addition. The names to be added are:
Kahurangi Cormack, Alexander Cheeseman

Signed-off-by: Nicole <nicole at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:11:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:11:27 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-Cph8W0bCm0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #24 from simith.doliveira at inlibro.com ---
Created attachment 36496
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36496&action=edit
Add changes to opac.less

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:12:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:12:25 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-t2kNuHylRj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #25 from simith.doliveira at inlibro.com ---
opac.less file added

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:21:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:21:12 +0000
Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
In-Reply-To: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13382-70-l8LaEtZ1nW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #23 from Winona Salesky <wsalesky at gmail.com> ---
Nick, 
Do you have a test record that has the issue with the chopped string? I have
not turned this bug up with my test records.

Thanks for the help.
-Winona

(In reply to Nick Clemens from comment #21)
> The only issue I see is that when displaying at a 'Contained Work' the last
> character of the field preceding the relator terms is clipped.  
> 
> When displaying contributors all looks fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:25:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:25:19 +0000
Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode,
 categorytype from table overduerules_transport_types
In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13624-70-hIHth3FNa8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:25:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:25:26 +0000
Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode,
 categorytype from table overduerules_transport_types
In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13624-70-Bz2rvsT1zU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36494|0                           |1
        is obsolete|                            |

--- Comment #11 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 36497
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36497&action=edit
Bug #13624: Remove columns branchcode, categorytype from table
overduerules_transport_types

Sponsored by Halland County Library

This patch is a _requirement_ to Bug #12771, and will be necessary once we
start managing more than 3 levels of overdue notice

In installer/data/mysql/updatedatabase.pl
    - A new column and primary key, 'overduerules_id', is added to the table
'overduerules'
    - A new column referencing a foreign key, 'overduerules_id', is added to
the table 'overduerules_transport_types'
    - The columns 'branchcode' and 'categorytype' are removed from the table
'overduerules_transport_types'
    - Data is migrated from the old tables to the new ones

In installer/data/mysql/kohastructure.sql :
    - Table 'overduerules'
    - Added a primary key named 'overduerules_id'
    - Table 'overduerules_transport_types'
    - Added a foreign key named 'overduerules_id'
    - Dropped columns 'branchcode', 'categorycode' since we now have them
referenced through 'overduerules_id'

In tools/overduerules.pl
    - INSERT and DELETE queries on 'overduerules_transport_types' were changed
to reflect the new schema

In C4/Overdues.pm :
    - The SQL query of the function 'GetOverdueMessageTransportTypes' is
changed to take into account the new design of 'overduerules_transport

In t/db_dependent/Overdues.t :
    - The INSERT calls before the tests were changed to take into account the
new design of 'overduerules' and 'overduerules_transport_types'

TEST PLAN
---------
1) Apply the patch
2) Run the script installer/data/mysql/updatedatabase.pl
    - It will create new tables and migrate the data
3) Run Overdues.t. Tests should be successful

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:26:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:26:05 +0000
Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new
	search
In-Reply-To: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12460-70-KoMyfuc9l0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Pierre Angot <tredok.pierre at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tredok.pierre at gmail.com
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Pierre Angot <tredok.pierre at gmail.com> ---
I've tested it on sandbox.

It Works ! ^^

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:27:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:27:56 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-lnLZjKIUTX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Failed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Dobrica,

a small thing: Could you rename "Stock number" to "Inventory number" please?
And I think the change in the debug section is not necessary - that appears to
seem somewhat dead debug code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 15:57:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 14:57:16 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-FkJ2W8P1Nv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Sorry Dobrica, I found an issue :-/
The encoding problem is fixed for the facet lib, but try to click on one facet,
it should be selected (i.e. not a link and with the [x] to remove it), and it's
not.
It looks like there is another encoding issue somewhere else...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:03:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:03:21 +0000
Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a
 suggestion can be treated
In-Reply-To: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13014-70-B5DQnQcKyO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014

--- Comment #34 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #33)
> Just wondering: Why not send out the email immediately like the other
> emails, but via a cronjob?

Because we would like the ability to sent an email for the suggestions not
processed for X days.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:04:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:04:35 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-wissN0zpc6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #26 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to simith.doliveira from comment #25)
> opac.less file added

Ok thanks.
No signoff needed for this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:12:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:12:28 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-JQoejMZTv9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
I completely agree. This should be an optional feature implemented at the
patron category level. Otherwise this makes an irreversible change to Koha.
Many librarians complain that the patron form is too long already. We cannot
hide this for adults without also hiding it for children, thus it must be
implemented as an optional feature. The most sensible way to do this would be
to add a switch at the patron category level that enables the ability to set a
guarantor for a given patron type.

(In reply to Nicole C. Engard from comment #5)
> While the code works, this is a problem for many libraries. I think this
> should be an on/off switch on the patron category administration page. That
> way some categories can have it and others won't.  If it's there for all
> patrons it will be requested that we hide it for all but children and that
> can't be done easily.
> 
> Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:22:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:22:46 +0000
Subject: [Koha-bugs] [Bug 13717] Add ability to move old patron attributes
 when importing borrowers
In-Reply-To: <bug-13717-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13717-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13717-70-R8ZAxWRmez@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |nengard at gmail.com

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Applying: Bug 13717 - Add ability to move old patron attributes when importing
new patron data
fatal: sha1 information is lacking or useless (Koha/Borrower/Import.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 13717 - Add ability to move old patron attributes when
importing new patron data
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-13717---Add-ability-to-move-old-patron-attribu-k3144M.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:22:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:22:56 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-9hE5ROdnbZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

--- Comment #5 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 36498
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36498&action=edit
Bug 12887: User logged out on refresh after CAS authentication

 - If the user is already logged-in, do not trigger CAS authentication even if
there is a ticket in the parameters.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:23:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:23:50 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-KcD5hdg0Rj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:25:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:25:28 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-rKmocz3b7D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Francois Charbonnier <francois.charbonnier at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #7 from Francois Charbonnier <francois.charbonnier at inlibro.com> ---
Hi Nicole, Hi Kyle,

I do not agree since it fixes an issue in Koha.

Koha already allows librarian to linked adult cards together. But once the
cards are linked together, if the guarantee is an adult, the patron edit page
doesn't display the "Guarantor information". So you can't edit the link. If you
want to, you have to change the patron category to a child type, edit it and
then put back the correct patron category.

To me, it's a feature that needed to be fixed.

I agree there is a need to be able to hide parts of the patron edit page but I
think it should be part of a different feature. If we add the ability to
control the display of the edit patron page, we should be able to do it for
every part of the page.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:26:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:26:49 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-A07tu0OL5Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #27 from Jonathan Druart <jonathan.druart at biblibre.com> ---
The opac.css does not look good.
With your patch:
-rw-r--r-- 1 koha koha 42132 Mar  4 16:25 bootstrap/css/opac.css

$lessc --compress bootstrap/less/opac.less > bootstrap/css/opac.css
-rw-r--r-- 1 koha koha 42946 Mar  4 16:25 bootstrap/css/opac.css

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:29:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:29:28 +0000
Subject: [Koha-bugs] [Bug 2806] issuingbranch isn't used
In-Reply-To: <bug-2806-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2806-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2806-70-JGV3VlhBzk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36124|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36499
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36499&action=edit
[SIGNED-OFF] Bug 2806: Remove issuingbranch columns

This column is not in used in the Koha code and could be removed.

Test plan:
Verify the branch is correctly displayed on the circulation history
(members/readingrec.pl) and that both reports Most-cisulated items
(cat_issues_top.pl) and Avg checkout (issues_avg_stats.pl) work as
before.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No problems found.
Fixed wrong table name on updatedatabase.pl and a tab char.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:30:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:30:03 +0000
Subject: [Koha-bugs] [Bug 2806] issuingbranch isn't used
In-Reply-To: <bug-2806-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2806-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2806-70-L9OBfW2FR8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:46:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:46:33 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-cr54L0ClLN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I think I found an issue, to reproduce:
Enable sms + email for checkout, check an item out => no letter is generated.

Ok it's a configuration problem, but I think it could easily be fixed if you
next instead of return if the template does not exist.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:49:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:49:10 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-juaWNZX6e9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:49:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:49:13 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-bjzlCh187k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #15 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36500
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36500&action=edit
Bug 13771: Add missing item search help file

This patch adds a help file for the staff item search.

To test:

* Click search
* click item search
* click help
* review the help file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:52:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:52:52 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-Z09VVIfxgQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:52:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:52:55 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-zhFIP2fCp5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36477|0                           |1
        is obsolete|                            |

--- Comment #4 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36501
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36501&action=edit
Bug 13789 - facets with accented utf-8 characters generate double encoded links

Bug 13425 tried to fix XSS in OPAC, by using url filter in template toolkit
on whole generated url. This doesn't work and create double encoded strings
in facets because we are creating url variable by concatenating query_cgi
(which did pass through uri_escape_utf8 on perl side) and other
parameters which have to be escaped in template.

Also, code like

[% SET limit_cgi_f = limit_cgi | url %]

doesn't do anything (at least doesn't apply url filter) so it's not needed.

Test scenario:
1. find results in your opac which contain accented characters
2. click on them and verify that results are missing
3. apply this patch
4. re-run search and click on facets link verifying that there are
   now results
5. verify that facets are still safe from injection by constructing url like
  
/cgi-bin/koha/opac-search.pl?q=123&sort_by='"><script>prompt('Happy_Holidays')</script>&limit=123
   and verifying that you DON'T see prompt window in your browser

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 16:59:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 15:59:26 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-wYEb0P0eIw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #8 from Nicole C. Engard <nengard at gmail.com> ---
Discussion from IRC: http://irc.koha-community.org/koha/2015-03-04#i_1645311

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:11:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:11:03 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-25wBLbjYiE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr
             Status|Needs Signoff               |Failed QA

--- Comment #11 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
I tested this patch on a sandbox :
1. set syspref CommentModeratorsEmail with my email adress
2. go to public interface and add a comment on a book
3. go to saved reports to check to table message_queue : I have a new record
with the letter_code ''COMMENT_CREATED' : Ok, it works !
4. Go to notices and slips to change the message of ''COMMENT_CREATED' model :
in email tab, I try to add the title of the book in the message
(<<biblio.title>>) and the biblionumber (<<biblio.biblionumber>>)
5. Go to the opac and add a new comment on an other book
6. go to saved reports to check to table message_queue :  I don't retrieve the
title of the book and the biblionumber in the email : it's a pity because it
can be usefull informations for the librarian.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:15:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:15:48 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-7m830oWdWF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35575|0                           |1
        is obsolete|                            |
  Attachment #35576|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36502
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36502&action=edit
Bug 13635: Unimarc - On editing a notice, the title should be displayed

The title method of MARC::Record does not deal with UNIMARC, it should
not be called if the marc flavour is UNIMARC.

Test plan:
On an unimarc installation, edit a notice, with this patch you should
see
 "Editing TITLE (Record number BIBLIONUMBER)"

Without, the title was not displayed.
Same in the breadcrumbs.

Bug 13635: Remove another useless call

There is another call to the title method in additem.pl without any
check on the marc flavour.
But here the title variable sent to the template is redefined 3 lines
later.
So it can be simply removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:15:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:15:44 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-xSgeq27NL2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:16:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:16:27 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-0ies2jcvx9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36500|0                           |1
        is obsolete|                            |

--- Comment #16 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36503
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36503&action=edit
Bug 13771: Add missing item search help file

This patch adds a help file for the staff item search.

To test:

* Click search
* click item search
* click help
* review the help file

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:16:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:16:30 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-rmxjKxAFVs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #3)
> Hi Jonathan,
> Seems that 'usmarc' is not a valid value for 'marcflavour' syspref,
> only MARC21, UNIMARC and NORMARC
> 
> And the same error is on line 916 of addbiblio.pl
> 
> Perhaps is better to write the code as:
> 
> if ( $record ne "-1" ) {
>     if ( C4::Context->preference('marcflavour') =~/unimarc/i ) {
>         $template->param( title => $record->subfield('200',"a") );
>     } else {
>         $template->param( title => $record->title() );
>     }
> }
> 
> ... unless I'm mistaken.

Yes of course, you are right!
Now patch attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:16:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:16:41 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-r7Pg7OWRbC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Francois Charbonnier <francois.charbonnier at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

--- Comment #9 from Francois Charbonnier <francois.charbonnier at inlibro.com> ---
Thanks nicole!
We just talked about this with Nicole and Kyle.
We agreeded on this :
* On the patron category page, there will be a new button : "display the edit
garantor information box" : yes | no
* by default, we will have "yes" for child and professional categories
* if yes, we will display the edit guarantor box on the patron edit page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:18:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:18:50 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-Dq9tsHj8p1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net
             Status|Needs Signoff               |Signed Off

--- Comment #17 from Mirko Tietgen <mirko at abunchofthings.net> ---
Item search help works for me.

I noticed that about the first half of the text is a description of how to get
to the very page you open that help file from, I'm not sure it is very helpful
in this context. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:33:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:33:23 +0000
Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new
	search
In-Reply-To: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12460-70-9KWQc2itAA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

LuceBarbey <luce.barbey at cirad.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luce.barbey at cirad.fr

--- Comment #9 from LuceBarbey <luce.barbey at cirad.fr> ---
I've tested it and I've some comments.
1.This function (developpement) needs a documentation about the behavior.
2. The first time we come on search history, we must select some lines and
click on "start a new search" before to see the boolean operator 'NOT'. It's
not intuitive
3. To build a complex search, we must proceed in several steps, because we
could search only with AND (match all) / OR (match any.)
Proposals :
1. Display the "not" column immediately
2. Modify the form : when nothing is checked display "Select searches to run a
combined search". When at least one search is checked, display "With selected
searches run a combined search [matching any of selected searches] [ok]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:34:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:34:39 +0000
Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature
In-Reply-To: <bug-12461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12461-70-d6li8ymuaK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net
             Status|Needs Signoff               |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:39:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:39:08 +0000
Subject: [Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for
 the same patron
In-Reply-To: <bug-12085-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12085-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12085-70-LJa14i8ybz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net
             Status|Needs Signoff               |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:54:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:54:07 +0000
Subject: [Koha-bugs] [Bug 12769] Notice fee management
In-Reply-To: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12769-70-q4C4KNbQof@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

--- Comment #8 from Ahmed Sfayhi <ahmed.sfayhi at inlibro.com> ---
Created attachment 36504
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36504&action=edit
Bug 12769 - Display fee in notice fee

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:58:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:58:13 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-2DDxBCvlQC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #12 from M. Tompsett <mtompset at hotmail.com> ---
I think that may be a cronjob configuration problem. I'll recheck this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 17:59:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 16:59:31 +0000
Subject: [Koha-bugs] [Bug 12769] Notice fee management
In-Reply-To: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12769-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12769-70-CxGAr7Qax6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

Ahmed Sfayhi <ahmed.sfayhi at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmed.sfayhi at inlibro.com

--- Comment #9 from Ahmed Sfayhi <ahmed.sfayhi at inlibro.com> ---
This attachment correct the problem with the last attachment: the fee was not
displayed in the notice fee input

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 18:05:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 17:05:17 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-UagTorVfjM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #8 from Charles Farmer <charles.farmer at inlibro.com> ---
I read _insert_accountlines again and adapted manualinvoice to take its place.
I also removed the *return* instruction at the end of chargelostitem() because,
as you said, it wasn't used anywhere (except once in ChargeLostItem.t)

Thank you for your time!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 18:05:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 17:05:44 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-YljG9Avqg3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36350|0                           |1
        is obsolete|                            |

--- Comment #9 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 36505
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36505&action=edit
Bug 12768 - Replacement cost and processing fee management

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 18:08:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 17:08:30 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-pDTk86qJHq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36505|0                           |1
        is obsolete|                            |

--- Comment #10 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 36506
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36506&action=edit
Bug 12768 - Replacement cost and processing fee management

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 18:33:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 17:33:48 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-4fIIgmSKN4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36502|0                           |1
        is obsolete|                            |

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36507
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36507&action=edit
[SIGNED-OFF] Bug 13635: Unimarc - On editing a notice, the title should be
displayed

The title method of MARC::Record does not deal with UNIMARC, it should
not be called if the marc flavour is UNIMARC.

Test plan:
On an unimarc installation, edit a notice, with this patch you should
see
 "Editing TITLE (Record number BIBLIONUMBER)"

Without, the title was not displayed.
Same in the breadcrumbs.

Bug 13635: Remove another useless call

There is another call to the title method in additem.pl without any
check on the marc flavour.
But here the title variable sent to the template is redefined 3 lines
later.
So it can be simply removed.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested on UNIMARC install, editing a 'record' (not notice) does not show
title on breadcrumbs, status bar or page title.
With patch it does!
No koha-qa errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 18:34:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 17:34:39 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-ca0YSd40gr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:14:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 18:14:36 +0000
Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices
In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6810-70-Y3Tg00nvII@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 19:30:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 18:30:47 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-9KVJGt1aOT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:00:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:00:33 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-QOP0lo9aPf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36412|0                           |1
        is obsolete|                            |

--- Comment #6 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36508
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36508&action=edit
Koha-stop-zebra should also work for disabled instances

Currently koha-stop-zebra will not stop zebra for disabled instances. It should
work more like koha-stop-sip, which does work for disabled instances. Also,
koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly
should also apply to disabled instances.

To Test:
1) Disable a koha instance.
2) Run koha-stop-zebra INSTANCE. You should get message
   "Instance INSTANCE disabled. No action taken."
3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra
   to package site over /usr/sbin/koha-stop-zebra.
4) Disable koha instance.
5) Run koha-stop-zebra INSTANCE. It should now stop zebra.

http://bugs.koha-community.org/show_bug.cgi?id=13784
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:00:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:00:49 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-hdtFDKrOky@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:08:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:08:25 +0000
Subject: [Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra
	for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-TvNNZojilP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36413|0                           |1
        is obsolete|                            |

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36509
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36509&action=edit
Bug 13785 - Koha-disable should also stop SIP and zebra for instance

Currently koha-disable ONLY disables the instance in the apache conf
file. Presumably if you want to disable the instance, you also want
its processes to stop, so this patch will stop zebra, if running,
and SIP, if enabled.

Depends on Bug 13784.

To Test:
1) Have an enabled instance, with zebra and SIP running.
2) Run koha-disable INST. Note that after, both zebra and SIP
   will still be running.
3) Re-enable INST.
4) Apply patch, and then copy debian/scripts/koha-disable to
   package site, over /usr/sbin/koha-disable.
5) Run koha-disable INST. You should now see that both zebra
   and SIP have been stopped.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:08:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:08:42 +0000
Subject: [Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra
	for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-FH9yNKVbza@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:12:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:12:03 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-3Yc5PnDuct@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #28 from simith.doliveira at inlibro.com ---
Created attachment 36510
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36510&action=edit
Small improvements for the availability informations in the search results list
on the OPAC

This patch contains small modifications to the template of OPAC search results.
Theses modifications affect the "Availability" line :
* Add a linebreak after each location.
* Add the text "Call Number:" before call numbers.

To test:

I) Apply the patch

II) Include the following test in the OPACUserCSS preference:

.searchresults .CommasWithLinebreaks {
    display: block; # block - line breaks, inline - all one line
}

.searchresults .LabelCallNumber {
    display: inline; # inline - display, none - don't display
}

III) Do a search on the OPAC

IV) Validate : check the format of availability informations for each search
result (Breakline or "Call Number:" text).

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:12:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:12:48 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-lEmKXA6K9I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34004|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:13:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:13:04 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-OvZSrqHIdI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36496|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:22:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:22:50 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-1rsJNSYaOK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #29 from simith.doliveira at inlibro.com ---
I created a new patch with just MARC21slim2OPACResults.xsl file because reading
the comments #2, #4, #9 and #21 we don't need .css ou .less files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:48:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:48:57 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-62zNirOvRL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30259|0                           |1
        is obsolete|                            |

--- Comment #12 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36511
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36511&action=edit
Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC

This fix permits the staff to pull apart the access to patron message setting.

Modified:

installer/data/mysql/sysprefs.sql                                        
-OPACEnhancedMessagingPreferences preference added
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref   
-OPACEnhancedMessagingPreferences preference added
koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc                   
-access to message setting changed

Testing:

I Apply the patch
II Run updatedatabase.pl

0) Search OPACEnhancedMessagingPreferences preference;
1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on
the OPAC (NOTE: EnhancedMessagingPreferences must be enabled).";
2) Disable OPACEnhancedMessagingPreferences preference;
3) Enable EnhancedMessagingPreferences preference;
4) On the OPAC -> user's settings, validate "your messaging" is not showed.

Patch behaves as expected
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
I fixed some minor conflicts, so I'm sending all patches w/ signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:49:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:49:09 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-gCKruZStml@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30487|0                           |1
        is obsolete|                            |

--- Comment #13 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36512
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36512&action=edit
Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC

QA Follow up

This patch will stop a person without access hitting the url directly and
being able to change their messaging preferences.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
I fixed some minor conflicts, so I'm sending all patches w/ signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:49:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:49:23 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-vEXa0ubqLJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31047|0                           |1
        is obsolete|                            |

--- Comment #14 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36513
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36513&action=edit
Bug 12528 Patch with updatedatabase.pl included

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:49:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:49:51 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-czzs26Ik2u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 20:52:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 19:52:38 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-8sZSBM4cAP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #15 from Mirko Tietgen <mirko at abunchofthings.net> ---
The description of EnhancedMessagingPreferences should probably be reworded as
it does not make much sense in combination with
OPACEnhancedMessagingPreferences.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 23:07:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 22:07:11 +0000
Subject: [Koha-bugs] [Bug 13794] New: Input field values not translated
Message-ID: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

            Bug ID: 13794
           Summary: Input field values not translated
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: maxime.beaulieu at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

The template translation tool does not translate input field values.
I have fixed a logical test marked by a #FIXME tag in tmpl_process3.pl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 23:10:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 22:10:58 +0000
Subject: [Koha-bugs] [Bug 13794] Input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-WN5yfMwqhh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

--- Comment #1 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Created attachment 36514
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36514&action=edit
Fixed logical test in tmpl_process3.pl

The line:
next if $a eq 'value' && ($tag ne 'input' || (ref $attr->{'type'} &&
$attr->{'type'}->[1] =~ /^(?:checkbox|hidden|radio|text)$/)); # FIXME

This portion: (ref $attr->{'type'} && $attr->{'type'}->[1] =~
/^(?:checkbox|hidden|radio|text)$/) checks if the input type is valid.

We get the following (wrong) logic:
next IF
$a eq value
    AND
the tag is not an input OR the input type is valid

The test is true when : $a eq value, tag is an input, input type is valid
We skip the tag when it is valid, it is never translated.

I propose the following change:
  my $isValidType = ref $attr->{'type'} && $attr->{'type'}->[1] =~
/^(?:checkbox|hidden|radio|text)$/;
  next if $a eq 'value' && !($tag eq 'input' && $isValidType);

next IF
$a eq value
    AND
NOT ( tag is an input AND input type is valid )
in short: NOT (tag is a valid input tag)

[ Alternative ] ( Not included in patch )
next if $a eq 'value' && ($tag ne 'input' || (ref $attr->{'type'} &&
$attr->{'type'}->[1] !~ /^(?:checkbox|hidden|radio|text)$/));
No extra variable, at the cost of code readability.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 23:11:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 22:11:40 +0000
Subject: [Koha-bugs] [Bug 13794] Input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-Bwyi5Pfoqy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 23:12:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 22:12:01 +0000
Subject: [Koha-bugs] [Bug 13794] Input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-lbK9rSbzaD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar  4 23:18:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 22:18:46 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-DV8Qg0SyKj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #28 from David Cook <dcook at prosentient.com.au> ---
(In reply to M. Tompsett from comment #26)

> I would think the parameter would be better renamed to $AuthenticatedEmail,
> because persona and this OAuth patch both authenticate against an Email
> address (the primary email address is used to find the user).
> 

Yeah, I thought about that a bit, but it also sets a "persona" key in the
session, which I think might be used for persona session management, so
re-using it without careful checking could lead to weirdness with Persona. 

> NOOOOOO! Please hashref the parameter!
> If there are more than 3 parameters, you probably should use a hashref.

...

Yes, a single hashref would be nicer. If I were designing a new sub, I would
use a single hashref. However, I'm personally not planning on refactoring
C4::Auth::checkauth() and testing every use of it. Nor am I going to add
checking to checkauth() so that it can use a single hashref OR a bunch of
scalars. That just leads to more technical debt.

Of course, I'm not planning on upstreaming my OpenID Connect work at the moment
anyway, so it doesn't really matter. I'm sure whoever refactors checkauth()
someday will use a single hashref instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 00:39:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 04 Mar 2015 23:39:37 +0000
Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
In-Reply-To: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13382-70-tZOrAseYbo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #24 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 36515
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36515&action=edit
MARC record with contained works

When displaying the contained works with this patch the last character is
chopped.  Presumably this is to remove punctuation, but for an incorrectly
punctuated field or field ending in ')' this could be problematic. 

In the attached record the first 700 contained work is badly punctuated and the
word orchestra is trimmed, for others a comma is trimmed and replaced with a
';' separator.  When testing it seems to be any character in the last field
displayed

AFAIK subject fields will trim a '.' on display, but not a ')' so maybe just
ensure only certain punctuation is trimmed if possible

Probably contained works should be separated by the '|' character as other
fields are for consistency throughout

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 02:19:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 01:19:01 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-dmPui96UFx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #13 from M. Tompsett <mtompset at hotmail.com> ---
Another reason this is currently failed qa. This modifies C4/Review.pm without
adding any tests. Don't worry, the patch I'm working on for this will handle
comment #11 and add tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 03:49:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 02:49:11 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-5GSL6QYnsG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36065|0                           |1
        is obsolete|                            |

--- Comment #14 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36516
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36516&action=edit
Bug 1985 - Email notification of new OPAC comments

This feature adds YAS 'CommentModeratorsEmail', where an email (template code
COMMENT_CREATED) is sent when
a borrower creates/modifies an comment/review. The syspref is empty by default
and no email is sent when the
syspref is empty.

This feature is needed because we want to alert our content moderators to take
action when needed. Usually
it is our librarians who write reviews and this improvement makes the process
of moving Koha reviews to our
CMS more smooth.

TEST SETUP:
-1. Run updatedatabase.pl to add the syspref and the new letter template.
0. Go to admin/preferences.pl?tab=opac, and set the
'CommentModeratorsEmail'-syspref to your email-address.

TEST PLAN:
1. Log in to OPAC and find any Biblio.
2. Make a comment/review for it.
3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'.
You should see the reasonable
   default message. You can change the message in tools/letter.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 03:49:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 02:49:24 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-Yh7Bh0cQAH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #15 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36517
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36517&action=edit
Bug 1985 - Add missing table variables, tweak License, and cleanup

In comment #11, it was mentioned that title and biblionumber from
the biblio table were not available as variables in the letter.

This corrects this by converting the parameter list to a hashref,
and adding the missing biblio number.

It also cleans up the license on C4/Review.pm to be in line with
the current coding guidelines license. Also strict and warning
have been changed to the 'Use Modern::Perl;' now.

TEST PLAN
---------
1) Create test branch and apply patch
2) run installer/data/mysql/updatedatabase.pl
   -- this will add the required default letter.
3) In the staff client:
   a) set the CommentModeratorsEmail system preference.
      -- not setting it will mean you won't get any queued
         letters.
   b) modify the COMMENT_CREATED default letter as desired.
      -- feel free to add other things.
4) In the OPAC:
   a) Log in
   b) Find something
   c) Click on the 'Comments' tab
      -- Holdings/Title notes/Comments (#) is at the bottom
   d) Click 'Post or edit your comments on this item'
   e) In the window that pops up, type your comment.
   f) Click 'Submit and close this window'.
   g) Click 'Edit' and repeat steps e and f again.
5) In a mysql client:
   a) Open the koha database
   b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED';
      -- There should be at least two.
      -- They should be able to contain the borrower number, biblio
         title, and other borrower and biblio related things.
      -- Comments are at a biblio level, so items, and issues don't
         make sense as variables for the letter.
6) prove -v t/db_dependent/Review.t
6) Run the koha qa test tool.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 03:50:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 02:50:39 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-ppzsEAXjh1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #16 from M. Tompsett <mtompset at hotmail.com> ---
Obviously item numbers and the like don't make sense in the context of this
bug, but fixing what is listed for what reports would require a separate
enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 03:52:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 02:52:21 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-KeFSXCQIcK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #17 from M. Tompsett <mtompset at hotmail.com> ---
And by the way, comment 10 is still a valid issue. I figure it might be useful
to include it in the letter in the future, but no code was added to make that
possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:37:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:37:45 +0000
Subject: [Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra
	for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-jh4OYjAt7l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36518|0                           |1
        is obsolete|                            |

--- Comment #4 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36519
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36519&action=edit
Bug 13785 - Koha-disable should also stop SIP and zebra for instance

Currently koha-disable ONLY disables the instance in the apache conf
file. Presumably if you want to disable the instance, you also want
its processes to stop, so this patch will stop zebra, if running,
and SIP, if enabled.

Depends on Bug 13784.

To Test:
1) Have an enabled instance, with zebra and SIP running.
2) Run koha-disable INST. Note that after, both zebra and SIP
   will still be running.
3) Re-enable INST.
4) Apply patch, and then copy debian/scripts/koha-disable to
   package site, over /usr/sbin/koha-disable.
5) Run koha-disable INST. You should now see that both zebra
   and SIP have been stopped.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Robin Sheat <robin at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:37:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:37:02 +0000
Subject: [Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra
	for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-9IMZrwvlGS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:37:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:37:06 +0000
Subject: [Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra
	for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-1IzvzKKrwu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36509|0                           |1
        is obsolete|                            |

--- Comment #3 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36518
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36518&action=edit
Bug 13785 - Koha-disable should also stop SIP and zebra for instance

Currently koha-disable ONLY disables the instance in the apache conf
file. Presumably if you want to disable the instance, you also want
its processes to stop, so this patch will stop zebra, if running,
and SIP, if enabled.

Depends on Bug 13784.

To Test:
1) Have an enabled instance, with zebra and SIP running.
2) Run koha-disable INST. Note that after, both zebra and SIP
   will still be running.
3) Re-enable INST.
4) Apply patch, and then copy debian/scripts/koha-disable to
   package site, over /usr/sbin/koha-disable.
5) Run koha-disable INST. You should now see that both zebra
   and SIP have been stopped.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Robin Sheat <robin at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:39:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:39:01 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-HRmZJZ742B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:39:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:39:04 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-MIKt7jeqcV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

--- Comment #7 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36520
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36520&action=edit
Bug 13784: Koha-stop-zebra should also work for disabled instances

Currently koha-stop-zebra will not stop zebra for disabled instances. It should
work more like koha-stop-sip, which does work for disabled instances. Also,
koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly
should also apply to disabled instances.

To Test:
1) Disable a koha instance.
2) Run koha-stop-zebra INSTANCE. You should get message
   "Instance INSTANCE disabled. No action taken."
3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra
   to package site over /usr/sbin/koha-stop-zebra.
4) Disable koha instance.
5) Run koha-stop-zebra INSTANCE. It should now stop zebra.

http://bugs.koha-community.org/show_bug.cgi?id=13784
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Robin Sheat <robin at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:43:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:43:33 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-F9fgsGOZfX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36516|0                           |1
        is obsolete|                            |

--- Comment #18 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36521
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36521&action=edit
Bug 1985 - Email notification of new OPAC comments

This feature adds YAS 'CommentModeratorsEmail', where an email (template code
COMMENT_CREATED) is sent when
a borrower creates/modifies an comment/review. The syspref is empty by default
and no email is sent when the
syspref is empty.

This feature is needed because we want to alert our content moderators to take
action when needed. Usually
it is our librarians who write reviews and this improvement makes the process
of moving Koha reviews to our
CMS more smooth.

TEST SETUP:
-1. Run updatedatabase.pl to add the syspref and the new letter template.
0. Go to admin/preferences.pl?tab=opac, and set the
'CommentModeratorsEmail'-syspref to your email-address.

TEST PLAN:
1. Log in to OPAC and find any Biblio.
2. Make a comment/review for it.
3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'.
You should see the reasonable
   default message. You can change the message in tools/letter.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:43:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:43:50 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-jHjPzZp3ha@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36517|0                           |1
        is obsolete|                            |

--- Comment #19 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36522
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36522&action=edit
Bug 1985 - tweak License and lots of cleanup

In comment #11, it was mentioned that title and biblionumber from
the biblio table were not available as variables in the letter.

This corrects this by converting the parameter list to a hashref,
and adding the missing biblio number.

It also cleans up the license on C4/Review.pm to be in line with
the current coding guidelines license. Also strict and warning
have been changed to the 'Use Modern::Perl;' now.

Additionally, <<reviews.reviewid>> is now usable in the letter,
as is <<StaffBaseURL>>. These were required additions, because
comment #1 expressly says there should be a direct link to
approve or delete. I also included a review everything link,
since there could be multiple comments outstanding.

The default letter was tweaked as well to reflect these changes.

TEST PLAN
---------
1) Create test branch and apply patch
2) run installer/data/mysql/updatedatabase.pl
   -- this will add the required default letter.
3) In the staff client:
   a) set the CommentModeratorsEmail system preference.
      -- not setting it will mean you won't get any queued
         letters.
   b) modify the COMMENT_CREATED default letter as desired.
      -- feel free to add other things.
4) In the OPAC:
   a) Log in
   b) Find something
   c) Click on the 'Comments' tab
      -- Holdings/Title notes/Comments (#) is at the bottom
   d) Click 'Post or edit your comments on this item'
   e) In the window that pops up, type your comment.
   f) Click 'Submit and close this window'.
   g) Click 'Edit' and repeat steps e and f again.
5) In a mysql client:
   a) Open the koha database
   b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED';
      -- There should be at least two.
      -- They should be able to contain the borrower number, biblio
         title, and other borrower and biblio related things.
      -- Comments are at a biblio level, so items, and issues don't
         make sense as variables for the letter.
6) prove -v t/db_dependent/Review.t
7) Run the koha qa test tool.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:45:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:45:24 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-jCwF115xCg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #20 from M. Tompsett <mtompset at hotmail.com> ---
Ignore comments #10 and #17. My second commit covers all that. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:45:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:45:26 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-43VhDFZfvl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:45:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:45:30 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-1ZOl4NAY72@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32870|0                           |1
        is obsolete|                            |

--- Comment #68 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36523
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36523&action=edit
Bug 11998 - timeout for syspref caching

This adds a 30 second timeout for syspref caching so that when run under
plack, you don't end up with different workers having different ideas of
what the sysprefs are for too long.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:45:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:45:36 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-7simT5ccIh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32871|0                           |1
        is obsolete|                            |

--- Comment #69 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36524
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36524&action=edit
Bug 11998 - move most syspref db access into Context.pm

There was a lot of direct database access in systempreferences.pl. This
moves a lot of it into C4::Context so that it'll interact with caching
better, and to centralise common functions and logging in one place.

Test plan:
* Make sure that creating, editing, deleting local use preferences works
* Make sure that other system preferences still function normally

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:45:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:45:44 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-ZIt56P8Fl7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32872|0                           |1
        is obsolete|                            |

--- Comment #70 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36525
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36525&action=edit
Bug 11998 - sysprefs in memcached

The caching mechanism has been abstracted a little bit, and now supports
memcached for storing sysprefs. These should be correctly stored and
cleared so caching will work between processes.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:45:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:45:50 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-KNhWmLLyUV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32873|0                           |1
        is obsolete|                            |

--- Comment #71 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36526
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36526&action=edit
Bug 11998 - add test case, fix issue found

Adds a test case with improved coverage of the caching functionality.
Fixes a bug that was uncovered by writing the test case.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:46:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:46:03 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-n0LTGJSplO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32874|0                           |1
        is obsolete|                            |

--- Comment #72 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36527
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36527&action=edit
Bug 11998 - make syspref caching use Koha::Cache

This modifies the caching system in C4::Context to use Koha::Cache
instead of a custom implementation.

It should be applied on top of the other syspref caching patches.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:46:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:46:08 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-oJEZmeNQ44@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33183|0                           |1
        is obsolete|                            |

--- Comment #73 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36528
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36528&action=edit
Bug 11998: QA follow-up - fix the perlcritic error

% perlcritic C4/Context.pm
Variable declared in conditional statement at line 544, column 5.
Declare variables outside of the condition.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:46:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:46:14 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-i0bqdX3sMO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33670|0                           |1
        is obsolete|                            |

--- Comment #74 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36529
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36529&action=edit
Bug 11998 - fix compile warnings

This creates a simplified logging system that can be used by
C4::Context.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:46:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:46:19 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-1IAvFYh7jc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33724|0                           |1
        is obsolete|                            |

--- Comment #75 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36530
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36530&action=edit
Bug 11998 - remove logging from places where it shouldn't be

This prevents duplicate action_log entries when a preference is updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:46:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:46:25 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-Tcu2FGEc8v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33725|0                           |1
        is obsolete|                            |

--- Comment #76 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36531
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36531&action=edit
Bug 11998 - fix test case so it's testing the cache properly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:46:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:46:31 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-nxWNAVQ4i8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33746|0                           |1
        is obsolete|                            |

--- Comment #77 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36532
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36532&action=edit
Bug 11998: Add Koha::Config::SystemPreference

This (dirty) patch extract the syspref set and delete routine into a
module.
It fixes the circular dependency and the logging problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:46:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:46:37 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-ZHCsMzXpUU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33829|0                           |1
        is obsolete|                            |

--- Comment #78 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36533
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36533&action=edit
Bug 11998 - tidy up the Koha::Config::SystemPreferences module a bit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:46:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:46:43 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-I6pGU34BRa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33940|0                           |1
        is obsolete|                            |

--- Comment #79 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 36534
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36534&action=edit
Bug 11998 - fix some compile warnings

This lazy-loads C4::Context and some other modules so that they can be
be safely used by C4::Context without introducing problematic circular
dependencies.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 05:59:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 04:59:31 +0000
Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password
In-Reply-To: <bug-13143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13143-70-M7mj29QoZN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #18 from Robin Sheat <robin at catalyst.net.nz> ---
My issue is that the pausing thing means it can't be used within a script.

It shouldn't say "password for x is y", it should just output the password, and
it should only block if it's outputting to a terminal, otherwise it'll block
forever.

A test for this is here:

http://stackoverflow.com/questions/911168/how-to-detect-if-my-shell-script-is-running-through-a-pipe

running koha-passwd instance | cat should output the password and then finish
without issuing a clear or anything. This makes it easy for people who need the
password as part of some other shell script.

Additionally, it'd probably be good (although I wouldn't consider it a blocker)
to make a function in koha-functions.sh to fetch the password and use that,
that way other scripts in the koha-* set can use that (if you're really keen
you can change them to use it, but certainly don't consider than necessary.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 06:01:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 05:01:57 +0000
Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list.
In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11881-70-vE6AP6e3x9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #30 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #27)
> The opac.css does not look good.
> With your patch:
> -rw-r--r-- 1 koha koha 42132 Mar  4 16:25 bootstrap/css/opac.css
> 
> $lessc --compress bootstrap/less/opac.less > bootstrap/css/opac.css
> -rw-r--r-- 1 koha koha 42946 Mar  4 16:25 bootstrap/css/opac.css

mtompset at ubuntu:~/kohaclone$ git reset --hard origin/master                HEAD
is now at 45e5afb Bug 13731: Suggestions reason does not save on updating the
status
mtompset at ubuntu:~/kohaclone$ ls -la koha-tmpl/opac-tmpl/bootstrap/css/opac.css
-rw-rw-r-- 1 mtompset mtompset 42879 Mar  5 00:01
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
mtompset at ubuntu:~/kohaclone$ lessc --compress
koha-tmpl/opac-tmpl/bootstrap/less/opac.less >
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
mtompset at ubuntu:~/kohaclone$ ls -la koha-tmpl/opac-tmpl/bootstrap/css/opac.css
-rw-rw-r-- 1 mtompset mtompset 43371 Mar  5 00:01
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
mtompset at ubuntu:~/kohaclone$

I don't think it is this patch per say.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 06:45:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 05:45:39 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-5WSsTIcjq8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #41 from Robin Sheat <robin at catalyst.net.nz> ---
FYI, the catalyst repo branch now has basic authority search working. There's
still a good bit to do (paging, biblio counts, many more things aren't there
yet), but results are coming out so I'm counting that as a win :)

You can see it in action here:

http://elasticsearch.koha.catalystdemo.net.nz/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=robert&marclist=any&and_or=and&orderby=HeadingAsc

I think the fact that there are so many Jordan, Roberts is due to the data, but
I haven't actually checked yet. At the moment it just replicates how the zebra
version works, but I do want to push some of the things into the indexing side
so that there's less computation needed to display results and things can
perhaps be made a bit simpler. We can do this because we can store arbitrary
fields in elasticsearch alongside the actual records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 08:10:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 07:10:54 +0000
Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for
 checking in items that are not checked out
In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13411-70-pRPogo00Rt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Colin, could you take a look at this again please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 08:13:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 07:13:41 +0000
Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in
 cataloguing/item editor
In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10480-70-C8hmWaAcb4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this probably shouldn't go on to the stable branches as it would break
custom plugins the library might have. As the title says "improvements"
switching to "enh" - but I know it's not quite.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 08:34:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 07:34:13 +0000
Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in
 cataloguing/item editor
In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10480-70-8kEjTePSUX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

--- Comment #36 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #35)
> I think this probably shouldn't go on to the stable branches as it would
> break custom plugins the library might have. 

Do you have any reasons to say that it would break custom plugins? Part of some
complexity here is backward compatibility.
BTW I agree that this is not targeted for the stable branches in the first
place.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:04:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 08:04:21 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-03ouEWM2mJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Charles Farmer from comment #8)
> I read _insert_accountlines again and adapted manualinvoice to take its
> place. I also removed the *return* instruction at the end of
> chargelostitem() because, as you said, it wasn't used anywhere (except once
> in ChargeLostItem.t)
> 
> Thank you for your time!

Thanks for those fixes!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:06:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 08:06:10 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-8SEeJBEEk7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:35:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 08:35:37 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-VH4zB5j27G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:35:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 08:35:40 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-Z5PT7uKIq0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36392|0                           |1
        is obsolete|                            |

--- Comment #4 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36535
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36535&action=edit
Bug 13773 - add stock number to details and items display

This patch adds stocknumber (named Inventory number in interface)
to details table and items display if it exists.

Test scenario:
1. find item(s) which have inventory number assigned
2. verify that you don't see inventory number in items display
3. apply this patch
4. verify that inventory number is now available

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:36:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 08:36:33 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-kGRWTuPDHV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

--- Comment #5 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Nicole, can I bother you for another sign-off? I decided not to make follow up,
because I think that master doesn't need two commits for such a simple change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:40:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 08:40:47 +0000
Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable
	version
In-Reply-To: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12399-70-i5Sztbk9Od@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:40:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 08:40:50 +0000
Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable
	version
In-Reply-To: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12399-70-ZJftyxCB4l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36263|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36536
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36536&action=edit
[PASSED QA] Bug 12399 - opaccredits printing at top on printable version

This patch introduces a new class "noprint" in
koha-tmpl/opac-tmpl/bootstrap/css/print.css
With this class, unwanted elements can be hidden when printing.

To test:
In OPAC, do a search with many results (> 1 Page)
Print page or do a print preview
See that footer elements are not displayed correctly (as of screenshot in
comment #1) and that on top of page 2 the language selector overlays the list
Apply patch
Repeat steps above.
Verify that printed page looks much nicer now by hiding unwanted elements
(including e.g. RSS icon, toolbar etc.)

This mechanism can be used on other pages as well.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:41:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 08:41:26 +0000
Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable
	version
In-Reply-To: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12399-70-BRZq1YbvFm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36537
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36537&action=edit
Bug 12399: Small change to remove the whole paging

Previous patch only removed the next and previous buttons.
This patch changes it a bit to remove the whole paging from
the print view of the page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:46:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 08:46:54 +0000
Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable
	version
In-Reply-To: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12399-70-5FF5s6C60z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399

--- Comment #7 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36538
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36538&action=edit
Bug 12399 - opaccredits printing at top on printable version

This patch introduces a new class "noprint" in
koha-tmpl/opac-tmpl/bootstrap/css/print.css
With this class, unwanted elements can be hidden when printing.

To test:
In OPAC, do a search with many results (> 1 Page)
Print page or do a print preview
See that footer elements are not displayed correctly (as of screenshot in
comment #1) and that on top of page 2 the language selector overlays the list
Apply patch
Repeat steps above.
Verify that printed page looks much nicer now by hiding unwanted elements
(including e.g. RSS icon, toolbar etc.)

This mechanism can be used on other pages as well.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:47:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 08:47:10 +0000
Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable
	version
In-Reply-To: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12399-70-e1MN0gFsHI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36537|0                           |1
        is obsolete|                            |

--- Comment #8 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36539
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36539&action=edit
Bug 12399: Small change to remove the whole paging

Previous patch only removed the next and previous buttons.
This patch changes it a bit to remove the whole paging from
the print view of the page.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 09:48:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 08:48:15 +0000
Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable
	version
In-Reply-To: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12399-70-NJEeNlvhDK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m
  Attachment #36538|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:07:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:07:32 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-jRhc3TjAYA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:07:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:07:35 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-SLeWNbKQ6B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36501|0                           |1
        is obsolete|                            |

--- Comment #5 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36540
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36540&action=edit
Bug 13789 - facets with accented utf-8 characters generate double encoded links

Bug 13425 tried to fix XSS in OPAC, by using url filter in template toolkit
on whole generated url. This doesn't work and create double encoded strings
in facets because we are creating url variable by concatenating query_cgi
(which did pass through uri_escape_utf8 on perl side) and other
parameters which have to be escaped in template.

Also, code like

[% SET limit_cgi_f = limit_cgi | url %]

doesn't do anything (at least doesn't apply url filter) so it's not needed.

This patch also fixes encoding of hidden fields used in sort by form.

And lastly, it tries to make facet changes for opac and intranet as same as
possible to simplify future maintencence of this code.

Test scenario:
1. find results in your opac which contain accented characters
2. click on them and verify that results are missing
3. apply this patch
4. re-run search and click on facets link verifying that there are
   now results
5. test sort by form and verify that results are ok
6. verify that facets are still safe from injection by constructing url like
  
/cgi-bin/koha/opac-search.pl?q=123&sort_by='"><script>prompt('Happy_Holidays')</script>&limit=123
   and verifying that you DON'T see prompt window in your browser

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:11:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:11:46 +0000
Subject: [Koha-bugs] [Bug 11311] Browse selected authorities
In-Reply-To: <bug-11311-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11311-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11311-70-4rJtWQXa7d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311

fpichenot at ville-roubaix.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fpichenot at ville-roubaix.fr

--- Comment #6 from fpichenot at ville-roubaix.fr ---
Install

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:12:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:12:50 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-amYADktjrP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #21 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
I have just tested it. Everything is fine except that <<staffClientBaseURL>>
isn't filled in the email : 
...
BEGIN COMMENT --- A lire absolument --- END COMMENT --- To approve:
http:///cgi-bin/koha/review/reviewswaiting.pl?op=approve&reviewid=10 To delete:
http:///cgi-bin/koha/review/reviewswaiting.pl?op=delete&reviewid=10 Or to
review all comments: http:///cgi-bin/koha/review/reviewswaiting.pl Check it
out! Your library.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:13:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:13:19 +0000
Subject: [Koha-bugs] [Bug 11311] Browse selected authorities
In-Reply-To: <bug-11311-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11311-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11311-70-Kn2rWF7rov@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311

--- Comment #7 from fpichenot at ville-roubaix.fr ---
Installation failed on sandbox :


The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 10858 11311:
<h1>Something went wrong !</h1>Applying: Bug 10858: Browse selected biblios
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-detail.pl
CONFLICT (content): Merge conflict in opac/opac-detail.pl
CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
deleted in HEAD and modified in Bug 10858: Browse selected biblios. Version Bug
10858: Browse selected biblios of
koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt left in tree.
CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
deleted in HEAD and modified in Bug 10858: Browse selected biblios. Version Bug
10858: Browse selected biblios of
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt left in tree.
CONFLICT (modify/delete):
koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc deleted in HEAD and
modified in Bug 10858: Browse selected biblios. Version Bug 10858: Browse
selected biblios of koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc
left in tree.
CONFLICT (modify/delete):
koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc deleted in HEAD and
modified in Bug 10858: Browse selected biblios. Version Bug 10858: Browse
selected biblios of koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc
left in tree.
Failed to merge in the changes.
Patch failed at 0001 Bug 10858: Browse selected biblios

When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 10858 - Browse selected biblios

25643 - Bug 10858: Browse selected biblios
25644 - Bug 10858 [Follow-up] Browse selected biblios
25645 - Bug 10858: FIX error if no biblio is selected
25646 - Bug 10858: Don't use the cookie if the ft is disabled
25647 - Bug 10858: Browse selected biblios - bootstrap
25648 - Bug 10858: FIX the Browse selected link
25649 - Bug 10858: FIX Only one occurrence of the biblionumbers should be
stored
25650 - Bug 10858: Replace Browse results with Browse selected results
25651 - Bug 10858: fix bad merge conflict
25652 - Bug 10858: follow-up Don't use the cookie if the ft is disabled
25653 - Bug 10858: Handle JS deactivated and cookies disabled

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-10858-Browse-selected-biblios-_uhkSZ.patch .
sandbox is not ready !
Admin User Koha

Jeudi 05 Mars 2015 10:04
A :     
fpichenot at ville-roubaix.fr

Afficher les d?tails


The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 10858 11311:
<h1>Something went wrong !</h1>Applying: Bug 10858: Browse selected biblios
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-detail.pl
CONFLICT (content): Merge conflict in opac/opac-detail.pl
CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
deleted in HEAD and modified in Bug 10858: Browse selected biblios. Version Bug
10858: Browse selected biblios of
koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt left in tree.
CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
deleted in HEAD and modified in Bug 10858: Browse selected biblios. Version Bug
10858: Browse selected biblios of
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt left in tree.
CONFLICT (modify/delete):
koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc deleted in HEAD and
modified in Bug 10858: Browse selected biblios. Version Bug 10858: Browse
selected biblios of koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc
left in tree.
CONFLICT (modify/delete):
koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc deleted in HEAD and
modified in Bug 10858: Browse selected biblios. Version Bug 10858: Browse
selected biblios of koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc
left in tree.
Failed to merge in the changes.
Patch failed at 0001 Bug 10858: Browse selected biblios

When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 10858 - Browse selected biblios

25643 - Bug 10858: Browse selected biblios
25644 - Bug 10858 [Follow-up] Browse selected biblios
25645 - Bug 10858: FIX error if no biblio is selected
25646 - Bug 10858: Don't use the cookie if the ft is disabled
25647 - Bug 10858: Browse selected biblios - bootstrap
25648 - Bug 10858: FIX the Browse selected link
25649 - Bug 10858: FIX Only one occurrence of the biblionumbers should be
stored
25650 - Bug 10858: Replace Browse results with Browse selected results
25651 - Bug 10858: fix bad merge conflict
25652 - Bug 10858: follow-up Don't use the cookie if the ft is disabled
25653 - Bug 10858: Handle JS deactivated and cookies disabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:18:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:18:51 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-20INuz6OR0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Peter Zhao <peterzhaonj at 163.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |peterzhaonj at 163.com

--- Comment #42 from Peter Zhao <peterzhaonj at 163.com> ---
(In reply to Robin Sheat from comment #41)
> FYI, the catalyst repo branch now has basic authority search working.
> There's still a good bit to do (paging, biblio counts, many more things
> aren't there yet), but results are coming out so I'm counting that as a win
> :)
> 
> You can see it in action here:
> 
> http://elasticsearch.koha.catalystdemo.net.nz/cgi-bin/koha/opac-authorities-
> home.
> pl?op=do_search&type=opac&operator=contains&value=robert&marclist=any&and_or=
> and&orderby=HeadingAsc
> 
> I think the fact that there are so many Jordan, Roberts is due to the data,
> but I haven't actually checked yet. At the moment it just replicates how the
> zebra version works, but I do want to push some of the things into the
> indexing side so that there's less computation needed to display results and
> things can perhaps be made a bit simpler. We can do this because we can
> store arbitrary fields in elasticsearch alongside the actual records.

Dear Robin,
          It is a great job! Thanks a lot. I tried to install a ES.
          It seems to index the biblio. But I can't search the record."No
results found!" I can find the record by Zebra.
          koha at koha:~$
/home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl -v -d
Indexing biblios
1

           Could you give some advice?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:21:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:21:03 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-37N2wtleZp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |String patch
         Depends on|                            |13575
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:21:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:21:03 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-EXCHtui1KI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7143

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:21:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:21:13 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-HIznGutjyv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #231 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36541
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36541&action=edit
BUG 7143: Add Kyle Hall as the 42nd developer to history

I found Kyle's first commit and added him to the history

http://lists.gnu.org/archive/cgi-bin/namazu.cgi?query=kyle&submit=Search!&idxname=koha-cvs&max=20&result=normal&sort=date%3Aearly

While in there I added tags to releases and developers that were missing.

To test:

* Log in to staff client
* visit about koha
* check to make sure timeline is right

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:32:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:32:59 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-lO7nZUCn49@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36541|0                           |1
        is obsolete|                            |

--- Comment #232 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36542
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36542&action=edit
BUG 7143: Add Kyle Hall as the 42nd developer to history

I found Kyle's first commit and added him to the history

http://lists.gnu.org/archive/cgi-bin/namazu.cgi?query=kyle&submit=Search!&idxname=koha-cvs&max=20&result=normal&sort=date%3Aearly

While in there I added tags to releases and developers that were missing.

To test:

* Log in to staff client
* visit about koha
* check to make sure timeline is right

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:37:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:37:33 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-jz5xL244mf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 36512
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36512
Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC

Review of attachment 36512:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12528&attachment=36512)
-----------------------------------------------------------------

::: opac/opac-messaging.pl
@@ +69,5 @@
>                    SMSnumber => defined $borrower->{'smsalertnumber'} ? $borrower->{'smsalertnumber'} : $borrower->{'mobile'},
>                    SMSSendDriver                =>  C4::Context->preference("SMSSendDriver"),
> +                  TalkingTechItivaPhone        =>  C4::Context->preference("TalkingTechItivaPhoneNotification"),
> +                  admin                        =>  C4::Context->preference('KohaAdminEmailAddress'),
> +                  Authorized                   =>  C4::Context->preference('OPACEnhancedMessagingPreferences'));

Please use the Koha plugin to access system preference values from the
templates ([% IF Koha.Preference('OPACEnhancedMessagingPreferences') %]).
And maybe EnhancedMessagingPreferences should be checked too, according to the
description of the syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:37:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:37:46 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-GQI04BnZNb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:37:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:37:48 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-vfI0eQzKSe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:37:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:37:52 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-B6we21uFHh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36542|0                           |1
        is obsolete|                            |

--- Comment #233 from Larry Baerveldt <larry at bywatersolutions.com> ---
Created attachment 36543
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36543&action=edit
BUG 7143: Add Kyle Hall as the 42nd developer to history

I found Kyle's first commit and added him to the history

http://lists.gnu.org/archive/cgi-bin/namazu.cgi?query=kyle&submit=Search!&idxname=koha-cvs&max=20&result=normal&sort=date%3Aearly

While in there I added tags to releases and developers that were missing.

To test:

* Log in to staff client
* visit about koha
* check to make sure timeline is right

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:40:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:40:06 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-u21mOxTrXu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36543|0                           |1
        is obsolete|                            |

--- Comment #234 from Larry Baerveldt <larry at bywatersolutions.com> ---
Created attachment 36544
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36544&action=edit
BUG 7143: Add Kyle Hall as the 42nd developer to history

I found Kyle's first commit and added him to the history

http://lists.gnu.org/archive/cgi-bin/namazu.cgi?query=kyle&submit=Search!&idxname=koha-cvs&max=20&result=normal&sort=date%3Aearly

While in there I added tags to releases and developers that were missing.

To test:

* Log in to staff client
* visit about koha
* check to make sure timeline is right

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:44:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:44:23 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-plHDECK3NF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

aloij <aloi54 at live.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aloi54 at live.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:49:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:49:01 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-UXAByWS6Zj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #235 from Nicole C. Engard <nengard at gmail.com> ---
Note that my patch depends on bug 15375 (listed as a dependency above) since
that has passed qa already.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:49:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:49:14 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-4HpztezPvX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #236 from Nicole C. Engard <nengard at gmail.com> ---
bug 13575

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:54:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:54:50 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-7HjDyFVXm0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

LuceBarbey <luce.barbey at cirad.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luce.barbey at cirad.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:57:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:57:02 +0000
Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout
 confirmation dialog when checking out a reserved item.
In-Reply-To: <bug-11882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11882-70-YOPdNkCbOR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:57:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:57:12 +0000
Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout
 confirmation dialog when checking out a reserved item.
In-Reply-To: <bug-11882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11882-70-S9jEyvfODi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36197|0                           |1
        is obsolete|                            |

--- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36545
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36545&action=edit
Bug 11882 - Add a new button to the checkout confirmation dialog when checking
out a reserved item

This patch adds a "Don't Check Out and Print Slip" button to the dialog that
appears
        when trying to checkout a reserved item.

Test case :
* Put a hold on an item for User A.
* Try to check out it item with User B.
* The "Please confirm checkout" box should appear. The "Don't Check Out and
Print Slip" button should appear in this box.
* Click on the "Don't Check Out and Print Slip" button.
* A print popup will appear

Signed-off-by: Nick <Nick at quechelibrary.org>

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 10:59:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 09:59:37 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-mtD4VKCt6V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36454|0                           |1
        is obsolete|                            |

--- Comment #2 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36546
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36546&action=edit
Bug 13793: Make the installer output the result of the updates under Plack

Test plan:
0/ Start plack for intranet
1/ Create a new entry in updatedatabase.pl, something like:

$DBversion = "3.19.00.013";
if(CheckVersion($DBversion)) {
    print "Upgrade to $DBversion done (Bug test plack - This is a
est)\n";
    print "Upgrade to $DBversion done (Bug test plack - This is anoter
est)\n";
    print "Upgrade to $DBversion done (Bug test plack - This is a third
est)\n";
    warn "this is an error";
}
and modify the kohaversion.pl accordingly.
You can also warn something to simulate an error.
2/ Go on the mainpage (or wherever you want), you should be redirected
to the installer
3/ Notice that the output of the updatedatabase is displayed on the
screen.
4/ Confirm that new files have been created in your Koha log directory
(check the logdir entry in your koha conf file).
5/ Confirm that the output is still displayed without Plack.

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:00:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:00:00 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-UJKbDj5xQh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |dpavlin at rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:04:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:04:14 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-sOdTEP5WEZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

LuceBarbey <luce.barbey at cirad.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luce.barbey at cirad.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:05:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:05:16 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-ciTe397Bke@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #18 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36547
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36547&action=edit
Bug 13771: Update manage staged marc help for 3.18

This updates the manage staged marc files help.

To test:

* Visit Tools > Staged MARC record management
* Click help
* Confirm it's there and correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:05:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:05:12 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-s8bOP0OGS9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:21:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:21:44 +0000
Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name
 on patron details
In-Reply-To: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13657-70-CnzgUg27kb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:21:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:21:48 +0000
Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name
 on patron details
In-Reply-To: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13657-70-XGg2sjwEHq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36266|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36548
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36548&action=edit
[PASSED QA] Bug 13657 - Don't show extra comma after guarantor name on patron
details

This patch suppresses the first name part (including comma) if first name is
empty. This way, first name is still displays with natural persons, but not
with organizations.

To test:
Apply this patch (without the first patch).
Have one patron with a natural person as guarantor and one patron with an
organization as guarantor. Verify that both display properly on the patron
details page.

Signed-off-by: Jesse Maseto <Jesse at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:24:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:24:24 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-xt8eySBuvx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |koha at univ-lyon3.fr

--- Comment #6 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Tested on a sandbox :
1. I've Changed this syspref : casAuthentication (use), casServerUrl,
OPACBaseURL
2. Go to the opac and connect this CAS authentication
3. refresh the page (I've tried F5 and the refresh button) : I'm still logged
in.
4. I've tried to deconnect and reconnect : no problem.

It works !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:26:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:26:49 +0000
Subject: [Koha-bugs] [Bug 13778] lists buttons ugly
In-Reply-To: <bug-13778-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13778-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13778-70-m3jI2JJpcl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
I like that idea.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:27:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:27:28 +0000
Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export
In-Reply-To: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13695-70-WG4RN1YNd6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Hugo Agud from comment #8)
> We have applied the patch and it works, but we have found some issues

Hugo, I don't reproduce the encoding issue (pmvers Encode: 2.60).
Is it expected to retrieve a file with the html tag?
IMO the ISBD generated file should be a simple text file, don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:31:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:31:11 +0000
Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export
In-Reply-To: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13695-70-nEcneF85ES@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695

--- Comment #10 from Hugo Agud <hagud at orex.es> ---
(In reply to Jonathan Druart from comment #9)
> (In reply to Hugo Agud from comment #8)
> > We have applied the patch and it works, but we have found some issues
> 
> Hugo, I don't reproduce the encoding issue (pmvers Encode: 2.60).
> Is it expected to retrieve a file with the html tag?
> IMO the ISBD generated file should be a simple text file, don't you think?

Yes txt is desirable of course, we just did that change becasue we were in a
hurry to push to the server.

We faced problems with diacritics (spanish), I will chech the encoding againg,
thanks for the tip

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:31:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:31:32 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-iyNcqCLQfY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:32:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:32:58 +0000
Subject: [Koha-bugs] [Bug 13766] biblioitems.ean field is too short
In-Reply-To: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13766-70-ZfYNEaHIzb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Fr?d?ric, I got an error on executing the updatedb entry:

DBD::mysql::db do failed: BLOB/TEXT column 'ean' used in key specification
without a key length at installer/data/mysql/updatedatabase.pl line 9798.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:34:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:34:15 +0000
Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format
	dates
In-Reply-To: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4402-70-Fe2biqEkh9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:34:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:34:23 +0000
Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format
	dates
In-Reply-To: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4402-70-2DadM5TIKW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36402|0                           |1
        is obsolete|                            |

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36549
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36549&action=edit
[PASSED QA] Bug 4402: Date filter on parcels.tt required db date format

The date filters on the parcel page would only work with
dates formatted YYYY-MM-DD.

To test:
- Select a vendor, that already has a few invoices
- "Receive shipment" - you are on the parcels page
- Use the From and To filters on the left, notice there
  is now a date picker on those fields
- Verify the search works correctly for different date
  formats

Signed-off-by: Nicole <nicole at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:38:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:38:35 +0000
Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new
	search
In-Reply-To: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12460-70-zarhwC7SLA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

LuceBarbey <luce.barbey at cirad.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:39:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:39:21 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-MUPIrW4USY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:39:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:39:24 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-BH357gvFjv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #19 from Larry Baerveldt <larry at bywatersolutions.com> ---
Created attachment 36550
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36550&action=edit
[SIGNED OFF] Bug 13771: Update manage staged marc help for 3.18

This updates the manage staged marc files help.

To test:

* Visit Tools > Staged MARC record management
* Click help
* Confirm it's there and correct

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:41:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:41:33 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-BfpX2yAzOC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36547|0                           |1
        is obsolete|                            |
  Attachment #36550|0                           |1
        is obsolete|                            |

--- Comment #20 from Larry Baerveldt <larry at bywatersolutions.com> ---
Created attachment 36551
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36551&action=edit
[SIGNED OFF] Bug 13771: Update manage staged marc help for 3.18

This updates the manage staged marc files help.

To test:

* Visit Tools > Staged MARC record management
* Click help
* Confirm it's there and correct

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:44:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:44:51 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-jjcRkkthoJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|mirko at abunchofthings.net    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:47:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:47:16 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-aRt2k1DFlR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:47:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:47:20 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-z7zaJbCBDW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36506|0                           |1
        is obsolete|                            |

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36552
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36552&action=edit
Bug 12768 [QA Followup] - Fix unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:48:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:48:37 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-q5cGEYA9hz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36552|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36553
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36553&action=edit
Bug 12768 [QA Followup] - Fix unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:49:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:49:29 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-YLkgra1D5i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36554
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36554&action=edit
[SIGNED-OFF] Bug 12768 - Replacement cost and processing fee management

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:50:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:50:03 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-N3hTOpfXdJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36553|0                           |1
        is obsolete|                            |

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36555
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36555&action=edit
Bug 12768 [QA Followup] - Fix unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:56:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:56:37 +0000
Subject: [Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
In-Reply-To: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13787-70-ESyGzINOFk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10937

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:56:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:56:37 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-KmG9UySDzg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13787

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:57:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:57:14 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-wkcxHeoaYc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

--- Comment #7 from LuceBarbey <luce.barbey at cirad.fr> ---
I've also tested and it works for me too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:59:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:59:13 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-Gnor5WkiwT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:59:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:59:19 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-8BNJy85Aeb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36535|0                           |1
        is obsolete|                            |

--- Comment #6 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36556
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36556&action=edit
[SIGNED-OFF] Bug 13773 - add stock number to details and items display

This patch adds stocknumber (named Inventory number in interface)
to details table and items display if it exists.

Test scenario:
1. find item(s) which have inventory number assigned
2. verify that you don't see inventory number in items display
3. apply this patch
4. verify that inventory number is now available

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:59:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:59:34 +0000
Subject: [Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
In-Reply-To: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13787-70-B8bxGaocYA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 11:59:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 10:59:38 +0000
Subject: [Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
In-Reply-To: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13787-70-Fwtfk0JX2b@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36436|0                           |1
        is obsolete|                            |

--- Comment #2 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36557
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36557&action=edit
Bug 13787 - Clean up noisy opac-advsearch warnings

While testing bug 10937, there were noisy warnings, which
distracted from testing the functionality of it.

Here is a snippet of the after the patch warnings:
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 384.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.

Tweaking the [% IF %] statements eliminated the warnings.

TEST PLAN
---------
1) Apply patch
2) Run koha qa test tools.
   -- there will be noisy warnings in the before processing, but
      there will be no such messages in the after processing.
3) git diff origin/master
   -- there should be no visible typos.

Signed-off-by: Magnus Enger <magnus at enger.priv.no>
- Applied the patch from bug 10937
- Ran "koha-qa.pl -c 1" and observed the warnings described in the
  commit message
- Applied the patch from this bug
- Ran "koha-qa.pl -c 1" again and saw no warnings
- Ran "koha-qa.pl -c 2" and saw no warnings

I have not tested the functionality of 10937 with this patch, just verified
that the changes look sensible.

This patch feels more like a followup for 10937, than a separate patch,
especially since 10937 is just "signed off" at this time. But as long as it
works...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:00:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:00:14 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-JWpszibqg5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #57 from Magnus Enger <magnus at enger.priv.no> ---
It might be a good idea to QA bug 13787 at the same time as this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:00:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:00:52 +0000
Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with
 diacritics, utf-8 or ttf fonts
In-Reply-To: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13709-70-9bhPIRExa1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:00:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:00:56 +0000
Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with
 diacritics, utf-8 or ttf fonts
In-Reply-To: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13709-70-EnaanHGorX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36264|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36558
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36558&action=edit
Bug 13709 - Patron cards creator utf-8 encoding and ttf fonts broken

This change is similar to Bug 8375 which introduced ttf fonts for
labels printing in order to support diacritics and utf-8 encoding,
but this change was never implemented for patron cards.

Test scenario:

1. make sure that you have <ttf> font mapping in koha-conf.xml
2. define partron card layout, template, profile and batch
   (with utf-8 chars, probably in patron firstname or surname)
3. verify that without this patch pdf export file is error message
   Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820
4. apply this patch and verify that generated pdf has correct encoding

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:03:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:03:13 +0000
Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links
 authority records to a biblio record during edition. (AJAX)
In-Reply-To: <bug-11299-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11299-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11299-70-YGUXus1evr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

fpichenot at ville-roubaix.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fpichenot at ville-roubaix.fr

--- Comment #9 from fpichenot at ville-roubaix.fr ---
I don't see the "Link authorities automatically" button.

Does this patch still apply ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:04:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:04:49 +0000
Subject: [Koha-bugs] [Bug 2806] issuingbranch isn't used
In-Reply-To: <bug-2806-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2806-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2806-70-0L2DsM7oy4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:04:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:04:52 +0000
Subject: [Koha-bugs] [Bug 2806] issuingbranch isn't used
In-Reply-To: <bug-2806-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2806-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2806-70-Q0HJWzlh9q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36499|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36559
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36559&action=edit
[PASSED QA] Bug 2806: Remove issuingbranch columns

This column is not in used in the Koha code and could be removed.

Test plan:
Verify the branch is correctly displayed on the circulation history
(members/readingrec.pl) and that both reports Most-cisulated items
(cat_issues_top.pl) and Avg checkout (issues_avg_stats.pl) work as
before.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No problems found.
Fixed wrong table name on updatedatabase.pl and a tab char.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes tests and QA script.
Checked issues and returns are still working correctly.
There is no mention of issuingbranch in the codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:06:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:06:37 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-Axz3urVrub@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

--- Comment #6 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
good catch, Jonathan! If a patron enables multiple message types, and a message
type is missing a template, it would return before processing the remaining
types.

A simple fix, as suggested, is to use next instead of return

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:08:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:08:15 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-pVMc89rYL6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com

--- Comment #21 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by JA <aloi54 at live.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:08:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:08:39 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-s9fGtYk9T8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36319|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:08:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:08:43 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-WwJP4biTap@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36320|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:08:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:08:49 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-2ZiYWM7d8B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36361|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:08:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:08:53 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-7VqFnMLwb2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36456|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:08:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:08:57 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-RnfTZ4IOUr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36503|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:09:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:09:02 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-gxbYOkNhiL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36551|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:09:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:09:21 +0000
Subject: [Koha-bugs] [Bug 13791] Plack out of the box
In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13791-70-3sYHSBfKY5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11998

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:09:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:09:21 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-vxT8EMBGJN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13791

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:09:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:09:22 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-fWSXb9gZUM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #22 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36560
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36560&action=edit
Bug 13753: koha-indexer contains invalid statement

An incorrect conditional makes the indexer daemon fail to load.

To test:
- Enable the indexer daemon on packages [1]
- Restart koha-common:
  $ service koha-common restart
- Run
  $ ps waux | grep koha-indexer
=> FAIL: there's no reference to the rebuild_zebra.pl script
  (line should look like *rebuild_zebra.pl -daemon*)
   Run ps -ef | grep rebuild_zebra.pl too to make sure.
- Apply the patch, repeat the steps
=> SUCCESS: the rebuild_zebra.pl script is ran
- Sign off :-D

Thanks

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:09:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:09:25 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-AnwzXzIZh5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #23 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36561
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36561&action=edit
Bug 13759 - git-build-snapshot misses YUI and dies of sorrow during build

Due to a line in debian/rules, git-build-snapshot tries to delete a YUI-related
path that does not exist anymore (bug 13612 I guess). Build process ends with
an error.
This patch deletes the line.

Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:09:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:09:28 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-JUAD5KhjGw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #24 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36562
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36562&action=edit
Bug 13676 - OpacSuppression description says 'items' but means 'records'

This patch changes the wording for the OpacSuppression preference description.

Without patch:
... items marked as suppressed from OPAC search results. Note that you must
have the <code>Suppress</code> index set up in Zebra and at least one
suppressed item, or your searches will be broken. ...

With patch:
... items marked as suppressed from OPAC search results. Note that you must
have the <code>Suppress</code> index set up in Zebra and at least one
suppressed biblio record, or your searches will be broken. ...

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:09:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:09:31 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-Y0NCs1eGNv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #25 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36563
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36563&action=edit
Bug 13741: "No fund found" is not translatable

The string "No fund found" on the funds overview page is
not translatable.

To test:
- Create a new budget
- Check for the string on the funds page of the new budget
- Run an update on one of the po file sets
    cd misc/translator
    perl translate update <langcode>
- Verify that the string now appars in the po file for staff
- Verify the page still looks the same as before the patch

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:09:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:09:35 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-VI54UsUnNB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #26 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36564
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36564&action=edit
Bug 13745: Fix serial collection page to always show branch name

The serial collection page shows 2 tables, one for the subscriptions
and a second for the issues. Both show the branch, but the first
showed the code while the second showed the name.
With this patch both tables show the name.

To test:
- Search for a subscription or create one
- Navigate to the serial collection page (navigation on left side)
- Check both tables on the page show the branch name with
  the patch applied

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:09:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:09:38 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-LZgGFjGSLs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #27 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36565
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36565&action=edit
Bug 13731: Suggestions reason does not save on updating the status

On the suggestion list view, if you set a status, it won't be saved.

Test plan:
1/ Create a suggestion
2/ Go on the suggestion list view (suggestion/suggestion.pl)
3/ Select a suggestion and marked it as "rejected" (or the status you
want) and choose a reason
4/ Save
5/ Browse you suggestions DB table (using your favorite MySQL CLI) and
verify that the "reason" field is correctly filled.

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as expected, thx!

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:17:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:17:41 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-wQwD936AzK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

--- Comment #16 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36567
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36567&action=edit
Bug 13478: Database revision (new biblio column and pref description)

TEST PLAN:
[1] Run the database revision. Check if the new column is present.

Signed-off-by: Nick <nick at quecheelibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Added a new column to biblio instead of the new table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:17:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:17:34 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-aTndt5YVGt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36237|0                           |1
        is obsolete|                            |
  Attachment #36238|0                           |1
        is obsolete|                            |

--- Comment #15 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36566
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36566&action=edit
Bug 13478: Force item holds only for specific biblios

This patch adds the option to selectively force item holds for specific
biblionumbers.
The patch adds routine C4::Reserves::CheckBiblioForceItemHolds. It is
tested in Reserves.t.
The preference OPACItemHolds gets a new choice: selectiveforce.
The description of the pref is adjusted.

Please note that this option is specifically targeted for the OPAC. Staff
users still have both possibilities.

A follow-up report (13479) will add the possibility for staff users to
enable the forced item hold on biblio level.

TEST PLAN:
[ 1] Run the unit test t/db_dependent/Reserves.t.
[ 2] Set OPACItemHolds to force.
[ 3] Add a hold in the OPAC; verify that you cannot place a next/av hold.
[ 4] Set OPACItemHolds to Allow.
[ 5] Add a hold in the OPAC; verify that you can place both hold types.
[ 6] Set OPACItemHolds to Do not allow.
[ 7] Add a hold in the OPAC; verify that you can only place next/av holds.
[ 8] Enable forced item holds for two biblionumbers:
     UPDATE biblio SET forced_item_holds=1 WHERE biblionumber=?
[ 9] Set OPACItemHolds to Selectively force.
[10] Add a hold on three biblionumbers at once (including these two).
     Verify that you have two hold types for the single biblio and that
     you have only item holds for the two other biblios.

Signed-off-by: Nick <nick at quecheelibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Added the column to biblio and removed the separate table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:23:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:23:25 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-pdQ17T6X48@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #17 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
In view of the overwhelming requests for a new column instead of a new small
table :) I have slightly adjusted the two patches.
Back to Signed off.
If Nick could resign or one of the column requestors (Kyle, Jonathan, Katrin),
that would be welcome too. In that case feel free to set back to NSO and add
your SO. Thanks.

BTW I will soon submit something for the follow-up report (13479). But no need
to wait for that..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:28:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:28:11 +0000
Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel
	page
In-Reply-To: <bug-13001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13001-70-AJXC5yXOXs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=9225

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:28:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:28:12 +0000
Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client
	OMNIBUS
In-Reply-To: <bug-12173-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12173-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12173-70-djcSCCx55J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173
Bug 12173 depends on bug 9225, which changed state.

Bug 9225 Summary: Subroutines should not be defined in acqui/parcel.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9225

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:28:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:28:11 +0000
Subject: [Koha-bugs] [Bug 9225] Subroutines should not be defined in
	acqui/parcel.pl
In-Reply-To: <bug-9225-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9225-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9225-70-Ja77T5QCws@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9225

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13001
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
             Status|NEW                         |RESOLVED

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
These 3 subroutines have been removed by bug 13001.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:30:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:30:26 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-b6L3UPFw0B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

--- Comment #18 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Probably resign is something different than re-sign (sign off again)..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:32:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:32:32 +0000
Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches
 for authority links on a Z39.50 server.
In-Reply-To: <bug-11300-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11300-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11300-70-4wrhtzFfrK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

fpichenot at ville-roubaix.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fpichenot at ville-roubaix.fr

--- Comment #1 from fpichenot at ville-roubaix.fr ---
Nice feature, but I can't test the patch on a sandbox.

Some problems occurred applying patches from bug 11299 11300:
<h1>Something went wrong !</h1>Applying: Add a Z39.50 Linker that searches for
authority links in the specified Z39.50 server. Also modifies the automatic
linker button so it won't create empty authorities when used.
fatal: sha1 information is lacking or useless (C4/Biblio.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

Patch failed at 0001 Add a Z39.50 Linker that searches for authority links in
the specified Z39.50 server. Also modifies the automatic linker button so it
won't create empty authorities when used.

When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 11300 - Add a new authority linker which searches for authority links on a
Z39.50 server.

23147 - Add a Z39.50 Linker that searches for authority links in the specified
Z39.50 server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:34:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:34:56 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-vicVwkKF9u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36406|0                           |1
        is obsolete|                            |

--- Comment #7 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36568
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36568&action=edit
Bug 12344 - Multi transport types for issues and checkins

This small patch corrects the order of generating notices for issues and
returns (checkout/checkin) so that borrower's notices are rendered correctly
(for sms,email,etc.)

Test plan:

1) Edit SMSSendDriver syspref to use driver 'Test'
2) Edit CHECKOUT template for sms to 'SMS test'
3) select SMS for test patron's messaging prefs for item checkout
4) checkout an item
5) check the table message_queue, verify that template sms is
   not used (message content is not 'SMS test')

6) apply patch, make new checkout
7) check that message_queue table now has a correctly generated
   notice with 'SMS test'

For a real world test use a real SMS::Send driver and run the
cronjob process-message-queue.pl to send messages immediately.

http://bugs.koha-community.org/show_bug.cgi?id=12344
Signed-off-by: Sophie Meynieux <sophie.meynieux at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:37:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:37:14 +0000
Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr
In-Reply-To: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12291-70-M8sJbIewYr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

--- Comment #8 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36569
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36569&action=edit
Bug 12291: [SIGNED-OFF] Replace acronym with tag at the OPAC

On the OPAC authentification page, the acronym tag is used, but
deprecated.
It should be replaced with abbr:
http://www.w3.org/wiki/HTML/Elements/acronym

Test plan:
Enable the CAS authentification and verify the tags have correctly been
replaced.

Signed-off-by: Magnus Enger <magnus at enger.priv.no>
Befor the patch, "grep -r "<acronym" koha-tmpl/*/*/en/*" shows 4 occurences of
<acronym>, 3 related to CAS. After the patch, the same grep shows 1 remaining
<acronym>, in acqui/parcels.tt. I sign off this patch and will provide a
followup for the last occurrence.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:37:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:37:15 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-xG4SN1455k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

--- Comment #8 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36570
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36570&action=edit
QA followup:

Use next instead of return when generating templates.
In case patron has enabled a message type that misses a template,
next message type will be attempted instead of returning at once.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:38:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:38:14 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-rkM3nKjJyZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

--- Comment #80 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36571
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36571&action=edit
Bug 11998 - Syspref caching issues

fix delete_preference method and make t/db_dependent/sysprefs.t
pass again

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:38:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:38:33 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-vb9qxBsPqU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36570|QA followup:                |QA followup: skip message
        description|                            |type if template is missing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:39:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:39:07 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-ghnWPHFIrq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 12:42:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 11:42:50 +0000
Subject: [Koha-bugs] [Bug 13739] KohaDates should display hours if they
 exists by default unless specified
In-Reply-To: <bug-13739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13739-70-xfo59bheVw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Kyle,
Before this patch, the plugin manages the as_due_date parameter. It's not with
your patch.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:02:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:02:50 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-uNHyxWUSvw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

aloij <aloi54 at live.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aloi54 at live.fr

--- Comment #7 from aloij <aloi54 at live.fr> ---
Tested on UNIMARC install
the title is displayed correctly in the instructions with this patch
signed-off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:26:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:26:25 +0000
Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr
In-Reply-To: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12291-70-W4Jjwo4oKf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at enger.priv.no
  Attachment #36064|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:26:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:26:44 +0000
Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr
In-Reply-To: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12291-70-4ut9WH3oum@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:30:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:30:04 +0000
Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr
In-Reply-To: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12291-70-tKn3xVLzSx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:30:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:30:09 +0000
Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr
In-Reply-To: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12291-70-ScyNpyNYcy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

--- Comment #9 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36572
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36572&action=edit
Bug 12291 - Replace the acronym HTML tag with abbr - FOLLOWUP

This patch replaces the last occurrence of <acronym> with <abbr>.

To test:
- Apply this patch on top of the first patch and check that
  "grep -r "<acronym" koha-tmpl/*/*/en/*" does not return any hits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:38:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:38:13 +0000
Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item
	form
In-Reply-To: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13648-70-UMUEY0IvSI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:38:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:38:16 +0000
Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item
	form
In-Reply-To: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13648-70-No4n86dQdJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35736|0                           |1
        is obsolete|                            |
  Attachment #36265|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36573
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36573&action=edit
Bug 13648: OPAC = hidden removes pull down from edit item form

If you uncheck the checkbox OPAC in the bibliographic framework
definition for an item subfield that is linked to an authorized
value list, the pull down will disappear from the item edit
form on staff. The label still shows.

1) Go to administration > bibliographic frameworks
2) Select a framework and go to the item field (MARC21: 952)
3) Edit a subfield with an authorized values list like damaged,
   lost or withdrawn
4) Uncheck the checkbox for OPAC visibility
5) Edit or add an item within your chosen framework
6) Verify the subfield code and description are shown, but the
   pull down has disappeared
7) Apply patch, verify the pull down shows now
8) Also test following hidden combination works correctly:
   OPAC: checked
   All other options: unchecked

Documentation of hidden values:
http://wiki.koha-community.org/wiki/Hidden_values

With special thanks to Jonathan Druart for helping me figure this out!

Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:39:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:39:55 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-5PaFyWFIu4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

--- Comment #8 from aloij <aloi54 at live.fr> ---
(In reply to aloij from comment #7)
> Tested on UNIMARC install
> the title is displayed correctly in the "edit record" with this patch
> signed-off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:40:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:40:58 +0000
Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr
In-Reply-To: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12291-70-LCAGlt3ybG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:41:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:41:01 +0000
Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr
In-Reply-To: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12291-70-vk85X14T1U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36572|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36574
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36574&action=edit
Bug 12291 - Replace the acronym HTML tag with abbr - FOLLOWUP

This patch replaces the last occurrence of <acronym> with <abbr>.

To test:
- Apply this patch on top of the first patch and check that
  "grep -r "<acronym" koha-tmpl/*/*/en/*" does not return any hits.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:42:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:42:13 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-1XoDhiyEnn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com

--- Comment #9 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by joel aloi <aloi54 at live.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:42:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:42:25 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-kZqFXRdTqr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36507|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:42:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:42:32 +0000
Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch
 from institution_id field AO
In-Reply-To: <bug-13666-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13666-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13666-70-9RoriCzoEi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666

--- Comment #3 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Hi Olli!

To recap:  the SIP-server infers the transaction branch from the
C4::Context->userenv->{'branch'}, but for some reason only on checkouts. This
has to do with how SIP2 uses AddIssue and ModReserve to handle reserves and
circulation.

AddIssue uses patron context, while AddReturn takes branch as param. This is
probably good enough for intranet use, but not for a service.

Use-case that illustrate this enhancement:

- library has need for a centralised handling of SIP connections, for handling
e.g. 10 or, say, 50 concurrent connections. SIP clients range from SelfCheck
automats to RFID clients and automated circulation systems.
- this is best handled by a centralised service which maintains a pool of
connections (users sippool1, sippool2, ...)
- centralised service handles connections and could easily open and close
connections at need, so we don't have to open connection, login, and close for
each transaction, (poor performance) or worse, spawn 100+ workers with
keep-alive connections
- more dynamic solution than maintaining two sets of "SIP users", one in
SIPConfig.xml and the other in Koha
- centralised service could handle retry logic, logging, message rewriting,
etc, and SIP server can focus on transactions.

I believe any library with a hope to use SIP2 effectively would benefit from
this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:42:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:42:33 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-oLI0Ps4r20@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

--- Comment #10 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36575
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36575&action=edit
Bug 13635: Unimarc - On editing a notice, the title should be displayed

The title method of MARC::Record does not deal with UNIMARC, it should
not be called if the marc flavour is UNIMARC.

Test plan:
On an unimarc installation, edit a notice, with this patch you should
see
 "Editing TITLE (Record number BIBLIONUMBER)"

Without, the title was not displayed.
Same in the breadcrumbs.

Bug 13635: Remove another useless call

There is another call to the title method in additem.pl without any
check on the marc flavour.
But here the title variable sent to the template is redefined 3 lines
later.
So it can be simply removed.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested on UNIMARC install, editing a 'record' (not notice) does not show
title on breadcrumbs, status bar or page title.
With patch it does!
No koha-qa errors.

Signed-off-by: joel aloi <aloi54 at live.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:48:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:48:25 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-SV7gLF8gOl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:48:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:48:28 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-75hMh0xfAI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36568|0                           |1
        is obsolete|                            |
  Attachment #36570|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36576
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36576&action=edit
Bug 12344 - Multi transport types for issues and checkins

This small patch corrects the order of generating notices for issues and
returns (checkout/checkin) so that borrower's notices are rendered correctly
(for sms,email,etc.)

Test plan:

1) Edit SMSSendDriver syspref to use driver 'Test'
2) Edit CHECKOUT template for sms to 'SMS test'
3) select SMS for test patron's messaging prefs for item checkout
4) checkout an item
5) check the table message_queue, verify that template sms is
   not used (message content is not 'SMS test')

6) apply patch, make new checkout
7) check that message_queue table now has a correctly generated
   notice with 'SMS test'

For a real world test use a real SMS::Send driver and run the
cronjob process-message-queue.pl to send messages immediately.

Signed-off-by: Sophie Meynieux <sophie.meynieux at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:48:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:48:37 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-yRrAC9uPAo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36577
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36577&action=edit
Bug 12344: QA followup: use next instead of return

Use next instead of return when generating templates.
In case patron has enabled a message type that misses a template,
next message type will be attempted instead of returning at once.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:51:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:51:03 +0000
Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches
 for authority links on a Z39.50 server.
In-Reply-To: <bug-11300-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11300-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11300-70-tbf2muWvsQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 13:51:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 12:51:55 +0000
Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as
 Amazon, Google and add fail over i.e. if first source fails, go to next
In-Reply-To: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7187-70-4oZPtDTQpN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

LuceBarbey <luce.barbey at cirad.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luce.barbey at cirad.fr

--- Comment #32 from LuceBarbey <luce.barbey at cirad.fr> ---
What's the news about this patch ? 
Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:03:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:03:25 +0000
Subject: [Koha-bugs] [Bug 13795] New: Delete unused columns from statistics
	table.
Message-ID: <bug-13795-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

            Bug ID: 13795
           Summary: Delete unused columns from statistics table.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: nengard at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

I ran the following on a system that has been using Koha for 3 years and it
appears that none of these fields are ever used:


mysql> select distinct proccode from statistics;
+----------+
| proccode |
+----------+
| NULL     |
+----------+
1 row in set (0.00 sec)

mysql> select distinct other from statistics;
+-------+
| other |
+-------+
|       |
+-------+
1 row in set (18.30 sec)

mysql> select distinct usercode from statistics;
+----------+
| usercode |
+----------+
| NULL     |
+----------+
1 row in set (0.03 sec)

mysql> select distinct associatedborrower from statistics;
+--------------------+
| associatedborrower |
+--------------------+
|               NULL |
+--------------------+
1 row in set (0.00 sec)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:05:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:05:54 +0000
Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
In-Reply-To: <bug-13795-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13795-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13795-70-zV38SS5shA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:05:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:05:58 +0000
Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
In-Reply-To: <bug-13795-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13795-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13795-70-ArIFcv7sS9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36578
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36578&action=edit
Bug 13795: Delete unused columns from stats table

The following 4 fields are never used in the statistics table:

associatedborrower
other
proccode
usercode

This patch removes them.

To test:

* check the database and make sure columns are gone

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:10:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:10:42 +0000
Subject: [Koha-bugs] [Bug 13351] Untranslatable javascript in members.tt
In-Reply-To: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13351-70-3M8WC8DHBw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:10:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:10:46 +0000
Subject: [Koha-bugs] [Bug 13351] Untranslatable javascript in members.tt
In-Reply-To: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13351-70-l7Y3NQU89e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36427|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36579
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36579&action=edit
[PASSED QA] Bug 13351 - Untranslatable javascript in members.tt

This patch streamlines the page title text for search results in Home > Patrons
to make it translateable (and more readable).

To test:
- Apply patch
- Select Englsh language
- Apply filter wit several values or click on a letter for "Browse by last
name"
- Verify that the title makes sense
- Translate to your language and select this language
- Verify that the text appears properly in your language

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, no problems found.

http://bugs.koha-community.org/show_bug.cgi?id=13352

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:11:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:11:16 +0000
Subject: [Koha-bugs] [Bug 11979] items status not for loan on course reserve
In-Reply-To: <bug-11979-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11979-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11979-70-6EhYVNoQyu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:20:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:20:23 +0000
Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr
In-Reply-To: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12291-70-FCQaPPAcXL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:20:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:20:27 +0000
Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr
In-Reply-To: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12291-70-FgltbMpYH8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36569|0                           |1
        is obsolete|                            |
  Attachment #36574|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36580
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36580&action=edit
[PASSED QA] Bug 12291: [SIGNED-OFF] Replace acronym with tag at the OPAC

On the OPAC authentification page, the acronym tag is used, but
deprecated.
It should be replaced with abbr:
http://www.w3.org/wiki/HTML/Elements/acronym

Test plan:
Enable the CAS authentification and verify the tags have correctly been
replaced.

Signed-off-by: Magnus Enger <magnus at enger.priv.no>
Befor the patch, "grep -r "<acronym" koha-tmpl/*/*/en/*" shows 4 occurences of
<acronym>, 3 related to CAS. After the patch, the same grep shows 1 remaining
<acronym>, in acqui/parcels.tt. I sign off this patch and will provide a
followup for the last occurrence.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:20:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:20:45 +0000
Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr
In-Reply-To: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12291-70-pFLKRWb1Iv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36581
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36581&action=edit
[PASSED QA] Bug 12291 - Replace the acronym HTML tag with abbr - FOLLOWUP

This patch replaces the last occurrence of <acronym> with <abbr>.

To test:
- Apply this patch on top of the first patch and check that
  "grep -r "<acronym" koha-tmpl/*/*/en/*" does not return any hits.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:28:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:28:08 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-GqNGO2Kyoo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:28:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:28:14 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-ZfeEJ7vElg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

--- Comment #14 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36582
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36582&action=edit
Bug 10703: Update course reserves DB documentation

To test review database documentation to see that course tables are
all documented.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:33:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:33:25 +0000
Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity'
In-Reply-To: <bug-10020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10020-70-SMm2ifcXfb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #5 from Nicole C. Engard <nengard at gmail.com> ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:36:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:36:20 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-UlYkgSuD6o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:36:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:36:24 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-fciiGFcxbG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36523|0                           |1
        is obsolete|                            |

--- Comment #81 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36583
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36583&action=edit
Bug 11998 - timeout for syspref caching

This adds a 30 second timeout for syspref caching so that when run under
plack, you don't end up with different workers having different ideas of
what the sysprefs are for too long.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:36:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:36:32 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-xCsfXviWuS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36524|0                           |1
        is obsolete|                            |

--- Comment #82 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36584
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36584&action=edit
Bug 11998 - move most syspref db access into Context.pm

There was a lot of direct database access in systempreferences.pl. This
moves a lot of it into C4::Context so that it'll interact with caching
better, and to centralise common functions and logging in one place.

Test plan:
* Make sure that creating, editing, deleting local use preferences works
* Make sure that other system preferences still function normally

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:36:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:36:38 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-oRz6dfoIql@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36525|0                           |1
        is obsolete|                            |

--- Comment #83 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36585
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36585&action=edit
Bug 11998 - sysprefs in memcached

The caching mechanism has been abstracted a little bit, and now supports
memcached for storing sysprefs. These should be correctly stored and
cleared so caching will work between processes.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:36:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:36:47 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-2lOPjtNROQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36526|0                           |1
        is obsolete|                            |

--- Comment #84 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36586
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36586&action=edit
Bug 11998 - add test case, fix issue found

Adds a test case with improved coverage of the caching functionality.
Fixes a bug that was uncovered by writing the test case.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:37:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:37:02 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-XaQuBZffnn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36527|0                           |1
        is obsolete|                            |

--- Comment #85 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36587
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36587&action=edit
Bug 11998 - make syspref caching use Koha::Cache

This modifies the caching system in C4::Context to use Koha::Cache
instead of a custom implementation.

It should be applied on top of the other syspref caching patches.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:37:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:37:20 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-yXL5g1rhxn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36528|0                           |1
        is obsolete|                            |

--- Comment #86 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36588
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36588&action=edit
Bug 11998: QA follow-up - fix the perlcritic error

% perlcritic C4/Context.pm
Variable declared in conditional statement at line 544, column 5.
Declare variables outside of the condition.  (Severity: 5)

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:37:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:37:28 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-d7LtQIuLNj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36529|0                           |1
        is obsolete|                            |

--- Comment #87 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36589
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36589&action=edit
Bug 11998 - fix compile warnings

This creates a simplified logging system that can be used by
C4::Context.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:37:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:37:35 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-ogEu0DKEZK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36530|0                           |1
        is obsolete|                            |

--- Comment #88 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36590
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36590&action=edit
Bug 11998 - remove logging from places where it shouldn't be

This prevents duplicate action_log entries when a preference is updated.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:37:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:37:42 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-2O9SFZG3M1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36531|0                           |1
        is obsolete|                            |

--- Comment #89 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36591
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36591&action=edit
Bug 11998 - fix test case so it's testing the cache properly

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:37:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:37:52 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-x4DC6NvE7V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36532|0                           |1
        is obsolete|                            |

--- Comment #90 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36592
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36592&action=edit
Bug 11998: Add Koha::Config::SystemPreference

This (dirty) patch extract the syspref set and delete routine into a
module.
It fixes the circular dependency and the logging problem.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:37:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:37:58 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-Y3KK8cv0V9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36533|0                           |1
        is obsolete|                            |

--- Comment #91 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36593
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36593&action=edit
Bug 11998 - tidy up the Koha::Config::SystemPreferences module a bit

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:38:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:38:04 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-BAfV049P2s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36534|0                           |1
        is obsolete|                            |

--- Comment #92 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36594
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36594&action=edit
Bug 11998 - fix some compile warnings

This lazy-loads C4::Context and some other modules so that they can be
be safely used by C4::Context without introducing problematic circular
dependencies.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:38:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:38:11 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-Nr7pkkuf4e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36571|0                           |1
        is obsolete|                            |

--- Comment #93 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36595
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36595&action=edit
Bug 11998 - Syspref caching issues

fix delete_preference method and make t/db_dependent/sysprefs.t
pass again

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:40:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:40:29 +0000
Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
In-Reply-To: <bug-13795-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13795-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13795-70-3OAQMI9fyI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
I have something in proccode, but nothing in others:

mysql> select distinct proccode from statistics;        +----------+
| proccode |
+----------+
| NULL     |
|          |
| 1        |
| 2        |
| 3        |
| 6        |
+----------+
6 rows in set (0.00 sec)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:43:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:43:04 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-bfDr1ghu5f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36249|0                           |1
        is obsolete|                            |

--- Comment #35 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36596
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36596&action=edit
Bug 13364 - Add a call number browser in item edition page

When editing an item, the call number browser search for existing call number.
If it shows a line is green between two calli numbers, the call numbers
searched is available. If the call number is highlighted in red, it means that
it already exists. This can be used to avoid repeated  call numbers in your
collection.

The call number browser also shows its position relative to the rest of the
collection.

Sponsored-by: CCSR

To test :

                   1) Go to MARC bibliographic framework
                   Home ? Administration ? MARC frameworks
                   2) Click in MARC structure (Default framework)
                   3) Search field 952 and click in subfields
                   4) Edit subfield o (Full call number)
                   5) Click Display more constraints
                   6) In Others Options, Plugin, Choose cn_browser.pl and save
changes
                   7) Search a record and edit its items
                   Validate : three points (?) beside Full call number input
                   8)  Click in ?
                   Validate : if it can not find the given call number, a green
line is shown. Otherwise,  the given call number is highlighted in red.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Magnus <magnus at enger.priv.no>
Works as advertised. QA scripts pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:43:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:43:41 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-uetdaeG0eS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36596|0                           |1
        is obsolete|                            |

--- Comment #36 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36597
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36597&action=edit
Bug 13364 - Add a call number browser in item edition page

When editing an item, the call number browser search for existing call number.
If it shows a line is green between two calli numbers, the call numbers
searched is available. If the call number is highlighted in red, it means that
it already exists. This can be used to avoid repeated  call numbers in your
collection.

The call number browser also shows its position relative to the rest of the
collection.

Sponsored-by: CCSR

To test :

                   1) Go to MARC bibliographic framework
                   Home ? Administration ? MARC frameworks
                   2) Click in MARC structure (Default framework)
                   3) Search field 952 and click in subfields
                   4) Edit subfield o (Full call number)
                   5) Click Display more constraints
                   6) In Others Options, Plugin, Choose cn_browser.pl and save
changes
                   7) Search a record and edit its items
                   Validate : three points (?) beside Full call number input
                   8)  Click in ?
                   Validate : if it can not find the given call number, a green
line is shown. Otherwise,  the given call number is highlighted in red.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Magnus <magnus at enger.priv.no>
Works as advertised. QA scripts pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:44:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:44:17 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-3mWHguA7zV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36597|0                           |1
        is obsolete|                            |

--- Comment #37 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36598
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36598&action=edit
Bug 13364 - Add a call number browser in item edition page

When editing an item, the call number browser search for existing call number.
If it shows a line is green between two calli numbers, the call numbers
searched is available. If the call number is highlighted in red, it means that
it already exists. This can be used to avoid repeated  call numbers in your
collection.

The call number browser also shows its position relative to the rest of the
collection.

Sponsored-by: CCSR

To test :

                   1) Go to MARC bibliographic framework
                   Home ? Administration ? MARC frameworks
                   2) Click in MARC structure (Default framework)
                   3) Search field 952 and click in subfields
                   4) Edit subfield o (Full call number)
                   5) Click Display more constraints
                   6) In Others Options, Plugin, Choose cn_browser.pl and save
changes
                   7) Search a record and edit its items
                   Validate : three points (?) beside Full call number input
                   8)  Click in ?
                   Validate : if it can not find the given call number, a green
line is shown. Otherwise,  the given call number is highlighted in red.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Magnus <magnus at enger.priv.no>
Works as advertised. QA scripts pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:44:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:44:57 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-ty3VhAnKIU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36598|0                           |1
        is obsolete|                            |

--- Comment #38 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36599
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36599&action=edit
Bug 13364 - Add a call number browser in item edition page

When editing an item, the call number browser search for existing call number.
If it shows a line is green between two calli numbers, the call numbers
searched is available. If the call number is highlighted in red, it means that
it already exists. This can be used to avoid repeated  call numbers in your
collection.

The call number browser also shows its position relative to the rest of the
collection.

Sponsored-by: CCSR

To test :

                   1) Go to MARC bibliographic framework
                   Home ? Administration ? MARC frameworks
                   2) Click in MARC structure (Default framework)
                   3) Search field 952 and click in subfields
                   4) Edit subfield o (Full call number)
                   5) Click Display more constraints
                   6) In Others Options, Plugin, Choose cn_browser.pl and save
changes
                   7) Search a record and edit its items
                   Validate : three points (?) beside Full call number input
                   8)  Click in ?
                   Validate : if it can not find the given call number, a green
line is shown. Otherwise,  the given call number is highlighted in red.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Magnus <magnus at enger.priv.no>
Works as advertised. QA scripts pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:45:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:45:27 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-4us1OKHrPr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:45:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:45:37 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-Vbsv6JsYjm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36599|0                           |1
        is obsolete|                            |

--- Comment #39 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36600
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36600&action=edit
Bug 13364 - Add a call number browser in item edition page

When editing an item, the call number browser search for existing call number.
If it shows a line is green between two calli numbers, the call numbers
searched is available. If the call number is highlighted in red, it means that
it already exists. This can be used to avoid repeated  call numbers in your
collection.

The call number browser also shows its position relative to the rest of the
collection.

Sponsored-by: CCSR

To test :

                   1) Go to MARC bibliographic framework
                   Home ? Administration ? MARC frameworks
                   2) Click in MARC structure (Default framework)
                   3) Search field 952 and click in subfields
                   4) Edit subfield o (Full call number)
                   5) Click Display more constraints
                   6) In Others Options, Plugin, Choose cn_browser.pl and save
changes
                   7) Search a record and edit its items
                   Validate : three points (?) beside Full call number input
                   8)  Click in ?
                   Validate : if it can not find the given call number, a green
line is shown. Otherwise,  the given call number is highlighted in red.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Magnus <magnus at enger.priv.no>
Works as advertised. QA scripts pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:50:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:50:55 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-WAEDGkQjJv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36431|0                           |1
        is obsolete|                            |
  Attachment #36600|0                           |1
        is obsolete|                            |

--- Comment #40 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36601
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36601&action=edit
Bug 13364 - fix datatables.inc

http://bugs.koha-community.org/show_bug.cgi?id=13364
Signed-off-by: Magnus <magnus at enger.priv.no>
Works as advertised. QA scripts pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:52:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:52:26 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-VaAM2N8nW7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at enger.priv.no

--- Comment #41 from Magnus Enger <magnus at enger.priv.no> ---
(Sorry about the spam with the first patch! Git bz was timing out and I didn't
realize it was actually attaching the first patch...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:54:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:54:30 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-EeafBxoMJg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36600|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 14:56:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 13:56:50 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-AGF18wWouL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

--- Comment #15 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36602
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36602&action=edit
Bug 10703: Update stats table documentation

This patch updates the DB documentation for the statistics
table.

To test review the file and cofirm that documentation is there

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:02:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:02:51 +0000
Subject: [Koha-bugs] [Bug 13796] New: Alert in OPAC when renewing an item
 with a rental charge
Message-ID: <bug-13796-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

            Bug ID: 13796
           Summary: Alert in OPAC when renewing an item with a rental
                    charge
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: fiona.borthwick at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Could a patron see an alert when renewing their items via My Account on the
OPAC if the item has a rental fee associated with it?

This would be very useful as then the patron could decide whether or not they
wish to go ahead with the renewal.

So for example, they have borrowed a DVD and already paid ?2.50 at the time of
checking the item out.  If they renew this DVD then they are automatically
charged another ?2.50 but currently there is no alert at the point of renewing
in the opac to tell them this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:02:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:02:52 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-qSECTm3UHA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 36407
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36407
[Signed-off] Bug 13350 - Untranslatable strings in aqbudgetperiods.tt

Review of attachment 36407:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13350&attachment=36407)
-----------------------------------------------------------------

Hi H?ctor,

I think something strange is going on here and I would like to avoid changing
how the bradcrumbs display the last bit - could you take another look? Also
adding Bernardo, maybe he has some ideas.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
@@ +238,2 @@
>          [% ELSE %]
> +            Delete budget <i>'[% budget_period_description %]'?</i>

I am not sure why the ' would cause the strings to be not translatable, but
probably easisest would be to just remove them and maybe also the <i>? Thinking
about how this looks like in other places in Koha.

@@ +240,5 @@
>          [% END %]
>      [% END %]
>      <!-- duplicate a budget -->
>      [% IF ( duplicate_form ) %]
> +        <a href="/cgi-bin/koha/admin/aqbudgetperiods.pl">Budgets</a> &rsaquo; <strong>Duplicate budget</strong>

I think we shouldn't use strong here, as the current page is not highlighted
like that on the other pages. I think a <span> should do the trick without an
optical change, but it would be a little better to see why these pages don't
get translated, while other pages work correctly and adjust the code to look
the same (hope I make sense).

@@ +257,5 @@
>      [% END %]
>      <!-- display budget periods list -->
>      <!-- ########################################## -->
>      [% IF ( else ) %]
> +        <strong>Budgets administration</strong>

Same here as above - there are a lot of strange looking comments on this site.
Hm.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:03:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:03:08 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-DKWHa89qTT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:03:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:03:27 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-3aiIVHDzDd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:04:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:04:20 +0000
Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a
	rental charge
In-Reply-To: <bug-13796-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13796-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13796-70-TjUXZSMxem@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796

Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:06:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:06:00 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-xv8tlDd8Q4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:06:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:06:04 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-0WH9LkqII3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36582|0                           |1
        is obsolete|                            |

--- Comment #16 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36603
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36603&action=edit
Bug 10703: Update course reserves DB documentation

To test review database documentation to see that course tables are
all documented.

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:07:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:07:14 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-U9hrysvkpb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36602|0                           |1
        is obsolete|                            |

--- Comment #17 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36604
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36604&action=edit
Bug 10703: Update stats table documentation

This patch updates the DB documentation for the statistics
table.

To test review the file and cofirm that documentation is there

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:18:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:18:56 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-Cp8CWvtKp2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

--- Comment #18 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36605
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36605&action=edit
Bug 10703: Update Patron DB Documentation

Update patron categories and patron restrictions DB docs.

To test:

* Review database documentation for categories
* Review database documentation for patron_debarments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:20:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:20:22 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-jDTVjm7iYc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34813|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:21:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:21:36 +0000
Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref
In-Reply-To: <bug-7981-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7981-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7981-70-ljlgWd4iOo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28199|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:24:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:24:01 +0000
Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related
 to their branch.
In-Reply-To: <bug-8438-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8438-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8438-70-jMRJ2eXeVy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35312|0                           |1
        is obsolete|                            |

--- Comment #36 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 35312
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35312
[SIGNED OFF] Bug 8438: Followup Set the superserials permission for all users
with the claim_serials permission

So it is preferable not to update the user permissions and maybe let a note in
the release notes to explain that if they have issues with serial permissions
to check the user permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:24:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:24:10 +0000
Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related
 to their branch.
In-Reply-To: <bug-8438-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8438-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8438-70-7PE5g9gkws@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:26:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:26:56 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys
In-Reply-To: <bug-10021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-2QVnbGXx3K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |6427
                 CC|                            |kyle.m.hall at gmail.com,
                   |                            |nengard at gmail.com

--- Comment #3 from Nicole C. Engard <nengard at gmail.com> ---
Most of this is solved in the accounts rewrite - bug 6427

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:26:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:26:56 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-aPcBnG00mP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10021

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:28:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:28:19 +0000
Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list
 of books with forced item holds
In-Reply-To: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13479-70-cpjBtTzGbY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36606
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36606&action=edit
Bug 13479: Enable/disable forced item holds on biblio level

This is a follow-up of report 13478.
If you set OPACItemHolds to 'selectiveforce', you can now enable or disable
forced item holds on biblio level on the Holds tab of the staff detail
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:28:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:28:44 +0000
Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list
 of books with forced item holds
In-Reply-To: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13479-70-l9Q8okFFcu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:28:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:28:57 +0000
Subject: [Koha-bugs] [Bug 13766] biblioitems.ean field is too short
In-Reply-To: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13766-70-xog2UQFrQ4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766

--- Comment #4 from Fr?d?ric Demians <frederic at tamil.fr> ---
(In reply to Jonathan Druart from comment #3)
> Fr?d?ric, I got an error on executing the updatedb entry:
> 
> DBD::mysql::db do failed: BLOB/TEXT column 'ean' used in key specification
> without a key length at installer/data/mysql/updatedatabase.pl line 9798.

Thanks testing. I also can get this error. I don't have it on recent DB. I get
it on older.

In updatedatebase.pl, line 5323:

$dbh->do("CREATE INDEX `ean` ON biblioitems (`ean`) ");

So a DB which was on Koha 3.8, and earlier, has an index on biblioitems.ean.

A fresh DB, hasn't such an index. kohastructre.sql, line 186 and after, there
are index defined for isbn but not for ean.

Do you think that an index is required on ean field?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:29:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:29:23 +0000
Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list
 of books with forced item holds
In-Reply-To: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13479-70-aGWxTimd3I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
This work is not yet ready, but this may helps those want to sign off on report
13478.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:29:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:29:36 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-IMEjDQ1EJR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:29:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:29:39 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-GMejpn1ldj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36575|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36607
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36607&action=edit
[PASSED QA] Bug 13635: Unimarc - On editing a notice, the title should be
displayed

The title method of MARC::Record does not deal with UNIMARC, it should
not be called if the marc flavour is UNIMARC.

Test plan:
On an unimarc installation, edit a notice, with this patch you should
see
 "Editing TITLE (Record number BIBLIONUMBER)"

Without, the title was not displayed.
Same in the breadcrumbs.

Bug 13635: Remove another useless call

There is another call to the title method in additem.pl without any
check on the marc flavour.
But here the title variable sent to the template is redefined 3 lines
later.
So it can be simply removed.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested on UNIMARC install, editing a 'record' (not notice) does not show
title on breadcrumbs, status bar or page title.
With patch it does!
No koha-qa errors.

Signed-off-by: joel aloi <aloi54 at live.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:30:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:30:15 +0000
Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list
 of books with forced item holds
In-Reply-To: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13479-70-fZWi263RzN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36606|0                           |1
        is obsolete|                            |

--- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36608
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36608&action=edit
Bug 13479: Enable/disable forced item holds on biblio level

This is a follow-up of report 13478.
If you set OPACItemHolds to 'selectiveforce', you can now enable or disable
forced item holds on biblio level on the Holds tab of the staff detail
page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:30:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:30:27 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-S7uotaZpBz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Sorry, failing qa again.
The title of the [X] link (to delete the facet) is badly encoded.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:31:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:31:54 +0000
Subject: [Koha-bugs] [Bug 13797] New: Applet / Script for combination silent
 printing/ till drawer kick out from Citizen CBM 1000 slip printer
Message-ID: <bug-13797-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13797

            Bug ID: 13797
           Summary: Applet / Script for combination silent printing/ till
                    drawer kick out from Citizen CBM 1000 slip printer
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: PC
                OS: Windows
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: thomas.rowley at cheshiresharedservices.gov.uk
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Is there an applet/script that combines the ability to 'silent' print (negating
dialog box intervention) and the kick out command sequence for a till drawer?

However the till only needs to come out for financial transactions via patron
accout or pay screen NOT any other receipt commands eg:- printing a list of
books on issue to a patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:31:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:31:59 +0000
Subject: [Koha-bugs] [Bug 13798] New: Display issues with forced item holds
Message-ID: <bug-13798-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13798

            Bug ID: 13798
           Summary: Display issues with forced item holds
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 36609
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36609&action=edit
Screenshot

When a record it forced to allow item holds, there are two oddities:
a) We can collapse the item selection list
b) We have a single radio button option set to 'A specific item'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:32:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:32:17 +0000
Subject: [Koha-bugs] [Bug 13797] Applet / Script for combination silent
 printing/ till drawer kick out from Citizen CBM 1000 slip printer
In-Reply-To: <bug-13797-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13797-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13797-70-2FlA3318zX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13797

Tom Rowley <thomas.rowley at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:33:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:33:18 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-YT4QYl2IGN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #22 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Koha Team Lyon 3 from comment #21)
> I have just tested it. Everything is fine except that <<staffClientBaseURL>>
> isn't filled in the email : 
> ...
> BEGIN COMMENT --- A lire absolument --- END COMMENT --- To approve:
> http:///cgi-bin/koha/review/reviewswaiting.pl?op=approve&reviewid=10 To
> delete: http:///cgi-bin/koha/review/reviewswaiting.pl?op=delete&reviewid=10
> Or to review all comments: http:///cgi-bin/koha/review/reviewswaiting.pl
> Check it out! Your library.

Not to ask the obvious question, but did you set staffClientBaseURL?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:36:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:36:00 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-T4LonTHDhS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34815|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:36:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:36:27 +0000
Subject: [Koha-bugs] [Bug 5337] In Acquisition,
	EAN search will return results
In-Reply-To: <bug-5337-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5337-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5337-70-rbh6AvokzR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13766

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:36:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:36:27 +0000
Subject: [Koha-bugs] [Bug 13766] biblioitems.ean field is too short
In-Reply-To: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13766-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13766-70-co63kvIVmr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=5337

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Fr?d?ric Demians from comment #4)
> Do you think that an index is required on ean field?

It has been added by bug 5337, but the patch does not update the
kohastructure.sql file.
I think it's an oversight and should exist.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:37:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:37:37 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-04qlt66iwp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

--- Comment #19 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. de Rooy from comment #17)
> BTW I will soon submit something for the follow-up report (13479). But no
> need to wait for that..

If you do not like to run the update statement manually (in the test plan),
apply the 13479 preliminary patch. And you can do it in the staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:47:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:47:39 +0000
Subject: [Koha-bugs] [Bug 8484] Add ability to choose if lost items are
 removed from a borrowers record.
In-Reply-To: <bug-8484-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8484-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8484-70-RvcFYOpwSB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484

--- Comment #24 from Nicole C. Engard <nengard at gmail.com> ---
This is something that came up at the hackfest - it's an option that a few
people here would still like to see make it in to Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:51:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:51:52 +0000
Subject: [Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
In-Reply-To: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13787-70-R07Pz9L44g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:51:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:51:55 +0000
Subject: [Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
In-Reply-To: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13787-70-Otk2GCb5hw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36557|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36610
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36610&action=edit
Bug 13787 - Clean up noisy opac-advsearch warnings

While testing bug 10937, there were noisy warnings, which
distracted from testing the functionality of it.

Here is a snippet of the after the patch warnings:
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 384.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.

Tweaking the [% IF %] statements eliminated the warnings.

TEST PLAN
---------
1) Apply patch
2) Run koha qa test tools.
   -- there will be noisy warnings in the before processing, but
      there will be no such messages in the after processing.
3) git diff origin/master
   -- there should be no visible typos.

Signed-off-by: Magnus Enger <magnus at enger.priv.no>
- Applied the patch from bug 10937
- Ran "koha-qa.pl -c 1" and observed the warnings described in the
  commit message
- Applied the patch from this bug
- Ran "koha-qa.pl -c 1" again and saw no warnings
- Ran "koha-qa.pl -c 2" and saw no warnings

I have not tested the functionality of 10937 with this patch, just verified
that the changes look sensible.

This patch feels more like a followup for 10937, than a separate patch,
especially since 10937 is just "signed off" at this time. But as long as it
works...

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:52:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:52:39 +0000
Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons
In-Reply-To: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11900-70-euNUhmnPct@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900

--- Comment #11 from Nicole C. Engard <nengard at gmail.com> ---
This is a step, but I do feel that we need a bit more because CART appears in
many places and is not easy to change with jquery.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:52:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:52:46 +0000
Subject: [Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
In-Reply-To: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13787-70-RgeYYQtCHp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10937
         Depends on|10937                       |
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I removed the dependency, this patch can be pushed before bug 10937.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:52:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:52:46 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-WLXTJ32Vb0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13787                       |
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13787

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:54:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:54:01 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-gWP3Ud7fiI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|gmcharlt at gmail.com          |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:55:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:55:14 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-aZjufAd7LX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36540|0                           |1
        is obsolete|                            |

--- Comment #7 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36611
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36611&action=edit
Bug 13789 - facets with accented utf-8 characters generate double encoded links

Bug 13425 tried to fix XSS in OPAC, by using url filter in template toolkit
on whole generated url. This doesn't work and create double encoded strings
in facets because we are creating url variable by concatenating query_cgi
(which did pass through uri_escape_utf8 on perl side) and other
parameters which have to be escaped in template.

Also, code like

[% SET limit_cgi_f = limit_cgi | url %]

doesn't do anything (at least doesn't apply url filter) so it's not needed.

This patch also fixes encoding of hidden fields used in sort by form.

And lastly, it tries to make facet changes for opac and intranet as same as
possible to simplify future maintencence of this code.

Test scenario:
1. find results in your opac which contain accented characters
2. click on them and verify that results are missing
3. apply this patch
4. re-run search and click on facets link verifying that there are
   now results
5. test sort by form and verify that results are ok
6. verify that facets are still safe from injection by constructing url like
  
/cgi-bin/koha/opac-search.pl?q=123&sort_by='"><script>prompt('Happy_Holidays')</script>&limit=123
   and verifying that you DON'T see prompt window in your browser

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:55:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:55:40 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-lGRV9qS4F4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 15:59:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 14:59:07 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-MlM2O4Z661@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #19 from Nicole C. Engard <nengard at gmail.com> ---
Latest patch needs sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:01:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:01:52 +0000
Subject: [Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
In-Reply-To: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13787-70-66JrBPrkij@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
There is no need to expressly test bug 10937, you can put a blank line into
opac-advsearch.tt and trigger the same problems.

I was merely giving a historical context. It does not depend solely on 10937.
It depends on anyone making a modification to the opac-advsearch.tt template
file. Thank you for changing this from 'Depends on' to 'See also', Jonathan.

Consider that this patch modifies that file. You should the problems before,
but not after the processing when running the koha qa tool.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:03:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:03:57 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-uDd40zRIsC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:04:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:04:00 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-GbCNU8G9As@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36556|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36612
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36612&action=edit
Bug 13773 - add stock number to details and items display

This patch adds stocknumber (named Inventory number in interface)
to details table and items display if it exists.

Test scenario:
1. find item(s) which have inventory number assigned
2. verify that you don't see inventory number in items display
3. apply this patch
4. verify that inventory number is now available

Signed-off-by: Nicole <nicole at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:06:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:06:13 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-Y552GnWgMt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36521|0                           |1
        is obsolete|                            |

--- Comment #23 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36613
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36613&action=edit
[SIGNED OFF] Bug 1985 - Email notification of new OPAC comments

This feature adds YAS 'CommentModeratorsEmail', where an email (template code
COMMENT_CREATED) is sent when
a borrower creates/modifies an comment/review. The syspref is empty by default
and no email is sent when the
syspref is empty.

This feature is needed because we want to alert our content moderators to take
action when needed. Usually
it is our librarians who write reviews and this improvement makes the process
of moving Koha reviews to our
CMS more smooth.

TEST SETUP:
-1. Run updatedatabase.pl to add the syspref and the new letter template.
0. Go to admin/preferences.pl?tab=opac, and set the
'CommentModeratorsEmail'-syspref to your email-address.

TEST PLAN:
1. Log in to OPAC and find any Biblio.
2. Make a comment/review for it.
3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'.
You should see the reasonable
   default message. You can change the message in tools/letter.pl.

NOTE: Tested in conjunction with my patch. However, this piece
      alone:
      - lacked unit tests since it modified C4/Review.pm
      - failed to provide the desired links in the email message,
        as mentioned in comment #1.
      - failed to pass biblionumber information for use in the
        letter as mentioned in comment #11.
      - passed $review, when it was really id that should have
        been passed and used to implement the inclusion of
        reviews.reviewid and other reviews table fields.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:06:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:06:27 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-KSxN9RE6zD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36522|0                           |1
        is obsolete|                            |

--- Comment #24 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36614
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36614&action=edit
Bug 1985 - tweak License and lots of cleanup

In comment #11, it was mentioned that title and biblionumber from
the biblio table were not available as variables in the letter.

This corrects this by converting the parameter list to a hashref,
and adding the missing biblio number.

It also cleans up the license on C4/Review.pm to be in line with
the current coding guidelines license. Also strict and warning
have been changed to the 'Use Modern::Perl;' now.

Additionally, <<reviews.reviewid>> is now usable in the letter,
as is <<staffClientBaseURL>>. These were required additions,
because comment #1 expressly says there should be a direct link
to approve or delete. I also included a review everything link,
since there could be multiple comments outstanding.

The default letter was tweaked as well to reflect these changes.

TEST PLAN
---------
1) Create test branch and apply patch
2) run installer/data/mysql/updatedatabase.pl
   -- this will add the required default letter.
3) In the staff client:
   a) set the CommentModeratorsEmail system preference.
      -- not setting it will mean you won't get any queued
         letters.
   a) set the staffClientBaseURL system preference.
      -- not setting it will mean your email links won't be
         valid (i.e http:///...).
   b) modify the COMMENT_CREATED default letter as desired.
      -- feel free to add other things.
4) In the OPAC:
   a) Log in
   b) Find something
   c) Click on the 'Comments' tab
      -- Holdings/Title notes/Comments (#) is at the bottom
   d) Click 'Post or edit your comments on this item'
   e) In the window that pops up, type your comment.
   f) Click 'Submit and close this window'.
   g) Click 'Edit' and repeat steps e and f again.
5) In a mysql client:
   a) Open the koha database
   b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED';
      -- There should be at least two.
      -- They should be able to contain the borrower number, biblio
         title, and other borrower and biblio related things.
      -- Comments are at a biblio level, so items, and issues don't
         make sense as variables for the letter.
6) prove -v t/db_dependent/Review.t
7) Run the koha qa test tool.

NOTE: Improved the test plan to make staffClientBaseURL obvious.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:13:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:13:58 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-8sRMp02DkO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #25 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Yes, you're right :-) I forgot to set the staffClientBaseURL syspref ...
I'll test one more time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:14:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:14:15 +0000
Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref
In-Reply-To: <bug-7981-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7981-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7981-70-OukgwNjSnz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:14:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:14:18 +0000
Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref
In-Reply-To: <bug-7981-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7981-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7981-70-BzaMFG8vzx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28199|0                           |1
        is obsolete|                            |
  Attachment #33455|0                           |1
        is obsolete|                            |

--- Comment #26 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36615
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36615&action=edit
Bug 7981 - Remove HomeOrHoldingBranchReturn syspref

This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl
respect branch
circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip
notice should reflect this.

Default should always be to return item to home branch.

Test plan:
- make sure syspref 'AutomaticItemReturn' is set to 'false'
- unset 'Default checkout, hold and return policy' or set 'Return policy' to
'Item returns home'
- checkout an item and do a checkin from different branch than items homebranch
- verify that you're prompted with a transfer message to item's home branch and
that print slip matches

- set 'Return policy' to 'Item returns to issuing library'
- do a checkout and a checkin from branch different than item's home branch
- verify that you're not prompted with a transfer message and that holding
library is your current branch

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Follow-up:
- Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn
  policies
- Removed HomeOrHoldingBranchReturn from sysprefs.sql
- Added notice on removing syspref in updatedatabase

QA edits:
- removed trailing whitespace in tests
- moved branchname lookup from returns.pl to template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:16:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:16:08 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-JAsRSET67v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:16:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:16:15 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-JMiNd6v0OU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36611|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36616
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36616&action=edit
Bug 13789 - facets with accented utf-8 characters generate double encoded links

Bug 13425 tried to fix XSS in OPAC, by using url filter in template toolkit
on whole generated url. This doesn't work and create double encoded strings
in facets because we are creating url variable by concatenating query_cgi
(which did pass through uri_escape_utf8 on perl side) and other
parameters which have to be escaped in template.

Also, code like

[% SET limit_cgi_f = limit_cgi | url %]

doesn't do anything (at least doesn't apply url filter) so it's not needed.

This patch also fixes encoding of hidden fields used in sort by form.

And lastly, it tries to make facet changes for opac and intranet as same as
possible to simplify future maintencence of this code.

Test scenario:
1. find results in your opac which contain accented characters
2. click on them and verify that results are missing
3. apply this patch
4. re-run search and click on facets link verifying that there are
   now results
5. test sort by form and verify that results are ok
6. verify that facets are still safe from injection by constructing url like
  
/cgi-bin/koha/opac-search.pl?q=123&sort_by='"><script>prompt('Happy_Holidays')</script>&limit=123
   and verifying that you DON'T see prompt window in your browser

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:25:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:25:27 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-5l2g2uHCbd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

--- Comment #5 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Hi Katrine

I've used strong tag on example basis. If you go to Patrons and then create a
New patron (e.g. Staff), this will display "Add patron (Staff)" in bold type.

So, this kind of code has been used in memberentrygen.tt

I will try to test another solution or if Bernardo can help, he has got more
experiences with untranslatables strings.

Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:28:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:28:06 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-6yc1gPTU44@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
I'm looking into this right now :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:28:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:28:56 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-z95WadEAxH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Bumping the severity since it's a regression.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:31:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:31:44 +0000
Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber
	and barcode
In-Reply-To: <bug-12122-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12122-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12122-70-u1UPZKQjan@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Sk?le!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:32:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:32:22 +0000
Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additional
	checkin)
In-Reply-To: <bug-9848-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9848-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9848-70-bwQNSAojv0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Adrien!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:32:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:32:50 +0000
Subject: [Koha-bugs] [Bug 13575] Updating developer list.
In-Reply-To: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13575-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13575-70-rfV5jPQaL3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Brandon!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:33:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:33:49 +0000
Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts
In-Reply-To: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13605-70-XKeWWJvoay@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Frido!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:34:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:34:38 +0000
Subject: [Koha-bugs] [Bug 11395] Batch modifications for records
In-Reply-To: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11395-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11395-70-WerNtHwutq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #122 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Nice job Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:37:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:37:14 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-VDkIuuc3bs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:37:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:37:55 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-Ju4Z5dtZDr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35385|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:49:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:49:54 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-6YXhM2v6XU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #42 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 36600
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36600
Bug 13364 - Add a call number browser in item edition page

Review of attachment 36600:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13364&attachment=36600)
-----------------------------------------------------------------

Is there a good reason to have the template file in the tools directory,
instead of cataloguing/value_builder?

The green line is always at the top of the table. If I am remember correctly,
in the previous version it was inserted correctly.

::: cataloguing/value_builder/cn_browser.pl
@@ +1,4 @@
> +#!/usr/bin/perl
> +
> +use strict;
> +use warnings;

Prefer use Modern::Perl;

@@ +9,5 @@
> +use C4::Output;
> +use POSIX;
> +use C4::ClassSource;
> +use URI::Escape;
> +use Data::Dumper;

No needed.

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/cn_browser.tt
@@ +12,5 @@
> +<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/jquery.dataTables.min.js"></script>
> +<script language="JavaScript">
> +$(document).ready(function()
> +{
> +    $("#course_reserves").DataTable({"paging":   false, "bFilter": false, "info":     false});

Hum? Why did you choose this id?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:52:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:52:49 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-NFW078WeWQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #26 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Tested on a sandbox :
- go to OPAC to add a comment without filling the syspref
CommentModeratorsEmail : nothing is added in message_queue table : OK

- set syspref CommentModeratorsEmail with my email adress and set the syspref
staffClientBaseURL

- add a comment on OPAC

- try SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED';
I have a new record : OK

- reedit the comment on the OPAC

- try the SQL request : 2 records : Ok

- go to notices and slips : try to change the model

- go to the OPAC : add a new comment

- retry the SQL reequest : I have a new record with the change I made in the
model : OK

It works as it is described in the test plan but I have a remarks in the url to
manage the comments : in the model, it's :
http://<<staffClientBaseURL>>/cgi-bin/koha/review/reviewswaiting.pl?

but the right URL is

http://<<staffClientBaseURL>>/cgi-bin/koha/reviewS/reviewswaiting.pl?
(there's a S and the end of review)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 16:56:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 15:56:56 +0000
Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export
In-Reply-To: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13695-70-tvRUxFuU2Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Tomas, I would like to get your opinion on this.
Shouldn't we create a new pref for the ISBD export or remove the html tags?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:00:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:00:58 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-cP7tI5ODeJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36383|0                           |1
        is obsolete|                            |
  Attachment #36405|0                           |1
        is obsolete|                            |

--- Comment #117 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36617
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36617&action=edit
[PASSED-QA] Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to
the Circulation Matrix

C4::Reserves:
* Added OnShelfHoldsAllowed() to check issuingrules
* Added OPACItemHoldsAllowed() to check issuingrules
* IsAvailableForItemLevelRequest() changed interface, now takes
  $item_record,$borrower_record; calls OnShelfHoldsAllowed()

opac/opac-reserve.pl and opac/opac-search.pl:
* rewrote hold allowed rule to use OPACItemHoldsAllowed()
* also use OnShelfHoldsAllowed() through
* IsAvailableForItemLevelRequest()

templates:
* Removed AllowOnShelfHolds and OPACItemHolds global flags, they now
  only have meaning per item type

Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>

I have tested this patch left, right and upside down for the last
several months. All tests have passed.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:00:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:00:52 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-u2rqnEZJUE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:01:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:01:00 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-O7UPV9h7A0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #19 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Alex, to change the patch's author, you can use
  git commit --amend --author "Author Name <authoremail at example.org>"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:01:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:01:18 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-QbhCc5Z4l8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #118 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36618
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36618&action=edit
[PASSED-QA] Bug 5786 [QA Followup]

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:01:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:01:25 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-Z0iRKTmFh7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #119 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36619
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36619&action=edit
[PASSED-QA] Bug 5786 [QA Followup] - Fix language

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:02:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:02:55 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-bjsb0yWeEv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

--- Comment #13 from simith.doliveira at inlibro.com ---
Created attachment 36620
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36620&action=edit
Add a new report : Orders by budget

This patch adds the "Orders by budget" report to the reports page.

This report can generate the list of all orders on a specific budget. The "All
budgets" and "All active budgets" options are also available to have different
views of all your orders.

A "[i]" is also added before the names of inactive budgets in the budget
selection box.

How to test:
Go to Home > Reports > Orders by budget
Select one or all budgets
Output to Scrren or CSV file
Set a budget to inactive
Verify that this budget is marked wit [i] in drop down list (Filters)

Sponsored-by: ccsr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:03:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:03:20 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-e7NlIPyd9x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30546|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:03:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:03:42 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-tRY9LuyHs1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30545|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:05:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:05:43 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-67XF2HrnBB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #14 from simith.doliveira at inlibro.com ---
Conflits fixes and old patchs squashed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:06:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:06:31 +0000
Subject: [Koha-bugs] [Bug 13799] New: Add base for building RESTful API
Message-ID: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

            Bug ID: 13799
           Summary: Add base for building RESTful API
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:09:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:09:06 +0000
Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services
In-Reply-To: <bug-13737-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13737-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13737-70-ODmVC7koYX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13799

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:09:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:09:06 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-arPpSiPIU3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13737

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:11:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:11:59 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-io9QfzlMX3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #20 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---

(In reply to Jonathan Druart from comment #19)
> Alex, to change the patch's author, you can use
>   git commit --amend --author "Author Name <authoremail at example.org>"

Sorry Jonathan, I'm afraid I'm confused: do you need me to change the name of
the contributor on the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:25:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:25:13 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-AN4G2NW2OE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:25:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:25:19 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-CGnfreASly@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36457|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:25:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:25:25 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-WBn31tdaUf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36458|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:25:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:25:28 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-7RWUQutPmF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36459|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:25:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:25:31 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-V5J0Yajdj2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35300|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:26:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:26:54 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-SlkdK9WlPR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36621
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36621&action=edit
[PASSED QA] Bug 5338: Serials Report

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:26:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:26:59 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-rEQUIm6GLn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36622
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36622&action=edit
[PASSED QA] Bug 5338: Add "Serials" to the report group list

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:27:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:27:03 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-Uj3Db9l37e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

--- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36623
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36623&action=edit
[PASSED QA] Bug 5338: Use insert ignore to avoid a warning if 'SER' already
exists

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:27:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:27:07 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-iN47TtwqO1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

--- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36624
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36624&action=edit
[PASSED QA] Bug 5338: Add the "SER" report group for all languages.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:32:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:32:19 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-B9sZJ5qP2g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Alex Sassmannshausen from comment #20)
> (In reply to Jonathan Druart from comment #19)
> > Alex, to change the patch's author, you can use
> >   git commit --amend --author "Author Name <authoremail at example.org>"
> 
> Sorry Jonathan, I'm afraid I'm confused: do you need me to change the name
> of the contributor on the patch?

Actually it could be done by the QAer, just wanted to share with you the trick
if you didn't know.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:32:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:32:57 +0000
Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
In-Reply-To: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13531-70-8n2dUtUzNH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:33:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:33:01 +0000
Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
In-Reply-To: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13531-70-4sJpxADpYY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35486|0                           |1
        is obsolete|                            |

--- Comment #16 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 36625
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36625&action=edit
[SIGNED OFF] Bug 13531 - Follow up

Add logging of errors.

Signed-off-by: Magnus Enger <magnus at enger.priv.no>
More errors are indeed showing up in the log.
(I took the liberty of changing the commit message a little bit.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:36:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:36:24 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-h1dnCE9ajb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34813|0                           |1
        is obsolete|                            |
  Attachment #34815|0                           |1
        is obsolete|                            |

--- Comment #26 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Created attachment 36626
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36626&action=edit
Bug 11982 - Fixed the amazon no image icon.

A no image icon will only be displayed if both the amazon and local images are
missing.
Added hyperlink to details on the local image in the search result page.
    modified:   koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js
    modified:   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
    modified:   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:39:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:39:16 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-l4FyiDH4XN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

--- Comment #27 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Created attachment 36627
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36627&action=edit
Some obsolete patches were needed and not rebased.

I have rebased and reuploaded the patches.

Bug 11982 - Images now display properly in the details section.

If the a cover image exists, it will be displayed on the details page.
Nothing is displayed of there is no cover available.
    modified:   koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js
    modified:   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Works as described, passes tests and QA script.
Checked Amazon covers and local covers display correctly
in staff on results and detail pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:40:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:40:13 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-pyphzpNi2i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36627|Some obsolete patches were  |Bug 11982 - Images now
        description|needed and not rebased.     |display properly in the
                   |                            |details

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:42:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:42:44 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-kjGcTCVCMN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Plase take a look at comment 25 too! Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:44:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:44:13 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-CSc6wev6B7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

--- Comment #29 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
(In reply to Katrin Fischer from comment #28)
> Plase take a look at comment 25 too! Thx!

The regression was caused by the missing patches.
If you apply all three you should not see any problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:46:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:46:50 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-wyPzlVkBhQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #27 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36628
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36628&action=edit
Bug 1985 - Email notification of new OPAC comments

This feature adds YAS 'CommentModeratorsEmail', where an email (template code
COMMENT_CREATED) is sent when
a borrower creates/modifies an comment/review. The syspref is empty by default
and no email is sent when the
syspref is empty.

This feature is needed because we want to alert our content moderators to take
action when needed. Usually
it is our librarians who write reviews and this improvement makes the process
of moving Koha reviews to our
CMS more smooth.

TEST SETUP:
-1. Run updatedatabase.pl to add the syspref and the new letter template.
0. Go to admin/preferences.pl?tab=opac, and set the
'CommentModeratorsEmail'-syspref to your email-address.

TEST PLAN:
1. Log in to OPAC and find any Biblio.
2. Make a comment/review for it.
3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'.
You should see the reasonable
   default message. You can change the message in tools/letter.pl.

NOTE: Tested in conjunction with my patch. However, this piece
      alone:
      - lacked unit tests since it modified C4/Review.pm
      - failed to provide the desired links in the email message,
        as mentioned in comment #1.
      - failed to pass biblionumber information for use in the
        letter as mentioned in comment #11.
      - passed $review, when it was really id that should have
        been passed and used to implement the inclusion of
        reviews.reviewid and other reviews table fields.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:47:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:47:02 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-gCH97Tepg0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36614|0                           |1
        is obsolete|                            |

--- Comment #28 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36629
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36629&action=edit
Bug 1985 - tweak License and lots of cleanup

In comment #11, it was mentioned that title and biblionumber from
the biblio table were not available as variables in the letter.

This corrects this by converting the parameter list to a hashref,
and adding the missing biblio number.

It also cleans up the license on C4/Review.pm to be in line with
the current coding guidelines license. Also strict and warning
have been changed to the 'Use Modern::Perl;' now.

Additionally, <<reviews.reviewid>> is now usable in the letter,
as is <<staffClientBaseURL>>. These were required additions,
because comment #1 expressly says there should be a direct link
to approve or delete. I also included a review everything link,
since there could be multiple comments outstanding.

The default letter was tweaked as well to reflect these changes.

Fixed bad URLs as noted in comment #26.

TEST PLAN
---------
1) Create test branch and apply patch
2) run installer/data/mysql/updatedatabase.pl
   -- this will add the required default letter.
3) In the staff client:
   a) set the CommentModeratorsEmail system preference.
      -- not setting it will mean you won't get any queued
         letters.
   a) set the staffClientBaseURL system preference.
      -- not setting it will mean your email links won't be
         valid (i.e http:///...).
   b) modify the COMMENT_CREATED default letter as desired.
      -- feel free to add other things.
4) In the OPAC:
   a) Log in
   b) Find something
   c) Click on the 'Comments' tab
      -- Holdings/Title notes/Comments (#) is at the bottom
   d) Click 'Post or edit your comments on this item'
   e) In the window that pops up, type your comment.
   f) Click 'Submit and close this window'.
   g) Click 'Edit' and repeat steps e and f again.
5) In a mysql client:
   a) Open the koha database
   b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED';
      -- There should be at least two.
      -- They should be able to contain the borrower number, biblio
         title, and other borrower and biblio related things.
      -- Comments are at a biblio level, so items, and issues don't
         make sense as variables for the letter.
      -- Confirm the URLs are valid by pasting into a browser.
6) prove -v t/db_dependent/Review.t
7) Run the koha qa test tool.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:52:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:52:33 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-KpHaEh2yx3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|List pending in-house uses  |List pending in-house
                   |                            |checkouts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:53:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:53:14 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-TYXJPaOSNL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 17:56:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 16:56:37 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-XB3oVa5pWP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry :(

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11201: Display overdues in red
fatal: sha1 information is lacking or useless (C4/Circulation.pm).
...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 18:00:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 17:00:00 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-HpH9ZDEqrp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36404|0                           |1
        is obsolete|                            |

--- Comment #22 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Created attachment 36630
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36630&action=edit
Revised patch with correct author

I understand now. Thank you.

Attached the revised patch.

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 18:54:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 17:54:17 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-8o1DIMUnxZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #49 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 36631
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36631&action=edit
Bug 13642 [ENH] Adding new features for Dublin Core metadata #2

When Koha export a bibliographic record to DC, makes it in XML format. This XML
not follows the DC-XML recommendations as should be: elements in uppercase eg.
dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property
names for the 15 DC elements should be all lower-case." eg. dc:date,
dc:creator" and section "4.3 Example - a simple DC record",
xsi:schemaLocation="http://example.org/myapp/
http://example.org/myapp/schema.xsd" schema does not exist.
The recommendation can be consulted at
<http://dublincore.org/documents/dc-xml-guidelines/>.
This new feature, adds an ability to export Dublin Core metadata to XML and RDF
(including rdfxml, rdfjson, ntriples, turtle, etc.)

Test plan
---------------
1) Download Dublin Core file. Open up the file, and make sure that the document
not follows the DC-XML recommendations as should be.
2) Apply patches.
3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core.
A modal will display, prove all options.
4) Change the system preference 'Opac ExportOptions' by enabling and disabling
Dublin Core and try to download a record in the OPAC.
5) Try several bibliographic records in any format (book, magazine, DVD, etc.)
to confirm that properly exported.
6) RDF/XML can be validated per RDF Validator W3C.
7) DC-XML cannot valid if not exist a valid XSD schema.
8) OAI-DC can be validated using
<http://www.freeformatter.com/xml-validator-xsd.html> and the proper schema
<http://www.openarchives.org/OAI/2.0/oai_dc.xsd> typed in text field for URL.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
XML::Entities was eliminated from patch, use instead
libhtml-entities-numbered-perl
librdf-trine-perl (1.000) not in Debian oldstable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 18:57:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 17:57:54 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-PYsOR3x4DI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #50 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Hi all

This the new patch that fix the last one.

Eliminate XML::Entities and RDF::Helper use instead HTML::Entities::Numbered
and RDF::Trine.

Please, test the patch again.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:05:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 18:05:19 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-lIbDi5m8LB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36154|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:05:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 18:05:42 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-jx1kEkvp4E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36631|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:08:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 18:08:00 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-KaXePJtZGP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #51 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 36632
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36632&action=edit
Bug 13642 [ENH] Adding new features for Dublin Core metadata #1

Signed-off attached by Marc not include changes on debian/control and
C4/Installer/PerlDependencies.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:10:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 18:10:13 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-o6FEKYs2OS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #52 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 36633
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36633&action=edit
Bug 13642 [ENH] Adding new features for Dublin Core metadata #2

This patch does the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:16:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 18:16:36 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-qNctj4pdQb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #53 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
I'm sorry, the applying fail. I'll try to reformat the patch as new again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:50:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 18:50:37 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-HPZvxjzhIt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Can't said that I found the problem, but a solution.
Removing comments on breadcrumb code does the job, e.g.

-    <!-- delete a budget period -->
-    <!-- ################################ -->

With only that the text is now picked up by translation script.
But new strings are not good, some phrases are split and then 
difficult to translate.

So I propose a counter patch, putting <span>...</span> on each
string. With that, updating and installing es-ES gives a correct 
result, no need to translate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:53:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 18:53:33 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-seaCrkGa5V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36634
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36634&action=edit
Bug 13350: Untranslatable strings in aqbudgetperiods.tt

Counter patch, same test plan as original

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 19:55:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 18:55:57 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-rxtzXYhnLL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
I think this need a sign, or an opinion :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 20:02:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 19:02:35 +0000
Subject: [Koha-bugs] [Bug 13794] Input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-iIy3JFd0n2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

--- Comment #2 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Created attachment 36635
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36635&action=edit
Added "submit" in the list of input types.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 20:31:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 19:31:19 +0000
Subject: [Koha-bugs] [Bug 13800] New: Diacritics not mapped
Message-ID: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13800

            Bug ID: 13800
           Summary: Diacritics not mapped
 Change sponsored?: ---
           Product: Koha
           Version: 3.16
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: joy at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Icelandic character found in Arnaldur Indri?ason is not mapped in
word-phrase-utf.chr   It should be mapped to d

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 20:32:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 19:32:44 +0000
Subject: [Koha-bugs] [Bug 13800] Diacritics not mapped
In-Reply-To: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13800-70-91BkUPZScK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13800

--- Comment #1 from Joy Nelson <joy at bywatersolutions.com> ---
Original comment from library:  

> When searching for author Arnaldur Indridason the character ?/? is not mapping to D/d

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 20:50:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 19:50:51 +0000
Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface
In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11559-70-aWAK1TZFwE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #76 from Jesse Weaver <jweaver at bywatersolutions.com> ---
(In reply to Zeno Tajoli from comment #75)
> Hi Jessie,
> 
> What about transfer support of JSONP for services in a specific bug ?
> It is a modification of C4/Service.pm.
> 
> I think could be useful alone.
> And probably in this way coulod be possible to extract also metasearch for
> Opac on z39.50

The new Koha::Service class
(http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272) allows JSONP,
so I'd vote not to split out JSONP from this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 21:36:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 20:36:34 +0000
Subject: [Koha-bugs] [Bug 13800] Diacritics not mapped
In-Reply-To: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13800-70-dcUsvMXBOa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13800

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 22:38:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 21:38:19 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-UtcePSjWe6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36632|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 22:38:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 21:38:41 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-LQmS38eOkU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36633|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 22:38:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 21:38:54 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-LXStECJ7RR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #28 from Chris Cormack <chris at bigballofwax.co.nz> ---
Something has gone really wrong on here, the sandbox has attached a bunch of
unrelated patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 22:54:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 21:54:25 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-euj6AKc2Hg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #54 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 36636
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36636&action=edit
Bug 13642 [ENH] Adding new features for Dublin Core metadata

Bug 13642 [ENH] Adding new features for Dublin Core metadata

When Koha export a bibliographic record to DC, makes it in XML format. This XML
not follows the DC-XML recommendations as should be: elements in uppercase eg.
dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property
names for the 15 DC elements should be all lower-case." eg. dc:date,
dc:creator" and section "4.3 Example - a simple DC record",
xsi:schemaLocation="http://example.org/myapp/
http://example.org/myapp/schema.xsd" schema does not exist.
The recommendation can be consulted at
<http://dublincore.org/documents/dc-xml-guidelines/>.
This new feature, adds an ability to export Dublin Core metadata to XML and RDF
(including rdfxml, rdfjson, ntriples, turtle, etc.)

Test plan
---------------
1) Download Dublin Core file. Open up the file, and make sure that the document
not follows the DC-XML recommendations as should be.
2) Apply patches.
3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core.
A modal will display, prove all options.
4) Change the system preference 'Opac ExportOptions' by enabling and disabling
Dublin Core and try to download a record in the OPAC.
5) Try several bibliographic records in any format (book, magazine, DVD, etc.)
to confirm that properly exported.
6) RDF/XML can be validated per RDF Validator W3C.
7) DC-XML cannot valid if not exist a valid XSD schema.
8) OAI-DC can be validated using
<http://www.freeformatter.com/xml-validator-xsd.html> and the proper schema
<http://www.openarchives.org/OAI/2.0/oai_dc.xsd> typed in text field for URL.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
XML::Entities was eliminated from patch, use instead
libhtml-entities-numbered-perl
RDF::Helper has been eliminated too.
librdf-trine-perl (1.000) not in Debian oldstable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 22:57:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 21:57:58 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-tgv1vmz9l2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Input field values not      |Text input field values not
                   |translated                  |translated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 22:58:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 21:58:44 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-A95qIZux0D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 23:02:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 22:02:05 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-1DlfpT6b7O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36514|0                           |1
        is obsolete|                            |
  Attachment #36635|0                           |1
        is obsolete|                            |

--- Comment #3 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Created attachment 36637
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36637&action=edit
Bug 13794 - New patch, the old patches were likely to cause regression issues.

I left the code logic intact, and simply removed "text" from the regex.
Text input field values are now translated, no other logical changes are
introduced.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar  5 23:08:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 05 Mar 2015 22:08:45 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-lk0RYPiVR2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 01:39:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 00:39:27 +0000
Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for
 Session Security. Disable when remote ip address changes frequently.
In-Reply-To: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5511-70-K4HGo6w6GY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_16_candidate
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 03:26:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 02:26:02 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-zoORY3XtcH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #43 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Peter Zhao from comment #42)
>           It is a great job! Thanks a lot. I tried to install a ES.
>           It seems to index the biblio. But I can't search the record."No
> results found!" I can find the record by Zebra.
>           koha at koha:~$
> /home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl -v -d
> Indexing biblios
> 1
> 
>            Could you give some advice?

There's not really enough info to go on there. I'd start by looking in the
logs. Many operations should be filling them full of search traces and so on,
so that might have useful things in it.

Have you followed the steps in here:
http://wiki.koha-community.org/wiki/Elasticsearch
in particular, adding the mapping SQL file into the database.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 05:43:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 04:43:37 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-dimVbKhusC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #44 from Peter Zhao <peterzhaonj at 163.com> ---
(In reply to Robin Sheat from comment #43)
> (In reply to Peter Zhao from comment #42)
> >           It is a great job! Thanks a lot. I tried to install a ES.
> >           It seems to index the biblio. But I can't search the record."No
> > results found!" I can find the record by Zebra.
> >           koha at koha:~$
> > /home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl -v -d
> > Indexing biblios
> > 1
> > 
> >            Could you give some advice?
> 
> There's not really enough info to go on there. I'd start by looking in the
> logs. Many operations should be filling them full of search traces and so
> on, so that might have useful things in it.
> 
> Have you followed the steps in here:
> http://wiki.koha-community.org/wiki/Elasticsearch
> in particular, adding the mapping SQL file into the database.

I followed the steps in "http://wiki.koha-community.org/wiki/Elasticsearch",and
also added the mapping SQL file into the database.
I useed Ubuntu 14.10 to install the ES Koha.
The following is the information of elasticsearch log file.

[2015-03-06 12:27:18,359][INFO ][node                     ] [koha]
version[1.3.7], pid[3448], build[3042293/2014-12-16T13:59:32Z]
[2015-03-06 12:27:18,360][INFO ][node                     ] [koha] initializing
...
[2015-03-06 12:27:18,367][INFO ][plugins                  ] [koha] loaded [],
sites []
[2015-03-06 12:27:23,291][INFO ][node                     ] [koha] initialized
[2015-03-06 12:27:23,292][INFO ][node                     ] [koha] starting ...
[2015-03-06 12:27:23,476][INFO ][transport                ] [koha]
bound_address {inet[/0:0:0:0:0:0:0:0:9300]}, publish_address
{inet[/192.168.1.3:9300]}
[2015-03-06 12:27:23,532][INFO ][discovery                ] [koha]
koha/yPYdtMzrTtucBGGFgGYAnw
[2015-03-06 12:27:26,588][INFO ][cluster.service          ] [koha] new_master
[koha][yPYdtMzrTtucBGGFgGYAnw][koha][inet[/192.168.1.3:9300]], reason:
zen-disco-join (elected_as_master)
[2015-03-06 12:27:26,644][INFO ][http                     ] [koha]
bound_address {inet[/0:0:0:0:0:0:0:0:9200]}, publish_address
{inet[/192.168.1.3:9200]}
[2015-03-06 12:27:26,649][INFO ][node                     ] [koha] started
[2015-03-06 12:27:26,728][INFO ][gateway                  ] [koha] recovered
[0] indices into cluster_state
[2015-03-06 12:28:45,881][INFO ][cluster.metadata         ] [koha]
[koha_biblios] creating index, cause [api], shards [5]/[1], mappings [data]
[2015-03-06 12:28:46,740][INFO ][cluster.metadata         ] [koha]
[koha_biblios] deleting index
[2015-03-06 12:29:35,050][INFO ][cluster.metadata         ] [koha]
[koha_biblios] creating index, cause [api], shards [5]/[1], mappings []
[2015-03-06 12:31:41,222][INFO ][node                     ] [koha] stopping ...
[2015-03-06 12:31:41,338][INFO ][node                     ] [koha] stopped
[2015-03-06 12:31:41,339][INFO ][node                     ] [koha] closing ...
[2015-03-06 12:31:41,352][INFO ][node                     ] [koha] closed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 06:04:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 05:04:13 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-6XGmVQzJBH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #45 from Peter Zhao <peterzhaonj at 163.com> ---
(In reply to Robin Sheat from comment #43)
> (In reply to Peter Zhao from comment #42)
> >           It is a great job! Thanks a lot. I tried to install a ES.
> >           It seems to index the biblio. But I can't search the record."No
> > results found!" I can find the record by Zebra.
> >           koha at koha:~$
> > /home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl -v -d
> > Indexing biblios
> > 1
> > 
> >            Could you give some advice?
> 
> There's not really enough info to go on there. I'd start by looking in the
> logs. Many operations should be filling them full of search traces and so
> on, so that might have useful things in it.
> 
> Have you followed the steps in here:
> http://wiki.koha-community.org/wiki/Elasticsearch
> in particular, adding the mapping SQL file into the database.

The following is the "koha-opac-error log "
[Fri Mar 06 12:30:19.551872 2015] [cgi:error] [pid 3674] [client
127.0.0.1:45890] AH01215: [Fri Mar  6 12:30:19 2015] opac-search.pl: Use of
uninitialized value $f in hash element at
/usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 479.,
referer: http://127.0.1.1/cgi-bin/koha/opac-search.pl?idx=ti&q=theology
[Fri Mar 06 12:33:43.232092 2015] [cgi:error] [pid 3759] [client
127.0.0.1:45904] AH01215: [Fri Mar  6 12:33:43 2015] opac-search.pl: Use of
uninitialized value $f in hash element at
/usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 479.,
referer: http://127.0.1.1/cgi-bin/koha/opac-search.pl?idx=&q=theology
[Fri Mar 06 12:33:43.398916 2015] [cgi:error] [pid 3759] [client
127.0.0.1:45904] AH01215: [Fri Mar  6 12:33:43 2015] opac-search.pl: Use of
uninitialized value $error in concatenation (.) or string at
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 568., referer:
http://127.0.1.1/cgi-bin/koha/opac-search.pl?idx=&q=theology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:11:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 07:11:54 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-HbbBzeCH5v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:11:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 07:11:58 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-J4ROvankWv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36616|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36638
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36638&action=edit
[PASSED QA] Bug 13789 - facets with accented utf-8 characters generate double
encoded links

Bug 13425 tried to fix XSS in OPAC, by using url filter in template toolkit
on whole generated url. This doesn't work and create double encoded strings
in facets because we are creating url variable by concatenating query_cgi
(which did pass through uri_escape_utf8 on perl side) and other
parameters which have to be escaped in template.

Also, code like

[% SET limit_cgi_f = limit_cgi | url %]

doesn't do anything (at least doesn't apply url filter) so it's not needed.

This patch also fixes encoding of hidden fields used in sort by form.

And lastly, it tries to make facet changes for opac and intranet as same as
possible to simplify future maintencence of this code.

Test scenario:
1. find results in your opac which contain accented characters
2. click on them and verify that results are missing
3. apply this patch
4. re-run search and click on facets link verifying that there are
   now results
5. test sort by form and verify that results are ok
6. verify that facets are still safe from injection by constructing url like
  
/cgi-bin/koha/opac-search.pl?q=123&sort_by='"><script>prompt('Happy_Holidays')</script>&limit=123
   and verifying that you DON'T see prompt window in your browser

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:50:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 07:50:28 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-RfUrnn3rva@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
  Attachment #36551|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:50:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 07:50:33 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-8E9epvx193@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36560|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:50:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 07:50:38 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-WecszWxEeC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36561|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:50:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 07:50:45 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-hhhHE87Nv9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36562|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:50:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 07:50:51 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-JaiMz9caxA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36563|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:50:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 07:50:56 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-s5PQqUK0kP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36564|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:51:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 07:51:03 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-iVrOyGFgdG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36565|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 08:51:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 07:51:58 +0000
Subject: [Koha-bugs] [Bug 13801] New: SVC bib bad encoding
Message-ID: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

            Bug ID: 13801
           Summary: SVC bib bad encoding
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org

If you want to get marcxml bibliographic record through /svc/bib service, it
return national characters badly (possibly double?) encoded. Like this:

<datafield tag="653" ind1="0" ind2=" ">
<subfield code="a">historick?? rom??ny</subfield>
<subfield code="a">Je?????? Kristus</subfield>
<subfield code="a">Jeruzal??m</subfield>
<subfield code="a">??ivotopis</subfield>
</datafield>

It should be:
<datafield tag="653" ind1="0" ind2=" ">
<subfield code="a">historick? rom?ny</subfield>
<subfield code="a">Je??? Kristus</subfield>
<subfield code="a">Jeruzal?m</subfield>
<subfield code="a">?ivotopis</subfield>
</datafield>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:06:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:06:03 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-4bLIc2EQk7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36278|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:06:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:06:33 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-S0sE7uk8oR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Should be good now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:21:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:21:49 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-ACNR16hdlS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:26:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:26:57 +0000
Subject: [Koha-bugs] [Bug 13802] New: Renewals ignore hard due dates
Message-ID: <bug-13802-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13802

            Bug ID: 13802
           Summary: Renewals ignore hard due dates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It appears that when renewing items the hard due date is not checked and so
there is a way around the hard due date if you renew.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:27:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:27:54 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-o06hkXk4js@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:29:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:29:24 +0000
Subject: [Koha-bugs] [Bug 12008] hold notice can be deleted
In-Reply-To: <bug-12008-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12008-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12008-70-XiKi18FiGT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12008

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Severity|critical                    |normal

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This should be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:33:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:33:33 +0000
Subject: [Koha-bugs] [Bug 9819] stopwords related code should be removed
In-Reply-To: <bug-9819-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9819-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9819-70-3qq9DaLOQz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9819

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #17 from Nicole C. Engard <nengard at gmail.com> ---
I'd also like to see this make it's way in to Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:33:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:33:32 +0000
Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold
 notifications in patron messaging preferences.
In-Reply-To: <bug-13171-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13171-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13171-70-ghd2ZV7b4H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Have you still the problem?
If yes, please paste the return for the following mysql command:
  select * from message_transports;

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:36:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:36:55 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-IhuaU3sawp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 36471
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36471
[SIGNED-OFF] Bug 11201: Add a in-house use list pages

Review of attachment 36471:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11201&attachment=36471)
-----------------------------------------------------------------

Tiny tiny things... :)

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt
@@ +46,4 @@
>  	systems with large numbers of overdue items.</li>[% END %]
>  	<li>    <a href="/cgi-bin/koha/circ/branchoverdues.pl">Overdues with fines</a> - Limited to your library.  See report help for other details.</li>
>  <!--	<li>    <a href="/cgi-bin/koha/circ/stats.pl?time=yesterday">Daily reconciliation</a></li> -->
> +    <li><a href="/cgi-bin/koha/circ/on-site_checkouts.pl">On-site checkout list</a></li>

Hi Jonathan, can you please make the visibility of the link depend on the
system preference?

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/on-site_checkouts.tt
@@ +40,5 @@
> +<div id="doc3" class="yui-t2">
> +  <div id="bd">
> +    <div id="yui-main">
> +      <div class="yui-b">
> +        <h4>Pending on-site checkout list</h4>

I think this should be <h1> as on the other pages - otherwise the 'no
pending...' message is bigger than the heading.

After discussing with Nicole it would be nice if the circulation start page and
the heading both said:
Pending on-site checkouts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:37:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:37:06 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-bKyACNymHY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:40:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:40:23 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-Vzo78UwaMm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
After checking with Jonathan, it would be ok to have the library always select
the due date and not force it to the end of the day. I will try to make that
happen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:42:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:42:51 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-KHozrF2roQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
Created attachment 36639
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36639&action=edit
[Signed-off] Bug 13350: Untranslatable strings in aqbudgetperiods.tt

Counter patch, same test plan as original

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:43:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:43:26 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-6kWWlthRHB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36634|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:43:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:43:43 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-TKCXEbuCK7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36407|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:44:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:44:12 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-XeAEYGhjVb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:49:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:49:04 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-tz1GNPtyWW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org

--- Comment #1 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
I can't seem to reproduce this bug on current master. Do you see that on all or
just some records? Do you see it on all fields?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:49:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:49:32 +0000
Subject: [Koha-bugs] [Bug 13558] In-house checkouts: optionally allow
 library to choose due date
In-Reply-To: <bug-13558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13558-70-JFCe1YsZn2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13558

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 13647 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:49:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:49:32 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-2pGLLPPETv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 13558 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:55:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:55:24 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-e9o9yiOy6d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:55:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:55:28 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-s5ioJnWRxD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36603|0                           |1
        is obsolete|                            |

--- Comment #20 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36640
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36640&action=edit
Bug 10703: Update course reserves DB documentation

To test review database documentation to see that course tables are
all documented.

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:55:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:55:39 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-JxpvD2UVge@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36604|0                           |1
        is obsolete|                            |

--- Comment #21 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36641
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36641&action=edit
Bug 10703: Update stats table documentation

This patch updates the DB documentation for the statistics
table.

To test review the file and cofirm that documentation is there

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 09:55:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 08:55:47 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-OEYK5GvrCu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36605|0                           |1
        is obsolete|                            |

--- Comment #22 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36642
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36642&action=edit
Bug 10703: Update Patron DB Documentation

Update patron categories and patron restrictions DB docs.

To test:

* Review database documentation for categories
* Review database documentation for patron_debarments

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:02:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:02:38 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-srahHlueyH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

--- Comment #2 from Mike <black23 at gmail.com> ---
Hello,
problem is in all tested records and fields. I can give You access into our
testing server, if it help. 
Complete example: http://pastebin.com/n6Fg0Ase

Thanks

Mike

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:12:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:12:12 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-SFxHs6zYu0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #29 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by sonia bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:12:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:12:29 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-tNKc7qEQnB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36613|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:12:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:12:34 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-sFdZfKqtkG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36628|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:12:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:12:39 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-Z8Jhid4gyX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36629|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:12:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:12:50 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-1k1EC5yEe2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #30 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36643
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36643&action=edit
Bug 13635: Unimarc - On editing a notice, the title should be displayed

The title method of MARC::Record does not deal with UNIMARC, it should
not be called if the marc flavour is UNIMARC.

Test plan:
On an unimarc installation, edit a notice, with this patch you should
see
 "Editing TITLE (Record number BIBLIONUMBER)"

Without, the title was not displayed.
Same in the breadcrumbs.

Bug 13635: Remove another useless call

There is another call to the title method in additem.pl without any
check on the marc flavour.
But here the title variable sent to the template is redefined 3 lines
later.
So it can be simply removed.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested on UNIMARC install, editing a 'record' (not notice) does not show
title on breadcrumbs, status bar or page title.
With patch it does!
No koha-qa errors.

Signed-off-by: joel aloi <aloi54 at live.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: sonia bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:12:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:12:54 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-VBcWLyae7a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #31 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36644
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36644&action=edit
Bug 1985 - Email notification of new OPAC comments

This feature adds YAS 'CommentModeratorsEmail', where an email (template code
COMMENT_CREATED) is sent when
a borrower creates/modifies an comment/review. The syspref is empty by default
and no email is sent when the
syspref is empty.

This feature is needed because we want to alert our content moderators to take
action when needed. Usually
it is our librarians who write reviews and this improvement makes the process
of moving Koha reviews to our
CMS more smooth.

TEST SETUP:
-1. Run updatedatabase.pl to add the syspref and the new letter template.
0. Go to admin/preferences.pl?tab=opac, and set the
'CommentModeratorsEmail'-syspref to your email-address.

TEST PLAN:
1. Log in to OPAC and find any Biblio.
2. Make a comment/review for it.
3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'.
You should see the reasonable
   default message. You can change the message in tools/letter.pl.

NOTE: Tested in conjunction with my patch. However, this piece
      alone:
      - lacked unit tests since it modified C4/Review.pm
      - failed to provide the desired links in the email message,
        as mentioned in comment #1.
      - failed to pass biblionumber information for use in the
        letter as mentioned in comment #11.
      - passed $review, when it was really id that should have
        been passed and used to implement the inclusion of
        reviews.reviewid and other reviews table fields.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: sonia bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:12:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:12:58 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-9uPOGqZvJt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #32 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36645
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36645&action=edit
Bug 1985 - tweak License and lots of cleanup

In comment #11, it was mentioned that title and biblionumber from
the biblio table were not available as variables in the letter.

This corrects this by converting the parameter list to a hashref,
and adding the missing biblio number.

It also cleans up the license on C4/Review.pm to be in line with
the current coding guidelines license. Also strict and warning
have been changed to the 'Use Modern::Perl;' now.

Additionally, <<reviews.reviewid>> is now usable in the letter,
as is <<staffClientBaseURL>>. These were required additions,
because comment #1 expressly says there should be a direct link
to approve or delete. I also included a review everything link,
since there could be multiple comments outstanding.

The default letter was tweaked as well to reflect these changes.

Fixed bad URLs as noted in comment #26.

TEST PLAN
---------
1) Create test branch and apply patch
2) run installer/data/mysql/updatedatabase.pl
   -- this will add the required default letter.
3) In the staff client:
   a) set the CommentModeratorsEmail system preference.
      -- not setting it will mean you won't get any queued
         letters.
   a) set the staffClientBaseURL system preference.
      -- not setting it will mean your email links won't be
         valid (i.e http:///...).
   b) modify the COMMENT_CREATED default letter as desired.
      -- feel free to add other things.
4) In the OPAC:
   a) Log in
   b) Find something
   c) Click on the 'Comments' tab
      -- Holdings/Title notes/Comments (#) is at the bottom
   d) Click 'Post or edit your comments on this item'
   e) In the window that pops up, type your comment.
   f) Click 'Submit and close this window'.
   g) Click 'Edit' and repeat steps e and f again.
5) In a mysql client:
   a) Open the koha database
   b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED';
      -- There should be at least two.
      -- They should be able to contain the borrower number, biblio
         title, and other borrower and biblio related things.
      -- Comments are at a biblio level, so items, and issues don't
         make sense as variables for the letter.
      -- Confirm the URLs are valid by pasting into a browser.
6) prove -v t/db_dependent/Review.t
7) Run the koha qa test tool.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: sonia bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:16:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:16:18 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-bM4gzbV8VZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
I've just tried the the master version from git now, on another server (new
clean virtual with debian wheezy). I've imported this record from library of
congress: http://lccn.loc.gov/59046328

and then tried to access it through
http://<staff-interface>/cgi-bin/koha/svc/bib/1

accessed through browser (Firefox and Chromium): http://pastebin.com/ueb58YKZ

downloaded using curl: http://pastebin.com/LG09JjeB

through browser, the encoding seems bad, through curl everything is ok...

could be some problem with http headers? (just guess)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:17:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:17:33 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-7AWJBaknYs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #33 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
I've done again all the tests (until point 6 but I think point 6 and 7 can be
done at the QA step ?)
Everything works correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:22:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:22:09 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-Kkt0PP1nUs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36643|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:23:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:23:36 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-9UnjIs9H8V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m, katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:30:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:30:35 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-O9ri7heBXp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

--- Comment #18 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36646
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36646&action=edit
Bug 11201: qa-followup

- move h4 to h1
- Make the link on the circ home page depending on the pref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:30:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:30:30 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-0Dh7l8ao92@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:31:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:31:33 +0000
Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch
 from a staged file
In-Reply-To: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12074-70-WB4laFVOeJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074

aloij <aloi54 at live.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |aloi54 at live.fr

--- Comment #14 from aloij <aloi54 at live.fr> ---
the patch is applied correctly. When adding a batch of documents to a basket ,
duplicates are ignored and correctly
a visual alert is displayed with a link to them so they can be treated so
individual .
Signed off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:33:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:33:13 +0000
Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch
 from a staged file
In-Reply-To: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12074-70-iCrL86MKnn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com

--- Comment #15 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by JA <aloi54 at live.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:33:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:33:31 +0000
Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch
 from a staged file
In-Reply-To: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12074-70-xvVm96NeqV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36144|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:33:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:33:38 +0000
Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch
 from a staged file
In-Reply-To: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12074-70-49qFTzDWUv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074

--- Comment #16 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36647
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36647&action=edit
Bug 12074 Filter duplicates when adding a batch from a staged file

When adding a batch of records to a basket, duplicates are skipped and
an alert is displayed with a link to them so as they could be treated
individually.

Signed-off-by: JA <aloi54 at live.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:39:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:39:48 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-2mxKmpJQ56@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:39:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:39:52 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-O3NArN4KaF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36640|0                           |1
        is obsolete|                            |
  Attachment #36641|0                           |1
        is obsolete|                            |
  Attachment #36642|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36648
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36648&action=edit
Bug 10703: Update course reserves DB documentation

To test review database documentation to see that course tables are
all documented.

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:40:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:40:37 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-wR8eqdbxX6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

--- Comment #24 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36649
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36649&action=edit
Bug 10703: Update stats table documentation

This patch updates the DB documentation for the statistics
table.

To test review the file and cofirm that documentation is there

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:43:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:43:39 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-h8yvpvtJrZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

--- Comment #25 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36650
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36650&action=edit
Bug 10703: Update Patron DB Documentation

Update patron categories and patron restrictions DB docs.

To test:

* Review database documentation for categories
* Review database documentation for patron_debarments

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:49:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:49:58 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-gfMg2Mo9Y6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I reproduce the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:53:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:53:40 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-LQpbpHW2e0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:53:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:53:45 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-Hvp1YKBPRf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36414|0                           |1
        is obsolete|                            |
  Attachment #36415|0                           |1
        is obsolete|                            |
  Attachment #36416|0                           |1
        is obsolete|                            |
  Attachment #36417|0                           |1
        is obsolete|                            |
  Attachment #36418|0                           |1
        is obsolete|                            |

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36651
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36651&action=edit
[PASSED-QA] Bug 7843 Create an RSS feed for news in Opac

Test plan:
* Install the patch
* Make shure there is news in the Opac
* Go to the Opac (opac-main.pl)
* Make shure you see an RSS icon below the news and a short text.
* Click the RSS icon and verify that you get an RSS feed that validates.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

I took the liberty of fixing the copyright statement when signing it off

Signed-off-by: Pierre <tredok.pierre at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:54:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:54:07 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-uBuhnWlTjj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36652
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36652&action=edit
[QA-FOLLOWUP] Bug 7843: Remove the useless use of casAuthentication

Certainly a c/p error from opac-main.pl

Signed-off-by: Pierre <tredok.pierre at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:54:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:54:12 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-GuTXaxz7U4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36653
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36653&action=edit
[PASSED-QA] Bug 7843: (qa-followup) Create an RSS feed for news in Opac

1/ use strict and warnings are useless, Modern::Perl is used
2/ Prefer to use the interface and theme TT var instead of the hard
coded path

Signed-off-by: Pierre <tredok.pierre at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:54:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:54:16 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-Cko4OBdP4r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36654
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36654&action=edit
[PASSED-QA] Bug 7843 - (follow up) Improve RSS feed language

The RSS button used to read ' RSS for the librarys general newsfeed.'
This included one grammatical error and I think included more words
than most average people would read.  This patch simplifies it to say
'RSS for Library News.'

To test:
* Apply all patches
* Review RSS feed button's text on main page under news

http://bugs.koha-community.org/show_bug.cgi?id=7843

Signed-off-by: Pierre <tredok.pierre at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:54:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:54:21 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-vxDYf3BhkQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36655
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36655&action=edit
[PASSED-QA] Bug 7843: Followup - fix broken url

This patch fixes an invalid URL when clicking
on RSS feed.

To test:
1) Using Nicole words :)
If you visit : http://mykoha/cgi-bin/koha/opac-main.pl
then the RSS feed works.
If you're on http://mykoha and you click the rss icon you
get : http://mykoha/opac-news-rss.pl which is a 404 page.

2) Apply the patch

3) Repeat 1, error is now fixed

Signed-off-by: Pierre <tredok.pierre at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:54:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:54:26 +0000
Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news
In-Reply-To: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7843-70-YBTwjkYgem@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36656
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36656&action=edit
Bug 7843 [QA Followup] - Make news selection persistant

This patch makes the following changes:
1) If there is no logged in patron, the RSS link states it is for
   system-wide news.
2) If a patron is logged in, the RSS link states it is for system-wide
   news *and* news for the patron's home library.
3) The patron's home branch code is embedded in the RSS feed url so
   he or she no longer needs to be logged in for us to know what branch's
   news to pull.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:54:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:54:53 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-Lh2RFtvwnp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:54:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:54:57 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-Mem3tnN9KD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36546|0                           |1
        is obsolete|                            |

--- Comment #3 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36657
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36657&action=edit
Bug 13793: Make the installer output the result of the updates under Plack

Test plan:
0/ Start plack for intranet
1/ Create a new entry in updatedatabase.pl, something like:

$DBversion = "3.19.00.013";
if(CheckVersion($DBversion)) {
    print "Upgrade to $DBversion done (Bug test plack - This is a
est)\n";
    print "Upgrade to $DBversion done (Bug test plack - This is anoter
est)\n";
    print "Upgrade to $DBversion done (Bug test plack - This is a third
est)\n";
    warn "this is an error";
}
and modify the kohaversion.pl accordingly.
You can also warn something to simulate an error.
2/ Go on the mainpage (or wherever you want), you should be redirected
to the installer
3/ Notice that the output of the updatedatabase is displayed on the
screen.
4/ Confirm that new files have been created in your Koha log directory
(check the logdir entry in your koha conf file).
5/ Confirm that the output is still displayed without Plack.

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:57:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:57:29 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-cweVsNSrgF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:57:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:57:32 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-wNAdNscvUV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36658
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36658&action=edit
Bug 13801: svc/bib - Set charset to utf-8 on printing header

Test plan:
0/ Add unicode characters on the record biblionumber=X
1/ go on http://<staff-interface>/cgi-bin/koha/svc/bib/X
2/ Confirm you have encoding issues
3/ Apply the patch
4/ Repeat 2
5/ Confirm that all is correctly encoded

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 10:57:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 09:57:45 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-eLi4kumlfA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:00:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:00:49 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-xOEOa6r9Kb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:00:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:00:53 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-S3bJBc8zG1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36659
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36659&action=edit
Bug 13647: On-site checkouts - Allow library to specify due date

This will remove the restriction that forces the due date for
an on-site checkout to the end of the current day.

It will still suggest the end of the day, but you will be able
to change the date to whatever you want using the datepicker
widget.

To test:

Before applying the patch:
- Turn on OnSiteCheckouts and OnSiteCheckoutsForce
  system preferences
- Check the on-site use checkbox and try to set due date
  manually, it should not be possible
- Check out the item and check the due date is set to the
  end of today
- Put a restriction on your patron account and repeat steps,
  the item checked out should again have a due date at the
  end of the day
> There should be no way to be able to check out an item
  with a 'custom' due date

Apply the patch:
- Repeat steps from above, check out
  - on-site use without a restriction on your account
    - without changing the due date
    - with a due date picked with the datepicker
  - on-site use with a restriction on your account
    ... see above
  - no on-site use but with a specified due date
  - no on-site use, not specifying a due date

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:01:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:01:15 +0000
Subject: [Koha-bugs] [Bug 13803] New: SelfCheck not setting flag when item
 requires transit
Message-ID: <bug-13803-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13803

            Bug ID: 13803
           Summary: SelfCheck not setting flag when item requires transit
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Self checkout
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

On 3M and other selfcheck machines returned items are routed to separate return
bins based on flags in checkin response. Some libraries are reporting this as
not happening. Problem was that when the return was flagging WasTransfered this
was not setting the flag unlike other conditions resulting in a transit. Add
this to the conditions setting the flag

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:03:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:03:22 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-0RIuBsB0am@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:03:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:03:26 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-eNQk34PNSy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

--- Comment #26 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36660
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36660&action=edit
Bug 10703: Add more serial table DB documentation

This patch adds a bit more documentation to the serial related tables
in Koha.

To test, apply the patch and review the kohastructure for comments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:04:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:04:48 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: <bug-13726-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13726-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13726-70-8L5kDVsIet@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Auto-merging acqui/invoice.pl
CONFLICT (content): Merge conflict in acqui/invoice.pl
Auto-merging acqui/basket.pl
CONFLICT (content): Merge conflict in acqui/basket.pl
Auto-merging C4/Acquisition.pm
CONFLICT (content): Merge conflict in C4/Acquisition.pm


After applying 13719...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:06:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:06:42 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-uUOn90liw3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:06:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:06:49 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-FrbtlplabU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36544|0                           |1
        is obsolete|                            |

--- Comment #237 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36661
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36661&action=edit
BUG 7143: Add Kyle Hall as the 42nd developer to history

I found Kyle's first commit and added him to the history

http://lists.gnu.org/archive/cgi-bin/namazu.cgi?query=kyle&submit=Search!&idxname=koha-cvs&max=20&result=normal&sort=date%3Aearly

While in there I added tags to releases and developers that were missing.

To test:

* Log in to staff client
* visit about koha
* check to make sure timeline is right

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:07:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:07:04 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-zgvLA2eHfe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #238 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36662
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36662&action=edit
Bug 7143: Add "developer" for all devs

Some were missing.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:07:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:07:17 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-b7jqVsWije@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36646|0                           |1
        is obsolete|                            |

--- Comment #19 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36663
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36663&action=edit
Bug 11201: qa-followup

- move h4 to h1
- Make the link on the circ home page depending on the pref

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:08:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:08:28 +0000
Subject: [Koha-bugs] [Bug 13804] New: Returns via the checkouts tables uses
 the phrase "Returned" rather than "Checked in"
Message-ID: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

            Bug ID: 13804
           Summary: Returns via the checkouts tables uses the phrase
                    "Returned" rather than "Checked in"
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:08:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:08:39 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-dubdetzdGU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:09:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:09:39 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-tVADEZObAs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36664
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36664&action=edit
Bug 13804 - Returns via the checkouts tables uses the phrase "Returned" rather
than "Checked in"

Test plan:
1) Apply this patch
2) Return an item via the checkouts table
3) Note the left most column now reads "Checked in" rather than "Returned"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:10:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:10:01 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-i9zsFEN4MU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:16:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:16:23 +0000
Subject: [Koha-bugs] [Bug 13803] SelfCheck not setting flag when item
	requires transit
In-Reply-To: <bug-13803-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13803-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13803-70-yj7nfsuThi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13803

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
                   |ity.org                     |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 36665
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36665&action=edit
Proposed Patch

Trivial patch adding check of this status to others already included. Can have
a big impact on libraries with lots of selfcheck machines and users able to
return other than home branch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:16:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:16:47 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-XrLMH08HV3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:16:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:16:51 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-3fm3vJwh36@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36659|0                           |1
        is obsolete|                            |

--- Comment #4 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36666
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36666&action=edit
Bug 13647: On-site checkouts - Allow library to specify due date

This will remove the restriction that forces the due date for
an on-site checkout to the end of the current day.

It will still suggest the end of the day, but you will be able
to change the date to whatever you want using the datepicker
widget.

To test:

Before applying the patch:
- Turn on OnSiteCheckouts and OnSiteCheckoutsForce
  system preferences
- Check the on-site use checkbox and try to set due date
  manually, it should not be possible
- Check out the item and check the due date is set to the
  end of today
- Put a restriction on your patron account and repeat steps,
  the item checked out should again have a due date at the
  end of the day
> There should be no way to be able to check out an item
  with a 'custom' due date

Apply the patch:
- Repeat steps from above, check out
  - on-site use without a restriction on your account
    - without changing the due date
    - with a due date picked with the datepicker
  - on-site use with a restriction on your account
    ... see above
  - no on-site use but with a specified due date
  - no on-site use, not specifying a due date

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:18:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:18:09 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-8QgCQOhEfj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:23:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:23:13 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-pNKX1zyGcI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Sorry, I found a bug. If SpecifyDueDate is disabled, the due date should be set
to today.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:24:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:24:04 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-4IxSGgM3Pr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36664|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36667
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36667&action=edit
Bug 13804 - Returns via the checkouts tables uses the phrase "Returned" rather
than "Checked in"

Test plan:
1) Apply this patch
2) Return an item via the checkouts table
3) Note the left most column now reads "Checked in" rather than "Returned"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:30:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:30:46 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-SeqwehFWPr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36658|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 36668
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36668&action=edit
Bug 13801: svc/bib - Set charset to utf-8 on printing header

Test plan:
0/ Add unicode characters on the record biblionumber=X
1/ go on http://<staff-interface>/cgi-bin/koha/svc/bib/X
2/ Confirm you have encoding issues
3/ Apply the patch
4/ Repeat 2
5/ Confirm that all is correctly encoded

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:32:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:32:15 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-T5YvpFYdwv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Works as expected, thank you Jonathan.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:32:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:32:56 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-wLS6JWV6Wm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:32:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:32:59 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-96r2wimk5W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36650|0                           |1
        is obsolete|                            |

--- Comment #27 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36669
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36669&action=edit
Bug 10703: Update Patron DB Documentation

Update patron categories and patron restrictions DB docs.

To test:

* Review database documentation for categories
* Review database documentation for patron_debarments

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:33:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:33:08 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-AMvcnfjq9y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36660|0                           |1
        is obsolete|                            |

--- Comment #28 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36670
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36670&action=edit
Bug 10703: Add more serial table DB documentation

This patch adds a bit more documentation to the serial related tables
in Koha.

To test, apply the patch and review the kohastructure for comments

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:38:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:38:40 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-rG33P7AwCz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:38:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:38:45 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-rntPmwqDVN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36348|0                           |1
        is obsolete|                            |
  Attachment #36349|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36671
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36671&action=edit
[PASSED QA] Bug 13507 [Follow-up] : Add unit test.

Signed-off-by: Koha Team AMU <koha.aixmarseille at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:39:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:39:28 +0000
Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports
In-Reply-To: <bug-11887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11887-70-MTb5VQI7DO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:39:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:39:46 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-TTodkHzLFY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36672
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36672&action=edit
[PASSED QA] Bug 13507: Add intranet support for CAS authentication

 This patch allows to use CAS authentication for intranet login.

 It works exactly the same as the OPAC login, except that the
 staffClientBaseURL syspref must be set for intranet login
 (like OPACBaseURL must be set for OPAC login).

Signed-off-by: Koha Team AMU <koha.aixmarseille at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:41:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:41:19 +0000
Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine
	payment form.
In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-EviG9qIsyG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #10 from Nicole C. Engard <nengard at gmail.com> ---
Am I supposed to apply to all these patches? I got the following:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11373: Add a "cash register" feature to the fine payment form.
/home/nengard/kohaclone/.git/rebase-apply/patch:242: trailing whitespace.
        $template->param( 
/home/nengard/kohaclone/.git/rebase-apply/patch:247: trailing whitespace.
        $template->param( 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
<stdin>:242: trailing whitespace.
        $template->param( 
<stdin>:247: trailing whitespace.
        $template->param( 
warning: 2 lines applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging members/paycollect.pl
Auto-merging C4/Accounts.pm
CONFLICT (content): Merge conflict in C4/Accounts.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 11373: Add a "cash register" feature to the fine
payment form.
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-11373-Add-a-cash-register-feature-to-the-fine--I0lypc.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:41:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:41:57 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-T26v71sJI5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Martin, could you take a final look at the code for this? 

In my testing it worked alright, tested with a biblibre test CAS server -
Matthias can give you the data for that. (Very useful!)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:44:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:44:41 +0000
Subject: [Koha-bugs] [Bug 13166] add all restrictions purge to
	cleanup_database.pl
In-Reply-To: <bug-13166-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13166-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13166-70-ZcAYFfCLTA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13166

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:44:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:44:45 +0000
Subject: [Koha-bugs] [Bug 13166] add all restrictions purge to
	cleanup_database.pl
In-Reply-To: <bug-13166-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13166-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13166-70-fXx6Uvp8py@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13166

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32971|0                           |1
        is obsolete|                            |

--- Comment #3 from Larry Baerveldt <larry at bywatersolutions.com> ---
Created attachment 36673
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36673&action=edit
[SIGNED OFF] Bug 13166 - add all restrictions purge to cleanup_database.pl

Bug 12760 adds the ability to purge expired restrictions older than some days.

But if you want to purge all expired restrictions, using "--restrictions 0"
does not work, it's like "--restrictions" so it uses default purge days.

This patch adds a new option "--all-restrictions" to purge all expired
restrictions.

Test plan :
- Select a borrower
- Create a restriction with expiration date in the futur
- Create a restriction expired since 1 day
- Create a restriction expired since 10 days
- run without argument "misc/cronjobs/cleanup_database.pl"
=> You see help text for --all-restrictions option
- run "misc/cronjobs/cleanup_database.pl -v --restrictions --all-restrictions"
=> You get the message : You can not specify both --restrictions and
--all-restrictions
- run "misc/cronjobs/cleanup_database.pl -v --restrictions 30"
=> no restriction is removed
- run "misc/cronjobs/cleanup_database.pl -v --restrictions 9"
=> restriction expired since 10 days is removed
- run "misc/cronjobs/cleanup_database.pl -v --all-restrictions"
=> restriction expired since 1 day is removed

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:46:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:46:48 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-FqzoEpriOX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35372|0                           |1
        is obsolete|                            |

--- Comment #78 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 36674
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36674&action=edit
Bug 8236 Renewing policy in overdue or restriction case

patch rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:46:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:46:56 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-n0A6Q0huR1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:47:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:47:13 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-1wDFH233rP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:47:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:47:47 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-9MnLq6pzBu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |nengard at gmail.com

--- Comment #15 from Nicole C. Engard <nengard at gmail.com> ---
It works great, but failed QA tests:


Processing files before patches
|========================>| 8 / 8 (100.00%)
Processing files after patches
|========================>| 8 / 8 (100.00%)

 FAIL   C4/Budgets.pm
   OK     critic
   OK     forbidden patterns
   FAIL   pod
                *** ERROR: 
                Spurious text after =cut  in file C4/Budgets.pm
   OK     valid

 FAIL   reports/orders_by_budget.pl
   OK     critic
   OK     forbidden patterns
   OK     pod
   FAIL   valid
                Possible attempt to separate words with commas

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:49:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:49:55 +0000
Subject: [Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19
	(October 2014)
In-Reply-To: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13322-70-pgmsAVDXfc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:50:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:50:01 +0000
Subject: [Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19
	(October 2014)
In-Reply-To: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13322-70-u0KCWxKwp1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36258|0                           |1
        is obsolete|                            |

--- Comment #3 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36675
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36675&action=edit
Bug 13322: Update MARC21 frameworks to Update No. 19

Summary of changes:
1) Bibliographic
- Added fields 370 and 388
- 382s is non repeatable
- $g added to 650 and 651
- $g now repeatable on 100,110,111,130,240,243,246,247,
  600,610,611,630,700,710,711,730,800,810,811 and 830

2) Authority
- Added field 388
- New $g on 150,151,450,451,550,551,750 and 751
- New $i on 700,710,711,730,748,750,751,755,762,780,781,782 and 785
- New $4 on 700,710,711,730,748,750,751,755,762,780,781,782,785 and 788
- $g now repeatable on 100,110,111,130,400,410,411,430,500,
  510,511,530,700,710,711 and 730

This patch updates MARC21 frameworks to Update No. 19 (October 2014)
Also updates values on database for MARC21 installs.

To test
1. Apply the patch
2. Run updatedatbase.pl, check that runs without error
3. Remove default frameworks, bibliographic and authorities (all of them),
load again. Check that both files load without errors.
4. Verify changes

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:55:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:55:56 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-IOxtrtJd6k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 11:56:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 10:56:01 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-jn9mjAHUZc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36498|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36676
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36676&action=edit
[PASSED QA] Bug 12887: User logged out on refresh after CAS authentication

If the user is already logged-in, do not trigger CAS authentication
even if there is a ticket in the parameters.

1) Authenticate to the OPAC through CAS.
2) Once redirected to your account, hit F5 or the refresh button of your
browser.
3) You're logged out.

Signed-off-by: Koha Team Lyon 3 <koha at univ-lyon3.fr>
Signed-off-by: Luce Barbey <luce.barbey at cirad.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Added sign of lines according to bug.
Works as described, small change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:01:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:01:23 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-W1d4lXvFkf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:01:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:01:28 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-fy2FiiJzcH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36644|0                           |1
        is obsolete|                            |
  Attachment #36645|0                           |1
        is obsolete|                            |

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36677
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36677&action=edit
[PASSED-QA] Bug 1985 - Email notification of new OPAC comments

This feature adds YAS 'CommentModeratorsEmail', where an email (template code
COMMENT_CREATED) is sent when
a borrower creates/modifies an comment/review. The syspref is empty by default
and no email is sent when the
syspref is empty.

This feature is needed because we want to alert our content moderators to take
action when needed. Usually
it is our librarians who write reviews and this improvement makes the process
of moving Koha reviews to our
CMS more smooth.

TEST SETUP:
-1. Run updatedatabase.pl to add the syspref and the new letter template.
0. Go to admin/preferences.pl?tab=opac, and set the
'CommentModeratorsEmail'-syspref to your email-address.

TEST PLAN:
1. Log in to OPAC and find any Biblio.
2. Make a comment/review for it.
3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'.
You should see the reasonable
   default message. You can change the message in tools/letter.pl.

NOTE: Tested in conjunction with my patch. However, this piece
      alone:
      - lacked unit tests since it modified C4/Review.pm
      - failed to provide the desired links in the email message,
        as mentioned in comment #1.
      - failed to pass biblionumber information for use in the
        letter as mentioned in comment #11.
      - passed $review, when it was really id that should have
        been passed and used to implement the inclusion of
        reviews.reviewid and other reviews table fields.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: sonia bouis <sonia.bouis at univ-lyon3.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:03:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:03:21 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-HlipFUhUgm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36678
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36678&action=edit
[PASSED-QA] Bug 1985 - tweak License and lots of cleanup

In comment #11, it was mentioned that title and biblionumber from
the biblio table were not available as variables in the letter.

This corrects this by converting the parameter list to a hashref,
and adding the missing biblio number.

It also cleans up the license on C4/Review.pm to be in line with
the current coding guidelines license. Also strict and warning
have been changed to the 'Use Modern::Perl;' now.

Additionally, <<reviews.reviewid>> is now usable in the letter,
as is <<staffClientBaseURL>>. These were required additions,
because comment #1 expressly says there should be a direct link
to approve or delete. I also included a review everything link,
since there could be multiple comments outstanding.

The default letter was tweaked as well to reflect these changes.

Fixed bad URLs as noted in comment #26.

TEST PLAN
---------
1) Create test branch and apply patch
2) run installer/data/mysql/updatedatabase.pl
   -- this will add the required default letter.
3) In the staff client:
   a) set the CommentModeratorsEmail system preference.
      -- not setting it will mean you won't get any queued
         letters.
   a) set the staffClientBaseURL system preference.
      -- not setting it will mean your email links won't be
         valid (i.e http:///...).
   b) modify the COMMENT_CREATED default letter as desired.
      -- feel free to add other things.
4) In the OPAC:
   a) Log in
   b) Find something
   c) Click on the 'Comments' tab
      -- Holdings/Title notes/Comments (#) is at the bottom
   d) Click 'Post or edit your comments on this item'
   e) In the window that pops up, type your comment.
   f) Click 'Submit and close this window'.
   g) Click 'Edit' and repeat steps e and f again.
5) In a mysql client:
   a) Open the koha database
   b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED';
      -- There should be at least two.
      -- They should be able to contain the borrower number, biblio
         title, and other borrower and biblio related things.
      -- Comments are at a biblio level, so items, and issues don't
         make sense as variables for the letter.
      -- Confirm the URLs are valid by pasting into a browser.
6) prove -v t/db_dependent/Review.t
7) Run the koha qa test tool.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: sonia bouis <sonia.bouis at univ-lyon3.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:06:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:06:23 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-MMfF8ukK26@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Passed QA                   |Failed QA

--- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> ---
One more addition is required for this to pass qa. Can you please add the new
notice to all the translations?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:07:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:07:59 +0000
Subject: [Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script
In-Reply-To: <bug-12169-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12169-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12169-70-04QUi1QmEM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |larry at bywatersolutions.com

--- Comment #2 from Larry Baerveldt <larry at bywatersolutions.com> ---
This patch hardcodes the user and group as "koha" and "koha". You should not
hardcode the user and group in the SIPConfig.xml file; those need to be
gathered at the Koha creation phase, either through koha-create and
koha-enable-sip for package, or with makefile.PL for git sites.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:13:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:13:05 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-xTvetVFHDa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:13:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:13:11 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-OpBi1WUfbP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36449|0                           |1
        is obsolete|                            |

--- Comment #59 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36679
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36679&action=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:13:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:13:22 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-zqbjafKq1p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36450|0                           |1
        is obsolete|                            |

--- Comment #60 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36680
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36680&action=edit
Bug 7677: UT: add unit tests for GetPreviousSerialid

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:13:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:13:28 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-a69A3xq46l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36451|0                           |1
        is obsolete|                            |

--- Comment #61 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36681
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36681&action=edit
Bug 7677: FIX QA issues

FAIL    C4/Serials.pm
   FAIL      forbidden patterns
    forbidden pattern: trailing space char (line 1501)
    forbidden pattern: trailing space char (line 921)

 FAIL    serials/serials-edit.pl
   FAIL      valid
        "my" variable $dbh masks earlier declaration in same scope

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:13:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:13:34 +0000
Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold
In-Reply-To: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13592-70-mzkVkxRD1l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592

Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:13:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:13:35 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-5w7rYJWxsC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36452|0                           |1
        is obsolete|                            |

--- Comment #62 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36682
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36682&action=edit
Bug 7677: Fix tests

They don't pass since bug 12098 has been pushed.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:13:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:13:42 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-yauJndcDls@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36453|0                           |1
        is obsolete|                            |

--- Comment #63 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36683
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36683&action=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Fix missing itemtype and previous itemtype when adding a subscription.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

http://bugs.koha-community.org/show_bug.cgi?id=7767

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:14:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:14:52 +0000
Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then
 searching for label items.
In-Reply-To: <bug-11880-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11880-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11880-70-ZEIYhd4nmB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Nicole C. Engard <nengard at gmail.com> ---
I'm confused by this. I was going to sign off but see the notes at the bottom
so I'm re-marking failed qa.  If that's wrong feel free to fix.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:17:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:17:00 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-qyjZuH0lK2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #27 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36684
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36684&action=edit
[SIGNED-OFF] Bug 12598 - Tidy import_borrowers.pl

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:17:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:17:08 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-Koob17ybo1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #28 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36685
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36685&action=edit
[SIGNED-OFF] Bug 12598 - Move importing code to a subroutine

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:17:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:17:10 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-JVUedLkcva@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36666|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36686
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36686&action=edit
Bug 13647: On-site checkouts - Allow library to specify due date

This will remove the restriction that forces the due date for
an on-site checkout to the end of the current day.

It will still suggest the end of the day, but you will be able
to change the date to whatever you want using the datepicker
widget.

To test:

Before applying the patch:
- Turn on OnSiteCheckouts and OnSiteCheckoutsForce
  system preferences
- Check the on-site use checkbox and try to set due date
  manually, it should not be possible
- Check out the item and check the due date is set to the
  end of today
- Put a restriction on your patron account and repeat steps,
  the item checked out should again have a due date at the
  end of the day
> There should be no way to be able to check out an item
  with a 'custom' due date

Apply the patch:
- Repeat steps from above, check out
  - on-site use without a restriction on your account
    - without changing the due date
    - with a due date picked with the datepicker
  - on-site use with a restriction on your account
    ... see above
  - no on-site use but with a specified due date
  - no on-site use, not specifying a due date
- Turn off SpecifyDueDate
  - on-site use with and without restriction should
    set the due date to the current date now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:17:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:17:21 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-ipY53NEVqd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #29 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36687
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36687&action=edit
[SIGNED-OFF] Bug 12598 - Update command line script to use patron import
subroutine

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:17:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:17:33 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-wpetdo15TN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #30 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36688
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36688&action=edit
[SIGNED-OFF] Bug 12598 - Move Koha::Patrons::Import to Koha::Borrower::Import

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:18:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:18:42 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-XNGsd0155g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:18:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:18:45 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-kOvYU8w7yc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36686|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36689
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36689&action=edit
Bug 13647: On-site checkouts - Allow library to specify due date

This will remove the restriction that forces the due date for
an on-site checkout to the end of the current day.

It will still suggest the end of the day, but you will be able
to change the date to whatever you want using the datepicker
widget.

To test:

Before applying the patch:
- Turn on OnSiteCheckouts and OnSiteCheckoutsForce
  system preferences
- Check the on-site use checkbox and try to set due date
  manually, it should not be possible
- Check out the item and check the due date is set to the
  end of today
- Put a restriction on your patron account and repeat steps,
  the item checked out should again have a due date at the
  end of the day
> There should be no way to be able to check out an item
  with a 'custom' due date

Apply the patch:
- Repeat steps from above, check out
  - on-site use without a restriction on your account
    - without changing the due date
    - with a due date picked with the datepicker
  - on-site use with a restriction on your account
    ... see above
  - no on-site use but with a specified due date
  - no on-site use, not specifying a due date
- Turn off SpecifyDueDate
  - on-site use with and without restriction should
    set the due date automatically to the end of the date
    now, altering the due date should not be possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:19:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:19:18 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-A3nerAJi9q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35848|0                           |1
        is obsolete|                            |
  Attachment #35849|0                           |1
        is obsolete|                            |
  Attachment #35850|0                           |1
        is obsolete|                            |
  Attachment #35851|0                           |1
        is obsolete|                            |
  Attachment #35964|0                           |1
        is obsolete|                            |

--- Comment #31 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36690
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36690&action=edit
[SIGNED-OFF] Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:19:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:19:31 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-CMZHjtjJWl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Needs Signoff

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
oops, bad reflex :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:27:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:27:31 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-66zEsgkm8S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:27:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:27:35 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-xzIAZdDSeS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36689|0                           |1
        is obsolete|                            |

--- Comment #9 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36691
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36691&action=edit
Bug 13647: On-site checkouts - Allow library to specify due date

This will remove the restriction that forces the due date for
an on-site checkout to the end of the current day.

It will still suggest the end of the day, but you will be able
to change the date to whatever you want using the datepicker
widget.

To test:

Before applying the patch:
- Turn on OnSiteCheckouts and OnSiteCheckoutsForce
  system preferences
- Check the on-site use checkbox and try to set due date
  manually, it should not be possible
- Check out the item and check the due date is set to the
  end of today
- Put a restriction on your patron account and repeat steps,
  the item checked out should again have a due date at the
  end of the day
> There should be no way to be able to check out an item
  with a 'custom' due date

Apply the patch:
- Repeat steps from above, check out
  - on-site use without a restriction on your account
    - without changing the due date
    - with a due date picked with the datepicker
  - on-site use with a restriction on your account
    ... see above
  - no on-site use but with a specified due date
  - no on-site use, not specifying a due date
- Turn off SpecifyDueDate
  - on-site use with and without restriction should
    set the due date automatically to the end of the date
    now, altering the due date should not be possible.

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:35:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:35:22 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-aB4pAdmSpZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

delaye <stephane.delaye at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stephane.delaye at biblibre.co
                   |                            |m

--- Comment #79 from delaye <stephane.delaye at biblibre.com> ---
after apply the patch i can't see the items in the account borrower ; i have
the message "loading..." so i can't apply the test plan...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:38:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:38:04 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-DvHpvpK7eD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36690|0                           |1
        is obsolete|                            |

--- Comment #32 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36692
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36692&action=edit
[SIGNED-OFF] Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:38:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:38:16 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-TMzB9nGgXj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36684|0                           |1
        is obsolete|                            |

--- Comment #33 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36693
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36693&action=edit
[SIGNED-OFF] Bug 12598 - Tidy import_borrowers.pl

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:38:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:38:24 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-OmsXytD1Oo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36685|0                           |1
        is obsolete|                            |

--- Comment #34 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36694
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36694&action=edit
[SIGNED-OFF] Bug 12598 - Move importing code to a subroutine

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:38:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:38:35 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-Q7Y0IWl9dK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36687|0                           |1
        is obsolete|                            |

--- Comment #35 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36695
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36695&action=edit
[SIGNED-OFF] Bug 12598 - Update command line script to use patron import
subroutine

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:38:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:38:55 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-gYjdETuu9R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36688|0                           |1
        is obsolete|                            |

--- Comment #36 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 36696
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36696&action=edit
[SIGNED-OFF] Bug 12598 - Move Koha::Patrons::Import to Koha::Borrower::Import

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:41:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:41:40 +0000
Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32
In-Reply-To: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13586-70-JUKec2rT1I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:41:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:41:44 +0000
Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32
In-Reply-To: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13586-70-ef60quPLRW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586

Larry Baerveldt <larry at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35318|0                           |1
        is obsolete|                            |
  Attachment #35947|0                           |1
        is obsolete|                            |
  Attachment #35948|0                           |1
        is obsolete|                            |

--- Comment #5 from Larry Baerveldt <larry at bywatersolutions.com> ---
Created attachment 36697
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36697&action=edit
[SIGNED OFF] Bug 13586: Makefile.PL mentions win32

Edited Makefile.PL to remove mentions of win32
To test: Run Makefile.PL

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:42:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:42:23 +0000
Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32
In-Reply-To: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13586-70-awIbu60bz1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586

--- Comment #6 from Larry Baerveldt <larry at bywatersolutions.com> ---
Created attachment 36698
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36698&action=edit
[SIGNED OFF] Bug 13586: Remove the entire block

Previous patch remove the condition but not the block tested.
The entire block should be removed.

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:42:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:42:27 +0000
Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32
In-Reply-To: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13586-70-BsBv4r8MhN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586

--- Comment #7 from Larry Baerveldt <larry at bywatersolutions.com> ---
Created attachment 36699
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36699&action=edit
[SIGNED OFF] Bug 13586: Remove some other occurrences

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:43:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:43:03 +0000
Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line
	tool
In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12598-70-3uSs0n26Ik@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #37 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Sorry for the initial screw-up on the order of sign-offs. This is absolutely a
valuable addition for automated setups!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 12:50:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 11:50:52 +0000
Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold
In-Reply-To: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13592-70-s4GFHteUjn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

--- Comment #1 from David Roberts <david.roberts at ptfs-europe.com> ---
There are circumstances where the fee is applied - if the item is already on
loan (or otherwise unavailable) a hold fee will be applied immediately. If the
item is available, no fee is applied, even at checkout. 

It might make more sense if a fee was applied immediately for items that are
available, and only applied at checkout for any items that were unavailable
when the hold was placed. 

This is true for 3.18.03.000, behaviour may differ at other versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:10:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 12:10:36 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-fliDwbUaZV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36700
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36700&action=edit
Bug 13799: REST API proof of concept with Mojolicious/Swagger2

1/ Install Mojolicious Perl module
2/ Launch server with:
     $ morbo ./rest

Actual routes are:
  /borrowers
    Return a list of all borrowers in Koha

  /borrowers/{borrowernumber}
    Return the borrower identified by {borrowernumber}
    (eg. /borrowers/1)

There is a test file you can run with:
  $ prove t/db_dependent/rest/borrowers.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:41:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 12:41:41 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-gfyRm6nwlH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:43:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 12:43:57 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-QSNz3z46fd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:45:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 12:45:21 +0000
Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then
 searching for label items.
In-Reply-To: <bug-11880-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11880-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11880-70-MOXyuryAQm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:45:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 12:45:26 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-R3AEPdY339@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |olli-antti.kivilahti at jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:46:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 12:46:02 +0000
Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services
In-Reply-To: <bug-13737-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13737-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13737-70-inU1aDqeR3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737

claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire.hernandez at biblibre.c
                   |                            |om

--- Comment #1 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> ---
Links related to this topic: 

http://koha.1045719.n5.nabble.com/Koha-devel-f3063671.html

-- Mail from Julian Maurice wich summarize

Hi all,

During the hackfest in Marseille, we talked a lot about the new RESTful
API and how to integrate it into Koha.

Discussions have been summarized in the wiki page [1], in particular in
sections "Suggested way forward" and "API Protocol Specification".

A proof-of-concept patch was made and is attached to Bug 13799 [2].
It uses Mojolicious and its Swagger2 plugin (more details on the wiki page).
This will be used as a base for building the API. So, please have a look
at it and report any problem you can think of.


[1] http://wiki.koha-community.org/wiki/New_REST_API_RFC
[2] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 13:47:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 12:47:43 +0000
Subject: [Koha-bugs] [Bug 12008] hold notice can be deleted
In-Reply-To: <bug-12008-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12008-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12008-70-vlEmy0gOlM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12008

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:00:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:00:30 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9223-70-gBqmykqJJw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #37 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
AFAIK:
The suggestions.itemtype-column is not used anywhere other than displayed as-is
in the suggestions.pl-view.
I tried setting the itemtype-column to "ITYPE - CCODE - LOCATION" and it seems
to work quite well.
I don't know why anybody would want to expose their patrons to
ILS-configuration technical parameters like that, but using this simple trick
it should be possible to collect and store all three values.

On a followup those three parameters can be separated to their distinctive
columns.

Also using only one ITEMTYPE or COLLECTIONCODE should be more than enough for a
borrower to categorize his suggestion.
I think the suggestions-mechanism is meant for ordinary library users and if
further "resource" description accurancy is needed, then an acquisitions
integration would be more suitable for the task using EDI or similar.


I feel sadness when a new system preference is added. In this case
"SupportsAuthorizedValues"||"SuggestionsUseValues".
A better solution would be to use the first value in "AdvancedSearchTypes", eg
"ccode|itemtypes|loc" would translate to using "ccode" as the selection
displayed for the user, or simply displaying all those options and
concatenating them to the suggestions.itemtype-column.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:03:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:03:40 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9223-70-S5nRW3GHsA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

--- Comment #38 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Other than that, this feature seems to work well enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:06:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:06:38 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-CIcIGqV57f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:06:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:06:41 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-miJW2BuRjF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36691|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36701
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36701&action=edit
Bug 13647: On-site checkouts - Allow library to specify due date

This will remove the restriction that forces the due date for
an on-site checkout to the end of the current day.

It will still suggest the end of the day, but you will be able
to change the date to whatever you want using the datepicker
widget.

To test:

Before applying the patch:
- Turn on OnSiteCheckouts and OnSiteCheckoutsForce
  system preferences
- Check the on-site use checkbox and try to set due date
  manually, it should not be possible
- Check out the item and check the due date is set to the
  end of today
- Put a restriction on your patron account and repeat steps,
  the item checked out should again have a due date at the
  end of the day
> There should be no way to be able to check out an item
  with a 'custom' due date

Apply the patch:
- Repeat steps from above, check out
  - on-site use without a restriction on your account
    - without changing the due date
    - with a due date picked with the datepicker
  - on-site use with a restriction on your account
    ... see above
  - no on-site use but with a specified due date
  - no on-site use, not specifying a due date
- Turn off SpecifyDueDate
  - on-site use with and without restriction should
    set the due date automatically to the end of the date
    now, altering the due date should not be possible.

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:19:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:19:52 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9223-70-CXR6HwfpO0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35492|0                           |1
        is obsolete|                            |

--- Comment #39 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36702
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36702&action=edit
Bug 9223: Multiple values of AdvancedSearchTypes in suggestions

Suggestion form uses C4::Koha::GetSupportList to get a list of supports that
can come from itemtypes or authoritized values LOC or CCODE.
C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one
value. But this syspref can contain several values separated by a pipe.

This patch introduces a new syspref SupportsAuthorizedValues to select wich
authorized values category that represents the physical support (itemtypes by
default, loc or ccode). These authorized values will be used in suggestion
management, known as 'document type'.
(Note that database field is still 'itemtype').

Test plan :
-----------
- Set SupportsAuthorizedValues with itemtypes or loc or ccode
- Get to suggestion form (OPAC or intranet)
- Look at "Document type" combobox, it must contains descriptions of selected
authorized values
- Save the suggestion
- Get to intranet suggestions management
- Organize suggestions by document type
=> your suggestion must appear in a tab with its document type description

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:20:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:20:32 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9223-70-Ij4Ve3Ug3f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36178|0                           |1
        is obsolete|                            |

--- Comment #40 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36703
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36703&action=edit
Bug 9223: Add SupportsAuthorizedValues syspref (followup 1)

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:23:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:23:49 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9223-70-mvGTiJJfSr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36179|0                           |1
        is obsolete|                            |

--- Comment #41 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36704
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36704&action=edit
Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions

This follow-up implements some things I think will improve on the
previous patches:

- Change the system preference name to "SuggestionsUseValues"
- Change the description of the preference to "Suggestions can be
  submitted using the following authorized values:"
- Move the new preference to the OPAC tab so that it is grouped with
  other suggestions-related preferences.
- Add the option offer no itemtype/collection code chooser on the
  submission form.
- Display the correct label on the submission form depending on the
  value of the SuggestionsUseValues preference.

To test, apply this patch on top of the previous ones. Test submission
of purchase suggestions through the OPAC and staff client with the
SuggestionsUseValues preference set to all the various choices: item
type, collection code, shelving location, and 'none.' The suggestion
forms should look correct and work correctly.

HOWEVER, neither the previous patches nor mine address the problem of
the suggestions management page's "organize by" option, which is
hard-coded to work with item types. Whether or not my patch is
acceptable this issue will need to be addressed.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

  Tested the TEST PLAN. With ccode, itype, none, loc.
  On both OPAC and SC.
  Making a code review, but it is hard during the hackfest.
  Morbid lack of any kind of unit test!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:24:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:24:59 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9223-70-8ohaTJ6uv7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #42 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Failed QA because no unit tests of any kind.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:33:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:33:57 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-hkUgrgpTgv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36700|0                           |1
        is obsolete|                            |

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36705
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36705&action=edit
Bug 13799: REST API proof of concept with Mojolicious/Swagger2

Fixed patch with added dependency on Swagger2 module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:42:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:42:37 +0000
Subject: [Koha-bugs] [Bug 13805] New: Installer does not work under Plack
Message-ID: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

            Bug ID: 13805
           Summary: Installer does not work under Plack
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

When going to the installer (without the DB structure), you have to log twice
before starting the installation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:42:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:42:57 +0000
Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13791-70-k94B9PbEW0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Plack out of the box        |Plack - Out of the box
                   |                            |support on packages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:43:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:43:09 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-ww6hMk4leQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
This patch is actually testable on sandbox 16 where I installed the required
dependencies. There is no special configuration, so it will run in CGI mode.

Base URL: http://pro.test16.biblibre.com/cgi-bin/koha/rest

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:43:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:43:46 +0000
Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13791-70-5Q6RGa5thM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13793, 13805
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
             Blocks|13793                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:43:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:43:46 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-kBKFSdB1Y5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13791
         Depends on|13791                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:43:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:43:46 +0000
Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack
In-Reply-To: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13805-70-L0ZAu4l1Yg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13791

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:46:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:46:47 +0000
Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack
In-Reply-To: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13805-70-AowS3HRhFp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:46:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:46:50 +0000
Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack
In-Reply-To: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13805-70-ITReWhG3LU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36706
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36706&action=edit
Bug 13805: Disable syspref cache - Plack

When going to the installer (without the DB structure), you have to log
twice before starting the installation.

Test plan:
0/ Create a new database and fill the database entry in the koha conf
with its name
1/ Go on the mainpage, you should be redirected to the installer
2/ Try to log in
Without this patch, you will get the login form again.
With this patch, you can start the installation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:51:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:51:48 +0000
Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack
In-Reply-To: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13805-70-kVTLfxlTy3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11998

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:51:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:51:48 +0000
Subject: [Koha-bugs] [Bug 11998] Syspref caching issues
In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11998-70-7fPbHNeJ5m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13805

--- Comment #94 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Could be "solved" by bug 13805.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:52:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:52:37 +0000
Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack
In-Reply-To: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13805-70-XUgy4clNOA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Actually the Dobrica's solution (on the wiki page) could be better:

    enable sub {
        my ( $app, $env ) = @_;
        return sub {
            my $env = shift;
            C4::Context->clear_syspref_cache();
            $app->( $env );
        }
    };

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:56:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:56:38 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-2Q8YulIuCk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #80 from Paul Poulain <paul.poulain at biblibre.com> ---
Katrin, Tomas, Jonathan, Brendan and I had a discussion about this patch during
the 2015 hackfest in Marseille.

We think Marcel proposal does too much things, and add some complexity where
initial my patch just fixed the main problem : applying patches on sandboxes
fails.

After a discussion, I'm about to resurrect my initial patches, keep the
cleaning atomicupdate one, as they're interesting, and we will go forward.
(I'll take care of Marcel comment 12 #1 into accout)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:56:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:56:55 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-9ub3nsHsFz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35000|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:57:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:57:06 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-mt3eHMq1t4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35001|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:57:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:57:12 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-hAQlm6LbiO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35368|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:57:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:57:21 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-9MKsjgmEUn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35370|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:58:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:58:19 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-n85fMXeht1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32173|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:58:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:58:24 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-eMaI6mls7F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32174|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:58:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:58:29 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-hGb81LYmH1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32175|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:58:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:58:34 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-KTRwC5Twcu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32185|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 14:58:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 13:58:40 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-WQnrmsdwmP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32841|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:00:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:00:47 +0000
Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number --
 Indexing & Matching
In-Reply-To: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6499-70-bamSWiox4G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not able to spot the problem in the filess, but it doesn't work for me.
I have:
- copied all the index related files to my koha-dev folder
- restarted zebra
- done a full reindex

I am puzzled. I am going to fail this for now, but would be happy if someone
else tested if it works for them.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:03:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:03:47 +0000
Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch
 from institution_id field AO
In-Reply-To: <bug-13666-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13666-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13666-70-wct5TFz9Yu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666

--- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Thanks for the input Benjamin!

Shouldn't this patch be extended to set the AO-field for all SIP2 transactions
where it is used?
Then propagate the value to the transaction handlers?

Now this special case is dealed with only for checkouts, which is not logical.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:07:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:07:35 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-iOZPJmF7Ko@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
  Attachment #36361|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:07:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:07:39 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-Ar9vwQbd0s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36456|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:07:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:07:45 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-D3e2Jde6kX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36503|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:07:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:07:59 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-HelL1fEZsQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36305|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:08:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:08:04 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-LKvG9pkGDR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36320|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:11:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:11:32 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-olzMSnmjAt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

--- Comment #16 from simith.doliveira at inlibro.com ---
Created attachment 36707
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36707&action=edit
QA fix

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:12:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:12:11 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-mCLBahbUEO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:16:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:16:12 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-jkCGw4ooQV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:16:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:16:17 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-z7MDJTIXAp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36551|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:16:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:16:15 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-46WgdOnzbm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36320|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:16:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:16:20 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-dtdfL3lkJE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36456|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:16:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:16:23 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-VpbULsgkYY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36361|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:16:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:16:26 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-lCu0YpjVYk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36305|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:16:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:16:29 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-tIsCEez3vB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36503|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:17:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:17:24 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-MLnQXlKCVg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36708
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36708&action=edit
[PASSED QA] BUG 13771: Update Tools Help Files for 3.18

This patch creates a helpf ile for the batch record delete tool
and updates the help files for notices and marc export.

To test:

* Visit tools > batch record deletion
* confirm help is right
* Visit tools > Notices & Slips
* confirm help is right
* Visit tools > export marc
* cofirm the help is right

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:17:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:17:28 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-G9MEVizRRs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36709
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36709&action=edit
[PASSED QA] Bug 13771: Main Page Help fro 3.18

This updates the main page help file for 3.18.

To test:
* Log in to staff cleint
* Click help on the mian page
* Review help file

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:17:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:17:32 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-T6eIBUQJnN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36710
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36710&action=edit
[PASSED QA] Bug 13771: Update Circ Help File

This updates the main circulation help file with new features in 3.18.

To test:

* visit circulation page
* click help
* review text

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:17:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:17:36 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-KFJKFhsbTF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36711
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36711&action=edit
[PASSED QA] Bug 13771: Add admin help files for 3.18

This patch adds a new help file for column settings and updates the
files for budgets, funds, libraries, patron categories, and circ rules.

To test:

* Visit the above listed admin pages
* Review help files

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:17:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:17:40 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-GrzAxKazgh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36712
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36712&action=edit
[PASSED QA] Bug 13771: Add missing item search help file

This patch adds a help file for the staff item search.

To test:

* Click search
* click item search
* click help
* review the help file

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:17:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:17:44 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-zxV1VJ6nvh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36713
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36713&action=edit
[PASSED QA] Bug 13771: Update manage staged marc help for 3.18

This updates the manage staged marc files help.

To test:

* Visit Tools > Staged MARC record management
* Click help
* Confirm it's there and correct

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:49:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:49:07 +0000
Subject: [Koha-bugs] [Bug 13802] Renewals ignore hard due dates
In-Reply-To: <bug-13802-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13802-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13802-70-xuG3Seh9GT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13802

Helen Linda <helen.linda at goddard.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |helen.linda at goddard.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:56:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:56:26 +0000
Subject: [Koha-bugs] [Bug 13806] New: No input sanitization where creating
 Reports subgroup
Message-ID: <bug-13806-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806

            Bug ID: 13806
           Summary: No input sanitization where creating Reports subgroup
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Since Bug 7993 there is a way to put Reports on subgroups. Koha let you create
a new subgroup just typing a "code" (authorised_value), but without "name" (lib
field on authorised_values table). That makes an empty entry on select
drop-down that should be deleted (if there is no reports in it) from
authorised_values table.
Both code and name should be mandatory fields while creating report subgroups.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 15:56:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 14:56:48 +0000
Subject: [Koha-bugs] [Bug 13769] Barcode showing blank in catalog/null in
	database
In-Reply-To: <bug-13769-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13769-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13769-70-obOaMpt9pe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13769

Johnathan Cintron <jcintron at hccc.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #1 from Johnathan Cintron <jcintron at hccc.edu> ---
Was user error.

Fixed now. Working as intended.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:21:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:21:07 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-wQEhEmHbOL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #55 from Marc V?ron <veron at veron.ch> ---
Created attachment 36714
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36714&action=edit
[Signed-off] Bug 13642 [ENH] Adding new features for Dublin Core metadata

When Koha export a bibliographic record to DC, makes it in XML format. This XML
not follows the DC-XML recommendations as should be: elements in uppercase eg.
dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property
names for the 15 DC elements should be all lower-case." eg. dc:date,
dc:creator" and section "4.3 Example - a simple DC record",
xsi:schemaLocation="http://example.org/myapp/
http://example.org/myapp/schema.xsd" schema does not exist.
The recommendation can be consulted at
<http://dublincore.org/documents/dc-xml-guidelines/>.
This new feature, adds an ability to export Dublin Core metadata to XML and RDF
(including rdfxml, rdfjson, ntriples, turtle, etc.)

Test plan
---------------
1) Download Dublin Core file. Open up the file, and make sure that the document
not follows the DC-XML recommendations as should be.
2) Apply patches.
3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core.
A modal will display, prove all options.
4) Change the system preference 'Opac ExportOptions' by enabling and disabling
Dublin Core and try to download a record in the OPAC.
5) Try several bibliographic records in any format (book, magazine, DVD, etc.)
to confirm that properly exported.
6) RDF/XML can be validated per RDF Validator W3C.
7) DC-XML cannot valid if not exist a valid XSD schema.
8) OAI-DC can be validated using
<http://www.freeformatter.com/xml-validator-xsd.html> and the proper schema
<http://www.openarchives.org/OAI/2.0/oai_dc.xsd> typed in text field for URL.

Installed libhtml-entities-numbered-perl and followed test plan. Works as
expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:22:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:22:03 +0000
Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13642-70-86N4wCaQi3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:29:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:29:27 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-bB32BnzwIH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #93 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Workflow question: After the patron has printed a discharge notice from the
OPAC he can go to the library and check out books again, so the discharge would
then be invalid. How can we deal with that?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:31:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:31:57 +0000
Subject: [Koha-bugs] [Bug 13807] New: SIPServer Input loop not checking for
 closed connections reliably
Message-ID: <bug-13807-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

            Bug ID: 13807
           Summary: SIPServer Input loop not checking for closed
                    connections reliably
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Debugging some sip connections found that a server could get stuck with a
partially unread buffer when the remote closed the connection. This could mean
it was also not responding to signals to shut down. Reworked the main loop to
be a bit more careful about checking the connection status. Moved it from the
Sip.pm module into the server where it seemed to belong more logically.

Have been running this with some other modifications in production sites for
some time and appears to have enhanced reliability and ability to control the
server.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:36:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:36:10 +0000
Subject: [Koha-bugs] [Bug 13807] SIPServer Input loop not checking for
 closed connections reliably
In-Reply-To: <bug-13807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13807-70-0nGKMYHl4X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
                   |ity.org                     |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 36715
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36715&action=edit
Proposed Patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:40:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:40:11 +0000
Subject: [Koha-bugs] [Bug 5176] SIPServer Incorrectly Requires Login over
	Socket
In-Reply-To: <bug-5176-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5176-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5176-70-TCglZabvQd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5176

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #2 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
As its not causing anyone major problems and everyone seems happy with things
the way they are lets consider this resolved

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:43:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:43:04 +0000
Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode,
 categorytype from table overduerules_transport_types
In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13624-70-FjGWrksuCV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Medium patch
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:43:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:43:40 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-l1IqsHrT3i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|alex.sassmannshausen at ptfs-e |julian.maurice at biblibre.com
                   |urope.com                   |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:44:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:44:26 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-NQ3PCzYWpU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #94 from Marc V?ron <veron at veron.ch> ---
(In reply to Katrin Fischer from comment #93)
> Workflow question: After the patron has printed a discharge notice from the
> OPAC he can go to the library and check out books again, so the discharge
> would then be invalid. How can we deal with that?

I would expect a restriction "Discharged" (similar to manual restricitions).

It would display a message like:
Restricted: Patron's account is restricted with the explanation:
Discharched

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:45:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:45:09 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-5Tv949hBWk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:45:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:45:27 +0000
Subject: [Koha-bugs] [Bug 13808] New: sample_notices are inconsistent
Message-ID: <bug-13808-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13808

            Bug ID: 13808
           Summary: sample_notices are inconsistent
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mtompset at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

There are sample notices in some languages lacking in others. This bug makes
sure all the sample notices are consistent between all languages.

This was noticed as a result of a QA comment on bug 1985 (comment 36).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:46:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:46:28 +0000
Subject: [Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron
 changes to a category with enrolment fee
In-Reply-To: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13697-70-xeV3qosLVR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |christophe.croullebois at bibl
                   |ity.org                     |ibre.com
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:47:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:47:29 +0000
Subject: [Koha-bugs] [Bug 13808] sample_notices are inconsistent
In-Reply-To: <bug-13808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13808-70-Nl6Cl6onuJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13808

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:48:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:48:25 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-oSXU1GyHys@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13808

--- Comment #37 from M. Tompsett <mtompset at hotmail.com> ---
ARG! Kyle, did you have to make me notice another bug? :P I'm cleaning it up
(bug 13808). In the mean time, I'll just add this notice into every language as
a separate patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:48:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:48:25 +0000
Subject: [Koha-bugs] [Bug 13808] sample_notices are inconsistent
In-Reply-To: <bug-13808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13808-70-78yV1CVMnR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13808

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=1985

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:49:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:49:08 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-PUT7t1nbEu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|olli-antti.kivilahti at jns.fi |mtompset at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:51:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:51:50 +0000
Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging
	in Koha
In-Reply-To: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13413-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13413-70-s8tFg4H8Om@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 16:52:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 15:52:53 +0000
Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements
In-Reply-To: <bug-11405-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11405-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11405-70-xaIWN6ia1q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

Koha Team AMU <koha.aixmarseille at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha.aixmarseille at gmail.com

--- Comment #22 from Koha Team AMU <koha.aixmarseille at gmail.com> ---
I'm trying this patch.
Ok for [1] (mervelous!!)
For [2], I will try again because message "No data available in table" (and
normally it's all right).
Ok for [3].

I just have to try csv file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:03:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:03:33 +0000
Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently
 treated as single-value or multi-value
In-Reply-To: <bug-11733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11733-70-YoAgbBynnn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |MOVED

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Will be taken care of with the tax rewrite.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:12:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:12:51 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-fkTuxc8rZR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32173|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:12:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:12:56 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-zJKtJO0Tkr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32174|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:13:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:13:01 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-J7NBZNV8eU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32175|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:13:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:13:06 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-rtjZhlRloj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32185|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:13:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:13:16 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-xsq2F4LPmB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32841|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:26:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:26:58 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-PBdlXtVAGX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #81 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 36716
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36716&action=edit
updatedatabase improvement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:27:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:27:29 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-9fQTZyxSls@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #82 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 36717
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36717&action=edit
bz 13068 atomicupdate directory cleaning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:28:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:28:08 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-Y1H3Gvr4mD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #83 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 36718
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36718&action=edit
bz 13068 follow-up : using slurp & removing oai-sets.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:28:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:28:29 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-LEM43tsD5Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #84 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 36719
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36719&action=edit
SAMPLE sql file, not for pushing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:44:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:44:10 +0000
Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts
In-Reply-To: <bug-13691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13691-70-8gjR6DqeoC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Check out the Perl Cucumber integration to use as a wrapper for feature
documentation and acceptance/integration testing framework.
It looks very promising and could be a good candidate as a mandatory testing
framework for the new REST-API.

https://metacpan.org/pod/Test::BDD::Cucumber::Manual::Integration
https://metacpan.org/pod/App::pherkin

Oslo is using Ruby, but we could try how the Perl implementation works.

However we should consider some test driven mechanism as a mandatory part of
getting REST API patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:58:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:58:05 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-oUxHFkWFiy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 17:58:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 16:58:08 +0000
Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments
In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1985-70-ltwQbxN9DK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #38 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36720
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36720&action=edit
Bug 1985 - Follow up: Add sample letter to other languages

As per comment #36, the letter COMMENT_CREATED has been added
to the other languages.

TEST PLAN
---------
0) Back up your letters table
1) In your mysql client after selected your Koha database,
   Run this:

SET foreign_key_checks = 0;
truncate letter;
source installer/data/mysql/de-DE/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/es-ES/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/it-IT/necessari/notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/pl-PL/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/ru-RU/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/uk-UA/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/en/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';

   -- there should be 9 counts of 1.
2) Restore your letters table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:00:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 17:00:13 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-CjuIZlkIbI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 36721
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36721&action=edit
[Signed-off] Bug 13804 - Returns via the checkouts tables uses the phrase
"Returned" rather than "Checked in"

Test plan:
1) Apply this patch
2) Return an item via the checkouts table
3) Note the left most column now reads "Checked in" rather than "Returned"

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:00:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 17:00:50 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-imRkD4dWJs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:01:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 17:01:03 +0000
Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number --
 Indexing & Matching
In-Reply-To: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6499-70-4ST10aqPMg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

--- Comment #13 from Barton Chittenden <barton at bywatersolutions.com> ---
Katrin,

about.pl on the koha installation that I was using lists

Zebra version:    Zebra 2.0.55 (C) 1994-2013, Index Data ApS Zebra is free
software, covered by the GNU General Public License, and you are welcome to
change it and/or distribute copies of it under certain conditions. SHA1 ID:
bd2bc9360225e695bbaba2c2d1cd6925c4eb23a5 Using ICU

Could this be an issue of zebra version?

Nick,

Could you check Main->About on your test machine, and report the zebra version
that worked for you?

[Zebra version is the last item on the 'about' page]

Thanks,

--Barton

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:14:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 17:14:14 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-S0HcQOos13@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:25:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 17:25:19 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-m1WADx5BD5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 36722
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36722&action=edit
[Follow-up] Bug 11364 - Label layout types and text justification types are not
translatable

Removed obsolete code from from C4/Creators/Lib.pm  around line 129.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 18:43:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 17:43:05 +0000
Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number --
 Indexing & Matching
In-Reply-To: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6499-70-eurpTv4jRG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

--- Comment #14 from Barton Chittenden <barton at bywatersolutions.com> ---
Katrin,

I ran the following in yaz-client:

yaz-client -c etc/zebradb/ccl.properties
unix:/home/barton/koha-dev/var/run/zebradb/bibliosocket
Connecting...OK.
Sent initrequest.
Connection accepted by v3 target.
ID     : 81
Name   : Zebra Information Server/GFS/YAZ
Version: 2.0.55/4.2.69 026ad3d737be4cbba4e98c6b6dc753f8029e3655
Options: search present delSet triggerResourceCtrl scan sort extendedServices
namedResultSets
Elapsed: 0.002972
Z> base biblios                                                                 
Z> scan @attr 1=1211 ocm03545607
query: @attr 1=1211 ocm03545607
Received ScanResponse
5 entries, position=1
Scan returned code 5
* ocm03545607 (1)
  ocm05041760 (1)
  ocm06098807 (1)
  OCoLC (4)
  VOY12798 (1)
Elapsed: 0.071230
Z> 

---

Do you get errors when you run the following commands in yaz-client?

base biblios                                                                    
scan @attr 1=1211 <your value in 035$a>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:04:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 19:04:47 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-j3vv1rArlL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi Maxime

Is the patch ready to sign?

I tried it anyway, I found no difference on translation files
with the patch, have you an example of same untranslated text?

Regards, Bernardo

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:11:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 19:11:24 +0000
Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number --
 Indexing & Matching
In-Reply-To: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6499-70-mlSGskiO73@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org

--- Comment #15 from Nick Clemens <nick at quecheelibrary.org> ---
I tested successfully on a clean branch again today using kohadevbox, zebra
version:
Zebra 2.0.60 (C) 1994-2015, Index Data Zebra is free software, covered by the
GNU General Public License, and you are welcome to change it and/or distribute
copies of it under certain conditions. SHA1 ID:
b51184e7cf9eabd2c609f50f721d6568351fbc33 Using ICU

Just to note, the js is missing closing ");" and should be

$(document).ready(function(){
    // Add Other Control Number to advanced search
    if (window.location.href.indexOf("catalogue/search.pl") > -1) {
        $(".advsearch").append('<option value="Other-control-number">Other
Control Number</option>');
    }
});

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:23:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 19:23:47 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-3G3szd295Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #43 from simith.doliveira at inlibro.com ---
Created attachment 36723
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36723&action=edit
Bug 13364 - Add a call number browser in item edition page - QA fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:32:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 19:32:31 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-sXfvKJZx8t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #44 from simith.doliveira at inlibro.com ---
Concerning #42 :

Is there a good reason to have the template file in the tools directory,
instead of cataloguing/value_builder?

- No, Moved.

The green line is always at the top of the table. If I am remember correctly,
in the previous version it was inserted correctly.

- Bug fixed


::: cataloguing/value_builder/cn_browser.pl
@@ +1,4 @@
> +#!/usr/bin/perl
> +
> +use strict;
> +use warnings;

Prefer use Modern::Perl;

- Fixed

@@ +9,5 @@
> +use C4::Output;
> +use POSIX;
> +use C4::ClassSource;
> +use URI::Escape;
> +use Data::Dumper;

No needed.

- Fixed. use C4::ClassSource needed

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/cn_browser.tt
@@ +12,5 @@
> +<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/jquery.dataTables.min.js"></script>
> +<script language="JavaScript">
> +$(document).ready(function()
> +{
> +    $("#course_reserves").DataTable({"paging":   false, "bFilter": false, "info":     false});

Hum? Why did you choose this id?

- In intranet-tmpl/prog/en/css/staff-global.css 
  there is "div#course_reserves_wrapper > table#course_reserves" needed to the
table. So I just use it (do not change staff-global.css file).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:47:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 19:47:55 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9223-70-kjVZBqHOqx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Joseph DeVore <joe_devore at mailhaven.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|joe_devore at mailhaven.com    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:47:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 19:47:58 +0000
Subject: [Koha-bugs] [Bug 13800] Diacritics not mapped
In-Reply-To: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13800-70-J6BTzIWJQM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13800

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:48:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 19:48:00 +0000
Subject: [Koha-bugs] [Bug 13800] Diacritics not mapped
In-Reply-To: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13800-70-SmsorPXfwI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13800

--- Comment #2 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 36724
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36724&action=edit
Bug 13800 - Diacritics not mapped

This patch adds a mapping for the lower case ? character to word-phrase-utf.chr
( ? was already mapped to d)

To test:
1. Add a record with the  ? character (Arnaldur Indri?ason is an example
author)
2. Rebuild zebra
3. Search for your record using d instead of ? and verify it is not found
4. Apply patch and copy word-phrase-utf.chr to the appropriate folder
5. Restart and rebuild zebra
6. Search for your record using d instead of ? and verify it is found

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 20:48:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 19:48:30 +0000
Subject: [Koha-bugs] [Bug 13800] Diacritics not mapped
In-Reply-To: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13800-70-0lNP0LSi0y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13800

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master
           Assignee|gmcharlt at gmail.com          |nick at quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 21:01:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 20:01:53 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-vd7f5OUv4M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|m.de.rooy at rijksmuseum.nl    |paul.poulain at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar  6 21:03:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 06 Mar 2015 20:03:56 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-uhNXPocf17@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

--- Comment #5 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Changes will only appear if the template you are generating contains:

<input type="text" name="translate" value="I wish to translate this">

And in the .po file:

#. INPUT type=text name=translate
#: pathToTemplate:lineNumber
msgid "I wish to translate this"
msgstr "Translated!"

Without the patch tmpl_process3 will skip translation the value of the text
input.
With the patch the value is translated.

In my case, the untranslated text appeared in a customized template.
I figured I would put a word out on the possible issue just in case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 02:03:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 01:03:24 +0000
Subject: [Koha-bugs] [Bug 13808] sample_notices are inconsistent
In-Reply-To: <bug-13808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13808-70-ob0CwjKe9F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13808

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 36725
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36725&action=edit
Bug 13808 - Clean up of sample notices

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 02:03:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 01:03:21 +0000
Subject: [Koha-bugs] [Bug 13808] sample_notices are inconsistent
In-Reply-To: <bug-13808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13808-70-EMfNrlkhxX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13808

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 06:14:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 05:14:57 +0000
Subject: [Koha-bugs] [Bug 13808] sample_notices are inconsistent
In-Reply-To: <bug-13808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13808-70-DAnYe2Sy0h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13808

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
biblio.title vs. aqorders.title (es-ES vs en, ACQCLAIM)
not to mention the titles for RENEWAL.
*sigh* I initially thought there were missing notices. It's uglier.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 08:35:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 07:35:59 +0000
Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
In-Reply-To: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12072-70-6b3qBQa0Ot@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

--- Comment #26 from Marc V?ron <veron at veron.ch> ---
I will try to move this forward by splitting it up to several steps / patches
based on paxed's work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 08:46:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 07:46:18 +0000
Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
In-Reply-To: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12072-70-sslecrmZVc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

--- Comment #27 from Marc V?ron <veron at veron.ch> ---
Created attachment 36726
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36726&action=edit
Bug 12072 - Step 1: Add system preference for New dateformat dd.mm.yyyy

As a first step, this patch adds a new system preference for the dateformat
dd.mm.yyy
No other changes are made.

To test:
1. apply the patch
2. run updatedatabase.pl
3. go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save
4. verify that the value was saved

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 16:49:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 15:49:20 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-WambgbvuqZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
There are conflicts in:
- t/DateUtils.t
- Koha/DateUtils.pm
- and something sha1 blob fatal in basket.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 17:13:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 16:13:14 +0000
Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC
In-Reply-To: <bug-11847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11847-70-aM1pKJmBVV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |mtompset at hotmail.com

--- Comment #18 from M. Tompsett <mtompset at hotmail.com> ---
There's a merge conflict with item-status.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 17:34:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 16:34:25 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-6uIx3iyLNV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

--- Comment #2 from Rizwan <rizwan.ahmed at 1campusconsulting.com> ---
What is the fix ? Can you please attach the solution ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 18:32:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 17:32:55 +0000
Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt
 and serials-recieve.tt
In-Reply-To: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13423-70-gTuneHULBP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36727
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36727&action=edit
Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt

Thid patch rewrites strings to make them translatable

To test:
1) Apply the patch
2) Update translation for your language of choice
3) Check new strings on staff PO file
+msgid "A barcode was not entered."
+msgid "Do you want to put in a barcode"
+msgid "Leave barcode blank?"
+msgid "Note: unable to change this later"
+msgid "or do you want to use a system generated barcode?"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 18:33:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 17:33:43 +0000
Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt
 and serials-recieve.tt
In-Reply-To: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13423-70-i3jsiAqfd7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 20:02:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 19:02:20 +0000
Subject: [Koha-bugs] [Bug 13656] "Change" button for linking a member to an
 organisation not translatable
In-Reply-To: <bug-13656-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13656-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13656-70-n9JslXcDdA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Sorry but... how you do this
> - create a member of organisation type patron
> - link second patron to your created organisation patron

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 21:00:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 20:00:09 +0000
Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export
In-Reply-To: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13695-70-rOtuarIxYo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #11)
> Tomas, I would like to get your opinion on this.
> Shouldn't we create a new pref for the ISBD export or remove the html tags?

As the patch author I might not be the best to say. I always expect the ISBD
(In reply to Jonathan Druart from comment #11)
> Tomas, I would like to get your opinion on this.
> Shouldn't we create a new pref for the ISBD export or remove the html tags?

I don't think we should tweak the generated ISBD. If such was the case, then we
 might have a bug on the ISBD generating code, that makes people use HTML code
to trick the browser, instead of showing the ISBD card as-is.

I don't favour adding new sysprefs for this kind of thing. At least no at a
first sight of the problem. I'll try to read a bit more about the ISBD code to
figure what is the expected behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 21:25:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 20:25:59 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-eGiUmDVz3k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
  Attachment #36508|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 21:40:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 20:40:04 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-AW6MDdBzMM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36520|0                           |1
        is obsolete|                            |

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36728
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36728&action=edit
Bug 13784: koha-stop-zebra should also work for disabled instances

Currently koha-stop-zebra will not stop zebra for disabled instances. It should
work more like koha-stop-sip, which does work for disabled instances. Also,
koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly
should also apply to disabled instances.

To Test:
1) Disable a koha instance.
2) Run koha-stop-zebra INSTANCE. You should get message
   "Instance INSTANCE disabled. No action taken."
3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra
   to package site over /usr/sbin/koha-stop-zebra.
4) Disable koha instance.
5) Run koha-stop-zebra INSTANCE. It should now stop zebra.

http://bugs.koha-community.org/show_bug.cgi?id=13784
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 21:40:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 20:40:11 +0000
Subject: [Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for
	disabled instances
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-2X48hbcPfs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36729
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36729&action=edit
Bug 13784: (QA followup) allow running Zebra for disabled instances on packages

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 21:41:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 20:41:00 +0000
Subject: [Koha-bugs] [Bug 13784] Allow running Zebra daemon for disabled
 instances in packages
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-M32iy9aW7E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Koha-stop-zebra should also |Allow running Zebra daemon
                   |work for disabled instances |for disabled instances in
                   |                            |packages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 21:43:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 20:43:52 +0000
Subject: [Koha-bugs] [Bug 13784] Allow running Zebra daemon for disabled
 instances in packages
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-Y5AcqRHnLS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
It is not clear to me that we should control disabled instances with
/etc/init.d/koha-common as it is a special situation in which you want to run
the zebra daemon on a disabled instance. Most people disable an instance and
expect is to be off.

I agree with adding some flexibility to the koha-{start|stop|restart}-zebra
scripts, but I'm not sure we should change the current behaviour for the init
script (i.e. removing --enabled).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 21:48:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 20:48:57 +0000
Subject: [Koha-bugs] [Bug 13784] Allow running Zebra daemon for disabled
 instances in packages
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-HnuTKbdgjb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36729|0                           |1
        is obsolete|                            |

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36730
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36730&action=edit
Bug 13784: (QA followup) allow running Zebra for disabled instances on packages

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:11:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:11:02 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-guxEVAAskN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Dobrica!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:11:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:11:32 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-uhluwd77Jo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #35 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Nice job Nicole!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:12:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:12:06 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-My61yWwpBC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:12:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:12:36 +0000
Subject: [Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
In-Reply-To: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13787-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13787-70-ulngLnTrvG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:13:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:13:10 +0000
Subject: [Koha-bugs] [Bug 13784] Allow running Zebra daemon for disabled
 instances in packages
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-CIvxl3Dw4S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Larry!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:13:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:13:45 +0000
Subject: [Koha-bugs] [Bug 13750] Holds queue: Always show branch name,
	not branch code
In-Reply-To: <bug-13750-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13750-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13750-70-jHEwFkLXct@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13750

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:14:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:14:53 +0000
Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not
 scanned" statuses
In-Reply-To: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12631-70-SUBtlUtvBq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks for the pastis Matthias!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:15:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:15:40 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-4SjCWKjqGC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #239 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Fixes pushed to master.

Thanks Nicole and Jonathan!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:15:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:15:47 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-W0J7uDTtHU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36661|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:15:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:15:54 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-NY4oGoxqTt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36662|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:16:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:16:57 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-ie0vef7cwc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:17:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:17:25 +0000
Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of
 "Logout" if not enough premissions
In-Reply-To: <bug-11400-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11400-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11400-70-kxGxygksQX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:27:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:27:55 +0000
Subject: [Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra
	for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-2PbFhuDYoX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36519|0                           |1
        is obsolete|                            |

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36731
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36731&action=edit
Bug 13785: koha-disable should also stop SIP and zebra for instance

Currently koha-disable ONLY disables the instance in the apache conf
file. Presumably if you want to disable the instance, you also want
its processes to stop, so this patch will stop zebra, if running,
and SIP, if enabled.

Depends on Bug 13784.

To Test:
1) Have an enabled instance, with zebra and SIP running.
2) Run koha-disable INST. Note that after, both zebra and SIP
   will still be running.
3) Re-enable INST.
4) Apply patch, and then copy debian/scripts/koha-disable to
   package site, over /usr/sbin/koha-disable.
5) Run koha-disable INST. You should now see that both zebra
   and SIP have been stopped.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:28:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:28:03 +0000
Subject: [Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra
	for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-WkNDq3nYX7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36732
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36732&action=edit
Bug 13785: (QA followup) koha-disable should stop the indexer daemon

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar  7 22:29:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 21:29:36 +0000
Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in
 Koha::Schema::Result::Biblio
In-Reply-To: <bug-13713-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13713-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13713-70-IxnjREewrf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Please rebase this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 00:16:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 07 Mar 2015 23:16:38 +0000
Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13791-70-bo7Aj5QBEa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 03:08:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2015 02:08:07 +0000
Subject: [Koha-bugs] [Bug 13809] New: The Notices tab on staff client
	disappeared
Message-ID: <bug-13809-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13809

            Bug ID: 13809
           Summary: The Notices tab on staff client disappeared
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jurgens.b at xtra.co.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Hi,

I updated to Koha 18.04, with no problems. Used it for a few days and suddenly
the sent notices tab on the staff client has disappeared. I can still access
the notices tab, by typing in the notice.pl script in browser address bar and
everything on it still functions normally. 

On any of the staff client pages for the patron (check out, details etc.) the
notice tap on the left hand side has disappeared.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 03:08:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2015 02:08:38 +0000
Subject: [Koha-bugs] [Bug 13809] The Notices tab on staff client disappeared
In-Reply-To: <bug-13809-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13809-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13809-70-PN7jDr02mW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13809

Jurgens Breytenbach <jurgens.b at xtra.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 07:12:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2015 06:12:01 +0000
Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt
 and serials-recieve.tt
In-Reply-To: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13423-70-9jYgX3HVPj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 10:44:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2015 09:44:43 +0000
Subject: [Koha-bugs] [Bug 13809] The Notices tab on staff client disappeared
In-Reply-To: <bug-13809-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13809-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13809-70-gevf4AGCUp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13809

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Do you have the system preference EnhancedMessagingPreferences allowed?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 10:53:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2015 09:53:50 +0000
Subject: [Koha-bugs] [Bug 13656] "Change" button for linking a member to an
 organisation not translatable
In-Reply-To: <bug-13656-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13656-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13656-70-8Hl1jBIkKz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 11:27:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2015 10:27:48 +0000
Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold
In-Reply-To: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13592-70-LsQR5mMK77@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 17:43:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2015 16:43:35 +0000
Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
In-Reply-To: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12532-70-sIPkRCUNJN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 21:05:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2015 20:05:20 +0000
Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13791-70-00YJNMPHWe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 21:13:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2015 20:13:04 +0000
Subject: [Koha-bugs] [Bug 7710] multiple holds per title
In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7710-70-16I4fMnyw7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar  8 21:14:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 08 Mar 2015 20:14:17 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-F9jNXnkvC3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 02:17:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 01:17:48 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-usOjj8KgLy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #46 from Robin Sheat <robin at catalyst.net.nz> ---
It might be useful to ensure that they indexed right, you can do this:

curl -XGET 'http://localhost:9200/koha_biblios/_search?pretty=1' 

where 'koha_biblios' is whatever your index is called. This'll give you a dump
of everything in the index.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 03:17:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 02:17:22 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-Ad0fLpBn9q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

Rizwan <rizwan.ahmed at 1campusconsulting.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 03:18:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 02:18:10 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-xj7DDH7qW8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

Rizwan <rizwan.ahmed at 1campusconsulting.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 07:05:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 06:05:30 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-2iIfFscbmK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #47 from Peter Zhao <peterzhaonj at 163.com> ---
(In reply to Robin Sheat from comment #46)
> It might be useful to ensure that they indexed right, you can do this:
> 
> curl -XGET 'http://localhost:9200/koha_biblios/_search?pretty=1' 
> 
> where 'koha_biblios' is whatever your index is called. This'll give you a
> dump of everything in the index.


-----------
$ curl -XGET 'http://localhost:9200/koha_biblios/_search?pretty=1' {
  "error" : "IndexMissingException[[koha_biblios] missing]",
  "status" : 404
}
----------
$ /home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl -v -d
Indexing biblios
1
-----------------
I just catalogued one record to try. But it always stay there.
I think it cannot finish to build the index. How to handle this problem?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 07:08:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 06:08:25 +0000
Subject: [Koha-bugs] [Bug 13351] Untranslatable javascript in members.tt
In-Reply-To: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13351-70-ED8zdL6Mk8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351

--- Comment #7 from paxed <pasi.kallinen at pttk.fi> ---
Pity the patch doesn't use the javascript .format() function, but just
concatenates strings together. Bad sentence structures it makes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 09:39:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 08:39:59 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-jlxsLNoV9H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35405|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36733
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36733&action=edit
Bug 13601: Add tests to highlight the problems with DateTime::Format::DateParse

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 09:40:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 08:40:02 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-UnxIcW77c5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35406|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36734
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36734&action=edit
Bug 13601: Make dt_from_string not using DateTime::Format::DateParse

For a couple of reasons, dt_from_string should not use
DateTime::Format::DateParse:
1/ It does not manage date < 1900, certainly caused by l.47 of this
module:
 $p{ year }      = $year ? $year + 1900 : DateTime->now->year;

2/ It considers 31/01/2015 as a valid us date, which is not.

Test plan:
1/ Verify that
  prove t/DateUtils.t
returns green
2/ Play with dates in Koha (yes I know, it's vague...)
3/ Try to find a regression with dates
4/ Create a date with year <= 1900 and confirm it works

QA comment:
Why the sql format switch was:
-                $date_string =~
-s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/;

>From where a date like "yyyymmdd hhmmss" can come?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 09:40:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 08:40:06 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-Gi9M41zKp8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35407|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36735
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36735&action=edit
Bug 13601: get rid of DateTime::Format::DateParse

This module is used in C4::Members::GetPendingIssues too, but we can use
dt_from_string.

Test plan:
1/ Verify that
    prove t/db_dependent/Members/GetPendingIssues.t
returns green
2/ On the patron pending issue list, verify that the issue and the due
dates are correctly displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 09:40:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 08:40:09 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-QDe9OlJWSJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35408|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36736
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36736&action=edit
Bug 13601: Add a fallback check for compability with existing code

There are a lot of places where the date comes from the DB but the
dateformat parameter is not set to 'sql'.
dt_from_string needs to fallback with this format if the pref format
does not match.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 09:40:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 08:40:13 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-jd3cGQUegU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35433|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36737
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36737&action=edit
Bug 13601: Fix special case in basket.pl

There is a badly managed date in acqui/basket.pl:
if the date is 15/01/2015 (metric format), it will become
2015-1-15 after the following line:
  $estimateddeliverydate = "$year-$month-$day";
Add_Delta_Days is used at several place, and the ouput is forced to
display date on 4 digits and month/day on 2 digits.
This patch does the same thing for $estimateddeliverydate.

Note that I previously developed a patch to take this format into account (with
missing 0)
in Koha::DateUtils::dt_from_string, but I don't think it's a good idea
to manage bad formated dates.
We will certainly find some issues after previous patches, but it will permit
to catch
them!
IMO it's preferable than to keep them hidden.

The patch was:

diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm
index 5fe2653..4434a67 100644
--- a/Koha/DateUtils.pm
+++ b/Koha/DateUtils.pm
@@ -72,17 +72,17 @@ sub dt_from_string {
         my $fallback_re = qr|
             (?<year>\d{4})
             -
-            (?<month>\d{2})
+            (?<month>\d{1,2})
             -
-            (?<day>\d{2})
+            (?<day>\d{1,2})
         |xms;

         if ( $date_format eq 'metric' ) {
             # metric format is "dd/mm/yyyy[ hh:mm:ss]"
             $regex = qr|
-                (?<day>\d{2})
+                (?<day>\d{1,2})
                 /
-                (?<month>\d{2})
+                (?<month>\d{1,2})
                 /
                 (?<year>\d{4})
             |xms;
@@ -90,9 +90,9 @@ sub dt_from_string {
         elsif ( $date_format eq 'us' ) {
             # us format is "mm/dd/yyyy[ hh:mm:ss]"
             $regex = qr|
-                (?<month>\d{2})
+                (?<month>\d{1,2})
                 /
-                (?<day>\d{2})
+                (?<day>\d{1,2})
                 /
                 (?<year>\d{4})
             |xms;
diff --git a/t/DateUtils.t b/t/DateUtils.t
index 886e1d6..0877240 100755
--- a/t/DateUtils.t
+++ b/t/DateUtils.t
@@ -189,3 +189,8 @@ is( output_pref( { dt => $dt } ), '31/01/2015 12:34',
'dt_from_string should mat
 # date before 1900
 $dt = dt_from_string('01/01/1900');
 is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/1900', 'dt_from_string
should manage date < 1900' );
+
+# missing 0
+$dt = dt_from_string('1/1/2015');
+is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/2015', 'dt_from_string
should generate a DT object even if 0 are missing' );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 09:41:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 08:41:09 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-cAOGjhBFp1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 09:42:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 08:42:11 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-r0tiK3NcBC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Rebase not trivial, please check there is no regression with bug 12669.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 09:45:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 08:45:17 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-MMhTnwWNes@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Which version do you use?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 09:59:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 08:59:29 +0000
Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch
 from institution_id field AO
In-Reply-To: <bug-13666-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13666-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13666-70-J2gC9bNDay@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666

--- Comment #5 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Actually, AO is respected in checkins already, as AddReturn takes $branch as
param, whereas AddIssue does not.

I suppose the only reason AO was not respected in checkout initially was due to
the fact that AddIssue doesn't take $branch as param, and this probably was
left to be solved in AddIssue at a later stage. The web interface requires user
to specify branch before checkout, so C4::Context->userenv->{'branch'} is set
which is the same as this patch does.

For Renew, location has no effect, and hold takes its own param,
pickup_location (BR), so that's the reason only checkout is handled in this
patch, which, in my opinion, should have been handled by AO in the first place,
as SIP is a transport protocol and should not have other dependencies than
authentication.

Also, the protocol specifies that AO is a required field in all transactions
and maps to the library?s institution ID, so SIP clients should adher to this.

Anyway, if AO is left empty, the transaction will fallback to user context, so
the patch will not cause anyone trouble

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:27:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 09:27:55 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-O1qMS4OR8I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35106|0                           |1
        is obsolete|                            |
  Attachment #35718|0                           |1
        is obsolete|                            |

--- Comment #114 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 36738
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36738&action=edit
Revised Patch

Revised patch addesses qa issues and incorporates some upstrwam changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:49:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 09:49:20 +0000
Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261
In-Reply-To: <bug-13532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13532-70-yVs0yKgiOX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #5 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
patch doesn't apply, probably due to bug 7904:

https://github.com/Koha-Community/Koha/commit/e5b834a1c474f761c9f9c8c01dd6abeb99ee5eac#diff-4a1e76b1dab1bba0924ef5abb699ccfa

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:49:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 09:49:40 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-V7L9ydX9w8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12072
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:49:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 09:49:40 +0000
Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
In-Reply-To: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12072-70-9lqBfpRBvn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13601

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:51:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 09:51:35 +0000
Subject: [Koha-bugs] [Bug 7899] Remove C4::Dates from C4::Circulation
In-Reply-To: <bug-7899-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7899-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7899-70-CdUSCuPWoL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7899

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12072
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 10:51:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 09:51:35 +0000
Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
In-Reply-To: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12072-70-UKADd3lUmw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=7899

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:58:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 10:58:22 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-IyJNHpSsdU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

koha at akafred.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |koha at akafred.com

--- Comment #36 from koha at akafred.com ---
Patch failed at 0001 Bug 8000 - Override emails of every message sent from Koha

Details:

$ git show-ref -s HEAD
66c9e7a183e8e56c29b34e57d6c3c0b3cee09699

$ git bz apply 11140
No patches on bug 11140

$ git bz apply 8000

Bug 8000 - Test mode for notices

25924 - Bug 8000 - Override emails of every message sent from Koha
25925 - Bug 8000 - Missing test to trigger code change
25926 - Bug 8000 - Add a sentto_address column to message_queue
25928 - Bug 8000 - Correct inability to know where message was sent
25939 - Bug 8000 [QA Followup] - Change mis-used qw to q
25951 - Bug 8000 - Validate allEmailsTo email address before using it
26446 - Bug 8000: Replace Data::Validate::Email with Email::Valid

Applying: Bug 8000 - Override emails of every message sent from Koha
Auto-merging virtualshelves/sendshelf.pl
Auto-merging opac/opac-sendshelf.pl
Auto-merging opac/opac-sendbasket.pl
Auto-merging misc/cronjobs/runreport.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging basket/sendbasket.pl
Auto-merging C4/Letters.pm
CONFLICT (content): Merge conflict in C4/Letters.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 8000 - Override emails of every message sent from Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 11:59:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 10:59:37 +0000
Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
In-Reply-To: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12072-70-q3vkW8SNlt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

--- Comment #28 from Marc V?ron <veron at veron.ch> ---
For the next steps we have the following problem:

- It is not allowed to touch C4::Dates (deprecated module, Comment #25)
- A new date format leads to error messages for example with C4::Dates->new(),
which is used by about 50 files *).
- Koha::DateUtils is a temporary module for wrappers to hide the complexity of
switch to DateTime. It contains some functions, but it is not really a
replacement for the C4::Dates object.
- Replacing C4::Dates affects a lot of files and needs a lot of testing (side
effects)

Plumbing 50+ files is far outside the scope of this bug. It is an architecural
task. We should move the replacement of C4::Dates to a separate architectural /
plumbing bug (that blocks this one and others as well).


----

*) Files using C4::Dates->new()
C4/Acquisition.pm
C4/Barcodes/annual.pm
C4/Barcodes/hbyymmincr.pm
C4/Calendar.pm
C4/Circulation.pm
C4/Items.pm
C4/Log.pm
C4/Members.pm
C4/Reserves.pm
C4/Utils/DataTables.pm
acqui/histsearch.pl
acqui/invoice.p
acqui/invoices.pl
acqui/orderreceive.pl
acqui/parcel.pl
acqui/parcels.pl
labels/label-item-search.pl
members/memberentry.pl
members/moremember.pl
members/readingrec.pl
misc/cronjobs/gather_print_notices.pl
misc/cronjobs/overdue_notices.pl
misc/cronjobs/serialsUpdate.pl
misc/cronjobs/staticfines.pl
misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
misc/maintenance/fix_accountlines_date.pl
opac/opac-memberentry.pl
opac/opac-showreviews.pl
opac/opac-user.pl
patroncards/members-search.pl
reports/dictionary.pl
reports/guided_reports.pl
serials/member-search.pl
serials/serials-edit.pl
serials/showpredictionpattern.pl
serials/subscription-renew.pl
t/Dates.t
t/Dates.t
t/db_dependent/Holds.t
t/db_dependent/Koha_template_plugin_KohaDates.t
t/db_dependent/Log.t
tools/exceptionHolidays.pl
tools/export.pl
tools/holidays.pl
tools/import_borrowers.pl
tools/newHolidays.pl
tools/scheduler.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:28:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 11:28:16 +0000
Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in
 Koha::Schema::Result::Biblio
In-Reply-To: <bug-13713-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13713-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13713-70-QhSIDtOBrM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35949|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 12:29:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 11:29:22 +0000
Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in
 Koha::Schema::Result::Biblio
In-Reply-To: <bug-13713-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13713-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13713-70-NSS4mnr8yo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
First patch was missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:22:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 13:22:45 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-bWTxRvCbCT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The plan was to have this in the maintenance releases (see comment #9) - Tomas,
could you please push soon? Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:23:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 13:23:47 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-nVenWXHb7O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

--- Comment #4 from Rizwan <rizwan.ahmed at 1campusconsulting.com> ---
Koha Version: 3.14.04.000
OS Version: Linux

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:39:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 13:39:03 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-AqPgjSdj1K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

Rafal Kopaczka <rkopaczka at afm.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:39:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 13:39:06 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-suKiyaRgiJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

Rafal Kopaczka <rkopaczka at afm.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26457|0                           |1
        is obsolete|                            |
  Attachment #26684|0                           |1
        is obsolete|                            |
  Attachment #26685|0                           |1
        is obsolete|                            |

--- Comment #18 from Rafal Kopaczka <rkopaczka at afm.edu.pl> ---
Created attachment 36739
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36739&action=edit
[PATCH] Bug 9481 - charge not showing fines On 'Check out' and 'Details'. When
looking at the patron record or the checkout screen the checkout summary is now
showing 0 for all the Charges even if the item was overdue and has accrued
fines.

To test:
1/ Check out items with past due date
2/ Run fines.pl script (ensure finesMode is set to Calculate and Charge)
3/ Verify on Fines->Pay Fines screen that fines where calculated
correct.
4/ Go to Patron record, charge column on Details and Check out
screen
should be 0 or rental charge amount only. But total amount row
display right
number, same as in pay fines screen.
4/ Apply patch.
5/ Now charges on display and check out screen shows all outstanding
fees for each item.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:39:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 13:39:59 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-0GzXdew3vU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

Rafal Kopaczka <rkopaczka at afm.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36739|0                           |1
        is obsolete|                            |

--- Comment #19 from Rafal Kopaczka <rkopaczka at afm.edu.pl> ---
Created attachment 36740
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36740&action=edit
[PATCH] Bug 9481 - charge not showing fines On 'Check out' and 'Details'.

When looking at the patron record or the checkout screen the checkout
summary is now showing 0 for all the Charges even if the item was
overdue and has accrued fines.

To test:
1/ Check out items with past due date
2/ Run fines.pl script (ensure finesMode is set to Calculate and Charge)
3/ Verify on Fines->Pay Fines screen that fines where calculated
correct.
4/ Go to Patron record, charge column on Details and Check out
screen
should be 0 or rental charge amount only. But total amount row
display right
number, same as in pay fines screen.
4/ Apply patch.
5/ Now charges on display and check out screen shows all outstanding
fees for each item.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:41:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 13:41:24 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-ScBASBhhhg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

--- Comment #20 from Rafal Kopaczka <rkopaczka at afm.edu.pl> ---
This patch, turns out is trivial after datatables patch has been pushed. But
now I'm wondering if showing fines in charges column is correct behaviour?
Maybe there should be some syspref for showing fines/charges or separate column
in table?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 14:45:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 13:45:03 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-CAnrap0bYn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

--- Comment #21 from David Roberts <david.roberts at ptfs-europe.com> ---
Showing fines in the charges column is definitely not correct (see my bug 13732
which was marked as a duplicate of this one). Charges refer to e.g. rental fees
which are different to fines. It would be better perhaps if there was a
separate column for fines. If more screen real-estate is needed, some of the
columns that display on this screen are probably not that useful (replacement
price, for example) so could be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:03:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 14:03:53 +0000
Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record
	details page.
In-Reply-To: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8688-70-UKUw5BsmqF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17740|0                           |1
        is obsolete|                            |

--- Comment #13 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 36741
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36741&action=edit
Bug 8688 - Add a Recall button to the biblio record details page.

This patch is a fusion of all previous patches for this feature, in
addition to a system preference to control the appearance of the
"Recall" button.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:06:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 14:06:29 +0000
Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record
	details page.
In-Reply-To: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8688-70-1GghsmHT3f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #14 from Charles Farmer <charles.farmer at inlibro.com> ---
I needed this patch for something else. Decided to update it to current master
(DBRev 3.19.00.012)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:25:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 14:25:53 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-JASUQ6c3IS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

Rafal Kopaczka <rkopaczka at afm.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36740|0                           |1
        is obsolete|                            |

--- Comment #22 from Rafal Kopaczka <rkopaczka at afm.edu.pl> ---
Created attachment 36742
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36742&action=edit
[PATCH] Bug 9481 - charge not showing fines On 'Check out' and 'Details'.

When looking at the patron record or the checkout screen the checkout
summary is now showing 0 for all the Charges even if the item was
overdue and has accrued fines.
Removed unused(?) footer values in checkouts-table-footer.inc

To test:
1/ Check out items with past due date
2/ Run fines.pl script (ensure finesMode is set to Calculate and Charge)
3/ Verify on Fines->Pay Fines screen that fines where calculated
correct.
4/ Go to Patron record, charge column on Details and Check out
screen
should be 0 or rental charge amount only. But total amount row
display right
number, same as in pay fines screen.
4/ Apply patch.
5/ Now charges on display and check out screen shows all outstanding
fees for each item.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:30:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 14:30:12 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-f3MVMPtE4d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

--- Comment #23 from Rafal Kopaczka <rkopaczka at afm.edu.pl> ---
(In reply to David Roberts from comment #21)
> Showing fines in the charges column is definitely not correct (see my bug
> 13732 which was marked as a duplicate of this one). Charges refer to e.g.
> rental fees which are different to fines. It would be better perhaps if
> there was a separate column for fines. If more screen real-estate is needed,
> some of the columns that display on this screen are probably not that useful
> (replacement price, for example) so could be removed.

That's what I've think. New patch with new column for fines. As for removing
columns, there is some feature for defining visibility of column. Maybe that
could be used to hide columns? But it's another bug I think.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 15:59:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 14:59:13 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-3eINI3eFZO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at biblibre.co |koha-bugs at lists.koha-commun
                   |m                           |ity.org
             Status|REOPENED                    |NEW
            Version|unspecified                 |3.14

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:01:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 15:01:24 +0000
Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then
 searching for label items.
In-Reply-To: <bug-11880-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11880-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11880-70-tlJML5DMXG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |charles.farmer at inlibro.com

--- Comment #6 from Charles Farmer <charles.farmer at inlibro.com> ---
Despite the ugliness of the template in its present form, the patch works and
is a development needed by our client.

This patch should be accepted as is. Fixing the template is considerably out of
the scope of this development.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:22:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 15:22:19 +0000
Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
In-Reply-To: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13381-70-iQ7jfoWcDZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

--- Comment #21 from Winona Salesky <wsalesky at gmail.com> ---
Hi All, 
I am finishing up on this bug. It seems to me that there is agreement on the
statement of responsibility being included within a <span>. However, my
understanding is that issue with subfield h is more complicated and should be
moved to a a new bug, in which case, for this bug, I will simply add a span so
it can be suppressed and the more complex logic can be worked out in a future
bug. 

Hope that works for everyone.
-Winona

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:30:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 15:30:22 +0000
Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving
In-Reply-To: <bug-13323-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13323-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13323-70-dtjiuofP4m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:30:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 15:30:31 +0000
Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed
In-Reply-To: <bug-13321-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-hn6LEHtHUe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:30:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 15:30:56 +0000
Subject: [Koha-bugs] [Bug 13324] The fund values must be based on tax
	included values
In-Reply-To: <bug-13324-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13324-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13324-70-zHSMJqfIY7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:32:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 15:32:40 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-w41fPr25Xs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 16:58:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 15:58:22 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-AaLzfJbRYN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36674|0                           |1
        is obsolete|                            |

--- Comment #80 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 36743
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36743&action=edit
Bug 8236 Renewing policy in overdue or restriction case

grrrmmffff...  silly error on calling HasOverdues function. patch redone

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:06:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 16:06:28 +0000
Subject: [Koha-bugs] [Bug 13810] New: Prevent updatedatabase.pl from
 breaking because of case insensitive utf8 collation
Message-ID: <bug-13810-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810

            Bug ID: 13810
           Summary: Prevent updatedatabase.pl from breaking because of
                    case insensitive utf8 collation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: nicolas.legrand at bulac.fr
        QA Contact: testopia at bugs.koha-community.org

When upgrading database from 3.18 to master upgrade Upgrade to 3.19.00.006 (Bug
11944 - Convert DB tables to utf8_unicode_ci) may fail like this:

DBD::mysql::db do failed: Duplicate entry 'ACQ-995-a' for key 'PRIMARY' at
./installer/data/mysql/updatedatabase.pl line 9671.

This is from table marc_subfield_structure where the keys are made of framework
(ACQ), tagfield (995) and tagsubfield (a). If we have a key ACQ-995-A it thinks
the entries are duplicates, because the collation is case insensitive. It's
rather annoying, since it's legit in mark to have a subfield 'a' different from
subfield 'A' inside the same subfield.

I propose to default collation on one which is not case insensitive, like
utf8_bin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:17:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 16:17:35 +0000
Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking
 because of case insensitive utf8 collation
In-Reply-To: <bug-13810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13810-70-9jlFt8MvHX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810

--- Comment #1 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 36744
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36744&action=edit
Change default collation to utf8_bin

When upgrading database from 3.18 to master upgrade Upgrade to
3.19.00.006 (Bug 11944 - Convert DB tables to utf8_unicode_ci) may
fail like this:

DBD::mysql::db do failed: Duplicate entry 'ACQ-995-a' for key 'PRIMARY' at
./installer/data/mysql/updatedatabase.pl line 9671.

This is from table marc_subfield_structure where the keys are made of
framework (ACQ), tagfield (995) and tagsubfield (a). If we have a key
ACQ-995-A it thinks the entries are duplicates, because the collation
is case insensitive. It's rather annoying, since it's legit in mark to
have a subfield 'a' different from subfield 'A' inside the same
subfield.

utf8_bin prevent updatedatabase.pl from breaking.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 17:18:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 16:18:16 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-iYaC5d2p6J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #45 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to simith.doliveira from comment #44)
> > +    $("#course_reserves").DataTable({"paging":   false, "bFilter": false, "info":     false});
> 
> Hum? Why did you choose this id?
> 
> - In intranet-tmpl/prog/en/css/staff-global.css 
>   there is "div#course_reserves_wrapper > table#course_reserves" needed to
> the table. So I just use it (do not change staff-global.css file).

Your last patch adds it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:12:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 17:12:43 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-NTpMVpy0on@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #17 from Marc V?ron <veron at veron.ch> ---
Patch did not apply:

Applying: Bug 13601: Add tests to highlight the problems with
DateTime::Format::DateParse
Applying: Bug 13601: Make dt_from_string not using DateTime::Format::DateParse
Applying: Bug 13601: get rid of DateTime::Format::DateParse
Applying: Bug 13601: Add a fallback check for compability with existing code
Applying: Bug 13601: Fix special case in basket.pl
fatal: corrupt patch at line 55
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 13601: Fix special case in basket.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:35:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 17:35:48 +0000
Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts
In-Reply-To: <bug-13691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13691-70-3ZPsJN7KX6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691

koha at akafred.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at akafred.com

--- Comment #7 from koha at akafred.com ---

I have a feeling that Koha could benefit from having a few tests that exercise
the most critical functionality from a user perspective, both as tools to
measure performance changes and to automate test of critical user scenarios.

These tests should optimally be in the same repo and be versioned along with
the Koha code. That way developers could get rapid feedback on the changes they
make, and also we would require the tests to pass along with production code
changes. 

However, if this turns out to be to much work for the individual developer,
these tests can be in a separate repo and perhaps be maintained by a separate
team ? as they in theory not break unless we are changing existing user
functionality. In reality, however, they will from time to time break from
changes the users cannot see, and they will have a certain cost to maintain. 

They will also need installations of Koha running the versions to test against.
My feeling is that one could spend a little effort setting up an infrastructure
for this and do some experiments on how this works, with a small number of
scenarios. 

(Oslo Public Library has some experience in using automated browser based
testing on Koha, using Cucumber and step definitions in Ruby.)

A couple of comments:

*** Browser-based testing ***

This is about testing a running web application:

Examples of tools: 

* Mechanize: (which already is used a little)
- simple 
- only parses html (it has no understanding of JavaScript, which Koha uses more
and more)

* Webdriver (in Selenium 2): (which is what Jonathan has created a patch for)
- drives actual browsers with JavaScript and all (can be "headless" browser)
- you can programatically interact with visible elements like a user
- there is currently no *direct* binding in perl, you have to run "selenium
server" (which needs java) which in turn drives the browsers (in ruby you do
not need this intermediary server) 
https://github.com/gempesaw/Selenium-Remote-Driver/issues/189

*** Feature based testing / behaviour driven testing / example driven testing
***

This is about how your test looks, and in addition to using normal unit test
tools, there are tools like Fit/-nesse and Cucumber that lets you write
automated tests in a way that is easier for users to understand. (Olli-Antti
touched on this.) These tests may or may not be browser-based, but in a
web-based application it is more likely that they do than that they don't. 

*** Acceptance tests ***

These are typically tests for a user story / scenario and confirms that a piece
of functionality is in place and works. They may be expressed in a tool that is
feature-based like the ones mentioned above, and will often drive a browser
interface in a web application like Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:53:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 17:53:28 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-5USDSoY577@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #18 from Marc V?ron <veron at veron.ch> ---
Created attachment 36745
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36745&action=edit
[Signed-off] Bug 13601: Add tests to highlight the problems with
DateTime::Format::DateParse

Test behaves as expected (Fail as expected  with first patch only, OK after 3rd
patch)
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 18:54:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 17:54:10 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-LXpXxeEe6K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36733|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:09:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 18:09:03 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-CNC0HRXdnm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #19 from Marc V?ron <veron at veron.ch> ---
Created attachment 36746
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36746&action=edit
[Signed-off] Bug 13601: Make dt_from_string not using
DateTime::Format::DateParse

For a couple of reasons, dt_from_string should not use
DateTime::Format::DateParse:
1/ It does not manage date < 1900, certainly caused by l.47 of this
module:
 $p{ year }      = $year ? $year + 1900 : DateTime->now->year;

2/ It considers 31/01/2015 as a valid us date, which is not.

Test plan:
1/ Verify that
  prove t/DateUtils.t
returns green
2/ Play with dates in Koha (yes I know, it's vague...)
3/ Try to find a regression with dates
4/ Create a date with year <= 1900 and confirm it works

QA comment:
Why the sql format switch was:
-                $date_string =~
-s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/;

>From where a date like "yyyymmdd hhmmss" can come?

Tested patches 1 - 3 together. Worked as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:09:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 18:09:35 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-lH3l5gWntv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36734|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:13:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 18:13:37 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-J4F3INYVuA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36735|0                           |1
        is obsolete|                            |

--- Comment #20 from Marc V?ron <veron at veron.ch> ---
Created attachment 36747
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36747&action=edit
Bug 13601: get rid of DateTime::Format::DateParse

This module is used in C4::Members::GetPendingIssues too, but we can use
dt_from_string.

Test plan:
1/ Verify that
    prove t/db_dependent/Members/GetPendingIssues.t
returns green
2/ On the patron pending issue list, verify that the issue and the due
dates are correctly displayed.

Tested together with other patches (except "Fix special cases). Worked as
expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:14:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 18:14:48 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-X7pxQDMtS6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36747|Bug 13601: get rid of       |[Signed-off] Bug 13601: get
        description|DateTime::Format::DateParse |rid of
                   |                            |DateTime::Format::DateParse

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:23:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 18:23:27 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-Jux9UPUnLP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #21 from Marc V?ron <veron at veron.ch> ---
Created attachment 36748
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36748&action=edit
[Signed-off] Bug 13601: Add a fallback check for compability with existing code

There are a lot of places where the date comes from the DB but the
dateformat parameter is not set to 'sql'.
dt_from_string needs to fallback with this format if the pref format
does not match.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:23:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 18:23:59 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-OZbNgWBSEg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36736|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:27:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 18:27:40 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-3EBLRqjCX5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #22 from Marc V?ron <veron at veron.ch> ---
After signing off the first 4 patches I tried again with "Fix secial case in
basket.pl", this one still does not apply with:
fatal: corrupt patch at line 55

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:37:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 18:37:29 +0000
Subject: [Koha-bugs] [Bug 11874] Add a "Call number fields" column to the
 Z39.50 search results.
In-Reply-To: <bug-11874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11874-70-NW0XrxLQ3I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11874

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 19:58:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 18:58:15 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-t4MJcqiHTZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #46 from simith.doliveira at inlibro.com ---
(In reply to comment #45)

- Your last patch adds it.

Yep, you are right. I don't remember why I put "course_reserves", maybe I was
working with other bz at the same time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:16:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 19:16:26 +0000
Subject: [Koha-bugs] [Bug 13811] New: Silent Cronjobs
Message-ID: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811

            Bug ID: 13811
           Summary: Silent Cronjobs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: maxime.beaulieu at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:19:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 19:19:19 +0000
Subject: [Koha-bugs] [Bug 13811] Silent Cronjobs
In-Reply-To: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13811-70-h2lk7dER64@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811

--- Comment #1 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Created attachment 36749
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36749&action=edit
Added -s|--silent option to borrowers-force-messaging-defaults

The script will not print to stdout when the flag is activated.

Test:
    Run the script with the flag. All to stdout is eliminated.
    Run the scirpt without the flag. A report is printed to stdout.

sponsored by: CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:20:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 19:20:18 +0000
Subject: [Koha-bugs] [Bug 13811] Silent Cronjobs
In-Reply-To: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13811-70-rb7WcNSFdp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811

--- Comment #2 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Created attachment 36750
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36750&action=edit
check-url's --html option prints directly to a file instead of stdout.

This change makes the option behave more like other cronjob's --html or --csv
options.
It also makes the script silent while printing html, as nothing is printed to
stdout unless the verbose option is passed.

The script's behaviour is not changed when launched without options. (Prints in
stdout)

sponsored by: CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:21:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 19:21:35 +0000
Subject: [Koha-bugs] [Bug 13811] Silent Cronjobs
In-Reply-To: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13811-70-12l2hes9Jg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com,
                   |                            |maxime.beaulieu at inlibro.com
                   |                            |,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:38:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 19:38:46 +0000
Subject: [Koha-bugs] [Bug 11874] Add a "Call number fields" column to the
 Z39.50 search results.
In-Reply-To: <bug-11874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11874-70-ZztaMICB49@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11874

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25736|0                           |1
        is obsolete|                            |

--- Comment #1 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 36751
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36751&action=edit
Add the "Call number fields" column to the Z39.50 search results. (MARC21)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:55:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 19:55:36 +0000
Subject: [Koha-bugs] [Bug 13812] New: Facet links broken when shelf location
 limit is used.
Message-ID: <bug-13812-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812

            Bug ID: 13812
           Summary: Facet links broken when shelf location limit is used.
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

This bug is analogous to Bug 13442, but it affects shelf location rather than
collection code:

Limiting a search by shelf location is broken, because it wraps double-quotes
around the "value" part of the key-value pair in the URL. This breaks the href=
part of the anchor tag.

The anchor tag generated for the shelf location faced is

<a
href="/cgi-bin/koha/opac-search.pl?&limit=mc-loc%3A"100100ADFICCF"&limit=mc-loc%3A"100200ADFIC"&limit=mc-loc%3A"100250ADFICGN"&limit=mc-loc%3A"100300ADFICHF"&limit=yr%2Cst-numeric%3D2014-&amp;sort_by=acqdate_dsc&amp;limit=au:Paetro%2C%20Maxine%2C"
title="Paetro, Maxine,">Paetro, Maxine,</a>

Once again, double-quotes inside the URL are causing a premature close of the
href, which results in a broken link.

I think that we need to take a look for code duplication inside
C4::Search::buildQuery -- if there's more than one section of code where we're
wrapping quotes around the 'value' part of the query, these should be
consolidated -- shouldn't we be using URL encoding for URL reserved characters
anyway?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:56:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 19:56:36 +0000
Subject: [Koha-bugs] [Bug 13812] Facet links broken when shelf location
	limit is used.
In-Reply-To: <bug-13812-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13812-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13812-70-E7NbEoVEnh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13442

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 20:56:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 19:56:36 +0000
Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code
	limit is used
In-Reply-To: <bug-13442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13442-70-pNpcIgll3x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13812

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:00:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 20:00:59 +0000
Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code
	limit is used
In-Reply-To: <bug-13442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13442-70-yPWXgzsn55@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442

--- Comment #5 from Barton Chittenden <barton at bywatersolutions.com> ---
Shelf location facets are breaking in exactly the same way. Does
C4::Search::buildQuery need to be refactored?

Bug 13812 - Facet links broken when shelf location limit is used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:05:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 20:05:18 +0000
Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
In-Reply-To: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12532-70-pNEJfDVj3o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35313|0                           |1
        is obsolete|                            |

--- Comment #8 from simith.doliveira at inlibro.com ---
Created attachment 36752
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36752&action=edit
Bug 12532 - Redirect guarantee email to guarantor

All email message placed in message_queue table will be affected.

Patch updated; system preference EnableRedirectGuaranteeEmail added to enable
this feature.

Testing:

I Apply the patch
II Run updatedatabase.pl

0) Enable EnhancedMessagingPreferences preference;
0) Enable EnableRedirectGuaranteeEmail preference;
1) Select a patron with child;
2) Enable Item checkout -> email in patron messaging preferences;
3) Select the patron's child;
4) Checkout an item;
5) Valide child checkout message in patron's inbox;

sponsored by the ville de victoriaville

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 21:09:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 20:09:03 +0000
Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
In-Reply-To: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12532-70-SfEZy4llxu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #9 from simith.doliveira at inlibro.com ---
conflit fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 22:04:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 21:04:03 +0000
Subject: [Koha-bugs] [Bug 12553] copynumber,
 location not printing correctly on spine labels.
In-Reply-To: <bug-12553-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12553-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12553-70-Idq8E504NL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12553

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3

--- Comment #1 from Barton Chittenden <barton at bywatersolutions.com> ---
I have a second partner who has seen this. Pushing priority.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 22:30:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 21:30:19 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-cGuuiVd9lO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

--- Comment #5 from Rizwan <rizwan.ahmed at 1campusconsulting.com> ---
Created attachment 36753
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36753&action=edit
KOHA - Check Out 2

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 22:30:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 21:30:43 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-W6rh9ac19R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

Rizwan <rizwan.ahmed at 1campusconsulting.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar  9 23:15:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 22:15:54 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-LwoFrKpnUt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #48 from Robin Sheat <robin at catalyst.net.nz> ---
404 means there is no index with that name, you need to verify that the index
name that you're providing is correct. You can do that with:

curl 'koha-es:9200/_cat/indices?v'

It is possible that there's a bug that if there aren't enough records to
commit, nothing happens. I haven't tested that case yet. Try setting the commit
option to the rebuild to '1'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 00:53:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 23:53:52 +0000
Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13791-70-VZU6IEfx6E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 00:56:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Mar 2015 23:56:14 +0000
Subject: [Koha-bugs] [Bug 13724] Not possible to undo a selected facet when
 search started with an authority id search
In-Reply-To: <bug-13724-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13724-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13724-70-vKQfBW64Vd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13724

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 01:48:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 00:48:01 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-TYIWEUk8b0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wsalesky at gmail.com

--- Comment #4 from Winona Salesky <wsalesky at gmail.com> ---
Should there be a separator? Or should each be on their own line? 
-Winona

(In reply to rgravel from comment #3)
> I agree with Katrin about the $4 and $e conflict- always favor the term over
> the code, as that is what patrons will more readily understand. 
> 
> I also still like the vertical bar as a separator for the reasons I
> mentioned in Bug 13382.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 02:23:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 01:23:55 +0000
Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general
	viewing
In-Reply-To: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13109-70-C7xlhbIZTu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #1 from Mason James <mtj at kohaaloha.com> ---
(In reply to Aliza from comment #0)
> For Log Magazine, also still an issue for Sports Business Journal
> 
> Received the following message
> 
> Software error:
> 
> Usage: Date::Calc::Delta_Days(year1, month1, day1, year2, month2, day2) at
> /usr/share/koha/lib/C4/Serials.pm line 2379.
> For help, please send mail to the webmaster (staff at bywatersolutions.com),
> giving this error message and the time and date of the error.


hmm, we just hit this bug on 3.16.7

i'll do a little more digging on this one

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 02:24:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 01:24:58 +0000
Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general
	viewing
In-Reply-To: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13109-70-pgBP2wroQG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
            Version|3.14                        |3.16

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 02:27:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 01:27:36 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-yk4T4PbiSt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

--- Comment #5 from Winona Salesky <wsalesky at gmail.com> ---
Also, while working on this I noticed that the relator code for field 111 is
actually subfield j, should I add that change into this fix as well? This is
not handled by the current version of the stylesheet. 
Thanks, 
-Winona


(In reply to Winona Salesky from comment #4)
> Should there be a separator? Or should each be on their own line? 
> -Winona
> 
> (In reply to rgravel from comment #3)
> > I agree with Katrin about the $4 and $e conflict- always favor the term over
> > the code, as that is what patrons will more readily understand. 
> > 
> > I also still like the vertical bar as a separator for the reasons I
> > mentioned in Bug 13382.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 02:45:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 01:45:48 +0000
Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing
	newlines
In-Reply-To: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11331-70-AMMxOsnww4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com
           Keywords|                            |rel_3_16_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 03:02:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 02:02:54 +0000
Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing
	newlines
In-Reply-To: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11331-70-Ek1mvaqYbd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |In Discussion

--- Comment #14 from Mason James <mtj at kohaaloha.com> ---
> Raises an error with perl <= 5.10
> 
> Type of arg 1 to keys must be hash (not array element) at
> /home/koha/src/tools/viewlog.pl line 214, near "];"


reopening bug to fix this new error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 03:34:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 02:34:03 +0000
Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing
	newlines
In-Reply-To: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11331-70-3mEwdGJjF7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331

--- Comment #15 from Mason James <mtj at kohaaloha.com> ---
(In reply to Mason James from comment #14)
> > Raises an error with perl <= 5.10
> > 
> > Type of arg 1 to keys must be hash (not array element) at
> > /home/koha/src/tools/viewlog.pl line 214, near "];"
> 
> 
> reopening bug to fix this new error


fyi: i think the following mod might fix the above fatal


- my @headings = grep { $_ ne 'action_id' } sort keys $data[0];
+ my @headings = grep { $_ ne 'action_id' } sort keys %{$data[0]};

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 06:14:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 05:14:45 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-a2mORJgzxM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #49 from Robin Sheat <robin at catalyst.net.nz> ---
Yay, the fundamentals of authority searching are now working (biblio count and
paging.) Next up is making sure the various types of searches result in the
right results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 06:21:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 05:21:47 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-sMtkocKVG5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #50 from Peter Zhao <peterzhaonj at 163.com> ---
(In reply to Robin Sheat from comment #48)
> 404 means there is no index with that name, you need to verify that the
> index name that you're providing is correct. You can do that with:
> 
> curl 'koha-es:9200/_cat/indices?v'
> 
> It is possible that there's a bug that if there aren't enough records to
> commit, nothing happens. I haven't tested that case yet. Try setting the
> commit option to the rebuild to '1'

I try to set the commit option to the rebuild to '1'. And then when rebuild the
record, it stays on ? is commiting?.
~$  /home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl -v -d
Indexing biblios
1
Committing...
-----------
~$ curl 'localhost:9200/_cat/indices?v'
health index        pri rep docs.count docs.deleted store.size pri.store.size 
yellow koha_biblios   5   1          0            0       575b           575b

-------------
~$ curl -XGET 'http://localhost:9200/koha_biblios/_search?pretty=1'
{
  "took" : 1,
  "timed_out" : false,
  "_shards" : {
    "total" : 5,
    "successful" : 5,
    "failed" : 0
  },
  "hits" : {
    "total" : 0,
    "max_score" : null,
    "hits" : [ ]
  }
}

-----------
koha-conf.xml
<elasticsearch>
     <server>localhost:9200</server>
     <index_name>koha</index_name>
 </elasticsearch>
----------
elasticsearch.yml
cluster.name: koha
node.name: "koha"
--------------
Should I change more setting information?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 06:38:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 05:38:11 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-VQfxxdKYz9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #51 from Robin Sheat <robin at catalyst.net.nz> ---
How long did you let it sit on 'Committing', the first one can take some time
(in the order of 10 seconds or so perhaps.)

Otherwise, it's hard to see what's going on without real information but it
does look like things aren't indexing well.

In Koha/ElasticSearch/Indexer.pm there are a couple of commented out
'trace_calls' entries. If you make that active, you may get more information
about what's going on.

Otherwise perhaps trace through it using the Perl debugger and see where it
stops.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 07:24:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 06:24:36 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-vyyTYfPfya@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #52 from Peter Zhao <peterzhaonj at 163.com> ---
(In reply to Robin Sheat from comment #51)
> How long did you let it sit on 'Committing', the first one can take some
> time (in the order of 10 seconds or so perhaps.)
> 
> Otherwise, it's hard to see what's going on without real information but it
> does look like things aren't indexing well.
> 
> In Koha/ElasticSearch/Indexer.pm there are a couple of commented out
> 'trace_calls' entries. If you make that active, you may get more information
> about what's going on.
> 
> Otherwise perhaps trace through it using the Perl debugger and see where it
> stops.

~$ perl -d /home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl

Loading DB routines from perl5db.pl version 1.33
Editor support available.

Enter h or `h h' for help, or `man perldebug' for more help.

main::(/home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl:92):
92:    my $verbose = 0;
  DB<1>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 08:37:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 07:37:48 +0000
Subject: [Koha-bugs] [Bug 13813] New: Remove deprecated module C4::Dates
	from system
Message-ID: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

            Bug ID: 13813
           Summary: Remove deprecated module C4::Dates from system
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org

The use of C4::Dates module is deprecated since June 2014. It has been
superseded by Koha::DateUtils. 
See: http://wiki.koha-community.org/wiki/Coding_Guidelines

Some functionality should be moved to Koha::DateUtils and it should be removed
step by step from the system.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 08:43:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 07:43:11 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-ysM16FH3R4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13601
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=7899
             Blocks|                            |12072

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 08:43:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 07:43:11 +0000
Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
In-Reply-To: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12072-70-fFG4Z0evZk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13813

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 08:43:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 07:43:11 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-9z3tMPYYAI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13813

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 08:43:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 07:43:11 +0000
Subject: [Koha-bugs] [Bug 7899] Remove C4::Dates from C4::Circulation
In-Reply-To: <bug-7899-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7899-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7899-70-0UdT8PQIKD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7899

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13813

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:12:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 08:12:44 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-393CpKcCc7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at biblibre.co |koha-bugs at lists.koha-commun
                   |m                           |ity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Rizwan, please stop assign me to this bug report, I don't plan to propose a
patch.

The following should fix your problem, without any guarantee:
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
index baf86b2..1a3b23c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ -722,7 +722,7 @@ No patron matched <span class="ex">[% message %]</span>
         </td>
         <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[%
todayissue.biblionumber %]&amp;type=intra"><strong>[% todayissue.title |html
%][% FOREACH subtitl IN todayissue.subtitle %] [% subtitl.subfield %][% END
%]</strong></a>[% IF ( todayissue.author ) %], by [% todayissue.author %][% END
%][% IF ( todayissue.itemnotes ) %]- <span class="circ-hlt">[%
todayissue.itemnotes %]</span>[% END %] <a
href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[%
todayissue.biblionumber %]&amp;itemnumber=[% todayissue.itemnumber %]#item[%
todayissue.itemnumber %]">[% todayissue.barcode %]</a></td>
         <td>[% UNLESS ( noItemTypeImages ) %] [% IF (
todayissue.itemtype_image ) %]<img src="[% todayissue.itemtype_image %]" alt=""
/>[% END %][% END %][% todayissue.itemtype %]</td>
-        <td><span title="[% todayissue.displaydate_sort %]">[%
todayissue.checkoutdate %]</span></td>
+        <td><span title="[% todayissue.displaydate_sort %]">[%
todayissue.displaydate %]</span></td>
         [% IF ( todayissue.multiple_borrowers ) %]<td>[% todayissue.firstname
%] [% todayissue.surname %]</td>[% END %]
         <td>[% todayissue.issuingbranchname %]</td>
         <td>[% todayissue.itemcallnumber %]</td>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:12:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 08:12:56 +0000
Subject: [Koha-bugs] [Bug 13788] Checked out On Date Appears without Time
In-Reply-To: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13788-70-mo43h75mAV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13788

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:17:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 08:17:38 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-aM5iSKMvyC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36737|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36754
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36754&action=edit
Bug 13601: Fix special case in basket.pl

There is a badly managed date in acqui/basket.pl:
if the date is 15/01/2015 (metric format), it will become
2015-1-15 after the following line:
  $estimateddeliverydate = "$year-$month-$day";
Add_Delta_Days is used at several place, and the ouput is forced to
display date on 4 digits and month/day on 2 digits.
This patch does the same thing for $estimateddeliverydate.

Note that I previously developed a patch to take this format into account (with
missing 0)
in Koha::DateUtils::dt_from_string, but I don't think it's a good idea
to manage bad formated dates.
We will certainly find some issues after previous patches, but it will permit
to catch
them!
IMO it's preferable than to keep them hidden.

The patch was:

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:20:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 08:20:44 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-nCg9YsSWMY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36754|0                           |1
        is obsolete|                            |

--- Comment #24 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36755
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36755&action=edit
Bug 13601: Fix special case in basket.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:21:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 08:21:49 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-a6Fs2mcwXA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #25 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Marc V?ron from comment #22)
> After signing off the first 4 patches I tried again with "Fix secial case in
> basket.pl", this one still does not apply with:
> fatal: corrupt patch at line 55

I c/p a diff in the commit message, git does not like that :)
Should be fixed now (I added a tab at the beginning of the lines).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:35:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 08:35:01 +0000
Subject: [Koha-bugs] [Bug 13607] Patron management API
In-Reply-To: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13607-70-HEwZPWDE39@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:57:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 08:57:09 +0000
Subject: [Koha-bugs] [Bug 13814] New: Add unit tests for C4::Boolean
Message-ID: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

            Bug ID: 13814
           Summary: Add unit tests for C4::Boolean
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: julian.fiol at biblibre.com
        QA Contact: gmcharlt at gmail.com

It missed some tests on C4::Boolean.
I want to add them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:57:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 08:57:35 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-RS57hmfWQu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Julian FIOL <julian.fiol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 09:58:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 08:58:07 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-WqQotZukfY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Julian FIOL <julian.fiol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |julian.fiol at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:14:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:14:34 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-gUadYZaOqA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #26 from Marc V?ron <veron at veron.ch> ---
Created attachment 36756
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36756&action=edit
[Signed-off] Bug 13601: Fix special case in basket.pl

There is a badly managed date in acqui/basket.pl:
if the date is 15/01/2015 (metric format), it will become
2015-1-15 after the following line:
  $estimateddeliverydate = "$year-$month-$day";
Add_Delta_Days is used at several place, and the ouput is forced to
display date on 4 digits and month/day on 2 digits.
This patch does the same thing for $estimateddeliverydate.

Note that I previously developed a patch to take this format into account (with
missing 0)
in Koha::DateUtils::dt_from_string, but I don't think it's a good idea
to manage bad formated dates.
We will certainly find some issues after previous patches, but it will permit
to catch
them!
IMO it's preferable than to keep them hidden.

The patch was:
    diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm
    index 5fe2653..4434a67 100644
    --- a/Koha/DateUtils.pm
    +++ b/Koha/DateUtils.pm
    @@ -72,17 +72,17 @@ sub dt_from_string {
             my $fallback_re = qr|
                 (?<year>\d{4})
                 -
    -            (?<month>\d{2})
    +            (?<month>\d{1,2})
                 -
    -            (?<day>\d{2})
    +            (?<day>\d{1,2})
             |xms;

             if ( $date_format eq 'metric' ) {
                 # metric format is "dd/mm/yyyy[ hh:mm:ss]"
                 $regex = qr|
    -                (?<day>\d{2})
    +                (?<day>\d{1,2})
                     /
    -                (?<month>\d{2})
    +                (?<month>\d{1,2})
                     /
                     (?<year>\d{4})
                 |xms;
    @@ -90,9 +90,9 @@ sub dt_from_string {
             elsif ( $date_format eq 'us' ) {
                 # us format is "mm/dd/yyyy[ hh:mm:ss]"
                 $regex = qr|
    -                (?<month>\d{2})
    +                (?<month>\d{1,2})
                     /
    -                (?<day>\d{2})
    +                (?<day>\d{1,2})
                     /
                     (?<year>\d{4})
                 |xms;
    diff --git a/t/DateUtils.t b/t/DateUtils.t
    index 886e1d6..0877240 100755
    --- a/t/DateUtils.t
    +++ b/t/DateUtils.t
    @@ -189,3 +189,8 @@ is( output_pref( { dt => $dt } ), '31/01/2015 12:34',
'dt_from_string should mat
     # date before 1900
     $dt = dt_from_string('01/01/1900');
     is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/1900',
'dt_from_string should manage date < 1900' );
    +
    +# missing 0
    +$dt = dt_from_string('1/1/2015');
    +is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/2015',
'dt_from_string should generate a DT object even if 0 are missing' );

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:15:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:15:02 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-cVy0mhHy6d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36755|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:16:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:16:05 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-6gcUUhLaeF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #27 from Marc V?ron <veron at veron.ch> ---
Hi Jonathan,

Is it possible to extract the regexp part in patch "Make dt_from_string not
using DateTime::Format::DateParse" to a separate sub (as replacement for the
regexp function in C4::Dates)?

Or should it be done in Bug 13813?

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:19:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:19:46 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-GVF2cABvaf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Marc V?ron from comment #27)
> Hi Jonathan,
> 
> Is it possible to extract the regexp part in patch "Make dt_from_string not
> using DateTime::Format::DateParse" to a separate sub (as replacement for the
> regexp function in C4::Dates)?
> 
> Or should it be done in Bug 13813?
> 
> Marc

Hello Marc,
I would prefer not to add any other changes to this patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:30:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:30:56 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-r4HES9KpG3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:31:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:31:01 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-p3dnZu4HZd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25643|0                           |1
        is obsolete|                            |
  Attachment #25644|0                           |1
        is obsolete|                            |
  Attachment #25645|0                           |1
        is obsolete|                            |
  Attachment #25646|0                           |1
        is obsolete|                            |
  Attachment #25647|0                           |1
        is obsolete|                            |
  Attachment #25648|0                           |1
        is obsolete|                            |
  Attachment #25649|0                           |1
        is obsolete|                            |
  Attachment #25650|0                           |1
        is obsolete|                            |
  Attachment #25651|0                           |1
        is obsolete|                            |
  Attachment #25652|0                           |1
        is obsolete|                            |
  Attachment #25653|0                           |1
        is obsolete|                            |

--- Comment #71 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36757
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36757&action=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link "Browse selected biblios >>" when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the "Browse results" block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the "Browse selected biblios >>" link
- Check that you are able to browse results you had checked.

You can also:
- check some biblios from several pages
- add them to the cart
- add them to a list

Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:31:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:31:16 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-C7IDTBM460@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

--- Comment #1 from Julian FIOL <julian.fiol at biblibre.com> ---
Created attachment 36758
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36758&action=edit
Bug 13814 : add 6 unit tests in t/Boolean.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:32:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:32:20 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-Y4U0vKhbQK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Julian FIOL <julian.fiol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:35:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:35:11 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-qoBP9HUsW3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #72 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Ok so, back on this one.
It did not apply at all and had ccsr+prog themes.
This new patch is just a squash patch with only the bootstrap theme changes.
Test plan is the same.

QA Note:(In reply to M. de Rooy from comment #26)
> If you browse the selection, it would imo be good to show that you are doing
> so (Browse selected results vs. Browse results).

I removed this change, it did not work.
Actually I don't see an easy way to do that and consider it as a minor and
should not be a blocker.

Switch back in the QA queue to give confidence to the RM.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:36:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:36:24 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-s0y0f7hbZi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|m.de.rooy at rijksmuseum.nl    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:39:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:39:04 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-LCvmZMpIaT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #29 from Marc V?ron <veron at veron.ch> ---
Ok, I set to Signed-off and hope that it will be soon QAed and pushed to master
:-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:39:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:39:19 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-MbW8WXrO0W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:42:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:42:13 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-Imj5bnVqut@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #95 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Marc V?ron from comment #94)
> I would expect a restriction "Discharged" (similar to manual restricitions).
> 
> It would display a message like:
> Restricted: Patron's account is restricted with the explanation:
> Discharched

Should work like that (looking at the code). I suspect the updatedb entry was
not executed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 10:47:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 09:47:44 +0000
Subject: [Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests
In-Reply-To: <bug-12516-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12516-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12516-70-I1JBW3tqV9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516

Julian FIOL <julian.fiol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.fiol at biblibre.com
             Status|NEW                         |ASSIGNED
           Assignee|chris at bigballofwax.co.nz    |julian.fiol at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:28:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 10:28:11 +0000
Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view
In-Reply-To: <bug-13371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13371-70-OMwgU0uxC1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

--- Comment #41 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36759
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36759&action=edit
Bug 13371: Add a simple view

This patch adds the ability to switch to a simple view if the complete
view to too complex.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 11:54:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 10:54:58 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: <bug-13726-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13726-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13726-70-fnofHD4FUn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:10:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 11:10:39 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-vnG7QNNSdK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Maxime Beaulieu from comment #5)
> Changes will only appear if the template you are generating contains:
> 
> <input type="text" name="translate" value="I wish to translate this">
> 
> And in the .po file:
> 
> #. INPUT type=text name=translate
> #: pathToTemplate:lineNumber
> msgid "I wish to translate this"
> msgstr "Translated!"
> 
> Without the patch tmpl_process3 will skip translation the value of the text
> input.
> With the patch the value is translated.
> 
> In my case, the untranslated text appeared in a customized template.
> I figured I would put a word out on the possible issue just in case.

Hi again, I found the following on current master:
1) Update a language 
2) Add an input type 'text' as suggested

e.g. on the first form of 'admin-home.tt',
<input type="text" name="translate" value="I wish to translate this">

3) Update again the language and diff staff PO file

+#. INPUT type=text name=translate
+#: intranet-tmpl/prog/en/modules/admin/admin-home.tt:25
+#, fuzzy
+msgid "I wish to translate this"
+msgstr "T?tulo traducido: "

And this "without" your patch!!
Could you confirm?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:18:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 11:18:05 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-n7sppbfxOb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:18:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 11:18:08 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-pcYUijd8nT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36667|0                           |1
        is obsolete|                            |
  Attachment #36721|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36760
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36760&action=edit
Bug 13804 - Returns via the checkouts tables uses the phrase "Returned" rather
than "Checked in"

Test plan:
1) Apply this patch
2) Return an item via the checkouts table
3) Note the left most column now reads "Checked in" rather than "Returned"

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:18:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 11:18:33 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-fqtZeo89zs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:51:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 11:51:18 +0000
Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
In-Reply-To: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12072-70-OBhnznUoZy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36726|0                           |1
        is obsolete|                            |

--- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36761
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36761&action=edit
[SIGNED-OFF] Bug 12072 - Step 1: Add system preference for New dateformat
dd.mm.yyyy

As a first step, this patch adds a new system preference for the dateformat
dd.mm.yyy
No other changes are made.

To test:
1. apply the patch
2. run updatedatabase.pl
3. go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save
4. verify that the value was saved

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
New preference brakes a lot of things, hopefully will be fixed
on 13813
No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 12:51:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 11:51:42 +0000
Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
In-Reply-To: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12072-70-padfLNdueD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27130|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:25:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 12:25:05 +0000
Subject: [Koha-bugs] [Bug 13591] Rss sample templates have hardcoded urls
In-Reply-To: <bug-13591-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13591-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13591-70-Wa5KDblLaY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 36762
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36762&action=edit
Proposed patch

Simple to test Generating an xml file without the patch (e.g. ./rss.pl
./lastAcquired-1.0.conf ) creates an xhtml page with all the links going to
library.org.nz   Doing the same with the patch applied and all links should be
to the site's own opac as specified in OPACBaseURL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:29:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 12:29:47 +0000
Subject: [Koha-bugs] [Bug 13815] New: plack loose CGI qw(-utf8) flag
 creating incorrect utf-8 encoding everywhere
Message-ID: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815

            Bug ID: 13815
           Summary: plack loose CGI qw(-utf8) flag creating incorrect
                    utf-8 encoding everywhere
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: dpavlin at rot13.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:37:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 12:37:19 +0000
Subject: [Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating
 incorrect utf-8 encoding everywhere
In-Reply-To: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13815-70-MJKhpweBU8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815

--- Comment #1 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36763
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36763&action=edit
Bug 13815 - plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding
everywhere

This is major problem for plack installations with utf-8 encoding.

In this case, we are overriding CGI->new to setup utf-8 flag and
get correctly decoded $cgi->params, and reset syspref cache using
C4::Context->clear_syspref_cache

Test scenario:
1. under plack try to search with utf-8 charactes
2. try to find patron with utf-8 characters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:38:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 12:38:07 +0000
Subject: [Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating
 incorrect utf-8 encoding everywhere
In-Reply-To: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13815-70-3E0IiBDIgx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:38:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 12:38:25 +0000
Subject: [Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating
 incorrect utf-8 encoding everywhere
In-Reply-To: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13815-70-DlaRAjp21y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |dpavlin at rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:38:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 12:38:28 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-BOYWonaAsr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

--- Comment #6 from rgravel at marlboro.edu ---
Thanks for catching that, Winona! I think this should be included in the fix,
as it was just overlooked and is the equivalent of the $e in the 100/110s.


(In reply to Winona Salesky from comment #5)
> Also, while working on this I noticed that the relator code for field 111 is
> actually subfield j, should I add that change into this fix as well? This is
> not handled by the current version of the stylesheet. 
> Thanks, 
> -Winona
> 
> 
> (In reply to Winona Salesky from comment #4)
> > Should there be a separator? Or should each be on their own line? 
> > -Winona
> > 
> > (In reply to rgravel from comment #3)
> > > I agree with Katrin about the $4 and $e conflict- always favor the term over
> > > the code, as that is what patrons will more readily understand. 
> > > 
> > > I also still like the vertical bar as a separator for the reasons I
> > > mentioned in Bug 13382.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:38:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 12:38:34 +0000
Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13791-70-kC19mAXWOx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13815

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:38:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 12:38:34 +0000
Subject: [Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating
 incorrect utf-8 encoding everywhere
In-Reply-To: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13815-70-S5GrAOTIDc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13791

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:46:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 12:46:54 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-if8A0Bz0gy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

--- Comment #7 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Hi Bernardo,

The PO's are generated correctly, but the translation does not apply to the
templates when 'translate install' is run.

TEST:
 Create custom text input in the template fo your choice
  <input type="text" name="translate" value="I wish to translate this">
 Run 'translate update [lang]'
 Check the appropriate [lang] po file and edit the translation for your input.
 Run 'translate install [lang]', the translated string does not appear.
 Apply the patch. Run 'translate install [lang]. The input is translated.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:49:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 12:49:29 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-ehOm9pq7Ci@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at biblibre.co |matthias.meusburger at biblibr
                   |m                           |e.com
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 13:53:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 12:53:36 +0000
Subject: [Koha-bugs] [Bug 13816] New: Set Overdue letter fine to the
	overduerules
Message-ID: <bug-13816-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13816

            Bug ID: 13816
           Summary: Set Overdue letter fine to the overduerules
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org

We need to be able to add a fine for borrowers for each overdueletter we send
them.

This patch makes the necessary DB modifications to add the fines-columns and
CRUD them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:01:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 13:01:55 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-L5ragdOSk9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #115 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Switched status back to needs signoff - issues with old gplv2 licenses causing
QA fail are fixed in the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:06:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 13:06:09 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-GCIcNw1Aox@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #53 from Peter Zhao <peterzhaonj at 163.com> ---
(In reply to Peter Zhao from comment #52)
> (In reply to Robin Sheat from comment #51)
> > How long did you let it sit on 'Committing', the first one can take some
> > time (in the order of 10 seconds or so perhaps.)
> > 
> > Otherwise, it's hard to see what's going on without real information but it
> > does look like things aren't indexing well.
> > 
> > In Koha/ElasticSearch/Indexer.pm there are a couple of commented out
> > 'trace_calls' entries. If you make that active, you may get more information
> > about what's going on.
> > 
> > Otherwise perhaps trace through it using the Perl debugger and see where it
> > stops.
> 
> ~$ perl -d /home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl
> 
> Loading DB routines from perl5db.pl version 1.33
> Editor support available.
> 
> Enter h or `h h' for help, or `man perldebug' for more help.
> 
> main::(/home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl:92):
> 92:	my $verbose = 0;
>   DB<1>

The problem is fixed by "cpan Task::Catmandu".
Index works well.

~$  /home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl -v -d
Indexing biblios
1
Committing...
1 records indexed.
Indexing authorities
0 records indexed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:13:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 13:13:00 +0000
Subject: [Koha-bugs] [Bug 13816] Set Overdue letter fine to the overduerules
In-Reply-To: <bug-13816-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13816-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13816-70-E00NwNSP4b@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13816

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36764
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36764&action=edit
Bug 13816 - Set Overdue letter fine to the overduerules

This patch makes the necessary DB modifications to add the fines-columns
and CRUD them using the tools/overduerules.pl

This is a good basis for defining a cost or a fine for sending the
notification, as sending them usually costs some money.

TEST PLAN:
Modify the overduerules and fines-column.
Save changes.
Observe the changes persist on page reloads.

Unit test cases are not broken and give no extra errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:24:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 13:24:42 +0000
Subject: [Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating
 incorrect utf-8 encoding everywhere
In-Reply-To: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13815-70-LAss1c6hok@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:32:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 13:32:36 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-bKolGRkYpx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 36765
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36765&action=edit
[Signed-off] Bug 13814 : add 6 unit tests in t/Boolean.t

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:33:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 13:33:07 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-hGkpzlibYc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #36758|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:33:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 13:33:16 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-fJtANWjHO2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:33:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 13:33:43 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-Xrafmqir0F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:34:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 13:34:16 +0000
Subject: [Koha-bugs] [Bug 11874] Add a "Call number fields" column to the
 Z39.50 search results.
In-Reply-To: <bug-11874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11874-70-64I2wrllLu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11874

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 14:37:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 13:37:53 +0000
Subject: [Koha-bugs] [Bug 13768] in quotes.tt line 14 the use of \" break
	the translation
In-Reply-To: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13768-70-VrP9YrB4y2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768

Christophe Croullebois <christophe.croullebois at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |christophe.croullebois at bibl
                   |                            |ibre.com
           Assignee|oleonard at myacpl.org         |christophe.croullebois at bibl
                   |                            |ibre.com

--- Comment #1 from Christophe Croullebois <christophe.croullebois at biblibre.com> ---
Created attachment 36766
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36766&action=edit
proposed patch

Bug 13768: Correction of double quotes escaped into double quotes

    Without the patch the translated pages for quotes.tt may have the
problematic line broken.
    So the js is broken too. The line with bad usage of double quotes escaped :
    var sEmptyTable = _("No quotes available. Please use the \"Add quote\"
button to add a quote.");

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:35:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 14:35:56 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-PziJxvxLgd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #4 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Tested this patch locally on a koha dev setup, and some remarks:

* incredibly fast! ~50msec on 50 borrowers...promising!
* few deps:

apt-get install -y make cpanm
cpanm Mojolicious
cpanm Swagger2

* clean and little "glue-code" to Koha
* self-documenting, in a way, with Swagger

I propose that this POC is moved forward to a fully working example covering
Borrowers, that can be part of Koha 3.20 if the New_REST_API_RFC
(http://wiki.koha-community.org/wiki/New_REST_API_RFC) are fullfilled.

What's missing now:
- authentication
- C4::Borrowers vs Koha::Borrowers?
- versioning
- content negotiation
- full CRUD

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:42:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 14:42:42 +0000
Subject: [Koha-bugs] [Bug 12553] copynumber,
 location not printing correctly on spine labels.
In-Reply-To: <bug-12553-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12553-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12553-70-wymb1DNfXP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12553

--- Comment #2 from Chris Nighswonger <cnighswonger at foundations.edu> ---
An inital look at this shows up the following:

1. The symptom manifests in bywatersolutions.com instance as described.
2. It partially manifests on my local dev box running over the current HEAD.

I say partially, because the copy number does display correctly on my dev box
with the caviate that it is always '1' because the code presently does not
distinguish between items. I'm not sure why it is always '0' on the Bywater
instance.

The problem with the location is that the current code does not return the
human-consumable form of the location, it appears to return the 

So there are two parts to this bug:

1. The copy number needs to be the correct one for the item selected in the
batch.

2. We need to add a join in order to translate the location code into a form
more palatable to the end user.

All of this happens here:

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Labels/Label.pm;h=bd3ee4fe7bbdc723d9b8b13bbb22ba8da3686086;hb=HEAD#l175

The addition of some code to that sub should fix the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:43:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 14:43:06 +0000
Subject: [Koha-bugs] [Bug 8603] Patron card creator - 'Barcode Type' doesn't
 stick in layouts
In-Reply-To: <bug-8603-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8603-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8603-70-LTla2tLDqv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:43:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 14:43:26 +0000
Subject: [Koha-bugs] [Bug 8603] Patron card creator - 'Barcode Type' doesn't
 stick in layouts
In-Reply-To: <bug-8603-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8603-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8603-70-ysXKRQXPT6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:44:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 14:44:09 +0000
Subject: [Koha-bugs] [Bug 12553] copynumber,
 location not printing correctly on spine labels.
In-Reply-To: <bug-12553-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12553-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12553-70-oFzjqVcabP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12553

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #3 from Chris Nighswonger <cnighswonger at foundations.edu> ---
Bumping importance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:45:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 14:45:11 +0000
Subject: [Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating
 incorrect utf-8 encoding everywhere
In-Reply-To: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13815-70-sy2Y03PqEw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Hi Dobrica,
I get the problem on the patron search, but not on searching biblios.
IMO we should remove the warns in the psgi file, don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:45:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 14:45:32 +0000
Subject: [Koha-bugs] [Bug 13768] in quotes.tt line 14 the use of \" break
	the translation
In-Reply-To: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13768-70-av71zf3N0k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768

--- Comment #2 from Christophe Croullebois <christophe.croullebois at biblibre.com> ---
Test plan :

without patch :

1/ in English pages go to tools/Edit quotes for QOTD feature
2/ create some quotes if there is no
3/ you must have at least 2 languages translated
4/ try with a language translated the page quotes.pl
5/ you must have the translated page broken (message charging... in the table,
no use possible in the page) if no try another language

With the patch :

same steps 1-5
5/ the translated pages must be ok

thx for testing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:59:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 14:59:00 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-oYEhkLO0is@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36637|0                           |1
        is obsolete|                            |

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36767
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36767&action=edit
[SIGNED-OFF] Bug 13794: Text input field values not translated

I left the code logic intact, and simply removed "text" from the regex.
Text input field values are now translated, no other logical changes are
introduced.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Test:
1) Update, install and enable es-ES language
2) Go to Reports > Acquisition wizard
3) On page bottom, there is a text field with the word 'Export'
4) Switch language, the word is not translated
5) Apply the patch
6) Update and install again es-ES language
7) Reload page, text now reads 'Exportar'

No koha-qa errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 15:59:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 14:59:31 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-4cWRN5CU84@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:00:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 15:00:56 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-XvdmpXS1T1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |maxime.beaulieu at inlibro.com
                   |ity.org                     |
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:08:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 15:08:46 +0000
Subject: [Koha-bugs] [Bug 13748] Acquisition wizard: some strings not
	translatable
In-Reply-To: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13748-70-qtcWb06qkY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36768
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36768&action=edit
Bug 13748: Acquisition wizard: some strings not translatable

This patch removes all instances of CGI::scrolling_list from
reports/acquisitions_stats.pl, which prevented proper translation

To test:
1) Install and enable a language (es-ES or de-DE are good choices)
2) On Acquisitons wizard, some pulldown labels are not translated
3) Apply the patch
4) Update and install again the language
5) Check labels are translated and all pulldown works

This does not solve the 'Collection code' problem,
is more strange

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:10:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 15:10:25 +0000
Subject: [Koha-bugs] [Bug 13748] Acquisition wizard: some strings not
	translatable
In-Reply-To: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13748-70-YJ8YXAyHSZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36768|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36769
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36769&action=edit
Bug 13748: Acquisition wizard: some strings not translatable

This patch removes all instances of CGI::scrolling_list from
reports/acquisitions_stats.pl, which prevented proper translation

To test:
1) Install and enable a language (es-ES or de-DE are good choices)
2) On Acquisitons wizard, some pulldown labels are not translated
3) Apply the patch
4) Update and install again the language
5) Check labels are translated and all pulldown works

This does not solve the 'Collection code' problem,
is more strange

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:12:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 15:12:04 +0000
Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents
 customization in template
In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-766-70-xytKeb2TVq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13748

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:12:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 15:12:04 +0000
Subject: [Koha-bugs] [Bug 13748] Acquisition wizard: some strings not
	translatable
In-Reply-To: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13748-70-UGAiQXhqux@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |766
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:36:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 15:36:44 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-aER13Hfw7u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #19 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Now "street type" is after the address.

I would like to see a letter or a syspref to address this problem.
We could imagine something like:

  [streettype] [address]
  [city]
  [phone]

and in the template:

  [% FOR field in fields %]
    [% SWITCH field %]
      [% CASE 'streettype' %]Street type: [% streettype %]
      [% CASE 'address' %]Address: [% address %]
      ...
    [% END %]
  [% END %]

We would avoid code duplication and it will be more customizable.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:44:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 15:44:09 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-z7lcSqT10B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Julian, Please resubmit a patch keeping alignment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:45:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 15:45:21 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-Vkj7u2druL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #47 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to simith.doliveira from comment #46)
> (In reply to comment #45)
> 
> - Your last patch adds it.
> 
> Yep, you are right. I don't remember why I put "course_reserves", maybe I
> was working with other bz at the same time.

So please resubmit a patch with a correct id for this table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:45:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 15:45:31 +0000
Subject: [Koha-bugs] [Bug 13768] in quotes.tt line 14 the use of \" break
	the translation
In-Reply-To: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13768-70-jskPa7OXAI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36766|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36770
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36770&action=edit
[SIGNED-OFF] Bug 13768: Correction of double quotes escaped into double quotes

Without the patch the translated pages for quotes.tt may have the problematic
line broken.
So the js is broken too. The line with bad usage of double quotes escaped :
var sEmptyTable = _("No quotes available. Please use the \"Add quote\" button
to add a quote.");

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

diff on staff PO file

-msgid ""
-"No quotes available. Please use the \\\"Add quote\\\" button to add a quote."
+#, fuzzy
+msgid "No quotes available. Please use the 'Add quote' button to add a quote."

No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:45:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 15:45:31 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-7plh61Xhni@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #96 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
General tests: 
 - discharge a patron as a librarian: ok
 - ask for a discharge as a patron: ok.

For the specific issue of restricting the patron:
 - in both cases, once the discharge was generated, the patron was restricted
with : 
   - Type: Discharge
   - Comment: <none>
   - Expiration: Indefinite.

Restriction works for me. I'm putting this enh back in Signed-Off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 16:46:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 15:46:48 +0000
Subject: [Koha-bugs] [Bug 13768] in quotes.tt line 14 the use of \" break
	the translation
In-Reply-To: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13768-70-wCGE5mTDMF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 17:00:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 16:00:27 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-8aUdYbSLwC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

--- Comment #4 from Julian FIOL <julian.fiol at biblibre.com> ---
Created attachment 36771
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36771&action=edit
Bug 13814 : Add Lines Alignment

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 17:08:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 16:08:03 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-ZRjiua0zfo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 17:08:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 16:08:12 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-optpojXjTB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36639|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36772
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36772&action=edit
Bug 13350: Untranslatable strings in aqbudgetperiods.tt

Counter patch, same test plan as original

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 17:09:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 16:09:40 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-ey4KfeLhB3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 17:13:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 16:13:30 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-rrVCaOYWLZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Julian FIOL <julian.fiol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36771|0                           |1
        is obsolete|                            |

--- Comment #5 from Julian FIOL <julian.fiol at biblibre.com> ---
Created attachment 36773
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36773&action=edit
Bug 13814 : Add Lines Alignment

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 17:32:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 16:32:18 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-lbti9XlmlK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36391|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:00:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:00:24 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-6vQdBvKig9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

--- Comment #20 from Marc V?ron <veron at veron.ch> ---

(In reply to Jonathan Druart from comment #19)

In Germany and Switzerland, Street type is not used as a separate part, and it
always would be after the name, often it is contained in the name.

We would write:
Baslerstrasse 50
for
50, rue de B?le

And we would not make use of the street type (because it is often a part of the
street name as Katrin pointed out above).

Drojf pointed out 
www.isotc211.org/address/iso19160.htm 
with a link to:
www.isotc211.org/address/docs/211n3188_Review_Summary_19160_Addressing.pdf

Very interesting, e.g.:
"The correct order of elements for a French address will not necessarily be
correct for a US address, and vice versa. Moreover, many Asian address systems
use the opposite order of address elements than European ones (...)".

It is almost impossible to cover all of the worldwide variations in a simple
way. That's why I choose this approach. A new address format can easily be
added (add new choice in preference and copy/edit includes with same postfix.
Fallback is always US style). 

First I was thinking about kind of "configurator" like for "Notices and Slips"
but it turned out to be a huge and complicated task (handling not only the
display /output of addresses, but the field order for editing them as well
including mandatory fields).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:00:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:00:58 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-wM7LZh4LgI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:16:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:16:37 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-AYU5911vLm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
Created attachment 36774
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36774&action=edit
[Signed-off] Bug 13814 : Add Lines Alignment

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:16:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:16:59 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-5j8U0Oi8Pp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36773|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:26:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:26:33 +0000
Subject: [Koha-bugs] [Bug 12553] copynumber,
 location not printing correctly on spine labels.
In-Reply-To: <bug-12553-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12553-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12553-70-RJmcUP6Bpm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12553

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10773

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:26:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:26:33 +0000
Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label
	Printing
In-Reply-To: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10773-70-PJa6RVHY5k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12553

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:31:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:31:54 +0000
Subject: [Koha-bugs] [Bug 13748] Acquisition wizard: some strings not
	translatable
In-Reply-To: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13748-70-F3MVWXAOBW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 36775
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36775&action=edit
[Signed-off] Bug 13748: Acquisition wizard: some strings not translatable

This patch removes all instances of CGI::scrolling_list from
reports/acquisitions_stats.pl, which prevented proper translation

To test:
1) Install and enable a language (es-ES or de-DE are good choices)
2) On Acquisitons wizard, some pulldown labels are not translated
3) Apply the patch
4) Update and install again the language
5) Check labels are translated and all pulldown works

This does not solve the 'Collection code' problem,
is more strange

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:32:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:32:23 +0000
Subject: [Koha-bugs] [Bug 13748] Acquisition wizard: some strings not
	translatable
In-Reply-To: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13748-70-dqgUb16d5E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36769|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:32:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:32:39 +0000
Subject: [Koha-bugs] [Bug 13748] Acquisition wizard: some strings not
	translatable
In-Reply-To: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13748-70-tZEcQ28rVP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:43:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:43:51 +0000
Subject: [Koha-bugs] [Bug 13817] New: Edit links on course items may point
 to the wrong course!
Message-ID: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817

            Bug ID: 13817
           Summary: Edit links on course items may point to the wrong
                    course!
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If items are assigned to multiple courses, the "edit" links for a course item
may pass the wrong course id. This is really a cosmetic issue. 

It appears that in Template Toolkit, if you reuse an existing variable name in
a foreach loop, it will not create a new temporary variable but will instead
re-use the existing variable leaving assigned at the end to the last
assignment, just as it would in Perl code. 

This is not a problem when all items are assigned to one and only one course,
but can cause issues when we loop through the other courses an item may be on. 

This is solved easily by renaming the variable used in the foreach loop to
another unused name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:45:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:45:03 +0000
Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the
 wrong course!
In-Reply-To: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13817-70-TO6VzsfGDn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:45:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:45:06 +0000
Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the
 wrong course!
In-Reply-To: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13817-70-xs0rZe6zZR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36776
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36776&action=edit
Bug 13817 - Edit links on course items may point to the wrong course!

If items are assigned to multiple courses, the "edit" links for a course
item may pass the wrong course id. This is really a cosmetic issue.

It appears that in Template Toolkit, if you reuse an existing variable
name in a foreach loop, it will not create a new temporary variable but
will instead re-use the existing variable leaving assigned at the end to
the last assignment, just as it would in Perl code.

This is not a problem when all items are assigned to one and only one
course, but can cause issues when we loop through the other courses an
item may be on.

This is solved easily by renaming the variable used in the foreach loop
to another unused name.

Test Plan:
1) Apply this patch
2) Try the edit and delete links for an item on reserve for a course
3) No changes in behavior should be noted

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:54:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:54:28 +0000
Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt
 and serials-recieve.tt
In-Reply-To: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13423-70-SmfzwLKDz5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 36777
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36777&action=edit
[Signed-off] Bug 13423: Untranslatable strings in serials-edit.tt and
serials-recieve.tt

Thid patch rewrites strings to make them translatable

To test:
1) Apply the patch
2) Update translation for your language of choice
3) Check new strings on staff PO file
+msgid "A barcode was not entered."
+msgid "Do you want to put in a barcode"
+msgid "Leave barcode blank?"
+msgid "Note: unable to change this later"
+msgid "or do you want to use a system generated barcode?"

Followed test plan. Strings appeared in staff PO file as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:54:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:54:51 +0000
Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt
 and serials-recieve.tt
In-Reply-To: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13423-70-tZirt9bRk7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36727|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 18:56:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 17:56:28 +0000
Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the
 wrong course!
In-Reply-To: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13817-70-AugnnuSIb2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:06:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 18:06:01 +0000
Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt
 and serials-recieve.tt
In-Reply-To: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13423-70-0rA23yTOUe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:17:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 18:17:35 +0000
Subject: [Koha-bugs] [Bug 13818] New: Editing and saving a course reserve
 displays the add item form
Message-ID: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13818

            Bug ID: 13818
           Summary: Editing and saving a course reserve displays the add
                    item form
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If one chooses to edit an existing course reserve for an item, saving it should
go back to the course details, but instead displays the "add items: scan
barcode" form.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:26:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 18:26:50 +0000
Subject: [Koha-bugs] [Bug 13818] Editing and saving a course reserve
 displays the add item form
In-Reply-To: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13818-70-cCV36yyVhR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13818

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:26:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 18:26:52 +0000
Subject: [Koha-bugs] [Bug 13818] Editing and saving a course reserve
 displays the add item form
In-Reply-To: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13818-70-RQEMZAvRqG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13818

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36778
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36778&action=edit
Bug 13818 - Editing and saving a course reserve displays the add item form

If one chooses to edit an existing course reserve for an item, saving it
should go back to the course details, but instead displays the "add
items: scan barcode" form.

Test Plan:
1) Edit a course reserve
2) Save it
3) Note you get the "add items: scan barcode" form
4) Apply this patch
5) Repeat steps 1 and 2
6) Note you are now redirected back to the course details page

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:34:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 18:34:44 +0000
Subject: [Koha-bugs] [Bug 13818] Editing and saving a course reserve
 displays the add item form
In-Reply-To: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13818-70-9dFDWQn8ib@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13818

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:53:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 18:53:11 +0000
Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label
	Printing
In-Reply-To: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10773-70-BpkjhWgMNh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barton at bywatersolutions.com

--- Comment #16 from Chris Nighswonger <cnighswonger at foundations.edu> ---
*** Bug 12553 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:53:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 18:53:11 +0000
Subject: [Koha-bugs] [Bug 12553] copynumber,
 location not printing correctly on spine labels.
In-Reply-To: <bug-12553-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12553-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12553-70-z6tGbI1rdT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12553

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #4 from Chris Nighswonger <cnighswonger at foundations.edu> ---


*** This bug has been marked as a duplicate of bug 10773 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:55:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 18:55:13 +0000
Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label
	Printing
In-Reply-To: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10773-70-0xJgZKnddo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

--- Comment #17 from Chris Nighswonger <cnighswonger at foundations.edu> ---
Bumping the priority on this as it is causing issues for several folks at this
point.

It would be good to get this into the next release.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 19:55:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 18:55:25 +0000
Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label
	Printing
In-Reply-To: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10773-70-NOs8uPD8Q6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major
           Priority|P5 - low                    |P3
                 CC|                            |cnighswonger at foundations.ed
                   |                            |u

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:00:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 19:00:27 +0000
Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached
In-Reply-To: <bug-13645-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13645-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13645-70-Xl2D37a5Ht@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #31 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:07:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 19:07:48 +0000
Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor
In-Reply-To: <bug-13729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13729-70-tLkJIMebwI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:13:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 19:13:06 +0000
Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with
	STRICT_TRANS_TABLES
In-Reply-To: <bug-13523-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13523-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13523-70-WZUL9z8Xvi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #18 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:49:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 19:49:02 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-nA1D002CD7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36716|0                           |1
        is obsolete|                            |

--- Comment #85 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36779
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36779&action=edit
[SIGNED OFF] Bug 13068: updatedatabase improvement for developer process

with this patch, the updatedatabase now checks info the atomicupdate directory.
If there is some SQL here, it's executed.
Note that there is no version update, so if you run the updatedatabase script
twice, you'll get an sql error probably.

This patch will be very useful for sandbox testing process.

When the RM pushes a patch with something in i'atomicupdate', he will have to
copy it into updatedatabase.pl, give it a number, and remove the file in
db_update

Test plan:
 * apply the patch
 * create a files with a .sql extension in the atomicupdate directory
 * run updatedatabase.pl
 * look at your database, what was in the .sql file must have been run

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:49:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 19:49:20 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-ihfUTaLolf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36717|0                           |1
        is obsolete|                            |

--- Comment #86 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36780
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36780&action=edit
[SIGNED OFF] Bug 13068: Follow-up for cleaning up atomicupdate folder

The folder atomicupdate can be cleaned up. It mainly contains old files that
are not used any more.
I found two files that are still referenced:
[1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl
    A readme file refers to it. The code in this file slightly differs
    from the TalkingTech db revision. It can probably be deleted too, but
    I will first check.
[2] oai_sets.sql
    This file should remain. It is used in dbrev 3.07.00.029.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:49:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 19:49:33 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-18Uf7vg6zJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36718|0                           |1
        is obsolete|                            |

--- Comment #87 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36781
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36781&action=edit
[SIGNED OFF] Bug 13068: (QA followup) Remove old files, use C4::Installer

* moving oai-sets.sql from atomicupdate to updatedatabase itself
 * using Installer file loader to load & execute SQL file

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:50:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 19:50:47 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-Sip8i98TOQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

--- Comment #88 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I'm pretty confident, just asking for another QA just in case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:55:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 19:55:26 +0000
Subject: [Koha-bugs] [Bug 13351] Untranslatable javascript in members.tt
In-Reply-To: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13351-70-c7QkMx9Zls@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:56:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 19:56:52 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-pAC5cf4X8R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #48 from simith.doliveira at inlibro.com ---
Created attachment 36782
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36782&action=edit
Bug 13364 - Add a call number browser in item edition page - QA fixed II

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 20:57:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 19:57:37 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-ce0sPX9ZNR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 21:31:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 20:31:50 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-3q7iCFwtU2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #65 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to M. Tompsett from comment #64)
> (In reply to Jonathan Druart from comment #62)
> > Be care, prototype of GetMarcBiblio is modified here, bug 12252 did it too!
> 
> This change catches the old way and a hashref. Though, because a third
> parameter was added in 12252, this would require a more detailed look there.
> However, that would more likely come anyways if that is pushed to master
> first anyways, because this would need a rebase. Thanks for the heads up.

I would consider this bugfix if it was implemented as a Koha::RecordProcessor
filter for MARC::Record objects, rather than just another hook to C4::Search.
That way we could use it wherever we need it.

BUT I have to say that I've been playing with an implementation that works with
MARCMXL instead (using XSLT) and could help us simplicy results rendering and
probably performance.

I'm trying to finish the patches (the hackfest had me busy with other stuff) so
I can attach them for peer review.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 22:02:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 21:02:10 +0000
Subject: [Koha-bugs] [Bug 13819] New: Add biblioitems to available tables in
 ISSUESLIP and ISSUEQSLIP
Message-ID: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819

            Bug ID: 13819
           Summary: Add biblioitems to available tables in ISSUESLIP and
                    ISSUEQSLIP
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Patron has requested publisher date and location information on call slips;
these are only available in biblioitems, which is not currently in the tables
available .

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 10 23:25:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 22:25:53 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-ygIJqV9c5C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #54 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Peter Zhao from comment #52)
> Enter h or `h h' for help, or `man perldebug' for more help.
> 
> main::(/home/koha/kohaclone/misc/search_tools/rebuild_elastic_search.pl:92):
> 92:	my $verbose = 0;
>   DB<1>

You would actually need to trace it through after this point :)

(In reply to Peter Zhao from comment #53)
> The problem is fixed by "cpan Task::Catmandu".
> Index works well.

Unfortunately, that doesn't solve the cause of the problem. It shouldn't be
necessary to cpan anything. It would be better to know what the missing module
is so that I can make it fail properly if it's missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 00:10:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 23:10:56 +0000
Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag
	visibility
In-Reply-To: <bug-11592-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11592-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11592-70-XKdVIZ7Ce6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #66 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Tom?s Cohen Arazi from comment #65)
> I would consider this bugfix if it was implemented as a
> Koha::RecordProcessor filter for MARC::Record objects, rather than just
> another hook to C4::Search. That way we could use it wherever we need it.

This does NOT touch C4::Search at all.

My initial worry is the whole inclusion loop making debugging a pain!
But your idea of effectively moving all the stuff added to C4::Biblio into a
filter module is good, if there isn't some magical loop which makes debugging a
pain.


> BUT I have to say that I've been playing with an implementation that works
> with MARCMXL instead (using XSLT) and could help us simplicy results
> rendering and probably performance.
> 
> I'm trying to finish the patches (the hackfest had me busy with other stuff)
> so I can attach them for peer review.

I was going to attempt to go that way. My concern is if we have MARCXML filters
and non-XML filters, we need to make sure they are identical. I suppose part of
the unit tests to add into the continuous integration. :)

This is why I was wondering if perhaps we would go completely MARCXML
internally, as I vaguely recall some indexing limit which you hit for a MARC
Record, but perhaps that is unrelated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 00:11:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Mar 2015 23:11:23 +0000
Subject: [Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating
 incorrect utf-8 encoding everywhere
In-Reply-To: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13815-70-2bEq2aVuPl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815

--- Comment #3 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Sure, this is just a quick code drop. I think that my production in now ready
to be updated to master with plack.

I also need to suppress warning.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 02:05:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 01:05:05 +0000
Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and
 deleted from the catalogue
In-Reply-To: <bug-12919-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12919-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12919-70-7Vm5NmwJVi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

--- Comment #4 from Liz Rea <liz at catalyst.net.nz> ---
This is such a handy tool, it could really use a signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 02:53:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 01:53:12 +0000
Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
In-Reply-To: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13381-70-8iPbO1BnB6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34997|0                           |1
        is obsolete|                            |

--- Comment #22 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 36783
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36783&action=edit
Bug 13381 - RDA: 245 field changes in XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:13:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 02:13:23 +0000
Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT
In-Reply-To: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13386-70-VPzsGf6LJT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wsalesky at gmail.com

--- Comment #1 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 36784
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36784&action=edit
RDA: 246 field changes in XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:23:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 02:23:31 +0000
Subject: [Koha-bugs] [Bug 13385] RDA: 508 display in XSLT
In-Reply-To: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13385-70-I5qVwiybpr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wsalesky at gmail.com

--- Comment #1 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 36785
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36785&action=edit
RDA: Added field 508 in XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 03:38:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 02:38:38 +0000
Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
In-Reply-To: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13382-70-DtNxRGtxqg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35759|0                           |1
        is obsolete|                            |

--- Comment #25 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 36786
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36786&action=edit
RDA 700s display in XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 04:13:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 03:13:48 +0000
Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT
In-Reply-To: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13433-70-rkIlaTJ3Qm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wsalesky at gmail.com

--- Comment #1 from Winona Salesky <wsalesky at gmail.com> ---
Any preferred location in the record for this display? My instinct is to place
it either next to or below "Material Type"
-Winona


(In reply to Nicole C. Engard from comment #0)
> 655: Display as Genre/Form (full display): Display corresponding subfields
> a, v, x, y, z. This change would bring Koha?s display in line with the now
> codified practice of separating about-ness (subject headings) from is-ness
> (genre/form headings). 
> 
> If you're interested, for more info on that, see:
> http://www.loc.gov/catdir/cpso/genre_form_faq.pdf

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 07:57:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 06:57:37 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-C92deniIbd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 07:57:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 06:57:42 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-iJhwgIj0Mn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36742|0                           |1
        is obsolete|                            |

--- Comment #24 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 36787
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36787&action=edit
Bug 9481 - charge not showing fines On 'Check out' and 'Details'.

When looking at the patron record or the checkout screen the checkout
summary is now showing 0 for all the Charges even if the item was
overdue and has accrued fines.
Removed unused(?) footer values in checkouts-table-footer.inc

To test:
1/ Check out items with past due date
2/ Run fines.pl script (ensure finesMode is set to Calculate and Charge)
3/ Verify on Fines->Pay Fines screen that fines where calculated
correct.
4/ Go to Patron record, charge column on Details and Check out
screen
should be 0 or rental charge amount only. But total amount row
display right
number, same as in pay fines screen.
4/ Apply patch.
5/ Now charges on display and check out screen shows all outstanding
fees for each item.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 08:01:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 07:01:23 +0000
Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of
	charge period
In-Reply-To: <bug-13590-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13590-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13590-70-8uHiZRP3cz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 08:08:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 07:08:08 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-hOsS6Xo3SX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27958|0                           |1
        is obsolete|                            |

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 36788
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36788&action=edit
Bug 11364: Label layout types and text justification types are not translatable

To test:

1) cd misc/translator
2) perl translate update xx-YY
3) check that there's no msgids that contain the layout types or
   text justification types in po/xx-YY-i-staff-t-prog-v-3006000.po
4) apply patch
5) perl translate update xx-YY
6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the
   msgid for the frequencies. (search for "BLOCK translate_label_types"
   and "BLOCK translate_justification_types")

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 08:08:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 07:08:43 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-V65ao6bBqh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 08:08:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 07:08:47 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-WeDF0xfC4D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36722|0                           |1
        is obsolete|                            |

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 36789
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36789&action=edit
Bug 11364 - Label layout types and text justification types are not
translatable

Removed obsolete code from from C4/Creators/Lib.pm  around line 129.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 08:15:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 07:15:19 +0000
Subject: [Koha-bugs] [Bug 13818] Editing and saving a course reserve
 displays the add item form
In-Reply-To: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13818-70-HsXSX2vIIl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13818

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 08:15:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 07:15:22 +0000
Subject: [Koha-bugs] [Bug 13818] Editing and saving a course reserve
 displays the add item form
In-Reply-To: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13818-70-Mzs8cNsT0G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13818

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36778|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 36790
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36790&action=edit
Bug 13818 - Editing and saving a course reserve displays the add item form

If one chooses to edit an existing course reserve for an item, saving it
should go back to the course details, but instead displays the "add
items: scan barcode" form.

Test Plan:
1) Edit a course reserve
2) Save it
3) Note you get the "add items: scan barcode" form
4) Apply this patch
5) Repeat steps 1 and 2
6) Note you are now redirected back to the course details page

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 09:18:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 08:18:12 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-5X9pxhSkDr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

koha at akafred.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at akafred.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:41:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 09:41:29 +0000
Subject: [Koha-bugs] [Bug 13818] Editing and saving a course reserve
 displays the add item form
In-Reply-To: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13818-70-8GPkUDgWwX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13818

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:41:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 09:41:31 +0000
Subject: [Koha-bugs] [Bug 13818] Editing and saving a course reserve
 displays the add item form
In-Reply-To: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13818-70-jXddWuaDh7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13818

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36790|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36791
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36791&action=edit
Bug 13818 - Editing and saving a course reserve displays the add item form

If one chooses to edit an existing course reserve for an item, saving it
should go back to the course details, but instead displays the "add
items: scan barcode" form.

Test Plan:
1) Edit a course reserve
2) Save it
3) Note you get the "add items: scan barcode" form
4) Apply this patch
5) Repeat steps 1 and 2
6) Note you are now redirected back to the course details page

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:42:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 09:42:01 +0000
Subject: [Koha-bugs] [Bug 13818] Editing and saving a course reserve
 displays the add item form
In-Reply-To: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13818-70-fFAmeKUq4Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13818

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:52:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 09:52:57 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-gXvpaI0Fkx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #89 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 36781
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36781
[SIGNED OFF] Bug 13068: (QA followup) Remove old files, use C4::Installer

Review of attachment 36781:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13068&attachment=36781)
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +4945,5 @@
> +    $dbh->do(qq{
> +DROP TABLE IF EXISTS `oai_sets_descriptions`;
> +DROP TABLE IF EXISTS `oai_sets_mappings`;
> +DROP TABLE IF EXISTS `oai_sets_biblios`;
> +DROP TABLE IF EXISTS `oai_sets`;

This does not work.
It's not possible to execute more than 1 query using the do method.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:53:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 09:53:07 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-VLIrqhAdfl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 10:53:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 09:53:43 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-dcTg5m0jxa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #90 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Jonathan Druart from comment #89)
> This does not work.
> It's not possible to execute more than 1 query using the do method.

I will try to submit a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:05:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 10:05:06 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-TYzeOgw0Xf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #91 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to Jonathan Druart from comment #89)
> Comment on attachment 36781 [details] [review]
> [SIGNED OFF] Bug 13068: (QA followup) Remove old files, use C4::Installer
> 
> Review of attachment 36781 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: installer/data/mysql/updatedatabase.pl
> @@ +4945,5 @@
> > +    $dbh->do(qq{
> > +DROP TABLE IF EXISTS `oai_sets_descriptions`;
> > +DROP TABLE IF EXISTS `oai_sets_mappings`;
> > +DROP TABLE IF EXISTS `oai_sets_biblios`;
> > +DROP TABLE IF EXISTS `oai_sets`;
> 
> This does not work.
> It's not possible to execute more than 1 query using the do method.

Sure ? When we tested this patch, with Tomas, I think we started from a 3.0 DB,
and I didn't saw any error. I must be wrong...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:13:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 10:13:37 +0000
Subject: [Koha-bugs] [Bug 12594] Get rid of z3950random
In-Reply-To: <bug-12594-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12594-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12594-70-jAA0rLvxr1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12594

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_16_candidate
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 11:23:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 10:23:21 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-bncPN2eWv2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #92 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Paul Poulain from comment #91)
> Sure ? When we tested this patch, with Tomas, I think we started from a 3.0
> DB, and I didn't saw any error. I must be wrong...

Yep, sure:
http://search.cpan.org/dist/DBI/DBI.pm#do
"Prepare and execute a single statement.[...]"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:07:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 11:07:28 +0000
Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as
	expected
In-Reply-To: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10985-70-T48VP2Oqzd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:07:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 11:07:48 +0000
Subject: [Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be
 included PRE-gst tax (as an option)
In-Reply-To: <bug-11062-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11062-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11062-70-NgNXKZACwu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:08:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 11:08:59 +0000
Subject: [Koha-bugs] [Bug 12825] GST / VAT rewrite
In-Reply-To: <bug-12825-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12825-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12825-70-eNh2C6zKKW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12825

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:09:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 11:09:57 +0000
Subject: [Koha-bugs] [Bug 12826] GST / VAT rewrite - plumbing
In-Reply-To: <bug-12826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12826-70-NR1HFZZcah@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12826

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:10:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 11:10:47 +0000
Subject: [Koha-bugs] [Bug 12964] GST / VAT rewrite - Overview
In-Reply-To: <bug-12964-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12964-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12964-70-AWU54DNS4W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 12:13:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 11:13:49 +0000
Subject: [Koha-bugs] [Bug 10984] Cannot cancel received order if the parent
 order is deleted
In-Reply-To: <bug-10984-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10984-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10984-70-5FmUZS56lB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10984

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:29:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 12:29:13 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-SPj0kmV69n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:29:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 12:29:47 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-aTgcM9iHT8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:31:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 12:31:36 +0000
Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables
In-Reply-To: <bug-13492-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13492-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13492-70-qdzUK9J3SI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:32:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 12:32:51 +0000
Subject: [Koha-bugs] [Bug 5338] Serials in guided reports
In-Reply-To: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5338-70-C4aik3y4S9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:33:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 12:33:37 +0000
Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
In-Reply-To: <bug-8992-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8992-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8992-70-KIlhcroDh2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:37:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 12:37:11 +0000
Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements
In-Reply-To: <bug-12404-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12404-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12404-70-OuZc72DTl5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:40:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 12:40:05 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-pTCSarBxGg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 13:42:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 12:42:03 +0000
Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials
In-Reply-To: <bug-13662-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13662-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13662-70-AuS2Jv225Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:20:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 13:20:11 +0000
Subject: [Koha-bugs] [Bug 13820] New: Hold Notification - generated at check
 in at destination branch
Message-ID: <bug-13820-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13820

            Bug ID: 13820
           Summary: Hold Notification - generated at check in at
                    destination branch
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: PC
                OS: Windows
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: thomas.rowley at cheshiresharedservices.gov.uk
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Koha would seem to generate a 'Hold Available' notification when a requested
item is checked in irrespective of whether the workstation is at the branch
where the item resides or not. 

This means that even if the item still has to go into transit to the requesting
branch, the check in process is designating the hold as being available
already. 

We need the process updating to only generate the 'Hold Available' notification
when the item arrives and is checked in at the destination/pickup/requesting
branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:20:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 13:20:33 +0000
Subject: [Koha-bugs] [Bug 13820] Hold Notification - generated at check in
 at destination branch
In-Reply-To: <bug-13820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13820-70-ZkPWGYws77@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13820

Tom Rowley <thomas.rowley at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:28:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 13:28:13 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-EqpAdaSKGY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:28:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 13:28:16 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-xDs8TKPPQK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #93 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36792
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36792&action=edit
Bug 13068: (follow-up) Remove old files, use C4::Installer

The do method does not accept more than 1 sql query.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 14:39:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 13:39:58 +0000
Subject: [Koha-bugs] [Bug 13820] Hold Notification - generated at check in
 at destination branch
In-Reply-To: <bug-13820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13820-70-Lv7Wtirjmh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13820

Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:00:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:00:16 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-Cfg28Iadrb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 36789
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36789
Bug 11364 - Label layout types and text justification types are not
translatable

Review of attachment 36789:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11364&attachment=36789)
-----------------------------------------------------------------

::: C4/Creators/Lib.pm
@@ -124,4 @@
>      {type => 'HBO',     name => 'Helvetica-Bold-Oblique',       selected => 0},
>  ];
>  
> -my $text_justification_types = [

This variable is still used.
However, the name keys could be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:00:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:00:26 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-Oau1rKlpoP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
  Attachment #36789|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:01:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:01:03 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-wj0qtbbsAc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:01:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:01:05 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-CzBkfKebiB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36788|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36793
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36793&action=edit
Bug 11364: Label layout types and text justification types are not translatable

To test:

1) cd misc/translator
2) perl translate update xx-YY
3) check that there's no msgids that contain the layout types or
   text justification types in po/xx-YY-i-staff-t-prog-v-3006000.po
4) apply patch
5) perl translate update xx-YY
6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the
   msgid for the frequencies. (search for "BLOCK translate_label_types"
   and "BLOCK translate_justification_types")

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:01:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:01:11 +0000
Subject: [Koha-bugs] [Bug 13821] New: Add possibility to select more than
 one department on a course reserve
Message-ID: <bug-13821-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13821

            Bug ID: 13821
           Summary: Add possibility to select more than one department on
                    a course reserve
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: marjorie.barry-vila at ccsr.qc.ca
        QA Contact: testopia at bugs.koha-community.org

Hi,
It would be fine to have the possibility to select more than one department on
a course reserve.
Sometimes some courses depend on several departments within the institution.
Currently the information must be doubled if you want to specify the names of
the two departments.

Regards,
Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:14:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:14:31 +0000
Subject: [Koha-bugs] [Bug 11023] Automatic item modification by age (Was
 "Toggle new status for items")
In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11023-70-nlM95XNy4k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com
           Assignee|jonathan.druart at biblibre.co |matthias.meusburger at biblibr
                   |m                           |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:15:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:15:52 +0000
Subject: [Koha-bugs] [Bug 11668] Untranslatable "Total" in borrowers stats
 and other reports
In-Reply-To: <bug-11668-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11668-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11668-70-8IpuMLyzgp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11668

--- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 36794
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36794&action=edit
Bug 11668: another approach

In this patch I pass the messages to be printed
as hidden parameters that are set using JQuery,
and translated in the usual way.

To test:
1) Apply the patch
2) Update and install de-DE (works with this lang)
3) Go to Reports > Patron statistics
4) Select Patron category in row, Library as column
(just an example), export as CSV
5) Switch to German and repeat 4
6) Check translated 'Total/TOTAL' in german CSV

Just a idea, if you like it, can be extended to
the other cases

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:18:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:18:30 +0000
Subject: [Koha-bugs] [Bug 11023] Automatic item modification by age (Was
 "Toggle new status for items")
In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11023-70-spHtd7lGz1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|matthias.meusburger at biblibr |jonathan.druart at biblibre.co
                   |e.com                       |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:22:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:22:49 +0000
Subject: [Koha-bugs] [Bug 13372] Items lost report improvements
In-Reply-To: <bug-13372-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13372-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13372-70-ZuLd60j41n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:24:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:24:11 +0000
Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related
 to their branch.
In-Reply-To: <bug-8438-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8438-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8438-70-3Tepy7RQzG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:25:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:25:51 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10363-70-gzAVJ7BnK5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:28:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:28:47 +0000
Subject: [Koha-bugs] [Bug 12771] Enhancement to manage more than 3 levels of
 overdue notice
In-Reply-To: <bug-12771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12771-70-nQosmMlzfc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12771

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:31:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:31:36 +0000
Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export
In-Reply-To: <bug-11603-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11603-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11603-70-AOdcqI96ZL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:31:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:31:58 +0000
Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email
In-Reply-To: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11678-70-xv7Yr9bc5h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:32:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:32:38 +0000
Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework
 to be used when creating a record in acquisitions
In-Reply-To: <bug-12743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12743-70-EytUiOi7vT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:33:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:33:26 +0000
Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a
 suggestion can be treated
In-Reply-To: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13014-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13014-70-DMyyf0sLD3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:34:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:34:12 +0000
Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a
	basket/list by email
In-Reply-To: <bug-13345-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13345-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13345-70-Ro6FaBrkKu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:34:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:34:45 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-7rL2WS2QHL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #62 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Jonathan, I like the patch set, but there are two minor things remaining:

- Missing the kohastructure.sql addition
- We should really stick with the adopted naming schema for tables. Even if it
will not be consistent with the current table names for acquisitions (we
should, at some point just rename them).

I would accept 'aqorder_users', but the ideal one would be
'aquisition_order_users', that would map to Koha::Acquisition::Order::Users.

I'm open to discussing the naming schema and I know this bug has been here
before the guidelines have been accepted. It is just a minor refactoring that i
will accept as PASSED-QA.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:41:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:41:18 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-eBBm66MwqR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34487|0                           |1
        is obsolete|                            |
  Attachment #34488|0                           |1
        is obsolete|                            |
  Attachment #35059|0                           |1
        is obsolete|                            |
  Attachment #35060|0                           |1
        is obsolete|                            |
  Attachment #35061|0                           |1
        is obsolete|                            |
  Attachment #35062|0                           |1
        is obsolete|                            |
  Attachment #35063|0                           |1
        is obsolete|                            |
  Attachment #35064|0                           |1
        is obsolete|                            |
  Attachment #35065|0                           |1
        is obsolete|                            |
  Attachment #35066|0                           |1
        is obsolete|                            |

--- Comment #63 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36795
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36795&action=edit
Bug 12648: Link patrons to an order - DB changes

This patch inserts the new notification template into the letters table.
It also add the insert statements into the language specific files.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

Amended patch: Add the kohastructure.sql changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:41:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:41:23 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-nPVVSpZsvy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #64 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36796
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36796&action=edit
Bug 12648: Refactoring to prepare user search for reuse

A previous enhancement allows to link basket with patrons.
Next patches will use the same way to link order with patrons.

In order to avoir c/p of code, this patch refactores this part of code.

Test plan:
1/ Verify there is no regression on adding/modifying users to a basket.
(acqui/basket.pl?basketno=XXX, "Managed by", "Add user").
2/ Note that you get a friendly message if the user is already present in the
list and when the user has correctly been added to the list.
3/ Note that the list uses the member search service (ie. DataTable +
serverside processing).

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:41:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:41:28 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-iSGfEdtjQQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #65 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36797
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36797&action=edit
Bug 12648: Link patrons to an order

This patch is the main patch.

This feature adds the ability to link patrons to an order.
On that way, they will be notified when the order is completely
received.

Test plan:
1/ Execute the updatedb entry and verify you have a new notification template
in your table (tools/letter.pl).
code: ACQ_NOTIF_ON_RECEIV, module: acquisition
2/ You can edit it if you want
3/ Create a basket and create an order with 1 or more items
4/ Link 1+ patrons to this order
5/ Close the basket and receive the order
6/ When you have received all items for this order, all patrons attached
will be notified. Check the message_queue table to check if the letters
have correctly been added to the queue.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:41:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:41:33 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-pDmiCpJdqO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #66 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36798
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36798&action=edit
Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers

Test plan:
Verify that unit tests pass with
    prove t/db_dependent/Acquisition/OrderUsers.t

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:41:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:41:38 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-YRt0B6cqHk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #67 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36799
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36799&action=edit
Bug 12648: The users added to basket should have a permission

Before this enh, the users to add to a basket should have the
acquisition.order_manage permission.
This patch reintroduces this behavior.

The code in acqui/add_user_search.pl was never used. The filter should
be done in the members/search service.

But it is not possible easily to filter using a sql query, so the filter
is done after. This means that we cannot use the DT pagination
(otherwise the results will become inconsistent).

Test plan:
1/ On adding patrons to a basket, verify that the search patron results contain
patron with the acquisition.order_manage permission.
2/ Verify that all patrons are return on the 'normal' patron search and
when adding patrons to an order.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:41:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:41:43 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-RmlfvYjKO6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #68 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36800
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36800&action=edit
Bug 12648: Fix conflict with bug 12833

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:41:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:41:47 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-b0VsP3y3OL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #69 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36801
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36801&action=edit
Bug 12648: Hide the result search on load

When no search has been done yet, it's not necessary to display the
result list.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:41:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:41:53 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-IXbsLPAt4Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #70 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36802
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36802&action=edit
Bug 12648: The patron's name should be the same as before

The displayed patron's name should be surname + firstname

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:41:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:41:57 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-zTDAbDsLXq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #71 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36803
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36803&action=edit
Bug 12648: Add the new 'Acquisition' entry in the letter module list

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:42:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:42:02 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-PElXJw3mFG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #72 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36804
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36804&action=edit
Bug 12648 - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:42:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:42:07 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-lDdR8Sa98x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #73 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36805
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36805&action=edit
Bug 12648: Rename aqorderusers to aqorder_users

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:42:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:42:56 +0000
Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to
 the shelves list view
In-Reply-To: <bug-13419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13419-70-zto7nNY2XZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:43:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:43:10 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-jVA2MTTNYk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #74 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Tom?s Cohen Arazi from comment #62)
> - Missing the kohastructure.sql addition

First patch amended.

> - We should really stick with the adopted naming schema for tables. Even if
> it will not be consistent with the current table names for acquisitions (we
> should, at some point just rename them).
> 
> I would accept 'aqorder_users', but the ideal one would be
> 'aquisition_order_users', that would map to Koha::Acquisition::Order::Users.

aqorderusers replaced with aqorders_users in the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:47:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:47:32 +0000
Subject: [Koha-bugs] [Bug 13822] New: Patron autocomplete search is severly
	limited
Message-ID: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

            Bug ID: 13822
           Summary: Patron autocomplete search is severly limited
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The script that returns data for the patron autocomplete does not use
C4::Members::Search. Instead it uses bespoke code that does not behave like the
traditional search and is very limited in how it can search.

If, for example, I search for "hall, k" in the standard search, I would get
"Kyle Hall" back as a result. For the autocomplete search, I will not.

This script should use C4::Members::Search to provide better searching and to
keep the code base DRY.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:48:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:48:03 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-wkSjdViQtc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:52:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:52:05 +0000
Subject: [Koha-bugs] [Bug 13434] 586 XSLT improvements
In-Reply-To: <bug-13434-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13434-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13434-70-gjMBc1g3Iv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |wsalesky at gmail.com
                 CC|                            |wsalesky at gmail.com

--- Comment #1 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 36806
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36806&action=edit
Bug 13434 - RDA: 586 field changes in XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:53:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:53:36 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-JYO4VAgcQM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #75 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36807
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36807&action=edit
Bug 12648: (RM followup) DBIx schema update

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:58:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:58:17 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-q7oZ8KLLMG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:58:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:58:19 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-zQ2Gzaxg7v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36808
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36808&action=edit
Bug 13822 - Patron autocomplete search is severly limited

The script that returns data for the patron autocomplete does not use
C4::Members::Search. Instead it uses bespoke code that does not behave like the
traditional search and is very limited in how it can search.

If, for example, I search for "Kyle Hall" in the standard search, I would get
"Kyle Hall" back as a result. For the autocomplete search, I will not.

This script should use C4::Members::Search to provide better searching and to
keep the code base DRY.

Test Plan:
1) Enable the system preference CircAutocompl
2) Create a user with the first name "Test" and the surname "User"
3) Perform a checkout autocomplete search for "Test User"
4) Note you do not get the user as a result
5) Apply this patch
6) Try different combinations of "Test" and "User" such as
   Test User
   User Test
   U Test
   Test U
   etc.
7) Note these searches now work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 15:58:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 14:58:29 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-6nXtc9d5Eo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:02:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 15:02:35 +0000
Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs
In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13734-70-eebToXaR7d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wsalesky at gmail.com

--- Comment #1 from Winona Salesky <wsalesky at gmail.com> ---
Are there a few example records I could use for testing? (MARCXML format would
be most helpful)
Thanks!
-Winona

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:16:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 15:16:25 +0000
Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as
	expected
In-Reply-To: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10985-70-PSocskh8NP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21714|0                           |1
        is obsolete|                            |

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36809
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36809&action=edit
Bug 10985: [UNIMARC] Fix authority summary

The problem is the template in authority type summary is not respected
at all. It is only read to see which fields and subfields should appear
in the summary.
This patch fixes that.
It also fixes a bug in auth_finder.pl plugin when summary contains
fields other than 2XX.

Test plan:
0/ You must use a UNIMARC setup for those tests
1/ edit an authority type summary with:
     NP : [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn:
009*]
2/ create a new authority with previous fields (it is possible some
   fields don't exist).
3/ search this authority and verify the summary is someting like:
     NP : Name, D.-- NP -- 23849 ppn: my_ppn
4/ Verify some summary for existing authorities and check they are
   correct.
5/ Edit a biblio record and use the plugin auth_finder.pl (for example
   in a 7XX field)
6/ Do a search and verify the summary is correct
7/ Click on 'choose' or one of the numbered links ('1', '2', ... ; you
should have multiple 2XX fields for the numbered links to show up)
8/ Verify that the biblio field is correctly filled.

/!\ For the ppn, it should be defined in the zebra indexes.

In MARC21 and NORMARC setups, this patch should change nothing, please
verify that too (you can check that the auth_finder.pl plugin is still
working and the auth type summary is correctly displayed in authorities
search and auth_finder.pl plugin).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:17:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 15:17:11 +0000
Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as
	expected
In-Reply-To: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10985-70-A6duL7VfEs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch rebased, test plan improved, and additional fix added

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:17:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 15:17:18 +0000
Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as
	expected
In-Reply-To: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10985-70-WZDqi2bUj0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at biblibre.co |julian.maurice at biblibre.com
                   |m                           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:25:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 15:25:15 +0000
Subject: [Koha-bugs] [Bug 12810] After MTT gather_print_notices includes
	overdues
In-Reply-To: <bug-12810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12810-70-EsdSUof0yB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12810

Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:31:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 15:31:35 +0000
Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking
 because of case insensitive utf8 collation
In-Reply-To: <bug-13810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13810-70-5wHJsk49lY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810

--- Comment #2 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
putting utf8_bin in place of everything else breaks something. The intranet
launches the web installer instead of the login prompt.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:33:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 15:33:28 +0000
Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in
	XSLT
In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13387-70-XS6Gj3NcVm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wsalesky at gmail.com

--- Comment #1 from Winona Salesky <wsalesky at gmail.com> ---
Just to be clear, Uniform Titles do not currently appear in the results list
(brief display). So they should be added? 

Thanks,
-Winona



(In reply to Nicole C. Engard from comment #0)
> The following change should be made to the MARC21 details in the staff and
> OPAC:
> 
> 130/240/730 Display as Uniform Titles (brief/full display) 
> 
> Display corresponding subfields a, b, c, k, n, p, s
> 
> Use vertical bar to separate multiple other titles
> 
> Examples: 
> 
> Uniform titles: Orchestra music. Selections.
> 
> Uniform titles: Hunger games (Motion picture)
> 
> Uniform titles: Organ music. Selections. | Kleine Pra?ludien und Fugen.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 16:35:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 15:35:44 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-N5H0wy0q9c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #76 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36810
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36810&action=edit
Bug 12648: Fix conflict with bug 8096

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:03:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 16:03:38 +0000
Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses
In-Reply-To: <bug-12802-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12802-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12802-70-L7YexDL1FZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:08:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 16:08:49 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-3j7TGM3f1D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I can confirm the patch work, but I cannot be sure it won't introduce
regression

The "text" have been added by 
commit db1660f512c52a9c848489f4e2e56516e99e1567
Author: acli <acli>
Date:   Mon Mar 8 04:59:38 2004 +0000

    Fixed some bugs which caused some context to be not recognized, and some
    spurious context to be recognized.  In particular, the bugs fixed are:

    1. Failure to recognize INPUT element at the end, e.g., if the input has
       the form "Item number:%S", then the pattern was recognized as only
       "Item number".

    2. Failure to remove matching <foo></foo> tags if the pattern contains
       INPUT or TMPL_VAR; e.g., if the input has the form "<h1>%s %s</h1>",
       the form would not be simplified to "%s %s".

    Unfortunately, fixing these 2 bugs will cause about 40 fuzzies to appear.

But it did a lot of other stuffs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:09:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 16:09:42 +0000
Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly
In-Reply-To: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10827-70-htGxRUlKq8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25942|0                           |1
        is obsolete|                            |

--- Comment #31 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 36811
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36811&action=edit
Bug 10827: Regression tests

The unit tests in the file db_dependent/Reserves/priorities.t describe
the issue.

To reproduce using the interface:
- Create 3 patrons A, B and C
- Check an item out to A
- Place a hold on this item for B and C
- Check the item in
- Confirm the hold
- Verify the hold list:
  The item is waiting for B and C has a priority 2
- Delete the hold for B
- Now you can see the item is not waiting for C. He has not been
  notified neither.

If you apply all patches from this bug, at the next ste, the item is
marked as waiting for C and C has been notified when the hold for B has
been deleted.

/!\Important note: This patch only manages item-level holds!
The commented UT is for biblio-level holds.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:09:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 16:09:53 +0000
Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly
In-Reply-To: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10827-70-0rTFRGWAKS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25943|0                           |1
        is obsolete|                            |

--- Comment #32 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 36812
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36812&action=edit
Bug 10827: Change prototype for ModReserveAffect

This patch only changes the prototype for
C4::Reserves::ModReserveAffect.
This modification will allow to simplify future changes.
No change should be expected with this patch.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:10:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 16:10:00 +0000
Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly
In-Reply-To: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10827-70-k8uc9elR0h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25944|0                           |1
        is obsolete|                            |

--- Comment #33 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 36813
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36813&action=edit
Bug 10827: Check if the item should be transfered in ModReserveAffect

Before this patch, ModReserveAffect should know if the item have to be
transfered. Now it is checked in the routine.

Moreover, it is possible to pass an item key in parameters.
If it is not given, the item's information is retrieved from
GetBiblioFromItemNumber.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:10:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 16:10:06 +0000
Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly
In-Reply-To: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10827-70-b24SjjJt9N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25945|0                           |1
        is obsolete|                            |

--- Comment #34 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 36814
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36814&action=edit
Bug 10827: Update item-level holds if deletion

If a lower level priority hold is deleted, the next on the list should
be marked as 'waiting' and the patron notified.

This patch only affects item-level holds.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:10:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 16:10:13 +0000
Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly
In-Reply-To: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10827-70-0sNWJg3uso@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25946|0                           |1
        is obsolete|                            |

--- Comment #35 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 36815
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36815&action=edit
Bug 10827: destBranch tt param is useless

With previous changes, the destBranch passed to the template become
useless and can be removed.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:12:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 16:12:50 +0000
Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly
In-Reply-To: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10827-70-uZYeMPQTkd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:14:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 16:14:05 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-STD8zk8P0X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Ok so, I tried to be sure no regression is added:

$ git checkout bug_13794
$ cd misc/translator
$ perl update es-ES
$ perl install es-ES
$ cp -r po/es-ES-i-staff-t-prog-v-3006000.po po/es-ES-opac-bootstrap.po
po/es-ES-pref.po po/es-ES-staff-help.po
../../koha-tmpl/intranet-tmpl/prog/es-ES/
../../koha-tmpl/opac-tmpl/bootstrap/es-ES /tmp/test_bug_13794
$ cd /tmp/test_bug_13794
$ git init;git add .; git commit -m"something"
# back in my koha src
$ git checkout master
$ cd misc/translator
$ perl update es-ES
$ perl install es-ES
$ cp -r po/es-ES-i-staff-t-prog-v-3006000.po po/es-ES-opac-bootstrap.po
po/es-ES-pref.po po/es-ES-staff-help.po
../../koha-tmpl/intranet-tmpl/prog/es-ES/
../../koha-tmpl/opac-tmpl/bootstrap/es-ES /tmp/test_bug_13794
$ cd /tmp/test_bug_13794
$ git diff | grep input | grep text | grep value | grep -v 'value=""' | grep -v
'value="\[\%'| vim -

gives me the following:

 id="start_card" class="focus" title="N?mero de carn? de inicio" size="5"
name="start_card" value="1" />
- <label class="inline" for="basename">Nombre: </label> <input name="basename"
value="Exportar" id="basename" type="text" />
+ <label class="inline" for="basename">Nombre: </label> <input type="text"
name="basename" id="basename" value="Export" />
- <label class="inline" for="basename">Nombre: </label><input value="Exportar"
name="basename" id="basename" type="text" />
+ <label class="inline" for="basename">Nombre: </label><input type="text"
name="basename" id="basename" value="Export" />
- <label class="inline" for="basename">Nombre: </label><input name="basename"
value="Exportar" id="basename" type="text" />
+ <label class="inline" for="basename">Nombre: </label><input type="text"
name="basename" id="basename" value="Export" />
- <label class="inline" for="basename">Nombre: </label><input type="text"
id="basename" value="Exportar" name="basename" />
+ <label class="inline" for="basename">Nombre: </label><input type="text"
name="basename" id="basename" value="Export" />
- <label class="inline" for="basename">Nombre: </label><input value="Exportar"
name="basename" id="basename" type="text" />
+ <label class="inline" for="basename">Nombre: </label><input type="text"
name="basename" id="basename" value="Export" />
- <label class="inline" for="basename">Nombre: </label><input name="basename"
value="Exportar" id="basename" type="text" />
+ <label class="inline" for="basename">Nombre: </label><input type="text"
name="basename" id="basename" value="Export" />
- <label class="inline" for="basename">Nombre: </label><input value="Exportar"
name="basename" id="basename" type="text" />
+ <label class="inline" for="basename">Nombre: </label><input type="text"
name="basename" id="basename" value="Export" />
- <label class="inline" for="basename">Nombre: </label><input value="Exportar"
name="basename" id="basename" type="text" />
+ <label class="inline" for="basename">Nombre: </label><input type="text"
name="basename" id="basename" value="Export" />
- <label class="inline" for="basename">Nombre: </label><input name="basename"
value="Exportar" id="basename" type="text" />
+ <label class="inline" for="basename">Nombre: </label><input type="text"
name="basename" id="basename" value="Export" />
- <label class="inline" for="basename">Nombre: </label><input name="basename"
value="Exportar" type="text" id="basename" />
+ <label class="inline" for="basename">Nombre: </label><input type="text"
name="basename" id="basename" value="Export" />
  con valor <input type="text" name="field_value" id="field_value" />
- <input value="Exportar" name="basename" type="text" id="basename" />
+ <input type="text" name="basename" id="basename" value="Export" />  

All looks good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:14:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 16:14:52 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-bvRe2u1wo1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 17:14:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 16:14:55 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-VUVtKB3O5y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36767|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36816
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36816&action=edit
Bug 13794: Text input field values not translated

I left the code logic intact, and simply removed "text" from the regex.
Text input field values are now translated, no other logical changes are
introduced.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Test:
1) Update, install and enable es-ES language
2) Go to Reports > Acquisition wizard
3) On page bottom, there is a text field with the word 'Export'
4) Switch language, the word is not translated
5) Apply the patch
6) Update and install again es-ES language
7) Reload page, text now reads 'Exportar'

No koha-qa errors.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:04:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:04:41 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-N4htAzJJGU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #77 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36817
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36817&action=edit
Bug 12648: Add some documentation on the kohastructure.sql file

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:09:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:09:41 +0000
Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label
	Printing
In-Reply-To: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10773-70-mcdPmZBCB2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I would say this is an enhancement. But, anyway, Chris N. is about to post a
followup with regression tests, so I'll be holding this until then.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:20:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:20:05 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-9O2kJgjNfH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #17 from simith.doliveira at inlibro.com ---
Created attachment 36818
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36818&action=edit
Fix koha plugin to access system pref. and EnhancedMessagingPreferences
description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:24:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:24:46 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
 to patrons on the OPAC
In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12528-70-2euQyEsuR4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:25:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:25:44 +0000
Subject: [Koha-bugs] [Bug 13785] koha-disable should also stop
 SIP/Zebra/Indexer for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-6APSxeCiR0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Koha-disable should also    |koha-disable should also
                   |stop SIP and zebra for      |stop SIP/Zebra/Indexer for
                   |instance                    |instance
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:39:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:39:31 +0000
Subject: [Koha-bugs] [Bug 12648] Link patrons to an order
In-Reply-To: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12648-70-4bVtlMePeK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #78 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Good job Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:40:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:40:07 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-9EgUHwU4B5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Bernardo! We are getting closer!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:40:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:40:35 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-yU4vYBZM8u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:40:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:40:59 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-aQUgonSnyt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Pasi!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:41:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:41:25 +0000
Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name
 on patron details
In-Reply-To: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13657-70-nCFGFsWOrf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:58:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:58:17 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-rTYsvkiLXB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29111|0                           |1
        is obsolete|                            |

--- Comment #75 from simith.doliveira at inlibro.com ---
Created attachment 36819
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36819&action=edit
Bug 8753 - Add forgot password link to OPAC

 This redo includes the following
 - usage of the template letters for the email instead of a .tt (that feature
didn't exist when the functionnality was initially coded for our client)
 - removal of the prog version
 - removal of the code that was initially put into Members.pm
 - Added a letter into updatedatabase.pl and sample_notices.sql
 - Of course, rebase to latest master.

 The rest remain unchanged since the previous comments/approvals.  As such,
what worked before should still work.

 TEST PLAN:

 1) apply the patch
 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 
That will cause the link 'Forgot yo
    2b) make sure that OpacPasswordChange is also ON.
 3) refresh front page, click on 'Forgot your password' and enter a VALID
address (one that is associated to an en
    3b) Also try an INVALID address (valid yet not in your koha db).  An error
message will show up.
 4) An email should be received at that address with a link.
 5) Follow the link in the mail to fill the new password.
    Until a satisfactory new password is entered, the old password is not
reset.
  6) Go to main page try the new password.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:59:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:59:02 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-Z604VR86Yl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34472|0                           |1
        is obsolete|                            |

--- Comment #76 from simith.doliveira at inlibro.com ---
Comment on attachment 34472
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34472
SQL code in the .pl files removed. New .pm and .t files created.

>From b775b68292a4c9757f7d0b93d2675d9165c18cc4 Mon Sep 17 00:00:00 2001
>From: simith <simith at inlibro.com>
>Date: Tue, 16 Dec 2014 13:22:26 -0500
>Subject: [PATCH] SQL code in the .pl files removed. New .pm and .t files
> created.
>
>http://bugs.koha-community.org/show_bug.cgi?id=8753
>---
> C4/Passwordrecovery.pm                             | 159 +++++++++++++++++++++
> .../data/mysql/en/mandatory/sample_notices.sql     |   2 +-
> opac/opac-password-recovery.pl                     | 100 ++-----------
> 3 files changed, 173 insertions(+), 88 deletions(-)
> create mode 100644 C4/Passwordrecovery.pm
>
>diff --git a/C4/Passwordrecovery.pm b/C4/Passwordrecovery.pm
>new file mode 100644
>index 0000000..f1b26e9
>--- /dev/null
>+++ b/C4/Passwordrecovery.pm
>@@ -0,0 +1,159 @@
>+package C4::Passwordrecovery;
>+
>+# Copyright 2014 PTFS Europe
>+#
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+use C4::Context;
>+
>+use vars qw($VERSION @ISA @EXPORT);
>+
>+BEGIN {
>+    # set the version for version checking
>+    $VERSION = 3.07.00.049;
>+    require Exporter;
>+    @ISA    = qw(Exporter);
>+    push @EXPORT, qw(
>+        &ValidateBorrowernumber
>+        &SendPasswordRecoveryEmail
>+        &GetValidLinkInfo
>+    );
>+}
>+
>+=head1 NAME
>+
>+C4::Passwordrecovery - Koha password recovery module
>+
>+=head1 SYNOPSIS
>+
>+use C4::Passwordrecovery;
>+
>+=head1 FUNCTIONS
>+
>+=head2 ValidateBorrowernumber
>+
>+$alread = ValidateBorrowernumber( $borrower_number );
>+
>+Check if the system already start recovery
>+
>+Returns true false
>+
>+=cut
>+
>+sub ValidateBorrowernumber {
>+    my ($borrower_number) = @_;
>+    my $schema = Koha::Database->new->schema;
>+
>+    my $rs = $schema->resultset('BorrowerPasswordRecovery')->search(
>+    {
>+       borrowernumber => $borrower_number,
>+       valid_until => \'> NOW()'
>+    }, {
>+        columns => 'borrowernumber'
>+    });
>+
>+    if ($rs->next){
>+        return 1;
>+    }
>+
>+    return 0;
>+}
>+
>+=head2 GetValidLinkInfo
>+
>+    Check if the link is still valid and return some info.
>+
>+=cut
>+
>+sub GetValidLinkInfo {
>+    my ($uniqueKey) = @_;
>+    my $dbh = C4::Context->dbh;
>+    my $query = '
>+    SELECT borrower_password_recovery.borrowernumber, userid
>+    FROM borrower_password_recovery, borrowers
>+    WHERE borrowers.borrowernumber = borrower_password_recovery.borrowernumber
>+    AND NOW() < valid_until
>+    AND uuid = ?
>+    ';
>+    my $sth = $dbh->prepare($query);
>+    $sth->execute($uniqueKey);
>+    return $sth->fetchrow;
>+}
>+
>+=head2 SendPasswordRecoveryEmail
>+
>+ It creates an email using the templates and send it to the user, using the specified email
>+
>+=cut
>+
>+sub SendPasswordRecoveryEmail {
>+    my $borrower = shift; # from GetMember
>+    my $userEmail = shift; #to_address (the one specified in the request)
>+    my $protocol = shift; #only required to determine if 'http' or 'https'
>+    my $update = shift;
>+
>+    my $schema = Koha::Database->new->schema;
>+
>+    # generate UUID
>+    my @chars = ("A".."Z", "a".."z", "0".."9");
>+    my $uuid_str;
>+    $uuid_str .= $chars[rand @chars] for 1..32;
>+
>+    # insert into database
>+    my $expirydate = DateTime->now(time_zone => C4::Context->tz())->add( days => 2 );
>+    if($update){
>+        my $rs = $schema->resultset('BorrowerPasswordRecovery')->search(
>+        {
>+            borrowernumber => $borrower->{'borrowernumber'},
>+        });
>+        $rs->update({uuid => $uuid_str, valid_until => $expirydate->datetime()});
>+    } else {
>+         my $rs = $schema->resultset('BorrowerPasswordRecovery')->create({
>+            borrowernumber=>$borrower->{'borrowernumber'},
>+            uuid => $uuid_str,
>+            valid_until=> $expirydate->datetime()
>+         });
>+    }
>+
>+    # create link
>+    my $uuidLink = $protocol . C4::Context->preference( 'OPACBaseURL' ) . "/cgi-bin/koha/opac-password-recovery.pl?uniqueKey=$uuid_str";
>+
>+    # prepare the email
>+    my $letter = C4::Letters::GetPreparedLetter (
>+        module => 'members',
>+        letter_code => 'PASSWORD_RESET',
>+        branchcode => $borrower->{branchcode},
>+        substitute => {passwordreseturl => $uuidLink, user => $borrower->{userid} },
>+    );
>+
>+    # define to/from emails
>+    my $kohaEmail = C4::Context->preference( 'KohaAdminEmailAddress' ); # from
>+
>+    C4::Letters::EnqueueLetter( {
>+         letter => $letter,
>+         borrowernumber => $borrower->{borrowernumber},
>+         to_address => $userEmail,
>+         from_address => $kohaEmail,
>+         message_transport_type => 'email',
>+    } );
>+
>+    return 1;
>+}
>+
>+END { }    # module clean-up code here (global destructor)
>+
>+1;
>\ No newline at end of file
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.sql b/installer/data/mysql/en/mandatory/sample_notices.sql
>index 37e9d9f..67c8b34 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.sql
>+++ b/installer/data/mysql/en/mandatory/sample_notices.sql
>@@ -144,5 +144,5 @@ Your library.'
> );
> 
> INSERT INTO `letter` (module, code, branchcode, name, is_html, title, content, message_transport_type)
>-VALUES ('members','PASSWORD_RESET','','Online password reset',1,'Koha password recovery','<html>\r\n<p>This email has been sent in response to your password recovery request for the account <strong><< borrowers.userid>></strong>.\r\n</p>\r\n<p>\r\nYou can now create your new password using the following link:\r\n<br/><a href=\"<<passwordreseturl>>\"><<passwordreseturl>></a>\r\n</p>\r\n<p>This link will be valid for 2 days from this email\'s reception, then you must reapply if you do not change your password.</p>\r\n<p>Thank you.</p>\r\n</html>\r\n','email'
>+VALUES ('members','PASSWORD_RESET','','Online password reset',1,'Koha password recovery','<html>\r\n<p>This email has been sent in response to your password recovery request for the account <strong><<user>></strong>.\r\n</p>\r\n<p>\r\nYou can now create your new password using the following link:\r\n<br/><a href=\"<<passwordreseturl>>\"><<passwordreseturl>></a>\r\n</p>\r\n<p>This link will be valid for 2 days from this email\'s reception, then you must reapply if you do not change your password.</p>\r\n<p>Thank you.</p>\r\n</html>\r\n','email'
> );
>diff --git a/opac/opac-password-recovery.pl b/opac/opac-password-recovery.pl
>index 27c8ea6..b5cd2c2 100755
>--- a/opac/opac-password-recovery.pl
>+++ b/opac/opac-password-recovery.pl
>@@ -9,6 +9,7 @@ use C4::Koha;
> use C4::Members qw(changepassword GetMember GetMemberDetails );
> use C4::Output;
> use C4::Context;
>+use C4::Passwordrecovery qw(SendPasswordRecoveryEmail ValidateBorrowernumber GetValidLinkInfo);
> use Koha::AuthUtils qw(hash_password);
> my $query = new CGI;
> use HTML::Entities;
>@@ -44,11 +45,8 @@ my $errLinkNotValid;
> my $errPassNotMatch;
> my $errPassTooShort;
> 
>-my $dbh = C4::Context->dbh;
>-
> if ( $query->param('sendEmail') || $query->param('resendEmail') ) {
>-    #send mail + confirmation
>-
>+    my $protocol = $query->https() ? "https://" : "http://";
>     #try with the main email
>     $email ||= ''; # avoid undef
>     my $borrower_infos = GetMember( email => $email );
>@@ -63,11 +61,9 @@ if ( $query->param('sendEmail') || $query->param('resendEmail') ) {
>         $errNoEmailFound = 1;
>     }
>     elsif ( !$query->param('resendEmail') ) {
>-        my $sth = $dbh->prepare(
>-"SELECT borrowernumber FROM borrower_password_recovery WHERE NOW() < valid_until AND borrowernumber = ?"
>-        );
>-        $sth->execute($borrower_number);
>-        if ( my $already = $sth->fetchrow ) {
>+        my $already = ValidateBorrowernumber( $borrower_number );
>+
>+        if ( $already ) {
>             $hasError                = 1;
>             $errAlreadyStartRecovery = 1;
>         }
>@@ -82,7 +78,7 @@ if ( $query->param('sendEmail') || $query->param('resendEmail') ) {
>             email                   => HTML::Entities::encode($email),
>         );
>     }
>-    elsif ( SendPasswordRecoveryEmail( $borrower_infos, $email, $query, $query->param('resendEmail') ) ) {#generate uuid and send recovery email
>+    elsif ( SendPasswordRecoveryEmail( $borrower_infos, $email, $protocol, $query->param('resendEmail') ) ) {#generate uuid and send recovery email
>         $template->param(
>             mail_sent => 1,
>             email     => $email
>@@ -96,18 +92,7 @@ if ( $query->param('sendEmail') || $query->param('resendEmail') ) {
>     }
> }
> elsif ( $query->param('passwordReset') ) {
>-    #new password form
>-    #check if the link is still valid
>-    my $sth = $dbh->prepare(
>-        "SELECT borrower_password_recovery.borrowernumber, userid
>-                              FROM borrower_password_recovery, borrowers
>-                              WHERE borrowers.borrowernumber = borrower_password_recovery.borrowernumber
>-                              AND NOW() < valid_until
>-                              AND uuid = ?"
>-    );
>-    $sth->execute($uniqueKey);
>-    ( $borrower_number, $username ) = $sth->fetchrow;
>-
>+    ( $borrower_number, $username ) = GetValidLinkInfo($uniqueKey);
>     #validate password length & match
>     if (   ($borrower_number)
>         && ( $password eq $repeatPassword )
>@@ -116,8 +101,9 @@ elsif ( $query->param('passwordReset') ) {
>         changepassword( $username, $borrower_number, hash_password($password) );
> 
>         #remove entry
>-        my $sth = $dbh->prepare("DELETE FROM borrower_password_recovery WHERE uuid = ? or NOW() > valid_until");
>-        $sth->execute($uniqueKey);
>+        my $schema = Koha::Database->new->schema;
>+        my $rs = $schema->resultset('BorrowerPasswordRecovery')->search({-or => [uuid => $uniqueKey, valid_until => \'< NOW()']});
>+        $rs->delete;
> 
>         $template->param(
>             password_reset_done => 1,
>@@ -148,19 +134,12 @@ elsif ( $query->param('passwordReset') ) {
> }
> elsif ($uniqueKey) {  #reset password form
>     #check if the link is valid
>-    my $sth = $dbh->prepare(
>-        "SELECT borrower_password_recovery.borrowernumber, userid
>-                              FROM borrower_password_recovery, borrowers
>-                              WHERE borrowers.borrowernumber = borrower_password_recovery.borrowernumber
>-                              AND NOW() < valid_until
>-                              AND uuid = ?"
>-    );
>-    $sth->execute($uniqueKey);
>-    ( $borrower_number, $username ) = $sth->fetchrow;
>+    ( $borrower_number, $username ) = GetValidLinkInfo($uniqueKey);
>+
>     if ( !$borrower_number ) {
>         $errLinkNotValid = 1;
>     }
>-warn "INLIBRO username $username";
>+
>     $template->param(
>         new_password    => 1,
>         minPassLength   => $minPassLength,
>@@ -175,56 +154,3 @@ else { #password recovery form (to send email)
> }
> 
> output_html_with_http_headers $query, $cookie, $template->output;
>-
>-#
>-# It creates an email using the templates and send it to the user, using the specified email
>-#
>-sub SendPasswordRecoveryEmail {
>-    my $borrower = shift; # from GetMember
>-    my $userEmail = shift; #to_address (the one specified in the request)
>-    my $query = shift; #only required to determine if 'http' or 'https'
>-    my $update = shift;
>-
>-    my $dbh = C4::Context->dbh;
>-
>-    # generate UUID
>-    my @chars = ("A".."Z", "a".."z", "0".."9");
>-    my $uuid_str;
>-    $uuid_str .= $chars[rand @chars] for 1..32;
>-
>-    # insert into database
>-    my $expirydate = DateTime->now(time_zone => C4::Context->tz())->add( days => 2 );
>-    if($update){
>-       my $sth = $dbh->prepare( 'UPDATE borrower_password_recovery set uuid=?, valid_until=? where borrowernumber=? ');
>-       $sth->execute($uuid_str, $expirydate->datetime(), $borrower->{'borrowernumber'});
>-    } else {
>-       my $sth = $dbh->prepare( 'INSERT INTO borrower_password_recovery VALUES (?, ?, ?)');
>-       $sth->execute($borrower->{'borrowernumber'}, $uuid_str, $expirydate->datetime());
>-    }
>-
>-    # create link
>-    my $protocol = $query->https() ? "https://" : "http://";
>-    my $uuidLink = $protocol . C4::Context->preference( 'OPACBaseURL' ) . "/cgi-bin/koha/opac-password-recovery.pl?uniqueKey=$uuid_str";
>-
>-    # prepare the email
>-    my $letter = C4::Letters::GetPreparedLetter (
>-        module => 'members',
>-        letter_code => 'PASSWORD_RESET',
>-        branchcode => $borrower->{branchcode},
>-        tables => {borrowers => $borrower},
>-        substitute => {passwordreseturl => $uuidLink},
>-    );
>-
>-    # define to/from emails
>-    my $kohaEmail = C4::Context->preference( 'KohaAdminEmailAddress' ); # from
>-
>-    C4::Letters::EnqueueLetter( {
>-         letter => $letter,
>-         borrowernumber => $borrower->{'borrowernumber'},
>-         to_address => $userEmail,
>-         from_address => $kohaEmail,
>-         message_transport_type => 'email',
>-    } );
>-
>-    return 1;
>-}
>-- 
>1.9.1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:59:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:59:19 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-xsZJSA7X5J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33176|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 18:59:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 17:59:34 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-ybn3Wfejph@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33175|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:02:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 18:02:53 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-0iQ5SMbqcF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #77 from simith.doliveira at inlibro.com ---
Sorry for #76

Conflit fixed and patches squashed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:04:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 18:04:22 +0000
Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines
In-Reply-To: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11430-70-Xq8bheCNR8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430

--- Comment #76 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36820
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36820&action=edit
Bug 11430: (QA followup) small typos in kohastructure.sql

?d (note the accent) is not a good column name :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:04:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 18:04:55 +0000
Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines
In-Reply-To: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11430-70-67JIBBqwkV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430

--- Comment #77 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36821
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36821&action=edit
Bug 11430: (RM followup) DBIx schema update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:11:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 18:11:31 +0000
Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines
In-Reply-To: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11430-70-ZXBmoPQhOe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430

--- Comment #78 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36822
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36822&action=edit
Bug 11430: (QA followup) we test for warnings, always

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:17:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 18:17:09 +0000
Subject: [Koha-bugs] [Bug 13785] koha-disable should also stop
 SIP/Zebra/Indexer for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-bJwZzwFGpo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Larry!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:18:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 18:18:38 +0000
Subject: [Koha-bugs] [Bug 11430] Search history: Delete selected lines
In-Reply-To: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11430-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11430-70-Svo8CQbh32@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #79 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:20:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 18:20:05 +0000
Subject: [Koha-bugs] [Bug 13578] Parameter public is lost on creating a
	report
In-Reply-To: <bug-13578-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13578-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13578-70-ypX7QVMZIm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13578

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonthan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:31:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 18:31:54 +0000
Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack
In-Reply-To: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13805-70-9C4BvobVxD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |mirko at abunchofthings.net

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
So, is the patch to be tested as is or going to be changed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:45:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 18:45:31 +0000
Subject: [Koha-bugs] [Bug 13607] Patron management API
In-Reply-To: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13607-70-sgBUZls5BP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

--- Comment #18 from Mirko Tietgen <mirko at abunchofthings.net> ---
I have played with this a little and I like it. Works for me so far, will try
to break it some more.

I think userid (for account login) is automatically created from
'firstname'.'surname' if not explicitly given (in the staff client), I wonder
if that should be the same here for consinstency (personally I don't mind).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 19:51:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 18:51:03 +0000
Subject: [Koha-bugs] [Bug 13823] New: item search should include note fields
Message-ID: <bug-13823-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13823

            Bug ID: 13823
           Summary: item search should include note fields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

It would be great if the item search in the staff client included the notes
fields on the item record (both public and non public).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 20:47:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 19:47:05 +0000
Subject: [Koha-bugs] [Bug 13824] New: Print notices message_queue.status
 defaults to Pending for patrons without e-mail
Message-ID: <bug-13824-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13824

            Bug ID: 13824
           Summary: Print notices message_queue.status defaults to Pending
                    for patrons without e-mail
 Change sponsored?: ---
           Product: Koha
           Version: 3.16
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: danielle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The status of notices that are sent to be printed (no e-mail for patrons)
defaults to PENDING. 

There should be a way to edit this or a trigger that updates the status to
something different than PENDING for message_queue.status field of notices not
e-mailed.  

If a library could edit this for print notices, or even if it said "SENT TO
PRINT" it would be helpful to librarians to know something happened to the
notice instead of sitting in the message queue, which it appears to be with
PENDING.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 20:51:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 19:51:30 +0000
Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
In-Reply-To: <bug-12747-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12747-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12747-70-TIc0Rwq5bH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #4 from simith.doliveira at inlibro.com ---
Created attachment 36823
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36823&action=edit
Fix table cell

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 20:52:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 19:52:06 +0000
Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
In-Reply-To: <bug-12747-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12747-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12747-70-rOqe0m1yfn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from simith.doliveira at inlibro.com ---
Table cell fixed 

Owen #2 "why there is no corresponding change to cataloguing/z3950_search.pl?
- Our sponsor (CCSR) did not ask for it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 23:57:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 22:57:04 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-O19ID4BOII@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 11 23:57:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 22:57:55 +0000
Subject: [Koha-bugs] [Bug 13821] Add possibility to select more than one
 department on a course reserve
In-Reply-To: <bug-13821-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13821-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13821-70-RlkLV2Uxme@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13821

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:20:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:20:08 +0000
Subject: [Koha-bugs] [Bug 13825] New: can't use profile more than one time
Message-ID: <bug-13825-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13825

            Bug ID: 13825
           Summary: can't use profile more than one time
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

You can't use the same printer profile for different label templates.  I had to
create a new identical printer profile while I was creating a new template even
tho all of the settings were identical (the existing printer profile was not
available via the drop-down menu).

Seems like an oversight - usually you're using the same printer for all your
labels so you should be able to reuse the profile.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:20:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:20:17 +0000
Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in
 ISSUESLIP and ISSUEQSLIP
In-Reply-To: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13819-70-fWPOfwyBJU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819

--- Comment #1 from Barton Chittenden <barton at bywatersolutions.com> ---
Created attachment 36824
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36824&action=edit
Add biblioitems to ISSUESLIP and ISSUEQSLIP in C4::Members::IssueSlip()

Document all expansions within  C4::Members::IssueSlip()

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:22:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:22:08 +0000
Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in
 ISSUESLIP and ISSUEQSLIP
In-Reply-To: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13819-70-0T3us7LIzX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |barton at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:23:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:23:11 +0000
Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in
 ISSUESLIP and ISSUEQSLIP
In-Reply-To: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13819-70-3Lgq0z3HKd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:43:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:43:16 +0000
Subject: [Koha-bugs] [Bug 13434] 586 XSLT improvements
In-Reply-To: <bug-13434-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13434-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13434-70-OIuNfVwsjb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:44:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:44:18 +0000
Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs
In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13734-70-PkCwYUfnp9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 36825
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36825&action=edit
Example MARC

Here a few records with 33x fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:44:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:44:49 +0000
Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in
	XSLT
In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13387-70-eh5nUCkZ4y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nengard at gmail.com           |wsalesky at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:46:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:46:36 +0000
Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
In-Reply-To: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13381-70-1kvIsty47b@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nengard at gmail.com           |wsalesky at gmail.com
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:47:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:47:08 +0000
Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT
In-Reply-To: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13386-70-DoJyPyTTX6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
           Assignee|nengard at gmail.com           |wsalesky at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:47:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:47:29 +0000
Subject: [Koha-bugs] [Bug 13385] RDA: 508 display in XSLT
In-Reply-To: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13385-70-767WPpgKyq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
           Assignee|nengard at gmail.com           |wsalesky at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:47:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:47:56 +0000
Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
In-Reply-To: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13382-70-1ZvuxENA2g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 00:48:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 11 Mar 2015 23:48:23 +0000
Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT
In-Reply-To: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13433-70-hNakSRCdUD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |wsalesky at gmail.com
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 01:31:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 00:31:48 +0000
Subject: [Koha-bugs] [Bug 13607] Patron management API
In-Reply-To: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13607-70-PlMFcIMKsk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

--- Comment #19 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Mirko Tietgen from comment #18)
> I have played with this a little and I like it. Works for me so far, will
> try to break it some more.
> 
> I think userid (for account login) is automatically created from
> 'firstname'.'surname' if not explicitly given (in the staff client), I
> wonder if that should be the same here for consinstency (personally I don't
> mind).

I kinda feel like for an API things should in general be made to be more
explicit. But I'm not particularly hung up on the idea either way.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 07:48:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 06:48:03 +0000
Subject: [Koha-bugs] [Bug 13826] New: OPAC: Display RSS icon on list of
	recent Comments
Message-ID: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

            Bug ID: 13826
           Summary: OPAC: Display RSS icon on list of recent Comments
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org

'Recent comments' supports RSS, but does not display an RSS icon on the page
(similar to search results page).

To reproduce:

1)
Enable display of 'Recent comments' in OPAC (Syspref OpacShowRecentComments)
2)
In OPAC, go to Home > Recent comments
3)
Verify that there is a link in the head part of the HTML source code (<link
rel="alternate" type="application/rss+xml"....), but no RSS icon on the pate
itself (like in search results).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 07:59:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 06:59:41 +0000
Subject: [Koha-bugs] [Bug 13473] Plugins fail when loading templates
In-Reply-To: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13473-70-kotlPp66DU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:03:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:03:40 +0000
Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in
	koha-indexer
In-Reply-To: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13753-70-CTgkhZgivt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:05:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:05:19 +0000
Subject: [Koha-bugs] [Bug 13826] OPAC: Display RSS icon on list of recent
	comments
In-Reply-To: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13826-70-vz6sxxh6vh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|OPAC: Display RSS icon on   |OPAC: Display RSS icon on
                   |list of recent Comments     |list of recent comments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:07:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:07:31 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-st1j8Bf8se@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:09:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:09:34 +0000
Subject: [Koha-bugs] [Bug 13826] OPAC: Display RSS icon on list of recent
	comments
In-Reply-To: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13826-70-Tifx3S0csF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 36826
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36826&action=edit
Bug 13826 - OPAC: Display RSS icon on list of recent comments

This patch adds RSS icon to OPAC page 'Recent comments'

To test:
1)
Enable display of 'Recent comments' in OPAC (Syspref OpacShowRecentComments)
2)
In OPAC, go to Home > Recent comments
3)
Verify that there is a link in the head part of the HTML source code (<link
rel="alternate" type="application/rss+xml"....), but no RSS icon on the pate
itself (like in search results).
4)
Apply patch
Result: Icon with link to RSS feed is displayed  next to title.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:10:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:10:13 +0000
Subject: [Koha-bugs] [Bug 13826] OPAC: Display RSS icon on list of recent
	comments
In-Reply-To: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13826-70-3mh6UgcNGG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:11:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:11:25 +0000
Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable
In-Reply-To: <bug-13741-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13741-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13741-70-CCSWDOChNC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:12:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:12:31 +0000
Subject: [Koha-bugs] [Bug 13745] Serial collection page shows branchcode
 instead of branchname
In-Reply-To: <bug-13745-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13745-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13745-70-XYe9cQlFhR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13745

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:14:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:14:59 +0000
Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save
In-Reply-To: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13731-70-Ci1buPN99t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:16:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:16:49 +0000
Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additional
	checkin)
In-Reply-To: <bug-9848-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9848-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9848-70-35CkeupVbM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #14 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:18:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:18:58 +0000
Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts
In-Reply-To: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13605-70-bpmjRiHfbK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:21:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:21:14 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-XAB6cULOyT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:26:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:26:18 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-CL8CNp7kid@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 08:57:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 07:57:48 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-1uXXNEJZKk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Chris Cormack from comment #12)
> Pushed to 3.18.x will be in 3.18.5

It introduces regression in 3.18.x, the facet is not selected anymore.
To reproduce:
- At the opac, search for something
- click on the author facet '<a>Goupy, Xavier</a>'
- the facet is correctly selected (Goupy, Xavier [<a>x</a>])
- search for something again
- click on the author facet '<a>Leblanc, St?phane</a>'
- the facet is not correctly selected (<a>Leblanc, St?phane</a>)

Note: Without this patch, the only issue on facet is the title of the [x] link
(<a title="Remove facet Leblanc%2C%20St%C3%A9phane">x</a>)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:01:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 08:01:33 +0000
Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters
 generate double encoded links
In-Reply-To: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13789-70-Vk7zQ8TQ0D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |Pushed to Master

--- Comment #14 from Chris Cormack <chris at bigballofwax.co.nz> ---
Good catch, reverted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:15:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 08:15:57 +0000
Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack
In-Reply-To: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13805-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13805-70-fj1X3OuFBl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
The Dobrica's solution does not seem to work for this issue.
I have the same double login issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:30:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 08:30:09 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-zi0xOLHyo9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 36827
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36827&action=edit
Bug 13813 - Remove deprecated C4::Dates from opac/opac-showreviews.pl

To test:

This patch removes C4::Dates from opac/opac-showreviews.pl and treats the RSS
time stamps the same way as in opac/opac-search.pl

To test:
- Enable display of 'Recent comments' in OPAC (Syspref OpacShowRecentComments)
- In OPAC, go to Home > Recent comments
- Test RSS feed
- Apply patch
- Test RSS feed again, it should work as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 09:37:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 08:37:36 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-qwPdn27WGM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Note: Patch "Bug 13813 - Remove deprecated C4::Dates from
opac/opac-showreviews.pl" does not depend from Bug 13601

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:23:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 09:23:38 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-D0IUqkSV8Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 36828
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36828&action=edit
Bug 13813 - Remove C4::Dates from members/readingrec.pl

This patch removes depraceted C4::Dates from members/readingrec.pl

To test:

Apply patch
Go to a patron's cirulation history
Verify that circulation history behaves as before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 10:54:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 09:54:49 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-zmKWkZNK8o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 36829
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36829&action=edit
Bug 13813 - Remove C4::Dates from C4/Items.pm

This patch removes depraceted C4::Dates from C4/Items.pm
To test:

Apply patch

To test:
Add modify items. Checkout added item.
Verify that item handling works as before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 12:47:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 11:47:29 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-cuty7kEmHC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 36830
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36830&action=edit
Bug 13813 - Remove C4::Dates from overdue_notices.pl

This patch removes depraceted C4::Dates from misc/cronjobs/overdue_notices.pl

To test:
Apply patch
Run misc/cronjobs/overdue_notices.pl
Verify that dates appear in notices as before (following syspref 'dateformat')

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 13:09:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 12:09:03 +0000
Subject: [Koha-bugs] [Bug 13825] can't use profile more than one time
In-Reply-To: <bug-13825-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13825-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13825-70-6bHxAnMRMq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13825

--- Comment #1 from Chris Nighswonger <cnighswonger at foundations.edu> ---
This is by design.

Profiles are unique to a template/printer combination. (In DB language,
profile-template-printer form a unique key.)

Each type of label will most likely need adjusting for each printer it is
printed on. For example: An Avery 5160 will need different tweaks to print
correctly on printer A than the Brodart 55459003 (or even the Demco WS14942260)
will on the same printer. Likewise, the Avery 5160 will probably need different
adjustments for use on printer B than on printer A.

We could certainly remove this requirement, but I wonder how often this is an
issue? I'd like to have a wider discussion before changing it. Maybe we can ask
for some feedback on the user list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:40:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 13:40:57 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-TeNuVji1wN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
Created attachment 36831
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36831&action=edit
Bug 13813 - Remove C4::Dates from C4/Acquisition.pm

This patch removes depraceted C4::Dates from C4/Acquisition.pm

To test:
Apply patch
Go to Home > Acquisitions
Verify that receiving orders works as before (Receiving orders only affected by
this patch)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:53:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 13:53:34 +0000
Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip
	are broken
In-Reply-To: <bug-12847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12847-70-xtlBREAI76@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
I can no longer reproduce this issue. It appears to be fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:54:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 13:54:25 +0000
Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha
	objects
In-Reply-To: <bug-13019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13019-70-G0xnx8Xz3J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #61 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Just wanted to say that good job with this one Kyle!
I just subclassed a subclass of one of your Koha::Objects :)
Works like a charm!
I updated the wiki page for that regard.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 14:55:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 13:55:30 +0000
Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify
	a DB table
In-Reply-To: <bug-12368-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12368-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12368-70-dt5Blw2x6Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

--- Comment #11 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
I tend to agree with Jonathan on this one:

  - It's better not to increase execution time when not needed.

  - This patch does not add that much complexity.

  - Wouldn't it add approximatively the same amount of complexity if using an
inner joint?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:03:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 14:03:58 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-e9YKRJ9mrZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Created attachment 36832
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36832&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from C4/HoldsQueue.pm

To test:
Apply patch
Make sure that C4::Dates is not used in C4/HoldsQueue.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:23:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 14:23:54 +0000
Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull'
	notices
In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8352-70-ztRdS3ph4B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:23:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 14:23:57 +0000
Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull'
	notices
In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8352-70-CrO6qMh3YR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28333|0                           |1
        is obsolete|                            |
  Attachment #28654|0                           |1
        is obsolete|                            |

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36833
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36833&action=edit
Bug 8352 - Add automatic printing of 'hold to pull' notices

Adds the ability to have a notice printed automatically
after a hold has been placed.

The system has the ability to define a separate printer
for each branchcode, so each library can receive a printed
notice for any holds placed, assuming they have set up the
ability to print over the LAN, WAN, or Internet. Notices are
printed to the pickup library.

Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:24:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 14:24:05 +0000
Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull'
	notices
In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8352-70-NULa3tZML1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36834
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36834&action=edit
Bug 8352 - Add printer administration, update script to use Koha defined
printers

This patch adds the ability to define printers within Koha. The printer
CRUD is based on the code for the quote of the day system.

This patch extends the existing ability to print via LPR to any network
printer with the added ability to print to a CUPS printer configured on
the Koha server.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Browse to admin/printers.pl
4) Configure a network printer via LPR ( explained in the printers help )
5) Create a hold
6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer
$BRANCHCODE=$PRINTER_ID
   where branchcode is the pickup branch for the hold, and printer_id is
   the id number for the printer.
7) See your reserve slip is printer!

Bonus points: Repeat the test plan, but for a printer you set up via CUPS on
the Koha server

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:29:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 14:29:40 +0000
Subject: [Koha-bugs] [Bug 12732] Sort late orders by basket creation or
	closing date
In-Reply-To: <bug-12732-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12732-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12732-70-FxrAGIZsS3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12732

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:30:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 14:30:25 +0000
Subject: [Koha-bugs] [Bug 13827] New: stuck on offline screen
Message-ID: <bug-13827-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13827

            Bug ID: 13827
           Summary: stuck on offline screen
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: askus at windstream.net
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

I have just finished an install of 3.18.  When I try to access the staff screen
(http:bclib-intra.mydomain.org:8080) I receive the offline for maintenance
screen.  Since it is my first install in 3 or 4 years I don't know if I am
missing some install doc or a configuration step???  Thanks in advance for your
help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:41:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 14:41:35 +0000
Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in
	XSLT
In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13387-70-D0gnq1o9LV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387

rgravel at marlboro.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rgravel at marlboro.edu

--- Comment #2 from rgravel at marlboro.edu ---
I don't know that it's necessary to crowd the brief display in the results
list. Currently "Other title" does display in the results, and that may be more
useful to patrons than the uniform title, so I personally think it's ok to just
keep the uniform title in the full record display.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:44:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 14:44:47 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-6feworQ9Bx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Created attachment 36835
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36835&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from Koha/Borrower/Files.pm

To test:
Apply patch
Make sure that uploading arbitrary files for a patron works as before (Set
syspref EnableBorrowerFiles for testing )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 15:49:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 14:49:23 +0000
Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT
In-Reply-To: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13433-70-jZWAt7AgmI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433

rgravel at marlboro.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rgravel at marlboro.edu

--- Comment #2 from rgravel at marlboro.edu ---
I'm not exactly sure where "Material type" is landing now, however, I will note
that Genre/Form headings are closely related to "Subject(s)," and so I think
they should be displayed near them. I had originally contemplated them
following "Subject(s)" but am open to other suggestions!

Thanks so much, Winona!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:20:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 15:20:17 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-JXHO0XLS3o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
Created attachment 36836
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36836&action=edit
Bug 13813 - Remove C4::Dates from PDF templates in acquisitions

To test:

Apply patch
In Acquisitions, go to a vendor's "Basket grouping"
Find a basket and print order
Change PDF templates using syspref OrderPdfFormat and test for
- English 2-page
- English 3-page
- French 3-page
- German 2-page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:30:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 15:30:23 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-sr6Jl8Ojd2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:30:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 15:30:26 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-TuyUfYnR0V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22634|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36837
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36837&action=edit
Bug 11084 - Delete biblios on Leader 05 == d

Position 05 of the leader in MARC 21 indicates the record's status.
A lower case 'd' indicates that the record is to be deleted
(http://www.loc.gov/marc/authority/adleader.html).

This patch adds a cronjob script that may be run nightly to delete
records where position 05 of the leader is set to 'd'.

Test Plan:
1) Edit one or more records, and set the leader position 05 to 'd'.
2) Run misc/cronjobs/deleted_fixed_field_5.pl -c -v
3) Those records should either be deleted, or an error message should
   state why they were not.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Works as advertised. Put some points of attention on Bugzilla comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:30:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 15:30:59 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-Pnj03H3Rrj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36837|0                           |1
        is obsolete|                            |

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36838
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36838&action=edit
Bug 11084 - Delete biblios on Leader 05 == d

Position 05 of the leader in MARC 21 indicates the record's status.
A lower case 'd' indicates that the record is to be deleted
(http://www.loc.gov/marc/authority/adleader.html).

This patch adds a cronjob script that may be run nightly to delete
records where position 05 of the leader is set to 'd'.

Test Plan:
1) Edit one or more records, and set the leader position 05 to 'd'.
2) Run misc/cronjobs/delete_records_via_leader.pl -c -v
3) Those records should either be deleted, or an error message should
   state why they were not.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Works as advertised. Put some points of attention on Bugzilla comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:37:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 15:37:50 +0000
Subject: [Koha-bugs] [Bug 13646] Facets encoding problem with GRS1
In-Reply-To: <bug-13646-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13646-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13646-70-Bjjqa0YKwQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at biblibre.co |fridolyn.somers at biblibre.co
                   |m                           |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:38:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 15:38:11 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10363-70-MM9L4Wm4Ui@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:39:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 15:39:11 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-j9x7G9bYL1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:40:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 15:40:14 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-1J0lbaIg93@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
Created attachment 36839
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36839&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from Koha/Misc/Files.pm

To test:
Apply patch
Make sure that C4::Dates is not used in the code
Set syspref AcqEnableFiles to enable
Go to Home > Acquisitions > Invoices
Find an invoice, go to Details, Manage Invoice files, make sure that uploading
/ displaying files works as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:47:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 15:47:46 +0000
Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting
In-Reply-To: <bug-12357-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12357-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12357-70-T1vMsTIvFq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357

Rolando Isidoro <rolando.isidoro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rolando.isidoro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 16:53:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 15:53:27 +0000
Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements
In-Reply-To: <bug-12404-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12404-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12404-70-DVgQKVvG4g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:02:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:02:15 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-34dRZnwonH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:02:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:02:18 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-KoVvAjDaOr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36838|0                           |1
        is obsolete|                            |

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36840
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36840&action=edit
Bug 11084 - Delete biblios on Leader 05 == d

Position 05 of the leader in MARC 21 indicates the record's status.
A lower case 'd' indicates that the record is to be deleted
(http://www.loc.gov/marc/authority/adleader.html).

This patch adds a cronjob script that may be run nightly to delete
records where position 05 of the leader is set to 'd'.

Test Plan:
1) Edit one or more records, and set the leader position 05 to 'd'.
2) Run misc/cronjobs/delete_records_via_leader.pl -c -v
3) Those records should either be deleted, or an error message should
   state why they were not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:02:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:02:40 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-nDgHlNqM5v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Script now displays all options.

(In reply to Katrin Fischer from comment #12)
> Hm, bit confused about the help too - is there a way to get it to list all
> available options? -h didn't seem to do the trick.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:03:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:03:12 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-Tp7g5C48VZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Updated patch should address all these concerns.

(In reply to M. de Rooy from comment #10)
> Signing off but with some smaller comments:
> 
> typo delete_fixec_field_5.pl
> test mode should be explained (not in usage)
> name of the script could be confusing: you are obviously not deleting a
> fixed field, but a record :)
> encoding: when you are printing the title to stdout, you should probably
> open stdout as utf8
> verbose mode: would it be helpful to say which biblios or items were
> actually deleted (and count them?)
> license statement: version 2 or 3? address no longer?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:05:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:05:06 +0000
Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn
	variations
In-Reply-To: <bug-13528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13528-70-3OvPcm3hIC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:06:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:06:11 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-nZ6gZdnJde@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
This is a definite issue, but appears to be outside the scope of this bug.

It would appear that misc/batchdeletebiblios.pl has the exact same issues. I
would suggest we file a separate bug to handle that issue.

(In reply to Katrin Fischer from comment #11)
> Hm, a few notes from me too: 
> 
> DelBiblio has a few shortcomings that could cause problems:
> 
> 1) It just deletes attached subscriptions. Subscription data can be created
> over a long time and is not easily reproducable. There is no backup when we
> delete it.
> 
>  428     # We delete attached subscriptions
> 429     require C4::Serials;
> 430     my $subscriptions =
> C4::Serials::GetFullSubscriptionsFromBiblionumber($biblionumber);
> 431     foreach my $subscription (@$subscriptions) {
> 432         C4::Serials::DelSubscription( $subscription->{subscriptionid} );
> 433     }
> 
> 2) It will also delete records that are used with orders, as this isn't
> checked at all.
> 
> Kyle, could you take a look at Marcel's and my comments?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:13:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:13:52 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-z3qmKEeiaC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:19:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:19:57 +0000
Subject: [Koha-bugs] [Bug 13828] New: items.onloan field not always
 populated when items are issued
Message-ID: <bug-13828-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13828

            Bug ID: 13828
           Summary: items.onloan field not always populated when items are
                    issued
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

When searching item table in database, not all items issued (checked out) are
reflecting this in the onloan field.  Some records show a null value.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:23:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:23:52 +0000
Subject: [Koha-bugs] [Bug 13828] items.onloan field not always populated
 when items are issued
In-Reply-To: <bug-13828-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13828-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13828-70-PLpOWXfSRx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13828

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:26:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:26:51 +0000
Subject: [Koha-bugs] [Bug 12421] no way to get back to search results from
 overdrive results
In-Reply-To: <bug-12421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12421-70-JRtBBXXLoO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:26:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:26:53 +0000
Subject: [Koha-bugs] [Bug 12421] no way to get back to search results from
 overdrive results
In-Reply-To: <bug-12421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12421-70-fzjYHTwh2x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36841
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36841&action=edit
Bug 12421 - no way to get back to search results from overdrive results

When on your search results you can click the link to overdrive results,
but then you can't get back to your catalog search results, the
line that links to the results should be there on both pages.

Test Plan:
1) Apply this patch
2) Enable Overdrive searching
3) Perform a search
4) View the overdrive results
5) Note the "Catalog search for '$q'" link in the breadcrumbs
6) Click the link
7) Note you return to the search results page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 17:27:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 16:27:57 +0000
Subject: [Koha-bugs] [Bug 12421] no way to get back to search results from
 overdrive results
In-Reply-To: <bug-12421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12421-70-HFt01XlEbQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 18:09:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 17:09:48 +0000
Subject: [Koha-bugs] [Bug 13829] New: Syntax highlighter on source code
	textareas
Message-ID: <bug-13829-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13829

            Bug ID: 13829
           Summary: Syntax highlighter on source code textareas
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Some textareas contain source code. For example SQL reports (not even monospace
font) and some sysprefs (4 with JS, 18 with HTML). Would be a nice (and pretty
easy) enhancement to offer syntax highlight on all of them, with very little
page overload. There are a lot of alternatives:
- SyntaxHighlighter
- Highlight.js
- Google Code Prettify (like StackOverflow)
- Snippet
- PrismJs

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 19:57:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 18:57:09 +0000
Subject: [Koha-bugs] [Bug 13826] OPAC: Display RSS icon on list of recent
	comments
In-Reply-To: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13826-70-BOjuTUFfA4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36826|0                           |1
        is obsolete|                            |

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36842
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36842&action=edit
Bug 13826 - OPAC: Display RSS icon on list of recent comments

This patch adds RSS icon to OPAC page 'Recent comments'

To test:
1)
Enable display of 'Recent comments' in OPAC (Syspref OpacShowRecentComments)
2)
In OPAC, go to Home > Recent comments
3)
Verify that there is a link in the head part of the HTML source code (<link
rel="alternate" type="application/rss+xml"....), but no RSS icon on the pate
itself (like in search results).
4)
Apply patch
Result: Icon with link to RSS feed is displayed  next to title.

Bug 13826 - Follow-Up: Close </h3>

There was a slash missing.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 19:57:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 18:57:41 +0000
Subject: [Koha-bugs] [Bug 13826] OPAC: Display RSS icon on list of recent
	comments
In-Reply-To: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13826-70-pPQNY8RpKS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 20:09:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 19:09:08 +0000
Subject: [Koha-bugs] [Bug 13826] OPAC: Display RSS icon on list of recent
	comments
In-Reply-To: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13826-70-hiydl3t2HS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 36843
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36843&action=edit
[Signed-off] Bug 13826 - OPAC: Display RSS icon on list of recent comments

This patch adds RSS icon to OPAC page 'Recent comments'

To test:
1)
Enable display of 'Recent comments' in OPAC (Syspref OpacShowRecentComments)
2)
In OPAC, go to Home > Recent comments
3)
Verify that there is a link in the head part of the HTML source code (<link
rel="alternate" type="application/rss+xml"....), but no RSS icon on the pate
itself (like in search results).
4)
Apply patch
Result: Icon with link to RSS feed is displayed  next to title.

Bug 13826 - Follow-Up: Close </h3>

There was a slash missing.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by for the Follow Up: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 20:09:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 19:09:13 +0000
Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet.
In-Reply-To: <bug-11317-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11317-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11317-70-KXWuJ05rsv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 20:09:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 19:09:15 +0000
Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet.
In-Reply-To: <bug-11317-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11317-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11317-70-i1MLiVyCg5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #18 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 36844
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36844&action=edit
Bug 11317: Correct critic, forbidden patterns issues when tested with
koha-test-tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 21:08:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 20:08:07 +0000
Subject: [Koha-bugs] [Bug 13830] New: Improve CSS styling for OPAC
Message-ID: <bug-13830-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13830

            Bug ID: 13830
           Summary: Improve CSS styling for OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org

This bug attempts to track improvements for CSS styling in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 21:11:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 20:11:02 +0000
Subject: [Koha-bugs] [Bug 13830] Improve CSS styling for OPAC,
 by adding more html 'id' values
In-Reply-To: <bug-13830-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13830-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13830-70-zaAKEV4jqp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13830

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Improve CSS styling for     |Improve CSS styling for
                   |OPAC                        |OPAC, by adding more html
                   |                            |'id' values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 21:12:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 20:12:30 +0000
Subject: [Koha-bugs] [Bug 13830] Improve OPAC,
	by adding more html 'id' values to markup
In-Reply-To: <bug-13830-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13830-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13830-70-QMsJVmaaMm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13830

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Improve CSS styling for     |Improve OPAC, by adding
                   |OPAC, by adding more html   |more html 'id' values to
                   |'id' values                 |markup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 21:24:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 20:24:51 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-6APxzZOzTA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #11 from Marc V?ron <veron at veron.ch> ---
Created attachment 36845
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36845&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from tags/list.pl

To test:
Apply patch
Verify in code that C4::Dates is not necessary in tags/list.pl
Set sysprefs to TagsEnabled and TagsModeration
Got to Home > Tools > Tags
In table of tags, click on a Term
You should get a page Home > Tools > Tags > Results for [Term]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 21:38:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 20:38:39 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-bc92G4U6rm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13601

--- Comment #12 from Marc V?ron <veron at veron.ch> ---
Note: Previous patches are independent from each other.

More patches to come will need changes to Koha/DateUtils.pm (reason for
dependency form Bug 13601

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 21:38:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 20:38:39 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-DP6YqiROOp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13813

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 21:39:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 20:39:15 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-mXQKTCHPpz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12072

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 12 21:39:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 20:39:15 +0000
Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
In-Reply-To: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12072-70-kyibA1wvch@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13813

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 00:18:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 23:18:40 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-3OSj59Svdc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 00:40:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 12 Mar 2015 23:40:52 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-h292EABNNM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 02:20:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 01:20:15 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-7AtP2xUbSv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #36 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 02:28:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 01:28:10 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-I6AhuWQWgS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #14 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 03:28:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 02:28:34 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-ckjT5Sds52@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #55 from Robin Sheat <robin at catalyst.net.nz> ---
Authority searching is now "complete", by which I mean it seems to work but
there are bound to be issues in it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 04:52:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 03:52:39 +0000
Subject: [Koha-bugs] [Bug 13829] Syntax highlighter on source code textareas
In-Reply-To: <bug-13829-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13829-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13829-70-L675dZOXET@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13829

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 06:12:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 05:12:38 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-MnHtR8HIN4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Tested for signing off, search behaviour is much better now!

However, I propose to keep sorting, something like:

my $order_by = 'surname, firstname';
my ($results) = Search( $term, $order_by, [ 10 ] );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 06:34:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 05:34:09 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9223-70-s5o47DKoNr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12136

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 06:34:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 05:34:09 +0000
Subject: [Koha-bugs] [Bug 12136] Problem in opac-topissues.pl if
 AdvancedSearchTypes has multiple values (separated by pipes)
In-Reply-To: <bug-12136-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12136-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12136-70-WQrMxQBw40@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=9223

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 07:55:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 06:55:34 +0000
Subject: [Koha-bugs] [Bug 13829] Syntax highlighter on source code textareas
In-Reply-To: <bug-13829-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13829-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13829-70-cM7P4MSxyr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13829

paxed <pasi.kallinen at pttk.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at pttk.fi

--- Comment #1 from paxed <pasi.kallinen at pttk.fi> ---
(In reply to Pablo AB from comment #0)
> Some textareas contain source code. For example SQL reports (not even
> monospace font)

For monospace font in SQL report textarea, add this to IntranetUserCSS:

#rep_guided_reports_start textarea#sql { font-family: monospace; }

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 09:22:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 08:22:11 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-NYaF33EbfO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 09:50:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 08:50:10 +0000
Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and
	result views
In-Reply-To: <bug-12561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12561-70-FKNbJWQKWr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m,
                   |                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:26:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 09:26:42 +0000
Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create
 duplicate fields in biblio
In-Reply-To: <bug-13760-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13760-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13760-70-KywQxmXR8o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36168|0                           |1
        is obsolete|                            |

--- Comment #3 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 36846
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36846&action=edit
Bug 13760 - Authorities merge sometimes create duplicate fields in biblio

When merging two authorities the biblio records linked to those authorities are
updated. It is directly done if syspref "dontmerge" is on "Do".

Actually some cases create a duplicate field.
For example, a biblio record as :
  600 $9 11 $a Son Goku
  600 $9 12 $a Vegeta
If you merge the authorities id=11 and id=12 into id=11 (creating Gogeta), you
actually get :
  600 $9 11 $a Son Goku
  600 $9 11 $a Son Goku

Having two identical fields linked to the same authority is useless.

The same problem is even more frequent when merging two authorities of
different type.

This patch corrects this behavior by searching already existing field with the
link to the autority, using flag $field_to_exists. This flag is not used in
case the merge is after a single authority modification.

Note that this patch changes the minium of code in order to rebase it easyly. A
followup will do the code formatting.

Test plan :
- Set syspref dontmerge to 'Do'
- Create a biblio record
- Link a field to an authority (the field gets a $9). For example :
  600 $9 11 $a Son Goku
- Link a field to another authority (the field gets a $9). For example :
  600 $9 12 $a Vegeta
- Save the record
- Index Zebra queue
- Search for autority "Vegeta"
- Click on "Merge"
- Search for autority "Son Goku"
- Click on "Merge"
- Click on "Next"
- Click on "Merge"
- Go to biblio record
=> Without the patch : you see 2 fields linked to the same authority "Son Goku"
=> With the patch : you see 1 field linked to the authority "Son Goku"
- Test also with autoritites of different type.
- Check that modifying the autority "Son Goku" impacts the biblio record

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:26:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 09:26:54 +0000
Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create
 duplicate fields in biblio
In-Reply-To: <bug-13760-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13760-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13760-70-E4garji2fx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760

--- Comment #4 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 36847
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36847&action=edit
Bug 13760 - formatting code

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:28:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 09:28:06 +0000
Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create
 duplicate fields in biblio
In-Reply-To: <bug-13760-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13760-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13760-70-j2NT63c7su@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Here is the follow-up patch for code formatting with perltidy.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:33:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 09:33:39 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-d5PMyf39zs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 10:35:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 09:35:52 +0000
Subject: [Koha-bugs] [Bug 12641] Formally deprecate the GRS-1 indexing mode
In-Reply-To: <bug-12641-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12641-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12641-70-U6VQoq7wvO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12641

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 11:09:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 10:09:27 +0000
Subject: [Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
In-Reply-To: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13254-70-nlRB876Qfv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 11:13:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 10:13:33 +0000
Subject: [Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
In-Reply-To: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13254-70-iioG9ClAAt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254

--- Comment #8 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Dirty bug indeed.
Can this be backported to 3.16.x ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 11:16:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 10:16:00 +0000
Subject: [Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
In-Reply-To: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13254-70-H0QINQDcwC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254

--- Comment #9 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
This bug shows that the behavior of the browser is sometimes dangerous :
                    $('a[href*="biblionumber="]').click(function (ev) {
                        ev.preventDefault();
                        window.location = $(this).attr('href') + '&searchid=' +
me.searchid;
                    });
In my opinion the selector 'a[href*="biblionumber="]' is too large.
It may impact future code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 11:20:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 10:20:13 +0000
Subject: [Koha-bugs] [Bug 11821] Staff client catalog: delete menu items
 greyed out without explanation
In-Reply-To: <bug-11821-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11821-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11821-70-koZA2eJHob@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11821

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13254

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 11:20:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 10:20:13 +0000
Subject: [Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
In-Reply-To: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13254-70-SuNJsXaKgo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11821

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 11:29:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 10:29:34 +0000
Subject: [Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
In-Reply-To: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13254-70-1V4cmKa6Qw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please see also bug 13644 - this piece of code can also break links under some
circumstances.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 12:53:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 11:53:39 +0000
Subject: [Koha-bugs] [Bug 13829] Syntax highlighter on source code textareas
In-Reply-To: <bug-13829-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13829-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13829-70-dCaQ4oJ5rg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13829

--- Comment #2 from Pablo AB <pablo.bianchi at gmail.com> ---
Thanks! I had already done it jQuery, but is better your choice:
$('#rep_guided_reports_start textarea#sql').css("font-family", "monospace" );

BTW, I thought jquery/plugins/jquery.highlight-3.js could help me, but is a
very basic highlight. Maybe we can use a better text highlighter jquery plugin
that do the full job (for both search and source code syntax highlight).

Also (and this could be another enhancement) I wonder if there is a good reason
why we don't have (AFAIK) a syspref to add anything to head HTML tag to both
opac and intranet. That's would let anyone to add their own jquery plugins.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:13:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:13:02 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-qjCB3PRzmU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---

(In reply to Benjamin Rokseth from comment #4)
> Tested this patch locally on a koha dev setup, and some remarks:
> 
> * incredibly fast! ~50msec on 50 borrowers...promising!
> * few deps:
> 
> apt-get install -y make cpanm
> cpanm Mojolicious
> cpanm Swagger2

Yes, the dependancies will definitely need to be added to PerlDependancies.pm

> * clean and little "glue-code" to Koha
> * self-documenting, in a way, with Swagger
> 
> I propose that this POC is moved forward to a fully working example covering
> Borrowers, that can be part of Koha 3.20 if the New_REST_API_RFC
> (http://wiki.koha-community.org/wiki/New_REST_API_RFC) are fullfilled.

I completely agree, this should definitely move forward!

> What's missing now:
> - authentication

Yes, there are a number of ways for handle this:
1) The way /svc works now
2) Ability to pass in a auth_username and auth_password ( simpler, stateless,
easy for command line use of /rest, only safe over https or from localhost )
3) API tokens ( best idea, will require a whole separate feature )

I think one or both of the first two ways would be perfectly acceptable.

> - C4::Borrowers vs Koha::Borrowers?

We should use this as an opportunity to take full advantage of the new
Koha::Object system wherever possible.

> - versioning

Versioning should be a simple matter ( as described in
http://wiki.koha-community.org/wiki/New_REST_API_RFC )

> - content negotiation

I personally think supporting JSON is adequate, but that's just my opinion.
Supporting other formats would be great as long as we implement it at a low
enough level that future developers will not have to deal with it ; )

I believe there is already a patch floating around that adds a to_json method
to Koha::Object. We could add a method 'serialize' instead that takes a format
and could output json, xml, yaml or whatever.

> - full CRUD

Definitely!

This is a great start!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:28:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:28:47 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-110UixAPom@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:28:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:28:50 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-AqLj8f1dlU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36787|0                           |1
        is obsolete|                            |

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36848
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36848&action=edit
[PASSED QA] Bug 9481 - charge not showing fines On 'Check out' and 'Details'.

When looking at the patron record or the checkout screen the checkout
summary is now showing 0 for all the Charges even if the item was
overdue and has accrued fines.
Removed unused(?) footer values in checkouts-table-footer.inc

To test:
1/ Check out items with past due date
2/ Run fines.pl script (ensure finesMode is set to Calculate and Charge)
3/ Verify on Fines->Pay Fines screen that fines where calculated
correct.
4/ Go to Patron record, charge column on Details and Check out
screen
should be 0 or rental charge amount only. But total amount row
display right
number, same as in pay fines screen.
4/ Apply patch.
5/ Now charges on display and check out screen shows all outstanding
fees for each item.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:30:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:30:14 +0000
Subject: [Koha-bugs] [Bug 13826] OPAC: Display RSS icon on list of recent
	comments
In-Reply-To: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13826-70-ohuYl4bfrW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
  Attachment #36842|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:36:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:36:15 +0000
Subject: [Koha-bugs] [Bug 13826] OPAC: Display RSS icon on list of recent
	comments
In-Reply-To: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13826-70-nFY1eFqQON@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:36:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:36:17 +0000
Subject: [Koha-bugs] [Bug 13826] OPAC: Display RSS icon on list of recent
	comments
In-Reply-To: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13826-70-xQTWUireBB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36843|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36849
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36849&action=edit
[PASSED QA] Bug 13826 - OPAC: Display RSS icon on list of recent comments

This patch adds RSS icon to OPAC page 'Recent comments'

To test:
1)
Enable display of 'Recent comments' in OPAC (Syspref OpacShowRecentComments)
2)
In OPAC, go to Home > Recent comments
3)
Verify that there is a link in the head part of the HTML source code (<link
rel="alternate" type="application/rss+xml"....), but no RSS icon on the pate
itself (like in search results).
4)
Apply patch
Result: Icon with link to RSS feed is displayed  next to title.

Bug 13826 - Follow-Up: Close </h3>

There was a slash missing.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by for the Follow Up: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:41:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:41:15 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-cdvQZcdTiI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #13 from Marc V?ron <veron at veron.ch> ---
Created attachment 36850
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36850&action=edit
Bug 13813 - Remove C4::Dates from C4/Members.pm

This patch removes C4::Dates from C4/Members.pm

Note: This patch can be tested independently from other patches in this Bug,
but it depends on patches from Bug 13601

To test:
Make sure that patches from 13601 are applied
Apply patch
Check changes in code
Make sure that following functionality works as before:
- Add a patron
- Renew patrons
- Go to checkout page and create  message for patron

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:47:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:47:06 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-t1ehDVoT1S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36828|0                           |1
        is obsolete|                            |

--- Comment #14 from Marc V?ron <veron at veron.ch> ---
Created attachment 36851
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36851&action=edit
Bug 13813 - Remove C4::Dates from members/readingrec.pl

This patch removes depraceted C4::Dates from members/readingrec.pl

To test:

Apply patch
Go to a patron's cirulation history
Verify that circulation history behaves as before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:51:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:51:42 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-ewsA4pbhFE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Maxime Beaulieu from comment #29)
> (In reply to Katrin Fischer from comment #28)
> > Plase take a look at comment 25 too! Thx!
> 
> The regression was caused by the missing patches.
> If you apply all three you should not see any problems.

With all three patches, I'm not seeing those problems!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:52:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:52:03 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-Ib8dqQFC6y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34816|0                           |1
        is obsolete|                            |
  Attachment #36626|0                           |1
        is obsolete|                            |
  Attachment #36627|0                           |1
        is obsolete|                            |

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36852
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36852&action=edit
[PASSED QA] Bug 11982 - Show local cover image in the intranet biblio details
page

Also, fix useless "No cover image" block when using Amazon and local
cover images at the same time.

http://bugs.koha-community.org/show_bug.cgi?id=11982
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:52:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:52:00 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-fTdu58tjED@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:52:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:52:11 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-GCkrt6Et7E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36853
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36853&action=edit
[PASSED QA] Bug 11982 - Fixed the amazon no image icon.

A no image icon will only be displayed if both the amazon and local images are
missing.
Added hyperlink to details on the local image in the search result page.
    modified:   koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js
    modified:   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
    modified:   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:52:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:52:14 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-VnRlHSMkSx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36854
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36854&action=edit
[PASSED QA] Bug 11982 - Images now display properly in the details section.

If the a cover image exists, it will be displayed on the details page.
Nothing is displayed of there is no cover available.
    modified:   koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js
    modified:   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Works as described, passes tests and QA script.
Checked Amazon covers and local covers display correctly
in staff on results and detail pages.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:58:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:58:03 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-yGP2VRAEDa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #58 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #56)
> Looks good to me too.
> Kyle could you run perl -wc Koha.pm and tell us what is the error/warning?
> It's certainly related to the perl version (5.20 here).

Agreed, I'm running perl v5.10.1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 13:58:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 12:58:21 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-Z0pQxBbeiF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36851|0                           |1
        is obsolete|                            |

--- Comment #15 from Marc V?ron <veron at veron.ch> ---
Created attachment 36855
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36855&action=edit
Bug 13813 - Remove C4::Dates from members/readingrec.pl

This patch removes depraceted C4::Dates from members/readingrec.pl

To test:

Apply patch
Go to a patron's cirulation history
Verify that circulation history behaves as before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:01:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:01:19 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-TRfxrsE5jM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:01:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:01:23 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-1ksjWa3yMd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36240|0                           |1
        is obsolete|                            |

--- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36856
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36856&action=edit
[PASSED QA] Bug 10937 - Option to hide and group itemtypes from advanced search

This allows to group certain item types in a category, to be displayed (and
searched) as such in OPAC's advanced search.  For example, you can group
Reserve 2h and Reserve 12h into a Reserve category.  The 2 and 12h types won't
appear anymore.
This also allows to simply prevent an item type from displaying as a search
option.

TEST PLAN
------------------
0) Back up database, so you can reset and retest easily. ;)
1) Apply the patch
2) Run Koha QA tool.
3) prove -v t/db_dependent/Koha.t
  -- all tests should pass.
  4) run ./installer/data/mysql/updatedatabase.pl to add the
  two columns to itemtypes
  -- Does a meaningful message get printed?
  Are the columns added?
  "DESCRIBE itemtypes;" should list hideinopac and searchcategory.
  5) You need to add a category to group your item types:
  a) In Intranet/Koha Admin/Authorized values,
  select DOCTYPECAT in the 'Show category:' dropdown
  i) If you do not have a DOCTYPECAT category, create one.
  b) Click button "New authorized value for DOCTYPECAT"
  c) Enter
  Authorized value: HARDWARE
  Description : Hardware
  Description (OPAC): Hardware
  6) Group your items under that new category
  a) In Intranet/Koha Admin/Item types, choose (at least)
  two item types and for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category list box, select
Hardware
  - click Save changes at the bottom
  7) Select at least one item to be hidden in the OPAC search
  a) In Intranet/Koha Admin/Item types (again), choose a different item type:
  -  Click action/Edit
  -  Click the checkbox "Hide in OPAC" below the list of icons.
  8) Go test your modifications
  a) Go to OPAC/Adv search.
  b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
  c) Validate that new item type Hardware does appear instead.
  d) Select item Hardware, start Search.
  ) Validate returned items are the of the two types that were grouped into the
Hardware category in step 4.

  Sponsored-by: Vanier college

Signed-off-by: Nick <nick at quecheelibrary.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:03:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:03:55 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-3JcZDNAGsn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36829|0                           |1
        is obsolete|                            |

--- Comment #16 from Marc V?ron <veron at veron.ch> ---
Created attachment 36857
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36857&action=edit
Bug 13813 - Remove C4::Dates from C4/Items.pm

This patch removes depraceted C4::Dates from C4/Items.pm
To test:

Apply patch

To test:
Add modify items. Checkout added item.
Verify that item handling works as before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:13:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:13:57 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-CAWTOxZKej@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36857|0                           |1
        is obsolete|                            |

--- Comment #17 from Marc V?ron <veron at veron.ch> ---
Created attachment 36858
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36858&action=edit
Bug 13813 - Remove C4::Dates from C4/Items.pm

This patch removes depraceted C4::Dates from C4/Items.pm
To test:

Apply patch

To test:
Add modify items. Checkout added item.
Verify that item handling works as before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:18:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:18:13 +0000
Subject: [Koha-bugs] [Bug 13831] New: Item history is anonymized when
 borrower anonymizes his reading history using Immediate deletion
Message-ID: <bug-13831-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13831

            Bug ID: 13831
           Summary: Item history is anonymized when borrower anonymizes
                    his reading history using Immediate deletion
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org

It is crucial to be able to tell who had the Item checked out last, so we can
pursue mishandling of Items.
Currently if a borrower checks-in a loan, and goes to his/her
  "OPAC" -> "Your privacy" -> "Immediate deletion"
the Item history points to the statistical anonymizer borrower, instead of the
real borrower.

The reading history anonymizer should not anonymize loans which should still be
visible in the Item's history.

TEST PLAN:
0. Make sure the system preference "AnonymousPatron" is set and points to a
   existing borrower record.
1. Checkout a Item.
2. Checkin the same Item.
3. Look at the Item's history at catalogue/moredetail.pl and see that you are
the
   "Last borrower"
4. Trigger "OPAC" -> "Your privacy" -> "Immediate deletion"
5. In catalogue/moredetail.pl, the "Last borrower" is now the statistical
   anynomization borrower.
6. Should we need to reimburse the "Last borrower" for any damages for the
Item,
   we cannot know who it was.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:23:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:23:25 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-NM2WXJy17E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36850|0                           |1
        is obsolete|                            |

--- Comment #18 from Marc V?ron <veron at veron.ch> ---
Created attachment 36859
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36859&action=edit
Bug 13813 - Remove C4::Dates from C4/Members.pm

This patch removes C4::Dates from C4/Members.pm

Note: This patch can be tested independently from other patches in this Bug,
but it depends on patches from Bug 13601

To test:
Make sure that patches from 13601 are applied
Apply patch
Check changes in code
Make sure that following functionality works as before:
- Add a patron
- Renew patrons
- Go to checkout page and create  message for patron

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:31:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:31:40 +0000
Subject: [Koha-bugs] [Bug 8612] System preference to have custom fields in
 exort csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-7p2HZtaPkV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #5 from simith.doliveira at inlibro.com ---
Created attachment 36860
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36860&action=edit
Bug 8612 - System preference to have custom fields in exort csv basket

This patch allows the user use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

To test:

I   -  Apply the patch;
II  - Create a CSV export profile - type sql -  Home ? Tools ? CSV export
profiles
 ex:
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
III - Create a new basket and add an order to the basket
IV  - Validate: the text "Select CSV profile:" and a dropdown
V   - Select the CSV export profile created
VI  - Validate: the CSV file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:31:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:31:59 +0000
Subject: [Koha-bugs] [Bug 8612] System preference to have custom fields in
 exort csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-g0H2i1A3Hr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11514|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:32:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:32:14 +0000
Subject: [Koha-bugs] [Bug 8612] System preference to have custom fields in
 exort csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-z8gzLReZyR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:41:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:41:57 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 exort csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-M89GXubBfg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|System preference to have   |CSV export profile to have
                   |custom fields in exort csv  |custom fields in exort csv
                   |basket                      |basket

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:42:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:42:28 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-kHy4pt0QQQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

simith.doliveira at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|CSV export profile to have  |CSV export profile to have
                   |custom fields in exort csv  |custom fields in export csv
                   |basket                      |basket

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:45:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:45:05 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
	guarantor search
In-Reply-To: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13021-70-sfwLCCw9ld@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Patch doesn't apply

--- Comment #28 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Jonathan, is it possible that the latest patch doesn't belong here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:53:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:53:30 +0000
Subject: [Koha-bugs] [Bug 13832] New: Missing table header IDs on record
 holdings table in OPAC
Message-ID: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

            Bug ID: 13832
           Summary: Missing table header IDs on record holdings table in
                    OPAC
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

All but two of the table headers in the item holdings table in the opac have
identifiers. The remaining two should be added so they can be modified easily
with CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:53:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:53:34 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-CT6Ao6h0pV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:56:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:56:45 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-koKNFnNI6G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 14:56:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 13:56:47 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-SYisjZJxv0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36861
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36861&action=edit
Bug 13832 - Missing table header IDs on record holdings table in OPAC

All but two of the table headers in the item holdings table in the opac have
identifiers. The remaining two should be added so they can be modified easily
with CSS.

Test Plan:
1) Apply this patch
2) View the holdings table for a record
3) Note the new id field for the item holds column
4) Note the new id field for the hold prioirty column ( if enabled )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 15:04:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 14:04:07 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-RmEqWg55Th@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #19 from Marc V?ron <veron at veron.ch> ---
Created attachment 36862
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36862&action=edit
Bug 13813 - Remove C4::Dates from C4/Barcodes/annual.pm

To test:
Set syspref autoBarcode to <year>-001, <year>-002
Edit items or add item, click in empty barcode field, verify that barcodes are
filled in as appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 15:22:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 14:22:19 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-jenMDOZT1I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #20 from Marc V?ron <veron at veron.ch> ---
Created attachment 36863
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36863&action=edit
Bug 13813 - Remove C4::Dates from C4/Barcodes/hbyymmincr.pm

To test:
Set syspref autoBarcode to <branchcode>yymm0001
Edit items or add item, click in empty barcode field, verify that barcodes are
filled in as appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 15:31:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 14:31:59 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-xCnEhS2CaP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #21 from Marc V?ron <veron at veron.ch> ---
Created attachment 36864
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36864&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from C4/Barcodes.pm

To test:
Apply patch
Verify that C4::Dates is not used in code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 15:41:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 14:41:23 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-dH4dfveja6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #22 from Marc V?ron <veron at veron.ch> ---
Created attachment 36865
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36865&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from C4/Biblio.pm

To test:
Apply patch
Verify that C4::Dates is not used in code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 15:41:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 14:41:36 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-QY9GpxBWw3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36566|0                           |1
        is obsolete|                            |
  Attachment #36567|0                           |1
        is obsolete|                            |

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36866
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36866&action=edit
[PASSED QA] Bug 13478: Force item holds only for specific biblios

This patch adds the option to selectively force item holds for specific
biblionumbers.
The patch adds routine C4::Reserves::CheckBiblioForceItemHolds. It is
tested in Reserves.t.
The preference OPACItemHolds gets a new choice: selectiveforce.
The description of the pref is adjusted.

Please note that this option is specifically targeted for the OPAC. Staff
users still have both possibilities.

A follow-up report (13479) will add the possibility for staff users to
enable the forced item hold on biblio level.

TEST PLAN:
[ 1] Run the unit test t/db_dependent/Reserves.t.
[ 2] Set OPACItemHolds to force.
[ 3] Add a hold in the OPAC; verify that you cannot place a next/av hold.
[ 4] Set OPACItemHolds to Allow.
[ 5] Add a hold in the OPAC; verify that you can place both hold types.
[ 6] Set OPACItemHolds to Do not allow.
[ 7] Add a hold in the OPAC; verify that you can only place next/av holds.
[ 8] Enable forced item holds for two biblionumbers:
     UPDATE biblio SET forced_item_holds=1 WHERE biblionumber=?
[ 9] Set OPACItemHolds to Selectively force.
[10] Add a hold on three biblionumbers at once (including these two).
     Verify that you have two hold types for the single biblio and that
     you have only item holds for the two other biblios.

Signed-off-by: Nick <nick at quecheelibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Added the column to biblio and removed the separate table.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 15:41:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 14:41:28 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-5A5KTPs6aU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 15:42:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 14:42:03 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-9CniJdpSdQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36867
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36867&action=edit
[PASSED QA] Bug 13478: Database revision (new biblio column and pref
description)

TEST PLAN:
[1] Run the database revision. Check if the new column is present.

Signed-off-by: Nick <nick at quecheelibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Added a new column to biblio instead of the new table.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:02:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 15:02:03 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-O3vfDFnJNq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:02:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 15:02:09 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-Qxi3LYcAxH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36765|0                           |1
        is obsolete|                            |
  Attachment #36774|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36868
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36868&action=edit
[PASSED QA] Bug 13814 : add 6 unit tests in t/Boolean.t

Works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:04:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 15:04:29 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-7ftjTrve61@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36869
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36869&action=edit
[PASSED QA] Bug 13814 : Add Lines Alignment

Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:42:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 15:42:35 +0000
Subject: [Koha-bugs] [Bug 4054] Double-clicking the 'place hold' button can
 result in duplicate holds
In-Reply-To: <bug-4054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4054-70-vVp909tUcg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4054

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com,
                   |                            |eric.begin at inLibro.com,
                   |                            |francois.charbonnier at inlibr
                   |                            |o.com,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:43:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 15:43:02 +0000
Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU
	indexing
In-Reply-To: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13751-70-oCCDXtrRbc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David,

I am not sure how to interpret your test results. The problem I see is that the
search seems to work... but the records titles DON'T BEGIN all with with the
search term I used ("P?dagogik..."), when ICU is enabled. I our other
installations using chr indexing, this works correctly. It should not depend on
the search term.

It would be interesting to see the titles for your results maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:44:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 15:44:42 +0000
Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record
	details page.
In-Reply-To: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8688-70-auhFgzZ3us@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com,
                   |                            |francois.charbonnier at inlibr
                   |                            |o.com,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:45:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 15:45:17 +0000
Subject: [Koha-bugs] [Bug 11874] Add a "Call number fields" column to the
 Z39.50 search results.
In-Reply-To: <bug-11874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11874-70-1zCOiHBS1I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11874

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com,
                   |                            |eric.begin at inLibro.com,
                   |                            |francois.charbonnier at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:52:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 15:52:37 +0000
Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label
	Printing
In-Reply-To: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10773-70-8HJ0ZX2W8h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

--- Comment #19 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to Tom?s Cohen Arazi from comment #18)
> I would say this is an enhancement.

This is not the intended nor expected behavior which makes me lean toward it
being a true bug.

> But, anyway, Chris N. is about to post a
> followup with regression tests, so I'll be holding this until then.

FTR, here are my current thoughts on this:

This is going to be a bit of a problem to try to mock. Notice here:

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Labels/Label.pm;h=bd3ee4fe7bbdc723d9b8b13bbb22ba8da3686086;hb=HEAD#l81

we grab all of the data in 4 tables. I know that DBD::Mock allows mocking
resultsets, but this would require a significant amount of coding, and it is
not clear whether DBD::Mock will handle a join or not. The way I read the docs,
it will not.

I think the only way to do this is to make it run over a test database which
means it will not be run as part of the standard test suite.

I will be glad to write up a test for this, but question the value of it if it
will not be run as a part of the standard test suite.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 16:53:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 15:53:01 +0000
Subject: [Koha-bugs] [Bug 13833] New: biblionumber in deletedbiblio should
 not be autoincrement
Message-ID: <bug-13833-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13833

            Bug ID: 13833
           Summary: biblionumber in  deletedbiblio should not be
                    autoincrement
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

kohastructure.sql defines deletedbiblio's biblionumber field as int(11) not
null autoincrement surely that should be not null default 0 as with other
deletedxxx tables?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:19:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 16:19:21 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-j3ChW44vvZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:31:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 16:31:16 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
	guarantor search
In-Reply-To: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13021-70-oYjhootAuy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021

--- Comment #29 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Tom?s Cohen Arazi from comment #28)
> Jonathan, is it possible that the latest patch doesn't belong here?

Yep, same as bug 12648 comment 76:

  Created attachment 36810 [details] [review]
    Bug 12648: Fix conflict with bug 8096

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:31:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 16:31:30 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
	guarantor search
In-Reply-To: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13021-70-3vEW0dM9yr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35632|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:31:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 16:31:39 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
	guarantor search
In-Reply-To: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13021-70-o8eKTy5uQf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 17:32:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 16:32:00 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-iCDTWpemoj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #23 from Marc V?ron <veron at veron.ch> ---
Created attachment 36870
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36870&action=edit
Bug 13813 - Remove C4::Dates from C4/Log.pm

To test:
Apply patch
Go to Home > Tools > Logs
Search logs with different from- and to-dates, verify that date range displays
as appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:07:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 17:07:59 +0000
Subject: [Koha-bugs] [Bug 13834] New: News: Wording not consistent for
 Publication date / Creation date
Message-ID: <bug-13834-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834

            Bug ID: 13834
           Summary: News: Wording not consistent for Publication date /
                    Creation date
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To verify:

In staff client, go to Home > Tools > News: 
You see a column "Creation date"

Create or edit a news item: 
Field label is "Publication date"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:09:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 17:09:31 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-4uQgOAubyv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #24 from Marc V?ron <veron at veron.ch> ---
Created attachment 36871
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36871&action=edit
Bug 13813 - Remove C4::Dates from C4/NewsChannels.pm

To test:
Apply patch
Create some news for OPAC and staff client (Home > Tools > News)
Verify that dates appear as appropriate
Verify that Publicaten Date (Creation Date) and Expiration Date work as
expected.

Note: Inconsistency in wording for creation date / publication date should be
managed in separate Bug 13834

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 18:22:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 17:22:33 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-TsXCeaJhdM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #25 from Marc V?ron <veron at veron.ch> ---
Created attachment 36872
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36872&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from C4/Output.pm

To test:

Apply patch
Verify that C4::Dates is not used in code

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 19:07:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 18:07:20 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-JZjItRD5Np@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 19:07:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 18:07:22 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-utyLJU4OYh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36410|0                           |1
        is obsolete|                            |
  Attachment #36411|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36873
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36873&action=edit
[PASSED QA] Bug 13740: Remove the NOT NULL clause in GetBorrowersToExpunge

C4::Borrowers::GetBorrowersToExpunge should not use a "NOT IN", it is
not efficient at all.

With only 1 guarantor and more than 136k patrons, the not in clause in
this subroutine takes ages:
mysql> select count(*) FROM   borrowers where  borrowernumber NOT IN
(SELECT guarantorid FROM borrowers WHERE guarantorid IS NOT NULL AND
guarantorid <> 0) ;
[...]

not ended after 5min

With the query modified by this patch, the results come after 1 sec :)

Test plan:
Verify the delete_patrons.pl cronjob or the cleanborrowers tools work as
before.
Especially with guarantors.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Koha Team AMU <koha.aixmarseille at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 19:07:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 18:07:32 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-j6ZgtcTNUo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36874
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36874&action=edit
[PASSED QA] Bug 13740: Fix null vs not null in the query

The previous patch did not work, only patrons *with* guanrantees were
deleted!

Signed-off-by: Koha Team AMU <koha.aixmarseille at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 20:23:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 19:23:52 +0000
Subject: [Koha-bugs] [Bug 13330] All overdue items with fines returned via
 checkouts table will have fines forgiven!
In-Reply-To: <bug-13330-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13330-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13330-70-WPryuxWXc6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13330

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 20:35:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 19:35:09 +0000
Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine
	payment form.
In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-eC4Cp5qUos@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26108|0                           |1
        is obsolete|                            |

--- Comment #11 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Created attachment 36875
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36875&action=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

If the amount received is greater than the amount to pay, a message is
shown to tell the employee how much money to give back.

Signed-off-by: Joel Aloi <aloi54 at live.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 20:36:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 19:36:11 +0000
Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine
	payment form.
In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-1GvhC0dxwq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29757|0                           |1
        is obsolete|                            |

--- Comment #12 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Created attachment 36876
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36876&action=edit
Bug 11373 - Unit tests for Accounts.pm

I added unit tests for the modified subs in C4/Accounts.pm.
    makepartialpayment()
    WriteOffFee()

    modified:   t/db_dependent/Accounts.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 20:36:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 19:36:38 +0000
Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine
	payment form.
In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-79JfH5HYfv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29938|0                           |1
        is obsolete|                            |

--- Comment #13 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Created attachment 36877
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36877&action=edit
Bug 11373 - Fixed: 'Change to give back' not displaying.

I tested the last patch and found that the case 'amount oustanding == amount
paid' was not handled in paycollect.p .
The confirmation box should now appear when those values are equal and the
amount collected is higher than the amount paid.

I have found another problem while testing.
When paying all fines or selected fines, the 'The amount collected is greater
than the total amount paid.' message would appear even when the entered data
was correct.

Both issues were adressed in this patch.
    modified:   koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
    modified:   members/paycollect.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 20:43:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 19:43:48 +0000
Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine
	payment form.
In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-dokPTwcAjo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #14 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> ---
Fixed the conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 20:47:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 19:47:54 +0000
Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine
	payment form.
In-Reply-To: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-K0ulNobiP5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 21:36:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 20:36:31 +0000
Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no
 description set in authorized value
In-Reply-To: <bug-13399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13399-70-o7Yzv0nawh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 22:59:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 21:59:10 +0000
Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label
	Printing
In-Reply-To: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10773-70-eICEBHetz7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

--- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Chris, tests on t/db_dependent are considered standard and are always run by
the dev team and jenkins too, when pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 23:24:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 22:24:52 +0000
Subject: [Koha-bugs] [Bug 13784] Allow running Zebra daemon for disabled
 instances in packages
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-gxHPWKgyxb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 23:26:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 22:26:27 +0000
Subject: [Koha-bugs] [Bug 13750] Holds queue: Always show branch name,
	not branch code
In-Reply-To: <bug-13750-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13750-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13750-70-3hHC4Rx4El@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13750

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 23:27:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 22:27:56 +0000
Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not
 scanned" statuses
In-Reply-To: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12631-70-CfkpZjE8ku@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 23:29:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 22:29:18 +0000
Subject: [Koha-bugs] [Bug 13351] Untranslatable javascript in members.tt
In-Reply-To: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13351-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13351-70-ptx6u44Igk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 23:32:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 22:32:08 +0000
Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt
In-Reply-To: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13350-70-pDtfdyXzzb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 23:33:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 22:33:32 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-1rK5XPp5X7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 23:37:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 22:37:22 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-VcSjaRkJ5Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 23:39:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 22:39:44 +0000
Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name
 on patron details
In-Reply-To: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13657-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13657-70-TcyYaMSiLp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 13 23:41:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 13 Mar 2015 22:41:59 +0000
Subject: [Koha-bugs] [Bug 13785] koha-disable should also stop
 SIP/Zebra/Indexer for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-GJ2KHH727s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 03:34:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2015 02:34:59 +0000
Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed
In-Reply-To: <bug-8133-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8133-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8133-70-x0WrSXtrce@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 03:35:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2015 02:35:50 +0000
Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar
In-Reply-To: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11211-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11211-70-Xsdtw9IIMb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 06:42:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2015 05:42:22 +0000
Subject: [Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
In-Reply-To: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13254-70-zx5hDXtiIr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_16_candidate
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 16:33:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2015 15:33:34 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-fF4rRpZzpH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #26 from Marc V?ron <veron at veron.ch> ---
Created attachment 36878
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36878&action=edit
Bug 13813 - Remove C4::Dates from C4/Suggestions.pm

To test:
Apply patch
Go to Home > Acquisitions > Suggestions management
Verify in "Filter by" that filter works for Suggestion information / dates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 16:58:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2015 15:58:35 +0000
Subject: [Koha-bugs] [Bug 13835] New: Popup "Search for budget owner" should
 not display language menu in footer
Message-ID: <bug-13835-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835

            Bug ID: 13835
           Summary: Popup "Search for budget owner" should not display
                    language menu in footer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org

To verify:

Go to Home > Administration > Funds and edit a fund

Click on "Edit owner"

The popup displays a form "Search for budget owner" with language selection in
footer. This language selection is not nexessary here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 17:42:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2015 16:42:45 +0000
Subject: [Koha-bugs] [Bug 13770] There should be a command in Debian
 packages to switch to DOM indexing
In-Reply-To: <bug-13770-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13770-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13770-70-RElhtOuyrJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13770

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
zebra-biblios-dom.cfg gets added by the packages anyway, so it's just the
koha-conf.xml changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 14 18:31:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 14 Mar 2015 17:31:43 +0000
Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT
In-Reply-To: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13433-70-Ag2ykdpYtK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433

--- Comment #3 from Winona Salesky <wsalesky at gmail.com> ---
Thanks, I will have them following Subjects.
-Winona

(In reply to rgravel from comment #2)
> I'm not exactly sure where "Material type" is landing now, however, I will
> note that Genre/Form headings are closely related to "Subject(s)," and so I
> think they should be displayed near them. I had originally contemplated them
> following "Subject(s)" but am open to other suggestions!
> 
> Thanks so much, Winona!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 07:32:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 06:32:47 +0000
Subject: [Koha-bugs] [Bug 13836] New: Koha/Number/Price.pm:
 format_for_editing fails 3 tests because of leading spaces in output
Message-ID: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

            Bug ID: 13836
           Summary: Koha/Number/Price.pm: format_for_editing fails 3 tests
                    because of leading spaces in output
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org

#   Failed test 'format_for_editing should return unformated integer part with
2 decimals'
#   at t/Prices.t line 610.
#          got: ' 1234567.00'
#     expected: '1234567.00'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 08:25:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 07:25:24 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-5ORt8vwowl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #27 from Marc V?ron <veron at veron.ch> ---
Created attachment 36879
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36879&action=edit
Bug 13813 - Remove C4::Dates from C4/VirtualShelves/Page.pm

To test:
Apply patch
In staff client, go to Home > Lists
Verify that list of lists displays as before
In OPAC, go to Lists
Verify that Public and Private Lists display as before

Note: 'dateadded' is not displayed in lists of lists.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 09:13:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 08:13:15 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-boyUVvfBsB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #28 from Marc V?ron <veron at veron.ch> ---
Created attachment 36880
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36880&action=edit
Bug 13813 - Remove C4::Dates from members/printinvoice.pl

To test:
Apply patch
Go to a patrons Account
In table of fines / transactions, column 'Print', click on 'Print' of a
transaction
Verify that the date displays correctly on the invoice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 09:35:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 08:35:41 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-tdNZxAqexk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #29 from Marc V?ron <veron at veron.ch> ---
Created attachment 36881
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36881&action=edit
Bug 13813 - Remove C4::Dates from members/printfeercpt.pl

To test:
Apply patch
Go to a patrons Account
In table of fines / transactions, column 'Print', click on 'Print' of a payment
transaction ("Payment, thanks")
Verify that the date displays correctly on the receipt.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 10:14:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 09:14:25 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-MJSUlDjQ71@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #30 from Marc V?ron <veron at veron.ch> ---
Created attachment 36882
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36882&action=edit
Bug 13813 - Remove C4::Dates from circ/bookcount.pl

To test:
Apply patch
Search a biblio with items that are or have been checked out
Go to "Items" (moredetail.pl)
Locate "Total checkouts" of an item and click 'View item's checkout hsitory'
Verify date and time in column "Last seen"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 10:37:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 09:37:05 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-iTm1vpBHO9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #31 from Marc V?ron <veron at veron.ch> ---
Created attachment 36883
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36883&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from members/notices.pl

To test:
Apply patch
Verify that C4::Dates is not used in members/notices.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 10:54:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 09:54:20 +0000
Subject: [Koha-bugs] [Bug 13837] New: Popup "Search for garantor" should not
 display language menu in footer
Message-ID: <bug-13837-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13837

            Bug ID: 13837
           Summary: Popup "Search for garantor" should not display
                    language menu in footer
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To verify:

Edit a patrons's detail
Add or change Guarantor information
Popup "Search for guarantor" displays language menu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 11:01:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 10:01:14 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-yJHHO4tkCr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #32 from Marc V?ron <veron at veron.ch> ---
Created attachment 36884
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36884&action=edit
Bug 13813 - Remove C4::Dates from members/guarantor_search.pl

To test:
Edit a patron's detail
Add or modify guarantor information
Do a search in  popup "Search for guarantor"
Verify that dates ob birth display correctly in list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 11:10:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 10:10:49 +0000
Subject: [Koha-bugs] [Bug 13835] Popup "Search for budget owner" should not
 display language menu in footer
In-Reply-To: <bug-13835-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13835-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13835-70-hkgoyvYR7J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13837

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 11:10:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 10:10:49 +0000
Subject: [Koha-bugs] [Bug 13837] Popup "Search for garantor" should not
 display language menu in footer
In-Reply-To: <bug-13837-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13837-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13837-70-WuJIHHDcoi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13837

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13835

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 12:07:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 11:07:44 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-lm2NSiE5L6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #33 from Marc V?ron <veron at veron.ch> ---
Created attachment 36885
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36885&action=edit
Bug 13813 - Remove C4::Dates from members/moremember.pl

To test:
Apply patch
Go to a patron's Details page (moremember.pl)
Verify that dates display correctly (birth date, registration, espiration,
manual restriction with date)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 12:15:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 11:15:53 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-xwWMJLu85w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #34 from Marc V?ron <veron at veron.ch> ---
Created attachment 36886
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36886&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-messaging.pl

To test:

Apply patch
Verify that C4::Dates is not used in code

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 12:23:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 11:23:38 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-RoISPU5Prt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #35 from Marc V?ron <veron at veron.ch> ---
Created attachment 36887
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36887&action=edit
Remove superfluous use 'C4::Dates' from opac/opac-privacy.pl

To test:

Apply patch
Verify that C4::Dates is not used in code

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 12:27:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 11:27:24 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-Q3D2jwzFx9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #36 from Marc V?ron <veron at veron.ch> ---
Created attachment 36888
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36888&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-ratings.pl

To test:

Apply patch
Verify that C4::Dates is not used in code

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 12:36:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 11:36:23 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-wybv2b3mZr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #37 from Marc V?ron <veron at veron.ch> ---
Created attachment 36889
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36889&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-search-history.pl

To test:

Apply patch
Verify that C4::Dates is not used in code
Enable display of reading history in OPAC (syspref opacreadinghistory)
Diesplay reading history in OPAC, should behave as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 12:40:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 11:40:31 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-IMuOnKxFCj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36889|0                           |1
        is obsolete|                            |

--- Comment #38 from Marc V?ron <veron at veron.ch> ---
Created attachment 36890
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36890&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-search-history.pl

To test:

Apply patch
Verify that C4::Dates is not used in code
Enable display of search history in OPAC (syspref EnableOpacSearchHistory)
Diesplay search history in OPAC, should behave as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 13:05:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 12:05:22 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-ZDXZP3RmZ4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36891
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36891&action=edit
Bug 13814: (QA followup) test for generated warnings

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 13:11:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 12:11:16 +0000
Subject: [Koha-bugs] [Bug 13746] On creating a new subscription,
 notes fields get confused
In-Reply-To: <bug-13746-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13746-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13746-70-1wxOFyxfyP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Katrina and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 13:11:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 12:11:42 +0000
Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item
	form
In-Reply-To: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13648-70-oS30RdRFjn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 13:12:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 12:12:13 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-h0LxL62dSN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #26 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 13:12:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 12:12:46 +0000
Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format
	dates
In-Reply-To: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4402-70-YU1ARDf6Y3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #34 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 13:13:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 12:13:35 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-l59Vsdd0s8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Julian, and congratulations!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 13:14:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 12:14:16 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-5FrLxiuGmZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Good catch Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 13:14:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 12:14:46 +0000
Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable
	version
In-Reply-To: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12399-70-9ZHigUqffi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 13:23:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 12:23:04 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-hN8Guv65KS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 13:23:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 12:23:45 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-oTpRdFhyFv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Maxime!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 14:01:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 13:01:36 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-F4pVO4cILJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #39 from Marc V?ron <veron at veron.ch> ---
Created attachment 36892
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36892&action=edit
Bug 13813 - Remove C4::Dates from opac/opac-user.pl

To test:
Apply patch
Manually restrict a patron (with end date)
Check in to OPAC with this patron's username/password
Verify that message about restrictions displays restriction date correctly in
tab "Your summary" (opac-user.pl)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 14:30:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 13:30:51 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-1yIZ0pw0po@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #40 from Marc V?ron <veron at veron.ch> ---
Created attachment 36893
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36893&action=edit
Bug 13813 - Remove C4::Dates from patroncards/members-search.pl

To test:
Apply patch
In staffclient go to Home > Tools > Patron card creator
Create new batch or edit existing one
Click button "Add Item(s)and perform a search in  pop-up "Patron search"
(patroncards/members-search.pl)
Verify that dates in column "Expires on" display correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:14:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 14:14:14 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-kTeOdVCWEV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #41 from Marc V?ron <veron at veron.ch> ---
Created attachment 36894
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36894&action=edit
Bug 13813 - Remove C4::Dates from reserve/request.pl

To test:
Apply patch
Search a biblio in staff client and place hold. This will take you to
reserve/request.pl
Add / Suspend / Unsuspend / hold(s)
Verify that all dates behave and display OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:35:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 14:35:21 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-fnyzMkX0iG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #42 from Marc V?ron <veron at veron.ch> ---
Created attachment 36895
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36895&action=edit
Bug 13813 - Remove C4::Dates from circ/waitingreserves.pl

To test:
Go to Home > Circulation > Holds awaiting pickup
(Circulation Rports - Holds awaiting pickup)

Verify that date in page title appears correcty

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 15:45:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 14:45:20 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-1fqsgNZC2g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #43 from Marc V?ron <veron at veron.ch> ---
Created attachment 36896
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36896&action=edit
Bug 13813 - Remove C4::Dates from circ/circ/transferstoreceive.pl

To test:
Go to Home > Circulation > Transfers to your library
(Circulation Reports - Transfers to receive)

Verify that date in page title appears correcty

w

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:05:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 16:05:33 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-dixqWT5W38@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #44 from Marc V?ron <veron at veron.ch> ---
Created attachment 36897
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36897&action=edit
Bug 13813 - Remove C4::Dates from cataloguing/value_builder/barcode.pl

To test:
Set syspref autoBarcode to <year>-001, <year>-002  and <branchcode>yymm001
Edit items or add item, click in empty barcode field, verify that barcodes are
filled in as appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:18:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 16:18:57 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-7p03dLa8K9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.sassmannshausen at ptfs-e
                   |                            |urope.com
                URL|                            |http://wiki.koha-community.
                   |                            |org/wiki/Inter_Library_Loan
           Assignee|koha-bugs at lists.koha-commun |alex.sassmannshausen at ptfs-e
                   |ity.org                     |urope.com
   Patch complexity|---                         |Large patch

--- Comment #6 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Hello,

PTFS Europe is working on ILL functionality within Koha. See the URL above for
a link to the RFC.

Best wishes,

Alex

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:20:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 16:20:58 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-HnicPiUE9K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://wiki.koha-community. |http://wiki.koha-community.
                   |org/wiki/Inter_Library_Loan |org/wiki/ILL_Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 17:58:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 16:58:09 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-lrOjhN8gLV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #45 from Marc V?ron <veron at veron.ch> ---
Created attachment 36898
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36898&action=edit
Bug 13813 - Remove C4::Dates from cataloguing/value_builder/barcode_manual.pl

To test:
Apply patch
Set the plugin for 952$p (or UNIMARC equivalent to items.barcode) for one of
your frameworks to barcode_manual.pl instead of barcode.pl
Set syspref autoBarcode to <year>-001, <year>-002  and <branchcode>yymm001
Edit items or add item, verify that barcodes are filled in as appropriate by
clicking on the value builder link (...)
(Note: Description of barcode_manual.pl in Bug 8524)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:18:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 17:18:34 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-xN89hRwFAS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #46 from Marc V?ron <veron at veron.ch> ---
Created attachment 36899
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36899&action=edit
Bug 13813 - Remove C4::Dates from cataloguing/value_builder/dateaccessioned.pl

To test:
Apply patch
Edit an item
Verifiy that autofilling date in d - Date acquired works as before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:41:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 17:41:58 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-SASWPIMgab@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #47 from Marc V?ron <veron at veron.ch> ---
Created attachment 36900
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36900&action=edit
Bug 13813 - Remove C4::Dates from tools/koha-news.pl

To test:
Apply patch
Go to Home > Tools > News
Verify that dates appear as expected in date columns
Create and edit news, verify dates behave as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 18:56:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 17:56:00 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-SrA1SzNz9v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36890|0                           |1
        is obsolete|                            |

--- Comment #48 from Marc V?ron <veron at veron.ch> ---
Created attachment 36901
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36901&action=edit
Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-search-history.pl

To test:

Apply patch
Verify that C4::Dates is not used in code
Go to ome > Tools > Logs
Display logs with from and to dates
Verify that search range behaves as expected.
'
(Note: In table 'XXXX lines found', date and time always appear as timestamp as
before)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 19:36:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 18:36:07 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-s1BdqCzH3E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #49 from Marc V?ron <veron at veron.ch> ---
Created attachment 36902
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36902&action=edit
Bug 13813 - Remove C4::Dates from tools/scheduler.pl

To test:
Apply patch
Go to Home > Tools > Task scheduler
Add new tasks
Verify that tasks are properly added

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 20:54:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 19:54:13 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-5RVPlqxirg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 21:09:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 20:09:07 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-OZwEhOBGpR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Priority|P5 - low                    |P3
   Patch complexity|---                         |Trivial patch

--- Comment #50 from Marc V?ron <veron at veron.ch> ---
So far, deprecated C4::Date is removed from 40+ files

I would appreciate if somebody could start signing off. I added a patch and a
test plan for every file. Most of the changes and tests ar rather trivial.

Please be aware that for parts of the patches depend on Bug 13601.

There are still about 90 files left with C4::Date - it still will be al long
way until we can have more international date formats (like dd.mm.yyyy -
blocked Bug 12072).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 21:14:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 20:14:45 +0000
Subject: [Koha-bugs] [Bug 13646] Facets encoding problem with GRS1
In-Reply-To: <bug-13646-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13646-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13646-70-Y0HsuBQrFo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Jonathan, is this still needed with the other patches to fix the encoding
problems?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:08:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 21:08:44 +0000
Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in
	XSLT
In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13387-70-Pi5mtJz5Rq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387

--- Comment #3 from Winona Salesky <wsalesky at gmail.com> ---
Okay, thanks!
-Winona

(In reply to rgravel from comment #2)
> I don't know that it's necessary to crowd the brief display in the results
> list. Currently "Other title" does display in the results, and that may be
> more useful to patrons than the uniform title, so I personally think it's ok
> to just keep the uniform title in the full record display.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:14:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 21:14:08 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-af3AnAQRKn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
With this patch I can't run the web installer in my dev installation. Following
error is displayed:

Cannot open log file
/home/katrin/koha-dev/var/log/updatedatabase_2015-03-15T21:59:53.log: No such
file or directory at /home/katrin/kohaclone/installer/install.pl line 332.

After reverting the patch the update process is completed normally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:19:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 21:19:09 +0000
Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in
	XSLT
In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13387-70-Jkh4paVmHL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387

--- Comment #4 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 36903
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36903&action=edit
Updates display of Uniform Title in full display for OPAC and Staff views

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:22:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 21:22:28 +0000
Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt
 and serials-recieve.tt
In-Reply-To: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13423-70-lBJFQSvKnU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have no problem with these fixes, but I wonder how to trigger the messages. I
didn't manage to - is this code still in use?
Please check and amend test plan - thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 22:30:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 21:30:57 +0000
Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly
In-Reply-To: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10827-70-dlUyiKuqyU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please take a look at my comment #30.  I am not in favor of setting the waiting
status automatically. In my opinion this should always require a check in, so
that we can trigger the printing of the next slip.

Moving this to "In discussion".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:07:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 22:07:22 +0000
Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly
In-Reply-To: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10827-70-gwvAtVWjY6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827

--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Apart from the general question if this is desirable behaviour, a quick test
showed a problem:

1) Place a title level hold for A
2) Place an item level hold for B
3) Check in item
4) Confirm hold for A
5) Check hold list: Both holds are marked waiting.

Repeated the test after deleting both holds with 2 item level holds, same
result.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:14:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 22:14:52 +0000
Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt
 and serials-recieve.tt
In-Reply-To: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13423-70-cEuBt3M8f8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Katrin Fischer from comment #5)
> I have no problem with these fixes, but I wonder how to trigger the
> messages. I didn't manage to - is this code still in use?
> Please check and amend test plan - thx!

Hehe :)

I don't put better instructions because I down't know either how to trigger the
messages

I'll check!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:18:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 22:18:06 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-tQSdlRA4G6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This breaks t/Letters.t - tests pass OK on master:

perl t/Letters.t 
1..5
ok 1 - use C4::Letters;
ok 2 - letter name for "ISBN" letter is book
ok 3 - GetLetters returns the 2 inserted letters
Use of uninitialized value $date_format in string eq at
/home/katrin/kohaclone/Koha/DateUtils.pm line 79.
Use of uninitialized value $date_format in string eq at
/home/katrin/kohaclone/Koha/DateUtils.pm line 89.
Use of uninitialized value $date_format in string eq at
/home/katrin/kohaclone/Koha/DateUtils.pm line 99.
Use of uninitialized value $date_format in string eq at
/home/katrin/kohaclone/Koha/DateUtils.pm line 99.
Use of uninitialized value $date_format in concatenation (.) or string at
/home/katrin/kohaclone/Koha/DateUtils.pm line 104.
Invalid dateformat parameter () at /home/katrin/kohaclone/Koha/DateUtils.pm
line 104.
# Looks like you planned 5 tests but ran 3.
# Looks like your test exited with 255 just after 3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:29:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 22:29:53 +0000
Subject: [Koha-bugs] [Bug 13748] Acquisition wizard: some strings not
	translatable
In-Reply-To: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13748-70-IsT55i61Xy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:29:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 22:29:56 +0000
Subject: [Koha-bugs] [Bug 13748] Acquisition wizard: some strings not
	translatable
In-Reply-To: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13748-70-lPvCTBYYuw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36775|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36904
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36904&action=edit
[PASSED QA] Bug 13748: Acquisition wizard: some strings not translatable

This patch removes all instances of CGI::scrolling_list from
reports/acquisitions_stats.pl, which prevented proper translation

To test:
1) Install and enable a language (es-ES or de-DE are good choices)
2) On Acquisitons wizard, some pulldown labels are not translated
3) Apply the patch
4) Update and install again the language
5) Check labels are translated and all pulldown works

This does not solve the 'Collection code' problem,
is more strange

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, good improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:42:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 22:42:55 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-igANtTF7Gk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Katrin, i tested both with and without plack on a regular dev install before
pushing. Please share some details about your directory structure and
permission.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:48:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 22:48:06 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-1jjWHLMotg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sure, it might be my installation, but I thought it would be better to have
someone check. This is a standard dev installation. The logs are being written
to  /home/katrin/koha-dev/var/log

The files within the directory currently are:
-rw-r--r-- 1 root   root   436429 M?r 15 23:11 koha-error_log
-rw-r--r-- 1 root   root    98095 M?r  6 14:55 koha-opac-error_log
-rw-r--r-- 1 katrin katrin   3657 M?r 15 02:46 koha-zebradaemon.err
-rw-r--r-- 1 katrin katrin  13428 M?r 15 23:19 koha-zebradaemon-output.log

I am not sure why there is a mix of root/katrin. Writing to the existing files
seems to work alright.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 15 23:53:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 22:53:36 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-9lWqYq1VFZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
And permissions on the directory itself:

drwxr-xr-x 2 katrin katrin 4096 M?r 15 23:45 log

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:02:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:02:07 +0000
Subject: [Koha-bugs] [Bug 13768] in quotes.tt line 14 the use of \" break
	the translation
In-Reply-To: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13768-70-zsMQsEdORv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:02:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:02:09 +0000
Subject: [Koha-bugs] [Bug 13768] in quotes.tt line 14 the use of \" break
	the translation
In-Reply-To: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13768-70-hnGjZKccF8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36770|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36905
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36905&action=edit
[PASSED QA] Bug 13768: Correction of double quotes escaped into double quotes

Without the patch the translated pages for quotes.tt may have the problematic
line broken.
So the js is broken too. The line with bad usage of double quotes escaped :
var sEmptyTable = _("No quotes available. Please use the \"Add quote\" button
to add a quote.");

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

diff on staff PO file

-msgid ""
-"No quotes available. Please use the \\\"Add quote\\\" button to add a quote."
+#, fuzzy
+msgid "No quotes available. Please use the 'Add quote' button to add a quote."

No koha-qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:06:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:06:51 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-zYOIkwsdC2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:06:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:06:54 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-DK2tzEzNwJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36668|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36906
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36906&action=edit
[PASSED QA] Bug 13801: svc/bib - Set charset to utf-8 on printing header

Test plan:
0/ Add unicode characters on the record biblionumber=X
1/ go on http://<staff-interface>/cgi-bin/koha/svc/bib/X
2/ Confirm you have encoding issues
3/ Apply the patch
4/ Repeat 2
5/ Confirm that all is correctly encoded

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:09:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:09:22 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-qFu0LUuIYU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Marc,

they pass ok for me:

prove t/Prices.t 
t/Prices.t .. ok     
All tests successful.
Files=1, Tests=16,  1 wallclock secs ( 0.04 usr  0.00 sys +  0.59 cusr  0.05
csys =  0.68 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:23:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:23:46 +0000
Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32
In-Reply-To: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13586-70-rmhDHKeTts@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:23:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:23:49 +0000
Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32
In-Reply-To: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13586-70-vdFTLlIO7S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36697|0                           |1
        is obsolete|                            |
  Attachment #36698|0                           |1
        is obsolete|                            |
  Attachment #36699|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36907
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36907&action=edit
[PASSED QA] Bug 13586: Makefile.PL mentions win32

Edited Makefile.PL to remove mentions of win32
To test: Run Makefile.PL

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:24:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:24:06 +0000
Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32
In-Reply-To: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13586-70-vfN6OV5FA6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36908
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36908&action=edit
[PASSED QA] Bug 13586: Remove the entire block

Previous patch remove the condition but not the block tested.
The entire block should be removed.

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:24:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:24:22 +0000
Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32
In-Reply-To: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13586-70-XORu9gyb6h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36909
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36909&action=edit
[PASSED QA] Bug 13586: Remove some other occurrences

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:41:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:41:51 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-T4Knp4vyXg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:41:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:41:53 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-OWWMtth9S9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36648|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:41:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:41:56 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-a2Fj5xINPc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36649|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:41:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:41:58 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-hY7ET9zc9A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36669|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:42:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:42:00 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-1sxhIX4sMT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36670|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:42:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:42:57 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-ycpY3Zdgsp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36910
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36910&action=edit
[PASSED QA] Bug 10703: Update course reserves DB documentation

To test review database documentation to see that course tables are
all documented.

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:43:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:43:01 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-o6e6nv4KbD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36911
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36911&action=edit
[PASSED QA] Bug 10703: Update stats table documentation

This patch updates the DB documentation for the statistics
table.

To test review the file and cofirm that documentation is there

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:43:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:43:05 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-O8vtvn3PWc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36912
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36912&action=edit
[PASSED QA] Bug 10703: Update Patron DB Documentation

Update patron categories and patron restrictions DB docs.

To test:

* Review database documentation for categories
* Review database documentation for patron_debarments

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 00:43:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 15 Mar 2015 23:43:08 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-9fNZwYtpFq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36913
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36913&action=edit
[PASSED QA] Bug 10703: Add more serial table DB documentation

This patch adds a bit more documentation to the serial related tables
in Koha.

To test, apply the patch and review the kohastructure for comments

Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:22:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 00:22:16 +0000
Subject: [Koha-bugs] [Bug 13746] On creating a new subscription,
 notes fields get confused
In-Reply-To: <bug-13746-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13746-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13746-70-UpECrXvZ4X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:23:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 00:23:33 +0000
Subject: [Koha-bugs] [Bug 13831] Item history is anonymized when borrower
 anonymizes his reading history using Immediate deletion
In-Reply-To: <bug-13831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13831-70-MVJbYtUlRi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13831

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Olli,

this might be interesting for you: bug 9011

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:24:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 00:24:06 +0000
Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU
	indexing
In-Reply-To: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13751-70-74h5Ec1Y8x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #6)
> Hi David,
> 
> I am not sure how to interpret your test results. The problem I see is that
> the search seems to work... but the records titles DON'T BEGIN all with with
> the search term I used ("P?dagogik..."), when ICU is enabled. I our other
> installations using chr indexing, this works correctly. It should not depend
> on the search term.
> 
> It would be interesting to see the titles for your results maybe?

Ah, I think I wasn't understanding your original question.

My test was just to show that a "ti" and a "ti,ext" search weren't returning
the same results. In my example, the former returned 5 results while the latter
returned 0.

I'll have to look more at this another time...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:30:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 00:30:22 +0000
Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item
	form
In-Reply-To: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13648-70-MKYVOTPyb7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:47:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 00:47:29 +0000
Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
In-Reply-To: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13531-70-W6hpvPFwF1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I see the warn, but not the message in the log file. Leaving this for Martin to
check again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:59:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 00:59:27 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-Q4VWGWzPRT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:59:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 00:59:29 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-oPlfvse1gG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36663|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:59:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 00:59:31 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-yARMvOuqVv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36475|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 01:59:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 00:59:34 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-xCcCClQ7fB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36471|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:00:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:00:24 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-dZ4Td2VQxO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36914
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36914&action=edit
[PASSED QA] Bug 11201: Add a in-house use list pages

The circulation page has a new entry: a link to a list of the pending
in-house use.

Bug 10860 introduces a new way for managing in-house uses.
This patch adds a new page (from the circulation home page) to list all
pending in-house uses.

Test plan:
Go on the circulation home page and click on the in-house use link.
Verify all your in-house uses are listed and information are consistent.

Bug 11201: Display lib instead of AV code

This patch assumes that items.location is linked the the LOC
authorised values.

Signed-off-by: Nicole <nicole at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:00:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:00:27 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-IaULMrLkw9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36915
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36915&action=edit
[PASSED QA] Bug 11201: Display overdues in red

On the pending on-site checkout list, the date for overdues are now
displayed in red.

Test plan:
Make sure you have on-site checkouts created today and before.
The date for the ones created before today should be displayed in red.

Signed-off-by: Nicole <nicole at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:00:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:00:30 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-MWWqxLIqzo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36916
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36916&action=edit
[PASSED QA] Bug 11201: qa-followup

- move h4 to h1
- Make the link on the circ home page depending on the pref

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:00:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:00:34 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-btXhdx6CNU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36917
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36917&action=edit
Bug 11201 - QA follow-up - Pending on-site checkouts

Changes page name to "Pending on-site checkouts" as
agreed during the hackfest.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:06:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:06:30 +0000
Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by
	relevance
In-Reply-To: <bug-13414-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13414-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13414-70-KO1VUozorA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
David, Team Lyon3, how do we proceed here?
Would you be ok with me changing the sysprefs.sql file back to the old label?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:07:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:07:41 +0000
Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are
 several issues per unit
In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12671-70-EsYr4qv6Yn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Patch doesn't apply

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, patches no longer apply on current master:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12671: Guess next serial date when there are several issues per
unit. Added support for real month and year lenghts.
fatal: sha1 information is lacking or useless (C4/Serials.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 12671: Guess next serial date when there are several
issues per unit. Added support for real month and year lenghts.
The copy of the patch that failed is found in:
   /home/katrin/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-12671-Guess-next-serial-date-when-there-are-se-UWVsuV.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:16:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:16:42 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
	for serials
In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8296-70-L2HA8HvIKj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #99 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Going to work on this next. Julian - could you check the last patch if you like
or hate it? I have no problem with either, but would be good to have your
feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:20:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:20:12 +0000
Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT
In-Reply-To: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13433-70-s5aYKxOFqe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433

--- Comment #4 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 36918
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36918&action=edit
655 display in XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:23:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:23:28 +0000
Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs
In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13734-70-y2vSvvOf1f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

--- Comment #3 from Winona Salesky <wsalesky at gmail.com> ---
Is this for both the results list and the details pages? Or just in the
details?
Thanks,
-Winona


(In reply to Nicole C. Engard from comment #2)
> Created attachment 36825 [details]
> Example MARC
> 
> Here a few records with 33x fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:39:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:39:28 +0000
Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs
In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13734-70-4gc4anyvzI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

--- Comment #4 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 36919
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36919&action=edit
Add fields 336, 337 and 338 to the full displays in the staff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:40:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:40:09 +0000
Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs
In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13734-70-yY1pBdegty@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

--- Comment #5 from Winona Salesky <wsalesky at gmail.com> ---
I think some css work will need to be done to get them to display inline? Or if
necessary, I can change the output in the xslt. 


(In reply to Winona Salesky from comment #4)
> Created attachment 36919 [details] [review]
> Add fields 336, 337 and 338 to the full displays in the staff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:47:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:47:38 +0000
Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs
In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13734-70-thKhdSQbSQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36919|0                           |1
        is obsolete|                            |

--- Comment #6 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 36920
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36920&action=edit
Updates 336, 337 and 338 to the full displays in the staff and OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 02:48:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 01:48:11 +0000
Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs
In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13734-70-lTmhCjKRTU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

--- Comment #7 from Winona Salesky <wsalesky at gmail.com> ---
Never mind, I fixed it so they appear inline. 

-Winona

(In reply to Winona Salesky from comment #6)
> Created attachment 36920 [details] [review]
> Updates 336, 337 and 338 to the full displays in the staff and OPAC

(In reply to Winona Salesky from comment #5)
> I think some css work will need to be done to get them to display inline? Or
> if necessary, I can change the output in the xslt. 
> 
> 
> (In reply to Winona Salesky from comment #4)
> > Created attachment 36919 [details] [review] [review]
> > Add fields 336, 337 and 338 to the full displays in the staff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 07:52:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 06:52:28 +0000
Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
In-Reply-To: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8995-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8995-70-pIPwB8HnFB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This patch conflicts in a since removed CSS file:
CONFLICT (modify/delete): koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css

Looking at the patch I can see that the .less file for bootstrap has been
modified, but there is no updated generated CSS file, but only the change to
the outdated file. Can you check please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 07:53:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 06:53:24 +0000
Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU
	indexing
In-Reply-To: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13751-70-S5pbD3IPma@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:09:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 07:09:05 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-RnSjpKVDjA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Hi Katrin,

See my results below. 
Maybe related to Number::Format?

cpan -D Number::Format     
Installed: 1.73
CPAN:      1.73  up to date

http://search.cpan.org/~wrw/Number-Format-1.73/Format.pm

Koha version 3.19.00.016
Perl version 5.014002

------------
prove t/Prices.t
t/Prices.t .. 1/16 
#   Failed test 'format_for_editing should return unformated integer part with
2 decimals'
#   at t/Prices.t line 610.
#          got: ' 1234567.00'
#     expected: '1234567.00'

#   Failed test 'format_for_editing should return unformated integer part with
2 decimals'
#   at t/Prices.t line 611.
#          got: ' 1234567.89'
#     expected: '1234567.89'

#   Failed test 'format_for_editing should return unformated integer part with
2 decimals'
#   at t/Prices.t line 610.
#          got: ' 1234567.00'
#     expected: '1234567.00'

#   Failed test 'format_for_editing should return unformated integer part with
2 decimals'
#   at t/Prices.t line 611.
#          got: ' 1234567.89'
#     expected: '1234567.89'
# Looks like you failed 4 tests of 16.
t/Prices.t .. Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/16 subtests 

Test Summary Report
-------------------
t/Prices.t (Wstat: 1024 Tests: 16 Failed: 4)
  Failed tests:  13-16
  Non-zero exit status: 4
Files=1, Tests=16,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.35 cusr  0.18
csys =  0.55 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:16:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 07:16:29 +0000
Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU
	indexing
In-Reply-To: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13751-70-6GzlDRR6mo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751

--- Comment #8 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Katrin Fischer from comment #1)
> Hm, I have to correct:
> 
> ti= gives more results than ti,ext=
> But: results don't match the expected result. I am not really sure what is
> happening there.
> 
> On a non-ICU installation something like:
> ti,ext=P?dagogik
> Works perfectly, all titles shown start with P?dagogik.

I guess Zebra version being used may be somehow relevant. Such searches were
indeed not working correctly w/ ICU in some older versions (like 2.0.44,
shipped by default with Debian Wheezy). AFAIRC, in particular 'ext' (4=1 6=3)
was affected by this, but also other bib-1 structure, position and trucation
attributes (or maybe just some specific combinations of thereof ?) were not yet
properly supported in 2.0.44 with ICU enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:22:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 07:22:46 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-ZJ2SI72zse@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I know this is old code, so not sure about DBIX or use of the new Koha Object,
but quite sure we should have tests! These patches only remove a few tests, but
none are added for the new module.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 08:24:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 07:24:10 +0000
Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU
	indexing
In-Reply-To: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13751-70-kZQjQxMaFf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jacek, thx for looking into this. Do you know if it works for newer versions
and if it's safe to use a newer version?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 09:05:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 08:05:29 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
	for serials
In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8296-70-yi84PMAHng@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #100 from Julian Maurice <julian.maurice at biblibre.com> ---
Hi Katrin,

Your patch is ok, no problem at all, it is already signed off ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 09:25:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 08:25:17 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-pFJ2iHzMMm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Marc, I have the same version. What is your locale setting?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 09:54:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 08:54:05 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-xh3kf6IAs5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #9 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Cannot open log file
/usr/share/kohadev/testclone/var/log/updatedatabase_2015-03-16T09:42:31.log: No
such file or directory at /usr/share/koha/testclone/installer/install.pl line
332.

If I update via the webinstaller, the apache user has no permission to write a
new log file in that directory.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 10:12:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 09:12:41 +0000
Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by
	relevance
In-Reply-To: <bug-13414-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13414-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13414-70-XvgdYdP62Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414

--- Comment #14 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
(In reply to Katrin Fischer from comment #13)
> David, Team Lyon3, how do we proceed here?
> Would you be ok with me changing the sysprefs.sql file back to the old label?

it's ok for me
          Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 10:23:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 09:23:34 +0000
Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
In-Reply-To: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13531-70-uNcGssfxyb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks good to me Katrin.. those errors will only appear in pretty specific
cases.. your probably just not causing them?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:05:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:05:02 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-geC3Qmy20x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Hi Katrin,

# dpkg -l locales

||/ Name           Version      Architektur  Beschreibung
+++-==============-============-============-=================================
ii  locales        2.13-38+deb7 all          Embedded GNU C Library: National 

# locale
LANG=de_CH.UTF-8
LANGUAGE=de_CH:de
LC_CTYPE="de_CH.UTF-8"
LC_NUMERIC="de_CH.UTF-8"
LC_TIME="de_CH.UTF-8"
LC_COLLATE="de_CH.UTF-8"
LC_MONETARY="de_CH.UTF-8"
LC_MESSAGES="de_CH.UTF-8"
LC_PAPER="de_CH.UTF-8"
LC_NAME="de_CH.UTF-8"
LC_ADDRESS="de_CH.UTF-8"
LC_TELEPHONE="de_CH.UTF-8"
LC_MEASUREMENT="de_CH.UTF-8"
LC_IDENTIFICATION="de_CH.UTF-8"
LC_ALL=

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:42:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:42:50 +0000
Subject: [Koha-bugs] [Bug 3474] Handling of and report for expired or
 cancelled holds, display expiration dates
In-Reply-To: <bug-3474-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3474-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3474-70-1LyUYBFRrr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3474

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is a cronjob as well to cancel expired holds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:43:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:43:50 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-antsZgL99n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
With de_DE.UTF-8 *) tests pass OK

What impact have locales on Koha?
Could there be bugs related to locales?


*)
# locale
LANG=de_DE.UTF-8
LANGUAGE=de_CH:de
LC_CTYPE="de_DE.UTF-8"
LC_NUMERIC="de_DE.UTF-8"
LC_TIME="de_DE.UTF-8"
LC_COLLATE="de_DE.UTF-8"
LC_MONETARY="de_DE.UTF-8"
LC_MESSAGES="de_DE.UTF-8"
LC_PAPER="de_DE.UTF-8"
LC_NAME="de_DE.UTF-8"
LC_ADDRESS="de_DE.UTF-8"
LC_TELEPHONE="de_DE.UTF-8"
LC_MEASUREMENT="de_DE.UTF-8"
LC_IDENTIFICATION="de_DE.UTF-8"
LC_ALL=

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:45:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:45:41 +0000
Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list
 of books with forced item holds
In-Reply-To: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13479-70-ujtzysRH4I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:45:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:45:43 +0000
Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list
 of books with forced item holds
In-Reply-To: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13479-70-w1Rv5oH9UZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36608|0                           |1
        is obsolete|                            |

--- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36921
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36921&action=edit
Bug 13479: Enable/disable forced item holds on biblio level

This is a follow-up of report 13478.
If you set OPACItemHolds to 'selectiveforce', you can now enable or disable
forced item holds on biblio level on the Holds tab of the staff detail
page.

TEST PLAN:
[1] Run the adjusted unit test (t/db_dependent/Reserves.t).
[2] Set OPACItemHolds to Allow.
[3] Check the Holds tab of staff catalog detail.
    You should not see the Force item holds-box.
[4] Set OPACItemHolds to Selectively force.
[5] Goto the Holds tab of staff catalog detail.
[6] Enable forced item holds. Check behavior with placing hold in OPAC.
[6] Disable forced item holds. Check behavior with placing hold in OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:45:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:45:55 +0000
Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list
 of books with forced item holds
In-Reply-To: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13479-70-sFPRzfbvy9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13478

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:45:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:45:55 +0000
Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios
In-Reply-To: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13478-70-lUgy4AMfia@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13479

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:47:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:47:12 +0000
Subject: [Koha-bugs] [Bug 13838] New: Redirect to 'expired holds' tab after
 cancelling a hold
Message-ID: <bug-13838-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838

            Bug ID: 13838
           Summary: Redirect to 'expired holds' tab after cancelling a
                    hold
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When working with the 'holds awaiting pickup' report, after cancelling a hold
that has not been picked up, you are redirected to the first tab. It would be
nice if the redirect led you to the second tab to save a click when working on
cancelling the holds.

To test:
- Go to the holds awaiting pickup report from the circulation start page
- you will need some holds that appear on the 'hold(s) over' tab
- cancel a hold from this tab
- verify you are redirected to the report page with the first tab 'Hold(s)
waiting' selected

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:49:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:49:33 +0000
Subject: [Koha-bugs] [Bug 13839] New: Force item holds on item type level
Message-ID: <bug-13839-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13839

            Bug ID: 13839
           Summary: Force item holds on item type level
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

This is a follow-up of reports 13478 and 13479.
It would be nice to add the option to force item holds for specific item types.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:50:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:50:03 +0000
Subject: [Koha-bugs] [Bug 13839] Force item holds on item type level
In-Reply-To: <bug-13839-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13839-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13839-70-BPua7oiONL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13839

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13479

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:50:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:50:03 +0000
Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list
 of books with forced item holds
In-Reply-To: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13479-70-d0Mz9De5hr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13839

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:50:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:50:28 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-HNuP8LjwcR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it's the Number::Price that might be a bit specific here - adding
Jonathan to the bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:50:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:50:41 +0000
Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list
 of books with forced item holds
In-Reply-To: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13479-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13479-70-m0xmWSctAm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479

--- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. de Rooy from comment #1)
> Might be interesting to add the option for item types too. For some item
> types you may want to force item holds.

Moved this to a new report: bug 13839.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:57:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:57:06 +0000
Subject: [Koha-bugs] [Bug 13839] Force item holds on item type level
In-Reply-To: <bug-13839-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13839-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13839-70-ynZHTxLK90@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13839

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Adding a reference to Bug 5786 - Move AllowOnShelfHolds and OpacItemHolds
system preferences to the Circulation Matrix.

With OpacItemHolds in the circulation matrix forcing for an item type should
work :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 11:59:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 10:59:55 +0000
Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC
In-Reply-To: <bug-11847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11847-70-8AJauxRBMn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30480|0                           |1
        is obsolete|                            |

--- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36922
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36922&action=edit
Bug 11847: Display basketgroup closed date at OPAC

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:00:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 11:00:05 +0000
Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC
In-Reply-To: <bug-11847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11847-70-EBPrrTcoVD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32088|0                           |1
        is obsolete|                            |

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36923
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36923&action=edit
Bug 11847: Add span with class around order date

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:00:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 11:00:32 +0000
Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC
In-Reply-To: <bug-11847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11847-70-rnvKYvcqwS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:03:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 11:03:43 +0000
Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are
 several issues per unit
In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12671-70-78CukvnTQc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34659|0                           |1
        is obsolete|                            |

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36924
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36924&action=edit
Bug 12671: Refactor GetNextDate

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:04:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 11:04:09 +0000
Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are
 several issues per unit
In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12671-70-h8sFx3Z85p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34660|0                           |1
        is obsolete|                            |

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36925
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36925&action=edit
Bug 12671: Guess next serial date when there are several issues per unit

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:04:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 11:04:23 +0000
Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are
 several issues per unit
In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12671-70-UiAk6EvwME@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34658|0                           |1
        is obsolete|                            |

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36926
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36926&action=edit
Bug 12671: Guess next serial date when there are several issues per unit. Added
support for real month and year lenghts.

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:05:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 11:05:48 +0000
Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are
 several issues per unit
In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12671-70-FU73pNnV8n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches applied well on master, but were in the wrong order.
Anyway, patches rebased and reordered.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:07:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 11:07:14 +0000
Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are
 several issues per unit
In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12671-70-wWvPsTz1zp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

--- Comment #13 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
This works well in production for 4 months already. Somebody should push this
to master asap!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:07:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 11:07:27 +0000
Subject: [Koha-bugs] [Bug 13049] Improve self-registration cronjobs
In-Reply-To: <bug-13049-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13049-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13049-70-L9NWjvRKki@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |m.de.rooy at rijksmuseum.nl
         Depends on|11945                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 12:07:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 11:07:27 +0000
Subject: [Koha-bugs] [Bug 11945] Cronjob
 delete_expired_opac_registrations.pl fails with error in SQL syntax
In-Reply-To: <bug-11945-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11945-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11945-70-zjxcudrsBg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11945

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13049                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 13:05:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 12:05:19 +0000
Subject: [Koha-bugs] [Bug 13840] New: Don't show library filter on full
 serial issue history in OPAC for single branch libraries
Message-ID: <bug-13840-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13840

            Bug ID: 13840
           Summary: Don't show library filter on full serial issue history
                    in OPAC for single branch libraries
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

If a library has only one branch or the singleBranchMode preference is
activated, don't show the library filter on the left side of the full serial
issue history page.

To test:
- add a subscription to a serial
- go to the OPAC detail page
- subscription tab > more details link at the bottom
- full history tab
- library filter to the left always shows, independent from number of branches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 14:41:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 13:41:38 +0000
Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in
 ISSUESLIP and ISSUEQSLIP
In-Reply-To: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13819-70-aP3VDiaQ1d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819

--- Comment #2 from Barton Chittenden <barton at bywatersolutions.com> ---
Created attachment 36927
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36927&action=edit
marc record containing test data.

Attached bib (Programming Perl, 4th edition) has an ISBN of 9780596004927

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 14:55:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 13:55:28 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-bEEJz6jwcW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #31 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36928
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36928&action=edit
Bug 13601: t/Letters.t needs to mock the dateformat pref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 14:55:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 13:55:25 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-cNUz8eFkAp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 14:58:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 13:58:28 +0000
Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in
 ISSUESLIP and ISSUEQSLIP
In-Reply-To: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13819-70-SN5xWT0Zd5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819

--- Comment #3 from Barton Chittenden <barton at bywatersolutions.com> ---
Test procedure:

[Setup]
1. Import the attached MARC file, and create an item. Make note of the barcode.
2. Set up ISSUESLIP [
.../cgi-bin/koha/tools/letter.pl?op=add_form&module=circulation&code=ISSUESLIP
] using the following parameters:

                module: circulation
                  code: ISSUESLIP
            branchcode: 
                  name: Issue Slip
               is_html: 1
                 title: Issue Slip
               content: 

<h3><<branches.branchname>></h3>
Checked out to <<borrowers.title>> <<borrowers.firstname>>
<<borrowers.initials>> <<borrowers.surname>> <br />
(<<borrowers.cardnumber>>) <br />

<<today>><br />

<h4>Checked Out</h4>
<checkedout>
<p>
<<biblio.title>> <br />
Barcode: <<items.barcode>><br />
Date due: <<issues.date_due>><br />
ISBN: <<biblioitems.isbn>><br />
</p>
</checkedout>

<h4>Overdues</h4>
<overdue>
<p>
<<biblio.title>> <br />
Barcode: <<items.barcode>><br />
Date due: <<issues.date_due>><br />
ISBN: <<biblioitems.isbn>><br />
</p>
</overdue>

<hr>

<h4 style="text-align: center; font-style:italic;">News</h4>
<news>
<div class="newsitem">
<h5 style="margin-bottom: 1px; margin-top: 1px"><b><<opac_news.title>></b></h5>
<p style="margin-bottom: 1px; margin-top: 1px"><<opac_news.new>></p>
<p class="newsfooter" style="font-size: 8pt; font-style:italic; margin-bottom:
1px; margin-top: 1px">Posted on <<opac_news.timestamp>></p>
<hr />
</div>
</news>
message_transport_type: email

[Test]

1. Check out the item to a test patron.
2. On the circulation check-out screen, choose print->print slip

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:13:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:13:49 +0000
Subject: [Koha-bugs] [Bug 13049] Improve self-registration cronjobs
In-Reply-To: <bug-13049-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13049-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13049-70-PoTyV5mX8q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:13:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:13:51 +0000
Subject: [Koha-bugs] [Bug 13049] Improve self-registration cronjobs
In-Reply-To: <bug-13049-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13049-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13049-70-0rDU82ZOJp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

--- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 36929
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36929&action=edit
Bug 13049: Merge selfreg cron jobs into cleanup_database

This patch moves the core code of two selfreg cron jobs into the Members
module. The new routines are called from cleanup_database with two new
parameters. The old cron jobs are now wrappers to cleanup_database.
As a bonus, we can add a unit test now.

In time, we can obsolete the selfreg cron jobs. For now, the code is in one
place and behavior does not change.
A next step (as described on the Bugzilla report) would be: remove the Delay
pref for self regs.

Test plan:
Run the unit test t/db_dependent/Members.t.
Test the two new parameters of cleanup_database.pl.
Verify if delete_expired_opac_registrations.pl still works.
Same for delete_unverified_opac_registrations.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:15:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:15:21 +0000
Subject: [Koha-bugs] [Bug 13841] New: Returns via backdating or SIP2 can
 create new fines with an amount outstanding of 0
Message-ID: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

            Bug ID: 13841
           Summary: Returns via backdating or SIP2 can create new fines
                    with an amount outstanding of 0
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Due to the way AddReturn and UpdateFine work, if you pass in a return date to
AddReturn, and that item has a calculated fine of 0, Koha will insert the 0
amount fine into accountlines. 

This is good behavior when we want to update an existing fine, but bad behavior
if there was no fine to begin with!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:16:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:16:27 +0000
Subject: [Koha-bugs] [Bug 13473] Plugins fail when loading templates
In-Reply-To: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13473-70-3kDUpmchtC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473

H?ctor <hectorejch at yahoo.com.ar> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hectorejch at yahoo.com.ar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:16:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:16:27 +0000
Subject: [Koha-bugs] [Bug 13473] Plugins fail when loading templates
In-Reply-To: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13473-70-pxTFvNsGol@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473

H?ctor <hectorejch at yahoo.com.ar> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hectorejch at yahoo.com.ar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:16:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:16:42 +0000
Subject: [Koha-bugs] [Bug 13842] New: Send payment slip to patron by email
Message-ID: <bug-13842-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13842

            Bug ID: 13842
           Summary: Send payment slip to patron by email
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Similar to sending checkout and checkin slips by email, it would be nice if
Koha also supported sending a "payment slip" to the patron by email.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:18:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:18:29 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-fx4QzY3Qdf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:18:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:18:31 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-6ZA7geuaco@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36930
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36930&action=edit
Bug 13841 - Unit Test

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:18:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:18:38 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-jeK6CWKZso@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36931
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36931&action=edit
Bug 13841 - Returns via backdating or SIP2 can create new fines with an amount
outstanding of 0

Due to the way AddReturn and UpdateFine work, if you pass in a return
date to AddReturn, and that item has a calculated fine of 0, Koha will
insert the 0 amount fine into accountlines.

This is good behavior when we want to update an existing fine, but bad
behavior if there was no fine to begin with!

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/Circulation.t
3) Note the test fails
4) Apply this patch
5) prove t/db_dependent/Circulation.t
6) Note the test passes

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:19:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:19:15 +0000
Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into
	cleanup_database
In-Reply-To: <bug-13049-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13049-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13049-70-8SqjLtA6gt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Improve self-registration   |Merge selfreg cron jobs
                   |cronjobs                    |into cleanup_database

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:23:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:23:09 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-B76yVjmVIR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:23:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:23:23 +0000
Subject: [Koha-bugs] [Bug 13473] Plugins fail when loading templates
In-Reply-To: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13473-70-UKyve3b74Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473

--- Comment #13 from H?ctor <hectorejch at yahoo.com.ar> ---
This works, but the system language is shown only in English, although it is
set to Spanish

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:25:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:25:24 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-UcqFbTqaPa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:25:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:25:27 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-FAJmRIVM4c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36932
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36932&action=edit
Bug 13836: Does not separate symbol and value if symbol is not displayed.

This patch force the separation between the symbol and the value to an
empty string if the symbol is not displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:26:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:26:00 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-HC5BvwK6JD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:30:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:30:09 +0000
Subject: [Koha-bugs] [Bug 10827] List of holds does not update correctly
In-Reply-To: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10827-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10827-70-8IXOtcdcCR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827

--- Comment #38 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Katrin Fischer from comment #36)
> Please take a look at my comment #30.  I am not in favor of setting the
> waiting status automatically. In my opinion this should always require a
> check in, so that we can trigger the printing of the next slip.
> 
> Moving this to "In discussion".

I agree with Katrin on this point.  If this patch automatically triggers a hold
when an existing hold is cancelled or expired, this WILL create a big mess. 
Libraries like ours put the holds out on a shelf for patrons to pickup.  They
are marked with slips for patrons to identify their items.

Having the next hold triggered automatically creates a mess for both staff and
patron.  The patron will get notified that their hold is waiting, but won't be
able to find it.  Staff will not have any idea what slips need updating.  Items
will be lost on the hold shelves.  Cats and dogs will fall in love.  It would
be chaos.

What NEEDS to happen is a better notification to staff of these expired and
cancelled holds, so we can get to them quicker.  It would be HIGHLY recommended
that cancelled holds and expired holds don't show as available in Koha, but
show as a status that it is waiting for some sort of handling, so that staff
have a clue where the item is.  It would also be HIGHLY recommended if BOTH
expired AND cancelled holds showed up on the Holds Over list in the Holds
Awaiting Pickup report.  Perhaps even an alert on the staff home page.

That's my two cents.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:35:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:35:12 +0000
Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in
 ISSUESLIP and ISSUEQSLIP
In-Reply-To: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13819-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13819-70-HrVQIiUMDn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819

--- Comment #4 from Barton Chittenden <barton at bywatersolutions.com> ---
Test procedure {submitted the previous message accidentally -- this is the full
procedure}.

[Setup]
1. Import the attached MARC file, and create an item. Make note of the
barcode.
2. Set up ISSUESLIP [
.../cgi-bin/koha/tools/letter.
pl?op=add_form&module=circulation&code=ISSUESLIP ] using the following
parameters:

                module: circulation
                  code: ISSUESLIP
            branchcode: 
                  name: Issue Slip
               is_html: 1
                 title: Issue Slip
               content: 

<h3><<branches.branchname>></h3>
Checked out to <<borrowers.title>> <<borrowers.firstname>>
<<borrowers.initials>> <<borrowers.surname>> <br />
(<<borrowers.cardnumber>>) <br />

<<today>><br />

<h4>Checked Out</h4>
<checkedout>
<p>
<<biblio.title>> <br />
Barcode: <<items.barcode>><br />
Date due: <<issues.date_due>><br />
ISBN: <<biblioitems.isbn>><br />
</p>
</checkedout>

<h4>Overdues</h4>
<overdue>
<p>
<<biblio.title>> <br />
Barcode: <<items.barcode>><br />
Date due: <<issues.date_due>><br />
ISBN: <<biblioitems.isbn>><br />
</p>
</overdue>

<hr>

<h4 style="text-align: center; font-style:italic;">News</h4>
<news>
<div class="newsitem">
<h5 style="margin-bottom: 1px; margin-top:
1px"><b><<opac_news.title>></b></h5>
<p style="margin-bottom: 1px; margin-top: 1px"><<opac_news.new>></p>
<p class="newsfooter" style="font-size: 8pt; font-style:italic;
margin-bottom: 1px; margin-top: 1px">Posted on <<opac_news.timestamp>></p>
<hr />
</div>
</news>
message_transport_type: email

Set up ISSUEQSLIP the same way -- Quick slips only have a <checkedout> section,
so <overdue> and <news> can be omitted.

[Test]

1. Check out the item to a test patron.
2. On the circulation check-out screen, choose print->print slip

3. The resulting print slip should contain the line

   ISBN: 9780596004927

In the 'Checkout' section.

4.  On the circulation check-out screen, choose print->print quick slip. The
ISBN should print here as well.

5. Check the item back in. Check it out, but change the due date to yesterday's
date.

6. Print the 'print slip' again. Now the line

   ISBN: 9780596004927

Will show in the 'Overdues' section.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:38:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:38:14 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-OmT1C0Qc90@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #32 from Marc V?ron <veron at veron.ch> ---
Created attachment 36933
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36933&action=edit
[Signed-off] Bug 13601: t/Letters.t needs to mock the dateformat pref

Test passes OK.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:58:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:58:35 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-zZIQJrCcRr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Created attachment 36934
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36934&action=edit
[Signed-off] Bug 13836: Does not separate symbol and value if symbol is not
displayed.

This patch force the separation between the symbol and the value to an
empty string if the symbol is not displayed.

Tested with locale de_CH.UTF-8, prove t/Prices.t is now successful.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 15:58:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 14:58:56 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-TJAZugShxM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:00:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 15:00:15 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-sxU7Y1rurM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36932|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:01:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 15:01:12 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-mneSwI74Cw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:03:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 15:03:37 +0000
Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported
 only as DEFAULT frameworks, not what they were originally
In-Reply-To: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10906-70-qQTok4XjB8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:05:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 15:05:27 +0000
Subject: [Koha-bugs] [Bug 13843] New: Layout of some forms does not deal
 well with longer labels
Message-ID: <bug-13843-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13843

            Bug ID: 13843
           Summary: Layout of some forms does not deal well with longer
                    labels
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Created attachment 36935
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36935&action=edit
basket form

In German the terms we use are often longer than the English terms, resulting
in some layout problems with some of the forms in the staff interface. 

Sometimes this can be fixed with a bit of CSS, but a more general solution
would be preferrable.

Example:
- Add basket - form

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:10:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 15:10:43 +0000
Subject: [Koha-bugs] [Bug 12786] permission to allow everyone in staff
 client to see all patron lists
In-Reply-To: <bug-12786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12786-70-3NBUO2H360@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12786

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Would prefer to have permission setting in individual accounts, and not an all
or nothing permission.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:14:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 15:14:12 +0000
Subject: [Koha-bugs] [Bug 13844] New: Orphaned lists
Message-ID: <bug-13844-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13844

            Bug ID: 13844
           Summary: Orphaned lists
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: gmcharlt at gmail.com
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When a staff account that created a public list is deleted, that public list is
no longer connected to an account, and can not be changed.  I propose that all
lists can be viewed, edited and deleted by a superlibrarian.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:15:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 15:15:17 +0000
Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no
 description set in authorized value
In-Reply-To: <bug-13399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13399-70-JDepqdVvfp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |veron at veron.ch

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Sorry, patch does not apply:

git bz apply 13399

36242 - Proposed Patch

Applying: Add check to determine if d.lib exists
fatal: corrupt patch at line 20
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Add check to determine if d.lib exists

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:15:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 15:15:51 +0000
Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no
 description set in authorized value
In-Reply-To: <bug-13399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13399-70-EsKlTyYmJr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.18                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:17:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 15:17:09 +0000
Subject: [Koha-bugs] [Bug 13845] New: patron update
Message-ID: <bug-13845-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13845

            Bug ID: 13845
           Summary: patron update
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 16:19:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 15:19:04 +0000
Subject: [Koha-bugs] [Bug 13843] Layout of some forms does not deal well
 with longer labels
In-Reply-To: <bug-13843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13843-70-RHWUBcbZL2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13843

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36936
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36936&action=edit
notices tool - html message checkbox

Tools > Notices and slips

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:00:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 16:00:46 +0000
Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when
 using HTTPS in Koha.
In-Reply-To: <bug-11358-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11358-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11358-70-1Z6zlLoZgs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com,
                   |                            |francois.charbonnier at inlibr
                   |                            |o.com,
                   |                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:01:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 16:01:36 +0000
Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when
 using HTTPS in Koha.
In-Reply-To: <bug-11358-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11358-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11358-70-goJwXqtmiz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23361|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:04:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 16:04:14 +0000
Subject: [Koha-bugs] [Bug 13846] New: Email patron asking to return an item
 that has been placed on hold
Message-ID: <bug-13846-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13846

            Bug ID: 13846
           Summary: Email patron asking to return an item that has been
                    placed on hold
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

An idea to improve service to patrons:
Email the patron that has a book checked out, asking him/her nicely to return
the item that is needed to fill a hold for another patron when this hold is
placed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:04:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 16:04:14 +0000
Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when
 using HTTPS in Koha.
In-Reply-To: <bug-11358-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11358-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11358-70-FuqIow3wCy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358

--- Comment #9 from Blou <philippe.blouin at inlibro.com> ---
I obsolete the old patch, as it is my understanding the new patch REPLACES it.
Anyway, otherwise, it is virtually impossible to apply the old one.

This remains to be tested/signed off.  We'll test it, but as the sponsor, we
can't sign it off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:04:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 16:04:27 +0000
Subject: [Koha-bugs] [Bug 13847] New: Cannot download large reports as Open
 Office Spreadsheet ODS
Message-ID: <bug-13847-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13847

            Bug ID: 13847
           Summary: Cannot download large reports as Open Office
                    Spreadsheet ODS
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

It appears that reports with large data sets ( say 40,000 rows or greater ) can
be downloaded as CSV files, but fail to download as ODS files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 17:32:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 16:32:47 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-nxsSqph1OP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Marcel, any update on this? I'd really like to see it happen.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:31:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 17:31:15 +0000
Subject: [Koha-bugs] [Bug 13848] New: XSLT and  OpacItemLocation  sys pref
Message-ID: <bug-13848-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848

            Bug ID: 13848
           Summary: XSLT and  OpacItemLocation  sys pref
 Change sponsored?: ---
           Product: Koha
           Version: 3.16
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: ed.veal at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If you turn on the call number only in the OpacItemLocation system preference
the system is removing the call number from the availability line when the item
is available for check out. However, when the item is not available for check
out the call number is being left. As a result you have the call number being
displayed twice. 

Ed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 18:35:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 17:35:39 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-tRZY6VVN9h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:22:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 21:22:50 +0000
Subject: [Koha-bugs] [Bug 13845] patron update
In-Reply-To: <bug-13845-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13845-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13845-70-JotLzdc5eA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13845

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Christopher, can you add a bit more information to this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:29:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 21:29:39 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-b5LMyeIAEt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:29:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 21:29:42 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-zuXEdtY96s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36934|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36937
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36937&action=edit
[PASSED QA] Bug 13836: Does not separate symbol and value if symbol is not
displayed.

This patch force the separation between the symbol and the value to an
empty string if the symbol is not displayed.

Tested with locale de_CH.UTF-8, prove t/Prices.t is now successful.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:30:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 21:30:53 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-SCL56jtLQ2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36928|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 22:33:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 21:33:43 +0000
Subject: [Koha-bugs] [Bug 13845] patron update
In-Reply-To: <bug-13845-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13845-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13845-70-0iYJsevcsw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13845

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:07:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 22:07:53 +0000
Subject: [Koha-bugs] [Bug 13473] Plugins fail when loading templates
In-Reply-To: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13473-70-FePkfhVWEf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473

--- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to H?ctor from comment #13)
> This works, but the system language is shown only in English, although it is
> set to Spanish

Could you please fill a new bug for that? Put this one in the 'see also'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 16 23:14:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 16 Mar 2015 22:14:46 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-dYijEF8d68@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am having problems checking out items with a certain due time with this date.

For a test I am checking out an item, with the due date specified to:
19/03/2015 07:45
But the item checks out with:
19/03/2015 00:00

But... in the database it shows the correct due date, it's just not being
displayed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 02:34:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 01:34:23 +0000
Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU
	indexing
In-Reply-To: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13751-70-WfCQwubquv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #9)
> Hi Jacek, thx for looking into this. Do you know if it works for newer
> versions and if it's safe to use a newer version?

I was using 2.0.60, which seemed to work fine, but I'm not sure I was testing
the issue correctly...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 02:36:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 01:36:54 +0000
Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU
	indexing
In-Reply-To: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13751-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13751-70-dSIsgiVXrv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751

--- Comment #11 from David Cook <dcook at prosentient.com.au> ---
Suppose it's worth mentioning that the upcoming versions of Debian/Ubuntu will
ship with Zebra 2.0.59, which has a few issues as noted by myself and Tomas, I
believe.

2.0.59 has a fairly major problem with ICU where strings containing hyphens
aren't tokenized properly. That is to say, when the strings are tokenized, only
the first token is used and everything after it is discarded. This was fixed in
Zebra 2.0.60, but I think OpenSuse is the only Linux distro which has upgraded
its packages to 2.0.60...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 09:37:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 08:37:39 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-OlHCgZkn8h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36938
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36938&action=edit
Bug 13799: Add versioning to API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 09:46:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 08:46:57 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-0vcfKL0xNk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 09:47:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 08:47:01 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-Rof8kgd3f4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #34 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36939
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36939&action=edit
Bug 13601: The fallback regex should contain the time part

On displaying a sql date, if the dateformat is not set to sql, the
output should contain the date.
In the previous version, the fallback regex (used for sql format) did not
included the time part (hh:mm:ss).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 09:48:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 08:48:15 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-nR5k5URS7o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #35 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #33)
> I am having problems checking out items with a certain due time with this
> date.
> 
> For a test I am checking out an item, with the due date specified to:
> 19/03/2015 07:45
> But the item checks out with:
> 19/03/2015 00:00
> 
> But... in the database it shows the correct due date, it's just not being
> displayed?

Good catch Katrin!
All sql dates were impacted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 09:56:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 08:56:51 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-5NFqNWBErB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #27 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:41:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 09:41:07 +0000
Subject: [Koha-bugs] [Bug 13849] New: Introduce acceptance tests with
	cucumber
Message-ID: <bug-13849-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13849

            Bug ID: 13849
           Summary: Introduce acceptance tests with cucumber
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: gmcharlt at gmail.com

During the hackfest 15 in Marseille, akafred present us how he integrated
acceptance tests in Koha using Cucumber.
I would like to get developer's opinions on the need of this kind of tests into
Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:43:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 09:43:09 +0000
Subject: [Koha-bugs] [Bug 13849] Introduce acceptance tests with cucumber
In-Reply-To: <bug-13849-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13849-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13849-70-bDghmWounT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13849

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36940
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36940&action=edit
Bug 13849: POC - my first Cucumber contact

During the hackfest 15 in Marseille, akafred present us how he
integrated acceptance tests in Koha using Cucumber.

With this patch, I would like to get other developer opinions on the
usefulness of this kind of tests for the Koha software.

To test:
0/
* Install the selenium server (have a look at bug 13691)
* Install libtest-bdd-cucumber-perl (pkg) and App::pherkin (cpan)
* Edit t/db_dependent/cucumber/features/step_definitions/basic_steps.pl
and fill the login and password of a superlibrarian user.
Maybe you should also change the address of the selenium server (search
for 'remote_server_addr').

1/ Start the selenium server and launch the tests:
$ cd t/db_dependent/cucumber
$ pherkin
  or
$ prove tests.t

Even if the second method is recommended in
Test::BDD::Cucumber::Manual::Integration, I prefer the first one
Indeed, the tests will pass if a step is not defined (maybe something is
wrong somewhere...).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:43:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 09:43:57 +0000
Subject: [Koha-bugs] [Bug 13849] Introduce acceptance tests with cucumber
In-Reply-To: <bug-13849-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13849-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13849-70-iBQZ8mS6AM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13849

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13691

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:43:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 09:43:57 +0000
Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts
In-Reply-To: <bug-13691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13691-70-K4raZwlPTG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13849

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:47:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 09:47:19 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-Uarw5cPzQ9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 36941
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36941&action=edit
Bug 13799: Use Koha::Objects

This add 'unblessed' subroutines to both Koha::Objects and Koha::Object
to be able to pass it to Mojolicious

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 10:49:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 09:49:10 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-R55JfMdguv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Not sure about the last patch, maybe there's a better way to transform
Koha::Object(s) into JSON.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:13:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 10:13:10 +0000
Subject: [Koha-bugs] [Bug 13849] Introduce acceptance tests with cucumber
In-Reply-To: <bug-13849-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13849-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13849-70-My495MxOFg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13849

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Hi there!
Awesome that somebody else is in flames about Cucumber!

I have been writing the Cucumber tests into another directory structure, and I
have encountered some issues with it.

My file hierarchy:

kohaclone/t/Cucumber/runCucumberTests.pl #Binds
*::Cucumber::Manual::Integration
                    #And runs all Cucumber tests.
kohaclone/t/Cucumber/Overdues/features/*.feature   #Feature definitions
kohaclone/t/Cucumber/Overdues/features/step_definitions/*_steps.pl #Step
handlers
kohaclone/t/Cucumber/TestObjects/Koha/Overdues/*.pm #Packages to actually
                    #implement the test code. I cannot set debugger breakpoints
                    #into the step-files, because of how the Test::BDD-modules
                    #load them as code closures, so I implement the business
logic
                    #in the TestObjects. Return the comparable values and run
the
                    #Test::More function on the returned values, eg two objects
or
                    #an error code.


Note regarding passing test data arrays in the Scenario description:
    Examples:
      | branchCode | borrowerCategory | letterNumber |
      |            | S                | 1            |
      |            | S                | 2            |
      |            | S                | 3            |
      |            | PT               | 1            |
      |            | PT               | 2            |
      |            | PT               | 3            |
      | CPL        | PT               | 1            |
      | CPL        | PT               | 2            |
      | FTL        | YA               | 1            |
      | FTL        | YA               | 2            |
      | FTL        | YA               | 3            |

Instead of getting the array values from the step-definition regexp, you can
get them from the StepContext-object:
See my attachment scenarioNumberForTableDriveScenarios.txt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:14:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 10:14:27 +0000
Subject: [Koha-bugs] [Bug 13849] Introduce acceptance tests with cucumber
In-Reply-To: <bug-13849-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13849-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13849-70-kqDpldIFJ5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13849

--- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36942
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36942&action=edit
scenarioNumberForTableDrivenScenarios. Keep track of the Scenario data array
location to get data as HASH instead of ARRAY.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:51:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 10:51:57 +0000
Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting
In-Reply-To: <bug-12357-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12357-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12357-70-3vYnwKKbwR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #35 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Kyle, could you please provide tests, at least of the marc2bibtex subroutine.
And I would prefer to see the tidy job (the 2 last patches) moved to another
bug report.
Moreover, the indentation changes in C4::Record::marcrecord2csv will be in
conflict with bug 12404.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:57:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 10:57:17 +0000
Subject: [Koha-bugs] [Bug 13850] New: C4::Ris does not manage correctly 660
 and 661 - UNIMARC
Message-ID: <bug-13850-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13850

            Bug ID: 13850
           Summary: C4::Ris does not manage correctly 660 and 661 -
                    UNIMARC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In C4/Ris.pm:
  @field_list = ('600', '601', '602', '604', '605', '606','607', '608', '610',
'615', '620', '660'. '661', '670', '675', '676', '680', '686');

Note the 
  '660'. '661'
instead of
  '660', '661'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:58:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 10:58:39 +0000
Subject: [Koha-bugs] [Bug 13850] C4::Ris does not manage correctly 660 and
	661 - UNIMARC
In-Reply-To: <bug-13850-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13850-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13850-70-mlr6DGFuHl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13850

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 11:58:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 10:58:41 +0000
Subject: [Koha-bugs] [Bug 13850] C4::Ris does not manage correctly 660 and
	661 - UNIMARC
In-Reply-To: <bug-13850-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13850-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13850-70-ForlLF5BSR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13850

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36943
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36943&action=edit
Bug 13850: Fix typo in C4::Ris

In C4/Ris.pm:
  @field_list = ('600', '601', '602', '604', '605', '606','607', '608',
  '610', '615', '620', '660'. '661', '670', '675', '676', '680', '686');

Note the
  '660'. '661'
instead of
  '660', '661'

Test plan:
Add a 660 and 661 field to a record and export it in RIS
The 660 and 661 field should be displayed (after "KW").

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:15:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 11:15:59 +0000
Subject: [Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating
 incorrect utf-8 encoding everywhere
In-Reply-To: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13815-70-1f9meIxPNg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36763|0                           |1
        is obsolete|                            |

--- Comment #4 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Created attachment 36944
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36944&action=edit
Bug 13815 - plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding
everywhere

This is major problem for plack installations with utf-8 encoding.

In this case, we are overriding CGI->new to setup utf-8 flag and
get correctly decoded $cgi->params, and reset syspref cache using
C4::Context->clear_syspref_cache

Test scenario:
1. under plack try to search with utf-8 charactes
2. try to find patron with utf-8 characters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:39:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 11:39:05 +0000
Subject: [Koha-bugs] [Bug 2898] C4::Letters::parseletter kills performance
	in notice jobs
In-Reply-To: <bug-2898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2898-70-VI4WdqAzD5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2898

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Closing, please reopen if I am wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:39:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 11:39:05 +0000
Subject: [Koha-bugs] [Bug 7923] Performance omnibus
In-Reply-To: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7923-70-Ob20d6gccY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923
Bug 7923 depends on bug 2898, which changed state.

Bug 2898 Summary: C4::Letters::parseletter kills performance in notice jobs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2898

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 12:49:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 11:49:45 +0000
Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY
 of message_queue
In-Reply-To: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7793-70-44YhS2ZP1y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Olli,
Could you
- move the updatedb entry at the end of the updatedatabase.pl file.
- make the change more clear, it's not easily readable

And I think there is a problem:
Before: 2 id=42
After: 1 id=43 and 1 id=44
I would expect: 1 id=42 and 1 id=43.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:08:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 12:08:16 +0000
Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY
 of message_queue
In-Reply-To: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7793-70-CgkBc1GfNg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36145|0                           |1
        is obsolete|                            |

--- Comment #12 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36945
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36945&action=edit
Bug 7793 - redefine the field message_id as PRIMARY KEY of message_queue

Making message_queue work nicely with DBIx.

DROP the existing KEY and replace with an PRIMARY KEY.
If somebody has managed to get duplicate message_ids in his/her
message_queue-table, this patch takes care of them as well, but givin
all duplicate message_id's a new id.

TEST INSTRUCTIONS: in the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:09:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 12:09:54 +0000
Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY
 of message_queue
In-Reply-To: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7793-70-JZFwLH069B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #13 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Fixed Jonathan's good bug.
Thanks for it.

Won't move the updatedatabase-subroutine "down" because it will just conflict
so badly with all future modifications.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 13:15:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 12:15:34 +0000
Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode,
 categorytype from table overduerules_transport_types
In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13624-70-NtPggsxCM5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
1/ On updating the overdue rules (overduerules.pl), I got:

overduerules.pl: DBD::mysql::st execute failed: Column count doesn't match
value count at row 1 at /home/koha/src/tools/overduerules.pl line 188.

2/ Provide a complete test plan

3/ The new DB column has to be inserted at the same place as in the
kohastructure.sql file.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:03:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:03:03 +0000
Subject: [Koha-bugs] [Bug 13030] Show waiting hold expiration date for
 waiting holds on circulation.pl
In-Reply-To: <bug-13030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13030-70-7lVq98SloZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:26:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:26:08 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-gVFvFfGfUh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

--- Comment #7 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 36946
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36946&action=edit
RDA: 100/110/111 changes to XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:34:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:34:55 +0000
Subject: [Koha-bugs] [Bug 13851] New: Replace waiting holds logic in
 circulation.pl with Koha Objects
Message-ID: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

            Bug ID: 13851
           Summary: Replace waiting holds logic in circulation.pl with
                    Koha Objects
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

This is the original patch for bug 12892 and replaces the older style of
fetching the holds data with Koha Objects.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:40:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:40:42 +0000
Subject: [Koha-bugs] [Bug 13851] Replace waiting holds logic in
 circulation.pl with Koha Objects
In-Reply-To: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13851-70-oOkfCpmGmk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:40:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:40:45 +0000
Subject: [Koha-bugs] [Bug 13851] Replace waiting holds logic in
 circulation.pl with Koha Objects
In-Reply-To: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13851-70-xbwwF0p1bR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36947
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36947&action=edit
Bug 13851 - Replace waiting holds logic in circulation.pl with Koha Objects

This is the original patch for bug 12892 and replaces the older style of
fetching the holds data with Koha Objects. It will be used as a
foundation for future features.

Test Plan:
1) Apply this patch
2) Create a hold, set to waiting
3) Browse to circulation.pl for that patron
4) Note you see the list of waiting holds
5) Switch your logged in branch to a different branch
6) Note the "Waiting at" line is no longer emphasized.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:41:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:41:25 +0000
Subject: [Koha-bugs] [Bug 13030] Show waiting hold expiration date for
 waiting holds on circulation.pl
In-Reply-To: <bug-13030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13030-70-vhp2jCzlYZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|12892, 13019                |13851

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:41:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:41:25 +0000
Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out
	screen
In-Reply-To: <bug-12892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12892-70-A55tkheqHm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13030                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:41:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:41:25 +0000
Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha
	objects
In-Reply-To: <bug-13019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13019-70-w9HgFZZxSr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13030                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:41:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:41:25 +0000
Subject: [Koha-bugs] [Bug 13851] Replace waiting holds logic in
 circulation.pl with Koha Objects
In-Reply-To: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13851-70-vzPIiXsIQk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13030

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:45:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:45:45 +0000
Subject: [Koha-bugs] [Bug 7923] Performance omnibus
In-Reply-To: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7923-70-bWTefHFHLL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:49:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:49:08 +0000
Subject: [Koha-bugs] [Bug 13852] New: Manage C4::VirtualShelves in C4::Auth
 for performance
Message-ID: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

            Bug ID: 13852
           Summary: Manage C4::VirtualShelves in C4::Auth for performance
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In C4::Auth there is a use C4::VirtualShelves.
Virtualshelves are displayed in all OPAC pages, but not in intranet.
For performance, we should move this into a require only for opac pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:49:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:49:20 +0000
Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for
	performance
In-Reply-To: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13852-70-6GC9CsOsOX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7923

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:49:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:49:20 +0000
Subject: [Koha-bugs] [Bug 7923] Performance omnibus
In-Reply-To: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7923-70-sjRpQOSLUw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13852

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:49:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:49:30 +0000
Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for
	performance
In-Reply-To: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13852-70-6xDEOevnGr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:50:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:50:42 +0000
Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch
 from a staged file
In-Reply-To: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12074-70-tzdoZvrpCd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:50:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:50:48 +0000
Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch
 from a staged file
In-Reply-To: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12074-70-NPETUvkU8g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36647|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36948
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36948&action=edit
Bug 12074 Filter duplicates when adding a batch from a staged file

When adding a batch of records to a basket, duplicates are skipped and
an alert is displayed with a link to them so as they could be treated
individually.

Test plan :

You need the 2 test attached files TestFile1.mrc and TestFile2.elc
(TestFile1 includes only the title "Amilec ou La graine d'hommes" that
is also included in TestFile2)

1) go to ?Stage MARC records for import? page, upload TestFile1 and
stage it (select iso 5426 encoding).
2) Manage staged record and import the batch.
3) Make sure that the new record is indexed (depending to your indexing
system and test platform).
4) Go back to go to ?Stage MARC records for import? page upload
TestFile2 and stage it (select iso 5426 encoding).
5) Go to acquisitions module and create a new basket.
6) From your basket, in the ?Add order to basket block?  choose  'From a
staged file'.
7) Then click File2 (?addorder button').
8) Go down the "Import all" block and save.
9) You are redirected to the basket page : a warning is displayed to
tell you that some duplicates have been found and skipped.
There's a link on the warning throughout you can go back to the list of
remaining records and treat them individually if necesary.
10) Click the link : you fall upon the title of TestFile1 (of course as
it's a duplicate).
11) Check that the imported records have been indexed.
11) Go down the "Import all" block and save.
12) A warning is displayed saying that no records have been imported
because they all match an existing record. The ?Import all? block is not
any more visible.

Signed-off-by: JA <aloi54 at live.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 14:54:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 13:54:09 +0000
Subject: [Koha-bugs] [Bug 13851] Replace waiting holds logic in
 circulation.pl with Koha Objects
In-Reply-To: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13851-70-4oWL6gAdUX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Kyle, please fix the POD, it's incorrect in some places.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:07:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:07:27 +0000
Subject: [Koha-bugs] [Bug 13797] Applet / Script for combination silent
 printing/ till drawer kick out from Citizen CBM 1000 slip printer
In-Reply-To: <bug-13797-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13797-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13797-70-MaVC7MnKMD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13797

Tom Rowley <thomas.rowley at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:09:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:09:03 +0000
Subject: [Koha-bugs] [Bug 13853] New: Show waiting hold expiration date for
 waiting holds in holds ajax datatable
Message-ID: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853

            Bug ID: 13853
           Summary: Show waiting hold expiration date for waiting holds in
                    holds ajax datatable
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

We should show the expiration date for waiting holds in the holds datatable
that appears in circulation.pl and moremember.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:09:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:09:19 +0000
Subject: [Koha-bugs] [Bug 13030] Show waiting hold expiration date for
 waiting holds on circulation.pl
In-Reply-To: <bug-13030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13030-70-TtPwJHGG2h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13853

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:09:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:09:19 +0000
Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for
 waiting holds in holds ajax datatable
In-Reply-To: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13853-70-t0dCTdfSAY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
         Depends on|                            |13030

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:09:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:09:34 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-VS8QspD5a3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:12:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:12:38 +0000
Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for
 waiting holds in holds ajax datatable
In-Reply-To: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13853-70-TiX7kHMbwv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:12:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:12:40 +0000
Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for
 waiting holds in holds ajax datatable
In-Reply-To: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13853-70-WYuzj8AiGK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36949
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36949&action=edit
Bug 13853 - Show waiting hold expiration date for waiting holds in holds ajax
datatable

We should show the expiration date for waiting holds in the holds
datatable that appears in circulation.pl and moremember.pl

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Place a second hold and set it to waiting by checking it in
4) Place a third hold with an expiration date
5) View the holds tab on circulation.pl and moremember.pl
6) Note the first hold has no expiration date
7) Note the second hold has an expiration date of today +
ReservesMaxPickUpDelay days
8) Note the thrid hold has an expiration date of whatever you set it to

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:20:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:20:30 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-J4SFyWJWU4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:24:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:24:18 +0000
Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for
	performance
In-Reply-To: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13852-70-TjEngil88F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

--- Comment #1 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 36950
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36950&action=edit
Bug 13852 - Manage C4::VirtualShelves in C4::Auth for performance

In C4::Auth there is a use C4::VirtualShelves.
Virtualshelves are displayed in all OPAC pages, but not in intranet.
For performance, we should move this into a require only for opac pages.

This patch adds a condition to fetch virtualshelves only if opac and moves the
dependancy on C4::VirtualShelves into require calls.

On my desktop, I have those compilation times for C4/Auth.pm :
- Without patch : 0,41 seconds
- With patch : 0,22 seconds

This performance improvement is very usefull for pages that only use a few as
dependancy, like errors/404.pl

Test plan :
- Be sure there are some public lists
- Apply patch
- Go to opac (not logged-in)
- Click on "Lists"
- Check you see the public lists
- Login with a user
- Be sure this user has some private lists
- Click on "Lists"
- Check you see the public and private lists
- Logout
- Go to /cgi-bin/koha/opac-reserve.pl
- You see the loggin page
- Click on "Lists"
- Check you see the public lists
- Go to intranet
- Check you can loggin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:24:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:24:43 +0000
Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for
	performance
In-Reply-To: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13852-70-cL7qwtFIVn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:25:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:25:09 +0000
Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for
	performance
In-Reply-To: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13852-70-VMNxRcFQ7w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:26:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:26:08 +0000
Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for
	performance
In-Reply-To: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13852-70-SJMDCN8MOO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:34:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:34:16 +0000
Subject: [Koha-bugs] [Bug 13820] Hold Notification - generated at check in
 at destination branch
In-Reply-To: <bug-13820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13820-70-l6eaBmPsQE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13820

Tom Rowley <thomas.rowley at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1 - high                   |P2
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:48:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:48:14 +0000
Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode,
 categorytype from table overduerules_transport_types
In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13624-70-wFrs4Pythj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |francois.charbonnier at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 15:54:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 14:54:35 +0000
Subject: [Koha-bugs] [Bug 13797] Applet / Script for combination silent
 printing/ till drawer kick out from Citizen CBM 1000 slip printer
In-Reply-To: <bug-13797-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13797-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13797-70-K84JbCeHuD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13797

Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:23:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:23:41 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-opJvMlSvnO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36951
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36951&action=edit
Bug 13758: Move the Koha version from kohaversion.pl

It will permit not to run another perl interpreter.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:27:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:27:04 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-okArA1fh3G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I did not find any time saving using a new package to store the version.

# Without the patch
$ more t.pl
use Modern::Perl;
use C4::Context;
say C4::Context->KOHAVERSION;

$ time perl t.pl => 0.150s

# With the patch
$ more t.pl
use Modern::Perl;
use C4::Context;
use Koha;
say Koha::version;

$ time perl t.pl => 0.150s

To be fair I kept the use of C4::Context, if I remove it I get, of course,
~0.024s

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:30:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:30:30 +0000
Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for
 waiting holds in holds ajax datatable
In-Reply-To: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13853-70-AxddD37LJ0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:36:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:36:14 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-OEOSpVlC7K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #2)
> I did not find any time saving using a new package to store the version.
> 
> # Without the patch
> $ more t.pl
> use Modern::Perl;
> use C4::Context;
> say C4::Context->KOHAVERSION;
> 
> $ time perl t.pl => 0.150s
> 
> # With the patch
> $ more t.pl
> use Modern::Perl;
> use C4::Context;
> use Koha;
> say Koha::version;
> 
> $ time perl t.pl => 0.150s
> 
> To be fair I kept the use of C4::Context, if I remove it I get, of course,
> ~0.024s

Could you try the opac home page using ntyprof?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:37:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:37:11 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-MIEt2d1bfN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tom?s Cohen Arazi from comment #3)
> (In reply to Jonathan Druart from comment #2)
> > I did not find any time saving using a new package to store the version.
> > 
> > # Without the patch
> > $ more t.pl
> > use Modern::Perl;
> > use C4::Context;
> > say C4::Context->KOHAVERSION;
> > 
> > $ time perl t.pl => 0.150s
> > 
> > # With the patch
> > $ more t.pl
> > use Modern::Perl;
> > use C4::Context;
> > use Koha;
> > say Koha::version;
> > 
> > $ time perl t.pl => 0.150s
> > 
> > To be fair I kept the use of C4::Context, if I remove it I get, of course,
> > ~0.024s
> 
> Could you try the opac home page using ntyprof?

BTW, I would simplify getting the Koha version just for the sake of cleaning
the code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:38:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:38:13 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-o7DGL6eQAI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nengard at gmail.com           |wsalesky at gmail.com
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:38:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:38:26 +0000
Subject: [Koha-bugs] [Bug 13820] Hold Notification - generated at check in
 at destination branch
In-Reply-To: <bug-13820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13820-70-WIFEj642eG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13820

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

--- Comment #1 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Just as a feedback, we are implementing holds in a 3.14.13 koha version and the
notification "hold available" is created only when the item arrived at the
pickup branch. But, perhaps, we don't have the same parameters.
Sonia Bouis

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:38:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:38:41 +0000
Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs
In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13734-70-Y6xkCo1tMc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |wsalesky at gmail.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:38:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:38:59 +0000
Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT
In-Reply-To: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13433-70-wDIoiNG7Sg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:39:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:39:30 +0000
Subject: [Koha-bugs] [Bug 13851] Replace waiting holds logic in
 circulation.pl with Koha Objects
In-Reply-To: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13851-70-TmXhp0V8su@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:39:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:39:33 +0000
Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in
	XSLT
In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13387-70-l2qxQWpy2U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 16:56:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 15:56:37 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-0pTxii48l8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Tom?s Cohen Arazi from comment #3)
> Could you try the opac home page using ntyprof?

I would not expect any difference. If the simple script I tested give the same
execution time, it should be the same on the opac main page.

(In reply to Tom?s Cohen Arazi from comment #4)
> BTW, I would simplify getting the Koha version just for the sake of cleaning
> the code.

Yep, that's a sufficient reason :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:08:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 16:08:45 +0000
Subject: [Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does
 not prevent librarian from placing the hold
In-Reply-To: <bug-12197-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12197-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12197-70-FAtlLHK9pw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28493|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36952
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36952&action=edit
Bug 12197: enforce the maxreserves preference when staff members place hold
requests

This patch ensures that the global maxreserves preference is enforced
when staff members place hold requests.

For example:

Create 3 items to place holds on. Set the circulation rule to allow 50
holds for all items. Set maxreserves to 2. Place a hold on 3 different
items. On the third item, it will give a warning, but you can still
place the hold. Despite what the circulation rule is set for (which is
only a specific case rule), maxreserves is a global rule and
should stop this from happening, not just give a warning.

Test Plan:
1) Reproduce the bug by following the steps above
2) Verify the bug exists
3) Apply this patch
4) Verify the librarian cannot place the hold now
5) Enable AllowHoldPolicyOverride
6) Verify the librarian can forcefully place the hold

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

Bug 12197: (follow-up) rename variable for greater clarity

"maxreserves" was referring both to the system preference and to the
condition of having exceeded the number of hold requests allowed.

This patch renames a variable to remove the ambguity.

Test plan:

* Same as the main patch.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:12:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 16:12:13 +0000
Subject: [Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does
 not prevent librarian from placing the hold
In-Reply-To: <bug-12197-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12197-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12197-70-9fomnAOgCS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:15:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 16:15:15 +0000
Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in
 cataloguing/item editor
In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10480-70-o06sTT8CF6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36106|0                           |1
        is obsolete|                            |
  Attachment #36107|0                           |1
        is obsolete|                            |
  Attachment #36108|0                           |1
        is obsolete|                            |
  Attachment #36109|0                           |1
        is obsolete|                            |
  Attachment #36110|0                           |1
        is obsolete|                            |

--- Comment #37 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36953
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36953&action=edit
Bug 10480: New module and unit test for framework plugins

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:15:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 16:15:31 +0000
Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in
 cataloguing/item editor
In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10480-70-TUeMjtDap2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

--- Comment #38 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36954
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36954&action=edit
Bug 10480: Use the framework plugin object in cataloguing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:15:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 16:15:45 +0000
Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in
 cataloguing/item editor
In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10480-70-KszFMmK5XA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

--- Comment #39 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36955
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36955&action=edit
Bug 10480: EXAMPLE plugin with associated template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:16:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 16:16:07 +0000
Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in
 cataloguing/item editor
In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10480-70-FxpfwYGUFk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

--- Comment #40 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36956
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36956&action=edit
Bug 10480: Remove useless routines and irrelevant pod lines

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:16:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 16:16:27 +0000
Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in
 cataloguing/item editor
In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10480-70-lyEwxxDhO9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

--- Comment #41 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36957
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36957&action=edit
Bug 10480: Follow-up for unimarc_field_686a/_700-4.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:20:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 16:20:23 +0000
Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in
 cataloguing/item editor
In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10480-70-cEgwUqHC9D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #42 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Great work Marcel!
I did not find any regression and the code looks better than before. I really
would like to see this one moving forward to motivate you to continue the job
:)
However I would like to get another pair of eyes on it, that's why I don't
change the status for now.

Just one question: The EXAMPLE plugin should be removed (or not pushed) or
hidden in the dropdown list, don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:24:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 16:24:23 +0000
Subject: [Koha-bugs] [Bug 13854] New: XSLT result list doesn't show 'on
 order' when itemtype is not for loan
Message-ID: <bug-13854-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13854

            Bug ID: 13854
           Summary: XSLT result list doesn't show 'on order' when itemtype
                    is not for loan
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Created attachment 36958
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36958&action=edit
On order status not showing for 'not for loan' itype items

If the itemtype of the item is marked as 'not for loan' the items are not
listed as 'on order' in the result list.

To test:
- Catalog 3 items
 - 1 item with an item type that can be checked out
 - 1 item with an item type that is marked 'not for loan'
 - 1 item with an item type that is marked 'not for loan' and status 'on order'
- Wait until Koha indexed your items
- Verify that result list will show 1 item as available and 2 as for reference
  The 'on order' status won't show at all

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 17:26:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 16:26:09 +0000
Subject: [Koha-bugs] [Bug 13854] XSLT result list doesn't show 'on order'
 when itemtype is not for loan
In-Reply-To: <bug-13854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13854-70-pKODsV4CL6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13854

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
... also, there is a misplaced space for the reference items number

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:32:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 17:32:24 +0000
Subject: [Koha-bugs] [Bug 10904] Limit patron update request management by
	branch
In-Reply-To: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10904-70-Ga9BL8pRxG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:32:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 17:32:27 +0000
Subject: [Koha-bugs] [Bug 10904] Limit patron update request management by
	branch
In-Reply-To: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10904-70-XVbFjGshdd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27254|0                           |1
        is obsolete|                            |
  Attachment #27255|0                           |1
        is obsolete|                            |
  Attachment #27256|0                           |1
        is obsolete|                            |

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36959
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36959&action=edit
Bug 10904 - would like to limit patron update request management by branch

By not limiting the patron modification lists by branch, it can quickly
become overwhelming for a librarian. This patch makes the following
modifications:

* Only superlibrians will see the full list of borrowers with pending
  modifications.
* Adds the patron cardnumber after the patrons name on the modification
  list.
* Adds a link to the patron's record from the modification list.

Test Plan:
1) Apply this patch
2) Set up some pending modifications for two branches
3) Log in to the staff intranet as one of those branches
4) You should note the number of pending modifications counts
   only your logged in branch's patrons
5) Click the link, you should only see your logged in branches
   patrons in the pending modifications list.
6) You should note the cardnumber is displayed next to the patron name
7) You should note the "View record" link below each patron's name

Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Comments on last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:32:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 17:32:37 +0000
Subject: [Koha-bugs] [Bug 10904] Limit patron update request management by
	branch
In-Reply-To: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10904-70-YIohOwiESD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36960
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36960&action=edit
Bug 10904 [QA Followup] - would like to limit patron update request management
by branch

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:32:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 17:32:41 +0000
Subject: [Koha-bugs] [Bug 10904] Limit patron update request management by
	branch
In-Reply-To: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10904-70-ruHOszSnCu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36961
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36961&action=edit
Bug 10904 [QA Followup] - Use branch limit if either IndependentBranches or
IndependentBranchesPatronModifications is enabled

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.

Behaviour now is:
IndependentBranches = Prevent
or
IndependentBranches = Don't prevent,
IndependentBranchesPatronModifications = Prevent:
You will always only see the modification requests of your branch's patrons.

IndependentBrnaches = Don't prevent,
IndependentBranchesPatronModifications = Don't prevent
All modification requests are shown.

Link to patron record works and cardnumber is shown.

IndependentBranches = OFF - use the new preference.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:52:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 17:52:14 +0000
Subject: [Koha-bugs] [Bug 13844] Orphaned lists
In-Reply-To: <bug-13844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13844-70-tIeTElD1We@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13844

--- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> ---
It would also be preferable if the superlibrarian could also associate an
existing account with the orphaned list.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 18:52:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 17:52:33 +0000
Subject: [Koha-bugs] [Bug 13844] Orphaned lists
In-Reply-To: <bug-13844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13844-70-285RxKkZIz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13844

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:08:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 18:08:18 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-LKIys1R488@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36962
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36962&action=edit
Bug 13758: Koha::Version introduced (counterpatch)

This patch introduces a trivial package: Koha::Version. It only contains
a constant: VERSION. It is set the current version number.

The idea is that we stop relying on calling the kohaversion.pl script to get
the current version number. The workfl

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:17:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 18:17:19 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-Qb9UJDJyzA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36962|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 36963
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36963&action=edit
Bug 13758: Koha::Version introduced (counterpatch)

This patch introduces a trivial package: Koha::Version. It only contains
a constant: VERSION. It is set the current version number.

The idea is that we stop relying on calling the kohaversion.pl script to get
the current version number. The workflow for RM/RMaints versioning their
updates
should be slightly changed, but overall is the same effort.

To test:
1 - Run
  $ perl Makefile.PL
  (it doesn't matter which version, just continue till the end)
=> SUCCESS: The printed version, is the correct one (3.19.00.016).

2 - Tweak the Koha/Version.pm file, shifting the version number
  - Launch the opac interface
=> SUCCESS: The OPAC shows the maintenance page
  - Launch the intranet:
=> SUCCESS: You are offered the update

Those are the most important use cases, because the rest just uses
C4::Context->KOHAVERSION()
to access the version number, which is proven to work by the use cases.

Edit: The commit message got truncated at some point, probably because I
recovered the version
prior to completing the commit message after the power outage

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:37:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 18:37:24 +0000
Subject: [Koha-bugs] [Bug 10382] collection not returning to null when
 removed from course reserves
In-Reply-To: <bug-10382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10382-70-iG2mt7EGrZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:49:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 18:49:11 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-ZikNWip5jY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com
             Status|Needs Signoff               |Signed Off

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Jen DeMuth <jdemuth at roseville.ca.us>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:49:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 18:49:24 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-kziG2Ao0tv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36930|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:49:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 18:49:28 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-BkyO2iM7UV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36931|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:49:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 18:49:35 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-FUBrlS07tf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

--- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36964
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36964&action=edit
Bug 13841 - Unit Test

Signed-off-by: Jen DeMuth <jdemuth at roseville.ca.us>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 19:49:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 18:49:38 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-ws4DStMr1v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 36965
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36965&action=edit
Bug 13841 - Returns via backdating or SIP2 can create new fines with an amount
outstanding of 0

Due to the way AddReturn and UpdateFine work, if you pass in a return
date to AddReturn, and that item has a calculated fine of 0, Koha will
insert the 0 amount fine into accountlines.

This is good behavior when we want to update an existing fine, but bad
behavior if there was no fine to begin with!

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/Circulation.t
3) Note the test fails
4) Apply this patch
5) prove t/db_dependent/Circulation.t
6) Note the test passes

Signed-off-by: Jen DeMuth <jdemuth at roseville.ca.us>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 21:30:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 20:30:15 +0000
Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in
 cataloguing/item editor
In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10480-70-RpAqrgzioi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

--- Comment #43 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #42)
> I did not find any regression and the code looks better than before. I
> really would like to see this one moving forward to motivate you to continue
> the job :)
> However I would like to get another pair of eyes on it, that's why I don't
> change the status for now.
Thanks for testing.

> Just one question: The EXAMPLE plugin should be removed (or not pushed) or
> hidden in the dropdown list, don't you think?
It is some kind of documentation; also easy to copy and extend it etc.
But we could certainly hide in the dropdown list. That would be a trivial
follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 21:35:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 20:35:16 +0000
Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type
 Choice, choices being "no", "yes", "force"
In-Reply-To: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7825-70-GegadYEu4O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 21:35:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 20:35:29 +0000
Subject: [Koha-bugs] [Bug 13088] Allow the user to specify a max amount of
 facets to show.
In-Reply-To: <bug-13088-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13088-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13088-70-JGTtan47cZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:02:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 21:02:07 +0000
Subject: [Koha-bugs] [Bug 13855] New: Fastadd framework has 2x 100$c,
	missing 100$a
Message-ID: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

            Bug ID: 13855
           Summary: Fastadd framework has 2x 100$c, missing 100$a
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: gmcharlt at gmail.com
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org

Field 100$a is missing from fastadd framework, 100$c appears twice in sql file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 22:02:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 21:02:23 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-0oCts0Hd3e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:22:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 22:22:30 +0000
Subject: [Koha-bugs] [Bug 13856] New: Hard to translate strings on patron
 search results page
Message-ID: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13856

            Bug ID: 13856
           Summary: Hard to translate strings on patron search results
                    page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Add selected patrons to: at the top of the patron search result table is hard
to translate correctly, because the 'to:' appears as a separate string.

<span>
Add selected patrons
<label for="add_to_patron_list">to:</label>

Results in:
Add selected patrons
to:

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:33:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 22:33:40 +0000
Subject: [Koha-bugs] [Bug 13856] Hard to translate strings on patron search
	results page
In-Reply-To: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13856-70-YS82QPbG2s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13856

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:33:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 22:33:43 +0000
Subject: [Koha-bugs] [Bug 13856] Hard to translate strings on patron search
	results page
In-Reply-To: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13856-70-nFYpO2mq2R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13856

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36966
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36966&action=edit
Bug 13856: Hard to translate strings on patron search results page

'Add selected patrons to:' at the top of the patron search result
table is hard to translate correctly, because the 'to:' appears
as a separate string from the rest of the sentence.

To test:
- Make sure patron lists are activated
- Do a patron search with more than 1 result
- Look for the text at the top of the search results table
- Verify it looks the same before and after the patch

Bonus:
- run perl translate update <langcode> and verify the
  2 strings are now 1 string with the patch applied

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:36:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 22:36:42 +0000
Subject: [Koha-bugs] [Bug 13857] New: Email input field for sharing lists is
	too small
Message-ID: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13857

            Bug ID: 13857
           Summary: Email input field for sharing lists is too small
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

The input field for the email address of the patron you want to share your list
with is a bit too short.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:41:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 22:41:10 +0000
Subject: [Koha-bugs] [Bug 13856] Hard to translate strings on patron search
	results page
In-Reply-To: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13856-70-6ePA39F1vY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13856

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:48:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 22:48:31 +0000
Subject: [Koha-bugs] [Bug 13857] Email input field for sharing lists is too
	small
In-Reply-To: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13857-70-oNmYPEVlQx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13857

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:48:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 22:48:33 +0000
Subject: [Koha-bugs] [Bug 13857] Email input field for sharing lists is too
	small
In-Reply-To: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13857-70-pWuOniAl3F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13857

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36967
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36967&action=edit
Bug 13857: Email field for sharing is a bit short

The email field for sharing a list with another patron is
a bit short.

To test:
- Make sure OpacAllowSharingPrivateLists is activated
- Create a list in OPAC
- Use the "Share list" link to share with another user
- Check the length of the email field and if you like it
  better with this patch applied

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:48:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 22:48:48 +0000
Subject: [Koha-bugs] [Bug 13857] Email input field for sharing lists is too
	small
In-Reply-To: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13857-70-Z0YinmnV4A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13857

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 17 23:49:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 22:49:52 +0000
Subject: [Koha-bugs] [Bug 13858] New: Datatables paging for news page is
	broken
Message-ID: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13858

            Bug ID: 13858
           Summary: Datatables paging for news page is broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

The paging in the tools > news page is broken slightly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 00:03:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 23:03:29 +0000
Subject: [Koha-bugs] [Bug 13858] Datatables paging for news page is broken
In-Reply-To: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13858-70-lCexjzfw1c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13858

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 00:03:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 23:03:32 +0000
Subject: [Koha-bugs] [Bug 13858] Datatables paging for news page is broken
In-Reply-To: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13858-70-m29S7FBKtr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13858

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36968
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36968&action=edit
Bug 13858: Datatables paging on Koha news tool page slightly broken

The paging is slightly broken in the datatables table on the
news page in the tools module.

To test:
- Access the tools > news page
- Make sure you have a few news entries
- Check that the paging is broken without the patch and
  fixed once the patch is applied

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 00:54:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 17 Mar 2015 23:54:19 +0000
Subject: [Koha-bugs] [Bug 13859] New: "by" in item search result list not
 needed for MARC21 and when no author exists
Message-ID: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

            Bug ID: 13859
           Summary: "by" in item search result list not needed for MARC21
                    and when no author exists
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

The new item search feature always displays 'by' after each title, even if no
author exists. Because of the ISBD punctuation the by is not needed for MARC21.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:00:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:00:40 +0000
Subject: [Koha-bugs] [Bug 13858] Datatables paging for news page is broken
In-Reply-To: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13858-70-ukfLCnQx6N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13858

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36968|0                           |1
        is obsolete|                            |

--- Comment #2 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36969
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36969&action=edit
Bug 13858: Datatables paging on Koha news tool page slightly broken

The paging is slightly broken in the datatables table on the
news page in the tools module.

To test:
- Access the tools > news page
- Make sure you have a few news entries
- Check that the paging is broken without the patch and
  fixed once the patch is applied

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:00:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:00:38 +0000
Subject: [Koha-bugs] [Bug 13858] Datatables paging for news page is broken
In-Reply-To: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13858-70-7StRGh5pu4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13858

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:17:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:17:48 +0000
Subject: [Koha-bugs] [Bug 13860] New: cloud-kw.pl not UTF-8 compliant
Message-ID: <bug-13860-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13860

            Bug ID: 13860
           Summary: cloud-kw.pl not UTF-8 compliant
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: verolencinas at yahoo.com.ar
        QA Contact: testopia at bugs.koha-community.org

An author or subject cloud that includes words with extended characters (for
example ?, ?, ?, etc.) generates messy output.
Example:
Subject: M?sica cl?sica 
Output: M??sica cl??sica

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:33:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:33:50 +0000
Subject: [Koha-bugs] [Bug 13589] add --mark-returned as a longoverdue sys
	pref
In-Reply-To: <bug-13589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13589-70-YJL9Jr1Fkw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:33:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:33:53 +0000
Subject: [Koha-bugs] [Bug 13589] add --mark-returned as a longoverdue sys
	pref
In-Reply-To: <bug-13589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13589-70-6tmZn72cYW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36970
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36970&action=edit
Bug 13589: Item search improvements - publication date and title formatting

In the item search accessible from the advanced search the publication
date would not display for MARC21 and the title always contained 'by'
even if there was no author information to display. Also the by is
not needed by MARC21 as the data includes punctuation.

To test:
- Check publication date always displays (MARC21 and UNIMARC)
- Check that for MARC21 the by has been removed from the title information
- Check that for UNIMARC the by only displays when there is also
  an author to display

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:34:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:34:45 +0000
Subject: [Koha-bugs] [Bug 13589] add --mark-returned as a longoverdue sys
	pref
In-Reply-To: <bug-13589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13589-70-gIGGUO9BG7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36970|1                           |0
           is patch|                            |
  Attachment #36970|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:34:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:34:59 +0000
Subject: [Koha-bugs] [Bug 13589] add --mark-returned as a longoverdue sys
	pref
In-Reply-To: <bug-13589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13589-70-DTQO2rfjsR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:35:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:35:03 +0000
Subject: [Koha-bugs] [Bug 13589] add --mark-returned as a longoverdue sys
	pref
In-Reply-To: <bug-13589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13589-70-VPRYOkszy1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:35:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:35:45 +0000
Subject: [Koha-bugs] [Bug 13859] "by" in item search result list not needed
 for MARC21 and when no author exists
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-9ngHQiqalr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:35:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:35:47 +0000
Subject: [Koha-bugs] [Bug 13859] "by" in item search result list not needed
 for MARC21 and when no author exists
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-YUt3giqcej@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36971
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36971&action=edit
Bug 13859: Item search improvements - publication date and title formatting

In the item search accessible from the advanced search the publication
date would not display for MARC21 and the title always contained 'by'
even if there was no author information to display. Also the by is
not needed by MARC21 as the data includes punctuation.

To test:
- Check publication date always displays (MARC21 and UNIMARC)
- Check that for MARC21 the by has been removed from the title information
- Check that for UNIMARC the by only displays when there is also
  an author to display

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:36:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:36:39 +0000
Subject: [Koha-bugs] [Bug 13859] Fix item search result list - obsolete "by"
 and display of publication date for MARC21
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-3XLv6tcVq4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de
           Severity|enhancement                 |normal
            Summary|"by" in item search result  |Fix item search result list
                   |list not needed for MARC21  |- obsolete "by" and display
                   |and when no author exists   |of publication date for
                   |                            |MARC21

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:45:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:45:11 +0000
Subject: [Koha-bugs] [Bug 13861] New: \n in strings don't translate well
Message-ID: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13861

            Bug ID: 13861
           Summary: \n in strings don't translate well
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Line breaks done with \n in Javascript strings will cause problems in
translation as Pootle escapes them automatically. The result is that in a
translated template \n is shown instead of a line break.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:49:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:49:21 +0000
Subject: [Koha-bugs] [Bug 13861] \n in strings don't translate well
In-Reply-To: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13861-70-bDfwjvKhCw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13861

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:49:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:49:24 +0000
Subject: [Koha-bugs] [Bug 13861] \n in strings don't translate well
In-Reply-To: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13861-70-qHCN2dJxHB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13861

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36972
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36972&action=edit
Bug 13861: \n in confirmation message on closing a budget

\n in strings doesn't translate well, so we move it outside
the translated string.

To test:
- create at least 2 budgets
- close one of the budgets (moving orders from one budget to the other)
- after selecting the budget to move your orders to, save
- the confirmation message shown should read:

You have chosen to move all unreceived orders from 'budget 1' to 'budget 2'.
This action cannot be reversed. Do you wish to continue?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 01:49:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 00:49:40 +0000
Subject: [Koha-bugs] [Bug 13861] \n in strings don't translate well
In-Reply-To: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13861-70-hHXnuhoLHE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13861

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 02:33:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 01:33:33 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-rGsTsp09Vp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36973
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36973&action=edit
BUG 13855 - Fastadd framework has 2x 100$c, missing 100$a

The fastadd framework ist missing a 100$a subfield, it has two 100$c instead.
This patch corrects English, German, Italian and Spanish .sql files.
Italian and Spanish need translations for the field name.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 02:34:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 01:34:49 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-ysHzheLpzK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 06:16:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 05:16:23 +0000
Subject: [Koha-bugs] [Bug 13862] New: Attach item feature need batch mode
	provision
Message-ID: <bug-13862-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13862

            Bug ID: 13862
           Summary: Attach item feature need batch mode provision
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: vimal0212 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Kindly give provision to add accession number in batch mode with 'Attach item'
in Cataloging section. Same like Tools > Batch item modification. Its easy to
attach many items in one stretch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 06:16:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 05:16:48 +0000
Subject: [Koha-bugs] [Bug 13862] Attach item feature need batch mode
	provision
In-Reply-To: <bug-13862-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13862-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13862-70-cqJRmeG725@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13862

vimal kumar <vimal0212 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:25:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 08:25:21 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-xmmyWBUyKO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I prefer my version :)
It cleans much more code, and Koha::version() (or $Koha::VERSION) make more
sense that Koha::Version::VERSION.
Besides, your patch introduces another way to know the Koha version, mine
replaces the existing one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 09:45:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 08:45:46 +0000
Subject: [Koha-bugs] [Bug 13797] Applet / Script for combination silent
 printing/ till drawer kick out from Citizen CBM 1000 slip printer
In-Reply-To: <bug-13797-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13797-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13797-70-KThegyEPWs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13797

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |enhancement
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hi Tom, 

This really is an enhancement request rather than a bug, and it's a difficult
one to solve from the koha side.

In fact, this is more of a general question/plea for others thoughts that would
be open to a larger audience on the koha mailing lists.

The User mailing lists are available to join here
http://lists.katipo.co.nz/mailman/listinfo/koha and there are also developer
mailing lists that might be worth punting the question to as well
(http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel).

I am still looking ino solutions at this end (as ptfs-europe), but it's
definitely a good idea opening up the question to the wider community audience.

Cheers

Martin

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:29:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 09:29:07 +0000
Subject: [Koha-bugs] [Bug 13858] Datatables paging for news page is broken
In-Reply-To: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13858-70-EnTEbURqLy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13858

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:29:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 09:29:09 +0000
Subject: [Koha-bugs] [Bug 13858] Datatables paging for news page is broken
In-Reply-To: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13858-70-2a6AaSRR9m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13858

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36969|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36974
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36974&action=edit
Bug 13858: Datatables paging on Koha news tool page slightly broken

The paging is slightly broken in the datatables table on the
news page in the tools module.

To test:
- Access the tools > news page
- Make sure you have a few news entries
- Check that the paging is broken without the patch and
  fixed once the patch is applied

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:49:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 09:49:39 +0000
Subject: [Koha-bugs] [Bug 13863] New: Datatables paging for cities and
 search history pages is broken
Message-ID: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

            Bug ID: 13863
           Summary: Datatables paging for cities and search history pages
                    is broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:49:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 09:49:44 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-Z6fJ2PzAR8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13858

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:49:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 09:49:44 +0000
Subject: [Koha-bugs] [Bug 13858] Datatables paging for news page is broken
In-Reply-To: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13858-70-NXPthJrhF2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13858

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13863

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:53:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 09:53:06 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-38bV2Tyhhy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:53:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 09:53:08 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-Pl8B5LGBNs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36975
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36975&action=edit
Bug 13863: Fix Datatables paging on the cities and search history pages

Test plan:
Go on admin/cities.pl and catalogue/search-history.pl and confirm the
pagination is not broken anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 10:53:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 09:53:36 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-6Ol8MqobEV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
It should be the 2 last ones!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:44:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 10:44:07 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-cZjaak2SJw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 11:44:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 10:44:09 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-AbCP2LKi6p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36975|0                           |1
        is obsolete|                            |

--- Comment #3 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36976
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36976&action=edit
Bug 13863: Fix Datatables paging on the cities and search history pages

Test plan:
Go on admin/cities.pl and catalogue/search-history.pl and confirm the
pagination is not broken anymore.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:04:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:04:45 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: <bug-13726-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13726-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13726-70-kAzQbj7VWo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:04:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:04:53 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: <bug-13726-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13726-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13726-70-FDvUIj04Ix@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35992|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36977
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36977&action=edit
Bug 13726: Make Koha::Acq::Bookseller using Koha::Object

This patch create a Koha::Acquisition::Booksellers module and
Koha::Acquisition::Bookseller::Contract[s] modules.

All code in the acquisition module is adapted to use the CRUD methods of
Koha::Object[s].
The former C4 routines are removed.

Test plan:
Since a lot of files are impacted by this patch, try a complete
acquisition workflow and try to catch errors.
Be focused on bookseller and bookseller's contracts data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:05:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:05:14 +0000
Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving
In-Reply-To: <bug-13323-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13323-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13323-70-rjsY4NDnnD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13726

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:05:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:05:14 +0000
Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use
	Koha::Object
In-Reply-To: <bug-13726-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13726-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13726-70-Bo261rRqy2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13323

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:12:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:12:59 +0000
Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of
	a MARC Record
In-Reply-To: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11194-70-x62ZvHNS0T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi
            Summary|Add a new index for edition |Add a new index for
                   |of a document               |"Edition Statement" of a
                   |                            |MARC Record

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:18:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:18:06 +0000
Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of
	a MARC Record
In-Reply-To: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11194-70-4f40Y9fCXr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36978
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36978&action=edit
Bug 11194 - Add a new index for "Edition Statement" of a MARC Record

Adds the "Edition Statement" MARC-field as a sortable search index in Koha.
This Field is also used by the MARC::Record->edition().

It is mapped to search keyword "edition" and it targets the following
MARC-fields:

UNIMARC: all 205-subfields concatenated
MARC21 : all 250-subfields concatenated
NORMARC: all 250-subfields concatenated

After applying this patch a full biblio reindexing needs to be done to make old
records searchable. New Biblios, and Biblios that are part of some operations
(checkin/out/hold/...), are searchable. These generate good test data to test
this feature without fully reindexing the search index.

TEST PLAN:
1. Find a record with some data in the "Edition Statement" -field.
2. Modify that Record and reindex it.
3. Search with the keyword "edition='<edition_statement>'" where
   <edition_statement> is the stuff you wrote in the MARC-field.
4. Observe the found record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:20:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:20:20 +0000
Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of
	a MARC Record
In-Reply-To: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11194-70-2tj0K9eFmx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36978|0                           |1
        is obsolete|                            |

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 36979
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36979&action=edit
Bug 11194 - Add a new index for "Edition Statement" of a MARC Record

Adds the "Edition Statement" MARC-field as a sortable search index in Koha.
This Field is also used by the MARC::Record->edition().

It is mapped to search keyword "edition" and it targets the following
MARC-fields:

UNIMARC: all 205-subfields concatenated
MARC21 : all 250-subfields concatenated
NORMARC: all 250-subfields concatenated

After applying this patch a full biblio reindexing needs to be done to make old
records searchable. New Biblios, and Biblios that are part of some operations
(checkin/out/hold/...), are searchable. These generate good test data to test
this feature without fully reindexing the search index.

TEST PLAN:
0. Move the search index and search word definitions from the koha source code
   to the directory where Zebra uses them.
   This is most easiest to do by reinstalling Koha, but can be manually moved
   as well.
1. Find a record with some data in the "Edition Statement" -field.
2. Modify that Record and reindex it.
3. Search with the keyword "edition='<edition_statement>'" where
   <edition_statement> is the stuff you wrote in the MARC-field.
4. Observe the found record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:21:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:21:52 +0000
Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of
	a MARC Record
In-Reply-To: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11194-70-j9KePfI08G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
There is still an issue regarding sorting this index.
Editions can be given in many ways, eg. 1. 2. 3. I II VI 2nd 3rd 1-2. ...
How to sort them smartly?
This is something for a followup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:22:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:22:20 +0000
Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of
	a MARC Record
In-Reply-To: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11194-70-HC1tq5RWEB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |olli-antti.kivilahti at jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:23:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:23:38 +0000
Subject: [Koha-bugs] [Bug 13851] Replace waiting holds logic in
 circulation.pl with Koha Objects
In-Reply-To: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13851-70-fppdtBOyqh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 36947
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36947
Bug 13851 - Replace waiting holds logic in circulation.pl with Koha Objects

Review of attachment 36947:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13851&attachment=36947)
-----------------------------------------------------------------

Please provide tests for new packages.

::: circ/circulation.pl
@@ +389,4 @@
>  # BUILD HTML
>  # show all reserves of this borrower, and the position of the reservation ....
>  if ($borrowernumber) {
> +    my $holds = Koha::Holds->new()->search( { borrowernumber => $borrowernumber } );

Koha::Holds->search
should be enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:39:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:39:02 +0000
Subject: [Koha-bugs] [Bug 13473] Plugins fail when loading templates
In-Reply-To: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13473-70-aqB6V1Fn2M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473

--- Comment #15 from H?ctor <hectorejch at yahoo.com.ar> ---
(In reply to Tom?s Cohen Arazi from comment #14)
> (In reply to H?ctor from comment #13)
> > This works, but the system language is shown only in English, although it is
> > set to Spanish
> 
> Could you please fill a new bug for that? Put this one in the 'see also'.

But the error occurs when you apply this patch.

I "solved" this by replacing:

    #Otherwise return theme/'en', last resort fallback/'en'
    for my $theme (@themes) {
        if ( -e "$htdocs/$theme/en/$where/$tmpl" ) {
            return ( $theme, 'en', uniq( \@themes ) );
        }
    }

by

    # Otherwise return theme/'en', last resort fallback/'en'
    for my $theme (@themes) {
        if ( -e "$htdocs/$theme/es-ES/$where/$tmpl" ) {
            return ( $theme, 'es-ES', uniq( \@themes ) );
        }
    }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 12:43:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 11:43:01 +0000
Subject: [Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does
 not prevent librarian from placing the hold
In-Reply-To: <bug-12197-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12197-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12197-70-PcyPkOcYRa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Before the patch, I got

Cannot place hold
    Too many holds: Joubu has too many holds.

After:

Cannot place hold
    Too many holds: Joubu can only place a maximum of 3 total holds.
    No items are available to be placed on hold

I don't understand why the second message appears.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:18:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:18:35 +0000
Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables
In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10212-70-IN822EXhv3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13372

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:18:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:18:35 +0000
Subject: [Koha-bugs] [Bug 13372] Items lost report improvements
In-Reply-To: <bug-13372-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13372-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13372-70-s5QirqzsgZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10212

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:20:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:20:51 +0000
Subject: [Koha-bugs] [Bug 13864] New: Columns configuration - Late orders
Message-ID: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

            Bug ID: 13864
           Summary: Columns configuration - Late orders
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 10212

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:20:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:20:51 +0000
Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables
In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10212-70-az1iidosSF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13864

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:22:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:22:40 +0000
Subject: [Koha-bugs] [Bug 13865] New: Columns configuration - Orders search
Message-ID: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865

            Bug ID: 13865
           Summary: Columns configuration - Orders search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 10212

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:22:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:22:40 +0000
Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables
In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10212-70-RM1iqxxQYV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13865

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:23:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:23:23 +0000
Subject: [Koha-bugs] [Bug 13866] New: Columns configuration - Patrons search
Message-ID: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

            Bug ID: 13866
           Summary: Columns configuration - Patrons search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 10212

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:23:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:23:23 +0000
Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables
In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10212-70-ZwydaZbQnC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13866

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:26:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:26:08 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-dRM2FRcnP3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:26:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:26:12 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-eMpaDHtFxX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36980
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36980&action=edit
Bug 13864: Columns configuration - Late orders

This patch adds the ability to hide columns on the late orders page
(acqui/lateorders.pl).

Test plan:
Go on the late orders page and confirm you are able to hide columns.
You can also play with the columns configuration admin page and confirm
that the behaviors are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:27:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:27:31 +0000
Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search
In-Reply-To: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13865-70-NpfsctWp8R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
         Depends on|10212                       |13864

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:27:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:27:31 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-nDuQQAVYUU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13865

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:27:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:27:31 +0000
Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables
In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10212-70-VvlrPmhgeI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13865                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:27:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:27:35 +0000
Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search
In-Reply-To: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13865-70-l22sIkkSUX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36981
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36981&action=edit
Bug 13865: Columns configuration - Orders search

This patch adds the ability to hide columns on the orders search page
(acqui/histsearch.pl).

Test plan:
Go on the orders search page and confirm you are able to hide columns.
You can also play with the columns configuration admin page and confirm
that the behaviors are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:29:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:29:00 +0000
Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search
In-Reply-To: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13866-70-Ds8NKu8hO7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|10212                       |13865
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:29:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:29:00 +0000
Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search
In-Reply-To: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13865-70-E4SDey7GQU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13866

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:29:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:29:00 +0000
Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables
In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10212-70-R7HEezJaPZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13866                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:29:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:29:05 +0000
Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search
In-Reply-To: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13866-70-QR3PKvKhtk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36982
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36982&action=edit
Bug 13866: Columns configuration - Patrons search

This patch adds the ability to hide columns on the patrons search page
(acqui/lateorders.pl).

Test plan:
Go on the patrons search page and confirm you are able to hide columns.
You can also play with the columns configuration admin page and confirm
that the behaviors are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:30:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:30:07 +0000
Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables
In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10212-70-R387l2bIY7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13865, 13866

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:30:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:30:07 +0000
Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search
In-Reply-To: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13865-70-YwRVQEXSO2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10212

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:30:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:30:07 +0000
Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search
In-Reply-To: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13866-70-xVVSyQnFKJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10212

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:34:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:34:00 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-p3OjfLsKWG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #17 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #16)
> Hi Marcel, any update on this? I'd really like to see it happen.

I will keep it on my list :) but the priority is another topic..
If someone else want to do it before me, please go ahead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:38:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:38:36 +0000
Subject: [Koha-bugs] [Bug 13473] Plugins fail when loading templates
In-Reply-To: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13473-70-UPWM3mrUXY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473

--- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to H?ctor from comment #15)
> (In reply to Tom?s Cohen Arazi from comment #14)
> > (In reply to H?ctor from comment #13)
> > > This works, but the system language is shown only in English, although it is
> > > set to Spanish
> > 
> > Could you please fill a new bug for that? Put this one in the 'see also'.
> 
> But the error occurs when you apply this patch.
> 
> I "solved" this by replacing:
> 
>     #Otherwise return theme/'en', last resort fallback/'en'
>     for my $theme (@themes) {
>         if ( -e "$htdocs/$theme/en/$where/$tmpl" ) {
>             return ( $theme, 'en', uniq( \@themes ) );
>         }
>     }
> 
> by
> 
>     # Otherwise return theme/'en', last resort fallback/'en'
>     for my $theme (@themes) {
>         if ( -e "$htdocs/$theme/es-ES/$where/$tmpl" ) {
>             return ( $theme, 'es-ES', uniq( \@themes ) );
>         }
>     }

That part of the code deals with the fallback language, in the situation the
required file doesn't exist in the requested language. So it is ok for that to
fallback to english.

Please fill a new bug if you think/see that the plugins don't respect the
selected language. And please specify the steps to reproduce it. On a new bug
report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:42:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:42:12 +0000
Subject: [Koha-bugs] [Bug 13844] Orphaned lists
In-Reply-To: <bug-13844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13844-70-SrF89dXWZ9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13844

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
This topic is/was in discussion on several older reports too. For instance, bug
11889.
Note that deleting a user should also delete his public lists currently (this
has been different for a short period of time). But you may not always like
that..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:53:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:53:33 +0000
Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
In-Reply-To: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13517-70-piI4CoCQjx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:53:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:53:36 +0000
Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
In-Reply-To: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13517-70-1aMcWbZZTH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35861|0                           |1
        is obsolete|                            |
  Attachment #35862|0                           |1
        is obsolete|                            |
  Attachment #35863|0                           |1
        is obsolete|                            |

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36983
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36983&action=edit
Bug 13517 - Show waiting date on reserve/request.pl

The holds table should show the waiting date for a hold in s similar
manner to the way it does on catalogue/detail.pl In addition, if the
ReservesMaxPickUpDelay syspref is set, we should display the date
when the waiting hold expires.

Test Plan:
1) Apply this patch
2) Set ReservesMaxPickUpDelay to 7
3) Find a waiting hold
4) Browse to reserve/request.pl for that record
5) Notice the "Item waiting" message now has "since <waitingdate>"
6) Notice the expiration field now has the date of <waitingdate> + 7 days

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:53:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:53:56 +0000
Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
In-Reply-To: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13517-70-HyUbVx6VoA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13853

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:53:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:53:56 +0000
Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for
 waiting holds in holds ajax datatable
In-Reply-To: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13853-70-xAbzYjyLP7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13517

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 13:59:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 12:59:56 +0000
Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for
 waiting holds in holds ajax datatable
In-Reply-To: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13853-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13853-70-NoNkAySRxV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36949|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36984
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36984&action=edit
Bug 13853 - Show waiting hold expiration date for waiting holds in holds ajax
datatable

We should show the expiration date for waiting holds in the holds
datatable that appears in circulation.pl and moremember.pl

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Place a second hold and set it to waiting by checking it in
4) Place a third hold with an expiration date
5) View the holds tab on circulation.pl and moremember.pl
6) Note the first hold has no expiration date
7) Note the second hold has an expiration date of today +
ReservesMaxPickUpDelay days
8) Note the thrid hold has an expiration date of whatever you set it to

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:06:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 13:06:05 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-9h4riwZhVj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:06:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 13:06:07 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-iXrcNQZHIY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36976|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36985
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36985&action=edit
[PASSED QA] Bug 13863: Fix Datatables paging on the cities and search history
pages

Test plan:
Go on admin/cities.pl and catalogue/search-history.pl and confirm the
pagination is not broken anymore.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 14:21:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 13:21:39 +0000
Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
In-Reply-To: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13517-70-MRr8N0qQ9z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36983|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 36986
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36986&action=edit
Bug 13517 - Show waiting date on reserve/request.pl

The holds table should show the waiting date for a hold in s similar
manner to the way it does on catalogue/detail.pl In addition, if the
ReservesMaxPickUpDelay syspref is set, we should display the date
when the waiting hold expires.

Test Plan:
1) Apply this patch
2) Set ReservesMaxPickUpDelay to 7
3) Find a waiting hold
4) Browse to reserve/request.pl for that record
5) Notice the "Item waiting" message now has "since <waitingdate>"
6) Notice the expiration field now has the date of <waitingdate> + 7 days

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:01:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 14:01:15 +0000
Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY
 of message_queue
In-Reply-To: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7793-70-g4gvmkHtnR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:01:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 14:01:19 +0000
Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY
 of message_queue
In-Reply-To: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7793-70-nZ4I7JueQf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36945|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36987
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36987&action=edit
Bug 7793 - redefine the field message_id as PRIMARY KEY of message_queue

Making message_queue work nicely with DBIx.

DROP the existing KEY and replace with an PRIMARY KEY.
If somebody has managed to get duplicate message_ids in his/her
message_queue-table, this patch takes care of them as well, but givin
all duplicate message_id's a new id.

TEST INSTRUCTIONS: in the patch.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:07:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 14:07:49 +0000
Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY
 of message_queue
In-Reply-To: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7793-70-KRy6ZCFR05@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

--- Comment #15 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Thanks for the sign off Joubu!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:23:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 14:23:00 +0000
Subject: [Koha-bugs] [Bug 5327] Omnibus for unit tests required for all C4
	modules
In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5327-70-kiQm7FkP4t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |MOVED

--- Comment #243 from Jonathan Druart <jonathan.druart at biblibre.com> ---
There is no activity on this bug for more than 2 years and a lot of other bug
reports have been opened.
This one can be closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:23:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 14:23:24 +0000
Subject: [Koha-bugs] [Bug 11889] Disown a list
In-Reply-To: <bug-11889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11889-70-JO2LHRe4ny@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to M. de Rooy from comment #1)
> Please see bug 9032 also. One of the last patches on that report made Koha
> behavior consistent when deleting a list or deleting a patron.
> But what if we would like to keep public lists or shared lists when deleting
> a patron that owned these lists?
> 
> We could add a syspref that controlled this. If enabled, we could allow
> owner NULL for public and shared lists if the patron is deleted, or if the
> patron deletes one of those lists. (Instead of the NULL value, we could also
> move them to a designated patron for this purpose.)
> 
> In the attachment some code that shows what should go into
> HandleDelBorrower. Similar changes should be made to DelShelf.
> 
> What do you think? Is this a welcome feature or is it confusing and should
> we just delete these lists?

Lists should not just automatically be deleted.  It should be a preference. 
Some public lists created by a former staff account, for example.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:27:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 14:27:18 +0000
Subject: [Koha-bugs] [Bug 9269] Remove  DefaultLanguageField008 syspref
In-Reply-To: <bug-9269-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9269-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9269-70-7pKv2dUJm1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9269

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Katrin, I don't see anything on bug 9145 related to this pref.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:44:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 14:44:24 +0000
Subject: [Koha-bugs] [Bug 13674] Remove useless output from t/Debug.t
In-Reply-To: <bug-13674-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13674-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13674-70-sE2XktoPgw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13674

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz,
                   |                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I am wondering if C4::Debug is useful or could be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 15:51:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 14:51:47 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-sLnNvjQX78@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36988
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36988&action=edit
Bug 13758: Add POD

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:51:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 15:51:54 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-r0X55fbnTI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:51:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 15:51:58 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-I3hVoXi6jR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36989
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36989&action=edit
Bug 2542: Validate the amount of a manual invoice

If a manual invoice amount is not correctly set, it should not be
accepted.

Test plan:
Try to create a manual invoice with an amount containing something else
than numbers.
It should not be possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:52:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 15:52:19 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-CGD7skvz4Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:55:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 15:55:13 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-DM7rj7u5Ae@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36989|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36990
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36990&action=edit
Bug 2542: Validate the amount of a manual invoice

If a manual invoice amount is not correctly set, it should not be
accepted.

Test plan:
Try to create a manual invoice with an amount containing something else
than numbers.
It should not be possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 16:59:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 15:59:56 +0000
Subject: [Koha-bugs] [Bug 2537] inconsistent behavior when entering tag via
 add button or hitting return
In-Reply-To: <bug-2537-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2537-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2537-70-5VS56EM9PK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2537

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
         Resolution|---                         |WORKSFORME

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I don't reproduce this behavior with modern browsers.
Please reopen if it is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:11:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 16:11:56 +0000
Subject: [Koha-bugs] [Bug 13724] Not possible to undo a selected facet when
 search started with an authority id search
In-Reply-To: <bug-13724-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13724-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13724-70-aoaYOir5jd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13724

kholt at roseville.ca.us changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kholt at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:21:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 16:21:56 +0000
Subject: [Koha-bugs] [Bug 13266] renewing an item doesn't remove lost
In-Reply-To: <bug-13266-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13266-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13266-70-lBPN0ylC9M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13266

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |kyle at bywatersolutions.com

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 9805 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:21:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 16:21:56 +0000
Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned,
	but not if renewed.
In-Reply-To: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9805-70-CcMy0tBcVU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
*** Bug 13266 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:22:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 16:22:08 +0000
Subject: [Koha-bugs] [Bug 2537] inconsistent behavior when entering tag via
 add button or hitting return
In-Reply-To: <bug-2537-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2537-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2537-70-NEU7OT22Ge@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2537

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
See bug 9120 for a fix on the result view.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:26:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 16:26:51 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-TjELCoiGe5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:26:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 16:26:56 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-kqWV0MvXag@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36991
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36991&action=edit
Bug 9120: Prevent form submission on adding tags - OPAC

At the OPAC, if the user adds tags pressing 'Enter', the page is
reloaded and the tags are not added.
To prevent that, this patch suggests to block the "press enter" event on
the inputs.

Test plan:
0/ Confirm the bad behavior, without this patch.
1/ Apply this patch and confirm nothing happen on pressing enter when
the focus is on the add tag input (At the opac, on the result view).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:29:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 16:29:27 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-NNaDRyuo0O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|oleonard at myacpl.org         |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:39:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 16:39:09 +0000
Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes
 are not URL encoded.
In-Reply-To: <bug-13812-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13812-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13812-70-dFCVA5Lyez@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Facet links broken when     |Facet links broken because
                   |shelf location limit is     |double-quotes are not URL
                   |used.                       |encoded.

--- Comment #1 from Barton Chittenden <barton at bywatersolutions.com> ---
(In reply to Barton Chittenden from comment #0)
> This bug is analogous to Bug 13442, but it affects shelf location rather
> than collection code:
> 
> Limiting a search by shelf location is broken, because it wraps
> double-quotes around the "value" part of the key-value pair in the URL. This
> breaks the href= part of the anchor tag.
> 
> The anchor tag generated for the shelf location faced is
> 
> <a
> href="/cgi-bin/koha/opac-search.pl?&limit=mc-loc%3A"100100ADFICCF"&limit=mc-
> loc%3A"100200ADFIC"&limit=mc-loc%3A"100250ADFICGN"&limit=mc-
> loc%3A"100300ADFICHF"&limit=yr%2Cst-numeric%3D2014-&amp;
> sort_by=acqdate_dsc&amp;limit=au:Paetro%2C%20Maxine%2C" title="Paetro,
> Maxine,">Paetro, Maxine,</a>
> 
> Once again, double-quotes inside the URL are causing a premature close of
> the href, which results in a broken link.
> 
> I think that we need to take a look for code duplication inside
> C4::Search::buildQuery -- if there's more than one section of code where
> we're wrapping quotes around the 'value' part of the query, these should be
> consolidated -- shouldn't we be using URL encoding for URL reserved
> characters anyway?

I found another example, this time in facets under Subject:

Starting here:

https://library.roseville.ca.us/cgi-bin/koha/opac-detail.pl?biblionumber=35767&query_desc=kw%2Cwrdl%3A%20Fairies

Click on Subject: Faries ... this leads us here:

https://library.roseville.ca.us/cgi-bin/koha/opac-search.pl?q=su:"Fairies."

All of the facets on this page are broken, because the quotes are passed
straight in, without being URL encoded. Here's an example from the HTML of that
page:

<span class="facet-label"><a
href="/cgi-bin/koha/opac-search.pl?q=ccl=su%3A"Fairies."&amp;sort_by=relevance_asc&amp;limit=su-to:Magic"
title="Magic">Magic</a></span>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:42:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 16:42:51 +0000
Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes
 are not URL encoded.
In-Reply-To: <bug-13812-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13812-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13812-70-waufyeo1cl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 17:43:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 16:43:35 +0000
Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code
	limit is used
In-Reply-To: <bug-13442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13442-70-wgCRR0o1Rh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 19:18:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 18:18:01 +0000
Subject: [Koha-bugs] [Bug 13867] New: change input in 245$a and 245$c for
	textarea
Message-ID: <bug-13867-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13867

            Bug ID: 13867
           Summary: change input in 245$a and 245$c for textarea
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: marjorie.barry-vila at ccsr.qc.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi,

Is it be possible to have for subfield 245$a and 245$c in marc21 textarea and
not input like textarea for fields 5XX?

Title and statement of responsability are now often a length greater than a
line only and that would be easier to catalog with textarea.

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 19:51:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 18:51:24 +0000
Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes
 are not URL encoded.
In-Reply-To: <bug-13812-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13812-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13812-70-46TnW6hoNj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
           Severity|enhancement                 |normal
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:11:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 19:11:46 +0000
Subject: [Koha-bugs] [Bug 13859] Fix item search result list - obsolete "by"
 and display of publication date for MARC21
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-sDgNaRECIV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36971|0                           |1
        is obsolete|                            |

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36992
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36992&action=edit
Bug 13859: Item search improvements - publication date and title formatting

In the item search accessible from the advanced search the publication
date would not display for MARC21 and the title always contained 'by'
even if there was no author information to display. Also the by is
not needed by MARC21 as the data includes punctuation.

To test:
- Check publication date always displays (MARC21 and UNIMARC)
- Check that for MARC21 the by has been removed from the title information
- Check that for UNIMARC the by only displays when there is also
  an author to display

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Tested for MARC21

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:12:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 19:12:09 +0000
Subject: [Koha-bugs] [Bug 13859] Fix item search result list - obsolete "by"
 and display of publication date for MARC21
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-CqCrq0rHWT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:12:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 19:12:55 +0000
Subject: [Koha-bugs] [Bug 13859] Fix item search result list - obsolete "by"
 and display of publication date for MARC21
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-z5JAqaOFX5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
Works for MARC21, setting back to needs signoff for a UNIMARC-Tester.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:30:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 19:30:35 +0000
Subject: [Koha-bugs] [Bug 13856] Hard to translate strings on patron search
	results page
In-Reply-To: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13856-70-t67fPtIg3Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13856

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36966|0                           |1
        is obsolete|                            |

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 36993
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36993&action=edit
Bug 13856: Hard to translate strings on patron search results page

'Add selected patrons to:' at the top of the patron search result
table is hard to translate correctly, because the 'to:' appears
as a separate string from the rest of the sentence.

To test:
- Make sure patron lists are activated
- Do a patron search with more than 1 result
- Look for the text at the top of the search results table
- Verify it looks the same before and after the patch

Bonus:
- run perl translate update <langcode> and verify the
  2 strings are now 1 string with the patch applied

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 20:30:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 19:30:51 +0000
Subject: [Koha-bugs] [Bug 13856] Hard to translate strings on patron search
	results page
In-Reply-To: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13856-70-C0WTIKdOSv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13856

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:22:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:22:21 +0000
Subject: [Koha-bugs] [Bug 13868] New: Date on routing list slip is not well
	formatted
Message-ID: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

            Bug ID: 13868
           Summary: Date on routing list slip is not well formatted
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Serials
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

The date planned printed on the issue slip is not formatted according to the
dateformat system preference setting.

To test:
- enable RoutingSerials
- create a subscription
- create a routing list from the serial collection page
- use the 'print list' links next to the issues to print a routing list
- verify that the date there is not displayed according to the dateformat 
  system preference without the patch, but is correct with the patch applied

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:24:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:24:06 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-t49FKIv1tM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:24:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:24:08 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-BMEn0KnTZo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36994
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36994&action=edit
Bug 13868: Correct formatting of date on routing list slip

The date planned printed on the issue slip is not formatted
according to the dateformat system preference setting.

To test:
- enable RoutingSerials
- create a subscription
- create a routing list from the serial collection page
- use the 'print list' links next to the issues to print a routing list
- verify that the date there is not displayed according to the dateformat
  system preference without the patch, but is correct with the patch applied

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:31:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:31:52 +0000
Subject: [Koha-bugs] [Bug 13869] New: Wrong capitalization on guided reports
	page
Message-ID: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

            Bug ID: 13869
           Summary: Wrong capitalization on guided reports page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

On the last step of saving a new guided report to the database, the button is
labelled "Save Report", but should be "Save report".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:34:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:34:11 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-e6pkCyqrHQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Small patch                 |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:34:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:34:13 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-SmCutmYszD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36994|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36995
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36995&action=edit
Bug 13869: Wrong capitalization of 'Save Report' in guided reports

On the last step of saving a new guided report to the database,
the button is labelled 'Save Report', but should be 'Save report'.

To test:
- Create a new guided report from the reports page
- Check on the very last step, when saving the report to the
  database, the button is labelled 'Save Report'
- With the patch applied, this reads 'Save report' instead

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:38:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:38:57 +0000
Subject: [Koha-bugs] [Bug 13870] New: Add subscription and order count to
 new batch record deletion tool
Message-ID: <bug-13870-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870

            Bug ID: 13870
           Summary: Add subscription and order count to new batch record
                    deletion tool
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

The batch record deletion tool checks for items, holds and checkouts. It would
be a nice enhancement to also show linked subscriptions and orders. This would
then match the checks done in acquisitions in order to be able to delete the
record when cancelling an order line.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:39:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:39:12 +0000
Subject: [Koha-bugs] [Bug 13870] Add subscription and order count to new
 batch record deletion tool
In-Reply-To: <bug-13870-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13870-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13870-70-KxfsTlgtIG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12403

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:39:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:39:12 +0000
Subject: [Koha-bugs] [Bug 12403] Batch record deletion
In-Reply-To: <bug-12403-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12403-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12403-70-J5QTANW5Lv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13870

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:40:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:40:51 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-cvotHInKRt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36995|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:41:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:41:11 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-OaPlDISZt6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36994|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:42:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:42:15 +0000
Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
In-Reply-To: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13869-70-8hWSMJHs9i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:42:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:42:18 +0000
Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
In-Reply-To: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13869-70-ND1RAh1w6Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 36996
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36996&action=edit
Bug 13869: Wrong capitalization of 'Save Report' in guided reports

On the last step of saving a new guided report to the database,
the button is labelled 'Save Report', but should be 'Save report'.

To test:
- Create a new guided report from the reports page
- Check on the very last step, when saving the report to the
  database, the button is labelled 'Save Report'
- With the patch applied, this reads 'Save report' instead

http://bugs.koha-community.org/show_bug.cgi?id=13868

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 18 23:43:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 18 Mar 2015 22:43:27 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-PVkoO910Z1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|String patch                |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 01:08:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 00:08:52 +0000
Subject: [Koha-bugs] [Bug 13871] New: OverDrive message when user
	authentication fails
Message-ID: <bug-13871-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

            Bug ID: 13871
           Summary: OverDrive message when user authentication fails
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bob at calyx.net.au
        QA Contact: testopia at bugs.koha-community.org

When a Koha user offers correct credentials, Overdrive redirects to the users'
Overdrive account page and no messages from Koha are displayed.

However:
1.  Where a correct cardnumber is entered with an incorrect password, Koha's
SIP server responds with '(1) Greetings from Koha.'
2.  Where an incorrect cardnumber is entered (with any password), the SIP
server responds with a blank message: '(1) '

These are displayed on an Overdrive page which includes a link: 'Click here
to return to the sign in form' but there is nothing to draw the user's
attention to their error and the need to follow that link back to try again.

We propose to replace these messages with 'You have entered an incorrect
cardnumber or password.  Please try again.'   This will appear just above
the 'Click here to return ...' link and should make the process obvious for
the user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 01:10:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 00:10:47 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-bg7ap36G5g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

--- Comment #1 from Bob Birchall <bob at calyx.net.au> ---
This change is being sponsored by Melbourne Athenaeum Library.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 01:11:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 00:11:39 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-6mUpMTPYQR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #2 from Bob Birchall <bob at calyx.net.au> ---
Colin Campbell wrote:
I've had this reported recently but havent been able to look at it. I
think there might be a change of behaviour I think screen message used to
get a default value in cases like this rather than the cryptic "1". It
may be the initial flag value for screen_msg in ILS::Patron is not
getting replaced by a default?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 01:13:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 00:13:55 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-bMPm5zMtnW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 01:59:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 00:59:30 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-xl6XO1zuQq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 02:00:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 01:00:07 +0000
Subject: [Koha-bugs] [Bug 13858] Datatables paging for news page is broken
In-Reply-To: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13858-70-Hnjak7PmAG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13858

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 03:53:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 02:53:41 +0000
Subject: [Koha-bugs] [Bug 13872] New: Typographical error on
	columns_settings.tt
Message-ID: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

            Bug ID: 13872
           Summary: Typographical error on columns_settings.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Documentation
          Assignee: nengard at gmail.com
          Reporter: hector.hecaxmmx at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The new help for Koha 3.18.5 has a typo in line 9 for "columsn" word.

The section name does not fit with the module i.e. title in staff client says
"Columns settings" in help says "Column Settings" even title section doesn't
follow coding guideline HTML4: Upper and lower cases in strings at wiki
<http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_lower_cases_in_strings>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 03:55:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 02:55:47 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-kCDq7rFdIx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13771
                 CC|                            |bgkriegel at gmail.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 03:55:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 02:55:47 +0000
Subject: [Koha-bugs] [Bug 13771] Koha 3.18 Help Files
In-Reply-To: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13771-70-yanGHoPhuE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13872

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 04:12:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 03:12:51 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-eTMStNFG27@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

--- Comment #1 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 36997
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36997&action=edit
Bug 13872 - Typographical error on columns_settings.tt

Bug 13872 - Typographical error on columns_settings.tt

Test plan:
1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/columns_set
2) See also changes for Column settings to Columns settings at lines 3 and 1
3) Apply the patch
4) Repeat step 1 and chek if the typo is fixed or go to Administration > Add

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 04:13:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 03:13:38 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-FvPwys1nYn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |hector.hecaxmmx at gmail.com
                   |y.org                       |
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 04:14:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 03:14:17 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-FSvBowooBa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|hector.hecaxmmx at gmail.com   |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 04:15:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 03:15:10 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-bt3It6wZww@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nengard at gmail.com           |hector.hecaxmmx at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 04:17:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 03:17:31 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-QhI9VE0ztW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 04:23:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 03:23:05 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-QqhROmIH5P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

--- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Sorry, Rewording test plan

Bug 13872 - Typographical error on columns_settings.tt

Test plan:
1) Go to url
'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/columns_settings.tt' line 9
and check the typo "columsn" and change for columns.
2) See also changes for Column settings to Columns settings at lines 3 and 15
3) Apply the patch
4) Repeat step 1 and chek if the typo is fixed or go to Administration >
Additional parameters > Configure columns and go to Help page.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:35:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 07:35:15 +0000
Subject: [Koha-bugs] [Bug 7339] Help System in IE8 Does Not Load With 500
	Error
In-Reply-To: <bug-7339-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7339-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7339-70-HJ7VkWW2NS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7339

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED
                 CC|                            |z.tajoli at cineca.it

--- Comment #16 from Zeno Tajoli <z.tajoli at cineca.it> ---
IE 7 is now not supported by Koha.
Bug closed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:35:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 07:35:59 +0000
Subject: [Koha-bugs] [Bug 7339] Help System in IE8 Does Not Load With 500
	Error
In-Reply-To: <bug-7339-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7339-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7339-70-q5bPpZ6aDM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7339

--- Comment #17 from Zeno Tajoli <z.tajoli at cineca.it> ---
The same for IE 8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 08:38:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 07:38:58 +0000
Subject: [Koha-bugs] [Bug 13873] New: Lenghty tables do not properly print
	in Firefox
Message-ID: <bug-13873-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13873

            Bug ID: 13873
           Summary: Lenghty tables do not properly print in Firefox
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

>From IRC: Reserve que only prints the first page from firefox.

Maybe related to:
https://support.mozilla.org/de/questions/967636

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:10:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 08:10:24 +0000
Subject: [Koha-bugs] [Bug 13867] change input in 245$a and 245$c for textarea
In-Reply-To: <bug-13867-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13867-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13867-70-e8HMzWOk3g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13867

--- Comment #1 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
This is hardcoded in addbiblio:
 if (
            length($value) > 100
            or
            ( C4::Context->preference("marcflavour") eq "UNIMARC" && $tag >=
300
                and $tag < 400 && $subfield eq 'a' )
            or (    $tag >= 500
                and $tag < 600
                && C4::Context->preference("marcflavour") eq "MARC21" )
          )
[ then textarea ... ]

Note that if you save a string of 101 chars and re-edit, you should get a
textarea..
A regex from a syspref instead of the hardcoded 500 and 600 here would be an
idea..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:26:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 08:26:58 +0000
Subject: [Koha-bugs] [Bug 12137] Extend CalendarFirstDayOfWeek to be any day
In-Reply-To: <bug-12137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12137-70-lJiiVghSGp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:31:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 08:31:19 +0000
Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed
In-Reply-To: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11385-70-cNhAwpdBJz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Needs Signoff               |BLOCKED

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
This depends on a report without patches in status Assigned.
Moving status to BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:47:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 08:47:48 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-buzubEq2Cn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Mar 19 09:40:31 kernel: type=1400 audit(): avc:  denied  { write } for 
pid=14194 comm="sh" name="log" dev="md2" ino=11150563
scontext=system_u:system_r:httpd_sys_script_t:s0
tcontext=unconfined_u:object_r:httpd_log_t:s0 tclass=dir

If I set the permission of this log folder to 777 (which I do not like!), I
stumble over my next security measure: SELinux. That's good :)
I can go further and add exceptions for that too of course. But I think we are
working in the wrong direction.

Can we REVERT this patch please?
The patch is meant for Plack users. Please write it so that non-Plack users are
not affected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 09:55:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 08:55:21 +0000
Subject: [Koha-bugs] [Bug 11165] auth_header.datemodified should be updated
In-Reply-To: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11165-70-aaJLyVmtb1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Needs Signoff               |Failed QA

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
What about:
Koha/Schema/Result/AuthHeader.pm:  "datemodified",
installer/data/mysql/kohastructure.sql:  `datemodified` date default NULL,

Also I do not like the update of datemodified when running the dbrev. If you
rename the column and add the 'on update' clause later, you should be able to
prevent that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:13:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 09:13:16 +0000
Subject: [Koha-bugs] [Bug 13856] Hard to translate strings on patron search
	results page
In-Reply-To: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13856-70-g3f4hqxasd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13856

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36993|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36998
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36998&action=edit
Bug 13856: Hard to translate strings on patron search results page

'Add selected patrons to:' at the top of the patron search result
table is hard to translate correctly, because the 'to:' appears
as a separate string from the rest of the sentence.

To test:
- Make sure patron lists are activated
- Do a patron search with more than 1 result
- Look for the text at the top of the search results table
- Verify it looks the same before and after the patch

Bonus:
- run perl translate update <langcode> and verify the
  2 strings are now 1 string with the patch applied

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:13:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 09:13:12 +0000
Subject: [Koha-bugs] [Bug 13856] Hard to translate strings on patron search
	results page
In-Reply-To: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13856-70-4LVPGuBVc7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13856

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:40:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 09:40:14 +0000
Subject: [Koha-bugs] [Bug 11165] auth_header.datemodified should be updated
In-Reply-To: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11165-70-LwiRRJ0Ufg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:40:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 09:40:17 +0000
Subject: [Koha-bugs] [Bug 11165] auth_header.datemodified should be updated
In-Reply-To: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11165-70-gbe9qfPkoB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34330|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36999
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36999&action=edit
Bug 11165: Automatically save the authority last modification time

This patch rename the column auth_header.datemodified with modification_time.
Now this column will be automatically updated when a row will be
updated.

Test plan:
0/ Verify that la major part of your auth_header.datemodified is set to
null
1/ Execute the updatedb entry
2/ Verify that the column is renamed and the values is set to now
(something better to suggest?)
3/ Update an authority and verify (using the sql cli) that this value
has been updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:40:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 09:40:58 +0000
Subject: [Koha-bugs] [Bug 11165] auth_header.datemodified should be updated
In-Reply-To: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11165-70-V2gOugXi9X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36999|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37000
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37000&action=edit
Bug 11165: Automatically save the authority last modification time

This patch rename the column auth_header.datemodified with modification_time.
Now this column will be automatically updated when a row will be
updated.

Test plan:
0/ Verify that la major part of your auth_header.datemodified is set to
null
1/ Execute the updatedb entry
2/ Verify that the column is renamed and the values have not been
changed.
3/ Update an authority and verify (using the sql cli) that this value
has been updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 10:42:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 09:42:01 +0000
Subject: [Koha-bugs] [Bug 11165] auth_header.datemodified should be updated
In-Reply-To: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11165-70-UlKcumQT76@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to M. de Rooy from comment #3)
> What about:
> Koha/Schema/Result/AuthHeader.pm:  "datemodified",
> installer/data/mysql/kohastructure.sql:  `datemodified` date default NULL,

Oops!
The schema file will be updated by the RM.

> Also I do not like the update of datemodified when running the dbrev. If you
> rename the column and add the 'on update' clause later, you should be able
> to prevent that.

Ho good catch, I have just tried and it seems to work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:13:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:13:08 +0000
Subject: [Koha-bugs] [Bug 13859] Fix item search result list - obsolete "by"
 and display of publication date for MARC21
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-VTFCXZDkFm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:13:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:13:11 +0000
Subject: [Koha-bugs] [Bug 13859] Fix item search result list - obsolete "by"
 and display of publication date for MARC21
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-8Jpsq2OOR5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36992|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37001
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37001&action=edit
Bug 13859: Item search improvements - publication date and title formatting

In the item search accessible from the advanced search the publication
date would not display for MARC21 and the title always contained 'by'
even if there was no author information to display. Also the by is
not needed by MARC21 as the data includes punctuation.

To test:
- Check publication date always displays (MARC21 and UNIMARC)
- Check that for MARC21 the by has been removed from the title information
- Check that for UNIMARC the by only displays when there is also
  an author to display

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Tested for MARC21

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:18:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:18:13 +0000
Subject: [Koha-bugs] [Bug 3125] IE7-8: Selected columns list in Reports
 Dictionary is not showing column names.
In-Reply-To: <bug-3125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3125-70-NNjznXvGdN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3125

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Is this one solved with newer versions of IE?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:19:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:19:14 +0000
Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for
	performance
In-Reply-To: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13852-70-HrhmHKEjtk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:19:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:19:16 +0000
Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for
	performance
In-Reply-To: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13852-70-I6P8eP09a0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36950|0                           |1
        is obsolete|                            |

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37002
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37002&action=edit
Bug 13852 - Manage C4::VirtualShelves in C4::Auth for performance

In C4::Auth there is a use C4::VirtualShelves.
Virtualshelves are displayed in all OPAC pages, but not in intranet.
For performance, we should move this into a require only for opac pages.

This patch adds a condition to fetch virtualshelves only if opac and moves the
dependancy on C4::VirtualShelves into require calls.

On my desktop, I have those compilation times for C4/Auth.pm :
- Without patch : 0,41 seconds
- With patch : 0,22 seconds

This performance improvement is very usefull for pages that only use a few as
dependancy, like errors/404.pl

Test plan :
- Be sure there are some public lists
- Apply patch
- Go to opac (not logged-in)
- Click on "Lists"
- Check you see the public lists
- Login with a user
- Be sure this user has some private lists
- Click on "Lists"
- Check you see the public and private lists
- Logout
- Go to /cgi-bin/koha/opac-reserve.pl
- You see the loggin page
- Click on "Lists"
- Check you see the public lists
- Go to intranet
- Check you can loggin

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:23:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:23:36 +0000
Subject: [Koha-bugs] [Bug 13857] Email input field for sharing lists is too
	small
In-Reply-To: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13857-70-QXsxNTYwkI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13857

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:23:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:23:38 +0000
Subject: [Koha-bugs] [Bug 13857] Email input field for sharing lists is too
	small
In-Reply-To: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13857-70-CfZE2VARN5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13857

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36967|0                           |1
        is obsolete|                            |

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37003
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37003&action=edit
Bug 13857: Email field for sharing is a bit short

The email field for sharing a list with another patron is
a bit short.

To test:
- Make sure OpacAllowSharingPrivateLists is activated
- Create a list in OPAC
- Use the "Share list" link to share with another user
- Check the length of the email field and if you like it
  better with this patch applied

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:24:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:24:25 +0000
Subject: [Koha-bugs] [Bug 13857] Email input field for sharing lists is too
	small
In-Reply-To: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13857-70-hbKLEYTFda@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13857

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
This is so trivial that I take the liberty to pass QA in one run.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:34:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:34:12 +0000
Subject: [Koha-bugs] [Bug 13674] Remove useless output from t/Debug.t
In-Reply-To: <bug-13674-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13674-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13674-70-vXeieRDHHo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13674

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
<rangi> just a vestige .. Koha::Log or something should theoretically take its
place

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:35:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:35:08 +0000
Subject: [Koha-bugs] [Bug 13861] \n in strings don't translate well
In-Reply-To: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13861-70-QWx84WcsZ7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13861

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:35:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:35:10 +0000
Subject: [Koha-bugs] [Bug 13861] \n in strings don't translate well
In-Reply-To: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13861-70-k611uJaOVR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13861

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36972|0                           |1
        is obsolete|                            |

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37004
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37004&action=edit
Bug 13861: \n in confirmation message on closing a budget

\n in strings doesn't translate well, so we move it outside
the translated string.

To test:
- create at least 2 budgets
- close one of the budgets (moving orders from one budget to the other)
- after selecting the budget to move your orders to, save
- the confirmation message shown should read:

You have chosen to move all unreceived orders from 'budget 1' to 'budget 2'.
This action cannot be reversed. Do you wish to continue?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:36:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:36:05 +0000
Subject: [Koha-bugs] [Bug 13861] \n in strings don't translate well
In-Reply-To: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13861-70-yFLdsYbFec@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13861

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Passed QA

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Very trivial: Passed QA in one run.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:42:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:42:12 +0000
Subject: [Koha-bugs] [Bug 3849] Acq Permissions unclear
In-Reply-To: <bug-3849-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3849-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3849-70-rC2d33GtTO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
What is the issue here?
The permissions don't work (in this case, what are the issues?) or the
descriptions need to be updated?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:52:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:52:34 +0000
Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves
In-Reply-To: <bug-13421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13421-70-Lfu8BaDP9f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421

--- Comment #8 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #7)
> I think we need to standardize our timestamp columns in Koha. I think this
> would be as good a place to start as any. I would suggest we use created_on
> for creation timestamps, and updated_on for last updated timestamps, if you
> have no objections. This is the naming convention I used for the accounts
> rewrite. I will also bring the issue up at the next channel meeting.

What did this channel meeting bring up?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:54:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:54:04 +0000
Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp
In-Reply-To: <bug-10459-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10459-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10459-70-eTMgEkpgLI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #18 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. de Rooy from comment #15)
> No. I will submit another patch as discussed on the dev list some time ago..

For documentation: you can find the discussion in the dev list archives of
November 2014.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 11:58:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 10:58:20 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
	for serials
In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8296-70-yJ9AWmgiz8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

--- Comment #101 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Julian, 

I have started on this and so far it looks good, but I am a little confused
about the general idea of this:

- Could you maybe give some more explanation about the use case?
- Why do we display it almost everywhere in staff, but only on a very hidden
page in the OPAC?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 12:11:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 11:11:55 +0000
Subject: [Koha-bugs] [Bug 13859] Fix item search result list - obsolete "by"
 and display of publication date for MARC21
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-PfvQGUlNJ3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 12:11:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 11:11:57 +0000
Subject: [Koha-bugs] [Bug 13859] Fix item search result list - obsolete "by"
 and display of publication date for MARC21
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-NZIepmyXx6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37001|0                           |1
        is obsolete|                            |

--- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37005
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37005&action=edit
Bug 13859: Item search improvements - publication date and title formatting

In the item search accessible from the advanced search the publication
date would not display for MARC21 and the title always contained 'by'
even if there was no author information to display. Also the by is
not needed by MARC21 as the data includes punctuation.

To test:
- Check publication date always displays (MARC21 and UNIMARC)
- Check that for MARC21 the by has been removed from the title information
- Check that for UNIMARC the by only displays when there is also
  an author to display

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Tested for MARC21

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 12:12:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 11:12:24 +0000
Subject: [Koha-bugs] [Bug 13859] Fix item search result list - obsolete "by"
 and display of publication date for MARC21
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-0HRppptn4R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:11:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 12:11:18 +0000
Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
In-Reply-To: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13869-70-RQ2ZRb5cuQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Please test carefully -- In Guided Reports the label on the button might be
used as a parameter by the script for determining what action to take.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:14:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 12:14:37 +0000
Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
In-Reply-To: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13869-70-hgLiFaUnXn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Good point Owen - I avoided changing other occurrences and only changed the
value that is getting translated. So I hope the change is save. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:49:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 12:49:15 +0000
Subject: [Koha-bugs] [Bug 11165] auth_header.datemodified should be updated
In-Reply-To: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11165-70-pZ2kXhNBjQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37000|0                           |1
        is obsolete|                            |

--- Comment #7 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37006
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37006&action=edit
Bug 11165: Automatically save the authority last modification time

This patch rename the column auth_header.datemodified with modification_time.
Now this column will be automatically updated when a row will be
updated.

Test plan:
0/ Verify that la major part of your auth_header.datemodified is set to
null
1/ Execute the updatedb entry
2/ Verify that the column is renamed and the values have not been
changed.
3/ Update an authority and verify (using the sql cli) that this value
has been updated.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
In the absence of a coding guideline stipulating a preferred column
name for a timestamp, this modification_time works for me.
Null values are replaced by current time after db rev; other values
are left alone.
NOTE FOR RM: Please run update_dbix_class_files.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 13:50:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 12:50:12 +0000
Subject: [Koha-bugs] [Bug 11165] auth_header.datemodified should be updated
In-Reply-To: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11165-70-jlJHByUktO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:14:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 13:14:14 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
	for serials
In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8296-70-gjbhhyQmwv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #102 from Julian Maurice <julian.maurice at biblibre.com> ---
1/ The initial need was to "describe" the date in a more human-friendly format.
For instance, if periodicity is "once every two months", instead of 2015-01-01
we can have "2015 January-February"

2/ I don't know very well the subscriptions part in OPAC. I can add this
information in other pages as well, if you tell me where :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:14:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 13:14:43 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-Gr0KY4VCbJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:14:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 13:14:45 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-quflkYJQFg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37007
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37007&action=edit
Bug 13855 - Fastadd framework has 2x 100$c, missing 100$a

The fastadd framework ist missing a 100$a subfield, it has two 100$c instead.
This patch corrects English, German, Italian and Spanish .sql files.
Italian and Spanish need translations for the field name.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested running all sql files manually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:15:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 13:15:17 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-VS6uDkeMcD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:15:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 13:15:19 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-pGUO8GG5r8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36973|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:17:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 13:17:06 +0000
Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned,
	but not if renewed.
In-Reply-To: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9805-70-WRwQHfD4Dc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:17:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 13:17:08 +0000
Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned,
	but not if renewed.
In-Reply-To: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9805-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9805-70-j6pTTvX670@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29214|0                           |1
        is obsolete|                            |

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37008
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37008&action=edit
Bug 9805 [QA Followup] - Control renewing and finding of list items via circ
rules

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Browse to the circ rules
4) Note the "Renew lost?" and "Renewal marks lost found" rules
5) Set and test each of the rules both ways for the rules for all libraries
6) Repeat but for a specific branch this time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:24:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 13:24:51 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-TeZxchLzFj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
I should note you can also test this by backdating a return to an hour before
the current time. This will trigger the behavior and is more easily testable in
a sandbox!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 14:30:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 13:30:59 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-x3VODo9ctw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
If I save a column (information) on the admin page (when hiding it), the admin
page does not show that again. The late orders either.
Seems to be a bug of what has been pushed already.
Since I cannot fail QA on master, I do it here :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:00:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 14:00:30 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-ri0DdvCjsF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

--- Comment #3 from Nicole C. Engard <nengard at gmail.com> ---
Thanks for finding the typo, but be aware that the help files haven't followed
the capitalization rules in the past.  

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:01:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 14:01:48 +0000
Subject: [Koha-bugs] [Bug 3849] Acq Permissions unclear
In-Reply-To: <bug-3849-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3849-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3849-70-SoAOxSIGlr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849

--- Comment #8 from Nicole C. Engard <nengard at gmail.com> ---
We don't know what the permissions are supposed to do because the descriptions
are unclear so we can't tell you if they work :)  So we need clearer permission
descriptions and then we'll tell you if they work.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:02:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 14:02:24 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-1xU4mfpjXy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36808|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37009
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37009&action=edit
Bug 13822 - Patron autocomplete search is severly limited

The script that returns data for the patron autocomplete does not use
C4::Members::Search. Instead it uses bespoke code that does not behave like the
traditional search and is very limited in how it can search.

If, for example, I search for "Kyle Hall" in the standard search, I would get
"Kyle Hall" back as a result. For the autocomplete search, I will not.

This script should use C4::Members::Search to provide better searching and to
keep the code base DRY.

Test Plan:
1) Enable the system preference CircAutocompl
2) Create a user with the first name "Test" and the surname "User"
3) Perform a checkout autocomplete search for "Test User"
4) Note you do not get the user as a result
5) Apply this patch
6) Try different combinations of "Test" and "User" such as
   Test User
   User Test
   U Test
   Test U
   etc.
7) Note these searches now work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:03:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 14:03:03 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-PaK50WE0Ut@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Done!

(In reply to Marc V?ron from comment #2)
> Tested for signing off, search behaviour is much better now!
> 
> However, I propose to keep sorting, something like:
> 
> my $order_by = 'surname, firstname';
> my ($results) = Search( $term, $order_by, [ 10 ] );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:08:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 14:08:21 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-ddlfzv0Ui6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:08:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 14:08:23 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-NRpl2IJ1FZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36620|0                           |1
        is obsolete|                            |

--- Comment #17 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37010
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37010&action=edit
Add a new report : Orders by budget

This patch adds the "Orders by budget" report to the reports page.

This report can generate the list of all orders on a specific budget. The "All
budgets" and "All active budgets" options are also available to have different
views of all your orders.

A "[i]" is also added before the names of inactive budgets in the budget
selection box.

How to test:
Go to Home > Reports > Orders by budget
Select one or all budgets
Output to Scrren or CSV file
Set a budget to inactive
Verify that this budget is marked wit [i] in drop down list (Filters)

Sponsored-by: ccsr

http://bugs.koha-community.org/show_bug.cgi?id=11371

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:10:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 14:10:13 +0000
Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget
In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11371-70-RX2kAtauLW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36707|0                           |1
        is obsolete|                            |

--- Comment #18 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37011
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37011&action=edit
QA fix

http://bugs.koha-community.org/show_bug.cgi?id=11371

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:14:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 14:14:23 +0000
Subject: [Koha-bugs] [Bug 13874] New: rotating collections and calendar are
	circ tools
Message-ID: <bug-13874-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13874

            Bug ID: 13874
           Summary: rotating collections and calendar are circ tools
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

I think that rotating and collections and calendar belong under Patrons &
Circulation on the Tools page: /cgi-bin/koha/tools/tools-home.pl

This is trivial, just something that I usually say in training that I'll jump
in to this other column to show you another circulation related tool.  Anyone
have any preference/feedback?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 15:51:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 14:51:53 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-dAuW0n1Ze5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #116 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Moved to status to In Disussion to hold back on testing - am reworking the cron
job logic to ensure it deals with some fields being passed in some suppliers
invoices and aware of some changes in Acq - also needs a rebase against current
master. Will revise patch in a couple of days but worth holding back tests
until then

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:35:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:35:00 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-ZxwGcf8x8l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36346|0                           |1
        is obsolete|                            |

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37012
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37012&action=edit
Bug 13733 - Give librarians the ability to add messages to an item

Some librarians would like the ability to leave messages attached to an
item ( outside the scope of itemnotes and itemnotes_nonpublic ). This
feature would give the librarians the ability to add and remove messages
of arbitrary types defined in an authorised value list.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Create some ITEM_MESSAGE authorised values
4) View an item's details
5) Try adding and deleting messages on an item

Signed-off-by: F Pichenot <fpichenot at ville-roubaix.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:37:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:37:45 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-0PxmqREgIx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to M. de Rooy from comment #2)
> If I save a column (information) on the admin page (when hiding it), the
> admin page does not show that again. The late orders either.
> Seems to be a bug of what has been pushed already.
> Since I cannot fail QA on master, I do it here :)

Caused by the underscore '_' in the table name, I will open a new bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:39:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:39:11 +0000
Subject: [Koha-bugs] [Bug 13875] New: Columns configuration - table name
 cannot contain underscore
Message-ID: <bug-13875-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13875

            Bug ID: 13875
           Summary: Columns configuration - table name cannot contain
                    underscore
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

This limitation is useless, the underscore is used to separate the page, the
table and the column.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:41:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:41:41 +0000
Subject: [Koha-bugs] [Bug 13875] Columns configuration - table name cannot
 contain underscore
In-Reply-To: <bug-13875-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13875-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13875-70-O7blavEK1s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13875

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:41:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:41:44 +0000
Subject: [Koha-bugs] [Bug 13875] Columns configuration - table name cannot
 contain underscore
In-Reply-To: <bug-13875-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13875-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13875-70-XO9gg9IpEd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13875

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37013
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37013&action=edit
Bug 13875: Columns configuration - Allow underscore in table name

This is a bug fix for bug the columns configuration feature, and
specialy for bug 13864.

Test plan:
Apply patches on bug 13864 and save columns for the late orders (in the
columns configuration admin page).
Confirm that they are correctly saved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:42:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:42:16 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-imTb1VDuja@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
         Depends on|                            |13875

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Bugfix submitted on bug 13875.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:42:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:42:16 +0000
Subject: [Koha-bugs] [Bug 13875] Columns configuration - table name cannot
 contain underscore
In-Reply-To: <bug-13875-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13875-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13875-70-tXoAipP58L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13875

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13864

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:52:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:52:59 +0000
Subject: [Koha-bugs] [Bug 13876] New: Permission issues on updating via
 installer - dev installations
Message-ID: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

            Bug ID: 13876
           Summary: Permission issues on updating via installer - dev
                    installations
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

On dev installations, bug 13793 introduced a regression.
If the $logdir directory is not writable, the installer script explodes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:53:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:53:45 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-aaAje6S9hv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13876

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
See bug 13876 for a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:53:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:53:45 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-RVxH5X0n8I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13793

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:57:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:57:57 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-uDa6aEwGBK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 16:58:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 15:58:34 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-OIvuJDwFG6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37014
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37014&action=edit
Bug 13876: Fallback to /tmp if logdir is not writable

If the logdir directory is not writable by the koha user, the installer
should not explode.
This patch uses /tmp as a fallback.
That means that the history won't be kept.

Test plan:
0/ Generate an update (modify updatedatabase.pl and kohaversion)
1/ Make sure the permission are not correct on $logdir
2/ Go on the interface and execute the update entry.
3/ Confirm that the log has been created in /tmp

Retry with correct permissions and confirm the log will be created in
$logdir.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:09:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:09:02 +0000
Subject: [Koha-bugs] [Bug 3849] Acq Permissions unclear
In-Reply-To: <bug-3849-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3849-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3849-70-NAc5rc25bz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I would say group_manage is for basket groups, order_receive for receiving
orders and order_manage for "managing" orders :)
By managing I suppose it's any actions != receive.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:11:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:11:31 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-sc8YTxOz1a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36174|0                           |1
        is obsolete|                            |
  Attachment #36175|0                           |1
        is obsolete|                            |

--- Comment #14 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37015
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37015&action=edit
Bug 12739 - SendAlerts function does not take care of "html" format or UTF-8 Pt
1

The UTF-8 charset in the content type is written as "utf8" instead of "utf-8"
in SendAlerts(), which causes UTF-8 characters to display incorrectly.

_TEST PLAN_

Before Applying:

1) Edit ACCTDETAILS
2) Add some UTF-8 characters
I recommend using the following website
http://www.ltg.ed.ac.uk/~richard/unicode-sample.html

In my tests, I added the samples from Hebrew, Arabic, Basic Latin,
Latin-1 Supplement, Latin Extended-A, and Latin Extended-B.

3) Set the system preference "AutoEmailOpacUser" to "Send"
4) Create a new user account with your email address

5) Note that the email in your inbox doesn't display the Unicode
characters correctly

Apply the patch

6) Create a new user account with your email address
7) Note that the email in your inbox _does_ display the
Unicode characters correctly.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:11:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:11:29 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-ltT3KAHm6j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:11:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:11:37 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-IGSoMfqfvh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

--- Comment #15 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37016
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37016&action=edit
Bug 12739 - SendAlerts function does not take care of "html" format or UTF-8
Pt. 2

The emails sent via SendAlerts don't take into account HTML format.

_TEST PLAN_

Before applying:

1) Change system preference "AutoEmailOpacUser" to "Send"
2) Change "ACCTDETAILS" notice to HTML and add HTML to it
3) Create a new user with your email address
4) Note how the email displays the HTML tags as plain text

Apply patch

5) Create a new user with your email address
6) Note how the email displays the email as an HTML email

For thoroughness:

7) Change "ACCTDETAILS" notice to non-HTML
8) Create a new user with your email address
9) Note how the email displays the HTML as plain text

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:16:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:16:51 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-ZHg7Yb68p2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Passed QA

--- Comment #16 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #12)
> There is something here I am not so happy with - the test plan tells you
> test one out of 4 notices that are touched by this patch set:
> - notifications about new serial issues
> - claims in serials
> - claims in acq
> 
> I'd love if those could be tested as well. Could a tester take a look at
> these as well please?

I have spent some time on getting that above the water (Dutch expression only?)

With a small test script I managed to generate all four notices in plain text
and html. These two patches are fine.
With the sign-off from Paola and the fairly trivial changes, I take the liberty
to pass QA on them too.
But I definitely agree with Katrin and David that the code around these changes
needs attention :)
I will put some additional comments below.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:26:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:26:13 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-EvS0aO4Fe6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

--- Comment #17 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
What I found while testing is:

[1] There is no claimissues notice in the system. (The claimacquisition is
created in the installer, the other one is not there.) Bad.
[2] The fact that $type is passed to GetPreparedLetter as module name looks
strange. 
[3] The second parameter of SendAlerts is externalid. In some cases this should
be an id, in other cases an array reference. Does not look good.
[4] For claimacquisition and claimissues, the From address is
userenv->{emailaddress}. This is uncommon.
[5] In the same part of the code, two fetch rows are behind each other without
any testing. If there are no records found, this will generate an error.

If I would look a little bit longer, I would find even more :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:38:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:38:36 +0000
Subject: [Koha-bugs] [Bug 11889] Disown a list
In-Reply-To: <bug-11889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11889-70-qODLALfGWc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

--- Comment #4 from kholt at roseville.ca.us ---
It would be great to be able to keep public lists.  We had this problem when
the staff person who maintained our Newbery Awards list retired and her staff
account was deleted.  A system administrator should be able to transfer
ownership of a list so that it can continue to be added to.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:40:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:40:00 +0000
Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs
In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13734-70-y8UyckGSFu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

--- Comment #8 from Winona Salesky <wsalesky at gmail.com> ---
This patch adds the 33x fields to the full display in staff and OPAC views. 
Display has id='content_type' so it can be easily suppressed. 

Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 335, 337 and/or 338
4) Perform an opac search that would show the record in the search results
5) Note the fields displays ( here you could go into detail about how and where
the field should show )
6) Repeat steps 4 and 5 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:45:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:45:38 +0000
Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in
	XSLT
In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13387-70-HTpzJg5iNn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387

--- Comment #5 from Winona Salesky <wsalesky at gmail.com> ---
Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 130, 240 or 730
4) Perform an opac search that would show the record in the search results
5) Note the fields displays subfields a,b,c,k,n,p,s with a vertical bar to
separate multiple titles. Vertical bar is wrapped in span class="separator" for
easy suppression/customization of separator. 
6) Repeat steps 4 and 5 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:46:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:46:38 +0000
Subject: [Koha-bugs] [Bug 13434] 586 XSLT improvements
In-Reply-To: <bug-13434-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13434-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13434-70-amd7g5INCY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434

--- Comment #2 from Winona Salesky <wsalesky at gmail.com> ---
Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 586
4) Perform an opac search that would show the record in the search results
5) Note the fields uses a vertical bar to separate multiple titles. Vertical
bar is wrapped in span class="separator" for easy suppression/customization of
separator. 
6) Repeat steps 4 and 5 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:49:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:49:44 +0000
Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT
In-Reply-To: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13433-70-MtAs8LP6JR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433

--- Comment #5 from Winona Salesky <wsalesky at gmail.com> ---
Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 655
4) Perform an opac search that would show the record in the search results
5) Note this patch adds field 655 to display. Displays subfields a,v,x,y,z.
uses a vertical bar to separate multiple titles. Vertical bar is wrapped in
span class="separator" for easy suppression/customization of separator.
6) Repeat steps 4 and 5 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:50:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:50:54 +0000
Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT
In-Reply-To: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13386-70-armex1B8Lm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386

--- Comment #2 from Winona Salesky <wsalesky at gmail.com> ---
Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 246
4) Perform an opac search that would show the record in the search results
5) Note the fields uses a vertical bar to separate multiple titles. Vertical
bar is wrapped in span class="separator" for easy suppression/customization of
separator. Change has been made to results view and detail view.
6) Repeat steps 4 and 5 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:53:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:53:31 +0000
Subject: [Koha-bugs] [Bug 13385] RDA: 508 display in XSLT
In-Reply-To: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13385-70-G7AEIIOsZ8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385

--- Comment #2 from Winona Salesky <wsalesky at gmail.com> ---
Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 508
4) Perform an opac search that would show the record in the search results. 
5) Click title to review record. 
6) Note the fields adds display for 508 subfield a.
7) Repeat steps 4 - 6 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:00:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 17:00:01 +0000
Subject: [Koha-bugs] [Bug 12137] Extend CalendarFirstDayOfWeek to be any day
In-Reply-To: <bug-12137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12137-70-1JqLY54Wdr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33771|0                           |1
        is obsolete|                            |

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37017
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37017&action=edit
Bug 12137 - Extend CalendarFirstDayOfWeek to be any day

Mubassir Ahsan asked on the Koha mailing list:
Is there any option to set Saturday as the first day of
the week? Please help me.

CalendarFirstDayOfWeek is currently either Sunday|Monday.

By converting it to 0|1|2|3|4|5|6
(Sunday, Monday, ..., Saturday), we can allow any day of the
week to be the first day of the week in the date picker.

TEST PLAN
---------
1) Backup DB
2) In mysql:
   > DELETE FROM systempreferences;
   > SOURCE .../installer/data/mysql/sysprefs.sql
   > SELECT variable,value FROM systempreferences;
   -- It should say 'CalendarFirstDayOfWeek' and '0'
      May say '1' if you are using Norwegian.
3) Restore your DB
4) .../installer/data/mysql/updatedatabase.pl
   -- If your previous value for 'CalendarFirstDayOfWeek' was
      'Sunday', it should be '0'. For 'Monday', it should be '1'.
5) Test an installation with 'de-DE' as the language.
   -- The default value should be '1'.
6) Test an installation with 'nb-NO' as the language.
   -- The default value should be '1'.
7) In the staff client, confirm that any day of the week is
   available in the I18N/L10N system preferences for the
   CalendarFirstDayOfWeek dropdown.
   -- I'm aware they aren't in order, but I'm after
      functionality, not finesse.
8) In another tab, go to a staff place that has a datepicker.
   For example, Home -> Tools -> Inventory/stocktaking
9) For each possible value in the CalendarFirstDayOfWeek,
   go to the other tab, refresh the page after updating the
   system preference, and click the datepicker icon.
   -- The date picker should then start on the selected
      day of the week.
10) Log into OPAC
    -- This may require setting: opacuserlogin to 'Allow'.
11) Click the personal details tab on the left.
12) There is a date picker for the date of birth.
    -- The date picker should then start on the selected
       day of the week.
13) Run koha QA test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 17:59:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 16:59:59 +0000
Subject: [Koha-bugs] [Bug 12137] Extend CalendarFirstDayOfWeek to be any day
In-Reply-To: <bug-12137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12137-70-VcAVMwomt6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12137

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:11:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 17:11:16 +0000
Subject: [Koha-bugs] [Bug 13748] Acquisition wizard: some strings not
	translatable
In-Reply-To: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13748-70-Qx100P742D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:11:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 17:11:41 +0000
Subject: [Koha-bugs] [Bug 13861] \n in strings don't translate well
In-Reply-To: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13861-70-DnyPpdMHcz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13861

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:12:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 17:12:17 +0000
Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in
 Koha::Schema::Result::Biblio
In-Reply-To: <bug-13713-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13713-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13713-70-5IjaAPQ5pK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Jonathan and Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:12:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 17:12:46 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-adj2SebpB2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #33 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Good job Nicole!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:13:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 17:13:12 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-ajOXkjzPPU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:17:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 17:17:11 +0000
Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code
	limit is used
In-Reply-To: <bug-13442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13442-70-BV6sPBGpqV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Does this target master? the 3.18.x branch? UTf-8 handling differs, a lot on
each.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:56:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 17:56:00 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-ym9IfbrL6v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Maybe use File::Temp instead of hardcoding /tmp ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:58:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 17:58:13 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-dix8e0Nd6b@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
BTW Note that if I would have permissions to write in the original log dir, but
SELinux would not allow it, your test here would not work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 18:58:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 17:58:39 +0000
Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code
	limit is used
In-Reply-To: <bug-13442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13442-70-EAjLBEmoD9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tom?s Cohen Arazi from comment #6)
> Does this target master? the 3.18.x branch? UTf-8 handling differs, a lot on
> each.

Sorry, wrong but number :-D

Kyle, could you please address Jonathan's concern?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:00:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:00:07 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-fnvgCBoR93@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

--- Comment #18 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
BTW Running the Letters.t test also includes a *test* of claimacquisition.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:02:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:02:01 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-T1uzDWARNc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:03:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:03:38 +0000
Subject: [Koha-bugs] [Bug 13768] in quotes.tt line 14 the use of \" break
	the translation
In-Reply-To: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13768-70-GreGg3IZU8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Christophe!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:04:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:04:04 +0000
Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32
In-Reply-To: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13586-70-mCnCRJnCBV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Rochele!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:04:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:04:30 +0000
Subject: [Koha-bugs] [Bug 13826] OPAC: Display RSS icon on list of recent
	comments
In-Reply-To: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13826-70-4yPLm1pjjX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:05:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:05:00 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
	guarantor search
In-Reply-To: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13021-70-LvAOGtWe0H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #30 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Good job Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:05:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:05:25 +0000
Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with
 diacritics, utf-8 or ttf fonts
In-Reply-To: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13709-70-czotSK7f7I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Dobrica!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:08:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:08:56 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-OhjXB9L4JS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #19 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
David, why aren't you using encode('UTF-8',$string) as stated in
http://wiki.koha-community.org/wiki/Handling_UTF8_in_development

Please take a look at my followup and check it is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:21:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:21:56 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-186Pifk4JR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

--- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 37018
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37018&action=edit
Bug 12739: (QA followup) use 'UTF-8' instead of 'utf8'

This patch makes Encode::encode be passed the 'UTF-8' encoding
instead of the discouraged 'utf8'.

Please read:
http://wiki.koha-community.org/wiki/Handling_UTF8_in_development

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:25:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:25:42 +0000
Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all
 images on the OPAC
In-Reply-To: <bug-7706-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7706-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7706-70-UulHB4le7i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #14 from Nicole C. Engard <nengard at gmail.com> ---
Changing to needs sign off since we have patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:31:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:31:45 +0000
Subject: [Koha-bugs] [Bug 13877] New: seasonal predictions showing wrong in
	test
Message-ID: <bug-13877-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877

            Bug ID: 13877
           Summary: seasonal predictions showing wrong in test
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Created attachment 37019
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37019&action=edit
test wrong

When you test a seasonal serial prediction it shows wrong, but when you receive
it it's all right.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 19:32:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 18:32:04 +0000
Subject: [Koha-bugs] [Bug 13877] seasonal predictions showing wrong in test
In-Reply-To: <bug-13877-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13877-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13877-70-llOkEicG4v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37020
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37020&action=edit
received shows right

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 20:00:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 19:00:40 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-Ikqctp440a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

--- Comment #21 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looks good to me, Tomas. Thanks.

Make another point also to mention to the above list:

[6] In two cases Koha::Email is used with parameter contenttype, in the other
case a hash is formed directly with parameter Content-Type. Consistent?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 19 20:41:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 19 Mar 2015 19:41:22 +0000
Subject: [Koha-bugs] [Bug 5672] Add RSS feeds to catalog search history
In-Reply-To: <bug-5672-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5672-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5672-70-33nQF2Cepk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672

kholt at roseville.ca.us changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kholt at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 04:47:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 03:47:16 +0000
Subject: [Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
In-Reply-To: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13878-70-flFby0uPk1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 04:46:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 03:46:43 +0000
Subject: [Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
In-Reply-To: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13878-70-FanfBwVmFx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

--- Comment #1 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 37021
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37021&action=edit
Bug 13878 - Typo in help file (aqbudgets.tt)

Bug 13878 - Typo in help file (aqbudgets.tt)

Test plan:
1) Go to url
'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:15' and check
the typo "wan" or go to Administration > Acquisition parameters > Funds > Help
2) Apply the patch
3) Repeat step 1 and check if the typo is fixed.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 09:14:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 08:14:49 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-EDfMpkDVnX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37014|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37022
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37022&action=edit
Bug 13876: Fallback to /tmp if logdir is not writable

If the logdir directory is not writable by the koha user, the installer
should not explode.
This patch uses a temporary directory as a fallback.
That means that the history won't be kept.

Test plan:
0/ Generate an update (modify updatedatabase.pl and kohaversion)
1/ Make sure the permission are not correct on $logdir
2/ Go on the interface and execute the update entry.
3/ Confirm that the log has been created in a temporaty directory.

Retry with correct permissions and confirm the log will be created in
$logdir.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 09:15:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 08:15:48 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-strOjDMUgD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to M. de Rooy from comment #2)
> Maybe use File::Temp instead of hardcoding /tmp ?

Done.

(In reply to M. de Rooy from comment #3)
> BTW Note that if I would have permissions to write in the original log dir,
> but SELinux would not allow it, your test here would not work.

I don't know a lot about SELinux, how can you know if a directory is writable?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 03:34:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 02:34:33 +0000
Subject: [Koha-bugs] [Bug 13878] New: Typo in help file (aqbudgets.tt)
Message-ID: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

            Bug ID: 13878
           Summary: Typo in help file (aqbudgets.tt)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Documentation
          Assignee: nengard at gmail.com
          Reporter: hector.hecaxmmx at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Typo in file: intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:15

It reads: In the form that appears you wan to enter the basics about your fund.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 03:37:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 02:37:10 +0000
Subject: [Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
In-Reply-To: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13878-70-t0PAnKjOSU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nengard at gmail.com           |hector.hecaxmmx at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 03:09:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 02:09:06 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-zJmM6YAjor@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

--- Comment #4 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
(In reply to Nicole C. Engard from comment #3)
> Thanks for finding the typo, but be aware that the help files haven't
> followed the capitalization rules in the past.  
> 
> Nicole

Hi Nicole

I will change the patch about the capitalization and let it as the original
one, what would you recommend me to do?

By the way there are another typo in file:
intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:15

It reads: In the form that appears you wan to enter the basics about your fund.

I will file a new bug for the typo and link it with this as See also.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 03:35:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 02:35:16 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-XYfQIpODzn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13878

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 01:39:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 00:39:10 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-EfVoFMb9ma@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

--- Comment #22 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tom?s Cohen Arazi from comment #19)
> David, why aren't you using encode('UTF-8',$string) as stated in
> http://wiki.koha-community.org/wiki/Handling_UTF8_in_development
> 
> Please take a look at my followup and check it is ok.

I didn't eve know that was a thing! Neat! It might be an idea to add the thing
about using "utf-8" in emails... or "UTF-8" if that works as well for the
content type.

At a glance, your patch looks good to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 03:35:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 02:35:16 +0000
Subject: [Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
In-Reply-To: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13878-70-8Ymgzo39RD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13872

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 09:59:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 08:59:46 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-IEEutRZ7Hd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #36 from Marc V?ron <veron at veron.ch> ---
Created attachment 37023
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37023&action=edit
[Signed-off] Bug 13601: The fallback regex should contain the time part

On displaying a sql date, if the dateformat is not set to sql, the
output should contain the date.
In the previous version, the fallback regex (used for sql format) did not
included the time part (hh:mm:ss).

Checked out an item with due date an ddue time. Time displays as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 10:00:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 09:00:19 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-3jEl7Z5riC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36939|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 10:49:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 09:49:30 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-KWuDgcKJxm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 37024
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37024&action=edit
[Signed-off] Bug 13822 - Patron autocomplete search is severly limited

The script that returns data for the patron autocomplete does not use
C4::Members::Search. Instead it uses bespoke code that does not behave like the
traditional search and is very limited in how it can search.

If, for example, I search for "Kyle Hall" in the standard search, I would get
"Kyle Hall" back as a result. For the autocomplete search, I will not.

This script should use C4::Members::Search to provide better searching and to
keep the code base DRY.

Test Plan:
1) Enable the system preference CircAutocompl
2) Create a user with the first name "Test" and the surname "User"
3) Perform a checkout autocomplete search for "Test User"
4) Note you do not get the user as a result
5) Apply this patch
6) Try different combinations of "Test" and "User" such as
   Test User
   User Test
   U Test
   Test U
   etc.
7) Note these searches now work

Folllowed test plan, works as expected
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 10:49:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 09:49:57 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-xu2l2ckDmm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37009|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 10:50:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 09:50:30 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-VIHVciTI0D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:20:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:20:22 +0000
Subject: [Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
In-Reply-To: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13878-70-UY91sFtbvL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 37025
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37025&action=edit
[Signed-off] Bug 13878 - Typo in help file (aqbudgets.tt)

Test plan:
1) Go to url
'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:15' and check
the typo "wan" or go to Administration > Acquisition parameters > Funds > Help
2) Apply the patch
3) Repeat step 1 and check if the typo is fixed.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx at gmail.com>

Typo is fixed.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:20:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:20:48 +0000
Subject: [Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
In-Reply-To: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13878-70-VMjhYtJZjc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37021|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:24:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:24:54 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-ln0zQ7MNGx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 37026
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37026&action=edit
[Signed off] Bug 13872 - Typographical error on columns_settings.tt

Test plan:
1) Go to url
'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/columns_settings.tt' line 9
and check the typo "columsn" and change for columns.
2) See also changes for Column settings to Columns settings at lines 3 and 15
3) Apply the patch
4) Repeat step 1 and chek if the typo is fixed or go to Administration >
Additional parameters > Configure columns and go to Help page.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx at gmail.com>

Typo is fixed
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:25:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:25:16 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-6WqAxLxfUr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #36997|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:25:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:25:26 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-Iw6BBsvbT0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:25:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:25:52 +0000
Subject: [Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
In-Reply-To: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13878-70-d5BZaQVmLz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:26:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:26:16 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-tFeNEICMSB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:31:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:31:12 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-wvAtpOKxzH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
No track of SQLHelper in C4::Members anymore :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:31:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:31:13 +0000
Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed
In-Reply-To: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11385-70-1J5aZQgkAu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385
Bug 11385 depends on bug 12633, which changed state.

Bug 12633 Summary: SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:41:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:41:23 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-bICTJElPoS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Woohoo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:44:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:44:11 +0000
Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed
In-Reply-To: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11385-70-s9yrQKNc7n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385
Bug 11385 depends on bug 12633, which changed state.

Bug 12633 Summary: SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:44:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:44:10 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-K0gL7xICnM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:44:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:44:49 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-6WSZEfWM1i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Sorry, but there is one left in C4::Members::Search :-/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 11:45:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 10:45:03 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-Xa85IxLvC8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:18:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:18:25 +0000
Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY
 of message_queue
In-Reply-To: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7793-70-yYt1z7gzXH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
I got this error when I tried to update my db:
DBD::mysql::db do failed: ALTER TABLE causes auto_increment resequencing,
resulting in duplicate entry '9' for key 'PRIMARY' at
installer/data/mysql/updatedatabase.pl line 6750.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:19:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:19:18 +0000
Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY
 of message_queue
In-Reply-To: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7793-70-X2V6jDCgEo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:19:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:19:20 +0000
Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY
 of message_queue
In-Reply-To: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7793-70-nlDM72Y83w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36987|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37027
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37027&action=edit
[SIGNED-OFF] Bug 7793 - redefine the field message_id as PRIMARY KEY of
message_queue

Making message_queue work nicely with DBIx.

DROP the existing KEY and replace with an PRIMARY KEY.
If somebody has managed to get duplicate message_ids in his/her
message_queue-table, this patch takes care of them as well, but givin
all duplicate message_id's a new id.

TEST INSTRUCTIONS: in the patch.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:19:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:19:29 +0000
Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY
 of message_queue
In-Reply-To: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7793-70-FhD999OWRn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37028
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37028&action=edit
Bug 7793 - Simplify db update

Since message_id is not linked to anything else in the database, we
can ensure the message_id's are unique by simply dropping the column
and recreating it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:58:09 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-Y5ac5blIAm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:58:12 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-U8ZpJX1UNV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36394|0                           |1
        is obsolete|                            |
  Attachment #36395|0                           |1
        is obsolete|                            |
  Attachment #36396|0                           |1
        is obsolete|                            |
  Attachment #36397|0                           |1
        is obsolete|                            |
  Attachment #36398|0                           |1
        is obsolete|                            |
  Attachment #36399|0                           |1
        is obsolete|                            |
  Attachment #36400|0                           |1
        is obsolete|                            |
  Attachment #36401|0                           |1
        is obsolete|                            |

--- Comment #97 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37029
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37029&action=edit
[PASSED QA] Bug 8007: Discharge - DB changes

This patch adds:
- syspref useDischarge
- the new table discharges
- the discharge notice

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:58:31 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-cMcgai0IxH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37029|0                           |1
        is obsolete|                            |

--- Comment #98 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37030
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37030&action=edit
[PASSED QA] Bug 8007: Discharge - DB changes

This patch adds:
- syspref useDischarge
- the new table discharges
- the discharge notice

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:58:38 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-ga1iTtJDzl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #99 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37031
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37031&action=edit
[PASSED QA] Bug 8007: Discharge - DBIx changes

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:58:41 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-regPIy9v1h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #100 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37032
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37032&action=edit
[PASSED QA] Bug 8007: Discharge - Glue

This patch adds:
- links to the new pages.
- syspref description
- links on the main page (intranet)
- the DISCHARGE type for debarment

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:58:44 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-G5lwQ93W5F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #101 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37033
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37033&action=edit
[PASSED QA] Bug 8007: Discharge management

This patch is the main patch. It adds new package and files for the new
pages (opac-discharge, members/discharge and members/discharges).

At the intranet, it is now possible to generate a discharge for a patron.
At the opac, a patron can request a discharge and a discharge if it has
been validated by a librarian.

Requirements:
    The perl module PDF::FromHTML

New sysprefs:
 - useDischarge: Allows librarians to discharge borrowers and borrowers
   to request a discharge

New letter with a letter_code DISCHARGE.

Test plan:
- Switch on the syspref useDischarge.
- Verify a new tab appears in the patron page (intranet and opac).
- Verify the discharge cannot be generated if the patron has issues.
- Verify the patron can request a discharge from it's opac area.
- The request appears on the main page (intranet).
- Generate the discharge from the intranet.
- Try to download it (from the opac and the intranet).

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:58:48 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-C4AeYMiDMZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #102 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37034
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37034&action=edit
[PASSED QA] Bug 8007: Discharge - Add unit tests

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:58:51 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-xdB7bUYy5R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #103 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37035
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37035&action=edit
[PASSED QA] Bug 8007 : Discharge - Adding Perl dependencie

HTML::HTMLDoc is required in order to generate the discharges in PDF format.

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:58:54 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-tR9t1YdRml@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #104 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37036
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37036&action=edit
[PASSED QA] Bug 8007: Replace HTML::HTMLDoc with PDF::FromHTML

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:58:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:58:57 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-XyWNp0Lynw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #105 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37037
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37037&action=edit
[PASSED QA] Bug 8007: Compatibility with bug 11944

This patch should be applied to work with bug 11944.
If you don't have 11944 yet, just don't apply this patch.

Note that the line
  binmode(STDOUT);
in pl files is mandatory.

It comes from bug 11944 that adds the line
  binmode( STDOUT, ":utf8" );
in C4::Templates::gettemplate.

Signed-off-by: Lucie <lucie.rousseaux at dracenie.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 13:59:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 12:59:56 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-es9BaOKLS5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:11:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:11:40 +0000
Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee!
In-Reply-To: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12820-70-zZn0vDEYJ9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:11:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:11:42 +0000
Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee!
In-Reply-To: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12820-70-zEgy8bQwzs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36155|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37038
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37038&action=edit
[PASSED QA] Bug 12820: Handle rental fees in Sip issue and renew

Implement correct handling of fees associated with checking out
an item.
This is associated with fee acknowledged field (BO)

To quote from the Sip2 document
" If this field is N in a Checkout message and there is a fee
associated with checking out the item, the ACS should tell the
SC in the Checkout Response that there is a fee, and refuse to
check out the item. If the SC and the patron then interact and the
patron agrees to pay the fee, this field will be set to Y on a second
Checkout message, indicating to the ACS that the patron has acknowledged
the fee and checkout of the item should not be refused just
because there is a fee associated with the item"

So there are two Checkout requests the first with BO not set to Y is
rejected but the fee amount is returned. The Second Checkout with BO set
to Y should succeed.

Added a debug log message indicating why we block a checkout
when we dont otherwise indicate

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:11:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:11:49 +0000
Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee!
In-Reply-To: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12820-70-eYEgUghcpS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37039
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37039&action=edit
Bug 12820 [QA Followup] - Tab and whitespace cleanup

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:11:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:11:58 +0000
Subject: [Koha-bugs] [Bug 13879] New: DataTables server-side processing for
 patrons - sort is broken
Message-ID: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

            Bug ID: 13879
           Summary: DataTables server-side processing for patrons - sort
                    is broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Bug 13021 introduced a regression for guarantor search and patron search for
orders, the sort is broken.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:12:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:12:35 +0000
Subject: [Koha-bugs] [Bug 13879] DataTables server-side processing for
 patrons - sort is broken
In-Reply-To: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13879-70-GmHxKxe6Wg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13021

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:12:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:12:35 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
	guarantor search
In-Reply-To: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13021-70-m2Mnh0tzaR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13879

--- Comment #31 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Regression found, will be fixed soon on bug 13879.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:17:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:17:24 +0000
Subject: [Koha-bugs] [Bug 13879] DataTables server-side processing for
 patrons - sort is broken
In-Reply-To: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13879-70-9gkwzBIj1h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:17:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:17:27 +0000
Subject: [Koha-bugs] [Bug 13879] DataTables server-side processing for
 patrons - sort is broken
In-Reply-To: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13879-70-LY8gLD8bZO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37040
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37040&action=edit
Bug 13879: Fix sort on patron search (guarantor and linked to orders)

This patch fixes a regression introduced by bug 13021.

Test plan:
1/ Go on a child detail page > edit
2/ Click on "Set a patron" as a guarantor
3/ Launch a search a confirm that you are able to sort on card, name and
date of birth.
Note that the Address column is not sortable (it's a limitation, could
be fixed later).
4/ Go on the acquisition module, create an order.
5/ Click on the "Add user" button.
6/ Launch a search a confirm that you are able to sort on card, name and
category

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:42:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:42:42 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-NsQcYysH6V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 37041
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37041&action=edit
[Signed-off] Bug 13868: Correct formatting of date on routing list slip

The date planned printed on the issue slip is not formatted
according to the dateformat system preference setting.

To test:
- enable RoutingSerials
- create a subscription
- create a routing list from the serial collection page
- use the 'print list' links next to the issues to print a routing list
- verify that the date there is not displayed according to the dateformat
  system preference without the patch, but is correct with the patch applied

Followed test plan, date appears according to the date format syspref.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:43:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:43:16 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-RZSlNkG758@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #36994|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:43:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:43:40 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-DknCW4fYbn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:47:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:47:30 +0000
Subject: [Koha-bugs] [Bug 13880] New: Allow svc/report to be passed sql
	parameters
Message-ID: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

            Bug ID: 13880
           Summary: Allow svc/report to be passed sql parameters
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The same feature added to the opac svc/report in bug 9915 should be added to
the staff side.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:47:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:47:50 +0000
Subject: [Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters
In-Reply-To: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13880-70-3luzaO1Oki@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:47:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:47:45 +0000
Subject: [Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters
In-Reply-To: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13880-70-mnOEDwAvjz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |Reports
                   |and plumbing                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:50:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:50:34 +0000
Subject: [Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters
In-Reply-To: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13880-70-nZyt0h4VcJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:50:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:50:36 +0000
Subject: [Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters
In-Reply-To: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13880-70-sqMifQXpqQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37042
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37042&action=edit
Bug 13880 - Allow svc/report to be passed sql parameters

The same feature added to the opac svc/report in bug 9915 should be
added to the staff side.

Test Plan:
1) Apply this patch
2) Create this report:
   SELECT * FROM biblio WHERE biblionumber = <<biblionumber>>
3) Note the id of the report
4) Go to the URL
/cgi-bin/koha/svc/report?id=YOUR_REPORT_ID&sql_params=SOME_VALID_BIBLIONUMBER
5) Note you recieve a json response

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:56:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:56:27 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-eFhJttwRoT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 37043
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37043&action=edit
[Signed-off] Bug 9120: Prevent form submission on adding tags - OPAC

At the OPAC, if the user adds tags pressing 'Enter', the page is
reloaded and the tags are not added.
To prevent that, this patch suggests to block the "press enter" event on
the inputs.

Test plan:
0/ Confirm the bad behavior, without this patch.
1/ Apply this patch and confirm nothing happen on pressing enter when
the focus is on the add tag input (At the opac, on the result view).

Patch works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:57:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:57:16 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-6iTn5L6u0V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:57:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:57:31 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-5pnwD8EyPe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36991|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 14:57:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 13:57:44 +0000
Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
In-Reply-To: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13531-70-MwzzOSUBFE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37044
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37044&action=edit
[PASSED QA] Bug 13531 - bulkmarcimport bombs if no match is found Changed the
die statment to a warn allowing the import to continue.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:18:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:18:46 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-8rCupQW4lJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
The patch prevents aumount with non-number characters.

Questions:

I can enter a negative number. Should that be possible? - It changes an invoice
to kind of credit.

Additionally, I can still enter non-number characters in "Create manual credit"
(and put negative numbers here as well, changing a credit to kind of invoice).

Should that be fixed here or with a separate Bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:19:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:19:14 +0000
Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
In-Reply-To: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13531-70-mF2DPMZYjo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:19:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:19:16 +0000
Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
In-Reply-To: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13531-70-KwujuhFIbQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35147|0                           |1
        is obsolete|                            |
  Attachment #35295|0                           |1
        is obsolete|                            |
  Attachment #36625|0                           |1
        is obsolete|                            |
  Attachment #37044|0                           |1
        is obsolete|                            |

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37045
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37045&action=edit
[PASSED QA] Bug 13531 - bulkmarcimport bombs if no match is found Changed the
die statment to a warn allowing the import to continue.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:19:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:19:23 +0000
Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
In-Reply-To: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13531-70-Ak76wjivob@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37046
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37046&action=edit
[PASSED QA] Bug 13531: QA follow up

A minor QA comment.

::: misc/migration_tools/bulkmarcimport.pl
@@ +271,5 @@
>          my ( $error, $results, $totalhits ) = C4::Search::SimpleSearch( $query, 0, 3, [$server] );
> +        # changed to warn so able to continue with one broken record
> +        if ( defined $error ) {
> +            warn "unable to search the database for duplicates : $error";
> +            next;

For consistency with the rest of the script, should this perhaps be:

next RECORD;

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:19:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:19:25 +0000
Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
In-Reply-To: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13531-70-KNn37j0zaH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37047
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37047&action=edit
[PASSED QA] Bug 13531 - Follow up

Add logging of errors.

Signed-off-by: Magnus Enger <magnus at enger.priv.no>
More errors are indeed showing up in the log.
(I took the liberty of changing the commit message a little bit.)

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:41:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:41:58 +0000
Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove
	public lists
In-Reply-To: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13417-70-BOchOq8xRl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #39 from Nicole C. Engard <nengard at gmail.com> ---
I'm seeing two new permissions - Lists and then the permission to delete under
that.  Does the lists permission do anything? Does it control who can use
lists? I'm looking for the manual.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:45:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:45:29 +0000
Subject: [Koha-bugs] [Bug 13881] New: Add desk management
Message-ID: <bug-13881-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

            Bug ID: 13881
           Summary: Add desk management
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nicolas.legrand at bulac.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

A Library may have multiple desks inside its public space. If desks are defined
in Koha, a librarion in public space should set her desk when opening her
session as she should set her library. When items are checked-in and trigger a
hold, the hold may be attachable to a desk and the patron may be advertised
where she can retreive her hold.

This may also be usefull when items come from closed stacked. Some may be kept
as hold behind the everyday items issue desk, some may be behind the rare books
section desks.

Such a module was developped by Progilone for the BULAC Koha 3.2, check:
<https://github.com/BULAC/koha/blob/bulac-dead_end-3.02.04/C4/Stack/Desk.pm>.
The BULAC is going to port it to current master, with a more Kohaish style and
comments. The circulation logic will be a bit different from those sources, as
the BULAC plans to use Holds for books coming from closed stacked and dumps its
overkill stack request module.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:46:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:46:28 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-ZBEgGL2o27@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
                 CC|                            |nicolas.legrand at bulac.fr

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:48:51 +0000
Subject: [Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron
 changes to a category with enrolment fee
In-Reply-To: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13697-70-gN6ih2OMol@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:48:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:48:53 +0000
Subject: [Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron
 changes to a category with enrolment fee
In-Reply-To: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13697-70-ySQjREc4oC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36234|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37048
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37048&action=edit
[PASSED QA] Bug 13697 : Syspref to not add a fee when a patron changes to a
category with enrolment fee

By default this syspref is "Do" to keep the previous behaviour.

Test plan :

1/ create 2 categories (A & B). B with enrolment fee
2/ create a patron in category A
3/ change the patron category from A to B
4/ check that the patron has an enrolment fee to pay

Apply the patch

1/ create a new patron in category A
2/ change the patron category from A to B.
3/ check that the patron has an enrolment fee to pay
4/ change the system preference 'FeeOnChangePatronCategory' to 'Don't';
5/ create a new patron in category A
6/ change the patron category from A to B
7/ check that the patron has no enrolment fee to pay

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:49:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:49:00 +0000
Subject: [Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron
 changes to a category with enrolment fee
In-Reply-To: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13697-70-5RhiiZQyjE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37049
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37049&action=edit
Bug 13697 [QA Followup] - Add Unit Test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:50:11 +0000
Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
In-Reply-To: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13869-70-AwpZKV0Iu1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 37050
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37050&action=edit
[Signed-off] Bug 13869: Wrong capitalization of 'Save Report' in guided reports

On the last step of saving a new guided report to the database,
the button is labelled 'Save Report', but should be 'Save report'.

To test:
- Create a new guided report from the reports page
- Check on the very last step, when saving the report to the
  database, the button is labelled 'Save Report'
- With the patch applied, this reads 'Save report' instead

http://bugs.koha-community.org/show_bug.cgi?id=13868

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:50:33 +0000
Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
In-Reply-To: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13869-70-gRd7Vnx2YU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #36996|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:50:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:50:55 +0000
Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
In-Reply-To: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13869-70-7mSlhpBaKu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 15:56:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 14:56:35 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-gcxL4cdeEU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Will sign off on this one with a follow-up. Please wait :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:10:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:10:41 +0000
Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove
	public lists
In-Reply-To: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13417-70-N2CSgfGm4Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

--- Comment #40 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Nicole C. Engard from comment #39)
> I'm seeing two new permissions - Lists and then the permission to delete
> under that.  Does the lists permission do anything? Does it control who can
> use lists? I'm looking for the manual.

Hi Nicole,
This patchset only introduced 1 'manage_shelves' permission.
If set, the librarian will be able to manage all shelves.
There is no specific permission for deletion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:13:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:13:51 +0000
Subject: [Koha-bugs] [Bug 3125] IE7-8: Selected columns list in Reports
 Dictionary is not showing column names.
In-Reply-To: <bug-3125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3125-70-GSBWPiIN5o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3125

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
(In reply to Jonathan Druart from comment #2)
> Is this one solved with newer versions of IE?

I compared IE 11 with FF 36.0, both work the same way, no problems found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:22:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:22:34 +0000
Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove
	public lists
In-Reply-To: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13417-70-6kDy4PFohy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

--- Comment #41 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37051
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37051&action=edit
permissions

I see two new permissions - and I see that one of the patches here is to rename
the delete permission. So my question is why are there 2 permission checkboxes?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:26:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:26:48 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-fLjmy2u9TG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:26:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:26:51 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-K3I09t3gJJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37022|0                           |1
        is obsolete|                            |

--- Comment #7 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37052
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37052&action=edit
Bug 13876: Fallback to /tmp if logdir is not writable

If the logdir directory is not writable by the koha user, the installer
should not explode.
This patch uses a temporary directory as a fallback.
That means that the history won't be kept.

Test plan:
0/ Generate an update (modify updatedatabase.pl and kohaversion)
1/ Make sure the permission are not correct on $logdir
2/ Go on the interface and execute the update entry.
3/ Confirm that the log has been created in a temporaty directory.

Retry with correct permissions and confirm the log will be created in
$logdir.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Adding a follow-up for completely resolving encountered issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:26:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:26:59 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-QSS4JdaYCd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #8 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37053
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37053&action=edit
Bug 13876: [QA Follow-up] Resolve updatedatabase logfile issues

This patch removes the test on write permissions of the logdir.
It uses File::Temp to generate a file in the logdir or otherwise in
a system tmp dir.
This resolves issues with both write permissions as well as SELinux
denials.
Note that after generating an empty file, we are appending to it in
the system statement.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:29:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:29:43 +0000
Subject: [Koha-bugs] [Bug 13882] New: Adding new unit tests in t/Borrower.t,
 testing all 'borrower' database fields
Message-ID: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

            Bug ID: 13882
           Summary: Adding new unit tests in t/Borrower.t, testing all
                    'borrower' database fields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: Test Suite
          Assignee: julian.fiol at biblibre.com
          Reporter: julian.fiol at biblibre.com
        QA Contact: gmcharlt at gmail.com

Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:31:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:31:55 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-9zZIsemrQf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #9 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Katrin or Jonathan: Please check. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:34:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:34:32 +0000
Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t,
 testing all 'borrower' database fields
In-Reply-To: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13882-70-Wt81fb8YCU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

--- Comment #1 from Julian FIOL <julian.fiol at biblibre.com> ---
Created attachment 37054
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37054&action=edit
Bug 13882 : Adding new unit tests in t/Borrower.t, testing all 'borrower'
database fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:35:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:35:39 +0000
Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t,
 testing all 'borrower' database fields
In-Reply-To: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13882-70-PuFe03QjbF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

Julian FIOL <julian.fiol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:37:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:37:03 +0000
Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove
	public lists
In-Reply-To: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13417-70-gfWdu9MmTk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

--- Comment #42 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Sorry yes, it's delete_public_lists (not manage).
And, there is 1 permission in the group of permissions "Lists".
It's the first permission of the "List" module, we can imagine other
permissions for this module.
Have a look at the userflags and permissions tables: 1 "flag" can have several
permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:55:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:55:22 +0000
Subject: [Koha-bugs] [Bug 7601] Preference for default language for field
 008 Range 35-37 (instead of hard coded "eng")
In-Reply-To: <bug-7601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7601-70-D44HEzOZbD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=9269

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 16:55:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 15:55:22 +0000
Subject: [Koha-bugs] [Bug 9269] Remove  DefaultLanguageField008 syspref
In-Reply-To: <bug-9269-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9269-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9269-70-9sYufScFhs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9269

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=7601
                 CC|                            |veron at veron.ch

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
See Bug 7601

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:06:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 16:06:30 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11625-70-ePKxu7TLwc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
It's been a month with no more feedback, resetting the status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:08:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 16:08:51 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11625-70-5rRWqUI0F1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:08:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 16:08:54 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11625-70-Zd2tbs3dTB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35460|0                           |1
        is obsolete|                            |
  Attachment #35461|0                           |1
        is obsolete|                            |
  Attachment #35462|0                           |1
        is obsolete|                            |
  Attachment #35463|0                           |1
        is obsolete|                            |

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37055
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37055&action=edit
Bug 11625 - Default to logged in library for circ rules and notices & slips

This patch makes the default circ rules and notices/slips to edit
the logged in branch, if one is set.

Test Plan:
1) Apply this patch
2) Log into staff side, and set your library
3) Browse to Administration/Circulation and fines rules
4) Note the rule set selected is for your library
5) Select "All libraries"
6) Note the rule set selected is for "All libraries"
7) Browse to Toos/Notices & slips
8) Note the notice set selected is for your library
9) Select "All libraries"
10) Not the rule set selected is for "All libraries"
11) Click "New Notice"
12) Note the Library field is set to "All libraries"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes QA script and tests.
Small ergonomic improvement, no regressions found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:09:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 16:09:07 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11625-70-eQORVpchNo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37058
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37058&action=edit
Bug 11625 [QA Followup 3] - Use system preferences to control behavior

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:09:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 16:09:02 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11625-70-OOPUmuS9am@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37056
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37056&action=edit
Bug 11625 [QA Followup] - Default to logged in library for circ rules and
notices & slips

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Fixes the case that someone logs in as database user and
changes circulation rules without explicitly selecting a
library first.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:09:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 16:09:05 +0000
Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules
 and notices & slips
In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11625-70-k9o8oRHvpp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37057
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37057&action=edit
Bug 11625 [QA Followup 2] - Don't default to branch specific rules if only one
branch exists

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:45:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 16:45:24 +0000
Subject: [Koha-bugs] [Bug 13879] DataTables server-side processing for
 patrons - sort is broken
In-Reply-To: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13879-70-m7VDQkVaFb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 37059
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37059&action=edit
[Signed-off] Bug 13879: Fix sort on patron search (guarantor and linked to
orders)

This patch fixes a regression introduced by bug 13021.

Test plan:
1/ Go on a child detail page > edit
2/ Click on "Set a patron" as a guarantor
3/ Launch a search a confirm that you are able to sort on card, name and
date of birth.
Note that the Address column is not sortable (it's a limitation, could
be fixed later).
4/ Go on the acquisition module, create an order.
5/ Click on the "Add user" button.
6/ Launch a search a confirm that you are able to sort on card, name and
category

Without patch, I could not sort on names. With patch, sorting works as
dexcribed in Test plan

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:45:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 16:45:49 +0000
Subject: [Koha-bugs] [Bug 13879] DataTables server-side processing for
 patrons - sort is broken
In-Reply-To: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13879-70-LUELyk9znY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 17:46:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 16:46:05 +0000
Subject: [Koha-bugs] [Bug 13879] DataTables server-side processing for
 patrons - sort is broken
In-Reply-To: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13879-70-1pr29ItfxN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37040|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:02:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:02:30 +0000
Subject: [Koha-bugs] [Bug 13743] Primary key for issues-table
In-Reply-To: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13743-70-n1xqSJDtH6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36102|0                           |1
        is obsolete|                            |

--- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 37060
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37060&action=edit
Bug 13743 - Primary key for issues-table

Each table must have a primary key.
This makes extending issues-related functionality much easier.

TEST PLAN:

1. Check-out Items for you.
2. Check-in Items from you.
3. Check-out using the SIP2-server.
4. Check-in using the SIP2-server.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:03:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:03:08 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-RkmGcpGyoH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Ok so...
The good news is that only 1 occurrence still exists in C4::Members::Search
The bad one is that it is called from 3 different places  (but I may have
missed some others...):
  admin/aqbudget_user_search.pl
  serials/member-search.pl
  patroncards/members-search.pl

I have a patch and will be able to submitted it on monday.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:10:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:10:36 +0000
Subject: [Koha-bugs] [Bug 8038] Enable network printing when UsePrintQueues
	is on
In-Reply-To: <bug-8038-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8038-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8038-70-s4xpz5Nm76@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8038

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:10:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:10:52 +0000
Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection
In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8034-70-ENl0wz0S19@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:25:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:25:32 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-TGbSeJ1EZ6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:25:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:25:35 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-7XI26mjwHG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36779|0                           |1
        is obsolete|                            |
  Attachment #36780|0                           |1
        is obsolete|                            |
  Attachment #36781|0                           |1
        is obsolete|                            |
  Attachment #36792|0                           |1
        is obsolete|                            |

--- Comment #94 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37061
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37061&action=edit
[PASSED QA] Bug 13068: updatedatabase improvement for developer process

with this patch, the updatedatabase now checks info the atomicupdate directory.
If there is some SQL here, it's executed.
Note that there is no version update, so if you run the updatedatabase script
twice, you'll get an sql error probably.

This patch will be very useful for sandbox testing process.

When the RM pushes a patch with something in i'atomicupdate', he will have to
copy it into updatedatabase.pl, give it a number, and remove the file in
db_update

Test plan:
 * apply the patch
 * create a files with a .sql extension in the atomicupdate directory
 * run updatedatabase.pl
 * look at your database, what was in the .sql file must have been run

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:25:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:25:43 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-AmC4hEieb8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #95 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37062
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37062&action=edit
[PASSED QA] Bug 13068: Follow-up for cleaning up atomicupdate folder

The folder atomicupdate can be cleaned up. It mainly contains old files that
are not used any more.
I found two files that are still referenced:
[1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl
    A readme file refers to it. The code in this file slightly differs
    from the TalkingTech db revision. It can probably be deleted too, but
    I will first check.
[2] oai_sets.sql
    This file should remain. It is used in dbrev 3.07.00.029.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:25:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:25:46 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-2hEY1a9tJ2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #96 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37063
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37063&action=edit
[PASSED QA] Bug 13068: (QA followup) Remove old files, use C4::Installer

 * moving oai-sets.sql from atomicupdate to updatedatabase itself
 * using Installer file loader to load & execute SQL file

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:25:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:25:49 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-ckWLTOcbpO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #97 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37064
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37064&action=edit
[PASSED QA] Bug 13068: (follow-up) Remove old files, use C4::Installer

 The do method does not accept more than 1 sql query.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:25:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:25:53 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-hlsUlo8rAm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #98 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37065
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37065&action=edit
Bug 13068 [QA Followup] - Fix reading of sql files list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:32:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:32:20 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-0Rr8bnflFj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #99 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37066
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37066&action=edit
Bug 13068 [QA Followup] - Remove use File::Slurp

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 18:40:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 17:40:09 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-CVDvM3N0BJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #100 from Kyle M Hall <kyle at bywatersolutions.com> ---
I wasn't able to get this feature to work without my QA followup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:01:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 18:01:53 +0000
Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
In-Reply-To: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13381-70-vL74m0TrJG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

--- Comment #23 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 37067
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37067&action=edit
Updates for #13381 This patch updates the display of the title and statement of
responsibility in the XSLT display in the staff and OPAC.

Display includes subfields a,b,c,h,k,n,p,s
Subfield c is wrapped in a span class=title_resp_stmt for easy suppression via
css.
Subfield h is wrapped in a span class=title_medium for easy suppression via
css.

To test:

* Search the opac
* Click the title
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:07:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 18:07:58 +0000
Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
In-Reply-To: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13381-70-ALryPsBfvN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

--- Comment #24 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 37068
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37068&action=edit
Updates display of 245 field

Updates for #13381
This patch updates the display of the title and statement of responsibility in
the
XSLT display in the staff and OPAC.

Display includes subfields a,b,c,h,k,n,p,s
Subfield c is wrapped in a span class=title_resp_stmt for easy suppression via
css.
Subfield h is wrapped in a span class=title_medium for easy suppression via
css.

To test:

* Search the opac
* Click the title
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:08:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 18:08:36 +0000
Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
In-Reply-To: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13381-70-55CG1L3spY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37068|0                           |1
        is obsolete|                            |

--- Comment #25 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 37069
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37069&action=edit
Updates display of 245 field

Updates for #13381
This patch updates the display of the title and statement of responsibility in
the
XSLT display in the staff and OPAC.

Display includes subfields a,b,c,h,k,n,p,s
Subfield c is wrapped in a span class=title_resp_stmt for easy suppression via
css.
Subfield h is wrapped in a span class=title_medium for easy suppression via
css.

To test:

* Search the opac
* Click the title
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:10:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 18:10:07 +0000
Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
In-Reply-To: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13381-70-shm6f2p9Zn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36783|0                           |1
        is obsolete|                            |
  Attachment #37067|0                           |1
        is obsolete|                            |
  Attachment #37069|0                           |1
        is obsolete|                            |

--- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37070
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37070&action=edit
Bug 13381 - RDA: 245 field changes in XSLT

This patch updates the display of the title and statement of responsibility in
the
XSLT display in the staff and OPAC.

Display includes subfields a,b,c,h,k,n,p,s
Subfield c is wrapped in a span class=title_resp_stmt for easy suppression via
css.
Subfield h is wrapped in a span class=title_medium for easy suppression via
css.

To test:

* Search the opac
* Click the title
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:13:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 18:13:35 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-XicSm05YW4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:13:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 18:13:37 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-lxNOHTmAAs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37043|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37071
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37071&action=edit
[PASSED QA] Bug 9120: Prevent form submission on adding tags - OPAC

At the OPAC, if the user adds tags pressing 'Enter', the page is
reloaded and the tags are not added.
To prevent that, this patch suggests to block the "press enter" event on
the inputs.

Test plan:
0/ Confirm the bad behavior, without this patch.
1/ Apply this patch and confirm nothing happen on pressing enter when
the focus is on the add tag input (At the opac, on the result view).

Patch works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:23:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 18:23:25 +0000
Subject: [Koha-bugs] [Bug 13879] DataTables server-side processing for
 patrons - sort is broken
In-Reply-To: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13879-70-im6tIiccv7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:23:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 18:23:27 +0000
Subject: [Koha-bugs] [Bug 13879] DataTables server-side processing for
 patrons - sort is broken
In-Reply-To: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13879-70-qsuP8O755M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37059|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37072
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37072&action=edit
[PASSED QA] Bug 13879: Fix sort on patron search (guarantor and linked to
orders)

This patch fixes a regression introduced by bug 13021.

Test plan:
1/ Go on a child detail page > edit
2/ Click on "Set a patron" as a guarantor
3/ Launch a search a confirm that you are able to sort on card, name and
date of birth.
Note that the Address column is not sortable (it's a limitation, could
be fixed later).
4/ Go on the acquisition module, create an order.
5/ Click on the "Add user" button.
6/ Launch a search a confirm that you are able to sort on card, name and
category

Without patch, I could not sort on names. With patch, sorting works as
dexcribed in Test plan

Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 19:33:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 18:33:57 +0000
Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
In-Reply-To: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13382-70-SRbflekQlP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36786|0                           |1
        is obsolete|                            |

--- Comment #26 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 37073
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37073&action=edit
Bug 13382 - RDA: 700/710/711 display in XSLT

Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 700,710,711
4) Perform an opac search that would show the record in the search results.
5) Click title to review record.
6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g,
h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span
class=separator |. Adds Related and Contained Works as new headings.
7) Repeat steps 4 - 6 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:47:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 19:47:17 +0000
Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode,
 categorytype from table overduerules_transport_types
In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13624-70-iiEUzLpDgD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

--- Comment #13 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 37074
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37074&action=edit
Bugs 13624 - Test plan and fixes db scripts for overduerules migrations

TEST PLAN
1) Create or improve on overduerules data
  .1) Intranet -> tools -> overdue notices
  .2) Make sure to have data in first, second and third tabs
  .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on
availability)
  .4) Make sure to have different letters and delay on first/second/third tab
for at least one category
  .5) Remember it all.
2) Apply patch
3) run installer/data/mysql/updatedatabase.pl
4) run t/db_dependant/Overdues.t
5) Validate Overdue Notice page
  .1) validate data entered previously is still there
  .2) Add some more, save changes, validate

This patch also
- simplifies (somewhat) updatedatabase.pl
- modifies kohastructure.sql to match updatedatabase.pl (because I couldn't
'insert after' with a KEY constraint)
- fixes database call

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 20 20:48:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 20 Mar 2015 19:48:59 +0000
Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode,
 categorytype from table overduerules_transport_types
In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13624-70-RTNaULRnQs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 07:01:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 06:01:27 +0000
Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the
 number of days used in purge_suggestions.pl
In-Reply-To: <bug-13287-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13287-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13287-70-kXAZgw46Z4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
I agree with Eric and Katrin.

The patch works as expected, however I think the explanation in syspref needs
some changes:

--Original-------
Keep purchase suggestions for a period of [   ] days.
WARNING - Leave this field empty if you don't want to activate this automatic
feature.
Example: [30] Sets purgation of suggestions for those older than 30 days.
(Used when the purge_suggestions.pl script is called with a specific number of
days)
------------------

--Proposition-----
Keep accepted or rejected purchase suggestions for a period of [   ] days.
WARNING - Leave this field empty if you don't want to activate this automatic
feature.
Example: [30] Sets purgation of suggestions for those older than 30 days.
(Used when the cronjob purge_suggestions.pl is active and called without a
specific number of days)
------------------

Additionally, I would like to see some more explanation in the manual
http://manual.koha-community.org/latest/en/cronjobsch.html#cronjobs
1.9.1. Clean up old suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 07:14:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 06:14:32 +0000
Subject: [Koha-bugs] [Bug 13811] Silent Cronjobs
In-Reply-To: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13811-70-bZXwuo3p9G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Status is NEW, but patches attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 11:33:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 10:33:14 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-jSB4koIUpR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #101 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37075
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37075&action=edit
Bug 13068: [QA Follow-up] Remove the Talking-Tech-itiva file from atomicupdate

The file can be removed. The code is included in the db revisions
3.09.00.014 and 3.15.00.040.
Also I adjusted the text of TalkingTech.README and removed the reference to
the atomicupdate file.

NOTE: I open a new report for adding TalkingTechItivaPhoneNotification to
sysprefs.sql. Probably, the text inserted in the db revisions should have
been inserted into the sample notices sql text too. These corrections are
outside the scope of this report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 11:45:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 10:45:17 +0000
Subject: [Koha-bugs] [Bug 13883] New: TalkingTechItiva housekeeping
Message-ID: <bug-13883-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13883

            Bug ID: 13883
           Summary: TalkingTechItiva housekeeping
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

With reference to bug 13068, the following housekeeping actions need to be
done:

[1] Add TalkingTechItivaPhoneNotification syspref to sysprefs.sql. See db rev
3.09.00.014.

[2] Add text to sample_notices.sql? Combine here 3.09.00.014 and 3.15.00.040.

[3] Add phone notifications to patron message preferences options?

I am leaving this to Kyle :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 11:45:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 10:45:33 +0000
Subject: [Koha-bugs] [Bug 13883] TalkingTechItiva housekeeping
In-Reply-To: <bug-13883-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13883-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13883-70-tYfLqUs4Bh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13883

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13068

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 11:45:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 10:45:33 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-s1Si1yljSM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13883

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 11:46:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 10:46:04 +0000
Subject: [Koha-bugs] [Bug 13514] Move two files out of atomicupdate folder
In-Reply-To: <bug-13514-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13514-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13514-70-a7lbYzWMMM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13514

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 11:46:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 10:46:22 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-3yzquQPslL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|http://bugs.koha-community. |
                   |org/bugzilla3/show_bug.cgi? |
                   |id=13514                    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 11:46:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 10:46:22 +0000
Subject: [Koha-bugs] [Bug 13514] Move two files out of atomicupdate folder
In-Reply-To: <bug-13514-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13514-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13514-70-VUL9Ks5YLp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13514

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|http://bugs.koha-community. |
                   |org/bugzilla3/show_bug.cgi? |
                   |id=13068                    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 11:47:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 10:47:20 +0000
Subject: [Koha-bugs] [Bug 13883] TalkingTechItiva housekeeping
In-Reply-To: <bug-13883-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13883-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13883-70-MwCHqua6qE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13883

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle.m.hall at gmail.com
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 11:57:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 10:57:54 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-CFHyYhcEeo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37075|0                           |1
        is obsolete|                            |

--- Comment #102 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 37076
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37076&action=edit
Bug 13068: [QA Follow-up] Remove the Talking-Tech-itiva file from atomicupdate

The file can be removed. The code is included in the db revisions
3.09.00.014 and 3.15.00.040.
Also I adjusted the text of TalkingTech.README and removed the reference to
the atomicupdate file.

NOTE: I open a new report for adding TalkingTechItivaPhoneNotification to
sysprefs.sql. Probably, the text inserted in the db revisions should have
been inserted into the sample notices sql text too. These corrections are
outside the scope of this report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:07:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 11:07:00 +0000
Subject: [Koha-bugs] [Bug 13811] Silent Cronjobs
In-Reply-To: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13811-70-MjrxGAuCWn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811

Eric B?gin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |maxime.beaulieu at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:08:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 11:08:00 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-yPpwMAnvkC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #103 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
There is one thing that I will still want to mention again, with reference to
comments 12 and 17:

I would like to run perl files too.
If we start doing more with DBIC, we should probably stop with db revisions in
sql format, but use the perl format.

The current implementation switches back to .sql only.
Aside from that, this seems to work fine (with some additional work for the
RM).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:11:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 11:11:40 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
 the Staff client to budget information.
In-Reply-To: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10013-70-ThZb1klznw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 12:35:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 11:35:19 +0000
Subject: [Koha-bugs] [Bug 13884] New: add the ability to search by isbn or
 by "any" in acqui-home.pl
Message-ID: <bug-13884-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13884

            Bug ID: 13884
           Summary: add the ability to search by isbn or by "any" in
                    acqui-home.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: marjorie.barry-vila at ccsr.qc.ca
        QA Contact: testopia at bugs.koha-community.org

Created attachment 37077
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37077&action=edit
acquisition_search

Hi,
Currently in acqui-home.pl, basic research orders is done on the title and only
advanced search provides search by ISBN.
Is there could be a drop-down menu to choose the search index in search orders?

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 15:54:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 14:54:18 +0000
Subject: [Koha-bugs] [Bug 13885] New: Cataloging search header should
 include more options
Message-ID: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885

            Bug ID: 13885
           Summary: Cataloging search header should include more options
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nick at quecheelibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When cataloging it would be nice to have the option of moving easily to
check-in or regular catalog search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 15:58:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 14:58:31 +0000
Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates
 999 entry and affects index
In-Reply-To: <bug-6657-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6657-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6657-70-XKlF8QqhSb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 15:58:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 14:58:59 +0000
Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include
	more options
In-Reply-To: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13885-70-e4auOXPNRj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885

--- Comment #1 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37078
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37078&action=edit
Bug 13885 - Cataloging search header should include more options

This patch adds the check in and standard catalog search to
cataloging-search.inc

To test:
1 - Apply patch
2 - Go to More->Cataloging
3 - Search in each tab (Cataloging search / Check out / Check in / Standard
search) and ensure that all work as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 15:59:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 14:59:33 +0000
Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include
	more options
In-Reply-To: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13885-70-Kyt4IacCp0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |nick at quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 16:31:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 15:31:31 +0000
Subject: [Koha-bugs] [Bug 4283] Merge bibliographic records
In-Reply-To: <bug-4283-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4283-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4283-70-oJzP5ArKSZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4283

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 16:33:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 15:33:39 +0000
Subject: [Koha-bugs] [Bug 13886] New: Add ability to merge records directly
 from cataloging search
Message-ID: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

            Bug ID: 13886
           Summary: Add ability to merge records directly from cataloging
                    search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nick at quecheelibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Current workflow requires that if one notices duplicated records in a
cataloging search they must then perform a standard search, add the records to
a list, then go to that list and merge them.  It would be nice to be able to
merge directly from the cataloging search screen (and the standard search
screen, but one step at a time)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 16:38:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 15:38:11 +0000
Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from
 cataloging search
In-Reply-To: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13886-70-m8VD5M0z4H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

--- Comment #1 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37079
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37079&action=edit
Bug 13886 - Add ability to merge records directly from cataloging search

This patch adds a merge button and checkboxes to the cataloging search results
screen to allow librarians to merge directly from these reults

To test:
1 - Apply patch
2 - Perform a cataloging search
3 - Try to select 1 or more than 2 records to merge and check that you get an
error
4 - Select 2 records to merge and confirm the correct records are passed to the
merge tool

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 16:38:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 15:38:48 +0000
Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from
 cataloging search
In-Reply-To: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13886-70-q7ui04UoNX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |nick at quecheelibrary.org
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 17:33:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 16:33:42 +0000
Subject: [Koha-bugs] [Bug 7369] duplicate item
In-Reply-To: <bug-7369-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7369-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7369-70-swlhQVgMv0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369

--- Comment #1 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37080
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37080&action=edit
Bug 7369 - duplicate item

This patch adds a link to duplicate existing items on the edit items screen

To test:
1 - Apply patch
2 - navigate to the edit items screen for a record with existing items
3 - click the duplicate link and ensure item info but not barcode are carried
over
4 - save the item and ensure it is added correctly
5 - check that all previous functionality on page works as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 17:33:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 16:33:59 +0000
Subject: [Koha-bugs] [Bug 7369] duplicate item
In-Reply-To: <bug-7369-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7369-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7369-70-cOmyRER3DW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |nick at quecheelibrary.org
           Assignee|gmcharlt at gmail.com          |nick at quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 18:28:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 17:28:46 +0000
Subject: [Koha-bugs] [Bug 13887] New: Add datatables to item specific holds
	table
Message-ID: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

            Bug ID: 13887
           Summary: Add datatables to item specific holds table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: nick at quecheelibrary.org
        QA Contact: testopia at bugs.koha-community.org

Currently when placing an item specific hold there is no, discernable, ordering
to the table or a way to search. On titles with many items it can be hard to
locate a copy for a specific library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 18:48:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 17:48:46 +0000
Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table
In-Reply-To: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13887-70-pa3cSAAjYq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

--- Comment #1 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37081
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37081&action=edit
Bug 13887 - Add datatables to item specific holds table

This patch adds datatables functionality to the item specific holds table

To test:
1 - Apply patch
2 - Attempt to place an item specific hold for a patron
3 - Note that columns are now sortable and searchable
4 - Ensure that you can place both specific and next available holds as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 18:49:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 17:49:16 +0000
Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table
In-Reply-To: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13887-70-vxarGtFRJO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |nick at quecheelibrary.org
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 18:49:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 17:49:32 +0000
Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from
 cataloging search
In-Reply-To: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13886-70-pMhEaVyh9R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 18:49:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 17:49:45 +0000
Subject: [Koha-bugs] [Bug 7369] duplicate item
In-Reply-To: <bug-7369-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7369-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7369-70-qTe3mkJrpd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 18:50:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 17:50:02 +0000
Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include
	more options
In-Reply-To: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13885-70-Qz1saxjX0Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 22:56:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 21:56:40 +0000
Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format
	dates
In-Reply-To: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4402-70-GLQRngSDyt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #35 from Chris Cormack <chris at bigballofwax.co.nz> ---
Template changes held for 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 22:59:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 21:59:14 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-h3cwcRCxAP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 23:02:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 22:02:09 +0000
Subject: [Koha-bugs] [Bug 13647] On-site checkouts: Allow library to
	specifiy due date
In-Reply-To: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13647-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13647-70-ti7YadeSKF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13647

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 23:03:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 22:03:48 +0000
Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable
	version
In-Reply-To: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12399-70-y6QpGMbnTp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
String changes held for 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 23:04:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 22:04:44 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-AxhhDJWIIR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> ---
Changes translations held for 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 23:06:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 22:06:51 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-GaGPaQBNna@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Doesn't apply cleanly on 3.18.x please rebase if it is needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 23:08:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 22:08:09 +0000
Subject: [Koha-bugs] [Bug 13858] Datatables paging for news page is broken
In-Reply-To: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13858-70-1XoSlHaeN2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13858

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 21 23:13:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 21 Mar 2015 22:13:28 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-IOkGUwCfd1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #34 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 06:13:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 05:13:43 +0000
Subject: [Koha-bugs] [Bug 13836] Koha/Number/Price.pm: format_for_editing
 fails 3 tests because of leading spaces in output
In-Reply-To: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13836-70-K7zA46lZNh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13836

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 06:15:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 05:15:30 +0000
Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32
In-Reply-To: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13586-70-uv5F6mnlpN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 06:26:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 05:26:36 +0000
Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with
 diacritics, utf-8 or ttf fonts
In-Reply-To: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13709-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13709-70-UgLPiWJBel@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 07:28:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 06:28:34 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-sxhr6b46Ih@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #204 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please see 13743 and 13790. Also there is a mismatch in this patch -
auto_increment for old_issues is in kohastructure.sql but not in the database
update.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 07:29:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 06:29:16 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-NK6QtVXa2u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13790,
                   |                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13743

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 07:29:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 06:29:16 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	oldissues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-L1p8tD8bpX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=9303

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 07:29:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 06:29:16 +0000
Subject: [Koha-bugs] [Bug 13743] Primary key for issues-table
In-Reply-To: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13743-70-7dHbEwbI4x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=9303

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 07:36:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 06:36:37 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	oldissues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-W7OhA78dUR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13743
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle, Olli has another patch for this on bug 13743, also this doesn't seem
to take into account the changes we made after testing on bug 9303.
I am wondering about the auto_increment on old_issues and the renumbering of
the old entries especially. Could you try and figure this out together?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 07:36:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 06:36:37 +0000
Subject: [Koha-bugs] [Bug 13743] Primary key for issues-table
In-Reply-To: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13743-70-kG5FktMlEn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13790

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 07:40:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 06:40:06 +0000
Subject: [Koha-bugs] [Bug 13743] Primary key for issues-table
In-Reply-To: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13743-70-5HRtktTycE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Olli, 

I think this doesn't look quite right - the database update instance is in the
wrong place in the file and I feel the old_issues should not auto_increment.
Also I think this wouldn't renumber the old entries?
Please take a look at Kyle's patch on bug 13790 and also my comments on bug
9303.

We did a similar patch for reserves and old_reserves in the past, maybe that
could be helpful to look at as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 08:10:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 07:10:20 +0000
Subject: [Koha-bugs] [Bug 13743] Primary key for issues-table
In-Reply-To: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13743-70-ARarJrTd6s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 08:10:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 07:10:14 +0000
Subject: [Koha-bugs] [Bug 13743] Primary key for issues-table
In-Reply-To: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13743-70-1azCuZV4Hs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 08:53:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 07:53:56 +0000
Subject: [Koha-bugs] [Bug 13888] 'Lists' permission should allow/disallow
 using the lists module in staff
In-Reply-To: <bug-13888-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13888-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13888-70-minTZXLuFk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 08:28:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 07:28:07 +0000
Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove
	public lists
In-Reply-To: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13417-70-CRfs30RUc1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it would be more clean to say 'lists' is general list permission with
'manage public lists' and 'remaining list permissions' as the sub permissions -
that way it would work like the other module permissions. There is a mismatch
there now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 08:32:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 07:32:18 +0000
Subject: [Koha-bugs] [Bug 13888] New: 'Lists' permission should
 allow/disallow using the lists module in staff
Message-ID: <bug-13888-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888

            Bug ID: 13888
           Summary: 'Lists' permission should allow/disallow using the
                    lists module in staff
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

With bug 13417 a new permission was added to allow/disallow deletion of public
lists. The lists permission doesn't work like other module level permissions as
turning it off won't disallow use of the lists module. 

It would be nice if this could be added. It might need a 'remaining lists
permissions' permission, so that you can only disallow the deletion of public
lists but allow general use of the module.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 08:32:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 07:32:47 +0000
Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove
	public lists
In-Reply-To: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13417-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13417-70-mzXta7TYth@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

--- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, have added bug 13888 with my thoughts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 13:47:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 12:47:23 +0000
Subject: [Koha-bugs] [Bug 13889] New: Add information about cron jobs to
	system log
Message-ID: <bug-13889-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

            Bug ID: 13889
           Summary: Add information about cron jobs to system log
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The system log should contain information about cron jobs performed and make it
viewable under Home > Tools > Logs ("Browse system logs")

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:04:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 13:04:55 +0000
Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system
	log
In-Reply-To: <bug-13889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13889-70-Z1tZuawHGr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 37082
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37082&action=edit
Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home > Tools > Logs ("Browse system logs")

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
cron jobs.
- Run some cron jobs
- Go to Home > Tools > Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
with Action "All" and Submit.
- Output should show Dae/time and info about Cron jobs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 14:06:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 13:06:39 +0000
Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system
	log
In-Reply-To: <bug-13889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13889-70-epCmSQBGd2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 17:25:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 16:25:48 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-p6mujAHEnk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

--- Comment #6 from Nicole C. Engard <nengard at gmail.com> ---
This is a-ok the way it was, just wanted you to know that you don't have to go
through every help file and fix it because with the next release they'll
probably get put back since I just copy from the manual and paste to the help
files.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 17:27:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 16:27:53 +0000
Subject: [Koha-bugs] [Bug 13888] 'Lists' permission should allow/disallow
 using the lists module in staff
In-Reply-To: <bug-13888-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13888-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13888-70-R82ypRKsr2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
I agree!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 19:47:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 18:47:25 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-ozW9ckqy0k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 19:47:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 18:47:28 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-gau36HTHFH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37026|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37083
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37083&action=edit
[PASSED QA] Bug 13872 - Typographical error on columns_settings.tt

Test plan:
1) Go to url
'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/columns_settings.tt' line 9
and check the typo "columsn" and change for columns.
2) See also changes for Column settings to Columns settings at lines 3 and 15
3) Apply the patch
4) Repeat step 1 and chek if the typo is fixed or go to Administration >
Additional parameters > Configure columns and go to Help page.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx at gmail.com>

Typo is fixed
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 19:49:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 18:49:16 +0000
Subject: [Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
In-Reply-To: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13878-70-NI2WaN5KBI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 19:49:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 18:49:19 +0000
Subject: [Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
In-Reply-To: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13878-70-Zyg1iUnroX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37025|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37084
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37084&action=edit
[PASSED QA] Bug 13878 - Typo in help file (aqbudgets.tt)

Test plan:
1) Go to url
'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:15' and check
the typo "wan" or go to Administration > Acquisition parameters > Funds > Help
2) Apply the patch
3) Repeat step 1 and check if the typo is fixed.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx at gmail.com>

Typo is fixed.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:14:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:14:25 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-RrSTEEMZPC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:14:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:14:27 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-vQRu4tGZrS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36964|0                           |1
        is obsolete|                            |
  Attachment #36965|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37085
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37085&action=edit
[PASSED QA] Bug 13841 - Unit Test

Signed-off-by: Jen DeMuth <jdemuth at roseville.ca.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:14:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:14:46 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-r6SKdy4sag@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37086
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37086&action=edit
[PASSED QA] Bug 13841 - Returns via backdating or SIP2 can create new fines
with an amount outstanding of 0

Due to the way AddReturn and UpdateFine work, if you pass in a return
date to AddReturn, and that item has a calculated fine of 0, Koha will
insert the 0 amount fine into accountlines.

This is good behavior when we want to update an existing fine, but bad
behavior if there was no fine to begin with!

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/Circulation.t
3) Note the test fails
4) Apply this patch
5) prove t/db_dependent/Circulation.t
6) Note the test passes

Signed-off-by: Jen DeMuth <jdemuth at roseville.ca.us>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Confirmed the problem in the staff interface and that the patch
fixes it. Also tested that fines still get calculated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:32:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:32:31 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-cGo9jCU92T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |In Discussion

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure about this change. With the patch applied a search for sch will
bring up "Fischer" - so it does a 'contains' search. I think on a big system
this will make the autocomplete harder to handle - it might bring up a lot of
unrelated searches. There might be reasons to make the autocomplete more strict
than the normal patron search, where you can pick your options.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:56:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:56:17 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-JmY25Zz8OI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36933|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:56:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:56:14 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-6nBInDma9K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:56:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:56:19 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-bNJKd7MU9u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36745|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:56:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:56:21 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-KALplA0z0O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36746|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:56:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:56:23 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-xUrfbC5ZW6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36747|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:56:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:56:25 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-CwuhtBEsd8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36748|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:56:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:56:28 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-0c5VuaUHbH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36756|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:56:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:56:30 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-BRkg9IjYGO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37023|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:56:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:56:59 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-5HeeptMab5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37087
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37087&action=edit
[PASSED QA] Bug 13601: Add tests to highlight the problems with
DateTime::Format::DateParse

Test behaves as expected (Fail as expected  with first patch only, OK after 3rd
patch)
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:57:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:57:02 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-MwWu92tCkk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37088
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37088&action=edit
[PASSED QA] Bug 13601: Make dt_from_string not using
DateTime::Format::DateParse

For a couple of reasons, dt_from_string should not use
DateTime::Format::DateParse:
1/ It does not manage date < 1900, certainly caused by l.47 of this
module:
 $p{ year }      = $year ? $year + 1900 : DateTime->now->year;

2/ It considers 31/01/2015 as a valid us date, which is not.

Test plan:
1/ Verify that
  prove t/DateUtils.t
returns green
2/ Play with dates in Koha (yes I know, it's vague...)
3/ Try to find a regression with dates
4/ Create a date with year <= 1900 and confirm it works

QA comment:
Why the sql format switch was:
-                $date_string =~
-s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/;

>From where a date like "yyyymmdd hhmmss" can come?

Tested patches 1 - 3 together. Worked as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:57:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:57:06 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-KS8UiWklxW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37089
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37089&action=edit
[PASSED QA] Bug 13601: get rid of DateTime::Format::DateParse

This module is used in C4::Members::GetPendingIssues too, but we can use
dt_from_string.

Test plan:
1/ Verify that
    prove t/db_dependent/Members/GetPendingIssues.t
returns green
2/ On the patron pending issue list, verify that the issue and the due
dates are correctly displayed.

Tested together with other patches (except "Fix special cases). Worked as
expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:57:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:57:09 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-tHjwpBNnbh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37090
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37090&action=edit
[PASSED QA] Bug 13601: Add a fallback check for compability with existing code

There are a lot of places where the date comes from the DB but the
dateformat parameter is not set to 'sql'.
dt_from_string needs to fallback with this format if the pref format
does not match.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:57:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:57:13 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-vgjmMQGC5m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37091
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37091&action=edit
[PASSED QA] Bug 13601: Fix special case in basket.pl

There is a badly managed date in acqui/basket.pl:
if the date is 15/01/2015 (metric format), it will become
2015-1-15 after the following line:
  $estimateddeliverydate = "$year-$month-$day";
Add_Delta_Days is used at several place, and the ouput is forced to
display date on 4 digits and month/day on 2 digits.
This patch does the same thing for $estimateddeliverydate.

Note that I previously developed a patch to take this format into account (with
missing 0)
in Koha::DateUtils::dt_from_string, but I don't think it's a good idea
to manage bad formated dates.
We will certainly find some issues after previous patches, but it will permit
to catch
them!
IMO it's preferable than to keep them hidden.

The patch was:
    diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm
    index 5fe2653..4434a67 100644
    --- a/Koha/DateUtils.pm
    +++ b/Koha/DateUtils.pm
    @@ -72,17 +72,17 @@ sub dt_from_string {
             my $fallback_re = qr|
                 (?<year>\d{4})
                 -
    -            (?<month>\d{2})
    +            (?<month>\d{1,2})
                 -
    -            (?<day>\d{2})
    +            (?<day>\d{1,2})
             |xms;

             if ( $date_format eq 'metric' ) {
                 # metric format is "dd/mm/yyyy[ hh:mm:ss]"
                 $regex = qr|
    -                (?<day>\d{2})
    +                (?<day>\d{1,2})
                     /
    -                (?<month>\d{2})
    +                (?<month>\d{1,2})
                     /
                     (?<year>\d{4})
                 |xms;
    @@ -90,9 +90,9 @@ sub dt_from_string {
             elsif ( $date_format eq 'us' ) {
                 # us format is "mm/dd/yyyy[ hh:mm:ss]"
                 $regex = qr|
    -                (?<month>\d{2})
    +                (?<month>\d{1,2})
                     /
    -                (?<day>\d{2})
    +                (?<day>\d{1,2})
                     /
                     (?<year>\d{4})
                 |xms;
    diff --git a/t/DateUtils.t b/t/DateUtils.t
    index 886e1d6..0877240 100755
    --- a/t/DateUtils.t
    +++ b/t/DateUtils.t
    @@ -189,3 +189,8 @@ is( output_pref( { dt => $dt } ), '31/01/2015 12:34',
'dt_from_string should mat
     # date before 1900
     $dt = dt_from_string('01/01/1900');
     is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/1900',
'dt_from_string should manage date < 1900' );
    +
    +# missing 0
    +$dt = dt_from_string('1/1/2015');
    +is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/2015',
'dt_from_string should generate a DT object even if 0 are missing' );

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:57:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:57:16 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-uiE7rBi56M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37092
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37092&action=edit
[PASSED QA] Bug 13601: t/Letters.t needs to mock the dateformat pref

Test passes OK.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 20:57:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 19:57:21 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-4SvhTJeTXK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37093
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37093&action=edit
[PASSED QA] Bug 13601: The fallback regex should contain the time part

On displaying a sql date, if the dateformat is not set to sql, the
output should contain the date.
In the previous version, the fallback regex (used for sql format) did not
included the time part (hh:mm:ss).

Checked out an item with due date an ddue time. Time displays as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 21:04:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 20:04:34 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11999-70-caW5O4W47y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This seems to break one of the existing tests, please check:

not ok 52 - Reserving a 'PEGI 16' Biblio by a 15 year old borrower fails
#   Failed test 'Reserving a 'PEGI 16' Biblio by a 15 year old borrower fails'
#   at t/db_dependent/Reserves.t line 498.
#          got: 'none_available'
#     expected: 'ageRestricted'
ok 53 - Reserving a 'PEGI 16' Biblio by a 30 year old borrower succeeds
# Looks like you failed 1 test of 53.

Please also include a short explanation in your new tests:

ok 35 - cannot request item if policy that matches on bib-level item type
forbids it (bug 9532)
ok 36
ok 37
ok 38
ok 39 - Waiting reserve beyond max pickup delay *not* canceled on holiday

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 21:29:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 20:29:32 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-BJ8hhvqIz1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37052|0                           |1
        is obsolete|                            |
  Attachment #37053|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37094
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37094&action=edit
[SIGNED OFF] Bug 13876: Fallback to /tmp if logdir is not writable

If the logdir directory is not writable by the koha user, the installer
should not explode.
This patch uses a temporary directory as a fallback.
That means that the history won't be kept.

Test plan:
0/ Generate an update (modify updatedatabase.pl and kohaversion)
1/ Make sure the permission are not correct on $logdir
2/ Go on the interface and execute the update entry.
3/ Confirm that the log has been created in a temporaty directory.

Retry with correct permissions and confirm the log will be created in
$logdir.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Adding a follow-up for completely resolving encountered issues.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 21:29:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 20:29:45 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-x5xHf1LI4L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37095
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37095&action=edit
[SIGNED OFF] Bug 13876: [QA Follow-up] Resolve updatedatabase logfile issues

This patch removes the test on write permissions of the logdir.
It uses File::Temp to generate a file in the logdir or otherwise in
a system tmp dir.
This resolves issues with both write permissions as well as SELinux
denials.
Note that after generating an empty file, we are appending to it in
the system statement.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 21:32:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 20:32:17 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-uSan7CyFrN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This fixes the problem for me, my database updates are working again!

As the QA follow-up has more lines than the initial patch ;) I'd like to get
another QA view from Jonathan or another QA person on this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 21:38:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 20:38:20 +0000
Subject: [Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does
 not prevent librarian from placing the hold
In-Reply-To: <bug-12197-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12197-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12197-70-Jyx8xBEQk3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Kyle, can you please look into Jonathan's last comment?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 22:06:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 21:06:58 +0000
Subject: [Koha-bugs] [Bug 13890] New: Full serial permission is needed to
 change sequence on a routing list
Message-ID: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890

            Bug ID: 13890
           Summary: Full serial permission is needed to change sequence on
                    a routing list
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

For changing the sequence of patrons on a routing list by changing one of the
numbers via the pull downs, full serial permission is needed:

reorder_members.pl:
checkauth( $query, 0, { serials => 1 }, 'intranet' );

To test:
- Give your patron full serial permissions
- Create a subscription and a routing list for it
- Change the sequence on the routing list using the pull downs
- Verify this works
- Remove any of the serial sub permissions
- Verify changing the sequence now results in a permission error

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 22:10:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 21:10:55 +0000
Subject: [Koha-bugs] [Bug 13890] Full serial permission is needed to change
 sequence on a routing list
In-Reply-To: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13890-70-IeWX9sKBHD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 22:10:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 21:10:57 +0000
Subject: [Koha-bugs] [Bug 13890] Full serial permission is needed to change
 sequence on a routing list
In-Reply-To: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13890-70-UWI2VhopZm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37096
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37096&action=edit
Bug 13890 - Switch from full serials permission to 'routing' permission for
reordering routing lists

For changing the sequence of patrons on a routing list by changing
one of the numbers via the pull downs, full serial permission is needed:

To test:
- Give your patron full serial permissions
- Create a subscription and a routing list for it
- Change the sequence on the routing list using the pull downs
- Verify this works
- Remove any of the serial sub permissions (claim serials or similar)
- Verify changing the sequence now results in a permission error
- Apply patch
- Verify that the permission error is gone now
- Remove the routing permission
- Verify the permission error is back (but this seems to make sense)

In general more fixes would be required to make all routing related
features depend on the routing permission, but I think this fixes
the bug making it depend on the correct permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 22:11:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 21:11:16 +0000
Subject: [Koha-bugs] [Bug 13890] Full serial permission is needed to change
 sequence on a routing list
In-Reply-To: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13890-70-Lm9DhFKMeU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 22:27:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 21:27:46 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
	for serials
In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8296-70-WUFURYBigc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #103 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Julian, 

I think the common "entry page" to subscriptions for parons in the OPAC is
opac-detail > subscriptions tab. This view is labelled as 'Normal view' when
you look at it from the the full history page. I think adding the information
there the same way we have it on the full history page would make sense to me. 

I am a bit torn about the feature still, but I think with that follow-up it
would make enough sense to me to pass QA. Patches tested ok so far. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 22:37:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 21:37:06 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-BHttIGNyl0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|enhancement                 |normal

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Updating this to a bug fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 22:42:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 21:42:11 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-10vh7BgUi4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36985|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37097
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37097&action=edit
[3.18.x] Bug 13863: Fix Datatables paging on the cities and search history
pages

Test plan:
Go on admin/cities.pl and catalogue/search-history.pl and confirm the
pagination is not broken anymore.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Fixed conflict so patch applies on 3.18.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 22:46:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 21:46:39 +0000
Subject: [Koha-bugs] [Bug 7290] new permission for receiving
In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7290-70-dycRfDXzN8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #53 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry. patch no longer applies and conflicts are not trivial - please fix!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 22:50:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 21:50:40 +0000
Subject: [Koha-bugs] [Bug 7290] new permission for receiving
In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7290-70-cVZvgIgpAU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #54 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
My branch was not on current master... sorry! 
Switching back to signed off, continuing work on this later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 22:54:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 21:54:06 +0000
Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
In-Reply-To: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13869-70-fwXAuIgaaq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 22:59:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 21:59:53 +0000
Subject: [Koha-bugs] [Bug 7290] new permission for receiving
In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7290-70-xLcWXUoAMb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 23:34:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 22:34:24 +0000
Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by
	relevance
In-Reply-To: <bug-13414-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13414-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13414-70-5m5iTNaieU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414

--- Comment #15 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #13)
> David, Team Lyon3, how do we proceed here?
> Would you be ok with me changing the sysprefs.sql file back to the old label?

It doesn't really matter too much what's in sysprefs.sql, since it won't show
up in the web UI, but I figure keeping the original label is probably the best
idea.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 23:42:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 22:42:08 +0000
Subject: [Koha-bugs] [Bug 7290] new permission for receiving
In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7290-70-eMG6SwgG2Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290

--- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some first findings:

Can you please amend your tests to have some explanations?
1..18
ok 1
ok 2
...

... and while you are on it, fix the little tab that crept into 
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt?
+    <h3>Error receiving items:</h3>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 23:43:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 22:43:34 +0000
Subject: [Koha-bugs] [Bug 7290] new permission for receiving
In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7290-70-X000fuq9Lx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290

--- Comment #56 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
... please also fix the databaes update to say XXX - it will make testing this
easier!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 22 23:59:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 22:59:50 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-svMtWaUNYL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 00:02:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 23:02:31 +0000
Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page,
 and new column aqbasketgroups.closeddate
In-Reply-To: <bug-11708-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11708-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11708-70-Fr8IMC7yqb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #108 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some first findings from the code review:

1) Database update removes closed column, but it's still in kohastructure.sql. 

2) I wonder if Basket groups should go first in the side navigation, as in the
workflow the basket group happens before the orders are late or invoices can be
done.

3) Why no paging on the basket groups datatable?

4) The database update statement is missing the version XXX - so it cannot be
run from commandline.

Mostly small things, please fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 00:08:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 23:08:03 +0000
Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl
In-Reply-To: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8436-70-OJjdBa6bAq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 00:08:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 23:08:28 +0000
Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl
In-Reply-To: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8436-70-VGuQ3papRq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 35166
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35166
[SIGNED OFF] Bug 8436: Add limit on branch in checkexpiration.pl

Review of attachment 35166:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8436&attachment=35166)
-----------------------------------------------------------------

::: serials/checkexpiration.pl
@@ +106,5 @@
>  }
> +
> +my $branchname;
> +my @branches_loop;
> +if (   $flags->{superlibrarian}

I think we should be using C4::Context->IsSuperLibrarian() here - please check!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 00:08:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 22 Mar 2015 23:08:39 +0000
Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl
In-Reply-To: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8436-70-CMEAfqNhYN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 05:57:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 04:57:27 +0000
Subject: [Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor
 - if subfield is disabled in OPAC/enabled in Staff, via frameworks
In-Reply-To: <bug-13331-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13331-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13331-70-QRXEfCFazf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331

--- Comment #18 from Mason James <mtj at kohaaloha.com> ---
(In reply to Tom?s Cohen Arazi from comment #17)
> (In reply to Mason James from comment #15)
> > (In reply to Tom?s Cohen Arazi from comment #13)
> > > Patch pushed to master.
> > > 
> > > Thanks Mason!
> > > 
> > > PS. try to tidy your commit messages a bit next time :-D
> > 
> > can you show me an example of an untidy commit message from me?
> 
> Sorry, I meant the subject!

aah, yes - my mistake :0)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 07:29:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 06:29:41 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-DiLKrf5XaZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 07:29:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 06:29:44 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-TXDlKKIUqd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37007|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37098
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37098&action=edit
[PASSED QA] Bug 13855 - Fastadd framework has 2x 100$c, missing 100$a

The fastadd framework ist missing a 100$a subfield, it has two 100$c instead.
This patch corrects English, German, Italian and Spanish .sql files.
Italian and Spanish need translations for the field name.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested running all sql files manually.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 07:43:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 06:43:54 +0000
Subject: [Koha-bugs] [Bug 13890] Full serial permission is needed to change
 sequence on a routing list
In-Reply-To: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13890-70-53m6rGfjNf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 37099
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37099&action=edit
[Signed-off] Bug 13890 - Switch from full serials permission to 'routing'
permission for reordering routing lists

For changing the sequence of patrons on a routing list by changing
one of the numbers via the pull downs, full serial permission is needed:

To test:
- Give your patron full serial permissions
- Create a subscription and a routing list for it
- Change the sequence on the routing list using the pull downs
- Verify this works
- Remove any of the serial sub permissions (claim serials or similar)
- Verify changing the sequence now results in a permission error
- Apply patch
- Verify that the permission error is gone now
- Remove the routing permission
- Verify the permission error is back (but this seems to make sense)

In general more fixes would be required to make all routing related
features depend on the routing permission, but I think this fixes
the bug making it depend on the correct permission.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 07:44:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 06:44:26 +0000
Subject: [Koha-bugs] [Bug 13890] Full serial permission is needed to change
 sequence on a routing list
In-Reply-To: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13890-70-1nAAxBbYP4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37096|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 07:44:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 06:44:36 +0000
Subject: [Koha-bugs] [Bug 13890] Full serial permission is needed to change
 sequence on a routing list
In-Reply-To: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13890-70-jCTydxpPdT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:01:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 07:01:20 +0000
Subject: [Koha-bugs] [Bug 7290] new permission for receiving
In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7290-70-qjzT5IgHC7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #57 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, some thoughts on permission management in acq for the parcel list:

- I have removed all _all permissions from my staff patron
- I have set AcqViewBaskets to 'created or managed by staff member'

I can't access a basket now, that belongs to another library and was also
created by another staff user than me.

But: On the parcel page, I can still see all the information about the orders.
I can't receive them (good!), but I can still delete and transfer the orders
(not good!)

Thinking about big libraries and the need to hide information from others, I
feel like there should be a combination of permissions here, that results in me
not seeing the order lines of other libraries at all. 

I'd expect the combination above should do it, but it doesn't.

When I also remove the 'order_manage' permission, I get a permission error on
clicking 'transfer' and 'delete' - but the links shouldn't be showing in the
first place.

I think the current situation is not very good here :(

The feature itself seems to be working ok, only found a small bug so far:
Manipulating the URL to gain access to an order I cannot receive it displays a
nice error message, but there is a small error in the heading on the page:

Receive items from : Books Books Books [HASH(0x530f938)] (order #138)

Waiting for the follow-ups and giving the permission problem some more thought.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:03:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 07:03:03 +0000
Subject: [Koha-bugs] [Bug 7290] new permission for receiving
In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7290-70-honrMmJS90@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290

--- Comment #58 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Another small problem found:

Being superlibrarian I still can't access the receive page, but I think I
should be able to.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:04:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 07:04:09 +0000
Subject: [Koha-bugs] [Bug 7290] new permission for receiving
In-Reply-To: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7290-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7290-70-ocPfH8d5BL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290

--- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #58)
> Another small problem found:
> 
> Being superlibrarian I still can't access the receive page, but I think I
> should be able to.

Scratch that - logging out and logging in again fixed it. I can access the
receive page as superlibrairan now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:33:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 07:33:21 +0000
Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable
	version
In-Reply-To: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12399-70-FIyJXcXdPf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 08:34:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 07:34:53 +0000
Subject: [Koha-bugs] [Bug 13794] Text input field values not translated
In-Reply-To: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13794-70-3YTyvkVu3E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #14 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:00:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 10:00:33 +0000
Subject: [Koha-bugs] [Bug 9811] Patrons search improvements
In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9811-70-QORhrU2fRT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13891

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:00:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 10:00:33 +0000
Subject: [Koha-bugs] [Bug 13891] New: Make all patron searches use
 DataTables server-side processing
Message-ID: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

            Bug ID: 13891
           Summary: Make all patron searches use DataTables server-side
                    processing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 9811
            Blocks: 12633

Bug 9811 introduces a new search way for patrons. Some code have been
refactored and the server-side option of DataTables is now used.

Bug 12648 (basket users) and bug 13021 (guarantors) uses the same way to search
patrons.

But in 3 other places, the former C4::Members::Search subroutine is still used
(and in some cases, a manual pagination...):
- budget users and owner
- serial recipients
- patron cards


The 2 expected goals are 1/ Use the same centralized way to search for patrons
and 2/ to get rid of the last calls to the C4::Members::Search (and so
SQLHelper).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:00:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 10:00:33 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-5Bi2nsiCjp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13891

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:55:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 10:55:51 +0000
Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase
 suggestions forms
In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9468-70-Q2YeroitH6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:55:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 10:55:53 +0000
Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase
 suggestions forms
In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9468-70-OOHCFpYEGX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22714|0                           |1
        is obsolete|                            |
  Attachment #22715|0                           |1
        is obsolete|                            |
  Attachment #27932|0                           |1
        is obsolete|                            |
  Attachment #27933|0                           |1
        is obsolete|                            |
  Attachment #27934|0                           |1
        is obsolete|                            |
  Attachment #27935|0                           |1
        is obsolete|                            |

--- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37100
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37100&action=edit
[SIGNED-OFF] Bug 9468: [COUNTER-PATCH] make av-build-dropbox.inc available to
OPAC

This patch makes the av-build-dropbox.inc template include introduced
by the latest patches for bug 766 available to the prog and Bootstrap
themes in the OPAC.

See later patches in this series for testing.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:56:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 10:56:00 +0000
Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase
 suggestions forms
In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9468-70-PpN4MXqfCG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

--- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37101
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37101&action=edit
[SIGNED-OFF] Bug 9468: [COUNTER-PATCH] define new SUGGEST_FORMAT authorize
value

This patch defines a new authorized called SUGGEST_FORMAT for
populating a list of patron-understandable formats for expressing
how they would prefer suggested items to be purchased.  For
database upgrades, it populates it based on the value returned by the
GetSupportList() routine.

To test
-------
[1] Run the database update.
[2] Verify that there is a new authorised value called SUGGEST_FORMAT
    whose codes and descriptions correspond to the list of "item types"
    available on the patron suggestion form.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:56:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 10:56:03 +0000
Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase
 suggestions forms
In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9468-70-RMLEKRLYzt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

--- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37102
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37102&action=edit
[SIGNED-OFF] Bug 9468: [COUNTER-PATCH] use new SUGGEST_FORMAT list

This patch uses the new SUGGEST_FORMAT authorized value list for
populating the list of suggestion item types/document types.  It
also improves the display by using the staff or OPAC description of
the authorised value rather than the code.

To test:

[1] Enter a suggestion via the OPAC and select an item type (which
    I will call "desired format" for the rest of this test plan).
[2] Verify that the saved suggestion displays the desired format
    description in both staff and OPAC.
[3] Verify that organizing the list of suggestions by item type
    now works in the staff interface, rather than displaying "Unknown"
    in each tab header.
[4] Verify that existing suggestions' desired formats are displayed
    correctly.
[5] Verify that suggestions can have their desired format edited
    in the staff inteface.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 11:56:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 10:56:06 +0000
Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase
 suggestions forms
In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9468-70-BRC5spqabP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37103
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37103&action=edit
[SIGNED-OFF] Bug 9468: [COUNTER-PATCH] sample SUGGEST_FORMAT values

This patch adds some sample values for the SUGGEST_FORMAT
authorized value list for new installations.

To test
-------
[1] Verify that the new SQL inserts added by this patch work.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:06:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:06:44 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-k80Z5s9CmU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:06:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:06:47 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-4yD9bO55eW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37104
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37104&action=edit
Bug 13891: DataTables server-side processing - budget users

This first patch remove the previous way to search for users to link to
budgets.

Test plan:
1/ Edit or create a fund
2/ Edit the owner of this fund a select a patron
3/ Add 1+ users to the user lists of this fund

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:06:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:06:52 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-y99tve0dCt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37105
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37105&action=edit
Bug 13891: DataTables server-side processing - Serial recipients

This second patch removes the previous way to search for serial recipients.

Test plan:
1/ Edit the routing list for a subscription
(serials/routing.pl?subscriptionid=X)
2/ Add 1+ recipients
3/ Confirm there is no regression on the add/delete/search actions

QA note: This search does not use a clean way to interact with the
window opener. Indeed the opener is reloaded to display the new item.
This patch does not change this behavior, but note the trick in the
template (common/patron_search.tt) to wait for the opener in order not
to get a JS error.
This is also used by the next patch (patron card).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:06:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:06:56 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-Uwn3QKcJL5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37106
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37106&action=edit
Bug 13891: DataTables server-side processing - patron cards

This third patch removes the previous way to search for patron cards users.

Test plan:
1/ Add items to a patron card batch
(patroncards/edit-batch.pl?op=edit&element_id=X)
2/ Add 1+ patrons to the batch
3/ Confirm there is no regression

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:07:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:07:00 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-VOQiqm6GlN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37107
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37107&action=edit
Bug 13891: DataTables server-side processing - Fix regressions

This patch fixes the regressions introduced by the previous patches.
If you have tested all in once, you didn't see them.

It introduces library, category and "first letter" filters.

Test plan:
1/ On all pages impacted by previous patches + new order empty (link patron to
an order) + guarantor search
2/ Add / Select patron to the list
3/ Use the filters
4/ Confirm there is no regression

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:08:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:08:30 +0000
Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing -
	guarantor search
In-Reply-To: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13021-70-dG9PU1l918@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13891

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:08:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:08:30 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-ESeE2WoHdw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13021

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:09:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:09:47 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-tkiDL7z0nr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Jonathan Druart from comment #16)
> Ok so...
> The good news is that only 1 occurrence still exists in C4::Members::Search
> The bad one is that it is called from 3 different places  (but I may have
> missed some others...):
>   admin/aqbudget_user_search.pl
>   serials/member-search.pl
>   patroncards/members-search.pl
> 
> I have a patch and will be able to submitted it on monday.

Done on bug 13891.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:10:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:10:05 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-c6U61bvjKU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
6 files deleted, 400 lines of code removed but new features added :)
Please test!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:16:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:16:35 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	oldissues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-moXb79fIgf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:23:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:23:44 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	oldissues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-jIyr8KxQrB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36441|0                           |1
        is obsolete|                            |
  Attachment #36442|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37108
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37108&action=edit
Bug 13790 - Add unique id issue_id to issues and old_issues tables

Test Plan:
1) Use a database with existing issues and old issues
2) Apply this patch
3) Run updatedatabase
4) Inspect the database
   a) old_issues should now have a column issue_id starting with 1
   b) issues should now have a column issue_id starting with the number
      of rows in the old_issues table plus one
5) Perform a checkout, note it is written to the database
6) Check in the checked out item, note it is moved to the old_issues table

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:23:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:23:50 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	oldissues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-Ytvx3NdQJu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37109
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37109&action=edit
Bug 13790 - Update Koha Schema

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:24:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:24:44 +0000
Subject: [Koha-bugs] [Bug 13743] Primary key for issues-table
In-Reply-To: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13743-70-W3YKZFVVqr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |kyle at bywatersolutions.com
             Status|Failed QA                   |RESOLVED

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 13790 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:24:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:24:44 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	oldissues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-PPWH2FcYlm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
*** Bug 13743 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:25:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:25:21 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	old_issues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-YAC9Nv3tPr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add unique id issue_id to   |Add unique id issue_id to
                   |issues and oldissues tables |issues and old_issues
                   |                            |tables

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:48:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:48:28 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-LYPDJfCjKM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:48:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:48:32 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-twdWzN3Np4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36287|0                           |1
        is obsolete|                            |
  Attachment #36288|0                           |1
        is obsolete|                            |
  Attachment #36289|0                           |1
        is obsolete|                            |

--- Comment #205 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37110
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37110&action=edit
Bug 9303 [1] - relative's checkouts in the opac - Database Updates

This patch gives patrons the option of allowing other
linked relatives to view his or her checkouts from
opac-user.pl in a manner similiar to the patron's own
checkouts tab. By default the setting is not enabled.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create three borrowers, link them as relatives
4) In the OPAC, go to "my privacy" and choose to allow
   relatives to view current checkouts for borrowers A and B
5) Check out some items to each borrower
6) Log into the OPAC as borrower A, you should see a "Relatives'
   checkouts" tab. In this tab you should see the checkouts for
   borrower B
7) Log into the OPAC as borrower C, you should be able to view
   the current checkouts for both borrower A and borrower B

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:48:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:48:43 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-UQgkX8DGOL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #206 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37111
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37111&action=edit
Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e
opac/svc/patron/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:48:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:48:47 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-R21b0ouebs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #207 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37112
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37112&action=edit
Bug 9303 [3] - relative's checkouts in the opac

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:48:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:48:56 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-H49uEAKHPQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13790

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:48:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:48:56 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	old_issues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-3JuwBIWNfe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |9303

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:49:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:49:30 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-EzgT0e7pU3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|9303                        |13790

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:49:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:49:30 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-ZDJiZXdcor@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|9011                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:49:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:49:30 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	old_issues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-5fcY5CNca4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |9011

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:50:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:50:15 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-ZbFftaNqzk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|13790                       |9303
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:50:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:50:15 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-8NLXCi1LfA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |9011

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:50:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:50:15 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	old_issues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-cCFxoJuR5K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|9011                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:52:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:52:31 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-iqO50j65En@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|9303                        |13790

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:52:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:52:31 +0000
Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac
In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9303-70-xI3iHv9V3q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|9011                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:52:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:52:31 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	old_issues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-SBM66I7Rtp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |9011

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:59:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:59:19 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-bYSTd9K5N8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32437|0                           |1
        is obsolete|                            |
  Attachment #32438|0                           |1
        is obsolete|                            |
  Attachment #32439|0                           |1
        is obsolete|                            |
  Attachment #32440|0                           |1
        is obsolete|                            |
  Attachment #32441|0                           |1
        is obsolete|                            |
  Attachment #32442|0                           |1
        is obsolete|                            |
  Attachment #32443|0                           |1
        is obsolete|                            |
  Attachment #32977|0                           |1
        is obsolete|                            |

--- Comment #96 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37113
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37113&action=edit
Bug 9011 - Re-engineer circ anonymization, move to subroutine in
C4::Circulation

Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:59:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:59:29 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-T1ncjNXqVD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #97 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37114
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37114&action=edit
Bug 9011 - Add the ability to store the last patron to return an item

Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:59:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:59:32 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-pOUdXv1Yy2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #98 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37115
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37115&action=edit
Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory

Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:59:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:59:44 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-de3s1LIXk1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #99 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37116
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37116&action=edit
Bug 9011 [QA Followup]

Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 12:59:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 11:59:48 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-A1duRMNRNX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #100 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37117
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37117&action=edit
Bug 9011 [QA Followup 2] - Add message to OPAC

* Adds warning to OPAC if StoreLastBorrower is enabled
* Updates db revision
* Fixes POD error

Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:00:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:00:10 +0000
Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice
In-Reply-To: <bug-11064-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11064-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11064-70-PLlci9c7cQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10906
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:00:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:00:10 +0000
Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported
 only as DEFAULT frameworks, not what they were originally
In-Reply-To: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10906-70-y0LKeO0Dct@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11064

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:07:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:07:35 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-diZxxBlB4v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|2546, 8798                  |13790

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:07:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:07:35 +0000
Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded
In-Reply-To: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2546-70-1jEhX54F7j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|6427                        |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:07:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:07:35 +0000
Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class
In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8798-70-6D2tgOfJHN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|6427                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:07:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:07:35 +0000
Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and
	old_issues tables
In-Reply-To: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13790-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13790-70-IO8q89uCkh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |6427

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:10:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:10:28 +0000
Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged
	MARC records
In-Reply-To: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10477-70-vuwIgKtJRg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:13:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:13:36 +0000
Subject: [Koha-bugs] [Bug 13892] New: SQLHelper replacement -
 C4::Members::Search - ysearch.pl
Message-ID: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

            Bug ID: 13892
           Summary: SQLHelper replacement - C4::Members::Search -
                    ysearch.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

ysearch.pl currently uses C4::Members::Search.
To get rid of SQLHelper, we should not use this subroutine anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:16:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:16:37 +0000
Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search
	- ysearch.pl
In-Reply-To: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13892-70-ZXxIsQ20Gd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:16:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:16:39 +0000
Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search
	- ysearch.pl
In-Reply-To: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13892-70-CoG7D4KaXo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37118
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37118&action=edit
Bug 13892: Make ysearch.pl not using C4::Members::Search

To get rid of SQLHelper, we should not use this C4::Members::Search anymore.

Test plan:
0/ Enable the CircAutocompl pref
1/ Go on the circulation home page, or the reserve page
2/ Search for a patron and wait for the autocompletion box
3/ Confirm there is no regression

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:16:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:16:46 +0000
Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search
	- ysearch.pl
In-Reply-To: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13892-70-bvIbcPzzbV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |12633

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:16:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:16:46 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-VsLLq3upkp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13892

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:17:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:17:21 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-AuC4yparMt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #18 from Jonathan Druart <jonathan.druart at biblibre.com> ---
circ/ysearch.pl should not use C4::Members::Search, done on bug 13892.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:24:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:24:53 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-TEyEEPg52u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #104 from Kyle M Hall <kyle at bywatersolutions.com> ---
Agreed, we will need the ability run perl files in the same manner, but that
can be a further enhancement independent of this.

(In reply to M. de Rooy from comment #103)
> There is one thing that I will still want to mention again, with reference
> to comments 12 and 17:
> 
> I would like to run perl files too.
> If we start doing more with DBIC, we should probably stop with db revisions
> in sql format, but use the perl format.
> 
> The current implementation switches back to .sql only.
> Aside from that, this seems to work fine (with some additional work for the
> RM).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:29:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:29:18 +0000
Subject: [Koha-bugs] [Bug 13893] New: Add ability to execute perl scripts in
 atomicupdates
Message-ID: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893

            Bug ID: 13893
           Summary: Add ability to execute perl scripts in atomicupdates
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Bug 13068 adds the ability to execute sql files from atomicupdates for in
process developments to reduce merge conflicts. We need to extend this ability
further to be able to handle perl code.

I can see either something like IPC::System::Simple to execute the perl script,
OR we can just have perl code in a file ( with the extension .perl or something
) which we simply evaluate. The latter seems like the better way, as the RM can
just copy and paste the code into updatedatabase.pl when it's ready to be
pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:29:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:29:22 +0000
Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in
	atomicupdates
In-Reply-To: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13893-70-CiTTnN8lBe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:29:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:29:35 +0000
Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in
	atomicupdates
In-Reply-To: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13893-70-jlK9m532ll@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13068

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:29:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:29:35 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-o5NCKaajzU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13893

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 13:52:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 12:52:38 +0000
Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported
 only as DEFAULT frameworks, not what they were originally
In-Reply-To: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10906-70-KolP0IaUzO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

--- Comment #2 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
This is still broken in current master (but only when records are being matched
& replaced when importing; for the records imported 'as new', framework choosen
by the user seems to be saved and retained properly - ?).

Looks like some changes introduced by commit
82dc7b55a8b5a7642a906dcd8963952b7464adb1 ("Bug 4321: clean
C4::Biblio::GetBiblio and uses") got inadvertantly reverted by next commmit
(6e71b80ca39e6f1d2c31659a9a656de807ef3f32, "Bug 7475: Teach matching rules to
handle authorities").

Another remaining place where GetBiblio() return results are wrongly assigned
is serials/subscription-history.pl script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:05:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:05:46 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-HPZEuGRM41@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 37119
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37119&action=edit
Bug 13799: Add Swagger UI documentation

Move all API stuff into /api/v1 (except for Perl modules).
So we have:
  /api/v1/script.cgi     CGI script
  /api/v1/swagger.json   Swagger specification
  /api/v1/doc            Swagger UI

Add a virtual host in Apache configuration api.HOSTNAME
So we have:
  http://api.HOSTNAME/v1/swagger.json   Swagger specification
  http://api.HOSTNAME/v1/doc            Swagger UI
  http://api.HOSTNAME/v1/{path}         API endpoint

To test, you need to:
  1/ perl Makefile.PL
  2/ make && make install
  3/ Change etc/koha-httpd.conf and copy it to the right place if needed
  4/ Reload Apache
  5/ Go to http://api.HOSTNAME/v1/doc and check everything works
  6/ Also check that http://api.HOSTNAME/v1/borrowers and
     http://api.HOSTNAME/v1/borrowers/{borrowernumber} works

Optionally, you could verify that http://api.HOSTNAME/vX/borrowers
(where X is an integer greater than 1) returns a 404 error

For the new vhost to work, you may need to modify your /etc/hosts file
if you run Koha locally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:06:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:06:44 +0000
Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in
	atomicupdates
In-Reply-To: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13893-70-OQDscMGHbR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:15:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:15:29 +0000
Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in
	atomicupdates
In-Reply-To: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13893-70-e6bIFtyGPD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:15:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:15:31 +0000
Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in
	atomicupdates
In-Reply-To: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13893-70-4JL6aOrKPY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37120
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37120&action=edit
Bug 13893 - Sample .perl file [Do Not Push]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:15:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:15:37 +0000
Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in
	atomicupdates
In-Reply-To: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13893-70-nhHj7sppoo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37121
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37121&action=edit
Bug 13893 - Add ability to execute perl scripts in atomicupdates

Bug 13068 adds the ability to execute sql files from atomicupdates for
in process developments to reduce merge conflicts. We need to extend
this ability further to be able to handle perl code.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) You should see the output "Upgrade to XXX done (Bug 13893 - Add ability to
execute perl scripts in atomicupdates)"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:17:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:17:47 +0000
Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in
	atomicupdates
In-Reply-To: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13893-70-PRNU7SrROC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37121|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37122
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37122&action=edit
Bug 13893 - Add ability to execute perl scripts in atomicupdates

Bug 13068 adds the ability to execute sql files from atomicupdates for
in process developments to reduce merge conflicts. We need to extend
this ability further to be able to handle perl code.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) You should see the output "Upgrade to XXX done (Bug 13893 - Add ability to
execute perl scripts in atomicupdates)"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:19:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:19:34 +0000
Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in
	atomicupdates
In-Reply-To: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13893-70-xY9uFsulBr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37122|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37123
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37123&action=edit
Bug 13893 - Add ability to execute perl scripts in atomicupdates

Bug 13068 adds the ability to execute sql files from atomicupdates for
in process developments to reduce merge conflicts. We need to extend
this ability further to be able to handle perl code.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) You should see the output "Upgrade to XXX done (Bug 13893 - Add ability to
execute perl scripts in atomicupdates)"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:44:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:44:29 +0000
Subject: [Koha-bugs] [Bug 13894] New: SQLHelper replacement -
 C4::Members::Search - reserve.pl
Message-ID: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

            Bug ID: 13894
           Summary: SQLHelper replacement - C4::Members::Search -
                    reserve.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

reserve/request.pl currently uses C4::Members::Search.
To get rid of SQLHelper, we should not use this subroutine anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:46:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:46:54 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-7xMVqsJINr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:46:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:46:56 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-WPxonuS4OJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37124
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37124&action=edit
Bug 13894: Make reserve.pl not using C4::Members::Search

Important note: This will modify the UI.
The patron list will now be displayed in a table (instead of a select).

Test plan:
1/ Place a hold on a record
2/ Search for a patron
3/ Select a patron and submit
4/ The hold workflow should continue as previously

No beviavior changes should be observed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:48:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:48:30 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-up2HJQ2RTn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13894

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 14:48:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 13:48:30 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-kC4g4f6CLV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |12633

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Note that this method will be applied to the circulation patron selection if
this reach an agreement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:05:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 14:05:05 +0000
Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search
	- ysearch.pl
In-Reply-To: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13892-70-KD9IdwEvZG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37118|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37125
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37125&action=edit
Bug 13892: Make ysearch.pl not using C4::Members::Search

To get rid of SQLHelper, we should not use this C4::Members::Search anymore.

Test plan:
0/ Enable the CircAutocompl pref
1/ Go on the circulation home page, or the reserve page
2/ Search for a patron and wait for the autocompletion box
3/ Confirm there is no regression

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:29:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 14:29:39 +0000
Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct
 display of tab descriptions broken
In-Reply-To: <bug-10519-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10519-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10519-70-S1gjY5DAC3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519

Koha Team Rennes 2 <koha at listes.univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at listes.univ-rennes2.fr
            Version|master                      |3.18

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:29:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 14:29:59 +0000
Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct
 display of tab descriptions broken
In-Reply-To: <bug-10519-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10519-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10519-70-OO1CYxciBI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519

Koha Team Rennes 2 <koha at listes.univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.18                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:49:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 14:49:00 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-e0MyowubB5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry to say this, but we missed a dependency :(
Bug 13379 - changes the category to varchar(16).
This means that on updating to 3.18.05 the value is too short and the code ends
up being ORDER_CANCELLATI

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 15:59:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 14:59:11 +0000
Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported
 only as DEFAULT frameworks, not what they were originally
In-Reply-To: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10906-70-QOkVhhed1X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906

--- Comment #3 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 37126
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37126&action=edit
Bug 10906 - Reimported records into Koha are imported only as DEFAULT
frameworks, not what they were originally

Existing framework code is currently not retained when local record
gets replaced during batch import, or when the restore/reverse function
is being used.

This patch fixes aforementioned issues by correcting outdated GetBiblio()
calls in C4/ImportBatch.pm

To test:

1/ try to replicate the issue: import some MARC records with
"Tools -> Stage MARC records for import" etc., using test setup,
matching rules and so on such that some existing records will get
replaced with imported ones
2/ observe that records replaced during import now open in the editor
with 'Default' framework, even if they have some other framework
set up previously
3/ apply patch
4/ redo 1/, confirming that this problem is no longer replicable
5/ try use 'restore' function with some freshly imported
records, ensure that original framework code got retained
in the records which had their imports reverted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:00:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:00:50 +0000
Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported
 only as DEFAULT frameworks, not what they were originally
In-Reply-To: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10906-70-iupwfZNCT5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|Windows                     |All
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |abl at biblos.pk.edu.pl
   Patch complexity|---                         |Trivial patch
            Version|3.10                        |master
           Hardware|PC                          |All

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:10:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:10:00 +0000
Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for
 checking in items that are not checked out
In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13411-70-1UlaxfDRQC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #16 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
There are a few problems with these patches. First the existing behaviour is
consistent with the standard ( 0 because a checkin has not succeeded) however I
can see that there is probably no practical distinction between checkin of an
unissued book and an issued one especially if some machines are routing returns
incorrectly as a result. But we should document it as a change in behaviour so
it gets reported as that in release notes (in case there are unforeseen
consequences)

The commit message also gives a test which does not succeed it says the message
is not returned after the patch is applied, but it is (incidently I think it
should still be returned as information, so the code is ok the test fails)

Finally the patch adds a new parameter into the config files but there is a) no
mention of it and b) it doesnt seem to be of any use in the implementation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:12:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:12:06 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-1Aq3qnC9Gp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36324|0                           |1
        is obsolete|                            |
  Attachment #36326|0                           |1
        is obsolete|                            |
  Attachment #36327|0                           |1
        is obsolete|                            |
  Attachment #36328|0                           |1
        is obsolete|                            |
  Attachment #36329|0                           |1
        is obsolete|                            |
  Attachment #36330|0                           |1
        is obsolete|                            |
  Attachment #36331|0                           |1
        is obsolete|                            |
  Attachment #36332|0                           |1
        is obsolete|                            |
  Attachment #36333|0                           |1
        is obsolete|                            |
  Attachment #36334|0                           |1
        is obsolete|                            |
  Attachment #36335|0                           |1
        is obsolete|                            |
  Attachment #36337|0                           |1
        is obsolete|                            |
  Attachment #36338|0                           |1
        is obsolete|                            |
  Attachment #36340|0                           |1
        is obsolete|                            |
  Attachment #36380|0                           |1
        is obsolete|                            |
  Attachment #36393|0                           |1
        is obsolete|                            |

--- Comment #645 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37127
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37127&action=edit
Bug 6427 - Update database

This patch set re-engineers Koha's accounting system to be faster, more
stable, and have a better historical accounting of fees and payments
while also unifying much of the payment logic and simplifying the code
behind it.

Three new tables have been created:
account_debits stores fines and fees owed by the patron.

account_credits stores payments, write-offs, and other line items that
reduce the amount owed by a patron.

account_offsets stores data about changes to debits and credits,
including which credits paid which debits.

borrowers.account_balance stores the current balance of the
patron, so it does not have to be calculated each time it needs to be
displayed.

issues.issue_id has been added so that individual fines can be directly
linked to the issue that caused them without ambiguity.

The various accounting code strings ( F, FU, Rent, etc ), some of which
have little or no documentation have been replaced by what enumerated
data types which are documented via POD.
There are three, one for each of Debits ( fees/fines ), Credits ( payments ),
and Offsets.

The system continues to allow custom fee types ( moving MANUAL_INV to
MANUAL_DEBIT )
while additionally allowing custom payment types ( MANUAL_CREDIT ).

The system also allows for overpayment, the the outstanding credit being
applied to future fees as they are created.

The system also allows for a librarian to accept a different amount of
money than what is to be paid, and will calculate the change to be
given.

Test Plan:
1) Apply this patch
2) Create some manual fees
3) Test the fee payments
   * Pay one fee
   * Pay multiple fees
   * Make a partial payment
   * Write off a fee
4) View the fees/payments, verify they are correct
5) Check out some items as overdue that should have fines
6) Run fines.pl, verify fines were generated
7) Pay on an accruing fine
8) Run fines.pl again, verify the fine hasn't changed
9) Increase the daily fine in issuing rules
10) Run fines.pl again, verify the fine has increased
11) Decrease the daily fine in issuing rules
12) Run fines.pl again, verify the fine has decreased
13) Test dropbox mode
14) Test WhenLostChargeReplacementFee both ways
15) Test RefundLostItemFeeOnReturn both ways
16) Test WhenLostForgiveFine both ways
17) Test CalculateFinesOnReturn both ways

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:12:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:12:21 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-89vL7ErF5J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #646 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37128
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37128&action=edit
Bug 6427 - Update schema files

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:12:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:12:30 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-MwlYyDCGqA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #647 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37129
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37129&action=edit
Bug 6427 - Add new Accounts related Koha modules

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:12:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:12:38 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-8UHLL7jXKD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #648 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37130
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37130&action=edit
Bug 6427 - Update existing Koha perl modules

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:12:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:12:46 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-ORtOgLIizV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #649 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37131
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37131&action=edit
Bug 6427 - Add new TT plugin to deal with currency

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:12:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:12:51 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-4en50voBrO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 37132
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37132&action=edit
Bug 13799: Move and fix unit test file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:12:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:12:57 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-YtlaCcz29p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #650 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37133
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37133&action=edit
Bug 6427 - Add TableTools plugin for DataTables

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:13:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:13:07 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-JFsHdGfB39@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #651 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37134
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37134&action=edit
Bug 6427 - Add new staff scripts for managing accounts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:13:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:13:15 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-8CXC03RzQk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #652 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37135
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37135&action=edit
Bug 6427 - Update existing intranet scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:13:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:13:23 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-pMoMIxlak4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #653 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37136
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37136&action=edit
Bug 6427 - Update OPAC scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:13:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:13:31 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-Pa0Xx01gcw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #654 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37137
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37137&action=edit
Bug 6427 - Add & update cron scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:13:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:13:40 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-P3qO6mGgIw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #655 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37138
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37138&action=edit
Bug 6427 - Delete unused and unnecessary files

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:13:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:13:48 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-oOWts0jY5p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #656 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37139
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37139&action=edit
Bug 6427 - Unit Tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:13:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:13:56 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-LsrsWN96Xq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #657 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37140
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37140&action=edit
Bug 6427 - Make fines tabs link to account payment page

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:14:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:14:04 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-0McpMTIUFN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #658 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37141
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37141&action=edit
Bug 6427 [QA Followup] - Improvements to OPAC view

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:14:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:14:12 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-yQIecIxluA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #659 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37142
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37142&action=edit
Bug 6427 [QA Followup] - Fix accounts table default sorting

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:14:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:14:20 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-LWCBEPK01R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #660 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37143
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37143&action=edit
Bug 6427 [QA Followup] - Drop old accounts tables

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:18:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:18:56 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-Yhsi4ZH00G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am afraid we need a follow up patch with another database update:
- changing the size of the 2 colums like in patch 13379
- changing the shortened codes the correct full length codes

Not sure if there is a better solution, but I don't see one right now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:24:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:24:38 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-sOquGpS0VK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
In the GUI the problem manifests as follows:

- the cancellation reason input field shows "0"
- an entered cancellation reason (free text) saves correctly to the database 
- the entered reason is not shown on the cancelled order line

So basically we are back to as before, with the change that the display is
affected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:27:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:27:46 +0000
Subject: [Koha-bugs] [Bug 11872] Lost overdue items should not generate fines
In-Reply-To: <bug-11872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11872-70-shoBMBp0EU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #21 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Pushed to 3.14, will be in 3.14.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 16:50:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 15:50:03 +0000
Subject: [Koha-bugs] [Bug 3125] IE7-8: Selected columns list in Reports
 Dictionary is not showing column names.
In-Reply-To: <bug-3125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3125-70-qCaeznDyHR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3125

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Thanks for testing Marc!
So closing this one :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:03:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 16:03:43 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-BndhN2SIwM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #31 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37144
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37144&action=edit
Bug 13380: 3.18.x Fix previous DB entry

The DB entry from bug 13379 should have been executed before bug 13380.

The AV category now contain truncated values.

This patch restores the correct category values.
The DB entry from bug 13379 should have been pushed before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:09:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 16:09:18 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-hu8qFOFB50@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36990|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37145
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37145&action=edit
Bug 2542: Validate the amount of a manual invoice/create

If a manual invoice/credit amount is not correctly set, it should not be
accepted.

Test plan:
Try to create a manual invoice and a manual credit with an amount containing
something else than numbers.
It should not be possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:09:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 16:09:55 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-eQYIkm4ZEC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Marc V?ron from comment #4)
> The patch prevents aumount with non-number characters.
> 
> Questions:
> 
> I can enter a negative number. Should that be possible? - It changes an
> invoice to kind of credit.
> 
> Additionally, I can still enter non-number characters in "Create manual
> credit" (and put negative numbers here as well, changing a credit to kind of
> invoice).

Ok both issues should be fixed with this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:17:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 16:17:15 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-Mk2qoapBJi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #32 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 37144
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37144
Bug 13380: 3.18.x Fix previous DB entry

Review of attachment 37144:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13380&attachment=37144)
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +9733,5 @@
>  
> +# IMPORTANT
> +# Here should be DB entry from 13379
> +
> +$DBversion = "3.18.05.001";

Should be 002 of course.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:36:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 16:36:51 +0000
Subject: [Koha-bugs] [Bug 13895] New: Add API routes for issues retrieval
	and renewal
Message-ID: <bug-13895-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

            Bug ID: 13895
           Summary: Add API routes for issues retrieval and renewal
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: new feature
          Priority: P5 - low
         Component: Web services
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Add API routes for issues retrieval and renewal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:41:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 16:41:16 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for issues retrieval and
	renewal
In-Reply-To: <bug-13895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-u2TkpvuR6a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13799

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:41:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 16:41:16 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-FlyQFRoEKI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13895

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:41:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 16:41:41 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for issues retrieval and
	renewal
In-Reply-To: <bug-13895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-mi4AG8ZugK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 37146
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37146&action=edit
Bug 13895: Add API routes for issues retrieval and renewal

GET /borrowers/{borrowernumber}/issues
GET /borrowers/{borrowernumber}/issues/{itemnumber}
PUT /borrowers/{borrowernumber}/issues/{itemnumber}

+ unit tests in t/db_dependent/api/v1/borrowers/issues.t

Test plan:
1/ Go to http://api.yourlibrary/v1/doc and test the above routes with
different values for each parameter
2/ Try to renew the same issue (with PUT) until the maximum number of
renewals is reached (you should have a 403 error then)
3/ Run unit tests in t/db_dependent/api/v1/borrowers/issues.t

Depends on bug 13799

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:41:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 16:41:54 +0000
Subject: [Koha-bugs] [Bug 13895] Add API routes for issues retrieval and
	renewal
In-Reply-To: <bug-13895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-raYKQc3a0v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:46:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 16:46:11 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-oZkiM25gGQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
I did a short test with following line:

my ($results) = Search( $term, $order_by, [ 10 ],'','','start_with' );

This way, the search would be more restricted.

To do a 'contains' search, the user can still use the wildcard character %

'Test' would give
Testmann, Fritz
Tester, Hans

'Hans' would give
Meier, Hans
M?ller, Hansli


'%est' would give
Hatfield, Lester 
Testman, Fritz
Tester, Hans
West, Mae

My proposition is to have the 'start_with' version and change the explanation
from:
Enter patron card number or partial name:
to something like:
Enter first digits/letters of patron card number or name. Prepend % for inline
search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 17:53:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 16:53:16 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-0pU3ynGx6Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm... the actual search matches the text, but the autocomplete is a different
thing... I am not sure about this here. Would be good to test on a big database
maybe. Maybe one of the bigger libraries could weigh in how they expect this to
work?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:42:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:42:15 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-KuwXO5fo1Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37127|0                           |1
        is obsolete|                            |
  Attachment #37128|0                           |1
        is obsolete|                            |
  Attachment #37129|0                           |1
        is obsolete|                            |
  Attachment #37130|0                           |1
        is obsolete|                            |
  Attachment #37131|0                           |1
        is obsolete|                            |
  Attachment #37133|0                           |1
        is obsolete|                            |
  Attachment #37134|0                           |1
        is obsolete|                            |
  Attachment #37135|0                           |1
        is obsolete|                            |
  Attachment #37136|0                           |1
        is obsolete|                            |
  Attachment #37137|0                           |1
        is obsolete|                            |
  Attachment #37138|0                           |1
        is obsolete|                            |
  Attachment #37139|0                           |1
        is obsolete|                            |
  Attachment #37140|0                           |1
        is obsolete|                            |
  Attachment #37141|0                           |1
        is obsolete|                            |
  Attachment #37142|0                           |1
        is obsolete|                            |
  Attachment #37143|0                           |1
        is obsolete|                            |

--- Comment #661 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37147
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37147&action=edit
Bug 6427 - Update database

This patch set re-engineers Koha's accounting system to be faster, more
stable, and have a better historical accounting of fees and payments
while also unifying much of the payment logic and simplifying the code
behind it.

Three new tables have been created:
account_debits stores fines and fees owed by the patron.

account_credits stores payments, write-offs, and other line items that
reduce the amount owed by a patron.

account_offsets stores data about changes to debits and credits,
including which credits paid which debits.

borrowers.account_balance stores the current balance of the
patron, so it does not have to be calculated each time it needs to be
displayed.

issues.issue_id has been added so that individual fines can be directly
linked to the issue that caused them without ambiguity.

The various accounting code strings ( F, FU, Rent, etc ), some of which
have little or no documentation have been replaced by what enumerated
data types which are documented via POD.
There are three, one for each of Debits ( fees/fines ), Credits ( payments ),
and Offsets.

The system continues to allow custom fee types ( moving MANUAL_INV to
MANUAL_DEBIT )
while additionally allowing custom payment types ( MANUAL_CREDIT ).

The system also allows for overpayment, the the outstanding credit being
applied to future fees as they are created.

The system also allows for a librarian to accept a different amount of
money than what is to be paid, and will calculate the change to be
given.

Test Plan:
1) Apply this patch
2) Create some manual fees
3) Test the fee payments
   * Pay one fee
   * Pay multiple fees
   * Make a partial payment
   * Write off a fee
4) View the fees/payments, verify they are correct
5) Check out some items as overdue that should have fines
6) Run fines.pl, verify fines were generated
7) Pay on an accruing fine
8) Run fines.pl again, verify the fine hasn't changed
9) Increase the daily fine in issuing rules
10) Run fines.pl again, verify the fine has increased
11) Decrease the daily fine in issuing rules
12) Run fines.pl again, verify the fine has decreased
13) Test dropbox mode
14) Test WhenLostChargeReplacementFee both ways
15) Test RefundLostItemFeeOnReturn both ways
16) Test WhenLostForgiveFine both ways
17) Test CalculateFinesOnReturn both ways

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:42:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:42:48 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-GQqorIKp8z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #662 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37148
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37148&action=edit
Bug 6427 - Update schema files

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:42:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:42:56 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-l2IsPPv0Cs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #663 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37149
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37149&action=edit
Bug 6427 - Add new Accounts related Koha modules

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:43:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:43:04 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-HRFCPH87f9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #664 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37150
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37150&action=edit
Bug 6427 - Update existing Koha perl modules

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:43:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:43:12 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-ZvHH0A9uqo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #665 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37151
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37151&action=edit
Bug 6427 - Add new TT plugin to deal with currency

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:43:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:43:22 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-ZwPoTdy46V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #666 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37152
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37152&action=edit
Bug 6427 - Add TableTools plugin for DataTables

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:43:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:43:31 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-Ut5E0rqkmS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #667 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37153
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37153&action=edit
Bug 6427 - Add new staff scripts for managing accounts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:43:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:43:39 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-OfvHc7Rxil@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #668 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37154
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37154&action=edit
Bug 6427 - Update existing intranet scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:43:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:43:47 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-DtBduil9Hs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #669 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37155
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37155&action=edit
Bug 6427 - Update OPAC scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:43:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:43:55 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-UZvN44XmS0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #670 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37156
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37156&action=edit
Bug 6427 - Add & update cron scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:44:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:44:04 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-dhoodvOyRw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #671 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37157
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37157&action=edit
Bug 6427 - Delete unused and unnecessary files

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:44:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:44:13 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-BOEfxZ7pk2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #672 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37158
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37158&action=edit
Bug 6427 - Unit Tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:44:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:44:20 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-rUygXJGTay@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #673 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37159
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37159&action=edit
Bug 6427 - Make fines tabs link to account payment page

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:44:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:44:29 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-50lOqedU4n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #674 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37160
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37160&action=edit
Bug 6427 [QA Followup] - Improvements to OPAC view

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:44:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:44:37 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-WjY0S1pJZg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #675 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37161
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37161&action=edit
Bug 6427 [QA Followup] - Fix accounts table default sorting

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 18:44:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 17:44:45 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-RzNam1f53L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #676 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37162
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37162&action=edit
Bug 6427 [QA Followup] - Drop old accounts tables

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 21:51:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 20:51:53 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-oNgnYwgVAj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37163
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37163&action=edit
[master] Bug 13380: Follow-up - only run database update, when it hasn't been
run already

As the ORDER_CANCELLATION_REASON authorised value has been
backported to 3.18.5, we need to make sure that the database
update is only run once.

This patch adds a check for the existance of the authorised
value in order to decide if the databaes update can be run.

To test:
- Create a branch 3.19.00.016
- Make sure you have a few orders where the cancellationreason
  is set (cancel an order, enter a reason)
- Update your branch to master + this patch
- Run the web installer
- ORDER_CANCELLATION_REASON authorised value category is created
- Reset your system preference Version to 3.19.00.015
- Run database update again - no changes are made, all is fine

Or:
- Create a branch 3.18.04 with cancelled orders
- Update to latest 3.18.x
- Make sure ORDER_CANCELLATION_REASON has been created
- Dump database
- Switch to master without this patch
- Run update - verify more O_C_R were created (bad)
- Load database
- Update to master with this patch
- All should be fine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 22:51:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 21:51:08 +0000
Subject: [Koha-bugs] [Bug 13896] New: PID is created in /tmp/ instead of in
 /var/run/koha/...
Message-ID: <bug-13896-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896

            Bug ID: 13896
           Summary: PID is created in /tmp/ instead of in
                    /var/run/koha/...
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: attila at kinali.ch
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

The daemon command uses /tmp/ as default directory for creating pid files
unless the directory has been specified explicitly. This affects only the
debian start scripts. The following patch fixes this

--- a/debian/scripts/koha-start-zebra
+++ b/debian/scripts/koha-start-zebra
@@ -40,6 +40,7 @@ start_zebra_instance()
         "/var/log/koha/$instancename/zebra-output.log"
     daemon \
         --name="$instancename-koha-zebra" \
+        --pidfiles="/var/run/koha/$instancename/" \
         --errlog="/var/log/koha/$instancename/zebra-error.log" \
         --stdout="/var/log/koha/$instancename/zebra.log" \
         --output="/var/log/koha/$instancename/zebra-output.log" \

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 22:51:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 21:51:25 +0000
Subject: [Koha-bugs] [Bug 13896] PID is created in /tmp/ instead of in
	/var/run/koha/...
In-Reply-To: <bug-13896-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13896-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13896-70-Ia3NWdbFJQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896

Attila Kinali <attila at kinali.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.18                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 23:03:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 22:03:07 +0000
Subject: [Koha-bugs] [Bug 13896] PID is created in /tmp/ instead of in
	/var/run/koha/...
In-Reply-To: <bug-13896-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13896-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13896-70-jT0xZduCBh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896

--- Comment #1 from Attila Kinali <attila at kinali.ch> ---
Created attachment 37164
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37164&action=edit
patch

Add patch file as requested by cait

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 23 23:03:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 23 Mar 2015 22:03:30 +0000
Subject: [Koha-bugs] [Bug 13896] PID is created in /tmp/ instead of in
	/var/run/koha/...
In-Reply-To: <bug-13896-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13896-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13896-70-qFlBjoL9eD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896

Attila Kinali <attila at kinali.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 01:40:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 00:40:32 +0000
Subject: [Koha-bugs] [Bug 13897] New: Use XML files for installer data
Message-ID: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

            Bug ID: 13897
           Summary: Use XML files for installer data
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

Installer data on main/marc21/unimarc SQL files is difficult to translate and
is prone to get off-sync with english original

As a way to overcome this problem, I propose to use XML files from which
corresponding SQL and TXT files could be created. 

XML files can be translated in the usual way, and all installer data can be
created/translated before install time.

There will be no need to preserve language folders, except some particular
cases (e.g. NORMARC)

An agreement will be needed for a superset of the all sample data on different
language folders

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 01:40:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 00:40:55 +0000
Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data
In-Reply-To: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-SQbiC2nKiU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 01:51:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 00:51:50 +0000
Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data
In-Reply-To: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-Iyo6n5Y0OS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7939, 10963, 13322

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
I'll make this enh dependent on 7939 10963 13322.

Bug 7939 modifies LangInstaller.pm
Bug 10963 rewrites MARC21 sample bib frameworks, no need to translate them
Bug 13322 updates MARC21 default bib framework

All signed ATM

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 01:51:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 00:51:50 +0000
Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects
In-Reply-To: <bug-7939-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7939-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7939-70-YYZgJNvpwc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13897

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 01:51:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 00:51:50 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-NTtVwrMJNB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13897

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 01:51:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 00:51:50 +0000
Subject: [Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19
	(October 2014)
In-Reply-To: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13322-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13322-70-lWMRgaBM1i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13897

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 02:46:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 01:46:30 +0000
Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data
In-Reply-To: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-qwmGpMTNNc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 37165
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37165&action=edit
Bug 13897 Patchset

Test implementation patchset
Only cover mysql mandatory/optional and marc21 mandatory, just as example

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 07:22:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 06:22:56 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-b3Iuo6Jx0O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Created attachment 37166
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37166&action=edit
[Signed-off] Bug 2542: Validate the amount of a manual invoice/create

If a manual invoice/credit amount is not correctly set, it should not be
accepted.

Test plan:
Try to create a manual invoice and a manual credit with an amount containing
something else than numbers.
It should not be possible.

Followed test plan. Patch behaves OK, including that negative values are not
allowed.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 07:23:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 06:23:12 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-dh3nmGC1E5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37145|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 07:23:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 06:23:23 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-uYZDRtwSoh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 08:15:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 07:15:10 +0000
Subject: [Koha-bugs] [Bug 2635] Adding non-digit chars to cost fields in
 items causes data corruption
In-Reply-To: <bug-2635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2635-70-TwYRyOEwvD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
I think dates should be validated as well. 

With current master (3.19.00.016) it is possible to enter something like
'blablabla' or '2004' in 'd - Date acquired' and 'w - Price effective from'.

Both result to a value '0000-00-00' in the data table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:19:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 08:19:41 +0000
Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing
	label weirdness
In-Reply-To: <bug-13124-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13124-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13124-70-QO4mwP9dUc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #18 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Pushed to 3.14, will be in 3.14.14.

In my opinion, dead code must be removed instead of commented.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:36:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 08:36:30 +0000
Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing
	newlines
In-Reply-To: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11331-70-ZGsHxJMgcM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

--- Comment #16 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Bug 13522 is pushed to master and stable so I close discussion on this bug and
set it back to pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 09:36:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 08:36:41 +0000
Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing
	newlines
In-Reply-To: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11331-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11331-70-rKMLUAALYT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:31:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 09:31:50 +0000
Subject: [Koha-bugs] [Bug 3145] patron templates using poorly named "P" and
	"C" variables
In-Reply-To: <bug-3145-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3145-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3145-70-r3EvSyeCBp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3145

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I have never seen that, it's certainly fixed.

Please reopen if I am wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:49:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 09:49:33 +0000
Subject: [Koha-bugs] [Bug 3309] Deleting authorized values when data exists
In-Reply-To: <bug-3309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3309-70-dtdmjlYVXO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3309

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Mirko Tietgen from comment #1)
> Two things happen:
> - DBD::mysql::st execute failed: Unknown column 'id' in 'where clause' at
> /home/mirko/koha/admin/authorised_values.pl line 228.
> - value is deleted, field shows '-5'
> 
> So there is no routine to check if the value is used and there is something
> wrong with the deletion. The line in referenced in the error message is
> 
> $sth = $dbh->prepare("DELETE FROM authorised_values_branches WHERE id = ?");
> 
> authorised_values_branches does not have a column called 'id', it is called
> 'av_id'

This is fixed by bug 9272, not related to the main problem.

(In reply to Owen Leonard from comment #2)
> (In reply to Mirko Tietgen from comment #1)
> > This seems to still be valid. To reproduce I
> > - added a value to NOT_LOAN: '-5' with value 'fish'
> > - set an item to use that value
> > - deleted the authorizes value.
> 
> I find that this is still the case -- I'm not blocked from deleting an
> authorized value which is in use by an item. However I see no related errors
> in the log.

Not sure how we could fix this problem.
We will need to check all items, it will be time consuming.
But we could imagine a "check" function to know if the AV is used (category
linked to a framework and value in the DB field).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:56:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 09:56:45 +0000
Subject: [Koha-bugs] [Bug 13898] New: Remove unused code in moremember.pl
 related to permission
Message-ID: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

            Bug ID: 13898
           Summary: Remove unused code in moremember.pl related to
                    permission
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:58:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 09:58:08 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-OiEZOPKNpR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:58:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 09:58:11 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-ADiX3pYaGc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37167
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37167&action=edit
Bug 13898: Remove CANDELETEUSER code

This code is never used. The permission to delete a patron is now done
in members-toolbar.inc using CAN_user_borrowers.
It's the good way to do.

Test plan:
  git grep CANDELETEUSER
should not return any result

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:58:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 09:58:58 +0000
Subject: [Koha-bugs] [Bug 5986] Inconsistent handling of patron deletion
	permission
In-Reply-To: <bug-5986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5986-70-RUvFT933qM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5986

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13898

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This is now fixed, the code is not used anymore.
I have submitted a patch on bug 13898 to remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:58:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 09:58:58 +0000
Subject: [Koha-bugs] [Bug 6261] Consolidate patron toolbar include files
In-Reply-To: <bug-6261-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6261-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6261-70-vqF9Q1H3aK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6261
Bug 6261 depends on bug 5986, which changed state.

Bug 5986 Summary: Inconsistent handling of patron deletion permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5986

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 10:58:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 09:58:58 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-MB08sNUFlK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=5986

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:01:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:01:12 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-cyDBWcDdes@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 37168
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37168&action=edit
[Signed-off] Bug 13832 - Missing table header IDs on record holdings table in
OPAC

All but two of the table headers in the item holdings table in the opac have
identifiers. The remaining two should be added so they can be modified easily
with CSS.

Test Plan:
1) Apply this patch
2) View the holdings table for a record
3) Note the new id field for the item holds column
4) Note the new id field for the hold prioirty column ( if enabled )

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:02:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:02:08 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-v7RicA8HJt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #36861|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:02:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:02:18 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-2dKul24903@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:13:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:13:04 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-BBWudPYDAF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 37169
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37169&action=edit
[Signed-off] Bug 13898: Remove CANDELETEUSER code

This code is never used. The permission to delete a patron is now done
in members-toolbar.inc using CAN_user_borrowers.
It's the good way to do.

Test plan:
  git grep CANDELETEUSER
should not return any result

Followed test plan. No CANDELETEUSER found.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:13:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:13:26 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-QgQKdOqOuC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37167|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:13:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:13:43 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-mDIqgLbo1J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:21:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:21:42 +0000
Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search
	- ysearch.pl
In-Reply-To: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13892-70-KX096ws1eY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 37170
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37170&action=edit
[Signed-off] Bug 13892: Make ysearch.pl not using C4::Members::Search

To get rid of SQLHelper, we should not use this C4::Members::Search anymore.

Test plan:
0/ Enable the CircAutocompl pref
1/ Go on the circulation home page, or the reserve page
2/ Search for a patron and wait for the autocompletion box
3/ Confirm there is no regression

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:22:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:22:07 +0000
Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search
	- ysearch.pl
In-Reply-To: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13892-70-UGGfWUVYAH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37125|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:22:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:22:17 +0000
Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search
	- ysearch.pl
In-Reply-To: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13892-70-R7ZwTA7a73@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:27:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:27:12 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-WFwPgbU715@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 37171
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37171&action=edit
[Signed-off] Bug 13894: Make reserve.pl not using C4::Members::Search

Important note: This will modify the UI.
The patron list will now be displayed in a table (instead of a select).

Test plan:
1/ Place a hold on a record
2/ Search for a patron
3/ Select a patron and submit
4/ The hold workflow should continue as previously

No behavior changes should be observed.

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:27:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:27:36 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-o8VHWzghbd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37124|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:27:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:27:45 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-KmpiAg5Dhm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:31:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:31:51 +0000
Subject: [Koha-bugs] [Bug 5553] can click buttons when error appears on circ
In-Reply-To: <bug-5553-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5553-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5553-70-vxsb81IOk3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5553

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Marc V?ron from comment #1)
> Is this still valid?

No, this is fixed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:35:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:35:15 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-3IiVA0eZGJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 37172
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37172&action=edit
Bug 13799: Fix Koha::Objects::find when no results are found

If we pass undef to Koha::Object::_new_from_dbic, it croaks with message
"DBIC result type  isn't of the type Borrower at Koha/Objects.pm"
(in case we're using Koha::Borrowers->find)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:39:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:39:59 +0000
Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a
 basket in a basket group
In-Reply-To: <bug-5365-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5365-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5365-70-Fcgi0kDRfe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Any suggestions on how we could clarify the situation?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:42:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:42:05 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-S71GTFHmSS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
Patch does not apply:

Applying: Bug 13891: DataTables server-side processing - budget users
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
Removing koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudget_user_search.tt
Removing admin/aqbudget_user_search.pl
Applying: Bug 13891: DataTables server-side processing - Serial recipients
Applying: Bug 13891: DataTables server-side processing - patron cards
Applying: Bug 13891: DataTables server-side processing - Fix regressions
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 13891: DataTables server-side processing - Fix
regressions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:42:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:42:32 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-uIbS05HGo0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:45:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:45:11 +0000
Subject: [Koha-bugs] [Bug 5170] budgets not giving user error messages on
	fail
In-Reply-To: <bug-5170-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5170-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5170-70-RowaYLtSet@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5170

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Owen, could you detail what is wrong here?
The dates are mandatory and controlled by the datepicker plugin.
Looks good to me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 11:59:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 10:59:53 +0000
Subject: [Koha-bugs] [Bug 5161] patron attributes clearing if duplicate
	warning
In-Reply-To: <bug-5161-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5161-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5161-70-botWu4OjwO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|patron attributes clearing  |patron attributes clearing
                   |if error                    |if duplicate warning
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Mandatory fields are now checked in JS, but the issue still exists if a
duplicate warning appears.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:00:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 11:00:40 +0000
Subject: [Koha-bugs] [Bug 5060] Quantity change not updating total price
In-Reply-To: <bug-5060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5060-70-xMlDtXXeLw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5060

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:04:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 11:04:10 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-k7dHmWjROW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36884|0                           |1
        is obsolete|                            |

--- Comment #51 from Marc V?ron <veron at veron.ch> ---
Comment on attachment 36884
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36884
Bug 13813 - Remove C4::Dates from members/guarantor_search.pl

Obsoleted because no longer necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:04:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 11:04:20 +0000
Subject: [Koha-bugs] [Bug 13879] DataTables server-side processing for
 patrons - sort is broken
In-Reply-To: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13879-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13879-70-VCMroNSaoy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13891

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:04:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 11:04:20 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-wGbaV7Xk1y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13879
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Marc V?ron from comment #6)

Sorry Marc, I forgot to add the dependency on bug 13879.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:29:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 11:29:09 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-QrBqhZKaan@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:29:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 11:29:11 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-x83ILJT7Qw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37173
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37173&action=edit
Bug 13822 [QA Followup] - Make search do a 'starts with' search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:39:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 11:39:45 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-JPuPdqenIS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:39:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 11:39:49 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-IDiifv4Ftb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37174
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37174&action=edit
Bug 5002: Display messages on adding/deleting patron category

There are no messages on adding and deleting patron category.
If an error occurs and the data is not inserted, the interface does not
alert the user.

This patch adds a message block to alert the user if something wrong
happened.

Test plan:
1/ Create a patron category PATCAT. You should get a confirmation
message.
2/ Try to create another patron category with the same code. You should
get an error message
3/ Delete the patron category PATCAT. You should get a confirmation
message.

Confirm there is no regression on this form (try update an existing
patron category too).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:40:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 11:40:06 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-6VFpowsbTe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 12:44:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 11:44:02 +0000
Subject: [Koha-bugs] [Bug 4936] no way to print from basket screen
In-Reply-To: <bug-4936-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4936-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4936-70-s8KpPdwwKG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4936

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Note that the link exists if the basket group is closed.
And I think there is no point to print it if it's not closed yet, don't you
think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:14:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 12:14:59 +0000
Subject: [Koha-bugs] [Bug 4936] no way to print from basket screen
In-Reply-To: <bug-4936-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4936-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4936-70-okHjRA4IGO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4936

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think when Nicole filed this the link didn't exist from the basket group name
to the basket group. So I'd agree that this is fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:27:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 12:27:10 +0000
Subject: [Koha-bugs] [Bug 4847] Python required for Debian package builds
In-Reply-To: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4847-70-ZjHo5iCoxh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4847

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:27:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 12:27:13 +0000
Subject: [Koha-bugs] [Bug 4847] Python required for Debian package builds
In-Reply-To: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4847-70-tf0Bg6yyWX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4847

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37175
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37175&action=edit
Bug 4847: Remove the python dependency for package builds

The only place python is used is in the debian/bd-to-depends script.
This patch rewrite this script using perl.

Test plan:
The execution of
  debian/bd-to-depends
Should return the same output.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 13:28:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 12:28:39 +0000
Subject: [Koha-bugs] [Bug 4847] Python required for Debian package builds
In-Reply-To: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4847-70-HyHNaxW1AU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4847

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|robin at catalyst.net.nz       |jonathan.druart at biblibre.co
                   |                            |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m, robin at catalyst.net.nz,
                   |                            |tomascohen at gmail.com

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Robin, as the package guru, I really would like to get your opinion on this
patch :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:04:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 13:04:06 +0000
Subject: [Koha-bugs] [Bug 13899] New: Adding misc/devel/coverage.pl,
 a script making a cover on all modules to see which ones are not
 tested yet.
Message-ID: <bug-13899-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899

            Bug ID: 13899
           Summary: Adding misc/devel/coverage.pl, a script making a cover
                    on all modules to see which ones are not tested yet.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: julian.fiol at biblibre.com
          Reporter: julian.fiol at biblibre.com
        QA Contact: gmcharlt at gmail.com

Adding misc/devel/coverage.pl, a script making a cover on all modules to see
which ones are not tested yet.

It uses Devel::Cover

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:07:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 13:07:42 +0000
Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl,
 a script making a cover on all modules to see which ones are not
 tested yet.
In-Reply-To: <bug-13899-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13899-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13899-70-9EYCl9dxFa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899

--- Comment #1 from Julian FIOL <julian.fiol at biblibre.com> ---
Created attachment 37176
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37176&action=edit
Bug 13899 : Adding misc/devel/coverage.pl, a script making a cover on all
modules to see which ones are not tested yet.         It uses Devel::Cover

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:09:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 13:09:11 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-t2mor6mk28@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
Created attachment 37177
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37177&action=edit
[Signed-off] Bug 13822 [QA Followup] - Make search do a 'starts with' search

Search uses now a 'starts with' search. Maxbe an other Sign-off is needed from
a library with a huge number of patrons (see Katrins comment #8)
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:10:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 13:10:09 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-wEfRba4hm1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37173|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:17:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 13:17:10 +0000
Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl,
 a script making a cover on all modules to see which ones are not
 tested yet.
In-Reply-To: <bug-13899-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13899-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13899-70-qDqXPdJ0Im@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899

Julian FIOL <julian.fiol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37176|0                           |1
        is obsolete|                            |

--- Comment #2 from Julian FIOL <julian.fiol at biblibre.com> ---
Created attachment 37178
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37178&action=edit
Bug 13899 : Adding misc/devel/coverage.pl

It's a script making a cover on all modules to see
which ones are not tested yet. It uses Devel::Cover

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:19:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 13:19:02 +0000
Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl,
 a script making a cover on all modules to see which ones are not
 tested yet.
In-Reply-To: <bug-13899-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13899-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13899-70-jHypLATHnI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899

Julian FIOL <julian.fiol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:19:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 13:19:20 +0000
Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl,
 a script making a cover on all modules to see which ones are not
 tested yet.
In-Reply-To: <bug-13899-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13899-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13899-70-yI78DV7JKB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:19:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 13:19:49 +0000
Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t,
 testing all 'borrower' database fields
In-Reply-To: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13882-70-LRT0H9QSG3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:41:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 13:41:26 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-jguItGQDmY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
I have the following problem (tested with adding owner and user to fund and
with routing list, but I thing it will appear at all places):

1) Do a search in the pop-up window
2) The names in the result table are linked to patron's detail page. If you
click on a name, patron's details appear inside this pop-up window, no way
back.

I would expect the names to have no detail link at all OR the link on the names
to behave like the 'Select' link.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 14:52:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 13:52:40 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-8rpn9v9e2Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37163|0                           |1
        is obsolete|                            |

--- Comment #34 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37179
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37179&action=edit
[master] Bug 13380: Follow-up - only run database update, when it hasn't been
run already

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:10:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 14:10:07 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-l62Kve9th8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Marc V?ron from comment #8)
> I have the following problem (tested with adding owner and user to fund and
> with routing list, but I thing it will appear at all places):
> 
> 1) Do a search in the pop-up window
> 2) The names in the result table are linked to patron's detail page. If you
> click on a name, patron's details appear inside this pop-up window, no way
> back.
> 
> I would expect the names to have no detail link at all OR the link on the
> names to behave like the 'Select' link.

I think the links already existed before this patch set. I am not sure removing
them is a good idea.
What did you mean with "behave like the 'Select' link"? Open in a new window?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:33:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 14:33:02 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-EdIG1wGE1l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
Created attachment 37180
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37180&action=edit
No links on patron's names (behaviour without patches)

Hi Jonathan,

Without patches applied the names are not linked.

With "Behave like the select link" I mean that if a link is on the name, it
should select this patron for the fund (or whatever the pop-up was opened for).

But I think it is better to have no links at all on the names, as it was
without patch.

See screenshot in attachment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:44:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 14:44:41 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-K2OaEDOdRJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Marc V?ron from comment #10)
> Created attachment 37180 [details]
> No links on patron's names (behaviour without patches)
> 
> Hi Jonathan,
> 
> Without patches applied the names are not linked.

On the users and owner of a budget, but it is on the order users search :)
So we need to have the same behavior everywhere.

> With "Behave like the select link" I mean that if a link is on the name, it
> should select this patron for the fund (or whatever the pop-up was opened
> for).
> 
> But I think it is better to have no links at all on the names, as it was
> without patch.

I don't have any objection to remove the link but I would prefer to wait for
the QA step before removing it.

If it's your only concern, you can add it as a tester note and let the QAer and
RM take the decision.
I will submit a followup if they agree with you.
Note that it is possible to have a link in a page and not in another one, but
it would be a weird behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:58:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 14:58:25 +0000
Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning
In-Reply-To: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4502-70-OaEjbJSlzi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:58:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 14:58:27 +0000
Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning
In-Reply-To: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4502-70-UnStb46vWb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37181
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37181&action=edit
Bug 4502: Catch software error if no active budget defined

To reproduce:
0/ On a fresh install (so no budget defined), create a budget and don't
mark it as active.
1/ Go on the budget detail page > Plannin > By months
2/ Click on the 'Select' button (on the left)

Without this patch, you get a software error:
  Usage: Date::Calc::Delta_YMD(year1, month1, day1, year2, month2, day2)
With this patch, you get a sweet alert message inviting you to create an
active budget.

Note: This script is a mess...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 15:58:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 14:58:45 +0000
Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning
In-Reply-To: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4502-70-a3j8g6EdV7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
           Severity|major                       |normal
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:02:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:02:06 +0000
Subject: [Koha-bugs] [Bug 4392] bulkmarcimport.pl leaves items.onloan set to
 '0000-00-00' instead of NULL
In-Reply-To: <bug-4392-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4392-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4392-70-xAjWdt5UA3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4392

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Martin, do you know if this is still an issue?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:08:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:08:37 +0000
Subject: [Koha-bugs] [Bug 1558] Initial zebra indexing config broken
In-Reply-To: <bug-1558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-1558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1558-70-ioTmexvuiL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1558

Sunny <rizwanqureshi6 at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rizwanqureshi6 at yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:10:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:10:42 +0000
Subject: [Koha-bugs] [Bug 13900] New: Records are not showing after zebra
	indexing
Message-ID: <bug-13900-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13900

            Bug ID: 13900
           Summary: Records are not showing after zebra  indexing
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: rizwanqureshi6 at yahoo.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

I used batch items modified cataloging. after editing i re build my index. my
records are shown in opac comepletely please guide me...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:15:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:15:11 +0000
Subject: [Koha-bugs] [Bug 4281] reports dictionary limited to only 1 field
In-Reply-To: <bug-4281-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4281-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4281-70-MeybEgcCEL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4281

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:15:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:15:14 +0000
Subject: [Koha-bugs] [Bug 4281] reports dictionary limited to only 1 field
In-Reply-To: <bug-4281-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4281-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4281-70-5Jzqjm465Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4281

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37182
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37182&action=edit
Bug 4281: Reports dictionary supports only 1 field selection

The reports dictionary allows the user to select several fields, but
only 1 is used.
The interface is quite confusing.
This patch removes the multiple selection and permit to select only 1
field.

Test plan:
1/ Create a report dictionary (reports/dictionary.pl)
2/ On the step 3, confirm that only 1 field can be selected

Confirm there is no regression on this tool.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:15:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:15:36 +0000
Subject: [Koha-bugs] [Bug 4281] reports dictionary limited to only 1 field
In-Reply-To: <bug-4281-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4281-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4281-70-lgt58b1sJl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4281

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m, nengard at gmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:25:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:25:21 +0000
Subject: [Koha-bugs] [Bug 4277] budget planning refreshes funny
In-Reply-To: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4277-70-TJsEVDGdX9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4277

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:25:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:25:24 +0000
Subject: [Koha-bugs] [Bug 4277] budget planning refreshes funny
In-Reply-To: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4277-70-rUJrLQ5Wt6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4277

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37183
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37183&action=edit
Bug 4277: Display the correct budget planning after saving

The budget_period_id is not pass to the script, so after saving the
budget planning, the planning for the first active budget is displayed.

Test plan:
1/ Edit a budget planning
2/ Save
3/ You should see the budget planning you were editing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:25:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:25:36 +0000
Subject: [Koha-bugs] [Bug 4277] budget planning refreshes funny
In-Reply-To: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4277-70-ogBWPNcSq1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4277

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:46:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:46:33 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-KgzGogJFaU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #12 from Marc V?ron <veron at veron.ch> ---
Created attachment 37184
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37184&action=edit
[Signed-off] Bug 13891: DataTables server-side processing - budget users

This first patch remove the previous way to search for users to link to
budgets.

Test plan:
1/ Edit or create a fund
2/ Edit the owner of this fund a select a patron
3/ Add 1+ users to the user lists of this fund

Tested together with other patches.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:47:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:47:01 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-sNv0Qhvdt6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37104|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:48:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:48:20 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-tDpEw6bcnu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #13 from Marc V?ron <veron at veron.ch> ---
Created attachment 37185
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37185&action=edit
[Signed-off] Bug 13891: DataTables server-side processing - Serial recipients

This second patch removes the previous way to search for serial recipients.

Test plan:
1/ Edit the routing list for a subscription
(serials/routing.pl?subscriptionid=X)
2/ Add 1+ recipients
3/ Confirm there is no regression on the add/delete/search actions

QA note: This search does not use a clean way to interact with the
window opener. Indeed the opener is reloaded to display the new item.
This patch does not change this behavior, but note the trick in the
template (common/patron_search.tt) to wait for the opener in order not
to get a JS error.
This is also used by the next patch (patron card).

Tested together with other patches.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:48:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:48:42 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-c1ijgBT36P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37105|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:57:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:57:12 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-xqxpmiqfJ8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #14 from Marc V?ron <veron at veron.ch> ---
Created attachment 37186
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37186&action=edit
[Signed-off] Bug 13891: DataTables server-side processing - patron cards

This third patch removes the previous way to search for patron cards users.

Test plan:
1/ Add items to a patron card batch
(patroncards/edit-batch.pl?op=edit&element_id=X)
2/ Add 1+ patrons to the batch
3/ Confirm there is no regression

Tested together with other patches.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:57:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:57:32 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-1KXR2Eu4ih@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37106|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:59:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:59:02 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-D61wAJ4kne@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #15 from Marc V?ron <veron at veron.ch> ---
Created attachment 37187
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37187&action=edit
[Signed-off] Bug 13891: DataTables server-side processing - Fix regressions

This patch fixes the regressions introduced by the previous patches.
If you have tested all in once, you didn't see them.

It introduces library, category and "first letter" filters.

Test plan:
1/ On all pages impacted by previous patches + new order empty (link patron to
an order) + guarantor search
2/ Add / Select patron to the list
3/ Use the filters
4/ Confirm there is no regression

Tested together with other patches.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:59:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:59:28 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-DPZp4i5Zrn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37107|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 16:59:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 15:59:58 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-v9igQMIDvH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:05:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:05:19 +0000
Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work
In-Reply-To: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4137-70-dnyyA9cZpm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:05:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:05:21 +0000
Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work
In-Reply-To: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4137-70-fqAYvZzO3S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37188
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37188&action=edit
Bug 4137: Fix the OPACViewOthersSuggestions behavior

This pref does not work at all, the interface let the user choose to
list all suggestions, but whatever he chooses the suggestion list is the
same.

This patch cleans a bit the suggestedby management.

Test plan:
1/ Enable OPACViewOthersSuggestions
2/ Go at the OPAC and confirm you are able to list all suggestions, even
the ones you don't have created
3/ Disable OPACViewOthersSuggestions
4/ On the same page confirm you are not able to see other suggestions
than yours.

Also test with AnonSuggestions and AnonymousPatron and confirm the
behavior is the one you expected (or not).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:05:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:05:52 +0000
Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work
In-Reply-To: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4137-70-28k6xQqYSf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart at biblibre.co
                   |                            |m
   Patch complexity|---                         |Small patch
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:07:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:07:44 +0000
Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in
	MARC editor
In-Reply-To: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7882-70-NAPFKQuW79@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:13:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:13:09 +0000
Subject: [Koha-bugs] [Bug 4277] budget planning refreshes funny
In-Reply-To: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4277-70-5MQvvUjG2u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4277

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 37189
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37189&action=edit
[Signed-off] Bug 4277: Display the correct budget planning after saving

The budget_period_id is not pass to the script, so after saving the
budget planning, the planning for the first active budget is displayed.

Test plan:
1/ Edit a budget planning
2/ Save
3/ You should see the budget planning you were editing

Patch behaves as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:14:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:14:04 +0000
Subject: [Koha-bugs] [Bug 4277] budget planning refreshes funny
In-Reply-To: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4277-70-YBC3VrLMDG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4277

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37183|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:14:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:14:28 +0000
Subject: [Koha-bugs] [Bug 4277] budget planning refreshes funny
In-Reply-To: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4277-70-JkzWqGE47c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4277

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:18:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:18:23 +0000
Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work
In-Reply-To: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4137-70-TstmHkbqic@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:18:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:18:25 +0000
Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work
In-Reply-To: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4137-70-nZMzwKzqEe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37188|0                           |1
        is obsolete|                            |

--- Comment #7 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37190
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37190&action=edit
Bug 4137: Fix the OPACViewOthersSuggestions behavior

This pref does not work at all, the interface let the user choose to
list all suggestions, but whatever he chooses the suggestion list is the
same.

This patch cleans a bit the suggestedby management.

Test plan:
1/ Enable OPACViewOthersSuggestions
2/ Go at the OPAC and confirm you are able to list all suggestions, even
the ones you don't have created
3/ Disable OPACViewOthersSuggestions
4/ On the same page confirm you are not able to see other suggestions
than yours.

Also test with AnonSuggestions and AnonymousPatron and confirm the
behavior is the one you expected (or not).

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:18:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:18:41 +0000
Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work
In-Reply-To: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4137-70-ovcyloqyMF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

--- Comment #8 from Nicole C. Engard <nengard at gmail.com> ---
Processing files before patches
|========================>| 3 / 3 (100.00%)
Processing files after patches
|========================>| 3 / 3 (100.00%)

 OK    C4/Auth.pm
   OK      critic
   OK      forbidden patterns
   OK      pod
   OK      valid

 OK    opac/opac-suggestions.pl
   OK      critic
   OK      forbidden patterns
   OK      pod
   OK      valid

 OK    koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
   OK      forbidden patterns
   OK      tt_valid
   OK      valid_template

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:20:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:20:34 +0000
Subject: [Koha-bugs] [Bug 13643] Can't subscribe to serial emails anymore
In-Reply-To: <bug-13643-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13643-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13643-70-xGxo07BckN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13643

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #4 from Nicole C. Engard <nengard at gmail.com> ---
Glad it's working

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:33:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:33:42 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-VAHxLb8KO0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:33:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:33:45 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-CafAztSFRT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

--- Comment #19 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37191
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37191&action=edit
Bug 3969: Fix funds search

The funds search does not work at all.
On the budget and the budget plan page, the library dropdown list is
empty.

Test plan:
On the budget, the budget plan and the fund pages, confirm that you are
able to search a fund by code (or name) and the library dropdown list is
correctly filled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:34:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:34:12 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-gx3bocWZg5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 17:51:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 16:51:07 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-UbYPJXW2g0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #20 from Nicole C. Engard <nengard at gmail.com> ---
When you visit the planning page you get this error:


Software error:

syntax error at /home/nengard/kohaclone/admin/aqplan.pl line 420, near
"@hide_cols
    branchloop"
Execution of /home/nengard/kohaclone/admin/aqplan.pl aborted due to compilation
errors.

For help, please send mail to the webmaster (webmaster at koha-vm), giving this
error message and the time and date of the error.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:15:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 17:15:11 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-6oXNB1cG30@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #49 from Marc V?ron <veron at veron.ch> ---
Created attachment 37192
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37192&action=edit
[Signed-off] Bug 13364 - Add a call number browser in item edition page

When editing an item, the call number browser search for existing call number.
If it shows a line is green between two calli numbers, the call numbers
searched is available. If the call number is highlighted in red, it means that
it already exists. This can be used to avoid repeated  call numbers in your
collection.

The call number browser also shows its position relative to the rest of the
collection.

Sponsored-by: CCSR

To test :

                   1) Go to MARC bibliographic framework
                   Home ? Administration ? MARC frameworks
                   2) Click in MARC structure (Default framework)
                   3) Search field 952 and click in subfields
                   4) Edit subfield o (Full call number)
                   5) Click Display more constraints
                   6) In Others Options, Plugin, Choose cn_browser.pl and save
changes
                   7) Search a record and edit its items
                   Validate : three points (?) beside Full call number input
                   8)  Click in ?
                   Validate : if it can not find the given call number, a green
line is shown. Otherwise,  the given call number is highlighted in red.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Magnus <magnus at enger.priv.no>
Works as advertised. QA scripts pass.

Tested together with other patches. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:15:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 17:15:44 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-4N0fdrpwl0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36600|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:17:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 17:17:15 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-YYLiWRzQwk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36601|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:20:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 17:20:27 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-rW89OpBIfq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36601|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:34:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 17:34:42 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-ZUtrCPusq7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #50 from Marc V?ron <veron at veron.ch> ---
Created attachment 37193
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37193&action=edit
[Signed-off] Bug 13364 - fix datatables.inc

http://bugs.koha-community.org/show_bug.cgi?id=13364
Signed-off-by: Magnus <magnus at enger.priv.no>
Works as advertised. QA scripts pass.

Tested together with other patches, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:35:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 17:35:08 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-KIz8lJCiJB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36601|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:36:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 17:36:53 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-4wfYwcqSwQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #51 from Marc V?ron <veron at veron.ch> ---
Created attachment 37194
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37194&action=edit
[Signed-off] Bug 13364 - Add a call number browser in item edition page - QA
fixed

Tested together with other patches.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:37:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 17:37:16 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-L9K4NNee6z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36723|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:38:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 17:38:24 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-ePjD0uQAU7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

--- Comment #52 from Marc V?ron <veron at veron.ch> ---
Created attachment 37195
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37195&action=edit
[Signed-off] Bug 13364 - Add a call number browser in item edition page - QA
fixed II

Tested together with oter patches.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:38:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 17:38:47 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-Z0SmZBUgPL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36782|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 18:39:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 17:39:16 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition
	page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-a5wnxtYOxX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 19:01:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 18:01:09 +0000
Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt
 and serials-recieve.tt
In-Reply-To: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13423-70-cn54dU7J1S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36777|0                           |1
        is obsolete|                            |

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 37196
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37196&action=edit
Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt

This patch removes unused code:
 * barcode_check() function, with untranslatable strings
 * commented call to this function

To test:
1. Apply the patch
2. Check serials receive, no changes shall be detected

http://bugs.koha-community.org/show_bug.cgi?id=13424

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 19:02:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 18:02:07 +0000
Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt
 and serials-recieve.tt
In-Reply-To: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13423-70-udIkoTwJhb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37196|0                           |1
        is obsolete|                            |

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 37197
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37197&action=edit
Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt

This patch removes unused code:
 * barcode_check() function, with untranslatable strings
 * commented call to this function

To test:
1. Apply the patch
2. Check serials receive, no changes shall be detected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 19:02:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 18:02:22 +0000
Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt
 and serials-recieve.tt
In-Reply-To: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13423-70-dJIDN5mojl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 19:54:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 18:54:41 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-FPf5HnMDnw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:35:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 19:35:33 +0000
Subject: [Koha-bugs] [Bug 4936] no way to print from basket screen
In-Reply-To: <bug-4936-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4936-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4936-70-Yf4mzQPcup@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4936

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 20:46:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 19:46:45 +0000
Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to
 control whether patron links go to circ or patron details
In-Reply-To: <bug-7680-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7680-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7680-70-I8dIHztE3e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680

--- Comment #18 from Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> ---
Hi,
I asked two years ago but this bug is still under discussion.
Some news about it?

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 21:04:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 20:04:18 +0000
Subject: [Koha-bugs] [Bug 10319] C4::SocialData is badly named
In-Reply-To: <bug-10319-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10319-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10319-70-bP3dY4Til4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10319

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 21:05:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 20:05:59 +0000
Subject: [Koha-bugs] [Bug 9789] goodreads and librarything in social share
In-Reply-To: <bug-9789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9789-70-s1WgHvpTWe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9789

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 21:19:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 20:19:32 +0000
Subject: [Koha-bugs] [Bug 2601] Order fines by date and time
In-Reply-To: <bug-2601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2601-70-9edbAk4nTU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2601

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 21:25:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 20:25:34 +0000
Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
In-Reply-To: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13381-70-9GJJQr7sT2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 21:37:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 20:37:25 +0000
Subject: [Koha-bugs] [Bug 4277] budget planning refreshes funny
In-Reply-To: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4277-70-HocLCkvq9q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4277

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 21:37:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 20:37:28 +0000
Subject: [Koha-bugs] [Bug 4277] budget planning refreshes funny
In-Reply-To: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4277-70-AvsmvXJKFl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4277

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37189|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37198
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37198&action=edit
[PASSED QA] Bug 4277: Display the correct budget planning after saving

The budget_period_id is not pass to the script, so after saving the
budget planning, the planning for the first active budget is displayed.

Test plan:
1/ Edit a budget planning
2/ Save
3/ You should see the budget planning you were editing

Patch behaves as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Thx!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 22:05:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 21:05:19 +0000
Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work
In-Reply-To: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4137-70-KyeGOtTFvL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

thx a lot for taking a look at those really old bugs!

I have tested this, but it does not seem to work quite right yet:

AnonymousPatron = 5
My user = 1

1) AnonSuggestions = ON
OPACViewOthersSuggestions = OFF
- purchase suggestion shows in OPAC navigation - OK
- purchase suggestion tab is gone from the patron account - NOT OK?
- Although the user is logged in, the suggestion is added to the
AnonymousPatron. This seems not right, I think it should only happen for
borrowers not logged in or the pref needs to be clarified:

Don't allow/allow patrons that aren't logged in to make purchase suggestions.
Suggestions are connected to the AnonymousPatron syspref 

To me the first makes more sense, but maybe there is a need for both?
- allow not logged in users to also make suggestions, treat logged in users
normally
- force all purchase suggestions to be anonymous?

2) AnonSuggestions = OFF
OPACViewOthersSuggestions = ON
Suggestions exist from: 5, 1, 2
- purchase suggestion shows in OPAC navigation - OK
- purchase suggestion tab shows in patron acount - OK
- If you select "Me" the pull down jumps back to "Anyone" after sending the
form - NOT OK

3) AnonSuggestions = ON
OPACViewOthersSuggestions = ON
- purchase suggestion shows in OPAC navigation - OK
- purchase suggestion tab doesn't show in patron account - NOT OK?
- only the anonymous suggestion shows, even after submitting 'anyone' - NOT OK

I think we need to figure out how AnonSuggestions should work first, because
this would also change 3). If it forces all to anonymous intentionally, we
shouldn't show the me/anyone pull down there. If it's a bug, 3) is ok, but we
should create suggestions for logged in users with their borrowernumber.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 22:31:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 21:31:17 +0000
Subject: [Koha-bugs] [Bug 13901] New: sort1 and sort2 not on self
	registration form
Message-ID: <bug-13901-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13901

            Bug ID: 13901
           Summary: sort1 and sort2 not on self registration form
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

For some reason patron fields sort1 and sort2 are not visible via the self
registration form and should be. You can hide them with the system preferences
if you don't want to see them, but all fields should show on the form by
default.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 23:01:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 22:01:14 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-gM03Aba3YW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is all ok, but can you please add matching classes to the <tr> tags like
we have it for the other columns? This way the complete column can be
hidden/influenced with CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 22:47:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 21:47:35 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-gFya3oEHWU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 22:47:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 21:47:05 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-vZzP85d7F8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I was curious, as this code looks basically right, but is not used, as you
pointed out. This is the commit that added it to Koha:
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=05b61e4f3a57828d0bc7d400cfc4bb97c4402a71

It seems to have been broken sometime between 3.10 - 3.12:
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8fd75227fcd87d2cea5d0cb31d7af72498fbb24d;hp=25232635f538ffb5582f56536c242d48f433018b#patch2

I wondered... should we bring it back instead of deleting it? 
I think it would just affect the behaviour for the IndependentBranches (not
being able to delete another branches users).
But I guess in order to make this really work consistently, we'd have to add
this variable to all the .pl scripts on the various pages that show the members
toolbar? This might be the reason why this has been removed in the first place. 

Passing QA... but leaving my notes here :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 22:56:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 21:56:20 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-39hiIwZeyh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Why start with 0, but empty the field, when the fine type is changed?

The 'required' on the field has no effect like this - you can still save 0
value fines and credits if you don't change the fine type but use the
preselected value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 23:00:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 22:00:16 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-jw8odBjWKk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37168|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37200
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37200&action=edit
[PASSED QA] Bug 13832 - Missing table header IDs on record holdings table in
OPAC

All but two of the table headers in the item holdings table in the opac have
identifiers. The remaining two should be added so they can be modified easily
with CSS.

Test Plan:
1) Apply this patch
2) View the holdings table for a record
3) Note the new id field for the item holds column
4) Note the new id field for the hold prioirty column ( if enabled )

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 22:56:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 21:56:54 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-EW54sVj2kK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Was actually watching a coworker running into this problem today... will be
good to see it fixed :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 22:47:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 21:47:38 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-1oToU1omOw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37169|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37199
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37199&action=edit
[PASSED QA] Bug 13898: Remove CANDELETEUSER code

This code is never used. The permission to delete a patron is now done
in members-toolbar.inc using CAN_user_borrowers.
It's the good way to do.

Test plan:
  git grep CANDELETEUSER
should not return any result

Followed test plan. No CANDELETEUSER found.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 23:00:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 22:00:14 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-ESCs4pk70I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 23:05:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 22:05:29 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-aLuogkkzYJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry, missed we already got one... ignore last comment. Time to go to sleep :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 23:40:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 22:40:29 +0000
Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha
In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13696-70-SkTO9YgpNl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am hesitating about adding those without an idea on how we plan to make use
of them. Why are they more free?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 24 23:41:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 22:41:53 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-TYN1HTzo5C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
  Attachment #31210|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 00:00:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 23:00:08 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-9xm839cQQZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 36476
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36476
[SIGNED-OFF] Bug 6934 New report Cash Register Statistics

Review of attachment 36476:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6934&attachment=36476)
-----------------------------------------------------------------

Hi Simith,

I have added a few comments from code review - please fix in a follow-up. I
have only marked the first occurrence of each, please also look below and above
to make sure to get them all. 

Thx!

::: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc
@@ +10,4 @@
>  		<li><a href="/cgi-bin/koha/reports/catalogue_stats.pl">Catalog</a></li>
>  		<li><a href="/cgi-bin/koha/reports/issues_stats.pl">Circulation</a></li>
>          <li><a href="/cgi-bin/koha/reports/serials_stats.pl">Serials</a></li>
> +        <li><a href="/cgi-bin/koha/reports/cash_register_stats.pl">Cash Register</a></li>

Please fix capitalization here and in the other template files to obey our
rules. Thx!

::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
@@ +7,5 @@
> +<script type="text/javascript" src="[% themelang %]/js/datatables.js"></script>
> +<script type="text/javascript" id="js">$(document).ready(function() {
> + $(document).ready(function() {
> +    $("#tbl_cash_register_stats").dataTable($.extend(true, {}, dataTablesDefaults, {
> +        "iDisplayLength": 50

Be careful, without adding a paging option here, the paging on the table is
broken (see recent 'paging' bugs for examples on how to fix)

@@ +143,5 @@
> +                        <option value="F">Fine</option>
> +                        [% END %]
> +
> +                        [% IF transaction_type == "FU" %]
> +                        <option value="FU" selected="selected">Fine - long period</option>

Please check fine descriptions with those in the other templates - I think this
one is not quite right.

@@ +233,5 @@
> +        <thead>
> +        <tr>
> +            <th>Manager name</th>
> +            <th>Borrower cardnumber</th>
> +            <th>Borrower name</th>

Please use patron instead of borrower.

@@ +234,5 @@
> +        <tr>
> +            <th>Manager name</th>
> +            <th>Borrower cardnumber</th>
> +            <th>Borrower name</th>
> +            <th>Branch</th>

Please use library instead of branch.

@@ +240,5 @@
> +            <th>Transaction type</th>
> +            <th>Amount</th>
> +            <th>Biblio title</th>
> +            <th>Barcode</th>
> +            <th>Document type</th>

Please use item type.

::: reports/cash_register_stats.pl
@@ +14,5 @@
> +# with Koha; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> +
> +use strict;
> +use warnings;

Please use Modern::Perl; instead.

@@ +22,5 @@
> +use C4::Reports;
> +use C4::Output;
> +use C4::Koha;
> +use C4::Circulation;
> +use C4::Dates qw/format_date format_date_in_iso/;

Please avoid use of C4::Dates as it's deprecated.

@@ +45,5 @@
> +my $output           = $input->param("output");
> +my $basename         = $input->param("basename");
> +my $transaction_type = $input->param("transaction_type") || 'ACT';
> +my $branchcode       = $input->param("branch") || C4::Context->userenv->{'branch'};
> +our $sep = ",";

I think the separator should not be hardcoded, it would be better to use a pull
down like on the other reports or using the delimiter system preference.

@@ +49,5 @@
> +our $sep = ",";
> +
> +$template->param(
> +    do_it => $do_it,
> +    DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(),

We are no longer using DHTML calendar, please use the TT Dates plugin instead.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 00:00:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 24 Mar 2015 23:00:18 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-f48sF5v74o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 02:37:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 01:37:18 +0000
Subject: [Koha-bugs] [Bug 4847] Python required for Debian package builds
In-Reply-To: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4847-70-prPxxnPYzL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4847

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37175|0                           |1
        is obsolete|                            |

--- Comment #4 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 37201
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37201&action=edit
Bug 4847: Remove the python dependency for package builds

The only place python is used is in the debian/bd-to-depends script.
This patch rewrite this script using perl.

Test plan:
The execution of
  debian/bd-to-depends
Should return the same output.

Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Checked output, built a package, all is happy. Yay for no python!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 02:37:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 01:37:44 +0000
Subject: [Koha-bugs] [Bug 4847] Python required for Debian package builds
In-Reply-To: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4847-70-tIti7BUPlu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4847

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 02:37:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 01:37:53 +0000
Subject: [Koha-bugs] [Bug 4847] Python required for Debian package builds
In-Reply-To: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4847-70-HnwnATROBC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4847

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 04:44:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 03:44:42 +0000
Subject: [Koha-bugs] [Bug 13085] bugfix : tools/export.pl don't works in
 commandline without id_list_file parameter
In-Reply-To: <bug-13085-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13085-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13085-70-gbDcUJgBO0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13085

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com
           Keywords|                            |rel_3_16_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 05:32:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 04:32:00 +0000
Subject: [Koha-bugs] [Bug 13902] New: Add --force option to koha-create and
 koha-remove commands
Message-ID: <bug-13902-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13902

            Bug ID: 13902
           Summary: Add --force option to koha-create and koha-remove
                    commands
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org

Add --force option to koha-create and koha-remove commands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 05:32:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 04:32:18 +0000
Subject: [Koha-bugs] [Bug 13902] Add --force option to koha-create and
 koha-remove commands
In-Reply-To: <bug-13902-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13902-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13902-70-uxra1ECmuO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13902

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 05:46:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 04:46:21 +0000
Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning
In-Reply-To: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4502-70-zIc4IqZhpp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 37181
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37181
Bug 4502: Catch software error if no active budget defined

Review of attachment 37181:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=4502&attachment=37181)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt
@@ +224,5 @@
>  
>  </form>
>  
> +        [% ELSIF not budget_period_id %]
> +<div class="dialog alert">No active budget defined. You should define on before continuing.</div>

"You should define one" -- there is a missing 'e'.
Sign off and post a typo patch? Or will you fix it, and I'll this off?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 05:46:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 04:46:46 +0000
Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha
In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12478-70-Cyg6yLkSDh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #56 from Robin Sheat <robin at catalyst.net.nz> ---
I've rebased the branch on top of current master* and pushed it into the
catalyst repo. This may cause the SearchEngine preference to vanish, if so,
just go and re-set it from the system preferences.

* git can get upset if a file is in the thing you're rebasing onto, but there
are still patches that have to go against it. It ended up grabbing a totally
unrelated file that presumably was the closest match and shoving the patches in
there. That's why there's the occasionally weird touching of
Koha::Template::Plugin::Price.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 06:13:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 05:13:58 +0000
Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning
In-Reply-To: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4502-70-vFjLWaL1Wd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
And yes, this whole section is ugly. HTML is poor. What is the bug number of
the acquisitions re-write? And when might that make it into master?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 07:01:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 06:01:19 +0000
Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha
In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13696-70-zYBPVjSmTd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
License of Glyphicons:
http://glyphicons.com/license/

License of Font-Awesome:
http://fortawesome.github.io/Font-Awesome/license/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 08:03:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 07:03:31 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-A6Arbc29Lg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 08:04:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 07:04:36 +0000
Subject: [Koha-bugs] [Bug 13901] sort1 and sort2 not on self registration
	form
In-Reply-To: <bug-13901-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13901-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13901-70-i2VNNcUPXz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13901

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 08:07:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 07:07:27 +0000
Subject: [Koha-bugs] [Bug 13842] Send payment slip to patron by email
In-Reply-To: <bug-13842-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13842-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13842-70-F7e1Rw8JYr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13842

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:02:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:02:11 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-mKQwudesnj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #3)
> I wondered... should we bring it back instead of deleting it? 

It's not used, so we can delete it.
If the IndependentBranches has to be checked (and I think it should), please
open a new bug report.

But... This exists for 2 years now and it does not seem to affect people.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:07:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:07:16 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-z8trTd4r33@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:07:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:07:19 +0000
Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous
 characters ( e.g. '$' )
In-Reply-To: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2542-70-Iz1uBJSOJN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37202
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37202&action=edit
Bug 2542: Does not empty the amount field when the fine type is changed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:07:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:07:31 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-FD1ij3BMUY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree... also the old code is not clean as it would only cover one page. - So
I passed QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:11:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:11:52 +0000
Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning
In-Reply-To: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4502-70-VoO0HEKpNS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37181|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37203
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37203&action=edit
Bug 4502: Catch software error if no active budget defined

To reproduce:
0/ On a fresh install (so no budget defined), create a budget and don't
mark it as active.
1/ Go on the budget detail page > Plannin > By months
2/ Click on the 'Select' button (on the left)

Without this patch, you get a software error:
  Usage: Date::Calc::Delta_YMD(year1, month1, day1, year2, month2, day2)
With this patch, you get a sweet alert message inviting you to create an
active budget.

Note: This script is a mess...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:15:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:15:50 +0000
Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning
In-Reply-To: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4502-70-0InzHK8Sdr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to M. Tompsett from comment #2)
> Comment on attachment 37181 [details] [review]
> Bug 4502: Catch software error if no active budget defined
> 
> Review of attachment 37181 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt
> @@ +224,5 @@
> >  
> >  </form>
> >  
> > +        [% ELSIF not budget_period_id %]
> > +<div class="dialog alert">No active budget defined. You should define on before continuing.</div>
> 
> "You should define one" -- there is a missing 'e'.

Fixed, thanks.

(In reply to M. Tompsett from comment #3)
> And yes, this whole section is ugly. HTML is poor. What is the bug number of
> the acquisitions re-write? And when might that make it into master?

When you see I need more than 6 months to get the tax rewrite stuffs tested
(not in master), I can't imagine how long a complete module rewrite would take.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:18:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:18:37 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-PxzT4nqRVZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37191|0                           |1
        is obsolete|                            |

--- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37204
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37204&action=edit
Bug 3969: Fix funds search

The funds search does not work at all.
On the budget and the budget plan page, the library dropdown list is
empty.

Test plan:
On the budget, the budget plan and the fund pages, confirm that you are
able to search a fund by code (or name) and the library dropdown list is
correctly filled.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:18:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:18:34 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-r7hj6v79Kt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:19:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:19:19 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-UYTyBoTOvG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

--- Comment #22 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Nicole C. Engard from comment #20)
> When you visit the planning page you get this error:

Sorry Nicole!
I amended my patch with a last minute change, never a good idea...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:20:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:20:17 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-vIdZaSqRne@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:20:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:20:25 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-NDVjqeibps@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:20:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:20:31 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-2YAGBKDbLz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:21:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:21:16 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-HxEBUQh6qE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35696|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:21:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:21:17 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-MNDO9Un3hN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35768|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:21:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:21:19 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-xZuiuW9aj5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35773|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:21:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:21:21 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-VRj4eVUrOW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37144|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:21:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:21:23 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-8vAQgUvK6F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35695|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:21:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:21:49 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-oQU6UMkAdb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Obsoleted the already pushed patches - the last one for master needs QA now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:37:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:37:21 +0000
Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication
	fails
In-Reply-To: <bug-13871-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13871-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13871-70-ZbXoNsn7D3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:43:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:43:08 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-LAmCrKFaBy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:43:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:43:11 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-JlrhO36o7T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37205
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37205&action=edit
Bug 3873: Avoid software error if the cart contains a deleted record

If a record is placed in the basket and deleted, the basket view
exploded with:
Can't use an undefined value as an ARRAY reference at
/home/koha/src/basket/basket.pl line 73.

Test plan:
1/ Add some records to the basket
2/ Delete one of them
3/ Look at your basket
It should not exploded

Note that the number of items in the basket is now wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 09:43:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 08:43:26 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-MeVNgeQmnM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|tomascohen at gmail.com        |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:28:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 09:28:28 +0000
Subject: [Koha-bugs] [Bug 13656] "Change" button for linking a member to an
 organisation not translatable
In-Reply-To: <bug-13656-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13656-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13656-70-vFFYGgA90E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
http://manual.koha-community.org/3.18/en/patscirc.html

Organizational
    Organizational patrons are organizations. Organizations can be used as
guarantors for Professional patrons.

Professional
    Professional patrons can be linked to Organizational patrons

I tested with a School (Category School (SC)) and a Teacher (Category Teacher
(T))

As far as I understand it's the same functionality as for Garantors? - But
there the button seems to translate to "?ndern" in German.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:55:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 09:55:26 +0000
Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data
In-Reply-To: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-iUWwU3FNxA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |z.tajoli at cineca.it

--- Comment #3 from Zeno Tajoli <z.tajoli at cineca.it> ---
Bernardo, can you describe 'the usual way' to transalte  XML files ?
Do you plan to use a .po file ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 10:55:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 09:55:52 +0000
Subject: [Koha-bugs] [Bug 13656] "Change" button for linking a member to an
 organisation not translatable
In-Reply-To: <bug-13656-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13656-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13656-70-eITBPZqF5U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think the untranslated text only appeared after I had linked the
guarantor/parent, but appeared translated in the beginning. I suspected a
Javascript problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:07:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 10:07:39 +0000
Subject: [Koha-bugs] [Bug 12488] bulkmarcimport.pl -d option should use
 DELETE instead of TRUNCATE
In-Reply-To: <bug-12488-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12488-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12488-70-CbIuE3ioWV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488

--- Comment #5 from Magnus Enger <magnus at enger.priv.no> ---
This does the trick for me:

if ($delete) {
        if ($biblios){
        print "deleting biblios\n";
        $dbh->do("DELETE FROM biblio");
        $dbh->do("ALTER TABLE biblio AUTO_INCREMENT = 1");
        $dbh->do("DELETE FROM biblioitems");
        $dbh->do("ALTER TABLE biblioitems AUTO_INCREMENT = 1");
        $dbh->do("DELETE FROM items");
        $dbh->do("ALTER TABLE items AUTO_INCREMENT = 1");
        }
        else {
        print "deleting authorities\n";
        $dbh->do("truncate auth_header");
        }
    $dbh->do("truncate zebraqueue");
}

On an uptodate Debian 7, running MySQL 5.5.41-0+wheezy1-log.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:23:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 10:23:47 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-qeL3HgRiUf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

--- Comment #23 from Marc V?ron <veron at veron.ch> ---
Created attachment 37206
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37206&action=edit
[Signed-off] Bug 3969: Fix funds search

The funds search does not work at all.
On the budget and the budget plan page, the library dropdown list is
empty.

Test plan:
On the budget, the budget plan and the fund pages, confirm that you are
able to search a fund by code (or name) and the library dropdown list is
correctly filled.

Tested with several combinations. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:25:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 10:25:05 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-oL9DJd8I8g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |veron at veron.ch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:25:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 10:25:21 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-iUnPZhddHe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37204|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:35:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 10:35:07 +0000
Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work
In-Reply-To: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4137-70-am17bLUfvO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:35:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 10:35:10 +0000
Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work
In-Reply-To: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4137-70-za8OVzX7E7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37190|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37207
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37207&action=edit
Bug 4137: Fix the OPACViewOthersSuggestions behavior

This pref does not work at all, the interface let the user choose to
list all suggestions, but whatever he chooses the suggestion list is the
same.

This patch cleans a bit the suggestedby management.

There are a lot of cases to test, because linked to 2 prefs:
 AnonSuggestions and OPACViewOthersSuggestions.
1/ AnonSuggestions = 0 and OPACViewOthersSuggestions = 0
  - A non logged in user is not able to purchase a suggestion.
  - A logged in user is not able to see suggestions made by someone else.
2/ AnonSuggestions = 0 and OPACViewOthersSuggestions = 1
  - A non logged in user is not able to purchase a suggestion.
  - A logged in user is able to see suggestions made by someone else.
3/ AnonSuggestions = 1 and OPACViewOthersSuggestions = 0
  - A non logged in user is able to purchase a suggestion.
  The suggestedby field will be filled with the AnonymousPatron pref value.
  He is not able to see suggestions, even the ones made by AnonymousPatron.
  - A logged in user is not able to see suggestions made by someone else.
4/ AnonSuggestions = 1 and OPACViewOthersSuggestions = 1
  - A non logged in user is able to purchase a suggestion.
  He is able to see all suggestions.
  - A logged in user is able to see suggestions made by someone else.

In all cases a logged in user should be able to search for suggestions
(except if he is not able to see them).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:40:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 10:40:18 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-GgJjLOXLq9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 37208
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37208&action=edit
[Signed-off] Bug 3873: Avoid software error if the cart contains a deleted
record

If a record is placed in the basket and deleted, the basket view
exploded with:
Can't use an undefined value as an ARRAY reference at
/home/koha/src/basket/basket.pl line 73.

Test plan:
1/ Add some records to the basket
2/ Delete one of them
3/ Look at your basket
It should not exploded

Note that the number of items in the basket is now wrong.

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:40:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 10:40:48 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-QPDk3AZ1MU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 11:41:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 10:41:05 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-xRjLwaSnsE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37205|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:04:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:04:15 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-LwkICIX3vO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:04:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:04:18 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-f6UVrcBYLd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37209
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37209&action=edit
Bug 3831: Does not allow to delete the FA framework

Test plan:
Go on the MARC framework list view and confirm there is no Delete link
anymore for the FA framework.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:04:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:04:28 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-CT28EsMN6S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|paul.poulain at biblibre.com   |jonathan.druart at biblibre.co
                   |                            |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:10:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:10:19 +0000
Subject: [Koha-bugs] [Bug 12302] OPAC course details not displaying item
 status correctly for itemtypes that are not for loan
In-Reply-To: <bug-12302-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12302-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12302-70-eZGdu11oRz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=3333

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:10:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:10:19 +0000
Subject: [Koha-bugs] [Bug 3333] item status for "not for loan" by item type
 / item is different
In-Reply-To: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3333-70-xnTMjAWow8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3333

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12302,
                   |                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=9253

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:10:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:10:19 +0000
Subject: [Koha-bugs] [Bug 9253] If an item is reserved,
 at the opac it is marked as available
In-Reply-To: <bug-9253-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9253-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9253-70-datHA7Zgb3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=3333

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:16:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:16:53 +0000
Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold
 notifications in patron messaging preferences.
In-Reply-To: <bug-13171-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13171-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13171-70-0hh0rNDNGB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We ran into the same problem: After updating from 3.12.09 to 3.18.5.1 the table
message_transports is missing all entries for the HOLD notice, resulting in the
checkbox missing from the interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:31:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:31:02 +0000
Subject: [Koha-bugs] [Bug 4998] OPAC Browse by Hierarchy fails badly,
 links to old Koha Wiki
In-Reply-To: <bug-4998-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4998-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4998-70-mV17yLfbUN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4998

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |minor
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This can be disabled by the OpacBrowser pref.
To me it's not a bug: You should not put in production a non-configured opac.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:33:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:33:05 +0000
Subject: [Koha-bugs] [Bug 13903] New: Add API routes to list, create, update,
 delete reserves
Message-ID: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

            Bug ID: 13903
           Summary: Add API routes to list, create, update, delete
                    reserves
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 13799

Add API routes to list, create, update, delete reserves

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:33:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:33:05 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-YR2fbc6h5h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13903

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:34:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:34:06 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete reserves
In-Reply-To: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13903-70-z23fRvlASt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 37210
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37210&action=edit
Bug 13903: Add API routes to list, create, update, delete reserves

GET    /borrowers/reserves    (list)
POST   /borrowers/reserves    (create)
PUT    /reserves/{reserve_id} (update)
DELETE /reserves/{reserve_id} (delete)

Unit tests in t/db_dependent/api/v1/borrowers/reserves.t and
t/db_dependent/api/v1/reserves.t

Test plan:
1/ Go to http://api.yourlibrary/v1/doc and test the above routes with
different values for each parameter
2/ Try to make reserves until the maximum number of reserves for a user
is reached (you should have a 403 error then)
3/ Run unit tests

Depends on bug 13799

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:34:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:34:14 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete reserves
In-Reply-To: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13903-70-vBS6LkAcXD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:37:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:37:05 +0000
Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when
 singleBranchMode is enabled
In-Reply-To: <bug-4941-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4941-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4941-70-4wj4x60hiV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
             Status|NEW                         |In Discussion

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Paul Poulain from comment #2)
> Having SingleBranch mode set and more than one branch sounds strange to me.

Same here, what's the point of having this pref enabled if you have more than 1
branch?

(In reply to Ian Walls from comment #1)
> I would contest that we shouldn't HAVE a singleBranchMode system preference.
> Rather, if only one branch is configured in the system, Koha should detect
> that, and not offer branch selection options.

What about this idea? singleBranchMode could be set in Auth.pm and sent to
templates.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:40:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:40:54 +0000
Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when
 singleBranchMode is enabled
In-Reply-To: <bug-4941-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4941-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4941-70-9Wibga65TC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking at the pref or doing a count of the branches in Auth.pm? Trying to
understand :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:45:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:45:39 +0000
Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when
 singleBranchMode is enabled
In-Reply-To: <bug-4941-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4941-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4941-70-qHfqU144FG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #7)
> Looking at the pref or doing a count of the branches in Auth.pm? Trying to
> understand :)

Count the branches from Auth and remove the pref everywhere.
$template->param( singleBranchMode => Koha::Branches->search->count );

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:53:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:53:33 +0000
Subject: [Koha-bugs] [Bug 4274] Cart now requires login before emailing
	contents
In-Reply-To: <bug-4274-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4274-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4274-70-4jrOoXHYBt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:56:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:56:25 +0000
Subject: [Koha-bugs] [Bug 4390] Notices missing fields in menu on left
In-Reply-To: <bug-4390-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4390-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4390-70-YF66hF8x9S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4390

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This should be fixed now.
Please reopen if I am wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 12:57:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 11:57:49 +0000
Subject: [Koha-bugs] [Bug 13212] Use CSS3 ellipsis instead of
	FacetLabelTruncationLength
In-Reply-To: <bug-13212-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13212-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13212-70-cKROz60lqL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13212

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:10:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:10:26 +0000
Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to
 control whether patron links go to circ or patron details
In-Reply-To: <bug-7680-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7680-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7680-70-1HCzFToKx7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680

--- Comment #19 from Owen Leonard <oleonard at myacpl.org> ---
I'm still interested in working on this feature but don't have time for it at
the moment. As far as I'm concerned it's not dead, FWIW.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:13:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:13:10 +0000
Subject: [Koha-bugs] [Bug 6587] Tag moderation lost colors
In-Reply-To: <bug-6587-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6587-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6587-70-dDQMB1Atk3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6587

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=6400

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:13:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:13:10 +0000
Subject: [Koha-bugs] [Bug 6400] Counter broken on tags review page
In-Reply-To: <bug-6400-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6400-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6400-70-SVo8aZLSHz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6400

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=6587
         Resolution|---                         |FIXED

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Fixed by bug 6587.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:38:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:38:01 +0000
Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when
 singleBranchMode is enabled
In-Reply-To: <bug-4941-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4941-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4941-70-e2fTgF5bLV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sounds good to me :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:39:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:39:26 +0000
Subject: [Koha-bugs] [Bug 13904] New: unimarc_field_4XX plugin doesn't
 display volume info, neither link to biblio
Message-ID: <bug-13904-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904

            Bug ID: 13904
           Summary: unimarc_field_4XX plugin doesn't display volume info,
                    neither link to biblio
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: frederic at tamil.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When searching for multivolumes titles, UNIMARC 4xx field plugin displays the
title of the biblios (200$a), without giving info about volumes (200 $h $i).

The displayed title is supposed to link to a biblio record view (MARC /
normal). It doesn't work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:42:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:42:32 +0000
Subject: [Koha-bugs] [Bug 13534] Deleting staff member who moderated a tag
 removes tags imcompletely
In-Reply-To: <bug-13534-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13534-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13534-70-ucyGIb24BB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534

rgravel at marlboro.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rgravel at marlboro.edu

--- Comment #1 from rgravel at marlboro.edu ---
Unfortunately I have no solution to offer on this, however, I wanted to chime
in and remark on how problematic this is for our library in the hope that it
will spark some movement on this! We lost *hundreds* of tags when two staff
member patron accounts were deleted, resulting in a labor-intensive project to
identify the lost tags and to re-tag things. I would love to see a solution
that preserves those tags after folks move on. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:46:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:46:41 +0000
Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected
 tags in the OPAC's "My tags" table
In-Reply-To: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6379-70-UOjgZQVp5B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:46:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:46:43 +0000
Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected
 tags in the OPAC's "My tags" table
In-Reply-To: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6379-70-b8s7PZf2ng@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37211
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37211&action=edit
Bug 6379: Remove link from unapproved tags

At the OPAC, if the tag is not approved, the tag's link did not return
any result.

This patch removes the link.
Test plan:
1/ Set TagsModeration to 'Require'
2/ Create tags at the OPAC
3/ Approve a couple
4/ Confirm that unapproved tags does not have links.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:47:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:47:06 +0000
Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected
 tags in the OPAC's "My tags" table
In-Reply-To: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6379-70-3HmzNvNlpp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:47:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:47:19 +0000
Subject: [Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display
 volume info, neither link to biblio
In-Reply-To: <bug-13904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13904-70-mYD4PRAT8k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904

--- Comment #1 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 37212
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37212&action=edit
Bug 13904 unimarc_field_4XX plugin doesn't display volume info, neither link to
biblio

When searching for multivolumes titles, UNIMARC 4xx field plugin displays the
title of the biblios (200$a), without giving info about volumes (200 $h $i).

The displayed title is supposed to link to a biblio record view (MARC /
normal). It doesn't work.

TO TEST:

- On a UNIMARC Koha, add a new biblio record
- Call the 4XX plugin from 461/463 field
- Search for a biblio record which contains 200$h and/or 200$i subfields.
- You get a result list, with two issues:
  1. $h & $i aren't displayed
  2. Biblio title is not a link
- Apply the patch, and repeat previous steps.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:47:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:47:17 +0000
Subject: [Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display
 volume info, neither link to biblio
In-Reply-To: <bug-13904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13904-70-y46nEnLyVw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:47:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:47:42 +0000
Subject: [Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display
 volume info, neither link to biblio
In-Reply-To: <bug-13904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13904-70-Dzd7PpQoWQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 13:56:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 12:56:06 +0000
Subject: [Koha-bugs] [Bug 6266] Ordering from staged file gives perl error
 when no budget defined
In-Reply-To: <bug-6266-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6266-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6266-70-IeBKgju94w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6266

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
             Status|NEW                         |RESOLVED

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This is fixed, you get 
"You can't create any orders unless you first define a budget and a fund." when
you try to add something to the basket.

Note that you still get the error if you access directly to the url.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:02:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:02:24 +0000
Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click
In-Reply-To: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6178-70-FTp9Ttnxay@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37213
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37213&action=edit
Bug 6178: Display tags from other users in all cases.

At the OPAC, if you click on the "your tags" link, only you tags are
displayed in the tag cloud.

There is no sense to do that, the user's tags are displayed in the table
below.

Test plan:
Confirm that you see all tags in the tag cloud, even if you click on the
"your tags" link.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:02:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:02:21 +0000
Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click
In-Reply-To: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6178-70-Z2td3B02VM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:02:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:02:40 +0000
Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click
In-Reply-To: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6178-70-hmLrlHQxeX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:09:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:09:13 +0000
Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data
In-Reply-To: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-DYQkXAbVjj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Zeno Tajoli from comment #3)
> Bernardo, can you describe 'the usual way' to transalte  XML files ?
> Do you plan to use a .po file ?

Yes, sorry, the plan is to use .po files-

In the patchset I introduce an XML file for each SQL one in common
mandatory/optional and MARC21 mandatory, soon I'll provide for marc21 optional
and hopefully UNIMARC.

I add mysql folders as targets to translation script, so new .po files are
build from XML files, and when we use the translation script it copy all sql
folders and rebuild sql and txt files from translated xml files, to allow an
install with translated values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:45:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:45:36 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-MxMgv5Tg7l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36946|0                           |1
        is obsolete|                            |

--- Comment #8 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 37214
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37214&action=edit
Bug 13383 - RDA: 100/110/111 changes to XSLT

Test plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 100,110,111
4) Perform an opac search that would show the record in the search results.
5) Click title to review record.
6) Note the fields updates 100,110,111 to show subfields a,b,c,d,q and
t.Multiple fields are separated by span class=separator |.
7) Repeat steps 4 - 6 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:49:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:49:25 +0000
Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking
 because of case insensitive utf8 collation
In-Reply-To: <bug-13810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13810-70-EWG85Ky8Vc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Quite worried about this one as we are also using upper case subfields in some
cases (running out of item subfields). Is there a way to fix this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:49:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:49:41 +0000
Subject: [Koha-bugs] [Bug 13905] New: Wrapping DBIx count inside Koha Object
Message-ID: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13905

            Bug ID: 13905
           Summary: Wrapping DBIx count inside Koha Object
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org

DBIx::Class::ResultSet has a handy method count() to see how many results this
prepared ResultSet would return.

This is hidden by the Koha::Object.

This patch adds a wrapper for the count() method inside the Koha::Object, so it
is nicely available for all subclasses.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:50:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:50:22 +0000
Subject: [Koha-bugs] [Bug 13905] Wrapping DBIx count inside Koha Object
In-Reply-To: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13905-70-7OCjf2EPCC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13905

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 37215
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37215&action=edit
Bug 13905 - Wrapping DBIx count inside Koha Object

DBIx::Class::ResultSet has a handy method count() to see how many results this
prepared ResultSet would return.

This is hidden by the Koha::Object.

This patch adds a wrapper for the count() method inside the Koha::Object, so it
is nicely available for all subclasses.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:51:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:51:03 +0000
Subject: [Koha-bugs] [Bug 13905] Wrapping DBIx count inside Koha Object
In-Reply-To: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13905-70-RuE67gL5Hm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13905

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:52:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:52:08 +0000
Subject: [Koha-bugs] [Bug 13905] Wrapping DBIx count inside Koha Object
In-Reply-To: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13905-70-jQ1QIoqoun@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13905

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:56:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:56:27 +0000
Subject: [Koha-bugs] [Bug 13906] New: TestObjectFactory(ies) for Koha
 objects. Enable easy Test object creation from HASHes or from preconfigured
 test groups.
Message-ID: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

            Bug ID: 13906
           Summary: TestObjectFactory(ies) for Koha objects. Enable easy
                    Test object creation from HASHes or from preconfigured
                    test groups.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:57:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:57:42 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13906-70-vScKQcSRFI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 37216
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37216&action=edit
Bug 13906 - TestObjectFactory(ies) for Koha objects. Enable easy Test object
creation from HASHes or from preconfigured test groups.

In discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:58:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:58:03 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13906-70-bPNaMFohIj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 14:58:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 13:58:13 +0000
Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects.
 Enable easy Test object creation from HASHes or from preconfigured test
 groups.
In-Reply-To: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13906-70-fir0KkMALL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:03:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:03:02 +0000
Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in
	XSLT
In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13387-70-YeI6Mrd7me@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36903|0                           |1
        is obsolete|                            |

--- Comment #6 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 37217
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37217&action=edit
Bug 13387 - Uniform titles (130 / 240 / 730) Display in XSLT

Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 130/240/730
4) Perform an opac search that would show the record in the search results.
5) Click title to review record.
6) Fields show subfields a,b,c,k,n,p,s with multiple fields separated by span
class=separator |
7) Repeat steps 4 - 6 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:03:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:03:55 +0000
Subject: [Koha-bugs] [Bug 13905] Wrapping DBIx count inside Koha Object
In-Reply-To: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13905-70-BZuri5RDws@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13905

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:04:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:04:21 +0000
Subject: [Koha-bugs] [Bug 13905] Wrapping DBIx count inside Koha Object
In-Reply-To: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13905-70-grx95Gwbev@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13905

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |olli-antti.kivilahti at jns.fi
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:06:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:06:09 +0000
Subject: [Koha-bugs] [Bug 13905] Wrapping DBIx count inside Koha Object
In-Reply-To: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13905-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13905-70-IeImP26Sa5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13905

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|In Discussion               |RESOLVED

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
count() is already in Koha::Objects

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:09:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:09:20 +0000
Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer
 - dev installations
In-Reply-To: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13876-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13876-70-JOQAsoFP0E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
What's the point of the suffix?
Now the log filename is updatedatabase_2015-03-25T15:06:59_uyj4.log
Your patch does not call the tempdir subroutine, you should modify the use
File::Temp line:
   10 use File::Temp qw( tempdir );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:10:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:10:32 +0000
Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs
In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13734-70-dVBR1LKy2D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36920|0                           |1
        is obsolete|                            |

--- Comment #9 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 37218
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37218&action=edit
Bug 13734 - RDA: Display 33xs

Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 700,710,711
4) Perform an opac search that would show the record in the search results.
5) Click title to review record.
6) Adds fields 336, 337 and 338 to staff and opac details
7) Repeat steps 4 - 6 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:12:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:12:53 +0000
Subject: [Koha-bugs] [Bug 6079] Single parentheses in currency causes order
 to fail when updating
In-Reply-To: <bug-6079-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6079-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6079-70-zlPiSeYtr3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6079

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Should be fixed with the following patch:

diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
index 0bb34c6..320169a 100644
--- a/C4/Acquisition.pm
+++ b/C4/Acquisition.pm
@@ -1269,7 +1269,7 @@ sub ModOrder {
     foreach my $orderinfokey (grep(!/ordernumber/, keys %$orderinfo)){
         # ... and skip hash entries that are not in the aqorders table
         # FIXME : probably not the best way to do it (would be better to have
a correct hash)
-        next unless grep(/^$orderinfokey$/, @$colnames);
+        next unless grep(/^\Q$orderinfokey\E$/, @$colnames);
             $query .= "$orderinfokey=?, ";
             push(@params, $orderinfo->{$orderinfokey});
     }

But not sure of the consequences...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:29:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:29:16 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-HDdYxgSl4O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #120 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Srdjan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:29:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:29:54 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-MaZL5PjQ3i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Gracias Hector!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:30:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:30:22 +0000
Subject: [Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
In-Reply-To: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13878-70-N3LFQ2Gm3o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Gracias Hector!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:30:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:30:58 +0000
Subject: [Koha-bugs] [Bug 4847] Python required for Debian package builds
In-Reply-To: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4847-70-YEaElnigBP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4847

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

I love this one Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:31:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:31:19 +0000
Subject: [Koha-bugs] [Bug 13907] New: Error creating users and categories
Message-ID: <bug-13907-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13907

            Bug ID: 13907
           Summary: Error creating users and categories
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: isabelaterra at cp2.g12.br
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To complete the form and send the message that "user does not exist", the id in
the url appears 0 and the same thing occurs when registering a category.

Anyone has experienced the same problem?

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:31:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:31:24 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-dGZAd2upTh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks ByWaterians!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:31:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:31:50 +0000
Subject: [Koha-bugs] [Bug 13856] Hard to translate strings on patron search
	results page
In-Reply-To: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13856-70-1wR0eERqFx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13856

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Nice catch Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:32:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:32:15 +0000
Subject: [Koha-bugs] [Bug 13818] Editing and saving a course reserve
 displays the add item form
In-Reply-To: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13818-70-4uvQzcg3u8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13818

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:32:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:32:43 +0000
Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee!
In-Reply-To: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12820-70-B1k7cGMcu6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks for making SIP support better Colin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:33:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:33:10 +0000
Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data
In-Reply-To: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-SsJpfcPN0u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #5 from Zeno Tajoli <z.tajoli at cineca.it> ---
I suggest to put .po file in a different git server, to limit the growth of
general git archive.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:33:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:33:37 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-kpnCue81ze@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:35:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:35:47 +0000
Subject: [Koha-bugs] [Bug 13472] Chapter 14.1 Plugin System : Setup
 instructions are wrong
In-Reply-To: <bug-13472-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13472-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13472-70-GTH1HLXoD0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13472

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
This is all done.

Thanks
Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:36:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:36:09 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-GEx0dzAAsg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Oh, there are more Softwre errors if you 

- try to send the basket:
Can't use an undefined value as an ARRAY reference at
/usr/share/kohaclone/basket/sendbasket.pl line 83.

- try to download as ISO2709:
Can't call method "as_usmarc" on an undefined value at
/usr/share/kohaclone/basket/downloadcart.pl line 71.

- try to download as RIS:
An error has occurred!
Error 500

- try to download as Bibtex
Can't call method "subfield" on an undefined value at
/usr/share/kohaclone/C4/Record.pm line 658.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:45:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:45:55 +0000
Subject: [Koha-bugs] [Bug 13462] I18N system preferences
 language/opaclanguages descriptions need an update
In-Reply-To: <bug-13462-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13462-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13462-70-McBUMSvVTS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13462

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
This is fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 15:58:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 14:58:01 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-9EVCkYImyi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37219
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37219&action=edit
Bug 3873: follow-up for all other pages

This should fix the issue on other pages.

Test plan:
Try to download and export the basket (intranet+opac sides).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:03:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:03:52 +0000
Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics
In-Reply-To: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6934-70-p39vaoe7uL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:06:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:06:35 +0000
Subject: [Koha-bugs] [Bug 6059] Problem with changing quantity on uncertain
	prices list
In-Reply-To: <bug-6059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6059-70-g2Bf1ysQbQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Not sure to know what is the expected behavior here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:07:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:07:05 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-ucseSFaAd5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Created attachment 37220
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37220&action=edit
[Signed-off] Bug 3873: follow-up for all other pages

This should fix the issue on other pages.

Test plan:
Try to download and export the basket (intranet+opac sides).

Re-tested for errors in comment #5, they do not longer appear.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:07:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:07:33 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-qIBgN4TE0C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37219|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:14:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:14:51 +0000
Subject: [Koha-bugs] [Bug 6059] Problem with changing quantity on uncertain
	prices list
In-Reply-To: <bug-6059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6059-70-4EJKwWFv0o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, I think it should not be possible to edit the quantity when items
are created 'on order' - because it won't create the items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:19:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:19:11 +0000
Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click
In-Reply-To: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6178-70-3Or1k3qfgu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178

--- Comment #12 from Marc V?ron <veron at veron.ch> ---
Created attachment 37221
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37221&action=edit
[Signed-off] Bug 6178: Display tags from other users in all cases.

At the OPAC, if you click on the "your tags" link, only you tags are
displayed in the tag cloud.

There is no sense to do that, the user's tags are displayed in the table
below.

Test plan:
Confirm that you see all tags in the tag cloud, even if you click on the
"your tags" link.

Patch behaves as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:19:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:19:33 +0000
Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click
In-Reply-To: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6178-70-47DGkhxpOr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37213|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:29:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:29:41 +0000
Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected
 tags in the OPAC's "My tags" table
In-Reply-To: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6379-70-vb2DRAdKYJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 37222
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37222&action=edit
[Signed-off] Bug 6379: Remove link from unapproved tags

At the OPAC, if the tag is not approved, the tag's link did not return
any result.

This patch removes the link.
Test plan:
1/ Set TagsModeration to 'Require'
2/ Create tags at the OPAC
3/ Approve a couple
4/ Confirm that unapproved tags does not have links.

Works as expected. Unapproved tags in column 'Terms' are not linked and are
marked with (not approved)
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:30:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:30:00 +0000
Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected
 tags in the OPAC's "My tags" table
In-Reply-To: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6379-70-gBYCiXL6aR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37211|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:30:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:30:15 +0000
Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected
 tags in the OPAC's "My tags" table
In-Reply-To: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6379-70-5YpSvLSPXV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:30:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:30:32 +0000
Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click
In-Reply-To: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6178-70-rqOudsmG4R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:30:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:30:44 +0000
Subject: [Koha-bugs] [Bug 13908] New: Checkouts table sorting is not
 honoring default sort preferences
Message-ID: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908

            Bug ID: 13908
           Summary: Checkouts table sorting is not honoring default sort
                    preferences
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The checkouts table no longer honors the system preferences
todaysIssuesDefaultSortOrder and previousIssuesDefaultSortOrder.

This causes much frustration for librarians who prefer a different sort order.
In particular, many librarians prefer to see the oldest previous issues at the
top of the list so those overdue items are visible "above the fold".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:33:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:33:46 +0000
Subject: [Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring
 default sort preferences
In-Reply-To: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13908-70-rYDsSOKFuT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:35:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:35:23 +0000
Subject: [Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring
 default sort preferences
In-Reply-To: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13908-70-PnaR3bKsL4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:35:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:35:25 +0000
Subject: [Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring
 default sort preferences
In-Reply-To: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13908-70-qlTlnN7aI5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37223
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37223&action=edit
Bug 13908 - Checkouts table sorting is not honoring default sort preferences

The checkouts table no longer honors the system preferences
todaysIssuesDefaultSortOrder and previousIssuesDefaultSortOrder.

This causes much frustration for librarians who prefer a different sort
order. In particular, many librarians prefer to see the oldest previous
issues at the top of the list so those overdue items are visible "above
the fold".

Test Plan:
1) Apply this patch
2) Find a patron with many previous checkouts due on different days
3) Try all 4 combinations of todaysIssuesDefaultSortOrder and
previousIssuesDefaultSortOrder
4) Note they all sort correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:35:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:35:45 +0000
Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected
 tags in the OPAC's "My tags" table
In-Reply-To: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6379-70-2MphVTHtSw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:36:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:36:10 +0000
Subject: [Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring
 default sort preferences
In-Reply-To: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13908-70-RwNaBsLGUE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37223|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37224
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37224&action=edit
Bug 13908 - Checkouts table sorting is not honoring default sort preferences

The checkouts table no longer honors the system preferences
todaysIssuesDefaultSortOrder and previousIssuesDefaultSortOrder.

This causes much frustration for librarians who prefer a different sort
order. In particular, many librarians prefer to see the oldest previous
issues at the top of the list so those overdue items are visible "above
the fold".

Test Plan:
1) Apply this patch
2) Find a patron with many previous checkouts due on different days
3) Try all 4 combinations of todaysIssuesDefaultSortOrder and
previousIssuesDefaultSortOrder
4) Note they all sort correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:38:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:38:34 +0000
Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle
 don't consider hold policy by item type
In-Reply-To: <bug-13687-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13687-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13687-70-oAMMYGatmy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Patch doesn't apply

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
The patch doesn't apply. Please consider taking a look at bug 5786 on rebasing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 16:56:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 15:56:36 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-HCkbuMtTVV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:04:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 16:04:57 +0000
Subject: [Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring
 default sort preferences
In-Reply-To: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13908-70-qMYQHBMIfc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37224|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37225
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37225&action=edit
Bug 13908 - Checkouts table sorting is not honoring default sort preferences

The checkouts table no longer honors the system preferences
todaysIssuesDefaultSortOrder and previousIssuesDefaultSortOrder.

This causes much frustration for librarians who prefer a different sort
order. In particular, many librarians prefer to see the oldest previous
issues at the top of the list so those overdue items are visible "above
the fold".

Test Plan:
1) Apply this patch
2) Find a patron with many previous checkouts due on different days
3) Try all 4 combinations of todaysIssuesDefaultSortOrder and
previousIssuesDefaultSortOrder
4) Note they all sort correctly

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:04:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 16:04:55 +0000
Subject: [Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring
 default sort preferences
In-Reply-To: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13908-70-Gzw99vgHOx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:06:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 16:06:46 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-tKB37BjBzH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

--- Comment #6 from Marc V?ron <veron at veron.ch> ---
Created attachment 37226
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37226&action=edit
[Signed-off] Bug 5002: Display messages on adding/deleting patron category

There are no messages on adding and deleting patron category.
If an error occurs and the data is not inserted, the interface does not
alert the user.

This patch adds a message block to alert the user if something wrong
happened.

Test plan:
1/ Create a patron category PATCAT. You should get a confirmation
message.
2/ Try to create another patron category with the same code. You should
get an error message
3/ Delete the patron category PATCAT. You should get a confirmation
message.

Confirm there is no regression on this form (try update an existing
patron category too).

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:07:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 16:07:00 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-n8uq23Jnv7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37174|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:20:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 16:20:29 +0000
Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from
	system
In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13813-70-QD66avDiHX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36894|0                           |1
        is obsolete|                            |

--- Comment #52 from Marc V?ron <veron at veron.ch> ---
Created attachment 37227
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37227&action=edit
Bug 13813 - Remove C4::Dates from reserve/request.pl

To test:
Apply patch
Search a biblio in staff client and place hold. This will take you to
reserve/request.pl
Add / Suspend / Unsuspend / hold(s)
Verify that all dates behave and display OK

Retested after 3-way-merge. / MV

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 17:49:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 16:49:46 +0000
Subject: [Koha-bugs] [Bug 7910] Batch renewal of serials and order creation
In-Reply-To: <bug-7910-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7910-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7910-70-5WlfUu0124@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It would be nice to see this moving again. A better integration of serials and
acquisition would be great.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 18:57:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 17:57:22 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-20H8BLPv28@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 18:58:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 17:58:35 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete reserves
In-Reply-To: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13903-70-NO1EvvEhJe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi there, just wondering: should we use holds instead of reserves? Reserves is
in the code, but all the gui uses the term holds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:08:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:08:49 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-OTvSajX2e5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #121 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I uggest updating this to 'new feature' as it's going to be a nice highlight in
the umcoming release :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:13:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:13:31 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-i5rIUX7uUv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:19:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:19:50 +0000
Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
In-Reply-To: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13381-70-DWImvM2ux7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:19:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:19:53 +0000
Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
In-Reply-To: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13381-70-sa20KnmYK9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37070|0                           |1
        is obsolete|                            |

--- Comment #27 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37228
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37228&action=edit
[SIGNED OFF] Bug 13381 - RDA: 245 field changes in XSLT

This patch updates the display of the title and statement of responsibility in
the
XSLT display in the staff and OPAC.

Display includes subfields a,b,c,h,k,n,p,s
Subfield c is wrapped in a span class=title_resp_stmt for easy suppression via
css.
Subfield h is wrapped in a span class=title_medium for easy suppression via
css.

To test:

* Search the opac
* Click the title
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:52:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:52:12 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-ycGV1eUO84@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37147|0                           |1
        is obsolete|                            |
  Attachment #37148|0                           |1
        is obsolete|                            |
  Attachment #37149|0                           |1
        is obsolete|                            |
  Attachment #37150|0                           |1
        is obsolete|                            |
  Attachment #37151|0                           |1
        is obsolete|                            |
  Attachment #37152|0                           |1
        is obsolete|                            |
  Attachment #37153|0                           |1
        is obsolete|                            |
  Attachment #37154|0                           |1
        is obsolete|                            |
  Attachment #37155|0                           |1
        is obsolete|                            |
  Attachment #37156|0                           |1
        is obsolete|                            |
  Attachment #37157|0                           |1
        is obsolete|                            |
  Attachment #37158|0                           |1
        is obsolete|                            |
  Attachment #37159|0                           |1
        is obsolete|                            |
  Attachment #37160|0                           |1
        is obsolete|                            |
  Attachment #37161|0                           |1
        is obsolete|                            |
  Attachment #37162|0                           |1
        is obsolete|                            |

--- Comment #677 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37229
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37229&action=edit
Bug 6427 - Update database

This patch set re-engineers Koha's accounting system to be faster, more
stable, and have a better historical accounting of fees and payments
while also unifying much of the payment logic and simplifying the code
behind it.

Three new tables have been created:
account_debits stores fines and fees owed by the patron.

account_credits stores payments, write-offs, and other line items that
reduce the amount owed by a patron.

account_offsets stores data about changes to debits and credits,
including which credits paid which debits.

borrowers.account_balance stores the current balance of the
patron, so it does not have to be calculated each time it needs to be
displayed.

issues.issue_id has been added so that individual fines can be directly
linked to the issue that caused them without ambiguity.

The various accounting code strings ( F, FU, Rent, etc ), some of which
have little or no documentation have been replaced by what enumerated
data types which are documented via POD.
There are three, one for each of Debits ( fees/fines ), Credits ( payments ),
and Offsets.

The system continues to allow custom fee types ( moving MANUAL_INV to
MANUAL_DEBIT )
while additionally allowing custom payment types ( MANUAL_CREDIT ).

The system also allows for overpayment, the the outstanding credit being
applied to future fees as they are created.

The system also allows for a librarian to accept a different amount of
money than what is to be paid, and will calculate the change to be
given.

Test Plan:
1) Apply this patch
2) Create some manual fees
3) Test the fee payments
   * Pay one fee
   * Pay multiple fees
   * Make a partial payment
   * Write off a fee
4) View the fees/payments, verify they are correct
5) Check out some items as overdue that should have fines
6) Run fines.pl, verify fines were generated
7) Pay on an accruing fine
8) Run fines.pl again, verify the fine hasn't changed
9) Increase the daily fine in issuing rules
10) Run fines.pl again, verify the fine has increased
11) Decrease the daily fine in issuing rules
12) Run fines.pl again, verify the fine has decreased
13) Test dropbox mode
14) Test WhenLostChargeReplacementFee both ways
15) Test RefundLostItemFeeOnReturn both ways
16) Test WhenLostForgiveFine both ways
17) Test CalculateFinesOnReturn both ways

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:52:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:52:33 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-XZYcwjshm8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #678 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37230
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37230&action=edit
Bug 6427 - Update schema files

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:52:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:52:41 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-HxJlUDkGiV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #679 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37231
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37231&action=edit
Bug 6427 - Add new Accounts related Koha modules

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:52:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:52:50 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-UDWRD1yuke@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #680 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37232
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37232&action=edit
Bug 6427 - Update existing Koha perl modules

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:52:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:52:58 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-2gSIjVsJ5I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #681 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37233
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37233&action=edit
Bug 6427 - Add new TT plugin to deal with currency

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:53:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:53:09 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-5WtoZWyVpL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #682 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37234
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37234&action=edit
Bug 6427 - Add TableTools plugin for DataTables

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:53:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:53:18 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-GFMf3mrcuN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #683 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37235
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37235&action=edit
Bug 6427 - Add new staff scripts for managing accounts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:53:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:53:26 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-krOU40mq5X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #684 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37236
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37236&action=edit
Bug 6427 - Update existing intranet scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:53:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:53:35 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-WJxfREVuu7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #685 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37237
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37237&action=edit
Bug 6427 - Update OPAC scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:53:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:53:43 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-SxNFi3J47Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #686 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37238
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37238&action=edit
Bug 6427 - Add & update cron scripts

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:53:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:53:52 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-mWmBRVoMcx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #687 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37239
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37239&action=edit
Bug 6427 - Delete unused and unnecessary files

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:54:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:54:00 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-jxSrHvmNde@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #688 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37240
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37240&action=edit
Bug 6427 - Unit Tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:54:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:54:08 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-4xNZgLuDWa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #689 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37241
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37241&action=edit
Bug 6427 - Make fines tabs link to account payment page

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm at pascolibraries.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:54:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:54:17 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-VV9C6b5LmZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #690 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37242
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37242&action=edit
Bug 6427 [QA Followup] - Improvements to OPAC view

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:54:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:54:25 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-D8UWuz9kEV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #691 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37243
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37243&action=edit
Bug 6427 [QA Followup] - Fix accounts table default sorting

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 19:54:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 18:54:33 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-AuhQb2qZum@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #692 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37244
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37244&action=edit
Bug 6427 [QA Followup] - Drop old accounts tables

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:04:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 19:04:26 +0000
Subject: [Koha-bugs] [Bug 13909] New: _debar_user_on_return doesn't honour
	finesCalendar
Message-ID: <bug-13909-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909

            Bug ID: 13909
           Summary: _debar_user_on_return doesn't honour finesCalendar
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The routine should be using C4::Overdues::_get_chargeable_units instead of an
ad-hoc calculation of the overdue days to use as basis for the calculatio here:


    my $calendar = Koha::Calendar->new( branchcode => $branchcode );

    # $deltadays is a DateTime::Duration object
    my $deltadays = $calendar->days_between( $dt_due, $dt_today );

To reproduce:
- Set finesCalendar = "directly"
- Have a circulation rule stating:
  interval for calculating fines = 1
  suspension days = 3
- Have the calendar set for sunday and saturday as holidays.
- Checkout an item with a branch/itype/borrower category that matches the
defined circ rule with a hand-writen due date to (say) last friday.
- Check the item in
=> FAIL: Notice that the user is debarred using the calendar (skipping saturday
and sunday).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:20:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 19:20:36 +0000
Subject: [Koha-bugs] [Bug 8055] reversing fines wonky
In-Reply-To: <bug-8055-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8055-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8055-70-6mQXYXJQkQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8055

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:23:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 19:23:32 +0000
Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
In-Reply-To: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13382-70-uBXCTxMRfo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #27 from Nick Clemens <nick at quecheelibrary.org> ---
Trying to check everything this time around, here are the few things I see:

1 - For related or contained works subfields n & p are not displaying
2 - 710/711 with subfield i appear in Contributors and not Related Works
3 - 710/711 with subfield i and 2nd indicator 2 do not appear

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:25:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 19:25:01 +0000
Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
In-Reply-To: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13382-70-n73akwkJcz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #28 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37245
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37245&action=edit
Smaple record to see all fields

This is just a sample record I used to put data into all the fields touched by
this bug, it is not properly formatted but is helpful for testing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:25:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 19:25:29 +0000
Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
In-Reply-To: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13382-70-j788lnwKNu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:27:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 19:27:53 +0000
Subject: [Koha-bugs] [Bug 8055] reversing fines wonky
In-Reply-To: <bug-8055-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8055-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8055-70-jwfkmpbMXP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8055

--- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> ---
Hi, i have the same problem.

When I make a partial payment of a fine and then I make the reverse of this
payment, the amount is given credit in the account.

See the video attached.

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:28:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 19:28:25 +0000
Subject: [Koha-bugs] [Bug 8055] reversing fines wonky
In-Reply-To: <bug-8055-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8055-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8055-70-rixyyKJapB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8055

--- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> ---
Created attachment 37246
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37246&action=edit
partial fine reverse

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:45:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 19:45:41 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-9CZGbf6m6q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #9 from Nick Clemens <nick at quecheelibrary.org> ---
1 - 100 subfield D is not displaying
2 - 111 subfields j,4 not displaying in any combination

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:47:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 19:47:13 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-7jqIKamefM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

--- Comment #10 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37247
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37247&action=edit
Sample record for testing

Sample record with data in all affected fields, not properly formatted, for
testing only

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 20:57:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 19:57:33 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-bbytCfFA7Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

--- Comment #11 from Nick Clemens <nick at quecheelibrary.org> ---
Let me revise the comments, was looking at pre-apply notes instead of
post-apply
100$d does display as well as 111$j


1 - For 100/110 In presence of both $4 and $e I think $e should take
preference, it is the other way around now

2 - 111$j displays whether or not $4 is present and $4 does NOT display whether
not $j is present

3 - If 111$j is blank, the record displays an empty []

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:01:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 20:01:19 +0000
Subject: [Koha-bugs] [Bug 13385] RDA: 508 display in XSLT
In-Reply-To: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13385-70-YLzdwtTfQK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36785|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37248
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37248&action=edit
[SIGNED OFF] Added field 508 bug #13385

This patch adds field 508 to the XSLT display in the staff and OPAC view.

Display includes subfields a,b,c,h,k,n,p,s
Subfield c is wrapped in a span class=title_resp_stmt for easy suppression via
css.
Subfield h is wrapped in a <span class=title_medium for easy suppression via
css.

To test:

* Search the opac
* Click the title
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:01:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 20:01:17 +0000
Subject: [Koha-bugs] [Bug 13385] RDA: 508 display in XSLT
In-Reply-To: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13385-70-9w3DSGLoTO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:19:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 20:19:58 +0000
Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT
In-Reply-To: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13386-70-ZDgjobeqJ6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org

--- Comment #3 from Nick Clemens <nick at quecheelibrary.org> ---
Outside the scope of this change, but if I had my druthers:

246 2nd indicator specifies type of other title, would be nice to display that
when 1st indicator 1.  Probab;y it would go into brackets like relator terms
and would be overridden by subfield i

That out of the way, works as described and will sign off momentarily

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:21:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 20:21:14 +0000
Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT
In-Reply-To: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13386-70-7sXF9nQdYf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36784|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37249
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37249&action=edit
[SIGNED OFF] Added separator to full and brief display.

This patch adds a  separator | to the full and brief displays in the staff and
OPAC views.
Separator wrapped with span clas=separator |
To test:

* Search the opac
* Click the title
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

http://bugs.koha-community.org/show_bug.cgi?id=13386
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 21:21:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 20:21:12 +0000
Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT
In-Reply-To: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13386-70-11IKDfxU8X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:01:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 21:01:12 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-5mzPaf5NbS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, 

noticed a small problem:
- edit an existing patron category
- save the change
- redirect is to the categories table - but only the edited caegory will show

I think it has something to do with a search parameter - visible in the top
search.

Also some suggestions for the messages:
- inserted with success > added successfully
- deleteing > deleting
- Hm, maybe: The patron category might already exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:08:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 21:08:06 +0000
Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in
	XSLT
In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13387-70-ZhCJppr6N9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at quecheelibrary.org
             Status|Needs Signoff               |In Discussion

--- Comment #7 from Nick Clemens <nick at quecheelibrary.org> ---
I just have a question on this one:

Are we intentionally not displaying subfields d,f,l,m,o ?  They show now but
are gone after I apply.  

I like the addition of n,p,s but I think it would be better to display all
fields that exist as I think you won't often encounter them all, but if they
are there you probably want to see them

Also, there is no subfield b or c for uniform titles, at least not according to
MARC21 standard

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:13:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 21:13:02 +0000
Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected
 tags in the OPAC's "My tags" table
In-Reply-To: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6379-70-gitqcHPsAg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Failed QA

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, I am sorry, but with the patch applied I have problems adding new tags,
this is after trying form the result list:

[Wed Mar 25 22:07:32.575073 2015] [cgi:error] [pid 18931] [client
127.0.0.1:59595] AH01215: [Wed Mar 25 22:07:32 2015] opac-tags.pl:
DBD::mysql::st execute failed: Column 'term' in where clause is ambiguous at
/home/katrin/kohaclone/C4/Tags.pm line 221., referer:
http://localhost/cgi-bin/koha/opac-search.pl?idx=kw&q=der&sort_by=relevance&addto=Add+to...&tagsel_new=&biblionumber=2&loggedinuser=&newtag2=XXX&biblionumber=4&loggedinuser=&newtag4=&biblionumber=8&loggedinuser=&newtag8=&biblionumber=9&loggedinuser=&newtag9=&biblionumber=10&loggedinuser=&newtag10=&biblionumber=13&loggedinuser=&newtag13=&biblionumber=14&loggedinuser=&newtag14=&biblionumber=18&loggedinuser=&newtag18=&biblionumber=19&loggedinuser=&newtag19=&biblionumber=23&loggedinuser=&newtag23=&biblionumber=32&loggedinuser=&newtag32=&biblionumber=38&loggedinuser=&newtag38=&biblionumber=40&loggedinuser=&newtag40=&biblionumber=47&loggedinuser=&newtag47=&biblionumber=50&loggedinuser=&newtag50=&biblionumber=58&loggedinuser=&newtag58=&biblionumber=60&loggedinuser=&newtag60=&biblionumber=61&loggedinuser=&newtag61=&biblionumber=63&loggedinuser=&newtag63=&biblionumber=64&loggedinuser=&newtag64=
[Wed Mar 25 22:07:32.575440 2015] [cgi:error] [pid 18931] [client
127.0.0.1:59595] AH01215: [Wed Mar 25 22:07:32 2015] opac-tags.pl: Can't use an
undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2064.,
referer:
http://localhost/cgi-bin/koha/opac-search.pl?idx=kw&q=der&sort_by=relevance&addto=Add+to...&tagsel_new=&biblionumber=2&loggedinuser=&newtag2=XXX&biblionumber=4&loggedinuser=&newtag4=&biblionumber=8&loggedinuser=&newtag8=&biblionumber=9&loggedinuser=&newtag9=&biblionumber=10&loggedinuser=&newtag10=&biblionumber=13&loggedinuser=&newtag13=&biblionumber=14&loggedinuser=&newtag14=&biblionumber=18&loggedinuser=&newtag18=&biblionumber=19&loggedinuser=&newtag19=&biblionumber=23&loggedinuser=&newtag23=&biblionumber=32&loggedinuser=&newtag32=&biblionumber=38&loggedinuser=&newtag38=&biblionumber=40&loggedinuser=&newtag40=&biblionumber=47&loggedinuser=&newtag47=&biblionumber=50&loggedinuser=&newtag50=&biblionumber=58&loggedinuser=&newtag58=&biblionumber=60&loggedinuser=&newtag60=&biblionumber=61&loggedinuser=&newtag61=&biblionumber=63&loggedinuser=&newtag63=&biblionumber=64&loggedinuser=&newtag64=

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:31:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 21:31:52 +0000
Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click
In-Reply-To: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6178-70-4MXqmSF3aJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, I am sorry, but I see no difference in behaviour before and after the
patch. I have 2 tags: der and das. One belongs to my user, the other to another
user.
Both always show for me :( 

I also got some anapproved tags. My list of records shows all my tags -
unapproved or not. The cloud only the 2 approved tags from my different users.

The other thing: I'd expect that if I set "Tags to show from other users" to 0
or empty, that 
a) the foreign tag goes away
b) that my selection sticks, but the pull down returns to 100 immediately

Could you take another look please?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:47:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 21:47:11 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-aJXFI5igjW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 22:47:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 21:47:14 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-tUXvYi6PZh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37206|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37250
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37250&action=edit
[PASSED QA] Bug 3969: Fix funds search

The funds search does not work at all.
On the budget and the budget plan page, the library dropdown list is
empty.

Test plan:
On the budget, the budget plan and the fund pages, confirm that you are
able to search a fund by code (or name) and the library dropdown list is
correctly filled.

Tested with several combinations. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Tested various combinations, no problems found.
Passes tests and QA script.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:15:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:15:41 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete reserves
In-Reply-To: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13903-70-oyqpzuunLy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:18:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:18:02 +0000
Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data
In-Reply-To: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-og6XQqfr3Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:26:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:26:00 +0000
Subject: [Koha-bugs] [Bug 4274] Cart now requires login before emailing
	contents
In-Reply-To: <bug-4274-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4274-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4274-70-yDpvHgTbVJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
(In reply to Chris Cormack from comment #6)
> (In reply to comment #5)
> The main reason being, it's a spam tool otherwise, so before we can let it
> be used without a login, someone needs to propose a solution that will stop
> spammers using it, that isn't using captcha or another discriminatory
> technique. Then we are good to go with a syspref.

Perhaps a negative captcha like we're now using for the Anonymous Suggestions
as per bug 3144?

I included some links on Comment 24 with some information. 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144#c24

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:27:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:27:38 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-TcKXXhPf5Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:28:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:28:01 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-I3ilWqcFLz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:29:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:29:24 +0000
Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions
In-Reply-To: <bug-3144-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3144-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3144-70-KkYcZ0kDMu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
A human being might still misuse the feature - I think it should be a choice 
for the library, so they can turn off 'non logged in cart sending'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:30:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:30:41 +0000
Subject: [Koha-bugs] [Bug 13910] New: Prevent delete of one's own patron
	account
Message-ID: <bug-13910-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910

            Bug ID: 13910
           Summary: Prevent delete of one's own patron account
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When deleting accounts, it should be impossible to delete one's own borrower
account.

Over the years, I've had a few librarians accidentally delete themselves and
lock themselves out of Koha. 

I suppose there are quite a few ways this could be implemented. I don't have a
patch yet, but this report here is mostly a placeholder for when I do...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:32:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:32:25 +0000
Subject: [Koha-bugs] [Bug 13901] sort1 and sort2 not on self registration
	form
In-Reply-To: <bug-13901-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13901-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13901-70-m9rZpPiCKx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13901

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Agreed! I actually added them locally for our libraries, so I'd love to see
this get into master. 

I'll even do a patch when I have time to work on Koha again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:33:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:33:24 +0000
Subject: [Koha-bugs] [Bug 9789] goodreads and librarything in social share
In-Reply-To: <bug-9789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9789-70-n8m7b0llq4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9789

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:35:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:35:24 +0000
Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions
In-Reply-To: <bug-3144-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3144-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3144-70-J3xsbgR5GH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Last comment was meant for another bug... bug 4274

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:36:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:36:00 +0000
Subject: [Koha-bugs] [Bug 4274] Cart now requires login before emailing
	contents
In-Reply-To: <bug-4274-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4274-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4274-70-FaO0hAzJLu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
A human being might still misuse the feature - I think it should be a choice 
for the library, so they can turn off 'non logged in cart sending'.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:37:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:37:19 +0000
Subject: [Koha-bugs] [Bug 4274] Cart now requires login before emailing
	contents
In-Reply-To: <bug-4274-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4274-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4274-70-NLcUMK3lvv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #8)
> A human being might still misuse the feature - I think it should be a choice
> for the library, so they can turn off 'non logged in cart sending'.

Agreed. We actually have this implemented locally as an "anonymous cart" system
preference. I think most of our libraries have it turned off (ie require
login), but a few want anyone to be able to use the cart.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:43:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:43:10 +0000
Subject: [Koha-bugs] [Bug 3125] IE7-8: Selected columns list in Reports
 Dictionary is not showing column names.
In-Reply-To: <bug-3125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3125-70-hC05aGvJTr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3125

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:44:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:44:43 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-T0vSi2JHsK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #122 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 36617
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36617
[PASSED-QA] Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to
the Circulation Matrix

Review of attachment 36617:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5786&attachment=36617)
-----------------------------------------------------------------

::: opac/opac-search.pl
@@ +602,5 @@
> +            if ($borrower) {
> +                $_->{holdable} =
> +                    IsAvailableForItemLevelRequest($_, $borrower) &&
> +                    OPACItemHoldsAllowed($_, $borrower)
> +                  foreach @newresults;

This totally breaks the OPAC search - resulting in a Perl error: 
No homebranch at /home/katrin/kohaclone/C4/Reserves.pm line 2157.

I think $_ is not what you think - especially with using XSLT results. It looks
like the HTML output that is created for display if my tests are correct.

The same code is used in the if condition above.

Using $_ and the foreach at the end also makes this quite a confusing read.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Mar 25 23:56:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 22:56:52 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-bcgoFTakqL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #123 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This might get reverted if not fixed fast - please take a look asap!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 00:51:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 23:51:19 +0000
Subject: [Koha-bugs] [Bug 13911] New: Add support for Internet Archive
	BookReader
Message-ID: <bug-13911-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911

            Bug ID: 13911
           Summary: Add support for Internet Archive BookReader
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: indradg at gmail.com
        QA Contact: testopia at bugs.koha-community.org

This new feature proposes to add support for storage and display (via the OPAC)
of scanned (.PDFs, JPEG / JPEG2000 / TIFF et al.) rare materials (old books
that are out of copyright and/or manuscripts) using the IA BookReader [1]
JavaScript library.

Since IA BookReader is licensed under AGPLv3, actual download and installation
of this JavaScript library will be left as a user initiated exercise via a .KPZ
plugin. However, this patch will add the supporting cgi perl module and
templates to integrate and facilitate the integrated functionality.

This feature is being partly sponsored by Bhaktivedanta Research Centre (BRC)
of ISKCON. BRC presently maintains its catalogue using Koha v3.18

A short video of the preliminary functionality is available on Youtube [2].

References:

[1] https://openlibrary.org/dev/docs/bookreader

[2] https://www.youtube.com/watch?v=vSJAUdtuKpk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 00:51:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 23:51:28 +0000
Subject: [Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader
In-Reply-To: <bug-13911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13911-70-Q2uGXyQDVN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 00:51:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 25 Mar 2015 23:51:54 +0000
Subject: [Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader
In-Reply-To: <bug-13911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13911-70-yzlH8Deaik@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |indradg at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 01:10:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 00:10:33 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-S3CwufaFoo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com
           Keywords|                            |rel_3_16_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 01:11:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 00:11:01 +0000
Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee!
In-Reply-To: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12820-70-jqv6fCCTwJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_16_candidate
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 01:38:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 00:38:39 +0000
Subject: [Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
In-Reply-To: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13254-70-ZTJsOK6W8F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_3_16_candidate          |

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
(In reply to Fridolin SOMERS from comment #8)
> Dirty bug indeed.
> Can this be backported to 3.16.x ?

Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 01:58:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 00:58:31 +0000
Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached
In-Reply-To: <bug-13645-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13645-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13645-70-qf7nF8lx4V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com
           Keywords|                            |rel_3_16_candidate

--- Comment #32 from Mason James <mtj at kohaaloha.com> ---
(In reply to Chris Cormack from comment #31)
> Pushed to 3.18.x will be in 3.18.5

hmm, possible selection for 3.16.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 02:03:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 01:03:44 +0000
Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor
In-Reply-To: <bug-13729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13729-70-JQT3R2LaCA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 02:53:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 01:53:28 +0000
Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with
	STRICT_TRANS_TABLES
In-Reply-To: <bug-13523-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13523-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13523-70-BUAPxWn9jn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #19 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 03:11:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 02:11:21 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-IJRPhkZqV9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_16_candidate
                 CC|                            |mtj at kohaaloha.com

--- Comment #6 from Mason James <mtj at kohaaloha.com> ---
Contains string changes, holding for 3.16.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 03:13:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 02:13:05 +0000
Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable
In-Reply-To: <bug-13741-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13741-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13741-70-4HuVirm6Gq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 03:14:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 02:14:19 +0000
Subject: [Koha-bugs] [Bug 13745] Serial collection page shows branchcode
 instead of branchname
In-Reply-To: <bug-13745-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13745-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13745-70-NuC5oq2nNn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13745

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #6 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 03:29:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 02:29:15 +0000
Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
In-Reply-To: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12627-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12627-70-9ExoCHb7GH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_16_candidate
                 CC|                            |mtj at kohaaloha.com

--- Comment #33 from Mason James <mtj at kohaaloha.com> ---
Possible selection for 3.16.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 03:30:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 02:30:00 +0000
Subject: [Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests
In-Reply-To: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12445-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12445-70-OW8XsHu9Cj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_16_candidate
                 CC|                            |mtj at kohaaloha.com

--- Comment #24 from Mason James <mtj at kohaaloha.com> ---
Possible selection for 3.16.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 03:30:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 02:30:47 +0000
Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save
In-Reply-To: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13731-70-MBuVJzQqJ5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_16_candidate
                 CC|                            |mtj at kohaaloha.com

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
Possible selection for 3.16.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 03:35:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 02:35:27 +0000
Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save
In-Reply-To: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13731-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13731-70-lhW3fGy8ou@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_3_16_candidate          |

--- Comment #12 from Mason James <mtj at kohaaloha.com> ---
(In reply to Mason James from comment #11)
> Possible selection for 3.16.x

bug does not exist in 3.16.9 - so skipping patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 03:40:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 02:40:50 +0000
Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts
In-Reply-To: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13605-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13605-70-XuHywhoKXP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 03:43:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 02:43:59 +0000
Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc
	flavour is UNIMARC
In-Reply-To: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13635-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13635-70-db1Ct9QBNb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #14 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 04:58:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 03:58:04 +0000
Subject: [Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader
In-Reply-To: <bug-13911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13911-70-YhcoGfbdKe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911

Indranil Das Gupta <indradg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 07:03:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 06:03:26 +0000
Subject: [Koha-bugs] [Bug 13831] Item history is anonymized when borrower
 anonymizes his reading history using Immediate deletion
In-Reply-To: <bug-13831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13831-70-ucbkKItxF2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13831

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 37251
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37251&action=edit
[Signed-off] Bug 3831: Does not allow to delete the FA framework

Test plan:
Go on the MARC framework list view and confirm there is no Delete link
anymore for the FA framework.

Delete link for Fast add framework does no longer display.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 07:06:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 06:06:08 +0000
Subject: [Koha-bugs] [Bug 13831] Item history is anonymized when borrower
 anonymizes his reading history using Immediate deletion
In-Reply-To: <bug-13831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13831-70-kXvbUpFcjT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13831

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37251|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Comment on attachment 37251
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37251
[Signed-off] Bug 3831: Does not allow to delete the FA framework

Wrong bug number, sorry...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 07:06:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 06:06:35 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-FYqT6OGBiB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 37252
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37252&action=edit
[Signed-off] Bug 3831: Does not allow to delete the FA framework

Test plan:
Go on the MARC framework list view and confirm there is no Delete link
anymore for the FA framework.

Delete link for Fast add framework does no longer display.
Signed-off-by: Marc V?ron <veron at veron.ch>

http://bugs.koha-community.org/show_bug.cgi?id=13831

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 07:06:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 06:06:55 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-9BkaT901ca@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37209|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 07:07:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 06:07:06 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-qfp0gD6Fmr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 07:09:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 06:09:00 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-d6TDlFgi8W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 07:22:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 06:22:15 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-UUCRfEn07X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
Perhaps it should also be required when doing a fresh install?

(This might be the case... I just noticed on a 3.18.5 install that I could
choose not to install the FA framework.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 07:36:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 06:36:26 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-y7CdQif1F8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #124 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 37253
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37253&action=edit
Bug 5786: Correction: Moved holdability check from opac-search.pl to
searchResults()

Additional param $borrowernumber for searchResults() when searching in OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 07:42:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 06:42:40 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-Q3HOoUlaNn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #125 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
I hope this patch is not too heavy. What I did is:
* Reverted opac-search.pl to almost what it was before we started this bug
* changed searchResults() in opac context to take in account issuingrules when
setting norequests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 08:35:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 07:35:22 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-sElLBGOJjH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 08:35:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 07:35:30 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-MFkkDKhLEf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 08:37:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 07:37:25 +0000
Subject: [Koha-bugs] [Bug 13912] New: System preference for default place of
 publication (country code) for field 008, range 15-17
Message-ID: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

            Bug ID: 13912
           Summary: System preference for default place of publication
                    (country code) for field 008, range 15-17
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

The country code of place of publication is hardcoded to xxu (United States) in
field 008 value builder. We should offer an option to change it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 08:48:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 07:48:06 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-UThTFUm2vb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 37254
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37254&action=edit
Bug 13912 - System preference for default place of publication (country code)
for field 008, range 15-17

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 08:54:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 07:54:13 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-gqIMsjDcgl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Test plan:
1. Apply the patch
2. Go to Administration -> System preferences -> Cataloguing and check the
section Record Structure has new preference DefaultCountryField008 and this
preference is blank
3. Insert into DefaultCountryField008 some country code (e.g. xr for Czech
Republic) and save
4. Go to Cataloguing module, make a new record in any framework, which has
marc_field:008.pl value builder set for field 008 (it should be default)
5. Prove that your country code is preset in field 008, range 15-17

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:17:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 08:17:29 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-E8Y5hnk2CC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 37255
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37255&action=edit
Bug 13912 - System preference for default place of publication (country code)
for field 008, range 15-17, followup, repairs the broken link

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:30:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 08:30:57 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-6bNhxRDz3A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:31:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 08:31:00 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-H6ttVDGkRq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37256
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37256&action=edit
Bug 5002: Show all patron categories after insert

+ wording changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:32:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 08:32:57 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-z96jZzyLuU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37256|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37257
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37257&action=edit
Bug 5002: Show all patron categories after insert

+ wording changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:34:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 08:34:36 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-kI3oVVSqPU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #7)
> Hi Jonathan, 
> 
> noticed a small problem:
> - edit an existing patron category
> - save the change
> - redirect is to the categories table - but only the edited caegory will show
> 
> I think it has something to do with a search parameter - visible in the top
> search.

I thought it was a feature... :)
I should have tested on master to confirm.

> Also some suggestions for the messages:
> - inserted with success > added successfully
> - deleteing > deleting
> - Hm, maybe: The patron category might already exist.

Fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:37:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 08:37:35 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-W6w4CilNQO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Created attachment 37258
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37258&action=edit
The column selection is not synchroized with it's header if window is resized

To reproduce:

Click on 'Show/hide columns'
Column selection with ccheckboxes appears
Select or de-select some columns
Resize window to adapt do new table width
Header 'Show hide columns' moves
Column selection dows mot move with 'Show hide columns' (e.g. will be invisible
outside the browser window or will display like on this screenshot).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:50:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 08:50:49 +0000
Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected
 tags in the OPAC's "My tags" table
In-Reply-To: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6379-70-h5g6W0hceB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:50:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 08:50:52 +0000
Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected
 tags in the OPAC's "My tags" table
In-Reply-To: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6379-70-Bgp0L3GdXq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37222|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37259
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37259&action=edit
Bug 6379: Remove link from unapproved tags

At the OPAC, if the tag is not approved, the tag's link did not return
any result.

This patch removes the link.
Test plan:
1/ Set TagsModeration to 'Require'
2/ Create tags at the OPAC
3/ Approve a couple
4/ Confirm that unapproved tags does not have links.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:52:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 08:52:54 +0000
Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected
 tags in the OPAC's "My tags" table
In-Reply-To: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6379-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6379-70-NmTOznXEYm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #6)
> Hm, I am sorry, but with the patch applied I have problems adding new tags,
> this is after trying form the result list:

Thanks for catching that!
My error was to try to modify C4::Tags, it's a nightmare.
This last patch does what I tried to do but without modifingy the module.
It's less efficient but much more safe.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:57:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 08:57:14 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-EKyhDfY2JV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 09:58:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 08:58:01 +0000
Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click
In-Reply-To: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6178-70-gIcBuIYhaR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178

--- Comment #14 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #13)
> Hm, I am sorry, but I see no difference in behaviour before and after the
> patch. I have 2 tags: der and das. One belongs to my user, the other to
> another user.
> Both always show for me :( 

You have to click on the 'your tags' link (not 'Tag cloud'). The link is
opac-tags.pl?mine=1 (note the param mine set to 1).

Without this patch, the views are different, with it, they are similar.

Please try again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:01:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 09:01:06 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete reserves
In-Reply-To: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13903-70-i5g86JGCLQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Hi Katrin,

I started this by using "holds", but since the ID field is named "reserve_id"
and it's returned in some responses, I think it's more consistent to use
"reserves".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:03:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 09:03:26 +0000
Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click
In-Reply-To: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6178-70-xtRv5PhVUa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I tried both links - from the top navigation and the user account. Will try
again.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:12:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 09:12:25 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-Z6cTjt3JxR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

--- Comment #11 from Marc V?ron <veron at veron.ch> ---
Created attachment 37260
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37260&action=edit
[Signed-off] Bug 5002: Show all patron categories after insert

+ wording changes.

How I tested:
- edit an existing patron category
- save the change
- redirect is to the categories table - it shows all categories OK

- wording OK as well

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:12:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 09:12:54 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-cQkeeB39yK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37257|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:22:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 09:22:18 +0000
Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking
 because of case insensitive utf8 collation
In-Reply-To: <bug-13810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13810-70-j830HrG3C2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810

--- Comment #4 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
I'm not on it right now, because I find a way to have a working master branch.
Not sure if it has everything it should about collation though.

I tried to debug this upgrading step by step, commit to updatedatabase.pl by
commit. It appears it ran smoothly without complains. I realised I launched a
different version of the dbrev 3.19.00.006: the one from commit
42a8082c8ffd05b3719b79060d81ba77d4f508d3. I then thought I was having trouble
with the code added by Martin from commit
a303cdec4871d3d3740d419c972eea7faf8e5a8a.

I'm not sure it make sense. But I didn't have complains when upgrading and
still have my items attached to biblios in intranet (I was losing them when
first trying with code from commit 
a303cdec4871d3d3740d419c972eea7faf8e5a8a).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:31:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 09:31:04 +0000
Subject: [Koha-bugs] [Bug 5844] Unhilight cuts off some strings
In-Reply-To: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5844-70-QnWGIjJ8vT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:36:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 09:36:46 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-YkabWHxHQ8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37254|0                           |1
        is obsolete|                            |
  Attachment #37255|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 37261
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37261&action=edit
Bug 13912 - System preference for default place of publication (country code)
for field 008, range 15-17

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:37:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 09:37:04 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-oq5SRKeIGi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 37262
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37262&action=edit
Bug 13912 - System preference for default place of publication (country code)
for field 008, range 15-17, followup, repairs the broken link

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:38:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 09:38:38 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-KKVjgmjgqI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 10:50:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 09:50:03 +0000
Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems,
 OpacHiddenItems total count, prog them facet display
In-Reply-To: <bug-11909-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11909-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11909-70-cq5mVPjFfa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at enger.priv.no

--- Comment #9 from Magnus Enger <magnus at enger.priv.no> ---
Should this be "Needs signoff"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:20:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 10:20:34 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-lfvOSAk6Qt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #126 from Marc V?ron <veron at veron.ch> ---
Created attachment 37263
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37263&action=edit
[Signed-off] Bug 5786: Correction: Moved holdability check from opac-search.pl
to searchResults()

Additional param $borrowernumber for searchResults() when searching in OPAC

With this patch OPAC search works agein (see comment #122)
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:24:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 10:24:46 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-RjaYrlKamZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37253|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 11:25:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 10:25:52 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-DcK8hh0Pq8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:13:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 11:13:05 +0000
Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and
 additional XSLT processing
In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6536-70-TVC82RY29u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #112 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 37264
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37264&action=edit
sample xslt

I attach our actual XSLT as example

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:13:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 11:13:45 +0000
Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and
 additional XSLT processing
In-Reply-To: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6536-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6536-70-qnIravo6Bo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37264|sample xslt                 |sample MARC21 to UNIMARC
        description|                            |xslt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:19:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 11:19:43 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-xfRnyBd56v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

--- Comment #1 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 37265
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37265&action=edit
Bug 9089 - show suggestion number

Show suggestion number on suggestion management.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:21:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 11:21:59 +0000
Subject: [Koha-bugs] [Bug 10382] collection not returning to null when
 removed from course reserves
In-Reply-To: <bug-10382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10382-70-jBYCwALoqH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

Derryn <derrynj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |derrynj at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:21:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 11:21:59 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-XeopzyjH4l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

--- Comment #2 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Someone in my library just ask for this functionnality. Here is a patch for it.
To test:

apply and check the suggestion page, a column "Suggestion number" should appear
on all tabs.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:25:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 11:25:14 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-tsH58MmITd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:26:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 11:26:20 +0000
Subject: [Koha-bugs] [Bug 13913] New: Renewal error message in OPAC is not
	correct
Message-ID: <bug-13913-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913

            Bug ID: 13913
           Summary: Renewal error message in OPAC is not correct
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Created attachment 37266
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37266&action=edit
screenshot of opac error message

To test:
- checkout a few items
- make sure you can't renew yet for some other reason than max limit of holds
reached
   - no renewal before in circ rules
   - a hold on the item
- click renewa all in opac patron account

The shown message reads:
Please note: Your loan renewal failed because of the following reason(s): You
have renewed this item the maximum number of times allowed. 

The given reason why the renewal failed is not correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 12:47:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 11:47:02 +0000
Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the
 intranet, also try to search for it on the LDAP server if one is configured.
In-Reply-To: <bug-11808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11808-70-eFqXVmxvho@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808

Derryn <derrynj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |derrynj at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:17:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 12:17:41 +0000
Subject: [Koha-bugs] [Bug 13914] New: The holds statistics report return
	random data
Message-ID: <bug-13914-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914

            Bug ID: 13914
           Summary: The holds statistics report return random data
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Reports
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

To reproduce:
Go on Reports ? Holds statistics

Fill the form with:
Hold status: All checked (Asked Processing Waiting Satisfied Cancelled)
Hold Date From 01/01/2014 To 31/01/2014

Pickup library => empty
Holding library => empty
Home library => empty

Row is "Hold status", Column is "Pickup library".

Submit!

Look at the results

Restart mysql

Ctrl+R to resubmit the form

Look at the results

Enjoy...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:25:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 12:25:00 +0000
Subject: [Koha-bugs] [Bug 13717] Add ability to move old patron attributes
 when importing borrowers
In-Reply-To: <bug-13717-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13717-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13717-70-GNJxNUoaAj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Looks like you forgot to apply the dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:33:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 12:33:09 +0000
Subject: [Koha-bugs] [Bug 13914] The holds statistics report return random
	data
In-Reply-To: <bug-13914-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13914-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13914-70-hOK8Q3qGXu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37267
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37267&action=edit
Bug 13914: Holds statistics report should add values from reserves and
old_reserves

And not pick one randomly...

To reproduce:
1/ Go on Reports ? Holds statistics

2/ Fill the form with:
Hold status: All checked (Asked Processing Waiting Satisfied Cancelled)
Hold Date From 01/01/2014 To 31/01/2014

Pickup library => empty
Holding library => empty
Home library => empty

Row is "Hold status", Column is "Pickup library".

3/ Submit!

4/ Look at the results

5/ Restart mysql

6/ Ctrl+R to resubmit the form

7/ Look at the results

The generated query looks like ( SELECT stuffs FROM reserves ) UNION (
SELECT stuffs FROM old_reserves )
It returns something like:
+------+---------------+-------------+
| line | col           | calculation |
+------+---------------+-------------+
|    1 | BRANCHCODE1   |           1 | < from the reserves table
|    1 | BRANCHCODE1   |          11 | < from the old_reserves table
|    1 | BRANCHCODE2   |           2 |
|    1 | BRANCHCODE2   |          22 |
|    2 | BRANCHCODE1   |           4 |
|    2 | BRANCHCODE1   |          44 |
|    2 | BRANCHCODE2   |           5 |
|    2 | BRANCHCODE2   |          55 |
+------+---------------+-------------+

The screen will display 1 OR 11 for the BRANCHCODE1 line 1.
Since ( line, col ) is not uniq, fetchall_hashref (l.280) was not a good
idea here.
This patch replaces it with fetchall_arrayref, reconstruct the variables
used later and add the values from reserves and old_reserves.

Test plan:
Confirm that the results are now relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:33:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 12:33:07 +0000
Subject: [Koha-bugs] [Bug 13914] The holds statistics report return random
	data
In-Reply-To: <bug-13914-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13914-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13914-70-BsrqDuxl4T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:40:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 12:40:29 +0000
Subject: [Koha-bugs] [Bug 13915] New: Inventory tool no longer hides items
 with date last seen greater than the inventory date
Message-ID: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915

            Bug ID: 13915
           Summary: Inventory tool no longer hides items with date last
                    seen greater than the inventory date
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In previous versions of Koha, selecting an inventory date would filter out
items that had been seen since the "Inventory date". Bug 12631 changed the
inventory tool so that this behavior only occurs when a barcodes list file is
uploaded for comparison.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:42:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 12:42:29 +0000
Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with
 date last seen greater than the inventory date
In-Reply-To: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13915-70-A6nAsycNxo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:42:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 12:42:32 +0000
Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with
 date last seen greater than the inventory date
In-Reply-To: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13915-70-LXY8R4mWx0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37268
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37268&action=edit
Bug 13915 - Inventory tool no longer hides items with date last seen greater
than the inventory date

In previous versions of Koha, selecting an inventory date would filter
out items that had been seen since the "Inventory date". Bug 12631
changed the inventory tool so that this behavior only occurs when a
barcodes list file is uploaded for comparison.

Test Plan:
1) Apply this patch
2) Run the inventory tool with no set parameters
3) Mark the first item as seen
4) Rerun the tool with only a date last seen parameter
   of yesterday
5) Note the item you marked as seen is no longer on the list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 13:48:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 12:48:42 +0000
Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with
 date last seen greater than the inventory date
In-Reply-To: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13915-70-lOvznC7r4d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Correction, bug 12631 is not the culprit in causing this regression. It was
just the last patch to change this line of code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:03:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:03:25 +0000
Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
In-Reply-To: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13382-70-5GglPDry58@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #29 from Winona Salesky <wsalesky at gmail.com> ---
Anyway I can get that attachment as MARCXML?

(In reply to Nick Clemens from comment #28)
> Created attachment 37245 [details]
> Smaple record to see all fields
> 
> This is just a sample record I used to put data into all the fields touched
> by this bug, it is not properly formatted but is helpful for testing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:04:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:04:13 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-oYmF9bTvM4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com
             Status|Needs Signoff               |Signed Off

--- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by m23 <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:04:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:04:26 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-L0A1b55APz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37261|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:04:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:04:30 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-VTg2xGIX0s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37262|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:04:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:04:37 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-lYJftqI64W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

--- Comment #7 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 37269
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37269&action=edit
Bug 13912 - System preference for default place of publication (country code)
for field 008, range 15-17

Signed-off-by: m23 <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:04:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:04:40 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-LCdXWR4kcv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

--- Comment #8 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 37270
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37270&action=edit
Bug 13912 - System preference for default place of publication (country code)
for field 008, range 15-17, followup, repairs the broken link

Signed-off-by: m23 <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:40:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:40:52 +0000
Subject: [Koha-bugs] [Bug 13916] New: NORMARC can have analytics with leader
 07 = a, b or p
Message-ID: <bug-13916-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13916

            Bug ID: 13916
           Summary: NORMARC can have analytics with leader 07 = a, b or p
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: magnus at enger.priv.no
          Reporter: magnus at enger.priv.no
        QA Contact: testopia at bugs.koha-community.org

When a record has leader 07 = 2 and "Show analytics" links are generated, they
look like this:

http://example.com/cgi-bin/koha/opac-search.pl?q=rcn:832083305+and+(bib-level:a+or+bib-level:b)

But NORMARC has three different types of analytics that can be indicated in 07:

a - Analytt til ikke-periodisk dokument
Posten inneholder en enkelt I-analytt, f.eks. en artikkel i en monografi.

b - Serieanalytt
Posten inneholder en I-analytt som beskriver en periodisk utgitt del av et
verk, f.eks. en fast spalte i et periodikum.

p - Analytt til periodikum
Posten inneholder en enkelt I-analytt.

So the links should look like this:

http://example.com/cgi-bin/koha/opac-search.pl?q=rcn:832083305+and+(bib-level:a+or+bib-level:b+or+bib-level:p)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:46:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:46:27 +0000
Subject: [Koha-bugs] [Bug 13917] New: OPAC: Still accessible by URL even if
 turned off by system preference
Message-ID: <bug-13917-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917

            Bug ID: 13917
           Summary: OPAC: Still accessible by URL even if turned off by
                    system preference
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org

To reproduce:

1)
In staff client, set System preference 'RequestOnOpac' to 'Allow patrons to
place holds on items from the OPAC.'
2)
Log in to OPAC with a patron' credentials, search a record, place hold without
confirming, copy URL, something like 
[YOUR SERVER]/cgi-bin/koha/opac-reserve.pl?biblionumbers=1
3)
In staff client, set  System preference 'RequestOnOpac' to 'Don't allow patrons
to place holds on items from the OPAC.'
4)
Log out. Log in again in OPAC.
5)
Paste URL in browser's address bar

Result: Page displays, you can put a hold on the requested item.

Expected: 
404 page, similar to solution for Bug 12703

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:49:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:49:55 +0000
Subject: [Koha-bugs] [Bug 13918] New: Add waiting expiration date to opac
 list of holds for user
Message-ID: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

            Bug ID: 13918
           Summary: Add waiting expiration date to opac list of holds for
                    user
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Waiting holds for patrons in the opac should display the hold expiration date
based on the max pickup delay if it is set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:52:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:52:55 +0000
Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of
 holds for user
In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13918-70-NOKX6mHhIe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:52:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:52:57 +0000
Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of
 holds for user
In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13918-70-Z1NkjpuiJg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37271
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37271&action=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until <date>' addition to the
   waiting hold line.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:53:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:53:13 +0000
Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of
 holds for user
In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13918-70-ud3pudSW1Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13517

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:53:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:53:13 +0000
Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
In-Reply-To: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13517-70-JQqMGBCVvd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13918

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:53:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:53:18 +0000
Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of
 holds for user
In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13918-70-F2DR8y4gWq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 14:56:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 13:56:46 +0000
Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of
 holds for user
In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13918-70-zPt7yys7oD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37271|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37272
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37272&action=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until <date>' addition to the
   waiting hold line.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:05:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:05:08 +0000
Subject: [Koha-bugs] [Bug 13917] OPAC: Holds still accessible by URL even if
 turned off by system preference
In-Reply-To: <bug-13917-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13917-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13917-70-LGdC2S5Yuq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|OPAC: Still accessible by   |OPAC: Holds still
                   |URL even if turned off by   |accessible by URL even if
                   |system preference           |turned off by system
                   |                            |preference

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:05:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:05:41 +0000
Subject: [Koha-bugs] [Bug 9614] Fines not assessed after renewing an item
In-Reply-To: <bug-9614-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9614-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9614-70-rQVYLSMQXY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9614

Cindy Murdock Ames <cmurdock at ccfls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cmurdock at ccfls.org

--- Comment #6 from Cindy Murdock Ames <cmurdock at ccfls.org> ---
I can confirm this on 3.18.4.  Some pertinent settings are:

CalculateFinesOnReturn:  Do
finesCalendar:  Calculate fines based on days overdue not including days the
library is closed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:06:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:06:19 +0000
Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL
 even if turned off by system preference
In-Reply-To: <bug-13917-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13917-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13917-70-QdTMwkkzMW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|OPAC: Holds still           |OPAC: Putting holds still
                   |accessible by URL even if   |possible by URL even if
                   |turned off by system        |turned off by system
                   |preference                  |preference

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:09:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:09:10 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-FU8FEwAEZ5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I don't have this problem, the column list sticks to the 'Show/hide' button.
I use Iceweasel 31.4.0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:10:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:10:14 +0000
Subject: [Koha-bugs] [Bug 5844] Unhilight cuts off some strings
In-Reply-To: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5844-70-syUfJeikwW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37273
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37273&action=edit
Bug 5844: Avoid strings cut on unhighlighing

If a user is searching for several words and that one is contained in
another ( "mag ma" ), some characters are cut (removed from the DOM!).

To reproduce:
1/ search for "mag ma m"
2/ The result page contains "Magazine"
3/ "Mag" is highlighted
4/ Click on the "Unhighlight" link
5/ The "Magazine" words become "azine", "Mag" has been cut.
There is no way to show these characters again.

Test plan:
1/ Confirm the bad behavior without this patch
2/ Apply this patch
3/ search for "mag ma m"
4/ The result page contains "Magazine"
5/ "Mag" is highlighted
6/ Click on the "Unhighlight" link
7/ strings are unhighlighted and still in the DOM :)

Note that the Highlight link won't work very well (only "a" will be
highlighted, but considered as minor since this did not work before the
patch neither).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:10:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:10:28 +0000
Subject: [Koha-bugs] [Bug 5844] Unhilight cuts off some strings
In-Reply-To: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5844-70-EassVor9M2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|oleonard at myacpl.org         |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:15:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:15:24 +0000
Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL
 even if turned off by system preference
In-Reply-To: <bug-13917-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13917-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13917-70-CzPkUQD6X4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 37274
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37274&action=edit
OPAC: Putting holds still possible by URL even if turned off by system
preference

To test:

1)
Prepare an URL that put's a hold in OPAC (see comment #1), e.g.
[YOUR SERVER]/cgi-bin/koha/opac-reserve.pl?biblionumbers=1

2)
Set system preference 'RequestOnOpac' to 'Don't allow patrons to place holds on
items from the OPAC.'

3)
Go diectly to this URL.
Result: The page displays to confirm hold (wrong)

4)
Apply patch

5)
Repeat step 3
Result: Redirect to 404 page (OK)

6)
Set system preference to "Allow"

7)
Repeat step 3
Result: The page displays to confirm hold (OK), like it would be from link in
OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:15:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:15:55 +0000
Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL
 even if turned off by system preference
In-Reply-To: <bug-13917-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13917-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13917-70-0nXDgxLbYE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:18:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:18:17 +0000
Subject: [Koha-bugs] [Bug 5599] koha_perl_deps.pl and PerlDependencies.pm
 don't compare $VERSION numbers correctly
In-Reply-To: <bug-5599-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5599-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5599-70-sr17LSphjp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5599

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
The issue raised by the description is now fixed

commit 80ba84159ddbdd52394984c8078263066dcc7a7b
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Thu Jul 21 20:04:02 2011 +1200

    Fixing missing padding on module version


-        'min_ver'  => '1.3.5'
+        'min_ver'  => '1.3.05'

So it's not needed at the moment.
I decrease the priority.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:42:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:42:52 +0000
Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL
	languages
In-Reply-To: <bug-12068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12068-70-8l33MXdY7T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068
Bug 12068 depends on bug 8375, which changed state.

Bug 8375 Summary: Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:42:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:42:51 +0000
Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when
 exporting batch label to PDF
In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8375-70-35lx1Bqqd6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|CLOSED                      |REOPENED
                 CC|                            |barton at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:48:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:48:43 +0000
Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when
 exporting batch label to PDF
In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8375-70-C6iUy9emXa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #91 from Barton Chittenden <barton at bywatersolutions.com> ---
Under 3.19.00.016, printing the title field containing RIGHT SINGLE QUOTATION
MARK (UTF-8 0xe28099) causes the following text to be written to the PDF file.

<h1>Software error:</h1>
<pre>Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820.
</pre>
<p>
For help, please send mail to the webmaster (<a
href="mailto:staff at bywatersolutions.com">staff at bywatersolutions.com</a>),
giving this error message 
and the time and date of the error.

</p>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:49:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:49:02 +0000
Subject: [Koha-bugs] [Bug 5617] fix-perl-path.pl misses some files
In-Reply-To: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5617-70-oB8JyqKUYB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5617

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37275
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37275&action=edit
Bug 5617: Fix existing wrong shebangs

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:49:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:49:08 +0000
Subject: [Koha-bugs] [Bug 5617] fix-perl-path.pl misses some files
In-Reply-To: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5617-70-8blP5nIOKj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5617

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37276
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37276&action=edit
Bug 5617: Use /usr/bin/env perl for **/*.pl scripts

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:49:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:49:13 +0000
Subject: [Koha-bugs] [Bug 5617] fix-perl-path.pl misses some files
In-Reply-To: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5617-70-55kkyxKg1y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5617

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37277
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37277&action=edit
Bug 5617: Use /usr/bin/env perl for all other occurrences

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:49:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:49:17 +0000
Subject: [Koha-bugs] [Bug 5617] fix-perl-path.pl misses some files
In-Reply-To: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5617-70-vr2orrymbr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5617

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37278
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37278&action=edit
Bug 5617: Remove useless script fix-perl-path.PL

It's now useless

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:51:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:51:58 +0000
Subject: [Koha-bugs] [Bug 5617] fix-perl-path.pl misses some files
In-Reply-To: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5617-70-jHcelrB7J2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5617

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m, robin at catalyst.net.nz,
                   |                            |tomascohen at gmail.com

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Tomas, Robin,

I thought this one was easy to fix replacing the current shebang with
/usr/bin/env perl
But it seems there are a lot of pros and cons
(https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58 for
instance).

Could I get your opinion on this?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 15:53:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 14:53:18 +0000
Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when
 exporting batch label to PDF
In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8375-70-EnlVyYdkun@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #92 from Barton Chittenden <barton at bywatersolutions.com> ---
Created attachment 37279
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37279&action=edit
Marc file containing record with UTF-8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:03:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:03:49 +0000
Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when
 exporting batch label to PDF
In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8375-70-dW1ERENm3Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #93 from Barton Chittenden <barton at bywatersolutions.com> ---
Steps to re-create bug:

1) Import 'Marc file containing record with UTF-8', create item record.
   [the record has a title containing 0xe28099 ]
2) Go to Tools->Labels, click 'New Batch' button.
3) Add barcode of item created in step 1.
4) Click 'Manage Batches'
5) Select the check-box for the new batch
6) Click 'Export'
7) Select a layout which contains the 'Title' field
8) Click 'Export'
9) Click 'Download as PDF'

The exported PDF will read as follows:

<h1>Software error:</h1>
<pre>Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820.
</pre>
<p>
For help, please send mail to the webmaster (<a
href="mailto:staff at bywatersolutions.com">staff at bywatersolutions.com</a>),
giving this error message 
and the time and date of the error.

</p>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:11:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:11:16 +0000
Subject: [Koha-bugs] [Bug 7391] Return to cart after adding items to a list
In-Reply-To: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7391-70-WEGl7Fiepn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7391

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:11:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:11:19 +0000
Subject: [Koha-bugs] [Bug 7391] Return to cart after adding items to a list
In-Reply-To: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7391-70-w11TkTFKKB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7391

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37280
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37280&action=edit
Bug 7391: Return to cart after adding items to a list

If you select items in your cart and choose to add them to a list, upon
completion of the transaction the pop-up window, which was originally
opened for the cart, is closed. Instead you should be returned to the
Cart view.

Test plan:
Confirm the expected behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:11:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:11:29 +0000
Subject: [Koha-bugs] [Bug 7391] Return to cart after adding items to a list
In-Reply-To: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7391-70-kLufLcNh3I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7391

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart at biblibre.co
                   |                            |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:11:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:11:34 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-4VPdz6wQgl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Hi Jonathan,

I can reproduce it with:
Debian:
Iceweasel 24.7.0

Win 8:
Firefox 36.0.4
Chrome 41.0.2272.01
IE 11.0.17

To reproduce:
Click on Show/hide colums. Staff client window turns gray/transparent. Directly
go to the right border of the browser window and drag browser window to become
smaller.

Result: Button "Show/hide" columns is sticky to the right border of browser
window and moves with it (float right), but the list with the checkboxes keeps
it's position and disappears at the right outside the browser window (like on
the screenshot).

To put them under the button again, click twice on "Show/hide columns".

Ah, if I click somewhere inside the browser window before dragging, the
checkboxes are hidden and the window turns white. Maybe the same should happen
if the browser window is resized?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:14:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:14:35 +0000
Subject: [Koha-bugs] [Bug 8149] Deleting Records/Biblios Omnibus
In-Reply-To: <bug-8149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8149-70-z5tR3LVsqe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8149
Bug 8149 depends on bug 7258, which changed state.

Bug 7258 Summary: Cannot delete a title from a list if the bibliographic record has been deleted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7258

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:14:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:14:35 +0000
Subject: [Koha-bugs] [Bug 7258] Cannot delete a title from a list if the
 bibliographic record has been deleted
In-Reply-To: <bug-7258-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7258-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7258-70-Fu9GGljofQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7258

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Seems to be fixed, please reopen if I am wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:15:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:15:58 +0000
Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL
 even if turned off by system preference
In-Reply-To: <bug-13917-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13917-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13917-70-0yTyoXZzrA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:18:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:18:15 +0000
Subject: [Koha-bugs] [Bug 7214] Changing framework with 'edit as duplicate'
 can cause data loss
In-Reply-To: <bug-7214-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7214-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7214-70-UkEpwjVVK7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7214

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
             Status|NEW                         |RESOLVED

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:25:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:25:31 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-f4pWGfFHLj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37214|0                           |1
        is obsolete|                            |

--- Comment #12 from Winona Salesky <wsalesky at gmail.com> ---
Created attachment 37281
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37281&action=edit
Bug 13383 - RDA: 100/110/111 changes to XSLT

Test plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 100,110,111
4) Perform an opac search that would show the record in the search results.
5) Click title to review record.
6) Note the fields updates 100,110,111 to show subfields a,b,c,d,q and
t.Multiple fields are separated by span class=separator |.
7) Repeat steps 4 - 6 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:25:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:25:29 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-USjS3cK7nz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

Winona Salesky <wsalesky at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:27:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:27:12 +0000
Subject: [Koha-bugs] [Bug 5844] Unhilight cuts off some strings
In-Reply-To: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5844-70-Pgzl1U38lM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 37282
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37282&action=edit
[Signed-off] Bug 5844: Avoid strings cut on unhighlighing

If a user is searching for several words and that one is contained in
another ( "mag ma" ), some characters are cut (removed from the DOM!).

To reproduce:
1/ search for "mag ma m"
2/ The result page contains "Magazine"
3/ "Mag" is highlighted
4/ Click on the "Unhighlight" link
5/ The "Magazine" words become "azine", "Mag" has been cut.
There is no way to show these characters again.

Test plan:
1/ Confirm the bad behavior without this patch
2/ Apply this patch
3/ search for "mag ma m"
4/ The result page contains "Magazine"
5/ "Mag" is highlighted
6/ Click on the "Unhighlight" link
7/ strings are unhighlighted and still in the DOM :)

Note that the Highlight link won't work very well (only "a" will be
highlighted, but considered as minor since this did not work before the
patch neither).

Followed test plan. Strings are no longer cut when unhiglighted.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:27:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:27:39 +0000
Subject: [Koha-bugs] [Bug 5844] Unhilight cuts off some strings
In-Reply-To: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5844-70-zWzLvtnG4n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37273|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:27:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:27:58 +0000
Subject: [Koha-bugs] [Bug 5844] Unhilight cuts off some strings
In-Reply-To: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5844-70-iZ0aSgQh32@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:30:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:30:20 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-LVgdCSQI0O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

--- Comment #13 from Winona Salesky <wsalesky at gmail.com> ---
This should address the issues with the relator codes and terms.

Thanks,
-Winona

(In reply to Winona Salesky from comment #12)
> Created attachment 37281 [details] [review]
> Bug 13383 - RDA: 100/110/111 changes to XSLT
> 
> Test plan:
> 1) Apply this patch
> 2) Ensure you are using the default XSLT setting for the staff and opac
> search results and record details
> 3) Find or create a record with MARC tags 100,110,111
> 4) Perform an opac search that would show the record in the search results.
> 5) Click title to review record.
> 6) Note the fields updates 100,110,111 to show subfields a,b,c,d,q and
> t.Multiple fields are separated by span class=separator |.
> 7) Repeat steps 4 - 6 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:35:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:35:20 +0000
Subject: [Koha-bugs] [Bug 7391] Return to cart after adding items to a list
In-Reply-To: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7391-70-qR4FGniCe8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7391

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 37283
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37283&action=edit
[Signed-off] Bug 7391: Return to cart after adding items to a list

If you select items in your cart and choose to add them to a list, upon
completion of the transaction the pop-up window, which was originally
opened for the cart, is closed. Instead you should be returned to the
Cart view.

Test plan:
Confirm the expected behavior.

Confirmed.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:35:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:35:41 +0000
Subject: [Koha-bugs] [Bug 7391] Return to cart after adding items to a list
In-Reply-To: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7391-70-60I7SauYJB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7391

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:35:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:35:56 +0000
Subject: [Koha-bugs] [Bug 7391] Return to cart after adding items to a list
In-Reply-To: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7391-70-uAFRFanMlB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7391

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37280|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:43:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:43:18 +0000
Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL
	languages
In-Reply-To: <bug-12068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12068-70-mO6RoXbPCb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068
Bug 12068 depends on bug 8375, which changed state.

Bug 8375 Summary: Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:43:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:43:17 +0000
Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when
 exporting batch label to PDF
In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8375-70-YGXUJkwUdF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #94 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to Barton Chittenden from comment #91)
> Under 3.19.00.016, printing the title field containing RIGHT SINGLE
> QUOTATION MARK (UTF-8 0xe28099) causes the following text to be written to
> the PDF file.
> 
> <h1>Software error:</h1>
> <pre>Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820.
> </pre>
> <p>
> For help, please send mail to the webmaster (<a
> href="mailto:staff at bywatersolutions.com">staff at bywatersolutions.com</a>),
> giving this error message 
> and the time and date of the error.
> 
> </p>

This is unrelated to this bug, Please open a new bug for it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 16:56:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 15:56:36 +0000
Subject: [Koha-bugs] [Bug 7136] language inconsistency on serials status
In-Reply-To: <bug-7136-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7136-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7136-70-IYBNxAODnP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com,
                   |                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org
          Component|Templates                   |Serials

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:00:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:00:21 +0000
Subject: [Koha-bugs] [Bug 7118] Any and empty entries in pull downs for
 suggestion filters
In-Reply-To: <bug-7118-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7118-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7118-70-4vt3cXiRgE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7118

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Looks good now, please reopen if I am wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:02:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:02:41 +0000
Subject: [Koha-bugs] [Bug 7050] Error in French web installer -
	sample_labels.sql
In-Reply-To: <bug-7050-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7050-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7050-70-7KsWLCZGzx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7050

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m,
                   |                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:04:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:04:18 +0000
Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull
	down
In-Reply-To: <bug-7046-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7046-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7046-70-kXKcKv6YOl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m,
                   |                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:06:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:06:22 +0000
Subject: [Koha-bugs] [Bug 7012] Limit to available does not exclude
	in-transit items
In-Reply-To: <bug-7012-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7012-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7012-70-DiihutGo8i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=9253

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:06:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:06:22 +0000
Subject: [Koha-bugs] [Bug 9253] If an item is reserved,
 at the opac it is marked as available
In-Reply-To: <bug-9253-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9253-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9253-70-a9Sf71dV4E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=7012

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:13:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:13:45 +0000
Subject: [Koha-bugs] [Bug 6993] Incorrect data type in
	auth_subfield_structure
In-Reply-To: <bug-6993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6993-70-ldqyNJGSAf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6993

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
For information:

MariaDB [koha]> INSERT INTO `auth_subfield_structure` (`authtypecode`,
`tagfield`, `tagsubfield`, `liblibrarian`, `libopac`, `repeatable`,
`mandatory`, `tab`, `authorised_value`, `value_builder`, `seealso`, `isu
rl`, `hidden`, `linkid`, `kohafield`, `frameworkcode`) VALUES
    -> ('', '000', '@', 'fixed length control field', 'fixed length control
field', 0, 1, 0, NULL, 'marc21_leader_authorities.pl', NULL, 0, 0, '', '', ''); 
Query OK, 1 row affected, 1 warning (0.08 sec)

MariaDB [koha]> show warnings;
+---------+------+----------------------------------------------------------+
| Level   | Code | Message                                                  |
+---------+------+----------------------------------------------------------+
| Warning | 1366 | Incorrect integer value: '' for column 'linkid' at row 1 |
+---------+------+----------------------------------------------------------+
1 row in set (0.00 sec)

MariaDB [koha]> select linkid from auth_subfield_structure where
tagfield='000';
+--------+
| linkid |
+--------+
|      0 |
+--------+
1 row in set (0.00 sec)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:14:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:14:46 +0000
Subject: [Koha-bugs] [Bug 6993] Incorrect data type in
	auth_subfield_structure
In-Reply-To: <bug-6993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6993-70-rSeoy3c3pY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6993

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |minor

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Not critical at all, considered as minor. Feel free to change it if you
disagree.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:17:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:17:20 +0000
Subject: [Koha-bugs] [Bug 13919] New: Renewal possible with item level hold
	on item
Message-ID: <bug-13919-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919

            Bug ID: 13919
           Summary: Renewal possible with item level hold on item
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Tested in 3.18.5.1:

- item is checked out to patron A
- patron B places an item level hold on the item
- patron A renews all - item is renewed :(

Can someone confirm? I think there is no configuration option that should allow
this, but maybe I am missing something.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:22:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:22:25 +0000
Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on
	item
In-Reply-To: <bug-13919-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13919-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13919-70-t93YsqoAQm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This also affects the staff interface: when checking out the item again to
another user, I get a warning that there is a hold. I override that and check
it out anyway - and I am offfered the option to renew it.

Soemthing is seriously going wrong here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:24:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:24:59 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-dpmzv5nLwg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37284
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37284&action=edit
Bug 6950: Make the resort working when searching for a tag

If you click a link from the Tag Cloud, the results page offers the
usual select menu to resort your results. However, doing so resubmits
the search as a standard keyword search.

Test plan:
1/ Click on a tag
2/ Use the resort dropdown list to change the sort
3/ Confirm that the results are relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:24:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:24:56 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-4zqpxCapfz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:25:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:25:17 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-a7AzWpdKPX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart at biblibre.co
                   |                            |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:41:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:41:19 +0000
Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on
	item
In-Reply-To: <bug-13919-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13919-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13919-70-nDk9NeN7uJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
In my setup it's AllowRenewalIfOtherItemsAvailable that makes the difference.

Switching that makes the difference between seeing the checkbox in the OPAC and
the 'on hold' message in the staff client.

I understood it should only allow renewal if items are available to fill the
hold - so I think this is a bug, as the other existing item can't fill the hold
here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 17:46:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 16:46:24 +0000
Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when
 exporting batch label to PDF
In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8375-70-JP90GJsz7X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #95 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 37285
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37285&action=edit
UTF-8 Quotes

Hi, on current master it works for me (see the screenshot)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 18:18:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 17:18:19 +0000
Subject: [Koha-bugs] [Bug 2389] overdue_notices.pl needs a test mode
In-Reply-To: <bug-2389-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2389-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2389-70-uY7WZwoz0G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2389

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:01:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 18:01:28 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-9hxEKwgmBV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Applied patch
In OPAC, went to Tag cloud, clicked on tag 'Geneva'

Two biblios are tagged with Geneva:

Rollo in Geneva
by Abbott, Jacob, 1803-1879. 

Mystery at Geneva An Improbable Tale of Singular Happenings
by Macaulay, Rose, 1881-1958. 

Seems to be sorted by Author ( Abbot < Macaulay )

The link reads:
...cgi-bin/koha/opac-search.pl?tag=Geneva&q=Geneva

At top right, I click on sorting by Title. 
This should change the display (Mystery < Rollo)

Page reloads
I have still first Rollo, then Mystery

The link reads now:
/cgi-bin/koha/opac-search.pl?idx=kw&q=Geneva&sort_by=title_az&tag=Geneva&addto=Add+to...&biblionumber=4673&biblionumber=44150&newtag44150=

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:25:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 18:25:18 +0000
Subject: [Koha-bugs] [Bug 8701] Help for OpacHiddenItems pref should not
 point to text in install directory
In-Reply-To: <bug-8701-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8701-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8701-70-wOaYgKhoIi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:37:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 18:37:23 +0000
Subject: [Koha-bugs] [Bug 13920] New: API authentication system - proposal
Message-ID: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

            Bug ID: 13920
           Summary: API authentication system - proposal
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: new feature
          Priority: P5 - low
         Component: Web services
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Before adding too many routes to the new API, I want to propose an
authentication system for this API.
Detailed description will follow in patches messages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:40:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 18:40:30 +0000
Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal
In-Reply-To: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13920-70-kYhPBjbzoR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 37286
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37286&action=edit
Bug 13920: API Authentication, part 1: API keys management in interface

This introduces the concept of API keys for use in the new REST API.
A key is a string of 32 alphanumerical characters (32 is purely
arbitrary, it can be changed easily).
A user can have multiple keys (unlimited at the moment)
Keys can be generated automatically, and then we have the possibility to
delete or revoke each one individually.

Test plan:
1/ Go to staff interface
2/ Go to a borrower page
3/ In toolbar, click on More -> Manage API keys
4/ Click on "Generate new key" multiple times, check that they are
   correctly displayed under the button, and they are active by default
5/ Revoke some keys, check that they are not active anymore
6/ Delete some keys, check that they disappear from table
7/ Go to opac interface, log in
8/ In your user account pages, you now have a new tab to the left "your
   API keys". Click on it.
9/ Repeat steps 4-6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:40:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 18:40:33 +0000
Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal
In-Reply-To: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13920-70-aVFhmGAjL4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 37287
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37287&action=edit
Bug 13920: API Authentication, part 2: implement authentication in API

For authentication to succeed, the client have to send 3 custom HTTP
headers:
 - X-Koha-Username: userid of borrower
 - X-Koha-Timestamp: timestamp of the request
 - X-Koha-Signature: signature of the request

The signature is a HMAC-SHA256 hash of several elements of the request,
separated by spaces:
 - HTTP method (uppercase)
 - URL path and query string
 - username
 - timestamp of the request

The server then tries to rebuild the signature with each user's API key.
If one matches the received X-Koha-Signature, then authentication is
almost OK.

To avoid requests to be replayed, the last request's timestamp is stored
in database and the authentication succeeds only if the stored timestamp
is lesser than X-Koha-Timestamp.

This patch implements both server-side authentication (in
Koha/REST/V1.pm) and client-side authentication in Swagger UI
(api/v1/doc/index.html).

There is also an "anonymous" mode if X-Koha-* headers are not set.
Anonymous mode differ from authenticated mode in one thing: if user is
authenticated, the corresponding Koha::Borrower object is stored in
Mojolicious stash, so it can easily be retrieved by controllers.
Controllers then have the responsability of what to do if user is
authenticated or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:40:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 18:40:36 +0000
Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal
In-Reply-To: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13920-70-wGtYDnAnCi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 37288
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37288&action=edit
[DO NOT PUSH] Bug 13920: Example usage for api authentication

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:40:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 18:40:46 +0000
Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal
In-Reply-To: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13920-70-hkTHxaXE0J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13799

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:40:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 18:40:46 +0000
Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API
In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13799-70-PpOEUILu3t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13920

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 19:45:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 18:45:13 +0000
Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal
In-Reply-To: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13920-70-MMql94511M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
2nd test plan:
1/ Go to http://api.YOURLIBRARY/v1/doc
2/ Try route /borrowers/{borrowernumber} and see you have a 401 (Unauthorized)
error
3/ Generate an API key (like described in 1st test plan) for a user that have
the 'borrowers' permission
4/ Fill 'username' and 'api_key' inputs at the top of the Swagger UI page and
retry /borrowers/{borrowernumber}. You should have a 200 status and the json
representation of a borrower (if it exists)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:17:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 20:17:22 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-X5KrjnmotW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #6 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 37289
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37289&action=edit
Bug 8612 - System preference to have custom fields in export csv basket

This patch allows the user use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

To test:

1) Apply the patch;
2) Create a CSV export profile - type sql -  Home ? Tools ? CSV export profiles
  ex:
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) Create a new basket and add an order to the basket
4) Validate: the text "Select CSV profile:" and a dropdown in the basket view
5) In the new dropdown, select the CSV export profile created
6) Validate the CSV file.
7) Do the same validation with a closed basket.
 a) close the basket
 b) View the basket
 c) validate that there is a dropdown
 d) test it with an export

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:19:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 20:19:30 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-WWMRrW4Mjm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36860|0                           |1
        is obsolete|                            |

--- Comment #7 from Blou <philippe.blouin at inlibro.com> ---
Comment on attachment 36860
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36860
Bug 8612 - System preference to have custom fields in exort csv basket

The left panel was removed by this patch, and it when used on a closed basket
it caused a crash.  These are fixed by the latest version.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:20:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 20:20:04 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-OBl9XOXpKf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:20:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 20:20:29 +0000
Subject: [Koha-bugs] [Bug 13921] New: XSLT Literary Formats Not Showing
Message-ID: <bug-13921-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

            Bug ID: 13921
           Summary: XSLT Literary Formats Not Showing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 37290
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37290&action=edit
blank literary form

It appears that not all literary forms show on the search results in staff or
OPAC.  Poetry and Mixed forms were the ones I tested but I've never seen
anything other than Fiction and Nonfiction.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 21:20:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 20:20:51 +0000
Subject: [Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing
In-Reply-To: <bug-13921-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13921-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13921-70-tnTzyNuYW4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37291
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37291&action=edit
poetry is selected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:03:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 21:03:16 +0000
Subject: [Koha-bugs] [Bug 13922] New: MODS Export Broken on Package
Message-ID: <bug-13922-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13922

            Bug ID: 13922
           Summary: MODS Export Broken on Package
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl, oleonard at myacpl.org

When trying to export using MODS you will get this error:

Software error:

Can't locate object method "code" via package "Could not create file parser
context for file
"/usr/share/koha/intranet/cgi-bin/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS.xsl":
No such file or directory at /usr/share/koha/opac/cgi-bin/opac/unapi line 207.
" (perhaps you forgot to load "Could not create file parser context for file
"/usr/share/koha/intranet/cgi-bin/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS.xsl":
No such file or directory at /usr/share/koha/opac/cgi-bin/opac/unapi line 207.
"?) at /usr/share/koha/opac/cgi-bin/opac/unapi line 150.




It looks like a path issue.  It is looking for:

/usr/share/koha/intranet/cgi-bin/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS.xsl

But the correct path appears to be:

/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2MODS.xsl

The incorrect path does appear to be a mix of package and git paths.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:11:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 21:11:54 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-tnXqGWS8Oy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #8 from Mike <black23 at gmail.com> ---
Hello Biou,
thanks for this pattch. I tested it in sandbox but get some messs with some
character for example "?". But not for all characters in natioanl alphabet. We
need more tests. 

I confirm that patch works with open or close basket.

Mike

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:42:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 21:42:04 +0000
Subject: [Koha-bugs] [Bug 13922] MODS Export Broken on Package
In-Reply-To: <bug-13922-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13922-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13922-70-vYQpPYc49T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13922

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
Okay, I did a little more checking. The bug appears to be in
/usr/share/koha/opac/cgi-bin/opac/unapi, line 201. It's concatenating the value
of 'intranetdir' with "/koha-tmpl/intranet-tmpl/prog/en/xslt/", which is what
is leading to the incorrect path.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 22:49:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 21:49:17 +0000
Subject: [Koha-bugs] [Bug 13922] MODS Export Broken on Package
In-Reply-To: <bug-13922-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13922-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13922-70-f52jz3L97m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13922

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Nicole C. Engard from comment #1)
> Okay, I did a little more checking. The bug appears to be in
> /usr/share/koha/opac/cgi-bin/opac/unapi, line 201. It's concatenating the
> value of 'intranetdir' with "/koha-tmpl/intranet-tmpl/prog/en/xslt/", which
> is what is leading to the incorrect path.

There's a function that specifically chooses the correct path. It should use
it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Mar 26 23:49:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 22:49:17 +0000
Subject: [Koha-bugs] [Bug 5617] fix-perl-path.pl misses some files
In-Reply-To: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5617-70-3jbpsXlb36@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5617

--- Comment #8 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #7)
> Tomas, Robin,
> 
> I thought this one was easy to fix replacing the current shebang with
> /usr/bin/env perl
> But it seems there are a lot of pros and cons
> (https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58 for
> instance).
> 
> Could I get your opinion on this?

I don't have a strong opinion, but I think we probably shouldn't go with
/usr/bin/env based on that thread. If the problem is that fix-perl-path.pl is
missing some files, then that should probably be fixed to use file(1) or grep
or something to detect what needs to be changed.

Would it be better to have MakeMaker do its thing and let it take care of the
problem? In that case, rerunning the install would have sorted it, and I don't
think that's too high of a bar when you're dealing with rolling with a custom
perl.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:19:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 23:19:44 +0000
Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the
 database for managing permission descriptions
In-Reply-To: <bug-13632-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13632-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13632-70-aTKONt9IJq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|dcook at prosentient.com.au    |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #22 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #17)
> It's not so much a translation thing - Bernardo already has provided the fix
> for that, but a maintenance/web installer problem.
> 
> The web installer will use the files in the language directory from the
> language you picked at the beginning of the installation process. There is
> no fallback to en if a file is missing.
> 
> So currently, when a new permission is added, we have to maintain not one
> central file, but the en file plus all translated files. Not good. 
> 
> For systempreferences the web installer knows that sysprefs.sql is
> mandatory, even tho it lives outside of the web installer files. I think
> maybe we can handle the permissions file the same way. One file - always
> installed independent of the picked language.

I think I understand this problem now... and I don't have an immediate solution
off the top of my head. 

I'm going to reset the assignee to default, as I probably won't have time to
work on this again. 

Jonathan, if you're still interested in this bug, please feel free to take it
over :).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 00:49:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 26 Mar 2015 23:49:37 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-Xo4sHPKuq4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #127 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Srdjan,

spotted some problems with the follow-up:

- With the patch t/db_dependent/Search.t fails 2 tests
- As this change a core routine now, we should have new unit tests for it
- It would help testing if you could include some notes about what the code
  is supposed to do and a little test plan
- I see a mismatch between the display in the result list and the 
  detail page. Example:
  * record with 1 item, 
  * on shelf holds are allowed
  * user is logged in
  - result page: no hold link shows
  - detail page: hold link shows
  I failed to make the place hold link show up :(


Good news:
- opac search no longer shows a perl error
- opac detail page - normal, marc and isbd view seem to work correctly
- staff search seems ok
- cataloging search as well

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:21:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 00:21:44 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-tvGdWEdpvO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:21:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 00:21:47 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-aIkZetYJzz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37263|0                           |1
        is obsolete|                            |

--- Comment #128 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 37292
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37292&action=edit
Bug 5786: Correction: Removed erroneous holdability check from opac-search.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:34:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 00:34:02 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-HwmVVZEWo6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #129 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
I see. Unfortunately, I have no quick solutions for that. I hate doing this,
but the only thing I can think of to push this to the release is to cheat.
I have removed the extra check, and it will err on the other side so I presume
there will be some cases when things will show on the search screen as
holdable, while it will be "No holds available" on the details page.
I suggest we keep it like that, and file a bug to fix holdable checkbox
appearing when it shouldn't be.
Otherwise I can try to fix it, but it is unlikely to meet the deadline. And I
may go into meltdown if this is pulled out :)

Tell me your thoughts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:41:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 00:41:35 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-VCcrHLYz7a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #130 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd like to avoid any meltdowns :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:44:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 00:44:57 +0000
Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken
In-Reply-To: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13744-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13744-70-zZOCFl8Ti5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com
           Keywords|                            |rel_3_16_candidate

--- Comment #15 from Mason James <mtj at kohaaloha.com> ---
Possible selection for 3.16.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 01:53:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 00:53:27 +0000
Subject: [Koha-bugs] [Bug 13784] Allow running Zebra daemon for disabled
 instances in packages
In-Reply-To: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13784-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13784-70-CRv24VF0Z2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #14 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

nice one Larry :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:32:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 01:32:41 +0000
Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not
 scanned" statuses
In-Reply-To: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12631-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12631-70-BfTXymufrA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #12 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:37:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 01:37:45 +0000
Subject: [Koha-bugs] [Bug 13804] Returns via the checkouts tables uses the
 phrase "Returned" rather than "Checked in"
In-Reply-To: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13804-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13804-70-zetdQsMy5z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13804

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #7 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 02:39:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 01:39:43 +0000
Subject: [Koha-bugs] [Bug 11364] Label layout types and text justification
 types are not translatable
In-Reply-To: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11364-70-SCNBQlYnm6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 03:18:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 02:18:06 +0000
Subject: [Koha-bugs] [Bug 13785] koha-disable should also stop
 SIP/Zebra/Indexer for instance
In-Reply-To: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13785-70-smKvTHSkua@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #9 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:32:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 03:32:09 +0000
Subject: [Koha-bugs] [Bug 13746] On creating a new subscription,
 notes fields get confused
In-Reply-To: <bug-13746-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13746-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13746-70-GxaxMOXoF0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com
           Keywords|                            |rel_3_16_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:33:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 03:33:38 +0000
Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item
	form
In-Reply-To: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13648-70-XKlWpeo4LQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #8 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:38:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 03:38:10 +0000
Subject: [Koha-bugs] [Bug 13814] Add unit tests for C4::Boolean
In-Reply-To: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13814-70-tkeWfePYEO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13814

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #12 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 04:50:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 03:50:10 +0000
Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32
In-Reply-To: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13586-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13586-70-wIEz0zgn7z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #13 from Mason James <mtj at kohaaloha.com> ---
Pushed to 3.16.x, will be in 3.16.9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:21:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 07:21:27 +0000
Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for
 checking in items that are not checked out
In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13411-70-bfWDXoTLaM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #17 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Actually,as Kyle mentioned above I'm also not entirely sure the current
implementation is correct as to the SIP2 standard. Checkin is not limited to
checked out items, it is, the way I see it,the only way for an ACS to validate
the circulation status of an item. (hold,wrong branch,in transfer, etc.)
Compare this to a package delivery service where every point involves a
checkin.

Any critical error in the process should fail the checkin response and give a
suitable feedback.

The "checked_in_ok" param from SIPConfig.xml is used as param in the checkin
routine and fallbacks to old behaviour (item not checked out) if unset.
Kyle,please correct me if wrong.

This bug is actually a showstopper for us (50+ self-check machines and book
sorting device) so I hope it can be resolved shortly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:59:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 07:59:18 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-2QrkVNR5FG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 37293
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37293&action=edit
[SIGNED-OFF] Bug 8612 - System preference to have custom fields in export csv
basket

This patch allows the user use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

To test:

1) Apply the patch;
2) Create a CSV export profile - type sql -  Home ? Tools ? CSV export profiles
  ex:
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) Create a new basket and add an order to the basket
4) Validate: the text "Select CSV profile:" and a dropdown in the basket view
5) In the new dropdown, select the CSV export profile created
6) Validate the CSV file.
7) Do the same validation with a closed basket.
 a) close the basket
 b) View the basket
 c) validate that there is a dropdown
 d) test it with an export

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Works as expected for me

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 08:59:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 07:59:43 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-suENtxZgB0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:00:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 08:00:47 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-ULsLo8OMiD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37289|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:30:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 08:30:12 +0000
Subject: [Koha-bugs] [Bug 5617] fix-perl-path.pl misses some files
In-Reply-To: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5617-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5617-70-eOni45pNJT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5617

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|rel_3_2                     |master

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Robin Sheat from comment #8)
> I don't have a strong opinion, but I think we probably shouldn't go with
> /usr/bin/env based on that thread. If the problem is that fix-perl-path.pl
> is missing some files, then that should probably be fixed to use file(1) or
> grep or something to detect what needs to be changed.
> 
> Would it be better to have MakeMaker do its thing and let it take care of
> the problem? In that case, rerunning the install would have sorted it, and I
> don't think that's too high of a bar when you're dealing with rolling with a
> custom perl.

Ok thanks.
I don't know if it is worth spending time on it, nobody has reported this
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 09:42:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 08:42:00 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-iJPi1aWy0A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Ok I think I reproduce it.
I click on the "show/hide", resize the window, and indeed the list is not
moving.
But if I click somewhere and click again on the "show/hide" button, the list is
at the right place.
IMO it's not a bug at all :)
Anyhow I cannot do anything to fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:06:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:06:43 +0000
Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms
In-Reply-To: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6911-70-fQBjWMyh9I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:06:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:06:46 +0000
Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms
In-Reply-To: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6911-70-96hXPZpFyb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37294
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37294&action=edit
Bug 6911: Remember search terms in the log viewer tool

The modules and actions selected by the user are now selected when a
log search is done.
Note that this patch also add the multiple attribute to the actions
select in order to add the ability to select several actions.
The code to do that already existed.

Test plan:
1/ Go on the log viewer tool (tools/viewlog.pl)
2/ Launch a search with modules and actions selected.
3/ Confirm that the values you have selected is still selected after the
search.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:06:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:06:58 +0000
Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms
In-Reply-To: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6911-70-BIJxfjy4H2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:07:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:07:20 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-f0mWvBALfY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36256|0                           |1
        is obsolete|                            |

--- Comment #21 from Marc V?ron <veron at veron.ch> ---
Created attachment 37295
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37295&action=edit
Bug 4041 - Second Step: Add system preference and "German style" address
formats for staff

To test:

Apply patch
Do a database update (e.g. by changing version number in kohaversion.pl)
Find new system preference 'addressformat' in I18N/L10N
Choose 'German style'
Go to Patrons and edit a patron / create new patron
Verify that Zip code appears above City
Change system preference to 'US style'
Verify that Zip code appears between State and Country.

BTW: New formats can be added by editing i18n_l10n.pref (add a new code, e.g.
fr for "French style") and copy / modify the includes using the same code as
postfix.
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

Patch amended to move street number after address. /Marc

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

Amended do resolve conflict with updatedatabase.pl  /Marc

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:10:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:10:38 +0000
Subject: [Koha-bugs] [Bug 6820] hide receive option if there is nothing to
	receive
In-Reply-To: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6820-70-LD8aKEjBmf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:10:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:10:40 +0000
Subject: [Koha-bugs] [Bug 6820] hide receive option if there is nothing to
	receive
In-Reply-To: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6820-70-ZaCf5AElB2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23920|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37296
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37296&action=edit
Bug 6820 - hide receive option if there is nothing to receive

The "receive shipment" button appears even if there are no orders to receive.
This patch hides the button if there are no orders.

To test the patch:
1. Go to "aquisitions"
2. Create a vendor
3. As the newly created vendor has no orders, there will now be no "receive
shipment" button
4. Create a basket
5. Go back to the vendor search
6. The button should now appear for that vendor

I've also tested it with a mix of vendors with and without baskets in the same
search.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:17:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:17:46 +0000
Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system
	preference
In-Reply-To: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4041-70-c7e2YHpXPs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36353|0                           |1
        is obsolete|                            |

--- Comment #22 from Marc V?ron <veron at veron.ch> ---
Created attachment 37297
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37297&action=edit
Bug 4041 - Third step - Display address on patron's pages using the system
preference

This patch displays the address information in the left column of the patron's
pages using the new system preference.
The address is formatted in member-display-address-style-us.inc and
member-display-address-style-de.inc

To test:
- Apply patch on top of 1st and 2nd patch
- Select 'German style' in system preference 'addressformat' in I18N/L10N
- Verify that the address information displays properly in the left column of
all patron's pages.
- Verify that the address displays properly in the main area of moremember.pl
as well (Note: In right column, Alternate address /contact are not yet
touched))
- Switch system preference to US style, repeat checks

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
AMending without changes to put this patch at the end of the patch list / Marc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:21:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:21:29 +0000
Subject: [Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success
In-Reply-To: <bug-6756-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6756-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6756-70-FHuMRHU109@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
What do you suggest?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:25:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:25:14 +0000
Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving
In-Reply-To: <bug-11141-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11141-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11141-70-BjyatyoBHo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
*** Bug 6741 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:25:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:25:14 +0000
Subject: [Koha-bugs] [Bug 6741] when receiving orders the filter clears
	after receiving
In-Reply-To: <bug-6741-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6741-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6741-70-tqkAzfd94f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6741

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---


*** This bug has been marked as a duplicate of bug 11141 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:26:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:26:44 +0000
Subject: [Koha-bugs] [Bug 6731] amounts not changing if budgeted amount
	changed
In-Reply-To: <bug-6731-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6731-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6731-70-hdxMXsvwbA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6731

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
             Status|NEW                         |RESOLVED

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This is fixed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:32:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:32:00 +0000
Subject: [Koha-bugs] [Bug 6729] block received order lines from editing
In-Reply-To: <bug-6729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6729-70-ZxgqM7aNLj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6729

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Note sure this is a bug.

(In reply to Nicole C. Engard from comment #0)
> that could cause problems if done by the wrong person.

Maybe you can play with permissions?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:44:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:44:22 +0000
Subject: [Koha-bugs] [Bug 13916] NORMARC can have analytics with leader 07 =
	a, b or p
In-Reply-To: <bug-13916-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13916-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13916-70-g2vAOcUSW1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13916

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:44:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:44:24 +0000
Subject: [Koha-bugs] [Bug 13916] NORMARC can have analytics with leader 07 =
	a, b or p
In-Reply-To: <bug-13916-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13916-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13916-70-8wAi0fHeG5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13916

--- Comment #1 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 37298
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37298&action=edit
Bug 13916 - NORMARC can have leader 07 = a, b or p

When a NORMARC record has leader 07 = s and "Show analytics"
links are generated, they look like this:

http://example.com/cgi-bin/koha/opac-search.pl?q=rcn:832083305+and+(bib-level:a+or+bib-level:b)

But NORMARC has three different types of analytics that can
be indicated in 07: a, b and p

So the links should look like this:

http://example.com/cgi-bin/koha/opac-search.pl?q=rcn:832083305+and+(bib-level:a+or+bib-level:b+or+bib-level:p)

To test:

- Create two records as described here:
  http://wiki.koha-community.org/wiki/Analytics
- Make sure you have leader position 07 = p
- Make sure the records are indexed
- Click on the "Show analytics" link from the host to the article record
- Verify that the article record is not found
- Apply the patch
- Click on the "Show analytics" link again
- Verify that the article record is now found

Or just read the patch and check that it makes sense in light of the fact that
NORMARC can have leader position 07 = a, b or p.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:49:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:49:17 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-PJhmvIHyHs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37284|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37299
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37299&action=edit
Bug 6950: Hide the resort option when searching for a tag

If you click a link from the Tag Cloud, the results page offers the
usual select menu to resort your results. However, doing so resubmits
the search as a standard keyword search.

Test plan:
1/ Click on a tag
2/ Confirm that the resort dropdown list does not appear.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:50:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:50:37 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-aGtxvhB0p4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Marc V?ron from comment #2)
Sorry about that, it was a very naive approach and cannot work (I am sure I
have tested!!....)
The last patch only removes the resort option.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:53:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:53:38 +0000
Subject: [Koha-bugs] [Bug 6614] CSV Basket Export gives blank lines
In-Reply-To: <bug-6614-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6614-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6614-70-DvfkLREov7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6614

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Patch pushed and the changes are removed by bug 7302.
Please open a new bug report if the issue still exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:55:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:55:35 +0000
Subject: [Koha-bugs] [Bug 6614] CSV Basket Export gives blank lines
In-Reply-To: <bug-6614-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6614-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6614-70-D0DpxdbIN9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6614

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:57:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:57:13 +0000
Subject: [Koha-bugs] [Bug 6579] getalert SQL invalid for KOHA_USER
In-Reply-To: <bug-6579-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6579-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6579-70-AJ1xECYIBM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6579

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
You are not allowed to use Koha with the DB user.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:59:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:59:04 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-rJs3FihLvz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

--- Comment #9 from Marc V?ron <veron at veron.ch> ---
I agree, the position after resizing is not a bug, it is a cosmetic thing. Will
sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 10:59:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 09:59:40 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-8PoZrMEAh7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
Created attachment 37300
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37300&action=edit
[Signed-off] Bug 13864: Columns configuration - Late orders

This patch adds the ability to hide columns on the late orders page
(acqui/lateorders.pl).

Test plan:
Go on the late orders page and confirm you are able to hide columns.
You can also play with the columns configuration admin page and confirm
that the behaviors are consistent.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:00:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 10:00:06 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-jPGPsWObL9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36980|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 11:01:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 10:01:07 +0000
Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders
In-Reply-To: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13864-70-r1g2NCqypB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:01:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:01:45 +0000
Subject: [Koha-bugs] [Bug 13923] New: Holds tab on the circulation page is
	broken
Message-ID: <bug-13923-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13923

            Bug ID: 13923
           Summary: Holds tab on the circulation page is broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:02:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:02:07 +0000
Subject: [Koha-bugs] [Bug 13923] Holds tab on the circulation page is broken
In-Reply-To: <bug-13923-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13923-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13923-70-IXWeMqkUbC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13923

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11703, 13713

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:02:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:02:07 +0000
Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
In-Reply-To: <bug-11703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11703-70-UznN0miy3O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13923

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:02:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:02:07 +0000
Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in
 Koha::Schema::Result::Biblio
In-Reply-To: <bug-13713-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13713-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13713-70-LwHE8kV5M9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13923

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:04:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:04:42 +0000
Subject: [Koha-bugs] [Bug 13923] Holds tab on the circulation page is broken
In-Reply-To: <bug-13923-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13923-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13923-70-rKT7WzYST0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13923

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:04:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:04:44 +0000
Subject: [Koha-bugs] [Bug 13923] Holds tab on the circulation page is broken
In-Reply-To: <bug-13923-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13923-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13923-70-vSUwX4er48@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13923

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37301
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37301&action=edit
Bug 13923: The prefetch used on existing constraint

The belongs_to constraint has been removed by bug 13713.
Not sure if it was a good idea, but atm the easy and quick way is to
remove the prefetch.

Test plan:
Go on the circulation page, holds tab
Confirm that there is no regression
(Same on the patron details page > Holds tab)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:07:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:07:04 +0000
Subject: [Koha-bugs] [Bug 13923] Holds tab on the circulation page is broken
In-Reply-To: <bug-13923-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13923-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13923-70-PnyIz4eEDw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13923

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:07:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:07:06 +0000
Subject: [Koha-bugs] [Bug 13923] Holds tab on the circulation page is broken
In-Reply-To: <bug-13923-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13923-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13923-70-Kr12oQKd2W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13923

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37301|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37302
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37302&action=edit
[SIGNED-OFF] Bug 13923: The prefetch used on existing constraint

The belongs_to constraint has been removed by bug 13713.
Not sure if it was a good idea, but atm the easy and quick way is to
remove the prefetch.

Test plan:
Go on the circulation page, holds tab
Confirm that there is no regression
(Same on the patron details page > Holds tab)

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:18:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:18:35 +0000
Subject: [Koha-bugs] [Bug 13851] Replace waiting holds logic in
 circulation.pl with Koha Objects
In-Reply-To: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13851-70-1gPynRDZRh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36947|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37303
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37303&action=edit
Bug 13851 - Replace waiting holds logic in circulation.pl with Koha Objects

This is the original patch for bug 12892 and replaces the older style of
fetching the holds data with Koha Objects. It will be used as a
foundation for future features.

Test Plan:
1) Apply this patch
2) Create a hold, set to waiting
3) Browse to circulation.pl for that patron
4) Note you see the list of waiting holds
5) Switch your logged in branch to a different branch
6) Note the "Waiting at" line is no longer emphasized.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:43:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:43:36 +0000
Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export
In-Reply-To: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13695-70-pmXqnaS7nM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:43:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:43:39 +0000
Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export
In-Reply-To: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13695-70-pSL81asaJS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36134|0                           |1
        is obsolete|                            |
  Attachment #36135|0                           |1
        is obsolete|                            |
  Attachment #36136|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37304
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37304&action=edit
[PASSED QA] Bug 13695: Add ISBD to OpacExportOptions

This patch adds 'isbd' as an export option on the system preferences.
Note this patch doesn't add the feature.

To test:
- On master, search for the OpacExportOptions syspref
=> FAIL: There is no ISBD option.
- Apply the patch
- Search for the OpacExportOptions syspref
=> SUCCESS: There is a new ISBD option.

Sponsored-by: Orex Digital

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:43:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:43:47 +0000
Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export
In-Reply-To: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13695-70-fK2sPIRsMR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37305&action=edit
[PASSED QA] Bug 13695: Add ISBD export option to OPAC (detail)

This patch adds the option to export a record (from within the
OPAC record detail page) in the ISBD format.

To test:
- Enable ISBD on the OpacExportOptions syspref
- Look for a record on your opac
- On the detail page, notice there's a new ISBD option for 'Save record'
- Choose ISBD
=> SUCCESS: a file containing the ISBD format for the record is downloaded

Sponsored-by: Orex Digital

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:43:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:43:50 +0000
Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export
In-Reply-To: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13695-70-I31Fo8uppZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37306
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37306&action=edit
[PASSED QA] Bug 13695: Add ISBD export option for the OPAC cart and lists

This patch adds the option to download records from the cart, and
lists in the ISBD format from the OPAC.

To test (cart):
- Apply the patch
- Add several records to your OPAC cart.
- Go to your cart, and choose 'Download'
=> SUCCESS: There's an ISBD option
- Dowload and open the exported records
=> SUCCESS: The file contains the ISBD format for the records on the cart

To test (lists):
- Add several records to a list (i did it from the cart ;-))
- Open the list
- Choose 'Download list'
=> SUCCESS: There's an ISBD option
- Download and open the exported records
=> SUCCESS: The file contains the ISBD format for the records on the list.

- Sign off :-D

Sponsored-by: Orex Digital

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 12:45:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 11:45:12 +0000
Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export
In-Reply-To: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13695-70-NlsL9kJuZy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Looks good. I do think a further enhancement to allow a system preference to
choose the filename suffix would be a good idea ( html vs txt ). But that's
another bug report for another day.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:19:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:19:20 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-FapjOhsOU7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:19:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:19:23 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-eq3Q7MYxyC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37041|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37307
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37307&action=edit
[PASSED QA] Bug 13868: Correct formatting of date on routing list slip

The date planned printed on the issue slip is not formatted
according to the dateformat system preference setting.

To test:
- enable RoutingSerials
- create a subscription
- create a routing list from the serial collection page
- use the 'print list' links next to the issues to print a routing list
- verify that the date there is not displayed according to the dateformat
  system preference without the patch, but is correct with the patch applied

Followed test plan, date appears according to the date format syspref.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:33:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:33:40 +0000
Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
In-Reply-To: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13869-70-3R35m5DFXF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:33:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:33:42 +0000
Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
In-Reply-To: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13869-70-lKbbx8MTEs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37050|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37308
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37308&action=edit
[PASSED QA] Bug 13869: Wrong capitalization of 'Save Report' in guided reports

On the last step of saving a new guided report to the database,
the button is labelled 'Save Report', but should be 'Save report'.

To test:
- Create a new guided report from the reports page
- Check on the very last step, when saving the report to the
  database, the button is labelled 'Save Report'
- With the patch applied, this reads 'Save report' instead

http://bugs.koha-community.org/show_bug.cgi?id=13868

Works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Safe change. Script uses the "phase" variable which remains "Save Report"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:38:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:38:47 +0000
Subject: [Koha-bugs] [Bug 13890] Full serial permission is needed to change
 sequence on a routing list
In-Reply-To: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13890-70-Qihk902pok@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:38:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:38:49 +0000
Subject: [Koha-bugs] [Bug 13890] Full serial permission is needed to change
 sequence on a routing list
In-Reply-To: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13890-70-ZwlWNNkXMU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37099|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37309
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37309&action=edit
[PASSED QA] Bug 13890 - Switch from full serials permission to 'routing'
permission for reordering routing lists

For changing the sequence of patrons on a routing list by changing
one of the numbers via the pull downs, full serial permission is needed:

To test:
- Give your patron full serial permissions
- Create a subscription and a routing list for it
- Change the sequence on the routing list using the pull downs
- Verify this works
- Remove any of the serial sub permissions (claim serials or similar)
- Verify changing the sequence now results in a permission error
- Apply patch
- Verify that the permission error is gone now
- Remove the routing permission
- Verify the permission error is back (but this seems to make sense)

In general more fixes would be required to make all routing related
features depend on the routing permission, but I think this fixes
the bug making it depend on the correct permission.

Followed test plan. Works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:41:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:41:42 +0000
Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged
	records
In-Reply-To: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6520-70-murzXUl2RL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:41:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:41:44 +0000
Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged
	records
In-Reply-To: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6520-70-Phik3s35e4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37310
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37310&action=edit
Bug 6520: Display items for staged record

When records are imported into Koha, the items is stored into the
import_items table.
This marcxml in this table is never retrieved to display items.

Test plan:
1/ Import a records with items
2/ Before importing the batch into the catalog, you can see the marc
of the records, in the table below.
3/ Verify that the items is correctly displayed.

QA note: This patch does not provide test for new subroutines but the
module (C4::ImportBatch) is not tested at all and it will be time
consuming to provide them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:44:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:44:49 +0000
Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged
	records
In-Reply-To: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6520-70-vqOmaEU0SP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37310|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37311
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37311&action=edit
Bug 6520: Display items for staged record

When records are imported into Koha, the items is stored into the
import_items table.
This marcxml in this table is never retrieved to display items.

Test plan:
1/ Import a records with items
2/ Before importing the batch into the catalog, you can see the marc
of the records, in the table below.
3/ Verify that the items is correctly displayed.

QA note: This patch does not provide test for new subroutines but the
module (C4::ImportBatch) is not tested at all and it will be time
consuming to provide them.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:46:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:46:00 +0000
Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged
	records
In-Reply-To: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6520-70-fA6LONVY2x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Tools
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|paul.poulain at biblibre.com   |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:47:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:47:21 +0000
Subject: [Koha-bugs] [Bug 13166] add all restrictions purge to
	cleanup_database.pl
In-Reply-To: <bug-13166-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13166-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13166-70-joD0T9J1f6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13166

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:47:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:47:23 +0000
Subject: [Koha-bugs] [Bug 13166] add all restrictions purge to
	cleanup_database.pl
In-Reply-To: <bug-13166-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13166-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13166-70-2FS87wQ3Gb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13166

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36673|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37312
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37312&action=edit
[PASSED QA] Bug 13166 - add all restrictions purge to cleanup_database.pl

Bug 12760 adds the ability to purge expired restrictions older than some days.

But if you want to purge all expired restrictions, using "--restrictions 0"
does not work, it's like "--restrictions" so it uses default purge days.

This patch adds a new option "--all-restrictions" to purge all expired
restrictions.

Test plan :
- Select a borrower
- Create a restriction with expiration date in the futur
- Create a restriction expired since 1 day
- Create a restriction expired since 10 days
- run without argument "misc/cronjobs/cleanup_database.pl"
=> You see help text for --all-restrictions option
- run "misc/cronjobs/cleanup_database.pl -v --restrictions --all-restrictions"
=> You get the message : You can not specify both --restrictions and
--all-restrictions
- run "misc/cronjobs/cleanup_database.pl -v --restrictions 30"
=> no restriction is removed
- run "misc/cronjobs/cleanup_database.pl -v --restrictions 9"
=> restriction expired since 10 days is removed
- run "misc/cronjobs/cleanup_database.pl -v --all-restrictions"
=> restriction expired since 1 day is removed

Signed-off-by: Larry Baerveldt <larry at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:49:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:49:43 +0000
Subject: [Koha-bugs] [Bug 6515] Advanced notice days not saved when notice
 is not activated (email, sms set)
In-Reply-To: <bug-6515-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6515-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6515-70-tOeayo7ytw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6515

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Now the "days in advance" value is kept even if no checkboxes are checked.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:55:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:55:00 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-o30GWC8qnk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:55:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:55:03 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-O2rMxeg10V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37269|0                           |1
        is obsolete|                            |
  Attachment #37270|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37313
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37313&action=edit
[PASSED QA] Bug 13912 - System preference for default place of publication
(country code) for field 008, range 15-17

Signed-off-by: m23 <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 13:55:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 12:55:10 +0000
Subject: [Koha-bugs] [Bug 13912] System preference for default place of
 publication (country code) for field 008, range 15-17
In-Reply-To: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13912-70-upzeID2mxl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37314
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37314&action=edit
[PASSED QA] Bug 13912 - System preference for default place of publication
(country code) for field 008, range 15-17, followup, repairs the broken link

Signed-off-by: m23 <black23 at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:01:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 13:01:44 +0000
Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for
	performance
In-Reply-To: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13852-70-GWkINSpFOe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:01:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 13:01:46 +0000
Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for
	performance
In-Reply-To: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13852-70-72oNtLM6zH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37002|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37315
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37315&action=edit
[PASSED QA] Bug 13852 - Manage C4::VirtualShelves in C4::Auth for performance

In C4::Auth there is a use C4::VirtualShelves.
Virtualshelves are displayed in all OPAC pages, but not in intranet.
For performance, we should move this into a require only for opac pages.

This patch adds a condition to fetch virtualshelves only if opac and moves the
dependancy on C4::VirtualShelves into require calls.

On my desktop, I have those compilation times for C4/Auth.pm :
- Without patch : 0,41 seconds
- With patch : 0,22 seconds

This performance improvement is very usefull for pages that only use a few as
dependancy, like errors/404.pl

Test plan :
- Be sure there are some public lists
- Apply patch
- Go to opac (not logged-in)
- Click on "Lists"
- Check you see the public lists
- Login with a user
- Be sure this user has some private lists
- Click on "Lists"
- Check you see the public and private lists
- Logout
- Go to /cgi-bin/koha/opac-reserve.pl
- You see the loggin page
- Click on "Lists"
- Check you see the public lists
- Go to intranet
- Check you can loggin

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:38:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 13:38:33 +0000
Subject: [Koha-bugs] [Bug 7391] Return to cart after adding items to a list
In-Reply-To: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7391-70-jcLLz7bYwg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7391

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:38:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 13:38:35 +0000
Subject: [Koha-bugs] [Bug 7391] Return to cart after adding items to a list
In-Reply-To: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7391-70-7fJ4yWQfbh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7391

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37283|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37316
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37316&action=edit
[PASSED QA] Bug 7391: Return to cart after adding items to a list

If you select items in your cart and choose to add them to a list, upon
completion of the transaction the pop-up window, which was originally
opened for the cart, is closed. Instead you should be returned to the
Cart view.

Test plan:
Confirm the expected behavior.

Confirmed.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:51:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 13:51:06 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-sILeiAM7CD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

--- Comment #5 from Marc V?ron <veron at veron.ch> ---
Hi Jonathan,

Sorry, the sort drop-down is still visible.
Seems that the var tag is not defined for the template.

I think it could be fixed after the following lines in opac/opac-search.pl,
around line 347:

my $tag;
$tag = $params->{tag} if $params->{tag};

I added following line:
$template->param(tag => $tag);

This way, the sorting drop down disappears as expected if tags are displayed.
With a 'normal' search, sorting drop down appears.

What do you think about?
Marc

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:54:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 13:54:09 +0000
Subject: [Koha-bugs] [Bug 5844] Unhilight cuts off some strings
In-Reply-To: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5844-70-G3PpuorIdR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 14:54:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 13:54:11 +0000
Subject: [Koha-bugs] [Bug 5844] Unhilight cuts off some strings
In-Reply-To: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5844-70-w0rn3FqXvU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37282|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37317
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37317&action=edit
[PASSED QA] Bug 5844: Avoid strings cut on unhighlighing

If a user is searching for several words and that one is contained in
another ( "mag ma" ), some characters are cut (removed from the DOM!).

To reproduce:
1/ search for "mag ma m"
2/ The result page contains "Magazine"
3/ "Mag" is highlighted
4/ Click on the "Unhighlight" link
5/ The "Magazine" words become "azine", "Mag" has been cut.
There is no way to show these characters again.

Test plan:
1/ Confirm the bad behavior without this patch
2/ Apply this patch
3/ search for "mag ma m"
4/ The result page contains "Magazine"
5/ "Mag" is highlighted
6/ Click on the "Unhighlight" link
7/ strings are unhighlighted and still in the DOM :)

Note that the Highlight link won't work very well (only "a" will be
highlighted, but considered as minor since this did not work before the
patch neither).

Followed test plan. Strings are no longer cut when unhiglighted.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:05:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:05:10 +0000
Subject: [Koha-bugs] [Bug 6820] hide receive option if there is nothing to
	receive
In-Reply-To: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6820-70-SjhigRq7sx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 37318
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37318&action=edit
[Signed-off] Bug 6820 - hide receive option if there is nothing to receive

The "receive shipment" button appears even if there are no orders to receive.
This patch hides the button if there are no orders.

To test the patch:
1. Go to "aquisitions"
2. Create a vendor
3. As the newly created vendor has no orders, there will now be no "receive
shipment" button
4. Create a basket
5. Go back to the vendor search
6. The button should now appear for that vendor

I've also tested it with a mix of vendors with and without baskets in the same
search.

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:05:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:05:33 +0000
Subject: [Koha-bugs] [Bug 6820] hide receive option if there is nothing to
	receive
In-Reply-To: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6820-70-Z48qKwHFu8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37296|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:05:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:05:47 +0000
Subject: [Koha-bugs] [Bug 6820] hide receive option if there is nothing to
	receive
In-Reply-To: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6820-70-Dpiy6IXHLD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:10:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:10:51 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-l8fW4u4K99@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:10:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:10:54 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-NK66YiCXVJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37226|0                           |1
        is obsolete|                            |
  Attachment #37260|0                           |1
        is obsolete|                            |

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37319
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37319&action=edit
[PASSED QA] Bug 5002: Display messages on adding/deleting patron category

There are no messages on adding and deleting patron category.
If an error occurs and the data is not inserted, the interface does not
alert the user.

This patch adds a message block to alert the user if something wrong
happened.

Test plan:
1/ Create a patron category PATCAT. You should get a confirmation
message.
2/ Try to create another patron category with the same code. You should
get an error message
3/ Delete the patron category PATCAT. You should get a confirmation
message.

Confirm there is no regression on this form (try update an existing
patron category too).

Followed test plan, works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:11:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:11:00 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-yrw2p07MtV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37320
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37320&action=edit
[PASSED QA] Bug 5002: Show all patron categories after insert

+ wording changes.

How I tested:
- edit an existing patron category
- save the change
- redirect is to the categories table - it shows all categories OK

- wording OK as well

Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:15:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:15:02 +0000
Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms
In-Reply-To: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6911-70-KFjZhxoEgF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 37321
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37321&action=edit
[Signed-off] Bug 6911: Remember search terms in the log viewer tool

The modules and actions selected by the user are now selected when a
log search is done.
Note that this patch also add the multiple attribute to the actions
select in order to add the ability to select several actions.
The code to do that already existed.

Test plan:
1/ Go on the log viewer tool (tools/viewlog.pl)
2/ Launch a search with modules and actions selected.
3/ Confirm that the values you have selected is still selected after the
search.

Patch works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:15:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:15:19 +0000
Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms
In-Reply-To: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6911-70-QGWEzxBona@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37294|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:15:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:15:47 +0000
Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms
In-Reply-To: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6911-70-6pYq4k0077@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:35:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:35:22 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-9XRaAbSwMg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37208|0                           |1
        is obsolete|                            |
  Attachment #37220|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37322
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37322&action=edit
[PASSED QA] Bug 3873: Avoid software error if the cart contains a deleted
record

If a record is placed in the basket and deleted, the basket view
exploded with:
Can't use an undefined value as an ARRAY reference at
/home/koha/src/basket/basket.pl line 73.

Test plan:
1/ Add some records to the basket
2/ Delete one of them
3/ Look at your basket
It should not exploded

Note that the number of items in the basket is now wrong.

Works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:36:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:36:01 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-pDptxdJhP6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37323
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37323&action=edit
[PASSED QA] Bug 3873: follow-up for all other pages

This should fix the issue on other pages.

Test plan:
Try to download and export the basket (intranet+opac sides).

Re-tested for errors in comment #5, they do not longer appear.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:36:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:36:14 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-vPyXzDQCXb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:44:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:44:09 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-FwCriR3YeA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37299|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37324
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37324&action=edit
Bug 6950: Hide the resort option when searching for a tag

If you click a link from the Tag Cloud, the results page offers the
usual select menu to resort your results. However, doing so resubmits
the search as a standard keyword search.

Test plan:
1/ Click on a tag
2/ Confirm that the resort dropdown list does not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:45:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:45:10 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-2uvadIaCDc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Marc V?ron from comment #5)
Marc,
Yes sorry (again) I forgot to add the pl changes to the last patch!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:49:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:49:02 +0000
Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system
	log
In-Reply-To: <bug-13889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13889-70-YcSzggDbAP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37082|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron <veron at veron.ch> ---
Created attachment 37325
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37325&action=edit
Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home > Tools > Logs ("Browse system logs")

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
cron jobs.
- Run some cron jobs
- Go to Home > Tools > Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
with Action "All" and Submit.
- Output should show Dae/time and info about Cron jobs

Rebased to work on top of Bug 6911 (conflict in viewlog.tt)  /MV

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:50:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:50:12 +0000
Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system
	log
In-Reply-To: <bug-13889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13889-70-ETvmZ8NtSt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |6911

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:50:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:50:12 +0000
Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms
In-Reply-To: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6911-70-Pm4JbFYqnf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13889

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:52:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:52:15 +0000
Subject: [Koha-bugs] [Bug 6505] purchase order not populating all fields
In-Reply-To: <bug-6505-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6505-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6505-70-BwCvK1HwlW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6505

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 15:57:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 14:57:00 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-qD1Gzx44jz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37326
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37326&action=edit
Bug 3831 - Move fast add framework from optional to mandatory

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:02:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:02:11 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-IOPscVLvRz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
I'm not entirely sure this is a good idea. Can anyone demonstrate an actual
error caused by not having the fast cataloging framework? I've found if I
delete it, and check out a nonexistant barcode, the fast cataloging link will
take me to the marc editor with a blank page, where I can choose a different
framework.

Would it not be better to handle the case where there is no FA framework
installed instead?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:02:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:02:19 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-qOWGDSci6P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:04:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:04:03 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-M04VILQmCG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

--- Comment #8 from Marc V?ron <veron at veron.ch> ---
Created attachment 37327
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37327&action=edit
[Signed-off] Bug 6950: Hide the resort option when searching for a tag

If you click a link from the Tag Cloud, the results page offers the
usual select menu to resort your results. However, doing so resubmits
the search as a standard keyword search.

Test plan:
1/ Click on a tag
2/ Confirm that the resort dropdown list does not appear.

Dropdown list disappears with tags as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:04:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:04:19 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-56N9heqkGt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37324|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:04:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:04:29 +0000
Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search
In-Reply-To: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6950-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6950-70-v9UYHtxQQO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:22:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:22:48 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-uen1gebCY3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37024|0                           |1
        is obsolete|                            |
  Attachment #37177|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37328
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37328&action=edit
Bug 13822 - Patron autocomplete search is severly limited

The script that returns data for the patron autocomplete does not use
C4::Members::Search. Instead it uses bespoke code that does not behave like the
traditional search and is very limited in how it can search.

If, for example, I search for "Kyle Hall" in the standard search, I would get
"Kyle Hall" back as a result. For the autocomplete search, I will not.

This script should use C4::Members::Search to provide better searching and to
keep the code base DRY.

Test Plan:
1) Enable the system preference CircAutocompl
2) Create a user with the first name "Test" and the surname "User"
3) Perform a checkout autocomplete search for "Test User"
4) Note you do not get the user as a result
5) Apply this patch
6) Try different combinations of "Test" and "User" such as
   Test User
   User Test
   U Test
   Test U
   etc.
7) Note these searches now work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:22:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:22:56 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-DFUa9K6OKE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:23:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:23:40 +0000
Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search
	- ysearch.pl
In-Reply-To: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13892-70-cN4ubBf6d7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:23:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:23:42 +0000
Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search
	- ysearch.pl
In-Reply-To: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13892-70-vVITLOwk5N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37170|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37329
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37329&action=edit
[PASSED QA] Bug 13892: Make ysearch.pl not using C4::Members::Search

To get rid of SQLHelper, we should not use this C4::Members::Search anymore.

Test plan:
0/ Enable the CircAutocompl pref
1/ Go on the circulation home page, or the reserve page
2/ Search for a patron and wait for the autocompletion box
3/ Confirm there is no regression

Works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:23:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:23:54 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-RtDbOhmZnT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13894

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:23:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:23:54 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-FkwFTIMUe3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13822

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:24:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:24:41 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-QPZNWDBe69@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|13894                       |13892

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:24:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:24:41 +0000
Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search
	- ysearch.pl
In-Reply-To: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13892-70-oCjS54vzIE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13822

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:24:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:24:41 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-XLl5mnJX1v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13822                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:25:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:25:30 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-eeQVVWUXum@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Patch rewritten to take into account bug 13892. Completely new version will
need a new sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:32:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:32:27 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-PXNXobIWqk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Kyle M Hall from comment #8)
> Would it not be better to handle the case where there is no FA framework
> installed instead?

If it is mandatory and we remove the delete action, we should not take into
account this case (even if it could appears for existing installations...).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:36:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:36:11 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-ubCsr6BcGT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:36:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:36:14 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-DQxMpdeXHv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37171|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37330
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37330&action=edit
[PASSED QA] Bug 13894: Make reserve.pl not using C4::Members::Search

Important note: This will modify the UI.
The patron list will now be displayed in a table (instead of a select).

Test plan:
1/ Place a hold on a record
2/ Search for a patron
3/ Select a patron and submit
4/ The hold workflow should continue as previously

No behavior changes should be observed.

Works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:36:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:36:40 +0000
Subject: [Koha-bugs] [Bug 3831] Fast Add Framework Should not be Deletable
In-Reply-To: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3831-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3831-70-UHzwZGbuQy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3831

--- Comment #10 from Marc V?ron <veron at veron.ch> ---
(In reply to Kyle M Hall from comment #8)
> (...) I've found if I
> delete it, and check out a nonexistant barcode, the fast cataloging link
> will take me to the marc editor with a blank page, where I can choose a
> different framework. (...)

Hmm, should the link 'Fast cataloging' be available/visible if no FA framework
is defined?

I think no, because of following code in circ/circulation.pl
(around line 536)
my $fast_cataloging = 0;
if (defined getframeworkinfo('FA')) {
    $fast_cataloging = 1
}

So if you can trigger the link without having a FA framework, there must be
some bug (condition 'defined' or return value of getframeworkinfo?).

Regarding the question optional vs. mandatory: 
Maybe we could keep the FA framework optional and display a warning on page
'About Koha', Tab 'System information' if the FA framework is missing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 16:43:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 15:43:31 +0000
Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system
	log
In-Reply-To: <bug-13889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13889-70-YUvG31efFB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:00:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:00:41 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-2bZIYVGbHu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37328|0                           |1
        is obsolete|                            |

--- Comment #13 from Marc V?ron <veron at veron.ch> ---
Created attachment 37331
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37331&action=edit
Bug 13822 - Patron autocomplete search is severly limited

The script that returns data for the patron autocomplete does not use
C4::Members::Search. Instead it uses bespoke code that does not behave like the
traditional search and is very limited in how it can search.

If, for example, I search for "Kyle Hall" in the standard search, I would get
"Kyle Hall" back as a result. For the autocomplete search, I will not.

This script should use C4::Members::Search to provide better searching and to
keep the code base DRY.

Test Plan:
1) Enable the system preference CircAutocompl
2) Create a user with the first name "Test" and the surname "User"
3) Perform a checkout autocomplete search for "Test User"
4) Note you do not get the user as a result
5) Apply this patch
6) Try different combinations of "Test" and "User" such as
   Test User
   User Test
   U Test
   Test U
   etc.
7) Note these searches now work

Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:01:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:01:42 +0000
Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly
	limited
In-Reply-To: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13822-70-mZK8K66xx7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:12:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:12:15 +0000
Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal
In-Reply-To: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13920-70-VHNac5Z0RK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:32:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:32:23 +0000
Subject: [Koha-bugs] [Bug 7480] authorisedbyname filled twice in
	neworderempty.pl
In-Reply-To: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7480-70-wFuroq3mZe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:32:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:32:26 +0000
Subject: [Koha-bugs] [Bug 7480] authorisedbyname filled twice in
	neworderempty.pl
In-Reply-To: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7480-70-InTDCMdvsp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37332
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37332&action=edit
Bug 7480: Don't display current logged in user as basket manager

The "Managed by" field displayed on creating/editing an order is always
the name of the logged in user.

To reproduce:
1/ Log in with patron A
2/ Create a basket
3/ Create an order
4/ Log in with patron B
5/ Edit the order
6/ The "Managed by" line is "patron B"

Test plan:
Apply the patch and confirm that the "patron A" is always the basket
manager.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:32:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:32:46 +0000
Subject: [Koha-bugs] [Bug 7480] authorisedbyname filled twice in
	neworderempty.pl
In-Reply-To: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7480-70-Tw3JysUrJd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
           Severity|trivial                     |normal
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:33:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:33:47 +0000
Subject: [Koha-bugs] [Bug 7480] The Basket manager is always the logged in
	user
In-Reply-To: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7480-70-3TxI7u1Lmz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|authorisedbyname filled     |The Basket manager is
                   |twice in neworderempty.pl   |always the logged in user

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:35:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:35:59 +0000
Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with
 date last seen greater than the inventory date
In-Reply-To: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13915-70-DZQ2W6fYUh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915

--- Comment #3 from Marc V?ron <veron at veron.ch> ---
Created attachment 37333
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37333&action=edit
[Signed-off] Bug 13915 - Inventory tool no longer hides items with date last
seen greater than the inventory date

In previous versions of Koha, selecting an inventory date would filter
out items that had been seen since the "Inventory date". Bug 12631
changed the inventory tool so that this behavior only occurs when a
barcodes list file is uploaded for comparison.

Test Plan:
1) Apply this patch
2) Run the inventory tool with no set parameters
3) Mark the first item as seen
4) Rerun the tool with only a date last seen parameter
   of yesterday
5) Note the item you marked as seen is no longer on the list

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:36:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:36:23 +0000
Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with
 date last seen greater than the inventory date
In-Reply-To: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13915-70-LAcbhfbhpg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37268|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:36:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:36:46 +0000
Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with
 date last seen greater than the inventory date
In-Reply-To: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13915-70-4ghAaYfsDf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:58:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:58:37 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-6fpTOOmOB6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
QA Note, it appears that serials/add_user_search takes into account the search
text field when browsing by last name. Original version doesn't have name
browse. Could be considered a bug or a feature depending on your point of view.

This behavior does no occur on the "patron cards" patron search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 17:59:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 16:59:44 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-YOoy7fGtl8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
> This behavior does no occur on the "patron cards" patron search.
correct, it *does* occur.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 18:01:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 17:01:08 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-qqzbeQ89z4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 18:01:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 17:01:11 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-ErTMglOeNW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37184|0                           |1
        is obsolete|                            |
  Attachment #37185|0                           |1
        is obsolete|                            |
  Attachment #37186|0                           |1
        is obsolete|                            |
  Attachment #37187|0                           |1
        is obsolete|                            |

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37334
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37334&action=edit
[PASSED QA] Bug 13891: DataTables server-side processing - budget users

This first patch remove the previous way to search for users to link to
budgets.

Test plan:
1/ Edit or create a fund
2/ Edit the owner of this fund a select a patron
3/ Add 1+ users to the user lists of this fund

Tested together with other patches.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 18:01:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 17:01:23 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-K8ZM1uI6dZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37336
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37336&action=edit
[PASSED QA] Bug 13891: DataTables server-side processing - patron cards

This third patch removes the previous way to search for patron cards users.

Test plan:
1/ Add items to a patron card batch
(patroncards/edit-batch.pl?op=edit&element_id=X)
2/ Add 1+ patrons to the batch
3/ Confirm there is no regression

Tested together with other patches.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 18:01:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 17:01:21 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-3p1IMt0gCN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37335
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37335&action=edit
[PASSED QA] Bug 13891: DataTables server-side processing - Serial recipients

This second patch removes the previous way to search for serial recipients.

Test plan:
1/ Edit the routing list for a subscription
(serials/routing.pl?subscriptionid=X)
2/ Add 1+ recipients
3/ Confirm there is no regression on the add/delete/search actions

QA note: This search does not use a clean way to interact with the
window opener. Indeed the opener is reloaded to display the new item.
This patch does not change this behavior, but note the trick in the
template (common/patron_search.tt) to wait for the opener in order not
to get a JS error.
This is also used by the next patch (patron card).

Tested together with other patches.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 18:01:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 17:01:26 +0000
Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables
 server-side processing
In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13891-70-kLJhqoMfiN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37337
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37337&action=edit
[PASSED QA] Bug 13891: DataTables server-side processing - Fix regressions

This patch fixes the regressions introduced by the previous patches.
If you have tested all in once, you didn't see them.

It introduces library, category and "first letter" filters.

Test plan:
1/ On all pages impacted by previous patches + new order empty (link patron to
an order) + guarantor search
2/ Add / Select patron to the list
3/ Use the filters
4/ Confirm there is no regression

Tested together with other patches.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 18:23:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 17:23:56 +0000
Subject: [Koha-bugs] [Bug 7480] The Basket manager is always the logged in
	user
In-Reply-To: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7480-70-PlpQXPe5zX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
Created attachment 37338
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37338&action=edit
[Signed-off] Bug 7480: Don't display current logged in user as basket manager

The "Managed by" field displayed on creating/editing an order is always
the name of the logged in user.

To reproduce:
1/ Log in with patron A
2/ Create a basket
3/ Create an order
4/ Log in with patron B
5/ Edit the order
6/ The "Managed by" line is "patron B"

Test plan:
Apply the patch and confirm that the "patron A" is always the basket
manager.

Followed test plan. Works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 18:24:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 17:24:23 +0000
Subject: [Koha-bugs] [Bug 7480] The Basket manager is always the logged in
	user
In-Reply-To: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7480-70-gNk4VhgdEM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
  Attachment #37332|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 18:24:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 17:24:31 +0000
Subject: [Koha-bugs] [Bug 7480] The Basket manager is always the logged in
	user
In-Reply-To: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7480-70-wzHQ6dJCZ3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 19:17:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 18:17:02 +0000
Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with
 date last seen greater than the inventory date
In-Reply-To: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13915-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13915-70-xaFCuWn0u0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 19:22:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 18:22:30 +0000
Subject: [Koha-bugs] [Bug 6820] hide receive option if there is nothing to
	receive
In-Reply-To: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6820-70-pZFYL5Txgk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 19:22:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 18:22:32 +0000
Subject: [Koha-bugs] [Bug 6820] hide receive option if there is nothing to
	receive
In-Reply-To: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6820-70-Z2tUTr1QPO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37318|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37339
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37339&action=edit
[PASSED QA] Bug 6820 - hide receive option if there is nothing to receive

The "receive shipment" button appears even if there are no orders to receive.
This patch hides the button if there are no orders.

To test the patch:
1. Go to "aquisitions"
2. Create a vendor
3. As the newly created vendor has no orders, there will now be no "receive
shipment" button
4. Create a basket
5. Go back to the vendor search
6. The button should now appear for that vendor

I've also tested it with a mix of vendors with and without baskets in the same
search.

Followed test plan, works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 19:37:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 18:37:09 +0000
Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are
 several issues per unit
In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12671-70-S72PCZzXfA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 19:37:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 18:37:11 +0000
Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are
 several issues per unit
In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12671-70-FSJ8DqVnUf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36924|0                           |1
        is obsolete|                            |
  Attachment #36925|0                           |1
        is obsolete|                            |
  Attachment #36926|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37340
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37340&action=edit
[PASSED QA] Bug 12671: Refactor GetNextDate

A much needed refactoring. Thanks for seeing the effort through.
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 19:37:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 18:37:26 +0000
Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are
 several issues per unit
In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12671-70-ILHOVYz25E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37341
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37341&action=edit
[PASSED QA] Bug 12671: Guess next serial date when there are several issues per
unit

This guess uses the following algorithm
1/ Get the number of days remaining from first issue of this unit of
time until the end of the unit of time (using 7 days for week, 28 for
month and 365 for year)
2/ Divide it by the number of issues per unit
3/ Take the integer part of the result, this is the number of days to
add to previous serial published date

This patch also try to guess the date of the first issue of a unit of
time. Before that, it was:
- for week: monday of week
- for month: 1st day of month
- for year: 1st day of year
Now it uses firstacquidate.

Example:
  firstacquidate = 1970-01-07 (wednesday)
  unit = week
  issuesperunit = 2 (2 issues per week)

  From wednesday to sunday, there are 4 days so we add 2 days to get the
  next date.
  The next dates should be:
  - 1970-01-09 (+ 2 days)
  - 1970-01-14 (wednesday of next week)
  - 1970-01-16 (+ 2 days)
  - ... and so on

Test plan:
1/ Go to numbering pattern creation page (Serials -> Manager numbering
patterns -> New numbering pattern)
2/ In "Test prediction pattern" fieldset, set subscription length to 50
issues (this avoid to compute the next 1000 dates, which can take time)
3/ Fill first issue publication date
4/ Choose the frequency you want to test
5/ click on "Test pattern" button
6/ Check that the dates are correct
7/ Repeat steps 3-7 until you think you have tested enough cases

Interesting frequencies to test:
- 1/day
- 1/week
- 2/week
- 6/week (firstacquidate should be monday or tuesday, or the generated
  dates will be the same for all the week)
- 1/month
- 2/month
- 3/month
- 1/year
- 2/year
- 3/year

----------------
Sign off report:
----------------
-Followed the test plan. Unit tests work. Also trying some more strange
 frequencies with our librarians:
 5/year, 43/year, 10/year.
-Received all serials for a subscription and found no errors.
-Received some serials with frequency 2/month pre-patch, getting publication
 date as 1st of every month for each magazine. Having applied the patch,
 publication dates started working mid-subscription for new magazines.
-Works well and fine!
Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 19:37:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 18:37:29 +0000
Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are
 several issues per unit
In-Reply-To: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12671-70-zEMyvtdTJP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37342
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37342&action=edit
[PASSED QA] Bug 12671: Guess next serial date when there are several issues per
unit. Added support for real month and year lenghts.

When getting the next frequency number, use the real number of days for each
month and each year.

Unit tests updated.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 20:58:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 19:58:39 +0000
Subject: [Koha-bugs] [Bug 13924] New: LocalHoldsPriority needs
	dateaccessioned limits.
Message-ID: <bug-13924-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13924

            Bug ID: 13924
           Summary: LocalHoldsPriority needs dateaccessioned limits.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

LocalHoldsPriority needs to have another parameter to limit by number of days
since dateaccessioned date.

We have several libraries that need the LocalHoldsPriority on, but in doing so,
have found that very popular items, such as video games or video streaming
devices never leave our library because we always have someone from our library
with a hold on them.  It would be great to have this new parameter, so new
items (which is what we tend to want the LocalHoldsPriority for) would be
priority at their home branch, but maybe 6 weeks or 2 months later they don't
have to be.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Mar 27 22:49:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 21:49:45 +0000
Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card
In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8796-70-9cfD9IZiza@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796

Heinrich Hartl <Heinrich.Hartl at email.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Heinrich.Hartl at email.de
           Priority|P5 - low                    |P3

--- Comment #10 from Heinrich Hartl <Heinrich.Hartl at email.de> ---
The bug is still existing in 3.18.4. Printing in the created .pdf starts
irrespective of input in position 1 of the label sheet/template.
The bug is effectively preventing the use of patron label creator. So I suggest
it to be given higher priority!

Moreover the documentation of the patron card creator in the manual is
incomplete. In 
http://translate.koha-community.org/manual/3.18/en/html-desktop \
/#patroncardcreator 
Chapter 3.1.6.4.?Batches seems to be truncated / incomplete.

The text displayed in the 3.18.4 export popup is 
Enter starting card number
and seems not to be consistent with attachment [SIGNED-OFF] Bug 8796...  The
user is still left without clear idea what this value means. Why not use a text
similar to "Start printing in template-position" []

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:53:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 23:53:22 +0000
Subject: [Koha-bugs] [Bug 13748] Acquisition wizard: some strings not
	translatable
In-Reply-To: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13748-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13748-70-CmXC9BfzNf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:54:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 23:54:28 +0000
Subject: [Koha-bugs] [Bug 13861] \n in strings don't translate well
In-Reply-To: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13861-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13861-70-R8JHgSsEVH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13861

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:55:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 23:55:32 +0000
Subject: [Koha-bugs] [Bug 13768] in quotes.tt line 14 the use of \" break
	the translation
In-Reply-To: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13768-70-34yGGicKEe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:57:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 23:57:08 +0000
Subject: [Koha-bugs] [Bug 13826] OPAC: Display RSS icon on list of recent
	comments
In-Reply-To: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13826-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13826-70-AUVUiQxG7F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13826

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 00:59:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 27 Mar 2015 23:59:42 +0000
Subject: [Koha-bugs] [Bug 13863] Datatables paging for cities and search
 history pages is broken
In-Reply-To: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13863-70-ZpL8fnieFO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 01:01:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2015 00:01:14 +0000
Subject: [Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
In-Reply-To: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13872-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13872-70-aHdR0djsS6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 01:02:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2015 00:02:02 +0000
Subject: [Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
In-Reply-To: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13878-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13878-70-OEcV5yH2jM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 01:06:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2015 00:06:23 +0000
Subject: [Koha-bugs] [Bug 13832] Missing table header IDs on record holdings
 table in OPAC
In-Reply-To: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13832-70-1e6IMzSRMZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13832

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 01:09:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2015 00:09:56 +0000
Subject: [Koha-bugs] [Bug 13856] Hard to translate strings on patron search
	results page
In-Reply-To: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13856-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13856-70-0AvKeEz9L9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13856

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 09:27:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2015 08:27:18 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-MtIq1XXSG9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #693 from Josef Moravec <josef.moravec at gmail.com> ---
I tried this by creating new instance, but web installer presented an SQL error
when creating db structure:

ERROR 1064 (42000) at line 3484: You have an error in your SQL syntax; check
the manual that corresponds to your MySQL server version for the right syntax
to use near 'account_credits ( credit_id int(11) NOT NULL AUTO_INCREMENT,
borrow' at line 1 


I think the problem is on this line in kohastructure.sql:

3484 CREATE TABLE IF account_credits (

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 09:51:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2015 08:51:03 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-rRiUXlexYO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #694 from Josef Moravec <josef.moravec at gmail.com> ---
I think that account_credits table should have foreign key to
account_debits.debit_id, without this key, it?s impossible to group payments by
fee type in reports. 

But this work is almost done, so it may be the best approach to open new bug
for this enhancement...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Mar 28 18:09:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 28 Mar 2015 17:09:36 +0000
Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13383-70-Lo4BPmzGC9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #14 from Nick Clemens <nick at quecheelibrary.org> ---
Applying: RDA: 100/110/111 changes to XSLT
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 RDA: 100/110/111 changes to XSLT
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-13383---RDA-100110111-changes-to-XSLT-9bjGww.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 08:29:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 06:29:11 +0000
Subject: [Koha-bugs] [Bug 13818] Editing and saving a course reserve
 displays the add item form
In-Reply-To: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13818-70-KneOpWupyu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13818

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 08:33:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 06:33:27 +0000
Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee!
In-Reply-To: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12820-70-EhSbr8bhmv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #17 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 08:39:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 06:39:10 +0000
Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding
In-Reply-To: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13801-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13801-70-j6zW8xhj6i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 11:33:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 09:33:59 +0000
Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card
In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8796-70-cDIphuzoLO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12573|0                           |1
        is obsolete|                            |

--- Comment #11 from Marc V?ron <veron at veron.ch> ---
Comment on attachment 12573
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12573
[SIGNED-OFF] Bug 8796 - patron cards not starting on designated card

Applying: Bug 8796 - patron cards not starting on designated card
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.

Obsoleted this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 11:57:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 09:57:13 +0000
Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card
In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8796-70-D1Q3Nbuhsl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796

--- Comment #12 from Marc V?ron <veron at veron.ch> ---
Created attachment 37343
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37343&action=edit
Bug 8796 - patron cards not starting on designated card

The patron cards always printed from position 1 on the print form, because
patroncards/create-pdf.pl expected start_label as parameter and got star_card
instead.

To verify and test:
1)
Go to Home > Tools >Patron card creator >Manage batches
2)
Select a batch anc click "Export"

3)
Set "Enter starting card number" e.g. to 5
4)
Export
5)
Download PDF and view it

Result: The first card is always printed on position 1 (top left) instead of
position 5.

Apply patch
Repeat steps above
Step 3) should now read "Enter starting card position"

Result after step 5)
The first card ist printed at the correct position on the printing form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 11:59:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 09:59:40 +0000
Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card
In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8796-70-btNnIjFTZz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12485|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 12:00:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 10:00:39 +0000
Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card
In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8796-70-9SP7VxSvSd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 12:35:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 10:35:41 +0000
Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card
In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8796-70-pgsNiqJ72P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|cnighswonger at foundations.ed |veron at veron.ch
                   |u                           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:42:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 19:42:50 +0000
Subject: [Koha-bugs] [Bug 2075] Create a page to show and manage the user's
	comments
In-Reply-To: <bug-2075-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2075-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2075-70-HsYl7DnC7W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2075

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:43:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 19:43:55 +0000
Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users
In-Reply-To: <bug-2093-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2093-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2093-70-fCj1qyJVZA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:45:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 19:45:37 +0000
Subject: [Koha-bugs] [Bug 2096] Label sources for OPAC descriptions
In-Reply-To: <bug-2096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2096-70-fy99p69Zah@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2096

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:46:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 19:46:43 +0000
Subject: [Koha-bugs] [Bug 2124] Moving MARC Fields Around When Cataloging
In-Reply-To: <bug-2124-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2124-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2124-70-z2xpFUJNSH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2124

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:56:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 19:56:10 +0000
Subject: [Koha-bugs] [Bug 4115] print a batch of patron cards from an import
In-Reply-To: <bug-4115-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4115-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4115-70-AssOWqVB1L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4115

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:58:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 19:58:40 +0000
Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged
	records
In-Reply-To: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6520-70-8ejVJSPpsq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:58:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 19:58:42 +0000
Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged
	records
In-Reply-To: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6520-70-8lHiwBuGNB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37311|0                           |1
        is obsolete|                            |

--- Comment #4 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37344
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37344&action=edit
Bug 6520: Display items for staged record

When records are imported into Koha, the items is stored into the
import_items table.
This marcxml in this table is never retrieved to display items.

Test plan:
1/ Import a records with items
2/ Before importing the batch into the catalog, you can see the marc
of the records, in the table below.
3/ Verify that the items is correctly displayed.

QA note: This patch does not provide test for new subroutines but the
module (C4::ImportBatch) is not tested at all and it will be time
consuming to provide them.

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:59:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 19:59:02 +0000
Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged
	records
In-Reply-To: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6520-70-KUDZ20osc0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
             Status|Signed Off                  |Needs Signoff

--- Comment #5 from Nicole C. Engard <nengard at gmail.com> ---
Processing files before patches
|========================>| 2 / 2 (100.00%)
Processing files after patches
|========================>| 2 / 2 (100.00%)

 OK    C4/ImportBatch.pm
   OK      critic
   OK      forbidden patterns
   OK      pod
   OK      valid

 OK    catalogue/showmarc.pl
   OK      critic
   OK      forbidden patterns
   OK      pod
   OK      valid

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 21:59:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 19:59:13 +0000
Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged
	records
In-Reply-To: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6520-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6520-70-XCBvLy2Gsr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:06:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:06:52 +0000
Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table
In-Reply-To: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13887-70-2YgsaXz3Sv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
           Assignee|nick at quecheelibrary.org     |nengard at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37345
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37345&action=edit
datatables

Don't look quite right. See attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:17:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:17:01 +0000
Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from
 cataloging search
In-Reply-To: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13886-70-1Gke9lSiiT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37346
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37346&action=edit
Bug 13801: svc/bib - Set charset to utf-8 on printing header

Test plan:
0/ Add unicode characters on the record biblionumber=X
1/ go on http://<staff-interface>/cgi-bin/koha/svc/bib/X
2/ Confirm you have encoding issues
3/ Apply the patch
4/ Repeat 2
5/ Confirm that all is correctly encoded

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:18:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:18:20 +0000
Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from
 cataloging search
In-Reply-To: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13886-70-2rAgYJQh0J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
  Attachment #37346|0                           |1
        is obsolete|                            |

--- Comment #3 from Nicole C. Engard <nengard at gmail.com> ---
Comment on attachment 37346
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37346
Bug 13801: svc/bib - Set charset to utf-8 on printing header

I made a mistake somewhere in signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:18:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:18:57 +0000
Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from
 cataloging search
In-Reply-To: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13886-70-r1MERhDuOZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:19:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:19:00 +0000
Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from
 cataloging search
In-Reply-To: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13886-70-uZ6cvfPwj8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37079|0                           |1
        is obsolete|                            |

--- Comment #4 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37347
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37347&action=edit
Bug 13886 - Add ability to merge records directly from cataloging search

This patch adds a merge button and checkboxes to the cataloging search results
screen to allow librarians to merge directly from these reults

To test:
1 - Apply patch
2 - Perform a cataloging search
3 - Try to select 1 or more than 2 records to merge and check that you get an
error
4 - Select 2 records to merge and confirm the correct records are passed to the
merge tool

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:19:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:19:47 +0000
Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from
 cataloging search
In-Reply-To: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13886-70-l6oF9ojm9A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

--- Comment #5 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37348
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37348&action=edit
Bug 13801: svc/bib - Set charset to utf-8 on printing header

Test plan:
0/ Add unicode characters on the record biblionumber=X
1/ go on http://<staff-interface>/cgi-bin/koha/svc/bib/X
2/ Confirm you have encoding issues
3/ Apply the patch
4/ Repeat 2
5/ Confirm that all is correctly encoded

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:22:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:22:07 +0000
Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from
 cataloging search
In-Reply-To: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13886-70-uekUaggWfn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37348|0                           |1
        is obsolete|                            |

--- Comment #6 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37349
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37349&action=edit
Bug 13886 QA Follow Up : Remove tabs

Fix tab errors in QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:24:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:24:58 +0000
Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include
	more options
In-Reply-To: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13885-70-aEtmkfpuoS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |nengard at gmail.com

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Nick I think 'Standard search' Should be Search the Catalog like on all other
pages.  I know it can be confusing to have that word in 2 searches, but I think
we need to be consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:32:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:32:03 +0000
Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search
In-Reply-To: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13866-70-uzP2z0i3r9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37350
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37350&action=edit
no option for patrons

It works on the patron search, but not on the admin page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:32:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:32:52 +0000
Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search
In-Reply-To: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13865-70-mTQcXgIrCF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |nengard at gmail.com

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
git15:32 ~/kohaclone (master % u=)$ git qa 13865
>From git://git.koha-community.org/koha
 * branch            master     -> FETCH_HEAD
Branch bug13865-qa set up to track remote branch master from origin.
Switched to a new branch 'bug13865-qa'
Bug 13865 - Columns configuration - Orders search

36981 - Bug 13865: Columns configuration - Orders search

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 13865: Columns configuration - Orders search
fatal: sha1 information is lacking or useless (admin/columns_settings.yml).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 13865: Columns configuration - Orders search
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-13865-Columns-configuration---Orders-search-hnC7nE.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:33:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:33:31 +0000
Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the
 wrong course!
In-Reply-To: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13817-70-Vlz4Nkt3FF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:34:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:34:45 +0000
Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
In-Reply-To: <bug-12747-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12747-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12747-70-pm40EpD3Ai@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:36:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:36:03 +0000
Subject: [Koha-bugs] [Bug 11874] Add a "Call number fields" column to the
 Z39.50 search results.
In-Reply-To: <bug-11874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11874-70-ZEcJmPdDqP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11874

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=12747
           Assignee|gmcharlt at gmail.com          |charles.farmer at inlibro.com

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
I wonder if this is a better way to do this:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:36:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:36:03 +0000
Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result
In-Reply-To: <bug-12747-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12747-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12747-70-o8mQhuzGDn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11874

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:38:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:38:01 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-0qy4ynB73p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nicolas.legrand at bulac.fr
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:43:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:43:51 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-hdAkAdNQ50@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:43:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:43:54 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-UAP1OakZvv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37265|0                           |1
        is obsolete|                            |

--- Comment #3 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37351
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37351&action=edit
Bug 9089 - show suggestion number

Show suggestion number on suggestion management.

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:44:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:44:31 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-B4HPxSfvVI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

--- Comment #4 from Nicole C. Engard <nengard at gmail.com> ---
I recommend a follow up to change the column header to be # or No. or something
much much shorter - but it didn't seem like a reason to fail this on QA.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:45:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:45:31 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-SryChpQV2U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I seem to remember we switched out # for No. in another patch in other places,
so I'd prefer that - also easier on translators.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 22:50:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 20:50:29 +0000
Subject: [Koha-bugs] [Bug 7369] duplicate item
In-Reply-To: <bug-7369-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7369-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7369-70-dybBxItdXq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
           Assignee|nick at quecheelibrary.org     |nengard at gmail.com

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37352
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37352&action=edit
duplicating fields it shouldn't

2 things.

1 - we should put the edit, duplicate, delete options in a pull down like on
other pages

2 - much bigger - the hidden fields are duplicating like number of checkouts
and last checkout (see attached)


Other QA tests passed:

Processing files before patches
|========================>| 2 / 2 (100.00%)
Processing files after patches
|========================>| 2 / 2 (100.00%)

 OK    cataloguing/additem.pl
   OK      critic
   OK      forbidden patterns
   OK      pod
   OK      valid

 OK    koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
   OK      forbidden patterns
   OK      tt_valid
   OK      valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 23:11:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 21:11:26 +0000
Subject: [Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader
In-Reply-To: <bug-13911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13911-70-gvlL3WJC3r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 23:16:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 21:16:44 +0000
Subject: [Koha-bugs] [Bug 13534] Deleting staff member who moderated a tag
 removes tags imcompletely
In-Reply-To: <bug-13534-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13534-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13534-70-cILdjHOY8C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 23:19:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 21:19:09 +0000
Subject: [Koha-bugs] [Bug 13881] Add desk management
In-Reply-To: <bug-13881-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13881-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13881-70-tBBUx8cslu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 23:20:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 21:20:37 +0000
Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page
In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13364-70-9R2mJ6pG6p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
            Summary|Add a call number browser   |Add a call number browser
                   |in item edition page        |to add item page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 23:37:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 21:37:02 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-qU5K7qjudZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Mar 29 23:45:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 29 Mar 2015 21:45:08 +0000
Subject: [Koha-bugs] [Bug 13846] Email patron asking to return an item that
 has been placed on hold
In-Reply-To: <bug-13846-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13846-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13846-70-09o6Ub1CK4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13846

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 03:47:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 01:47:20 +0000
Subject: [Koha-bugs] [Bug 13925] New: koha-restore doesn't start Zebra
Message-ID: <bug-13925-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13925

            Bug ID: 13925
           Summary: koha-restore doesn't start Zebra
 Change sponsored?: ---
           Product: Koha
           Version: 3.18
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

It appears that Zebra isn't started for an instance after koha-restore is run.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 04:38:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 02:38:21 +0000
Subject: [Koha-bugs] [Bug 9754] koha-remove does not remove the stuff in
	/var/lib/koha/
In-Reply-To: <bug-9754-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9754-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9754-70-cSpoTlJOHk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
Still an issue in 3.18.5. 

I did a koha-create, then a koha-remove, then a koha-restore. Here's the output
of the koha-restore:

sudo koha-restore library.sql.gz library.tar.gz
ERROR: File exists: /var/lib/koha/library/
ERROR: File exists: /var/lib/koha/library/plugins/
ERROR: File exists: /var/lib/koha/library/biblios/
ERROR: File exists: /var/lib/koha/library/biblios/key/
ERROR: File exists: /var/lib/koha/library/biblios/shadow/
ERROR: File exists: /var/lib/koha/library/biblios/tmp/
ERROR: File exists: /var/lib/koha/library/biblios/register/
ERROR: File exists: /var/lib/koha/library/biblios/register/reci-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/gmatch-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/dict-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/isambB-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/recdB-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/isambA-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/isambD-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/isambC-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/sort18-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/recdA-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/sort23-0.mf
ERROR: File exists: /var/lib/koha/library/authorities/
ERROR: File exists: /var/lib/koha/library/authorities/key/
ERROR: File exists: /var/lib/koha/library/authorities/shadow/
ERROR: File exists: /var/lib/koha/library/authorities/tmp/
ERROR: File exists: /var/lib/koha/library/authorities/register/
ERROR 1396 (HY000) at line 1: Operation DROP USER failed for 'koha_library'@'%'
[ ok ] Restarting web server: apache2 ... waiting .

I figure koha-remove should remove everything... but if there's no consensus on
that one, I'm happy to have a --purge or --force option. It would be nice to be
able to completely destroy any trace of an instance afterward.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 04:38:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 02:38:50 +0000
Subject: [Koha-bugs] [Bug 13925] koha-restore doesn't start Zebra
In-Reply-To: <bug-13925-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13925-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13925-70-IpP4eAh5Ga@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13925

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Here's my koha-restore output:

sudo koha-restore library.sql.gz library.tar.gz
ERROR: File exists: /var/lib/koha/library/
ERROR: File exists: /var/lib/koha/library/plugins/
ERROR: File exists: /var/lib/koha/library/biblios/
ERROR: File exists: /var/lib/koha/library/biblios/key/
ERROR: File exists: /var/lib/koha/library/biblios/shadow/
ERROR: File exists: /var/lib/koha/library/biblios/tmp/
ERROR: File exists: /var/lib/koha/library/biblios/register/
ERROR: File exists: /var/lib/koha/library/biblios/register/reci-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/gmatch-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/dict-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/isambB-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/recdB-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/isambA-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/isambD-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/isambC-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/sort18-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/recdA-0.mf
ERROR: File exists: /var/lib/koha/library/biblios/register/sort23-0.mf
ERROR: File exists: /var/lib/koha/library/authorities/
ERROR: File exists: /var/lib/koha/library/authorities/key/
ERROR: File exists: /var/lib/koha/library/authorities/shadow/
ERROR: File exists: /var/lib/koha/library/authorities/tmp/
ERROR: File exists: /var/lib/koha/library/authorities/register/
ERROR 1396 (HY000) at line 1: Operation DROP USER failed for 'koha_library'@'%'
[ ok ] Restarting web server: apache2 ... waiting .

I was wondering why I couldn't search anything... and then realized it's
because Zebra hadn't started up!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 05:52:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 03:52:56 +0000
Subject: [Koha-bugs] [Bug 13607] Patron management API
In-Reply-To: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13607-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13607-70-WwiL892MvX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

--- Comment #20 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 37353
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37353&action=edit
Bug 13607: test cases fixes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 06:14:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 04:14:53 +0000
Subject: [Koha-bugs] [Bug 13846] Email patron asking to return an item that
 has been placed on hold
In-Reply-To: <bug-13846-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13846-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13846-70-jY0SZSYp8P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13846

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
I think a lot of systems refer to this as a "recall", but they force a change
to the due date (e.g.
http://www.library.usyd.edu.au/borrowing/requests.html#recalls) where the
patron has to bring the item back within 7 days.

I suppose there could be a preference for this though. One, it could just be a
friendly reminder. Two, it could be a forced shortening of the due date.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 06:15:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 04:15:47 +0000
Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages
	to an item
In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13733-70-DYmrdMUqlk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 06:16:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 04:16:40 +0000
Subject: [Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader
In-Reply-To: <bug-13911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13911-70-M0b8j5xvFh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 06:17:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 04:17:38 +0000
Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning
In-Reply-To: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4502-70-hPTbo6wONK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 06:17:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 04:17:40 +0000
Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning
In-Reply-To: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4502-70-nKq5R9byEs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37203|0                           |1
        is obsolete|                            |

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37354
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37354&action=edit
Bug 4502: Catch software error if no active budget defined

TEST PLAN
---------
0) Back up your database.
1) In mysql client:
   > DROP DATABASE {your koha database name};
   > CREATE DATABASE {your koha database name};
   > QUIT;
2) Go to the staff client, and install all the default
   and optional things -- except patrons. :)
3) Log into staff client.
4) Create a patron -> New Patron -> Staff
5) Enter data and Save
6) More -> Set Permissions
7) Make superlibrarian
8) Log out
9) Log in as new superlibrarian
10) Acquisitions -> Budgets -> New Budget
11) Enter a non-active budget with some funds.
    -- Once saved, it should list in the inactive budgets.
12) Click on the name.
13) Click on one of the Planning submenu options.
14) Click the 'Submit' button in the Filter area.
    -- This should trigger the blow up.
15) Apply the patch
16) Repeat steps 12-15
    -- The kaboom is avoided and a nice message given.

NOTE: This does not solve all the problems in this ugly, ugly
      module area. It does solve the one thing it is meant to:
      that nasty kaboom.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 06:49:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 04:49:18 +0000
Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the
 number of days used in purge_suggestions.pl
In-Reply-To: <bug-13287-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13287-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13287-70-0NYf6ltUUr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 33661
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33661
Add a system preference to define the number of days used in
purge_suggestions.pl

Review of attachment 33661:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13287&attachment=33661)
-----------------------------------------------------------------

::: misc/cronjobs/purge_suggestions.pl
@@ +47,5 @@
> +-help|? This message
> +-days TTT to define the age of suggestions to delete
> +
> +Example:
> +$PERL5LIB/misc/cronjobs/purge_suggestions.pl -days 30

This line change seems wrong to me.
It doesn't interpret $PERL5LIB, and this is a drastic change from what was
already there. And though what was there is a little unclear to the average
user, perhaps it is better?

@@ +68,4 @@
>      DelSuggestionsOlderThan($days);
>  }
> +elsif(defined($days) && $days == 0) {
> +    print << 'ERROR';

Seriously, why? There is no need to << 'LABEL ... LABEL this. It's a waste of
vertical space.

@@ +72,5 @@
> +    This script is not executed with 0 days. Aborted.
> +ERROR
> +}
> +else {
> +    print << 'ERROR';

Why not use:
    print STDERR "This script requires a positive number of days. Aborted.";

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 06:56:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 04:56:50 +0000
Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the
 number of days used in purge_suggestions.pl
In-Reply-To: <bug-13287-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13287-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13287-70-WYf6ce0Wv9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

--- Comment #11 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 33661
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33661
Add a system preference to define the number of days used in
purge_suggestions.pl

Review of attachment 33661:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13287&attachment=33661)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ +561,5 @@
> +              class: integer
> +            - days.
> +            - <br>WARNING - Leave this field empty if you don't want to activate this automatic feature.
> +            - "<br>Example: [30] Sets purgation of suggestions for those older than 30 days."
> +            - <br>(Used when the purge_suggestions.pl script is called with a specific number of days)

As per comment #9. This is unclear. This feature is only used if the --days ###
command line parameter is not passed. This last line makes it sound like it is
used instead of the command line value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 06:59:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 04:59:41 +0000
Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the
 number of days used in purge_suggestions.pl
In-Reply-To: <bug-13287-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13287-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13287-70-erqOObUlTD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #12 from M. Tompsett <mtompset at hotmail.com> ---
Marking as 'Failed QA', since 'In Discussion' tends to head into 'Never get
looked at again' land.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 07:24:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 05:24:32 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-ODzoAYZlBN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #695 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Josef Moravec from comment #694)
> I think that account_credits table should have foreign key to
> account_debits.debit_id, without this key, it?s impossible to group payments
> by fee type in reports. 
> 
> But this work is almost done, so it may be the best approach to open new bug
> for this enhancement...

I am sorry, I just missed the table account_offsets...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 07:48:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 05:48:30 +0000
Subject: [Koha-bugs] [Bug 13846] Email patron asking to return an item that
 has been placed on hold
In-Reply-To: <bug-13846-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13846-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13846-70-noJpgNyII0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13846

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The library suggesting this didn't want to shorten the due date - just to send
a nice email asking if the book is still needed. A recall feature would of
course still be useful at some point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 07:59:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 05:59:58 +0000
Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search
In-Reply-To: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13866-70-blP2fj9rEg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:10:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 06:10:33 +0000
Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card
In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8796-70-WUrg65cacP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37343|0                           |1
        is obsolete|                            |

--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 37355
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37355&action=edit
Bug 8796 - patron cards not starting on designated card

The patron cards always printed from position 1 on the print form, because
patroncards/create-pdf.pl expected start_label as parameter and got star_card
instead.

To verify and test:
1)
Go to Home > Tools >Patron card creator >Manage batches
2)
Select a batch anc click "Export"

3)
Set "Enter starting card number" e.g. to 5
4)
Export
5)
Download PDF and view it

Result: The first card is always printed on position 1 (top left) instead of
position 5.

Apply patch
Repeat steps above
Step 3) should now read "Enter starting card position"

Result after step 5)
The first card ist printed at the correct position on the printing form.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:10:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 06:10:56 +0000
Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card
In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8796-70-wDdgRMTDqM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:37:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 06:37:55 +0000
Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general
	viewing
In-Reply-To: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13109-70-YG3j7CMAW5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109

--- Comment #2 from Mason James <mtj at kohaaloha.com> ---
(In reply to Aliza from comment #0)
> For Log Magazine, also still an issue for Sports Business Journal
> 
> Received the following message
> 
> Software error:
> 
> Usage: Date::Calc::Delta_Days(year1, month1, day1, year2, month2, day2) at
> /usr/share/koha/lib/C4/Serials.pm line 2379.
> For help, please send mail to the webmaster (staff at bywatersolutions.com),
> giving this error message and the time and date of the error.

aah, i see the problem here...

the abouttoexpire() sub tries to compare 2 dates, but doesnt check that both
dates actually exist

i'll send a patch for this

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:38:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 06:38:00 +0000
Subject: [Koha-bugs] [Bug 2124] Moving MARC Fields Around When Cataloging
In-Reply-To: <bug-2124-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2124-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2124-70-xpJrAPN5Xf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2124

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=7882

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:38:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 06:38:00 +0000
Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in
	MARC editor
In-Reply-To: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7882-70-7iRDYWPSMQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=2124

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:41:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 06:41:09 +0000
Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general
	viewing
In-Reply-To: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13109-70-sK5d9iXi3G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109

--- Comment #3 from Mason James <mtj at kohaaloha.com> ---
Created attachment 37356
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37356&action=edit
Bug 13109 - Serial failure for received and general viewing.

modified:   C4/Serials.pm

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:42:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 06:42:45 +0000
Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from
 cataloging search
In-Reply-To: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13886-70-B3boYSwBYi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:43:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 06:43:05 +0000
Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in
	MARC editor
In-Reply-To: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7882-70-AwnsnXPS4v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:51:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 06:51:28 +0000
Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general
	viewing
In-Reply-To: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13109-70-3n36z7dgyG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:51:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 06:51:31 +0000
Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general
	viewing
In-Reply-To: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13109-70-HX9B4BLxHY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37356|0                           |1
        is obsolete|                            |

--- Comment #4 from Mason James <mtj at kohaaloha.com> ---
Created attachment 37357
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37357&action=edit
Bug 13109 - Serial failure for received and general viewing.

to test...

1/ attempt to view a subscription-detail that has a NULL value for either it's
'startdate' or 'enddate'

  an example url would be...
 
http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1

  observe error...
  'Date::Calc::PP::Delta_Days(): Usage:
Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at
/your/koha/C4/Serials.pm line 2325'

2/ apply patch
3/ repeat step 1/
   observe that detail page displays OK

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 08:59:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 06:59:01 +0000
Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general
	viewing
In-Reply-To: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13109-70-XddIistUDc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.16                        |master
           Keywords|                            |rel_3_16_candidate

--- Comment #5 from Mason James <mtj at kohaaloha.com> ---
..bug confirmed on master, and 3.18.5 too

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 09:02:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 07:02:02 +0000
Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general
	viewing
In-Reply-To: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13109-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13109-70-nCuQl9xxSL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
           Severity|normal                      |major
                 CC|                            |chris at bigballofwax.co.nz
           Keywords|                            |rel_3_18_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 09:49:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 07:49:38 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-mxboNSvfN6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37351|0                           |1
        is obsolete|                            |

--- Comment #6 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 37358
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37358&action=edit
Bug 9089 - show suggestion number

Show suggestion number on suggestion management.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 09:50:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 07:50:47 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-GuzEIu5Pvw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

--- Comment #7 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Ok! I just changed it to "No".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 09:56:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 07:56:45 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-mG59YQ5PAR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:42:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 08:42:41 +0000
Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search
In-Reply-To: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13865-70-IyruhqiHEN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Apply cleanly on top of bug 13864.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:51:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 08:51:59 +0000
Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in
	MARC editor
In-Reply-To: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7882-70-D9n7NPimDO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

--- Comment #42 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Marjorie Barry-Vila from comment #41)

> Someone is still working on it?

I wonder the same thing.. turns out that such feature would really come in
handy, especially as C4::AuthoritiesMarc::merge() does currently have uncanny
tendency to mess up field order in biblio records pretty badly, when authority
records are being modified.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 10:57:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 08:57:31 +0000
Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search
In-Reply-To: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13865-70-e6g51QZ0jw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36981|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37359
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37359&action=edit
Bug 13865: Columns configuration - Orders search

This patch adds the ability to hide columns on the orders search page
(acqui/histsearch.pl).

Test plan:
Go on the orders search page and confirm you are able to hide columns.
You can also play with the columns configuration admin page and confirm
that the behaviors are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:04:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 09:04:53 +0000
Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search
In-Reply-To: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13866-70-WvBJD6suCq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36982|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37360
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37360&action=edit
Bug 13866: Columns configuration - Patrons search

This patch adds the ability to hide columns on the patrons search page
(acqui/lateorders.pl).

Test plan:
Go on the patrons search page and confirm you are able to hide columns.
You can also play with the columns configuration admin page and confirm
that the behaviors are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 11:05:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 09:05:31 +0000
Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search
In-Reply-To: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13866-70-ApnARHWOBU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Nicole C. Engard from comment #2)
> Created attachment 37350 [details]
> no option for patrons
> 
> It works on the patron search, but not on the admin page

Thanks Nicole for catching that!
Last patch adds it to the admin page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:07:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 10:07:03 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-dILZ6n9e0i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37361
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37361&action=edit
Bug 13894: Fix if the search returns only 1 result

In the case where only 1 result is returned by the search, the
borrowernumber should be passed correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:15:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 10:15:08 +0000
Subject: [Koha-bugs] [Bug 13926] New: SQLHelper replacement -
 C4::Members::Search - circulation.pl
Message-ID: <bug-13926-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926

            Bug ID: 13926
           Summary: SQLHelper replacement - C4::Members::Search -
                    circulation.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: jonathan.druart at biblibre.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

circ/circulation.pl currently uses C4::Members::Search.
To get rid of SQLHelper, we should not use this subroutine anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:15:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 10:15:21 +0000
Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search
 - circulation.pl
In-Reply-To: <bug-13926-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13926-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13926-70-VF1jS6IlDn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |12633

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:15:21 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 10:15:21 +0000
Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
In-Reply-To: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12633-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12633-70-amYwCDcB4X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13926

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:17:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 10:17:45 +0000
Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search
 - circulation.pl
In-Reply-To: <bug-13926-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13926-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13926-70-vxIVeSu7sg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:17:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 10:17:47 +0000
Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search
 - circulation.pl
In-Reply-To: <bug-13926-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13926-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13926-70-uKHqIVxFf3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37362
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37362&action=edit
Bug 13926: ake circulation.pl not using C4::Members::Search

This patch uses the same method as bug 13894.

Important note: This will modify the UI.
The patron list will now be displayed in a table (instead of a select).

Test plan:
1/ Search for a patron using the checkout tab
2/ The patron list should appear correctly

Test with different type of search (returns 0, 1, 1+ results).

No behavior changes should be observed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:18:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 10:18:32 +0000
Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search
 - circulation.pl
In-Reply-To: <bug-13926-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13926-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13926-70-EWbtYIdddo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13894

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:18:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 10:18:32 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-eDw6i6KTnC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13926

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:25:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 10:25:26 +0000
Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in
	MARC editor
In-Reply-To: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7882-70-UixioHXeF6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:50:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 10:50:26 +0000
Subject: [Koha-bugs] [Bug 10148] 007/006 not filling in with existing values
In-Reply-To: <bug-10148-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10148-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10148-70-h1urevj7Ex@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 12:55:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 10:55:02 +0000
Subject: [Koha-bugs] [Bug 12814] KOHA Cataloging (Authorities) Problem
In-Reply-To: <bug-12814-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12814-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12814-70-TDcm0OPS3m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12814

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:08:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 11:08:38 +0000
Subject: [Koha-bugs] [Bug 10198] Add the ability to import and export
	authorized values
In-Reply-To: <bug-10198-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10198-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10198-70-EOXkusbGId@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:09:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 11:09:36 +0000
Subject: [Koha-bugs] [Bug 10198] Add the ability to import and export
	authorized values
In-Reply-To: <bug-10198-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10198-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10198-70-ttOTeWj1ts@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:11:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 11:11:27 +0000
Subject: [Koha-bugs] [Bug 13851] Replace waiting holds logic in
 circulation.pl with Koha Objects
In-Reply-To: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13851-70-ziZFbPHsCK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:19:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 11:19:55 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-aOgeU2jrqT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:20:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 11:20:05 +0000
Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from
 authorised values
In-Reply-To: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13380-70-xqnbMd7vFT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37179|0                           |1
        is obsolete|                            |

--- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37363
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37363&action=edit
[PASSED QA] Bug 13380: Follow-up - only run database update, when it hasn't
been run already

As the ORDER_CANCELLATION_REASON authorised value has been
backported to 3.18.5, we need to make sure that the database
update is only run once.

This patch adds a check for the existance of the authorised
value in order to decide if the databaes update can be run.

To test:
- Create a branch 3.19.00.016
- Make sure you have a few orders where the cancellationreason
  is set (cancel an order, enter a reason)
- Update your branch to master + this patch
- Run the web installer
- ORDER_CANCELLATION_REASON authorised value category is created
- Reset your system preference Version to 3.19.00.015
- Run database update again - no changes are made, all is fine

Or:
- Create a branch 3.18.04 with cancelled orders
- Update to latest 3.18.x
- Make sure ORDER_CANCELLATION_REASON has been created
- Dump database
- Switch to master without this patch
- Run update - verify more O_C_R were created (bad)
- Load database
- Update to master with this patch
- All should be fine

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:27:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 11:27:16 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-qEtrhPLn3K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37364
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37364&action=edit
Bug 7561: Fast cataloging - Allow add/edit items and delete record

With the fast cataloging permission, a librarian was not able to
add/edit items and to delete a record with the FA framework.

This patch fixes that.

Test plan:
0/ Set the permission fast_cataloging (and only this one under
editcatalogue) to a librarian
1/ Log in with this account
2/ Go to Circulation > Fast cataloging
3/ Confirm you can create a record
4/ Save and confirm you can create items
5/ Confirm you are able to edit items, remove all of them and delete the
record.
6/ Make sure it only works for records with the FA framework code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:27:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 11:27:13 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-bnVgv0I06t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:28:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 11:28:10 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-PTgXY7I4QU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |major
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Not sure this is critical, lowering the priority.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:50:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 11:50:59 +0000
Subject: [Koha-bugs] [Bug 12533] Improve authority search result display
In-Reply-To: <bug-12533-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12533-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12533-70-AkEVztecxl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 13:53:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 11:53:29 +0000
Subject: [Koha-bugs] [Bug 7650] total not always right on checkout summary
In-Reply-To: <bug-7650-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7650-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7650-70-g27IadXAdd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7650

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Looks good now. Please reopen if the problem persists.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:01:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 12:01:27 +0000
Subject: [Koha-bugs] [Bug 7723] Copyrightdate in dropdown menu should read
	"date added"
In-Reply-To: <bug-7723-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7723-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7723-70-h1evuJBOEd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7723

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I don't think this is valid.
When a list is sorted by copyrightdate, the field biblio.copyrightdate is used
to sort the list.

We could add a "date added" sort option, but it's not the idea of this bug
report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:08:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 12:08:22 +0000
Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice
In-Reply-To: <bug-13622-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13622-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13622-70-6xbDStwIhZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Reintroduce this one in the needs signoff queue, there is no discussion and I
think this patch could bring a global solution to date formatting in notices.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:40:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 12:40:54 +0000
Subject: [Koha-bugs] [Bug 13927] New: Add API route to check hold
	capabilities
Message-ID: <bug-13927-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927

            Bug ID: 13927
           Summary: Add API route to check hold capabilities
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 13903

Often when a 3rd-party application want to deal with reserves in Koha, it must
know in advance if the reserve is allowed (for example to hide the "place hold"
link if hold is not allowed)

This new route does just that, telling if a given hold is allowed for a given
patron.

Moreover, it also returns a list of available pickup locations (restricting to
only the borrower's branch if IndependentBranches is set).

Depends on bug 13903.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:40:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 12:40:54 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete reserves
In-Reply-To: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13903-70-2bPD88tnCm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13927

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:41:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 12:41:31 +0000
Subject: [Koha-bugs] [Bug 13927] Add API route to check hold capabilities
In-Reply-To: <bug-13927-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13927-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13927-70-fD49sfhBNu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 37365
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37365&action=edit
Bug 13927: Add API route to check hold capabilities

OPTIONS /borrowers/{borrowernumber}/reserves

Request body should contain biblionumber or itemnumber, and response
tells us if reserve is allowed, and which pickup locations are available

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:45:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 12:45:59 +0000
Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update,
	delete reserves
In-Reply-To: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13903-70-C1IIZx4O3v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #2)
> Hi there, just wondering: should we use holds instead of reserves? Reserves
> is in the code, but all the gui uses the term holds.

+1 for "holds". And I don't fear refactoring the code a bit to make it more
consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:55:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 12:55:08 +0000
Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t,
 testing all 'borrower' database fields
In-Reply-To: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13882-70-eSR48OaCLW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 14:55:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 12:55:10 +0000
Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t,
 testing all 'borrower' database fields
In-Reply-To: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13882-70-i4XFDsbjLo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37054|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37366
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37366&action=edit
Bug 13882 : Adding new unit tests in t/Borrower.t

This adds testing for all the 'borrower' database fields.

TEST PLAN
---------
1) apply patch
2) prove -v t/Borrowers.t
   -- All 67 subtests for both the setter and accessor
      should run successfully.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:04:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:04:04 +0000
Subject: [Koha-bugs] [Bug 13928] New: Noisy t/Borrower tests
Message-ID: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

            Bug ID: 13928
           Summary: Noisy t/Borrower tests
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: mtompset at hotmail.com
        QA Contact: gmcharlt at gmail.com

Rather than generate noisy messages which aren't caught and checked,
t/Borrower.t tests should catch them and confirm they are as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:04:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:04:17 +0000
Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests
In-Reply-To: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13928-70-bY7Q1EzpFJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |mtompset at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:11:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:11:09 +0000
Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests
In-Reply-To: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13928-70-9LvyYrsKaY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37367
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37367&action=edit
Bug 13928: Clean up noisy t/Borrower.t tests

While testing bug 13882, noisy messages were noticed. Also,
Test::Warn was used, but no catching attempts were made. This
patch solves that problem.

TEST PLAN
---------
1) prove -v t/Borrowers.t
   -- There shoud be three noisy lines.
2) apply patch
3) prove -v t/Borrowers.t
   -- There will be 3 more tests and no noisy lines.
4) Run koha qa test tool
   -- There should be no issues.

NOTE: This will conflict with bug 13882 if either gets pushed
      to master, but fixing the conflict should be easy enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:11:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:11:07 +0000
Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests
In-Reply-To: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13928-70-XyNL9zRbAv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:12:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:12:07 +0000
Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests
In-Reply-To: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13928-70-HrwZSxz7Mj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37367|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37368
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37368&action=edit
Bug 13928: Clean up noisy t/Borrower.t tests

While testing bug 13882, noisy messages were noticed. Also,
Test::Warn was used, but no catching attempts were made. This
patch solves that problem.

TEST PLAN
---------
1) prove -v t/Borrowers.t
   -- There should be three noisy lines.
2) apply patch
3) prove -v t/Borrowers.t
   -- There will be 3 more tests and no noisy lines.
4) Run koha qa test tool
   -- There should be no issues.

NOTE: This will conflict with bug 13882 if either gets pushed
      to master, but fixing the conflict should be easy enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:12:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:12:25 +0000
Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests
In-Reply-To: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13928-70-Bd1a9MyMVN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13882

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:12:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:12:25 +0000
Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t,
 testing all 'borrower' database fields
In-Reply-To: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13882-70-8er3AeTwoq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13928

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:28:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:28:29 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-CHHUHNHVpF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:28:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:28:31 +0000
Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion
	management
In-Reply-To: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9089-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9089-70-dx9JFIBiB6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37358|0                           |1
        is obsolete|                            |

--- Comment #8 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37369
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37369&action=edit
Bug 9089 - show suggestion number

Show suggestion number on suggestion management.

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:34:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:34:55 +0000
Subject: [Koha-bugs] [Bug 13685] Sorting Patron Reading History
In-Reply-To: <bug-13685-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13685-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13685-70-SgUYETNRaA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37370
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37370&action=edit
Bug 13865: Columns configuration - Orders search

This patch adds the ability to hide columns on the orders search page
(acqui/histsearch.pl).

Test plan:
Go on the orders search page and confirm you are able to hide columns.
You can also play with the columns configuration admin page and confirm
that the behaviors are consistent.

Signed-off-by: Nicole <nicole at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:35:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:35:11 +0000
Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search
In-Reply-To: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13865-70-1HXYnsEIPB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:35:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:35:13 +0000
Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search
In-Reply-To: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13865-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13865-70-Kb3Qy5cqKV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37359|0                           |1
        is obsolete|                            |

--- Comment #5 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37371
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37371&action=edit
Bug 13865: Columns configuration - Orders search

This patch adds the ability to hide columns on the orders search page
(acqui/histsearch.pl).

Test plan:
Go on the orders search page and confirm you are able to hide columns.
You can also play with the columns configuration admin page and confirm
that the behaviors are consistent.

Signed-off-by: Nicole <nicole at bywatersolutions.com>

http://bugs.koha-community.org/show_bug.cgi?id=13685

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:35:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:35:31 +0000
Subject: [Koha-bugs] [Bug 13685] Sorting Patron Reading History
In-Reply-To: <bug-13685-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13685-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13685-70-3f8adpkvYM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com
  Attachment #37370|0                           |1
        is obsolete|                            |

--- Comment #3 from Nicole C. Engard <nengard at gmail.com> ---
Comment on attachment 37370
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37370
Bug 13865: Columns configuration - Orders search

Sorry attached to the wrong bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:37:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:37:26 +0000
Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search
In-Reply-To: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13866-70-An3fuWbYlC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:37:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:37:28 +0000
Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search
In-Reply-To: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13866-70-CTmZVoqrnm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37360|0                           |1
        is obsolete|                            |

--- Comment #5 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37372
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37372&action=edit
Bug 13866: Columns configuration - Patrons search

This patch adds the ability to hide columns on the patrons search page
(acqui/lateorders.pl).

Test plan:
Go on the patrons search page and confirm you are able to hide columns.
You can also play with the columns configuration admin page and confirm
that the behaviors are consistent.

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:42:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:42:35 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-MEzZvnOyGN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:42:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:42:39 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-wqoNecPd0J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36617|0                           |1
        is obsolete|                            |
  Attachment #36618|0                           |1
        is obsolete|                            |
  Attachment #36619|0                           |1
        is obsolete|                            |
  Attachment #37292|0                           |1
        is obsolete|                            |

--- Comment #131 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37373
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37373&action=edit
[SIGNED-OFF] Bug 5786: Correction: Removed erroneous holdability check from
opac-search.pl

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:43:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:43:45 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-I6KJtvrds4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Nicole C. Engard <nengard at gmail.com> ---
This doesn't change the behavior.  In this video I'll show you that I'm logged
in as someone with fast cataloging permissions and they cannot add an item but
when I go log in as a superlibrarian I can.  I also show you the permissions
the patron has : http://screencast.com/t/o0DznRTZ9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:50:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:50:30 +0000
Subject: [Koha-bugs] [Bug 13909] _debar_user_on_return doesn't honour
	finesCalendar
In-Reply-To: <bug-13909-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13909-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13909-70-uQDkqHlNSD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 37374
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37374&action=edit
Bug 13909: Suspension days calculation should respect finesCalendar

This patch make _debar_user_on_return respect the finesCalendar syspref.

It does so, by replacing the ad-hoc overdue days calculation in favor of
C4::Overdues::_get_chargeable_units (which is renamed
C4::Overdues::get_chargeable_units
and exported). There's no behaviour change besides making the calculation
simpler
and correct.

To test:
- Set finesCalendar = "directly"
- Have a circulation rule stating:
  interval for calculating fines = 1
  suspension days = 3
- Have the calendar set for sunday and saturday as holidays.
- Checkout an item with a branch/itype/borrower category that matches the
defined circ rule with a hand-writen due date to (say) last friday.
- Check the item in
=> FAIL: Notice that the user is debarred using the calendar (skipping saturday
and sunday).
- Apply the patch
- Repeat the previous steps
=> SUCCESS: calculation is correct (counting saturday and sunday as overdue
days, i.e. 'directly').
- Set finesCalendar = "calendar"
- Repeat the test
=> SUCCESS: calculation is correct (skipping holidays).
- Sign off.

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:50:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:50:28 +0000
Subject: [Koha-bugs] [Bug 13909] _debar_user_on_return doesn't honour
	finesCalendar
In-Reply-To: <bug-13909-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13909-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13909-70-bQzO9hb8S0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:50:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:50:47 +0000
Subject: [Koha-bugs] [Bug 13909] _debar_user_on_return doesn't honour
	finesCalendar
In-Reply-To: <bug-13909-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13909-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13909-70-i4FEkOZaA0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:50:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:50:52 +0000
Subject: [Koha-bugs] [Bug 13909] _debar_user_on_return doesn't honour
	finesCalendar
In-Reply-To: <bug-13909-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13909-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13909-70-0vl8A6M5wn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 15:53:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 13:53:46 +0000
Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search
In-Reply-To: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13866-70-aMU1I6OPKG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37372|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 37375
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37375&action=edit
Bug 13866: Columns configuration - Patrons search

This patch adds the ability to hide columns on the patrons search page
(acqui/lateorders.pl).

Test plan:
Go on the patrons search page and confirm you are able to hide columns.
You can also play with the columns configuration admin page and confirm
that the behaviors are consistent.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:18:09 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 14:18:09 +0000
Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on
	item
In-Reply-To: <bug-13919-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13919-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13919-70-gQLwZcshpA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:18:11 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 14:18:11 +0000
Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on
	item
In-Reply-To: <bug-13919-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13919-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13919-70-NRkhqr2aJZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37376
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37376&action=edit
Bug 13919 - Unit Test

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:18:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 14:18:40 +0000
Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on
	item
In-Reply-To: <bug-13919-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13919-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13919-70-TWbv7Fk87A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37377
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37377&action=edit
Bug 13919 - Renewal possible with item level hold on item

Test Plan:
1) Apply this patch
2) Enable AllowRenewalIfOtherItemsAvailable
3) Check out an item from a record with multiple holdable items
4) Place an item level hold on the checked out item
5) Verify the item can not be renewed from the opac

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:33:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 14:33:10 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-iqIKjXTH0h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:33:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 14:33:13 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-Fe7ZGzVtP3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37364|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37378
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37378&action=edit
Bug 7561: Fast cataloging - Allow add/edit items and delete record

With the fast cataloging permission, a librarian was not able to
add/edit items and to delete a record with the FA framework.

This patch fixes that.

Test plan:
0/ Set the permission fast_cataloging (and only this one under
editcatalogue) to a librarian
1/ Log in with this account
2/ Go to Circulation > Fast cataloging
3/ Confirm you can create a record
4/ Save and confirm you can create items
5/ Confirm you are able to edit items, remove all of them and delete the
record.
6/ Make sure it only works for records with the FA framework code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:34:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 14:34:20 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-Tq0vPrXFmE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
With tools permissions, it worked.
Now it should work even the user does not have any tool permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:40:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 14:40:41 +0000
Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search
In-Reply-To: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13866-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13866-70-DMhlVnXM9h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Josef Moravec from comment #6)
> Created attachment 37375 [details] [review]
> Bug 13866: Columns configuration - Patrons search
> 
> This patch adds the ability to hide columns on the patrons search page
> (acqui/lateorders.pl).

Of course, it's not lateorders.pl, but members/member.pl (bad c/p).


> Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
> Works as expected

Thanks Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:50:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 14:50:22 +0000
Subject: [Koha-bugs] [Bug 11029] Marc Language Code in a list
In-Reply-To: <bug-11029-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11029-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11029-70-5ElQmkh71u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11029

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Maybe it could by something like autocomplete? 

We use autocomplete for RDA field 336/337/338 and for indicators. It is
implemented in javascript inserted in intranetuserjs syspref. Although not
ideal, it works fine for us... But some more sophisticated solution in Koha may
be better. 

What about an option to have authorised values behave like autocomplete instead
to be a dropdown list?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 16:53:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 14:53:29 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-WACgNBBCwY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #11 from Nicole C. Engard <nengard at gmail.com> ---
Okay, this is better because you can edit items, but you can't add items.  For
example. If you're a superlibrarian - or a cataloger - if you check out an item
and the barcode isn't found it pops up and asks you if you want to fast catalog
- if you do that it lets you add the title, brings you to the item record - you
add the item and it checks out.

If you only have fast cataloging permissions it lets you catalog the bib but
then shows you the bib record - it doesn't take you to the add item form. 
Which is the whole point of fast cataloging - to be fast :)

Let me know if you need a video of this too.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:05:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:05:28 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-XDFROXkUsP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:05:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:05:31 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-Cqz3cZU74p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37379
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37379&action=edit
Bug 7561: Redirect to the add items form if it's a fast cataloging

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:17:38 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:17:38 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-LhM38UkRWB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #7 from Nicole C. Engard <nengard at gmail.com> ---
Shouldn't we then change the beginning of the preference description:

___ items marked as suppressed from OPAC search results. 

should be

___ biblios marked as suppressed from OPAC search results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:20:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:20:10 +0000
Subject: [Koha-bugs] [Bug 11520] Invoice isn't really an invoice
In-Reply-To: <bug-11520-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11520-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11520-70-sq7Hte64aX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11520

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:22:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:22:57 +0000
Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches
 for authority links on a Z39.50 server.
In-Reply-To: <bug-11300-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11300-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11300-70-GgqULdO030@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:30:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:30:12 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
	management
In-Reply-To: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12768-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12768-70-NdLR7pkI86@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:30:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:30:55 +0000
Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from
 cataloging search
In-Reply-To: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13886-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13886-70-XpzqJdiTjF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:32:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:32:17 +0000
Subject: [Koha-bugs] [Bug 2193] Lost Item Fines - Editable if $0
In-Reply-To: <bug-2193-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2193-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2193-70-wiLIlzoEas@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2193

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|PC                          |All

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:32:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:32:18 +0000
Subject: [Koha-bugs] [Bug 13773] add stock number to details and items
	display
In-Reply-To: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13773-70-ThdVI1YKQX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:33:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:33:20 +0000
Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
In-Reply-To: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13501-70-rYsy7hTzDJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:36:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:36:51 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-0K1kuEl7F6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Jason Burds <jburds at dubuque.lib.ia.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |jburds at dubuque.lib.ia.us

--- Comment #78 from Jason Burds <jburds at dubuque.lib.ia.us> ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 8753:
<h1>Something went wrong !</h1>Applying: Bug 8753 - Add forgot password link to
OPAC Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql Auto-merging
installer/data/mysql/kohastructure.sql
Auto-merging installer/data/mysql/en/mandatory/sample_notices.sql
CONFLICT (content): Merge conflict in
installer/data/mysql/en/mandatory/sample_notices.sql
Failed to merge in the changes.
Patch failed at 0001 Bug 8753 - Add forgot password link to OPAC

When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 8753 - Add forgot password link to OPAC

36819 - Bug 8753 - Add forgot password link to OPAC

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-8753---Add-forgot-password-link-to-OPAC-VCLXC4.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:40:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:40:04 +0000
Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit
 a bibliographic record
In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10263-70-dVXsXSojtC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:42:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:42:16 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-EkqYM007ct@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

dmin <dminuck at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|dminuck at gmail.com           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:46:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:46:42 +0000
Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links
 authority records to a biblio record during edition. (AJAX)
In-Reply-To: <bug-11299-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11299-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11299-70-0OCYD411fv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:47:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:47:39 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-3GLrzo4jxc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:47:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:47:52 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-0jfMiUjHsz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37378|0                           |1
        is obsolete|                            |

--- Comment #13 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37380
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37380&action=edit
Bug 7561: Fast cataloging - Allow add/edit items and delete record

With the fast cataloging permission, a librarian was not able to
add/edit items and to delete a record with the FA framework.

This patch fixes that.

Test plan:
0/ Set the permission fast_cataloging (and only this one under
editcatalogue) to a librarian
1/ Log in with this account
2/ Go to Circulation > Fast cataloging
3/ Confirm you can create a record
4/ Save and confirm you can create items
5/ Confirm you are able to edit items, remove all of them and delete the
record.
6/ Make sure it only works for records with the FA framework code.

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:47:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:47:59 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-ABcJYlB9NV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37379|0                           |1
        is obsolete|                            |

--- Comment #14 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37381
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37381&action=edit
Bug 7561: Redirect to the add items form if it's a fast cataloging

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:48:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:48:17 +0000
Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging
	permissions
In-Reply-To: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7561-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7561-70-5ZM3jUH2vu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561

--- Comment #15 from Nicole C. Engard <nengard at gmail.com> ---
BINGO!!! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:51:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:51:49 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-LIDMKkDX5i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 17:59:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 15:59:20 +0000
Subject: [Koha-bugs] [Bug 13851] Replace waiting holds logic in
 circulation.pl with Koha Objects
In-Reply-To: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13851-70-tml9jHxx2r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

Jason Burds <jburds at dubuque.lib.ia.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jburds at dubuque.lib.ia.us

--- Comment #5 from Jason Burds <jburds at dubuque.lib.ia.us> ---
Kyle,

I ran through the steps on a sandbox.

1. "Waiting at" is still bold, but not different colored.
2. Selecting Hold in the circulation.pl continues to show the "Processing" box.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:16:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:16:24 +0000
Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues
In-Reply-To: <bug-10606-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10606-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10606-70-jZMBPH004G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606

--- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I reverted the patch. There's no point breaking functionalities for
something that should be handled in the ORM. Even having an IF switch
for each engine...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:16:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:16:51 +0000
Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search
	- reserve.pl
In-Reply-To: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13894-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13894-70-jE8MP5gs0L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:17:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:17:22 +0000
Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons
In-Reply-To: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11900-70-5XyMJYFdfc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:18:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:18:10 +0000
Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not functional
In-Reply-To: <bug-7976-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7976-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7976-70-LYu3xXAAHs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kyle.m.hall at gmail.com       |jonathan.druart at biblibre.co
                   |                            |m
           Severity|trivial                     |minor
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:19:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:19:30 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-TqAh2D1l7k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:20:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:20:28 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-b3KvkrQI36@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #132 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Followup pushed to master.

I'll be waiting for the new bug report. Please add me to the CC.

Thanks Srdjan!

PS: /me hopes no melting took place :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:21:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:21:33 +0000
Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search
	- ysearch.pl
In-Reply-To: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13892-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13892-70-yE2NWncqcc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonthan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:24:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:24:23 +0000
Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not functional
In-Reply-To: <bug-7976-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7976-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7976-70-jspvkwn3t0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:24:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:24:26 +0000
Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not functional
In-Reply-To: <bug-7976-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7976-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7976-70-Xl3U6V61hz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37382
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37382&action=edit
Bug 7976: Remove the borrow permission

The borrow permission was used but uselessly.
For instance, at the opac, the flagsrequired parameter was set to
'borrow' but the 'authnotrequired' was set also (which means no auth
required).
At the end, this permission was used at only 1 place: for the basket,
intranet side.
This can be replaced with the catalogue permission (which is used to
search).

Test plan:
1/ Confirm that you are able to show/download/sent the cart (intranet side)
with the catalogue permission.
2/ At the OPAC, you should be able to access the same pages as before
with any other permissions.

Concretely it is quite difficult to test this patch, you should have a
look at the code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:25:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:25:02 +0000
Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not useless and can
	be removed
In-Reply-To: <bug-7976-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7976-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7976-70-350FyUIuUN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|"Borrow Permission" is not  |"Borrow Permission" is not
                   |functional                  |useless and can be removed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:27:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:27:05 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-b2Yx7x6QvD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36963|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:27:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:27:13 +0000
Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
In-Reply-To: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13758-70-wYMPjneEyU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:33:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:33:57 +0000
Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication
In-Reply-To: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13507-70-cVImot7Lg7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Guys, this doesn't apply, could you please fix the conflict? I'm willing to
push it ASAP

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:45:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:45:27 +0000
Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the
 wrong course!
In-Reply-To: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13817-70-Fsv3Dx9LqO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:45:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:45:30 +0000
Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the
 wrong course!
In-Reply-To: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13817-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13817-70-2fMldP9fKf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36776|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 37383
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37383&action=edit
Bug 13817 - Edit links on course items may point to the wrong course!

If items are assigned to multiple courses, the "edit" links for a course
item may pass the wrong course id. This is really a cosmetic issue.

It appears that in Template Toolkit, if you reuse an existing variable
name in a foreach loop, it will not create a new temporary variable but
will instead re-use the existing variable leaving assigned at the end to
the last assignment, just as it would in Perl code.

This is not a problem when all items are assigned to one and only one
course, but can cause issues when we loop through the other courses an
item may be on.

This is solved easily by renaming the variable used in the foreach loop
to another unused name.

Test Plan:
1) Apply this patch
2) Try the edit and delete links for an item on reserve for a course
3) No changes in behavior should be noted

Signed-off-by: Tom Misilo <misilot at fit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:47:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:47:30 +0000
Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label
	Printing
In-Reply-To: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10773-70-6f7ln6axzv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Dobrica!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:47:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:47:56 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-yHkIIqKhLA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Matthias!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:48:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:48:18 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-W42SqgNUiD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks David!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:48:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:48:42 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-xrzIhwjvBS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:49:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:49:37 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-zlPW7fPlk3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Benjamin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:50:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:50:20 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-XRcmxFSOKt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #44 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Good job Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:50:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:50:43 +0000
Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices
 cronjob is broken
In-Reply-To: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11120-70-Pq3O8M1Brp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #30 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:51:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:51:13 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-PMOpcwrqB5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #34 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Frederick!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:51:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:51:41 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-rWxtosxToD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 18:53:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 16:53:16 +0000
Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on
 creating record from Z39.50
In-Reply-To: <bug-9742-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9742-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9742-70-IwCaQUlWVb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I'm not happy to do this. But I don't agree with this. I'm marking as 'In
discussion' for future consideration.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:32:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 17:32:43 +0000
Subject: [Koha-bugs] [Bug 13850] C4::Ris does not manage correctly 660 and
	661 - UNIMARC
In-Reply-To: <bug-13850-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13850-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13850-70-5jUBMCGfnn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13850

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36943|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37384
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37384&action=edit
Bug 13850: Fix typo in C4::Ris

In C4/Ris.pm:
  @field_list = ('600', '601', '602', '604', '605', '606','607', '608',
  '610', '615', '620', '660'. '661', '670', '675', '676', '680', '686');

Note the
  '660'. '661'
instead of
  '660', '661'

Test plan:
Add a 660 and 661 field to a record and export it in RIS
The 660 and 661 field should be displayed (after "KW").

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:32:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 17:32:41 +0000
Subject: [Koha-bugs] [Bug 13850] C4::Ris does not manage correctly 660 and
	661 - UNIMARC
In-Reply-To: <bug-13850-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13850-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13850-70-Nk8mJTwz0q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13850

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 19:39:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 17:39:08 +0000
Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests
In-Reply-To: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13928-70-TFmNHLcWoS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 21:15:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 19:15:00 +0000
Subject: [Koha-bugs] [Bug 13929] New: opac description not showing on search
 results for authorized values
Message-ID: <bug-13929-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13929

            Bug ID: 13929
           Summary: opac description not showing on search results for
                    authorized values
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

If you set an opac description for a lost authorized value it only shows on the
detail page - the results says 'lost' no matter what you set as the opac
descriptions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 21:19:54 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 19:19:54 +0000
Subject: [Koha-bugs] [Bug 13930] New: Add supporting service svc/ncip for
 xnciptoolkit driver
Message-ID: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930

            Bug ID: 13930
           Summary: Add supporting service svc/ncip for xnciptoolkit
                    driver
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org

We need ncip service for Koha, because it will the main communication protocol
for libraries portal here in Czech Republic.

The work is almost done and is sponsored by Municipal Library Ceska Trebova and
by grant from Ministry of Culture of Czech Republic.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 21:20:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 19:20:24 +0000
Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for
	xnciptoolkit driver
In-Reply-To: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13930-70-h2wvSKPIvV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 21:21:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 19:21:48 +0000
Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for
	xnciptoolkit driver
In-Reply-To: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13930-70-xP2QrIDQcK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 21:25:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 19:25:58 +0000
Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for
	xnciptoolkit driver
In-Reply-To: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13930-70-VASzUaIczB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 21:49:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 19:49:46 +0000
Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for
	xnciptoolkit driver
In-Reply-To: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13930-70-OhNeogO8s1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #1 from Chris Cormack <chris at bigballofwax.co.nz> ---
Oh, have you seen? 

http://git.evergreen-ils.org/?p=working/NCIPServer.git;a=summary

Looks like Koha will have 2 NCIP servers possible :)

It will be good to see the supporting services, I could change the NCIPServer
to use them too. Then people could chose the pure perl one, or if they want a
java stack, xnciptoolkit.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:10:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 20:10:42 +0000
Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for
	xnciptoolkit driver
In-Reply-To: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13930-70-Kj02UPjwAM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Yes, 

I've seen it before, but we have to use xcncip2toolkit (it was somewhat
consensus made by libraries and library system vendors here in Czech Republic)

You can see the work-in-progress in the repository of our developer Ji??
Kozlovsk?: 
https://github.com/jirislav/Koha/

look at svc/ncip and C4/NCIP/* for the Koha service

and here is the xcncip2toolkit connector for Koha:
https://github.com/moravianlibrary/xcncip2toolkit/tree/master/connectors/koha/3.xx/trunk

We are open to any opinion and suggestions!

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:13:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 20:13:17 +0000
Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table
In-Reply-To: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13887-70-Ki4GTChbft@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:13:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 20:13:19 +0000
Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table
In-Reply-To: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13887-70-0pBvfybCWi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37081|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37385
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37385&action=edit
Bug 13887 - Add datatables to item specific holds table

This patch adds datatables functionality to the item specific holds table

To test:
1 - Apply patch
2 - Attempt to place an item specific hold for a patron
3 - Note that columns are now sortable and searchable
4 - Ensure that you can place both specific and next available holds as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:15:47 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 20:15:47 +0000
Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table
In-Reply-To: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13887-70-rxafxxsjdL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

--- Comment #4 from Nick Clemens <nick at quecheelibrary.org> ---
That should look better.

The only way I could figure out to fix the styling was using js to alter the
css but am definitely willing to update if there is a better/preferred method

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:19:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 20:19:34 +0000
Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include
	more options
In-Reply-To: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13885-70-Hiiwbp9VBG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:19:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 20:19:37 +0000
Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include
	more options
In-Reply-To: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13885-70-yprKBQldvb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37078|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37386
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37386&action=edit
Bug 13885 - Cataloging search header should include more options

This patch adds the check in and standard catalog search to
cataloging-search.inc

To test:
1 - Apply patch
2 - Go to More->Cataloging
3 - Search in each tab (Cataloging search / Check out / Check in / Standard
search) and ensure that all work as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 22:31:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 20:31:25 +0000
Subject: [Koha-bugs] [Bug 13931] New: Date of birth in patron search result
 and in autocomplete
Message-ID: <bug-13931-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931

            Bug ID: 13931
           Summary: Date of birth in patron search result and in
                    autocomplete
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would be nice to see the date of birth in patron search results and possibly
in autocomplete in searchfield for patron which you are going to checking out
to.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:26:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 21:26:13 +0000
Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table
In-Reply-To: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13887-70-OHhrOoSPL8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #5 from Nicole C. Engard <nengard at gmail.com> ---
Sorry, this one doesn't apply.

16:25 ~/kohaclone (master % u=)$ git qa 13887
>From git://git.koha-community.org/koha
 * branch            master     -> FETCH_HEAD
Branch bug13887-qa set up to track remote branch master from origin.
Switched to a new branch 'bug13887-qa'
Bug 13887 - Add datatables to item specific holds table

37385 - Bug 13887 - Add datatables to item specific holds table

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 13887 - Add datatables to item specific holds table
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
Failed to merge in the changes.
Patch failed at 0001 Bug 13887 - Add datatables to item specific holds table
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-13887---Add-datatables-to-item-specific-holds--D8nqyD.patch
16:25 ~/kohaclone (bug13887-qa *+%|AM u=)$

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:34:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 21:34:08 +0000
Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include
	more options
In-Reply-To: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13885-70-SSu6eGcyGH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Nicole C. Engard <nengard at gmail.com> ---
All tabs work - except check in which gives me this error:

Software error:

Can't bless non-reference value at /home/nengard/kohaclone/C4/ItemType.pm line
64.

For help, please send mail to the webmaster (webmaster at koha-vm), giving this
error message and the time and date of the error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:53:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 21:53:56 +0000
Subject: [Koha-bugs] [Bug 13800] Diacritics not mapped
In-Reply-To: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13800-70-YuiKaxb0kV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13800

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36724|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 37387
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37387&action=edit
Bug 13800 - Diacritics not mapped

This patch adds a mapping for the lower case ? character to word-phrase-utf.chr
( ? was already mapped to d)

To test:
1. Add a record with the  ? character (Arnaldur Indri?ason is an example
author)
2. Rebuild zebra
3. Search for your record using d instead of ? and verify it is not found
4. Apply patch and copy word-phrase-utf.chr to the appropriate folder
5. Restart and rebuild zebra
6. Search for your record using d instead of ? and verify it is found

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Mar 30 23:54:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 21:54:14 +0000
Subject: [Koha-bugs] [Bug 13800] Diacritics not mapped
In-Reply-To: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13800-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13800-70-cXJosx0QPK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13800

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:02:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 22:02:10 +0000
Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table
In-Reply-To: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13887-70-FHZWfl8Y0h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:02:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 22:02:12 +0000
Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table
In-Reply-To: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13887-70-R4rPLNsvaZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37385|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37388
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37388&action=edit
Bug 13887 - Add datatables to item specific holds table

This patch adds datatables functionality to the item specific holds table

To test:
1 - Apply patch
2 - Attempt to place an item specific hold for a patron
3 - Note that columns are now sortable and searchable
4 - Ensure that you can place both specific and next available holds as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:28:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 22:28:20 +0000
Subject: [Koha-bugs] [Bug 9227] items in transit can be checked out without
	warning
In-Reply-To: <bug-9227-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9227-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9227-70-LWDBUEC556@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9227

Rendi <rhodge at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rhodge at roseville.ca.us

--- Comment #2 from Rendi <rhodge at roseville.ca.us> ---
We are having this issues with all of our 3M Self-checks now as well.  When an
item is "in transit" and ends up on the shelf, customers are able to take it to
a self-check and successfully check the item out.

Ideally, this would not happen.  "In Transit" items are usually being sent to
another library to fill a request.  In addition, once the item is checked out
rather than sent in transit, it becomes almost like an item specific hold and
the customer that was waiting for it initially will not get any other copy of
that title.  Their hold will not be filled until the customer that shouldn't
have been able to check it out returns it.

I can provide details/test plans if needed but nothing seems to be moving on
this bug. 

Thanks,
Rendi

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:32:56 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 22:32:56 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-VUpjtBedqt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #105 from M. Tompsett <mtompset at hotmail.com> ---
Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:36:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 22:36:13 +0000
Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as
 Amazon, Google and add fail over i.e. if first source fails, go to next
In-Reply-To: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7187-70-qdjHTRO9q2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11982

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:36:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 22:36:13 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-WqxvrtcoDy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=7187

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:36:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 22:36:35 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-A8GgsD08BU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:41:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 22:41:39 +0000
Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in
	atomicupdates
In-Reply-To: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13893-70-h5ppYw0fM5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|Trivial patch               |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 00:41:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 22:41:41 +0000
Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in
	atomicupdates
In-Reply-To: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13893-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13893-70-csedzqpVbc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37123|0                           |1
        is obsolete|                            |

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37389
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37389&action=edit
Bug 13893 - Add ability to execute perl scripts in atomicupdates

Bug 13068 adds the ability to execute sql files from atomicupdates for
in process developments to reduce merge conflicts. We need to extend
this ability further to be able to handle perl code.

Revised Test Plan
-----------------
1) Apply bug 13068 if not pushed to master yet.
   -- I had to manually rebase the updatedatabase.pl,
      but it wasn't hard. Asked for a rebase on the bug.
2) Apply this patch set
3) Run updatedatabase.pl
   -- Expect output to be similar to:
--- BEGIN OUTPUT ---
$ ./installer/data/mysql/updatedatabase.pl
DEV atomic update : test_bz13068.sql
Upgrade to XXX done (Bug 13893 - Add ability to execute perl scripts in
atomicupdates)
--- END OUTPUT ---

4) Run koha qa test tools.
   -- only need to check last commit (-c 1), because first commit is a
      sample file which shouldn't be pushed.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 01:06:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 23:06:04 +0000
Subject: [Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters
In-Reply-To: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13880-70-HSEiBxpvvi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 01:06:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 23:06:07 +0000
Subject: [Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters
In-Reply-To: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13880-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13880-70-WCxIVduaRf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37042|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37390
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37390&action=edit
Bug 13880 - Allow svc/report to be passed sql parameters

The same feature added to the opac svc/report in bug 9915 should be
added to the staff side.

Test Plan:
1) Apply this patch
2) Create this report:
   SELECT * FROM biblio WHERE biblionumber = <<biblionumber>>
3) Note the id of the report
4) Go to the Staff URL
/cgi-bin/koha/svc/report?id=YOUR_REPORT_ID&sql_params=SOME_VALID_BIBLIONUMBER
5) Note you recieve a json response

NOTE: without applying the patch you get an empty JSON response.

ALSO: running koha qa tools does not verify the changes.
      $ perlcritic -4 svc/report
      (my perlcritic rc points to the koha qa tool one)
      No issues.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 01:14:50 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Mar 2015 23:14:50 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-sD7E3Lg7Js@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #106 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to M. Tompsett from comment #105)
> Please rebase.

No problem, Mark. It is already applied on my working branch. It will be pushed
tomorrow morning (argentinian tz).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 02:02:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 00:02:37 +0000
Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
In-Reply-To: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12532-70-qmYlYPDjHF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 36752
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36752
Bug 12532 - Redirect guarantee email to guarantor

Review of attachment 36752:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12532&attachment=36752)
-----------------------------------------------------------------

::: C4/Members.pm
@@ +1562,5 @@
> +    my $enableRedirectGuaranteeEmail =  C4::Context->preference("EnableRedirectGuaranteeEmail");
> +    if (!$enableRedirectGuaranteeEmail){
> +        $borrowerNumberToSendEmail = $borrowernumber;
> +        $guarantorid = undef;
> +    }

This logic works, but it is not clear to the person who reads code.

@@ +1574,5 @@
> +        my $guarantor = C4::Members::GetMember( 'borrowernumber' => $guarantorid );
> +        if ( $guarantor ){
> +            $to_address = $guarantor->{ $which_address };
> +        }
> +   }

Mixing which_address comparisons with guarantorid logic in the same if
structure level is not good coding style in my opinion.

::: installer/data/mysql/sysprefs.sql
@@ +116,4 @@
>  ('EnableBorrowerFiles','0',NULL,'If enabled, allows librarians to upload and attach arbitrary files to a borrower record.','YesNo'),
>  ('EnableOpacSearchHistory','1','YesNo','Enable or disable opac search history',''),
>  ('EnableSearchHistory','0','','Enable or disable search history','YesNo'),
> +('EnableRedirectGuaranteeEmail', '0', NULL, 'Enable the ability to redirect guarantee email messages to guarantor.', 'YesNo'),

R comes before S. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 02:27:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 00:27:48 +0000
Subject: [Koha-bugs] [Bug 13932] New: Allow a header to be considered
 trusted to provide the userid
Message-ID: <bug-13932-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13932

            Bug ID: 13932
           Summary: Allow a header to be considered trusted to provide the
                    userid
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: gmcharlt at gmail.com
          Reporter: robin at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

When Koha is placed behind an SSO system, it'd be useful to be able to get the
user ID, like happens with basic auth.

This patch allows a header to be considered an authoritative source of user ID.

This only works with a plack-like environment, when apache is running Koha as
CGI I think the headers come through using a different method.

An example configuration would be:

   <Location />
        ... mod_auth_mellon config goes here ...

    Header unset X_REMOTE_USER
    RequestHeader unset X_REMOTE_USER
    RequestHeader set X_REMOTE_USER %{MELLON_sfdcid}e
   </Location>

(REMOTE_USER seems to have a special use to apache that means it doesn't work,
hence using X_REMOTE_USER.)

For testing, you can fake it by replacing the variable with something hardcoded
and ignore all the SSO guff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 03:14:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 01:14:17 +0000
Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds
 system preferences to the Circulation Matrix
In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5786-70-WFr58yLbqc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #133 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
> PS: /me hopes no melting took place :-D

Not really. Actually it was never an option. It is just when I hear a word that
I like I'm so eager to use it :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 03:16:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 01:16:26 +0000
Subject: [Koha-bugs] [Bug 13933] New: t/DateUtils.t causes the build to break
Message-ID: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933

            Bug ID: 13933
           Summary: t/DateUtils.t causes the build to break
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: robin at catalyst.net.nz
        QA Contact: gmcharlt at gmail.com

DBI connect('dbname=koha;host=localhost;port=3306','kohaadmin',...) failed:
Can't connect to local MySQL server through socket
'/var/run/mysqld/mysqld.sock' (2) at /usr/share/perl5/DBIx/Connector.pm line 32
Can't call method "do" on unblessed reference at
/tmp/buildd/koha-3.19~git+20150331135711.7fa67b2f/blib/PERL_MODULE_DIR/C4/Context.pm
line 817.
# Looks like you planned 55 tests but ran 4.
# Looks like your test exited with 255 just after 4.
t/DateUtils.t ....................... 

This is caused by:

commit dd9f456ab7c2f0e66173a6feb7df2a38604c82cd
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue Jan 20 15:28:19 2015 +0100

    Bug 13601: Add tests to highlight the problems with
DateTime::Format::DateParse

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 03:17:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 01:17:59 +0000
Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break
In-Reply-To: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13933-70-b5P4A54l4R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13601
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 03:17:59 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 01:17:59 +0000
Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
In-Reply-To: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13601-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13601-70-74SPAJLFNe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13933

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 03:18:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 01:18:18 +0000
Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break
	(from bug 13601)
In-Reply-To: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13933-70-EBxzAxfz28@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|t/DateUtils.t causes the    |t/DateUtils.t causes the
                   |build to break              |build to break (from bug
                   |                            |13601)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 03:26:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 01:26:49 +0000
Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
In-Reply-To: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12532-70-2xo4nT3Bd3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |mtompset at hotmail.com

--- Comment #11 from M. Tompsett <mtompset at hotmail.com> ---
If you modify routines in C4 or Koha namespaces, you need to make sure there is
test coverage for your changes.

Failed to add tests to ./t/db_dependent/Members.t reflecting changes in
C4::Members::GetNoticeEmailAddress.

Failed to add tests to ./t/db_dependent/Letters.t reflecting changes in the
C4::Letters::_send_message_by_email routine, which is called by
SendQueuedMessages.

These tests would need to include things like intentional failures based on
specific system preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 04:01:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 02:01:43 +0000
Subject: [Koha-bugs] [Bug 5685] Validation of email address field
In-Reply-To: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5685-70-yGR4U843JI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

--- Comment #13 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37391
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37391&action=edit
Bug 5685: Validation of email address field

This patch adds server-side & client-side validation for email
form fields in the members/memberentry -view and in the
opac/memberentry-view (bootstrap).

I recently added simple validation for phone number and email address fields
for our in-house koha and saw this old bug: I'm open to any ideas on how
to do this better. Validation for phone numbers would be easy to add on
top of this but I left it out since this bug is only about the email
fields.

To test:
1) Select a member and go to any of the edit forms with email fields
(Primary info, "Library use", "Alternate address", "Alternative
contact").
2) Disable javascript in the browser in order to test server-side
validation and try to input invalid emails in each of the email form
fields.
3) Confirm that an invalid address is catched from any of the email
fields, an alert shown for each invalid address and that the member's
information was not updated with invalid data.
4) Enable javascript in the browser.
5) Confirm that the jquery validation plugin caches invalid addresses
from any of the email fields and that you cannot send the form before
correcting the problem.
6) Perform the same tests for the opac-memberentry-view.

Note: as the jQuery validation plugin doesn't exist in the bootstrap
folder, I just copied it over from the staff-client folder -how to deal
with this?

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

I have undone the changes to opac.css so that they can be submitted as a
separate patch. I have some other follow-ups to make as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 04:01:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 02:01:49 +0000
Subject: [Koha-bugs] [Bug 5685] Validation of email address field
In-Reply-To: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5685-70-o2gACuT95L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32623|0                           |1
        is obsolete|                            |

--- Comment #14 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37392
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37392&action=edit
Bug 5685 [Compiled CSS] Validation of email address field

This patch contains the recompiled opac.css file based on changes made
to opac.less in the previous patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 04:01:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 02:01:55 +0000
Subject: [Koha-bugs] [Bug 5685] Validation of email address field
In-Reply-To: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5685-70-i8m1ZwYpRr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32624|0                           |1
        is obsolete|                            |

--- Comment #15 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37393
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37393&action=edit
Bug 5685 [OPAC follow-up] Validation of email address field

This patch makes a few changes to the way errors are handled in the
OPAC:

- The validation plugin has been moved from the global include file to
  the template itself. Since we aren't doing form validation on any
  other page yet it doesn't make sense to include it globally at this
  time.

- The error message which appears if you have JavaScript disabled and
  have submitted invalid emails was styled in a non-standard way.

- I have added in-page links to the error message which appears if you
  have JavaScript disabled so that you can click to jump to the field
  which contains the error.

- I have modified the error message language slightly to make it (I
  hope) read better.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 04:05:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 02:05:33 +0000
Subject: [Koha-bugs] [Bug 5685] Validation of email address field
In-Reply-To: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5685-70-jwfa1lcFNv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
  Attachment #32622|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 04:07:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 02:07:45 +0000
Subject: [Koha-bugs] [Bug 5685] Validation of email address field
In-Reply-To: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5685-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5685-70-h7cmd4ct4R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #16 from M. Tompsett <mtompset at hotmail.com> ---
This seemed to be languishing a little. I hopefully have rebased appropriately.
jseppal at student.uef.fi, could you please confirm?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 04:58:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 02:58:34 +0000
Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t,
 testing all 'borrower' database fields
In-Reply-To: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13882-70-EkVtOz5hVE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 37394
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37394&action=edit
Bug 9120: Prevent form submission on adding tags - OPAC

At the OPAC, if the user adds tags pressing 'Enter', the page is
reloaded and the tags are not added.
To prevent that, this patch suggests to block the "press enter" event on
the inputs.

Test plan:
0/ Confirm the bad behavior, without this patch.
1/ Apply this patch and confirm nothing happen on pressing enter when
the focus is on the add tag input (At the opac, on the result view).

Patch works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:04:30 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:04:30 +0000
Subject: [Koha-bugs] [Bug 13069] Enable sort by title to ignore articles on
 circulation and patron detail pages
In-Reply-To: <bug-13069-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13069-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13069-70-wj4fotD0Tn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32237|0                           |1
        is obsolete|                            |

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37395
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37395&action=edit
Bug 13069 - Enable sort by title to ignore articles on circulation and patron
detail pages

With the conversion of the circulation and patron detail checkout
summary tables to AJAX recently we lost the ability to sort by title
while ignoring articles.

This patch corrects the problem by adding the "anti-the" configuration
to the relevant column in the DataTables initializtion script.

To test, apply the patch and clear your cache if necessary. Check out to
a patron who has multiple checkouts, some of which have titles beginning
with "a," "an," and "the." Sorting those checkouts by title should
ignore articles.

Test the patron detail page for that patron as well.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

NOTE: This is the one early in the javascript file.
      This is the one visible by having multiple checkouts
      where the title excluding the articles is a different
      order than titles including the articles.
      Patrons -> Details (scroll down to check out area, view
      checkouts and toggle the title sort)

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:04:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:04:39 +0000
Subject: [Koha-bugs] [Bug 13069] Enable sort by title to ignore articles on
 circulation and patron detail pages
In-Reply-To: <bug-13069-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13069-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13069-70-JBiCO26xL4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32238|0                           |1
        is obsolete|                            |

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37396
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37396&action=edit
Bug 13069 - (follow-up) Enable sort by title to ignore articles

This should affect the relatives' checkouts table too.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

NOTE: This is the one later in the javascript file.
      Checkout tab on the patron details page.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:06:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:06:19 +0000
Subject: [Koha-bugs] [Bug 13069] Enable sort by title to ignore articles on
 circulation and patron detail pages
In-Reply-To: <bug-13069-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13069-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13069-70-Tjk55uDmZR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
             Status|Patch doesn't apply         |Signed Off

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
I'm not sure if this should be back to Passed QA or what, but since I fixed it
and signed it off. I'll let someone else figure out what's next.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:09:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:09:57 +0000
Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests
In-Reply-To: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13928-70-fE4fez39oq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

--- Comment #3 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 37397
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37397&action=edit
Bug 9120: Prevent form submission on adding tags - OPAC

At the OPAC, if the user adds tags pressing 'Enter', the page is
reloaded and the tags are not added.
To prevent that, this patch suggests to block the "press enter" event on
the inputs.

Test plan:
0/ Confirm the bad behavior, without this patch.
1/ Apply this patch and confirm nothing happen on pressing enter when
the focus is on the add tag input (At the opac, on the result view).

Patch works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

http://bugs.koha-community.org/show_bug.cgi?id=13882
Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:11:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:11:28 +0000
Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests
In-Reply-To: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13928-70-6l1r4IgpIC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37397|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 37398
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37398&action=edit
Bug 9120: Prevent form submission on adding tags - OPAC

At the OPAC, if the user adds tags pressing 'Enter', the page is
reloaded and the tags are not added.
To prevent that, this patch suggests to block the "press enter" event on
the inputs.

Test plan:
0/ Confirm the bad behavior, without this patch.
1/ Apply this patch and confirm nothing happen on pressing enter when
the focus is on the add tag input (At the opac, on the result view).

Patch works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

http://bugs.koha-community.org/show_bug.cgi?id=13882
Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:11:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:11:45 +0000
Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests
In-Reply-To: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13928-70-ePN3oRsMYe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:32:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:32:19 +0000
Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t,
 testing all 'borrower' database fields
In-Reply-To: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13882-70-eQPBP5LZc8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com
  Attachment #37394|0                           |1
        is obsolete|                            |
  Attachment #37394|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:46:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:46:19 +0000
Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t,
 testing all 'borrower' database fields
In-Reply-To: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13882-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13882-70-XhfJof7hp6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

--- Comment #4 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
All tests pass, signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:47:13 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:47:13 +0000
Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests
In-Reply-To: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13928-70-h6xXNVkVcV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37398|0                           |1
        is obsolete|                            |
  Attachment #37398|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:47:25 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:47:25 +0000
Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests
In-Reply-To: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13928-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13928-70-Xzzf8MibwB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928

--- Comment #5 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
All tests pass, signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:48:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:48:04 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-ZlmdngtVO6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

--- Comment #5 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
Created attachment 37399
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37399&action=edit
Bug 9120: Prevent form submission on adding tags - OPAC

At the OPAC, if the user adds tags pressing 'Enter', the page is
reloaded and the tags are not added.
To prevent that, this patch suggests to block the "press enter" event on
the inputs.

Test plan:
0/ Confirm the bad behavior, without this patch.
1/ Apply this patch and confirm nothing happen on pressing enter when
the focus is on the add tag input (At the opac, on the result view).

Patch works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 05:48:41 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 03:48:41 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-GgAhC9fU5s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Aleisha Amohia <aleishaamohia at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleishaamohia at hotmail.com
  Attachment #37399|0                           |1
        is obsolete|                            |
  Attachment #37399|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 07:19:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 05:19:57 +0000
Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons
In-Reply-To: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11900-70-Oyuw0rqSo4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
           Severity|minor                       |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 07:22:16 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 05:22:16 +0000
Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label
	Printing
In-Reply-To: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10773-70-ZG4XBO84sI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #22 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 07:23:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 05:23:44 +0000
Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS
	authentication
In-Reply-To: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12887-70-mU1seC4xIc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 07:27:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 05:27:12 +0000
Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of
 "html" format or UTF-8
In-Reply-To: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12739-70-UXva9u3l0H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #24 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 07:28:33 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 05:28:33 +0000
Subject: [Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c,
	missing 100$a
In-Reply-To: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13855-70-W4kZM7u5cK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 07:31:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 05:31:45 +0000
Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and
	checkins
In-Reply-To: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12344-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12344-70-Ymrd3ACzxB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

Just a note Benjamin, you might want to fix your git.author and git.email
settings in your vagrant instance.

Ive fixed the author in the 3.18.x branch, but its still wrong in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 07:39:29 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 05:39:29 +0000
Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices
 cronjob is broken
In-Reply-To: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11120-70-lWQ9xw8AGj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #31 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 07:42:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 05:42:19 +0000
Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio
 details page in the intranet.
In-Reply-To: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11982-70-GYPPkvkimE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #35 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 07:44:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 05:44:31 +0000
Subject: [Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag
 from search results reloads the page
In-Reply-To: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9120-70-aH3HnRWSct@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.18.x will be in 3.18.6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 09:02:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 07:02:57 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-JyPCqphKvc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
*** Bug 10654 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 09:02:57 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 07:02:57 +0000
Subject: [Koha-bugs] [Bug 10654] Add feature: export basket in CSV,
 list of custom formats for various vendors
In-Reply-To: <bug-10654-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10654-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10654-70-gUagzmP2N1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10654

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---


*** This bug has been marked as a duplicate of bug 8612 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 09:04:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 07:04:28 +0000
Subject: [Koha-bugs] [Bug 10198] Add the ability to import and export
	authorized values
In-Reply-To: <bug-10198-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10198-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10198-70-PapiFFrKh6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10363

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 09:04:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 07:04:28 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10363-70-vUzSrg38Bw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10198

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 10:00:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 08:00:18 +0000
Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break
	(from bug 13601)
In-Reply-To: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13933-70-yG3XfJiTNd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 10:00:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 08:00:20 +0000
Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break
	(from bug 13601)
In-Reply-To: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13933-70-FqPrFrM5wP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37400
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37400&action=edit
Bug 13933: Fix t/DateUtils.t without DB

If the mysql server is not running, the DateUtils.t tests failed.
This is caused by

commit dd9f456ab7c2f0e66173a6feb7df2a38604c82cd
    Bug 13601: Add tests to highlight the problems with
    DateTime::Format::DateParse

The pref dateformat and TimeFormat were retrieved before the mock.
Before bug 13601, the complete preference method was mocked, that's why
the error did not appear.

Test plan:
  sudo service mysql stop
  prove t/DateUtils.t
should be happy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 10:00:46 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 08:00:46 +0000
Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break
	(from bug 13601)
In-Reply-To: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13933-70-Kiig8en5SI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 10:08:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 08:08:02 +0000
Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break
	(from bug 13601)
In-Reply-To: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13933-70-bcnvWA7xaj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 10:08:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 08:08:04 +0000
Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break
	(from bug 13601)
In-Reply-To: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13933-70-ACwJEIYuVK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37400|0                           |1
        is obsolete|                            |

--- Comment #2 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 37401
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37401&action=edit
Bug 13933: Fix t/DateUtils.t without DB

If the mysql server is not running, the DateUtils.t tests failed.
This is caused by

commit dd9f456ab7c2f0e66173a6feb7df2a38604c82cd
    Bug 13601: Add tests to highlight the problems with
    DateTime::Format::DateParse

The pref dateformat and TimeFormat were retrieved before the mock.
Before bug 13601, the complete preference method was mocked, that's why
the error did not appear.

Test plan:
  sudo service mysql stop
  prove t/DateUtils.t
should be happy

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 10:57:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 08:57:49 +0000
Subject: [Koha-bugs] [Bug 7806] Illegal dates are used to signal non
	existing dates.
In-Reply-To: <bug-7806-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7806-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7806-70-ZU2C5s2XUl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
How could we remove all the checks of 0000-00-00 in the code?
I personally have no good idea.

We could remove the not null constraint and update all date fields with NULL.
Or keep the constraint and update with 1970-01-01.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:01:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 09:01:02 +0000
Subject: [Koha-bugs] [Bug 7770] usage of OPACBaseURL
In-Reply-To: <bug-7770-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7770-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7770-70-1iarxeirWI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7770

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---


*** This bug has been marked as a duplicate of bug 5010 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:01:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 09:01:02 +0000
Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol
In-Reply-To: <bug-5010-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5010-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5010-70-kLQSEQUurc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laurence.lefaucheur at biblibr
                   |                            |e.com

--- Comment #88 from Jonathan Druart <jonathan.druart at biblibre.com> ---
*** Bug 7770 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:22:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 09:22:51 +0000
Subject: [Koha-bugs] [Bug 8658] Don't display patron attributes which have
 been limited to another patron category
In-Reply-To: <bug-8658-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8658-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8658-70-1SO4EWA6bN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8658

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I could be quite easy to hide them, but they will still be searchable.
To remove them from the patron search would be much more tricky.
Maybe an easier way would be to provide a script to remove the attributes which
should not be set for a patron.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 11:44:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 09:44:22 +0000
Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for
	xnciptoolkit driver
In-Reply-To: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13930-70-OAZR9uJpdY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at enger.priv.no

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 12:30:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 10:30:52 +0000
Subject: [Koha-bugs] [Bug 8504] patron import explains attributes import
	wrong
In-Reply-To: <bug-8504-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8504-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8504-70-2p5gRI2kj9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8504

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This does not appear anymore on the import patrons page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:27:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:27:36 +0000
Subject: [Koha-bugs] [Bug 8480] auth_subfield_structure is not cleared when
 deleting an authority type
In-Reply-To: <bug-8480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8480-70-Acjh2yswXU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8480

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:27:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:27:39 +0000
Subject: [Koha-bugs] [Bug 8480] auth_subfield_structure is not cleared when
 deleting an authority type
In-Reply-To: <bug-8480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8480-70-jlasVj9quw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8480

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37402
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37402&action=edit
Bug 8480: Add constraint on auth_subfield_structure.authtypecode

In order not to have useless entries in the auth_subfield_structure
table, this patch modifies the DB structure to add a foreign key on the
authtypecode column.
Note that the auth_tag_structure already has this constraint.

Test plan:
0/ Don't apply this patch
1/ Create a now authority type 'RM_ME'
2/ Look at the MARC structure, to create the subfield structure and
populate the auth_subfield_structure table.
3/ Delete the authority type
4/ Using your SQL cli:
 SELECT COUNT(*) FROM auth_subfield_structure WHERE authtypecode='RM_ME';
=> The data are still in this table.
5/ Apply this patch
6/ Execute the updatedb entry
7/ Confirm the entries in the auth_subfield_structure table related to
RM_ME have been deleted
8/ Repeat 1, 2 and 3 and verify the auth_subfield_structure entries have
been correctly removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:28:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:28:24 +0000
Subject: [Koha-bugs] [Bug 8480] auth_subfield_structure is not cleared when
 deleting an authority type
In-Reply-To: <bug-8480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8480-70-rgARxOiR8P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8480

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Note that this is also valid for marc_subfield_structure (I can provide a patch
if this patch is accepted).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:30:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:30:28 +0000
Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors
 in koha-error_log
In-Reply-To: <bug-8474-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8474-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8474-70-6BUXBD29wQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
  Attachment #11000|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:30:37 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:30:37 +0000
Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors
 in koha-error_log
In-Reply-To: <bug-8474-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8474-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8474-70-0gxTSW3QKI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:30:51 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:30:51 +0000
Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors
 in koha-error_log
In-Reply-To: <bug-8474-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8474-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8474-70-HOCeGV1O2R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
           Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:32:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:32:12 +0000
Subject: [Koha-bugs] [Bug 8471] loading an sql file into mysql,
 often fails when loading the 'letter' table
In-Reply-To: <bug-8471-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8471-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8471-70-Jx1Mvot3bU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8471

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This is certainly not valid anymore.
Please reopen if I am wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:32:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:32:23 +0000
Subject: [Koha-bugs] [Bug 8471] loading an sql file into mysql,
 often fails when loading the 'letter' table
In-Reply-To: <bug-8471-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8471-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8471-70-e0iWzPLu3R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8471

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:35:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:35:23 +0000
Subject: [Koha-bugs] [Bug 8423] Koha/SearchEngine/Zebra/Search.pm fails
	'perl -c' test
In-Reply-To: <bug-8423-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8423-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8423-70-qlFTGZU1wi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8423

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Files removed by bug 12538.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:43:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:43:01 +0000
Subject: [Koha-bugs] [Bug 13875] Columns configuration - table name cannot
 contain underscore
In-Reply-To: <bug-13875-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13875-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13875-70-dsDb2oMmtF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13875

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37013|0                           |1
        is obsolete|                            |

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 37403
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37403&action=edit
[SIGNED-OFF] Bug 13875: Columns configuration - Allow underscore in table name

This is a bug fix for bug the columns configuration feature, and
specialy for bug 13864.

Test plan:
Apply patches on bug 13864 and save columns for the late orders (in the
columns configuration admin page).
Confirm that they are correctly saved.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:43:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:43:58 +0000
Subject: [Koha-bugs] [Bug 13875] Columns configuration - table name cannot
 contain underscore
In-Reply-To: <bug-13875-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13875-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13875-70-KbypKz3YnG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13875

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 13:53:32 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 11:53:32 +0000
Subject: [Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
In-Reply-To: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13254-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13254-70-Nfalc2jmRZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254

--- Comment #12 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Mason James from comment #11)
> (In reply to Fridolin SOMERS from comment #8)
> > Dirty bug indeed.
> > Can this be backported to 3.16.x ?
> 
> Pushed to 3.16.x, will be in 3.16.9

Thanks a lot ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:20:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 12:20:01 +0000
Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date
In-Reply-To: <bug-8417-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8417-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8417-70-tNnqDQvIob@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 14:20:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 12:20:03 +0000
Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date
In-Reply-To: <bug-8417-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8417-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8417-70-J2QEW2hJXn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37404
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37404&action=edit
Bug 8417: Make the order receive date editable

Currently the date of the order reception is the date of shipping date,
which is wrong.
This patch makes this date editable (with default is today).

Test plan:
1/ Create an order and receive it
2/ Confirm that you can edit the reception date and it's take into
account as the datereceived.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:17:58 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 13:17:58 +0000
Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create
 duplicate fields in biblio
In-Reply-To: <bug-13760-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13760-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13760-70-Mmd4dgRegs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:18:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 13:18:52 +0000
Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date
In-Reply-To: <bug-8417-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8417-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8417-70-bXVjfMC9Mi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kohapatch at gmail.com         |jonathan.druart at biblibre.co
                   |                            |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:32:36 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 13:32:36 +0000
Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message
 for authorities
In-Reply-To: <bug-8399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8399-70-WPCiVQap96@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:32:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 13:32:39 +0000
Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message
 for authorities
In-Reply-To: <bug-8399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8399-70-N2TBo8VwRt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37405
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37405&action=edit
Bug 8399: Display tab number on the mandatory field alert (authority)

A wrong variable scope was used here, the number value is contained in
the BIG_LOOP (note for later: change this variable name...).

Test plan:
1/ Define 1+ mandatory fields for an authority type
2/ Create an authority and don't fill the mandatory fields
3/ Try to save: the popup alert should display the number of the tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:33:14 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 13:33:14 +0000
Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message
 for authorities
In-Reply-To: <bug-8399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8399-70-0tI8MkcH7i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:33:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 13:33:23 +0000
Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message
 for authorities
In-Reply-To: <bug-8399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8399-70-kgcI7ks42a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:34:28 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 13:34:28 +0000
Subject: [Koha-bugs] [Bug 8397] Can import patrons with duplicate userids
In-Reply-To: <bug-8397-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8397-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8397-70-fvebuluBnY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
             Status|NEW                         |RESOLVED

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Should have been fixed by bug 1861.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:37:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 13:37:31 +0000
Subject: [Koha-bugs] [Bug 8389] BEGIN considered harmful
In-Reply-To: <bug-8389-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8389-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8389-70-Yhx3vud7KW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8389

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=13275
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:37:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 13:37:31 +0000
Subject: [Koha-bugs] [Bug 13275] (OMNIBUS) Tests on t/ should pass without a
	DB
In-Reply-To: <bug-13275-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13275-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13275-70-6316eNcR35@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13275

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8389

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 15:49:03 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 13:49:03 +0000
Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined
In-Reply-To: <bug-8361-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8361-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8361-70-tQDKSLSse8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Is this still an issue?
Why should we refuse checkouts if no rule is defined?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:01:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:01:23 +0000
Subject: [Koha-bugs] [Bug 5002] No error message if category code already
	exists
In-Reply-To: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5002-70-GhNm3O2zfR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:01:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:01:23 +0000
Subject: [Koha-bugs] [Bug 8287] remove filter on checked out from overdues
In-Reply-To: <bug-8287-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8287-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8287-70-9ZMSpHqlRc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8287

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
What could be a correct wording for the checkbox label and the page/report
title?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:01:43 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:01:43 +0000
Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work
In-Reply-To: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3969-70-6mcIkhh8hR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #25 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:02:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:02:15 +0000
Subject: [Koha-bugs] [Bug 5844] Unhilight cuts off some strings
In-Reply-To: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5844-70-ccaBwc9S12@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:02:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:02:39 +0000
Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export
In-Reply-To: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13695-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13695-70-QgwhoYNBsD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:03:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:03:26 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-TLR1zVsTUE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:04:05 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:04:05 +0000
Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr
In-Reply-To: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12291-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12291-70-QplbdIc8pb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Jonathan and Magnus!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:04:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:04:31 +0000
Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many
	patrons
In-Reply-To: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13740-70-zo2Q7ZZ7iZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:04:55 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:04:55 +0000
Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
In-Reply-To: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13531-70-aaR75rYL7Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Thomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:05:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:05:18 +0000
Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
In-Reply-To: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13869-70-XjDqOIHYKz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:11:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:11:04 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-jt3FlIt95K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias.meusburger at biblibr
                   |                            |e.com

--- Comment #81 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
I've tested the last version of this patch following the more recent test plan
provided.

Everything works to me.

I'm signing off the patch.

Can someone have a look at the QA? (Should not be much, as most of the problems
were already addressed)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:12:06 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:12:06 +0000
Subject: [Koha-bugs] [Bug 8276] circ history not sorting right
In-Reply-To: <bug-8276-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8276-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8276-70-vsNG5QHZ8P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37406
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37406&action=edit
Bug 8276: circ history - checked out items are later

If the sort is done on "checkin on", the items currently checked out
should be list after all others.

Test plan:
1/ Go on the checkout history page for a record with checked out items
2/ Sort on the "checkin on" column and confirm that the checked out
items are sorted after/before others depending on the sort order
(asc/desc).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:12:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:12:04 +0000
Subject: [Koha-bugs] [Bug 8276] circ history not sorting right
In-Reply-To: <bug-8276-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8276-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8276-70-7KCqL7gqU5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:12:18 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:12:18 +0000
Subject: [Koha-bugs] [Bug 8276] circ history not sorting right
In-Reply-To: <bug-8276-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8276-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8276-70-eLW5uAKhJ4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:17:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:17:53 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-2nQ8n3sMRK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #82 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 37407
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37407&action=edit
[SIGNED-OFF] Bug 8236 Renewing policy in overdue or restriction case

This patch introduces 2 sysprefs :
    RestrictionBlockRenewing to allow/block renewal of items when patron is
restricted.
    OverduesBlockRenewing to allow, block only the late ones or block all
checked out items
    Default is "allow" in both case.

Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:19:08 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:19:08 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-SlE4w3KAvh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36743|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:19:35 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:19:35 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-vPpVUVsks8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:36:23 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:36:23 +0000
Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
In-Reply-To: <bug-8246-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8246-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8246-70-fEvCpPtGou@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37408
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37408&action=edit
Bug 8246: Allow deleting record if no more items

The "Delete records if no items remain" was only available if the batch
did not contain "too many" items (see MaxItemsForBatch).
This limitation does not make any sense.

Test plan:
1/ Set MaxItemsForBatch=10
2/ Use the batch item deletion to delete 10+ items
3/ Confirm the checkbox "Delete records if no items remain" is displayed
4/ Check it
5/ Launch the job

Verify that the records without items have been deleted also.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:36:20 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:36:20 +0000
Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
In-Reply-To: <bug-8246-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8246-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8246-70-tPks64ohI8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:37:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:37:22 +0000
Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox
In-Reply-To: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13068-70-okhnkQVwvJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #107 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Improvement pushed to master.

Thanks Paul and Marcel.
Please help me update the wiki to reflect the new workflow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:37:22 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:37:22 +0000
Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete
In-Reply-To: <bug-8246-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8246-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8246-70-69tKxJGvUb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:37:48 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:37:48 +0000
Subject: [Koha-bugs] [Bug 13857] Email input field for sharing lists is too
	small
In-Reply-To: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13857-70-9bvM5h22UU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13857

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:38:10 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:38:10 +0000
Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to
	OpacAdditionalStyleSheet
In-Reply-To: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10328-70-APDwcankjD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:38:45 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:38:45 +0000
Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts
In-Reply-To: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11201-70-I3aGB7Euo8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #24 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:39:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:39:07 +0000
Subject: [Koha-bugs] [Bug 13890] Full serial permission is needed to change
 sequence on a routing list
In-Reply-To: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13890-70-wpLzNTAM7g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:39:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:39:34 +0000
Subject: [Koha-bugs] [Bug 7391] Return to cart after adding items to a list
In-Reply-To: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7391-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7391-70-0eIfzDXibL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7391

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:40:02 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:40:02 +0000
Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create
 new fines with an amount outstanding of 0
In-Reply-To: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13841-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13841-70-yGu9ByAM21@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Nice one Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:55:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:55:19 +0000
Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well
	formatted
In-Reply-To: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13868-70-txBySw6l4S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:55:49 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:55:49 +0000
Subject: [Koha-bugs] [Bug 6820] hide receive option if there is nothing to
	receive
In-Reply-To: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6820-70-nx9KdgSaTp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Samuel!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:56:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:56:19 +0000
Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the
	"alphabet" syspref
In-Reply-To: <bug-13686-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13686-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13686-70-f5v6atxdlF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patches pushed to master.

Thanks Viktor!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:56:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:56:42 +0000
Subject: [Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related
 to permission
In-Reply-To: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13898-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13898-70-cQmr9maY3H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 16:59:31 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 14:59:31 +0000
Subject: [Koha-bugs] [Bug 13859] Fix item search result list - obsolete "by"
 and display of publication date for MARC21
In-Reply-To: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13859-70-3K5et32bV3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:15:52 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 15:15:52 +0000
Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with
	STRICT_TRANS_TABLES
In-Reply-To: <bug-13523-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13523-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13523-70-j48PVfGUuG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523

Stephen Warren <swarren at wwwdotorg.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |swarren at wwwdotorg.org

--- Comment #20 from Stephen Warren <swarren at wwwdotorg.org> ---
I have 3.18.05.1 installed from your dpkg repo, so I think I have this fix:

> # dpkg -l koha-common
> ii  koha-common  3.18.05.1  all  integrated (physical) library management system

I'm still seeing this error when editing items (as reported by my user; I can
get more details exactly which edit page she's using if needed).

I checked my database and as far as I can tell, the DB schema patch has been
applied:

> mysql> show columns from biblioitems;
> | Field                 | Type         | Null | Key | Default           | Extra                       |
> ...
> | marcxml               | longtext     | YES  |     | NULL              |                             |

Was the "edit" use-case not covered by the patch, or is there something else I
should look at to track down the issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:28:01 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 15:28:01 +0000
Subject: [Koha-bugs] [Bug 9580] Cover image from Coce,
	a remote image URL cache
In-Reply-To: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9580-70-3sI7z6Z0C0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #66 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I'm willing to push this ASAP. Two questions:

- Do you think we could have a "Coce" syspref that could serve as a global
switch instead of testing for CoceHost? That would make it consistent with how
the rest of the enhanced content services are set in Koha.

- Does Coce provide a way to set custom providers? If it doesn't, we don't need
a free text syspref, could we make the CoceProviders a 'multiple' type syspref?
With fixed values: aws, gb and ol? [1]

I can just provide a followup implementing this changes if you want to, I only
want your opinion before doing so.


[1] With proper descriptions. Check OpacAdvSearchOptions on the .pref file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:30:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 15:30:00 +0000
Subject: [Koha-bugs] [Bug 8198] Need to track the call to
 "C4::Context->userenv->{'xxxx'} without check if it is undefined
In-Reply-To: <bug-8198-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8198-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8198-70-2gTdx9yG0C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8198

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Maybe the following change would do the trick:

diff --git a/C4/Context.pm b/C4/Context.pm
index cc93af4..14ce1c7 100644
--- a/C4/Context.pm
+++ b/C4/Context.pm
@@ -1085,7 +1085,7 @@ sub userenv {
     if (defined $var and defined $context->{"userenv"}->{$var}) {
         return $context->{"userenv"}->{$var};
     } else {
-        return;
+        return {};
     }
 }

Need to be confirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 17:38:44 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 15:38:44 +0000
Subject: [Koha-bugs] [Bug 11144] Switch order of overdues and fines cronjob
 for packages and in crontab.example
In-Reply-To: <bug-11144-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11144-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11144-70-g0rhKchUj9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 18:29:07 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 16:29:07 +0000
Subject: [Koha-bugs] [Bug 10071] language improvement for holds/transfers
In-Reply-To: <bug-10071-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10071-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10071-70-8HgrvaAhoa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10071

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Heather Braum <hbraum at nekls.org> ---
At some point before 3.18, this bug has been sorted out; it is fixed in 3.18.4.
The language now on the patron's holds tab in circulation.pl or moremember.pl
is "Item is in transit from [branch] since [date]. 

Also, bug 13122 may have had something to do with resolving this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 19:03:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 17:03:17 +0000
Subject: [Koha-bugs] [Bug 9580] Cover image from Coce,
	a remote image URL cache
In-Reply-To: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9580-70-A1o8aqO7e2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

--- Comment #67 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 37409
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37409&action=edit
Bug 9580: (QA followup) add a Coce syspref and fix options for Providers

This proposed followup adds a 'Coce' syspref so it is consistent with the rest
of the enhanced
content providers sysprefs (also, there's no point making the user delete its
configuration
if disabling his Coce integration for testing purposes, for example).

It also changes the CoceProviders syspref so it is a 'multiple' type syspref.
It puts
some sensible descriptions to the options too.

Feel free to discuss this followup, it is just an idea!

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 19:11:00 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 17:11:00 +0000
Subject: [Koha-bugs] [Bug 9580] Cover image from Coce,
	a remote image URL cache
In-Reply-To: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9580-70-PZkRgCxABi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

--- Comment #68 from Fr?d?ric Demians <frederic at tamil.fr> ---
> I'm willing to push this ASAP. Two questions:

+1

> - Do you think we could have a "Coce" syspref that could serve as a global
> switch instead of testing for CoceHost? That would make it consistent with
> how the rest of the enhanced content services are set in Koha.

Ok. I do it and send an amended patch.

> - Does Coce provide a way to set custom providers? If it doesn't, we don't
> need a free text syspref, could we make the CoceProviders a 'multiple' type
> syspref? With fixed values: aws, gb and ol? [1]

For the time being, Coce support only 3 images providers. But the system is
designed to be extended, so it can change in the future. I'd recommend not to
impose choices in Koha system preference. Forcing choices would prevent using
new providers as soon as available.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 19:18:42 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 17:18:42 +0000
Subject: [Koha-bugs] [Bug 9481] charge not showing fines
In-Reply-To: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9481-70-I9tMrM6Qsw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #26 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Rafal!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 19:19:04 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 17:19:04 +0000
Subject: [Koha-bugs] [Bug 4277] budget planning refreshes funny
In-Reply-To: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4277-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4277-70-SK3yzhEeGI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4277

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Joubu!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 19:19:53 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 17:19:53 +0000
Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for
	performance
In-Reply-To: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13852-70-kQzBDGxDum@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks (for the Pastis) Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 19:20:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 17:20:17 +0000
Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation
	report overdue.pl
In-Reply-To: <bug-13549-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13549-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13549-70-wa9iE8WfMJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |tomascohen at gmail.com

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Patch pushed to master.

Thanks Justin!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 19:24:34 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 17:24:34 +0000
Subject: [Koha-bugs] [Bug 9580] Cover image from Coce,
	a remote image URL cache
In-Reply-To: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9580-70-8dJpc4n6q7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37409|0                           |1
        is obsolete|                            |

--- Comment #69 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 37410
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37410&action=edit
(QA followup) add a Coce syspref and fix options for Providers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 20:01:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 18:01:24 +0000
Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table
In-Reply-To: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13887-70-fBOmM6d6yo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 20:01:26 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 18:01:26 +0000
Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table
In-Reply-To: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13887-70-J2DUT9mjNt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37388|0                           |1
        is obsolete|                            |

--- Comment #7 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 37411
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37411&action=edit
Bug 13887 - Add datatables to item specific holds table

This patch adds datatables functionality to the item specific holds table

To test:
1 - Apply patch
2 - Attempt to place an item specific hold for a patron
3 - Note that columns are now sortable and searchable
4 - Ensure that you can place both specific and next available holds as before

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 20:08:27 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 18:08:27 +0000
Subject: [Koha-bugs] [Bug 13934] New: Check in fails on master "Can't bless
 non-reference at .../ItemType.pm Line 64"
Message-ID: <bug-13934-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934

            Bug ID: 13934
           Summary: Check in fails on master "Can't bless non-reference at
                    .../ItemType.pm Line 64"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at quecheelibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Check in some barcodes on master and you get the perl error above

tcohen says git bisect points to 7431f8cfe29e330e2232b0df591afc4d923b0a52

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 20:09:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 18:09:15 +0000
Subject: [Koha-bugs] [Bug 9580] Cover image from Coce,
	a remote image URL cache
In-Reply-To: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9580-70-6X5mmZgGr0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

--- Comment #70 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
We could perhaps add a route to lookup available providers on the specified
coce server?  That would allow koha's syspref to be 'clever' about presenting
the available provider for your specific coce server.

I say this as for instance in the UK, I'm rather tempted to write a BDS
connector for coce..  but BDS is uk only, so our coce instance would support it
but others may not.

Any thoughts Frederic?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 20:11:19 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 18:11:19 +0000
Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include
	more options
In-Reply-To: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13885-70-vZfdyFjOLD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from Nick Clemens <nick at quecheelibrary.org> ---
Not my bug causing it, problem is on master (bug 13943) , but can't test until
that is cleared

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 20:12:40 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 18:12:40 +0000
Subject: [Koha-bugs] [Bug 9580] Cover image from Coce,
	a remote image URL cache
In-Reply-To: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9580-70-jEItH8bjan@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

--- Comment #71 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #70)
> I say this as for instance in the UK, I'm rather tempted to write a BDS
> connector for coce..  but BDS is uk only, so our coce instance would support
> it but others may not.

I always try to avoid letting the user making mistakes/breaking their
configuration (and have features fully documented). That's the POV that
motivated my followup change to 'multiple'.

We could have a CoceCustomProviders syspref that is free text.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 20:25:39 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 18:25:39 +0000
Subject: [Koha-bugs] [Bug 9580] Cover image from Coce,
	a remote image URL cache
In-Reply-To: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9580-70-yyO9uc7EcX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

--- Comment #72 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'd say, feel free to push as is.. I'll submit a followup to both coce and koha
to show what I mean afterwards ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 21:15:24 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 19:15:24 +0000
Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include
	more options
In-Reply-To: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13885-70-XuCgL1hc92@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885

--- Comment #6 from Nicole C. Engard <nengard at gmail.com> ---
What is the bug number? that one doesn't exist, I was going to add it as a
dependency here.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 21:21:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 19:21:17 +0000
Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include
	more options
In-Reply-To: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13885-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13885-70-HPTEdYDuQv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13934

--- Comment #7 from Nick Clemens <nick at quecheelibrary.org> ---
(In reply to Nicole C. Engard from comment #6)
> What is the bug number? that one doesn't exist, I was going to add it as a
> dependency here.
> 
> Nicole

13934, stupid fingers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 21:21:17 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 19:21:17 +0000
Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless
 non-reference at .../ItemType.pm Line 64"
In-Reply-To: <bug-13934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-13934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13934-70-gIS2j3JluT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13885

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 21:56:15 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 19:56:15 +0000
Subject: [Koha-bugs] [Bug 12618] Sending of authority records via Z39.50
In-Reply-To: <bug-12618-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-12618-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12618-70-BQqsutxwlT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12618

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Zeno Tajoli <z.tajoli at cineca.it> ---
It isn't a bug but a request on help about setup of z39.50 server

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Mar 31 23:10:12 2015
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Mar 2015 21:10:12 +0000
Subject: [Koha-bugs] [Bug 9580] Cover image from Coce,
	a remote image URL cache
In-Reply-To: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9580-70-XvDncjSWfI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

--- Comment #73 from Fr?d?ric Demians <frederic at tamil.fr> ---
Martin: This idea of a Coce route responding with available providers sound
good of course. But the the difficulty would be Koha side in the syspref
editor to display those info appropriately. The way Tomas has displayed the 3
currently available providers is really good and consistent, and easy to
extend if required. 

Concerning BDS integration, I can't say a lot since I don't know what it is at
all. Adding a new provider shouldn't be too difficult. You have to add a
method to the CoceFetcher class. If you have a public API for BDS, I could
take a look.

What I'd like to add to Coce is its integration with an image storage server
which could replace the one integrated in Koha: local cover images. This would
allow libraries to share scanning work, and stop this madness which consist to
store images directly in the DB. I have several libraries that have MySQL DB
made up of 95% of image data.

A new image storage server may just be a new OpenLibrary project. So it may be
a bad idea. But I had the feeling OpenLibrary was stopping its activity.

-- 
You are receiving this mail because:
You are watching all bug changes.