[Koha-bugs] [Bug 13787] New: Clean up noisy koha qa tool warnings

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787

            Bug ID: 13787
           Summary: Clean up noisy koha qa tool warnings
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: mtompset at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

While testing bug 10937, there were noisy warnings, which
distracted from testing the functionality of it.

Here is a snippet of the after the patch warnings:
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 384.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.

Tweaking the [% IF %] statements eliminated the warnings.

TEST PLAN
---------
1) Apply patch
2) Run koha qa test tools.
   -- there will be noisy warnings in the before processing, but
      there will be no such messages in the after processing.
3) git diff origin/master
   -- there should be no visible typos.

-- 
You are receiving this mail because:
You are watching all bug changes.