[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, here it is: 

- We failed to get superserials and this patch set into the same version. 
- Superserials permission has been in use for quite a while now (see bug 8435) 
- This patch currently updates your permission set to add 'superserials' to it,
if you had the permission to claim serials before.
- We have a time gap here that will cause some change in behaviour, no matter
how we do it.

So this is the situation as I see it:

1) Not using IndependentBranches
= Nothing needs to be done, because nothing should change. 
No need to update the permissions in that case. 
We could add an additional check for IndependentBranches to the database
update.

2) Using IndependentBranches

a) Having superserials permission already
= Nothing changes

b) Not having superserials permission before update
= Can now suddenly manage serials from other branches after the update.
If we don't update the permission:
= Can suddenly no longer claim issues from other branches

So what can we do here?
- Introducing a 'superserialclaim permission' seems silly.
- Taking away a smaller permission seems making more sense than giving access
to even more data than before.
- I'd vote for 'don't add the superserials permission on update'.

Another thing: If I am not allowed to claim the issues from other branches,
should these issues be visible to me? A user without
superlibrarian/superserials will still see all issues that need claiming in the
serial claim view, but they will miss the checkbox for claiming them. This
doesn't seem to make sense, as I can't find the subscription using the
search... but I can access it form the link. This is not very clean.

I think the access problem could be on a separate bug ("Can still access other
branches subsriptions with IndyBranches and no superserials"), but I'd really
like to see a filtered view for the claims.

Jonathan, could you take a look? Woudl also be good to get more opinions about
b).

-- 
You are receiving this mail because:
You are watching all bug changes.