[Koha-bugs] [Bug 10988] Allow login via Google OAuth2

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #28 from David Cook <dcook at prosentient.com.au> ---
(In reply to M. Tompsett from comment #26)

> I would think the parameter would be better renamed to $AuthenticatedEmail,
> because persona and this OAuth patch both authenticate against an Email
> address (the primary email address is used to find the user).
> 

Yeah, I thought about that a bit, but it also sets a "persona" key in the
session, which I think might be used for persona session management, so
re-using it without careful checking could lead to weirdness with Persona. 

> NOOOOOO! Please hashref the parameter!
> If there are more than 3 parameters, you probably should use a hashref.

...

Yes, a single hashref would be nicer. If I were designing a new sub, I would
use a single hashref. However, I'm personally not planning on refactoring
C4::Auth::checkauth() and testing every use of it. Nor am I going to add
checking to checkauth() so that it can use a single hashref OR a bunch of
scalars. That just leads to more technical debt.

Of course, I'm not planning on upstreaming my OpenID Connect work at the moment
anyway, so it doesn't really matter. I'm sure whoever refactors checkauth()
someday will use a single hashref instead.

-- 
You are receiving this mail because:
You are watching all bug changes.