[Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 36407
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36407
[Signed-off] Bug 13350 - Untranslatable strings in aqbudgetperiods.tt

Review of attachment 36407:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13350&attachment=36407)
-----------------------------------------------------------------

Hi Héctor,

I think something strange is going on here and I would like to avoid changing
how the bradcrumbs display the last bit - could you take another look? Also
adding Bernardo, maybe he has some ideas.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
@@ +238,2 @@
>          [% ELSE %]
> +            Delete budget <i>'[% budget_period_description %]'?</i>

I am not sure why the ' would cause the strings to be not translatable, but
probably easisest would be to just remove them and maybe also the <i>? Thinking
about how this looks like in other places in Koha.

@@ +240,5 @@
>          [% END %]
>      [% END %]
>      <!-- duplicate a budget -->
>      [% IF ( duplicate_form ) %]
> +        <a href="/cgi-bin/koha/admin/aqbudgetperiods.pl">Budgets</a> › <strong>Duplicate budget</strong>

I think we shouldn't use strong here, as the current page is not highlighted
like that on the other pages. I think a <span> should do the trick without an
optical change, but it would be a little better to see why these pages don't
get translated, while other pages work correctly and adjust the code to look
the same (hope I make sense).

@@ +257,5 @@
>      [% END %]
>      <!-- display budget periods list -->
>      <!-- ########################################## -->
>      [% IF ( else ) %]
> +        <strong>Budgets administration</strong>

Same here as above - there are a lot of strange looking comments on this site.
Hm.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.