[Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch from institution_id field AO

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666

--- Comment #5 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Actually, AO is respected in checkins already, as AddReturn takes $branch as
param, whereas AddIssue does not.

I suppose the only reason AO was not respected in checkout initially was due to
the fact that AddIssue doesn't take $branch as param, and this probably was
left to be solved in AddIssue at a later stage. The web interface requires user
to specify branch before checkout, so C4::Context->userenv->{'branch'} is set
which is the same as this patch does.

For Renew, location has no effect, and hold takes its own param,
pickup_location (BR), so that's the reason only checkout is handled in this
patch, which, in my opinion, should have been handled by AO in the first place,
as SIP is a transport protocol and should not have other dependencies than
authentication.

Also, the protocol specifies that AO is a required field in all transactions
and maps to the library’s institution ID, so SIP clients should adher to this.

Anyway, if AO is left empty, the transaction will fallback to user context, so
the patch will not cause anyone trouble

-- 
You are receiving this mail because:
You are watching all bug changes.