[Koha-bugs] [Bug 13812] New: Facet links broken when shelf location limit is used.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812

            Bug ID: 13812
           Summary: Facet links broken when shelf location limit is used.
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

This bug is analogous to Bug 13442, but it affects shelf location rather than
collection code:

Limiting a search by shelf location is broken, because it wraps double-quotes
around the "value" part of the key-value pair in the URL. This breaks the href=
part of the anchor tag.

The anchor tag generated for the shelf location faced is

<a
href="/cgi-bin/koha/opac-search.pl?&limit=mc-loc%3A"100100ADFICCF"&limit=mc-loc%3A"100200ADFIC"&limit=mc-loc%3A"100250ADFICGN"&limit=mc-loc%3A"100300ADFICHF"&limit=yr%2Cst-numeric%3D2014-&sort_by=acqdate_dsc&limit=au:Paetro%2C%20Maxine%2C"
title="Paetro, Maxine,">Paetro, Maxine,</a>

Once again, double-quotes inside the URL are causing a premature close of the
href, which results in a broken link.

I think that we need to take a look for code duplication inside
C4::Search::buildQuery -- if there's more than one section of code where we're
wrapping quotes around the 'value' part of the query, these should be
consolidated -- shouldn't we be using URL encoding for URL reserved characters
anyway?

-- 
You are receiving this mail because:
You are watching all bug changes.