[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #16 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
There are a few problems with these patches. First the existing behaviour is
consistent with the standard ( 0 because a checkin has not succeeded) however I
can see that there is probably no practical distinction between checkin of an
unissued book and an issued one especially if some machines are routing returns
incorrectly as a result. But we should document it as a change in behaviour so
it gets reported as that in release notes (in case there are unforeseen
consequences)

The commit message also gives a test which does not succeed it says the message
is not returned after the patch is applied, but it is (incidently I think it
should still be returned as information, so the code is ok the test fails)

Finally the patch adds a new parameter into the config files but there is a) no
mention of it and b) it doesnt seem to be of any use in the implementation

-- 
You are receiving this mail because:
You are watching all bug changes.