[Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

thx a lot for taking a look at those really old bugs!

I have tested this, but it does not seem to work quite right yet:

AnonymousPatron = 5
My user = 1

1) AnonSuggestions = ON
OPACViewOthersSuggestions = OFF
- purchase suggestion shows in OPAC navigation - OK
- purchase suggestion tab is gone from the patron account - NOT OK?
- Although the user is logged in, the suggestion is added to the
AnonymousPatron. This seems not right, I think it should only happen for
borrowers not logged in or the pref needs to be clarified:

Don't allow/allow patrons that aren't logged in to make purchase suggestions.
Suggestions are connected to the AnonymousPatron syspref 

To me the first makes more sense, but maybe there is a need for both?
- allow not logged in users to also make suggestions, treat logged in users
normally
- force all purchase suggestions to be anonymous?

2) AnonSuggestions = OFF
OPACViewOthersSuggestions = ON
Suggestions exist from: 5, 1, 2
- purchase suggestion shows in OPAC navigation - OK
- purchase suggestion tab shows in patron acount - OK
- If you select "Me" the pull down jumps back to "Anyone" after sending the
form - NOT OK

3) AnonSuggestions = ON
OPACViewOthersSuggestions = ON
- purchase suggestion shows in OPAC navigation - OK
- purchase suggestion tab doesn't show in patron account - NOT OK?
- only the anonymous suggestion shows, even after submitting 'anyone' - NOT OK

I think we need to figure out how AnonSuggestions should work first, because
this would also change 3). If it forces all to anonymous intentionally, we
shouldn't show the me/anyone pull down there. If it's a bug, 3) is ok, but we
should create suggestions for logged in users with their borrowernumber.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.