[Koha-bugs] [Bug 13898] Remove unused code in moremember.pl related to permission

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Mar 24 22:47:05 CET 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13898

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I was curious, as this code looks basically right, but is not used, as you
pointed out. This is the commit that added it to Koha:
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=05b61e4f3a57828d0bc7d400cfc4bb97c4402a71

It seems to have been broken sometime between 3.10 - 3.12:
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8fd75227fcd87d2cea5d0cb31d7af72498fbb24d;hp=25232635f538ffb5582f56536c242d48f433018b#patch2

I wondered... should we bring it back instead of deleting it? 
I think it would just affect the behaviour for the IndependentBranches (not
being able to delete another branches users).
But I guess in order to make this really work consistently, we'd have to add
this variable to all the .pl scripts on the various pages that show the members
toolbar? This might be the reason why this has been removed in the first place. 

Passing QA... but leaving my notes here :)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list