[Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

--- Comment #122 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 36617
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36617
[PASSED-QA] Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to
the Circulation Matrix

Review of attachment 36617:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5786&attachment=36617)
-----------------------------------------------------------------

::: opac/opac-search.pl
@@ +602,5 @@
> +            if ($borrower) {
> +                $_->{holdable} =
> +                    IsAvailableForItemLevelRequest($_, $borrower) &&
> +                    OPACItemHoldsAllowed($_, $borrower)
> +                  foreach @newresults;

This totally breaks the OPAC search - resulting in a Perl error: 
No homebranch at /home/katrin/kohaclone/C4/Reserves.pm line 2157.

I think $_ is not what you think - especially with using XSLT results. It looks
like the HTML output that is created for display if my tests are correct.

The same code is used in the if condition above.

Using $_ and the foreach at the end also makes this quite a confusing read.

-- 
You are receiving this mail because:
You are watching all bug changes.