[Koha-bugs] [Bug 5617] fix-perl-path.pl misses some files

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5617

--- Comment #8 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #7)
> Tomas, Robin,
> 
> I thought this one was easy to fix replacing the current shebang with
> /usr/bin/env perl
> But it seems there are a lot of pros and cons
> (https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58 for
> instance).
> 
> Could I get your opinion on this?

I don't have a strong opinion, but I think we probably shouldn't go with
/usr/bin/env based on that thread. If the problem is that fix-perl-path.pl is
missing some files, then that should probably be fixed to use file(1) or grep
or something to detect what needs to be changed.

Would it be better to have MakeMaker do its thing and let it take care of the
problem? In that case, rerunning the install would have sorted it, and I don't
think that's too high of a bar when you're dealing with rolling with a custom
perl.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.