[Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 33661
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33661
Add a system preference to define the number of days used in
purge_suggestions.pl

Review of attachment 33661:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13287&attachment=33661)
-----------------------------------------------------------------

::: misc/cronjobs/purge_suggestions.pl
@@ +47,5 @@
> +-help|? This message
> +-days TTT to define the age of suggestions to delete
> +
> +Example:
> +$PERL5LIB/misc/cronjobs/purge_suggestions.pl -days 30

This line change seems wrong to me.
It doesn't interpret $PERL5LIB, and this is a drastic change from what was
already there. And though what was there is a little unclear to the average
user, perhaps it is better?

@@ +68,4 @@
>      DelSuggestionsOlderThan($days);
>  }
> +elsif(defined($days) && $days == 0) {
> +    print << 'ERROR';

Seriously, why? There is no need to << 'LABEL ... LABEL this. It's a waste of
vertical space.

@@ +72,5 @@
> +    This script is not executed with 0 days. Aborted.
> +ERROR
> +}
> +else {
> +    print << 'ERROR';

Why not use:
    print STDERR "This script requires a positive number of days. Aborted.";

-- 
You are receiving this mail because:
You are watching all bug changes.