From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:07:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 22:07:11 +0000 Subject: [Koha-bugs] [Bug 14105] New: SMS Notices/Messages section could use the addition of an India specific Send driver Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14105 Bug ID: 14105 Summary: SMS Notices/Messages section could use the addition of an India specific Send driver Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org SMS Notices/Messages list a few SMS::Send drivers. Typically these are meant for SMS services in North American / Western Europe / elsewhere in the world. None of the listed examples work in India. I request for making an inclusion for a India specific regional context driver, given that this is regular question on Koha m/l from Indian users. I would like to submit a patch that inclusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 00:07:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 22:07:44 +0000 Subject: [Koha-bugs] [Bug 14105] SMS Notices/Messages section could use the addition of an India specific Send driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14105 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 01:02:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 23:02:44 +0000 Subject: [Koha-bugs] [Bug 14105] SMS Notices/Messages section could use the addition of an India specific Send driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14105 --- Comment #1 from Indranil Das Gupta --- Created attachment 38731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38731&action=edit Bug 14105 [ENH] Adds India specific SMS::Send driver information Adds India specific references to SMS Notices/Messages section for SMS::Send drivers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 05:50:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 03:50:43 +0000 Subject: [Koha-bugs] [Bug 14106] New: koha-conf paths to zebra libraries are wrong in jessie Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 Bug ID: 14106 Summary: koha-conf paths to zebra libraries are wrong in jessie Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz On jessie, doing a zebra reindex will cause errors like: 15:10:47-01/05 zebraidx(16108) [warn] No such record type: dom./etc/koha/zebradb/biblios/etc/dom-config.xml A workaround is documented here: http://wiki.koha-community.org/wiki/Troubleshooting_Zebra#No_such_record_type However we need to get it working out of the box, and to be backwards compatible. My plan is: * have koha-start-zebra check for the location of mod-dom.so, probably searching through a predefined list. * have it create a symlink inside /var/lib/koha that points to the right directory for the libraries. * update the zebra*.cfg templates so that they point to the new symlink location * as part of postinst, update the configuration for currently installed files so that they point to the symlink location. This'll mean that it'll work on all the layouts of the zebra libraries that we care to handle. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 05:51:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 03:51:02 +0000 Subject: [Koha-bugs] [Bug 14106] koha-conf paths to zebra libraries are wrong in jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 1 09:54:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 07:54:14 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 10:05:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 08:05:48 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #31 from Chris Cormack --- This doesn't apply on 3.18.x please rebase if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 10:08:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 08:08:36 +0000 Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:25:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 11:25:00 +0000 Subject: [Koha-bugs] [Bug 12503] Problem with label alignment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12503 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:25:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 11:25:26 +0000 Subject: [Koha-bugs] [Bug 12503] Problem with label alignment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12503 --- Comment #5 from Marc V?ron --- Is this still valid on current master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 13:25:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 11:25:58 +0000 Subject: [Koha-bugs] [Bug 9480] Set barcode width and height configurable with system preferences in patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9480 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:10:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 12:10:55 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37909|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 38732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38732&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:29:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 12:29:17 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:29:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 12:29:19 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38636|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 38733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38733&action=edit [PASSED QA] Bug 14057 - Inventory is painfully slow This patch is a rough start. I believe it runs exponentially faster, but its equality to the previous version needs to be tested before I clean it up to acceptable standards. Nested hashes of hashes was being a debugging nightmare. Moved the SQL select to C4::Koha. Changed the GetItemsForInventory to have a hashref parameter. Added interface, in case there is a need for 'opac' vs. 'staff'. Added t/db_dependent/Items/GetItemsForInventory.t Added t/db_dependent/Koha/GetKohaAuthorisedValuesMapping.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:38:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 12:38:39 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 12:38:41 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38498|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 38734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38734&action=edit [PASSED QA] Bug 14039 - Add patron salutation to checkout screen To test: Install this patch. Ensure a user has a salutation (Mr, Dr, Miss etc) set, and checkout an item to this user. In the area above the barcode box, the patron's title should display, e.g: Checking out to Mr John Doe (0001). Followed test plan. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:46:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 12:46:34 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:46:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 12:46:37 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38505|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 38735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38735&action=edit [PASSED QA] Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Check what values to have entered for WITHDRAWN authorized values (Home -> Koha Administration -> Authorized values change dropdown to WITHDRAWN) 2) Add a new authorized value of 0 () if one is missing. 3) Add a new authorized value of 1 (Withdrawn) if one is missing. 4) Run inventory on a filtered set such that the selected barcode is not withdrawn. (Home -> Tools -> Inventory/stocktaking) -- the Withdrawn column displays '0'. 5) Run inventory on a filtered set such that the selected barcode is withdrawn. -- the Withdrawn column displays '1'. 6) Apply patch 7) Rerun steps 4 & 5 -- the Withdrawn column displays the descriptions as seen in steps 1-3. 8) run koha qa test tools Followed test plan #1-#7. Aut. value for 0 set to: 'No' amd 1: "withdrawn'. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 12:59:44 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 14:59:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 12:59:48 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38720|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 38736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38736&action=edit [PASSED QA] Bug 14069: Drop existing primary key on items if exists On old databases, the issues table has a primary key on itemnumber. The DBrev 3.19.00.028 (Bug 13790 - Add unique id issue_id to issues and oldissues tables) has to remove it before adding the new primary key Test plan: 1/ Make sure you have an old DB, or add primary key (issues.itemnumber)manually on a DB created before 3.19.00.028. 2/ Execute the updatedatabase.pl script 3/ You should not get any error and the primary key on itemnumber should have been removed and the new one created as expected. Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors Tested using a 3.4 db (3.0404000) Interestingly, it gives a similar error on the same table but on another (older $DBversion = "3.05.00.009";) update 1) Pre-patch, 3.4 DB, updatedatabase from master, errors (older) DBD::mysql::db do failed: Multiple primary key defined at installer/data/mysql/updatedatabase.pl line 4435. (13790) DBD::mysql::db do failed: Multiple primary key defined at installer/data/mysql/updatedatabase.pl line 10166. DBD::mysql::db do failed: Unknown column 'issue_id' in 'order clause' at installer/data/mysql/updatedatabase.pl line 10170. DBD::mysql::st execute failed: Unknown column 'me.issue_id' in 'field list' at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1593. DBIx::Class::ResultSetColumn::max(): Unknown column 'me.issue_id' in 'field list' at installer/data/mysql/updatedatabase.pl line 10174 2) Post-patch, same conditions (only older) DBD::mysql::db do failed: Multiple primary key defined at installer/data/mysql/updatedatabase.pl line 4435. There are other warnings, but nor related with keys. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:02:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:02:39 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37913|0 |1 is obsolete| | --- Comment #14 from Blou --- Created attachment 38737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38737&action=edit Bug 11299 - add the lost button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:20:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:20:17 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:20:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:20:19 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38662|0 |1 is obsolete| | Attachment #38663|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 38738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38738&action=edit [PASSED QA] Bug 13758: Move the Koha version from kohaversion.pl It will permit not to run another perl interpreter. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:20:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:20:29 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 --- Comment #14 from Kyle M Hall --- Created attachment 38739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38739&action=edit [PASSED QA] Bug 13758: Add POD Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:31:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:31:12 +0000 Subject: [Koha-bugs] [Bug 10235] Koha's syspref search fails to find 'local' sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:31:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:31:14 +0000 Subject: [Koha-bugs] [Bug 10235] Koha's syspref search fails to find 'local' sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37822|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 38740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38740&action=edit Bug 10235: Add DataTables filters on local use prefs There is no way to search for local use prefs. This patch provides an easy way to search for pref present in of local use prefs table. Test plan: 1/ Go on the system preferences administration page 2/ Click on the Local Use table 3/ Confirm you are able to filter the table by pref name or description using the DataTables filters on top of it. Signed-off-by: Mark Tompsett NOTE: Local use tab is distinct from other tabs, so implementing 'Search system preferences' across all tabs would be very difficult. This patch adds a filter to the Local Use tab, which nicely allows for filtering, as per Owen's suggestion in comment #2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:32:11 +0000 Subject: [Koha-bugs] [Bug 10235] Koha's syspref search fails to find 'local' sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38740|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 38741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38741&action=edit Bug 10235: Add DataTables filters on local use prefs There is no way to search for local use prefs. This patch provides an easy way to search for pref present in of local use prefs table. Test plan: 1/ Go on the system preferences administration page 2/ Click on the Local Use table 3/ Confirm you are able to filter the table by pref name or description using the DataTables filters on top of it. Signed-off-by: Mark Tompsett NOTE: Local use tab is distinct from other tabs, so implementing 'Search system preferences' across all tabs would be very difficult. This patch adds a filter to the Local Use tab, which nicely allows for filtering, as per Owen's suggestion in comment #1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:34:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:34:54 +0000 Subject: [Koha-bugs] [Bug 14105] SMS Notices/Messages section could use the addition of an India specific Send driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14105 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:35:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:35:01 +0000 Subject: [Koha-bugs] [Bug 14105] SMS Notices/Messages section could use the addition of an India specific Send driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14105 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:35:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:35:13 +0000 Subject: [Koha-bugs] [Bug 14105] SMS Notices/Messages section could use the addition of an India specific Send driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14105 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:35:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:35:36 +0000 Subject: [Koha-bugs] [Bug 14105] SMS Notices/Messages section could use the addition of an India specific Send driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14105 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Nicole C. Engard --- This is pushed to the manual and will be visible in the HTML and PDF tomorrow. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:41:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:41:20 +0000 Subject: [Koha-bugs] [Bug 14105] SMS Notices/Messages section could use the addition of an India specific Send driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14105 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #3 from Nicole C. Engard --- Both 3.20 and 3.18 manuals were updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:46:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:46:14 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #11 from Kyle M Hall --- (In reply to Jonathan Druart from comment #10) > Kyle, > Don't you think it would be better to correctly fix the issue and store the > searches using the sessionStorage? > It will avoid YASP. Yes, but as David said, this will work in the mean-time, unless someone is willing to write and submit a counter patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:52:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:52:06 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- Here's my checking. Looks good. mtompset at debian:~/kohaclone$ grep -i intranetuserjs `git grep -l -i intranetuserjs | grep -v "\.po"` C4/Auth.pm: intranetuserjs => C4::Context->preference("intranetuserjs"), C4/Auth.pm: intranetuserjs => C4::Context->preference("intranetuserjs"), installer/data/mysql/sysprefs.sql:('intranetuserjs','','70|10','Custom javascript for inclusion in Intranet','Textarea'), installer/data/mysql/updatedatabase.pl: $dbh->do("UPDATE `systempreferences` SET options='70|10' WHERE variable='intranetuserjs'"); installer/data/mysql/updatedatabase.pl: my $intranetuserjs = C4::Context->preference('intranetuserjs'); installer/data/mysql/updatedatabase.pl: if ($intranetuserjs and $intranetuserjs eq $bad_value) { installer/data/mysql/updatedatabase.pl:WHERE variable = 'intranetuserjs' installer/data/mysql/updatedatabase.pl: print "Upgrade to $DBversion done (removed bogus intranetuserjs syspref)\n"; koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:[% IF ( intranetuserjs ) %] koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc: [% intranetuserjs %] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref: - pref: intranetuserjs koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:[% IF ( intranetuserjs ) %] koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt: [% intranetuserjs %] [SNIP] mtompset at debian:~/kohaclone$ grep -i opacuserjs `git grep -l -i opacuserjs | grep -v "\.po"` C4/Auth.pm: opacuserjs => C4::Context->preference("opacuserjs"), C4/Auth.pm: opacuserjs => C4::Context->preference("opacuserjs"), installer/data/mysql/sysprefs.sql:('opacuserjs','','70|10','Define custom javascript for inclusion in OPAC','Textarea'), installer/data/mysql/updatedatabase.pl: $dbh->do("UPDATE `systempreferences` SET options='70|10' WHERE variable='opacuserjs'"); koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: - pref: opacuserjs koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF ( opacuserjs ) %] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc: [% opacuserjs %] [SNIP] mtompset at debian:~/kohaclone$ git bz apply 12160 Bug 12160 - Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS 38563 - Bug 12160: Rename intranetuserjs with IntranetUserJS 38566 - Bug 12160: Rename opacuserjs with OPACUserJS Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12160: Rename intranetuserjs with IntranetUserJS Applying: Bug 12160: Rename opacuserjs with OPACUserJS mtompset at debian:~/kohaclone$ grep -i intranetuserjs `git grep -l -i intranetuserjs | grep -v "\.po"` C4/Auth.pm: IntranetUserJS => C4::Context->preference("IntranetUserJS"), C4/Auth.pm: IntranetUserJS => C4::Context->preference("IntranetUserJS"), installer/data/mysql/atomicupdate/Bug_12160-Rename_pref_intranetuserjs_to_IntranetUserJS.sql:UPDATE systempreferences SET variable="IntranetUserJS" where variable="intranetuserjs" installer/data/mysql/sysprefs.sql:('IntranetUserJS','','70|10','Custom javascript for inclusion in Intranet','Textarea'), installer/data/mysql/updatedatabase.pl: $dbh->do("UPDATE `systempreferences` SET options='70|10' WHERE variable='intranetuserjs'"); installer/data/mysql/updatedatabase.pl: my $intranetuserjs = C4::Context->preference('intranetuserjs'); installer/data/mysql/updatedatabase.pl: if ($intranetuserjs and $intranetuserjs eq $bad_value) { installer/data/mysql/updatedatabase.pl:WHERE variable = 'intranetuserjs' installer/data/mysql/updatedatabase.pl: print "Upgrade to $DBversion done (removed bogus intranetuserjs syspref)\n"; koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:[% IF ( IntranetUserJS ) %] koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc: [% IntranetUserJS %] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref: - pref: IntranetUserJS koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:[% IF ( IntranetUserJS ) %] koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt: [% IntranetUserJS %] [SNIP] mtompset at debian:~/kohaclone$ grep -i opacuserjs `git grep -l -i opacuserjs | grep -v "\.po"` C4/Auth.pm: OPACUserJS => C4::Context->preference("OPACUserJS"), C4/Auth.pm: OPACUserJS => C4::Context->preference("OPACUserJS"), installer/data/mysql/atomicupdate/Bug_12160-Rename_pref_opacuserjs_to_OPACUserJS.sql:UPDATE systempreferences SET variable="OPACUserJS" where variable="opacuserjs" installer/data/mysql/sysprefs.sql:('OPACUserJS','','70|10','Define custom javascript for inclusion in OPAC','Textarea'), installer/data/mysql/updatedatabase.pl: $dbh->do("UPDATE `systempreferences` SET options='70|10' WHERE variable='opacuserjs'"); koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: - pref: OPACUserJS koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF ( OPACUserJS ) %] koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc: [% OPACUserJS %] [SNIP] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:58:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:58:46 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38563|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 38742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38742&action=edit Bug 12160: Rename intranetuserjs with IntranetUserJS To match IntranetUserCSS, intranetuserjs should be renamed IntranetUserJS. Test plan: 1/ Be sure there is no occurrence of intranetuserjs 2/ Confirm the pref still works as before Signed-off-by: Mark Tompsett NOTE: Worked before and after updatedatabase.pl, though after is less confusing to the person unaware of case insensitivity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:58:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:58:54 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38566|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 38743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38743&action=edit Bug 12160: Rename opacuserjs with OPACUserJS Test plan: Same as previous patch for opacuserjs Signed-off-by: Mark Tompsett NOTE: Worked before and after updatedatabase.pl, though after is less confusing to the programmer unaware of case-insensitivity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:59:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:59:16 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #38711|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 1 15:59:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 13:59:38 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:00:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 14:00:34 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:00:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 14:00:38 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38708|0 |1 is obsolete| | Attachment #38709|0 |1 is obsolete| | Attachment #38710|0 |1 is obsolete| | Attachment #38715|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall --- Created attachment 38744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38744&action=edit [PASSED QA] Bug 5685: Validation of email address field This patch adds server-side & client-side validation for email form fields in the members/memberentry -view and in the opac/memberentry-view (bootstrap). I recently added simple validation for phone number and email address fields for our in-house koha and saw this old bug: I'm open to any ideas on how to do this better. Validation for phone numbers would be easy to add on top of this but I left it out since this bug is only about the email fields. To test: 1) Select a member and go to any of the edit forms with email fields (Primary info, "Library use", "Alternate address", "Alternative contact"). 2) Disable javascript in the browser in order to test server-side validation and try to input invalid emails in each of the email form fields. 3) Confirm that an invalid address is catched from any of the email fields, an alert shown for each invalid address and that the member's information was not updated with invalid data. 4) Enable javascript in the browser. 5) Confirm that the jquery validation plugin caches invalid addresses from any of the email fields and that you cannot send the form before correcting the problem. 6) Perform the same tests for the opac-memberentry-view. Note: as the jQuery validation plugin doesn't exist in the bootstrap folder, I just copied it over from the staff-client folder -how to deal with this? Signed-off-by: Owen Leonard I have undone the changes to opac.css so that they can be submitted as a separate patch. I have some other follow-ups to make as well. Signed-off-by: Nicole Engard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:00:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 14:00:48 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #29 from Kyle M Hall --- Created attachment 38745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38745&action=edit [PASSED QA] Bug 5685 [Compiled CSS] Validation of email address field This patch contains the recompiled opac.css file based on changes made to opac.less in the previous patch. Signed-off-by: Nicole Engard FIXED the compress. - mtompset Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:00:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 14:00:51 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #30 from Kyle M Hall --- Created attachment 38746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38746&action=edit [PASSED QA] Bug 5685 [OPAC follow-up] Validation of email address field This patch makes a few changes to the way errors are handled in the OPAC: - The validation plugin has been moved from the global include file to the template itself. Since we aren't doing form validation on any other page yet it doesn't make sense to include it globally at this time. - The error message which appears if you have JavaScript disabled and have submitted invalid emails was styled in a non-standard way. - I have added in-page links to the error message which appears if you have JavaScript disabled so that you can click to jump to the field which contains the error. - I have modified the error message language slightly to make it (I hope) read better. Signed-off-by: Nicole Engard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:00:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 14:00:55 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #31 from Kyle M Hall --- Created attachment 38747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38747&action=edit [PASSED QA] Bug 5685: Add missing about information In comment #20, Katrin requested the about page be updated to reflect the addition of a jquery plugin. TEST PLAN --------- 1) Apply all patches 2) Log in to Staff Client 3) Home -> About Koha -> Licenses -- jQuery Validation Plugin is now listed nicely. 4) Run koha qa test tools License appears as expected, qa OK Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 14:07:22 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:08:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 14:08:16 +0000 Subject: [Koha-bugs] [Bug 14107] New: Patron cards: Make barcode width and height scaling editable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Bug ID: 14107 Summary: Patron cards: Make barcode width and height scaling editable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:33:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 14:33:49 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 16:33:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 14:33:53 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36192|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 38748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38748&action=edit Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 17:15:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 15:15:07 +0000 Subject: [Koha-bugs] [Bug 14108] New: manual chapter 3.1.6 on patron card creator - revision Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14108 Bug ID: 14108 Summary: manual chapter 3.1.6 on patron card creator - revision Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: Heinrich.Hartl at email.de QA Contact: testopia at bugs.koha-community.org Created attachment 38749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38749&action=edit Revised manual chapter (3.) 1.6 Patron Card Creator The manual description for patron card creator as of 3.18 was incomplete and not consistent with the current program. Please find attached the revised chapter. Any comments for further improvement are welcome. Providing it in .odt format is in agreement with nengard. The tool oxygen is not available for me. Also she could not suggest any other tool that allows .xml editing + inspecting e.g. a .html transform thereof. The initial document content was copied from chapter (3.) 1.6 in http://manual.koha-community.org/3.18/en/index.html and pasted in a virgin .odt document. All the text changes are recorded. I ended with changing quite a lot, so looking at the document with viewing changes enabled is a little bit confusing but fortunately viewing changes can be disabled at least in my LibrOffice writer. To present the information in the order given by the left side menu I moved the chapter on layout to (3.) 1.6.1. Screen snapshots were taken with irfanview. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 17:53:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 15:53:02 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- Is it possible to add a reserve/hold with a particular expiration date, but then before that expiration date, change a system preference to indicate that it should already be expired? If so, this patch is insufficient. If not, then it should be fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 18:05:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 16:05:34 +0000 Subject: [Koha-bugs] [Bug 11941] "Patron lists" are not easily accessible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 --- Comment #3 from M. Tompsett --- Comment on attachment 38598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38598 Bug 11941: Add link to patron lists from the patron home page Review of attachment 38598: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11941&attachment=38598) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc @@ +6,5 @@ > [% FOREACH category IN categories %]
  • [% category.description %]
    • [% END %] > > > + [% IF CAN_user_tools_manage_patron_lists %] > + This isn't inside a form, as far as I can tell. Please change 'button' to 'a'. I couldn't get it to meaningfully click with 'button'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 18:06:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 16:06:28 +0000 Subject: [Koha-bugs] [Bug 11941] "Patron lists" are not easily accessible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 18:48:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 16:48:43 +0000 Subject: [Koha-bugs] [Bug 14109] New: ability to do multiple custom field searches on item search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14109 Bug ID: 14109 Summary: ability to do multiple custom field searches on item search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 38750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38750&action=edit custom field search on item search It would be nice if there was a way to add more than one field search on the item search (a plus sign like on advanced search?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 19:07:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 17:07:28 +0000 Subject: [Koha-bugs] [Bug 14109] ability to do multiple custom field searches on item search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14109 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 19:09:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 17:09:30 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 19:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 17:40:21 +0000 Subject: [Koha-bugs] [Bug 5704] bib level item type icon should display on search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5704 kholt at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholt at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:26:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:26:07 +0000 Subject: [Koha-bugs] [Bug 7232] clicking title on receive should open in new window/tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7232 kholt at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholt at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:26:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:26:46 +0000 Subject: [Koha-bugs] [Bug 14110] New: Silence warnings t/00-load.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 Bug ID: 14110 Summary: Silence warnings t/00-load.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com Noted: bug 8879 is an omnibus for the ./t errors. This cleanly catches all the errors in t/00-load.t, but it does not clean up the Koha tests which actually exclude testing Koha/NorwegianPatronDB.pm! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:27:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:27:01 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:27:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:27:13 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8879 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:27:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:27:13 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14110 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:28:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:28:14 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11402 |14110 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:28:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:28:14 +0000 Subject: [Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8879 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:28:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:28:14 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8879 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:28:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:28:30 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8879 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:28:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:28:30 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14110 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:36:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:36:43 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 20:36:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 18:36:46 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 --- Comment #1 from M. Tompsett --- Created attachment 38751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38751&action=edit Bug 14110: Silence t/00-load.t warnings prove t/00-load.t has noisy messages. This catches them. TEST PLAN --------- 1) $ prove -v t/00-load.t -- ugly INIT errors, etc. 2) apply patch 3) $ prove -v t/00-load.t -- nice "Expected warnings" type messages on the ones that were noisy. 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 21:14:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 19:14:03 +0000 Subject: [Koha-bugs] [Bug 14111] New: Silence warnings t/Auth_with_shibboleth.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Bug ID: 14111 Summary: Silence warnings t/Auth_with_shibboleth.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com Remove noise from prove t/Auth_with_shibboleth.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 21:14:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 19:14:41 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8879 Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 21:14:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 19:14:41 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14111 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 21:17:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 19:17:54 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 21:17:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 19:17:56 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 --- Comment #1 from M. Tompsett --- Created attachment 38752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38752&action=edit Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Poorly capturing warnings_exist test cases generated noise. This patch fixes that. TEST PLAN --------- 1) $ prove t/Auth_with_shibboleth.t -- There are messages about lines 132 and 133. Noise. 2) Apply patch 3) $ prove t/Auth_with_shibboleth.t -- No messages. YAY! 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 21:48:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 19:48:47 +0000 Subject: [Koha-bugs] [Bug 14112] New: Silence warnings t/Charset.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Bug ID: 14112 Summary: Silence warnings t/Charset.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com Self-explanitory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 21:49:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 19:49:06 +0000 Subject: [Koha-bugs] [Bug 14112] Silence warnings t/Charset.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |8879 Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 21:49:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 19:49:06 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14112 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 21:51:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 19:51:34 +0000 Subject: [Koha-bugs] [Bug 14112] Silence warnings t/Charset.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 21:51:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 19:51:37 +0000 Subject: [Koha-bugs] [Bug 14112] Silence warnings t/Charset.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 --- Comment #1 from M. Tompsett --- Created attachment 38753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38753&action=edit Bug 14112: Silence warnings in t/Charset.t Running prove on t/Charset.t had a complaint about a better way to write \c3. This suppresses it. TEST PLAN --------- 1) $ prove t/Charset.t -- get a warning 2) apply patch 3) $ prove t/Charset.t 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 22:33:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 20:33:16 +0000 Subject: [Koha-bugs] [Bug 14113] New: Silence warnings t/Date.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113 Bug ID: 14113 Summary: Silence warnings t/Date.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com And clean up the vertical spacing too on the output which is forced on the user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 22:33:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 20:33:34 +0000 Subject: [Koha-bugs] [Bug 14113] Silence warnings t/Date.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8879 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 22:33:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 20:33:34 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14113 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 22:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 20:33:52 +0000 Subject: [Koha-bugs] [Bug 14113] Silence warnings t/Date.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 22:37:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 20:37:46 +0000 Subject: [Koha-bugs] [Bug 14113] Silence warnings t/Date.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 22:37:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 20:37:48 +0000 Subject: [Koha-bugs] [Bug 14113] Silence warnings t/Date.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113 --- Comment #1 from M. Tompsett --- Created attachment 38754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38754&action=edit Bug 14113: Silence t/Dates.t warnings and cleanup output. The expectation of a user not freaking out over 'Illegal date' messages is not sensible. Catch the messages, give a nicer message. Also, compress the veritical spacing on the output. TEST PLAN --------- 1) $ prove t/Dates.t -- notice Illegal date messages, and extra lines between some sectional messages. 2) Apply patch 3) $ prove t/Dates.t -- Notice how nice and clean it is? Try it with -v to see all the warnings, including the expected warning type messages. 4) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 23:13:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 21:13:14 +0000 Subject: [Koha-bugs] [Bug 14114] New: Silence warnings t/Debug.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14114 Bug ID: 14114 Summary: Silence warnings t/Debug.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com Turns out there are annoying and pointless diags. Clean up. Fix layout. And perhaps even a Modern::Perl while I'm at it. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 23:13:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 21:13:32 +0000 Subject: [Koha-bugs] [Bug 14114] Silence warnings t/Debug.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14114 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Blocks| |8879 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 23:13:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 21:13:32 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14114 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 23:16:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 21:16:17 +0000 Subject: [Koha-bugs] [Bug 14114] Silence warnings t/Debug.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14114 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 23:16:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 21:16:20 +0000 Subject: [Koha-bugs] [Bug 14114] Silence warnings t/Debug.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14114 --- Comment #1 from M. Tompsett --- Created attachment 38755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38755&action=edit Bug 14114: Silence warns and cleanup t/Debug.t TEST PLAN --------- 1) $ prove t/Debug.t -- What's with this BEFORE and AFTER stuff?! 2) apply patch 3) $ prove t/Debug.t -- cleaner, and you only get fuller output with -v. 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 23:55:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 21:55:24 +0000 Subject: [Koha-bugs] [Bug 14115] New: Silence warnings t/Label* Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14115 Bug ID: 14115 Summary: Silence warnings t/Label* Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com Various uninitialized warnings spew out when proving. Clean up output while maintaining test integrity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 23:55:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 21:55:40 +0000 Subject: [Koha-bugs] [Bug 14115] Silence warnings t/Label* In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14115 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8879 Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 1 23:55:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 21:55:40 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14115 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 00:01:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 22:01:25 +0000 Subject: [Koha-bugs] [Bug 14115] Silence warnings t/Label* In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14115 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 00:01:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 May 2015 22:01:27 +0000 Subject: [Koha-bugs] [Bug 14115] Silence warnings t/Label* In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14115 --- Comment #1 from M. Tompsett --- Created attachment 38756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38756&action=edit Bug 14115: Silence warnings in t/Label* Two functions were triggering noisy warnings while testing: _get_text_fields and _split_lccn. TEST PLAN ---------- 1) $ prove t/Label* -- several warnings 2) apply patch 3) $ prove t/Label* -- no warnings 4) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:16:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:16:27 +0000 Subject: [Koha-bugs] [Bug 14116] New: Silence noise t/Scrubber.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Bug ID: 14116 Summary: Silence noise t/Scrubber.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com Some diag's are better suited as prints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:16:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:16:49 +0000 Subject: [Koha-bugs] [Bug 14116] Silence noise t/Scrubber.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Blocks| |8879 Severity|enhancement |minor Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:16:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:16:49 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14116 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:19:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:19:25 +0000 Subject: [Koha-bugs] [Bug 14116] Silence noise t/Scrubber.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:19:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:19:27 +0000 Subject: [Koha-bugs] [Bug 14116] Silence noise t/Scrubber.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 --- Comment #1 from M. Tompsett --- Created attachment 38757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38757&action=edit Bug 14116: Silence noisy output for t/Scrubber. Some diag's are better suited as prints. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:38:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:38:00 +0000 Subject: [Koha-bugs] [Bug 14117] New: Silence warnings t/Search_PazPar2.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Bug ID: 14117 Summary: Silence warnings t/Search_PazPar2.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com Relative URLs trigger warnings. Test for them, instead of letting them loose on the screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:38:41 +0000 Subject: [Koha-bugs] [Bug 14117] Silence warnings t/Search_PazPar2.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Blocks| |8879 Status|NEW |ASSIGNED Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:38:41 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14117 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:38:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:38:51 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bgkriegel at gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel --- We still add things on C4? Just a question 1) License need to be updated to GPL v3 2) koha-qa complains FAIL C4/ZebraIndex.pm OK pod OK forbidden patterns OK critic FAIL valid "my" variable $string masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:40:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:40:22 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Bernardo Gonzalez Kriegel --- On top of 13705. 1) No license 2) koha-qa complais FAIL misc/migration_tools/dedup_authorities.pl FAIL pod *** ERROR: Apparent command =cut not preceded by blank line in file misc/migration_tools/dedup_authorities.pl *** WARNING: =head2 without preceding higher level in file misc/migration_tools/dedup_authorities.pl OK forbidden patterns FAIL critic Variable declared in conditional statement at line 429, column 5. Declare variables outside of the condition. Variable declared in conditional statement at line 435, column 5. Declare variables outside of the condition. FAIL valid "my" variable $string masks earlier declaration in same scope given is experimental when is experimental -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:41:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:41:42 +0000 Subject: [Koha-bugs] [Bug 14117] Silence warnings t/Search_PazPar2.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 03:41:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 01:41:44 +0000 Subject: [Koha-bugs] [Bug 14117] Silence warnings t/Search_PazPar2.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 --- Comment #1 from M. Tompsett --- Created attachment 38758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38758&action=edit Bug 14117: Silence warnings t/SearchPazPar2.t The use of relative URLS (null actually), triggers warnings. Catch them, instead of letting them loose. TEST PLAN --------- 1) $ prove t/Search_PazPar2.t -- noise for each test currently. 2) apply patch 3) $ prove t/Search_PazPar2.t -- No noise, and extra tests added. -v shows caught warning tests. 4) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 04:11:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 02:11:24 +0000 Subject: [Koha-bugs] [Bug 14118] New: Silence warnings t/DataTables/Members.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Bug ID: 14118 Summary: Silence warnings t/DataTables/Members.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com A couple uninitialized variable warnings when a prove -r t is issued. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 04:12:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 02:12:22 +0000 Subject: [Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8879 Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Status|NEW |ASSIGNED --- Comment #1 from M. Tompsett --- I know that bug 8879 is just "prove ./t", but I think it is reasonable to extend that omnibus to include "prove -r ./t". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 04:12:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 02:12:22 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14118 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 04:36:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 02:36:57 +0000 Subject: [Koha-bugs] [Bug 14119] New: Missing de-DE DISCHARGE message Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Bug ID: 14119 Summary: Missing de-DE DISCHARGE message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 8007 DB changes forgot de-DE DISCHARGE message, prove xt/sample_notices.t fails -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 04:41:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 02:41:54 +0000 Subject: [Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 04:41:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 02:41:56 +0000 Subject: [Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 --- Comment #2 from M. Tompsett --- Created attachment 38759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38759&action=edit Bug 14118: Silence warnings t/DataTables/Members.t After cleaning 'prove t' up. 'prove -r t' was attempted next. A couple uninitialized variable warning were triggered. TEST PLAN ---------- 1) prove t/DataTables/Members.t -- warnings. 2) apply patch 3) prove t/DataTables/Members.t -- no warnings. 4) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 04:43:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 02:43:31 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 38760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38760&action=edit Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 2 04:47:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 02:47:42 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Patch complexity|--- |Trivial patch --- Comment #2 from Bernardo Gonzalez Kriegel --- If a German patch is provided, please reset assignee :) I will sign. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 2 04:50:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 02:50:38 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Failed QA --- Comment #5 from Bernardo Gonzalez Kriegel --- It works. Just a couple of things: 1) If you have no new or deleted records, an email is sent anyway with an empty Koha.mrc file 2) License needs to be updated FAIL misc/cronjobs/newly_deleted_records.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK pod OK valid FAIL misc/cronjobs/newly_added_records.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK pod OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 05:00:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 03:00:23 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- This works, but I rather a German counter patch. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 05:03:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 03:03:59 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 05:04:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 03:04:02 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38760|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 38761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38761&action=edit Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett As noted, a German counter patch is preferred. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 06:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 04:08:27 +0000 Subject: [Koha-bugs] [Bug 14120] New: Silence warnings t/db_dependent/Auth.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14120 Bug ID: 14120 Summary: Silence warnings t/db_dependent/Auth.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com prove t/db_dependent/Auth.t is noisy. Reduce the noise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 06:09:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 04:09:53 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14120 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 06:09:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 04:09:53 +0000 Subject: [Koha-bugs] [Bug 14120] Silence warnings t/db_dependent/Auth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14120 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Severity|enhancement |minor Blocks| |8879 Depends on| |5010 Status|NEW |ASSIGNED --- Comment #1 from M. Tompsett --- In order to fully remove all the warnings, bug 5010 needs to be applied. Fixing the updatedatabase.pl for the application is easy enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 06:09:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 04:09:53 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14120 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 06:14:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 04:14:03 +0000 Subject: [Koha-bugs] [Bug 14120] Silence warnings t/db_dependent/Auth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14120 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 06:14:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 04:14:05 +0000 Subject: [Koha-bugs] [Bug 14120] Silence warnings t/db_dependent/Auth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14120 --- Comment #2 from M. Tompsett --- Created attachment 38762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38762&action=edit Bug 14120: Fixing t/db_dependent/Auth.t noise TEST PLAN --------- 1) $ prove t/db_dependent/Auth.t -- warnings 2) Apply this patch 3) $ prove t/db_dependent/Auth.t -- only one specific type of warning 4) Apply bug 5010 patch 5) $ prove t/db_dependent/Auth.t -- noisy is eliminated 6) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 06:30:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 04:30:52 +0000 Subject: [Koha-bugs] [Bug 14121] New: Silence warnings t/db_dependent/Auth_with_cas.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Bug ID: 14121 Summary: Silence warnings t/db_dependent/Auth_with_cas.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com C4::Auth_with_case has a $query->param($_) in a context which is not clearly scalar to the interpreter, so it throws a security warning. Introduce a variable, use the variable instead of calling param() twice. Noise disappears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 06:31:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 04:31:08 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Blocks| |8879 Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 06:31:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 04:31:08 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14121 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 06:33:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 04:33:22 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 06:33:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 04:33:25 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #1 from M. Tompsett --- Created attachment 38763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38763&action=edit Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t TEST PLAN --------- 1) $ prove t/db_dependent/Auth_with_cas.t -- CGI security warning 2) apply patch 3) $ prove t/db_dependent/Auth_with_cas.t -- no noise. 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 07:42:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 05:42:42 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 07:50:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 05:50:50 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 --- Comment #1 from Marc V?ron --- Created attachment 38764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38764&action=edit Bug 14107 - Patron cards: Make barcode width and height scaling editable The size of the barcode in patron card creator was hardcoded to 1% of the card height and 80% of the card width. This patch exposes both values in the layout editor. If no values are given, the previousely hard coded values (0.01 / 0.8) are used in order to work with existing card definitions. To test: - Go to Home > Tools > Patron card creator - Export a patron card (PDF) from en existing definition - Apply patch - Export patron card again, compare results (should be the same) - Go to Home > Tools > Patron card creator > Manage card layouts - Edit the layout you use for testing and set barcode scaling values e.g. to 0.03 for height and 0.4 for widht - Export patron card again, verify that barcode size changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 07:56:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 05:56:11 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |veron at veron.ch |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 08:14:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 06:14:49 +0000 Subject: [Koha-bugs] [Bug 9480] Set barcode width and height configurable with system preferences in patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9480 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14107 --- Comment #8 from Marc V?ron --- Bug 14107 exposes the scaling values in the layout editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 08:14:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 06:14:49 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9480 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 08:18:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 06:18:36 +0000 Subject: [Koha-bugs] [Bug 14108] manual chapter 3.1.6 on patron card creator - revision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14108 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14107 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 08:18:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 06:18:36 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14108 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 08:19:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 06:19:27 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 09:31:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 07:31:36 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 --- Comment #5 from Marc V?ron --- Created attachment 38765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38765&action=edit Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 10:26:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 08:26:35 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 13:04:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 11:04:14 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u --- Comment #2 from Chris Nighswonger --- This needs to be tested with barcodes of less than 4 digits. The original problem with exposing scaling was that barcode shorter than ability about 5 digits behaved badly. At the time some libraries were starting numbering at 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 15:07:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 13:07:09 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38765|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 38766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38766&action=edit [SIGNED_OFF] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel Right wording :) Fixed version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 15:07:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 13:07:32 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 15:09:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 13:09:25 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bgkriegel at gmail.com |veron at veron.ch Status|Needs Signoff |Signed Off --- Comment #7 from Bernardo Gonzalez Kriegel --- First patch obsoleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 16:51:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 14:51:56 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 --- Comment #3 from Marc V?ron --- Created attachment 38767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38767&action=edit Use case "Butterfly" Card Usecase "Butterfly" card. This type of card has a self adhesive part on a sheet of paper (e.g. an invoice) that can be detached and folded. See follwong attachments (Cards created without and with patch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 16:55:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 14:55:51 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 --- Comment #4 from Marc V?ron --- Created attachment 38768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38768&action=edit Output PDF without patch Butterfly card without patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 16:58:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 14:58:29 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 --- Comment #5 from Marc V?ron --- Created attachment 38769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38769&action=edit OutputPDF with patch After applying the patch and adjusting the value for barcode width scaling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 17:06:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 15:06:41 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 17:45:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 15:45:15 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38761|1 |0 is obsolete| | --- Comment #8 from M. Tompsett --- Comment on attachment 38761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38761 Bug 14119: Missing de-DE DISCHARGE message It looks like the second patch requires the first. Unchecking 'obsolete' for a clean apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 17:54:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 15:54:43 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38761|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 38770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38770&action=edit Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett As noted, a German counter patch is preferred. :) Signed-off-by: Mark Tompsett Required for a clean install of German patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 17:55:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 15:55:14 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38766|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 38771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38771&action=edit Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel Right wording :) Fixed version Signed-off-by: Mark Tompsett German version. YAY! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 19:43:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 17:43:01 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- C4/Patroncards/Patroncard.pm is modified. Is there a way to add tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 19:49:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 17:49:47 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 --- Comment #7 from Chris Nighswonger --- Looks good to me. If it's not done before Monday, I'll be glad to sign-off on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 20:33:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 18:33:18 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 --- Comment #8 from Marc V?ron --- (In reply to M. Tompsett from comment #6) > C4/Patroncards/Patroncard.pm is modified. Is there a way to add tests? Changing the values has a visual impact on the PDF, I do not know how this could be tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 21:44:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 19:44:34 +0000 Subject: [Koha-bugs] [Bug 14122] New: Patron card: Software error when creating using borrower_number as parameter from URL Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 Bug ID: 14122 Summary: Patron card: Software error when creating using borrower_number as parameter from URL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Use case: Add link to directly print a patron card from the patron's detail page. This could be done using a URL like the following: ...cgi-bin/koha/patroncards/create-pdf.pl?borrower_number=61&template_id=24&layout_id=21&start_card=1 To test, replace the values for borrower_number, temlate_id and layout_id to something that exists in your system. The URL leads to a software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/patroncards/create-pdf.pl line 118. Reason: Line 92: push(@{$items}, {item_number => $_}); should read: push(@{$items}, {borrower_number => $_}); Patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 21:45:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 19:45:48 +0000 Subject: [Koha-bugs] [Bug 7915] Print a barcoded membership card from member detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7915 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14122 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 21:45:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 19:45:48 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |veron at veron.ch |y.org | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7915 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 21:53:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 19:53:19 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 --- Comment #1 from Marc V?ron --- Created attachment 38772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38772&action=edit Bug 14122 - Patron card: Software error when creating using borrower_number as parameter from URL To test prepare an URL like the following: ...cgi-bin/koha/patroncards/create-pdf.pl?borrower_number=61&template_id=24&layout_id=21&start_card=1 Change the values for borrower_number, template_id and layout_id to something that exists in your system. Without patch, the URL leads to a software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/patroncards/create-pdf.pl line 118. With patch, a PDF with the patron card is created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 2 21:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 19:54:15 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 00:13:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 22:13:49 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 --- Comment #2 from M. Tompsett --- Comment on attachment 38481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38481 Bug 14059 : Testing C4::Creators::Lib Review of attachment 38481: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14059&attachment=38481) ----------------------------------------------------------------- ::: C4/Creators/Lib.pm @@ -448,5 @@ > -Return an arrayref of an array containing the column names of the supplied table. > - > -=cut > - > -sub get_column_names { git grep get_column_names shows that C4::Creators exports this function, and this lib still exports it too. Yes, it isn't used, but you forgot to cut the other parts out too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 00:14:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 May 2015 22:14:25 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- Failed QA'ing this for reason in comment #2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 08:44:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 06:44:01 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 --- Comment #4 from M. Tompsett --- I also had a hard time getting 13899 to run well. It runs great the first time (long time to run). But second run after apply doesn't seem to work. I did a rm -rf cover_db and a reboot to get it to work again after the patch. This does improve the coverage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 09:05:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 07:05:02 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- (In reply to Marc V?ron from comment #1) > Change the values for borrower_number, template_id and layout_id to > something that exists in your system. Are you going to submit a bug report for the case that they don't?

    Software error:

    Can't bless non-reference value at
/home/mtompset/kohaclone/C4/Creators/Layout.pm line 111.

    For help, please send mail to the webmaster (webmaster at debian), giving this error message and the time and date of the error.

    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 10:24:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 08:24:50 +0000 Subject: [Koha-bugs] [Bug 14123] New: Patroncard: Patron search for batch no longer has Select / Select All / Add selected Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123 Bug ID: 14123 Summary: Patroncard: Patron search for batch no longer has Select / Select All / Add selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Created attachment 38773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38773&action=edit Compare patron search for patron card batch 3.18 - current master The new patron search for patron card batches has no longer the possibility to select /select all and add selected to batch. To add, each single patron has to be added clicking the 'Add' button in the table row. Use case: Search for patrons for a category, select all, add all to the batch. See screenshot with old / new version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 10:45:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 08:45:27 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 --- Comment #3 from Marc V?ron --- > Are you going to submit a bug report for the case that they don't? Maybe I do not understand your question, but: No, for the case that they do... In my example I want to print a patron card for borrower 61 with template 24 and layout 21. This fails without patch and works fine with patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 11:18:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 09:18:47 +0000 Subject: [Koha-bugs] [Bug 14124] New: Add 'Unimarc only' note to IdRef system preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14124 Bug ID: 14124 Summary: Add 'Unimarc only' note to IdRef system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The description for the new IdRef system preference should contain a little note that this feature is UNIMARC only. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 11:18:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 09:18:56 +0000 Subject: [Koha-bugs] [Bug 14124] Add 'Unimarc only' note to IdRef system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8992 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 11:18:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 09:18:56 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14124 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 11:36:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 09:36:22 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7187 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 11:36:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 09:36:22 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9580 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 12:19:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 10:19:51 +0000 Subject: [Koha-bugs] [Bug 14125] New: Version variable not properly replaced in csv profiles help page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125 Bug ID: 14125 Summary: Version variable not properly replaced in csv profiles help page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To see the problem: - Go to Tools > CSV-Profiles - Open help page - Check link to the manual:

    See the full documentation for CSV Profiles in the manual (online).

    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 12:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 10:54:15 +0000 Subject: [Koha-bugs] [Bug 14126] New: Typo on order receive page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14126 Bug ID: 14126 Summary: Typo on order receive page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Found while doing translation: intranet-tmpl/prog/en/modules/acqui/neworderempty.tt:268 "To notify on reveiving:" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 14:24:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 12:24:37 +0000 Subject: [Koha-bugs] [Bug 14127] New: Typo in message preference form - "mesage" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127 Bug ID: 14127 Summary: Typo in message preference form - "mesage" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Found while translating: /intranet-tmpl/prog/en/includes/messaging-preference-form.inc:28 "You can ask for a digest to reduce the number of messages. Messages will be saved and sent as a single mesage." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 17:44:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 15:44:58 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 17:45:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 15:45:02 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38742|0 |1 is obsolete| | Attachment #38743|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 38774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38774&action=edit [PASSED QA] Bug 12160: Rename intranetuserjs with IntranetUserJS To match IntranetUserCSS, intranetuserjs should be renamed IntranetUserJS. Test plan: 1/ Be sure there is no occurrence of intranetuserjs 2/ Confirm the pref still works as before Signed-off-by: Mark Tompsett NOTE: Worked before and after updatedatabase.pl, though after is less confusing to the person unaware of case insensitivity. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 17:45:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 15:45:43 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 --- Comment #9 from Katrin Fischer --- Created attachment 38775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38775&action=edit [PASSED QA] Bug 12160: Rename opacuserjs with OPACUserJS Test plan: Same as previous patch for opacuserjs Signed-off-by: Mark Tompsett NOTE: Worked before and after updatedatabase.pl, though after is less confusing to the programmer unaware of case-insensitivity. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:24:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:24:12 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 --- Comment #9 from Katrin Fischer --- Created attachment 38776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38776&action=edit [PASSED QA] Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly Signed-off-by: Nick Signed-off-by: Katrin Fischer http://bugs.koha-community.org/show_bug.cgi?id=13561 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:25:14 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:25:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:25:17 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35097|0 |1 is obsolete| | Attachment #35098|0 |1 is obsolete| | Attachment #38776|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 38777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38777&action=edit [PASSED QA] Bug 13516 - Tidy relevant code block Signed-off-by: Nick Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:25:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:25:36 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 --- Comment #11 from Katrin Fischer --- Created attachment 38778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38778&action=edit [PASSED QA] Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly Signed-off-by: Nick Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:30:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:30:58 +0000 Subject: [Koha-bugs] [Bug 10235] Koha's syspref search fails to find 'local' sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:31:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:31:01 +0000 Subject: [Koha-bugs] [Bug 10235] Koha's syspref search fails to find 'local' sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38741|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 38779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38779&action=edit [PASSED QA] Bug 10235: Add DataTables filters on local use prefs There is no way to search for local use prefs. This patch provides an easy way to search for pref present in of local use prefs table. Test plan: 1/ Go on the system preferences administration page 2/ Click on the Local Use table 3/ Confirm you are able to filter the table by pref name or description using the DataTables filters on top of it. Signed-off-by: Mark Tompsett NOTE: Local use tab is distinct from other tabs, so implementing 'Search system preferences' across all tabs would be very difficult. This patch adds a filter to the Local Use tab, which nicely allows for filtering, as per Owen's suggestion in comment #1. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:37:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:37:22 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:37:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:37:26 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38725|0 |1 is obsolete| | Attachment #38726|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 38780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38780&action=edit [PASSED QA] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:37:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:37:55 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #17 from Katrin Fischer --- Created attachment 38781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38781&action=edit [PASSED QA] Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:38:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:38:50 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #18 from Katrin Fischer --- I am a little worried that this feature is hidden by the fact the print preview doesn't match the actual print out - but this is a good enhancement, no reason to hold it back :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:54:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:54:45 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:54:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:54:48 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38502|0 |1 is obsolete| | Attachment #38640|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 38782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38782&action=edit [PASSED QA] Bug 11890: Click events on titles does not work as expected The browse results feature (bug 10404) modified the click events on titles on the search result page (intranet). It introduced bad behaviors: 1/ ctrl+click on a title does not open a new tab 2/ middle click on a title does open a new tab but the browser is not displayed. Note that this patch is not perfect, it fixes the 2 bad behaviors but the ctrl+click gives the focus to the new tab (could go against the preferences of the users). Test plan: 1/ On the staff interface, launch a search (catalogue/search.pl?q=XXX) 2/ When middle-clicking on a title, a new tab should open. On this tab the browse result feature should be displayed 3/ Same for cltr+click Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:55:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:55:04 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #14 from Katrin Fischer --- Created attachment 38783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38783&action=edit [PASSED QA] Bug 11890: Prevent default on click event It seems that the previous patch does not stop the propagation of the event if the link is clicked with the left button (which=1). Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 18:55:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 16:55:36 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #15 from Katrin Fischer --- Improves behaviour, but there are still some problems: - left click open in new tab is missing the browser -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 19:02:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 17:02:19 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 19:02:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 17:02:22 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38770|0 |1 is obsolete| | Attachment #38771|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 38784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38784&action=edit [PASSED QA] Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett As noted, a German counter patch is preferred. :) Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 19:02:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 17:02:39 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 --- Comment #12 from Katrin Fischer --- Created attachment 38785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38785&action=edit [PASSED QA] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel Right wording :) Fixed version Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 19:13:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 17:13:37 +0000 Subject: [Koha-bugs] [Bug 14128] New: Capitalization: Guided Reports - step 2 - Build A Report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 Bug ID: 14128 Summary: Capitalization: Guided Reports - step 2 - Build A Report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When building a report using the guided reports tool, on step 2 there is a capitalization problem: Build A Report Some more issues might appear on taking a closer look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 19:19:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 17:19:39 +0000 Subject: [Koha-bugs] [Bug 14129] New: templates.readme is outdated Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129 Bug ID: 14129 Summary: templates.readme is outdated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Developer documentation Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The file koha-tmpl/templates.readme is very outdated and contains a lot of wrong information: - references CVS - HTML::Template - wrong paths - wrong language codes... It needs to be removed or compeletely rewritten -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 19:24:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 17:24:58 +0000 Subject: [Koha-bugs] [Bug 14130] New: column.def should be updated with descriptions for new columns Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130 Bug ID: 14130 Summary: column.def should be updated with descriptions for new columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The file koha-tmpl/intranet-tmpl/prog/en/columns.def needs to be updated to include descriptions for the newly added database columns. To test: - Go to reports > Build new - Go to step 3 The list of tables will be different depending on the module you select. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 19:29:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 17:29:11 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 19:29:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 17:29:14 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38657|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 38786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38786&action=edit [PASSED QA] Bug 10976: Fix typo itemtype vs itemtypes When creating a new report, the limit step let you choose itype|itemtype. But it should be itype|itemtypes. If you try to create a guided report and you choose this option as a limit, you will get a warning on saving it: Errors found when processing parameters for report: itype: The authorized value category (itemtype) you selected does not exist. Looking at the code: reports/guided_reports.pl l.657 elsif ( $authorised_value eq "itemtypes" ) { Test plan: 0/ Don't apply the patch 1/ Create a guided report, select Koha itemtype as a limit(step 4) 2/ Confirm you get the error when saving 3/ Apply the patch and repeat step 1 4/ There is no error and the report should work correctly Tested with steps in comment #4/#5, error is gone after applying patch. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 20:52:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 18:52:34 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |saga-sumerki at list.ru When did the bot| |2015-05-17 last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 20:52:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 18:52:59 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2015-05-17 00:00:00 |2015-05-17 13:00 last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 20:53:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 18:53:29 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2015-05-17 13:00:00 |2015-05-04 13:00 last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 20:54:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 18:54:25 +0000 Subject: [Koha-bugs] [Bug 8464] Age limitations not handled during patron creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |saga-sumerki at list.ru When did the bot| |2015-05-04 last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 20:56:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 18:56:03 +0000 Subject: [Koha-bugs] [Bug 5294] Vendor name shows with '%20' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5294 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2015-05-05 last check this| | CC| |saga-sumerki at list.ru -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 20:56:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 18:56:28 +0000 Subject: [Koha-bugs] [Bug 8464] Age limitations not handled during patron creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2015-05-04 00:00:00 | last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 20:56:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 18:56:50 +0000 Subject: [Koha-bugs] [Bug 5294] Vendor name shows with '%20' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5294 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2015-05-05 00:00:00 | last check this| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 20:57:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 18:57:12 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2015-05-04 13:00:00 | last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 20:59:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 18:59:46 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2015-05-22 last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:01:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:01:03 +0000 Subject: [Koha-bugs] [Bug 4857] aqplan.pl: consideration of Planning categories with authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4857 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |saga-sumerki at list.ru When did the bot| |2015-05-22 last check this| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:01:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:01:42 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2015-05-22 00:00:00 | last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:02:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:02:26 +0000 Subject: [Koha-bugs] [Bug 4857] aqplan.pl: consideration of Planning categories with authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4857 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2015-05-22 00:00:00 | last check this| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:04:48 +0000 Subject: [Koha-bugs] [Bug 5294] Vendor name shows with '%20' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5294 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2015-05-31 last check this| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:06:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:06:58 +0000 Subject: [Koha-bugs] [Bug 5294] Vendor name shows with '%20' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5294 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2015-05-31 00:00:00 | last check this| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:12:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:12:00 +0000 Subject: [Koha-bugs] [Bug 4857] aqplan.pl: consideration of Planning categories with authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4857 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Fic TUM -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:12:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:12:28 +0000 Subject: [Koha-bugs] [Bug 8464] Age limitations not handled during patron creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Fic SHIR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:12:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:12:54 +0000 Subject: [Koha-bugs] [Bug 4856] problem with NSB/NSE chars In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4856 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Fic Axa CC| |saga-sumerki at list.ru -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:13:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:13:06 +0000 Subject: [Koha-bugs] [Bug 4856] problem with NSB/NSE chars In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4856 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|Fic Axa |Fic AXA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:13:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:13:34 +0000 Subject: [Koha-bugs] [Bug 5294] Vendor name shows with '%20' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5294 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Fic SEV -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:14:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:14:38 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Fic ANA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:15:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:15:02 +0000 Subject: [Koha-bugs] [Bug 4864] modules required by SIP not in module list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4864 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Fic TER CC| |saga-sumerki at list.ru -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:16:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:16:57 +0000 Subject: [Koha-bugs] [Bug 4857] aqplan.pl: consideration of Planning categories with authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4857 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2015-05-22 19:12 last check this| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:18:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:18:03 +0000 Subject: [Koha-bugs] [Bug 8464] Age limitations not handled during patron creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2015-05-22 last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:18:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:18:19 +0000 Subject: [Koha-bugs] [Bug 8464] Age limitations not handled during patron creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2015-05-22 00:00:00 |2015-05-22 19:12 last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:18:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:18:28 +0000 Subject: [Koha-bugs] [Bug 8464] Age limitations not handled during patron creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 Hamletik changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2015-05-22 19:12:00 | last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:57:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:57:58 +0000 Subject: [Koha-bugs] [Bug 4857] aqplan.pl: consideration of Planning categories with authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|Fic TUM | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:58:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:58:07 +0000 Subject: [Koha-bugs] [Bug 8464] Age limitations not handled during patron creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Whiteboard|Fic SHIR | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:58:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:58:45 +0000 Subject: [Koha-bugs] [Bug 4864] modules required by SIP not in module list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|Fic TER | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:58:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:58:52 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Whiteboard|Fic ANA | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:58:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:58:59 +0000 Subject: [Koha-bugs] [Bug 5294] Vendor name shows with '%20' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Whiteboard|Fic SEV | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 21:59:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 19:59:06 +0000 Subject: [Koha-bugs] [Bug 4856] problem with NSB/NSE chars In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4856 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Whiteboard|Fic AXA | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:06:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:06:39 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:06:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:06:43 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38592|0 |1 is obsolete| | Attachment #38593|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 38787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38787&action=edit [PASSED QA] Bug 14066: Remove the Readonly[::XS] dependency The Readonly and Readonly::XS package are only used in Koha::Calendar. IMO the added value of there packages does not justify their purpose. Test plan: 1/ Remove Readonly and Readonly::XS 2/ Open the calendar and confirm you don't get any error concerning missing dependency Signed-off-by: Mark Tompsett Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:06:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:06:56 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 --- Comment #17 from Katrin Fischer --- Created attachment 38788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38788&action=edit [PASSED QA] Bug 14066: Correct and optimize As far as I can tell $sunday is never used. And it seemed to be scoped to only _init. The remaining hashiness was cleaned up for the $return_by_hour. TEST PLAN --------- 1) Apply both patches 2) (Skip this one - file does not exist / MV) prove -v t/db_dependent/Calendar.t 3) prove -v t/db_dependent/Holidays.t 4) prove -v t/Calendar.t 5) perlcritic -3 Koha/Calendar.pm -- the message corresponds to a comment in the code already and not this change. 6) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:08:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:08:30 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Katrin Fischer --- Do we need a patch to remove from debian/control as well? I will attach a follow-up removing some more occurrences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:08:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:08:55 +0000 Subject: [Koha-bugs] [Bug 5294] Vendor name shows with '%20' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5294 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC|saga-sumerki at list.ru | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:08:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:08:55 +0000 Subject: [Koha-bugs] [Bug 4856] problem with NSB/NSE chars In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4856 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC|saga-sumerki at list.ru | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:08:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:08:55 +0000 Subject: [Koha-bugs] [Bug 8464] Age limitations not handled during patron creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8464 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC|saga-sumerki at list.ru | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:08:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:08:55 +0000 Subject: [Koha-bugs] [Bug 4864] modules required by SIP not in module list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4864 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC|saga-sumerki at list.ru | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:08:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:08:55 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC|saga-sumerki at list.ru | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:08:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:08:55 +0000 Subject: [Koha-bugs] [Bug 4857] aqplan.pl: consideration of Planning categories with authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4857 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC|saga-sumerki at list.ru | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:16:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:16:25 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 --- Comment #19 from Katrin Fischer --- Created attachment 38789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38789&action=edit Bug 14066: Removing more Readonly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:27:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:27:09 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 --- Comment #15 from Katrin Fischer --- It literally showed up as " in the result list - but retesting it now it is ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:29:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:29:14 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:29:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:29:17 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38671|0 |1 is obsolete| | Attachment #38718|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 38790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38790&action=edit [PASSED QA] Bug 14044: Escape json strings for patron searches In a couple of patron searches, the address is displayed. If the address contain invalid json characters, DataTables won't manage to parse the results and display them. This patch makes the templates more readable by creating a BLOCK instead of a long line and escape the invalid json characters calling the TT plugin (To.json). Test plan: Edit a patron and add something like: patron
    \123 ? ? in the address field. Search for this patron using the main patron search (members/member.pl) and the guarantor search. Confirm that a result with this patron is correctly displayed. Regression test: Since Koha::Template::Plugin::To::json is modified, confirm that the add users to basket search (on acqui/basket.pl?basketno=X click on the "Add user" button) still works as expected. Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 22:40:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 20:40:17 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 --- Comment #17 from Katrin Fischer --- Created attachment 38791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38791&action=edit [PASSED QA] Bug 14044: Don't escape html characters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 23:23:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 21:23:52 +0000 Subject: [Koha-bugs] [Bug 14131] New: Patroncard: Add possibility to print from patron lists Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Bug ID: 14131 Summary: Patroncard: Add possibility to print from patron lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org The patron card creator allows to print batches from it's own batch functionality. It would be very useful if it could export patron cards from patron lists as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 23:40:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 21:40:06 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #1 from Marc V?ron --- Created attachment 38792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38792&action=edit Bug 14131 - Patroncard: Add possibility to print from patron lists This patch adds the possibility to print patron cards from patron lists. To test: - Go to Home > Tools > Patron card creator - Prepare a patron card and create some cards using the batch functionality - Apply patch - Prepare a patron list e.g. from patron search - Go to Home > Tools > Patron card creator > Manage batches - Below the list of batches you have a dropdown to select a patron list - Select your list and hit "Export from patron list" - Select template and layout as you would do with batches - Hit "Export" - Download PDF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 23:42:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 21:42:26 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|cnighswonger at foundations.ed |veron at veron.ch |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 23:49:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 21:49:58 +0000 Subject: [Koha-bugs] [Bug 12471] Create patron card batch from from patron list or patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12471 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14131 --- Comment #1 from Marc V?ron --- See Bug 14131 for printing from patron lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 3 23:49:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 21:49:58 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12471 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 00:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 22:01:33 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 00:01:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 May 2015 22:01:36 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38664|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 38793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38793&action=edit [PASSED QA] Bug 13810: Change collate for tagsubfield (utf8_bin) Before bug 11944, the marc_subfield_structure.tagsubfield column had a specific collate: utf8_bin. It has been introduced by commit 67e20d82ffdfcd69344ec30696bebc51c00d863c Date: Sun Jun 22 16:35:48 2008 -0500 DB Bump 094 - bug 2268 -- allow mixed case subfield labels in MARC21 by changing db column collation. This change should be kept and Koha should continue to allow and create subfields with the same letter but different case sensitivity. What does this patch: 1/ To prevent the updatedatabase entry 3.19.00.006 to fail if subfields with different case sensitivity already exist in the DB, the table is managed separately from others. 2/ To update DB which have already pass this dbrev, a new entry will be create to update the specific collate for this column. Test plan: 1/ a. With a 3.18 DB, create subfield 'a' and 'A' for the same field b. Execute the updatedatabase.pl script. 3.19.00.006 should not fail anymore 2/ a. With a master DB (3.19.00.006 has already been executed), create subfields 'a' and 'A'. You should get an error. b. Apply this patch, execute the DB entry and try again 2/a. you should be able to create the second subfield. Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 04:03:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 02:03:44 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #12 from David Cook --- (In reply to Andreas Hedstr?m Mace from comment #11) > Also very interested in this. Any progress lately? Sadly no :( I'm tempted to post my work in progress... but I still have a few things that I need to work out. Here are my current notes to myself: 1) Add a UI in the staff client so that users can configure the repositories from which to harvest (NOTE: this is the change that will create the most merge conflicts, since it touches existing templates) 2) Add the ability to completely re-harvest from a repository (I suppose the thing to do is delete all the records that were derived from that repository, then re-harvest) 3) Improve the whole feature so that the Perl scripts and templates handle the presentation, while most of the logic is driven by the modules. 4) Double-check database structure? 5) Add POD to Harvester.pm and Importer.pm 6) Add unit tests for Harvester.pm and Importer.pm 7) Add necessary changes to updatedatabase.pl 8) Add function to OAI::Importer that will add the item type if it doesn't already exist? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 04:46:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 02:46:19 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #13 from David Cook --- Actually, I am going to post my code after all. Here's a link to a Github repository that has my current code: https://github.com/minusdavid/Koha/tree/pro_master_oai -- At the moment, I have a test instance of Koha that uses the OAI harvester to pull in all new/changed records from about 6-7 different Koha OAI servers. It seems to work reasonably well. I suppose priorities that I would highlight are: 1) The ability to completely re-harvest from a server. This would involve deleting all the harvested records in Koha, and re-harvesting from the OAI server. 2) Creating a web UI to add/modify/remove repositories for OAI harvesting -- Other than that... it's tidying up the code, adding documentation, and adding unit tests so that this can actually get into Koha. I just don't have time for any of this at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 05:22:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 03:22:29 +0000 Subject: [Koha-bugs] [Bug 14126] Typo on order receive page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14126 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Assignee|oleonard at myacpl.org |hector.hecaxmmx at gmail.com Status|NEW |Needs Signoff --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 38794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38794&action=edit Bug 14126 - Typo on order receive page A typo found while doing translation: To test 1) Go to dir 'intranet-tmpl/prog/en/modules/acqui/neworderempty.tt' line 268 and check the typo "To notify on reveiving:" 2) Apply the patch 3) Repeat step 1 and check if the typo is fixed Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 05:35:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 03:35:24 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 06:11:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 04:11:00 +0000 Subject: [Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- $ grep "^sub " C4/Context.pm | cut -f2 -d' ' > ~/subs $ vi ~/subs :%s/^/C4::Context->/g :wq $ git grep 'C4::Context\->' | grep -v -f ~/subs Yes, intranetdir, but also: 1 perldoc line IsSuperlibrarian typo something ugly in C4/Input.pm typo in 3.07.00.030 updatedatabase.pl upgrade Perhaps those deserve a bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 06:28:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 04:28:17 +0000 Subject: [Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from M. Tompsett --- Koha::FrameworkPlugin needs tweaking, and is the reason a lot of the other stuff doesn't apply. Please rebase, amend, test, and reattach for signoff. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 07:28:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 05:28:02 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #19 from Katrin Fischer --- Colin, could you take a look at the last 2 comments and update the status here? Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:02:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:02:45 +0000 Subject: [Koha-bugs] [Bug 14129] templates.readme is outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:02:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:02:47 +0000 Subject: [Koha-bugs] [Bug 14129] templates.readme is outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129 --- Comment #1 from Katrin Fischer --- Created attachment 38795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38795&action=edit Bug 14129: templates.readme is outdated The file templates.readme dates back to CSV and HTML::Template times and is outdated. To test: - Verify the file is outdated and removed by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:02:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:02:58 +0000 Subject: [Koha-bugs] [Bug 14129] templates.readme is outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:03:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:03:31 +0000 Subject: [Koha-bugs] [Bug 14129] templates.readme is outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129 --- Comment #2 from Katrin Fischer --- I am proposing to remove the file - I think nowadays this kind of information would be better in the wiki. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:05:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:05:07 +0000 Subject: [Koha-bugs] [Bug 14126] Typo on order receive page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14126 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:05:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:05:10 +0000 Subject: [Koha-bugs] [Bug 14126] Typo on order receive page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14126 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38794|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 38796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38796&action=edit [SIGNED OFF] Bug 14126 - Typo on order receive page A typo found while doing translation: To test 1) Go to dir 'intranet-tmpl/prog/en/modules/acqui/neworderempty.tt' line 268 and check the typo "To notify on reveiving:" 2) Apply the patch 3) Repeat step 1 and check if the typo is fixed Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:23:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:23:14 +0000 Subject: [Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:23:17 +0000 Subject: [Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125 --- Comment #1 from Katrin Fischer --- Created attachment 38797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38797&action=edit Bug 14125: Fix template problems on csv profiles help page Page uses TAGS Directive in order to print TT directives in the manual without having them interpreted, but fails to switch back/change all following TT code, causing problems in displaying the file correctly. See TT documentation: http://www.template-toolkit.org/docs/manual/Directives.html#section_TAGS As [- ... -] showed up in translations, I chose to switch back instead of changing the TT variable and INCLUDE. To test: - Go to tools > csv profiles - Open the help page - Verify the link to the manual includes the version and works - Verify the footer shows up correctly with the edit buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:23:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:23:27 +0000 Subject: [Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:49:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:49:08 +0000 Subject: [Koha-bugs] [Bug 14130] column.def should be updated with descriptions for new columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:51:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:51:20 +0000 Subject: [Koha-bugs] [Bug 14129] templates.readme is outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 08:51:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 06:51:23 +0000 Subject: [Koha-bugs] [Bug 14129] templates.readme is outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38795|0 |1 is obsolete| | --- Comment #3 from Magnus Enger --- Created attachment 38798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38798&action=edit Bug 14129: templates.readme is outdated The file templates.readme dates back to CSV and HTML::Template times and is outdated. To test: - Verify the file is outdated and removed by this patch. Signed-off-by: Magnus Enger If noone spotted the outdatedness of this file until now I agree with Katrin that we should get rid of it and maybe create something similar in the wiki. The patch works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 09:22:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 07:22:24 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 --- Comment #23 from Katrin Fischer --- Bug 14099 - thx Christopher! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 09:22:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 07:22:33 +0000 Subject: [Koha-bugs] [Bug 14099] RESERVESLIP shows incorrect information in items.holdingbranch on first scan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 09:22:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 07:22:38 +0000 Subject: [Koha-bugs] [Bug 14099] RESERVESLIP shows incorrect information in items.holdingbranch on first scan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 09:49:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 07:49:40 +0000 Subject: [Koha-bugs] [Bug 12348] unique barcodes should be mandatory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12348 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED CC| |magnus at enger.priv.no --- Comment #2 from Magnus Enger --- I agree with Katrin. Because of itemBarcodeFallbackSearch, we cannot force barcodes to be NOT NULL. This should be ficed in the frameworks instead. Marking as RECOLVED WONTFIX. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 09:52:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 07:52:01 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 --- Comment #27 from Marcel de Rooy --- Why does the db rev of this report not update kohafield for existing installs? If 952$x has not been connected to some other field, what would be the problem in connecting it to itemnotes_nonpublic just as you do for the new install? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 09:53:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 07:53:54 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 --- Comment #8 from Olli-Antti Kivilahti --- FYI: Just started working on this. https://metacpan.org/pod/Selenium::Remote::Driver no longer needs the stand-alone server !! YAY YAY!!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 10:06:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 08:06:59 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 --- Comment #28 from Katrin Fischer --- Because the data is still in more_subfields_xml or items.paidfor (depending on the age of the installation) you will have problems accessing your data. I did a lot of tests when we tried to do that in the first iteration and there always remained problems (see bug 4222). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 10:28:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 08:28:51 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Marc V?ron --- Ho, forgot to set to Needs Signoff... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 10:37:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 08:37:22 +0000 Subject: [Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125 --- Comment #2 from Marc V?ron --- Created attachment 38799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38799&action=edit [Signed-off] Bug 14125: Fix template problems on csv profiles help page Page uses TAGS Directive in order to print TT directives in the manual without having them interpreted, but fails to switch back/change all following TT code, causing problems in displaying the file correctly. See TT documentation: http://www.template-toolkit.org/docs/manual/Directives.html#section_TAGS As [- ... -] showed up in translations, I chose to switch back instead of changing the TT variable and INCLUDE. To test: - Go to tools > csv profiles - Open the help page - Verify the link to the manual includes the version and works - Verify the footer shows up correctly with the edit buttons Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 10:37:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 08:37:41 +0000 Subject: [Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 10:38:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 08:38:06 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 --- Comment #9 from Olli-Antti Kivilahti --- Cannot proceed because generating test users with test permissions has no API in Koha:: or C4:: Looking into the Koha REST API to create one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 11:10:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 09:10:24 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #4 from Julian FIOL --- Created attachment 38800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38800&action=edit Bug 14097 : Delete table issues before testing If we delete all biblio DB, we could have some troubles with foreign keys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 11:20:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 09:20:33 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 11:20:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 09:20:36 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 --- Comment #5 from Julian FIOL --- Created attachment 38801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38801&action=edit Bug 14059 : Delete all export of get_column_names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 11:25:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 09:25:31 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 --- Comment #1 from Marc V?ron --- Created attachment 38802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38802&action=edit Bug 14128 - Capitalization: Guided Reports - step 2 - Build A Report To verify and test: Go to Home > Reports Click on 'Build new' Verify that the title in Step 1 and to display with correct capitalization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 11:27:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 09:27:38 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #5 from Julian FIOL --- About Comment #3 After some tests, it seems that if the script stops / exits / fails for whatever reason after following lines, there is no $dbh->rollback, and the changes of the DB remains... my $dbh = C4::Context->dbh; $dbh->{AutoCommit} = 0; $dbh->{RaiseError} = 1; $dbh->do('DELETE FROM biblio'); $dbh->do('DELETE FROM items'); $dbh->do('DELETE FROM auth_header'); $dbh->do('DELETE FROM old_issues'); $dbh->do('DELETE FROM old_reserves'); $dbh->do('DELETE FROM borrowers'); $dbh->do('DELETE FROM aqorders'); $dbh->do('DELETE FROM subscription'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 11:36:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 09:36:27 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 --- Comment #2 from Marc V?ron --- Created attachment 38803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38803&action=edit Title 'Build a report' should display with all steps The tile displayed only with steps #1 and #2 This patch adds the title to the following steps. To test: Home > Reports Click on 'Build new' Step through steps 1 - 6 Verify that title displays with each step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 11:38:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 09:38:24 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch CC| |veron at veron.ch Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 11:38:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 09:38:53 +0000 Subject: [Koha-bugs] [Bug 12036] Neworderempty.pl fails to add items when itemrecorddisplay is too long (acqCreateItem=ordering) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12036 --- Comment #3 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #2) > Marcel, do you still have this issue? Normally, I do not have AcqCreateItem set to ordering. So I did not see it recently. But no proof of a solution yet :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 11:49:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 09:49:10 +0000 Subject: [Koha-bugs] [Bug 14127] Typo in message preference form - "mesage" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127 --- Comment #1 from Marc V?ron --- Created attachment 38804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38804&action=edit Bug 14127 - Typo in message preference form - "mesage" This path fixes the typo. To reproduce and test: Go to a patron's detail page The message appears as hint in column-header 'Digests only (i)' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 11:49:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 09:49:25 +0000 Subject: [Koha-bugs] [Bug 14127] Typo in message preference form - "mesage" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 11:52:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 09:52:04 +0000 Subject: [Koha-bugs] [Bug 14127] Typo in message preference form - "mesage" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 12:12:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 10:12:09 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #138 from Marc V?ron --- Patches still apply on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 13:33:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 11:33:57 +0000 Subject: [Koha-bugs] [Bug 14132] New: suggestions table is missing indexes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Bug ID: 14132 Summary: suggestions table is missing indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Suggestions table is missing some indexes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 13:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 11:34:07 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 13:40:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 11:40:47 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14132 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 13:40:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 11:40:44 +0000 Subject: [Koha-bugs] [Bug 14133] New: Print notices generated in special case do not use print template Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Bug ID: 14133 Summary: Print notices generated in special case do not use print template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: sophie.meynieux at biblibre.com QA Contact: testopia at bugs.koha-community.org In http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832, there are specific cases where print notices are generated (If a user don't have a smsalertnumber and a sms is required or if a user don't have an email defined and an email is required). But in this case, the template used is not print one, but sms or email. The pb is that in that case, there is no way to identify the borrower that should receive this message (especially for sms where the message is very brief) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 13:40:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 11:40:47 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7923 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 13:41:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 11:41:08 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10832 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 13:41:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 11:41:08 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14133 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 13:58:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 11:58:04 +0000 Subject: [Koha-bugs] [Bug 14134] New: Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134 Bug ID: 14134 Summary: Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If ExpireReservesMaxPickUpDelay is enabled, the "holds over" tab becomes useless. It would be nice if the "holds over" tab would display *tomorrow's* "holds over" so the librarian can see what will be automatically canceled over night. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 13:58:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 11:58:08 +0000 Subject: [Koha-bugs] [Bug 14134] Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:00:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:00:25 +0000 Subject: [Koha-bugs] [Bug 14134] Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134 --- Comment #1 from Kyle M Hall --- Created attachment 38805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38805&action=edit Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set If ExpireReservesMaxPickUpDelay is enabled, the "holds over" tab becomes useless. It would be nice if the "holds over" tab would display *tomorrow's* "holds over" so the librarian can see what will be automatically canceled over night. Test Plan: 1) Apply this patch 2) Enable ExpireReservesMaxPickUpDelay 3) Note the "holds over" list now displays holds that will have been waiting more than the number of days defined in ReservesMaxPickUpDelay as of tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:03:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:03:37 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 --- Comment #1 from Fridolin SOMERS --- Created attachment 38806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38806&action=edit Bug 14132 - suggestions table is missing indexes Suggestions table is missing some indexes. Index on biblionumber will speed up C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop. Index on status and branchcode will speed up many queries. Note that an index on budgetid is automatically added by the creation of the foreign key constraint. Test plan : - Check performance with an invoice containing a lot of orders. - Check suggestions pages are faster or at least not slower. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:03:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:03:48 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 --- Comment #2 from Fridolin SOMERS --- Created attachment 38807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38807&action=edit Bug 14132 - suggestions table is missing indexes - atomicupdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:08:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:08:50 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #9 from Marc V?ron --- Created attachment 38808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38808&action=edit [Signed-off] Bug 14053 - Acquisition db tables are missing indexes - atomicupdates Signed-off-by: Mark Tompsett Atomic updates worked OK Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:09:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:09:24 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #38729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:09:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:09:39 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:10:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:10:26 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:18:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:18:24 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Should this have the status "Needs sign-off"? For the second patch: Instead of ALTER TABLE `suggestions`... maybe better: ALTER IGNORE TABLE `suggestions`... http://wiki.koha-community.org/wiki/Database_updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:19:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:19:53 +0000 Subject: [Koha-bugs] [Bug 14134] Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:21:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:21:27 +0000 Subject: [Koha-bugs] [Bug 7840] Remove from manual Koha as a CMS (or add it to master) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:35:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:35:33 +0000 Subject: [Koha-bugs] [Bug 14134] Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38805|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 38809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38809&action=edit Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set If ExpireReservesMaxPickUpDelay is enabled, the "holds over" tab becomes useless. It would be nice if the "holds over" tab would display *tomorrow's* "holds over" so the librarian can see what will be automatically canceled over night. Test Plan: 1) Apply this patch 2) Enable ExpireReservesMaxPickUpDelay 3) Note the "holds over" list now displays holds that will have been waiting more than the number of days defined in ReservesMaxPickUpDelay as of tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 14:58:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 12:58:24 +0000 Subject: [Koha-bugs] [Bug 14067] 500 error when deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #2 from Barton Chittenden --- Here's the error as found in intranet-error.log [Mon May 04 08:52:27 2015] [error] [client xx.xx.xx.xx] [Mon May 4 08:52:27 2015] deletemem.pl: DBD::mysql::st execute failed: Column 'cardnumber' cannot be null at /usr/local/share/perl/5.10.1/DBIx/Class/Storage/DBI.pm line 1834. [Mon May 04 08:52:27 2015] [error] [client xx.xx.xx.xx] Premature end of script headers: deletemem.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:06:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:06:55 +0000 Subject: [Koha-bugs] [Bug 14135] New: Local Use syspref addition form missing variable type 'Free' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Bug ID: 14135 Summary: Local Use syspref addition form missing variable type 'Free' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSource. But there is no option presented for "Free" which seems to be the most used variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime) This trivial patch proposes to modify the systempreferences.tt and add the option 'Free' to the list offered to users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:08:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:08:19 +0000 Subject: [Koha-bugs] [Bug 14136] New: Remove superfluous template parameters from members/member-flags.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136 Bug ID: 14136 Summary: Remove superfluous template parameters from members/member-flags.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This bug was triggered because intranet-error ad entries like the following: member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/member-flags.pl line 176. To reproduce: Have a patron without roadtype and go to Home > Patrons > Set permissions for ... There are some template parameters that are not used in the template member-flags.tt ( $roadtype is used while preparing $address ) Unused template params are: cardnumber othernames categorycode category_type categoryname address address2 city state zipcode country phone phonepro mobile email emailpro branchcode branchname loop is_child activeBorrowerRelationship RoutingSerials -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:10:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:10:53 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38481|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 38810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38810&action=edit Bug 14059 : Testing C4::Creators::Lib Testing C4::Creators::Lib at 100% Deleting get_column_names subroutine (never used) TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Creators/Lib.t -- All 644 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Check with bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 11,6% Branch : 0,0% Condition : N/A Subroutine : 36,0% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:11:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:11:01 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38801|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 38811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38811&action=edit Bug 14059 : Delete all export of get_column_names This deals with my concerns raised in comment #2. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:11:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:11:18 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:13:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:13:46 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #10 from Fridolin SOMERS --- I have to review those patches because I discovered that adding a foreign key constraint automatically adds an index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:14:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:14:19 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:14:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:14:42 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38808|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:15:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:15:18 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14132 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:15:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:15:18 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14053 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:23:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:23:18 +0000 Subject: [Koha-bugs] [Bug 14136] Remove superfluous template parameters from members/member-flags.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136 --- Comment #1 from Marc V?ron --- Created attachment 38812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38812&action=edit Bug 14136 - Remove superfluous template parameters from members/member-flags.pl This bug was triggered because intranet-error.log had entries like the following: member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/member-flags.pl line 176. To reproduce: Have a patron without roadtype and go to Home > Patrons > Set permissions for ... There are some template parameters that are not used in the template member-flags.tt ( $roadtype is used while preparing $address ) Unused template params are: cardnumber othernames categorycode category_type categoryname address address2 city state zipcode country phone phonepro mobile email emailpro branchcode branchname loop is_child activeBorrowerRelationship RoutingSerials To test: - Verify that you get the warning above in intranet-error.log - Verify that the parameters above are not used in the template member-flags.tt - Apply patch - Verify that setting permissions for patrons still works Note: There are a lot of indenting issues in this file. This patch does not intend to resolve them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:24:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:24:04 +0000 Subject: [Koha-bugs] [Bug 14136] Remove superfluous template parameters from members/member-flags.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:28:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:28:27 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:28:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:28:29 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38772|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 38813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38813&action=edit Bug 14122 - Patron card: Software error when creating using borrower_number as parameter from URL To test prepare an URL like the following: ...cgi-bin/koha/patroncards/create-pdf.pl?borrower_number=61&template_id=24&layout_id=21&start_card=1 Change the values for borrower_number, template_id and layout_id to something that exists in your system. Without patch, the URL leads to a software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/patroncards/create-pdf.pl line 118. With patch, a PDF with the patron card is created. Signed-off-by: Mark Tompsett NOTE: This does NOT deal with the case where borrowernumber, template_id, or layout_id are invalid. This only deals with the case where they do exist. Invalid borrowernumber still gives same error. Invalid template_id or layout_id gives error on line 111. Those are beyond the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:30:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:30:29 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #6 from Julian FIOL --- Created attachment 38814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38814&action=edit Bug 14097 : changing verif_systempreferences_values subroutine It's saving a large number of lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:32:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:32:27 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 --- Comment #6 from Chris Nighswonger --- (In reply to M. Tompsett from comment #5) > NOTE: This does NOT deal with the case where borrowernumber, > template_id, or layout_id are invalid. This only deals with > the case where they do exist. > > Invalid borrowernumber still gives same error. > Invalid template_id or layout_id gives error on line 111. > Those are beyond the scope of this bug. If you don't mind, go ahead and open a bug for this. create-pdf.pl and friends should handle this gracefully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:33:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:33:20 +0000 Subject: [Koha-bugs] [Bug 14137] New: Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 Bug ID: 14137 Summary: Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Some libraries would like to be able to use ExpireReservesMaxPickUpDelayCharge without ExpireReservesMaxPickUpDelay. ExpireReservesMaxPickUpDelay automatically cancels the holds but some librarians would prefer to cancel the holds manually but still have the patron's charged the fee for allowing a waiting hold to become expired and canceled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:34:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:34:40 +0000 Subject: [Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:34:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:34:42 +0000 Subject: [Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 --- Comment #1 from Kyle M Hall --- Created attachment 38815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38815&action=edit Bug 14137 - Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay Some libraries would like to be able to use ExpireReservesMaxPickUpDelayCharge without ExpireReservesMaxPickUpDelay. ExpireReservesMaxPickUpDelay automatically cancels the holds but some librarians would prefer to cancel the holds manually but still have the patron's charged the fee for allowing a waiting hold to become expired and canceled. Test Plan: 1) Apply this patch 2) Set a fee amount in ExpireReservesMaxPickUpDelayCharge 3) Cancel a hold from the "holds over" tab 4) View the patron record, note the fee has been added -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:50:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:50:03 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #1 from Indranil Das Gupta --- Created attachment 38816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38816&action=edit Bug 14135 [ENH] Adds 'Free' to variabletypes in systempreferences.tt The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Uplo There is no option presented for "Free" which seems to be the most used variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime) This trivial patch proposes to modify the systempreferences.tt and add the option 'Free' to the list offered to users. Test Plan ========= 1/ Go to Home > Administration > System preferences > Local use 2/ Click on 'New preference'. 3/ In the fieldset 'Koha Internal', the variable types offered are Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources. 4/ Clicking on 'Choice' should set the 'preftype' field as 'Choice'. 5/ Apply this patch. 6/ Refresh the page. 7/ The variable types list should read - "Free, Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources". 8/ Clicking on 'Free' should set the 'preftype' field as 'Free'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 15:52:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 13:52:52 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:05:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:05:33 +0000 Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from cataloging search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886 --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 38817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38817&action=edit Bug 13886: (QA followup) only show merge button on search results Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:13:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:13:33 +0000 Subject: [Koha-bugs] [Bug 14138] New: Patroncard: Prevent errors if create-pdf.pl gets wrong parameters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Bug ID: 14138 Summary: Patroncard: Prevent errors if create-pdf.pl gets wrong parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Creating PDF for patron cards fails if it is getting invalid parameters for borrowernumber, template_id or layout_id -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:16:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:16:40 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14122 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14122 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:16:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:16:40 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14138 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14138 QA Contact|veron at veron.ch |testopia at bugs.koha-communit | |y.org Assignee|cnighswonger at foundations.ed |veron at veron.ch |u | --- Comment #7 from Marc V?ron --- I was about to open Bug 14138... (Oh, it seems that I mistaked by setting Assignee...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:22:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:22:56 +0000 Subject: [Koha-bugs] [Bug 14139] New: Koha showing 1 264 and it's not the first Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14139 Bug ID: 14139 Summary: Koha showing 1 264 and it's not the first Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org When there are two 264 fields with blank indicators, Koha seems to display the second 264 field display rather than the first 264 field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:26:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:26:32 +0000 Subject: [Koha-bugs] [Bug 14140] New: Reversed payments don't generate entry in statistics Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14140 Bug ID: 14140 Summary: Reversed payments don't generate entry in statistics Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We are tracking payments in the statistics table, but when a payment gets reversed, the data you can get from there is not correct. We should also be tracking reversed payments so it's possible to calculate the correct amounts from the statistics table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:31:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:31:31 +0000 Subject: [Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:45:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:45:45 +0000 Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from cataloging search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:46:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:46:54 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #32 from Tom?s Cohen Arazi --- Patches pushed to master. Good job Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:47:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:47:33 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #28 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:48:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:48:01 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:48:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:48:26 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Tom?s Cohen Arazi --- Fix pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:48:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:48:52 +0000 Subject: [Koha-bugs] [Bug 14011] Triggering slip print with enter key collides with 'barcode submitted' message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14011 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 16:52:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 14:52:36 +0000 Subject: [Koha-bugs] [Bug 14141] New: Changing the Library for a notice duplicates the notice instead of updating it Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Bug ID: 14141 Summary: Changing the Library for a notice duplicates the notice instead of updating it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If you edit a notice for a library and choose to change the Library field, the notice is created for that library, but the old notice remains. Essentially this turns the "update" into a "copy with edits". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 17:11:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 15:11:16 +0000 Subject: [Koha-bugs] [Bug 14127] Typo in message preference form - "mesage" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38804|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 38818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38818&action=edit [SIGNED-OFF] Bug 14127 - Typo in message preference form - "mesage" This path fixes the typo. To reproduce and test: Go to a patron's detail page The message appears as hint in column-header 'Digests only (i)' Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 17:13:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 15:13:36 +0000 Subject: [Koha-bugs] [Bug 14127] Typo in message preference form - "mesage" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 17:28:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 15:28:04 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38220|0 |1 is obsolete| | --- Comment #64 from H?ctor Eduardo Castro Avalos --- Created attachment 38819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38819&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. The recommendation can be consulted at . This new feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patches. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C. 7) DC-XML cannot valid if not exist a valid XSD schema. 8) OAI-DC can be validated using and the proper schema typed in text field for URL. 9) Since unit test fail last time, test with prove t/db_dependent/Record.t Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities, HTML::Entities and, HTML::Entities::Numbered were eliminated from patch, use instead C4::Record::_entity_encode, RDF::Helper has been eliminated too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 17:33:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 15:33:48 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #65 from H?ctor Eduardo Castro Avalos --- New patch sent since PerlDependencies.pm changed in master branch for 3.20 and merge conflict with it. I really hope this not continue changing. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 17:34:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 15:34:58 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38446|0 |1 is obsolete| | Attachment #38447|0 |1 is obsolete| | Attachment #38448|0 |1 is obsolete| | Attachment #38449|0 |1 is obsolete| | Attachment #38450|0 |1 is obsolete| | --- Comment #226 from Kyle M Hall --- Created attachment 38820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38820&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 17:35:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 15:35:09 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #227 from Kyle M Hall --- Created attachment 38821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38821&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e opac/svc/patron/ Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 17:35:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 15:35:14 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #228 from Kyle M Hall --- Created attachment 38822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38822&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 17:35:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 15:35:19 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #229 from Kyle M Hall --- Created attachment 38823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38823&action=edit Bug 9303 [QA Followup] - Remove extra 'USE Koha', change "Call number" back to "Call no." Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 17:35:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 15:35:24 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #230 from Kyle M Hall --- Created attachment 38824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38824&action=edit Bug 9303 [QA Followup] - Restore missing biblio relationship -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 18:48:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 16:48:40 +0000 Subject: [Koha-bugs] [Bug 14108] manual chapter 3.1.6 on patron card creator - revision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14108 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #1 from Nicole C. Engard --- I am slowly copying the text out of the doc and in to the manual's XML. To answer your question - the text was copied from the page in Koha many years ago and probably never edited in the manual. They are not linked in any way. ** I don't know what this means "Multiple virgin card labels are assumed to be arranged in a grid on a sheet." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 18:53:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 16:53:39 +0000 Subject: [Koha-bugs] [Bug 14142] New: Holds queue viewer only displays first subtitle from marc keyword mappings Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Bug ID: 14142 Summary: Holds queue viewer only displays first subtitle from marc keyword mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Despite the point of the Keyword to MARC Mappings being to simplify the handling and display of repeated values from multiple subfields, the holds queue viewer will only display the first value found. What it should be doing instead is displaying all fields that match the subtitle keyword. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 18:55:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 16:55:54 +0000 Subject: [Koha-bugs] [Bug 14142] Holds queue viewer only displays first subtitle from marc keyword mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 18:55:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 16:55:57 +0000 Subject: [Koha-bugs] [Bug 14142] Holds queue viewer only displays first subtitle from marc keyword mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 --- Comment #1 from Kyle M Hall --- Created attachment 38825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38825&action=edit Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings Despite the point of the Keyword to MARC Mappings being to simplify the handling and display of repeated values from multiple subfields, the holds queue viewer will only display the first value found. What it should be doing instead is displaying all fields that match the subtitle keyword. Test Plan: 1) Apply this patch 2) Define multiple Keyword to MARC mappings for the subtitle keyword 3) Place a hold on a record using those subtitle fields 4) View the hold in the holds queue viewer 5) Note that all the subtitles now appear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 19:15:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 17:15:50 +0000 Subject: [Koha-bugs] [Bug 14108] manual chapter 3.1.6 on patron card creator - revision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14108 --- Comment #2 from Nicole C. Engard --- You say: "As of 3.18.5 this is a relict of functionallity that is removed. If you want labels for both sides of your patron cards you have to define two layouts and print a batch for each side." I don't like to put bugs in the manual - is there a bug report to remove these options or fix them? Or are these choices just there (front and back) for the library to track what side they're designing? That's how I'll write it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 19:26:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 17:26:09 +0000 Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 19:27:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 17:27:06 +0000 Subject: [Koha-bugs] [Bug 12329] Inventory setting date last seen to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12329 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Kyle M Hall --- So far I've been unable to reproduce this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 19:52:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 17:52:15 +0000 Subject: [Koha-bugs] [Bug 14099] RESERVESLIP shows incorrect information in items.holdingbranch on first scan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- What I think is going on is the following: 1) The "print slip, confirm and transfer" button it clicked 2) The item is transferred, this act updates the holdingbranch to the destination branchcode for the item 3) The data is gathered and the slip is printed <-- This is why the branch is "wrong" 4) Rescanning the item triggers and update of the holdingbranch again and sets it to your branchcode 5) Reprinting the slip now makes it look "correct" but has possibly screwed up the transfer and the item needs transferred again ( or possibly the holdingbranch is updated a second time later on in step 4 after the data is gathered for the slip ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 4 20:12:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 18:12:03 +0000 Subject: [Koha-bugs] [Bug 14108] manual chapter 3.1.6 on patron card creator - revision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14108 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Nicole C. Engard --- Added the manual: http://git.koha-community.org/gitweb/?p=kohadocs.git;a=commitdiff;h=0fa2fb63e2249cd9d9b9b1edd925b85540359656 most of this was just rewording of what was already said - in that case I did not change the manual so that the manual remains in one tone of language. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 20:12:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 18:12:11 +0000 Subject: [Koha-bugs] [Bug 14108] manual chapter 3.1.6 on patron card creator - revision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14108 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 20:12:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 18:12:20 +0000 Subject: [Koha-bugs] [Bug 14108] manual chapter 3.1.6 on patron card creator - revision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14108 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 20:21:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 18:21:53 +0000 Subject: [Koha-bugs] [Bug 12025] Inventory tool fails with "Could not reads headers", or sometimes a timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12025 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14057 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 20:21:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 18:21:53 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12025 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 20:26:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 18:26:29 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 --- Comment #5 from M. Tompsett --- Katrin suggested this could be a duplicate for bug 12025, but perhaps I also resolved it with bug 14057. Perhaps this should be resolved/duplicate closed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 20:57:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 18:57:41 +0000 Subject: [Koha-bugs] [Bug 13773] add stock number to details and items display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13773 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Dobrica! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 20:58:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 18:58:10 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 20:58:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 18:58:38 +0000 Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Feature pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 20:59:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 18:59:07 +0000 Subject: [Koha-bugs] [Bug 10388] acq edited items showing 'null's In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 21:06:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 19:06:28 +0000 Subject: [Koha-bugs] [Bug 13888] 'Lists' permission should allow/disallow using the lists module in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 21:54:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 19:54:47 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u --- Comment #1 from Chris Nighswonger --- The upgrade mechanism really needs to run the same dep check which is run on a clean install... every time. And error trapping has never been our strong point, but really should become so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 22:09:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 20:09:50 +0000 Subject: [Koha-bugs] [Bug 14130] column.def should be updated with descriptions for new columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130 --- Comment #1 from Katrin Fischer --- Created attachment 38826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38826&action=edit Bug 14130: Update columns.def - Updates columns.def with new columns in items - Adds some descriptions - Corrects some existing column descrpitions To test: - Read the patch to see what has been changed - Run the guided report builder for the 'circulation' module - Observe changes show up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 22:10:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 20:10:24 +0000 Subject: [Koha-bugs] [Bug 14130] column.def should be updated with descriptions for new columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Katrin Fischer --- Not a complete patch, but hopefully a first improvement :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 22:13:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 20:13:34 +0000 Subject: [Koha-bugs] [Bug 14127] Typo in message preference form - "mesage" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 22:13:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 20:13:37 +0000 Subject: [Koha-bugs] [Bug 14127] Typo in message preference form - "mesage" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38818|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 38827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38827&action=edit [PASSED QA] Bug 14127 - Typo in message preference form - "mesage" This path fixes the typo. To reproduce and test: Go to a patron's detail page The message appears as hint in column-header 'Digests only (i)' Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 22:20:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 20:20:52 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Can you please make this a little more fail save? I think isses needs to be emptied out in the tests for them to run: $ prove t/db_dependent/Creators/Lib.t t/db_dependent/Creators/Lib.t .. 1/644 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/Creators/Lib.t line 61. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/Creators/Lib.t line 61. # Looks like you planned 644 tests but ran 6. # Looks like your test exited with 255 just after 6. t/db_dependent/Creators/Lib.t .. Dubious, test returned 255 (wstat 65280, 0xff00) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 22:35:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 20:35:08 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 22:35:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 20:35:11 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38813|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 38828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38828&action=edit [PASSED QA] Bug 14122 - Patron card: Software error when creating using borrower_number as parameter from URL To test prepare an URL like the following: ...cgi-bin/koha/patroncards/create-pdf.pl?borrower_number=61&template_id=24&layout_id=21&start_card=1 Change the values for borrower_number, template_id and layout_id to something that exists in your system. Without patch, the URL leads to a software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/patroncards/create-pdf.pl line 118. With patch, a PDF with the patron card is created. Signed-off-by: Mark Tompsett NOTE: This does NOT deal with the case where borrowernumber, template_id, or layout_id are invalid. This only deals with the case where they do exist. Invalid borrowernumber still gives same error. Invalid template_id or layout_id gives error on line 111. Those are beyond the scope of this bug. Signed-off-by: Katrin Fischer Nice! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 22:36:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 20:36:59 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #21 from Katrin Fischer --- Sorry, but the second patch doesn't apply: $ git bz apply 9805 Bug 9805 - Lost items are un-lost if returned, but not if renewed. 38432 - Bug 9805 - Lost items are un-lost if returned, but not if renewed. 38433 - Bug 9805 [QA Followup] - Control renewing and finding of list items via circ rules Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9805 - Lost items are un-lost if returned, but not if renewed. Applying: Bug 9805 [QA Followup] - Control renewing and finding of list items via circ rules fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9805 [QA Followup] - Control renewing and finding of list items via circ rules The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9805-QA-Followup---Control-renewing-and-findin-VqfKfD.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 22:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 20:41:51 +0000 Subject: [Koha-bugs] [Bug 14067] 500 error when deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hm, is the cardnumber set for the patron they are trying to delete? The cardnumber should never be empty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 22:58:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 20:58:50 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Heinrich Hartl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Heinrich.Hartl at email.de --- Comment #9 from Heinrich Hartl --- Created attachment 38829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38829&action=edit new barcode scaling options in patron card creator menue The enhancement provided by mveron allows scaling the barcode both in horizontal and vertical direction. The scaling values in the menue are preset with the values that produce the same result as before the the enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:01:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:01:34 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #17 from Katrin Fischer --- Marcel, can you check Kyle's last comment? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:03:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:03:17 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 --- Comment #10 from Heinrich Hartl --- koha manual chapter 3.1.6 on patron card creator needs to be adapted to include the new barcode scaling options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:11:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:11:32 +0000 Subject: [Koha-bugs] [Bug 11528] TrackClicks feature messes up proxied EBSCO e-books links? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11528 Ed Veal changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed.veal at bywatersolutions.co | |m --- Comment #2 from Ed Veal --- I can confirm that when you have an Ebsco URL in the item record (u - Uniform Resource Identifier) the link ends up taking you to Ebsco but to the search page rather than the item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:18:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:18:00 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #33 from Chris Cormack --- This is being tested by clients, you can (as always) see the work on the catalyst repo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:21:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:21:14 +0000 Subject: [Koha-bugs] [Bug 14143] New: Patron cards: Crash (confusion between table names creator_templates and club_template_enrollment_fields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14143 Bug ID: 14143 Summary: Patron cards: Crash (confusion between table names creator_templates and club_template_enrollment_fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: Go to Home > Tools > Patron card creator Click on 'Manage profiles' Result: Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/share/kohaclone/C4/Creators/Lib.pm line 564. Reason: Select statment to get field 'template code' from table 'club_template_enrollment_fields' (!) instead of 'table creator_templates'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:25:14 +0000 Subject: [Koha-bugs] [Bug 11528] TrackClicks feature messes up proxied EBSCO e-books links? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11528 --- Comment #3 from Katrin Fischer --- Can you give us an example URL for testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:31:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:31:15 +0000 Subject: [Koha-bugs] [Bug 14143] Patron cards: Crash (confusion between table names creator_templates and club_template_enrollment_fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14143 --- Comment #1 from Marc V?ron --- Created attachment 38830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38830&action=edit Bug 14143 - Patron cards: Crash (confusion between table names creator_templates and club_template_enrollment_fields) To reproduce: Go to Home > Tools > Patron card creator Click on 'Manage profiles' Result: Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/share/kohaclone/C4/Creators/Lib.pm line 564. Reason: Select statment to get field 'template code' from table 'club_template_enrollment_fields' (!) instead of 'table creator_templates'. To test: Apply patch Try to reproduce issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:33:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:33:46 +0000 Subject: [Koha-bugs] [Bug 14143] Patron cards: Crash (confusion between table names creator_templates and club_template_enrollment_fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14143 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:47:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:47:26 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com, | |robin at catalyst.net.nz --- Comment #2 from H?ctor Eduardo Castro Avalos --- (In reply to Marc V?ron from comment #0) > After the upgrade to 3.19.00.035 the mainpage of the > cgi-bin/koha/mainpage.pl -> Software error: Can't locate PDF/FromHTML.pm in > @INC > > However, other pages are available, e.g. > cgi-bin/koha/circ/circulation-home.pl > > There were missing dependencies, see comment on Bug 8007 > > * libhtml-tidy-perl > * libgraphics-colornames-perl > * libpdf-fromhtml-perl (build needed) > * libpdf-writer-perl (build needed) > > However, the depenencies are not listed on the About page (Perl modules). > > The crash on mainpage.pl occurs because does use Koha::Borrower::Discharge > Maybe this could be handled more gracefully if the dependencies are not > installed. The PerlDependencies.pm show only PDF::FromHTML module and is set to don't required. 'PDF::FromHTML' => { 'usage' => 'Discharge generation', 'required' => '0', 'min_ver' => '0.31', }, The other modules are requiered by PDF::FromHTML and indeed the error its launched by mainpage.pl at line 32. This is because the use of Koha::Borrower::Discharge. Maybe Robin can do something to build the packages. Regards -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:48:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:48:43 +0000 Subject: [Koha-bugs] [Bug 14143] Patron cards: Crash (confusion between table names creator_templates and club_template_enrollment_fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14143 --- Comment #2 from Marc V?ron --- Note: This is kind of prospective patch, it appeared after testing Bug 12461 - Add patron clubs feature No changes for Bug 12461 needed though, the reason of the ambiguity waited in C4/Creators/Lib.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:50:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:50:11 +0000 Subject: [Koha-bugs] [Bug 14108] manual chapter 3.1.6 on patron card creator - revision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14108 --- Comment #4 from Heinrich Hartl --- (In reply to Nicole C. Engard from comment #1) > I am slowly copying the text out of the doc and in to the manual's XML. > > To answer your question - the text was copied from the page in Koha many > years ago and probably never edited in the manual. They are not linked in > any way. > > ** I don't know what this means "Multiple virgin card labels are assumed to > be arranged in a grid on a sheet." In the text Avery 5160 is mentioned as an example. This Avery product actually is a box of 100 sheets to be fed into the printer as needed. On each sheet you find 30 self adhesive blank labels each 1" by 2-5/8" three in a row and 10 rows per sheet. The arrangement 3*10 in my words is a grid of labels. I have no better term for such a rectangular arrangement. I don't think matrix is better. The functionality of patron card creator allows to print in a first batch e.g. only 10 patron cards - if you start printing on label 1 the 9 labels in the first three rows and one extra, the left one in row 4 are printed. The printed labels are likely to be peeled off the sheet and used for the actual patron cards. The next time printing a batch of patron cards you might use the same sheet again (only 10 labels are used so far, 20 more are on the sheet) but start printing on label 11 i.e in row 4 the second label. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:56:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:56:57 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38802|0 |1 is obsolete| | Attachment #38803|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 38831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38831&action=edit [SIGNED-OFF] Bug 14128 - Capitalization: Guided Reports - step 2 - Build A Report Title 'Build a report' should display with all steps The tile displayed only with steps #1 and #2 This patch adds the title to the following steps. To test: Home > Reports Click on 'Build new' Step through steps 1 - 6 Verify that title displays with each step. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:57:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:57:41 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 4 23:58:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 21:58:03 +0000 Subject: [Koha-bugs] [Bug 14142] Holds queue viewer only displays first subtitle from marc keyword mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 01:05:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 23:05:11 +0000 Subject: [Koha-bugs] [Bug 14067] 500 error when deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067 --- Comment #4 from David Cook --- (In reply to Barton Chittenden from comment #2) > Here's the error as found in intranet-error.log > > [Mon May 04 08:52:27 2015] [error] [client xx.xx.xx.xx] [Mon May 4 08:52:27 > 2015] deletemem.pl: DBD::mysql::st execute failed: Column 'cardnumber' > cannot be null at /usr/local/share/perl/5.10.1/DBIx/Class/Storage/DBI.pm > line 1834. > [Mon May 04 08:52:27 2015] [error] [client xx.xx.xx.xx] Premature end of > script headers: deletemem.pl That's an interesting error. When I look at my databases, 'cardnumber' is a nullable column. I'd suggest looking at Koha::Schema::Result::Borrower.pm and seeing if "cardnumber" has "is_nullable" set to 1. I'd also check the actual database to see if it's a nullable column... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 01:20:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 May 2015 23:20:26 +0000 Subject: [Koha-bugs] [Bug 14108] manual chapter 3.1.6 on patron card creator - revision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14108 --- Comment #5 from Nicole C. Engard --- I feel this information is really not necessary for the manual. People might buy one card at a time and print them - they might buy a sheet of cards. There are too many options here to assume that the paper is in a 'grid' format. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 02:41:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 00:41:43 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 --- Comment #2 from M. Tompsett --- Created attachment 38832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38832&action=edit Bug 14111 - More t/Auth_with_shibboleth.t silencing TEST PLAN --------- 1) Apply first patch 2) prove t/Auth_with_shibboleth.t -- failed?! 3) apply this patch 4) prove t/Auth_with_shibboleth.t -- success. *whew* 5) koha-qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 02:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 00:43:58 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14111 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 02:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 00:43:58 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5010 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 02:44:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 00:44:22 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #114 from David Cook --- (In reply to Tom?s Cohen Arazi from comment #112) > FTR: > > - It doesn't need python-pisa :-D (this was removed at some point) > - The new dependencies for this one are: > * libhtml-tidy-perl > * libgraphics-colornames-perl > * libpdf-fromhtml-perl (build needed) > * libpdf-writer-perl (build needed) I'm a bit confused... It appears that libgraphics-colornames-perl and libpdf-writer-perl are dependencies for libpdf-fromhtml-perl. However, I don't see libhtml-tidy-perl in the code? I notice that Image::Size is a dependency of PDF::FromHtml though. Also, why is PDF::FromHTML marked as not required in the koha_perl_deps.pl? As soon as you log in to Koha on master, you're faced with: "Can't locate PDF/FromHTML.pm in @INC (you may need to install the PDF::FromHTML module)", since Koha::Borrower::Discharge loads on mainpage.pl... Do we just need a follow-up patch for C4::Installer::PerlDependencies to mark it as required? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 02:46:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 00:46:26 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38658|0 |1 is obsolete| | --- Comment #95 from M. Tompsett --- Created attachment 38833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38833&action=edit Bug 5010 - Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/it-IT/necessari/notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased again on kohadevbox... Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 02:46:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 00:46:34 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38659|0 |1 is obsolete| | --- Comment #96 from M. Tompsett --- Created attachment 38834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38834&action=edit Bug 5010: Fix - replace tab with spaces Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 5 04:00:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 02:00:41 +0000 Subject: [Koha-bugs] [Bug 14144] New: Silence warnings t/db_dependent/Auth_with_ldap.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 Bug ID: 14144 Summary: Silence warnings t/db_dependent/Auth_with_ldap.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com prove t/db_dependent/Auth_with_ldap.t generates a shibboleth warning, it shouldn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 04:01:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 02:01:09 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 04:05:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 02:05:55 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 04:05:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 02:05:57 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 --- Comment #1 from M. Tompsett --- Created attachment 38835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38835&action=edit Bug 14144: Silence warnings in t/db_dependent/Auth_with_ldap.t TEST PLAN ---------- 1) prove t/db_dependent/Auth_with_ldap.t -- there is a shibboleth related warning 2) apply patch 3) prove t/db_dependent/Auth_with_ldap.t -- now there is not. 4) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 04:11:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 02:11:20 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 04:20:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 02:20:52 +0000 Subject: [Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38835|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 38836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38836&action=edit Bug 14144: Silence warnings in t/db_dependent/Auth_with_ldap.t TEST PLAN ---------- 1) prove t/db_dependent/Auth_with_ldap.t -- there is a shibboleth related warning 2) apply patch 3) prove t/db_dependent/Auth_with_ldap.t -- now there is not. 4) koha qa test tools. NOTE: Further investigation determined this would merely delay it, as the function is not called by this test. A delay is better than nothing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 04:27:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 02:27:10 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #115 from David Cook --- (In reply to David Cook from comment #114) > (In reply to Tom?s Cohen Arazi from comment #112) > > FTR: > > > > - It doesn't need python-pisa :-D (this was removed at some point) > > - The new dependencies for this one are: > > * libhtml-tidy-perl > > * libgraphics-colornames-perl > > * libpdf-fromhtml-perl (build needed) > > * libpdf-writer-perl (build needed) > > I'm a bit confused... > > It appears that libgraphics-colornames-perl and libpdf-writer-perl are > dependencies for libpdf-fromhtml-perl. However, I don't see > libhtml-tidy-perl in the code? I notice that Image::Size is a dependency of > PDF::FromHtml though. > > Also, why is PDF::FromHTML marked as not required in the koha_perl_deps.pl? > As soon as you log in to Koha on master, you're faced with: > > "Can't locate PDF/FromHTML.pm in @INC (you may need to install the > PDF::FromHTML module)", since Koha::Borrower::Discharge loads on > mainpage.pl... > > Do we just need a follow-up patch for C4::Installer::PerlDependencies to > mark it as required? My bad about libhtml-tidy-perl. I already had it installed, so I didn't see it as a dependency. I assume it's a dependency of PDF::FromHTML? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 05:07:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 03:07:30 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #3 from H?ctor Eduardo Castro Avalos --- This bug represent a problem when doing a new installation. When execute perl koha_perl_deps.pl -u -m gives a table: Module Name Installed Version Required Version Module is Required PDF::FromHTML * 0.31 No If you ignore the module and installion haven't done, before doing all steps the software crash, showing us the software error page. I propose to change the module to required since people without a experience on Koha will become confused. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 05:38:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 03:38:56 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14143 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 05:38:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 03:38:56 +0000 Subject: [Koha-bugs] [Bug 14143] Patron cards: Crash (confusion between table names creator_templates and club_template_enrollment_fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14143 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12461 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 05:59:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 03:59:59 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |hector.hecaxmmx at gmail.com |ity.org | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 38837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38837&action=edit Bug 14103 - Discharge management: Software error on main page after upgrade If module PDF::FromHTML is set to not required, the software crash in new installations if the module is ignored. Changing the module to required will fix it up. I propose to change the module to required since people without experience on Koha will become confused. Test plan 1) Emulate new installation and not install PDF::FromHTML from cpan 2) Run perl koha_perl_deps.pl -u -m and get notice that the module is not required 3) Run your staff client and opac. The software crash showing us the error page 4) Apply patch 5) Run koha_perl_deps.pl -u -m again and observe that the module has changed to required 6) Install PDF::FromHTML and get access to staff client and opac, the error will not be displayed Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 06:02:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 04:02:00 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com --- Comment #5 from H?ctor Eduardo Castro Avalos --- I add Katrin and Tom?s, since this represent a critical bug for 3.20 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 06:08:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 04:08:12 +0000 Subject: [Koha-bugs] [Bug 10105] Gate register module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 06:08:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 04:08:40 +0000 Subject: [Koha-bugs] [Bug 10105] Gate register module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 --- Comment #8 from M. Tompsett --- Is there a status update on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 06:46:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 04:46:03 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #116 from Robin Sheat --- PDF::Writer is pretty straightforward, but PDF::FromHTML is not high enough quality to be a Debian package so is going to take a bit of time to prepare packages for (I'm not willing to take on the technical debt of being a sole maintainer, I'm afraid, so am going to insist that it's ready for debian before I put it into the Koha repo.) Here's the list of errors it produces: http://paste.koha-community.org/86 If you want to make some patches to fix any of this, especially the manpage errors, that would help this process along a whole lot. The git repo is here: ssh://git.debian.org/git/pkg-perl/packages/libpdf-fromhtml-perl.git Tom?s, this does mean that master isn't going to be able to be built properly until this is resolved. PS: good practice for anyone who wants to learn about what's needed to package things correctly, which I encourage as then it means less to do for me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 07:02:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 05:02:02 +0000 Subject: [Koha-bugs] [Bug 14145] New: Noisy warns in admin/preferences.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 Bug ID: 14145 Summary: Noisy warns in admin/preferences.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com 'Odd number elements in anonymous hash' warns on lines 116 and 121 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 5 07:07:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 05:07:11 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #6 from Robin Sheat --- I added a note to bug 8007: PDF::Writer is pretty straightforward, but PDF::FromHTML is not high enough quality to be a Debian package so is going to take a bit of time to prepare packages for (I'm not willing to take on the technical debt of being a sole maintainer, I'm afraid, so am going to insist that it's ready for debian before I put it into the Koha repo.) Here's the list of errors it produces: http://paste.koha-community.org/86 If you want to make some patches to fix any of this, especially the manpage errors, that would help this process along a whole lot. The git repo is here: ssh://git.debian.org/git/pkg-perl/packages/libpdf-fromhtml-perl.git Tom?s, this does mean that master isn't going to be able to be built properly until this is resolved. PS: good practice for anyone who wants to learn about what's needed to package things correctly, which I encourage as then it means less to do for me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 07:13:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 05:13:00 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 5 07:13:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 05:13:02 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 --- Comment #1 from Aleisha Amohia --- Created attachment 38838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38838&action=edit Bug 14145: Noisy warns in admin/preferences.pl This patch silences the warns on lines 116 and 121 by referring to the chunk variable name (type) rather than what I assume is the string 'multiple'. I don't know that this is the best solution for this, but the warns are gone and the page seems to work still. To test: 1) Go to Admin -> System Preferences and click on the OPAC tab 2) Notice the warns in the error log 3) Apply the patch and refresh page 4) Notice page still works but no warns in error log -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 5 07:45:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 05:45:05 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #7 from Robin Sheat --- I've added some patches using quilt that fix the encoding issues. For an intro to using quilt, go here: http://pkg-perl.alioth.debian.org/howto/quilt.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 07:49:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 05:49:09 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 --- Comment #2 from Aleisha Amohia --- Created attachment 38839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38839&action=edit Bug 14145: Noisy warns in admin/preferences.pl on Enhanced Content tab 'Use of uninitialized value $value in split' on line 109, fixed by setting $value to an empty string. To test: 1) Go to Admin -> System preferences 2) Click on Enhanced content tab 3) Notice warns in error log 4) Apply patch and refresh page 5) Notice page still works but no warns in error log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 08:27:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 06:27:12 +0000 Subject: [Koha-bugs] [Bug 10105] Gate register module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 08:32:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 06:32:04 +0000 Subject: [Koha-bugs] [Bug 10105] Gate register module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 --- Comment #9 from Indranil Das Gupta --- (In reply to Nabakumar from comment #7) > First of all thanks a lot for this valuable information.Can i have a video > regarding this? The client I was writing this for ran short on funds. So, presently looking for sponsors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 08:48:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 06:48:44 +0000 Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 09:26:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 07:26:39 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 09:28:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 07:28:13 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 --- Comment #4 from Fridolin SOMERS --- (In reply to Marc V?ron from comment #3) > Should this have the status "Needs sign-off"? Indeed. I've used git bz without -e. > > For the second patch: > Instead of > ALTER TABLE `suggestions`... > maybe better: > ALTER IGNORE TABLE `suggestions`... > > http://wiki.koha-community.org/wiki/Database_updates Ok thanks. I did not knew that INGORE can be used with ALTER TABLE. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 09:35:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 07:35:17 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 09:35:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 07:35:20 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 --- Comment #9 from Julian FIOL --- Created attachment 38840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38840&action=edit Bug 14059 : Deleting 'issues' table before processing the tests It's suppose to avoid foreign key trouble -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 09:37:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 07:37:57 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38806|0 |1 is obsolete| | --- Comment #5 from Fridolin SOMERS --- Created attachment 38841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38841&action=edit Bug 14132 - suggestions table is missing indexes Suggestions table is missing some indexes. Index on biblionumber will speed up C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop. Index on status and branchcode will speed up many queries. Note that an index on budgetid is automatically added by the creation of the foreign key constraint. Test plan : - Check performance with an invoice containing a lot of orders. - Check suggestions pages are faster or at least not slower. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 09:38:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 07:38:08 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38807|0 |1 is obsolete| | --- Comment #6 from Fridolin SOMERS --- Created attachment 38842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38842&action=edit Bug 14132 - suggestions table is missing indexes - atomicupdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 09:54:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 07:54:28 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 --- Comment #7 from Fridolin SOMERS --- Ready for signoff. I've spitted each alter table in a unique line because if one key already exists the all line fails. If the key alreeady exists, it will still return an error even with ALTER IGNORE. Looks like the is only useful for unique keys. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 11:04:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 09:04:15 +0000 Subject: [Koha-bugs] [Bug 14146] New: Additional days are not added to restriction period when checking-in several overdues for same patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146 Bug ID: 14146 Summary: Additional days are not added to restriction period when checking-in several overdues for same patron Change sponsored?: --- Product: Koha Version: 3.16 Hardware: PC OS: Windows Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: carol.andreu at masmedios.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We've noticed that when checking in some items with overdues Koha only takes the first checked-in item to apply the restriction period to that borrower. A borrower has three overdue items. We check-in the first of them, and Koha automatically sets a restriction period for that borrower. We check-in second and third item, but restriction period remains the same number of days, additional days of suspension are not accumulated to the restriction period. The expected behaviour would be that Koha added days to the restriction period for every single overdue the borrower checked-in, whether the check-in date of the overdue items was. Build 2015-03-27 on Windows 7, running Google Chrome and also tested with Mozilla Firefox and Internet Explorer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 11:13:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 09:13:40 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- This is still a problem we experience in Koha 3.18.5.1 - even for an almost empty Koha start page the language chooser is hiding. This is a problem as people have problems locating it as they don't expect it to be hidden below. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 12:35:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 10:35:02 +0000 Subject: [Koha-bugs] [Bug 14147] New: Add unit tests to C4::External::OverDrive Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Bug ID: 14147 Summary: Add unit tests to C4::External::OverDrive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Test Suite Assignee: julian.fiol at biblibre.com Reporter: julian.fiol at biblibre.com QA Contact: gmcharlt at gmail.com This patch test 'IsOverDriveEnabled' subroutine TEST PLAN --------- 1. Apply patch 2. prove -v t/External/OverDrive.t -- All 6 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Check with bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 47,5% Branch : 0,0% Condition : 0,0% Subroutine : 75,0% Coverage AFTER this patch : Statement : 49,1% Branch : 0,0% Condition : 33,3% Subroutine : 83,3% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 12:37:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 10:37:23 +0000 Subject: [Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 12:37:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 10:37:25 +0000 Subject: [Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 --- Comment #1 from Julian FIOL --- Created attachment 38843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38843&action=edit Bug 14147 : Add unit tests to C4::External::OverDrive This patch test 'IsOverDriveEnabled' subroutine TEST PLAN --------- 1. Apply patch 2. prove -v t/External/OverDrive.t -- All tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Check with bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 47,5% Branch : 0,0% Condition : 0,0% Subroutine : 75,0% Coverage AFTER this patch : Statement : 49,1% Branch : 0,0% Condition : 33,3% Subroutine : 83,3% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 12:41:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 10:41:41 +0000 Subject: [Koha-bugs] [Bug 14126] Typo on order receive page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14126 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 12:41:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 10:41:43 +0000 Subject: [Koha-bugs] [Bug 14126] Typo on order receive page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14126 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38796|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 38844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38844&action=edit [PASSED QA] Bug 14126 - Typo on order receive page A typo found while doing translation: To test 1) Go to dir 'intranet-tmpl/prog/en/modules/acqui/neworderempty.tt' line 268 and check the typo "To notify on reveiving:" 2) Apply the patch 3) Repeat step 1 and check if the typo is fixed Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 12:46:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 10:46:00 +0000 Subject: [Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 12:46:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 10:46:02 +0000 Subject: [Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38797|0 |1 is obsolete| | Attachment #38799|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 38845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38845&action=edit [PASSED QA] Bug 14125: Fix template problems on csv profiles help page Page uses TAGS Directive in order to print TT directives in the manual without having them interpreted, but fails to switch back/change all following TT code, causing problems in displaying the file correctly. See TT documentation: http://www.template-toolkit.org/docs/manual/Directives.html#section_TAGS As [- ... -] showed up in translations, I chose to switch back instead of changing the TT variable and INCLUDE. To test: - Go to tools > csv profiles - Open the help page - Verify the link to the manual includes the version and works - Verify the footer shows up correctly with the edit buttons Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 12:56:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 10:56:08 +0000 Subject: [Koha-bugs] [Bug 14129] templates.readme is outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 12:56:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 10:56:10 +0000 Subject: [Koha-bugs] [Bug 14129] templates.readme is outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38798|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 38846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38846&action=edit [PASSED QA] Bug 14129: templates.readme is outdated The file templates.readme dates back to CSV and HTML::Template times and is outdated. To test: - Verify the file is outdated and removed by this patch. Signed-off-by: Magnus Enger If noone spotted the outdatedness of this file until now I agree with Katrin that we should get rid of it and maybe create something similar in the wiki. The patch works as advertised. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 13:07:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 11:07:08 +0000 Subject: [Koha-bugs] [Bug 14108] manual chapter 3.1.6 on patron card creator - revision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14108 --- Comment #6 from Heinrich Hartl --- (In reply to Nicole C. Engard from comment #5) > I feel this information is really not necessary for the manual. People > might buy one card at a time and print them - they might buy a sheet of > cards. There are too many options here to assume that the paper is in a > 'grid' format. > > Nicole Everything in the template (+ the start value when exporting a batch is only provided to deal with printing on a sheet on which a grid of labels is arranged whereas the layout deals with a single patron card. Please make up your mind - either we explain how to print onto sheets with multiple labels arranged in a grid or delete templates from the patron card creator all together. Actually if people decide to use patron card creator for printing on a single card they have to define a template with a 1 by 1 grid! Moreover there is also a provision for a printer profile which also handles a specific problem associated with such a grid : creep! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 14:00:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 12:00:34 +0000 Subject: [Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38843|0 |1 is obsolete| | --- Comment #2 from Julian FIOL --- Created attachment 38847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38847&action=edit Bug 14147 : Add unit tests to C4::External::OverDrive This patch test 'IsOverDriveEnabled' subroutine TEST PLAN --------- 1. Apply patch 2. prove -v t/External/OverDrive.t -- All tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Check with bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 47,5% Branch : 0,0% Condition : 0,0% Subroutine : 75,0% Coverage AFTER this patch : Statement : 49,1% Branch : 0,0% Condition : 33,3% Subroutine : 83,3% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 14:17:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 12:17:40 +0000 Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #12 from Dobrica Pavlinusic --- This bug will break Koha installation if there is no enable_plugins in koha-conf.xml with following error: Can't call method "GetPlugins" on an undefined value at /srv/koha_ffzg/tools/stage-marc-import.pl line 206, line 603. This is not ideal, since it will break old installations. Problem is line: Koha::Plugins->new()->GetPlugins('to_marc'); where Koha::Plugins->new() will return undef is plugins are not enabled. It seems we also have same syntax in plugins/plugins-home.pl so it should probably be fixed also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 14:22:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 12:22:03 +0000 Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 --- Comment #13 from Dobrica Pavlinusic --- It's a little bit worse: plugins had to be enabled. Even adding 0 to koha-conf.xml won't help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 14:44:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 12:44:08 +0000 Subject: [Koha-bugs] [Bug 14148] New: Bug 12412 breaks import if plugins are not enabled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 Bug ID: 14148 Summary: Bug 12412 breaks import if plugins are not enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Dobrica reported on bug 12412: This bug will break Koha installation if there is no enable_plugins in koha-conf.xml with following error: Can't call method "GetPlugins" on an undefined value at /srv/koha_ffzg/tools/stage-marc-import.pl line 206, line 603. This is not ideal, since it will break old installations. Problem is line: Koha::Plugins->new()->GetPlugins('to_marc'); where Koha::Plugins->new() will return undef is plugins are not enabled. It seems we also have same syntax in plugins/plugins-home.pl so it should probably be fixed also. -- It's a little bit worse: plugins had to be enabled. Even adding 0 to koha-conf.xml won't help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 14:44:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 12:44:20 +0000 Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14148 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 14:44:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 12:44:20 +0000 Subject: [Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12412 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 14:44:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 12:44:28 +0000 Subject: [Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:00:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:00:24 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 --- Comment #11 from Chris Nighswonger --- Marc, would it be possible for you to add this to the label tool as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:04:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:04:10 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:04:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:04:12 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38764|0 |1 is obsolete| | --- Comment #12 from Chris Nighswonger --- Created attachment 38848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38848&action=edit [SIGNED OFF] Bug 14107: Patron cards: Make barcode width and height scaling editable The size of the barcode in patron card creator was hardcoded to 1% of the card height and 80% of the card width. This patch exposes both values in the layout editor. If no values are given, the previousely hard coded values (0.01 / 0.8) are used in order to work with existing card definitions. To test: - Go to Home > Tools > Patron card creator - Export a patron card (PDF) from en existing definition - Apply patch - Export patron card again, compare results (should be the same) - Go to Home > Tools > Patron card creator > Manage card layouts - Edit the layout you use for testing and set barcode scaling values e.g. to 0.03 for height and 0.4 for widht - Export patron card again, verify that barcode size changed Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:09:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:09:59 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 --- Comment #13 from Marc V?ron --- (In reply to Chris Nighswonger from comment #11) > Marc, would it be possible for you to add this to the label tool as well? Chris, I think so. Can you open a separate Bug for the label tool and put me on the cc? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:13:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:13:12 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35677|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall --- Created attachment 38849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38849&action=edit Bug 10877 - Add "Order Record" processing Order Record Processing will allow a library to stage an "order record" file which is a standard marc file with some additional information in it about how to create items automatically ( quantity, itemtype, etc ). The location of these fields is defined in the system preference MarcFieldsToOrder from bug 7180. The workflow is thus: 1) A librarian uploads an "order record" file, and marks the batch as an order file during the staging process. 2) The librarian selects an acquisitions basket and chooses "from a staged order file" 3) From here, the librarian can view all the records that will be created, along with quantity and other data ( from bug 7180 ). The librarian will *not* see the item fields, as those are automatically created using the minimum data needed ( branches, itype ). 4) The librarian hits "save" and the items are automatically generated on order. Later ( using features not directly tied to this feature ), the librarian will receive a new marc batch file with items attached ( including itemnumbers ). The vendor will have this information because it was sent via EDI ( bug 7736 ). The librarian will then use the marc record staging feature to overlay those bare bones item records with the full data ( via bug 7131 ). Signed-off-by: Aaron Sakovich -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:15:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:15:35 +0000 Subject: [Koha-bugs] [Bug 14149] New: Labels: Make barcode width and height scaling editable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149 Bug ID: 14149 Summary: Labels: Make barcode width and height scaling editable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: cnighswonger at foundations.edu QA Contact: testopia at bugs.koha-community.org Provide an extension of Bug 14107 to apply to barcodes on label layouts as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:17:24 +0000 Subject: [Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14107 CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:17:24 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14149 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:19:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:19:04 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:19:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:19:06 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 --- Comment #37 from Kyle M Hall --- Created attachment 38850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38850&action=edit Bug 10877 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:26:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:26:00 +0000 Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #1 from Jonathan Druart --- (In reply to Kyle M Hall from comment #0) > In previous versions of Koha, a marc modfication rules like "Copy field > XXX$Y to 952$x" would add the field to an existing 952 field if there was > one already, and only create a 952 field if none existed. Now an entirely > new 952 field is created to store the subfield even if there is already one! Hello Kyle, I would say it's the way it should work. Or maybe should we create a new action and let the choice to the user? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:34:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:34:34 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38802|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:57:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:57:43 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Component|I18N/L10N |Label/patron card printing Assignee|koha-bugs at lists.koha-commun |cnighswonger at foundations.ed |ity.org |u -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 15:58:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 13:58:03 +0000 Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #2 from Gaetan Boisson --- That seems quite tricky. We certainly should let the user decide, but it then becomes quite complicated to take into account all the possibilities. Copying the value to a new 952 subfield sounds like a good default to me, right now i cannot think of a case where the result would be unclear/unexpected. On the other hand copying to an existing field raises the question of what happens when we have multiple such fields in the record. I can think of quite a few options from the top of my head: - Add the subfield to all of the existing fields - Do nothing - Add only to the first such field that exists (probably not a very interesting option...) - Add to the field matching this and this criteria on this other subfield - Create a new field with a subfield having the given value (current behaviour) In the end the process would be something like: If the record has no such field already, choose between: - Create the field with the subfield and the wanted value - Do nothing If the record has exactly one field of this type, choose between: - Add the subfield to the existing field - Create a new field with the subfield and the wanted value - Do nothing If the record has multiple fields of this type, choose between: - Add the subfield to all the existing fields - Create a new field with the subfield and the wanted value - Add to the field matching this and this criteria on this other subfield - Do nothing Else: - Timewarp I feel like this is a bug, since existing templates are not working as they were before. But it seems to me that this action is very unclear in itself and probably deserves some enhancement to let users choose more clearly what will happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 16:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 14:02:03 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38802|0 |1 is obsolete| | Attachment #38831|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 38851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38851&action=edit [SIGNED-OFF]Bug 14128 - Capitalization: Guided Reports - step 2 - Build A Report To verify and test: Go to Home > Reports Click on 'Build new' Verify that the title in Step 1 and to display with correct capitalization Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 16:03:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 14:03:02 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 38852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38852&action=edit [SIGNED-OFF] Bug 14128 - Capitalization: Guided Reports - step 2 - Build A Report Title 'Build a report' should display with all steps The tile displayed only with steps #1 and #2 This patch adds the title to the following steps. To test: Home > Reports Click on 'Build new' Step through steps 1 - 6 Verify that title displays with each step. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 16:24:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 14:24:44 +0000 Subject: [Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 16:24:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 14:24:46 +0000 Subject: [Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 38853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38853&action=edit Bug 14148: marc import broken if plugins are not enabled Bug 12412 introduced a way to use plugins to generate MARC records out of any arbitrary format. But failed to properly check for a valid configuration (plugins_enabled entry on koha-conf.xml, and even the UseKohaPlugins syspref). This patch makes tools/stage-marc-import.pl test for the required configuration before attempting to create the Koha::Plugins object. To test: 1/ Make sure you don't have a plugins_enabled entry on your koha-conf.xml file 2/ On master, browse to tools/stage-marc-import.pl => FAIL: You get a nasty "Can't call method "GetPlugins"..." error 3/ Apply the patch and reload => SUCCESS: Stage MARC for import page renders correctly Repeat with plugins_enabled == 0 and == 1. Also UseKohaPlugins enabled/disabled. It should work as expected. Regards Tomas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 16:45:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 14:45:24 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 --- Comment #1 from Marc V?ron --- Created attachment 38854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38854&action=edit Bug 14138 - Patroncard: POC for pre-testing parameters for create-pdf.pl If wrong parameters are given, create-pdf.pl displays a "Software error" or creates an invalid PDF (it is a text file containing "Software error...."). This patch is a proof of concept with the aim to prevent such a situation. It implements pre-testing the parameters provided for create-pdf.pl. If wrong parameters are given, a error message is displayed instead of creating the PDF. The user has then the possibility to go back to the page she came from. (Patron card tool, maybe later patron's detail page? ) To test: 1) Apply on top of Bug 14122 (otherwise it is not possible to test for borrower) 2) Test with links similar to the following ...cgi-bin/koha/patroncards/create-pdf.pl?borrower_number=61&template_id=24&layout_id=21&start_card=1 or: ...cgi-bin/koha/patroncards/create-pdf.pl?batch_id=8&template_id=24&layout_id=21&start_card=1 3) Change values for existing / not existing Ids. If a parameter is not valid, a new HTML page is displayed with a JavaScript alert. (This will need optimization. Ideas and/or patterns for doing this part are highly welcome). Comments are welcome - is this the way to go? Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 16:47:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 14:47:54 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |veron at veron.ch |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 16:48:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 14:48:24 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14138 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 16:48:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 14:48:24 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14131 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:03 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #1 from David Roberts --- Created attachment 38855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38855&action=edit Add jquery-complexify library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:05 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #2 from David Roberts --- Created attachment 38856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38856&action=edit Added complexify display to opac-passwd page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:08 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #3 from David Roberts --- Created attachment 38857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38857&action=edit Change formatting and correct spelling mistakes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:12 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #5 from David Roberts --- Created attachment 38859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38859&action=edit Add SQL for OPACPasswordStrength syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:10 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #4 from David Roberts --- Created attachment 38858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38858&action=edit Add OPACPasswordStrength syspref to staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:14 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #6 from David Roberts --- Created attachment 38860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38860&action=edit Add default OPACPasswordStrength syspref to updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:16 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #7 from David Roberts --- Created attachment 38861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38861&action=edit Add OPACPasswordStrength System Preference to Auth.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:19 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #8 from David Roberts --- Created attachment 38862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38862&action=edit Put password meter under syspref control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:23 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #10 from David Roberts --- Created attachment 38864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38864&action=edit Add jquery plugins to staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:21 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #9 from David Roberts --- Created attachment 38863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38863&action=edit Add password strength meter to staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:25 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #11 from David Roberts --- Created attachment 38865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38865&action=edit Add complexify includes file to staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:27 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #12 from David Roberts --- Created attachment 38866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38866&action=edit Add new PasswordStrength syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:29 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #13 from David Roberts --- Created attachment 38867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38867&action=edit Add code to updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:34 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #15 from David Roberts --- Created attachment 38869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38869&action=edit Add password strength meter to add and duplicate user in staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 17:57:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 15:57:32 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #14 from David Roberts --- Created attachment 38868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38868&action=edit Put staff client password strength meter under syspref control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 18:09:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 16:09:27 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #16 from David Roberts --- To Test: This patch adds two new system preferences: PasswordStrength which works in the staff client, and OPACPasswordStrength which controls the OPAC. 1) Install patches 2) Enable both system preferences. 3) Log into the OPAC 4) Go to "Change your Password" 5) Type a new password into the new password field - the meter should indicate how strong the password is based on the length of the password and whether or not any part of the password appears in a ban list of some 500 bad passwords (e.g. qwerty, password, 1234 etc) 6) Log into the staff client 7) Create a new patron - the meter should display next to the password field. 8) Check that it also displays when editing or duplicating a patron. Check that typing into the field moves the meter appropriately, and that you are still able to save passwords / edits to the user record when this system preference is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 18:10:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 16:10:44 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 19:03:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 17:03:54 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 38870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38870&action=edit Bug 11057: Bootstrap theme: Don't hide language chooser below the fold This patch removes one attribute from one class on opac.less Generated css files show language changer all the time To test: 1) Update and translate for a anguage of your choice 2) Enable lang on OPAC, also allow opaclanguagesdisplay 3) Go to OPAC, note language changer 'hidden', scroll to view 4) Apply the patch 5) Check you have node.js and lessc (nodejs and node-less packeages) 6) Compile and replace new opac.css lessc --compress koha-tmpl/opac-tmpl/bootstrap/less/opac.less > koha-tmpl/opac-tmpl/bootstrap/css/opac.css 7) Reload OPAC, check language changer is visible without scrolling. 8) Check Advanced search, Authority search, Tag cloud, Login page, etc Language changer must be visible without scroll I do not provide a new opac.css Hope Owen could take a look -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 19:04:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 17:04:14 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 19:58:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 17:58:05 +0000 Subject: [Koha-bugs] [Bug 14150] New: Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 Bug ID: 14150 Summary: Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 38871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38871&action=edit SAMPLE ISSUESLIP (may be used for testing). The field <> will not display in the ISSUESLIP or ISSUEQSLIP notices, when printed inside or tags. Steps to replicate: 1) Go to tools->notices and slips, edit ISSUESLIP for all branches. 2) Put the following text in the EMAIL template: Checked out: Date Due: <> Overdue: Date Due: <> 3) Set the following fields in ISSUESLIP (I don't know that any of these matter) Name: Issue Slip HTML Message: [checked] Message Subject: Issue Slip 4) Check out an item 5) Click Print Issue Slip You will see that the issue slip does not print issues.date_due the same problem affects ISSUEQSLIP. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 5 19:59:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 17:59:23 +0000 Subject: [Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 --- Comment #1 from Barton Chittenden --- Note that items.onloan *will* print correctly; this is an acceptable work-around. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 5 20:19:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 18:19:55 +0000 Subject: [Koha-bugs] [Bug 14151] New: SIP2 Checkouts file in Koha 3.18 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Bug ID: 14151 Summary: SIP2 Checkouts file in Koha 3.18 Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When Bug 12820 was added to Koha 3.18, the namespace was not altered. This causes checkouts to fail via SIP2. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 5 20:21:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 18:21:20 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 20:21:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 18:21:22 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 --- Comment #1 from Kyle M Hall --- Created attachment 38872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38872&action=edit Bug 14151 - SIP2 Checkouts file in Koha 3.18 When Bug 12820 was added to Koha 3.18, the namespace was not altered. This causes checkouts to fail via SIP2. Test Plan: 1) Attempt to check out an item via SIP2 2) Note you never get back a response 3) Apply this patch 4) Repeat step 1 5) Note it now works! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 20:27:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 18:27:02 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 20:34:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 18:34:06 +0000 Subject: [Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38853|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 38873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38873&action=edit [SIGNED.OFF] Bug 14148: marc import broken if plugins are not enabled Bug 12412 introduced a way to use plugins to generate MARC records out of any arbitrary format. But failed to properly check for a valid configuration (plugins_enabled entry on koha-conf.xml, and even the UseKohaPlugins syspref). This patch makes tools/stage-marc-import.pl test for the required configuration before attempting to create the Koha::Plugins object. To test: 1/ Make sure you don't have a plugins_enabled entry on your koha-conf.xml file 2/ On master, browse to tools/stage-marc-import.pl => FAIL: You get a nasty "Can't call method "GetPlugins"..." error 3/ Apply the patch and reload => SUCCESS: Stage MARC for import page renders correctly Repeat with plugins_enabled == 0 and == 1. Also UseKohaPlugins enabled/disabled. It should work as expected. Regards Tomas Signed-off-by: Bernardo Gonzalez Kriegel Works as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 20:34:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 18:34:20 +0000 Subject: [Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 20:43:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 18:43:28 +0000 Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Nicolas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 20:43:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 18:43:55 +0000 Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #17 from Tom?s Cohen Arazi --- Patches pushed to master. Good job Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 20:44:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 18:44:17 +0000 Subject: [Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Fix pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 20:44:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 18:44:59 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks code cleanup monk! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 20:51:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 18:51:02 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #8 from Tom?s Cohen Arazi --- (In reply to Robin Sheat from comment #7) > I've added some patches using quilt that fix the encoding issues. For an > intro to using quilt, go here: > > http://pkg-perl.alioth.debian.org/howto/quilt.html Thanks Robin. Can you point me to some reference docs on how to build the package from source (for testing purposees)? I'm only familiar with dh-make-perl and always used --cpan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:03:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:03:27 +0000 Subject: [Koha-bugs] [Bug 14152] New: Check for required dependencies during upgrades Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 Bug ID: 14152 Summary: Check for required dependencies during upgrades Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: cnighswonger at foundations.edu QA Contact: testopia at bugs.koha-community.org When performing upgrades, the code should re-check for required dependencies. This is particularly important for those installations which are not package-based. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:03:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:03:54 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |cnighswonger at foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:12:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:12:05 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:12:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:12:07 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 --- Comment #1 from Chris Nighswonger --- Created attachment 38874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38874&action=edit Bug 14152: Re-check required dependencies during upgrade process This code causes the installer to re-check dependencies during the upgrade process. Test Plan: 1. Remove a required dependency. (Such as the recently added PDF::FromHTML and associated HTML::Tidy.) 2. Run the installer and note that it does not catch the missing dependency. 3. Also note that things break badly due to the missing dependency. 4. Apply this patch. 5. Under Global System Preferences > Local Use > Version change the dev revision number back one unit and save. 6. The updater will run and catch the missing dependency. 7. Install the missing dependency. 8. Return to the updater and continue with the update. 9. The update should complete successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:12:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:12:46 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14152 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:12:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:12:46 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14103 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:27:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:27:29 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u --- Comment #2 from Chris Nighswonger --- When attempting to create a patron list (running master), I receive an error which states: "An error occurred." See the attached screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:28:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:28:00 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:29:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:29:22 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #3 from Chris Nighswonger --- Created attachment 38875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38875&action=edit Error when attempting to build a patron list This may be a tangential bug not directly related to this enhancement, but I'll wait for confirmation before opening a separate bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:30:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:30:56 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38875|0 |1 is obsolete| | --- Comment #4 from Chris Nighswonger --- Created attachment 38876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38876&action=edit Error when attempting to build a patron list And now the shot with the error showing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:49:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:49:44 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 21:49:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 19:49:46 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38874|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 38877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38877&action=edit Bug 14152: Re-check required dependencies during upgrade process This code causes the installer to re-check dependencies during the upgrade process. Test Plan --------- 1) Log in to staff client 2) Koha Administration -> Global system preferences -> Local 3) Change Version to previous version -- DO NOT HIT SAVE YET! 4) In command line: sudo apt-get purge libpdf-fromhtml-perl NOTE: This could be ANY required library. I chose PDF::FromHTML, because it has been a thorn in my side. 5) NOW! Hit the 'Save' button. 6) Log in, etc. etc... -- Blows up on redirect to log in. 7) In command line, add it back (I had to compile my own so, I used sudo dpkg -i /path/to/libpdf-fromhtml-perl...) 8) Apply patch 9) Edit the C4/Installer/PerlDependencies.pm to make PDF::FromHTML required. See also bug 14103. 10) Log in to staff client 11) Koha Administration -> Global system preferences -> Local 12) Change Version to previous version -- DO NOT HIT SAVE YET! 13) In command line: sudo apt-get purge libpdf-fromhtml-perl 14) NOW! Hit the 'Save' button. 15) Log in, etc. etc... 16) Once warned you are missing it, add it back at the command line. 17) Click 'Recheck' -- Proceeds as expected now. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 22:19:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 20:19:46 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- With libxml-libxslt-perl, there is no kaboom, but somehow it let's you proceed. Once the patch is applied, it is properly caught. Don't let the test case I gave with PDF::FromHTML stop this from passing QA. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 22:39:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 20:39:11 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 --- Comment #4 from Tom?s Cohen Arazi --- Thanks for taking cara of this, Chris. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 22:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 20:42:01 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 --- Comment #5 from M. Tompsett --- (In reply to M. Tompsett from comment #3) > With libxml-libxslt-perl, there is no kaboom, -- the staff client, but OPAC will barf nicely when you try to search for something. > but somehow it lets you proceed. > Once the patch is applied, it is properly caught. YAY! Please Pass QA this. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 22:47:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 20:47:12 +0000 Subject: [Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149 --- Comment #1 from Marc V?ron --- Hi Chris, I'm sorry but it is not as easy as with the patron cards. Reason: Patron cards store the layout values as xml in the table creator_layouts in field layout_xml, while labels store their values in separate columns. This is commented in line 41 of : # FIXME: all layouts should be stored in xml format to greatly simplify handling -chris_n To expose scaling for editing it would be necessary to first move store the values in the xml field. For exsting installations the values of defined labels would have to be transferred to xml as well and after that the obsolete columns could be removed. We would then have the same situation as with patron cards and could implement the scaling editing following the same pattern. Link to schema: http://schema.koha-community.org/tables/creator_layouts.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 5 23:01:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 21:01:44 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #5 from Marc V?ron --- (In reply to Chris Nighswonger from comment #3) > Created attachment 38875 [details] > Error when attempting to build a patron list > > This may be a tangential bug not directly related to this enhancement, but > I'll wait for confirmation before opening a separate bug report. I just re-tested on current master, I could create patron lists from patron search with and without patch. Additonally, this pach does not touch creating of patron lists but uses existing patron lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 01:08:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 23:08:05 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #9 from Robin Sheat --- (In reply to Tom?s Cohen Arazi from comment #8) > Thanks Robin. Can you point me to some reference docs on how to build the > package from source (for testing purposees)? I'm only familiar with > dh-make-perl and always used --cpan. I wrote a getting-started wiki page: http://wiki.koha-community.org/wiki/Building_Debian_Dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 01:53:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 May 2015 23:53:35 +0000 Subject: [Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149 --- Comment #2 from Chris Nighswonger --- (In reply to Marc V?ron from comment #1) > This is commented in line 41 of : > # FIXME: all layouts should be stored in xml format to greatly simplify > handling -chris_n > WOW! Its been a long time since I added that note, but I do remember that appearing to be a much easier method. Thanks for looking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 05:09:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 03:09:50 +0000 Subject: [Koha-bugs] [Bug 11941] "Patron lists" are not easily accessible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 05:09:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 03:09:52 +0000 Subject: [Koha-bugs] [Bug 11941] "Patron lists" are not easily accessible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38598|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 38878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38878&action=edit Bug 11941: Add link to patron lists from the patron home page The patron lists are only accessible from the tools module, which is not easily accessible when you are in the patron module. Test plan: Go on the patron home page. In the toolbar, you should see a link to the patron lists. NOTE: Tweaked button to a to get the click to work. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 05:13:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 03:13:30 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #14 from M. Tompsett --- Bug 14066 passed QA, and I believe Katrin has gotten the remaining tiny pieces we missed all cleaned up. Once pushed to master, this should be resolved/closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 05:15:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 03:15:47 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from M. Tompsett --- Patch added by comment #9 needs sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 05:56:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 03:56:26 +0000 Subject: [Koha-bugs] [Bug 11941] "Patron lists" are not easily accessible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38878|0 |1 is obsolete| | --- Comment #5 from Liz Rea --- Created attachment 38879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38879&action=edit Bug 11941: Add link to patron lists from the patron home page The patron lists are only accessible from the tools module, which is not easily accessible when you are in the patron module. Test plan: Go on the patron home page. In the toolbar, you should see a link to the patron lists. NOTE: Tweaked button to a to get the click to work. Signed-off-by: Mark Tompsett Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 06:46:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 04:46:31 +0000 Subject: [Koha-bugs] [Bug 14153] New: Noisy warns in admin/transport-cost-matrix.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14153 Bug ID: 14153 Summary: Noisy warns in admin/transport-cost-matrix.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com my $update = $input->param('op') eq 'set-cost-matrix'; The above code (line 45) causes a warn 'Use of unintialized value in string eq' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 6 06:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 04:54:08 +0000 Subject: [Koha-bugs] [Bug 14153] Noisy warns in admin/transport-cost-matrix.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14153 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 6 06:54:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 04:54:10 +0000 Subject: [Koha-bugs] [Bug 14153] Noisy warns in admin/transport-cost-matrix.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14153 --- Comment #1 from Aleisha Amohia --- Created attachment 38880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38880&action=edit Bug 14153: Noisy warns in admin/transport-cost-matrix.pl This patch silences the warn by putting curly braces around the $input->param('op') code, to kind of group this as a variable. I don't know that this is the best solution for this but the warn is no longer there. To test: 1) Go to Admin -> Transport cost matrix 2) Notice the warns in the error log 3) Apply the patch and refresh page 4) Notice page still works but no warns in error log -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 6 07:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 05:25:14 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #10 from M. Tompsett --- Created attachment 38881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38881&action=edit Bug 14103 - PDF::FromHTML is conditionally required on UseDischarge systempreference Since this is only in generate_as_pdf of Koha::Borrowers::Discharge, it made sense to change it from a use to a require (avoiding a compile time error), and placing it inside the eval where the PDF is generated, thus capturing the problem in the koha error log. TEST PLAN --------- 1) Log in to staff client 2) Koha Administration -> Global system preferences -> Local Use 3) Lower the Version number by 1, but DO NOT CLICK SAVE. 4) At the command line, sudo apt-get purge libpdf-fromhtml-perl 5) Back in the staff client, click save. 6) Every looks great until you attempt to log in. KABOOM! 7) Apply patch 8) Log in to staff client -- YAY! 9) Koha Administration -> Global system preferences -> Patrons 10) Make use the useDischarge is set to Allow 11) Find a patron with nothing checked out. 12) There is now a Discharge tab on the left at the bottom. 13) Click the 'Generate Discharge' button. -- nice error message -- check koha error log file for the ugly @INC missing message 14) At the command line, reinstall PDF::FromHTML (I built my own with cpan2deb: sudo dpkg -i /path/to/libpdf-fromhtml-perl_...) 15) In the staff client, click the 'Generate Discharge' button again. -- PDF is created as expected. All is well. 16) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 07:26:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 05:26:42 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #11 from M. Tompsett --- I have provided a counter patch, which I think is better. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 09:11:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 07:11:44 +0000 Subject: [Koha-bugs] [Bug 14154] New: 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 Bug ID: 14154 Summary: 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In DOM config file : etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml, the 608$9 is defined a second time instead of 610$9. Just a type I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 10:36:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 08:36:14 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 --- Comment #1 from Fridolin SOMERS --- Created attachment 38882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38882&action=edit Bug 14154 - 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In DOM config file : etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml, the 608$9 is defined a second time instead of 610$9. Just a type I think. Test plan : - Apply patch - Install a UNIMARC + DOM instance - Define in a framework 610 using a thesaurus - Create a new biblio - Create a new authority (same type as the thesaurus defined above) - Index : rebuild_zebra.pl -a -b -x -z - Link the field 610 to the new authority - Index : rebuild_zebra.pl -a -b -x -z - In authorities search, search for the new authority => You see Use in 1 Records(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 10:36:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 08:36:12 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 11:39:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 09:39:08 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 11:48:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 09:48:20 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #12 from Chris Nighswonger --- (In reply to M. Tompsett from comment #11) > I have provided a counter patch, which I think is better. :) +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 12:18:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 10:18:34 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 12:21:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 10:21:20 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #13 from Fridolin SOMERS --- (In reply to M. Tompsett from comment #11) > I have provided a counter patch, which I think is better. :) +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 12:23:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 10:23:36 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #14 from Fridolin SOMERS --- Do you think that UT t/db_dependent/Borrower_Discharge.t will not be able to validate this patch ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 12:36:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 10:36:04 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #15 from Chris Nighswonger --- (In reply to Fridolin SOMERS from comment #14) > Do you think that UT t/db_dependent/Borrower_Discharge.t will not be able to > validate this patch ? cnighswonger at cnighswonger-dt:~/Repositories/koha.dev (bugs/bug_14103)$ prove t/db_dependent/Borrower_Discharge.t t/db_dependent/Borrower_Discharge.t .. SELECT COUNT( * ) FROM borrowers me WHERE ( userid = ? ): 'myfirstname.mysurname' SELECT me.categorycode, me.description, me.enrolmentperiod, me.enrolmentperioddate, me.upperagelimit, me.dateofbirthrequired, me.finetype, me.bulk, me.enrolmentfee, me.overduenoticerequired, me.issuelimit, me.reservefee, me.hidelostitems, me.category_type, me.BlockExpiredPatronOpacActions, me.default_privacy FROM categories me WHERE ( me.categorycode = ? ): 'S' INSERT INTO issues ( auto_renew, borrowernumber, branchcode, date_due, issuedate, itemnumber, onsite_checkout) VALUES ( ?, ?, ?, ?, ?, ?, ? ): '0', '51', 'CPL', '2015-05-27 23:59:00', '2015-05-06 06:35:37', '1', '0' t/db_dependent/Borrower_Discharge.t .. 1/? SELECT me.borrower, me.needed, me.validated FROM discharges me WHERE ( ( me.needed IS NOT NULL AND me.validated IS NULL ) ): t/db_dependent/Borrower_Discharge.t .. ok All tests successful. Files=1, Tests=5, 13 wallclock secs ( 0.02 usr 0.02 sys + 1.74 cusr 0.22 csys = 2.00 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 12:38:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 10:38:11 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 12:38:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 10:38:13 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38881|0 |1 is obsolete| | --- Comment #16 from Chris Nighswonger --- Created attachment 38883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38883&action=edit [SIGNED OFF] Bug 14103: PDF::FromHTML is conditionally required on UseDischarge systempreference Since this is only in generate_as_pdf of Koha::Borrowers::Discharge, it made sense to change it from a use to a require (avoiding a compile time error), and placing it inside the eval where the PDF is generated, thus capturing the problem in the koha error log. TEST PLAN --------- 1) Log in to staff client 2) Koha Administration -> Global system preferences -> Local Use 3) Lower the Version number by 1, but DO NOT CLICK SAVE. 4) At the command line, sudo apt-get purge libpdf-fromhtml-perl 5) Back in the staff client, click save. 6) Every looks great until you attempt to log in. KABOOM! 7) Apply patch 8) Log in to staff client -- YAY! 9) Koha Administration -> Global system preferences -> Patrons 10) Make use the useDischarge is set to Allow 11) Find a patron with nothing checked out. 12) There is now a Discharge tab on the left at the bottom. 13) Click the 'Generate Discharge' button. -- nice error message -- check koha error log file for the ugly @INC missing message 14) At the command line, reinstall PDF::FromHTML (I built my own with cpan2deb: sudo dpkg -i /path/to/libpdf-fromhtml-perl_...) 15) In the staff client, click the 'Generate Discharge' button again. -- PDF is created as expected. All is well. 16) run koha qa test tools. Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 12:43:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 10:43:59 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #17 from Chris Nighswonger --- (In reply to Chris Nighswonger from comment #15) > (In reply to Fridolin SOMERS from comment #14) > > Do you think that UT t/db_dependent/Borrower_Discharge.t will not be able to > > validate this patch ? > > cnighswonger at cnighswonger-dt:~/Repositories/koha.dev (bugs/bug_14103)$ prove > t/db_dependent/Borrower_Discharge.t Opps. I just realized that this test does not appear to test the sub in question. I'll be out today, but will look at adding a test for it if no one gets to it before I get back. FTR, I still support this second fix over the first. Keeping required deps to a minimum should be a priority for us. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 13:21:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 11:21:15 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #18 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #17) > Marcel, can you check Kyle's last comment? I still have some doubts if we should consider this to be outside the scope of this report. Maybe another QAer can have a look too. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 14:43:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 12:43:59 +0000 Subject: [Koha-bugs] [Bug 14155] New: Placing holds via ILSDI bypass some checks Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Bug ID: 14155 Summary: Placing holds via ILSDI bypass some checks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you make a hold request using ILSDI webservices (HoldItem or HoldTitle) 2 important checks are skipped while they are done using staff user interface. 1) maxreserves system preference is ignored so you can place as many hold as issuingrules allow you even if maxreserves is set. 2) nothing checks if the borrower already reserved the biblio. Patch is coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:03:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:03:04 +0000 Subject: [Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | CC| |alex.arnaud at biblibre.com Status|NEW |Needs Signoff --- Comment #1 from Alex Arnaud --- Created attachment 38884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38884&action=edit Add maxreserves and alreadyreserved checks when placing hold via ILSDI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:03:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:03:53 +0000 Subject: [Koha-bugs] [Bug 14139] Koha showing 1 264 and it's not the first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14139 --- Comment #1 from Nicole C. Engard --- Created attachment 38885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38885&action=edit normal display in staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:04:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:04:06 +0000 Subject: [Koha-bugs] [Bug 14139] Koha showing 1 264 and it's not the first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14139 --- Comment #2 from Nicole C. Engard --- Created attachment 38886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38886&action=edit marc display in staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:25:39 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #8 from Katrin Fischer --- This is growing into a bigger problem - we also got a report of the same phenomenon in acquisitions now when cancelling an order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:32:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:32:35 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #26 from Kyle M Hall --- (In reply to Robin Sheat from comment #19) > (In reply to Julian Maurice from comment #18) > > Anyway, Jessie will become the new stable in few days. Should we just wait > > before integrating this ? > > We'd be waiting for a year or three, we're only dropping squeeze support as > at 3.20. With 3.20 around the corner is this really an issue? It just means that it wouldn't be backportable to earlier versions of Koha, correct? Considering this is an enhancement I wouldn't expect it to be backported anyway. Are there other considerations I'm missing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:36:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:36:48 +0000 Subject: [Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:39:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:39:16 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #27 from Kyle M Hall --- (In reply to Julian Maurice from comment #25) > (In reply to Chris Cormack from comment #24) > > Regardless of the packages, I think this should be split into a bunch of > > bugs, certainly shifting the documentation one off on to its on thing. I > > don't think we need to build any front end stuff for this. If we do that > > should be on it's on bug also. > > To get something like this in, its much better to do what was done with the > > acquisitions work, seperate bugs that don't mean the entire thing has to > > pass at once. > > I disagree. The "front end stuff" is the API documentation, and I don't > think we can integrate the new API without a proper documentation. I would tend to agree with Julian on this. The documentation is part and parcel of the api. I don't see any advantage to splitting it into a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:42:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:42:52 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #18 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:43:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:43:24 +0000 Subject: [Koha-bugs] [Bug 14126] Typo on order receive page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14126 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. ?Gracias Hector! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:43:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:43:57 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:44:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:44:19 +0000 Subject: [Koha-bugs] [Bug 14127] Typo in message preference form - "mesage" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:44:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:44:48 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:45:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:45:17 +0000 Subject: [Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tom?s Cohen Arazi --- Patches pushed to master. Good job Bernardo and Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:45:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:45:55 +0000 Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Great improvement Bernardo. Thanks! Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:46:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:46:20 +0000 Subject: [Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:47:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:47:13 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #21 from Tom?s Cohen Arazi --- Delightfully pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 15:47:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 13:47:28 +0000 Subject: [Koha-bugs] [Bug 14156] New: add id tags to each marc note in the display Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 Bug ID: 14156 Summary: add id tags to each marc note in the display Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Add ID tags to each note in the title notes tab. So here's a sample of the HTML:

    Antonio Chavarrias

    Tristan Ulloa, Unax Ugalde

    The great virtue in this film is the persistent sense that something pretty bad is on it's way.

    Instead each p should have and ID of the MARC tag that note came from so it can be styled if need be.

    Antonio Chavarrias

    Tristan Ulloa, Unax Ugalde

    The great virtue in this film is the persistent sense that something pretty bad is on it's way.

    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 16:17:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 14:17:04 +0000 Subject: [Koha-bugs] [Bug 14157] New: EnhancedMessagingPreferences and Notices tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157 Bug ID: 14157 Summary: EnhancedMessagingPreferences and Notices tab Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you ?Don?t Allow? the EnhancedMessagingPreferences then staff looses the ?notice? tab in the patron record and they can?t see information about overdue notices being sent. So if you don?t want patrons to choose enhanced messages you can?t track the sending of overdue notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 16:32:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 14:32:45 +0000 Subject: [Koha-bugs] [Bug 7591] deleting an issue from an expired subscription generates next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7591 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 16:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 14:42:40 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #28 from Kyle M Hall --- (In reply to Kyle M Hall from comment #26) > (In reply to Robin Sheat from comment #19) > > (In reply to Julian Maurice from comment #18) > > > Anyway, Jessie will become the new stable in few days. Should we just wait > > > before integrating this ? > > > > We'd be waiting for a year or three, we're only dropping squeeze support as > > at 3.20. > > With 3.20 around the corner is this really an issue? It just means that it > wouldn't be backportable to earlier versions of Koha, correct? Considering > this is an enhancement I wouldn't expect it to be backported anyway. Are > there other considerations I'm missing? Ignore this comment, I had my versions crossed. Any idea what the possibility of taking the package for Jesse and using it on Wheezy is? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 16:44:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 14:44:08 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #29 from Kyle M Hall --- Another idea, can't we have a temporary package for Mojo even if it's not proper for upstreaming? Once the debian mojo package hit's the right version we could remove our own package. Would that work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 16:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 14:48:23 +0000 Subject: [Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 16:51:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 14:51:46 +0000 Subject: [Koha-bugs] [Bug 14148] stage-marc-import.pl broken if plugins not enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 12412 breaks import if |stage-marc-import.pl broken |plugins are not enabled |if plugins not enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 17:03:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 15:03:37 +0000 Subject: [Koha-bugs] [Bug 14158] New: t/db_dependent/www/search_utf8.t hangs if error is returned Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14158 Bug ID: 14158 Summary: t/db_dependent/www/search_utf8.t hangs if error is returned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com There is currently a bug with the stage-marc-import.pl when the plugins are disabled. It raises a "Internal server error" page. I noticed that Koha_Master_U14 (the task on jenkins that runs the mentioned test) just hangs waiting for output of the test. This should be fixed. To reproduce: - Checkout 4e0468e8c2587fa4f51cb22b59ac5466383bbab1 (a commit without the fix for the specific problem that raises the test problem). - Set the environment for running the test: export KOHA_USER=kohaadmin export KOHA_PASS=katikoan export KOHA_INTRANET_URL="" export KOHA_OPAC_URL="" - Run the test: prove t/db_dependent/www/search_utf8.t => FAIL: You will see something like this on the output while the test just hangs: t/db_dependent/www/search_utf8.t .. 3/64 Error GETing http://koha-dev.biblioadmin/cgi-bin/koha/tools/stage-marc-import.pl: Internal Server Error at t/db_dependent/www/search_utf8.t line 127. # Looks like you planned 64 tests but ran 4. # Looks like your test exited with 255 just after 4. and the prompt is not released. At all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 17:08:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 15:08:03 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #61 from Tom?s Cohen Arazi --- Can someone rebase this one ASAP? I'm sorry... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 17:09:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 15:09:31 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #20 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 17:10:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 15:10:08 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #60 from Tom?s Cohen Arazi --- Feature pushed to master. Thanks Simith! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 17:16:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 15:16:20 +0000 Subject: [Koha-bugs] [Bug 14148] stage-marc-import.pl broken if plugins not enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 17:16:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 15:16:23 +0000 Subject: [Koha-bugs] [Bug 14148] stage-marc-import.pl broken if plugins not enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38873|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 38887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38887&action=edit [PASSED QA] Bug 14148: marc import broken if plugins are not enabled Bug 12412 introduced a way to use plugins to generate MARC records out of any arbitrary format. But failed to properly check for a valid configuration (plugins_enabled entry on koha-conf.xml, and even the UseKohaPlugins syspref). This patch makes tools/stage-marc-import.pl test for the required configuration before attempting to create the Koha::Plugins object. To test: 1/ Make sure you don't have a plugins_enabled entry on your koha-conf.xml file 2/ On master, browse to tools/stage-marc-import.pl => FAIL: You get a nasty "Can't call method "GetPlugins"..." error 3/ Apply the patch and reload => SUCCESS: Stage MARC for import page renders correctly Repeat with plugins_enabled == 0 and == 1. Also UseKohaPlugins enabled/disabled. It should work as expected. Regards Tomas Signed-off-by: Bernardo Gonzalez Kriegel Works as described, no koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 17:19:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 15:19:30 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #15 from M. Tompsett --- This was properly fixed and pushed to master by bug 14066. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 17:32:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 15:32:59 +0000 Subject: [Koha-bugs] [Bug 14159] New: history only showing up to 2014 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14159 Bug ID: 14159 Summary: history only showing up to 2014 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org When you go to about koha and click timeline you only see up to 12/24/14 - but if you look at the doc it does have entries for 2015. I don't see any errors, but something is causing it to not show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 17:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 15:45:39 +0000 Subject: [Koha-bugs] [Bug 14148] stage-marc-import.pl broken if plugins not enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 17:46:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 15:46:18 +0000 Subject: [Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #15 from Pablo AB --- *** Bug 12213 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 6 17:46:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 15:46:17 +0000 Subject: [Koha-bugs] [Bug 12213] Creating a report with unnamed report group shows strange "disconnected" tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12213 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |pablo.bianchi at gmail.com Status|NEW |RESOLVED --- Comment #2 from Pablo AB --- *** This bug has been marked as a duplicate of bug 2969 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 18:49:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 16:49:39 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #70 from Nicole C. Engard --- I'm documenting this now and want to ask what sudoc we're talking about. In the US Sudoc is a government document number - I assume we're talking about a French example. Is this unimarc only? If not can you attach a marc record for me to import to my test system and document this feature with? Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 18:54:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 16:54:49 +0000 Subject: [Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 18:56:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 16:56:32 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #71 from Nicole C. Engard --- Tom?s says it's unimarc + french specific - so I'm wondering if I could have some screenshots and a bit of documentation for the manual on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 18:57:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 16:57:14 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37178|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 38888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38888&action=edit [SIGNED-OFF] Bug 13899: Adding misc/devel/coverage.pl It's a script making a cover on all modules to see which ones are not tested yet. It uses Devel::Cover Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 18:57:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 16:57:22 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37905|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 38889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38889&action=edit [SIGNED-OFF] Bug 13899: Add changes as asked in Comment 5 Signed-off-by: Bernardo Gonzalez Kriegel Fixed a small conflict on PerlDependencies.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 18:57:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 16:57:31 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38530|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 38890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38890&action=edit [SIGNED-OFF] Bug 13899: Changing license to GPLv3 koha-qa should be good : OK misc/devel/coverage.pl OK critic OK forbidden patterns OK pod OK valid OK C4/Installer/PerlDependencies.pm OK critic OK forbidden patterns OK pod OK valid Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors. Test plan not explicitly stated, script run and generates a lot of data :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 18:57:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 16:57:48 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 18:57:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 16:57:48 +0000 Subject: [Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:03:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:03:36 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38544|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 38891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38891&action=edit [SIGNED-OFF] Bug 11576: Make "manage" translatable - serials-collection If a subscription is irregular, a tab with "manage" is displayed on the serial collection page. But this string is not translatable. Test plan: 1/ Go on the serial collection page of an irregular subscription (or create one). 2/ Note that the first tab was named "managed", it's now "Manage". 3/ Update a po lang file and confirm you see the string and you are able to translate it. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:03:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:03:48 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:05:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:05:47 +0000 Subject: [Koha-bugs] [Bug 14160] New: typo in AddressFormat preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Bug ID: 14160 Summary: typo in AddressFormat preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org there is a missing d in address. patch coming -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:06:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:06:19 +0000 Subject: [Koha-bugs] [Bug 14124] Add 'Unimarc only' note to IdRef system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14124 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 38892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38892&action=edit Bug 14124: Add 'Unimarc only' note to IdRef system preference This patch adds a note to the IdRef service syspref making it clear that the feature is only available for UNIMARC setups. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:06:17 +0000 Subject: [Koha-bugs] [Bug 14124] Add 'Unimarc only' note to IdRef system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14124 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:09:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:09:14 +0000 Subject: [Koha-bugs] [Bug 14160] typo in AddressFormat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:09:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:09:15 +0000 Subject: [Koha-bugs] [Bug 14160] typo in AddressFormat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 --- Comment #1 from Nicole C. Engard --- Created attachment 38893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38893&action=edit Bug 14160: Fix typo in AddressFormat preference The preference was missing a 'd' in the word address. To test: * Visit preferences * Visit I18N/L10N tab * Confirm spelling of options in Addressformat preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:21:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:21:08 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #61 from Tom?s Cohen Arazi --- Created attachment 38894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38894&action=edit Bug 13364: (QA followup) missing id and class Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:28:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:28:41 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Attachment #38612|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:34:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:34:32 +0000 Subject: [Koha-bugs] [Bug 14129] templates.readme is outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:34:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:34:57 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:35:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:35:21 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:36:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:36:41 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37619|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 38895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38895&action=edit [SIGNED-OFF] Bug 9892: Make export_borrowers.pl using the delimiter pref The original concern of bug 9892 was that this borrowers export script cannot handle tabulation to separate columns. With this patch, the delimiter preference is used as separator for the output, to be consistent with others scripts. This should be highlighted on the release, it can produce change in behaviors. Test plan: Confirm that the 'delimiter' pref is used for the output, but you are able to overwrite it with the 'separator' parameter Signed-off-by: Bernardo Gonzalez Kriegel Works as expected, respect preference but is supeseeded by cmd line No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:36:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:36:44 +0000 Subject: [Koha-bugs] [Bug 14161] New: highlighting on edit line not always there Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14161 Bug ID: 14161 Summary: highlighting on edit line not always there Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl See : http://screencast.com/t/Hz9cKsc6LL If you click 'edit' on the holding table to edit an item the line you're editing is highlighted in yellow, but if you click edit from the item items page the line is not highlighted in yellow anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:36:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:36:54 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:40:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:40:25 +0000 Subject: [Koha-bugs] [Bug 14160] typo in AddressFormat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38893|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 38896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38896&action=edit [SIGNED-OFF] Bug 14160: Fix typo in AddressFormat preference The preference was missing a 'd' in the word address. To test: * Visit preferences * Visit I18N/L10N tab * Confirm spelling of options in Addressformat preference Signed-off-by: Bernardo Gonzalez Kriegel Spelling is right, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:40:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:40:37 +0000 Subject: [Koha-bugs] [Bug 14160] typo in AddressFormat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:48:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:48:57 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37618|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 38897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38897&action=edit [SIGNED-OFF] Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% Signed-off-by: Bernardo Gonzalez Kriegel All tests run -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:49:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:49:04 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37820|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 38898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38898&action=edit [SIGNED-OFF] Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:49:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:49:21 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:51:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:51:11 +0000 Subject: [Koha-bugs] [Bug 14162] New: Instance creation information on YAML Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162 Bug ID: 14162 Summary: Instance creation information on YAML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org It would be handy to have information about instance creation on a YAML file. It could serve for recreating an instance, for creating it, etc. It would serve as an instance registry that could be used by the maintenance scripts to gather information too. For example: if you choose to configure --zebra-lang fr on creation, and we had such a registry, we could be able to make the right decision on upgrades, to also populate the instance with the right files too. It is just an example of course. Another example: everytime an entry is added to koha-conf.xml, we could have the information to re-create the koha-conf.xml file with the rigt options too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:52:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:52:56 +0000 Subject: [Koha-bugs] [Bug 14162] Instance creation information on YAML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:54:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:54:27 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 19:55:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 17:55:13 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #18 from H?ctor Eduardo Castro Avalos --- (In reply to Chris Nighswonger from comment #17) > FTR, I still support this second fix over the first. Keeping required deps > to a minimum should be a priority for us. I totally agree with you, please when send the another patch for unit test do obsolete the first one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 20:12:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 18:12:09 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eskaaren at yahoo.no --- Comment #10 from Eivin Giske Skaaren --- I get this when trying to apply the patch to an up to date branch: pplying: Bug 12769 - Notice fee management fatal: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12769 - Notice fee management Is there any dependency not listed or perhaps the patch must be rebased? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 20:27:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 18:27:20 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 20:28:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 18:28:57 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 20:29:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 18:29:00 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #19 from M. Tompsett --- Created attachment 38899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38899&action=edit Bug 14103 - Improved testing coverage As per Chris' comment #17, this improves the testing coverage. Same test plan as comment #16, but add: TEST PLAN SUPPLEMENT -------------------- 1) $ prove -v t/db_dependent/Borrower_Discharge.t -- notice only 5 tests, and generate_as_pdf not tested. 2) Apply this patch. 3) Retest as per comment #16 -- this will test the error and no error cases tweaked in Koha/Borrower/Discharge.pm 4) remove PDF::HTML $ sudo apt-get purge libpdf-fromhtml-perl 5) $ prove -v t/db_dependent/Borrower_Discharge.t -- 7 tests, all successful 6) add PDF::HTML $ sudo dpkg -i /path/to/libpdf-fromhtml-perl... -- depends on how you get it. vary accordingly. 7) $ prove -v t/db_dependent/Borrower_Discharge.t -- 7 tests, all successful -- Note that is was a different 7th test. :) 8) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 20:29:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 18:29:01 +0000 Subject: [Koha-bugs] [Bug 14018] Ordering from suggestion shows 'copy. year:2014' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 20:30:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 18:30:24 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38837|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Comment on attachment 38837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38837 Bug 14103 - Discharge management: Software error on main page after upgrade I am obsoleting the first one. Please follow the test plans in comment #16 and comment #19. :) Enjoy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 20:39:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 18:39:00 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37944|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 38900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38900&action=edit [SIGNED-OFF] Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. Signed-off-by: Bernardo Gonzalez Kriegel Moved updatedatabase entry (was in wrong position) to atomicupdate with commented copy of orignal No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 20:40:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 18:40:27 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 20:41:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 18:41:48 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38900|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 38901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38901&action=edit [SIGNED-OFF] Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. Signed-off-by: Bernardo Gonzalez Kriegel Moved updatedatabase entry (was in wrong position) to atomicupdate with commented copy of orignal No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 20:53:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 18:53:36 +0000 Subject: [Koha-bugs] [Bug 13591] Rss sample templates have hardcoded urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 --- Comment #2 from Eivin Giske Skaaren --- Created attachment 38902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38902&action=edit Bug 13591 Pass OPACBaseURL to rss creation process Links in rss templates were hardcoded to library.org.nz. Should pass and use the system's OPACBaseURL. Tested and verified. Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 21:01:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 19:01:18 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #30 from Chris Cormack --- This feels like making work for users and package maintainers, to make something arguably easier for developers. This is something that has made a mess for us a lot in the past. However, we probably should not be worrying about this, as it's missed the window for 3.20 already and be expending energy on testing and fixing bugs. We can argue about adding unnessecary dependencies again after the release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 21:44:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 19:44:51 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- This is not an enhancement. It's a bug fix, since Free should have been there in the first place. This is not adding anything new (another type) that wasn't there before, nor is it brand new functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 21:46:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 19:46:04 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |indradg at gmail.com --- Comment #3 from M. Tompsett --- Obviously, Indranil Das Gupta is the bug taker, not Owen Leonard. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 21:51:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 19:51:07 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 21:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 19:51:09 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38816|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 38903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38903&action=edit Bug 14135 Adds 'Free' to variabletypes in systempreferences.tt The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or There is no option presented for "Free" which seems to be the most used variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime) This trivial patch proposes to modify the systempreferences.tt and add the option 'Free' to the list offered to users. Test Plan ========= 1/ Go to Home > Administration > System preferences > Local use 2/ Click on 'New preference'. 3/ In the fieldset 'Koha Internal', the variable types offered are Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources. 4/ Clicking on 'Choice' should set the 'preftype' field as 'Choice'. 5/ Apply this patch. 6/ Refresh the page. 7/ The variable types list should read - "Free, Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources". 8/ Clicking on 'Free' should set the 'preftype' field as 'Free'. Signed-off-by: Mark Tompsett NOTE: Discovered that there is no validation on the type field. However, that is beyond the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 21:53:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 19:53:52 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 21:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 19:55:35 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #5 from Indranil Das Gupta --- (In reply to M. Tompsett from comment #3) > Obviously, Indranil Das Gupta is the bug taker, not Owen Leonard. :) Ack! thanks for the cluebat! :P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 21:57:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 19:57:10 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #1) > Test plan: > 1/ Define RESERVESLIP with, at least, > Hold until: <> On current master RESERVESLIP belongs to 'circulation' module, on edit there is no access to 'reserves' values. If you change first to 'Holds' module, and save, then you can access 'reserves' values. Could be this the cause of the problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:00:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:00:35 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Discharge management: |PDF::FromHTML headaches |Software error on main page |related to optional |after upgrade - Missing |discharging. |dependencies on About page | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:01:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:01:25 +0000 Subject: [Koha-bugs] [Bug 14113] Silence warnings t/Date.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38754|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 38904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38904&action=edit [SIGNED-OFF] Bug 14113: Silence t/Dates.t warnings and cleanup output. The expectation of a user not freaking out over 'Illegal date' messages is not sensible. Catch the messages, give a nicer message. Also, compress the veritical spacing on the output. TEST PLAN --------- 1) $ prove t/Dates.t -- notice Illegal date messages, and extra lines between some sectional messages. 2) Apply patch 3) $ prove t/Dates.t -- Notice how nice and clean it is? Try it with -v to see all the warnings, including the expected warning type messages. 4) run koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel Tests run, cleaner output, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:01:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:01:35 +0000 Subject: [Koha-bugs] [Bug 14113] Silence warnings t/Date.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:04:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:04:46 +0000 Subject: [Koha-bugs] [Bug 14114] Silence warnings t/Debug.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14114 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38755|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 38905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38905&action=edit [SIGNED-OFF] Bug 14114: Silence warns and cleanup t/Debug.t TEST PLAN --------- 1) $ prove t/Debug.t -- What's with this BEFORE and AFTER stuff?! 2) apply patch 3) $ prove t/Debug.t -- cleaner, and you only get fuller output with -v. 4) koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel Cleaner, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:04:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:04:57 +0000 Subject: [Koha-bugs] [Bug 14114] Silence warnings t/Debug.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14114 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:10:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:10:15 +0000 Subject: [Koha-bugs] [Bug 14116] Silence noise t/Scrubber.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38757|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 38906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38906&action=edit [SIGNED-OFF] Bug 14116: Silence noisy output for t/Scrubber. Some diag's are better suited as prints. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel Works, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:10:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:10:30 +0000 Subject: [Koha-bugs] [Bug 14116] Silence noise t/Scrubber.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:15:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:15:45 +0000 Subject: [Koha-bugs] [Bug 14115] Silence warnings t/Label* In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14115 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38756|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 38907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38907&action=edit [SIGNED-OFF] Bug 14115: Silence warnings in t/Label* Two functions were triggering noisy warnings while testing: _get_text_fields and _split_lccn. TEST PLAN ---------- 1) $ prove t/Label* -- several warnings 2) apply patch 3) $ prove t/Label* -- no warnings 4) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel Nicer, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:15:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:15:58 +0000 Subject: [Koha-bugs] [Bug 14115] Silence warnings t/Label* In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14115 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:23:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:23:56 +0000 Subject: [Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:47:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:47:17 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36677|0 |1 is obsolete| | --- Comment #39 from M. Tompsett --- Created attachment 38908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38908&action=edit Bug 1985 - Email notification of new OPAC comments This feature adds YAS 'CommentModeratorsEmail', where an email (template code COMMENT_CREATED) is sent when a borrower creates/modifies an comment/review. The syspref is empty by default and no email is sent when the syspref is empty. This feature is needed because we want to alert our content moderators to take action when needed. Usually it is our librarians who write reviews and this improvement makes the process of moving Koha reviews to our CMS more smooth. TEST SETUP: -1. Run updatedatabase.pl to add the syspref and the new letter template. 0. Go to admin/preferences.pl?tab=opac, and set the 'CommentModeratorsEmail'-syspref to your email-address. TEST PLAN: 1. Log in to OPAC and find any Biblio. 2. Make a comment/review for it. 3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'. You should see the reasonable default message. You can change the message in tools/letter.pl. NOTE: Tested in conjunction with my patch. However, this piece alone: - lacked unit tests since it modified C4/Review.pm - failed to provide the desired links in the email message, as mentioned in comment #1. - failed to pass biblionumber information for use in the letter as mentioned in comment #11. - passed $review, when it was really id that should have been passed and used to implement the inclusion of reviews.reviewid and other reviews table fields. Signed-off-by: Mark Tompsett Signed-off-by: sonia bouis Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:47:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:47:33 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36678|0 |1 is obsolete| | --- Comment #40 from M. Tompsett --- Created attachment 38909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38909&action=edit Bug 1985 - tweak License and lots of cleanup In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <> is now usable in the letter, as is <>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Review.t 7) Run the koha qa test tool. Signed-off-by: Mark Tompsett Signed-off-by: sonia bouis Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 22:47:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 20:47:43 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36720|0 |1 is obsolete| | --- Comment #41 from M. Tompsett --- Created attachment 38910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38910&action=edit Bug 1985 - Follow up: Add sample letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:00:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:00:04 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #42 from M. Tompsett --- This is a rebase. The last patch (Follow up: Add sample letter to other languages) is what addresses Kyle's comment #36. The first two patches have passed QA, the last one needs sign off. prove xt/sample_notices.t might be in order too. :) If there is a failure, check if bug 14119 has been applied, since I discovered a problem elsewhere. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:12:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:12:39 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37696|0 |1 is obsolete| | --- Comment #300 from M. Tompsett --- Created attachment 38911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38911&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:12:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:12:49 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37697|0 |1 is obsolete| | --- Comment #301 from M. Tompsett --- Created attachment 38912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38912&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:12:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:12:58 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37698|0 |1 is obsolete| | --- Comment #302 from M. Tompsett --- Created attachment 38913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38913&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:13:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:13:06 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37699|0 |1 is obsolete| | --- Comment #303 from M. Tompsett --- Created attachment 38914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38914&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:13:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:13:14 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37700|0 |1 is obsolete| | --- Comment #304 from M. Tompsett --- Created attachment 38915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38915&action=edit Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:13:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:13:22 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37701|0 |1 is obsolete| | --- Comment #305 from M. Tompsett --- Created attachment 38916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38916&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:13:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:13:31 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37702|0 |1 is obsolete| | --- Comment #306 from M. Tompsett --- Created attachment 38917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38917&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:13:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:13:41 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37703|0 |1 is obsolete| | --- Comment #307 from M. Tompsett --- Created attachment 38918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38918&action=edit Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN --------- 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:13:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:13:54 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37704|0 |1 is obsolete| | --- Comment #308 from M. Tompsett --- Created attachment 38919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38919&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, in that the protocol is assumed in the OpacBaseURL system preference. It also adds improved error handling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:14:06 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37705|0 |1 is obsolete| | --- Comment #309 from M. Tompsett --- Created attachment 38920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38920&action=edit Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:14:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:14:18 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37706|0 |1 is obsolete| | --- Comment #310 from M. Tompsett --- Created attachment 38921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38921&action=edit Bug 6874: Catch warnings for clean tests. I hate noisy tests, so I cleaned them up. MEGA TEST PLAN -------------- git checkout -b bug_6874 origin/master git bz apply 6874 -- yes, it should all apply smoothly. I intentionally restored an old backup from a couple months ago to force the upgrade. staff client: -- upgrade -- login Koha administration MARC Bibliographic framework MARC structure (for BKS) Search for 856 Subfields Edit (for u) Other options Plugin: upload.pl Save changes Search the catalog tab {choose a word, any word. I used fancy, because I knew we had a cookbook} click first link Edit Edit record 8 (that's the tab name) click the name for 856 scroll down to u and click the plugin icon -- Correctly got a configuration error message. At a command prompt: vi ~/koha-dev/etc/koha-conf.xml /enable_plug -- add in: {appropriate path. I used /home/mtompset/uploads} :wq mkdir {appropriate path used} -- I even added some subdirectories sudo chown -R -v www-data.www-data {appropriate path used} Back in staff client: click the plugin icon again -- this time an upload screen pops up click the 'Upload file' button -- message about no file or destination browse for a file, select one click the 'Upload file' button -- message about no destination click the 'Cancel' button click the plugin icon click a destination radio button click the 'Upload file' button -- message about no file browse for a file, select one click the 'Upload file' button -- message about success click the 'close' button. -- the text box has been filled in with a nice URL click the plugin icon click cancel click the plugin icon click delete -- the test box should be blanked, and a success message given click Close -- reupload a file properly click the plugin icon click delete click upload file browse for a file, select a destination, click upload file click close on success message click 'Clone this subfield' click the second plugin icon click delete click close click the first plugin icon -- Nice error message about a URL which points to nothing. click cancel In the second 856$u type in a URL (eg. www.google.com) click the second plugin icon -- this jumps immediately to the upload screen, but does not give an error message, because the URL does not have opac-retrieve-file in it. click save (we need to save the bibliographic record) In OPAC: search for the same word (I used fancy) find the entry you just updated with links click the two links. The dangling entry should give you a 500 error, and the other link should work just fine. get back to the detail page In staff client: edit edit record 8 change the 856$u to a valid file in the first link. save In OPAC: refresh the detail page, and click the first link again this time it should get downloaded nicely. >From a command line: prove -v t/db_dependent/UploadedFiles.t perldoc C4::Biblio perldoc C4::UploadedFiles One more round of tests tomorrow, and this should be ready. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:19:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:19:57 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38911|0 |1 is obsolete| | --- Comment #311 from M. Tompsett --- Created attachment 38922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38922&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:20:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:20:06 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38912|0 |1 is obsolete| | --- Comment #312 from M. Tompsett --- Created attachment 38923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38923&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:20:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:20:14 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38913|0 |1 is obsolete| | --- Comment #313 from M. Tompsett --- Created attachment 38924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38924&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:20:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:20:22 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38914|0 |1 is obsolete| | --- Comment #314 from M. Tompsett --- Created attachment 38925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38925&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:21:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:21:33 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38922|0 |1 is obsolete| | --- Comment #315 from M. Tompsett --- Created attachment 38926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38926&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:21:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:21:41 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38923|0 |1 is obsolete| | --- Comment #316 from M. Tompsett --- Created attachment 38927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38927&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:21:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:21:56 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38924|0 |1 is obsolete| | --- Comment #317 from M. Tompsett --- Created attachment 38928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38928&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:22:05 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38925|0 |1 is obsolete| | --- Comment #318 from M. Tompsett --- Created attachment 38929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38929&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:22:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:22:14 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38915|0 |1 is obsolete| | --- Comment #319 from M. Tompsett --- Created attachment 38930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38930&action=edit Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:22:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:22:22 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38916|0 |1 is obsolete| | --- Comment #320 from M. Tompsett --- Created attachment 38931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38931&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:22:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:22:30 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38917|0 |1 is obsolete| | --- Comment #321 from M. Tompsett --- Created attachment 38932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38932&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:22:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:22:38 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38918|0 |1 is obsolete| | --- Comment #322 from M. Tompsett --- Created attachment 38933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38933&action=edit Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN --------- 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:22:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:22:47 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38919|0 |1 is obsolete| | --- Comment #323 from M. Tompsett --- Created attachment 38934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38934&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, in that the protocol is assumed in the OpacBaseURL system preference. It also adds improved error handling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:22:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:22:57 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38920|0 |1 is obsolete| | --- Comment #324 from M. Tompsett --- Created attachment 38935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38935&action=edit Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 6 23:23:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 21:23:05 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38921|0 |1 is obsolete| | --- Comment #325 from M. Tompsett --- Created attachment 38936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38936&action=edit Bug 6874: Catch warnings for clean tests. I hate noisy tests, so I cleaned them up. MEGA TEST PLAN -------------- git checkout -b bug_6874 origin/master git bz apply 6874 -- yes, it should all apply smoothly. I intentionally restored an old backup from a couple months ago to force the upgrade. staff client: -- upgrade -- login Koha administration MARC Bibliographic framework MARC structure (for BKS) Search for 856 Subfields Edit (for u) Other options Plugin: upload.pl Save changes Search the catalog tab {choose a word, any word. I used fancy, because I knew we had a cookbook} click first link Edit Edit record 8 (that's the tab name) click the name for 856 scroll down to u and click the plugin icon -- Correctly got a configuration error message. At a command prompt: vi ~/koha-dev/etc/koha-conf.xml /enable_plug -- add in: {appropriate path. I used /home/mtompset/uploads} :wq mkdir {appropriate path used} -- I even added some subdirectories sudo chown -R -v www-data.www-data {appropriate path used} Back in staff client: click the plugin icon again -- this time an upload screen pops up click the 'Upload file' button -- message about no file or destination browse for a file, select one click the 'Upload file' button -- message about no destination click the 'Cancel' button click the plugin icon click a destination radio button click the 'Upload file' button -- message about no file browse for a file, select one click the 'Upload file' button -- message about success click the 'close' button. -- the text box has been filled in with a nice URL click the plugin icon click cancel click the plugin icon click delete -- the test box should be blanked, and a success message given click Close -- reupload a file properly click the plugin icon click delete click upload file browse for a file, select a destination, click upload file click close on success message click 'Clone this subfield' click the second plugin icon click delete click close click the first plugin icon -- Nice error message about a URL which points to nothing. click cancel In the second 856$u type in a URL (eg. www.google.com) click the second plugin icon -- this jumps immediately to the upload screen, but does not give an error message, because the URL does not have opac-retrieve-file in it. click save (we need to save the bibliographic record) In OPAC: search for the same word (I used fancy) find the entry you just updated with links click the two links. The dangling entry should give you a 500 error, and the other link should work just fine. get back to the detail page In staff client: edit edit record 8 change the 856$u to a valid file in the first link. save In OPAC: refresh the detail page, and click the first link again this time it should get downloaded nicely. >From a command line: prove -v t/db_dependent/UploadedFiles.t perldoc C4::Biblio perldoc C4::UploadedFiles One more round of tests tomorrow, and this should be ready. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 00:36:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 22:36:08 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #31 from Robin Sheat --- (In reply to Kyle M Hall from comment #28) > Ignore this comment, I had my versions crossed. Any idea what the > possibility of taking the package for Jesse and using it on Wheezy is? Dependency packages need to be actually built for the environment, we can't just grab a .deb file and throw it in. (In reply to Kyle M Hall from comment #29) > Another idea, can't we have a temporary package for Mojo even if it's not > proper for upstreaming? Once the debian mojo package hit's the right version > we could remove our own package. Would that work? That's exactly what I'm trying to avoid. Now it's something I have to maintain for the next few years. Hence my policy being that if I can't make a package that can go into Debian, then I'm not really willing to put it into the Koha repo. This also forces me to check the package for overall worthiness (e.g. people depending on modules that have no copyright notice, therefore we can't legally redistribute - not the case here though, this is just simply unbuildable until I find a version of tar without the bug.) If you want to help out on this front, have a look here: http://wiki.koha-community.org/wiki/Building_Debian_Dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 01:09:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 23:09:34 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38842|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 38938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38938&action=edit [SIGNED-OFF] Bug 14132: suggestions table is missing indexes - atomicupdate Signed-off-by: Bernardo Gonzalez Kriegel Sorry but removed backticks No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 01:10:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 23:10:01 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 01:09:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 May 2015 23:09:17 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38841|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 38937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38937&action=edit [SIGNED-OFF] Bug 14132: suggestions table is missing indexes Suggestions table is missing some indexes. Index on biblionumber will speed up C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop. Index on status and branchcode will speed up many queries. Note that an index on budgetid is automatically added by the creation of the foreign key constraint. Test plan : - Check performance with an invoice containing a lot of orders. - Check suggestions pages are faster or at least not slower. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 02:53:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 00:53:34 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 --- Comment #9 from David Cook --- (In reply to Katrin Fischer from comment #8) > This is growing into a bigger problem - we also got a report of the same > phenomenon in acquisitions now when cancelling an order. Interesting... does the result browser Javascript get called there? That's what's causing the problem elsewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 02:59:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 00:59:06 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 02:59:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 00:59:16 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 02:59:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 00:59:25 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #21 from David Cook --- (In reply to Chris Nighswonger from comment #1) > The upgrade mechanism really needs to run the same dep check which is run on > a clean install... every time. > > And error trapping has never been our strong point, but really should become > so. I so agree with this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 05:22:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 03:22:20 +0000 Subject: [Koha-bugs] [Bug 11270] Search Result highlighting should be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 --- Comment #7 from M. Tompsett --- Created attachment 38939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38939&action=edit Bug 11270: Search Result highlighting should be refactored (master) Whilst working on Bug 6149 I found there to be many repeats of code in different file relating to the search highlighting. This patch tries to factor out some of the code into include's to enhance maintainability. This is just the bootstrap portions. Untested. This should apply. However, Martin Renvoize has yet to post a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 05:59:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 03:59:11 +0000 Subject: [Koha-bugs] [Bug 11270] Search Result highlighting should be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23039|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 38940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38940&action=edit Bug 11270: Search Result highlighting should be refactored (3.16.x) Whilst working on Bug 6149 I found there to be many repeats of code in different file relating to the search highlighting. This patch tries to factor out some of the code into include's to enhance maintainability. This is just the bootstrap portions. Untested. This should apply. However, Martin Renvoize has yet to post a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 06:05:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 04:05:10 +0000 Subject: [Koha-bugs] [Bug 11270] Search Result highlighting should be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38940|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 38941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38941&action=edit Bug 11270: Search Result highlighting should be refactored (3.16.x) Whilst working on Bug 6149 I found there to be many repeats of code in different file relating to the search highlighting. This patch tries to factor out some of the code into include's to enhance maintainability. This is just the bootstrap portions. Untested. This should apply. However, Martin Renvoize has yet to post a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 06:10:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 04:10:00 +0000 Subject: [Koha-bugs] [Bug 11270] Search Result highlighting should be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com CC| |mtompset at hotmail.com Status|Patch doesn't apply |ASSIGNED --- Comment #10 from M. Tompsett --- Changing back to assigned to Martin, since he posted the initial patches, and he never responded with a test plan. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 06:14:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 04:14:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #87 from Liz Rea --- Hi, I had a chance to take a look at this today. My comments are not code-level, they are "I applied this and had a look at the actual function" level. This is definitely a desirable feature, please don't give up. :) I saw several issues with this when I was testing: 1. The patch won't apply, it has easily resolved conflicts in database structure and update database. I fixed them for my testing purposes, just wanted you to be aware. 1a. As noted elsewhere, the feature should go into Koha turned off, instead of turned on. We don't want surprises for our users. 2. In the bootstrap theme, we will want to have the "Forgot password" link on the home page beneath the login, on /cgi-bin/koha/opac-user.pl, as well as in the modal box. This can be a follow up. 3. The markup on the opac-password-recovery pages is not consistent with the rest of the OPAC in the Bootstrap theme. This will need to be fixed. 4. On the "reset password" phase ("Password recovery form") - I don't understand why the first field is "Surname in lower case" and the second field is "Confirm password" - the standard behaviour for functions like this is to have something like "Type password" and "repeat password." The function works, but it wasn't clear to me when testing that the "surname" field was actually supposed to be the initial go at the password. It may be a relic from the implementation for your client, but I don't think we want it to be default Koha behaviour for it to suggest the surname as a password. Please fix. 5. *Good thing* submitting the form, (when I realised that both fields are for passwords) works just fine, and the password is reset, and I was able to log in with no issue. 6. Having a mismatch in the passwords on the reset form seems to pop up a box asking me to confirm which user I am changing the password for - this doesn't seem right to me, please check. It doesn't seem to actually *work* but it's a bit scary to see, as it suggests that I could possibly change the password for a user that is not "me." 7. This functionality does not work when you have more than one borrower with the same email address, it presents "We chould not authenticate you as the account owner." I think we may need to use a combination of userid and email address to authenticate users. Userid's do have to be unique, maybe use that instead and pop an error if the user does not have a registered email address. 8. *Good thing* the email seems to work fine. Maybe minor updates to the text from a native English speaker are needed, but the message and the link are fine. Any changes can come in a follow up. I understand this is a lot of things to deal with - I think everyone in the community wants this patch/function to be successful, so please say if you need help or if you have any questions. If you feel like you would rather not continue on with this development, please say so that someone else will feel better about picking up where you left off. Cheers, Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 06:45:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 04:45:21 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #88 from Liz Rea --- A couple of other things that I saw just after I posted the last message - - Please check the copyright - should it be InLibro or PTFS Europe? - It occurs to me that by default, the message queue sends things every 15 minutes and that's a pretty long time in password-reset land. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 06:48:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 04:48:34 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Tim Hannah changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |timdhannah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 07:54:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 05:54:43 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED Resolution|--- |INVALID --- Comment #15 from M. Tompsett --- Because Bug 14057 was pushed to master, this bug is invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 09:21:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 07:21:50 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 --- Comment #15 from Julian FIOL --- Test Plan --------- 1. Go to your koha/src directory 2. Launch misc/devel/coverage.pl script 3. After a pretty long time it will generate an html file (path given at the end of execution). It something like [...]/koha/src/cover_db/coverage.html 4. This html file give you a lot of information about coverage of koha modules I use it to see which module are not coverage by unit tests and improve it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 10:17:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 08:17:53 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #32 from Julian Maurice --- (In reply to Robin Sheat from comment #31) > (In reply to Kyle M Hall from comment #28) > > Ignore this comment, I had my versions crossed. Any idea what the > > possibility of taking the package for Jesse and using it on Wheezy is? > > Dependency packages need to be actually built for the environment, we can't > just grab a .deb file and throw it in. I tried to build Mojolicious package for Wheezy from here: git://git.debian.org/git/pkg-perl/packages/libmojolicious-perl.git I had to install several *build* dependencies from Jessie, but the resulting binary package should work well on wheezy. In Jessie libmojolicious-perl depends on libjs-prettify which is not in Wheezy so I had to also build this package. Building source packages requires much more work, as there is a lot of build dependencies not packaged in wheezy, but do we need them ? (for libjs-prettify I retrieved files from packages.debian.org and built from there) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 10:45:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 08:45:00 +0000 Subject: [Koha-bugs] [Bug 14163] New: "Show all" on order page confusing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Bug ID: 14163 Summary: "Show all" on order page confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org On the order form there is a checkbox next to the fund list labelled 'show all'. I think the description is not very clear here as librares are asking about the effect of the checkbox. Suggestion: relabel it to say: show inactive. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 7 11:20:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 09:20:18 +0000 Subject: [Koha-bugs] [Bug 12719] Fix bulkmarcimport.pl documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12719 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #3 from Magnus Enger --- --match can be given multiple times, because of the @ here: 'match=s@' => \$match, but this is not mentioned in the documentation. It should also be explicitly said if multiple --match'es are ANDed or ORed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 11:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 09:33:52 +0000 Subject: [Koha-bugs] [Bug 9525] group floating rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #1 from Olli-Antti Kivilahti --- We need the same thing ASAP. We just added a few bookmobiles which need floating between their parent libraries and are shifting priorities to try to solve this issue ASAP. This is an awkward pending issue for us and hopefully I can deliver an acceptable solution soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 11:34:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 09:34:01 +0000 Subject: [Koha-bugs] [Bug 9525] group floating rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 11:47:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 09:47:09 +0000 Subject: [Koha-bugs] [Bug 14164] New: Change in due date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14164 Bug ID: 14164 Summary: Change in due date Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Case1: No fine displaying. The bookk has Rs.20/- fine The screen shot taken on 20/4/2015 while check in the book. Eventhough the duedate is 31/3/2015 no fine generated for this student. See the screenshot http://postimg.org/image/wo96tpfdd/ Case 2: Automatically changing the due date. As per system we are issuing the books for 25 days but for this student the due date is less than 25 days(book India govt and politics) Screenshot http://postimg.org/image/tl8gqc0ep/ Case3: System automatically forgiving the fines without our instruction Screenshot http://postimg.org/image/dx79jjksx/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 7 11:47:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 09:47:41 +0000 Subject: [Koha-bugs] [Bug 14164] Change in due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14164 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 7 12:47:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 10:47:08 +0000 Subject: [Koha-bugs] [Bug 14165] New: Typo in PerlDependencies Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14165 Bug ID: 14165 Summary: Typo in PerlDependencies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 12:52:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 10:52:04 +0000 Subject: [Koha-bugs] [Bug 14165] Typo in PerlDependencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14165 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 12:52:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 10:52:07 +0000 Subject: [Koha-bugs] [Bug 14165] Typo in PerlDependencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14165 --- Comment #1 from Marcel de Rooy --- Created attachment 38942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38942&action=edit Bug 14165: Typo in PerlDependencies Dependency PDF::FromHTML should be listed as required. See mainpage.pl line 32 (using Koha::Borrower::Discharge). Test plan: If you do not have this dependency, verify that accessing the staff client already results in a software error (Cannot locate PDF/FromHTML.pm). Run koha_perl_deps.pl -m -r without this patch. FromHTML is not listed. Run it with this patch. FromHTML is listed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 12:52:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 10:52:20 +0000 Subject: [Koha-bugs] [Bug 14165] Typo in PerlDependencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14165 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 12:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 10:53:49 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14165 CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 12:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 10:53:49 +0000 Subject: [Koha-bugs] [Bug 14165] Typo in PerlDependencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14165 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8007 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 13:11:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 11:11:58 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #117 from Marcel de Rooy --- (In reply to Robin Sheat from comment #116) > PDF::Writer is pretty straightforward, but PDF::FromHTML is not high enough > quality to be a Debian package so is going to take a bit of time to prepare > packages for (I'm not willing to take on the technical debt of being a sole > maintainer, I'm afraid, so am going to insist that it's ready for debian > before I put it into the Koha repo.) If Debian does not like it, why are we using it? Maybe changing the dependency to a better alternative is not that much work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 13:19:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 11:19:55 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14165 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 13:19:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 11:19:54 +0000 Subject: [Koha-bugs] [Bug 14165] Typo in PerlDependencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14165 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14103 --- Comment #2 from Jonathan Druart --- This is not a typo, see bug 14103. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 13:21:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 11:21:27 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #118 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #117) > (In reply to Robin Sheat from comment #116) > > PDF::Writer is pretty straightforward, but PDF::FromHTML is not high enough > > quality to be a Debian package so is going to take a bit of time to prepare > > packages for (I'm not willing to take on the technical debt of being a sole > > maintainer, I'm afraid, so am going to insist that it's ready for debian > > before I put it into the Koha repo.) > > If Debian does not like it, why are we using it? > Maybe changing the dependency to a better alternative is not that much work? You can read back the 100+ comments above. I did not find a better alternative, otherwise I would have used it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 13:47:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 11:47:40 +0000 Subject: [Koha-bugs] [Bug 14165] Typo in PerlDependencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14165 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Chris Nighswonger --- Marking a duplicate. *** This bug has been marked as a duplicate of bug 14103 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 13:47:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 11:47:40 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #22 from Chris Nighswonger --- *** Bug 14165 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 14:04:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 12:04:29 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 14:04:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 12:04:33 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38899|0 |1 is obsolete| | --- Comment #23 from Chris Nighswonger --- Created attachment 38943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38943&action=edit [SIGNED OFF] Bug 14103: Improved testing coverage As per Chris' comment #17, this improves the testing coverage. Same test plan as comment #16, but add: TEST PLAN SUPPLEMENT -------------------- 1) $ prove -v t/db_dependent/Borrower_Discharge.t -- notice only 5 tests, and generate_as_pdf not tested. 2) Apply this patch. 3) Retest as per comment #16 -- this will test the error and no error cases tweaked in Koha/Borrower/Discharge.pm 4) remove PDF::HTML $ sudo apt-get purge libpdf-fromhtml-perl 5) $ prove -v t/db_dependent/Borrower_Discharge.t -- 7 tests, all successful 6) add PDF::HTML $ sudo dpkg -i /path/to/libpdf-fromhtml-perl... -- depends on how you get it. vary accordingly. 7) $ prove -v t/db_dependent/Borrower_Discharge.t -- 7 tests, all successful -- Note that is was a different 7th test. :) 8) koha qa test tools Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 14:06:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 12:06:59 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 14:07:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 12:07:02 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38700|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 38944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38944&action=edit [PASSED QA] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 15:31:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 13:31:07 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 15:31:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 13:31:26 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38840|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 38945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38945&action=edit [SIGNED-OFF] Bug 14059: Deleting 'issues' table before processing the tests It's suppose to avoid foreign key trouble Signed-off-by: Bernardo Gonzalez Kriegel No error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 15:31:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 13:31:41 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 15:46:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 13:46:40 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #12 from Tom?s Cohen Arazi --- Please rebase this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 15:53:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 13:53:27 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38719|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 38946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38946&action=edit [SIGNED-OFF] Bug 14097: Testing C4::UsageStats DESCRIPTION ----------- Add unit tests to C4::UsageStats Subroutine : (V : tested, X : Not tested) V NeedUpdate V BuiltReport X ReportToCommunity V _count TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/UsageStats.t -- All tests should run successfully /!\ I have 1 warning but I don't know where it can come /!\ (in cleanup) DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308 TEST PLAN OPTIONAL ------------------ Go check bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 40,5% Branch : 0,0% Condition : 0,0% Subroutine : 55,6% Coverage AFTER this patch : Statement : 81,0% Branch : 100,0% Condition : 100,0% Subroutine : 88,8% Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 15:53:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 13:53:33 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38800|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 38947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38947&action=edit [SIGNED-OFF] Bug 14097: Delete table issues before testing If we delete all biblio DB, we could have some troubles with foreign keys Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 15:53:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 13:53:40 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38814|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 38948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38948&action=edit [SIGNED-OFF] Bug 14097: changing verif_systempreferences_values subroutine It's saving a large number of lines Signed-off-by: Bernardo Gonzalez Kriegel All tests run, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 15:53:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 13:53:56 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 15:56:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 13:56:26 +0000 Subject: [Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38847|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 38949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38949&action=edit [SIGNED-OFF] Bug 14147: Add unit tests to C4::External::OverDrive This patch test 'IsOverDriveEnabled' subroutine TEST PLAN --------- 1. Apply patch 2. prove -v t/External/OverDrive.t -- All tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Check with bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 47,5% Branch : 0,0% Condition : 0,0% Subroutine : 75,0% Coverage AFTER this patch : Statement : 49,1% Branch : 0,0% Condition : 33,3% Subroutine : 83,3% Signed-off-by: Bernardo Gonzalez Kriegel Tests tun, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 16:03:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 14:03:58 +0000 Subject: [Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 16:14:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 14:14:44 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Bernardo Gonzalez Kriegel --- Mmmm, changed my mind. After running the test, my db was left without items, borrowers, etc. No rollback it seems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 16:19:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 14:19:52 +0000 Subject: [Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the patron import tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 16:20:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 14:20:18 +0000 Subject: [Koha-bugs] [Bug 14124] Add 'Unimarc only' note to IdRef system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14124 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38892|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 38950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38950&action=edit [SIGNED-OFF] Bug 14124: Add 'Unimarc only' note to IdRef system preference This patch adds a note to the IdRef service syspref making it clear that the feature is only available for UNIMARC setups. Signed-off-by: Bernardo Gonzalez Kriegel Added a missing 'is' No errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 16:20:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 14:20:29 +0000 Subject: [Koha-bugs] [Bug 14124] Add 'Unimarc only' note to IdRef system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14124 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 7 16:38:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 14:38:07 +0000 Subject: [Koha-bugs] [Bug 14136] Remove superfluous template parameters from members/member-flags.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38812|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 38951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38951&action=edit [SIGNED-OFF] Bug 14136: Remove superfluous template parameters from members/member-flags.pl This bug was triggered because intranet-error.log had entries like the following: member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/member-flags.pl line 176. To reproduce: Have a patron without roadtype and go to Home > Patrons > Set permissions for ... There are some template parameters that are not used in the template member-flags.tt ( $roadtype is used while preparing $address ) Unused template params are: cardnumber othernames categorycode category_type categoryname address address2 city state zipcode country phone phonepro mobile email emailpro branchcode branchname loop <--- this is used is_child activeBorrowerRelationship RoutingSerials To test: - Verify that you get the warning above in intranet-error.log - Verify that the parameters above are not used in the template member-flags.tt - Apply patch - Verify that setting permissions for patrons still works Note: There are a lot of indenting issues in this file. This patch does not intend to resolve them. Signed-off-by: Bernardo Gonzalez Kriegel Warn exists, now removed. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 16:38:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 14:38:24 +0000 Subject: [Koha-bugs] [Bug 14136] Remove superfluous template parameters from members/member-flags.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 16:39:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 14:39:46 +0000 Subject: [Koha-bugs] [Bug 14166] New: exportable version of reading history Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14166 Bug ID: 14166 Summary: exportable version of reading history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice if there was (in the staff and opac) a csv exportable version of the reading history. Home schoolers would use this alot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:20:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:20:43 +0000 Subject: [Koha-bugs] [Bug 14167] New: Add Koha::Logger based on Log4perl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Bug ID: 14167 Summary: Add Koha::Logger based on Log4perl Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:20:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:20:56 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:25:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:25:33 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 --- Comment #15 from Tom?s Cohen Arazi --- Created attachment 38952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38952&action=edit Bug 13758: (QA followup) Make Makefile.PL aware of Koha.pm Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:28:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:28:11 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:28:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:28:13 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #1 from Kyle M Hall --- Created attachment 38953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38953&action=edit Bug 14167 - Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the /path/to/log4perl.conf line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from DEBUG to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:34:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:34:09 +0000 Subject: [Koha-bugs] [Bug 14065] Typo in opac self registration form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:34:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:34:10 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38953|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 38954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38954&action=edit Bug 14167 - Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the /path/to/log4perl.conf line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from DEBUG to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:34:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:34:34 +0000 Subject: [Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:35:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:35:01 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:35:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:35:38 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:35:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:35:58 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #16 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:36:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:36:21 +0000 Subject: [Koha-bugs] [Bug 11464] Saving preferences - Nothing to Save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:36:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:36:50 +0000 Subject: [Koha-bugs] [Bug 4281] reports dictionary limited to only 1 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4281 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:37:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:37:35 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:38:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:38:18 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:39:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:39:26 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13413 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:39:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:39:26 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14167 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:39:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:39:46 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14167 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:39:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:39:46 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8190 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:39:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:39:54 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:49:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:49:29 +0000 Subject: [Koha-bugs] [Bug 14168] New: enhance streaming cataloging to include youtube Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Bug ID: 14168 Summary: enhance streaming cataloging to include youtube Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Would be nice if you could catalog youtube videos and have them steam in Koha like you can other HTML5 videos. We might be able to use something like https://metacpan.org/pod/WWW::YouTube::Download for this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 17:53:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 15:53:14 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #1 from Nicole C. Engard --- an idea from drojf: soething like this http://www.htmlgoodies.com/imagesvr_ce/9722/youtube3.jpg and if you catalogue the url part, the rest around it could be generated. still a new feature though -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 18:02:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 16:02:48 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 18:02:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 16:02:51 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38883|0 |1 is obsolete| | Attachment #38943|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 38955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38955&action=edit [PASSED QA] Bug 14103: PDF::FromHTML is conditionally required on UseDischarge systempreference Since this is only in generate_as_pdf of Koha::Borrowers::Discharge, it made sense to change it from a use to a require (avoiding a compile time error), and placing it inside the eval where the PDF is generated, thus capturing the problem in the koha error log. TEST PLAN --------- 1) Log in to staff client 2) Koha Administration -> Global system preferences -> Local Use 3) Lower the Version number by 1, but DO NOT CLICK SAVE. 4) At the command line, sudo apt-get purge libpdf-fromhtml-perl 5) Back in the staff client, click save. 6) Every looks great until you attempt to log in. KABOOM! 7) Apply patch 8) Log in to staff client -- YAY! 9) Koha Administration -> Global system preferences -> Patrons 10) Make use the useDischarge is set to Allow 11) Find a patron with nothing checked out. 12) There is now a Discharge tab on the left at the bottom. 13) Click the 'Generate Discharge' button. -- nice error message -- check koha error log file for the ugly @INC missing message 14) At the command line, reinstall PDF::FromHTML (I built my own with cpan2deb: sudo dpkg -i /path/to/libpdf-fromhtml-perl_...) 15) In the staff client, click the 'Generate Discharge' button again. -- PDF is created as expected. All is well. 16) run koha qa test tools. Signed-off-by: Chris Nighswonger Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 18:03:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 16:03:00 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 --- Comment #25 from Kyle M Hall --- Created attachment 38956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38956&action=edit [PASSED QA] Bug 14103: Improved testing coverage As per Chris' comment #17, this improves the testing coverage. Same test plan as comment #16, but add: TEST PLAN SUPPLEMENT -------------------- 1) $ prove -v t/db_dependent/Borrower_Discharge.t -- notice only 5 tests, and generate_as_pdf not tested. 2) Apply this patch. 3) Retest as per comment #16 -- this will test the error and no error cases tweaked in Koha/Borrower/Discharge.pm 4) remove PDF::HTML $ sudo apt-get purge libpdf-fromhtml-perl 5) $ prove -v t/db_dependent/Borrower_Discharge.t -- 7 tests, all successful 6) add PDF::HTML $ sudo dpkg -i /path/to/libpdf-fromhtml-perl... -- depends on how you get it. vary accordingly. 7) $ prove -v t/db_dependent/Borrower_Discharge.t -- 7 tests, all successful -- Note that is was a different 7th test. :) 8) koha qa test tools Signed-off-by: Chris Nighswonger Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 18:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 16:52:40 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Bernardo Gonzalez Kriegel --- fatal: sha1 information is lacking or useless (Koha/Accounts/CreditTypes.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11622 - Add ability to pay fees and fines from OPAC via PayPa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 18:55:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 16:55:21 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- CONFLICT (content): Merge conflict in t/db_dependent/SIP_ILS.t Failed to merge in the changes. Patch failed at 0001 Bug 13532 - Unit tests for Bugg 13261 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 19:12:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 17:12:35 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38620|0 |1 is obsolete| | --- Comment #15 from Bernardo Gonzalez Kriegel --- Created attachment 38957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38957&action=edit [SIGNED-OFF] Bug 13734: RDA: Display 33xs Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 336,337,338 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Adds fields 336, 337 and 338 to staff and opac details. Adds comma between multiple subfields and | with class='separator' between multiple datafields (e.g. two 336 fields) 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Bernardo Gonzalez Kriegel Works, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 19:12:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 17:12:57 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 19:21:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 17:21:20 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 --- Comment #17 from Tom?s Cohen Arazi --- Created attachment 38958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38958&action=edit Bug 13758: (QA followup) revert case change that broke the tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 19:23:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 17:23:52 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #26 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 19:35:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 17:35:46 +0000 Subject: [Koha-bugs] [Bug 14169] New: Item Search csv export Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14169 Bug ID: 14169 Summary: Item Search csv export Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Files exported from Item Search do not open correctly in Microsoft Excel. However .csv files exported from Reports Module do open correctly in Microsoft Excel. (Note: all files open correctly in LibreOffice) Steps to reproduce: 1. Go to Item Search and select criteria 2. Output to .csv file 3. Select open with Excel 4. Columns are not lined up correctly and extra "" appear 5. Go to Reports 6. Run a report 7. Download to csv 8. Open csv in Microsoft Excel - it opens cleanly and data in right columns. Can Item Search csv export work as Reports csv export? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 19:38:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 17:38:49 +0000 Subject: [Koha-bugs] [Bug 14169] Item Search csv export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14169 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 19:45:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 17:45:28 +0000 Subject: [Koha-bugs] [Bug 14169] Item Search csv export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14169 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger --- Maybe related to bug 10117? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 21:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 19:01:43 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #3 from M. Tompsett --- Comment on attachment 38954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38954 Bug 14167 - Add Koha::Logger based on Log4perl Review of attachment 38954: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14167&attachment=38954) ----------------------------------------------------------------- ::: Koha/Logger.pm @@ +58,5 @@ > + my ( $class, $category ) = @_; > + > + croak("No category passed in!") unless $category; > + > + my $interface = C4::Context->interface(); What if it isn't set? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 21:20:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 19:20:29 +0000 Subject: [Koha-bugs] [Bug 13591] Rss sample templates have hardcoded urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 21:22:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 19:22:14 +0000 Subject: [Koha-bugs] [Bug 13591] Rss sample templates have hardcoded urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eskaaren at yahoo.no Status|Needs Signoff |Signed Off --- Comment #3 from M. Tompsett --- Corrected Eivin's sign off, by obsoleting unsigned version, and marking unsigned. Enjoy QA'ing. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 21:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 19:33:52 +0000 Subject: [Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 21:36:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 19:36:35 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #11 from M. Tompsett --- Comment on attachment 36351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36351 Bug 12769 - Notice fee management Review of attachment 36351: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12769&attachment=36351) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +9793,4 @@ > SetVersion($DBversion); > } > > +$DBversion = "XXX"; Please convert this to an atomic update. See http://wiki.koha-community.org/wiki/Database_updates#updatedatabase.pl @@ +9794,5 @@ > } > > +$DBversion = "XXX"; > +if ( CheckVersion($DBversion) ) { > + $dbh->do("ALTER TABLE `letter` add `fee` decimal(10,2) DEFAULT NULL"); https://dev.mysql.com/doc/refman/5.1/en/alter-table.html Please include AFTER so that this alter will generate same column order as kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 21:36:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 19:36:58 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Failed QA --- Comment #12 from M. Tompsett --- See reasons in comment #11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 21:41:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 19:41:07 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Assignee|gmcharlt at gmail.com |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 22:10:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 20:10:00 +0000 Subject: [Koha-bugs] [Bug 14170] New: branchtransfers items need to be cancelled when on loan or a waiting reserve Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170 Bug ID: 14170 Summary: branchtransfers items need to be cancelled when on loan or a waiting reserve Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Occasionally I find items in the branchtransfers that are still active while the item is on loan or a reserve waiting for pickup. I've actually found one item that is waiting for a patron, but has TWO unfinished transfers! Unless there is something I am missing, seems like it would be a good routine for Koha to check the branchtransfers table upon issue or being placed in a waiting status and cancel any pending transfers. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 7 22:40:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 20:40:07 +0000 Subject: [Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170 --- Comment #1 from Christopher Brannon --- Additionally, we still see remnants of incomplete transfers when the hold is triggered. It would be nice if when a hold message is displayed upon check-in if it would go ahead and cancel any existing transfers, and not display the message. I can't think of any good reason to keep an old transfer if the holds is triggering. If the item has to be routed elsewhere, it would do so after triggering the hold. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 22:43:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 20:43:16 +0000 Subject: [Koha-bugs] [Bug 14171] New: Buttons instead of links in messages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14171 Bug ID: 14171 Summary: Buttons instead of links in messages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 38959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38959&action=edit Options show as links I noticed in a transfer message that some options appear as links rather than buttons. These options seem to get lost in the message. I would HIGHLY recommend changing these choices to buttons. I will attach a screenshot of an example. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 7 22:54:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 20:54:17 +0000 Subject: [Koha-bugs] [Bug 14171] Buttons instead of links in messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 23:05:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 21:05:02 +0000 Subject: [Koha-bugs] [Bug 14171] Buttons instead of links in messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14171 --- Comment #1 from Chris Cormack --- The content of attachment 38959 has been deleted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 7 23:07:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 21:07:58 +0000 Subject: [Koha-bugs] [Bug 14171] Buttons instead of links in messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14171 --- Comment #2 from Christopher Brannon --- Created attachment 38960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38960&action=edit Options show as links -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 01:24:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 23:24:05 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 01:36:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 May 2015 23:36:12 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #33 from Robin Sheat --- (In reply to Julian Maurice from comment #32) > I tried to build Mojolicious package for Wheezy from here: > git://git.debian.org/git/pkg-perl/packages/libmojolicious-perl.git This is version 5.54 though. The problem is when you run uscan to create the DFSG-compliant source tarball of version 6.08, and swagger2 declares a dependency on Mojolicious 6.0+, so changing the minimum version that Koha requires doesn't change a whole lot. > I had to install several *build* dependencies from Jessie, but the resulting > binary package should work well on wheezy. > In Jessie libmojolicious-perl depends on libjs-prettify which is not in > Wheezy so I had to also build this package. > Building source packages requires much more work, as there is a lot of build > dependencies not packaged in wheezy, but do we need them ? We will need the source packages, because we need to build them. This is because we need to modify the changelogs to specify which pockets of the repo it's going to go into. I avoid doing it in hacky ways, or ways that are not Debian-compliant, because that ends up causing maintenance headaches and more unnecessary work in the long run, and will also interfere with my planned efforts to automate some parts of this process. All this said, I just downgraded tar in my package building VM to the version from squeeze, and uscan succeeds. So there is hope yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 03:24:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 01:24:49 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #119 from Robin Sheat --- (In reply to Marcel de Rooy from comment #117) > If Debian does not like it, why are we using it? > Maybe changing the dependency to a better alternative is not that much work? Oh, it won't be a large amount of work to make the package acceptable, it's mostly that it has a lot of incorrectly formatted/missing documentation.* It's just that between fixing things for jessie, and some other things, it might be a bit of time before I get to it. So, I included instructions for someone else to make some progress on polishing it up. * something I feel that we can't fault it for, but in this case we need to fix it** :) ** I'll probably submit these patches to the upstream project, too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 04:23:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 02:23:07 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31282|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 38961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38961&action=edit Bug 8609 - Add an URL validation plugin for authority and biblio frameworks This patch adds a new validation plugin to validate that a field/subfield contains a valid url. This plugin that can be used in biblio and authority frameworks. Changes: C4/Installer/PerlDependencies.pm - Regexp::Common::URI dependence added cataloguing/value_builder/url.pl - new file koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt - new function called in url.pl koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt - new function called in url.pl koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt - new function called in url.pl koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt - new function called in url.pl Testing: I) Before applying: 0) Go to the Cataloging module: menu->More->Cataloging; 1) Click < default framework>> bouton; 2) Click tab << 8 >>; 3) Insert a text (for example "test") in the 856->u input field; 4) Click out of the input field; 5) Validate no message; II) After Applying: i) field/subfield plugin attach 0) In Koha adminstration, click << MARC bibliographic framework >>; 1) In Default framework, click << MARC structure >>; 2) Search field 856 and click << Subfields >>; 3) Click << u >>; 4) In Other options -> Plugin, choose url.pl ii) Insert a text in the 856->u input field 0) Go to the Cataloging module: menu->More->Cataloging; 1) Click < default framework>> bouton; 2) Click tab << 8 >>; 3) Insert a text (for example "test") in the 856->u input field; 4) Click out of the input field; 5) Validate message: << The field 856$u must contain a valid URL! ex : http://www.google.com >> REBASED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 04:23:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 02:23:59 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #10 from M. Tompsett --- "Patterns for the following URIs are supported: fax, file, FTP, gopher, HTTP, news, NTTP, pop, prospero, tel, telnet, tv and WAIS." It does not include https. Kind of important. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 05:02:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 03:02:39 +0000 Subject: [Koha-bugs] [Bug 13180] Errors when acquiring from the new improved staged file, empty indicator warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13180 --- Comment #8 from M. Tompsett --- Comment on attachment 33375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33375 Bug 13180 - Errors when acquiring from the new improved staged file, empty indicator warning, is flooding the gosh-darn out of my koha-error.log... Nice to have you back joubu! Review of attachment 33375: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13180&attachment=33375) ----------------------------------------------------------------- I stopped before I cried too much, not because of this patch, but because of the resulting issue(s) I found. ::: acqui/addorderiso2709.pl @@ +269,4 @@ > my @field_values = $input->param('field_value'); > my @serials = $input->param('serial'); > my @ind_tag = $input->param('ind_tag'); > + my @indicator = $input->param('indicator'); #Passing the imaginary empty " " -indicators from the templates, to stop C4::Biblio::TransformHtmlToXml() to warn the bejesus out of my koha-error.log First, why is it @indicator and only $input->param and not $input->multi_param? Next, why not append "// ();" so as to reduce the number of files modified?! In fact, as far as I can tell addorderido2709.pl can't be called with an indicator parameter! $ git grep addorderiso2709.pl acqui/addorder.pl: print $input->redirect("/cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=$import_batch_id&basketno=$basketno&booksellerid=$booksellerid"); --- This won't pass indicator. acqui/addorderiso2709.pl:$template->param(scriptname => "/cgi-bin/koha/acqui/addorderiso2709.pl", --- This doesn't do anything to pass indicator. koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-add-to-basket.inc:
  • From a staged file
    • --- This is a link. No indicator passed. koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:
    --- Only the actual template could pass it. $ grep indicator ... --- You get the idea, nothing was there. @@ +275,5 @@ > push @{ $item->{subfields} }, $subfields[0]; > push @{ $item->{field_values} }, $field_values[0]; > push @{ $item->{ind_tag} }, $ind_tag[0]; > push @{ $item->{indicator} }, $indicator[0]; > + my $xml = TransformHtmlToXml( \@tags, \@subfields, \@field_values, \@indicator, \@ind_tag ); I checked the prototype of the TransfromHtmlToXML: $tags, $subfields, $values, $indicator, $ind_tag, $auth_type I see you caught the swapped parameters. Good! :) ARG! C4::Biblio insanity ($ind_tag isn't even used in the function!) ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt @@ +299,4 @@ > > > > + [%#Pass imaginary indicators to stop warnings in C4::Biblio::TransformHtmlToXml() %] Yuck. No. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 05:05:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 03:05:15 +0000 Subject: [Koha-bugs] [Bug 13180] Errors when acquiring from the new improved staged file, empty indicator warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13180 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #9 from M. Tompsett --- Perhaps we can get a better patch? I'm switching to Failed QA so it doesn't languish in the "In Discussion" queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 05:14:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 03:14:27 +0000 Subject: [Koha-bugs] [Bug 13180] Errors when acquiring from the new improved staged file, empty indicator warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13180 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11247 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 05:14:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 03:14:27 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13180 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:30:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:30:01 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:30:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:30:04 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38851|0 |1 is obsolete| | Attachment #38852|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 38962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38962&action=edit Bug 14128 - Capitalization: Guided Reports - step 2 - Build A Report To verify and test: Go to Home > Reports Click on 'Build new' Verify that the title in Step 1 and to display with correct capitalization Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:30:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:30:10 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 --- Comment #7 from Marcel de Rooy --- Created attachment 38963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38963&action=edit Bug 14128 - Capitalization: Guided Reports - step 2 - Build A Report Title 'Build a report' should display with all steps The tile displayed only with steps #1 and #2 This patch adds the title to the following steps. To test: Home > Reports Click on 'Build new' Step through steps 1 - 6 Verify that title displays with each step. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro Works as advertised. Signed-off-by: Hector Castro Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:30:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:30:49 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:38:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:38:02 +0000 Subject: [Koha-bugs] [Bug 11941] "Patron lists" are not easily accessible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:38:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:38:04 +0000 Subject: [Koha-bugs] [Bug 11941] "Patron lists" are not easily accessible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38879|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 38964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38964&action=edit Bug 11941: Add link to patron lists from the patron home page The patron lists are only accessible from the tools module, which is not easily accessible when you are in the patron module. Test plan: Go on the patron home page. In the toolbar, you should see a link to the patron lists. NOTE: Tweaked button to a to get the click to work. Signed-off-by: Mark Tompsett Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:38:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:38:50 +0000 Subject: [Koha-bugs] [Bug 11941] "Patron lists" are not easily accessible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com Component|Lists |Patrons Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:50:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:50:00 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:50:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:50:03 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38891|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 38965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38965&action=edit Bug 11576: Make "manage" translatable - serials-collection If a subscription is irregular, a tab with "manage" is displayed on the serial collection page. But this string is not translatable. Test plan: 1/ Go on the serial collection page of an irregular subscription (or create one). 2/ Note that the first tab was named "managed", it's now "Manage". 3/ Update a po lang file and confirm you see the string and you are able to translate it. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:50:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:50:36 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:55:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:55:36 +0000 Subject: [Koha-bugs] [Bug 14160] typo in AddressFormat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:55:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:55:38 +0000 Subject: [Koha-bugs] [Bug 14160] typo in AddressFormat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38896|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 38966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38966&action=edit Bug 14160: Fix typo in AddressFormat preference The preference was missing a 'd' in the word address. To test: * Visit preferences * Visit I18N/L10N tab * Confirm spelling of options in Addressformat preference Signed-off-by: Bernardo Gonzalez Kriegel Spelling is right, no errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 08:56:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 06:56:10 +0000 Subject: [Koha-bugs] [Bug 14160] typo in AddressFormat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 09:00:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 07:00:29 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 09:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 07:33:52 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 09:33:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 07:33:55 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38895|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 38967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38967&action=edit Bug 9892: Make export_borrowers.pl using the delimiter pref The original concern of bug 9892 was that this borrowers export script cannot handle tabulation to separate columns. With this patch, the delimiter preference is used as separator for the output, to be consistent with others scripts. This should be highlighted on the release, it can produce change in behaviors. Test plan: Confirm that the 'delimiter' pref is used for the output, but you are able to overwrite it with the 'separator' parameter Signed-off-by: Bernardo Gonzalez Kriegel Works as expected, respect preference but is supeseeded by cmd line No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 09:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 07:33:59 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 --- Comment #6 from Marcel de Rooy --- Created attachment 38968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38968&action=edit Bug 9892: [QA Follow-up] Typo and updated usage Corrected specifield. Updated usage statement on use of delimiter pref. Clarified the CONDITION explanation somewhat.. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 09:35:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 07:35:17 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38967|0 |1 is obsolete| | Attachment #38968|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 38969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38969&action=edit Bug 9892: Make export_borrowers.pl using the delimiter pref The original concern of bug 9892 was that this borrowers export script cannot handle tabulation to separate columns. With this patch, the delimiter preference is used as separator for the output, to be consistent with others scripts. This should be highlighted on the release, it can produce change in behaviors. Test plan: Confirm that the 'delimiter' pref is used for the output, but you are able to overwrite it with the 'separator' parameter Signed-off-by: Bernardo Gonzalez Kriegel Works as expected, respect preference but is supeseeded by cmd line No koha-qa errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 09:35:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 07:35:22 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 --- Comment #8 from Marcel de Rooy --- Created attachment 38970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38970&action=edit Bug 9892: [QA Follow-up] Typo and updated usage Corrected specifield. Updated usage statement on use of delimiter pref. Clarified the CONDITION explanation somewhat.. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 09:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 07:39:42 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 --- Comment #9 from Marcel de Rooy --- QA Comment: The problem in Comment1 has not yet been fully addressed. You can now choose tabulation in the delimiter pref but it is hard to pass a tab via the command line. But it is an improvement imo. The commit message says: [This should be highlighted on the release, it can produce change in behaviors.] This only pertains to the situation that someone does not pass a separator parameter and has a delimiter<>comma. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 10:20:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 08:20:59 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 --- Comment #18 from Marcel de Rooy --- Created attachment 38971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38971&action=edit Bug 13758: Correct KOHA::VERSION in OverDrive.pm Correct $KOHA::VERSION to $Koha::VERSION. Also, passing this string to LWP::UserAgent is wrong. It expects key/value pairs. Since this string is apparently intended as an agent, this patch passes it as such. Note: The OverDrive has unfortunately no unit tests. Signed-off-by: Marcel de Rooy Tested this change in the perl debugger with just these lines: use C4::External::OverDrive; C4::External::OverDrive::_request(); Printed $ua->agent while stepping into sub _request. Without the agent change, the adjusted Koha string would just be ignored and I would still have "libwww-perl/6.04" as agent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 10:21:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 08:21:23 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 10:21:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 08:21:33 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 10:21:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 08:21:41 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 10:21:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 08:21:50 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 10:22:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 08:22:09 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 --- Comment #19 from Marcel de Rooy --- Tomas: Please see the last QA follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 10:38:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 08:38:12 +0000 Subject: [Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Hey Julian, I am not sure about passing QA on this patch. You only actually do some trivial tests for IsOverDriveEnabled. The real stuff with requests, UserAgent etc. (probably mocking OverDrive behavior somehow) is not there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 11:57:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 09:57:56 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #4 from Kyle M Hall --- (In reply to M. Tompsett from comment #3) > Comment on attachment 38954 [details] [review] > Bug 14167 - Add Koha::Logger based on Log4perl > > Review of attachment 38954 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Logger.pm > @@ +58,5 @@ > > + my ( $class, $category ) = @_; > > + > > + croak("No category passed in!") unless $category; > > + > > + my $interface = C4::Context->interface(); > > What if it isn't set? The idea is that we want the category to be required. That is absolutely no reason to log a line without specifying a category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 12:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 10:06:13 +0000 Subject: [Koha-bugs] [Bug 14172] New: Acq: "Spent" lists incorrect titles and wrong total in some cases Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Bug ID: 14172 Summary: Acq: "Spent" lists incorrect titles and wrong total in some cases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In the acquisition module the spent and ordered amounts are linked to separate pages which show the records and freight costs that build up to the amount seen in the table. The page showing the ordered records appearst to be always correct, but there are problems with the spent page. At the moment, the problem always seems to occur for the 'serials' fund in each library (subscription order workflow?) The list is missing records in this case and the total is incorrect and not matching the value shown on the acq start page. We see this behaviour in several databases using acquisitons + serials with 3.18.5.1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 12:36:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 10:36:55 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: "Spent" lists incorrect titles and wrong total in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 --- Comment #1 from Katrin Fischer --- Hm, the problem seems to be that there is an entry in aqorders_items, but the corresponding item has since been deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 8 14:05:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 12:05:23 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #34 from Julian Maurice --- (In reply to Robin Sheat from comment #33) > All this said, I just downgraded tar in my package building VM to the > version from squeeze, and uscan succeeds. So there is hope yet. Yay! \o/ About 5.54 vs 6.0, maybe we could ask the author of Swagger2 to change the required version of Mojolicious (if Swagger2 is proven to work with 5.54 of course). What do you think ? Will that make things easier ? On the other hand, having the latest version of Mojolicious into Debian would be great if this doesn't require extra work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 14:14:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 12:14:24 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Mirko Tietgen --- I have a prototype that uses https://metacpan.org/pod/WWW::YouTube::Download to resolve the webm video link on the fly from a regular youtube link catalogued in 856$u. I will upload it when I had some more time for testing. Two things: - WWW::YouTube::Download is packaged for Debian Jessie, but not Wheezy. It depends on libxml-treepp-perl which is available on both systems. Have not checked Ubuntu. Probably have to ask Robin what to do about that. I rolled a package for Wheezy to test, I will upload it or link to it so the patch can be tested. - I have no idea if this is compliant to Youtube TOS. It does the same thing as your browser would if you opened the Youtube link: check for the file in a desired format and then play it. Link is generated on the fly, nothing is downloaded and stored anwhere on the Koha server. The video file is sent directly to the person opening the record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 14:23:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 12:23:48 +0000 Subject: [Koha-bugs] [Bug 13591] Rss sample templates have hardcoded urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 14:23:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 12:23:50 +0000 Subject: [Koha-bugs] [Bug 13591] Rss sample templates have hardcoded urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38902|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 38972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38972&action=edit [PASSED QA] Bug 13591 Pass OPACBaseURL to rss creation process Links in rss templates were hardcoded to library.org.nz. Should pass and use the system's OPACBaseURL. Tested and verified. Signed-off-by: Eivin Giske Skaaren Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 14:29:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 12:29:28 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38877|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 38973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38973&action=edit [PASSED QA] Bug 14152: Re-check required dependencies during upgrade process This code causes the installer to re-check dependencies during the upgrade process. Test Plan --------- 1) Log in to staff client 2) Koha Administration -> Global system preferences -> Local 3) Change Version to previous version -- DO NOT HIT SAVE YET! 4) In command line: sudo apt-get purge libpdf-fromhtml-perl NOTE: This could be ANY required library. I chose PDF::FromHTML, because it has been a thorn in my side. 5) NOW! Hit the 'Save' button. 6) Log in, etc. etc... -- Blows up on redirect to log in. 7) In command line, add it back (I had to compile my own so, I used sudo dpkg -i /path/to/libpdf-fromhtml-perl...) 8) Apply patch 9) Edit the C4/Installer/PerlDependencies.pm to make PDF::FromHTML required. See also bug 14103. 10) Log in to staff client 11) Koha Administration -> Global system preferences -> Local 12) Change Version to previous version -- DO NOT HIT SAVE YET! 13) In command line: sudo apt-get purge libpdf-fromhtml-perl 14) NOW! Hit the 'Save' button. 15) Log in, etc. etc... 16) Once warned you are missing it, add it back at the command line. 17) Click 'Recheck' -- Proceeds as expected now. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 14:29:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 12:29:39 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 14:41:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 12:41:17 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 14:41:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 12:41:19 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38901|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 38974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38974&action=edit [PASSED QA] Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. Signed-off-by: Bernardo Gonzalez Kriegel Moved updatedatabase entry (was in wrong position) to atomicupdate with commented copy of orignal No koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 14:47:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 12:47:24 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 14:47:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 12:47:26 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38937|0 |1 is obsolete| | Attachment #38938|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 38975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38975&action=edit [PASSED QA] Bug 14132: suggestions table is missing indexes Suggestions table is missing some indexes. Index on biblionumber will speed up C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop. Index on status and branchcode will speed up many queries. Note that an index on budgetid is automatically added by the creation of the foreign key constraint. Test plan : - Check performance with an invoice containing a lot of orders. - Check suggestions pages are faster or at least not slower. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 14:47:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 12:47:34 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 --- Comment #11 from Kyle M Hall --- Created attachment 38976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38976&action=edit [PASSED QA] Bug 14132: suggestions table is missing indexes - atomicupdate Signed-off-by: Bernardo Gonzalez Kriegel Sorry but removed backticks No errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 15:51:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 13:51:25 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 15:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 13:51:27 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38888|0 |1 is obsolete| | Attachment #38889|0 |1 is obsolete| | Attachment #38890|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 38977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38977&action=edit [PASSED QA] Bug 13899: Adding misc/devel/coverage.pl It's a script making a cover on all modules to see which ones are not tested yet. It uses Devel::Cover Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 15:51:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 13:51:35 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 --- Comment #17 from Kyle M Hall --- Created attachment 38978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38978&action=edit [PASSED QA] Bug 13899: Add changes as asked in Comment 5 Signed-off-by: Bernardo Gonzalez Kriegel Fixed a small conflict on PerlDependencies.pm Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 15:51:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 13:51:37 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 --- Comment #18 from Kyle M Hall --- Created attachment 38979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38979&action=edit [PASSED QA] Bug 13899: Changing license to GPLv3 koha-qa should be good : OK misc/devel/coverage.pl OK critic OK forbidden patterns OK pod OK valid OK C4/Installer/PerlDependencies.pm OK critic OK forbidden patterns OK pod OK valid Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors. Test plan not explicitly stated, script run and generates a lot of data :) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 15:52:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 13:52:32 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38954|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 38980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38980&action=edit Bug 14167 - Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the /path/to/log4perl.conf line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from DEBUG to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 15:54:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 13:54:32 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #6 from Kyle M Hall --- > > ::: Koha/Logger.pm > > @@ +58,5 @@ > > > + my ( $class, $category ) = @_; > > > + > > > + croak("No category passed in!") unless $category; > > > + > > > + my $interface = C4::Context->interface(); > > > > What if it isn't set? I think I missed your meaning. That's a very good question. By default if the interface isn't 'staff' it's 'opac'. I think maybe we should be able to pass in an interface parameter as well so we can set the interface to 'cli' or 'cron' or other such things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 15:55:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 13:55:53 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38980|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 38981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38981&action=edit Bug 14167 - Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the /path/to/log4perl.conf line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from DEBUG to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:05:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:05:04 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38897|0 |1 is obsolete| | Attachment #38898|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 38982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38982&action=edit Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:05:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:05:02 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:05:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:05:26 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #9 from Kyle M Hall --- Created attachment 38983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38983&action=edit Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% Signed-off-by: Bernardo Gonzalez Kriegel All tests run -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:06:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:06:04 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #10 from Kyle M Hall --- Created attachment 38984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38984&action=edit Bug 13969 [QA Followup] - Delete issues before borrowers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:10:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:10:48 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38982|0 |1 is obsolete| | Attachment #38983|0 |1 is obsolete| | Attachment #38984|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 38985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38985&action=edit Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% Signed-off-by: Bernardo Gonzalez Kriegel All tests run -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:11:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:11:00 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #12 from Kyle M Hall --- Created attachment 38986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38986&action=edit Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:11:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:11:03 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #13 from Kyle M Hall --- Created attachment 38987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38987&action=edit Bug 13969 [QA Followup] - Delete issues before borrowers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:13:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:13:56 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38985|0 |1 is obsolete| | Attachment #38986|0 |1 is obsolete| | Attachment #38987|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 38988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38988&action=edit [PASSED QA] Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% Signed-off-by: Bernardo Gonzalez Kriegel All tests run Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:14:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:14:02 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #15 from Kyle M Hall --- Created attachment 38989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38989&action=edit [PASSED QA] Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:14:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:14:04 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #16 from Kyle M Hall --- Created attachment 38990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38990&action=edit [PASSED QA] Bug 13969 [QA Followup] - Delete issues before borrowers Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:17:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:17:42 +0000 Subject: [Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #4) > Hey Julian, > I am not sure about passing QA on this patch. > You only actually do some trivial tests for IsOverDriveEnabled. > The real stuff with requests, UserAgent etc. (probably mocking OverDrive > behavior somehow) is not there. While I agree, I say any coverage is better than no coverage! This won't stop additional tests from being added later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:22:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:22:18 +0000 Subject: [Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:22:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:22:20 +0000 Subject: [Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38949|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 38991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38991&action=edit [PASSED QA] Bug 14147: Add unit tests to C4::External::OverDrive This patch test 'IsOverDriveEnabled' subroutine TEST PLAN --------- 1. Apply patch 2. prove -v t/External/OverDrive.t -- All tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Check with bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 47,5% Branch : 0,0% Condition : 0,0% Subroutine : 75,0% Coverage AFTER this patch : Statement : 49,1% Branch : 0,0% Condition : 33,3% Subroutine : 83,3% Signed-off-by: Bernardo Gonzalez Kriegel Tests tun, no koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 16:25:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 14:25:55 +0000 Subject: [Koha-bugs] [Bug 14173] New: Paging on 'recent comments' page in OPAC is not displaying correctly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Bug ID: 14173 Summary: Paging on 'recent comments' page in OPAC is not displaying correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Created attachment 38992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38992&action=edit Screenshot of broken paging The recent comments paging is displayig the 'current' page to the right side of the paging list. (see screenshot) In order to test this you need to activate the page via system preference and then add 21+ comments to different records in your catalog. There is also a small bug, as we are missing a space before the 'by' in each entry. Verified on a somewhat recent master and a 3.18.5.1 installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 17:31:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 15:31:01 +0000 Subject: [Koha-bugs] [Bug 14174] New: Home suspension and / or in situ Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14174 Bug ID: 14174 Summary: Home suspension and / or in situ Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: hectorejch at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently the library where I work applies two types of sanctions: per household or per room (in situ). If the sanction is per household, the borrower may check-out a book only by room. If the sanction is in situ, the borrower is completely penalized, unable to borrow any of the two forms. (Sorry for my bad english) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 17:31:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 15:31:10 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: "Spent" lists incorrect titles and wrong total in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 --- Comment #2 from Katrin Fischer --- The big problem is the 'missing' item, independent of the existence of an entry in aqorders.items. As this is a very normal thing for serial orders (no items, but a subscription instead) we need to make the SQL query for the spent page more flexible to include those as well. Haven't succeeded there so far, but maybe someone else wants to give it a try. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 8 18:16:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 16:16:07 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38981|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 38993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38993&action=edit Bug 14167 - Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the /path/to/log4perl.conf line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from DEBUG to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 18:55:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 16:55:09 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 19:41:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 17:41:08 +0000 Subject: [Koha-bugs] [Bug 14136] Remove superfluous template parameters from members/member-flags.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- Those parameters are used in circ-menu.inc which is used by this template. Without them that data does not display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 20:54:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 18:54:14 +0000 Subject: [Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 21:14:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 19:14:27 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #231 from Nick Clemens --- I am still having issues making this work correctly, I cannot see option to show to guarantor when OPACPrivacy is enabled and I can see but not edit (on opac-memberentry.pl) when disabled Digging into it a bit, the line in opac-privacy.tt: [% SET b = Koha.Find('Borrower', borrower.borrowernumber) %] doesn't seem to be returning anything into 'b' for me. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 21:26:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 19:26:13 +0000 Subject: [Koha-bugs] [Bug 14175] New: Update explanation of publication and expiration dates in newstool Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14175 Bug ID: 14175 Summary: Update explanation of publication and expiration dates in newstool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: indradg at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org Minor patch to expand upon existing explanation "Using the publication and expiration date fields you can control how long your item appears" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 21:51:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 19:51:33 +0000 Subject: [Koha-bugs] [Bug 12787] Unit test files should be better organized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- I agree with this idea. If it is in C4::Context... and is not database dependent: t/C4/Context/{function or method}.t and is database dependent: t/db_dependent/C4/Context/{function or method}.t I know that would eventually mean splitting large tests up, but in the meantime we could use 00-default.t for the large test everything ones. Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 21:51:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 19:51:35 +0000 Subject: [Koha-bugs] [Bug 14175] Update explanation of publication and expiration dates in newstool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14175 --- Comment #1 from Indranil Das Gupta --- Created attachment 38994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38994&action=edit Bug 14175 Update explanation of newstool in the manual Minor doc patch to expand upon existing explanation "Using the publication and expiration date fields you can control how long your item appears". Adds examples of publication date being set differently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 22:28:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 20:28:33 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #2 from M. Tompsett --- Created attachment 38995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38995&action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) prove t/db_dependent/Barcodes.t 3) apply patch 4) prove t/db_dependent/Barcodes.t -- same output as before. -- code is identical except for indentations. 5) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 22:32:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 20:32:16 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38995|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 38996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38996&action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 22:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 20:49:51 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #4 from M. Tompsett --- Created attachment 38997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38997&action=edit Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 23:19:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 21:19:35 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 23:19:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 21:19:37 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #5 from M. Tompsett --- Created attachment 38998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38998&action=edit Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 8 23:20:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 May 2015 21:20:01 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 07:39:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 05:39:35 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 --- Comment #3 from M. Tompsett --- Created attachment 38999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38999&action=edit Bug 14145: Nicer counter-patch The problem with the odd number of hashes happens when not everything is selected. The grep returns undef, because it isn't found in @values. By turning the grep into a ternary-operator truth value, we can set a value (1 or 0) expressly. The next problem is when nothing is selected in these multiple lists, $value is undefined, so you can't split it. By splitting the definition of @values from the actual splitting, we can split only if $value is defined, thus eliminating the warning message. TEST PLAN --------- 1) back up your koha error log file 2) blank your koha error log file 3) log in to the staff client 4) Home -> Koha administration -> Global system preferences 5) Click on every tab, EXCEPT local use. 6) notice the koha error log file has warnings. 7) blank the koha error log file again 8) apply this patch 9) Click on every tab, EXCEPT local use, again. 10) notice the koha error log file has no warnings. 11) koha qa test tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 07:44:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 05:44:57 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- To sign off this bug either: 1) sign off the first two and obsolete my counter patch OR 2) sign off my counter patch and obsolete the first two. Though, I personally am confused by some of the changes in the first two patches, so that is why I wrote the counter patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 07:48:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 05:48:20 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 9 07:54:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 05:54:11 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 --- Comment #5 from M. Tompsett --- Comment on attachment 38838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38838 Bug 14145: Noisy warns in admin/preferences.pl Review of attachment 38838: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14145&attachment=38838) ----------------------------------------------------------------- ::: admin/preferences.pl @@ +46,4 @@ > my $tab_template = C4::Templates::gettemplate( 'admin/preferences/' . $tab . '.pref', 'intranet', $input ); > > my $active_currency = GetCurrency(); > + my $local_currency;; Double ;;'s? @@ +112,5 @@ > sort { $a->{'text'} cmp $b->{'text'} } > map { > my $option_value = $_; > { > + text => $options{type}->{$option_value}, This works, because the $options{type} doesn't exist, so two undefs reduces the list size by an even number for the failed grep too. There is no reason to change 'multiple' to 'type'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 07:59:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 05:59:15 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 --- Comment #6 from M. Tompsett --- Comment on attachment 38839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38839 Bug 14145: Noisy warns in admin/preferences.pl on Enhanced Content tab Review of attachment 38839: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14145&attachment=38839) ----------------------------------------------------------------- ::: admin/preferences.pl @@ +62,4 @@ > > my $name = $options{'pref'}; > my $chunk = { name => $name, value => $value, type => $options{'type'} || 'input', class => $options{'class'} };; > + $value //= ''; If $value is undef, then the question is what else is undef in the list above? $options{'pref'}? $options{'class'}? Because otherwise line 64 would be barfing errors too about uneven lists. Perhaps there is something here to fix? Neither my counter patch nor this would fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 15:46:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 13:46:15 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #6 from Indranil Das Gupta --- Created attachment 39000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39000&action=edit Bug 13758: (QA followup) revert case change that broke the tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 16:24:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 14:24:36 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38997|0 |1 is obsolete| | --- Comment #7 from Indranil Das Gupta --- Created attachment 39001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39001&action=edit Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 16:27:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 14:27:50 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39001|0 |1 is obsolete| | --- Comment #8 from Indranil Das Gupta --- Created attachment 39002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39002&action=edit Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 16:48:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 14:48:46 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38996|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 39003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39003&action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 16:49:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 14:49:42 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39003|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 39004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39004&action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 16:49:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 14:49:47 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39002|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 39005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39005&action=edit Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 16:49:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 14:49:52 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38998|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 39006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39006&action=edit Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 16:50:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 14:50:08 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 17:15:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 15:15:23 +0000 Subject: [Koha-bugs] [Bug 11967] Add support for RMA notices to Acquisitions. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11967 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- More reasons to fail qa. This only added it to english and french. This must be added to all sample notices. MY next concern is there are no tests. When you modify a C4 or Koha library, you must have test coverage. The test file t/db_dependent/Letters.t was not modified to include such coverage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 17:45:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 15:45:30 +0000 Subject: [Koha-bugs] [Bug 10160] Add z39.50 command line tester In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10160 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |mtompset at hotmail.com Status|Failed QA |RESOLVED --- Comment #4 from M. Tompsett --- Galen makes a valid point in comment #3. I'm going to change this to RESOLVED INVALID, since yaz-client already exists. Feel free to change back, if there is a reason to think that yaz-client doesn't meet this need. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 17:54:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 15:54:16 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #19 from M. Tompsett --- How does this relate to something like bug 6874? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 18:10:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 16:10:47 +0000 Subject: [Koha-bugs] [Bug 14175] Update explanation of publication and expiration dates in newstool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14175 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Nicole C. Engard --- Pushed to manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 18:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 16:33:04 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 18:33:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 16:33:07 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35036|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 39007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39007&action=edit Bug 13532 - Unit tests for Bugg 13261 This patch adds unit tests to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 18:35:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 16:35:34 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 --- Comment #8 from M. Tompsett --- Comment on attachment 39007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39007 Bug 13532 - Unit tests for Bugg 13261 Review of attachment 39007: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13532&attachment=39007) ----------------------------------------------------------------- ::: t/db_dependent/SIP_ILS.t @@ +1,1 @@ > +#!/usr/bin/perl -d Why -d? @@ +15,4 @@ > > BEGIN { > use_ok('C4::SIP::ILS'); > + new C4::Context; Why new? @@ +22,5 @@ > +use Koha::Borrower::Debarments; > +use C4::Circulation; > +use C4::Biblio; > +use C4::Items; > +use Sip; What is Sip? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 18:37:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 16:37:06 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #9 from M. Tompsett --- Testing shouldn't require the user to type stuff, so there is something not quite right with this. Also, what is Sip? C4::SIP::Sip? I'm just going to Failed QA this, because it doesn't just work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 18:40:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 16:40:57 +0000 Subject: [Koha-bugs] [Bug 13135] cancel_expired_holds.pl/CancelExpiredReserves() logging improvements to catch evasive bugs in production. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13135 --- Comment #3 from M. Tompsett --- Comment on attachment 32619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32619 Bug 13135 - cancel_expired_holds.pl/CancelExpiredReserves() logging improvements to catch evasive bugs in production. Review of attachment 32619: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13135&attachment=32619) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +949,4 @@ > =cut > > sub CancelExpiredReserves { > + my $verbose = shift; || 0 would be a good thing to add, so $verbose is always defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 18:44:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 16:44:47 +0000 Subject: [Koha-bugs] [Bug 13135] cancel_expired_holds.pl/CancelExpiredReserves() logging improvements to catch evasive bugs in production. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13135 --- Comment #4 from M. Tompsett --- Comment on attachment 32619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32619 Bug 13135 - cancel_expired_holds.pl/CancelExpiredReserves() logging improvements to catch evasive bugs in production. Review of attachment 32619: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13135&attachment=32619) ----------------------------------------------------------------- ::: Koha/Calendar.pm @@ +365,5 @@ > > +sub printMe { > + my $self = shift; > + my @sb; #String buffer to collect self output. > + Do you have your git configured properly? White space like this is bad. git config --global core.whitespace trailing-space,space-before-tab git config --global apply.whitespace fix ::: misc/cronjobs/holds/cancel_expired_holds.pl @@ +17,4 @@ > # with Koha; if not, write to the Free Software Foundation, Inc., > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > +use Modern::Perl; Don't just change to Modern::Perl when both strict and warnings are commented out. Are you sure this doesn't break anything else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 18:58:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 16:58:05 +0000 Subject: [Koha-bugs] [Bug 13135] cancel_expired_holds.pl/CancelExpiredReserves() logging improvements to catch evasive bugs in production. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13135 --- Comment #5 from M. Tompsett --- Comment on attachment 32619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32619 Bug 13135 - cancel_expired_holds.pl/CancelExpiredReserves() logging improvements to catch evasive bugs in production. Review of attachment 32619: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13135&attachment=32619) ----------------------------------------------------------------- Given that 3.16.x is much higher than 3.16.4, is there merit reworking this? Or should it be closed RESOLVED WON'T FIX? ::: C4/Reserves.pm @@ +981,4 @@ > > my $today = DateTime->now( time_zone => C4::Context->tz() ); > > + push @sb, "##Removing holds waiting too long\n##using today=$today, ReservesMaxPickUpDelay=$max_pickup_delay, ExpireReservesMaxPickUpDelayCharge=$charge\n". The whole today logic was ripped out and replaced with SQL logic in 3.16.x -- not required. @@ +992,5 @@ > } > CancelReserve({ reserve_id => $res->{'reserve_id'} }); > + push @sb, printReserve($res,'tab',['reserve_id','borrowernumber','branchcode','waitingdate']).sprintf("% 14s",substr($expiration,0,10))."| past lastpickupdate.\n" if $verbose; > + } > + elsif($verbose > 1) { Because of SQL logic, there is no if statement to elsif off of. @@ +998,2 @@ > } > + $usedCalendars{ $res->{branchcode} } = Koha::Calendar->new( branchcode => $res->{branchcode} ) if ( $verbose > 2 && not(exists($usedCalendars{$res->{branchcode}})) ); Is this required? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 19:06:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 17:06:18 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #7 from M. Tompsett --- (In reply to Galen Charlton from comment #5) > Comment on attachment 24754 [details] [review] > Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal > > Review of attachment 24754 [details] [review]: > ----------------------------------------------------------------- [SNIP] > > @@ +65,5 @@ > > + > > + my $opac_base_url = C4::Context->preference('OPACBaseURL'); > > + > > + my $return_url = > > + URI->new( "http://" > > This should be checking whether the OPAC is using SSL. Can someone please look at bug 5010 so we can avoid this mess of https/http concatentation/detection? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 19:25:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 17:25:32 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #20 from M. Tompsett --- (In reply to Tom?s Cohen Arazi from comment #16) > Patches pushed to master. > > Thanks Jonathan! Uh... no it isn't? prove t/db_dependent/Context.t kaboom, because C4::Context::KOHAVERSION is not there yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 9 20:12:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 May 2015 18:12:30 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 --- Comment #21 from Tom?s Cohen Arazi --- (In reply to M. Tompsett from comment #20) > (In reply to Tom?s Cohen Arazi from comment #16) > > Patches pushed to master. > > > > Thanks Jonathan! > > Uh... no it isn't? > prove t/db_dependent/Context.t kaboom, because C4::Context::KOHAVERSION is > not there yet. git fetch git reset--hard origin/master Maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 02:49:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 00:49:38 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38833|0 |1 is obsolete| | --- Comment #97 from M. Tompsett --- Created attachment 39008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39008&action=edit Bug 5010 - Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/it-IT/necessari/notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased again on kohadevbox... Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 10 02:49:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 00:49:46 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38834|0 |1 is obsolete| | --- Comment #98 from M. Tompsett --- Created attachment 39009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39009&action=edit Bug 5010: Fix - replace tab with spaces Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 04:28:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 02:28:09 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 --- Comment #22 from M. Tompsett --- (In reply to Tom?s Cohen Arazi from comment #21) [SNIP] > Maybe? Remedied somehow. Confusion probably started with rebase of bug 5010. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 07:17:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 05:17:46 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39006|0 |1 is obsolete| | --- Comment #13 from Indranil Das Gupta --- Created attachment 39010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39010&action=edit Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. Signed-off-by: Indranil Das Gupta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 07:25:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 05:25:54 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39004|0 |1 is obsolete| | --- Comment #14 from Indranil Das Gupta --- Created attachment 39011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39011&action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools Signed-off-by: Indranil Das Gupta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 07:26:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 05:26:28 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39005|0 |1 is obsolete| | --- Comment #15 from Indranil Das Gupta --- Created attachment 39012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39012&action=edit Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 07:27:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 05:27:05 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39010|0 |1 is obsolete| | --- Comment #16 from Indranil Das Gupta --- Created attachment 39013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39013&action=edit Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. Signed-off-by: Indranil Das Gupta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 07:33:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 05:33:00 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com Status|Needs Signoff |Signed Off --- Comment #17 from Indranil Das Gupta --- 1/ All three test plans were followed. 2/ All three patches cleared koha-qa.pl -c 1 -v 2 without errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 07:55:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 05:55:03 +0000 Subject: [Koha-bugs] [Bug 14112] Silence warnings t/Charset.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 10:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 08:22:02 +0000 Subject: [Koha-bugs] [Bug 14112] Silence warnings t/Charset.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38753|0 |1 is obsolete| | --- Comment #2 from Indranil Das Gupta --- Created attachment 39014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39014&action=edit Bug 14112: Silence warnings in t/Charset.t Running prove on t/Charset.t had a complaint about a better way to write \c3. This suppresses it. TEST PLAN --------- 1) $ prove t/Charset.t -- get a warning 2) apply patch 3) $ prove t/Charset.t 4) run koha qa test tools Signed-off-by: Indranil Das Gupta Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 10:23:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 08:23:04 +0000 Subject: [Koha-bugs] [Bug 14112] Silence warnings t/Charset.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39014|0 |1 is obsolete| | --- Comment #3 from Indranil Das Gupta --- Created attachment 39015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39015&action=edit Bug 14112: Silence warnings in t/Charset.t Running prove on t/Charset.t had a complaint about a better way to write \c3. This suppresses it. TEST PLAN --------- 1) $ prove t/Charset.t -- get a warning 2) apply patch 3) $ prove t/Charset.t 4) run koha qa test tools Signed-off-by: Indranil Das Gupta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 10:27:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 08:27:02 +0000 Subject: [Koha-bugs] [Bug 14117] Silence warnings t/Search_PazPar2.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38758|0 |1 is obsolete| | --- Comment #2 from Indranil Das Gupta --- Created attachment 39016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39016&action=edit Bug 14117: Silence warnings t/SearchPazPar2.t The use of relative URLS (null actually), triggers warnings. Catch them, instead of letting them loose. TEST PLAN --------- 1) $ prove t/Search_PazPar2.t -- noise for each test currently. 2) apply patch 3) $ prove t/Search_PazPar2.t -- No noise, and extra tests added. -v shows caught warning tests. 4) koha qa test tools. Signed-off-by: Indranil Das Gupta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 10:30:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 08:30:43 +0000 Subject: [Koha-bugs] [Bug 14117] Silence warnings t/Search_PazPar2.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 10:31:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 08:31:15 +0000 Subject: [Koha-bugs] [Bug 14112] Silence warnings t/Charset.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 17:26:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 15:26:21 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38674|0 |1 is obsolete| | --- Comment #17 from Indranil Das Gupta --- Created attachment 39017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39017&action=edit Bug 13993 - (1) Add tests to confirm 'new' and 'cancelled' This adds 2 tests to t/db_dependent/Acquisition/TransferOrder.t in order to confirm the order's status is properly marked. TEST PLAN --------- 1) Log into staff client 2) Acquisitions 3) Create a basket for two differing vendors. 4) Place an order in one of the baskets. 5) Transfer the order from one vendor's basket to the others. 6) Apply this patch (1) only 7) prove -v t/db_dependent/Acquisition/TransferOrder.t -- should fail one test: not marked as 'cancelled'. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 17:26:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 15:26:32 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38675|0 |1 is obsolete| | --- Comment #18 from Indranil Das Gupta --- Created attachment 39018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39018&action=edit Bug 13993 - (2) Correct poorly transferred orders Added Atomic Update to fix poorly transferred orders TEST PLAN --------- 8) Apply patch (2) 9) Run the database updates $ ./installer/data/mysql/updatedatabase.pl -- This should run without error 10) prove -v t/db_dependent/Acquisition/TransferOrder.t -- This should fail, because the transfer function is still not fixed. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 17:27:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 15:27:00 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38676|0 |1 is obsolete| | --- Comment #19 from Indranil Das Gupta --- Created attachment 39019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39019&action=edit Bug 13993 - (3) Transfer order leaves incorrect orderstatus 11) Apply patch (3) 12) Log in to staff client 13) Acquisitions 14) Create a basket for two different vendors 15) Place an order in one vendor's basket. 16) Transfer the order to the other vendor's basket. 17) prove -v t/db_dependent/Acquisition/TransferOrder.t -- This should succeed without intervention. 18) Run koha qa test tools for the last 3 commits. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 17:29:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 15:29:49 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 17:41:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 15:41:52 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 19:24:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 17:24:06 +0000 Subject: [Koha-bugs] [Bug 14176] New: No fine displaying. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14176 Bug ID: 14176 Summary: No fine displaying. Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The bookk has Rs.20/- fine The screen shot taken on 20/4/2015 while check in the book. Eventhough the duedate is 31/3/2015 no fine generated for this student. See the screenshot http://postimg.org/image/wo96tpfdd/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 10 19:30:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 17:30:37 +0000 Subject: [Koha-bugs] [Bug 14177] New: Automatically changing the due date. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14177 Bug ID: 14177 Summary: Automatically changing the due date. Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com As per system we are issuing the books for 25 days but for this student the due date is less than 25 days(book India govt and politics) Screenshot http://postimg.org/image/ilmdt84pl/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 10 19:32:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 17:32:40 +0000 Subject: [Koha-bugs] [Bug 14178] New: System automatically forgiving the fines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14178 Bug ID: 14178 Summary: System automatically forgiving the fines Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com System automatically forgiving the fines without our instruction Screenshot http://postimg.org/image/nn5cry9rl/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 23:42:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 21:42:48 +0000 Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 --- Comment #2 from Indranil Das Gupta --- Created attachment 39020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39020&action=edit Bug 12146 [ENH] Add isocode column to parameters.sql a) Adds currency.isocode column to parameters.sql b) Introduces INR as an option for Koha's EN installation locale in the list of currencies Remarks: The issue of non-mandatory nature of isocode column is already settled via bug 9593, comment 77. Test Plan ========= 1/ create a fresh Koha instance and run the web installer 2/ at step #3 - "Selecting Default Settings", select "Some basic currencies with USA dollar as default for ACQ module" under the section "Optional" to import the sample currencies. 3/ login to this new instance and go to Home -> Administration -> Currencies & Exchange rates 4/ click edit for any of the currency options 5/ ISO code will be blank 6/ Apply patch 7/ Repeat steps 1 to 4 above 8/ ISO code will now show 3-letter ISO codes inserted by patched parameters.sql -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 10 23:45:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 21:45:32 +0000 Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |indradg at gmail.com Assignee|koha-bugs at lists.koha-commun |indradg at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 10 23:54:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 21:54:13 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 00:16:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 22:16:35 +0000 Subject: [Koha-bugs] [Bug 14179] New: Field width for currency.currency is inadequate Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Bug ID: 14179 Summary: Field width for currency.currency is inadequate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P4 Component: Database Assignee: gmcharlt at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org The database field currency.currency is defined as VARCHAR(10) NOT NULL. This needs to be increased e.g. set as VARCHAR(255) NOT NULL. The rationale: a) While it is possible to accomodate 'US Dollar' in that width, for many currencies this space is inadequate e.g. 'East Caribbean Dollar', 'Indian Rupee' or 'Tanzanian Shilling'. b) Further, in the 'New currency' addition form, the maxlength and size attributes are set as 50, and allows user to enter long names as examples above. While saving the record, it is truncated to VARCHAR(10). I propose the following: 1/ Alter the currency.currency field to VARCHAR(255) NOT NULL from VARCHAR(10) NOT NULL. 2/ Change the 'maxlength' attribute in the template to 255 (to match column property) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 00:58:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 22:58:19 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #35 from Robin Sheat --- (In reply to Julian Maurice from comment #34) > About 5.54 vs 6.0, maybe we could ask the author of Swagger2 to change the > required version of Mojolicious (if Swagger2 is proven to work with 5.54 of > course). What do you think ? Will that make things easier ? It certainly would, but it might be the difference between 5 minutes and half and hour, or 5 minutes and 5 weeks :) it remains to be seen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 01:04:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 23:04:11 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 --- Comment #1 from Indranil Das Gupta --- Created attachment 39021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39021&action=edit Bug 14179 - Alters currency field to VARCHAR(255) Alters `currency`.`currency` column from VARCHAR(10) to VARCHAR(255) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 01:12:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 23:12:25 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 --- Comment #2 from Indranil Das Gupta --- Created attachment 39022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39022&action=edit Bug 14179 - Update currency field's maxlength attribute Updates 'maxlength' attribute of field 'currency' in the 'New currency' addition form to 255 and brings it in sync with the field width of corresponding `currency`.`currency` column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 01:46:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 23:46:07 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |indradg at gmail.com Status|NEW |Needs Signoff --- Comment #3 from Indranil Das Gupta --- Test plan (for attachment 39021) ================================ 1/ login to Koha staff client and go to Home -> Administration -> Currencies & Exchange rates 2/ add a new currency - Bhutanese Ngultrum, ISO code BTN, currency symbol Nu. and rate of 0.016) and save it. 3/ the currency name should be truncated as 'Bhutanese ' 4/ apply the patch in attachment 39021 5/ update the db schema by running : % perl installer/data/mysql/updatedatabase.pl 6/ delete currency 'Bhutanese ' 7/ repeat step #2 above 8/ the currency should be saved correctly (without truncation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 01:58:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 May 2015 23:58:51 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 --- Comment #4 from Indranil Das Gupta --- Test plan for attachment 39022 ============================== 1/ login to Koha staff client and go to Home -> Administration -> Currencies & Exchange rates 2/ try to enter a 59 character long fictitious currency name e.g. 'very long imaginary currency name from a fictitious country' 3/ you shouldn't be able to enter more than 'very long imaginary currency name from a fictitiou' (50 characters). do not try to save the record. 4/ apply the patch in attachment 39022 5/ repeat step #2 6/ you should be able to save the entire 59 char long name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 02:08:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 00:08:02 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38584|0 |1 is obsolete| | --- Comment #52 from Srdjan Jankovic --- Created attachment 39023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39023&action=edit bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - removed GetItemsLocationInfo() - added sort_by input param to GetItemsInfo() - VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call with GetItemsInfo() call, passing order_by "cn_sort" * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 02:08:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 00:08:16 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38585|0 |1 is obsolete| | --- Comment #53 from Srdjan Jankovic --- Created attachment 39024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39024&action=edit bug_11213: whitespace correction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 02:08:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 00:08:28 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38586|0 |1 is obsolete| | --- Comment #54 from Srdjan Jankovic --- Created attachment 39025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39025&action=edit bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 02:08:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 00:08:35 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38587|0 |1 is obsolete| | --- Comment #55 from Srdjan Jankovic --- Created attachment 39026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39026&action=edit bug_11213: C4::VirtualShelves::Page::shelf_contents() * Extracted shelf items processing from shelfpage() into a separate sub shelf_contents() in order to be able to test it * Added tests for shelf_contents() with XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 02:08:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 00:08:44 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38588|0 |1 is obsolete| | --- Comment #56 from Srdjan Jankovic --- Created attachment 39027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39027&action=edit bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 02:09:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 00:09:08 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38589|0 |1 is obsolete| | --- Comment #57 from Srdjan Jankovic --- Created attachment 39028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39028&action=edit bug_11213: Added XSLTParse4Display() to Items test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 02:09:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 00:09:19 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38590|0 |1 is obsolete| | --- Comment #58 from Srdjan Jankovic --- Created attachment 39029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39029&action=edit bug_11213: Check for $item->{itype} presence to avoid warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 02:43:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 00:43:15 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39021|0 |1 is obsolete| | --- Comment #5 from Indranil Das Gupta --- Created attachment 39030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39030&action=edit Bug 14179 - Alters currency field to VARCHAR(255) Alters `currency`.`currency` column from VARCHAR(10) to VARCHAR(255) Test plan ========= 1/ login to Koha staff client and go to Home -> Administration -> Currencies & Exchange rates 2/ add a new currency - Bhutanese Ngultrum, ISO code BTN, currency symbol Nu. and rate of 0.016) and save it. 3/ the currency name should be truncated as 'Bhutanese ' 4/ apply the patch in attachment 39021 [details] [review] 5/ update the db schema by running : % perl installer/data/mysql/updatedatabase.pl 6/ delete currency 'Bhutanese ' 7/ repeat step #2 above 8/ the currency should be saved correctly (without truncation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 02:47:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 00:47:13 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39030|0 |1 is obsolete| | --- Comment #6 from Indranil Das Gupta --- Created attachment 39031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39031&action=edit Bug 14179 - Alters currency field to VARCHAR(255) Alters `currency`.`currency` column from VARCHAR(10) to VARCHAR(255) Test plan ========= 1/ login to Koha staff client and go to Home -> Administration -> Currencies & Exchange rates 2/ add a new currency - Bhutanese Ngultrum, ISO code BTN, currency symbol Nu. and rate of 0.016) and save it. 3/ the currency name should be truncated as 'Bhutanese ' 4/ apply the patch 5/ update the db schema by running : % perl installer/data/mysql/updatedatabase.pl 6/ delete currency 'Bhutanese ' 7/ repeat step #2 above 8/ the currency should be saved correctly (without truncation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 02:48:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 00:48:50 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mtompset at hotmail.com --- Comment #7 from M. Tompsett --- I believe the problem of a currency description is in need of a new table, not an increased field width. The currency column is used as a CODE not as a DESCRIPTION, as you are assuming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 02:54:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 00:54:56 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 --- Comment #8 from Indranil Das Gupta --- (In reply to M. Tompsett from comment #7) > I believe the problem of a currency description is in need of a new table, > not an increased field width. The currency column is used as a CODE not as a > DESCRIPTION, as you are assuming. That be the case, giving it a maxlength and size of 50 is highly misleading. No? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 03:17:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 01:17:18 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #9 from M. Tompsett --- (In reply to Indranil Das Gupta from comment #8) > (In reply to M. Tompsett from comment #7) > > I believe the problem of a currency description is in need of a new table, > > not an increased field width. The currency column is used as a CODE not as a > > DESCRIPTION, as you are assuming. > > That be the case, giving it a maxlength and size of 50 is highly misleading. > No? I stand corrected. There is a column ISO code for that. Though, I protest that schema.koha-community.org failed me. ;) Sadly, my iso codes are all null. Please fix that too in this. ;) Oh, and display the ISO code too. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 03:22:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 01:22:51 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 --- Comment #10 from Indranil Das Gupta --- (In reply to M. Tompsett from comment #9) This is what lead me to originally write the patch >From bug 9593, comment 46 : "Moreover, an 'isocode' column had been added in currency table (editable in the pro interface from Administration/Currencies and exchange rates). So the active currency can be picked either through its symbol or through its iso code." >From bug 9593, comment 68 : "I agree, the default data convention is for the "Currency" field to be the ISO code. However, that doesn't mean that everyone is currently following this convention. I *don't* think this is a blocker. I could easily see the Currency being "Brazilian real" while the ISO code would be "BRL". Since not everyone memorizes ISO codes for currency, I think this may be an improvement anyway." and then Galen pointing out in bug 9593, comment 76 : "Note that currency.currency is only a varchar(10)." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 03:24:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 01:24:02 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11939 --- Comment #11 from M. Tompsett --- Added bug 11939, since I posted a nice little script I wrote there. Perhaps you might like it. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 03:24:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 01:24:02 +0000 Subject: [Koha-bugs] [Bug 11939] Sample of currencies with a working active value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14179 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 04:17:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 02:17:28 +0000 Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9593 CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- Bug 9593 is what added the isocode into the currency table. I figure a See Also link might be useful to have. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 04:17:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 02:17:28 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12146 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 06:53:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 04:53:19 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #12 from M. Tompsett --- If I type something more than 255 characters, I get no warnings. I lost the first part of my currency description for something over 255 characters. Is there a way to wrap long descriptions, because my 255 character descriptions make the table impractical to use. I find it strange the description can not be edited. Why? AH! Because of the relationships into aqbooksellers invoiceprice and listprice. Perhaps you need another bug to fix the relation to be on the ISO code, and then this one to fix the width. Because you can't change the width to 255 on this related field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 08:52:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 06:52:37 +0000 Subject: [Koha-bugs] [Bug 14025] Fix 865u-links in the OPAC for NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 --- Comment #3 from Magnus Enger --- (In reply to Magnus Enger from comment #2) > The scope of this bug changed a bit after I made the first comment, please > disregard it. ...where "it" = the first comment (not the bug and the patch :-). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 09:07:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 07:07:30 +0000 Subject: [Koha-bugs] [Bug 14162] Instance creation information on YAML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 09:07:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 07:07:44 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 09:56:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 07:56:38 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking developer |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 10:44:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 08:44:02 +0000 Subject: [Koha-bugs] [Bug 10113] Currency and cost calculation problem in acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10113 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com Severity|enhancement |normal OS|Windows |All -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 10:44:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 08:44:19 +0000 Subject: [Koha-bugs] [Bug 10113] Currency and cost calculation problem in acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10113 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:02:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:02:11 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:02:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:02:14 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34894|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 39032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39032&action=edit Bug 12743: ACQ: default values for catalogue records At the moment, it is possible to create records in acquisitions, but the ACQ framework is only used for items created in this module. This patch allows to defined default values in the ACQ framework for records created on the acquisition module. Test plan: 1/ Make sure you have the ACQ framework created (otherwise create it from the default framework). 2/ Define a default value for a field (for instance 099$z=1). 3/ Go in the acquisition module and create a new order from a new record. 4/ Fill mandatory information and save. 5/ Go on the detail page of this record and verify the default value exist. Signed-off-by: Gaetan Boisson Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:06:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:06:40 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:06:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:06:44 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38411|0 |1 is obsolete| | Attachment #38412|0 |1 is obsolete| | Attachment #38413|0 |1 is obsolete| | Attachment #38414|0 |1 is obsolete| | Attachment #38415|0 |1 is obsolete| | Attachment #38416|0 |1 is obsolete| | Attachment #38417|0 |1 is obsolete| | Attachment #38418|0 |1 is obsolete| | Attachment #38419|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart --- Created attachment 39033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39033&action=edit Bug 11603: Preparation step, cleaning up This patch refactores and adds some good practices: - use Modern::Perl - use Pod::Usage - add POD Signed-off-by: Frederic Demians Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:06:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:06:49 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #63 from Jonathan Druart --- Created attachment 39034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39034&action=edit Bug 11603: Gather print notices - add a csv parameter This patch adds: - the ability to generate a csv file instead of a html file. - a letter_code parameter. >From now you are able to generate a csv file for print notices. Imagine a template notice defined as: cardnumber:patron:email:item <>:<> >:<>:<> You would like to generate a csv file and not a html file. Test plan: - define your ODUE notice for the print template as: cardnumber:patron:email:item <>:<> <>:<>:<> - define overdues rules for a patron category - check 2 items out using a due date in order to generate the overdue notices - check these 2 items in - launch the overdue_notices script - the message_queue table should now contain 2 new entries - launch the gather_print_notices cronjob with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE --letter_code=CHECKIN you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE -d=: will produce 1 csv file in your /tmp/test directory - verify the csv file is correct and contain only 1 csv header column. Signed-off-by: Frederic Demians Signed-off-by: Katrin Fischer QA note: Keep in mind that you can use all placeholders for the csv that you can use for the normal templates. If you normally get the item information from you need to use that. If you can use <> directly, you can also do so in the csv. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:06:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:06:58 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #65 from Jonathan Druart --- Created attachment 39036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39036&action=edit Bug 11603: If a letter code is given, filenames should contain it If you choose to generate print notices for a specific letter code, the generated files should be distinct. The use case is: you want to process print notice for letter codes: overdue1, overdue2 and overdue3. The cronjobs will be: perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue1 --csv --ods --html --delimiter=";" perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue2 --csv --ods --html --delimiter=";" perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue3 --csv --ods --html --delimiter=";" without this patch, the 2 first files will be erased. Signed-off-by: Frederic Demians Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:06:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:06:54 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #64 from Jonathan Druart --- Created attachment 39035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39035&action=edit Bug 11603: Gather print notices - add a ods parameter This patch adds: - the ability to generate an ods file >From now you are able to generate a ods file for print notices. You would like to generate a csv file and not a html file. Test plan: - same as previous patch but test the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods --letter_code=OVERDUE -d=: you should get an error because csv2ods is not installed. Follow the installation instructions and try again the command. A ods file should be generated in your /tmp/test directory. Signed-off-by: Frederic Demians Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:07:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:07:02 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #66 from Jonathan Druart --- Created attachment 39037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39037&action=edit Bug 11603: Fix encoding issues (bug 11944 is now pushed) Signed-off-by: Frederic Demians No more encoding issue with html file, no problem with csv|ods Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:07:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:07:07 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #67 from Jonathan Druart --- Created attachment 39038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39038&action=edit Bug 11603 Add --send|--nosend, fix stuf Fix --html without --letter_code Fix --ods which was producing a 2 lines ods file Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:07:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:07:11 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #68 from Jonathan Druart --- Created attachment 39039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39039&action=edit Bug 11603: Some minor documentation changes Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:07:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:07:15 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #69 from Jonathan Druart --- Created attachment 39040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39040&action=edit Bug 11603: (follow-up) pod The filenames will change Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 12:07:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 10:07:20 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #70 from Jonathan Druart --- Created attachment 39041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39041&action=edit Bug 11603: Change the output filenames The output filename is notices_all_.[html|csv|ods] if no letter_code parameter is given. If 1 is given: notices__.[html|csv|ods] If 1+ are given: noties__...__.[html|csv|ods] Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 13:33:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 11:33:32 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38820|0 |1 is obsolete| | Attachment #38821|0 |1 is obsolete| | Attachment #38822|0 |1 is obsolete| | Attachment #38823|0 |1 is obsolete| | Attachment #38824|0 |1 is obsolete| | --- Comment #232 from Kyle M Hall --- Created attachment 39042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39042&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 13:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 11:33:41 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #233 from Kyle M Hall --- Created attachment 39043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39043&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e opac/svc/patron/ Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 13:33:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 11:33:46 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #234 from Kyle M Hall --- Created attachment 39044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39044&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 13:33:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 11:33:50 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #235 from Kyle M Hall --- Created attachment 39045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39045&action=edit Bug 9303 [QA Followup] - Remove extra 'USE Koha', change "Call number" back to "Call no." Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 13:33:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 11:33:55 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #236 from Kyle M Hall --- Created attachment 39046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39046&action=edit Bug 9303 [QA Followup] - Restore missing biblio relationship -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 13:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 11:33:59 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #237 from Kyle M Hall --- Created attachment 39047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39047&action=edit Bug 9303 [QA Followup] - Restore ability for patron to control setting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 13:46:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 11:46:44 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39047|0 |1 is obsolete| | --- Comment #238 from Kyle M Hall --- Created attachment 39048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39048&action=edit Bug 9303 [QA Followup] - Restore ability for patron to control setting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 14:27:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 12:27:55 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 14:32:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 12:32:06 +0000 Subject: [Koha-bugs] [Bug 14180] New: Make "Always show checkouts immediately" a global setting Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Bug ID: 14180 Summary: Make "Always show checkouts immediately" a global setting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Right now the checkbox is unchecked by default and your setting will be kept during the session. Several libraries have asked to check the checkbox permanently, as it's annoying to redo the checkbox every morning or even several times during the day. One of the librarians reporting this is relying on a screen reader and braille line - which makes the task of rechecking the checkbox in order to be able to read the checkouts even more tedious. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 14:34:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 12:34:39 +0000 Subject: [Koha-bugs] [Bug 3758] Automatic Exchange Rates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3758 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com --- Comment #3 from Indranil Das Gupta --- http://treasury.un.org/operationalrates/UNOperationalRatesRSS.xml seems to be a possible useful source. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 14:34:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 12:34:59 +0000 Subject: [Koha-bugs] [Bug 2889] templates should not use [% IF ( loop.odd ) %] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2889 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 14:56:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 12:56:26 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 --- Comment #1 from Owen Leonard --- (In reply to Katrin Fischer from comment #0) > Several libraries have asked to check the checkbox permanently, as it's > annoying to redo the checkbox every morning or even several times during the > day. I thought Bug 13196 fixed this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 11 15:00:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 13:00:27 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Chris, can you consider this for the next 3.18.x? We have had several libraries asking for it since their update to 3.18 (see bug 14180). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 15:01:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 13:01:26 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 15:01:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 13:01:30 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14180 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 15:01:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 13:01:30 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37492|0 |1 is obsolete| | --- Comment #89 from Maxime Beaulieu --- Created attachment 39049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39049&action=edit Bug 8753 - Add forgot password link to OPAC I've addressed a lot of Liz Rea's points. 1. I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory. 1a. The feature is now off by default when the atomicupdate is run. 2. The password reset link is now visible on the home page, in the modal box and on opac-user.pl . 3. The password recovery pages now use bootstrap markup. 4. I am unsure here. I see "New Password:" and "Confirm new password:". 5. This should still work :). 6. I could not reproduce. 7. I have added the userid field. You can now reset the password by submitting either your useid or email address. Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email). When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid. 8. The text is in the atomicupdate file. Have at it, anyone. Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed. Maybe we could add a sub in Letters.pm that: Takes the same argments as EnqueueLetter Sends the letter. Saves the letter in the message queue with a 'sent' status. TEST PLAN: Setup) 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 2b) make sure that OpacPasswordChange is also ON. A) 1) refresh front page, click on 'Forgot your password' and enter a VALID address 1b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 2) An email should be received at that address with a link. 3) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 4) Go to main page try the new password. B) 1) Repeat the password reset, this time use the userid (username) field. 2) Try to reset the password using a userid and an email not linked to the account. An error appears. 3) Make sure the borrower has many available email addresses. 4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address C) 1) Make sure two borrowers use the same email. 2) Repeat the reset procedure in test case A). An error message appears Author: Maxime Beaulieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 15:01:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 13:01:30 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13196 --- Comment #2 from Katrin Fischer --- Hi Owen, thx for the comment! I have left a comment on the other bug - it's not in 3.18.x and marking ths see also for now to see if it fixes the problem for the library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 15:04:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 13:04:35 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.beaulieu at inlibro.com Assignee|philippe.blouin at inlibro.com |maxime.beaulieu at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 15:09:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 13:09:20 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks for the followup Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 15:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 13:43:42 +0000 Subject: [Koha-bugs] [Bug 13723] OPAC cart not pulling date from RDA tag 264 only tag 260 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13723 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10306 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 15:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 13:43:42 +0000 Subject: [Koha-bugs] [Bug 10306] acquisitions shows publisher from 260 only (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13723 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 11 16:09:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 14:09:20 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 --- Comment #17 from Winona Salesky --- I don't see any reason not to include the 100$j, if no one objects I will add it. -Winona (In reply to Nick Clemens from comment #16) > Okay, fixed what I saw before but noticed new issue: > > -Multiple relator terms/codes do seem to be showing (only shows first $e/$4 > (or $j/$4 for 111) > > Also a question: Should we display 100$j (Attribution qualifier)? I don't > know if I have ever used it, but seems like it should show if present (and > all if repeated) > > I think that is it then, trying to catch all the cases but so many little > details to watch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 16:24:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 14:24:01 +0000 Subject: [Koha-bugs] [Bug 10941] MARC21 documentation links while adding an authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10941 --- Comment #4 from Stefano Bargioni --- (In reply to Pablo AB from comment #3) > Added to JQuery Library on wiki: > http://wiki.koha-community.org/wiki/ > JQuery_Library#MARC21_documentation_links_while_adding_an_authority but in > status=incomplete because it shows also on bibliographic frameworks. > A lot of this JQuery enhancement should be added to Koha... Thx Pablo to adding it to the jQuery Library. I wrapped the code into an IF statement to apply it only in case of auth frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 16:29:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 14:29:06 +0000 Subject: [Koha-bugs] [Bug 14181] New: MARC21 773 -- Display when ind1 = 0 or blank Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Bug ID: 14181 Summary: MARC21 773 -- Display when ind1 = 0 or blank Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: wsalesky at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently 773 is set to display if ind1=0 and is suppressed if ind1 = ''. Patch will change code to display if ind1 != 1. So it will catch both scenarios. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 16:49:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 14:49:25 +0000 Subject: [Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170 --- Comment #2 from Christopher Brannon --- I'm wondering if this ticket should address a more pressing issue. It is really perplexing as to why we are tracking the status of an item in 4 or more tables. I can find the status of an item in the items, reserves, branchtransfers and issues tables, if not others. This is extremely inefficient, and possibly the reason statuses get jumbled in Koha, I'm finding, on a regular basis. Why not have an itemstatus table that keeps track of an item if it is not available? The reserves table should really only keep track of who is next in the reserves. On loan, waiting, transfers, and even damaged, lost, withdrawn, etc could all be tracked in one table. You could even put the status of on cart for recently returned items in this table. This is an area of Koha that could really use some attention and streamlining, in my opinion. If I am wrong, that is fine. I just think it should be discussed more. It just seems like it could be a lot easier to troubleshoot and eliminate dual statuses. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 11 16:53:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 14:53:19 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 16:53:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 14:53:21 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 --- Comment #1 from Winona Salesky --- Created attachment 39050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39050&action=edit Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank Display 773 in opac and staff details when ind1 !=1 Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 773 with ind1 set to 0 or blanks 4) Check display 6) Repeat steps 3 and 4 for the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 17:48:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 15:48:35 +0000 Subject: [Koha-bugs] [Bug 14067] 500 error when deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067 --- Comment #5 from Barton Chittenden --- (In reply to David Cook from comment #4) > (In reply to Barton Chittenden from comment #2) > > Here's the error as found in intranet-error.log > > > > [Mon May 04 08:52:27 2015] [error] [client xx.xx.xx.xx] [Mon May 4 08:52:27 > > 2015] deletemem.pl: DBD::mysql::st execute failed: Column 'cardnumber' > > cannot be null at /usr/local/share/perl/5.10.1/DBIx/Class/Storage/DBI.pm > > line 1834. > > [Mon May 04 08:52:27 2015] [error] [client xx.xx.xx.xx] Premature end of > > script headers: deletemem.pl > > That's an interesting error. When I look at my databases, 'cardnumber' is a > nullable column. I'd suggest looking at Koha::Schema::Result::Borrower.pm > and seeing if "cardnumber" has "is_nullable" set to 1. I'd also check the > actual database to see if it's a nullable column... Yes, borrowers.cardnumber is nullable in the database in question: mysql> describe borrowers; +---------------------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +---------------------+--------------+------+-----+---------+----------------+ | borrowernumber | int(11) | NO | PRI | NULL | auto_increment | | cardnumber | varchar(16) | YES | UNI | NULL | | and in /usr/share/koha/lib/Koha/Schema/Result/Borrower.pm =head2 cardnumber data_type: 'varchar' is_nullable: 1 size: 16 So... I don't know. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 18:02:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 16:02:59 +0000 Subject: [Koha-bugs] [Bug 14067] 500 error when deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067 Arturo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library at sll.texas.gov --- Comment #6 from Arturo --- Our library is experiencing this bug, and to add a little more insight, even though the DB 'cardnumber' field is nullable, we've set our BorrowerMandatoryField sys pref to require a value for the 'cardnumber' field. In our case, we allow self-registrations, and during the self-registration process, a card number is not automatically generated -- we manually add that in later once we review each self-registration. So when we come across a self-registered patron during our workflow whose account we need to delete, we get this error since we are trying to delete the account and it does not have one of the required fields. In other words, I don't think this bug involves a SQL error -- perhaps it is needlessly running a check on required fields before deleting the account? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 18:35:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 16:35:08 +0000 Subject: [Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- It does appear that C4::Circulation::AddIssue closes out any open branch transfers at the time of checkin with the following query: UPDATE branchtransfers SET datearrived = now(), tobranch = ?, comments = 'Forced branchtransfer' WHERE itemnumber= ? AND datearrived IS NULL Where tobranch is the logged in branch. Have you been able to trigger a scenario where the transfer isn't closed out when an item is issued? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 18:55:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 16:55:17 +0000 Subject: [Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170 --- Comment #4 from Christopher Brannon --- No. I cannot tell exactly what causes it to be missed, but we are regularly seeing things like this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 11 18:59:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 16:59:14 +0000 Subject: [Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170 --- Comment #5 from Kyle M Hall --- ModReserveStatus is only called by C4::Circulation::AddReturn, but any open branch transfers are closed out by the same code: 1918 if ($datesent) { 1919 if ( $tobranch eq $branch ) { 1920 my $sth = C4::Context->dbh->prepare( 1921 "UPDATE branchtransfers SET datearrived = now() WHERE itemnumber= ? AND datearrived IS NULL" 1922 ); 1923 $sth->execute( $item->{'itemnumber'} ); 1924 # if we have a reservation with valid transfer, we can set it's status to 'W' 1925 ShelfToCart( $item->{'itemnumber'} ) if ( C4::Context->preference("ReturnToShelvingCart") ); 1926 C4::Reserves::ModReserveStatus($item->{'itemnumber'}, 'W'); 1927 } else { 1928 $messages->{'WrongTransfer'} = $tobranch; 1929 $messages->{'WrongTransferItem'} = $item->{'itemnumber'}; 1930 } 1931 $validTransfert = 1; 1932 } else { 1933 ShelfToCart( $item->{'itemnumber'} ) if ( C4::Context->preference("ReturnToShelvingCart") ); 1934 } ModReserveAffect should probably close out any open transfers in the case it's called to set an item to waiting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 11 20:26:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 18:26:33 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38999|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 39051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39051&action=edit [SIGNED-OFF] Bug 14145: Noisy warns in admin/preferences.pl The problem with the odd number of hashes happens when not everything is selected. The grep returns undef, because it isn't found in @values. By turning the grep into a ternary-operator truth value, we can set a value (1 or 0) expressly. The next problem is when nothing is selected in these multiple lists, $value is undefined, so you can't split it. By splitting the definition of @values from the actual splitting, we can split only if $value is defined, thus eliminating the warning message. TEST PLAN --------- 1) back up your koha error log file 2) blank your koha error log file 3) log in to the staff client 4) Home -> Koha administration -> Global system preferences 5) Click on every tab, EXCEPT local use. 6) notice the koha error log file has warnings. 7) blank the koha error log file again 8) apply this patch 9) Click on every tab, EXCEPT local use, again. 10) notice the koha error log file has no warnings. 11) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel I like more this version Works as described No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 20:26:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 18:26:49 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Attachment #38838|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 20:27:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 18:27:03 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 20:27:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 18:27:14 +0000 Subject: [Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 20:34:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 18:34:31 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 20:34:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 18:34:35 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38319|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 39052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39052&action=edit [SIGNED-OFF] Bug 11064: Hide the framework choice when importing biblio This choice is ignored, it's preferable to hide it. Test plan: 0/ Before to apply the patch, confirm the issue 1/ Stage some records for import and on the detail of the batch (/tools/manage-marc-import.pl?import_batch_id=XXX), confirm the framework dropdown list does not appear anymore. Signed-off-by: Bernardo Gonzalez Kriegel Woks as described, no more dropdown. As stated, is not a fix, only hide the option. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 21:35:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 19:35:50 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Sheila Kearns changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sheila.kearns at state.vt.us --- Comment #1 from Sheila Kearns --- --Kyle, There seems to be a conflict in this test plan for our consortium purposes. HomeOrHolding is set to "the library the item is checked out from" in order to make it possible for the holding library to charge fines and feeds for their patrons according to their own rules--particularly libraries that do not charge fines. However, it is the home libraries that want to be able to decide whether or not a lost item charge gets forgiven if a lost item makes it back to their library. It is completely possible that I do not understand what you are planning to do. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 21:41:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 19:41:47 +0000 Subject: [Koha-bugs] [Bug 14130] column.def should be updated with descriptions for new columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 21:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 19:41:51 +0000 Subject: [Koha-bugs] [Bug 14130] column.def should be updated with descriptions for new columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38826|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 39053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39053&action=edit [SIGNED-OFF] Bug 14130: Update columns.def - Updates columns.def with new columns in items - Adds some descriptions - Corrects some existing column descrpitions To test: - Read the patch to see what has been changed - Run the guided report builder for the 'circulation' module - Observe changes show up Signed-off-by: Bernardo Gonzalez Kriegel Changes show up, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 22:03:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 20:03:09 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Bernardo Gonzalez Kriegel --- Sorry, patch does not apply. Small conflicts, and DB update is not on atomicupdate, perhaps RM can make an exception -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 22:34:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 20:34:20 +0000 Subject: [Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 22:49:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 20:49:02 +0000 Subject: [Koha-bugs] [Bug 14182] New: Suspended holds should show in separate list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14182 Bug ID: 14182 Summary: Suspended holds should show in separate list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be helpful if suspended holds were moved to a separate suspended hold list below the active holds list, or on a separate tab, when reviewing holds on a bib record. They tend to blend together and staff don't always discern what is active and what is suspended. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 11 22:49:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 20:49:39 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Jose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julianescobarmorales at gmail. | |com --- Comment #95 from Jose --- (In reply to Jesse Weaver from comment #1) > Created attachment 19142 [details] [review] > Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC (1/2) > > This adds a new page to the OPAC that can search several Z39.50 targets > using Pazpar2. > > Test plan: > 1) Apply patches. > 2) Update database. > 3) Add one or more Z39.50 targets, using the Administration -> External > targets screen. Note that not all targets support keyword search, but > here are some that do: > * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8 > * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8 > 4) Perform a search on the OPAC, check to see if the "external targets" > notice pops up at the top. > 5) Click on the results link near that message. > 6) This should bring back results from all enabled targets, all of which > should be clickable to bring up a detailed view of the record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 22:57:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 20:57:37 +0000 Subject: [Koha-bugs] [Bug 14183] New: [Koha] z39.50 search refused to connect Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14183 Bug ID: 14183 Summary: [Koha] z39.50 search refused to connect Change sponsored?: --- Product: Koha Version: 3.16 Hardware: PC OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: julianescobarmorales at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl [Connection failed to lx2.loc.gov] I'm using Koha 3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 23:08:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 21:08:34 +0000 Subject: [Koha-bugs] [Bug 11884] SlipCSS and NoticeCSS should be CSS not a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11884 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |barton at bywatersolutions.com --- Comment #3 from Barton Chittenden --- I'm bumping the priority on this -- it causes support issues in hosted environments -- granting partners access to those files, and supporting users who are trying to edit their own files are both pain points. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 23:16:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 21:16:27 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #90 from Liz Rea --- Hi, Spectacular, thanks I'll have another look. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 23:37:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 21:37:02 +0000 Subject: [Koha-bugs] [Bug 14046] CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 23:39:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 21:39:00 +0000 Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the wrong course! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 23:41:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 21:41:04 +0000 Subject: [Koha-bugs] [Bug 14016] Due dates in OPAC show 0:00 when it should be 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 11 23:42:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 21:42:04 +0000 Subject: [Koha-bugs] [Bug 14022] Subscription form resets 'subscription length' to issues on editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 00:10:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 22:10:23 +0000 Subject: [Koha-bugs] [Bug 14008] Filters are not displayed on search for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 00:19:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 22:19:57 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #24 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 00:26:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 22:26:36 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #18 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 00:32:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 22:32:47 +0000 Subject: [Koha-bugs] [Bug 14099] RESERVESLIP shows incorrect information in items.holdingbranch on first scan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099 --- Comment #2 from Christopher Brannon --- So, Kyle, are you saying that scanning the item a 2nd time messes up the transfer? I have seen no evidence of that, and it shouldn't. The process works as expected. It is just the holding branch that appears to be incorrect. But it sounds like you are saying it really isn't incorrect until it is scanned and printed again. Am I understanding that correctly? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 00:35:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 22:35:35 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 00:37:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 22:37:21 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 00:42:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 22:42:00 +0000 Subject: [Koha-bugs] [Bug 14051] Tiny adjustment of ReturnPathDefault pref description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 00:47:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 22:47:54 +0000 Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 01:53:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 May 2015 23:53:58 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com Status|Needs Signoff |In Discussion --- Comment #2 from Indranil Das Gupta --- (In reply to Winona Salesky from comment #0) > Currently 773 is set to display if ind1=0 and is suppressed if ind1 = ''. > Patch will change code to display if ind1 != 1. So it will catch both > scenarios. Apologies in advance for my ignorance. but isn't the point of leaving ind1 as other than 1, is to suppress the display of the note? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 02:06:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 00:06:41 +0000 Subject: [Koha-bugs] [Bug 11356] can't order from suggestions not at my branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11356 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 03:17:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 01:17:35 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39050|0 |1 is obsolete| | --- Comment #3 from Indranil Das Gupta --- Created attachment 39054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39054&action=edit Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank Display 773 in opac and staff details when ind1 !=1 Test plan ========= 1/ Add a new record which uses the 773 field to an instance running master code. (the selected MARC framework should have the 773's relevant sub-fields enabled and visible on staff client, opac and the editor). 2/ Set ind1 as '0' (zero). The note should be displayed both on OPAC as well as the staff client. 3/ Reset ind1 with a non-zero value or leave it blank. The display note should no longer be visible from either client or opac. 4/ Apply the patch. 5/ Repeat step #1 and #2. The note is displayed on staff and opac. 6/ Repeat step #3. The display note should be visible on both staff and opac. 7/ run koha-qa.pl -c 1 -v 2 Note : For #1 above, the following LoC record was used: http://www.loc.gov/marc/bibliographic/examples.html#monographic The patch applied cleanly and performed as expected. The koha-qa.pl gave OK as results. Signed-off-by: Indranil Das Gupta -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 03:18:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 01:18:11 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 03:23:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 01:23:09 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 --- Comment #4 from Winona Salesky --- I believe that coding ind1=0 is to suppress the display, 1 to display, and blank is just a default value. According to my understanding of the LOC rules indicate the element should be displayed as the default, or unless expressly coded as 0. Any other catalogers want to chime in? Thanks! -Winona (In reply to Indranil Das Gupta from comment #2) > (In reply to Winona Salesky from comment #0) > > Currently 773 is set to display if ind1=0 and is suppressed if ind1 = ''. > > Patch will change code to display if ind1 != 1. So it will catch both > > scenarios. > > Apologies in advance for my ignorance. but isn't the point of leaving ind1 > as other than 1, is to suppress the display of the note? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 03:57:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 01:57:19 +0000 Subject: [Koha-bugs] [Bug 14067] 500 error when deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067 --- Comment #7 from David Cook --- I can't reproduce this one on 3.14.5 or master. Barton: I'd suggest checking /usr/local/share/perl/5.10.1/DBIx/Class/Storage/DBI.pm line 1834 I use Perl 5.20.1 and that line doesn't seem relevant in my DBIx::Class::Storage::DBI. Which version of DBIx::Class are you using? It looks like we're using version 0.082810. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 06:17:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 04:17:44 +0000 Subject: [Koha-bugs] [Bug 14184] New: Noisy warns in C4/CourseReserves.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184 Bug ID: 14184 Summary: Noisy warns in C4/CourseReserves.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org If $term is not set and left as undefined there are a couple noisy warns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 06:25:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 04:25:57 +0000 Subject: [Koha-bugs] [Bug 14184] Noisy warns in C4/CourseReserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 06:25:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 04:25:59 +0000 Subject: [Koha-bugs] [Bug 14184] Noisy warns in C4/CourseReserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184 --- Comment #1 from Aleisha Amohia --- Created attachment 39055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39055&action=edit Bug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm This patch sets $term to be an empty string. To test: 1) Go to Course Reserves on the OPAC 2) Notice warns in error log 3) Apply patch 4) Reload page 5) Notice page still works but no warns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 06:29:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 04:29:42 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 --- Comment #23 from Stephen Warren --- The issue I mentioned in comment 20 here was caused by user error. For the record, when I modified my koha-conf.xml to add some lines to fix bug 13396, I didn't realize that the __xxx__ values needed to be replaced with their actual values. It seems there are some fields that contain __xxx__ after koha-create and some that don't... After fixing that and rebuilding the search index, everything seems to be working again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 07:14:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 05:14:59 +0000 Subject: [Koha-bugs] [Bug 14185] New: Noisy warns in opac-readingrecord.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 Bug ID: 14185 Summary: Noisy warns in opac-readingrecord.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org If $limit is left undefined it causes a warn in error log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 07:19:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 05:19:58 +0000 Subject: [Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 07:20:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 05:20:00 +0000 Subject: [Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 --- Comment #1 from Aleisha Amohia --- Created attachment 39056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39056&action=edit Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl This patch sets $limit to be an empty string. To test: 1) On the OPAC, click on your account in the top right (Welcome, 'yourname') 2) Go to 'your reading history' tab 3) Notice warns in error log 4) Apply patch 5) Reload page 6) Notice page still works but no warns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 07:20:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 05:20:15 +0000 Subject: [Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 07:40:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 05:40:13 +0000 Subject: [Koha-bugs] [Bug 14186] New: Noisy warns in opac-reserve.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 Bug ID: 14186 Summary: Noisy warns in opac-reserve.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org If $reservedfor is undefined, a warn comes up in error log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 07:48:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 05:48:21 +0000 Subject: [Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 07:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 05:48:23 +0000 Subject: [Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 --- Comment #1 from Aleisha Amohia --- Created attachment 39057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39057&action=edit Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl This patch sets $reservedfor to an empty string. To test: 1) On the OPAC, do a simple search for an item that will return results (ie by Keyword, search for "a") 2) Click Place Hold on any item 3) Notice warn in error log 4) Apply patch 5) Reload page (attempt to Place Hold) 6) Notice page still works but no warns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 08:36:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 06:36:19 +0000 Subject: [Koha-bugs] [Bug 13839] Force item holds on item type level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13839 --- Comment #2 from Katrin Fischer --- Hi Marcel - can this be closed with the new option in the circulation conditions? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 09:16:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 07:16:38 +0000 Subject: [Koha-bugs] [Bug 14187] New: branchtransfer needs a primary key (id) for DBIx. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Bug ID: 14187 Summary: branchtransfer needs a primary key (id) for DBIx. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 09:16:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 07:16:52 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|branchtransfer needs a |branchtransfer needs a |primary key (id) for DBIx. |primary key (id) for DBIx | |and common sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 09:21:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 07:21:05 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 39058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39058&action=edit Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 09:52:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 07:52:27 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 09:52:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 07:52:56 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 --- Comment #5 from Indranil Das Gupta --- (In reply to Winona Salesky from comment #4) > I believe that coding ind1=0 is to suppress the display, 1 to display, and > blank is just a default value. According to my understanding of the LOC > rules indicate the element should be displayed as the default, or unless > expressly coded as 0. I discussed this with Galen Charlton, after I asked the question here. He agrees with the idea of you patch and said that should be default behavior if not set to 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 10:14:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 08:14:45 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39058|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 39059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39059&action=edit Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 10:21:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 08:21:04 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39059|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 39060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39060&action=edit Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 10:43:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 08:43:08 +0000 Subject: [Koha-bugs] [Bug 14188] New: branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188 Bug ID: 14188 Summary: branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 10:43:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 08:43:17 +0000 Subject: [Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 10:44:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 08:44:05 +0000 Subject: [Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 39061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39061&action=edit Bug 14188 - branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. Because there is no nice way of getting all branchtransfers and putting SQL into tests is VERY VERY BAD, introducing these branchtransfer API calls to conveniently get all transfers data nicely. Unit tests included. TEST PLAN: Run t/db_dependent/Circulation_transfers.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 10:44:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 08:44:19 +0000 Subject: [Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 10:44:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 08:44:30 +0000 Subject: [Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14187 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 10:44:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 08:44:30 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14188 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 11:32:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 09:32:40 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- The plan of attack looks good to me. I am just wondering if the field branches.refund_lost_item_fee_on_return makes sense. Don't you think it would be better to set this rule in the "Circulation and fine rules" page (admin/smart-rules.pl)? It would be easy to change the behavior for all libraries (if only a default rule is defined). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 11:33:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 09:33:00 +0000 Subject: [Koha-bugs] [Bug 13774] Add the unique anchors of news as links in the RSS for news in Opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Viktor Sarge --- Hi Pierre! We discovered that the sandboxes has the opac disabled as public. The RSS stream does link to the correct news item but when the opac require log in you will not be able to see the news. Does the problem persist when you make the opac public in the sysprefs? Another thing to watch our for is that the RSS stream can only expose news that are directed to "all libraries". If you view the news while logged in and only have news directed to a particular library (but none directed to "all libraries" you will get an empty RSS. This need to be handled a bit better, but that's a matter for other patches :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 11:39:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 09:39:48 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #6 from Colin Campbell --- Wonder if there needs to be a unique constraint on itemnumber in issues. Have noticed after losing the old PK constraint that duplicate issues can now occur, in various places ( fines? holds?) I think there are assumptions that only 1 isssue will exist for an itemnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 11:58:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 09:58:09 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 --- Comment #7 from Katrin Fischer --- (In reply to Colin Campbell from comment #6) > Wonder if there needs to be a unique constraint on itemnumber in issues. > Have noticed after losing the old PK constraint that duplicate issues can > now occur, in various places ( fines? holds?) I think there are assumptions > that only 1 isssue will exist for an itemnumber I think a unique for the issues table would make sense. Did you experience double issues? It sounds scary, but I am still hoping we are not doing that, as it looked like not all installations had the PK to begin with. We removed the line from kohastructure quite a while back by accident with: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=91b5a09c6cef398d9ad39ca1ced7d6569a87456b -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 12:09:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 10:09:27 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #36 from Julian Maurice --- Just asked: https://github.com/jhthorsen/swagger2/issues/14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 13:21:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 11:21:14 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 13:23:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 11:23:14 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 13:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 11:23:17 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38910|0 |1 is obsolete| | --- Comment #43 from Bernardo Gonzalez Kriegel --- Created attachment 39062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39062&action=edit [SIGNED-OFF] Bug 1985: Follow up - Add sample letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. Signed-off-by: Bernardo Gonzalez Kriegel Sample letter in all languages No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:03:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:03:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38247|0 |1 is obsolete| | Attachment #38248|0 |1 is obsolete| | Attachment #38249|0 |1 is obsolete| | Attachment #38250|0 |1 is obsolete| | Attachment #38251|0 |1 is obsolete| | Attachment #38252|0 |1 is obsolete| | Attachment #38253|0 |1 is obsolete| | Attachment #38254|0 |1 is obsolete| | Attachment #38255|0 |1 is obsolete| | Attachment #38256|0 |1 is obsolete| | Attachment #38257|0 |1 is obsolete| | Attachment #38258|0 |1 is obsolete| | Attachment #38259|0 |1 is obsolete| | Attachment #38260|0 |1 is obsolete| | Attachment #38261|0 |1 is obsolete| | Attachment #38262|0 |1 is obsolete| | --- Comment #714 from Kyle M Hall --- Created attachment 39063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39063&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:03:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:03:29 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #715 from Kyle M Hall --- Created attachment 39064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39064&action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:03:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:03:38 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #716 from Kyle M Hall --- Created attachment 39065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39065&action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:03:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:03:47 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #717 from Kyle M Hall --- Created attachment 39066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39066&action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:03:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:03:56 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #718 from Kyle M Hall --- Created attachment 39067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39067&action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:03:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:03:58 +0000 Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:04:01 +0000 Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37207|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 39068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39068&action=edit [SIGNED-OFF] Bug 4137: Fix the OPACViewOthersSuggestions behavior This pref does not work at all, the interface let the user choose to list all suggestions, but whatever he chooses the suggestion list is the same. This patch cleans a bit the suggestedby management. There are a lot of cases to test, because linked to 2 prefs: AnonSuggestions and OPACViewOthersSuggestions. 1/ AnonSuggestions = 0 and OPACViewOthersSuggestions = 0 - A non logged in user is not able to purchase a suggestion. - A logged in user is not able to see suggestions made by someone else. 2/ AnonSuggestions = 0 and OPACViewOthersSuggestions = 1 - A non logged in user is not able to purchase a suggestion. - A logged in user is able to see suggestions made by someone else. 3/ AnonSuggestions = 1 and OPACViewOthersSuggestions = 0 - A non logged in user is able to purchase a suggestion. The suggestedby field will be filled with the AnonymousPatron pref value. He is not able to see suggestions, even the ones made by AnonymousPatron. - A logged in user is not able to see suggestions made by someone else. 4/ AnonSuggestions = 1 and OPACViewOthersSuggestions = 1 - A non logged in user is able to purchase a suggestion. He is able to see all suggestions. - A logged in user is able to see suggestions made by someone else. In all cases a logged in user should be able to search for suggestions (except if he is not able to see them). Signed-off-by: Bernardo Gonzalez Kriegel All use cases tested, work as expected No errors Only comment is perhaps (in the future) a gracefull failure when AnonymousPatron is not set, or has '0' value Message is DBIx::Class::ResultSet::create(): Column 'suggestedby' cannot be null at ... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:04:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:04:05 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #719 from Kyle M Hall --- Created attachment 39069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39069&action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:04:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:04:14 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #720 from Kyle M Hall --- Created attachment 39070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39070&action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:04:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:04:22 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #721 from Kyle M Hall --- Created attachment 39071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39071&action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:04:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:04:31 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #722 from Kyle M Hall --- Created attachment 39072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39072&action=edit Bug 6427 - Add & update cron scripts Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:04:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:04:40 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #723 from Kyle M Hall --- Created attachment 39073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39073&action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:04:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:04:49 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #724 from Kyle M Hall --- Created attachment 39074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39074&action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:04:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:04:58 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #725 from Kyle M Hall --- Created attachment 39075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39075&action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:05:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:05:08 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #726 from Kyle M Hall --- Created attachment 39076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39076&action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:05:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:05:17 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #727 from Kyle M Hall --- Created attachment 39077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39077&action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:05:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:05:26 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #728 from Kyle M Hall --- Created attachment 39078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39078&action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:05:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:05:35 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #729 from Kyle M Hall --- Created attachment 39079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39079&action=edit Bug 6427 [QA Followup] - Fix kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:34:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:34:51 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod at lib.auth.gr --- Comment #14 from Theodoros Theodoropoulos --- Very useful enhancement Martin! It is exactly what we need too :) One small suggestion: An extra line that defines dbh is probably required in the beginning of checkpw_shib in case _autocreate has to be called (ie something like: my $dbh = C4::Context->dbh; ) Other than that it's working like a charm for me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:39:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:39:19 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Katrin Fischer --- Hi Theodoros, thx for testing this! I am setting to failed QA for now, as this will need a follow-up from Martin to get further. If you want, you could also sign off his patches as they are and add a follow-up for Martin to check and sign off on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:44:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:44:43 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:44:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:44:45 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #11 from Julian FIOL --- Created attachment 39080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39080&action=edit Bug 14097 : Rollback issue and warning corrected The rollback issue came from '_count' testing. It used a 'DROP TABLE' and 'CREATE TABLE' which implicitly do autocommit. That's why the final rollback could not be. This patch no longer uses t::lib::TestBuilder either because it was the cause of the warning on Comment #1 : "DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:48:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:48:59 +0000 Subject: [Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 14:49:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 12:49:29 +0000 Subject: [Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.fiol at biblibre.com |chris at bigballofwax.co.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 15:25:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 13:25:07 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37354|0 |1 is obsolete| | --- Comment #15 from Bernardo Gonzalez Kriegel --- Created attachment 39081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39081&action=edit [SIGNED-OFF] Bug 4502: Catch software error if no active budget defined TEST PLAN --------- 0) Back up your database. 1) In mysql client: > DROP DATABASE {your koha database name}; > CREATE DATABASE {your koha database name}; > QUIT; 2) Go to the staff client, and install all the default and optional things -- except patrons. :) 3) Log into staff client. 4) Create a patron -> New Patron -> Staff 5) Enter data and Save 6) More -> Set Permissions 7) Make superlibrarian 8) Log out 9) Log in as new superlibrarian 10) Acquisitions -> Budgets -> New Budget 11) Enter a non-active budget with some funds. -- Once saved, it should list in the inactive budgets. 12) Click on the name. 13) Click on one of the Planning submenu options. 14) Click the 'Submit' button in the Filter area. -- This should trigger the blow up. 15) Apply the patch 16) Repeat steps 12-15 -- The kaboom is avoided and a nice message given. NOTE: This does not solve all the problems in this ugly, ugly module area. It does solve the one thing it is meant to: that nasty kaboom. Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 15:26:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 13:26:26 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 15:26:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 13:26:32 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39081|0 |1 is obsolete| | --- Comment #16 from Bernardo Gonzalez Kriegel --- Created attachment 39082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39082&action=edit [SIGNED-OFF] Bug 4502: An attempt to make things more sensible. The reason the budget_period_id was not defined was because in two cases it was not passed! This patch adds those missing parameters. And as a result, cuts out the attempt to default the authcat to '' unless the budget_period_id is defined. Additionally, the start and end months don't seem to be passed, so rather than have it blow up, checking them forces the else case logic. budget_period_id is the budget id. If you have two budgets, you can craft a URL to work with budget_period_id matching those two ids. Anything else should trigger the new error which was modified to reflect more of what the problem is. Follow the test plan in comment #6. Feel free to also to attempt crafting URLs and triggering errors. Signed-off-by: Bernardo Gonzalez Kriegel Well, works and does not explode any more No errors To trigger the new message simply put /cgi-bin/koha/admin/aqplan.pl on your staff page, an intriguing 'Planning for by Asort1' appears :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 15:28:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 13:28:07 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37534|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel --- Created attachment 39083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39083&action=edit [SIGNED-OFF] Bug 4502: Catch software error if no active budget defined TEST PLAN --------- 0) Back up your database. 1) In mysql client: > DROP DATABASE {your koha database name}; > CREATE DATABASE {your koha database name}; > QUIT; 2) Go to the staff client, and install all the default and optional things -- except patrons. :) 3) Log into staff client. 4) Create a patron -> New Patron -> Staff 5) Enter data and Save 6) More -> Set Permissions 7) Make superlibrarian 8) Log out 9) Log in as new superlibrarian 10) Acquisitions -> Budgets -> New Budget 11) Enter a non-active budget with some funds. -- Once saved, it should list in the inactive budgets. 12) Click on the name. 13) Click on one of the Planning submenu options. 14) Click the 'Submit' button in the Filter area. -- This should trigger the blow up. 15) Apply the patch 16) Repeat steps 12-15 -- The kaboom is avoided and a nice message given. NOTE: This does not solve all the problems in this ugly, ugly module area. It does solve the one thing it is meant to: that nasty kaboom. Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 15:28:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 13:28:16 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39082|0 |1 is obsolete| | --- Comment #18 from Bernardo Gonzalez Kriegel --- Created attachment 39084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39084&action=edit [SIGNED-OFF] Bug 4502: An attempt to make things more sensible. The reason the budget_period_id was not defined was because in two cases it was not passed! This patch adds those missing parameters. And as a result, cuts out the attempt to default the authcat to '' unless the budget_period_id is defined. Additionally, the start and end months don't seem to be passed, so rather than have it blow up, checking them forces the else case logic. budget_period_id is the budget id. If you have two budgets, you can craft a URL to work with budget_period_id matching those two ids. Anything else should trigger the new error which was modified to reflect more of what the problem is. Follow the test plan in comment #6. Feel free to also to attempt crafting URLs and triggering errors. Signed-off-by: Bernardo Gonzalez Kriegel Well, works and does not explode any more No errors To trigger the new message simply put /cgi-bin/koha/admin/aqplan.pl on your staff page, an intriguing 'Planning for by Asort1' appears :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 15:31:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 13:31:44 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 --- Comment #6 from Winona Salesky --- Great! Thanks, -Winona (In reply to Indranil Das Gupta from comment #5) > (In reply to Winona Salesky from comment #4) > > I believe that coding ind1=0 is to suppress the display, 1 to display, and > > blank is just a default value. According to my understanding of the LOC > > rules indicate the element should be displayed as the default, or unless > > expressly coded as 0. > > I discussed this with Galen Charlton, after I asked the question here. He > agrees with the idea of you patch and said that should be default behavior > if not set to 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 15:39:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 13:39:36 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 15:39:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 13:39:39 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39080|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 39085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39085&action=edit [SIGNED-OFF] Bug 14097: Rollback issue and warning corrected The rollback issue came from '_count' testing. It used a 'DROP TABLE' and 'CREATE TABLE' which implicitly do autocommit. That's why the final rollback could not be. This patch no longer uses t::lib::TestBuilder either because it was the cause of the warning on Comment #1 : "DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308" Signed-off-by: Bernardo Gonzalez Kriegel Now data is preserved, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 16:23:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 14:23:54 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39008|0 |1 is obsolete| | --- Comment #99 from Bernardo Gonzalez Kriegel --- Created attachment 39086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39086&action=edit [SIGNED-OFF] Bug 5010: Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/it-IT/necessari/notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased again on kohadevbox... Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 16:24:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 14:24:03 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39009|0 |1 is obsolete| | --- Comment #100 from Bernardo Gonzalez Kriegel --- Created attachment 39087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39087&action=edit [SIGNED-OFF] Bug 5010: Fix - replace tab with spaces Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel No errors. Tested what I can, not plack/shibboleth/cas Perhaps this can pass and we can fix any problem later (for 3.22) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 16:24:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 14:24:20 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 16:27:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 14:27:46 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 16:57:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 14:57:54 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Hi, tested and works. One problem, when I click on tag's link, I got a no results found, and "Can't locate YAML/XS.pm in @INC..." Installing YAML::XS (using cpan) solves the problem, but can't understand what is calling or ising that library, and is not a Koha dep. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:00:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:00:59 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:01:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:01:03 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37259|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 39088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39088&action=edit [SIGNED-OFF] Bug 6379: Remove link from unapproved tags At the OPAC, if the tag is not approved, the tag's link did not return any result. This patch removes the link. Test plan: 1/ Set TagsModeration to 'Require' 2/ Create tags at the OPAC 3/ Approve a couple 4/ Confirm that unapproved tags does not have links. Signed-off-by: Bernardo Gonzalez Kriegel works as described, no errors For the (approved) link to work I need to install YAML::XS -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:09:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:09:23 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:09:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:09:23 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:09:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:09:25 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 --- Comment #2 from Martin Persson --- Created attachment 39089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39089&action=edit Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 100 years from the current date. Default value selected is current date minus 15 years; this assumes that 15 years is a common age for new patrons. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The default selected date will be current date minus one. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The default selected date should be current year minus 15. - The year selection drop-down should show current year minus 100. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:09:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:09:32 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #244 from Tom?s Cohen Arazi --- Created attachment 39090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39090&action=edit Bug 7143: Small fix on the 3.20 release team Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:14:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:14:00 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |xarragon at gmail.com |ity.org | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:15:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:15:15 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:15:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:15:18 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39090|0 |1 is obsolete| | --- Comment #245 from Bernardo Gonzalez Kriegel --- Created attachment 39091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39091&action=edit [SIGNED-OFF] Bug 7143: Small fix on the 3.20 release team Signed-off-by: Tomas Cohen Arazi Signed-off-by: Bernardo Gonzalez Kriegel Magnus is alone, no errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:18:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:18:06 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:18:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:18:10 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35674|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 39092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39092&action=edit Bug 13486: Apache version empty in about page if Apache 2.4 This patch makes about.pl query the running Apache version using the apache2ctl command. I tested it on Apache 2.2 and is backwards compatible (it is present in both). To test: ( On an Apache 2.4 setup ) - Go to the about page => FAIL: "Apache version:" is empty - Apply the patch - Reload the page => SUCCESS: "Apache version:" shows the correct version. - Sign off :-D If you have an Apache 2.2 setup to try it, verify that there are no regressions (trivial because you can run apache2ctl manually and verify the first result is the expecte). Regards PS. I even changed the order in which Apache version is tested because most people is using Debian/Ubuntu and it was the last option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:34:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:34:17 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #1 from Marcel de Rooy --- Created attachment 39093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39093&action=edit Bug 13437: Perltidy marc21_linking_section Preliminary work before converting to new plugin style. Test plan: Run perltidy -pro=xt/perltidyrc on marc21_linking_section and compare. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:51:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:51:53 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:51:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:51:56 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39092|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 39094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39094&action=edit [SIGNED-OFF] Bug 13486: Apache version empty in about page if Apache 2.4 This patch makes about.pl query the running Apache version using the apache2ctl command. I tested it on Apache 2.2 and is backwards compatible (it is present in both). To test: ( On an Apache 2.4 setup ) - Go to the about page => FAIL: "Apache version:" is empty - Apply the patch - Reload the page => SUCCESS: "Apache version:" shows the correct version. - Sign off :-D If you have an Apache 2.2 setup to try it, verify that there are no regressions (trivial because you can run apache2ctl manually and verify the first result is the expecte). Regards PS. I even changed the order in which Apache version is tested because most people is using Debian/Ubuntu and it was the last option. Signed-off-by: Bernardo Gonzalez Kriegel Tested with apache 2.2/2.4, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 17:57:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 15:57:23 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #2 from Marcel de Rooy --- Created attachment 39095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39095&action=edit Bug 13437: Preliminary changes for marc21 plugins field 008 Preliminary work on marc21_field_008.pl and 008_authorities.pl. Moving $dateentered en $defaultval to lower scope level. Test plan: Use both plugins in the marc21 editor (biblios/authorities). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 18:15:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 16:15:42 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #3 from Marcel de Rooy --- Still more to come..Please wait -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 18:43:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 16:43:06 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 18:43:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 16:43:09 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37981|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 39096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39096&action=edit Bug 13948 - Add ability to dump template toolkit variables to html comment It would be incredibly helpful if we could easily enable Koha to dump all Template Toolkit variables to a comment for debugging purposes. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preferences DumpTemplateVarsIntranet and DumpTemplateVarsOpac 4) Load a page in the staff intranet, view the html source 5) Note the template toolkit variables are embedded in an html comment 6) Load a page in the opac, view the html source 7) Note the template toolkit variable are embedded in an html comment NOTE: I had to cpan2deb Template::Plugin::Stash to test. This is not optimal. Additionally: http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html does not contain Stash. I suspect this was how it was introduced initially by TT. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 18:43:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 16:43:16 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 --- Comment #10 from Kyle M Hall --- Created attachment 39097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39097&action=edit Bug 13948 [QA Followup] - Make dependency optional -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:04:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:04:34 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39089|0 |1 is obsolete| | --- Comment #3 from Eivin Giske Skaaren --- Created attachment 39098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39098&action=edit Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 100 years from the current date. Default value selected is current date minus 15 years; this assumes that 15 years is a common age for new patrons. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The default selected date will be current date minus one. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The default selected date should be current year minus 15. - The year selection drop-down should show current year minus 100. Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:05:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:05:24 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |eskaaren at yahoo.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:11:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:11:42 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:11:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:11:50 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36105|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel --- Created attachment 39099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39099&action=edit [SIGNED-OFF] Bug 6499: Add Zebra index "Other-control-number" covering MARC21 035$a, 035$z and 035 (entire tag) 1) Apply patch 2) Make sure that you have a bib that has MARC21 035$a (and possibly also 035$z) populated. pre 3) Replace all modified zebra files and restart zebra server 3) Rebuild zebra: misc/migration_tools/rebuild_zebra.pl -x -b -z 4) Add the following to the intranetuserjs syspref: $(document).ready(function(){ // Add Other Control Number to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append(''); } }); 5) Do an advanced search, select "Other Control Number" from the search menu, then add the Other Control Number in 035$a for the bib specified in step 1. Signed-off-by: Bernardo Gonzalez Kriegel Works, no koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:14:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:14:49 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 --- Comment #11 from M. Tompsett --- (In reply to Kyle M Hall from comment #10) > Created attachment 39097 [details] [review] > Bug 13948 [QA Followup] - Make dependency optional This doesn't answer the implied question from what I wrote: "Additionally: http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html does not contain Stash. I suspect this was how it was introduced initially by TT." Do you even need to mention it? Is not stash already part of TT? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:30:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:30:20 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34196|0 |1 is obsolete| | --- Comment #211 from Bernardo Gonzalez Kriegel --- Created attachment 39100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39100&action=edit [SIGNED-OFF] Bug 6679 - Fixing code so it passes basic Perl:::Critic tests opac/ilsdi.pl: Stricture disabled at line 217, column 17. See page 429 of PBP. (Severity: 5) Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:30:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:30:35 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34197|0 |1 is obsolete| | --- Comment #212 from Bernardo Gonzalez Kriegel --- Created attachment 39101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39101&action=edit [SIGNED-OFF] Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:32:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:32:30 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:32:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:32:34 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34194|0 |1 is obsolete| | --- Comment #213 from Bernardo Gonzalez Kriegel --- Created attachment 39102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39102&action=edit Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Record.pm Expression form of "eval" at line 358, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 367, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 510, column 3. See page 161 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Fixed conflict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:55:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:55:23 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > The plan of attack looks good to me. > I am just wondering if the field branches.refund_lost_item_fee_on_return > makes sense. > Don't you think it would be better to set this rule in the "Circulation and > fine rules" page (admin/smart-rules.pl)? It would be easy to change the > behavior for all libraries (if only a default rule is defined). I was wondering that myself Jonathan. I'll look into it, seems like a good idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:57:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:57:47 +0000 Subject: [Koha-bugs] [Bug 12366] Better handling of Zebra errors when searching empty indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12366 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:58:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:58:05 +0000 Subject: [Koha-bugs] [Bug 14189] New: Make text persist/populate hidden fields for the Staff searchbox Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Bug ID: 14189 Summary: Make text persist/populate hidden fields for the Staff searchbox Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: eskaaren at yahoo.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Sponsored by Halland County Library. When clicking the tabs under the search box the currently typed value does not persist since hidden fields are used. Users of the system are interested in that the text is populated to the hidden fields so that they don't have to type it in again if they for example had the wrong tab selected when searching the first time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:59:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:59:00 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |eskaaren at yahoo.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 19:59:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 17:59:30 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 20:16:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 18:16:25 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38993|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 39103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39103&action=edit Bug 14167 - Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the /path/to/log4perl.conf line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from DEBUG to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 20:19:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 18:19:06 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- Nice concise bit of code here adding a long needed logger to koha in as simple a way as possible using a well developed lib. Lets make the choice and get this rolling! Minor comments, I can't fully remember how the package building get put together.. but I 'think' we need a copy of the log4perl.conf file that's added here also adding under the debian dir somewhere. I'll try and dig out my notes to advise, assuming Tomas or Robin don't beat me to it. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 20:23:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 18:23:52 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #11 from Tom?s Cohen Arazi --- (In reply to Martin Renvoize from comment #10) > Nice concise bit of code here adding a long needed logger to koha in as > simple a way as possible using a well developed lib. > > Lets make the choice and get this rolling! > > Minor comments, I can't fully remember how the package building get put > together.. but I 'think' we need a copy of the log4perl.conf file that's > added here also adding under the debian dir somewhere. > > I'll try and dig out my notes to advise, assuming Tomas or Robin don't beat > me to it. ;) Indeed, for the packages we will need to: - Add a template file into debian/templates/(logger4perl-site.conf.in ?) - Tweak the debian/scripts/koha-create script so it correctly puts the template file with the right variable substitutions. - Maybe add some switches controlling the logging configuration, but this could go into a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 20:24:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 18:24:07 +0000 Subject: [Koha-bugs] [Bug 12681] Shibboleth attributes may contain lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 20:24:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 18:24:42 +0000 Subject: [Koha-bugs] [Bug 14034] User logged out on refresh after Shibboleth authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 20:30:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 18:30:17 +0000 Subject: [Koha-bugs] [Bug 14035] Shibboleth SingleSignOut In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14035 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 20:33:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 18:33:31 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Thanks Mark, will take a quick test but looks good from a quick read. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 20:33:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 18:33:47 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #1 from Eivin Giske Skaaren --- Created attachment 39104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39104&action=edit Added the functionality to most staff header search boxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 20:42:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 18:42:34 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #16 from Martin Renvoize --- Thanks Theodoros, Think that must have crept in amongst the various rebases/iterations.. >From a quick read of the code I actually thing the $dbh param can be removed from both the calling line and the sub unless I'm mistaken as it doesn't appear to be called upon at anywhere. I'll do a quick test and a followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 20:49:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 18:49:28 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39104|0 |1 is obsolete| | --- Comment #2 from Eivin Giske Skaaren --- Created attachment 39105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39105&action=edit Bug 14189 - Make text persist/populate hidden fields for the Staff searchbox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 20:49:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 18:49:53 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #3 from Eivin Giske Skaaren --- Created attachment 39106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39106&action=edit Added the functionality to most staff header search boxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 21:02:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 19:02:18 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39105|0 |1 is obsolete| | Attachment #39106|0 |1 is obsolete| | --- Comment #4 from Eivin Giske Skaaren --- Created attachment 39107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39107&action=edit Made text persist when clicking the tabs under the searchbox To test: Apply the patch and see that the text now is there in the search box when clicking the tabs: check in, check out etc.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 21:17:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 19:17:15 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39107|0 |1 is obsolete| | --- Comment #5 from Eivin Giske Skaaren --- Created attachment 39108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39108&action=edit Made text persist when clicking the tabs under the searchbox To test: Apply the patch and see that the text now is there in the search box when clicking the tabs: check in, check out etc.. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 21:32:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 19:32:08 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 21:46:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 19:46:42 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I think Sheila has a good point - maybe the dependence on HomeOrHolding is not the best option here and we need something that is a bit more flexible? Only other thing is maybe the column name - refund_lost_item_fee_on_return is quite a bit to write, maybe just refund_lost_on_return? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 12 22:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 20:06:02 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #101 from M. Tompsett --- (In reply to Bernardo Gonzalez Kriegel from comment #100) > Tested what I can, not plack/shibboleth/cas For plack: https://github.com/digibib/kohadevbox (Because I don't understand how to get it installed by default either) For shibboleth: I figure the tests are good enough, but you need Test::DBIx::Class (which I believe is in the kohadevbox :) ) For cas: Again, I just assumed the tests were good enough. > Perhaps this can pass and we can fix any problem later (for 3.22) Yes, please. :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 22:49:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 20:49:40 +0000 Subject: [Koha-bugs] [Bug 14190] New: Scale search boxes in staff head Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Bug ID: 14190 Summary: Scale search boxes in staff head Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: viktor.sarge at regionhalland.se QA Contact: testopia at bugs.koha-community.org I've had pointed out to me that the search boxes in the head of the staff interface in unnecessarily small. For catalog search it could even shape the expectation of how many search terms is expected and unconsciously steer librarians towards broader searches. Since screens is often bigger these days and the area right of the search box is unused it seems a bit conservative to go with "size 40". I suggest that we make the container float up to some max size and then let the individual search boxes be for example size 60 but also have the CSS rule of "width:100%" to resize with the container. That way it will use the space better, scale up and down and still not become ridiculously huge on a 27". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 23:41:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 21:41:22 +0000 Subject: [Koha-bugs] [Bug 14191] New: Noisy warns in C4/XSLT.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191 Bug ID: 14191 Summary: Noisy warns in C4/XSLT.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org "Use of uninitialized value in numeric eq" at an if statement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 23:45:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 21:45:10 +0000 Subject: [Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 12 23:45:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 21:45:12 +0000 Subject: [Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191 --- Comment #1 from Aleisha Amohia --- Created attachment 39109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39109&action=edit Bug 14191: Use of operators causing warn in C4/XSLT.pm In this if statement causing the warns, || is used in the left arguments. This patch changes these to // as I think this is essentially the same thing. I don't know that this is the best way to fix this but it silences the warns. To test: 1) On the OPAC, do a simple search for an item that will return results (ie by Keyword, search for "a") 2) Notice the warns in the error log 3) Apply patch 4) Reload page (search for "a") 5) Notice page still works but no warns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 00:03:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 22:03:04 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #12 from Robin Sheat --- How does this compare to bug 13413? As for the packaging stuff, what Tom?s says looks like the right idea to me, it shouldn't be too complicated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 00:30:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 May 2015 22:30:01 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39108|0 |1 is obsolete| | --- Comment #6 from Eivin Giske Skaaren --- Created attachment 39110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39110&action=edit Made text persist when clicking the tabs under the searchbox To test: Apply the patch and see that the text now is there in the search box when clicking the tabs: check in, check out etc.. (More files changed for persistent text in searchbox) Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 02:16:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 00:16:02 +0000 Subject: [Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39056|0 |1 is obsolete| | --- Comment #2 from Indranil Das Gupta --- Created attachment 39111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39111&action=edit Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl This patch sets $limit to be an empty string. Test plan ========= 1/ login into the opac using your user account credentials 2/ in a terminal, run a `tail -f ` on your instance's opac-error.log 3/ go back to the opac, click on 'your reading history' tab to go to opac-readingrecord.pl 4/ notice the warning - "opac-readingrecord.pl: Use of uninitialized value $limit" appear in the `tail`ed opac-error.log 5/ apply the patch 6/ reload the page (opac-readingrecord.pl) 7/ page works but the warning in step #4 is no longer logged 8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error Remarks: Testing result match expected test plan output. The QA tests pass with "OK" for the commit. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 02:19:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 00:19:14 +0000 Subject: [Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 05:02:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 03:02:48 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #102 from M. Tompsett --- (In reply to M. Tompsett from comment #101) > For shibboleth: I figure the tests are good enough, but you need > Test::DBIx::Class (which I believe is in the kohadevbox :) ) Debug and make sense of this to get it in. sudo apt-get install dh-make-perl libdata-visitor-perl libdbix-class-timestamp-perl libdatetime-format-sqlite-perl libdatetimex-easy-perl libtype-tiny-perl libyaml-tiny-perl libmoox-handlesvia-perl libtest-fatal-perl libclass-dbi-perl libmoosex-types-path-class-perl libmoosex-types-json-perl libmoosex-types-loadableclass-perl libtime-piece-mysql-perl libmath-base36-perl libcpanel-json-xs-perl libclass-accessor-lite-perl libfile-copy-recursive-perl libtest-sharedfork-perl libtest-deep-perl libdata-uuid-perl libdbix-class-uuidcolumns-perl libtest-differences-perl libdbd-mysql mysql-server libdatetime-format-mysql-perl cpan2deb MooseX::Attribute::ENV cpan2deb DBD::SQLite cpan2deb MooX::HandlesVia cpan2deb DBIx::Class::Schema::PopulateMore cpan2deb Test::mysqld cpan2deb Test::DBIx::Class -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 05:27:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 03:27:44 +0000 Subject: [Koha-bugs] [Bug 14192] New: Noisy warns in Koha/XSLT_Handler.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14192 Bug ID: 14192 Summary: Noisy warns in Koha/XSLT_Handler.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Module isn't locating XSLT file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 06:14:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 04:14:49 +0000 Subject: [Koha-bugs] [Bug 1811] Zebra search stops working with Zebra 2.0.26 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1811 Rupesh kabra changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roopkabra at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 06:44:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 04:44:07 +0000 Subject: [Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 --- Comment #3 from M. Tompsett --- Comment on attachment 39111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39111 Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl Review of attachment 39111: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14185&attachment=39111) ----------------------------------------------------------------- ::: opac/opac-readingrecord.pl @@ +73,4 @@ > > > my $limit = $query->param('limit'); > +$limit //= ''; This works, but why not add "// ''" to line 75? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 06:56:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 04:56:49 +0000 Subject: [Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 --- Comment #4 from Aleisha Amohia --- (In reply to M. Tompsett from comment #3) > Comment on attachment 39111 [details] [review] > Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl > > Review of attachment 39111 [details] [review]: > ----------------------------------------------------------------- > > ::: opac/opac-readingrecord.pl > @@ +73,4 @@ > > > > > > my $limit = $query->param('limit'); > > +$limit //= ''; > > This works, but why not add "// ''" to line 75? I'm still very new to perl and had seen this warn solved this way before so just did it again. Of course if you think your way is cleaner then do that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 09:16:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 07:16:11 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 09:16:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 07:16:13 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #7 from Magnus Enger --- Created attachment 39112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39112&action=edit Bug 14189 - [SIGNED-OFF] Made text persist when clicking the tabs under the searchbox To test: Apply the patch and see that the text now is there in the search box when clicking the tabs: check in, check out etc.. (More files changed for persistent text in searchbox) Sponsored-by: Halland County Library http://bugs.koha-community.org/show_bug.cgi?id=14189 Signed-off-by: Magnus Enger This is something I have wanted quite a few times over the years... Tested by going to every main area of Koha, entering some random text into the search box and then clicking on all the available tabs to check that the entered text is carried over to all the boxes. There are a couple of places where text is not carried over, but I guess that might be because one of the boxes is structurally different to the others. These are: - "Vendor search" and "Orders search" in Acquisitions - "Search subscriptions" in Serials I have not looked at how this is implemented, just that it works as it should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 09:17:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 07:17:12 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no Attachment #39110|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 10:25:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 08:25:15 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #8 from Eivin Giske Skaaren --- What Magnus discovered with the few places it is not implemented was done intentionally as it did not make sense from a UX perspective for example when there is 2 search boxes on one tab and 1 on the other. It should work for most daily use cases where this would be helpful. The templates should probably at some point be refactored since there was some duplication of HTML, but that is not needed for this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 10:26:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 08:26:16 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 --- Comment #8 from Katrin Fischer --- I have tried to check the checkbox with jQuery, but it doesn't work quite right - the checkbox is checked, but the checkouts don't load... I think this patch would improve things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 10:46:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 08:46:36 +0000 Subject: [Koha-bugs] [Bug 14193] New: Accessibility: Searching patrons using the alphabetic index doesn't work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Bug ID: 14193 Summary: Accessibility: Searching patrons using the alphabetic index doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It's not possible to use the alphabetic index search using only the keyboard. The librarian reporting this is using braille line, screenreader and keyboard for navigating and using Koha. After selecting a character from the alphabetic index list and pressing enter to trigger the feature, the table of patrons is loaded, but it always shows 'no results found', even if there are patrons for that letter in the database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 10:49:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 08:49:16 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 --- Comment #9 from Katrin Fischer --- Argh, I see now that this is already in 3.18. Sorry for the confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 10:50:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 08:50:31 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 --- Comment #3 from Katrin Fischer --- I realized that the patch Owen pointed to is already in 3.18, but this is still a problem to the library - maybe because of restrictive cookie settings? In general it would be nice if there was an option to just always load and get rid of the checkbox for some libraires. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 11:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 09:12:40 +0000 Subject: [Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 11:21:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 09:21:10 +0000 Subject: [Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 --- Comment #2 from Indranil Das Gupta --- Comment on attachment 39057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39057 Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl Review of attachment 39057: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14186&attachment=39057) ----------------------------------------------------------------- Hi Aleisha, Would you be considering making the small change mtompset at hotmail.com suggested in bug 14185, comment 3 for this patch? If you do, then I'll wait for your update, before I sign off on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 11:21:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 09:21:25 +0000 Subject: [Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 11:21:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 09:21:55 +0000 Subject: [Koha-bugs] [Bug 14184] Noisy warns in C4/CourseReserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 11:28:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 09:28:28 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |wsalesky at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 11:36:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 09:36:42 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 12:26:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 10:26:41 +0000 Subject: [Koha-bugs] [Bug 14192] Noisy warns in Koha/XSLT_Handler.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14192 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #0) > Module isn't locating XSLT file. Please provide more information. Or copy the error log line here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 12:51:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 10:51:47 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #5 from Kyle M Hall --- (In reply to Katrin Fischer from comment #4) > I think Sheila has a good point - maybe the dependence on HomeOrHolding is > not the best option here and we need something that is a bit more flexible? > > Only other thing is maybe the column name - refund_lost_item_fee_on_return > is quite a bit to write, maybe just refund_lost_on_return? :) (In reply to Jonathan Druart from comment #2) > The plan of attack looks good to me. > I am just wondering if the field branches.refund_lost_item_fee_on_return > makes sense. > Don't you think it would be better to set this rule in the "Circulation and > fine rules" page (admin/smart-rules.pl)? It would be easy to change the > behavior for all libraries (if only a default rule is defined). Jonathan, I believe moving this to the circulation rules is at odds with what Sheila is looking for. The only way to make both work will be to add a new system preference to choose which circulation rule to select. Something like RefundLostOnReturnControl. The options could be CheckinLibrary, PatronLibrary, ItemHomeBranch and ItemHoldingbranch. What do you think? Given this, should we still make this a circulation rule setting? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 12:52:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 10:52:26 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #6 from Kyle M Hall --- (In reply to Katrin Fischer from comment #4) > I think Sheila has a good point - maybe the dependence on HomeOrHolding is > not the best option here and we need something that is a bit more flexible? See above for a new idea! > Only other thing is maybe the column name - refund_lost_item_fee_on_return > is quite a bit to write, maybe just refund_lost_on_return? :) Sure! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 13 12:56:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 10:56:58 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 13:05:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 11:05:01 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #13 from Kyle M Hall --- (In reply to Robin Sheat from comment #12) > How does this compare to bug 13413? > > As for the packaging stuff, what Tom?s says looks like the right idea to me, > it shouldn't be too complicated. The biggest advantages of this patch vs bug 13413 are a) Simplicity of implementation b) Incredibly powerful configurability by just editing a configuration file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 13:11:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 11:11:44 +0000 Subject: [Koha-bugs] [Bug 13839] Force item holds on item type level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #2) > Hi Marcel - can this be closed with the new option in the circulation > conditions? Yes, I assume so :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 14:03:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 12:03:19 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #37 from Julian Maurice --- New version of Swagger2 on CPAN (0.31) now requires Mojolicious 5.54 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 14:37:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 12:37:36 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 14:37:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 12:37:44 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 14:52:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 12:52:31 +0000 Subject: [Koha-bugs] [Bug 11599] itemBarcodeFallbackSearch should work even for items that don't have barcodes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11599 Jeremy Evans changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Jeremy.evans at nibsc.org --- Comment #2 from Jeremy Evans --- I encountered this problem earlier. We had received a couple of new books required urgently by one of our users so they were sent straight to him. Therefore I was not able to put a barcode into the books when cataloguing/issuing them. When I tried to issue them to the user the books did not appear on the list of titles if I did a title search in the checkout. one other point - a filter on the holding library would be useful here as it brings up a long list of items held by other branches without giving details of the location. I got round the issuing problem using the method Galen mentioned - i.e. using a dummy barcode in the format of temp1234. On the default item view screen there is a place hold button so maybe an additional checkout link from there would be another useful way to handle these items. Or a checkout link from the list of holds? The barcode not being in the book/item record when it is returned would not be a problem for us - as we would at that point edit the item to put in a barcode number. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:12:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:12:18 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38926|0 |1 is obsolete| | --- Comment #326 from Bernardo Gonzalez Kriegel --- Created attachment 39113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39113&action=edit [SIGNED-OFF] Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:12:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:12:33 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38927|0 |1 is obsolete| | --- Comment #327 from Bernardo Gonzalez Kriegel --- Created attachment 39114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39114&action=edit [SIGNED-OFF] Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:12:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:12:51 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38928|0 |1 is obsolete| | --- Comment #328 from Bernardo Gonzalez Kriegel --- Created attachment 39115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39115&action=edit [SIGNED-OFF] Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:13:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:13:06 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38929|0 |1 is obsolete| | --- Comment #329 from Bernardo Gonzalez Kriegel --- Created attachment 39116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39116&action=edit [SIGNED-OFF] Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:13:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:13:27 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38930|0 |1 is obsolete| | --- Comment #330 from Bernardo Gonzalez Kriegel --- Created attachment 39117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39117&action=edit [SIGNED-OFF] Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:13:44 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38931|0 |1 is obsolete| | --- Comment #331 from Bernardo Gonzalez Kriegel --- Created attachment 39118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39118&action=edit [SIGNED-OFF] Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:14:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:14:00 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38932|0 |1 is obsolete| | --- Comment #332 from Bernardo Gonzalez Kriegel --- Created attachment 39119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39119&action=edit [SIGNED-OFF] Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:14:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:14:17 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38933|0 |1 is obsolete| | --- Comment #333 from Bernardo Gonzalez Kriegel --- Created attachment 39120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39120&action=edit [SIGNED-OFF] Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN --------- 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:14:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:14:37 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38934|0 |1 is obsolete| | --- Comment #334 from Bernardo Gonzalez Kriegel --- Created attachment 39121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39121&action=edit [SIGNED-OFF] Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, in that the protocol is assumed in the OpacBaseURL system preference. It also adds improved error handling. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:14:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:14:54 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38935|0 |1 is obsolete| | --- Comment #335 from Bernardo Gonzalez Kriegel --- Created attachment 39122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39122&action=edit [SIGNED-OFF] Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:15:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:15:12 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38936|0 |1 is obsolete| | --- Comment #336 from Bernardo Gonzalez Kriegel --- Created attachment 39123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39123&action=edit [SIGNED-OFF] Bug 6874: Catch warnings for clean tests. I hate noisy tests, so I cleaned them up. MEGA TEST PLAN -------------- git checkout -b bug_6874 origin/master git bz apply 6874 -- yes, it should all apply smoothly. I intentionally restored an old backup from a couple months ago to force the upgrade. staff client: -- upgrade -- login Koha administration MARC Bibliographic framework MARC structure (for BKS) Search for 856 Subfields Edit (for u) Other options Plugin: upload.pl Save changes Search the catalog tab {choose a word, any word. I used fancy, because I knew we had a cookbook} click first link Edit Edit record 8 (that's the tab name) click the name for 856 scroll down to u and click the plugin icon -- Correctly got a configuration error message. At a command prompt: vi ~/koha-dev/etc/koha-conf.xml /enable_plug -- add in: {appropriate path. I used /home/mtompset/uploads} :wq mkdir {appropriate path used} -- I even added some subdirectories sudo chown -R -v www-data.www-data {appropriate path used} Back in staff client: click the plugin icon again -- this time an upload screen pops up click the 'Upload file' button -- message about no file or destination browse for a file, select one click the 'Upload file' button -- message about no destination click the 'Cancel' button click the plugin icon click a destination radio button click the 'Upload file' button -- message about no file browse for a file, select one click the 'Upload file' button -- message about success click the 'close' button. -- the text box has been filled in with a nice URL click the plugin icon click cancel click the plugin icon click delete -- the test box should be blanked, and a success message given click Close -- reupload a file properly click the plugin icon click delete click upload file browse for a file, select a destination, click upload file click close on success message click 'Clone this subfield' click the second plugin icon click delete click close click the first plugin icon -- Nice error message about a URL which points to nothing. click cancel In the second 856$u type in a URL (eg. www.google.com) click the second plugin icon -- this jumps immediately to the upload screen, but does not give an error message, because the URL does not have opac-retrieve-file in it. click save (we need to save the bibliographic record) In OPAC: search for the same word (I used fancy) find the entry you just updated with links click the two links. The dangling entry should give you a 500 error, and the other link should work just fine. get back to the detail page In staff client: edit edit record 8 change the 856$u to a valid file in the first link. save In OPAC: refresh the detail page, and click the first link again this time it should get downloaded nicely. >From a command line: prove -v t/db_dependent/UploadedFiles.t perldoc C4::Biblio perldoc C4::UploadedFiles One more round of tests tomorrow, and this should be ready. :) Signed-off-by: Bernardo Gonzalez Kriegel Tested on top of 5010 Followed mostly mega test plan, seems to work :) Can upload, delete, modify, etc Test runs Ok No koha-qa errors I view this as valuable addition, dangling since 2011! As with 5010, I consider this can be pushed (for 3.22) and we can fix anything wrong later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:16:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:16:05 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:22:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:22:56 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:22:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:22:59 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36692|0 |1 is obsolete| | Attachment #36693|0 |1 is obsolete| | Attachment #36694|0 |1 is obsolete| | Attachment #36695|0 |1 is obsolete| | Attachment #36696|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 39124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39124&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:23:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:23:07 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #40 from Kyle M Hall --- Created attachment 39125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39125&action=edit Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:23:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:23:10 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #41 from Kyle M Hall --- Created attachment 39126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39126&action=edit Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:23:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:23:13 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #42 from Kyle M Hall --- Created attachment 39127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39127&action=edit Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:23:16 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #43 from Kyle M Hall --- Created attachment 39128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39128&action=edit Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:28:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:28:03 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:39:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:39:35 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14194 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:39:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:39:35 +0000 Subject: [Koha-bugs] [Bug 14194] New: Date due for on-site checkouts defaults to 00:00 for hh:mm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Bug ID: 14194 Summary: Date due for on-site checkouts defaults to 00:00 for hh:mm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Circulation Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 13601 Introduced by bug 13601. To reproduce: 1/ Enable On-site checkouts 2/ Go on the checkouts page 3/ Click on the "On-site checkout" checkbox => The default date due is today with 00:00 as hh:mm instead of 23:59 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:41:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:41:32 +0000 Subject: [Koha-bugs] [Bug 14195] New: TestBuilder does not generate the good length for text fields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Bug ID: 14195 Summary: TestBuilder does not generate the good length for text fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: gmcharlt at gmail.com Depends on: 12603 t::lib::TestBuilder::_gen_text does not use correctly the regex and the max parameter to generate the random string (String::Random). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:41:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:41:32 +0000 Subject: [Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14195 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:50:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:50:44 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36489|0 |1 is obsolete| | --- Comment #86 from Bernardo Gonzalez Kriegel --- Created attachment 39129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39129&action=edit [SIGNED-OFF] Bug 7683: Cataloguing statistics wizard improvements - Add 3 options for cells value - Titles count "COUNT (biblionumber)" - Items count "COUNT (itemnumber)" (current behavior) - Deleted items count "COUNT (deleteditems.itemnumber)" - Add to selectable rows, colums and filters: - items.notforloan - items.materials - items.statisticvalue For each of these fields, retrieve the label in the default cataloging framework. If no MARC field is mapped to the field in question, it does not show this line in the wizard. If the MARC field is associated with a list of authorized values, it displays a dropdown list for the filter, otherwise it displays a text field. - Add to selectable rows, columns and filters: - items.dateaccessioned (creation date) - deleteditems.timestamp (deletion date) (Only if the third option (eg count deleted items) is selected) - Add unit tests for GetMarcSubfieldStructureFromKohaField Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Owen Leonard Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:50:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:50:55 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36490|0 |1 is obsolete| | --- Comment #87 from Bernardo Gonzalez Kriegel --- Created attachment 39130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39130&action=edit [SIGNED-OFF] Bug 7683: [Follow-up] Move unit tests in t/db_dependent/Biblio.t Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:51:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:51:04 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36491|0 |1 is obsolete| | --- Comment #88 from Bernardo Gonzalez Kriegel --- Created attachment 39131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39131&action=edit [SIGNED-OFF] Bug 7683: Remove use of items.statisticvalue and DHTMLcalendar() Also fix indexes of @filters array Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:51:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:51:17 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36492|0 |1 is obsolete| | --- Comment #89 from Bernardo Gonzalez Kriegel --- Created attachment 39132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39132&action=edit [SIGNED-OFF] Bug 7683: Remove dead code about dewey and lccn filters $hasdewey and $haslccn were hardcoded to 0 Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:51:27 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36493|0 |1 is obsolete| | --- Comment #90 from Bernardo Gonzalez Kriegel --- Created attachment 39133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39133&action=edit [SIGNED-OFF] Bug 7683: Fix a shift in date filter indexes Date filter indexes are 13, 14, 15, 16, not 14, 15, 16, 17 Signed-off-by: Bernardo Gonzalez Kriegel Works, no koha-qa errors (some message for the deleted file) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:51:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:51:56 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:56:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:56:26 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Bernardo Gonzalez Kriegel --- Sorry, this patchset references files from OPAC prog :( CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt deleted in HEAD and modified in Bug 7706 - Do not display authorized value image if url is empty. Version Bug 7706 - Do not display authorized value image if url is empty of koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt left in tree. CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt deleted in HEAD and modified in Bug 7706 - Do not display authorized value image if url is empty. Version Bug 7706 - Do not display authorized value image if url is empty of koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt left in tree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:56:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:56:39 +0000 Subject: [Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 15:56:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 13:56:42 +0000 Subject: [Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 --- Comment #1 from Jonathan Druart --- Created attachment 39134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39134&action=edit Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts (Introduced by bug 13601) Test plan: 1/ Enable On-site checkouts 2/ Go on the checkouts page 3/ Click on the "On-site checkout" checkbox => The default date due should be today with 23:59 as HH:MM (not 00:00). Technical note: There is a confusion with iso and sql date formats at some places in the code. A better way should be provided (later) to fix globally the mismatch between these 2 formats. What happened before this patch: the DateTime was cast to a string and the template received "YYYY-MM-DDTHH:MM:SS" which is an iso formatted date. BUT this format is not managed by Koha::DateUtils::output_pref ("iso" and "sql" are considered as indentical which is wrong). As I did not estimated the problem (how big it is) I prefer to fix it easily (and dirty) for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 16:17:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 14:17:35 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #11 from Fridolin SOMERS --- Created attachment 39135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39135&action=edit Bug 14053 - Acquisition db tables are missing indexes Acquisition db tables are missing some indexes to have performance queries. This patch adds an index on some columns very often used in search queries, such as aqbooksellers.name and aqbudgets.budget_code. Also adds an index on aqorders.orderstatus, very often used with hardcoded value like 'cancelled', in various queries. Test plan : - Check SQL syntax is correct - Try to compare performance after and before database update. I think query contained in C4::Acquistion::GetInvoices could be a good example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 16:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 14:17:47 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #12 from Fridolin SOMERS --- Created attachment 39136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39136&action=edit Bug 14053 - Acquisition db tables are missing indexes - atomicupdates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 16:18:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 14:18:19 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #13 from Fridolin SOMERS --- Patches updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 16:19:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 14:19:34 +0000 Subject: [Koha-bugs] [Bug 14196] New: Encoding error adding new biblio in custom framework Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14196 Bug ID: 14196 Summary: Encoding error adding new biblio in custom framework Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: pablo.jimenez at ext.satec.es QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi. I have created my own framework (from BKS), with less fields in the structure, and with new Labels in spanish. When I try to add a new record (biblio) with ? or ? character, the h1 field remove those characters, and diacritical marks are showed wrong (Jim?nez as Jimn?ez). The info in the database is correct. This is not happening in detail.tt OS: CenOS 7 Locale: LANG=es_ES.utf8 LC_CTYPE="es_ES.utf8" LC_NUMERIC="es_ES.utf8" LC_TIME="es_ES.utf8" LC_COLLATE="es_ES.utf8" LC_MONETARY="es_ES.utf8" LC_MESSAGES="es_ES.utf8" LC_PAPER="es_ES.utf8" LC_NAME="es_ES.utf8" LC_ADDRESS="es_ES.utf8" LC_TELEPHONE="es_ES.utf8" LC_MEASUREMENT="es_ES.utf8" LC_IDENTIFICATION="es_ES.utf8" LC_ALL= Apache with AddDefaultCharset UTF-8 Mysql 5.6 char variables: +--------------------------+----------------------------+ | Variable_name | Value | +--------------------------+----------------------------+ | character_set_client | utf8 | | character_set_connection | utf8 | | character_set_database | utf8 | | character_set_filesystem | binary | | character_set_results | utf8 | | character_set_server | utf8 | | character_set_system | utf8 | | character_sets_dir | /usr/share/mysql/charsets/ | +--------------------------+----------------------------+ Regards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 16:34:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 14:34:31 +0000 Subject: [Koha-bugs] [Bug 14196] Encoding error adding new biblio in custom framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14196 --- Comment #1 from pablo.jimenez at ext.satec.es --- I was wrong about the data in database, after a query it looks like is double utf-8 encoded SELECT title, LENGTH(title), CHAR_LENGTH(title) FROM biblio WHERE LENGTH(title) != CHAR_LENGTH(title); +----------------------+---------------+--------------------+ | title | LENGTH(title) | CHAR_LENGTH(title) | +----------------------+---------------+--------------------+ | Espa?a | 7 | 6 | | ?AM | 4 | 3 | | ???? | 8 | 4 | | ?am3 | 5 | 4 | | ?AAAAM | 7 | 6 | | ????? | 10 | 5 | | eeeee?? | 9 | 7 | | bbbbbbb??????o | 20 | 14 | +----------------------+---------------+--------------------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 16:41:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 14:41:50 +0000 Subject: [Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39134|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 39137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39137&action=edit Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts (Introduced by bug 13601) Test plan: 1/ Enable On-site checkouts 2/ Go on the checkouts page 3/ Click on the "On-site checkout" checkbox => The default date due should be today with 23:59 as HH:MM (not 00:00). Technical note: There is a confusion with iso and sql date formats at some places in the code. A better way should be provided (later) to fix globally the mismatch between these 2 formats. What happened before this patch: the DateTime was cast to a string and the template received "YYYY-MM-DDTHH:MM:SS" which is an iso formatted date. BUT this format is not managed by Koha::DateUtils::output_pref ("iso" and "sql" are considered as indentical which is wrong). As I did not estimated the problem (how big it is) I prefer to fix it easily (and dirty) for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 16:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 14:42:27 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 16:42:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 14:42:30 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 --- Comment #1 from Jonathan Druart --- Created attachment 39138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39138&action=edit Bug 14105: TestBuilder - A random string should not be longer than the DB field t::lib::TestBuilder::_gen_text does not use correctly the regex and the max parameter to generate the random string (String::Random). This can cause future tests to fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 16:44:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 14:44:35 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 --- Comment #2 from Jonathan Druart --- Created attachment 39139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39139&action=edit To reproduce the issue Launch this script several times, without applying the patch. If the generated string for categorycode has a length > 10, you will see a difference. After applying the patch, the difference should never occur. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:03:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:03:57 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39093|0 |1 is obsolete| | Attachment #39095|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 39140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39140&action=edit Bug 13437: Perltidy some plugin files before conversion Preliminary work before converting to new plugin style. Several files still contained tabs or had strange indentation. Perltidied: marc21_linking_section.pl Perltidied: marc21_field_007.pl Perltidied: marc21_leader_authorities.pl Perltidied: marc21_leader.pl Perltidied: marc21_leader_book.pl Perltidied: marc21_leader_computerfile.pl Perltidied: marc21_leader_video.pl Test plan: Run perltidy -pro=xt/perltidyrc on marc21_linking_section and compare. Try another one too :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:04:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:04:00 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #5 from Marcel de Rooy --- Created attachment 39141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39141&action=edit Bug 13437: Preliminary changes for marc21 plugins field 008 Preliminary work on marc21_field_008.pl and 008_authorities.pl. Moving $dateentered en $defaultval to lower scope level. Test plan: Use both plugins in the marc21 editor (biblios/authorities). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:04:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:04:04 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #6 from Marcel de Rooy --- Created attachment 39142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39142&action=edit Bug 13437: Trivial edits on marc21 plugins before conversion marc21_field_003.pl: copy-pasta comment about date removed marc21_field_005.pl: commented use removed marc21_field_006.pl: old/irrelevant pod lines marc21_field_007.pl: old/irrelevant pod lines marc21_field_008.pl: old/irrelevant pod lines, move sub par line twice marc21_field_008_authorities.pl: whitespace, old/irrelevant pod lines marc21_field_040c.pl: two commented lines removed marc21_field_040d.pl: whitespace, commented lines, old/irrelevant pod marc21_field_245h.pl: whitespace marc21_linking_section.pl: relocated some comment lines, and replaced a new CGI object by the one passed in via the plugin launcher (agreed, this may not be so trivial as the other changes) Test plan: These (trivial) changes are hard to test. Pick a few plugins and verify that behavior is not changed in the marc editor. For the brave: Try marc21_linking_section.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:04:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:04:33 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:04:48 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #7 from Marcel de Rooy --- Two more coming -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:14:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:14:54 +0000 Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:14:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:14:59 +0000 Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37028|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 39143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39143&action=edit [SIGNED-OFF] Bug 7793: Simplify db update Since message_id is not linked to anything else in the database, we can ensure the message_id's are unique by simply dropping the column and recreating it. Signed-off-by: Bernardo Gonzalez Kriegel Moved updatedatabase to atomicupdate First patch signed. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:15:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:15:03 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m CC| |jonathan.druart at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:53:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:53:11 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #91 from Marc V?ron --- Created attachment 39144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39144&action=edit [Signed-off] Bug 8753 - Add forgot password link to OPAC I've addressed a lot of Liz Rea's points. 1. I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory. 1a. The feature is now off by default when the atomicupdate is run. 2. The password reset link is now visible on the home page, in the modal box and on opac-user.pl . 3. The password recovery pages now use bootstrap markup. 4. I am unsure here. I see "New Password:" and "Confirm new password:". 5. This should still work :). 6. I could not reproduce. 7. I have added the userid field. You can now reset the password by submitting either your useid or email address. Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email). When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid. 8. The text is in the atomicupdate file. Have at it, anyone. Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed. Maybe we could add a sub in Letters.pm that: Takes the same argments as EnqueueLetter Sends the letter. Saves the letter in the message queue with a 'sent' status. TEST PLAN: Setup) 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 2b) make sure that OpacPasswordChange is also ON. A) 1) refresh front page, click on 'Forgot your password' and enter a VALID address 1b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 2) An email should be received at that address with a link. 3) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 4) Go to main page try the new password. B) 1) Repeat the password reset, this time use the userid (username) field. 2) Try to reset the password using a userid and an email not linked to the account. An error appears. 3) Make sure the borrower has many available email addresses. 4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address C) 1) Make sure two borrowers use the same email. 2) Repeat the reset procedure in test case A). An error message appears http://bugs.koha-community.org/show_bug.cgi?id=13068 Author: Maxime Beaulieu Followed test plan. Works as described. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:53:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:53:45 +0000 Subject: [Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39137|0 |1 is obsolete| | --- Comment #3 from Indranil Das Gupta --- Created attachment 39145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39145&action=edit Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts (Introduced by bug 13601) Test plan ========= 1/ enable 'OnSiteCheckouts' pref under Circulation Preferences 2/ go to the checkouts page and try to issue an item to any user. 3/ when the item barcode entry form shows, select the 'On-site checkout' checkbox 4/ the default date due should show as today with 00:00 as HH:MM 5/ apply the patch 6/ repeat steps 2 - 3. The default date due should show today's date with 23:59 as HH:MM. 7/ run koha-qa.pl -c 1 -v 2 Remarks: Testing result match expected test plan output. The QA tests pass with "OK" for the commit. Technical note: There is a confusion with iso and sql date formats at some places in the code. A better way should be provided (later) to fix globally the mismatch between these 2 formats. What happened before this patch: the DateTime was cast to a string and the template received "YYYY-MM-DDTHH:MM:SS" which is an iso formatted date. BUT this format is not managed by Koha::DateUtils::output_pref ("iso" and "sql" are considered as indentical which is wrong). As I did not estimated the problem (how big it is) I prefer to fix it easily (and dirty) for now. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:54:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:54:13 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39049|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:54:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:54:30 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:54:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:54:45 +0000 Subject: [Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:56:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:56:18 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 17:57:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 15:57:09 +0000 Subject: [Koha-bugs] [Bug 14197] New: Warning raised by TestBuilder Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Bug ID: 14197 Summary: Warning raised by TestBuilder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: gmcharlt at gmail.com (in cleanup) DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 318 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:02:12 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #1 from Jonathan Druart --- Created attachment 39146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39146&action=edit Bug 14197: Remove the warning on destroying TestBuilder objects This module will be called by db_dependent tests, which already create a transaction. TestBuilder creates a new one (which is certainly useless) and the rollback does not do anything. To see the warning see patches on bug 14045. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:02:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:02:09 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:02:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:02:21 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14197 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:02:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:02:21 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14045 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:02:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:02:34 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14195 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:02:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:02:34 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14045 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:02:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:02:51 +0000 Subject: [Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14045 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:02:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:02:51 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14194 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:03:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:03:53 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:03:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:03:56 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #1 from Jonathan Druart --- Created attachment 39147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39147&action=edit Bug 14045: Add specific quotas to on-site checkouts This patch set adds the ability to defined independent quotas for on-site checkouts. This will be done using the circulation rules matrix where a new column ?Current on-site checkouts allow? will be added. This feature is going to use the same method as the existing fields maxissueqty ("Current checkouts allowed"), the new fields will be added to the different tables (see the "DB changes" patch) and will be named maxonsiteissueqty (for consistency). In order to keep the existing behavior and to let more flexibility, a new system preference is added (ConsiderOnSiteCheckoutsAsNormalCheckouts). This syspref will let the liberty to the library to decide if an on-site checkout should be considered as a "normal" checkout or not. To keep the existing behavior, the syspref will be disabled (i.e. an on-site checkout is considered as a normal checkout) and the number of on-site checkouts will be the same as the number of checkout (maxissueqty == maxonsiteissueqty). Technically: There are only very few tests for the Circulation module, and the 2 subroutines impacted by this patch set were not tested at all. It is necessary to introduce non-regression tests for this area. The 2 subroutines are: C4::Circulation::GetBranchBorrowerCircRule and C4::Circulation::TooMany (only called by C4::Circulation::CanBookBeIssued, so we will take the liberty to change the prototype to raise a better warning to the end user). Test plan: I. Confirm there is no regression and the existing behavior is kept 0/ Let the syspref disabled 1/ Set a rule to limit to 2 the number of checkouts allowed 2/ Do a normal checkout 3/ Do an on-site checkout 4/ Try to checkout (on-site or normal) an item again. You should not be allowed. II. Test the new feature - pref disabled 0/ Let the syspref disabled 1/ Set a rule to limit to 2 the number of checkouts allowed and to 1 the number of on-site checkouts allowed. 2/ Do an on-site checkout 3/ Try to do another one, you should not be allowed to do it. 4/ A normal checkout should pass successfully Note that it does not make sense to have the number of on-site checkouts alowed > number of checkouts allowed. III. Test the new feature - pref enabled 0/ Enable the syspref Now an on-site checkout is *not* counted as a normal checkout. This means you can have the number of on-site checkouts > number of checkouts allowed. 1/ Set the values you want for the 2 types of checkouts (normal vs on-site). 2/ Even if a patron has reached the maximum of checkouts allowed, he will be allowed to do a on-site checkout (vice versa). IV. Stress the developper Using the different configurations available in the circulation matrix, try to find one where the checkout is allowed and not should be. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:04:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:04:05 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #3 from Jonathan Druart --- Created attachment 39149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39149&action=edit Bug 14045: Introduce the maxonsiteissueqty field as a copy of maxissueqty This patch adds the new fields maxonsiteissueqty as a copy of the existing maxissueqty field. There is no brainy code here, it only adds the ability to fill the new field from the admin interface (admin/smart-rules.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:04:01 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #2 from Jonathan Druart --- Created attachment 39148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39148&action=edit Bug 14045: Change prototype of TooMany to raise a better warning With this patch, the user will know why the checkout is refused. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:04:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:04:09 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #4 from Jonathan Druart --- Created attachment 39150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39150&action=edit Bug 14045: Make GetBranchBorrowerCircRule return maxonsiteissueqty GetBranchBorrowerCircRule should return the value for maxissueqty and maxonsiteissueqty. It's what this patch does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:04:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:04:13 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #5 from Jonathan Druart --- Created attachment 39151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39151&action=edit Bug 14045: DB Changes This patch is the DB changes for the feature. It adds 5 new columns named 'maxonsiteissueqty' to the following tables: - branch_borrower_circ_rules - default_borrower_circ_rules - default_branch_circ_rules - default_circ_rules - issuingrules It also adds the pref ConsiderOnSiteCheckoutsAsNormalCheckouts. See main patch for more details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:04:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:04:17 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #6 from Jonathan Druart --- Created attachment 39152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39152&action=edit Bug 14045: DBIC Changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:05:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:05:00 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Failed QA --- Comment #32 from Bernardo Gonzalez Kriegel --- Hi, on your first patch you add on kohastructure.pl `printed` tinyint(1) DEFAULT NULL, for reserves and old_reserves But on final updatedatabase.pl (needs to be on atomicupdate!), you "only" alter reserves but using a different type $dbh->do("ALTER TABLE reserves ADD printed DATETIME NULL AFTER suspend_until"); Both patches have conflicts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:22:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:22:15 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14111 | Depends on| |14111 --- Comment #103 from M. Tompsett --- I may have gotten the Depends on direction wrong for the: prove t/Auth_with_shibboleth.t I retested all this yesterday on the kohadev box. I ended up making the same sorts of changes that are in bug 14111 in order for it to pass the t/Auth_with_shibboleth.t tests. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:22:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:22:15 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5010 Depends on|5010 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:22:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:22:31 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #7 from Indranil Das Gupta --- Comment on attachment 39151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39151 Bug 14045: DB Changes Review of attachment 39151: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14045&attachment=39151) ----------------------------------------------------------------- Hi Jonathan, I've a newbie question. Why are you putting in this code in the updatedatabase.pl, instead of in the atomicupdates? Or did I get it wrong? http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39151&action=diff#a/installer/data/mysql/updatedatabase.pl_sec1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:32:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:32:39 +0000 Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #1) > (In reply to Kyle M Hall from comment #0) > > In previous versions of Koha, a marc modfication rules like "Copy field > > XXX$Y to 952$x" would add the field to an existing 952 field if there was > > one already, and only create a 952 field if none existed. Now an entirely > > new 952 field is created to store the subfield even if there is already one! > > Hello Kyle, > I would say it's the way it should work. > Or maybe should we create a new action and let the choice to the user? Owen has created a template that relied on the previous behavior, so I think it's a regression. However, if adding a new behavior would allow him to get his previous template to work by changing its' rules, that seems like a fine compromise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:36:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:36:44 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #14 from M. Tompsett --- Comment on attachment 39135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39135 Bug 14053 - Acquisition db tables are missing indexes Review of attachment 39135: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14053&attachment=39135) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +2903,4 @@ > PRIMARY KEY (`id`), > KEY `listprice` (`listprice`), > KEY `invoiceprice` (`invoiceprice`), > + KEY `name` (`name`(255)), Remove (255) This causes a failure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:48:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:48:54 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #15 from M. Tompsett --- Created attachment 39153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39153&action=edit Bug 14053 - Fix cut and paste mistake (255) does not belong in the key definition. TEST PLAN ---------- 1) Back up db. 2) $ git reset --hard origin/master 3) $ git bz apply 14053 -- do not apply this patch. 4) in your mysql client: > DROP DATABASE koha_library; > CREATE DATABASE koha_library; > QUIT; 5) Navigate to staff client -- blows up in step 3 6) $ git bz apply 14053 -- apply just this final patch 7) repeat step 4. 8) Navigate to staff client -- everything proceeds smoothly. 9) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 18:50:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 16:50:21 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39153|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Comment on attachment 39153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39153 Bug 14053 - Fix cut and paste mistake Nope that's not the solution. Sorry, my bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 19:00:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 17:00:55 +0000 Subject: [Koha-bugs] [Bug 14198] New: RDA: Indexing 264 field (Zebra) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 Bug ID: 14198 Summary: RDA: Indexing 264 field (Zebra) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org Since RDA has been published, Koha need support for this Code. In this way 264 field need to be searchable. Bib-1 set a new index for provider Provider 1225, although I think 264 should be included like 260 $a$b$c Patch coming soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 19:13:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 17:13:06 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #17 from M. Tompsett --- Comment on attachment 39135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39135 Bug 14053 - Acquisition db tables are missing indexes Review of attachment 39135: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14053&attachment=39135) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +2903,4 @@ > PRIMARY KEY (`id`), > KEY `listprice` (`listprice`), > KEY `invoiceprice` (`invoiceprice`), > + KEY `name` (`name`(255)), This wasn't the problem. @@ +2933,5 @@ > + KEY `budget_parent_id` (`budget_parent_id`), > + KEY `budget_code` (`budget_code`), > + KEY `budget_branchcode` (`budget_branchcode`), > + KEY `budget_period_id` (`budget_period_id`), > + KEY `budget_owner_id` (`budget_owner_id`), This comma is the problem! I'm going to remove it from your patch and sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 19:14:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 17:14:31 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #18 from M. Tompsett --- (In reply to M. Tompsett from comment #3) > Comment on attachment 38568 [details] [review] > Bug 14053 - Acquisition db tables are missing indexes > > Review of attachment 38568 [details] [review]: > ----------------------------------------------------------------- > > ::: installer/data/mysql/kohastructure.sql > @@ +2934,5 @@ > > + KEY `budget_parent_id` (`budget_parent_id`), > > + KEY `budget_code` (`budget_code`), > > + KEY `budget_branchcode` (`budget_branchcode`), > > + KEY `budget_period_id` (`budget_period_id`), > > + KEY `budget_owner_id` (`budget_owner_id`), > > I believe this trailing comma is an issue. > I dropped koha_library. created it. then run web install. Please fix your branch. This comma bug was introduced again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 19:18:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 17:18:56 +0000 Subject: [Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Aleisha, // is not exactly the same as ||, as it returns first 'defined' value Anyway, on current master I don't see the warning messages, and you changed the first condition before: if ( $item->{itemnotforloan} > 0 || $item->{notforloan} > 0 || $itemtypes->{ $item->{itype} }->{notforloan} == 1 ) after: if ( $item->{notforloan} > 0 // $item->{notforloan} > 0 // $itemtypes->{ $item->{itype} }->{notforloan} == 1 ) $item->{itemnotforloan} > 0 <=> $item->{notforloan} > 0 First and second condition on your 'if' are equal! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 19:48:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 17:48:59 +0000 Subject: [Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- (In reply to Aleisha Amohia from comment #4) > I'm still very new to perl and had seen this warn solved this way before so > just did it again. Ah, okay. :) I didn't know. When I started perl, I was unaware of //. The difference between || and // is an important distinction to know. :) undef || 'blah'; -- This is 'blah' 0 || 'blah'; -- This is 'blah' '' || 'blah'; -- This is 'blah' undef // 'blah'; -- This is 'blah' 0 // 'blah'; -- This is 0 '' // 'blah'; -- This is '' As you can see // depends on whether the value is actually defined, not just its truth value. So, you actually chose the better operator inadvertently. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 20:05:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 18:05:58 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39136|0 |1 is obsolete| | --- Comment #19 from M. Tompsett --- Created attachment 39154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39154&action=edit Bug 14053 - Acquisition db tables are missing indexes - atomicupdates Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 20:06:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 18:06:03 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39135|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 39155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39155&action=edit Bug 14053 - Acquisition db tables are missing indexes Acquisition db tables are missing some indexes to have performance queries. This patch adds an index on some columns very often used in search queries, such as aqbooksellers.name and aqbudgets.budget_code. Also adds an index on aqorders.orderstatus, very often used with hardcoded value like 'cancelled', in various queries. Test plan : 1) Back up database 2) $ git reset --hard origin/master 3) $ git bz apply 14053 4) In your mysql client > DROP DATABASE koha_library; > CREATE DATABASE koha_library; > QUIT; -- Obviously you may need to vary koha_library :) 5) Navigate to staff client -- should be able to set up the DB just fine. -- this will catch the comma bug that keeps coming in. 6) $ git reset --hard origin/master 7) Repeat step 4 8) Navigate to staff client -- nothing tested, but we need the DB set up. 9) $ ./installer/data/mysql/updatedatabase.pl -- atomic updates run without issue. 10) run koha qa test tools 11) Restore DB 12) Try to compare performance after and before database update. I think query contained in C4::Acquistion::GetInvoices could be a good example Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 20:09:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 18:09:05 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #21 from M. Tompsett --- NOTE: I did not compare performance issues, though it conceptually makes sense. My sign offs are based on tweaked (I fixed the comma bug) patches and a more explicit test plan (to prevent the comma bug from returning). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 21:13:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 19:13:22 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36705|0 |1 is obsolete| | --- Comment #38 from Benjamin Rokseth --- Created attachment 39156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39156&action=edit Bug 13799: REST API proof of concept with Mojolicious/Swagger2 1/ Install Mojolicious Perl module 2/ Launch server with: $ morbo ./rest Actual routes are: /borrowers Return a list of all borrowers in Koha /borrowers/{borrowernumber} Return the borrower identified by {borrowernumber} (eg. /borrowers/1) There is a test file you can run with: $ prove t/db_dependent/rest/borrowers.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 21:15:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 19:15:23 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #39 from Benjamin Rokseth --- Darn, messed up order when fixing resolve issue on first patch. Will fix ASAP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 21:17:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 19:17:20 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36705|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 21:17:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 19:17:51 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39156|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 22:13:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 20:13:17 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 --- Comment #1 from M. Tompsett --- Created attachment 39157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39157&action=edit Bug 14076: silence warnings in opac/opac-authorities-home.pl TEST PLAN --------- 1) Blank your koha opac error log file 2) Open your OPAC 3) Click 'Authority search' 4) Click 'Submit' 5) Review the koha opac error log file -- the end should have messages about security vunerabilities because CGI param is used in a list context. 6) blank your koha opac error log file 7) apply patch 8) repeat steps 2-5 -- this time, those security warnings should be gone. -- if you see an oAuth error, that's because you have no authority records and the search failed as a result. 9) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 22:18:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 20:18:35 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 22:18:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 20:18:47 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 22:26:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 20:26:02 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36705|0 |1 is obsolete| | Attachment #36938|0 |1 is obsolete| | Attachment #36941|0 |1 is obsolete| | Attachment #37119|0 |1 is obsolete| | Attachment #37132|0 |1 is obsolete| | Attachment #37172|0 |1 is obsolete| | Attachment #38246|0 |1 is obsolete| | --- Comment #40 from Benjamin Rokseth --- Created attachment 39158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39158&action=edit Bug 13799: REST API proof of concept with Mojolicious/Swagger2 1/ Install Mojolicious Perl module 2/ Launch server with: $ morbo ./rest Actual routes are: /borrowers Return a list of all borrowers in Koha /borrowers/{borrowernumber} Return the borrower identified by {borrowernumber} (eg. /borrowers/1) There is a test file you can run with: $ prove t/db_dependent/rest/borrowers.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 22:26:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 20:26:24 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #41 from Benjamin Rokseth --- Created attachment 39159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39159&action=edit Bug 13799: Add versioning to API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 22:26:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 20:26:56 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #42 from Benjamin Rokseth --- Created attachment 39160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39160&action=edit Bug 13799: Use Koha::Objects This add 'unblessed' subroutines to both Koha::Objects and Koha::Object to be able to pass it to Mojolicious -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 22:27:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 20:27:10 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #43 from Benjamin Rokseth --- Created attachment 39161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39161&action=edit Bug 13799: Add Swagger UI documentation Move all API stuff into /api/v1 (except for Perl modules). So we have: /api/v1/script.cgi CGI script /api/v1/swagger.json Swagger specification /api/v1/doc Swagger UI Add a virtual host in Apache configuration api.HOSTNAME So we have: http://api.HOSTNAME/v1/swagger.json Swagger specification http://api.HOSTNAME/v1/doc Swagger UI http://api.HOSTNAME/v1/{path} API endpoint To test, you need to: 1/ perl Makefile.PL 2/ make && make install 3/ Change etc/koha-httpd.conf and copy it to the right place if needed 4/ Reload Apache 5/ Go to http://api.HOSTNAME/v1/doc and check everything works 6/ Also check that http://api.HOSTNAME/v1/borrowers and http://api.HOSTNAME/v1/borrowers/{borrowernumber} works Optionally, you could verify that http://api.HOSTNAME/vX/borrowers (where X is an integer greater than 1) returns a 404 error For the new vhost to work, you may need to modify your /etc/hosts file if you run Koha locally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 22:27:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 20:27:20 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #44 from Benjamin Rokseth --- Created attachment 39162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39162&action=edit Bug 13799: Move and fix unit test file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 22:27:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 20:27:30 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #45 from Benjamin Rokseth --- Created attachment 39163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39163&action=edit Bug 13799: Fix Koha::Objects::find when no results are found If we pass undef to Koha::Object::_new_from_dbic, it croaks with message "DBIC result type isn't of the type Borrower at Koha/Objects.pm" (in case we're using Koha::Borrowers->find) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 13 22:27:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 20:27:41 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #46 from Benjamin Rokseth --- Created attachment 39164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39164&action=edit Bug 13799: Change Mojolicious minimum version required (5.54) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 00:12:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 22:12:35 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #239 from Nick Clemens --- Okay, with OPACprivacy enabled and AllowPatronToSetCheckoutsVisibilityForGuarantor enabled a patron can set wether guarantor can view or not with OPACprivacy disabled and AllowPatronToSetCheckoutsVisibilityForGuarantor enabled a patron can see their guarantor but cannot save changes to whether their checkouts are shown. The update button doesn't work and a change to this field doesn't register if using the "submit update request" button Just a minor question too: If AllowPatronToSetCheckoutsVisibilityForGuarantor is disallow and AllowStaffToSetCheckoutsVisibilityForGuarantor is allow the patrons checkouts can be shown to their guarantor but they can neither see who their guarantor is or whether or not their checkouts are visible. That seems slightly concerning to me. The same goes for when both are set to disallow. To my mind if there is a situation in which your checkouts are being shown to a guarantor that info should be visible whether or not you can edit it All else seems to work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 00:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 22:17:47 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #92 from Liz Rea --- Hi, I tested this with opacpublic enabled and disabled - we probably need to modify the templates to not include the opacnav blocks if opacpublic is disabled. This can be a followup. I'm not super keen on the syspref text, I may send a followup with text that more clearly differentiates the purpose of this new syspref from OpacPasswordChange. Otherwise, thank you very much for the updated patch! Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 00:18:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 22:18:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #93 from Liz Rea --- Created attachment 39165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39165&action=edit Bug 8753 - Add forgot password link to OPAC I've addressed a lot of Liz Rea's points. 1. I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory. 1a. The feature is now off by default when the atomicupdate is run. 2. The password reset link is now visible on the home page, in the modal box and on opac-user.pl . 3. The password recovery pages now use bootstrap markup. 4. I am unsure here. I see "New Password:" and "Confirm new password:". 5. This should still work :). 6. I could not reproduce. 7. I have added the userid field. You can now reset the password by submitting either your useid or email address. Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email). When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid. 8. The text is in the atomicupdate file. Have at it, anyone. Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed. Maybe we could add a sub in Letters.pm that: Takes the same argments as EnqueueLetter Sends the letter. Saves the letter in the message queue with a 'sent' status. TEST PLAN: Setup) 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 2b) make sure that OpacPasswordChange is also ON. A) 1) refresh front page, click on 'Forgot your password' and enter a VALID address 1b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 2) An email should be received at that address with a link. 3) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 4) Go to main page try the new password. B) 1) Repeat the password reset, this time use the userid (username) field. 2) Try to reset the password using a userid and an email not linked to the account. An error appears. 3) Make sure the borrower has many available email addresses. 4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address C) 1) Make sure two borrowers use the same email. 2) Repeat the reset procedure in test case A). An error message appears http://bugs.koha-community.org/show_bug.cgi?id=13068 Author: Maxime Beaulieu Followed test plan. Works as described. Signed-off-by: Marc V?ron I tested this with opacpublic enabled and disabled - we probably need to modify the templates to not include opacnav if opacpublic is disabled. I'm not super keen on the syspref text, I may send a followup with text that more clearly differentiates the purpose of this new syspref from OpacPasswordChange Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 00:33:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 22:33:43 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #94 from Liz Rea --- Created attachment 39166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39166&action=edit Bug 8753 - Followup - change value text on syspref Followup changes text from "The user can reset | can not reset their password on OPAC" to "Library users are allowed | not allowed to recover their password via e-mail in the OPAC" This change more clearly differentiates the purpose of this new preference from OpacPasswordChange. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 00:56:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 22:56:26 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #95 from Liz Rea --- Created attachment 39167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39167&action=edit Bug 8753 - followup - update text for link to match common UI paradigms Updated the link for forgotten passwords to more closely match common UI paradigms, i.e. Facebook and Twitter To test: apply all patches, link should now be the less verbose "Forgot your password?" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 01:00:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 23:00:04 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39167|0 |1 is obsolete| | --- Comment #96 from Liz Rea --- Created attachment 39168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39168&action=edit Bug 8753 - followup - update text for link to match common UI paradigms, fixes OpacPublic disabled view Also corrects OpacNav being included on the reset page on private catalogues. Updated the link for forgotten passwords to more closely match common UI paradigms, i.e. Facebook and Twitter To test: apply all patches, link should now be the less verbose "Forgot your password?" disable OpacPublic, anything in opacnav should not appear (you may need to add something to opacnav to test properly) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 01:12:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 May 2015 23:12:19 +0000 Subject: [Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Nicole C. Engard --- Actually ODUE is Overdue - this notice is new and not needed. I've been deleting it from most installs. Nicole -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 14 02:36:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 00:36:56 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38111|0 |1 is obsolete| | --- Comment #22 from Bernardo Gonzalez Kriegel --- Created attachment 39169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39169&action=edit [SIGNED-OFF] Bug 8688: Add a Recall button to the biblio record details page. This patch is a fusion of all previous patches for this feature, in addition to a system preference to control the appearance of the "Recall" button. NOTE: Rebased so updatedatabase.pl doesn't fail. Signed-off-by: Bernardo Gonzalez Kriegel Fixed conflicts Moved update to atomic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 02:37:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 00:37:08 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38118|0 |1 is obsolete| | --- Comment #23 from Bernardo Gonzalez Kriegel --- Created attachment 39170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39170&action=edit [SIGNED-OFF] Bug 8688: Cleaned up pointless parameter passing It does not make sense to $template->param( 'foo' => 'bar' ); when in the template file we can Koha.Preference('foo') in order to get 'bar'. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 02:37:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 00:37:18 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38119|0 |1 is obsolete| | --- Comment #24 from Bernardo Gonzalez Kriegel --- Created attachment 39171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39171&action=edit [SIGNED-OFF] Bug 8688: Update License, Perlcritic -3 friendly This patch tweaks the license information to v3, as per the license found in the Coding Guidelines on the wiki: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence This also changes: use strict; use warnings; into: use Modern::Perl; As per the PERL2: Modern::Perl requirement in the Guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL2:_Modern::Perl And though the guidelines only require perlcritic -5, a single line tweak gets a bump to perlcritic -3. TEST PLAN --------- 1) perlcritic -5 circ/send_recall_notice.pl -- success, so technically no change was required. 2) perlcritic -3 circ/send_recall_notice.pl -- fails 3) apply patch 4) perlcritic -3 circ/send_recall_notice.pl -- success 5) run koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 02:38:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 00:38:17 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 --- Comment #25 from Bernardo Gonzalez Kriegel --- Created attachment 39172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39172&action=edit Bug 8688: (follow-up) Fix quotes Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 02:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 00:38:41 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 --- Comment #26 from Bernardo Gonzalez Kriegel --- Created attachment 39173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39173&action=edit Bug 8688: (follow-up 2) Add notice to all langs and fix permission Set eXecute bit for script Added notice on all langs Tested by me but if you must, Run SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='RECALL'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='RECALL'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='RECALL'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='RECALL'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='RECALL'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='RECALL'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='RECALL'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='RECALL'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='RECALL'; All counts must be 1 Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 02:40:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 00:40:52 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #27 from Bernardo Gonzalez Kriegel --- Re-signed first three patches, after fixing conflicts Added two new ones, first for koha-qa, second to add notices to all langs They need a check and sign -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 02:47:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 00:47:38 +0000 Subject: [Koha-bugs] [Bug 14184] Noisy warns in C4/CourseReserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 03:00:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 01:00:37 +0000 Subject: [Koha-bugs] [Bug 14184] Noisy warns in C4/CourseReserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39055|0 |1 is obsolete| | --- Comment #2 from Indranil Das Gupta --- Created attachment 39174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39174&action=edit Bug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm This patch sets $term to be an empty string. Test plan ========= 1/ enable 'UseCourseReserves' syspref in Circulation preferences 2/ in a terminal, run a `tail -f ` on your instance's opac-error.log 3/ go to the opac, click on 'Course reserve' tab to go to opac-course-reserves.pl 4/ notice the warning - "opac-course-reserves.pl: Use of uninitialized value $term" appear in the `tail`ed opac-error.log 5/ apply the patch 6/ reload the page (opac-course-reserves.pl) 7/ page works but the warning in step #4 is no longer logged 8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error Remarks: Testing result match expected test plan output. The QA tests pass with "OK" for the commit. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 03:01:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 01:01:56 +0000 Subject: [Koha-bugs] [Bug 14184] Noisy warns in C4/CourseReserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 03:08:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 01:08:10 +0000 Subject: [Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #3 from Indranil Das Gupta --- (In reply to Indranil Das Gupta from comment #2) > Comment on attachment 39057 [details] [review] > Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl > > Review of attachment 39057 [details] [review]: > ----------------------------------------------------------------- > > Hi Aleisha, > > Would you be considering making the small change mtompset at hotmail.com > suggested in bug 14185, comment 3 for this patch? > > If you do, then I'll wait for your update, before I sign off on this. ^^^ the question is no longer relevant. Will proceed with testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 03:35:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 01:35:23 +0000 Subject: [Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39057|0 |1 is obsolete| | --- Comment #4 from Indranil Das Gupta --- Created attachment 39175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39175&action=edit Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl This patch sets $reservedfor to an empty string. Test plan ========= 1/ in a terminal, run `tail -f ` on your instance's opac-error.log 2/ go to the opac and search from an item that exists on the Koha instance. 3/ Select the title (if more than one title is returned) and click on 'Place hold' link to go to opac-reserve.pl 4/ notice the warning - "opac-reserve.pl: Use of uninitialized value $reservedfor" appear in the `tail`ed opac-error.log 5/ apply the patch 6/ reload the page (opac-reserve.pl) 7/ page works but the warning in step #4 is no longer thrown up 8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error Remarks: The QA test failed - "forbidden pattern: tab char (line 470)". Marking this as 'FAILED QA' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 03:36:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 01:36:53 +0000 Subject: [Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 03:41:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 01:41:31 +0000 Subject: [Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 --- Comment #5 from Indranil Das Gupta --- Comment on attachment 39175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39175 Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl Result of QA test FAIL opac/opac-reserve.pl OK critic FAIL forbidden patterns forbidden pattern: tab char (line 470) OK pod OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 04:09:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 02:09:10 +0000 Subject: [Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 --- Comment #6 from Indranil Das Gupta --- Created attachment 39176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39176&action=edit [FOLLOWUP] Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl This is a followup for Bug 14186 that removes the extraneous tab char on line 470, so that the patch can clear QA tools. This patch sets $reservedfor to an empty string. Test plan ========= 1/ in a terminal, run `tail -f ` on your instance's opac-error.log 2/ go to the opac and search from an item that exists on the Koha instance. 3/ Select the title (if more than one title is returned) and click on 'Place hold' link to go to opac-reserve.pl 4/ notice the warning - "opac-reserve.pl: Use of uninitialized value $reservedfor" appear in the `tail`ed opac-error.log 5/ apply the patch 6/ reload the page (opac-reserve.pl) 7/ page works but the warning in step #4 is no longer thrown up 8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error Remarks: Testing result match expected test plan output. The QA tests pass with "OK" for the commit. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 04:10:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 02:10:25 +0000 Subject: [Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 04:45:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 02:45:15 +0000 Subject: [Koha-bugs] [Bug 14192] Noisy warns in Koha/XSLT_Handler.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14192 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 07:59:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 05:59:06 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 07:59:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 05:59:14 +0000 Subject: [Koha-bugs] [Bug 14106] koha-conf paths to zebra libraries are wrong in jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 08:05:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 06:05:40 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #14 from Mason James --- Pushed to 3.16.x, will be in 3.16.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:11:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:11:38 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #8 from Marcel de Rooy --- Created attachment 39177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39177&action=edit Bug 13437: Conversion of marc21 cataloguing plugins to new style This patch converts marc21 plugins to new style by making the following modifications: [1] Replace use strict with use Modern::Perl. This implies that we now re-enabled warnings. There are no redefine warnings anymore, but note that we need to silence some warnings from individual plugins that were covered by disabling the warnings pragma until now. Silencing these individual warnings is outside the scope of this report. [2] Sub plugin_javascript is replaced by an anonymous subroutine $builder. [3] The parameters of $builder are combined in a params hashref. In most cases we only need $params->{id} for the function name. [4] Javascript function Clicxxx is renamed to Clickxxx. [5] The builder does no longer return function_name. [6] Sub plugin is replaced by subroutine $launcher. [7] The parameters of $launcher are combined in a params hashref. We only use $params->{cgi}. Mostly we save that to $input. One exception: $query. [8] The plugins returns a hash with $builder and/or $launcher. Test plan: [1] Run t/db_dependent/FrameworkPlugin.t -incl cataloguing/value_builder/ marc21*.pl. This should catch compile errors and general problems when building or launching these plugins. NOTE: You will see several initialize warnings from individual plugins that were hidden until now by disabling warnings. This is fine; we will be able to address these warnings now on new reports. [2] Check behavior of several plugins in the marc editor. Signed-off-by: Marcel de Rooy Checked all marc21 plugins. Attached unused plugins to some field. Some plugins (unused by default) may need some further attention, but also outside the scope of this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:12:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:12:25 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:18:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:18:51 +0000 Subject: [Koha-bugs] [Bug 14199] New: Unify all organization code plugins Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Bug ID: 14199 Summary: Unify all organization code plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl We are using several plugins to do the same. See marc21_field_040c and 040d. There must be even some more: 003. Seems not to be used at unimarc side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:19:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:19:19 +0000 Subject: [Koha-bugs] [Bug 14200] New: GetNormalizedISBN failing to normalize valid ISBNs in some cases Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Bug ID: 14200 Summary: GetNormalizedISBN failing to normalize valid ISBNs in some cases Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org For some reason the regular expression used to split the multiple ISBN fields can fail which keeps Business::ISBN from being able to parse out and return a valid isbn. Using split() instead of the regex fixes the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:19:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:19:26 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:19:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:19:53 +0000 Subject: [Koha-bugs] [Bug 14201] New: leader plugins Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201 Bug ID: 14201 Summary: leader plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:21:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:21:29 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:21:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:21:32 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 --- Comment #1 from Kyle M Hall --- Created attachment 39178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39178&action=edit Bug 14200 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:21:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:21:38 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 --- Comment #2 from Kyle M Hall --- Created attachment 39179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39179&action=edit Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in some cases For some reason the regular expression used to split the multiple ISBN fields can fail which keeps Business::ISBN from being able to parse out and return a valid isbn. Using split() instead of the regex fixes the issue. Test Plan: 1) Apply the unit test patch first 2) prove t/Koha.t 3) Note the failures 4) Apply the second patch 5) prove t/Koha.t 6) Note all tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:23:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:23:38 +0000 Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Summary|leader plugins |Remove unused code or | |template from some MARC21 | |leader plugins --- Comment #1 from Marcel de Rooy --- Some of the marc21 leader plugins refer to leader.pl and include unused code. Have to check also if attached template is used at all. Pertains to: marc21_leader_book.pl marc21_leader_computerfile.pl marc21_leader_video.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:25:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:25:16 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Convert marc21 framework |Convert marc21 framework |plugins to new style (see |plugins to new style |also 10480) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:25:47 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13437 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:25:47 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14199 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:25:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:25:56 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14201 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:25:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:25:56 +0000 Subject: [Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13437 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 12:57:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 10:57:49 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 --- Comment #12 from Kyle M Hall --- (In reply to M. Tompsett from comment #11) > (In reply to Kyle M Hall from comment #10) > > Created attachment 39097 [details] [review] [review] > > Bug 13948 [QA Followup] - Make dependency optional > > This doesn't answer the implied question from what I wrote: > "Additionally: > http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html > does not contain Stash. I suspect this was how it was > introduced initially by TT." > > Do you even need to mention it? Is not stash already part of TT? It appears that while Template::Stash is part of TT, Template::Plugin::Stash is not part of TT, so we do need to have it as a separate dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 13:05:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 11:05:33 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #14 from Kyle M Hall --- Created attachment 39180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39180&action=edit Bug 14167 [QA Followup] - Add template and changes needed for packages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 13:44:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 11:44:15 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #47 from Bernardo Gonzalez Kriegel --- This no longer applies CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc Also GRS-1 is deprecated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 14:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 12:14:39 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 14:14:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 12:14:43 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38748|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 39181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39181&action=edit Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 14:33:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 12:33:54 +0000 Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour customizable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Bernardo Gonzalez Kriegel --- I fixed conflicts to test, also loaded a bunch of auths. But... how is this supposed to be tested? For now, does not apply. But give me a test plan and I will upload a fixed patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 14:38:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 12:38:39 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 --- Comment #7 from Kyle M Hall --- > 0) The QA script fails: > > FAIL misc/migration_tools/import_lexile.pl > FAIL critic > I/O layer ":utf8" used at line 39, column 1. Use ":encoding(UTF-8)" to get > strict validation. > FAIL forbidden patterns > forbidden pattern: Koha is now under the GPLv3 license (line 9) > OK pod > OK valid Will fix! > 1) Is copyright 2013 correct? Will fix! > > 2) I am not sure what one of the options means from the description, could > you clarify? > + --source-value Defines the value to put stored in the "Source" > subfield ( default: "Lexile" ) Please take a look at http://www.loc.gov/marc/bibliographic/bd521.html Basically, 521 fields can store all types of target audience data. 521$a stores the 'rating' while 521$b stores the type of the rating. In this case, the rating is a Lexile score. > 3) The documentation for --file says: "acquired from Lexile.com", but the > actual file format is not documented. I think maybe we need to decide here > if this is a vendor specific or a general purpose script. If it's vendor > specific, we might want to reflect that more clearly in the file name and > description. If it's general purpose, we should include notes about the file > format to make this easier to reuse. I'll add the file format to the help. This is meant specifically for importing Lexile.com files ( as they own and control Lexile rankings ) but this script is general purpose enough to import any CSV file that matches the schema. > > 4) We didn't really finish our discussions about the standard options for > CLI scripts > (http://wiki.koha-community.org/wiki/Coding_Guidelines#Command- > line_argument_conventions), but maybe this should have a -c for confirming > the action as it's going to change data? I'll add the -c and -t options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 14:42:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 12:42:20 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 14:42:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 12:42:22 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36438|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 39182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39182&action=edit Bug 11368 - Add script to import Lexile scores Koha needs a script to automate the importing of Lexile score data for titles that have available scores but are not currently in the title's record. This script will take a CSV file of Lexile scores, and locate any matching records in the Koha database ( by ISBN ). If the record already has a score, it will be updated. If not, the Lexile score field will be created. Test Plan: 1) Apply this patch 2) Catalog a record for each of the following ISBNs: 0789170191 9780673779410 3) Download the file LexileTitlesTruncated.txt attached to this bug report 4) Run the script from the command line: ./misc/migraction_tools/import_lexile.pl -v --file /path/to/LexileTitlesTruncated.txt 5) View those records in Koha 6) Note those records now have valid Lexile scores 7) Edit the Lexile score ( 521$a ) and change the value to something else 8) Repeat step 4 9) Note the original Lexile score has been restored Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 14:42:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 12:42:29 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 --- Comment #9 from Kyle M Hall --- Created attachment 39183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39183&action=edit Bug 11368 [QA Followup] * Fix QA failures * Fix copyright * Add file format documentation * Add -c --confirm option * Add -t --test option * Add -h --help option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 14:59:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 12:59:02 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Marc, you still see those messages? On current master (aa8bd7a Koha 3.20 beta) I see no messages at all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 15:06:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 13:06:58 +0000 Subject: [Koha-bugs] [Bug 14202] New: Unexpected parameter for window.open in marc21_linking_section plugin Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Bug ID: 14202 Summary: Unexpected parameter for window.open in marc21_linking_section plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Code contains: window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&index=\" + i + \"&result=\"+defaultvalue,\"marc21_field_7\"+i+\"\",'width=900,height=700,toolbar=false,scrollbars=yes'); The part ,\"marc21_field_7\"+i+\"\", is somewhat unexpected. If I am correct, js could interpret this as the name parameter of window.open. Note that this name is not the title. I propose to remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 15:08:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 13:08:09 +0000 Subject: [Koha-bugs] [Bug 14202] Unexpected parameter for window.open in marc21_linking_section plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13437 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 15:08:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 13:08:09 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14202 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 15:57:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 13:57:00 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #9 from Marcel de Rooy --- Created attachment 39184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39184&action=edit Bug 13437: Replace javascript function parameter in builder The builder contains js functions with a parameter like subfield_managed or i or something similar. This parameter contains the html id of the field corresponding with the plugin. With the functionality of Koha::FrameworkPlugin in place, we can eliminate one js function call and get the same id via the event passed in. Note that this actually makes the function a 'real' event handler. Also note that in many cases this parameter was not used but the id was borrowed from a perl variable like $params->{id}. If the field is not cloned, this is not a problem. But some fields can be cloned and should not use the static perl value but should get it from the event. Test plan: Look for js errors when loading the marc editor. Since the Focus or Click event code has been touched for most marc21 plugins, move your cursor into the field or click on the tag editor button. Verify that the focus event updates the correct field or the click event correctly launches the plugin AND the value comes back into the right field. Bonus: Attach a plugin with popup (like leader) to 040$d. Clone this field. Verify that the two launch buttons operate on the correct value. (This resolves a current bug.) Signed-off-by: Marcel de Rooy Checked all 15 plugins. Plugin marc21_linking_section seems to work, but I could not get it to pass back something useful into my field. (Same without this patch.) Tested the clone button with leader on 040d. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:03:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:03:33 +0000 Subject: [Koha-bugs] [Bug 11115] Pull help files from the manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11115 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|testopia at bugs.koha-communit |indradg at gmail.com |y.org | CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:08:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:08:12 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #10 from Marcel de Rooy --- Ready for signoff. This patch set can go on its own. The see also reports may bring some later refinements, but are not needed right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:12:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:12:02 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 --- Comment #3 from M. Tompsett --- (In reply to Bernardo Gonzalez Kriegel from comment #2) > Marc, you still see those messages? > On current master (aa8bd7a Koha 3.20 beta) I see no messages at all Greetings, I do. I should have also mentioned. This will require Apache 2.4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:14:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:14:08 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 --- Comment #4 from Bernardo Gonzalez Kriegel --- (In reply to M. Tompsett from comment #3) ... > Greetings, I do. I should have also mentioned. This will require Apache 2.4. Ah! I have 2.2, will try in another machine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:18:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:18:21 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:18:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:18:55 +0000 Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly limited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! tatus: Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:19:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:19:21 +0000 Subject: [Koha-bugs] [Bug 14160] typo in AddressFormat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:19:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:19:50 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:20:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:20:13 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:20:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:20:44 +0000 Subject: [Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:21:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:21:12 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! tatus: Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:30:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:30:45 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 39185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39185&action=edit Bug 13421: (RM followup) DBIx updates Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:31:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:31:04 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 39186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39186&action=edit Bug 11006: (RM followup) DBIx updates Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:32:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:32:45 +0000 Subject: [Koha-bugs] [Bug 14160] typo in AddressFormat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:39:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:39:57 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #14 from Tom?s Cohen Arazi --- Please rebase for inclusion ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:40:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:40:28 +0000 Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly limited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:43:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:43:07 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:55:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:55:24 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:55:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:55:45 +0000 Subject: [Koha-bugs] [Bug 14074] 'suggested on' date on suggestion list not correctly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14074 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:56:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:56:10 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:56:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:56:31 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:57:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:57:06 +0000 Subject: [Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:57:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:57:37 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #20 from Tom?s Cohen Arazi --- Parches aplicados en master. Gracias Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 16:59:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 14:59:11 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:06:13 +0000 Subject: [Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:06:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:06:16 +0000 Subject: [Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39145|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 39187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39187&action=edit [PASSED QA] Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts (Introduced by bug 13601) Test plan ========= 1/ enable 'OnSiteCheckouts' pref under Circulation Preferences 2/ go to the checkouts page and try to issue an item to any user. 3/ when the item barcode entry form shows, select the 'On-site checkout' checkbox 4/ the default date due should show as today with 00:00 as HH:MM 5/ apply the patch 6/ repeat steps 2 - 3. The default date due should show today's date with 23:59 as HH:MM. 7/ run koha-qa.pl -c 1 -v 2 Remarks: Testing result match expected test plan output. The QA tests pass with "OK" for the commit. Technical note: There is a confusion with iso and sql date formats at some places in the code. A better way should be provided (later) to fix globally the mismatch between these 2 formats. What happened before this patch: the DateTime was cast to a string and the template received "YYYY-MM-DDTHH:MM:SS" which is an iso formatted date. BUT this format is not managed by Koha::DateUtils::output_pref ("iso" and "sql" are considered as indentical which is wrong). As I did not estimated the problem (how big it is) I prefer to fix it easily (and dirty) for now. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:06:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:06:49 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:11:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:11:38 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Bernardo Gonzalez Kriegel --- Almost all tested, looks good. But reloading kohastructure with your patch applied, gives mysql kohadev < ~/kohaclone/installer/data/mysql/kohastructure.sql ERROR 1005 (HY000) at line 3656: Can't create table 'kohadev.#sql-42d1_401' (errno: 150) Can't understand or find the error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:14:06 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #15 from M. Tompsett --- Created attachment 39188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39188&action=edit Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:14:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:14:11 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #16 from M. Tompsett --- Created attachment 39189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39189&action=edit Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:14:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:14:35 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:14:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:14:46 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38631|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:15:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:15:22 +0000 Subject: [Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:15:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:15:45 +0000 Subject: [Koha-bugs] [Bug 14132] suggestions table is missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:19:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:19:21 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #17 from M. Tompsett --- Fixed conflict, retested, reset back to Passed QA. (*grumbles about commas and white space making things conflict so easily*) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:30:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:30:33 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:30:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:30:35 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 --- Comment #1 from Katrin Fischer --- Created attachment 39190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39190&action=edit Bug 14072: Update German web installer for 3.20 - translates new notice ACQ_NOTIF_ON_RECEIV - translates new permissions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:30:54 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:37:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:37:06 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #60 from Nicole C. Engard --- Removing in discussion as it seems we can maybe get this in now? It's a big big deal to track what was ordered/deleted for reorder and accounting purposes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:38:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:38:15 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan and Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:40:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:40:42 +0000 Subject: [Koha-bugs] [Bug 10235] Koha's syspref search fails to find 'local' sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:47:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:47:31 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 17:47:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 15:47:34 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39190|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 39191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39191&action=edit [SIGNED-OFF] Bug 14072: Update German web installer for 3.20 - translates new notice ACQ_NOTIF_ON_RECEIV - translates new permissions Signed-off-by: Bernardo Gonzalez Kriegel Tested German install till "Gratulation, die Installation ist abgeschlossen" No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 18:34:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 16:34:19 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #240 from Katrin Fischer --- > with OPACprivacy disabled and > AllowPatronToSetCheckoutsVisibilityForGuarantor enabled a patron can see > their guarantor but cannot save changes to whether their checkouts are > shown. The update button doesn't work and a change to this field doesn't > register if using the "submit update request" button Should this be failed QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 18:54:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 16:54:03 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:18:02 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 --- Comment #3 from Indranil Das Gupta --- Created attachment 39192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39192&action=edit Bug 14072: Update German web installer for 3.20 - translates new notice ACQ_NOTIF_ON_RECEIV - translates new permissions Signed-off-by: Bernardo Gonzalez Kriegel Tested German install till "Gratulation, die Installation ist abgeschlossen" No errors Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Same results noted as above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:19:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:19:11 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:35:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:35:33 +0000 Subject: [Koha-bugs] [Bug 5534] koha does not ignore punctuation when searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:38:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:38:16 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39141|0 |1 is obsolete| | Attachment #39142|0 |1 is obsolete| | Attachment #39177|0 |1 is obsolete| | Attachment #39184|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 39193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39193&action=edit Bug 13437: Preliminary changes for marc21 plugins field 008 Preliminary work on marc21_field_008.pl and 008_authorities.pl. Moving $dateentered en $defaultval to lower scope level. date_entered is a new sub (in a module); sub Field008 has been reduced to one line. Added a trivial unit test for date_entered. Note: the format used in date_entered could be added in DateUtils, moving this logic to a better place. Test plan: Use both plugins in the marc21 editor (biblios/authorities). Run the adjusted unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:38:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:38:21 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #12 from Marcel de Rooy --- Created attachment 39194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39194&action=edit Bug 13437: Trivial edits on marc21 plugins before conversion marc21_field_003.pl: copy-pasta comment about date removed marc21_field_005.pl: commented use removed marc21_field_006.pl: old/irrelevant pod lines marc21_field_007.pl: old/irrelevant pod lines marc21_field_008.pl: old/irrelevant pod lines, move sub par line twice marc21_field_008_authorities.pl: whitespace, old/irrelevant pod lines marc21_field_040c.pl: two commented lines removed marc21_field_040d.pl: whitespace, commented lines, old/irrelevant pod marc21_field_245h.pl: whitespace marc21_linking_section.pl: relocated some comment lines, and replaced a new CGI object by the one passed in via the plugin launcher (agreed, this may not be so trivial as the other changes) Test plan: These (trivial) changes are hard to test. Pick a few plugins and verify that behavior is not changed in the marc editor. For the brave: Try marc21_linking_section.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:38:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:38:25 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #13 from Marcel de Rooy --- Created attachment 39195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39195&action=edit Bug 13437: Conversion of marc21 cataloguing plugins to new style This patch converts marc21 plugins to new style by making the following modifications: [1] Replace use strict with use Modern::Perl. This implies that we now re-enabled warnings. There are no redefine warnings anymore, but note that we need to silence some warnings from individual plugins that were covered by disabling the warnings pragma until now. Silencing these individual warnings is outside the scope of this report. [2] Sub plugin_javascript is replaced by an anonymous subroutine $builder. [3] The parameters of $builder are combined in a params hashref. In most cases we only need $params->{id} for the function name. [4] Javascript function Clicxxx is renamed to Clickxxx. [5] The builder does no longer return function_name. [6] Sub plugin is replaced by subroutine $launcher. [7] The parameters of $launcher are combined in a params hashref. We only use $params->{cgi}. Mostly we save that to $input. One exception: $query. [8] The plugins returns a hash with $builder and/or $launcher. Test plan: [1] Run t/db_dependent/FrameworkPlugin.t -incl cataloguing/value_builder/ marc21*.pl. This should catch compile errors and general problems when building or launching these plugins. NOTE: You will see several initialize warnings from individual plugins that were hidden until now by disabling warnings. This is fine; we will be able to address these warnings now on new reports. [2] Check behavior of several plugins in the marc editor. Signed-off-by: Marcel de Rooy Checked all marc21 plugins. Attached unused plugins to some field. Some plugins (unused by default) may need some further attention, but also outside the scope of this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:38:28 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #14 from Marcel de Rooy --- Created attachment 39196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39196&action=edit Bug 13437: Replace javascript function parameter in builder The builder contains js functions with a parameter like subfield_managed or i or something similar. This parameter contains the html id of the field corresponding with the plugin. With the functionality of Koha::FrameworkPlugin in place, we can eliminate one js function call and get the same id via the event passed in. Note that this actually makes the function a 'real' event handler. Also note that in many cases this parameter was not used but the id was borrowed from a perl variable like $params->{id}. If the field is not cloned, this is not a problem. But some fields can be cloned and should not use the static perl value but should get it from the event. Test plan: Look for js errors when loading the marc editor. Since the Focus or Click event code has been touched for most marc21 plugins, move your cursor into the field or click on the tag editor button. Verify that the focus event updates the correct field or the click event correctly launches the plugin AND the value comes back into the right field. Bonus: Attach a plugin with popup (like leader) to 040$d. Clone this field. Verify that the two launch buttons operate on the correct value. (This resolves a current bug.) Signed-off-by: Marcel de Rooy Checked all 15 plugins. Plugin marc21_linking_section seems to work, but I could not get it to pass back something useful into my field. (Same without this patch.) Tested the clone button with leader on 040d. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:39:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:39:14 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 --- Comment #15 from Marcel de Rooy --- Second patch slightly adjusted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:44:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:44:10 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:44:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:44:12 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39178|0 |1 is obsolete| | Attachment #39179|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 39197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39197&action=edit [SIGNED-OFF] Bug 14200 - Unit Tests Signed-off-by: Kyle M Hall Signed-off-by: Karen Bryant -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:44:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:44:41 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 --- Comment #4 from Kyle M Hall --- Created attachment 39198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39198&action=edit [SIGNED-OFF] Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in some cases For some reason the regular expression used to split the multiple ISBN fields can fail which keeps Business::ISBN from being able to parse out and return a valid isbn. Using split() instead of the regex fixes the issue. Test Plan: 1) Apply the unit test patch first 2) prove t/Koha.t 3) Note the failures 4) Apply the second patch 5) prove t/Koha.t 6) Note all tests pass Signed-off-by: Kyle M Hall Signed-off-by: Karen Bryant -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 19:51:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 17:51:20 +0000 Subject: [Koha-bugs] [Bug 5534] koha does not ignore punctuation when searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #9 from Christopher Brannon --- We're seeing this when we do searches between the word "don't" and "dont". This is a real, ongoing problem. I'm wondering if there is anything that can be done outside of waiting for ElasticSearch? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 14 20:01:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 18:01:16 +0000 Subject: [Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- Barton, Does this affect only those two slips, or does it affect any notices as well? Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 20:07:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 18:07:36 +0000 Subject: [Koha-bugs] [Bug 5534] koha does not ignore punctuation when searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- We should fix this taking advantage of DOM: i.e. generating indexes for the strings with punctuation removed. It could be tricky in some scenarios, but it should work. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 20:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 18:08:06 +0000 Subject: [Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 20:08:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 18:08:10 +0000 Subject: [Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37960|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 39199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39199&action=edit [SIGNED-OFF] Bug 10299: authority plugin - authority field are reversed If you click the plugin next to an authority field that is already populated it takes the values from the field and puts them in the search in the reverse order. Test plan: 1/ Edit a biblio 2/ Fill the subfield for an authority field (for instance 650$v, 650$x, 650$y, etc.) 3/ Click on the authority plugin Before this patch, the values were concatenated in the reverse order. With this patch, it should not. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 20:40:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 18:40:27 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 20:40:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 18:40:30 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39138|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 39200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39200&action=edit [SIGNED-OFF] Bug 14195: TestBuilder - A random string should not be longer than the DB field t::lib::TestBuilder::_gen_text does not use correctly the regex and the max parameter to generate the random string (String::Random). This can cause future tests to fail. http://bugs.koha-community.org/show_bug.cgi?id=14195 Signed-off-by: Bernardo Gonzalez Kriegel Script tested, problem occurs, patch fixes it. Bad number on commit subject No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 20:40:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 18:40:51 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 39201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39201&action=edit Bug 14195: (followup) increment number of tests Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 20:46:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 18:46:03 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 --- Comment #10 from Mirko Tietgen --- (In reply to Katrin Fischer from comment #6) > If it's vendor > specific, we might want to reflect that more clearly in the file name and > description. If it's general purpose, we should include notes about the file > format to make this easier to reuse. I thought about broadening the scope of the script when I signed off on the patch, checking with the table for Antolin (German reading platform with quizzes for school kids, run by a publisher). I don't think it's feasible to guess all possible fields and options that may occur in such lists, and given the non-standardized nature of these things, you never know if a format will change at some point. It is easily possible to tweak the script if you know what you need, so I'd say keeping it vendor specific and having more vendor specific scripts of this nature if needed makes sense. This patch is a good starting point for similar tasks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 20:58:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 18:58:10 +0000 Subject: [Koha-bugs] [Bug 12824] Create a general purpose koha-config script? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12824 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14162 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 14 20:58:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 18:58:10 +0000 Subject: [Koha-bugs] [Bug 14162] Instance creation information on YAML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12824 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:06:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:06:39 +0000 Subject: [Koha-bugs] [Bug 14162] Instance creation information on YAML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162 --- Comment #1 from Indranil Das Gupta --- (In reply to Tom?s Cohen Arazi from comment #0) > It would be handy to have information about instance creation on a YAML > file. It could serve for recreating an instance, for creating it, etc. Something on similar lines: Bug 12824, comment 4 by Magnus Bug 12824, comment 4 by Robin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:07:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:07:33 +0000 Subject: [Koha-bugs] [Bug 14162] Instance creation information on YAML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162 --- Comment #2 from Indranil Das Gupta --- (In reply to Indranil Das Gupta from comment #1) > (In reply to Tom?s Cohen Arazi from comment #0) > > It would be handy to have information about instance creation on a YAML > > file. It could serve for recreating an instance, for creating it, etc. > That should read as Something on similar lines: Bug 12824, comment 0 by Magnus Bug 12824, comment 4 by Robin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:08:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:08:23 +0000 Subject: [Koha-bugs] [Bug 14070] Notice not saved when mandatory fields are not filled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14070 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:18:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:18:40 +0000 Subject: [Koha-bugs] [Bug 12824] Create a general purpose koha-config script? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12824 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:24:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:24:56 +0000 Subject: [Koha-bugs] [Bug 14203] New: koha-translate error string for non-existent lang removal Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Bug ID: 14203 Summary: koha-translate error string for non-existent lang removal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: indradg at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org CC: tomascohen at gmail.com An attempt to remove a language that is not installed shows the message: "Error: the selected language is not already installed." I feel that it will be nicer to just have "Error: the selected language is not installed." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:26:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:26:52 +0000 Subject: [Koha-bugs] [Bug 14162] Instance creation information on YAML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162 --- Comment #3 from Tom?s Cohen Arazi --- (In reply to Indranil Das Gupta from comment #2) > (In reply to Indranil Das Gupta from comment #1) > > (In reply to Tom?s Cohen Arazi from comment #0) > > > It would be handy to have information about instance creation on a YAML > > > file. It could serve for recreating an instance, for creating it, etc. > > > > That should read as > > Something on similar lines: > > Bug 12824, comment 0 by Magnus > > Bug 12824, comment 4 by Robin They are related, but talk about different things. Because a cli tool for manipulating the instance's koha-conf.xml file is one thing, and a registry of how instances were created is another one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:39:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:39:59 +0000 Subject: [Koha-bugs] [Bug 13929] opac description not showing on search results for authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13929 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:47:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:47:54 +0000 Subject: [Koha-bugs] [Bug 14203] koha-translate error string for non-existent lang removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 --- Comment #1 from Indranil Das Gupta --- Created attachment 39202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39202&action=edit Bug 14203 - Message for non-existent lang removal A trivial string patch to update the error message displayed to user if koha-translate is used to attempt removal of a language that is not installed. Test plan ========= 1/ attempt to remove a non-existent language by /debian/scripts/koha-translate --remove 2/ it should show "Error: the selected language is not already installed." 3/ apply patch 4/ repeat step 1; it should show "Error: the selected language is not installed." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:48:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:48:47 +0000 Subject: [Koha-bugs] [Bug 14203] koha-translate error string for non-existent lang removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:53:49 +0000 Subject: [Koha-bugs] [Bug 14204] New: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Bug ID: 14204 Summary: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: nick at quecheelibrary.org QA Contact: gmcharlt at gmail.com Bug 12991 altered the creation of label batches such that the batch_id is set at 0 until items are added. The variable in the tests was set at batch creation and not updated after items were added to test batch and this led to failing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:53:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:53:56 +0000 Subject: [Koha-bugs] [Bug 14162] Instance creation information on YAML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162 --- Comment #4 from Indranil Das Gupta --- (In reply to Tom?s Cohen Arazi from comment #3) > (In reply to Indranil Das Gupta from comment #2) > They are related, but talk about different things. Because a cli tool for > manipulating the instance's koha-conf.xml file is one thing, and a registry > of how instances were created is another one. You are right! So more like a YAML based "install log" that can cross-checked / replayed etc? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:55:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:55:02 +0000 Subject: [Koha-bugs] [Bug 14162] Instance creation information on YAML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162 --- Comment #5 from Tom?s Cohen Arazi --- (In reply to Indranil Das Gupta from comment #4) > (In reply to Tom?s Cohen Arazi from comment #3) > > (In reply to Indranil Das Gupta from comment #2) > > > They are related, but talk about different things. Because a cli tool for > > manipulating the instance's koha-conf.xml file is one thing, and a registry > > of how instances were created is another one. > > You are right! So more like a YAML based "install log" that can > cross-checked / replayed etc? Yeah, so better upgrade path for packages too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:59:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:59:40 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 --- Comment #1 from Nick Clemens --- Created attachment 39203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39203&action=edit Bug 14204 - Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 This patch updaes the batch_id variable after items are added to test batch To test: 1. prove t/db_dependent/Labels/t_Batch.t and see two tests fail 2. apply patch 3. prove again, tests pass! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 21:59:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 19:59:38 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 22:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 20:04:01 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 22:04:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 20:04:22 +0000 Subject: [Koha-bugs] [Bug 13610] delete_patrons.pl crashes on debian squeeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13610 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Can this be closed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 22:04:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 20:04:34 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 22:57:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 20:57:03 +0000 Subject: [Koha-bugs] [Bug 14203] koha-translate error string for non-existent lang removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 22:57:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 20:57:06 +0000 Subject: [Koha-bugs] [Bug 14203] koha-translate error string for non-existent lang removal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39202|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 39204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39204&action=edit [SIGNED OFF] Bug 14203 - Message for non-existent lang removal A trivial string patch to update the error message displayed to user if koha-translate is used to attempt removal of a language that is not installed. Test plan ========= 1/ attempt to remove a non-existent language by /debian/scripts/koha-translate --remove 2/ it should show "Error: the selected language is not already installed." 3/ apply patch 4/ repeat step 1; it should show "Error: the selected language is not installed." Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 23:11:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 21:11:56 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 23:53:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 21:53:56 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mathsabypro at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 23:54:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 21:54:09 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 23:55:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 21:55:59 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #61 from mathieu saby --- Sorry Katrin, I'm to far from Koha now to continue my work on that issue. So if someone want to work on it, feel free to take my patches as a base. I'm unassinging me. Mathieu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 14 23:56:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 21:56:52 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mathsabypro at gmail.com |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 14 23:58:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 21:58:16 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #48 from mathieu saby --- Hello I won't be able to work on that bug anymore. Feel free to take my patches as a base for further work if you think they can be useful. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 00:04:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 22:04:31 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #9 from Katrin Fischer --- Shoudl this be needs sign-off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 00:04:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 22:04:45 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 00:07:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 22:07:24 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 --- Comment #49 from Katrin Fischer --- Magnuse, reading your last comment - should this be failed qa for a regression on making 'exceptions'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 00:31:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 22:31:17 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 00:37:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 22:37:29 +0000 Subject: [Koha-bugs] [Bug 14205] New: Deleting an Item/Record does not remove link to course reserve Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 Bug ID: 14205 Summary: Deleting an Item/Record does not remove link to course reserve Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: misilot at fit.edu QA Contact: testopia at bugs.koha-community.org Steps to Reproduce: 1. Login to Staff Site. 2. Go to Course Reserves 3. Create Course 4. Add Reserve 5. Go to item added (delete item/record) 6. Refresh Course (see no items attached) 7. Delete Course 8. See course still listed in the courses (Not deleted) I tested on 3.18.5 and 3.19.00.016 When deleting an item/record it does not remove the link from the course reserves, making it so you cannot remove the course even though it shows no items attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 00:37:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 22:37:56 +0000 Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 01:01:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 23:01:41 +0000 Subject: [Koha-bugs] [Bug 9253] If an item is reserved, at the opac it is marked as available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 01:03:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 May 2015 23:03:28 +0000 Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 06:52:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 04:52:39 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 --- Comment #13 from M. Tompsett --- Created attachment 39205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39205&action=edit Bug 13948: Prevent explosion when Template::Plugin::Stash not installed TEST PLAN --------- 1) Install first two patches 2) do not install, or uninstall Template::Plugin::Stash 3) Upgrade to make sure system preference is added. 4) Set the system preference to turn it on for Staff and OPAC 5) Refresh staff -- kaboom 6) Load OPAC -- kaboom 7) Apply this patch 8) Reload staff and OPAC -- nice HTML comment about what is wrong. 9) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 06:52:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 04:52:36 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 06:55:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 04:55:08 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 --- Comment #14 from M. Tompsett --- (In reply to Kyle M Hall from comment #12) > It appears that while Template::Stash is part of TT, Template::Plugin::Stash > is not part of TT, so we do need to have it as a separate dependency. Okay. Also, I didn't like the explosion in that bad configuration case. I fixed it. Could you test it, Kyle? If it works, let's set this signed off. In the mean time, I'll put it back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 07:11:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 05:11:17 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38903|0 |1 is obsolete| | CC| |amitddng135 at gmail.com --- Comment #6 from Amit --- Created attachment 39206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39206&action=edit Bug 14135 - Local Use syspref addition form missing variable type 'Free' Bug 14135 Adds 'Free' to variabletypes in systempreferences.tt The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or There is no option presented for "Free" which seems to be the most used variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime) This trivial patch proposes to modify the systempreferences.tt and add the option 'Free' to the list offered to users. Test Plan ========= 1/ Go to Home > Administration > System preferences > Local use 2/ Click on 'New preference'. 3/ In the fieldset 'Koha Internal', the variable types offered are Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources. 4/ Clicking on 'Choice' should set the 'preftype' field as 'Choice'. 5/ Apply this patch. 6/ Refresh the page. 7/ The variable types list should read - "Free, Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources". 8/ Clicking on 'Free' should set the 'preftype' field as 'Free'. - No issue found in patch work fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 07:17:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 05:17:05 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 07:27:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 05:27:22 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Bug 12991 has no patches on it, and it is set to NEW. prove t/db_dependent/Labels/t_Batch.t works in master fine. Granted I have no labels. Do you? I'm trying to see why this is a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 07:30:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 05:30:15 +0000 Subject: [Koha-bugs] [Bug 13774] Add the unique anchors of news as links in the RSS for news in Opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7843 |5010 CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- I added depends on 5010, because there is no hardcoded protocol in this link, which means it will be protocol-less currently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 07:30:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 05:30:15 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13774 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 07:30:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 05:30:15 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13774 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 07:39:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 05:39:27 +0000 Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when placing a hold/reservation in Staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #10 from M. Tompsett --- Is this still a problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 07:58:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 05:58:40 +0000 Subject: [Koha-bugs] [Bug 11849] consolidate display of analytic/bound-with analytic item links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11849 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|consolidate display of |consolidate display of |analytic/bound-width |analytic/bound-with |analytic item links |analytic item links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:00:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:00:32 +0000 Subject: [Koha-bugs] [Bug 11849] EasyAnalytics: consolidate display of analytic/bound-with analytic item links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11849 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|consolidate display of |EasyAnalytics: consolidate |analytic/bound-with |display of |analytic item links |analytic/bound-with | |analytic item links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:04:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:04:49 +0000 Subject: [Koha-bugs] [Bug 13445] Scheduled Report, Type=URL fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Offering options/features that don't work is never a good thing - removing it from the GUI would be good in my opinion. I can imagine maybe the reason was not to send out patron information by email, but offer a link to access it instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:06:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:06:21 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- We had another library asking for this - it would be nice to see it moving. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:06:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:06:43 +0000 Subject: [Koha-bugs] [Bug 14070] Notice not saved when mandatory fields are not filled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14070 --- Comment #1 from Indranil Das Gupta --- (In reply to Katrin Fischer from comment #0) > To test: > - Enter a new text for a notice, don't fill the subject line > - Save - a note is shown that not all mandatory fields have been filled in > - Verify: You are kicked back to the overview page of notices, your changes > have not been saved > - Start again... I found another issue too - the same issue affected during edits too. Example: You had mail and print filled in. Now you want to edit print, but accidentally managed to delete one of the fields in the mail fieldset. Koha would allow you to save the record, but in the process knocked off the rest of the mail fieldset data. Wrote a small patch. Uploading in a few. -idg -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:07:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:07:18 +0000 Subject: [Koha-bugs] [Bug 14070] Notice not saved when mandatory fields are not filled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14070 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |indradg at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:12:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:12:19 +0000 Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I can confirm that the new facets are too slow to be used for a big library currently. We tried with a database of rougly 1.000.000 as well and saw even slower response times than in Jonathan's test below. Searches took up to 40 seconds. With the old facets the time came down dramatically to about 4-6 seconds for the same search and is generally much faster. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:13:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:13:04 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:20:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:20:36 +0000 Subject: [Koha-bugs] [Bug 13656] "Change" button for linking a member to an organisation not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 --- Comment #4 from Katrin Fischer --- I have retested this. With the sample data: - Search for an existing 'Kid' patron - buttons display as '?ndern' and 'L?schen' - click '?ndern' - Search for an adult patron to link to and confirm - Suddenly instead of '?ndern', there is 'Change' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:21:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:21:56 +0000 Subject: [Koha-bugs] [Bug 13827] stuck on offline screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13827 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Randy, the maintenance screen indicates that you are not looking at the staff/intranet side, but at the OPAC. As this is an installation question, it's best to ask on the mailing list where more people can help you out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:24:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:24:39 +0000 Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold notifications in patron messaging preferences. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171 --- Comment #5 from Katrin Fischer --- We updated over 15 installations now and the problem only appeared once. It might depend on the version the database started with or something in configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:26:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:26:07 +0000 Subject: [Koha-bugs] [Bug 13959] itemBarcodeFallbackSearch does not appear to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13959 --- Comment #4 from Katrin Fischer --- Hi Nicole, did the items you were looking for have dummy barcodes or no barcodes at all? (see bug 11599) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:26:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:26:43 +0000 Subject: [Koha-bugs] [Bug 12709] Mailing list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12709 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|Mailling list |Mailing list CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:30:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:30:43 +0000 Subject: [Koha-bugs] [Bug 14104] Renew check-box appears on checked out items with item level holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 13919 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:30:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:30:43 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #20 from Katrin Fischer --- *** Bug 14104 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 08:32:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 06:32:01 +0000 Subject: [Koha-bugs] [Bug 14159] history only showing up to 2014 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- It's working now for me in master - maybe fixed with an update since? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 10:15:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 08:15:32 +0000 Subject: [Koha-bugs] [Bug 13656] "Change" button for linking a member to an organisation not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 --- Comment #5 from Josef Moravec --- Strange, I see the similar behavior but with "set to patron" string... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 12:06:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 10:06:12 +0000 Subject: [Koha-bugs] [Bug 12459] clicking spent on acq main page not showing everything In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- Going to attach a patch on 14172 that should fix this as well. Problem also appeared when there was no item to begin with (subscription orders). *** This bug has been marked as a duplicate of bug 14172 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 12:06:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 10:06:12 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: "Spent" lists incorrect titles and wrong total in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #3 from Katrin Fischer --- *** Bug 12459 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 12:23:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 10:23:44 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: "Spent" lists incorrect titles and wrong total in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 12:23:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 10:23:46 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: "Spent" lists incorrect titles and wrong total in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 --- Comment #4 from Katrin Fischer --- Created attachment 39207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39207&action=edit Bug 14172: Acq: Orders without items missing from 'spent' list If the item for an order had been deleted since or there was never an item created for the order (subscription orders) those records where missing from the "Spent" page in acquisitions. Patch corrects the SQL to list the correct records. To test: - Create different orders for one fund and receive them - normal order with a few items - subscription order (no item) - normal order with an item, delete the item after receiving - include some freight cost in one of the invoices - Compare the amount spent shown on the acq start page with the amount shown at the end of the 'spent' page - Without the patch, the amounts don't match and not all received titles are listed - With the patch, amounts should match and list shoudl be complete -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 12:23:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 10:23:57 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: "Spent" lists incorrect titles and wrong total in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 12:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 10:25:30 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Acq: "Spent" lists |Acq: Orders without items |incorrect titles and wrong |missing from 'Spent' list |total in some cases | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 12:42:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 10:42:58 +0000 Subject: [Koha-bugs] [Bug 13656] "Change" button for linking a member to an organisation not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 12:43:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 10:43:00 +0000 Subject: [Koha-bugs] [Bug 13656] "Change" button for linking a member to an organisation not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 --- Comment #6 from Josef Moravec --- Created attachment 39208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39208&action=edit Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 12:43:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 10:43:17 +0000 Subject: [Koha-bugs] [Bug 13656] "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Change" button for linking |"Change"/"Set to patron" |a member to an organisation |button for linking a member |not translatable |to an organisation (or | |child to guarantor) not | |translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 12:47:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 10:47:55 +0000 Subject: [Koha-bugs] [Bug 13656] "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39208|0 |1 is obsolete| | --- Comment #7 from Josef Moravec --- Created attachment 39209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39209&action=edit Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 7.1. update translation (koha-translate -u language_code) 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 14:32:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 12:32:25 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix |Fix |t/db_dependent/Labels/t_Bat |t/db_dependent/Labels/t_Bat |ch.t failing test from Bug |ch.t failing test from Bug |12991 |12911 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 15:06:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 13:06:51 +0000 Subject: [Koha-bugs] [Bug 14206] New: notice using only the 'print' template can't be deleted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Bug ID: 14206 Summary: notice using only the 'print' template can't be deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: P3 Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org Use-case: Wanted a 'letter' that will only be printed and NOT emailed. What I found: 1/ can define and save such a letter with only the print template filled 2/ letter shows up in the list or letters with 'edit' and 'delete' links next to it 3/ edit works fine, but delete doesn't work. In fact, with delete, the values of library, module, code and name are not displayed. 4/ delete does not work for a letter using print only template To delete: Edit the letter and add a 'print' template (additionally). Now the letter can be deleted. Question: is this the correct / expected behaviour? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 15:11:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 13:11:34 +0000 Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 Paul Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lostjohnny1 at gmail.com --- Comment #12 from Paul Johnson --- Hi Amit I['ve just had a go at trying this on a sandbox and it will not load. Any chance you could try re-patching it again. thanks Paul -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 15:20:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 13:20:16 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14207 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 15:20:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 13:20:16 +0000 Subject: [Koha-bugs] [Bug 14207] New: Improving circulation performance by caching yaml file Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14207 Bug ID: 14207 Summary: Improving circulation performance by caching yaml file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.fiol at biblibre.com Reporter: julian.fiol at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 7923 Created attachment 39210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39210&action=edit Caching yaml file (requirements, test plans and proofs) This patch improve circulation performance by caching yaml file With this patch we saved between 300ms and 500ms on circulation page. All requirements, test plans and proofs are explained in the attached PDF file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 15:28:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 13:28:44 +0000 Subject: [Koha-bugs] [Bug 14207] Improving circulation performance by caching yaml file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14207 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 15:28:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 13:28:46 +0000 Subject: [Koha-bugs] [Bug 14207] Improving circulation performance by caching yaml file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14207 --- Comment #1 from Julian FIOL --- Created attachment 39211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39211&action=edit Bug 14207 - Improving circulation performance by caching yaml file This patch improve circulation performance by caching yaml file With this patch we saved between 300ms and 500ms on circulation page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 16:22:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 14:22:14 +0000 Subject: [Koha-bugs] [Bug 14070] Notice not saved when mandatory fields are not filled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14070 --- Comment #2 from Indranil Das Gupta --- Created attachment 39212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39212&action=edit Bug 14070 Improved handling of Notice saving Addresses the issue of losing already entered data when an user attempts to save a new or existing letter / notice. Happened if the used template's (i.e. email, phone, print or sms) mandatory field(s) i.e. subject or content were left empty. Test plan ========= 1/ Enter a new text for a notice, don't fill the subject line of the template used 2/ Save - a note is shown that not all mandatory fields have been filled in 3/ Verify: You are kicked back to the overview page of notices, your changes have not been saved 4/ apply patch 5/ repeat step #1 and #2 - a note is shown that not all mandatory fields have been filled in. You should remain on the add_form screen without losing data due to redirection back to Notices overview page. 6/ run koha qa tests tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 16:22:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 14:22:35 +0000 Subject: [Koha-bugs] [Bug 14070] Notice not saved when mandatory fields are not filled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14070 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 16:27:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 14:27:58 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 16:28:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 14:28:39 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 16:28:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 14:28:52 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 16:29:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 14:29:50 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #1 from Indranil Das Gupta --- I looked into C4/Letters.pm sub getletter { my ( $module, $code, $branchcode, $message_transport_type ) = @_; $message_transport_type ||= 'email'; While tools/letters.pl is invoking getletter with only $module, $code, $branchcode params -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 16:44:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 14:44:21 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 16:44:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 14:44:23 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39203|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 39213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39213&action=edit Bug 14204 - Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 This patch updaes the batch_id variable after items are added to test batch To test: 1. prove t/db_dependent/Labels/t_Batch.t and see two tests fail 2. apply patch 3. prove again, tests pass! Signed-off-by: Mark Tompsett NOTE: The $batch->add_item() call to C4::Creators::Batch::add_item triggers the change of the batch_id so this line is necessary! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 16:57:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 14:57:30 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #4 from Zeno Tajoli --- Created attachment 39214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39214&action=edit Patch for sorting z39.50 servers IN acq The patch is for acqui/z3950_search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 16:57:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 14:57:49 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 16:59:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 14:59:23 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #5 from Zeno Tajoli --- To fix the bug you must applay the two patch. To test the second patch you need to use z39.50 inside an order into ACQ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 17:37:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 15:37:54 +0000 Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 17:39:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 15:39:04 +0000 Subject: [Koha-bugs] [Bug 14208] New: Allow for Write of Selected Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14208 Bug ID: 14208 Summary: Allow for Write of Selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: misilot at fit.edu QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On the fines page we have the option to write off all fines, pay all fines, or pay selected fines. Wouldn't it make sense to be able to also write off selected fines? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 18:10:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 16:10:06 +0000 Subject: [Koha-bugs] [Bug 14209] New: opacserialdefaulttab ignored with bibs having items <1 or >50 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14209 Bug ID: 14209 Summary: opacserialdefaulttab ignored with bibs having items <1 or >50 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org opacserialdefaulttab is set to holdings Opac defaults to the subscription tab for biblio records when the number of holdings =0 or the number of holdings >50 If library selects a system preference for holdings, it should display holdings tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:01:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:01:23 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 --- Comment #14 from Heinrich Hartl --- I have done a little bit black box analysis: how does the bar code behave under different sized labels/cards. The analysis is done with 3.18.5, hence without this patch or any other modification. 1. The bar code position defines the position of the lower left corner of the bar code string (as designed). The bar code includes a little bit of white lead space, approximately half a code character.Therefore the first black bar of the bar code is found that amount to the right of the defined start position. 2.The length of the bar code string including white lead and trailing space is approximately 75% of the label width. if this observed length is associated with a value 0.8 some extra space is included in the calculation. 3. The lower left position defined is the baseline of the human readable string. If that string is not printed the height reserved for the human readable string is left blank. 4. the height of human readable string + the bar code is about 27% of the label/card height. The bar code alone is 20% of the label/card height. If these values are associated with an internal scale 0.01 I do not know to which basis this scale is chosen. 14 digits + start char + stop char were measured 49 mm long 7mm high on a template with label/cards 70*36mm close to credit card size 85*54mm. Aspect ratio of bar code letters h/w hence was 7/3 w~0.5*h. Unfortunately the bar code is the only element of the layout that reacts to the size of the label/card. All text and pictures remain same size and position (with respect to lower left corner) with disregard to the size of the label/card I think it is desirable to have a consistent and foreseeable behaviour. May I suggest to think about giving the barcode a height in chosen units and define its (estimated) length from the number of characters in string * character width (derived from height * aspect factor 0,5). It is then the users responsibility to choose a barcode height in the layout which results an acceptable string length not exceeding the available space on the label/card. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:05:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:05:31 +0000 Subject: [Koha-bugs] [Bug 13656] "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:05:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:05:34 +0000 Subject: [Koha-bugs] [Bug 13656] "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39209|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 39215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39215&action=edit Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 7.1. update translation (koha-translate -u language_code) 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors Fixed message capitalization -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:06:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:06:19 +0000 Subject: [Koha-bugs] [Bug 13656] "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39215|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 39216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39216&action=edit [SIGNED-OFF] Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 7.1. update translation (koha-translate -u language_code) 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors Fixed message capitalization -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:10:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:10:30 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12911 CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:10:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:10:30 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14204 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:10:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:10:41 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:30:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:30:52 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39213|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 39217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39217&action=edit [PASSED QA] Bug 14204: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 This patch updaes the batch_id variable after items are added to test batch To test: 1. prove t/db_dependent/Labels/t_Batch.t and see two tests fail 2. apply patch 3. prove again, tests pass! Signed-off-by: Mark Tompsett NOTE: The $batch->add_item() call to C4::Creators::Batch::add_item triggers the change of the batch_id so this line is necessary! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:32:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:32:07 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 39218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39218&action=edit Bug 14204: (QA followup) remove unneeded messages Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:32:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:32:21 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:39:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:39:58 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 --- Comment #15 from Chris Nighswonger --- The problem with this is that PDF::Barcode does some internal scaling on the image depending on the length of the number, etc. So one ends up chasing ones tail so to speak. The currently proposed solution avoids this effect for the most part. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:43:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:43:49 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Nick for this quick response! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:44:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:44:14 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:44:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:44:40 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #37 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan, almost there! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:45:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:45:16 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Good job Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:45:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:45:20 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39218|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 39219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39219&action=edit Bug 14204: (QA followup) remove unneeded messages TEST PLAN --------- 1) Apply first patch 2) prove -v t/db_dependent/Labels/t_Batch.t -- YUCK! No meaningful messages on a lot of the ok's. 3) Apply this patch 4) prove -v t/db_dependent/Labels/t_Batch.t -- YAY! Meaningful test results 5) koha qa test tools Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:46:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:46:48 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:46:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:46:49 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Bug 12633 depends on bug 14038, which changed state. Bug 14038 Summary: SQLHelper replacement - C4::Members::Search - nl-search.pl http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:48:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:48:01 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:53:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:53:30 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:58:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:58:54 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39011|0 |1 is obsolete| | --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 39220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39220&action=edit [PASSED QA] Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN --------- 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools Signed-off-by: Indranil Das Gupta Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:59:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:59:03 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39012|0 |1 is obsolete| | --- Comment #19 from Tom?s Cohen Arazi --- Created attachment 39221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39221&action=edit [PASSED QA] Bug 13673: Remove diags TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools Signed-off-by: Indranil Das Gupta Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:59:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:59:13 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39013|0 |1 is obsolete| | --- Comment #20 from Tom?s Cohen Arazi --- Created attachment 39222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39222&action=edit [PASSED QA] Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN --------- 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. Signed-off-by: Indranil Das Gupta Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:59:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:59:28 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #21 from Tom?s Cohen Arazi --- Created attachment 39223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39223&action=edit Bug 13673: (QA followup) Add license Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 20:59:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 18:59:52 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 21:03:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 19:03:19 +0000 Subject: [Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 21:03:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 19:03:48 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #22 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 21:04:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 19:04:14 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #19 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 21:10:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 19:10:38 +0000 Subject: [Koha-bugs] [Bug 13591] Rss sample templates have hardcoded urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 21:12:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 19:12:16 +0000 Subject: [Koha-bugs] [Bug 13591] Rss sample templates have hardcoded urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Good catch Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 21:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 19:14:06 +0000 Subject: [Koha-bugs] [Bug 14052] apt-get install koha-common error 403 Forbidden In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14052 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Version|unspecified |3.18 QA Contact| |testopia at bugs.koha-communit | |y.org CC| |robin at catalyst.net.nz, | |tomascohen at gmail.com Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org Component|Koha |Packaging Product|Koha security |Koha Group|Koha security | Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 21:27:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 19:27:00 +0000 Subject: [Koha-bugs] [Bug 14070] Notice not saved when mandatory fields are not filled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14070 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 21:27:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 19:27:02 +0000 Subject: [Koha-bugs] [Bug 14070] Notice not saved when mandatory fields are not filled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14070 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39212|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 39224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39224&action=edit Bug 14070 Improved handling of Notice saving Addresses the issue of losing already entered data when an user attempts to save a new or existing letter / notice. Happened if the used template's (i.e. email, phone, print or sms) mandatory field(s) i.e. subject or content were left empty. Revised Test plan ================= 1) Set the SMSSendDriver system preference to *anything* in order to enable entry of SMS notices. (Home -> Koha administration -> Global system preferences -> Patrons) 2) Set the TalkingTechItivaPhoneNotification system preference to Enable in order to enable entry of Phone notices. (Home -> Koha administration -> Global system preferences -> Patrons) 3) Home -> Tools -> Notices & slips -> + New notice 4) For each of the four types (Email, Phone, Print, SMS): a) Enter a code and description. (e.g. TST, testing) b) type 'test' into the letter box. c) Click 'Submit' -- You should get a warning, but it will force you back to the Notices & Slips page! This is WRONG! 5) Apply this patch 6) Repeat steps 4a-c for each type, but also. -- when you click Submit, you will get a warning, but not be redirected d) After the warning, clear out the letter box before attempting the next type. The warning gets caught for the first problem section, not all of them. Fixing that is beyond the scope of this bug. 7) run koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 22:03:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 20:03:40 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10544|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 39225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39225&action=edit Bug 7571 Maintain exchange rate history Keep track of changes to exchange rates for accounting purposes. History is displayed with each currency. Behaviour is as expected. NOTE: Removed sign off, because this also fails to update kohastructure.sql in order to create the currency history table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 22:50:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 20:50:13 +0000 Subject: [Koha-bugs] [Bug 14210] New: Manage staged marc records deletes replaced item when undoing import into catalog Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14210 Bug ID: 14210 Summary: Manage staged marc records deletes replaced item when undoing import into catalog Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nick at quecheelibrary.org QA Contact: testopia at bugs.koha-community.org If records are staged with the item rule: Replace items if matching bib was found (only for existing items) And some items are successfully updated those items are deleted when you click: Undo import into catalog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 22:54:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 20:54:23 +0000 Subject: [Koha-bugs] [Bug 14210] Manage staged marc records deletes replaced item when undoing import into catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think the item values from before the update are not stored anywhere, os it might be a problem turning them back... maybe what we could do for now is print a big warn? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:03:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:03:19 +0000 Subject: [Koha-bugs] [Bug 14164] Change in due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- (In reply to vimal kumar from comment #0) > Case1: > No fine displaying. The bookk has Rs.20/- fine The screen shot taken on > 20/4/2015 while check in the book. Eventhough the duedate is 31/3/2015 no > fine generated for this student. See the screenshot > - Check findesmode is active - Check your holiday calendar and OverdueNoticeCalendar - Check your circulation conditions, especially if there is a rule that applies and the grace period > > Case 2: > Automatically changing the due date. As per system we are issuing the books > for 25 days but for this student the due date is less than 25 days(book > India govt and politics) There are 2 things that can shorten the due date: - the patron is about to expire (see ReturnBeforeExpiry) - holds on the record (see decreaseLoanHighHolds*) > Case3: > System automatically forgiving the fines without our instruction - Check your action_logs table if your fines log is turned on for more information - I think it is likely the 'forgive fines' checkbox was checked on return I feel like those issues are more likely to be configuration issues than bugs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:08:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:08:09 +0000 Subject: [Koha-bugs] [Bug 14176] No fine displaying. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14176 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 14164 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:08:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:08:10 +0000 Subject: [Koha-bugs] [Bug 14164] Change in due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14164 --- Comment #2 from Katrin Fischer --- *** Bug 14176 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:08:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:08:59 +0000 Subject: [Koha-bugs] [Bug 14177] Automatically changing the due date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 14164 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:08:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:08:59 +0000 Subject: [Koha-bugs] [Bug 14164] Change in due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14164 --- Comment #3 from Katrin Fischer --- *** Bug 14177 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:09:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:09:20 +0000 Subject: [Koha-bugs] [Bug 14178] System automatically forgiving the fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14178 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 14164 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:09:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:09:20 +0000 Subject: [Koha-bugs] [Bug 14164] Change in due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14164 --- Comment #4 from Katrin Fischer --- *** Bug 14178 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:11:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:11:06 +0000 Subject: [Koha-bugs] [Bug 14183] [Koha] z39.50 search refused to connect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14183 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Jose, could this be a temporary problem? Also often a local firewall causes this kind of problem. Please check and reopen if necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:20:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:20:50 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38751|0 |1 is obsolete| | --- Comment #2 from Indranil Das Gupta --- Created attachment 39226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39226&action=edit Bug 14110: Silence t/00-load.t warnings prove t/00-load.t has noisy messages. This catches them. TEST PLAN --------- 1) $ prove -v t/00-load.t -- ugly INIT errors, etc. 2) apply patch 3) $ prove -v t/00-load.t -- nice "Expected warnings" type messages on the ones that were noisy. 4) koha qa test tools Signed-off-by: Indranil Das Gupta Test remarks: Expected outcome as per test plan. No anomaly noted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:24:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:24:13 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:25:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:25:10 +0000 Subject: [Koha-bugs] [Bug 9157] Enhance inventory tool to skip checked out barcodes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9157 --- Comment #5 from Katrin Fischer --- (In reply to M. Tompsett from comment #4) > (In reply to Katrin Fischer from comment #3) > > So I think maybe what's needed would be: > > > > - an option to not automatically check items in > > - an option to set the inventory/last seen date manually > > > > ? > > I thought the request was for: > > (In reply to Melia Meggs from comment #0) > > The librarian > > would prefer that the inventory tool were enhanced so that it's smart enough > > to skip any items that are currently checked out at the time the .txt file > > is uploaded. I was worried about changing existing behaviour - so thought this might be better as an option. Looking at this again, isn't this what "Skip items on loan: " should do? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:27:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:27:14 +0000 Subject: [Koha-bugs] [Bug 13997] no flag is not set in the Home> Visitors> Setting privileges. Bug in log "Use of uninitialized value $roadtype in string..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13997 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- Hi annvpro, looking at your screenshot I think the issue is that some of the mandatory data got 'unchecked' while running the web installer or that you installed with a non-english installer and out of date files. Please bring this up on the mailing list if it's still an issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:30:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:30:33 +0000 Subject: [Koha-bugs] [Bug 14211] New: Clean up printing lists in staff interface Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14211 Bug ID: 14211 Summary: Clean up printing lists in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Moved here from bug 11574 that took another direction: Would like to see list printing from staff client cleaned up. Right now, the list printing includes buttons and the "Add and item..." section below. These should be omitted to save paper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:30:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:30:50 +0000 Subject: [Koha-bugs] [Bug 14211] Clean up printing lists in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14211 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11574 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:30:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:30:50 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14211 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:34:07 +0000 Subject: [Koha-bugs] [Bug 4960] No way to enter custom purchase order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4960 --- Comment #5 from Katrin Fischer --- I think we have a place for the number with the basket name, but it still might be nice to have an option to automatically generate what goes in there, so 4456 is still valid. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:35:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:35:30 +0000 Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456 --- Comment #12 from Katrin Fischer --- The approach taken here looks similar to the cataloguing plugin stocknumberAV.pl - maybe some kind of plugin mechanism would be helpful? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:37:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:37:36 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38752|0 |1 is obsolete| | --- Comment #4 from Indranil Das Gupta --- Created attachment 39227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39227&action=edit Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Poorly capturing warnings_exist test cases generated noise. This patch fixes that. TEST PLAN --------- 1) $ prove t/Auth_with_shibboleth.t -- There are messages about lines 132 and 133. Noise. 2) Apply patch 3) $ prove t/Auth_with_shibboleth.t -- No messages. YAY! 4) koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Test remarks: Expected outcome as per test plan. No anomaly noted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:40:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:40:10 +0000 Subject: [Koha-bugs] [Bug 12616] Locale in subscriptions not preselecting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #4 from Katrin Fischer --- Somethins strange is happening here - on master the options are clean and complete, but on switching to German the language list stays in English? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:41:24 +0000 Subject: [Koha-bugs] [Bug 7806] Illegal dates are used to signal non existing dates. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I like NULL better and it looks less dangerous and cleaner than 1970-01-01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:42:27 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Switching status to 'needs signoff' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:46:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:46:48 +0000 Subject: [Koha-bugs] [Bug 9530] Allow separate 'Reply To' and 'From' email address for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #44 from Katrin Fischer --- > ::: C4/Letters.pm > @@ +286,5 @@ > > + my $message = Koha::Email->new(); > > + my %mail = $message->create_message_headers( > > + { > > + to => $email, > > + from => $branchdetails->{'branchemail'}, > > Was there a reason the > || C4::Context->preference("KohaAdminEmailAddress") > portion was removed? > I'm trying to rescue bug 8000. Please take a look at Koha::Email: 45 $params->{from} ||= C4::Context->preference('KohaAdminEmailAddress'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:50:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:50:17 +0000 Subject: [Koha-bugs] [Bug 11267] default notices should not be allowed to be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11267 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I agree with Jonathan - For example there is no other way to turn off the suggestion related notice templates than deleting them. And some notices are not strict about the code - like the overdue notices can really use any code, as long as they are defined in the notice triggers. We'd probably need to make only some non-deleteable. Or have a nicer error message telling the librarian to create a new notice with code X instead of having Koha explode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:52:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:52:33 +0000 Subject: [Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 --- Comment #7 from Katrin Fischer --- (In reply to Kyle M Hall from comment #4) > For the most part the system goes like this for selecting circulation rules: > > 1) If CircControl is set to "the library you are logged in at" circ rules > will be selected based on the logged in branchcode > ... Thx for explaining Kyle! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 15 23:58:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 21:58:07 +0000 Subject: [Koha-bugs] [Bug 13792] Impossibility to pay a fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Juliane, I just retested this on current master and had no problems paying the enrolment fee. Please reopen if you still see this problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:00:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:00:08 +0000 Subject: [Koha-bugs] [Bug 13831] Item history is anonymized when borrower anonymizes his reading history using Immediate deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13831 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 9011 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:00:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:00:08 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #107 from Katrin Fischer --- *** Bug 13831 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:05:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:05:41 +0000 Subject: [Koha-bugs] [Bug 9269] Remove DefaultLanguageField008 syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9269 --- Comment #4 from Katrin Fischer --- (In reply to Jonathan Druart from comment #2) > Katrin, I don't see anything on bug 9145 related to this pref. I think I confused the bug numbers again - but can't find the right bug now :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:18:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:18:27 +0000 Subject: [Koha-bugs] [Bug 13877] seasonal predictions showing wrong in test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Created attachment 39228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39228&action=edit seasonal pattern not correctly predicted Seeing the same behaviour as Nicole - also: Locale is set to German, but seasons appear in English. Could it be the problem appears when seasonal is not first? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:18:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:18:37 +0000 Subject: [Koha-bugs] [Bug 13877] seasonal predictions showing wrong in test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:21:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:21:05 +0000 Subject: [Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756 --- Comment #2 from Katrin Fischer --- (In reply to Jonathan Druart from comment #1) > What do you suggest? I think we should display a message that as no AnonymousPatron has been set up the data couldn't be anonymized. - Stating we deleted something while we didn't is quite evil in this case. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:23:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:23:25 +0000 Subject: [Koha-bugs] [Bug 14196] Encoding error adding new biblio in custom framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14196 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Pablo, can you check if your framework includes the controlfield for setting the encoding for the MARC record? - I think it's LDR, pos. 9 Make sure that it's also linked to the standard plugin for the leader. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:23:32 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel at gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- A problem here... git bz apply 14111 Bug 14111 - Silence warnings t/Auth_with_shibboleth.t 38832 - Bug 14111 - More t/Auth_with_shibboleth.t silencing 39227 - Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14111 - More t/Auth_with_shibboleth.t silencing fatal: sha1 information is lacking or useless (t/Auth_with_shibboleth.t). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:26:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:26:17 +0000 Subject: [Koha-bugs] [Bug 5534] koha does not ignore punctuation when searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- I think also ICU could help/work here - I remember we tested both, mapping - to a space and to nothing, only thing that didn't seem possible is doing both at the same time. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:27:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:27:31 +0000 Subject: [Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:27:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:27:33 +0000 Subject: [Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38759|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 39229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39229&action=edit [SIGNED-OFF] Bug 14118: Silence warnings t/DataTables/Members.t After cleaning 'prove t' up. 'prove -r t' was attempted next. A couple uninitialized variable warning were triggered. TEST PLAN ---------- 1) prove t/DataTables/Members.t -- warnings. 2) apply patch 3) prove t/DataTables/Members.t -- no warnings. 4) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel Cleaned. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:29:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:29:27 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |h.meissner.82 at web.de, | |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Nicole, I think this is how it's intended to work and not sure how it could be changed to work differently. See http://wiki.koha-community.org/wiki/Automatic_renewal_RFC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:32:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:32:19 +0000 Subject: [Koha-bugs] [Bug 14120] Silence warnings t/db_dependent/Auth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14120 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:32:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:32:22 +0000 Subject: [Koha-bugs] [Bug 14120] Silence warnings t/db_dependent/Auth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14120 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38762|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 39230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39230&action=edit [SIGNED-OFF] Bug 14120: Fixing t/db_dependent/Auth.t noise TEST PLAN --------- 1) $ prove t/db_dependent/Auth.t -- warnings 2) Apply this patch 3) $ prove t/db_dependent/Auth.t -- only one specific type of warning 4) Apply bug 5010 patch 5) $ prove t/db_dependent/Auth.t -- noisy is eliminated 6) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel With patch only one warn With 5010 no more warns No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:35:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:35:10 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- No warns on current master... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:35:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:35:48 +0000 Subject: [Koha-bugs] [Bug 11490] Deleting Batch Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 --- Comment #2 from Katrin Fischer --- Hi Jonathan, I'd agree that the behaviour described doesn't match the syspref description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:49:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:49:00 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 00:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 22:49:17 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com --- Comment #6 from Indranil Das Gupta --- (In reply to Bernardo Gonzalez Kriegel from comment #5) > A problem here... > > git bz apply 14111 > Bug 14111 - Silence warnings t/Auth_with_shibboleth.t > > 38832 - Bug 14111 - More t/Auth_with_shibboleth.t silencing > 39227 - Bug 14111: Silence warnings in t/Auth_with_shibboleth.t > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 14111 - More t/Auth_with_shibboleth.t silencing > fatal: sha1 information is lacking or useless (t/Auth_with_shibboleth.t). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. Bernardo: I believe I goofed up there! :-( that mess is quite likely my creation. I'm trying to git-revert. But no success so far. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 01:04:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 23:04:23 +0000 Subject: [Koha-bugs] [Bug 12616] Locale in subscriptions not preselecting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 --- Comment #5 from Bernardo Gonzalez Kriegel --- Sorry but can't reproduce, on master and 3.16.10 Tried using German and Spanish -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 16 01:28:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 23:28:59 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39227|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 39231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39231&action=edit Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Poorly capturing warnings_exist test cases generated noise. This patch fixes that. TEST PLAN --------- 1) $ prove t/Auth_with_shibboleth.t -- There are messages about lines 132 and 133. Noise. 2) Apply patch 3) $ prove t/Auth_with_shibboleth.t -- No messages. YAY! 4) koha qa test tools Signed-off-by: Indranil Das Gupta Test remarks: Expected outcome as per test plan. No anomaly noted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 01:29:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 23:29:05 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38832|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 39232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39232&action=edit Bug 14111 - More t/Auth_with_shibboleth.t silencing TEST PLAN --------- 1) Apply first patch 2) prove t/Auth_with_shibboleth.t -- failed?! 3) apply this patch 4) prove t/Auth_with_shibboleth.t -- success. *whew* 5) koha-qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 01:32:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 23:32:00 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38752|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 01:32:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 23:32:13 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38832|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 01:32:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 23:32:24 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 01:32:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 23:32:36 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 01:49:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 23:49:14 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from M. Tompsett --- Okay... Here's the deal. Test the first patch with or without 5010. No issues. It will silence problems. Apply just 5010, and you will see problems. Apply the second patch on top of 5010 and those problems are solved. However, it is still noisy. Apply the first and test it, noise disappears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 01:57:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 May 2015 23:57:06 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #3 from M. Tompsett --- (In reply to Bernardo Gonzalez Kriegel from comment #2) > No warns on current master... Apache 2.4 issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 02:04:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 00:04:56 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #104 from M. Tompsett --- (In reply to M. Tompsett from comment #103) > I ended up making the same sorts of changes that are in bug 14111 in order > for it to pass the t/Auth_with_shibboleth.t tests. Specifically, I applied the second patch of bug 14111 in order to ensure prove t/Auth_with_shibboleth.t did not fail. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 02:25:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 00:25:33 +0000 Subject: [Koha-bugs] [Bug 14207] Improving circulation performance by caching yaml file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14207 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 02:25:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 00:25:36 +0000 Subject: [Koha-bugs] [Bug 14207] Improving circulation performance by caching yaml file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14207 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39211|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 39233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39233&action=edit [SIGNED-OFF] Bug 14207: Improving circulation performance by caching yaml file This patch improve circulation performance by caching yaml file With this patch we saved between 300ms and 500ms on circulation page. Signed-off-by: Bernardo Gonzalez Kriegel Times can be different, but is a gain anyway. Work as described following test plan (pdf) No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 08:01:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 06:01:45 +0000 Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 --- Comment #4 from M. Tompsett --- Tweak the other currency files too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 11:26:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 09:26:57 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38752|0 |1 is obsolete| | --- Comment #10 from Indranil Das Gupta --- Created attachment 39234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39234&action=edit Bug 14111: Silence warnings in t/Auth_with_shibboleth.t Poorly capturing warnings_exist test cases generated noise. This patch fixes that. TEST PLAN --------- 1) $ prove t/Auth_with_shibboleth.t -- There are messages about lines 132 and 133. Noise. 2) Apply patch 3) $ prove t/Auth_with_shibboleth.t -- No messages. YAY! 4) koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Test remarks: Expected outcome as per test plan. No anomaly noted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 11:27:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 09:27:08 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38832|0 |1 is obsolete| | --- Comment #11 from Indranil Das Gupta --- Created attachment 39235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39235&action=edit Bug 14111 - More t/Auth_with_shibboleth.t silencing TEST PLAN --------- 1) Apply first patch 2) prove t/Auth_with_shibboleth.t -- failed?! 3) apply this patch 4) prove t/Auth_with_shibboleth.t -- success. *whew* 5) koha-qa test tools. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Test remarks: Expected outcome as per test plan. No anomaly noted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 11:29:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 09:29:14 +0000 Subject: [Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 11:35:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 09:35:24 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com --- Comment #4 from Indranil Das Gupta --- (In reply to Bernardo Gonzalez Kriegel from comment #2) > No warns on current master... this is what I have (gitified install): l2c2technologies at gadfly:~/koha$ apache2 -v Server version: Apache/2.4.7 (Ubuntu) Server built: Mar 10 2015 13:05:59 test result l2c2technologies at gadfly:~/koha$ prove t/db_dependent/Auth_with_cas.t t/db_dependent/Auth_with_cas.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.01 usr 0.01 sys + 0.18 cusr 0.00 csys = 0.20 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 13:39:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 11:39:37 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com --- Comment #3 from Indranil Das Gupta --- I have problems applying this patch with git bz Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2633, in do_attach(*args) File "/usr/local/bin/git-bz", line 1999, in do_attach attach_commits(bug, commits, edit_comments=global_options.edit) File "/usr/local/bin/git-bz", line 1914, in attach_commits description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body) File "/usr/local/bin/git-bz", line 1867, in edit_attachment_comment lines = edit_template(template.getvalue()) File "/usr/local/bin/git-bz", line 811, in edit_template f.write(template) UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 30: ordinal not in range(128) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 13:43:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 11:43:15 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Bernardo Gonzalez Kriegel --- (In reply to M. Tompsett from comment #3) > (In reply to Bernardo Gonzalez Kriegel from comment #2) > > No warns on current master... > > Apache 2.4 issue. Server version: Apache/2.4.7 (Ubuntu) HEAD: 607b224 Bug 13591: Pass OPACBaseURL to rss creation process prove t/db_dependent/Auth_with_cas.t t/db_dependent/Auth_with_cas.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.04 usr 0.00 sys + 0.29 cusr 0.01 csys = 0.34 CPU) Result: PASS No noise for me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 13:49:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 11:49:14 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 --- Comment #4 from Indranil Das Gupta --- (In reply to Indranil Das Gupta from comment #3) > I have problems applying this patch with git bz CORRECTION: s/applying/attaching Patch applies and works correctly as per test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 13:56:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 11:56:38 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 --- Comment #5 from Indranil Das Gupta --- Created attachment 39236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39236&action=edit Signed off patch for bug 12054 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 13:59:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 11:59:12 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 14:02:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 12:02:46 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 14:03:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 12:03:50 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 --- Comment #6 from Indranil Das Gupta --- Created attachment 39237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39237&action=edit Bug 12054: Inactive vendors should be inactive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 14:04:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 12:04:12 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 14:05:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 12:05:19 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39237|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 14:07:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 12:07:53 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 --- Comment #7 from Indranil Das Gupta --- Created attachment 39238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39238&action=edit Bug 12054: Inactive vendors should be inactive This patch make inactive vendors really inactive. That means an inactive vendor would not be able to receive / add a basket / add an order. Revised test plan ================= 1/ In the acquisition module create 2 vendors: 1 active and 1 inactive. 2/ On the acqui/booksellers.pl, acqui/uncertainprice.pl, admin/aqcontract.pl and acqui/supplier.pl (pages which include the acq toolbar), you should be able to, for both the 'active' as well as the inactive vendor : (a) add new basket (b) add order items to the basket (c) receive shipment and enter invoice details and files Remark: This is *wrong*. You should be able to do so only for active vendor. 3/ Apply the patch 4/ Go to the links in step #2 above and select the inactive vendor you should no longer be able to: (a) add new basket (b) add order items to the basket (c) receive shipment and enter invoice details and files Remark: This is the *correct* behaviour 5/ No change should be noted for vendor marked "active", and should be able to undertake operations 4 (a), 4 (b) and 4 (c). Remark: This is the *correct* behaviour. 6/ run koha qa tests tool Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Remarks: Testing result match expected test plan output. The QA tests pass with "OK" for the commit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 15:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 13:31:05 +0000 Subject: [Koha-bugs] [Bug 11790] C4::Charset should not depend on C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11790 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 15:31:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 13:31:08 +0000 Subject: [Koha-bugs] [Bug 11790] C4::Charset should not depend on C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11790 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38494|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 39239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39239&action=edit [SIGNED-OFF] Bug 11790: Remove dependency C4::Context from C4::Charset C4::Context is only used to retrieve a syspref value. This patch moves the use of C4::Context to a require. Test plan: Try to reach the SetMarcUnicodeFlag subroutine (batchmod, add/update a biblio, etc.) Signed-off-by: Bernardo Gonzalez Kriegel Tested on French UNIMARC install No errors adding/editing biblios No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 17:13:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 15:13:16 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xarragon at gmail.com --- Comment #5 from Martin Persson --- I have tried the patch, it applied cleanly to current master. I have tested the subscription aquisition bug and can confirm both the bug and that the patch fixes that particular issue. I have not yet tested the 'Delete Item' bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 19:32:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 17:32:42 +0000 Subject: [Koha-bugs] [Bug 13916] NORMARC can have analytics with leader 07 = a, b or p In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13916 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |In Discussion --- Comment #3 from Bernardo Gonzalez Kriegel --- Same as Mirko, some 773 subfields does not save Only this 773 ## - Vertsdokument (R) 7 Type hovedordningsord i delfelt $a 7 a Hovedordningsord for posten det lenkes til, hvis dette er et personnavn, korporasjonsnavn eller en standardtittel a b Utgave b d Sted, forlag og dato (?r) for utgivelse d e Spr?kkode e f Landekode f g Relasjonsopplysninger (R) g h Materialbetegnelse h NORMARC setup Don't know... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 20:09:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 18:09:45 +0000 Subject: [Koha-bugs] [Bug 14025] Fix 865u-links in the OPAC for NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 20:09:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 18:09:49 +0000 Subject: [Koha-bugs] [Bug 14025] Fix 865u-links in the OPAC for NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38677|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 39240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39240&action=edit [SIGNED-OFF] Bug 14025 - Fix 865u-links in the OPAC for NORMARC The display of links found in 856$u for NORMARC has not been keeping up with the one for MARC21, and several sysprefs have not been implemented. This patch tries to fix that. Affected sysprefs: - OPACURLOpenInNewWindow - URLLinkText - OPACDisplay856uAsImage - OPACTrackClicks To test: - Make sure you have a record with a URL in 856$u and marcflavor = NORMARC. (It does not have to be a full NORMARC setup or a NORMARC record, just make sure you are viewing the record through the NORMARC XSLT files.) - View the record both in a result list and in detail view - Check that the 4 involved sysprefs affect the display in the expected ways Signed-off-by: Bernardo Gonzalez Kriegel Tested on NORMARC setup and XSLTs Works as described, each syspref works No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 20:33:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 18:33:22 +0000 Subject: [Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 20:33:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 18:33:25 +0000 Subject: [Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37212|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 39241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39241&action=edit [SIGNED-OFF] Bug 13904: unimarc_field_4XX plugin doesn't display volume info, neither link to biblio When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Signed-off-by: Bernardo Gonzalez Kriegel I can see 200$h and 200$i on search results, but not on result list from 4XX plugin, but they are copied into 46X. The title is now a link, so I think could be my example record. At last one of the problems is fixed :) No koha-qa errors Tested on UNIMARC setup, french files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:45:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:45:15 +0000 Subject: [Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 39242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39242&action=edit [SIGNED-OFF] Bug 13948: Add ability to dump template toolkit variables to html comment It would be incredibly helpful if we could easily enable Koha to dump all Template Toolkit variables to a comment for debugging purposes. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preferences DumpTemplateVarsIntranet and DumpTemplateVarsOpac 4) Load a page in the staff intranet, view the html source 5) Note the template toolkit variables are embedded in an html comment 6) Load a page in the opac, view the html source 7) Note the template toolkit variable are embedded in an html comment NOTE: I had to cpan2deb Template::Plugin::Stash to test. This is not optimal. Additionally: http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html does not contain Stash. I suspect this was how it was introduced initially by TT. Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:45:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:45:24 +0000 Subject: [Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 39243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39243&action=edit [SIGNED-OFF] Bug 13948 [QA Followup] - Make dependency optional Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:45:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:45:32 +0000 Subject: [Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 39244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39244&action=edit [SIGNED-OFF] Bug 13948: Prevent explosion when Template::Plugin::Stash not installed TEST PLAN --------- 1) Install first two patches 2) do not install, or uninstall Template::Plugin::Stash 3) Upgrade to make sure system preference is added. 4) Set the system preference to turn it on for Staff and OPAC 5) Refresh staff -- kaboom 6) Load OPAC -- kaboom 7) Apply this patch 8) Reload staff and OPAC -- nice HTML comment about what is wrong. 9) run koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel Neat, runs well. Tested with/without sysprefs and Template::Plugin::Stash No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:46:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:46:30 +0000 Subject: [Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Attachment #39242|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:46:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:46:43 +0000 Subject: [Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39243|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:46:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:46:58 +0000 Subject: [Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39244|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:47:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:47:14 +0000 Subject: [Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848 --- Comment #4 from Bernardo Gonzalez Kriegel --- Sorry, wrong bug :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:47:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:47:51 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39096|0 |1 is obsolete| | --- Comment #15 from Bernardo Gonzalez Kriegel --- Created attachment 39245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39245&action=edit [SIGNED-OFF] Bug 13948: Add ability to dump template toolkit variables to html comment It would be incredibly helpful if we could easily enable Koha to dump all Template Toolkit variables to a comment for debugging purposes. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preferences DumpTemplateVarsIntranet and DumpTemplateVarsOpac 4) Load a page in the staff intranet, view the html source 5) Note the template toolkit variables are embedded in an html comment 6) Load a page in the opac, view the html source 7) Note the template toolkit variable are embedded in an html comment NOTE: I had to cpan2deb Template::Plugin::Stash to test. This is not optimal. Additionally: http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html does not contain Stash. I suspect this was how it was introduced initially by TT. Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel http://bugs.koha-community.org/show_bug.cgi?id=13848 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:47:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:47:58 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39097|0 |1 is obsolete| | --- Comment #16 from Bernardo Gonzalez Kriegel --- Created attachment 39246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39246&action=edit [SIGNED-OFF] Bug 13948 [QA Followup] - Make dependency optional Signed-off-by: Bernardo Gonzalez Kriegel http://bugs.koha-community.org/show_bug.cgi?id=13848 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:48:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:48:05 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39205|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel --- Created attachment 39247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39247&action=edit [SIGNED-OFF] Bug 13948: Prevent explosion when Template::Plugin::Stash not installed TEST PLAN --------- 1) Install first two patches 2) do not install, or uninstall Template::Plugin::Stash 3) Upgrade to make sure system preference is added. 4) Set the system preference to turn it on for Staff and OPAC 5) Refresh staff -- kaboom 6) Load OPAC -- kaboom 7) Apply this patch 8) Reload staff and OPAC -- nice HTML comment about what is wrong. 9) run koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel Neat, runs well. Tested with/without sysprefs and Template::Plugin::Stash No koha-qa errors http://bugs.koha-community.org/show_bug.cgi?id=13848 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:48:23 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 21:58:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 19:58:21 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Bernardo Gonzalez Kriegel --- (In reply to Bernardo Gonzalez Kriegel from comment #4) > (In reply to M. Tompsett from comment #3) > ... > > Greetings, I do. I should have also mentioned. This will require Apache 2.4. > > Ah! I have 2.2, will try in another machine Tried, Server version: Apache/2.4.7 (Ubuntu) No warns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 16 23:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 21:02:12 +0000 Subject: [Koha-bugs] [Bug 14212] New: Add 'oldip' and 'newip' to different_ip message in auth.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14212 Bug ID: 14212 Summary: Add 'oldip' and 'newip' to different_ip message in auth.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When IP addresses are changing frequently, users will be logged out and the login screen will have the warning message "Error: IP address has changed. Please log in again" This is confusing to users, and it is often unclear to the users that this is a network issue, not a problem with with Koha. Furthermore, the library's IT staff may claim that the IP addresses have not changed, which puts the user in a very difficult position. C4/Auth.pm defines the variables 'oldip' and 'newip' in addition to 'different_ip'. I would suggest changing [% IF ( different_ip ) %]
    Error: IP address has changed, please log in again
    [% END %] to [% IF ( different_ip ) %]
    Error: IP address has changed from '[% oldip %]' to '[% newip %]', please log in again
    [% END %] This message gives users (and anyone supporting them) the evidence to back up the claim that the IP address has changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 00:00:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 22:00:01 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #6 from M. Tompsett --- mtompset at debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 607b224 Bug 13591: Pass OPACBaseURL to rss creation process mtompset at debian:~/kohaclone$ prove t/db_dependent/Auth_with_cas.t t/db_dependent/Auth_with_cas.t .. 1/4 CGI::param called in list context from package C4::Auth_with_cas line 217, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package C4::Auth_with_cas line 217, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. t/db_dependent/Auth_with_cas.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.16 cusr 0.01 csys = 0.19 CPU) Result: PASS mtompset at debian:~/kohaclone$ git bz apply 14121 Bug 14121 - Silence warnings t/db_dependent/Auth_with_cas.t 38763 - Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t mtompset at debian:~/kohaclone$ prove t/db_dependent/Auth_with_cas.t t/db_dependent/Auth_with_cas.t .. ok All tests successful. Files=1, Tests=4, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.16 cusr 0.00 csys = 0.17 CPU) Result: PASS mtompset at debian:~/dhmake$ cpan2deb CGI == dh-make-perl 0.84 == CGI is a standard module. Will not build without --core-ok. mtompset at debian:~/dhmake$ perl -v This is perl 5, version 20, subversion 2 (v5.20.2) built for x86_64-linux-gnu-thread-multi (with 40 registered patches, see perl -V for more detail) Copyright 1987-2015, Larry Wall Perl may be copied only under the terms of either the Artistic License or the GNU General Public License, which may be found in the Perl 5 source kit. Complete documentation for Perl, including FAQ lists, should be found on this system using "man perl" or "perldoc perl". If you have access to the Internet, point your browser at http://www.perl.org/, the Perl Home Page. I'm testing Debian Jessie with perl 5.20.2 Both of you were testing Ubuntu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 00:07:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 22:07:26 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #7 from M. Tompsett --- I attempted to test with Ubuntu 14.04 LTS which has Perl 5.18.2, and I did not get noise either. This is clearly a newer perl (hence newer CGI) issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 00:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 22:17:43 +0000 Subject: [Koha-bugs] [Bug 7806] Illegal dates are used to signal non existing dates. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #4 from Marc Balmer --- Using a valid date like 1.1.1970 to denote an invalid date is so obviously a bad idea. I suggest to go the NULL route. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 00:54:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 May 2015 22:54:56 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from M. Tompsett --- Test with a newer version of Perl. This was Perl 5.20.2 under Debian. CGI is a core module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 05:44:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 03:44:12 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #45 from Chris Cormack --- Doesn't apply and I think is not needed on 3.18.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 05:47:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 03:47:58 +0000 Subject: [Koha-bugs] [Bug 13992] Software error in reports if field or table does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13992 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Doesn't apply on 3.18.x please rebase if you think it is needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 05:49:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 03:49:39 +0000 Subject: [Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 05:52:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 03:52:19 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 05:55:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 03:55:34 +0000 Subject: [Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 06:19:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 04:19:48 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #21 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 06:24:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 04:24:41 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #20 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 06:27:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 04:27:00 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 06:33:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 04:33:18 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 06:38:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 04:38:48 +0000 Subject: [Koha-bugs] [Bug 6059] Problem with changing quantity on uncertain prices list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 17 07:34:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 05:34:43 +0000 Subject: [Koha-bugs] [Bug 10388] acq edited items showing 'null's In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 07:36:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 05:36:48 +0000 Subject: [Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 07:40:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 05:40:05 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #31 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 07:45:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 05:45:58 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 07:48:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 05:48:09 +0000 Subject: [Koha-bugs] [Bug 14127] Typo in message preference form - "mesage" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 07:50:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 05:50:50 +0000 Subject: [Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 07:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 05:53:49 +0000 Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 07:57:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 05:57:58 +0000 Subject: [Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 08:32:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 06:32:41 +0000 Subject: [Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 08:33:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 06:33:50 +0000 Subject: [Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 08:35:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 06:35:39 +0000 Subject: [Koha-bugs] [Bug 14129] templates.readme is outdated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 08:36:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 06:36:43 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 08:38:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 06:38:39 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 08:45:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 06:45:12 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 08:46:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 06:46:26 +0000 Subject: [Koha-bugs] [Bug 14018] Ordering from suggestion shows 'copy. year:2014' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 08:48:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 06:48:09 +0000 Subject: [Koha-bugs] [Bug 14065] Typo in opac self registration form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 08:52:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 06:52:05 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 08:54:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 06:54:17 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #17 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 08:57:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 06:57:03 +0000 Subject: [Koha-bugs] [Bug 11464] Saving preferences - Nothing to Save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 13:15:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 11:15:10 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Hi Indranil, make sure you have checked out the latest version of the fishsoup branch from the git-bz repository on kc.org - that should make the problem disappear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 15:02:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 13:02:36 +0000 Subject: [Koha-bugs] [Bug 10938] item columns in different order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10938 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38268|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 39248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39248&action=edit [SIGNED-OFF] Bug 10938: Item columns displayed in random order On the MARC detail page, the columns are displayed in a random order. This means that you can open 2 different records and see the columns displayed in a different order. Test plan: Go on different MARC detail view and confirm that 1/ all fields are present and 2/ they always are displayed in the same order Signed-off-by: Bernardo Gonzalez Kriegel 1/ & 2/ correct No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 15:03:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 13:03:29 +0000 Subject: [Koha-bugs] [Bug 10938] item columns in different order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10938 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 15:03:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 13:03:31 +0000 Subject: [Koha-bugs] [Bug 10938] item columns in different order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10938 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38269|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 39249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39249&action=edit [SIGNED-OFF] Bug 10938: Item columns displayed in random order - OPAC Same as before for the OPAC. Signed-off-by: Bernardo Gonzalez Kriegel Good result, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 15:50:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 13:50:59 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |In Discussion --- Comment #4 from Bernardo Gonzalez Kriegel --- Perhaps the key is needed, also a test plan. And rewrite database update as atomicupdate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 17 16:08:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 14:08:29 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16242|0 |1 is obsolete| | --- Comment #33 from M. Tompsett --- Created attachment 39250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39250&action=edit Bug 7679: circulation statistics wizard improvements - Add patron branch to the list of possible rows, columns, and filters - Add extended patron attributes to the list of possible rows, columns, and filters - Allow to group period by hour - Allow to translate filter names Signed-off-by: Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 16:08:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 14:08:44 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16243|0 |1 is obsolete| | --- Comment #34 from M. Tompsett --- Created attachment 39251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39251&action=edit Bug 7679: Followup: circulation statistics wizard improvements Signed-off-by: Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 16:08:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 14:08:50 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17798|0 |1 is obsolete| | --- Comment #35 from M. Tompsett --- Created attachment 39252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39252&action=edit Bug 7679: Fix criteria display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 16:08:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 14:08:55 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22745|0 |1 is obsolete| | --- Comment #36 from M. Tompsett --- Created attachment 39253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39253&action=edit Bug 7679: Group different case values in the same row/column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 16:09:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 14:09:02 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25053|0 |1 is obsolete| | --- Comment #37 from M. Tompsett --- Created attachment 39254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39254&action=edit Bug 7679: Fix several bugs in circulation statistics wizard - Display values in NULL columns/rows - Display columns/rows that contain values only in NULL rows/columns - "To" filter in period row should be inclusive (YYYY-MM-DD should be YYYY-MM-DD 23:59:59) - Make it possible to use only the "To" filter in period row (actually it results in DBI error (2 bind variables instead of 1)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 16:09:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 14:09:08 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25443|0 |1 is obsolete| | --- Comment #38 from M. Tompsett --- Created attachment 39255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39255&action=edit Bug 7679: Fix two SQL queries when using patron attributes and remove some Perl warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 16:09:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 14:09:14 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26531|0 |1 is obsolete| | --- Comment #39 from M. Tompsett --- Created attachment 39256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39256&action=edit Bug 7679: Various fixes for circulation statistics wizard - use SQL TRIM functions to avoid having '' and ' ' considered as different values - use Text::Unaccent to remove accents from columns or rows values when accessing %table. This is required as MySQL consider as equals two strings that differ only by their accents when using GROUP BY clause. - Exclude '' values from the list of columns or rows. Otherwise we could have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same values in their cells. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 16:09:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 14:09:21 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31311|0 |1 is obsolete| | --- Comment #40 from M. Tompsett --- Created attachment 39257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39257&action=edit Bug 7679: Display all table headers (case and accent sensitive) It appears that we can't assume that a lowercase word is equivalent to the same word in uppercase (or a mix of lowercase and uppercase letters). And this is also true about accented words. So display all values even if they differ only by case or by their accents. This means that: - "foobar" and "Foobar" will be in two separate rows/columns - "Etudiant" and "?tudiant" (french) will be in two separate rows/columns too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 16:16:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 14:16:00 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #41 from M. Tompsett --- Comment on attachment 39251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39251 Bug 7679: Followup: circulation statistics wizard improvements Review of attachment 39251: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7679&attachment=39251) ----------------------------------------------------------------- ::: reports/issues_stats.pl @@ +251,4 @@ > ( $line =~ /datetime/ ) ? @$filters[0] > : ( $line =~ /category/ ) ? @$filters[2] > : ( $line =~ /itemtype/ ) ? @$filters[3] > + : ( $line =~ /^branch/ ) ? @$filters[4] issuingbranch branchcode Unchanged, both match. This change only matches the last one. Katrin raises a valid point: Is this really a desired change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 16:27:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 14:27:09 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |mtompset at hotmail.com --- Comment #42 from M. Tompsett --- This should now cleanly apply. It is identical change-wise as far as I can tell. Setting this to 'Needs Signoff' since Julian posted patchs as a result of the 'Failed QA' starting in comment #28. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 16:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 14:42:40 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #7 from M. Tompsett --- Comment on attachment 23144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23144 Add support for custom Z39.50 attributes for Z39.50 servers. Review of attachment 23144: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11297&attachment=23144) ----------------------------------------------------------------- Also, missing kohastructure.sql modifications. ::: installer/data/mysql/updatedatabase.pl @@ +7331,5 @@ > } > > +$DBversion = "3.13.00.XXX"; > +if ( CheckVersion($DBversion) ) { > + $dbh->do("ALTER TABLE z3950servers ADD COLUMN attributes VARCHAR(255);"); please include an explicit AFTER, so that things run out of order will generate some layout. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 20:14:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 18:14:13 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 21:23:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 19:23:11 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se --- Comment #1 from Viktor Sarge --- We would have good use of drop downs with full call number, shelving location and collection code. (regular text fields might of course be an alternative when a drop down might be overly long) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 21:44:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 19:44:25 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14190 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 21:44:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 19:44:25 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14189 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 21:47:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 19:47:37 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eskaaren at yahoo.no --- Comment #1 from Eivin Giske Skaaren --- Changes here may cause a merge conflict with the signed off 14189 since some of the same files must be updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 22:00:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 20:00:55 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 --- Comment #2 from Viktor Sarge --- Owen - we'll gladly let you write this patch. But give us a shout if not since Eivin is ready to write it otherwise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 22:11:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 20:11:11 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 --- Comment #3 from Viktor Sarge --- Got an update from Cait that template bugs are auto assigned to Owen so we're going for this one ourselves :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 22:11:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 20:11:50 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |eskaaren at yahoo.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 22:16:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 20:16:26 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 22:17:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 20:17:06 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 22:39:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 20:39:22 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eskaaren at yahoo.no --- Comment #23 from Eivin Giske Skaaren --- I just tried applying this patch to a branch up to date with the current master and there are merge conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 23:04:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 21:04:53 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 23:40:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 21:40:15 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 39258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39258&action=edit [SIGNED-OFF] Bug 10355: paramater 'object' lost on the road Test plan: 1) Go to any detail page in staff 2) Click on the modification log tab 3) Verify, that the object is prefilled with the records biblionumber and you can also see it as parameter in the url 4) Click a second time on modification log to reset your search Before this patch, the object parameter was empty. It now contains the value of the biblionumber. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 23:41:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 21:41:07 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39258|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel --- Comment on attachment 39258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39258 [SIGNED-OFF] Bug 10355: paramater 'object' lost on the road Sorry, wrong bug number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 23:41:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 21:41:42 +0000 Subject: [Koha-bugs] [Bug 10355] Second click on modification log misses object parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 23:41:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 21:41:45 +0000 Subject: [Koha-bugs] [Bug 10355] Second click on modification log misses object parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37964|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 39259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39259&action=edit [SIGNED-OFF] Bug 10355: paramater 'object' lost on the road Test plan: 1) Go to any detail page in staff 2) Click on the modification log tab 3) Verify, that the object is prefilled with the records biblionumber and you can also see it as parameter in the url 4) Click a second time on modification log to reset your search Before this patch, the object parameter was empty. It now contains the value of the biblionumber. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors http://bugs.koha-community.org/show_bug.cgi?id=10335 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 23:42:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 21:42:49 +0000 Subject: [Koha-bugs] [Bug 4281] reports dictionary limited to only 1 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4281 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 17 23:46:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 21:46:50 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 17 23:56:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 21:56:05 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:03:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:03:14 +0000 Subject: [Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:04:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:04:54 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:24:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:24:41 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31589|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 39260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39260&action=edit [SIGNED-OFF] Bug 12919 : Module to facilitate sending new (or updated or deleted) cataloguing records somewhere Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:24:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:24:49 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31590|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 39261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39261&action=edit [SIGNED-OFF] Bug 12919: Cronjob to create and email new or updated MARC records To test 1/ Add some new records to your Koha 2/ if you are using koha from packages run sudo koha-shell otherwise export PERL5LIB=/path/to/koha export KOHA_CONF=/path/to/koha-conf.xml 3/ run perl misc/cronjobs/newly_added_records --days 1 --address your at email.goes.here --format marc 4/ Check your email and see if you got some marc records Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:24:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:24:56 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31591|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 39262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39262&action=edit [SIGNED-OFF] Bug 12919: Script to grab and email deleted records To test 1/ Delete some records from your Koha (with isbns) OR mark all items attached to a biblio as lost 2/ if you are using koha from packages run sudo koha-shell otherwise export PERL5LIB=/path/to/koha export KOHA_CONF=/path/to/koha-conf.xml 3/ run perl misc/cronjobs/newly_added_records --days 1 --address your at email.goes.here --lost --format isbn 4/ Check your email and see if you got a list of isbn of deleted records Signed-off-by: Bernardo Gonzalez Kriegel Work as described, both patches A simple error on license, fixed in followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:27:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:27:50 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 39263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39263&action=edit Bug 12929: (followup) fix license I fix it myself. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:28:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:28:07 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:44:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:44:31 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:53:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:53:03 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27970|0 |1 is obsolete| | --- Comment #29 from Bernardo Gonzalez Kriegel --- Created attachment 39264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39264&action=edit [SIGNED_OFF] Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Indentation and whitespace fixes Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:53:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:53:17 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27971|0 |1 is obsolete| | --- Comment #30 from Bernardo Gonzalez Kriegel --- Created attachment 39265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39265&action=edit [SIGNED_OFF] Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes - Returns the list of modified biblio records - Retrieve MARC records from DB if not given in parameters - Delete source authority if source and destination records are different Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:53:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:53:24 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27972|0 |1 is obsolete| | --- Comment #31 from Bernardo Gonzalez Kriegel --- Created attachment 39266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39266&action=edit [SIGNED_OFF] Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:53:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:53:31 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27973|0 |1 is obsolete| | --- Comment #32 from Bernardo Gonzalez Kriegel --- Created attachment 39267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39267&action=edit [SIGNED_OFF] Bug 11700: Fix unit tests when index mode is 'dom' Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:53:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:53:38 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28177|0 |1 is obsolete| | --- Comment #33 from Bernardo Gonzalez Kriegel --- Created attachment 39268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39268&action=edit [SIGNED_OFF] Bug 11700: Avoid to try to delete the authority twice Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:53:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:53:45 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35107|0 |1 is obsolete| | --- Comment #34 from Bernardo Gonzalez Kriegel --- Created attachment 39269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39269&action=edit [SIGNED_OFF] Bug 11700: Fix unit test when index mode is not defined Use the same default value as everywhere (dom) Signed-off-by: Bernardo Gonzalez Kriegel Tested mergin auths, no problems Test runs Ok No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:53:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:53:56 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:56:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:56:12 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 00:59:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 22:59:24 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 01:01:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 23:01:39 +0000 Subject: [Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 01:16:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 23:16:57 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #21 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 01:20:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 23:20:55 +0000 Subject: [Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 01:26:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 23:26:59 +0000 Subject: [Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12911 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 01:32:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 23:32:21 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #20 from Chris Cormack --- Doesn't apply cleanly on 3.18.x please rebase if it is needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 01:35:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 23:35:29 +0000 Subject: [Koha-bugs] [Bug 13591] Rss sample templates have hardcoded urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 01:40:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 May 2015 23:40:53 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Bernardo Gonzalez Kriegel --- Trying to test Some conflicts, dependencies installed. When runnin I found: misc/bin/koha-index --verbose Exporting records to update Can't call method "config" on an undefined value at /home/bgkriegel/kohaclone/C4/Context.pm line 640. Am I doing something wrong? Some strange POD errors FAIL Koha/Indexer/Daemon.pm OK critic OK forbidden patterns FAIL pod *** ERROR: Unknown command 'attr' in file Koha/Indexer/Daemon.pm OK valid FAIL Koha/Indexer/Indexing.pm OK critic OK forbidden patterns FAIL pod *** ERROR: Unknown command 'method' in file Koha/Indexer/Indexing.pm *** ERROR: Unknown command 'HEAD1' in file Koha/Indexer/Indexing.pm OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 02:07:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 00:07:52 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #2 from Indranil Das Gupta --- Created attachment 39270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39270&action=edit 'print'-only notice deletion confirmation dialog Shows the s not being populated. Clicking the 'Yes, delete' button will submit the page without any apparent error. But the record will not be deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 02:29:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 00:29:38 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 02:29:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 00:29:40 +0000 Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21630|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 39271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39271&action=edit [SIGNED-OFF] Bug 10824 - OAI-PMH repository/server not handling time in 'until' and 'from' This patch removes the DATE() function from a query on timestamp, and adds a sub that strips the UTC designators "T" and "Z" from incoming "from" and "until" arguments in OAI-PMH requests so that they're more compliant with MySQL (and probably other databases as well). This means that the date and time for the 'from' and 'until' arguments will be matched correctly in the database. This patch also adds 'T00:00:00Z' to 'from' arguments and 'T23:59:59Z' to until arguments, when only dates are provided via the OAI parameters. The zero time isn't necessary, since MySQL treats '2013-09-30' as '2013-09-30 00:00:00' by default. However, the near midnight time is needed for 'until'. Otherwise, you'll never be able to retrieve a record with a date/time matching the 'until' argument. In summary, this patch adds handling for times as well as dates, which is necessary so that Koha is closer to meeting the actual OAI-PMH spec. TEST PLAN: 0) Note down a selection of timestamps from your biblio table 1) Enable your OAI-PMH server through the global system preferences Web services tab. 2) Craft and submit a similar request to the following in your browser: KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc& from=2013-09-02T13:44:33Z&until=2013-09-05T13:44:33Z Change the exact dates to accord with your timestamps, but keep the YYYY-MM-DDTHH:MM:SSZ format. 3) Note the unexpected behaviour. A "from" argument with the timestamp 2013-09-02T13:44:33Z will show records from 2013-09-03 but not records from 2013-09-02 even though the timestamp in the database will say "2013-09-02 13:44:33". Also note that records with a timestamp later than 13:44:33 will show up for the day 2013-09-05, even though they shouldn't. 4) APPLY THE PATCH 5) Resubmit the links you tried above 6) Note that the applicable records now appear (or do not appear) in accordance with the precise date/time ranges! -- Developer Note: We could've not stripped the UTC designators and used DATE() around the parameters in the SQL queries, but that would have lost the whole purpose of using times in the "from" arguments, since they would've been generalized to just the dates. I think this is probably the best solution. Admittedly, creating "form_arg" and "until_arg" hashrefs in the ResumptionToken object might not be ideal, but I preferred that to copying the _strip_UTC_designator subroutine into two other objects. Perhaps this sub could go somewhere else and be imported into those other two objects but this seemed to be the most sensible decision. I'm open to other opinions though. Signed-off-by: Bernardo Gonzalez Kriegel Works, find results with correct timestamp No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 03:03:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 01:03:03 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #3 from Indranil Das Gupta --- Created attachment 39272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39272&action=edit Bug 14206 - Fixes deletion issue for non-email notices message_transport_type was not being passed to routine in letter.pl routines, so notices that did not include an email template couldn't be deleted from Tools -> Notices & Slips page. This patch fixes that issue. Test plan ========= 1/ Go to Tools -> Notices & Slips. Add a new notice only for print, leave 'Library' and 'Koha module' options as default selections. Enter 'KOHA_14206' and 'Koha Test 14206' against Code and Name respectively, and 'Test' and 'Test Message' for subject and body. Leave the Email, Phone and SMS tabs blank. Save the notice. 2/ On the notices listing page the new notice will be listed. Try to delete it. It will load the 'Delete notice' dialog form, but the table will not show any data under s - 'Library', 'Module', 'Code' or 'Name'. 3/ Click the "Yes, delete" button. The page will be submitted and the Notices listing reloaded. The print-only KOHA_14206 notice should continue to exist. This is *wrong*. 4/ Apply the patch 5/ Reload the listings page and click on the 'Delete' link for Notice KOHA_14206. This time, it should show the data under 'Module', 'Code' or 'Name' at least. 6/ Click on 'Yes, delete'. The page should submit and the listing page reload. This time KOHA_14206 will be gone. 7/ Run sql statement SELECT * FROM `letter` WHERE `code` = 'KOHA_14206' to check actual deletion from the database. No record should be returned. 8/ Re-add notice KOHA_14206, but this time also add fill in print, email, phone and sms delivery options. 9/ Delete the newly re-added notice KOHA_14206. It should no longer be shown in the listing. Confirm deletion by running step #7. No record should be returned. 10/ run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 03:04:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 01:04:35 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 04:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 02:57:42 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 06:15:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 04:15:17 +0000 Subject: [Koha-bugs] [Bug 14192] Noisy warns in Koha/XSLT_Handler.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14192 --- Comment #2 from Aleisha Amohia --- (In reply to Marcel de Rooy from comment #1) > (In reply to Aleisha Amohia from comment #0) > > Module isn't locating XSLT file. > > Please provide more information. Or copy the error log line here? Sorry, I was working on a patch for this and went home before I could crack it so filed the bug so I wouldn't forget what I was working on. Feel free to have a go! Error log line says this : [Mon May 18 01:58:38 2015] [error] [client 10.0.2.2] [Mon May 18 01:58:38 2015] opac-detail.pl: XSLT file not found. at /home/vagrant/kohaclone/Koha/XSLT_Handler.pm line 366., referer: http://localhost:8080/cgi-bin/koha/opac-search.pl?q=a&branch_group_limit= -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 07:07:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 05:07:11 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 07:07:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 05:07:14 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38872|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 39273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39273&action=edit Bug 14151 - SIP2 Checkouts file in Koha 3.18 When Bug 12820 was added to Koha 3.18, the namespace was not altered. This causes checkouts to fail via SIP2. Test Plan: 1) Attempt to check out an item via SIP2 2) Note you never get back a response 3) Apply this patch 4) Repeat step 1 5) Note it now works! Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 08:32:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 06:32:59 +0000 Subject: [Koha-bugs] [Bug 14192] Noisy warns in Koha/XSLT_Handler.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14192 --- Comment #3 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #2) > Sorry, I was working on a patch for this and went home before I could crack > it so filed the bug so I wouldn't forget what I was working on. Feel free to > have a go! Error log line says this : > [Mon May 18 01:58:38 2015] [error] [client 10.0.2.2] [Mon May 18 01:58:38 > 2015] opac-detail.pl: XSLT file not found. at > /home/vagrant/kohaclone/Koha/XSLT_Handler.pm line 366., referer: > http://localhost:8080/cgi-bin/koha/opac-search.pl?q=a&branch_group_limit= I cannot reproduce this error. Note that it appears to be a warning about a wrong path to your opac detail xslt. Please check your xslt preferences and paths. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 08:37:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 06:37:31 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 08:37:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 06:37:34 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22081|0 |1 is obsolete| | --- Comment #8 from Fr?d?ric Demians --- Created attachment 39274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39274&action=edit Port Koha::Contrib::Tamil indexer into Koha code base Add two scripts for indexing: koha-index and koha-index-daemon. Documentation: perldoc koha-index perldoc koha-index-daemon New dependencies: MooseX::Getopt MooseX::RW AnyEvent::Processor Available as a Debian package: libmoosex-getopt-perl Test plan: - Apply the patch - Install dependencies, if necessary - Reindex a whole biblio catalog: koha-index --verbose - Reindex a whole authorities catalog: koha-index --source authority --verbose - Modify 1 biblio record, and index it: koha-index --select queue - Modifiy 1 authority record, and index it: koha-index --select queue --source authority - Run indexing daemon, with a 15s timeout: koha-index-daemon --timeout 15 - Modify a biblio record: wait 15s, and see - Modify an authority record: wait 15s, and see -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 08:39:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 06:39:11 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 --- Comment #9 from Fr?d?ric Demians --- (In reply to Bernardo Gonzalez Kriegel from comment #7) > Trying to test Thanks! > Some conflicts, dependencies installed. Fixed on the new attached patch. > When runnin I found: > misc/bin/koha-index --verbose > Exporting records to update > Can't call method "config" on an undefined value at > /home/bgkriegel/kohaclone/C4/Context.pm line 640. Fixed. > Am I doing something wrong? > > Some strange POD errors Fixed. I stay available for fixing any issue you may encounter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 08:57:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 06:57:10 +0000 Subject: [Koha-bugs] [Bug 14196] Encoding error adding new biblio in custom framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14196 --- Comment #3 from pablo.jimenez at ext.satec.es --- (In reply to Katrin Fischer from comment #2) > Hi Pablo, > can you check if your framework includes the controlfield for setting the > encoding for the MARC record? - I think it's LDR, pos. 9 Make sure that it's > also linked to the standard plugin for the leader. Hi Katrin. The field exists, in 000 tag, and its asociated with marc21_leader.pl. An example of leader tax in marcxml in the database is: 00147 a2200085 4500 The 'a' in the pos. 09 is what you asked for? Also, tags for title as 100a or 245a show Pr?ez --> It should be P?rez Jimn?ez Muo?z --> It should be Jim?nez Mu?oz Thanks for your time. Pablo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 09:22:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 07:22:19 +0000 Subject: [Koha-bugs] [Bug 13916] NORMARC can have analytics with leader 07 = a, b or p In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13916 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #4 from Magnus Enger --- I'll have to investigate this properly when I can find the time. Thanks for looking! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 09:31:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 07:31:21 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #50 from Magnus Enger --- (In reply to Katrin Fischer from comment #49) > Magnuse, reading your last comment - should this be failed qa for a > regression on making 'exceptions'? I think this needs some more clarification, yes. Setting it to FQA to see if anything happens. ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 09:47:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 07:47:29 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 10:31:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 08:31:04 +0000 Subject: [Koha-bugs] [Bug 14213] New: Field cloning problem Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14213 Bug ID: 14213 Summary: Field cloning problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 10:31:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 08:31:11 +0000 Subject: [Koha-bugs] [Bug 14213] Field cloning problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14213 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 10:32:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 08:32:25 +0000 Subject: [Koha-bugs] [Bug 7806] Illegal dates are used to signal non existing dates. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 10:44:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 08:44:46 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #8 from Jonathan Druart --- (In reply to Indranil Das Gupta from comment #7) > I've a newbie question. Why are you putting in this code in the > updatedatabase.pl, instead of in the atomicupdates? Or did I get it wrong? We cannot add more than 1 query in 1 atomic update file. So I should have created ~7 files, which I considered as more work than rebase 1 patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 10:48:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 08:48:58 +0000 Subject: [Koha-bugs] [Bug 14136] Remove superfluous template parameters from members/member-flags.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #4 from Marc V?ron --- Sorry, I was not aware of circ-menu.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 10:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 08:49:17 +0000 Subject: [Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- CC|julian.fiol at biblibre.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 11:02:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 09:02:32 +0000 Subject: [Koha-bugs] [Bug 14213] Field cloning problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14213 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 11:02:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 09:02:34 +0000 Subject: [Koha-bugs] [Bug 14213] Field cloning problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14213 --- Comment #1 from Marcel de Rooy --- Created attachment 39275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39275&action=edit Bug 14213: Cataloging plugin in cloned field does not work A code change for report 10480 in cataloging.js does not work well in case you clone a field with a plugin on a subfield. The events (click, focus, etc.) do not work on the subfield of the clone. This patch corrects the situation by finding the right html element for adding event binding. NOTE: The test plan uses EXAMPLE.pl since many old plugins do not operate on the correct field value when cloning. This is corrected in bug 13437. Test plan: [1] Attach EXAMPLE.pl to field 007, 246h and 260c. In sql for 007: update marc_subfield_structure set value_builder='EXAMPLE.pl' where tagfield='007' and tagsubfield='@'; [2] Clone field 007. Verify that focus and click operate on both fields. Check also that the plugin works on the value corresponding with the button you clicked. [3] Clone field 246. Do the same checks on both subfields $h. [4] Clone subfield 260c. Do the same checks again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 11:02:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 09:02:57 +0000 Subject: [Koha-bugs] [Bug 14213] Cataloging plugin in cloned field does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14213 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Summary|Field cloning problem |Cataloging plugin in cloned | |field does not work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 11:22:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 09:22:18 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 --- Comment #18 from Jonathan Druart --- I am not sure it's a good idea to test dependencies on TT side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 11:25:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 09:25:25 +0000 Subject: [Koha-bugs] [Bug 7806] Illegal dates are used to signal non existing dates. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #5 from Jonathan Druart --- I really don't know where I have found this stupid idea :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 11:28:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 09:28:39 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 11:43:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 09:43:34 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 11:44:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 09:44:57 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #46 from Jonathan Druart --- (In reply to Chris Cormack from comment #45) > Doesn't apply and I think is not needed on 3.18.x No it's not, bug 11395 will be in 3.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 11:57:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 09:57:16 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38042|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 39276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39276&action=edit Bug 13049: Merge selfreg cron jobs into cleanup_database This patch moves the core code of two selfreg cron jobs into the Members module. The new routines are called from cleanup_database with two new parameters. The old cron jobs are now wrappers to cleanup_database. As a bonus, we can add a unit test now. In time, we can obsolete the selfreg cron jobs. For now, the code is in one place and behavior does not change. A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Test plan: Run the unit test t/db_dependent/Members.t. Test the two new parameters of cleanup_database.pl. Verify if delete_expired_opac_registrations.pl still works. Same for delete_unverified_opac_registrations.pl. Signed-off-by: Frederic Demians . Fixed minor merge confict on UT & cleanup_database.pl . UT ok . The two deprecated scripts still work as before, with a warning message. . cleanup_database.pl do the deletion job, calling new C4::Members function rather that doing it directly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 11:59:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 09:59:04 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #15 from Marcel de Rooy --- Rebased: cronlogaction is called in cleanup_database; so the action is logged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 12:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 10:30:54 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #4 from Jonathan Druart --- I disagree with this patch. I understand the problem, but this patch does not fix it in the right way. It does not make sense to add the mtt param to the "delete" link. Indeed, we will delete all mtt for a given letter. A better fix would be to change the getletter behavior to default on "email", but return the first letter if the email template has not been created. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 12:49:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 10:49:23 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Indranil Das Gupta --- (In reply to Jonathan Druart from comment #4) > I disagree with this patch. > I understand the problem, but this patch does not fix it in the right way. > It does not make sense to add the mtt param to the "delete" link. Indeed, we > will delete all mtt for a given letter. > > A better fix would be to change the getletter behavior to default on > "email", but return the first letter if the email template has not been > created. I agree with your comment, personally I wasn't happy doing it this way, but wasn't sure if it would be OK to mess with an 'in-use' Letters.pm So, you suggest that I should focus on: sub getletter { my ( $module, $code, $branchcode, $message_transport_type ) = @_; $message_transport_type ||= 'email'; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 12:54:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 10:54:58 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 --- Comment #19 from Kyle M Hall --- (In reply to Jonathan Druart from comment #18) > I am not sure it's a good idea to test dependencies on TT side. Can you explain why? It seems like a good solution here, especially considering that this feature would rarely if ever be used in production. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 13:02:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 11:02:21 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 13:02:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 11:02:24 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39274|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 39277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39277&action=edit [SIGNED-OFF] Bug 11081: Port Koha::Contrib::Tamil indexer into Koha code base Add two scripts for indexing: koha-index and koha-index-daemon. Documentation: perldoc koha-index perldoc koha-index-daemon New dependencies: MooseX::Getopt MooseX::RW AnyEvent::Processor Available as a Debian package: libmoosex-getopt-perl Test plan: - Apply the patch - Install dependencies, if necessary - Reindex a whole biblio catalog: koha-index --verbose - Reindex a whole authorities catalog: koha-index --source authority --verbose - Modify 1 biblio record, and index it: koha-index --select queue - Modifiy 1 authority record, and index it: koha-index --select queue --source authority - Run indexing daemon, with a 15s timeout: koha-index-daemon --timeout 15 - Modify a biblio record: wait 15s, and see - Modify an authority record: wait 15s, and see Signed-off-by: Bernardo Gonzalez Kriegel Works well, followed test plan without problems One comment: perhaps an option for koha-index-daemon to work quietly, without printing information. No koha-qa errors, but new files don't have license, fixed in followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 13:02:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 11:02:48 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 39278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39278&action=edit Bug 11081: (followup) Add license information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 13:11:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 11:11:51 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 --- Comment #20 from Jonathan Druart --- (In reply to Kyle M Hall from comment #19) > (In reply to Jonathan Druart from comment #18) > > I am not sure it's a good idea to test dependencies on TT side. > > Can you explain why? It seems like a good solution here, especially > considering that this feature would rarely if ever be used in production. We have a script to know when deps are missing (and it's also displayed on the about page). With this patch, we will have checks in pm, pl and tt files. As you said, this feature should only be enabled on a dev env, and a developer will know what to do if the missing deps error appears. But it's not a big deal and I don't want to block this enh for this reason. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 13:13:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 11:13:02 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 13:13:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 11:13:05 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39207|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 39279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39279&action=edit Bug 14172: Acq: Orders without items missing from 'spent' list If the item for an order had been deleted since or there was never an item created for the order (subscription orders) those records where missing from the "Spent" page in acquisitions. Patch corrects the SQL to list the correct records. To test: - Create different orders for one fund and receive them - normal order with a few items - subscription order (no item) - normal order with an item, delete the item after receiving - include some freight cost in one of the invoices - Compare the amount spent shown on the acq start page with the amount shown at the end of the 'spent' page - Without the patch, the amounts don't match and not all received titles are listed - With the patch, amounts should match and list shoudl be complete Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 13:13:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 11:13:25 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- Signing off with the following notes: On page spent.pl I see typo: Sub total A total of 52 euro is not listed as 52,00 although the items are listed as 12,00 and 40,00 The total of the shipping costs is not mentioned on the first form. But is included in the final total of the spent page. The removed item number is still in the aqorders_items table. The fact that an order number is corresponding with an item, is not intuitively clear. (Probably, the main cause is that an order is actually an order line.) A comment in the code where you join aqorders_items on ordernumber might be helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 13:37:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 11:37:23 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 --- Comment #21 from M. Tompsett --- (In reply to Jonathan Druart from comment #20) > We have a script to know when deps are missing (and it's also displayed on > the about page). With this patch, we will have checks in pm, pl and tt files. Which you can't get to, if you enable it and don't catch the error. Who regularly visits the about page before changing system preferences? > As you said, this feature should only be enabled on a dev env, and a > developer will know what to do if the missing deps error appears. It should be noted that sometimes the person playing with this in a development environment is not a developer. We have librarians with no linux and/or development experience trying to use Koha. A cleaner catch is a good thing for them. > But it's not a big deal and I don't want to block this enh for this reason. Thanks. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:09:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:09:38 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:09:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:09:40 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39279|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 39280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39280&action=edit Bug 14172: Acq: Orders without items missing from 'spent' list If the item for an order had been deleted since or there was never an item created for the order (subscription orders) those records where missing from the "Spent" page in acquisitions. Patch corrects the SQL to list the correct records. To test: - Create different orders for one fund and receive them - normal order with a few items - subscription order (no item) - normal order with an item, delete the item after receiving - include some freight cost in one of the invoices - Compare the amount spent shown on the acq start page with the amount shown at the end of the 'spent' page - Without the patch, the amounts don't match and not all received titles are listed - With the patch, amounts should match and list shoudl be complete Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:10:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:10:25 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9987 Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:10:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:10:25 +0000 Subject: [Koha-bugs] [Bug 9987] biblioitemnumber is useless for orders. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14172 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:23:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:23:58 +0000 Subject: [Koha-bugs] [Bug 14214] New: Automatic renewal to renew at end of due date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14214 Bug ID: 14214 Summary: Automatic renewal to renew at end of due date Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: fiona.borthwick at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If an item is set to automatically renew, then there should be a straightforward way to set the value so that it will renew at the end of the due date. I have done substantial testing on this but cannot get it to do what I need. Setting the 'no renewals before' to 1 means that it will renew one day prior to due date. Setting it to -1 means that it will renew one day past due date - i.e. item is overdue. Setting the value to 0 in the Circulation Policies translates to null when saved and the 0 is removed. We established that we could get 0 into the database by entering 0.001. However this seems to be ignored as the automatic renewal is happening every day in the same way that it would if there was no value set in 'no renewal before'. We can change the timing of the automatic_renewal.pl script to run at a more convenient time (e.g. before the overdue processing) but we need the item to be able to be renewed at the end of its due date - not before and not after. This is especially important for items that have rental fees associated with them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:24:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:24:10 +0000 Subject: [Koha-bugs] [Bug 14214] Automatic renewal to renew at end of due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14214 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:27:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:27:35 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:27:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:27:38 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35539|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 39281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39281&action=edit Bug 13622: Display a datetime without time in a notice For some needs, a librarian would like to display a datetime or timestamp field without the time. This patch adds filter logic in the notice/letter parsing process. Test plan: 1/ Defined a notice using a datetime or timestamp DB field (biblio.timestamp for instance). 2/ Generate the notice 3/ Verify that the letter is generated with the time 4/ Use the "dateonly" filter like: <> <> 5/ Generate the notice 6/ Confirm the the letter is generated without the time for this field. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:27:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:27:42 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 --- Comment #10 from Marcel de Rooy --- Created attachment 39282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39282&action=edit Bug 13622: [QA Follow-up] Add unit test descriptions This report adds a few unit tests for datonly flag in notices. This patch adds (very trivial) unit test descriptions. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:31:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:31:16 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 --- Comment #11 from Marcel de Rooy --- Here we have it moving again :) I will close report 13536 now; this is more global. The discussion status did not bring us any news. Point of attention: the feature needs to be documented somewhere.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:31:38 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 --- Comment #12 from Marcel de Rooy --- *** Bug 13536 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:31:38 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #12 from Marcel de Rooy --- *** This bug has been marked as a duplicate of bug 13622 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:47:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:47:11 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #6 from Indranil Das Gupta --- Created attachment 39283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39283&action=edit Bug 14206 - message_transport_type handling in C4::Letters::getletter Revised patch based on Jonathan Druart's comment. Addresses the default message_transport_type value in C4::Letters::getletter() for notices that do not use an email template (i.e. uses phone / print / sms). Fixes the issue of not being able to delete notices with non-email templates from Tools -> Notices & Slips Test plan ========= 1/ Go to Tools -> Notices & Slips. Add a new notice only for print, leave 'Library' and 'Koha module' options as default selections. Enter 'KOHA_14206' and 'Koha Test 14206' against Code and Name respectively, and 'Test' and 'Test Message' for subject and body. Leave the Email, Phone and SMS tabs blank. Save the notice. 2/ On the notices listing page the new notice will be listed. Try to delete it. It will load the 'Delete notice' dialog form, but the table will not show any data under s - 'Library', 'Module', 'Code' or 'Name'. 3/ Click the "Yes, delete" button. The page will be submitted and the Notices listing reloaded. The print-only KOHA_14206 notice should continue to exist. This is *wrong*. 4/ Apply the patch 5/ Reload the listings page and click on the 'Delete' link for Notice KOHA_14206. This time, it should show the data under 'Module', 'Code' or 'Name' at least. 6/ Click on 'Yes, delete'. The page should submit and the listing page reload. This time KOHA_14206 will be gone. 7/ Run sql statement SELECT * FROM `letter` WHERE `code` = 'KOHA_14206' to check actual deletion from the database. No record should be returned. 8/ Re-add notice KOHA_14206, but this time also add fill in print, email, phone and sms delivery options. 9/ Delete the newly re-added notice KOHA_14206. It should no longer be shown in the listing. Confirm deletion by running step #7. No record should be returned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:47:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:47:50 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 14:48:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 12:48:28 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 15:14:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 13:14:26 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 15:14:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 13:14:29 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37973|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 39284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39284&action=edit Bug 13265 - Still too many search cursor cookies We have multiple sites that are still exhibiting bug 11369. For whatever reason, the cookies on these sites are larger and thus the maximum of 10 is still too large. This setting should be controlled by a system preference to the number can be tailored on a per-site basis. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference MaxSearchCookies to a high number ( e.g. 20 ). 4) Perform searches until you get the error described in bug 11369 5) Delete your cookies so you can use the staff intranet again 5) Set the system preference to a much lower number ( e.g. 5 ) 6) Repeat setp 4, you should no longer get the error. Signed-off-by: Marcel de Rooy Works, but does not remove all superfluous cookies. The code still removes only the oldest one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 15:15:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 13:15:00 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 15:23:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 13:23:45 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om --- Comment #4 from David Roberts --- Is this related to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 15:24:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 13:24:18 +0000 Subject: [Koha-bugs] [Bug 14213] Cataloging plugin in cloned field does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14213 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39275|0 |1 is obsolete| | --- Comment #2 from Indranil Das Gupta --- Created attachment 39285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39285&action=edit Bug 14213: Cataloging plugin in cloned field does not work A code change for report 10480 in cataloging.js does not work well in case you clone a field with a plugin on a subfield. The events (click, focus, etc.) do not work on the subfield of the clone. This patch corrects the situation by finding the right html element for adding event binding. NOTE: The test plan uses EXAMPLE.pl since many old plugins do not operate on the correct field value when cloning. This is corrected in bug 13437. Test plan: [1] Attach EXAMPLE.pl to field 007, 246h and 260c. In sql for 007: update marc_subfield_structure set value_builder='EXAMPLE.pl' where tagfield='007' and tagsubfield='@'; [2] Clone field 007. Verify that focus and click operate on both fields. Check also that the plugin works on the value corresponding with the button you clicked. [3] Clone field 246. Do the same checks on both subfields $h. [4] Clone subfield 260c. Do the same checks again. Test Remarks: ============ 1/ Setup a new framework (B213) based off 'Default' and fired off an SQL statement to update value_builder values for 007, 246$h and 269$c (UPDATE `marc_subfield_structure` SET value_builder = 'EXAMPLE.pl' WHERE frameworkcode = 'B213' AND ( (tagfield = '007' AND tagsubfield = '@') OR ( tagfield LIKE '246' AND tagsubfield = 'h') OR (tagfield = '260' AND tagsubfield = 'c')) 2/ Tested step 2, 3 and 4 of the given test plan above. The missing plugin support in the cloned fields were noted. 3/ Applied patch 4/ Re-tested steps 2, 3 and 4 as before. The defined plugins were correctly cloned and found to be functional. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 15:25:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 13:25:18 +0000 Subject: [Koha-bugs] [Bug 14213] Cataloging plugin in cloned field does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14213 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 16:04:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 14:04:34 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #9 from Nicolas Legrand --- Thanks a lot for the patches. Test II.4 doesn't pass, it says "Please confirm checkout, Too many checked out. 2 checked out, only 2 are allowed." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 16:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 14:25:30 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 16:26:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 14:26:03 +0000 Subject: [Koha-bugs] [Bug 8480] auth_subfield_structure is not cleared when deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8480 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks "funny" Jonathan! :-P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 16:29:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 14:29:15 +0000 Subject: [Koha-bugs] [Bug 10904] Limit patron update request management by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 16:39:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 14:39:39 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 16:50:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 14:50:58 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- I could reproduce the double facets following the test plan. Howver, the patch did not apply on current master, I got: Apply? [(y)es, (n)o, (i)nteractive] y Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2630, in do_apply(*args) File "/usr/local/bin/git-bz", line 1755, in do_apply users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users'] File "/usr/lib/python2.7/xmlrpclib.py", line 1224, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.7/xmlrpclib.py", line 1578, in __request verbose=self.__verbose File "/usr/lib/python2.7/xmlrpclib.py", line 1264, in request return self.single_request(host, handler, request_body, verbose) File "/usr/lib/python2.7/xmlrpclib.py", line 1312, in single_request response.msg, xmlrpclib.ProtocolError: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 16:52:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 14:52:07 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl separator should default to the 'delimiter' syspref value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|export_borrowers.pl cannot |export_borrowers.pl |handle tab-separated output |separator should default to | |the 'delimiter' syspref | |value CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 16:54:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 14:54:45 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 --- Comment #3 from Tom?s Cohen Arazi --- (In reply to Marc V?ron from comment #2) > > xmlrpclib.ProtocolError: bugs.koha-community.org/xmlrpc.cgi: 404 Not Found> That looks like a networking issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:07:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:07:40 +0000 Subject: [Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- The patch 'works', but you should implement it on print.less instead of editing the print.css file yourself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:09:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:09:43 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #14 from Tom?s Cohen Arazi --- Ping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:14:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:14:10 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:14:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:14:36 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:15:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:15:06 +0000 Subject: [Koha-bugs] [Bug 12109] Authority subfield configuration page for controlled fields is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:18:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:18:49 +0000 Subject: [Koha-bugs] [Bug 14215] New: Change the 'delimiter' syspref description to say it applies to more than just Reports Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14215 Bug ID: 14215 Summary: Change the 'delimiter' syspref description to say it applies to more than just Reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The 'delimiter' syspref mentions it targets reports exports. But it is used in more places, for example bug 9892 makes the export_borrowers.pl script rely on it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:19:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:19:11 +0000 Subject: [Koha-bugs] [Bug 14215] Change the 'delimiter' syspref description to say it applies to more than just Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14215 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9892 Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:19:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:19:11 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl separator should default to the 'delimiter' syspref value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14215 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:31:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:31:24 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 --- Comment #4 from Marc V?ron --- I tried with other bugs / patches, no problem to apply, only with this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:33:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:33:47 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #2 from Nicole C. Engard --- I'm a bit confused then on how it works if I check the auto renew box when I check out - in that scenario you're overriding the default and there is no way to set 'no renewal before' in that scenario ... make sense? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:34:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:34:51 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #3 from Kyle M Hall --- Maybe the documentation on this feature is wrong, but when I've tried to set up automatica renewals I have a serious issue. I enable the nightly cron and all my automatic renewals are renewed every night! So if I set up automatic renewals on an item with 3 renewals and a renewal period of 7 days, I find that the item is renewed on the 1st night, on the 2nd night, and on the 3rd night. At that point it's out of renewals! This seems to happen even if I set a no renewal before value. Katrin, have you tried the feature? I'd love to get confirmation or clarification on how this should work! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 17:36:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 15:36:17 +0000 Subject: [Koha-bugs] [Bug 13854] XSLT result list doesn't show 'on order' when itemtype is not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13854 Isabela Terra changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isabelaterra at cp2.g12.br --- Comment #2 from Isabela Terra --- I am having the same problem.. some solution?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 18:12:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 16:12:16 +0000 Subject: [Koha-bugs] [Bug 14216] New: Koha should send a notice (via e-mail/print/or both) when changes are made to a patron account. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14216 Bug ID: 14216 Summary: Koha should send a notice (via e-mail/print/or both) when changes are made to a patron account. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Koha should send an e-mail to a patron's e-mail account (and optionally print) if changes are made to a patron's account, such as patron change request, updates to contact info, etc. Not necessarily everything, like internal notes, should alert the patron. No personal info should be included in the notice. It should simply state if the account has been successfully updated, or if the account has been renewed (and for how long), etc, and direct the patron to login to the catalog to see the updated information. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 18:24:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 16:24:12 +0000 Subject: [Koha-bugs] [Bug 7107] 'used in' column on analytics not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7107 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #11 from Joy Nelson --- On a site that is 3.18.06 I am seeing the 'Used in X analytic' data in the column. However the link is invalid. The link has this language: /cgi-bin/koha/catalogue/search.pl?idx=hi&q=181290 The 181290 is the item number. The itemnumber is not in the HI (hostitem) index. When the link is clicked, no results are returned. Joy (In reply to Nicole C. Engard from comment #10) > This is version 3.6, 3.8, 3.10 and master. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 19:15:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 17:15:32 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 19:15:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 17:15:35 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38345|0 |1 is obsolete| | Attachment #39214|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 39286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39286&action=edit Bug 14047: Order z39.50 biblioservers in cataloguing Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 19:15:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 17:15:39 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #7 from Marcel de Rooy --- Created attachment 39287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39287&action=edit Bug 14047: Sort z39.50 servers in Acquisition Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 19:15:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 17:15:42 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #8 from Marcel de Rooy --- Created attachment 39288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39288&action=edit Bug 14047: [QA Follow-up] Move result_class back into attributes No need to put this into a separate call. Signed-off-by: Marcel de Rooy Note that we strictly speaking do not need the hashref inflator here, because TT understands hash.column as well as object.property. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 19:33:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 17:33:38 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #4 from Katrin Fischer --- I think it should take the 'no renewal before' into account - I am not sure why it wouldn't. I haven't tested this myself, but I have added the developer in CC. Maybe the feature could fall back to try a renewal on the due date if there is nothing else specified in the circulation rules? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 20:52:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 18:52:42 +0000 Subject: [Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- To defend this patch a bit... print.less was added to master 13 days ago - after this patch had been written. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 20:54:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 18:54:58 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 --- Comment #9 from Indranil Das Gupta --- Created attachment 39289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39289&action=edit "Powered by Koha" getting cut into Hi Bernardo, Ran the tests (both pre and post patching). The switcher panel *does* stay visible in place after patch. But I'm having the "Powered by Koha" cut away. 'opaccredits' is not impacted, -idg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 22:06:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 20:06:03 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #24 from Katrin Fischer --- Hi Eivin, if you find a problem while testing the patch you can set to 'failed qa' - or 'patch doesn't apply' if there are conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 22:09:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 20:09:04 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 --- Comment #5 from Katrin Fischer --- It looks like the patch file is missing a few lines at the top - might need to be redone. I have the same error as Marc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 22:11:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 20:11:31 +0000 Subject: [Koha-bugs] [Bug 14214] Automatic renewal to renew at end of due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14101 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 22:11:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 20:11:31 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14214 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 18 22:18:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 20:18:30 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 --- Comment #10 from Katrin Fischer --- Hm, I only see a difference with and without the patch with a recompiled css file - attaching as a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 22:19:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 20:19:33 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 --- Comment #11 from Katrin Fischer --- Created attachment 39290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39290&action=edit Bug 11057: Follow-up - Bootstrap theme - recompiled css file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 22:35:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 20:35:34 +0000 Subject: [Koha-bugs] [Bug 14213] Cataloging plugin in cloned field does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14213 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 22:35:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 20:35:37 +0000 Subject: [Koha-bugs] [Bug 14213] Cataloging plugin in cloned field does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14213 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39285|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 39291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39291&action=edit [PASSED QA] Bug 14213: Cataloging plugin in cloned field does not work A code change for report 10480 in cataloging.js does not work well in case you clone a field with a plugin on a subfield. The events (click, focus, etc.) do not work on the subfield of the clone. This patch corrects the situation by finding the right html element for adding event binding. NOTE: The test plan uses EXAMPLE.pl since many old plugins do not operate on the correct field value when cloning. This is corrected in bug 13437. Test plan: [1] Attach EXAMPLE.pl to field 007, 246h and 260c. In sql for 007: update marc_subfield_structure set value_builder='EXAMPLE.pl' where tagfield='007' and tagsubfield='@'; [2] Clone field 007. Verify that focus and click operate on both fields. Check also that the plugin works on the value corresponding with the button you clicked. [3] Clone field 246. Do the same checks on both subfields $h. [4] Clone subfield 260c. Do the same checks again. Test Remarks: ============ 1/ Setup a new framework (B213) based off 'Default' and fired off an SQL statement to update value_builder values for 007, 246$h and 269$c (UPDATE `marc_subfield_structure` SET value_builder = 'EXAMPLE.pl' WHERE frameworkcode = 'B213' AND ( (tagfield = '007' AND tagsubfield = '@') OR ( tagfield LIKE '246' AND tagsubfield = 'h') OR (tagfield = '260' AND tagsubfield = 'c')) 2/ Tested step 2, 3 and 4 of the given test plan above. The missing plugin support in the cloned fields were noted. 3/ Applied patch 4/ Re-tested steps 2, 3 and 4 as before. The defined plugins were correctly cloned and found to be functional. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 18 23:56:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 21:56:19 +0000 Subject: [Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 00:01:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 22:01:28 +0000 Subject: [Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 00:05:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 22:05:19 +0000 Subject: [Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #3 from Mason James --- a bit more info about the bug here, too :) http://bywatersolutions.com/2015/05/18/koha-slips/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 00:06:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 22:06:28 +0000 Subject: [Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 --- Comment #4 from Christopher Brannon --- (In reply to Barton Chittenden from comment #1) > Note that items.onloan *will* print correctly; this is an acceptable > work-around. This is acceptable if you are not using hourly loans. items.onloan does not display the time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 00:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 22:47:46 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #3 from Mason James --- i'll test this bug on 3.16.x too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 00:51:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 May 2015 22:51:37 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I tried testing this on 3.18.x, but I had problems with the telnet connection - can someone else give this a try please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 03:34:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 01:34:45 +0000 Subject: [Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 --- Comment #6 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #5) > To defend this patch a bit... print.less was added to master 13 days ago - > after this patch had been written. Still have time to push it. Please re-do so it applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 05:16:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 03:16:52 +0000 Subject: [Koha-bugs] [Bug 14217] New: Add a DOM syntax for specifying conditions on indexes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Bug ID: 14217 Summary: Add a DOM syntax for specifying conditions on indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org It would be great to have a way on the XML syntax to specify conditions for fields to get indexed. For example: we could want to index the 100$a subfield on "Author" only if the 1st indicator is not 'z'. The current syntax doesn't allow us to specify that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 05:17:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 03:17:08 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com Change sponsored?|--- |Seeking cosponsors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 05:17:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 03:17:17 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking cosponsors |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 06:37:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 04:37:20 +0000 Subject: [Koha-bugs] [Bug 14192] Noisy warns in Koha/XSLT_Handler.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14192 --- Comment #4 from Aleisha Amohia --- (In reply to Marcel de Rooy from comment #3) > I cannot reproduce this error. Note that it appears to be a warning about a > wrong path to your opac detail xslt. Please check your xslt preferences and > paths. My apologies, XSLT path preference was specified rather than set to default. Changed that and the error is gone. Do I set this to Blocked now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 07:24:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 05:24:08 +0000 Subject: [Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 07:24:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 05:24:10 +0000 Subject: [Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39109|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 39292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39292&action=edit Bug 14191: Use smartmatch operator rather than equality operator This patch uses ~~ instead of == which silences the warns. Still not sure this is the best way to fix this but the warns are not there. Feel free to comment if you have any other better suggestions. To test: 1) On the OPAC, do a simple search for an item that will return results (ie by Keyword, search for "a") 2) Notice the warns in the error log 3) Apply patch 4) Reload page (search for "a") 5) Notice page still works but no warns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 08:17:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 06:17:57 +0000 Subject: [Koha-bugs] [Bug 14192] Noisy warns in Koha/XSLT_Handler.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14192 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #4) > (In reply to Marcel de Rooy from comment #3) > > I cannot reproduce this error. Note that it appears to be a warning about a > > wrong path to your opac detail xslt. Please check your xslt preferences and > > paths. > > My apologies, XSLT path preference was specified rather than set to default. > Changed that and the error is gone. Do I set this to Blocked now? No, we can set it to Resolved - Fixed. Thanks for checking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 10:22:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 08:22:33 +0000 Subject: [Koha-bugs] [Bug 14218] New: Error in adding child fund Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14218 Bug ID: 14218 Summary: Error in adding child fund Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: arunvr2467 at gmail.com QA Contact: testopia at bugs.koha-community.org After adding funds from a budget,I added child fund from the created fund. But it is not taking from the created fund. When I look into the total amount it exceeds the created budget. Created Budget = 10 lakhs Fund for book = 5 lakhs Fund for journals= 5lakhs Child fund for english book- 2.5lakhs This child fund is taken from 'the added fund for books of Rs 5lakhs' But when I look into total budget is shows 12.5 lakhs. Can you resolve it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 19 10:27:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 08:27:34 +0000 Subject: [Koha-bugs] [Bug 14219] New: Error in receiving books Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14219 Bug ID: 14219 Summary: Error in receiving books Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: arunvr2467 at gmail.com QA Contact: testopia at bugs.koha-community.org I given a purchase order for single book with 5 quanties. When I received these 5 books, the amount is not changed from the created budget. The spend and ordered amount shows 0. But when I received the books one by one it shows correctly. Please check this matter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 19 10:45:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 08:45:37 +0000 Subject: [Koha-bugs] [Bug 14196] Encoding error adding new biblio in custom framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14196 --- Comment #4 from Katrin Fischer --- Hm, strange. Just to make sure - does the problem also appear in the default framework? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 11:38:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 09:38:51 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 --- Comment #5 from Jacek Ablewicz --- (In reply to David Roberts from comment #4) > Is this related to > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906? In a way I guess (hard to say for sure, because original bug report is a bit vaque, and over 1.5 years old). It is somehow complicated.. There are 2 possible cases when importing biblio records: 1) some of the biblios in the given import batch do match some existing local record[s], and our choice is to replace such local records contents with imported ones if they match 2) some of the biblios in the import batch do not match any existing record[s] in the local catalogue, or we wish to import them 'as new' even if there are some possible matches found for them Before Bug 10906 fix, for cases #1, framework choice in import batch commit form was being ignored no matter what (but note that this particular setting is worded as 'Add _new_ bibliographic records into this framework', so it should not apply for records whitch are not imported 'as new' - ?) and also the previousy set framework in the existing recods being replaced by imported ones was getting lost in the process After Bug 10906, for cases #1, previously set framework in the existing records is not getting lost any longer, but framework choosen in the import batch commit form (if any) is still being ignored for the records which are not imported "as new". But I guess it probably should behave like this = this is an expected behaviour for such cases? Now, for cases #2 (biblios imported "as new" for whatever reason - there are no matches, or we don't wish to replace any existing records even if there is a match), framework choosen in the import batch commit form _should_ apply. But it seems to me that it _does_ apply and is not being ignored (at least not for records imported "as new") - ? Note: I tested it only in 3.18 and in ~2 months old master (and it appears to work fine / as expected), but not in the current clean master - perhaps it got somehow broken in more recent versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 11:48:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 09:48:34 +0000 Subject: [Koha-bugs] [Bug 14220] New: Bugzilla Not sending emails in other than gmail account Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14220 Bug ID: 14220 Summary: Bugzilla Not sending emails in other than gmail account Change sponsored?: --- Product: Koha Version: master Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: moazzamm at zenithss.co.in QA Contact: testopia at bugs.koha-community.org Hi, I have installed and configured bugzilla in my system. My issue is bugzilla is not sending emails other than gmail account. Like my email id is 'moazzamm at zenithss.co.in'. In my local system Bugzilla is unable to send emails on that email id or any other zenith account. So please guide me if there is any steps or configuration to be done so that Bugzilla will be able to send email on zenith account. Iam using sendmail utility of bugzilla and email is sent by bugzilla-daemon at zenith-optiplex-3020. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 11:49:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 09:49:32 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 --- Comment #6 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #1) > Created attachment 38319 [details] [review] > Bug 11064: Hide the framework choice when importing biblio > > This choice is ignored, it's preferable to hide it. > > Test plan: > 0/ Before to apply the patch, confirm the issue I'm unable to replicate such issue - framework choice seems to work for me as expected, and it doesn't appear to be ignored (at least not always / not in the cases when it shouldn't be ignored). Can you provide some more details regarding the circumstances when this issue still occurs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 11:55:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 09:55:53 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at biblibre.co |claire.hernandez at biblibre.c |m |om CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 12:07:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 10:07:11 +0000 Subject: [Koha-bugs] [Bug 14214] Automatic renewal to renew at end of due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14214 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |h.meissner.82 at web.de --- Comment #1 from Holger Mei?ner --- (In reply to Fiona Borthwick from comment #0) > If an item is set to automatically renew, then there should be a > straightforward way to set the value so that it will renew at the end of the > due date. Hi Fiona, there is a global syspref RenewalPeriodBase. It can be set to base the new due date on the current date or on the old due date. So the time the renewal happens doesn't have to be exactly at the end of the loan period. The automatic renewal feature uses the No renewal before setting, but No renewal before also is a feature in its own right. I didn't consider values smaller than 1, because that would mean users cannot renew before the item is already due. But maybe this could be changed. It should definitely work with values equal to or greater than 1. I will look into this more deeply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 13:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 11:43:42 +0000 Subject: [Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Bernardo Gonzalez Kriegel --- Aleisha, seems that your second patch needs the first! You need to un-obsolete first patch fatal: sha1 information is lacking or useless (C4/XSLT.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Comments: 1) You wrote my $itemtypes = "" unless GetItemTypes(); here I think you can use // my $itemtypes = GetItemTypes() // ""; 2) About ~~, as per Bug 12151 we can't use smartmatch operator 3) Which Linux/Perl/Apache version are you using? I don't see those warnings, but on Debian weezy there are warnings that do not appear on Ubuntu 14.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 13:56:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 11:56:59 +0000 Subject: [Koha-bugs] [Bug 14220] Bugzilla Not sending emails in other than gmail account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14220 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- Bugzilla bugs should be reported to Bugzilla developers, not Koha developers: https://www.bugzilla.org/developers/reporting_bugs.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:07:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:07:40 +0000 Subject: [Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:07:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:07:43 +0000 Subject: [Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39199|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 39293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39293&action=edit Bug 10299: authority plugin - authority field are reversed If you click the plugin next to an authority field that is already populated it takes the values from the field and puts them in the search in the reverse order. Test plan: 1/ Edit a biblio 2/ Fill the subfield for an authority field (for instance 650$v, 650$x, 650$y, etc.) 3/ Click on the authority plugin Before this patch, the values were concatenated in the reverse order. With this patch, it should not. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:08:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:08:31 +0000 Subject: [Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:14:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:14:55 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:14:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:14:59 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39091|0 |1 is obsolete| | --- Comment #246 from Marcel de Rooy --- Created attachment 39294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39294&action=edit Bug 7143: Small fix on the 3.20 release team Signed-off-by: Tomas Cohen Arazi Signed-off-by: Bernardo Gonzalez Kriegel Magnus is alone, no errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:15:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:15:08 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #247 from Marcel de Rooy --- Created attachment 39295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39295&action=edit Bug 7143: [QA Follow-up] Restoring lost tag Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:28:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:28:31 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #248 from Tom?s Cohen Arazi --- Update pushed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:28:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:28:36 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39294|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:28:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:28:41 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39295|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:29:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:29:38 +0000 Subject: [Koha-bugs] [Bug 10011] Branch limitiations are not saved on creating a new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10011 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:30:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:30:02 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl separator should default to the 'delimiter' syspref value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:30:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:30:24 +0000 Subject: [Koha-bugs] [Bug 10947] Default framework for authorities can't be edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:30:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:30:44 +0000 Subject: [Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:31:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:31:17 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:32:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:32:21 +0000 Subject: [Koha-bugs] [Bug 14213] Cataloging plugin in cloned field does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14213 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Good catch Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:41:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:41:41 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:41:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:41:43 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39197|0 |1 is obsolete| | Attachment #39198|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 39296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39296&action=edit Bug 14200 - Unit Tests Signed-off-by: Kyle M Hall Signed-off-by: Karen Bryant Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:41:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:41:49 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 --- Comment #6 from Marcel de Rooy --- Created attachment 39297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39297&action=edit Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in some cases For some reason the regular expression used to split the multiple ISBN fields can fail which keeps Business::ISBN from being able to parse out and return a valid isbn. Using split() instead of the regex fixes the issue. Test Plan: 1) Apply the unit test patch first 2) prove t/Koha.t 3) Note the failures 4) Apply the second patch 5) prove t/Koha.t 6) Note all tests pass Signed-off-by: Kyle M Hall Signed-off-by: Karen Bryant Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:43:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:43:18 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|Trivial patch |Small patch Version|3.18 |master CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:47:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:47:54 +0000 Subject: [Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patches pushed to master. Good work Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 14:59:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 12:59:06 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- Small question before passing QA: why do you decrement $size here: + if ( defined $size and $size > 1 ) { + $size--; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 15:13:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 13:13:30 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #32 from Tom?s Cohen Arazi --- Patches pushed to master. Good one Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 15:18:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 13:18:34 +0000 Subject: [Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com, | |sophie.meynieux at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 15:19:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 13:19:15 +0000 Subject: [Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 --- Comment #38 from Sophie MEYNIEUX --- Would it be possible to have it in 3.16.x ? Thanx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 15:41:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 13:41:46 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38367|0 |1 is obsolete| | --- Comment #25 from M. Tompsett --- Created attachment 39298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39298&action=edit Bug 12768 - Updated schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 15:41:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 13:41:54 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38368|0 |1 is obsolete| | --- Comment #26 from M. Tompsett --- Created attachment 39299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39299&action=edit Bug 12768 - Replacement cost and processing fee management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 15:42:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 13:42:02 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38375|0 |1 is obsolete| | --- Comment #27 from M. Tompsett --- Created attachment 39300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39300&action=edit Bug 12768 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 15:43:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 13:43:36 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |mtompset at hotmail.com --- Comment #28 from M. Tompsett --- I set this back to Needs Signoff, as resolving the conflict was relatively trivial. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 16:35:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 14:35:16 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #5 from Holger Mei?ner --- (In reply to Nicole C. Engard from comment #0) > It seems as though the autorenewal feature needs to have the column "no > renewal before" filled in or it will auto renew everyday after the duedate Hello Nicole. Yes, this is intentional. The "no renewal before" setting is the only way for the cronjob to know whether it is too soon for renewal or not. So without it, it will just renew every time it runs. Unless another restriction is met. > I'm not sure (haven't had time to test) how this effects auto renewals that > happen from the check box on the check out screen. There is a flag in the database called issues.auto_renew. If automatic renewal is scheduled by issing rule, this flag will be set for all issues where the rule applies. By checkbox the same flag is set, just for one issue. It makes no difference for the automatic renewal cronjob. It just tries to renew every flagged issue and uses the "no renewal before" settig from the issuing rule that applies. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 16:36:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 14:36:09 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 --- Comment #6 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #5) > Small question before passing QA: why do you decrement $size here: > > + if ( defined $size and $size > 1 ) { > + $size--; Because the regex, in this case, is [A-Za-z][A-Za-z0-9_]* And the max size passed to String::Random is related to the wild card, not the the size of the complete string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 16:37:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 14:37:37 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 vinod changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vinod_librarian at rediffmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 16:38:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 14:38:33 +0000 Subject: [Koha-bugs] [Bug 6685] circ rules by groups of items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 16:42:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 14:42:46 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 --- Comment #3 from vinod --- This feature may be provided as a new feature called federated search via z39.5/SRU servers. The function may be same as at the time of data entry via z39.5 only the format of result display needs to be changes. With this facility libraries may search the remote z39.5/SRU enabled OPAC as well as they can configure their Institutional repositories also like in DSpace and eprints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 16:46:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 14:46:41 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #6 from Holger Mei?ner --- (In reply to Kyle M Hall from comment #3) > This seems to happen even if I set a no renewal before value. Hi Kyle, which values did you test? It should work with values equal to or greater than 1. Maybe the feature broke. I am going to re-test, but this is how it used to work. The cronjob calls CanBookBeRenewed. There "no renewal before" is calculated like this: if ( $issuingrule->{norenewalbefore} ) { # Get current time and add norenewalbefore. # If this is smaller than date_due, it's too soon for renewal. if ( DateTime->now( time_zone => C4::Context->tz() )->add( $issuingrule->{lengthunit} => $issuingrule->{norenewalbefore} ) < $itemissue->{date_due} ) { return ( 0, "auto_too_soon" ) if $itemissue->{auto_renew}; return ( 0, "too_soon" ); } } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 19 16:50:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 14:50:51 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #36 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 16:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 14:51:15 +0000 Subject: [Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 16:54:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 14:54:01 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #26 from M. Tompsett --- (In reply to Katrin Fischer from comment #25) > If you or Rolando can tell me how to alter the data in order to make the > problem appear that would work for me for now. Haven't triggered the exact problem, but a similar one: 1) Set up stuff. a) Home -> Acquisitions b) Add Vendor c) Add Budget d) Add Fund for that Budget -- not all these steps may be necessary, but they are a good idea. 2) Home -> Serials 3) New Subscription 4) Fill in first page nicely, click Next 5) Fill in second page nicely, click 'Test prediction pattern' 6) EVIL STEP: Change the publication date to 00/00/0000 7) Click 'Save' -- KABOOM! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:08:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:08:00 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:12:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:12:37 +0000 Subject: [Koha-bugs] [Bug 14221] New: Error: Not for Loan doesn't save. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14221 Bug ID: 14221 Summary: Error: Not for Loan doesn't save. Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: isabelaterra at cp2.g12.br QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi guys. I created a server with 3:18 Koha installed. After creating the records, I saw that when creating copies it does not save the field "Not for loan", getting empty. Someone went through it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:16:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:16:12 +0000 Subject: [Koha-bugs] [Bug 14222] New: sort holds in OPAC by priority Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222 Bug ID: 14222 Summary: sort holds in OPAC by priority Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org I got this feedback from a patron today: It would be nice if the patron's holds list in the OPAC was sorted by priority by default so that the waiting items show at the top. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:17:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:17:57 +0000 Subject: [Koha-bugs] [Bug 10075] Extend CGI to provide a param_utf8_decode method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10075 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Tom?s Cohen Arazi --- This is not needed, as we patched all cgi files to have 'use CGI qw (-utf8)' instead. *** This bug has been marked as a duplicate of bug 11944 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:17:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:17:57 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #294 from Tom?s Cohen Arazi --- *** Bug 10075 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:18:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:18:00 +0000 Subject: [Koha-bugs] [Bug 14223] New: show comments on reading history Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14223 Bug ID: 14223 Summary: show comments on reading history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org I got this feedback from a patron today: Allow commenting from reading history - and see my comments and star rating on the reading history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:19:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:19:20 +0000 Subject: [Koha-bugs] [Bug 14224] New: patron notes about item shown at check in Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Bug ID: 14224 Summary: patron notes about item shown at check in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice (per a patron) if there was a way for patrons to enter a note about the item they have checked out - this DVD is scratched - the binding was torn - etc. Then this note emails to the library and shows up at check in so the librarian knows that the item is damages or has an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:21:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:21:36 +0000 Subject: [Koha-bugs] [Bug 14225] New: calendar results in Koha Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14225 Bug ID: 14225 Summary: calendar results in Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org If the library has a calendar (in this example a wordpress events plugin) it would be awesome to be able to search it from the catalog. So if you search for Knitting you get at the top of the results the knitting event that is happening at the library before the bib record results. This is a suggestion from a patron I met today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:28:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:28:48 +0000 Subject: [Koha-bugs] [Bug 11858] RFID for circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Nicole C. Engard --- I have a library that likes this idea a lot - what's the status of this? Is it sponsored or looking for sponsors? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:33:52 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 39301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39301&action=edit Bug 14198: RDA: Indexing 264 field (Zebra) This patch add zebra indexes to RDA 264 field. The new Provider index is added too. The XSLT for staff and OPAC has been updated to reflect the index. To test: 1) Download RDA records with 264 fields from this attachment . Import the file and re-index/rebuild zebra. These records contain 260 and 264 fields per record. 2) Do a search with pb:Bethany two records will appear with title The guardian. Search with pl:Minneapolis too, the two records will appear. Notice that 264 not show the link for Publisher in the record detail page. 3) Select one record of both records and delete the 260 field keeping the 264 field and save, rebuild your zebra. 4) Search again with pb:Bethany and just one record will appear. Thats mean 264 is not indexed. 5) Apply patch. 6) Rebuild your zebra but this time all biblio records. 7) Search again with pb:Bethany, this time will appear the two records, 264 is indexed. 8) This patch add three new indexes Provider, Provider-date and Provider-place for 260 and 264 fields. 9) Do a search with the three new indexes for Bethany publisher. 10) Search with copydate:2013 and Provider-date:2013 both searches will give the same result. 11) Get access to record detail page of one record and notice that the link for Publisher in 264 field appear. Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:36:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:36:12 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |hector.hecaxmmx at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 17:53:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 15:53:09 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |joy at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |nengard at gmail.com, | |tomascohen at gmail.com, | |wsalesky at gmail.com --- Comment #2 from H?ctor Eduardo Castro Avalos --- I add here maybe some interested in RDA development for Koha Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 18:56:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 16:56:01 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #37 from Tom?s Cohen Arazi --- Created attachment 39302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39302&action=edit Bug 5338: (QA followup) update the tests for the new reports This patch fixes the unit tests related to guided reports. It is needed now that there are more options available. It also fixes a wrong 'savedsql' key (should be 'sql') that caused the tests to print warnings. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 19:06:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 17:06:23 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 19:06:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 17:06:27 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31138|0 |1 is obsolete| | --- Comment #15 from Bernardo Gonzalez Kriegel --- Created attachment 39303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39303&action=edit Bug 12176: Remove HTML from additem.pl This patch removes HTML code from additem.pl To test: 1. Chech no regressions on Add/Edit/Save items 2. Update translation files for a language, check new strings "Tag editor" & "No popup" on staff PO file 3. Check it pass xt/tt_valid.t Patch partially rebased, part rewrite -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:07:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:07:20 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #27 from M. Tompsett --- (In reply to Katrin Fischer from comment #25) > If you or Rolando can tell me how to alter the data in order to make the > problem appear that would work for me for now. I have looked further, and believe the only way to trigger this problem is bad data. However, as I just posted, there are validation failures at the template level which end up calling these functions in exploding ways. GetNextSeq and GetNextDate in C4::Serials both call GetFictiveIssueNumber, and it is the second parameter as 0000-00-00 which causes the explosion. This is easy to trigger as tests apart from the interface. However, some validation on the template pages actually prevents such explosions. Though, as demonstrated in comment #26, there needs to be an improvement in validations done. Would adding those validations to solve comment #26 be sufficient to pass all of this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:10:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:10:25 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33337|0 |1 is obsolete| | --- Comment #56 from Bernardo Gonzalez Kriegel --- Created attachment 39304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39304&action=edit Bug 12017 - 1 - Move language description out of database This patch adds identical copies of languages.inc file on include dirs, and modifies include files to process it. To test: 1. No change on current behavior must be observer, any page staff/opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:10:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:10:34 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33338|0 |1 is obsolete| | --- Comment #57 from Bernardo Gonzalez Kriegel --- Created attachment 39305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39305&action=edit Bug 12017 - 2 - Enable languages on web installer This patch modifies installer/step1.tt to use new language descriptions. Only parameter used is rfc4646 code. To test: 1. Do some fake translations, for example all langs for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do mkdir koha-tmpl/intranet-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/bootstrap/$l; mkdir koha-tmpl/opac-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/ccsr/$l; done or make some lang dirs on intranet-tmpl/prog 2. Apply the patch 3. Edit your koha-conf.xml, change database name to a new name, create that database and grant access, reload staff page, log in with database user, you will be redirected to step1 of web installer. 4. Check names and codes for installed languages. Revert to your old database before proceed, but left dirs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:10:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:10:40 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33339|0 |1 is obsolete| | --- Comment #58 from Bernardo Gonzalez Kriegel --- Created attachment 39306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39306&action=edit Bug 12017 - 3 - Change lang display on sysprefs I18N This patch change the display of languages on sysprefs to set translated languages on I18N Only parameter used is rfc4646 subtag To test: 1. Apply the patch 2. Go to I18N syspref, look language descriptions Following steps are for next patch 3. Set a bunch of languages for staff/opac, save, reload Inlude vi-VN for which there is no current description in databasse 4. Set opaclanguagesdisplay to Allow Current display is preserved, native description for languages outside group, and script/region for language groups Only change is languages ordered by rfc4646 subtag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:10:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:10:46 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33340|0 |1 is obsolete| | --- Comment #59 from Bernardo Gonzalez Kriegel --- Created attachment 39307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39307&action=edit Bug 12017 - 4 - Change language changers This patch modifies language changers on staff/opac Only parameter used is rfc4646 To test: 1. Apply the patch 2. Reload staff and opac (prog/ccsr/bootstrap) 3. Check display of language changers 4. Do a real translation and check language change works Do not change language unless you did a real translation Only change in display is showing only regions for sublanguages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:10:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:10:52 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33341|0 |1 is obsolete| | --- Comment #60 from Bernardo Gonzalez Kriegel --- Created attachment 39308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39308&action=edit Bug 12017 - 5 - Change local use syspref type Language This patch changes local use syspref of type Language Currently this type of syspref is not used, and shows currently translated staff languages. It's values can't be changed. To make something useful, this kind of syspref is changed to show all langs and save iso639_2 codes. And they not use descriptions on database, only rfc4646 codes from templates. It's easy to add new kinds that save rfc4646 codes, or only show translated languages. To test: 1. Apply the patch 2. Go to system preferences, local use 3. Define a new syspref, any name/description, type 'Language', Save 4. New syspref is showed as a multiple selection of iso639_2 codes with current lang and native names. Check that 5. Select some values, save, check they are saved and restored 6. Edit, similar view, change values, save, check 7. Delete test syspref Values are stored as ',' separated values Verify in database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:10:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:10:58 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33342|0 |1 is obsolete| | --- Comment #61 from Bernardo Gonzalez Kriegel --- Created attachment 39309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39309&action=edit Bug 12017 - 6 - Change syspref AdvancedSearchLanguages Bug 10986 introduces a way of limiting advanced search languages list. It's a good feature, but to fill the preference you need to list iso639_2 codes. And there is no way to get the list of all codes again as before, and language descriptions are taken from database. This patch changes that preference so it's now a Local syspref, to present an interface to set it's value. Also adds another syspref to control if language chooser is limited at all, recovering previous behavior. As per comments on Bug 10986 language list shows translated and native names and is ordered by iso639_2 code To test: 1. Apply the patch 2. Run updatedatabase.pl 3. Go to system preferences, Searching, new syspref LimitAdvancedSearchLanguages, on by default 4. Go to Local use sysprefs, AdvancedSearchLanguages is now here with interface to set it's values 5. Check language limit on advanced search on staff and opac (any theme) 6. Disable limit and chech language list 7. Enable limit and set different languages on syspref, check language list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:11:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:11:05 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33343|0 |1 is obsolete| | --- Comment #62 from Bernardo Gonzalez Kriegel --- Created attachment 39310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39310&action=edit Bug 12017 - 7 - Remove function getFrameworkLanguages [ Note: From now on dependence on language descriptions in database is about to be removed, also some code cleaning.] This must be an old relic, not used anymore. To test: 1. Check use of getFrameworkLanguages egrep -Rl getFrameworkLanguages * No result save for definition file 2. Apply the patch 3. check again, no results Reason for removing this function is that it's not used and tries to send languages descriptions from database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:11:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:11:11 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33344|0 |1 is obsolete| | --- Comment #63 from Bernardo Gonzalez Kriegel --- Created attachment 39311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39311&action=edit Bug 12017 - 8 - Remove use of getAllLanguages from installer getAllLanguages is only used on installer/install.pl, and some tests. Result parameters are passed to C4/Install.pm, but its use is futile, language check on Installer.pm uses parameters that are not present on return value of getAllLanguages, and returned value fwk_code is undefined To test: 1. Apply the patch 2. Do translated install (eg using de-DE or es-ES) a. translate first, b. then create a new database, c. grant permissions, d. change koha-conf to use new db, e. reload staff, f. proceed to web install, g. select translated language, h. use marc21, i. finish, 3. Login and check that marc frameworks are translated The translated install must proceed without problems. Removed only the very first occurence of template parameter fwk_language because of it's null value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:11:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:11:17 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33345|0 |1 is obsolete| | --- Comment #64 from Bernardo Gonzalez Kriegel --- Created attachment 39312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39312&action=edit Bug 12017 - 9 - Remove use of language_get_description function This patch removes every use of language_get_description function. This function retrieves lang names from database To test: 1. Functionality removed by this patch do not affect anything, because previous patches are only using rfc4646_subtag value, not values stored in database. 2. Removed import from Templates.pm, not used there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:11:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:11:23 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33346|0 |1 is obsolete| | --- Comment #65 from Bernardo Gonzalez Kriegel --- Created attachment 39313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39313&action=edit Bug 12017 - 10 - Remove description from getLanguage This patch rewrites getLanguage function. This function is of not much use, but is rewrited to takes its data from language_rfc4646_to_iso639 table. To test: 1. Apply the patch 2. Only place that use this function is t/db_dependent/Languages.t so run the test and check that it pass 3. To compare the output pre and post patch you can run perl -e 'use C4::Languages; use Data::Dumper; $a = getLanguages(); print Dumper $a;' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:12:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:12:26 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #66 from Bernardo Gonzalez Kriegel --- Rebased and updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:39:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:39:05 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 --- Comment #12 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #10) > Hm, I only see a difference with and without the patch with a recompiled css > file - attaching as a follow-up. Yeah, that's point 6) in test plan :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:40:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:40:49 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #13 from Bernardo Gonzalez Kriegel --- (In reply to Indranil Das Gupta from comment #9) > Created attachment 39289 [details] > "Powered by Koha" getting cut into > > Hi Bernardo, > > Ran the tests (both pre and post patching). The switcher panel *does* stay > visible in place after patch. But I'm having the "Powered by Koha" cut away. > 'opaccredits' is not impacted, > > -idg I can reproduce, so it's not ready and needs more work. Thanks for testing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:48:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:48:30 +0000 Subject: [Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37577|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 39314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39314&action=edit [SIGNED-OFF] Bug 9314: Remove useless code related to the type_only parameter Since the pref AddPatronLists has been removed in bug 13497, the code related to type_only and category_type in memberentry.pl is useless. Test plan: Confirm you don't the information message. You can also confirm that the message was wrong and nothing was saved. Signed-off-by: Bernardo Gonzalez Kriegel Dead code removed, no errors Think that bug description can be updated to commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:48:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:48:54 +0000 Subject: [Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 20:55:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 18:55:21 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 21:43:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 19:43:17 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39283|0 |1 is obsolete| | --- Comment #7 from Indranil Das Gupta --- Created attachment 39315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39315&action=edit Bug 14206 Adds two tests to t/db_dependent/Letters.t C4::Letters::getletter is called in tools/letter.pl by the function delete_confirm() to display the selected notice for deletion. Due to current implementation of getletter(), a notice that does not use the 'email' template (but uses any/all of the other templates - sms, print or phone) can't be deleted from the staff client. This patch adds 2 tests to t/db_dependent/Letters.t to test the bug. Test plan ========= 1/ Apply the patch and run prove -v t/db_dependent/Letters.t 2/ Test 38 should pass demonstrating unpatched getletter() behaviour Test 39 should FAIL, highlighting the problem # Failed test 'Bug 14206 - returns actual message_transport_type' # at t/db_dependent/Letters.t line 181. # got: undef # expected: 'print' (Test plan continues in the second commit) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 21:57:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 19:57:09 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #8 from Indranil Das Gupta --- Created attachment 39316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39316&action=edit Bug 14206 Adds delete function for non email templates This patch adds deletion capability for notices that do not use email template, but uses any/all of the other templates i.e. sms, print or phone. Test plan (Continued) ===================== 3/ Go to Tools -> Notices & Slips. Add a new notice only for print, leave 'Library' and 'Koha module' options as default selections. Enter 'KOHA_14206' and 'Koha Test 14206' against Code and Name respectively, and 'Test' and 'Test Message' for subject and body. Leave the Email, Phone and SMS tabs blank. Save the notice. 4/ On the notices listing page the new notice will be listed. Try to delete it. It will load the 'Delete notice' dialog form, but the table will not show any data under s - 'Library', 'Module', 'Code' or 'Name'. 5/ Click the "Yes, delete" button. The page will be submitted and the Notices listing reloaded. The print-only KOHA_14206 notice should continue to exist. This is *wrong*. 6/ Apply this patch 7/ Reload the listings page and click on the 'Delete' link for Notice KOHA_14206. This time, it should show the data under 'Module', 'Code' or 'Name' at least. 8/ Click on 'Yes, delete'. The page should submit and the listing page reload. This time KOHA_14206 will be gone. 9/ Re-run prove -v t/db_dependent/Letters.t This time all tests should PASS without any error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 21:58:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 19:58:40 +0000 Subject: [Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 22:19:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 20:19:13 +0000 Subject: [Koha-bugs] [Bug 14221] Error: Not for Loan doesn't save. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14221 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Isabela, did you change the authorised value for authorized value? Please check that the codes are numeric - otherwise it won't save. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 22:27:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 20:27:50 +0000 Subject: [Koha-bugs] [Bug 11858] RFID for circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 --- Comment #3 from Viktor Sarge --- Nicole - I very much suspect that the relevant projekt is over at https://github.com/digibib/koha-rfidhub. But I'm not shure whether it's near getting the full workflow with the necessary parts in Koha done even if the RFIDhub seems done. The way Hylte does RFID now is that the vendor created a workflow with the RFID-reader posting codes at a certain pace and relying on focus being set to the barcode box. That's not very pretty even if it works and for the staff side I'm looking forward to batch checkout since that lets them checkout the whole bunch at the same time which works perfectly with how the reader wants to work. I guess running the RFIDhub would be even better :) But at least it works for now (and I guess some RFID-vendors might use SIP2 instead(?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 22:48:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 20:48:57 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts fail in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP2 Checkouts file in Koha |SIP2 Checkouts fail in Koha |3.18 |3.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 19 23:54:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 21:54:35 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |indradg at gmail.com |ity.org | Summary|notice using only the |notices using non email |'print' template can't be |templates can't be deleted |deleted |from the staff client Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 20 00:58:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 22:58:11 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #120 from Robin Sheat --- libpdf-writer-perl is currently in the Debian NEW queue, and in the Koha repository. libpdf-fromhtml-perl is being a more recalcitrant. I'm hoping that by spending some time on it today, I'll succeed it making it build correctly, and if I'm really lucky it'll work in wheezy too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 01:09:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 23:09:07 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 01:09:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 23:09:10 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39301|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 39317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39317&action=edit [SIGNED-OFF] Bug 14198: RDA: Indexing 264 field (Zebra) This patch add zebra indexes to RDA 264 field. The new Provider index is added too. The XSLT for staff and OPAC has been updated to reflect the index. To test: 1) Download RDA records with 264 fields from this attachment . Import the file and re-index/rebuild zebra. These records contain 260 and 264 fields per record. 2) Do a search with pb:Bethany two records will appear with title The guardian. Search with pl:Minneapolis too, the two records will appear. Notice that 264 not show the link for Publisher in the record detail page. 3) Select one record of both records and delete the 260 field keeping the 264 field and save, rebuild your zebra. 4) Search again with pb:Bethany and just one record will appear. Thats mean 264 is not indexed. 5) Apply patch. 6) Rebuild your zebra but this time all biblio records. 7) Search again with pb:Bethany, this time will appear the two records, 264 is indexed. 8) This patch add three new indexes Provider, Provider-date and Provider-place for 260 and 264 fields. 9) Do a search with the three new indexes for Bethany publisher. 10) Search with copydate:2013 and Provider-date:2013 both searches will give the same result. 11) Get access to record detail page of one record and notice that the link for Publisher in 264 field appear. Sponsored-by: Universidad de El Salvador Signed-off-by: Bernardo Gonzalez Kriegel Work as described following test plan. Only comment is that if 260 and 264 are present, link only shows for 260 value. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 01:20:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 May 2015 23:20:22 +0000 Subject: [Koha-bugs] [Bug 12191] Items with not for loan status shouldn't trigger a transfer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12191 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Heather Braum --- With the new UpdateNotForLoanStatusOnCheckin sys pref in 3.18, this is no longer an issue. I hope it's okay, I'm marking this resolved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 20 03:49:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 01:49:22 +0000 Subject: [Koha-bugs] [Bug 13970] Remove related code to category_type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 03:49:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 01:49:25 +0000 Subject: [Koha-bugs] [Bug 13970] Remove related code to category_type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37578|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 39318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39318&action=edit [SIGNED-OFF] Bug 13970: Remove category_type related code Working on bug 13497 and bug 9314, I run into some Koha vestiges. The category_type parameter should not be passed to memberentry. On creating a new patron, the categorycode should be passed, and on editing, it's useless. We can work with the borrowernumber and retrieve these values. Details of the changes: - members-toolbar.inc: Remove the category_type parameter passed to memberentry.pl - memberentrygen.tt: Just remove the useless category_type parameter on editing a patron. Also remove the unused one passed to guarantor_search.pl. - tables/members_results.tt: the borrowernumber is enough to edit a patron. - memberentry.pl: check_categorytype is never used in the template, all the process to calculate/retrieve it is unnecessary. - members/nl-search.tt: The borrowernumber is enough to edit a patron. Test plan: Try to create and edit patrons and verify that - the guarantor search still work - the form (memberentry) behave as before Edit a patron from the nl-search.pl script (Magnus?) Signed-off-by: Bernardo Gonzalez Kriegel On top of 9314 (13497 already pushed) No evident regressions found, add/edit patron works, search/set guarantor works. Cant test nl-patron.pl save for exec it. prove -v t/NorwegianPatronDB.t runs No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 03:50:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 01:50:37 +0000 Subject: [Koha-bugs] [Bug 13970] Remove related code to category_type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |magnus at libriotech.no --- Comment #3 from Bernardo Gonzalez Kriegel --- Adding magnus in cc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 04:12:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 02:12:51 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14226 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 04:12:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 02:12:51 +0000 Subject: [Koha-bugs] [Bug 14226] New: LC help in professional cataloging interface Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14226 Bug ID: 14226 Summary: LC help in professional cataloging interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 11559 It would be nice if the professional cataloging interface had built in LC help links - like with the basic editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 04:13:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 02:13:46 +0000 Subject: [Koha-bugs] [Bug 14227] New: rda toolkit integration Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14227 Bug ID: 14227 Summary: rda toolkit integration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Would be nice if there was RDA toolkit integration in Koha and/or a way to convert records to RDA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 04:14:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 02:14:27 +0000 Subject: [Koha-bugs] [Bug 14228] New: fill in patron info by scanning an ID Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14228 Bug ID: 14228 Summary: fill in patron info by scanning an ID Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice if you could scan a barcode on a drivers license and get the name, address, birthday info -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 04:15:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 02:15:19 +0000 Subject: [Koha-bugs] [Bug 14229] New: fines clickable on patron results to pay Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14229 Bug ID: 14229 Summary: fines clickable on patron results to pay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Would be nice if on the patron search results the fine amount was clickable so you could jump to the patron's pay screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 04:16:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 02:16:57 +0000 Subject: [Koha-bugs] [Bug 14230] New: fund list show percentage Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14230 Bug ID: 14230 Summary: fund list show percentage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice (since you can set warnings at percentages) to add a column to the fund list on the acq homepage that shows the percentage spent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 05:15:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 03:15:00 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #121 from Robin Sheat --- (In reply to Robin Sheat from comment #120) > libpdf-writer-perl is currently in the Debian NEW queue, and in the Koha > repository. libpdf-fromhtml-perl is being a more recalcitrant. I'm hoping > that by spending some time on it today, I'll succeed it making it build > correctly, and if I'm really lucky it'll work in wheezy too. ...and after days of wailing and gnashing of teeth, both modules are in a releasable state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 05:26:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 03:26:46 +0000 Subject: [Koha-bugs] [Bug 14231] New: Package updates for 3.20 release Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231 Bug ID: 14231 Summary: Package updates for 3.20 release Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 20 06:04:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 04:04:58 +0000 Subject: [Koha-bugs] [Bug 14232] New: Biblio records are not showing after zebra indexing from cronjob Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14232 Bug ID: 14232 Summary: Biblio records are not showing after zebra indexing from cronjob Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: nishantsingal at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, I have upgrade koha3.6 to Koha3.18 from Tarball. Everything is working fine but while rebuild_zebra.pl is executing via cronjob, records is not showing. When we run manual this script, we are getting the records. We checked the cronjob logs also, but it shows Record exported(No. of Records) ============================= Reindexing Zebra. ============================ Cleaning. =================== Zebra Version 2.60 is running. Please give some steps to resolve this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 06:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 04:22:05 +0000 Subject: [Koha-bugs] [Bug 14231] Package updates for 3.20 release In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231 --- Comment #1 from Robin Sheat --- Created attachment 39319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39319&action=edit Bug 14231: changes required for 3.20 release -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 20 06:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 04:22:02 +0000 Subject: [Koha-bugs] [Bug 14231] Package updates for 3.20 release In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 06:22:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 04:22:28 +0000 Subject: [Koha-bugs] [Bug 14231] Package updates for 3.20 release In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 06:22:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 04:22:41 +0000 Subject: [Koha-bugs] [Bug 14231] Package updates for 3.20 release In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 07:17:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 05:17:25 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 09:07:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 07:07:29 +0000 Subject: [Koha-bugs] [Bug 14233] New: Add logging support to notices' management Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Bug ID: 14233 Summary: Add logging support to notices' management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P4 Component: Notices Assignee: indradg at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 14206 Notices are a key feature that provides notifications to Koha users and patrons. The present code does not provide logging when notices are added or deleted. This bug aims to fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 09:07:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 07:07:29 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14233 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 09:28:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 07:28:24 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39278|0 |1 is obsolete| | --- Comment #12 from Fr?d?ric Demians --- Created attachment 39320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39320&action=edit [SIGNED-OFF] Bug 11081: (followup) Add license information Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 10:10:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 08:10:34 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #9 from Marc V?ron --- Created attachment 39321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39321&action=edit [Signed-off] Bug 14206 Adds two tests to t/db_dependent/Letters.t C4::Letters::getletter is called in tools/letter.pl by the function delete_confirm() to display the selected notice for deletion. Due to current implementation of getletter(), a notice that does not use the 'email' template (but uses any/all of the other templates - sms, print or phone) can't be deleted from the staff client. This patch adds 2 tests to t/db_dependent/Letters.t to test the bug. Test plan ========= 1/ Apply the patch and run prove -v t/db_dependent/Letters.t 2/ Test 38 should pass demonstrating unpatched getletter() behaviour Test 39 should FAIL, highlighting the problem # Failed test 'Bug 14206 - returns actual message_transport_type' # at t/db_dependent/Letters.t line 181. # got: undef # expected: 'print' (Test plan continues in the second commit) Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 10:11:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 08:11:00 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #39315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 10:13:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 08:13:36 +0000 Subject: [Koha-bugs] [Bug 14234] New: Include the user manual with Koha package Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14234 Bug ID: 14234 Summary: Include the user manual with Koha package Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Documentation Assignee: indradg at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org CC: nengard at gmail.com At present, Koha's online help documentation includes a link to the topics as presented on the Koha manual hosted at http://manual.koha-community.org/. This presents a major problem for users who run Koha with intermittent / low bandwidth Internet access, as they are largely unable to access the manual pages. The usual workaround is to locally downloading the Koha manual, which does not solve the issue as the online help topics do not link to a downloaded copy. Can we consider shipping the manual along with the koha package? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 10:13:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 08:13:56 +0000 Subject: [Koha-bugs] [Bug 11115] Pull help files from the manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11115 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14234 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 10:13:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 08:13:56 +0000 Subject: [Koha-bugs] [Bug 14234] Include the user manual with Koha package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14234 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11115 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 10:19:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 08:19:27 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #10 from Marc V?ron --- First patch (with tests) worked OK (signed-off), but I could not apply main patch: Applying: Bug 14206 Adds delete function for non email templates fatal: sha1 information is lacking or useless (C4/Letters.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 14206 Adds delete function for non email templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 10:35:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 08:35:12 +0000 Subject: [Koha-bugs] [Bug 14234] Include the user manual with Koha package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14234 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- I like the idea. The help pages then could have two links: #1 to the local copy #2 to the online help -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 10:56:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 08:56:53 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38869|0 |1 is obsolete| | --- Comment #17 from tadeas.moravec at gmail.com --- Created attachment 39322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39322&action=edit Add password strength meter to add and duplicate user in staff client http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: tadeasm Works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:05:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:05:12 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:05:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:05:14 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38855|0 |1 is obsolete| | --- Comment #18 from tadeas.moravec at gmail.com --- Created attachment 39323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39323&action=edit Add jquery-complexify library http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:05:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:05:29 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38856|0 |1 is obsolete| | --- Comment #19 from tadeas.moravec at gmail.com --- Created attachment 39324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39324&action=edit Added complexify display to opac-passwd page http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:05:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:05:35 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38857|0 |1 is obsolete| | --- Comment #20 from tadeas.moravec at gmail.com --- Created attachment 39325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39325&action=edit Change formatting and correct spelling mistakes http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:05:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:05:49 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38858|0 |1 is obsolete| | --- Comment #21 from tadeas.moravec at gmail.com --- Created attachment 39326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39326&action=edit Add OPACPasswordStrength syspref to staff client http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:05:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:05:55 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38859|0 |1 is obsolete| | --- Comment #22 from tadeas.moravec at gmail.com --- Created attachment 39327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39327&action=edit Add SQL for OPACPasswordStrength syspref http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:06:02 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38860|0 |1 is obsolete| | --- Comment #23 from tadeas.moravec at gmail.com --- Created attachment 39328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39328&action=edit Add default OPACPasswordStrength syspref to updatedatabase.pl http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:06:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:06:14 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38861|0 |1 is obsolete| | --- Comment #24 from tadeas.moravec at gmail.com --- Created attachment 39329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39329&action=edit Add OPACPasswordStrength System Preference to Auth.pm http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:06:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:06:24 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38863|0 |1 is obsolete| | --- Comment #26 from tadeas.moravec at gmail.com --- Created attachment 39331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39331&action=edit Add password strength meter to staff client http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:06:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:06:19 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38862|0 |1 is obsolete| | --- Comment #25 from tadeas.moravec at gmail.com --- Created attachment 39330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39330&action=edit Put password meter under syspref control http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:06:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:06:31 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38864|0 |1 is obsolete| | --- Comment #27 from tadeas.moravec at gmail.com --- Created attachment 39332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39332&action=edit Add jquery plugins to staff client http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:06:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:06:44 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38866|0 |1 is obsolete| | --- Comment #29 from tadeas.moravec at gmail.com --- Created attachment 39334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39334&action=edit Add new PasswordStrength syspref http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:06:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:06:36 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38865|0 |1 is obsolete| | --- Comment #28 from tadeas.moravec at gmail.com --- Created attachment 39333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39333&action=edit Add complexify includes file to staff client http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:06:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:06:50 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38867|0 |1 is obsolete| | --- Comment #30 from tadeas.moravec at gmail.com --- Created attachment 39335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39335&action=edit Add code to updatedatabase.pl http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:06:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:06:55 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38868|0 |1 is obsolete| | --- Comment #31 from tadeas.moravec at gmail.com --- Created attachment 39336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39336&action=edit Put staff client password strength meter under syspref control http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 11:07:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 09:07:01 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.moravec at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39322|0 |1 is obsolete| | --- Comment #32 from tadeas.moravec at gmail.com --- Created attachment 39337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39337&action=edit Add password strength meter to add and duplicate user in staff client http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: tadeasm Works as expected Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 12:21:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 10:21:14 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #10 from Jonathan Druart --- (In reply to Nicolas Legrand from comment #9) > Thanks a lot for the patches. > > Test II.4 doesn't pass, it says "Please confirm checkout, Too many checked > out. 2 checked out, only 2 are allowed." At this point, the patron should have only 1 on-site checkout in his/her checkout list. The 3 steps (I, II and III) are independent. I have just retested and it works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 12:29:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 10:29:57 +0000 Subject: [Koha-bugs] [Bug 14221] Error: Not for Loan doesn't save. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14221 --- Comment #2 from Isabela Terra --- Sorry! Where I have to change it? I am newcomer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 12:36:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 10:36:11 +0000 Subject: [Koha-bugs] [Bug 14221] Error: Not for Loan doesn't save. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14221 --- Comment #3 from Isabela Terra --- Hi!! I changed! It worked! Thank you! =) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 12:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 10:51:27 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 12:52:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 10:52:03 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #11 from Indranil Das Gupta --- (In reply to Marc V?ron from comment #10) > First patch (with tests) worked OK (signed-off), but I could not apply main > patch: > > Applying: Bug 14206 Adds delete function for non email templates > fatal: sha1 information is lacking or useless (C4/Letters.pm). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 14206 Adds delete function for non email templates I prolly need to rebase the patch. let me check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 12:58:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 10:58:47 +0000 Subject: [Koha-bugs] [Bug 14221] Error: Not for Loan doesn't save. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14221 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- Not a bug - so moving "INVALID" - glad it works now. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 12:59:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 10:59:33 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39191|0 |1 is obsolete| | Attachment #39192|0 |1 is obsolete| | --- Comment #4 from Mirko Tietgen --- Created attachment 39338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39338&action=edit Bug 14072: Update German web installer for 3.20 - translates new notice ACQ_NOTIF_ON_RECEIV - translates new permissions Signed-off-by: Bernardo Gonzalez Kriegel Tested German install till "Gratulation, die Installation ist abgeschlossen" No errors Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Same results noted as above. Signed-off-by: Mirko Tietgen Tested installation, checked new translations in Koha and deleted an extra space in the ACQ_NOTIF_ON_RECEIV notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:06:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:06:56 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #11 from Nicolas Legrand --- Mhmm, tested, again, indeed, it works :), sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:08:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:08:01 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 --- Comment #5 from Mirko Tietgen --- Created attachment 39339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39339&action=edit Bug 14072: Followup: delete extra space Delete extra space in sample notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:18:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:18:36 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:18:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:18:38 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39200|0 |1 is obsolete| | Attachment #39201|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 39340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39340&action=edit Bug 14195: TestBuilder - A random string should not be longer than the DB field t::lib::TestBuilder::_gen_text does not use correctly the regex and the max parameter to generate the random string (String::Random). This can cause future tests to fail. http://bugs.koha-community.org/show_bug.cgi?id=14195 Signed-off-by: Bernardo Gonzalez Kriegel Script tested, problem occurs, patch fixes it. Bad number on commit subject No errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:18:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:18:43 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 --- Comment #8 from Marcel de Rooy --- Created attachment 39341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39341&action=edit Bug 14195: (followup) increment number of tests Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:20:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:20:18 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > Because the regex, in this case, is > [A-Za-z][A-Za-z0-9_]* > And the max size passed to String::Random is related to the wild card, not > the the size of the complete string. Fine. Could have read this in your comment :) Just not very intuitive Random parameter.. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:24:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:24:24 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39316|0 |1 is obsolete| | --- Comment #12 from Indranil Das Gupta --- Created attachment 39342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39342&action=edit Bug 14206 Adds delete function for non email templates This patch adds deletion capability for notices that do not use email template, but uses any/all of the other templates i.e. sms, print or phone. Test plan (Continued) ===================== 3/ Go to Tools -> Notices & Slips. Add a new notice only for print, leave 'Library' and 'Koha module' options as default selections. Enter 'KOHA_14206' and 'Koha Test 14206' against Code and Name respectively, and 'Test' and 'Test Message' for subject and body. Leave the Email, Phone and SMS tabs blank. Save the notice. 4/ On the notices listing page the new notice will be listed. Try to delete it. It will load the 'Delete notice' dialog form, but the table will not show any data under s - 'Library', 'Module', 'Code' or 'Name'. 5/ Click the "Yes, delete" button. The page will be submitted and the Notices listing reloaded. The print-only KOHA_14206 notice should continue to exist. This is *wrong*. 6/ Apply this patch 7/ Reload the listings page and click on the 'Delete' link for Notice KOHA_14206. This time, it should show the data under 'Module', 'Code' or 'Name' at least. 8/ Click on 'Yes, delete'. The page should submit and the listing page reload. This time KOHA_14206 will be gone. 9/ Re-run prove -v t/db_dependent/Letters.t This time all tests should PASS without any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:25:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:25:10 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:39:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:39:02 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts fail in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 --- Comment #5 from Colin Campbell --- Problem arises because patch for bug 7904 had not been applied in 3.18 and 12820 assumed it had reverting to old libpath fixes this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:46:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:46:36 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #16 from Marcel de Rooy --- Created attachment 39343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39343&action=edit Bug 13049: [QA Follow-up] Remove unneeded module The call to cronlogaction is done in cleanup_database. So there is no use in keeping the module here. Test plan: Run or compile (perl -c) script delete_expired_opac_registrations.pl. Run or compile (perl -c) script delete_unverified_opac_registrations.pl. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:55:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:55:09 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts fail in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 --- Comment #6 from Katrin Fischer --- Hi Colin, is this a fail for the patch or a pass? Sorry, still confused! Can you please switch the status accordingly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:59:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:59:45 +0000 Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on| |7904 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 13:59:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 11:59:45 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12820 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 14:04:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 12:04:22 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts fail in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- >From my understanding.. we could either push this patch to fix it in 3.18... or apply bug 7904 to fix the same issue.. It's either end of the same problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 14:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 12:17:24 +0000 Subject: [Koha-bugs] [Bug 14234] Include the user manual with Koha package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14234 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- (In reply to Marc V?ron from comment #1) > The help pages then could have two links: > #1 to the local copy > #2 to the online help Perhaps (another) syspref to show local/remote/both links. 3.18 Manual use ~76 MB ( 3 html + 73 images) If you put it inside intranet DocumentRoot then you could access it by http(s)://staff_url/manual/ for example. We can use also version and/or language A downloadable version here: http://translate.koha-community.org/manual/3.18/manual-3.18-en.tgz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 14:30:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 12:30:55 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #16 from Marcel de Rooy --- Looking at this one now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 14:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 12:47:46 +0000 Subject: [Koha-bugs] [Bug 14234] Include the user manual with Koha package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14234 --- Comment #3 from Indranil Das Gupta --- (In reply to Bernardo Gonzalez Kriegel from comment #2) > (In reply to Marc V?ron from comment #1) > > The help pages then could have two links: > > #1 to the local copy > > #2 to the online help > > Perhaps (another) syspref to show local/remote/both links. > 3.18 Manual use ~76 MB ( 3 html + 73 images) > > If you put it inside intranet DocumentRoot then you could access it > by http(s)://staff_url/manual/ for example. > We can use also version and/or language > > A downloadable version here: > http://translate.koha-community.org/manual/3.18/manual-3.18-en.tgz We also need to consider the requirement for the l10n-ised manual in languages other than English. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 15:27:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 13:27:56 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10753 CC| |sophie.meynieux at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 15:27:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 13:27:56 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10449 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 15:28:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 13:28:35 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #14 from Sophie MEYNIEUX --- Does bug 10753 help to resolve ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 15:29:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 13:29:05 +0000 Subject: [Koha-bugs] [Bug 14235] New: Items appear as LOST when Missing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14235 Bug ID: 14235 Summary: Items appear as LOST when Missing Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: carmen at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Items appear as LOST when Missing in the staff client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 20 15:57:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 13:57:40 +0000 Subject: [Koha-bugs] [Bug 14236] New: Firefox usr/pwd storing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14236 Bug ID: 14236 Summary: Firefox usr/pwd storing Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I noticed if you have FF store your usr/pwd then your usr/pwd auto populates the usr/pwd fields when you are adding a new patron. This is not really a bug but more an issue that might need to be addressed. Ed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 20 16:02:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 14:02:38 +0000 Subject: [Koha-bugs] [Bug 14231] Package updates for 3.20 release In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39319|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 39344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39344&action=edit Bug 14231: changes required for 3.20 release Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 16:19:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 14:19:37 +0000 Subject: [Koha-bugs] [Bug 13650] Parenthesis in subject links problematic for search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi --- Is this a MARC21-only issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 16:21:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 14:21:07 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 16:21:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 14:21:10 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39303|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 39345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39345&action=edit Bug 12176: [QA Follow-up] Small additem adjustments Adjusting a few small things and making qa tools happy: [1] Remove .hidden after [% avalue %] in additem.tt. (Typo) [2] A closer look revealed that mv.avalue is useless too. An input element does not contain any content. Putting it after the hidden element in a non-visible context has no meaning. [3] Change handling of select attributes readonly and disabled. [4] Remove unused variable $attributes_no_value_textarea [5] Removed a comment with TODO referring to this report. [6] Moving a duplicated TT variable (mv.javascript) outside IF statement. [7] And finally could not resist this one: Moving strings Tag editor and No popup from script to template. Plugins++ NOTE: Most item plugins redirect click to focus. In that case there is no popup, but unfortunately the text Tag editor comes up. When you remove or rename function Click, No popup comes up. So it works. Sorry that this small list kept growing :) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 16:21:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 14:21:25 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39345|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 39346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39346&action=edit Bug 12176: Remove HTML from additem.pl This patch removes HTML code from additem.pl. To test: 1. Check no regressions on Add/Edit/Save items 2. Update translation files for a language, check new strings "Tag editor" & "No popup" on staff PO file 3. Check it passes xt/tt_valid.t Patch partially rebased, part rewritten. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 16:21:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 14:21:29 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #19 from Marcel de Rooy --- Created attachment 39347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39347&action=edit Bug 12176: [QA Follow-up] Small additem adjustments Adjusting a few small things and making qa tools happy: [1] Remove .hidden after [% avalue %] in additem.tt. (Typo) [2] A closer look revealed that mv.avalue is useless too. An input element does not contain any content. Putting it after the hidden element in a non-visible context has no meaning. [3] Change handling of select attributes readonly and disabled. [4] Remove unused variable $attributes_no_value_textarea [5] Removed a comment with TODO referring to this report. [6] Moving a duplicated TT variable (mv.javascript) outside IF statement. [7] And finally could not resist this one: Moving strings Tag editor and No popup from script to template. Plugins++ NOTE: Most item plugins redirect click to focus. In that case there is no popup, but unfortunately the text Tag editor comes up. When you remove or rename function Click, No popup comes up. So it works. Sorry that this small list kept growing :) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 16:23:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 14:23:02 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #20 from Marcel de Rooy --- Thanks Bernardo for reviving this one. The patch was fine already although I eventually added a list of seven points.. Hopefully the QAer of duty will not be too hard on us :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 16:23:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 14:23:07 +0000 Subject: [Koha-bugs] [Bug 14231] Package updates for 3.20 release In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #3 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 20 16:23:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 14:23:30 +0000 Subject: [Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 16:26:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 14:26:30 +0000 Subject: [Koha-bugs] [Bug 11925] patron category not checking ages limits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 16:45:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 14:45:44 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #21 from Marcel de Rooy --- Created attachment 39348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39348&action=edit Bug 12176: [QA Follow-up] Capitalization typo after eleventh hour While cleaning up, still found this super tiny string typo :) Yes, Tag Editor should now be Tag editor. Test plan :) Git grep on Tag editor and Tag Editor Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:06:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:06:40 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts fail in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 --- Comment #8 from Katrin Fischer --- Can someone confirm that bug 7904 applies on 3.18.x and would solve this problem please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:08:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:08:35 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39338|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 39349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39349&action=edit [PASSED QA] Bug 14072: Update German web installer for 3.20 - translates new notice ACQ_NOTIF_ON_RECEIV - translates new permissions Signed-off-by: Bernardo Gonzalez Kriegel Tested German install till "Gratulation, die Installation ist abgeschlossen" No errors Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Same results noted as above. Signed-off-by: Mirko Tietgen Tested installation, checked new translations in Koha and deleted an extra space in the ACQ_NOTIF_ON_RECEIV notice Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:08:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:08:43 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39339|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 39350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39350&action=edit [PASSED QA] Bug 14072: Followup: extra space Detele extra space in sample notice Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:09:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:09:03 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:11:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:11:32 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts fail in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate |rel_3_18_candidate QA Contact|testopia at bugs.koha-communit |colin.campbell at ptfs-europe. |y.org |com CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:14:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:14:50 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #22 from Bernardo Gonzalez Kriegel --- (In reply to Marcel de Rooy from comment #20) > Thanks Bernardo for reviving this one. Thank you!! > > [1] Remove .hidden after [% avalue %] in additem.tt. (Typo) a leftover from my debugging > [2] A closer look revealed that mv.avalue is useless too. An input element > does not contain any content. Putting it after the hidden element > in a non-visible context has no meaning. Ok! > [3] Change handling of select attributes readonly and disabled. I was worried about this, since i think select can't have readonly attribute, only disabled. But if disabled, it's content is not sent back to GET/POST, so perhaps a hidden attribute with same name and old value is needed. Or may be now select can have readonly, but then we need to remove disabled. I left both to not change old behavior > [4] Remove unused variable $attributes_no_value_textarea Good! I forgot them But in my first patch i also removed "my $attributes_no_value" > > Sorry that this small list kept growing :) Perfect, thanks again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:24:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:24:28 +0000 Subject: [Koha-bugs] [Bug 14072] Update German web installer for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:24:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:24:53 +0000 Subject: [Koha-bugs] [Bug 13650] Parenthesis in subject links problematic for search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:34:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:34:05 +0000 Subject: [Koha-bugs] [Bug 12066] New renew page in staff client doesn't record branch in statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:34:07 +0000 Subject: [Koha-bugs] [Bug 12066] New renew page in staff client doesn't record branch in statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 --- Comment #3 from Kyle M Hall --- Created attachment 39351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39351&action=edit Bug 12066 - New renew page in staff client doesn't record branch in statistics Test Plan: 1) Apply this patch 2) Renew an item via circ/renew.pl 3) Note the branch code of your logged in library is set as the branch in the generated statistic line -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:34:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:34:13 +0000 Subject: [Koha-bugs] [Bug 12066] New renew page in staff client doesn't record branch in statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 20 17:39:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 15:39:59 +0000 Subject: [Koha-bugs] [Bug 14237] New: allow bibs to be added to course without items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Bug ID: 14237 Summary: allow bibs to be added to course without items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice if you could add a bib to a course even if it has no items - this would be great for e-reserves. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 18:19:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 16:19:42 +0000 Subject: [Koha-bugs] [Bug 14238] New: C4::Matcher is mangling data to match on Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238 Bug ID: 14238 Summary: C4::Matcher is mangling data to match on Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When setting up an OCLC match point ( see bug 6499 ) the match always fails because C4::Matcher::_normalize converts "(OCoLC)20329436" to "OCOLC20329436" for reasons unknown. The _normalize subroutine has zero documentation as to what it is supposed to do or not do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 18:23:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 16:23:14 +0000 Subject: [Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238 --- Comment #1 from Kyle M Hall --- Created attachment 39352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39352&action=edit Bug 14238 - Unit Test to demonstrate issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 18:25:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 16:25:10 +0000 Subject: [Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 19:01:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 17:01:20 +0000 Subject: [Koha-bugs] [Bug 14141] Changing the Library for a notice duplicates the notice instead of updating it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 20 20:10:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 18:10:53 +0000 Subject: [Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does not prevent librarian from placing the hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 20:29:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 18:29:48 +0000 Subject: [Koha-bugs] [Bug 14239] New: Bibframe support in Koha Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239 Bug ID: 14239 Summary: Bibframe support in Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This is getting asked about more and more. I thought I should open a bug for it. There is an open source tool to convert marc to bibframe we should maybe watch: https://github.com/lcnetdev/marc2bibframe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 20:58:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 18:58:15 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #23 from Marcel de Rooy --- (In reply to Bernardo Gonzalez Kriegel from comment #22) > > [3] Change handling of select attributes readonly and disabled. > > I was worried about this, since i think select can't have readonly > attribute, only disabled. But if disabled, it's content is not sent > back to GET/POST, so perhaps a hidden attribute with same name and > old value is needed. > Or may be now select can have readonly, but then we need to remove disabled. > I left both to not change old behavior Seems good to me. I recall seeing some code in the template that removes the disabled status when submitting the form .. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 21:52:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 19:52:18 +0000 Subject: [Koha-bugs] [Bug 13964] "Withdrawn" status does not appear in Staff search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13964 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 21:53:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 19:53:03 +0000 Subject: [Koha-bugs] [Bug 8461] Block returns of withdrawn items show as 'not checked out' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8461 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 21:53:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 19:53:52 +0000 Subject: [Koha-bugs] [Bug 12998] Option to exclude withdrawn items when exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12998 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 21:54:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 19:54:29 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 22:12:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 20:12:33 +0000 Subject: [Koha-bugs] [Bug 6705] hide withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6705 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 22:16:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 20:16:23 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Hi, on unimarc/dom install, I can link 610 with new auth, and auth search shows 1 link etc... without patch! For me patch is Ok, but how to check something specific to it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 22:42:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 20:42:52 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #13 from M. Tompsett --- Comment on attachment 39342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39342 Bug 14206 Adds delete function for non email templates Review of attachment 39342: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14206&attachment=39342) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +227,4 @@ > SELECT * > FROM letter > WHERE module=? AND code=? AND (branchcode = ? OR branchcode = '') > + AND ( message_transport_type = ? OR message_transport_type IN (SELECT message_transport_type FROM message_transport_types)) "message_transport_type IN (SELECT message_transport_type FROM message_transport_types)" is always true, isn't it?! I don't think this is the patch you want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:03:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:03:09 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:08:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:08:11 +0000 Subject: [Koha-bugs] [Bug 10753] Don't use _ANY_ as branchcode when creating suggestions for 'Any library' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Creating suggestions for |Don't use _ANY_ as |'Any library' uses _ANY as |branchcode when creating |branchcode |suggestions for 'Any | |library' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:10:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:10:04 +0000 Subject: [Koha-bugs] [Bug 12944] Search for creator of an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|There is no way to search |Search for creator of an |orders by creator |order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:11:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:11:02 +0000 Subject: [Koha-bugs] [Bug 13156] Display cardnumber of borrower who made a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Display borrower's |Display cardnumber of |cardnumber who did a |borrower who made a |suggestion in suggestion.pl |suggestion in suggestion.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:25:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:25:35 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:25:47 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:27:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:27:47 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.18 CC| |katrin.fischer at bsz-bw.de Component|Architecture, internals, |Notices |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:31:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:31:04 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:35:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:35:43 +0000 Subject: [Koha-bugs] [Bug 13611] Make serial enumeration visible in user account when browsing own holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Serial enumeration not |Make serial enumeration |visible in the opac-user.pl |visible in user account |when browsing own holds. |when browsing own holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:38:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:38:00 +0000 Subject: [Koha-bugs] [Bug 11399] batch rebuild items tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|batch Rebuild Items Tables |batch rebuild items tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:40:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:40:01 +0000 Subject: [Koha-bugs] [Bug 11008] Remove unused column supplierreference in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Useless column |Remove unused column |supplierreference in |supplierreference in |aqorders table |aqorders table CC| |katrin.fischer at bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:42:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:42:06 +0000 Subject: [Koha-bugs] [Bug 11165] Save and update auth_header.modification_time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|auth_header.datemodified |Save and update |should be updated |auth_header.modification_ti | |me Component|Database |Cataloging CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:42:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:42:55 +0000 Subject: [Koha-bugs] [Bug 13611] Make serial enumeration visible in user account when browsing own holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Hold requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:46:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:46:58 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:47:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:47:40 +0000 Subject: [Koha-bugs] [Bug 14152] Check for required dependencies during upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Installation and upgrade |and plumbing |(web-based installer) CC| |gmcharlt at gmail.com, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:48:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:48:12 +0000 Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in atomicupdates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Installation and upgrade |and plumbing |(web-based installer) CC| |gmcharlt at gmail.com, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:51:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:51:26 +0000 Subject: [Koha-bugs] [Bug 7843] Add RSS feeds for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create RSS for OPAC news |Add RSS feeds for OPAC news CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 20 23:58:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 21:58:37 +0000 Subject: [Koha-bugs] [Bug 11900] Add tooltips to cart and list in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|OPAC cart can confuse |Add tooltips to cart and |patrons |list in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:00:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:00:38 +0000 Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search - ysearch.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:00:43 +0000 Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search - reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:01:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:01:51 +0000 Subject: [Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters for non-public reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |katrin.fischer at bsz-bw.de Summary|Allow svc/report to be |Allow svc/report to be |passed sql parameters |passed sql parameters for | |non-public reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:07:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:07:05 +0000 Subject: [Koha-bugs] [Bug 8033] remove unused sco/receipt template file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:07:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:07:48 +0000 Subject: [Koha-bugs] [Bug 5338] Add serials module to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Serials in guided reports |Add serials module to | |guided reports -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:09:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:09:53 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Hold requests CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:13:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:13:11 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CSV profiles improvements |CSV profiles improvements | |(concatenations, | |substrings, conditions...) CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:22:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:22:56 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Installation and upgrade |and plumbing |(web-based installer) CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:24:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:24:19 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:24:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:24:29 +0000 Subject: [Koha-bugs] [Bug 13679] If you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|There is a bug in overdues |If you have overdues that |if you have overdues that |match a rule, and have some |match a rule, and have some |items due in the future |items due in the future |they are included in the |they are included in the |list of overdues |list of overdues | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:25:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:25:03 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable Severity|enhancement |normal --- Comment #22 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:28:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:28:46 +0000 Subject: [Koha-bugs] [Bug 13679] If you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:30:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:30:12 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:31:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:31:00 +0000 Subject: [Koha-bugs] [Bug 13917] OPAC: Placing holds still possible by URL even if turned off by system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Component|OPAC |Hold requests Summary|OPAC: Putting holds still |OPAC: Placing holds still |possible by URL even if |possible by URL even if |turned off by system |turned off by system |preference |preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:33:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:33:30 +0000 Subject: [Koha-bugs] [Bug 14103] PDF::FromHTML headaches related to optional discharging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|PDF::FromHTML headaches |PDF::FromHTML headaches |related to optional |related to optional |discharging. |discharging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:35:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:35:01 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Deleting parent fund will |Deleting parent fund will |orphan child funds, leaving |orphan child funds, leaving |them un-editable. |them un-editable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:36:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:36:43 +0000 Subject: [Koha-bugs] [Bug 13222] Accessors for import_record.status have variable names suggesting overlay_status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13222 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Architecture, internals, | |and plumbing CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:37:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:37:59 +0000 Subject: [Koha-bugs] [Bug 13006] suggestions.mailoverseeing is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13006 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Database |and plumbing | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 00:43:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 22:43:09 +0000 Subject: [Koha-bugs] [Bug 5844] Unhighlight cuts off some strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unhilight cuts off some |Unhighlight cuts off some |strings |strings -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 21 01:35:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 May 2015 23:35:32 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts fail in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 03:13:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 01:13:34 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39321|0 |1 is obsolete| | --- Comment #14 from Indranil Das Gupta --- Created attachment 39353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39353&action=edit Bug 14206 Adds two tests to t/db_dependent/Letters.t C4::Letters::getletter is called in tools/letter.pl by the function delete_confirm() to display the selected notice for deletion. Due to current implementation of getletter(), a notice that does not use the 'email' template (but uses any/all of the other templates - sms, print or phone) can't be deleted from the staff client. This patch adds 2 tests to t/db_dependent/Letters.t to test the bug. Test plan ========= 1/ Apply the patch and run prove -v t/db_dependent/Letters.t 2/ Test 38 should FAIL - getletter() fails when message_transport_type is not passed by caller function i.e. delete_confirm() in letter.pl # Failed test 'Bug 14206 - message_transport_type not passed, correct mtt detected' # at t/db_dependent/Letters.t line 179. # got: undef # expected: 'print' Test 39 should pass - getletter() functions correctly when passed message_transport_type param by caller function i.e. add_validate() (Test plan continues in the second commit) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 03:17:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 01:17:08 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39342|0 |1 is obsolete| | --- Comment #15 from Indranil Das Gupta --- Created attachment 39354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39354&action=edit Bug 14206 Adds delete function for non email templates This patch adds deletion capability for notices that do not use email template, but uses any/all of the other templates i.e. sms, print or phone. Test plan (Continued) ===================== 3/ Go to Tools -> Notices & Slips. Add a new notice only for print, leave 'Library' and 'Koha module' options as default selections. Enter 'KOHA_14206' and 'Koha Test 14206' against Code and Name respectively, and 'Test' and 'Test Message' for subject and body. Leave the Email, Phone and SMS tabs blank. Save the notice. 4/ On the notices listing page the new notice will be listed. Try to delete it. It will load the 'Delete notice' dialog form, but the table will not show any data under s - 'Library', 'Module', 'Code' or 'Name'. 5/ Click the "Yes, delete" button. The page will be submitted and the Notices listing reloaded. The print-only KOHA_14206 notice should continue to exist. This is *wrong*. 6/ Apply this patch 7/ Reload the listings page and click on the 'Delete' link for Notice KOHA_14206. This time, it should show the data under 'Module', 'Code' or 'Name' at least. 8/ Click on 'Yes, delete'. The page should submit and the listing page reload. This time KOHA_14206 will be gone. 9/ Re-run prove -v t/db_dependent/Letters.t This time all tests should PASS without any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 03:21:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 01:21:46 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #16 from Indranil Das Gupta --- modified the patch including the tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 03:36:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 01:36:33 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Priority|P3 |P5 - low -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 03:46:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 01:46:37 +0000 Subject: [Koha-bugs] [Bug 14240] New: Add '(All libraries)' to notice deletion confirmation page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 Bug ID: 14240 Summary: Add '(All libraries)' to notice deletion confirmation page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: indradg at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org Notices that are applicable to all libraries do not show '(All libraries)' in the deletion confirmation form (tools/letter.pl?op=delete_confirm). The proposed patch adds that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 03:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 01:57:42 +0000 Subject: [Koha-bugs] [Bug 14240] Add '(All libraries)' to notice deletion confirmation page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 --- Comment #1 from Indranil Das Gupta --- Created attachment 39355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39355&action=edit Bug 14240 - Add '(All libraries)' to notice deletion form Trivial patch that shows (All libraries) instead of an empty cell for notices that are applicable across all libraries. Test plan ========= 1/ Apply the patch 2/ Attempt to delete a notice that is defined for all libraries You should be able to see '(All libraries)' in the table cell instead of a blank cell -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 03:58:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 01:58:21 +0000 Subject: [Koha-bugs] [Bug 14240] Add '(All libraries)' to notice deletion confirmation page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 04:08:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 02:08:31 +0000 Subject: [Koha-bugs] [Bug 14239] Bibframe support in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 04:11:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 02:11:13 +0000 Subject: [Koha-bugs] [Bug 14237] allow bibs to be added to course without items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 05:30:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 03:30:58 +0000 Subject: [Koha-bugs] [Bug 14106] koha-conf paths to zebra libraries are wrong in jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 --- Comment #1 from Robin Sheat --- Created attachment 39356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39356&action=edit Bug 14106: koha-start-zebra ensures a correct link exists When koha-start-zebra starts, it first checks to see if there is a symlink (/var/lib/koha/zebramodules) pointing to the location that contains the zebra modules. If not, it makes one. It will also remove and replace incorrect ones. Testing: * Run koha-start-zebra, see that /var/lib/koha/zebramodules exists and points to whatever directory contains your zebra modules. * Run koha-start-zebra, see that nothing has changed * Delete the symlink, run koha-start-zebra, see that it puts it back, * Make a new symlink that points to the wrong place, run koha-start-zebra, see that it replaces it with a correct one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 05:33:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 03:33:35 +0000 Subject: [Koha-bugs] [Bug 14017] Join the General Mailing list does is a 404 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14017 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea --- Hi, This is working for me. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 05:34:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 03:34:47 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wizzyrea at gmail.com |gmcharlt at gmail.com Component|Websites, Mailing Lists, |Tools |etc | CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 05:36:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 03:36:00 +0000 Subject: [Koha-bugs] [Bug 7819] Title page of manual page says "Koha downloads" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7819 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 05:46:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 03:46:12 +0000 Subject: [Koha-bugs] [Bug 14106] koha-conf paths to zebra libraries are wrong in jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39356|0 |1 is obsolete| | --- Comment #2 from Robin Sheat --- Comment on attachment 39356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39356 Bug 14106: koha-start-zebra ensures a correct link exists Turns out this is unnecessary, we can put multiple paths directly into the zebra configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 05:51:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 03:51:47 +0000 Subject: [Koha-bugs] [Bug 14106] koha-conf paths to zebra libraries are wrong in jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 --- Comment #3 from Robin Sheat --- Created attachment 39357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39357&action=edit Bug 14106: fill up the zebra config with a list of modulePaths This adds the full list of paths that debian might use for zebra to the search path for modules. It also means we can say we support s390x architecture. Whatever that is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 07:21:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 05:21:52 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 07:50:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 05:50:03 +0000 Subject: [Koha-bugs] [Bug 14241] New: Ability to make permanent withdrawn of item (with withdrawn number) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14241 Bug ID: 14241 Summary: Ability to make permanent withdrawn of item (with withdrawn number) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl We need to be able to withdraw items permanently, with added withdrawn number. The number should be generated automatically and we need to print the withdrawn list. The reason is the Czech Librarianship Act, so for us there is absolutely no excuse to not have this feature implemented. So patches will follow hopefully soon. (I'm working on it) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 07:50:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 05:50:21 +0000 Subject: [Koha-bugs] [Bug 14241] Ability to make permanent withdrawn of item (with withdrawn number) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14241 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 09:12:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 07:12:14 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- Just a dumb question: What happens if you translate the staff client with these pref types here? Clicking on a translation would still work (insert the original English), but would the user understand? Should we not convert this text box to a select now ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 10:27:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 08:27:19 +0000 Subject: [Koha-bugs] [Bug 14241] Ability to make permanent withdrawn of item (with withdrawn number) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14241 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 10:47:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 08:47:25 +0000 Subject: [Koha-bugs] [Bug 14242] New: Use ISBN-field to fill out purchase suggestions (using an Ajax-request) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Bug ID: 14242 Summary: Use ISBN-field to fill out purchase suggestions (using an Ajax-request) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: viktor.sarge at regionhalland.se QA Contact: testopia at bugs.koha-community.org We suggest that the purchase suggestion in Opac could use the ISBN field to try and find the information for the other fileds. People will often not know how to fill out this form in a way that makes librarians smile :) Perhaps an Ajax request in the background and fronting this field a bit more as a starting point if we get this function on the road. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 12:03:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 10:03:05 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 12:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 10:53:16 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #8 from M. Tompsett --- (In reply to Marcel de Rooy from comment #7) > Just a dumb question: What happens if you translate the staff client with > these pref types here? Clicking on a translation would still work (insert > the original English), but would the user understand? > Should we not convert this text box to a select now ? Actually, that is a valid point. Converting to a drop down selection list would be better. That would also prevent the entry of invalid types. My sign off was to encourage development. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 13:21:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 11:21:49 +0000 Subject: [Koha-bugs] [Bug 14243] New: intranet Detail does not open in new window (Firefox) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14243 Bug ID: 14243 Summary: intranet Detail does not open in new window (Firefox) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 13:22:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 11:22:43 +0000 Subject: [Koha-bugs] [Bug 14243] intranet Detail does not open in new window (Firefox) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14243 --- Comment #1 from Marcel de Rooy --- This is about the intranet XSLT detail view with the OPAC view link. Firefox does not like target="_blank" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 13:36:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 11:36:46 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 13:36:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 11:36:50 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39086|0 |1 is obsolete| | Attachment #39087|0 |1 is obsolete| | --- Comment #105 from Marcel de Rooy --- Created attachment 39358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39358&action=edit Bug 5010: Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/it-IT/necessari/notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased again on kohadevbox... Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 21 13:36:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 11:36:57 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #106 from Marcel de Rooy --- Created attachment 39359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39359&action=edit Bug 5010: Fix - replace tab with spaces Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel No errors. Tested what I can, not plack/shibboleth/cas Perhaps this can pass and we can fix any problem later (for 3.22) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 13:43:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 11:43:40 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #107 from Marcel de Rooy --- QA Comment: Great work, Mark. This took some time :) Code looks good to me. No complaints from qa tools. I understood that Martin tested the shibboleth case. I did not test cas or plack. Altough I do not expect something there when looking at the code, I leave it to RM to request additional tests. A very early push of this patch in 3.22 could perhaps resolve that btw.. Some small remarks: + if ($oldprotocol ne 'https') { + $debug + and warn + 'Shibboleth requires OPACBaseURL to use the https protocol!'; + } Perhaps we could argue here that the debug flag is not needed. Just warn. C4/Context.pm: + # force explicit protocol on OPACBaseURL + if ($var eq 'opacbaseurl' && substr($value,0,4) !~ /http/) { + $value = 'http://' . $value; + } This is bit more of a philosophical nature: Should we enforce it and make users lazy? Or should we enforce it differently: Perhaps with a select combo with protocol? Or in javascript? Note that if you now save the pref, you still have a wrong value. Should we depend on modules to correct pref values? I would be more in favor of correcting it earlier in the process. (No blocker) What about staffClientBaseURL now? :-) svc/import_bib: my $url = 'http://'. C4::Context->preference('staffClientBaseURL') .'/cgi-bin/koha/catalogue/detail.pl?biblionumber='. $biblionumber; [This pref seems to be the easier case.] Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 13:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 11:46:33 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Lists |Architecture, internals, | |and plumbing QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 13:49:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 11:49:09 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #108 from Marcel de Rooy --- Additionally: I git grepped on several case combinations of OPACBaseUrl and found this exception: t/db_dependent/Auth_with_cas.t contains OpacBaseURL (NOK) misc/release_notes/release_notes_3_10_0.txt contains OPACBaseurl (OK) No big deal, noted for the record.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 14:03:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 12:03:07 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|paul.poulain at biblibre.com |m.de.rooy at rijksmuseum.nl --- Comment #337 from Marcel de Rooy --- QA: Like to do this one next :) But if someone else is faster.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 16:42:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 14:42:31 +0000 Subject: [Koha-bugs] [Bug 14244] New: viewing a bib item's circ history requires circulation permissions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Bug ID: 14244 Summary: viewing a bib item's circ history requires circulation permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On issuehistory.pl you have: flagsrequired => { circulate => "circulate_remaining_permissions" }, But that really doesn't make sense. People should be able to view the history of circulation without having permission to circulate items themselves. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 17:41:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 15:41:34 +0000 Subject: [Koha-bugs] [Bug 14245] New: RIS in unimarc flavour is still deficient Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245 Bug ID: 14245 Summary: RIS in unimarc flavour is still deficient Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jvr at fct.unl.pt QA Contact: testopia at bugs.koha-community.org Created attachment 39360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39360&action=edit Detail report (3) is what you get and (4) is what it should be File in cause is: /usr/share/koha/lib/C4/Ris.pm RIS in unimarc flavour is still deficient, because the variable $intype is out of scope outside --> sub marc2ris { } , so every other code that references to it render useless in an unimarc flavour where you need to join several fields to output correct information for AU, PY or PB. In attached image (3) is what you get in the export file, but (4) is what it should be to be totally correct... For live example data goto: https://opac.fct.unl.pt/cgi-bin/koha/opac-detail.pl?biblionumber=20049&query_desc=kw%252Cwrdl%253A%252020049 Thank you in antecipation for an early reply. Victor do Ros?rio Especialista de Inform?tica Divis?o de Documenta??o e Cultura FCT/UNL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 17:44:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 15:44:13 +0000 Subject: [Koha-bugs] [Bug 14246] New: Add borrowernumber to koha_news Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Bug ID: 14246 Summary: Add borrowernumber to koha_news Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: xarragon at gmail.com QA Contact: testopia at bugs.koha-community.org News items in Koha's OPAC and Staff client are anonymous. This is the first in a set of patches to add authorship tracking to the news items, with optional display preferences maintaining the current functionality. This first patch changes the database; it adds a column called 'borrowernumber' to the 'koha_news' table, adding a foreign key relationship to the 'borrowers' table. This is how tracking authorship is done. A LEFT JOIN statement is then used to get the title, firstname and surname columns available in the news data set. That is a separate patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 18:00:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 16:00:58 +0000 Subject: [Koha-bugs] [Bug 14247] New: System preference for news author display Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Bug ID: 14247 Summary: System preference for news author display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: xarragon at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 14246 This patch adds a new binary option under Preferences/Tools called 'NewsAuthorDisplay'; it allows Koha to display the full name of the user who authored a news item. Depends on the patch in bug 14246. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 21 18:00:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 16:00:58 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14247 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 18:06:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 16:06:07 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14248 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 18:06:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 16:06:07 +0000 Subject: [Koha-bugs] [Bug 14248] New: Optionally display authorship for news items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 Bug ID: 14248 Summary: Optionally display authorship for news items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: xarragon at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 14247 This patch adds the ability to display the name of the user who authored a specific news item. It will by default work as before, not displaying any information. Enabling it will make Koha more suitable as a simple CMS and/or blog. It depends on the patches for bugs 14246 and 14247. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 18:14:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 16:14:31 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xarragon at gmail.com --- Comment #1 from Martin Persson --- Created attachment 39361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39361&action=edit Adds koha_news column borrowernumber Should merge with f52084df0e395fdf89d80ca2fd77844273a8cf7c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 18:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 16:15:11 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xarragon at gmail.com --- Comment #1 from Martin Persson --- Created attachment 39362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39362&action=edit DB update script and sysprefs file Should merge with f52084df0e395fdf89d80ca2fd77844273a8cf7c -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 18:15:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 16:15:50 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #1 from Martin Persson --- Created attachment 39363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39363&action=edit Changes to templates and perl files to enable display Should merge with f52084df0e395fdf89d80ca2fd77844273a8cf7c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 18:46:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 16:46:49 +0000 Subject: [Koha-bugs] [Bug 14249] New: discharge letter edits Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Bug ID: 14249 Summary: discharge letter edits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The discharge letter says 'his' regardless of gender. We should probably reword it so that it's clear. Also it uses the library's code instead of name and probably most people wouldn't know the library code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 18:47:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 16:47:02 +0000 Subject: [Koha-bugs] [Bug 14249] discharge letter edits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 --- Comment #1 from Nicole C. Engard --- Created attachment 39364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39364&action=edit letter image -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 21 18:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 16:47:46 +0000 Subject: [Koha-bugs] [Bug 14250] New: can generate discharge for patron with fines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Bug ID: 14250 Summary: can generate discharge for patron with fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I can generate a discharge for a patron with fines - shouldn't the patron have no checkouts and no fines? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 21 18:48:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 16:48:47 +0000 Subject: [Koha-bugs] [Bug 14251] New: style discharge letter Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Bug ID: 14251 Summary: style discharge letter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 39365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39365&action=edit contents of letter Would be nice if the discharge letter was a bit more styled - maybe a library logo to make it look like letterhead? Or at least a few more line breaks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 19:16:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 17:16:20 +0000 Subject: [Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 39366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39366&action=edit Bug 14245: Problems with RIS export in unimarc Variable $itype is used an all C4/Ris.pm to switch between marc falvors, but is local and not passed along as argument. As a quick solution, is defined as global To test: 1) On UNIMARC setup, export a record as RIS, check that author (and other fields) are displayed incorrectly 2) Apply the patch 3) Export again, improved results 4) Run t/Ris.t There are other problems in this script, needs maintenance (e.g. no Modern::Perl friendly) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 19:16:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 17:16:58 +0000 Subject: [Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |bgkriegel at gmail.com Patch complexity|--- |Trivial patch CC| |bgkriegel at gmail.com Status|NEW |Needs Signoff Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 19:34:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 17:34:15 +0000 Subject: [Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 19:49:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 17:49:15 +0000 Subject: [Koha-bugs] [Bug 12320] $.cookie('foo', null) deprecated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12320 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38600|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 39367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39367&action=edit [SIGNED-OFF] Bug 12320: Remove deprecated construct to delete cookie holdfor $.cookie('foo', null); is deprecated and should be replaced with $.removeCookie('foo'); This patch replaces the occurrences for the "holdfor" cookie. Test plan: 1/ Search for a patron 2/ On the patron detail page, click on "search to hold" 3/ Search for records 4/ On the results page, click on "Place hold" > "Forget PATRON" 5/ Reload the page. 6/ The "Place hold" button should not contain the patron anymore Signed-off-by: Bernardo Gonzalez Kriegel Works as described, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 19:49:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 17:49:22 +0000 Subject: [Koha-bugs] [Bug 12320] $.cookie('foo', null) deprecated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12320 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38601|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 39368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39368&action=edit [SIGNED-OFF] Bug 12320: Remove deprecated construct to delete cookie showColumns $.cookie('foo', null); is deprecated and should be replaced with $.removeCookie('foo'); This patch replaces the occurrences for the "showColumns" cookie. Before this patch, there was a bug on the batchmod tools. To reproduce the issue: 1/ Go on the Batch item modification tool 2/ Fill the textarea with barcodes and submit 3/ Click on some column names (to create the cookie) 4/ Click on 'Show all columns" (to set the cookie to null) 5/ Don't submit and repeat steps 1 & 2 6/ You should see a js error: Error: Syntax error, unrecognized expression: :nth-child ...break;q=a}return s},m.error=function(a){throw new Error("Syntax error, unrecogni... Test plan: Confirm the issue has gone away and there is no regression on the column selection Signed-off-by: Bernardo Gonzalez Kriegel No js error, no regressions, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 19:49:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 17:49:37 +0000 Subject: [Koha-bugs] [Bug 12320] $.cookie('foo', null) deprecated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12320 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 20:26:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 18:26:33 +0000 Subject: [Koha-bugs] [Bug 14252] New: Moving the OPAC language switcher to masthead navbar Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Bug ID: 14252 Summary: Moving the OPAC language switcher to masthead navbar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P3 Component: OPAC Assignee: oleonard at myacpl.org Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 39369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39369&action=edit The suggested placement at 1366x768 resolution The OPAC language switcher takes up a lot of space at the bottom of the browser. it also has issues of being not always visible (being worked on by Bernardo - http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057). Discussed this with @bgkriegel and @drojf on #koha. The common opinion seemed to be that this might not be a bad idea to explore, provided it doesn't blow up on handhelds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 20:29:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 18:29:25 +0000 Subject: [Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11057 Patch complexity|--- |Trivial patch Severity|trivial |normal Assignee|oleonard at myacpl.org |indradg at gmail.com CC| |bgkriegel at gmail.com, | |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 20:29:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 18:29:25 +0000 Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14252 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 20:35:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 18:35:22 +0000 Subject: [Koha-bugs] [Bug 14253] New: can't scroll though patron notify list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14253 Bug ID: 14253 Summary: can't scroll though patron notify list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 39370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39370&action=edit can't scroll When trying to add patrons to notify of new acq you can't scroll using the scroll button on the mouse or the scroll bar - which doesn't exist. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 20:55:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 18:55:12 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39140|0 |1 is obsolete| | --- Comment #16 from Bernardo Gonzalez Kriegel --- Created attachment 39371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39371&action=edit [SIGNED-OFF] Bug 13437: Perltidy some plugin files before conversion Preliminary work before converting to new plugin style. Several files still contained tabs or had strange indentation. Perltidied: marc21_linking_section.pl Perltidied: marc21_field_007.pl Perltidied: marc21_leader_authorities.pl Perltidied: marc21_leader.pl Perltidied: marc21_leader_book.pl Perltidied: marc21_leader_computerfile.pl Perltidied: marc21_leader_video.pl Test plan: Run perltidy -pro=xt/perltidyrc on marc21_linking_section and compare. Try another one too :) Signed-off-by: Bernardo Gonzalez Kriegel Minor differences on comparison :) No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 20:55:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 18:55:19 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39193|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel --- Created attachment 39372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39372&action=edit [SIGNED-OFF] Bug 13437: Preliminary changes for marc21 plugins field 008 Preliminary work on marc21_field_008.pl and 008_authorities.pl. Moving $dateentered en $defaultval to lower scope level. date_entered is a new sub (in a module); sub Field008 has been reduced to one line. Added a trivial unit test for date_entered. Note: the format used in date_entered could be added in DateUtils, moving this logic to a better place. Test plan: Use both plugins in the marc21 editor (biblios/authorities). Run the adjusted unit test. Signed-off-by: Bernardo Gonzalez Kriegel Both plugins works, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 20:55:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 18:55:25 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39194|0 |1 is obsolete| | --- Comment #18 from Bernardo Gonzalez Kriegel --- Created attachment 39373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39373&action=edit [SIGNED-OFF] Bug 13437: Trivial edits on marc21 plugins before conversion marc21_field_003.pl: copy-pasta comment about date removed marc21_field_005.pl: commented use removed marc21_field_006.pl: old/irrelevant pod lines marc21_field_007.pl: old/irrelevant pod lines marc21_field_008.pl: old/irrelevant pod lines, move sub par line twice marc21_field_008_authorities.pl: whitespace, old/irrelevant pod lines marc21_field_040c.pl: two commented lines removed marc21_field_040d.pl: whitespace, commented lines, old/irrelevant pod marc21_field_245h.pl: whitespace marc21_linking_section.pl: relocated some comment lines, and replaced a new CGI object by the one passed in via the plugin launcher (agreed, this may not be so trivial as the other changes) Test plan: These (trivial) changes are hard to test. Pick a few plugins and verify that behavior is not changed in the marc editor. For the brave: Try marc21_linking_section.pl. Signed-off-by: Bernardo Gonzalez Kriegel Tried marc21_linking_section.pl :) (ling plugin to 773$9, create new record, search for parent and check values inserted) No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 20:55:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 18:55:33 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39195|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 39374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39374&action=edit [SIGNED-OFF] Bug 13437: Conversion of marc21 cataloguing plugins to new style This patch converts marc21 plugins to new style by making the following modifications: [1] Replace use strict with use Modern::Perl. This implies that we now re-enabled warnings. There are no redefine warnings anymore, but note that we need to silence some warnings from individual plugins that were covered by disabling the warnings pragma until now. Silencing these individual warnings is outside the scope of this report. [2] Sub plugin_javascript is replaced by an anonymous subroutine $builder. [3] The parameters of $builder are combined in a params hashref. In most cases we only need $params->{id} for the function name. [4] Javascript function Clicxxx is renamed to Clickxxx. [5] The builder does no longer return function_name. [6] Sub plugin is replaced by subroutine $launcher. [7] The parameters of $launcher are combined in a params hashref. We only use $params->{cgi}. Mostly we save that to $input. One exception: $query. [8] The plugins returns a hash with $builder and/or $launcher. Test plan: [1] Run t/db_dependent/FrameworkPlugin.t -incl cataloguing/value_builder/ marc21*.pl. This should catch compile errors and general problems when building or launching these plugins. NOTE: You will see several initialize warnings from individual plugins that were hidden until now by disabling warnings. This is fine; we will be able to address these warnings now on new reports. [2] Check behavior of several plugins in the marc editor. Signed-off-by: Marcel de Rooy Checked all marc21 plugins. Attached unused plugins to some field. Some plugins (unused by default) may need some further attention, but also outside the scope of this report. Signed-off-by: Bernardo Gonzalez Kriegel New warnigs, but all seems to work. No errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 20:55:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 18:55:40 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39196|0 |1 is obsolete| | --- Comment #20 from Bernardo Gonzalez Kriegel --- Created attachment 39375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39375&action=edit [SIGNED-OFF] Bug 13437: Replace javascript function parameter in builder The builder contains js functions with a parameter like subfield_managed or i or something similar. This parameter contains the html id of the field corresponding with the plugin. With the functionality of Koha::FrameworkPlugin in place, we can eliminate one js function call and get the same id via the event passed in. Note that this actually makes the function a 'real' event handler. Also note that in many cases this parameter was not used but the id was borrowed from a perl variable like $params->{id}. If the field is not cloned, this is not a problem. But some fields can be cloned and should not use the static perl value but should get it from the event. Test plan: Look for js errors when loading the marc editor. Since the Focus or Click event code has been touched for most marc21 plugins, move your cursor into the field or click on the tag editor button. Verify that the focus event updates the correct field or the click event correctly launches the plugin AND the value comes back into the right field. Bonus: Attach a plugin with popup (like leader) to 040$d. Clone this field. Verify that the two launch buttons operate on the correct value. (This resolves a current bug.) Signed-off-by: Marcel de Rooy Checked all 15 plugins. Plugin marc21_linking_section seems to work, but I could not get it to pass back something useful into my field. (Same without this patch.) Tested the clone button with leader on 040d. Signed-off-by: Bernardo Gonzalez Kriegel All seems to work, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 20:55:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 18:55:50 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #72 from Nicole C. Engard --- Checking in on this - can someone help me a bit with documentation on this? I don't have much more before I'm done with the 3.20 manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 20:57:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 18:57:11 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com --- Comment #21 from Bernardo Gonzalez Kriegel --- Great work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 22:21:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 20:21:07 +0000 Subject: [Koha-bugs] [Bug 14249] discharge letter edits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Nicole, I offer to write the patch, but can you write the text for me? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 21 22:35:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 20:35:01 +0000 Subject: [Koha-bugs] [Bug 14243] intranet Detail does not open in new window (Firefox) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14243 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Marcel, could this be a duplicate to 11937? It seems to be related to the 'result browser' feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 21 22:39:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 20:39:56 +0000 Subject: [Koha-bugs] [Bug 14234] Include the user manual with Koha package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14234 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi Indranil, this sounds like a nice idea. Could we keep the manual in a separate 'dependency'? So you could choose to install it or not? Not sure what would work best for providing different translations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 22:41:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 20:41:45 +0000 Subject: [Koha-bugs] [Bug 14232] Biblio records are not showing after zebra indexing from cronjob In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Nishant, Please check the about > system information page in your Koha installation for more information. With 3.18 DOM indexing is mandatory, so you might need to switch from grs1 to DOM to get your search back to normal. If you need help there, it's best to ask on the mailing list as not a lot of people read here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 22:42:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 20:42:11 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #122 from Katrin Fischer --- Yay! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 21 22:46:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 20:46:35 +0000 Subject: [Koha-bugs] [Bug 13854] XSLT result list doesn't show 'on order' when itemtype is not for loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13854 --- Comment #3 from Katrin Fischer --- Hi Isabela, there is currently no fix available yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 22 00:25:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 22:25:49 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39353|0 |1 is obsolete| | Attachment #39354|0 |1 is obsolete| | --- Comment #17 from Indranil Das Gupta --- Created attachment 39376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39376&action=edit Bug 14206 Adds delete function for non email templates C4::Letters::getletter() is called in tools/letter.pl by the function delete_confirm() to display the selected notice for deletion. Due to current implementation of getletter(), a notice that does not use the 'email' template (but uses any/all of the other templates - sms, print or phone) can't be deleted from the staff client. This patch adds deletion capability for notices that do not use email template, but uses any/all of the other templates i.e. sms, print or phone. This also adds 2 tests to t/db_dependent/Letters.t for testing both conditions - a) when message_transport_type is specified b) when it is not. Test plan ========= 1/ Go to Tools -> Notices & Slips. Add a new notice only for print, leave 'Library' and 'Koha module' options as default selections. Enter 'KOHA_14206' and 'Koha Test 14206' against Code and Name respectively, and 'Test' and 'Test Message' for subject and body. Leave the Email, Phone and SMS tabs blank. Save the notice. 2/ On the notices listing page the new notice will be listed. Try to delete it. It will load the 'Delete notice' dialog form, but the table will not show any data under s - 'Library', 'Module', 'Code' or 'Name'. 3/ Click the "Yes, delete" button. The page will be submitted and the Notices listing reloaded. The print-only KOHA_14206 notice should continue to exist. This is *wrong*. 4/ Apply this patch 5/ Reload the listings page and click on the 'Delete' link for Notice KOHA_14206. This time, it should show the data under 'Module', 'Code' or 'Name' at least. 6/ Click on 'Yes, delete'. The page should submit and the listing page reload. This time KOHA_14206 will be gone. 7/ Run prove -v t/db_dependent/Letters.t All tests should PASS without any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 22 00:28:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 22:28:29 +0000 Subject: [Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #18 from Indranil Das Gupta --- Converted into a single commit. LIMIT 1 added back in. Test plan revised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 22 01:24:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 May 2015 23:24:55 +0000 Subject: [Koha-bugs] [Bug 14254] New: Unclosed