[Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 38838
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38838
Bug 14145: Noisy warns in admin/preferences.pl

Review of attachment 38838:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14145&attachment=38838)
-----------------------------------------------------------------

::: admin/preferences.pl
@@ +46,4 @@
>      my $tab_template = C4::Templates::gettemplate( 'admin/preferences/' . $tab . '.pref', 'intranet', $input );
>  
>      my $active_currency = GetCurrency();
> +    my $local_currency;;

Double ;;'s?

@@ +112,5 @@
>              sort { $a->{'text'} cmp $b->{'text'} }
>                map {
>                  my $option_value = $_;
>                  {
> +                    text     => $options{type}->{$option_value},

This works, because the $options{type} doesn't exist, so two undefs reduces the
list size by an even number for the failed grep too. There is no reason to
change 'multiple' to 'type'.

-- 
You are receiving this mail because:
You are watching all bug changes.