[Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat May 9 07:59:15 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 38839
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38839
Bug 14145: Noisy warns in admin/preferences.pl on Enhanced Content tab

Review of attachment 38839:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14145&attachment=38839)
-----------------------------------------------------------------

::: admin/preferences.pl
@@ +62,4 @@
>  
>      my $name = $options{'pref'};
>      my $chunk = { name => $name, value => $value, type => $options{'type'} || 'input', class => $options{'class'} };;
> +    $value //= '';

If $value is undef, then the question is what else is undef in the list above?
$options{'pref'}? $options{'class'}? Because otherwise line 64 would be barfing
errors too about uneven lists.

Perhaps there is something here to fix? Neither my counter patch nor this would
fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list