[Koha-bugs] [Bug 13135] cancel_expired_holds.pl/CancelExpiredReserves() logging improvements to catch evasive bugs in production.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13135

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 32619
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32619
Bug 13135 - cancel_expired_holds.pl/CancelExpiredReserves() logging
improvements to catch evasive bugs in production.

Review of attachment 32619:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13135&attachment=32619)
-----------------------------------------------------------------

Given that 3.16.x is much higher than 3.16.4, is there merit reworking this? Or
should it be closed RESOLVED WON'T FIX?

::: C4/Reserves.pm
@@ +981,4 @@
>  
>          my $today = DateTime->now( time_zone => C4::Context->tz() );
>  
> +        push @sb, "##Removing holds waiting too long\n##using today=$today, ReservesMaxPickUpDelay=$max_pickup_delay, ExpireReservesMaxPickUpDelayCharge=$charge\n".

The whole today logic was ripped out and replaced with SQL logic in 3.16.x --
not required.

@@ +992,5 @@
>                  }
>                  CancelReserve({ reserve_id => $res->{'reserve_id'} });
> +                push @sb, printReserve($res,'tab',['reserve_id','borrowernumber','branchcode','waitingdate']).sprintf("% 14s",substr($expiration,0,10))."| past lastpickupdate.\n" if $verbose;
> +            }
> +            elsif($verbose > 1) {

Because of SQL logic, there is no if statement to elsif off of.

@@ +998,2 @@
>              }
> +            $usedCalendars{  $res->{branchcode}  } = Koha::Calendar->new( branchcode => $res->{branchcode} ) if (  $verbose > 2 && not(exists($usedCalendars{$res->{branchcode}}))  );

Is this required?

-- 
You are receiving this mail because:
You are watching all bug changes.