[Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |bgkriegel at gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Aleisha,
// is not exactly the same as ||, as it returns first 'defined' value

Anyway, on current master I don't see the warning messages, and you changed the
first condition

before:
if ( $item->{itemnotforloan} > 0 || $item->{notforloan} > 0 || $itemtypes->{
$item->{itype} }->{notforloan} == 1 )

after:
if ( $item->{notforloan} > 0 // $item->{notforloan} > 0 // $itemtypes->{
$item->{itype} }->{notforloan} == 1 )


$item->{itemnotforloan} > 0 <=> $item->{notforloan} > 0

First and second condition on your 'if' are equal!

-- 
You are receiving this mail because:
You are watching all bug changes.