[Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206

--- Comment #6 from Indranil Das Gupta <indradg at gmail.com> ---
Created attachment 39283
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39283&action=edit
Bug 14206 - message_transport_type handling in C4::Letters::getletter

Revised patch based on Jonathan Druart's comment. Addresses the
default message_transport_type value in C4::Letters::getletter()
for notices that do not use an email template (i.e. uses phone /
print / sms).

Fixes the issue of not being able to delete notices with non-email
templates from Tools -> Notices & Slips

Test plan
=========

1/ Go to Tools -> Notices & Slips. Add a new notice only for print,
   leave 'Library' and 'Koha module' options as default selections.
   Enter 'KOHA_14206' and 'Koha Test 14206' against Code and Name
   respectively, and 'Test' and 'Test Message' for subject and body.
   Leave the Email, Phone and SMS tabs blank. Save the notice.
2/ On the notices listing page the new notice will be listed. Try to
   delete it. It will load the 'Delete notice' dialog form, but the
   table will not show any data under <th>s - 'Library', 'Module',
   'Code' or 'Name'.
3/ Click the "Yes, delete" button. The page will be submitted and the
   Notices listing reloaded. The print-only KOHA_14206 notice should
   continue to exist. This is *wrong*.
4/ Apply the patch
5/ Reload the listings page and click on the 'Delete' link for Notice
   KOHA_14206. This time, it should show the data under 'Module',
   'Code' or 'Name' at least.
6/ Click on 'Yes, delete'. The page should submit and the listing page
   reload. This time KOHA_14206 will be gone.
7/ Run sql statement SELECT * FROM `letter` WHERE `code` = 'KOHA_14206'
   to check actual deletion from the database. No record should be
   returned.
8/ Re-add notice KOHA_14206, but this time also add fill in print,
   email, phone and sms delivery options.
9/ Delete the newly re-added notice KOHA_14206. It should no longer
   be shown in the listing. Confirm deletion by running step #7.
   No record should be returned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.